[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Nind changed: What|Removed |Added Text to go in the||This enhancement enables release notes||exporting search results ||from the staff interface ||when using Elasticsearch or ||Open Search. Two formats ||are available by default: ||MARC (UTF-8) and MARC XML. ||The export is run as a ||background job, with the ||results available for ||download from the details ||page for the completed job. ||Requires the export_catalog ||permission. || ||Three new ||system preferences are used ||to configure exporting ||search results: ||- ||EnableElasticsearchSearchRe ||sultExport: enable the ||exporting of search results || ||- ||ElasticsearchSearchResultEx ||portCustomFormats: define ||custom export formats ||- ||ElasticsearchSearchResultEx ||portLimit: limit the number ||of search results exported --- Comment #36 from David Nind --- I have: 1. Amended the title and test plan for the patch (to update to the new system preference name) 2. Added a follow-up with some edits to the system preference descriptions. Testing notes using KTD: 1. Start up KTD using Elasticsearch: ktd --es8 up 2. The new system preference EnableElasticsearchSearchResultExport is enabled by default. 3. Test exporting using custom export formats: . Test the example custom export formats in the ElasticsearchSearchResultExportCustomFormats system preference description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Nind changed: What|Removed |Added Attachment #162343|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 --- Comment #35 from David Nind --- Created attachment 163762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163762=edit Bug 27859: (follow-up) Update system preference descriptions Format and edit the descriptions for the new EnableElasticsearchSearchResultExport and ElasticsearchSearchResultExportCustomFormats system preferences. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 --- Comment #34 from David Nind --- Created attachment 163761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163761=edit Bug 27859: Export staff interface search results when using Elasticsearch Enable export of staff interface search results in different marc formats. This feature is only supported when using Elasticsearch. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the EnableElasticsearchSearchResultExport system preference is enabled 4) Make sure the current user has the export_catalog permission (Use all tools > Export bibliographic and holdings data) 5) Perform a search 6) Export the serach result by choosing a format under the "Export all results" drop down 7) Verify that link(s) with exported data appear on the background job detail page when the export is completed 8) Revoke the permission in step 4 and ensure exporting is no longer possible 9) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #162342|0 |1 is obsolete|| --- Comment #33 from David Gustafsson --- Created attachment 162343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162343=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. This feature is only supported when using Elasticsearch. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the current user has the tools -> export_catalog permission 5) Perform a search 6) Export the serach result by choosing a format under the "Export results" drop down 7) Verify that link(s) with exported data appear when export is completed 8) Revoke the permission in 3) and ensure exporting is no longer possible 9) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #32 from David Gustafsson --- The job_progress-files where misspelled in previous version of Koha, that's why the includes now fail and this is now fixed. The qa script complains about POD coverage being greater before for Koha/BackgroundJob/SearchResultExport.pm, but don't really understand why. It's the same as the other background job classes, and a coverage of 1 should be fine? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #147936|0 |1 is obsolete|| --- Comment #31 from David Gustafsson --- Created attachment 162342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162342=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. This feature is only supported when using Elasticsearch. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the current user has the tools -> export_catalog permission 5) Perform a search 6) Export the serach result by choosing a format under the "Export results" drop down 7) Verify that link(s) with exported data appear when export is completed 8) Revoke the permission in 3) and ensure exporting is no longer possible 9) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #30 from Lucas Gass --- David, unfortunately your tests no longer apply cleanly. ( t/db_dependent/Koha/SearchEngine/Elasticsearch.t ) It looks like a simple fix where you just need to adjust the number of tests. QA Tool: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt FAIL valid_template str/job_progess.inc: not found I don't see an include in Koha called this. Also, don't forget to tidy! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #29 from David Gustafsson --- Rebased against master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Sam Lau changed: What|Removed |Added CC||sama...@gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28793 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 --- Comment #28 from David Gustafsson --- (In reply to Katrin Fischer from comment #24) > Testing... > > 1) QA test tools > > FAIL > koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ > search_result_marc_export.inc >FAIL filters > missing_filter at line 14 ([% format %]: href="[% > report.export_links.$format | $raw %]">[% report.export_links.$format | html > %] > 2) Database update > > It would be better to use the new template for system preferences, but the > output should include the names of the new preferences. > > 3) System preference definitions > > a) This needs to be 0/1 instead of yes/no: > +- pref: EnableSearchResultMARCExport > + type: boolean > + default: yes > + choices: > + yes: Enable > + no: Disable > > > b) This doesn't read quite right: > "A format have the required properties \"name\", > \"fields\" and an optional > \"multiple\"." > > c) SearchResultMARCExportCustomFormats > It says MARC export... but do we actually export MARC? Maybe a note where to > find the filed names would help here. From the name, I had expected MARC > fields. > > d) ElasticSearch should be Elasticsearch > > e) As this appears to be an Elasticserach only feature, all relating prefs > should say so. Also you might want to add some links from one pref to the > others involved. > > I got to stop here now since Elasticsearch doesn't want to cooperate in my > koha-testing-docker environment right now :( Thanks for the feedback! The issues should now be fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #147935|0 |1 is obsolete|| --- Comment #27 from David Gustafsson --- Created attachment 147936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147936=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. This feature is only supported when using Elasticsearch. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the current user has the tools -> export_catalog permission 5) Perform a search 6) Export the serach result by choosing a format under the "Export results" drop down 7) Verify that link(s) with exported data appear when export is completed 8) Revoke the permission in 3) and ensure exporting is no longer possible 9) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #147927|0 |1 is obsolete|| --- Comment #26 from David Gustafsson --- Created attachment 147935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147935=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. This feature is only supported when using Elasticsearch. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the current user has the tools -> export_catalog permission 5) Perform a search 6) Export the serach result by choosing a format under the "Export results" drop down 7) Verify that link(s) with exported data appear when export is completed 8) Revoke the permission in 3) and ensure exporting is no longer possible 9) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #145300|0 |1 is obsolete|| --- Comment #25 from David Gustafsson --- Created attachment 147927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147927=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. This feature is only supported when using Elasticsearch. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the current user has the tools -> export_catalog permission 5) Perform a search 6) Export the serach result by choosing a format under the "Export results" drop down 7) Verify that link(s) with exported data appear when export is completed 8) Revoke the permission in 3) and ensure exporting is no longer possible 9) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer --- Testing... 1) QA test tools FAIL koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/search_result_marc_export.inc FAIL filters missing_filter at line 14 ([% format %]: [% report.export_links.$format | html %]name\", \"fields\" and an optional \"multiple\"." c) SearchResultMARCExportCustomFormats It says MARC export... but do we actually export MARC? Maybe a note where to find the filed names would help here. From the name, I had expected MARC fields. d) ElasticSearch should be Elasticsearch e) As this appears to be an Elasticserach only feature, all relating prefs should say so. Also you might want to add some links from one pref to the others involved. I got to stop here now since Elasticsearch doesn't want to cooperate in my koha-testing-docker environment right now :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 --- Comment #23 from David Nind --- (In reply to David Gustafsson from comment #21) > Ok! Forgot to include that file in the commit, have now fixed this. Thanks David! Now signed off. Tested with ES7. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Nind changed: What|Removed |Added Attachment #145263|0 |1 is obsolete|| --- Comment #22 from David Nind --- Created attachment 145300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145300=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. This feature is only supported when using Elasticsearch. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the current user has the tools -> export_catalog permission 5) Perform a search 6) Export the serach result by choosing a format under the "Export results" drop down 7) Verify that link(s) with exported data appear when export is completed 8) Revoke the permission in 3) and ensure exporting is no longer possible 9) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 --- Comment #21 from David Gustafsson --- (In reply to David Nind from comment #19) > Just one item from testing. > > When I click on the "View detail of the enqueued job" (link is > http://127.0.0.1:8081/cgi-bin/koha/admin/background_jobs.pl?op=view=1) I > get an error trace page: > > Template process failed: file error - > background_jobs/search_result_marc_export.inc: not found at > /kohadevbox/koha/C4/Templates.pm line 127 > > in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 127 > > 124: > 125: my $data; > 126: binmode( STDOUT, ":encoding(UTF-8)" ); > 127: $template->process( $self->filename, $vars, \$data ) > 128: || die "Template process failed: ", $template->error(); > 129: return $data; > 130: } > > > > I get the same error if I try to view the job details from Administration > > Jobs > Manage jobs Ok! Forgot to include that file in the commit, have now fixed this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #145244|0 |1 is obsolete|| --- Comment #20 from David Gustafsson --- Created attachment 145263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145263=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. This feature is only supported when using Elasticsearch. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the current user has the tools -> export_catalog permission 5) Perform a search 6) Export the serach result by choosing a format under the "Export results" drop down 7) Verify that link(s) with exported data appear when export is completed 8) Revoke the permission in 3) and ensure exporting is no longer possible 9) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #19 from David Nind --- Just one item from testing. When I click on the "View detail of the enqueued job" (link is http://127.0.0.1:8081/cgi-bin/koha/admin/background_jobs.pl?op=view=1) I get an error trace page: Template process failed: file error - background_jobs/search_result_marc_export.inc: not found at /kohadevbox/koha/C4/Templates.pm line 127 in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 127 124: 125: my $data; 126: binmode( STDOUT, ":encoding(UTF-8)" ); 127: $template->process( $self->filename, $vars, \$data ) 128: || die "Template process failed: ", $template->error(); 129: return $data; 130: } I get the same error if I try to view the job details from Administration > Jobs > Manage jobs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #145243|0 |1 is obsolete|| --- Comment #18 from David Gustafsson --- Created attachment 145244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145244=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. This feature is only supported when using Elasticsearch. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the current user has the tools -> export_catalog permission 5) Perform a search 6) Export the serach result by choosing a format under the "Export results" drop down 7) Verify that link(s) with exported data appear when export is completed 8) Revoke the permission in 3) and ensure exporting is no longer possible 9) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #17 from David Gustafsson --- Thanks for the review! Issues should now be fixed. Now using background job when performing the export so removed the feature for sending results in email. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #133076|0 |1 is obsolete|| --- Comment #16 from David Gustafsson --- Created attachment 145243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145243=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. This feature is only supported when using Elasticsearch. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the current user has the tools -> export_catalog permission 5) Perform a search 6) Export the serach result by choosing a format under the "Export results" drop down 7) Verify that link(s) with exported data appear when export is completed 8) Revoke the permission in 3) and ensure exporting is no longer possible 9) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #15 from Katrin Fischer --- Hi David, the QA test tools turn up some issues with this patch, can you please fix? 1) QA test tools FAIL Koha/SearchEngine/Elasticsearch.pm FAIL spelling prefered ==> preferred OK Koha/SearchEngine/Elasticsearch/Search.pm FAIL catalogue/search.pl FAIL critic # ControlStructures::ProhibitMutatingListFunctions: Got 1 violation(s). # Variables::ProhibitUnusedVariables: Got 1 violation(s). OK installer/data/mysql/atomicupdate/bug_27859-add_enable_search_result_marc_export_sysprefs.pl OK installer/data/mysql/mandatory/sysprefs.sql FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt FAIL filters wrong_html_filter at line 325 ( [% custom_export_formats.$id.name | html %]) missing_filter at line 325 ( [% custom_export_formats.$id.name | html %]) missing_filter at line 360 ([% export_message %]) missing_filter at line 363 ([% export_error %]) FAIL t/db_dependent/Koha/SearchEngine/Elasticsearch.t FAIL spelling indentical ==> identical indentical ==> identical 2) Translatability This will not be translatable and should be moved to templates, also the other places where export_links_html is set. HTML should not be generated in .pl files: +$export_links_html = $links_count > 1 ? +"Some records exceeded the maximum size supported by ISO2709 and was exported as MARCXML instead." . $export_links_html : $export_links_html; Also here: $message = "The export finished successfully:" 3) System preferences I am a little in doubt about SearchResultMARCExportFromAddress. The from address can not always be set to be a library specific email, especially for installations hosted centrally by a support provider. We usually tend to use the reply-to for individual settings. But it should for sure be type = email in the .prefs file (activates validation). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #132997|0 |1 is obsolete|| --- Comment #14 from David Gustafsson --- Created attachment 133076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133076=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. The export will be mailed to the configured mail address of the current user. This feature is Elasticsearch only. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the syspref EnableSearchResultMARCExportEmail is enabled 5) Add a custom filter in the SearchResultMARCExportCustomFormats syspref, for example by copying one of the example formats 6) Make sure the current user has the tools -> export_catalog permission 7) Make sure the current user has an email under your control set 8) Perform a search 9) Export the search result for each format in the "Export all results" drop down 10) Verify that link(s) with exported data has been mailed to the provided email 11) Revoke the permission in 3) and make sure exporting is no longer possible 12) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #132993|0 |1 is obsolete|| --- Comment #13 from David Gustafsson --- Created attachment 132997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132997=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. The export will be mailed to the configured mail address of the current user. This feature is Elasticsearch only. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the syspref EnableSearchResultMARCExportEmail is enabled 5) Add a custom filter in the SearchResultMARCExportCustomFormats syspref, for example by copying one of the example formats 6) Make sure the current user has the tools -> export_catalog permission 7) Make sure the current user has an email under your control set 8) Perform a search 9) Export the search result for each format in the "Export all results" drop down 10) Verify that link(s) with exported data has been mailed to the provided email 11) Revoke the permission in 3) and make sure exporting is no longer possible 12) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #12 from David Gustafsson --- Ok! Rebased against master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #131443|0 |1 is obsolete|| --- Comment #11 from David Gustafsson --- Created attachment 132993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132993=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. The export will be mailed to the configured mail address of the current user. This feature is Elasticsearch only. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the syspref EnableSearchResultMARCExportEmail is enabled 5) Make sure the current user has the tools -> export_catalog permission 6) Make sure the current user has an email under your control set 7) Perform a search 8) Export the serach result by choosing a format under the "Export results" drop down 9) Verify that link(s) with exported data has been mailed to the provided email 10) Revoke the permission in 3) and make sure exporting is no longer possible 11) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||severine.que...@bulac.fr --- Comment #10 from Séverine Queune --- Sorry David, patch needs rebase :/ Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27859: marc search result export Using index info to reconstruct a base tree... M Koha/SearchEngine/Elasticsearch/Search.pm M catalogue/search.pl M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging catalogue/search.pl Auto-merging Koha/SearchEngine/Elasticsearch/Search.pm CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 27859: marc search result export hint: Use 'git am --show-current-patch=diff' to see the failed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #131442|0 |1 is obsolete|| --- Comment #9 from David Gustafsson --- Created attachment 131443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131443=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. The export will be mailed to the configured mail address of the current user. This feature is Elasticsearch only. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the syspref EnableSearchResultMARCExportEmail is enabled 5) Make sure the current user has the tools -> export_catalog permission 6) Make sure the current user has an email under your control set 7) Perform a search 8) Export the serach result by choosing a format under the "Export results" drop down 9) Verify that link(s) with exported data has been mailed to the provided email 10) Revoke the permission in 3) and make sure exporting is no longer possible 11) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson changed: What|Removed |Added Attachment #128632|0 |1 is obsolete|| --- Comment #8 from David Gustafsson --- Created attachment 131442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131442=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. The export will be mailed to the configured mail address of the current user. This feature is Elasticsearch only. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the syspref EnableSearchResultMARCExportEmail is enabled 5) Make sure the current user has the tools -> export_catalog permission 6) Make sure the current user has an email under your control set 7) Perform a search 8) Export the serach result by choosing a format under the "Export results" drop down 9) Verify that link(s) with exported data has been mailed to the provided email 10) Revoke the permission in 3) and make sure exporting is no longer possible 11) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Katrin Fischer changed: What|Removed |Added Summary|Marc export for search |MARC export for search |result |results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
