[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Blocks||32262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262 [Bug 32262] smart-rules: Some rules can be created but are not visible on interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #112 from Marcel de Rooy --- I added an open_article_requests_limit without patron category by script. And it works fine. Disadvantage: the record is not shown on the Circulation rules interface.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Keywords|Manual | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Bug 27945 depends on bug 27944, which changed state. Bug 27944 Summary: Add new stages to the article request process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #111 from Jonathan Druart --- (In reply to Jonathan Druart from comment #110) > Created attachment 125761 [details] [review] > Bug 27945: (follow-up) Add tests > > Restore +x flag Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #110 from Jonathan Druart --- Created attachment 125761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125761=edit Bug 27945: (follow-up) Add tests Restore +x flag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #109 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #108 from Tomás Cohen Arazi --- Created attachment 125741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125741=edit Bug 27945: Terminology: max daily => open requests limit Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #107 from Jonathan Druart --- Created attachment 125726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125726=edit Bug 27945: Don't save rule if not defined The DB rev added a row with NULL (unlimited), and the UI a row with '' (unlimited as well) when saved without value. Better is to not have a row (still unlimited) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Jonathan Druart changed: What|Removed |Added Blocks||29169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29169 [Bug 29169] Wrong "daily limit" warning when article request is not available -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Jonathan Druart changed: What|Removed |Added Blocks||29168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 [Bug 29168] Disable "Request article" links when limit is reached -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #106 from Tomás Cohen Arazi --- Created attachment 125707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125707=edit Bug 27945: Fix error handling and translatability This patch adds better error handling and reporting when placing an article request fails. It also makes the error messages translatable. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #105 from Tomás Cohen Arazi --- Created attachment 125706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125706=edit Bug 27945: Implement limits using circulation rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #104 from Tomás Cohen Arazi --- Created attachment 125705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125705=edit Bug 27945: Add max_daily_article_requests circulation rule Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #103 from Tomás Cohen Arazi --- Created attachment 125704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125704=edit Bug 27945: Clarify 'same day' behavior This patch introduces tests for the 'same day' check of the ability to place article requests for a patron. The limit goes against current requests, and those that have been completed on the same day. The tests cover this specific situation. The current behavior is that it takes into account a 24 hr timespan, but consensus on the QA step was that we should do it as 'same day' and use a separate feature request to change this, if required. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #102 from Tomás Cohen Arazi --- Created attachment 125703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125703=edit Bug 27945: Add limit article request feature This patch makes it possible to limit article requests per patron per day. To test: 1. Apply patches 2. updatedatabase 3. Enable ArticleRequests preference 4. Edit a patron category and set an article request limit to 1 CHECK => if you set the limit to anything else but a positive number or empty string, a warning appears 5. In staff search biblios and request an article for a patron of the modified category 6. Repeat step 5 SUCCESS => if limit is reached, when you select the user to request an article a warning appears saying that the limit was reached 7. Repeat steps 5 and 6 but this time in opac SUCCESS => Patron is not allowed to request another article if limit is reached 8. prove t/db_dependent/ArticleRequests.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Edit: This patchset originally changed the 'categories' table structure and relied on that for limit calculation. I removed all that code and squashed into this one, as we moved everything to the circulation_rules table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #101 from Tomás Cohen Arazi --- Created attachment 125702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125702=edit Bug 27945: Add tests Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125150|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125149|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125148|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125147|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125146|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125145|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125144|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125143|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125142|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125140|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125571|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125178|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125690|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125638|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125179|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125569|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #100 from Jonathan Druart --- Why is it a category's attribute and not a circ rule? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #99 from Jonathan Druart --- Created attachment 125690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125690=edit Bug 27945: (follow-up) Clarify 'same day' behavior Don't use MySQLism -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #98 from Marcel de Rooy --- But rhetorical questions dont need an answer ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #97 from Tomás Cohen Arazi --- Created attachment 125638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125638=edit Bug 27945: Clarify 'same day' behavior This patch introduces tests for the 'same day' check of the ability to place article requests for a patron. The limit goes against current requests, and those that have been completed on the same day. The tests cover this specific situation. The current behavior is that it takes into account a 24 hr timespan, but consensus on the QA step was that we should do it as 'same day' and use a separate feature request to change this, if required. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #96 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #95) > (In reply to Tomás Cohen Arazi from comment #92) > > Marcel: what is the right behavior? > > Thats a good question. I'm about to resubmit this patchset with some requests from the RM, and I will make it 'same day' as it was at some point. Sand promise to work on another approach on another bug if it is filed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #95 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #92) > Marcel: what is the right behavior? Thats a good question. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #94 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #91) > The DB structure and data types should help us avoid useless manual > validations. But as we don't use STRICT_TRANS_TABLES, even marking the > column as UNSIGNED INT will allow setting even a string... (nitpicky mode) It will actually raise a non-blocker warnings and the value will be ignored. The DBMS won't store a string into a int ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #93 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #88) > do that more often? We could just check !value < 0 in js as well. The JS validation I added already checks the min value is 1. So no negative values allowed (in the form) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #92 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #87)
> I am not convinced by the COMPLETED, updated_on code:
>
> 965 Returns true if the patron can request articles. As limits apply for
> the patron
> 966 on on the same day, those completed the same day are considered as
> current.
>
> 976 my $dtf = Koha::Database->new->schema->storage->datetime_parser;
> 977 my $compdate = dt_from_string->add( days => -1 );
> 978 my $count = Koha::ArticleRequests->search([
> 979 { borrowernumber => $self->borrowernumber, status =>
> ['REQUESTED','PENDING','PROCESSING'] },
> 980 { borrowernumber => $self->borrowernumber, status =>
> 'COMPLETED', updated_on => { '>', $dtf->format_date($compdate) }},
>
> if today is Oct 1st, $dtf->format_date($compdate) will be Sept 30th and
> updated_on > 2021-09-30 will return the rows updated yesterday as well.
>
> There is no test coverage for that.
So this is the main blocker for this dev. I will add tests:
Marcel: what is the right behavior? 24 hours timespan? same day? I feel like
'same day' is the right thing. But will implement it as you want, so: how?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #91 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #88) > (In reply to Jonathan Druart from comment #86) > > I think so, it does not make sense to have it there. It may be better to > > just remove this check as we have the JS validation. > > > > If it is really what you need, you must use a "int unsigned" at DB level. > > Agustin added the test with \d+ before there was js validation. I agree to > remove it now. Not sure if we should really specify unsigned in SQL; did we > do that more often? We could just check !value < 0 in js as well. The DB structure and data types should help us avoid useless manual validations. But as we don't use STRICT_TRANS_TABLES, even marking the column as UNSIGNED INT will allow setting even a string... This is one of the reasons we should push for the API instead of this controller scripts (for data entry at least), because we can add the rules to the spec, and the OpenAPI plugin validates all the things for us. That said, I believe we can either keep or remove the validation. Keeping it prevents passing bad data manually, removing it cleans the controller a tiny bit. I would say let's do whatever the RM is more comfortable with so we move on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #90 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #89) > (In reply to Jonathan Druart from comment #87) > > > if today is Oct 1st, $dtf->format_date($compdate) will be Sept 30th and > > updated_on > 2021-09-30 will return the rows updated yesterday as well. > > Read 'same day' here as last 24 hours. Are you sure this is correct? Sept 30th 16pm is yesterday for me, and it's Oct 1st 11am now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #89 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #87) > if today is Oct 1st, $dtf->format_date($compdate) will be Sept 30th and > updated_on > 2021-09-30 will return the rows updated yesterday as well. Read 'same day' here as last 24 hours. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #88 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #86) > I think so, it does not make sense to have it there. It may be better to > just remove this check as we have the JS validation. > > If it is really what you need, you must use a "int unsigned" at DB level. Agustin added the test with \d+ before there was js validation. I agree to remove it now. Not sure if we should really specify unsigned in SQL; did we do that more often? We could just check !value < 0 in js as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #87 from Jonathan Druart ---
I am not convinced by the COMPLETED, updated_on code:
965 Returns true if the patron can request articles. As limits apply for the
patron
966 on on the same day, those completed the same day are considered as
current.
976 my $dtf = Koha::Database->new->schema->storage->datetime_parser;
977 my $compdate = dt_from_string->add( days => -1 );
978 my $count = Koha::ArticleRequests->search([
979 { borrowernumber => $self->borrowernumber, status =>
['REQUESTED','PENDING','PROCESSING'] },
980 { borrowernumber => $self->borrowernumber, status => 'COMPLETED',
updated_on => { '>', $dtf->format_date($compdate) }},
if today is Oct 1st, $dtf->format_date($compdate) will be Sept 30th and
updated_on > 2021-09-30 will return the rows updated yesterday as well.
There is no test coverage for that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #86 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #84)
> (In reply to Jonathan Druart from comment #81)
> > 3.
> >
> > +if ($article_request_limit ne '' && $article_request_limit !~ /^\d+$/)
> > {
> > +push @messages, {type => 'error', code =>
> > 'article_request_numeric_limit' };
> > +$op = 'add_form';
> > +} elsif ($article_request_limit ne '' && $article_request_limit < 0) {
> > +push @messages, {type => 'error', code =>
> > 'article_request_negative_limit' };
> > +$op = 'add_form';
> > +} else {
> >
> > Why that?
> > I am expecting to see a JS validation and an exception raised in
> > Koha::Category->store. But not in the controller.
>
> Is this a blocker for inclusion?
I think so, it does not make sense to have it there. It may be better to just
remove this check as we have the JS validation.
If it is really what you need, you must use a "int unsigned" at DB level.
Btw why do you use tinyint(4) when other "limit" columns in the same table are
smallint(6)?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #85 from Tomás Cohen Arazi --- Created attachment 125571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125571=edit Bug 27945: (QA follow-up) Validate the input in the form Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #84 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #81)
> 3.
>
> +if ($article_request_limit ne '' && $article_request_limit !~ /^\d+$/) {
> +push @messages, {type => 'error', code =>
> 'article_request_numeric_limit' };
> +$op = 'add_form';
> +} elsif ($article_request_limit ne '' && $article_request_limit < 0) {
> +push @messages, {type => 'error', code =>
> 'article_request_negative_limit' };
> +$op = 'add_form';
> +} else {
>
> Why that?
> I am expecting to see a JS validation and an exception raised in
> Koha::Category->store. But not in the controller.
Is this a blocker for inclusion?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #83 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #81) > 1. +my $can_request = $borrower->can_request_article > $patron is better now Done. > 2. > +my $compdate = dt_from_string->add( days => -1 ); > I don't understand, what are we doing here? Can you add a line in the POD > about that? Done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #82 from Tomás Cohen Arazi --- Created attachment 125569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125569=edit Bug 27945: (QA follow-up) Clarify behavior in POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #81 from Jonathan Druart ---
1. +my $can_request = $borrower->can_request_article
$patron is better now
2.
+my $compdate = dt_from_string->add( days => -1 );
I don't understand, what are we doing here? Can you add a line in the POD about
that?
3.
+if ($article_request_limit ne '' && $article_request_limit !~ /^\d+$/) {
+push @messages, {type => 'error', code =>
'article_request_numeric_limit' };
+$op = 'add_form';
+} elsif ($article_request_limit ne '' && $article_request_limit < 0) {
+push @messages, {type => 'error', code =>
'article_request_negative_limit' };
+$op = 'add_form';
+} else {
Why that?
I am expecting to see a JS validation and an exception raised in
Koha::Category->store. But not in the controller.
4.
circ/request-article.pl
+error_message => 'Patron cannot request more articles for today'
[% error_message | html %]
Hum? Non translatable message.
Same for the exception actually:
+error_message => $_->{message}
And same in opac-request-article.pl
5. opac-request-article.pl
+exit unless $_->[0] && $_->[0] eq 'EXIT';
This is very awkward. Why not simply having the print+exit outside of the try?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Blocks|29083 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 [Bug 29083] Update article requests-related Koha::Patron methods to use relationships -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Attachment #125152|0 |1 is obsolete|| --- Comment #80 from Marcel de Rooy --- Created attachment 125179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125179=edit Bug 27945: (QA follow-up) Fix and move tests to proper file Koha::Patron methods tests belong to the t/db_dependent/Koha/Patron.t tests file. This patch moves the tests, and also acknowledges the fact that we can use Test::Exception instead of a try/catch block. It also fixes the tests so they actually trigger the ->request method, which is the one that raises the exception if the limit is reached. At some point, because of the dependency mess, this bug ended up with the exception throwing in the wrong method, and that's why tests were also failing. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t \ t/db_dependent/ArticleRequests.t => FAIL: Patron.t passes, ArticleRequests.t doesn't 2. Apply this patch 3. Repeat 1 => SUCCESS: Both pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Attachment #125151|0 |1 is obsolete|| --- Comment #79 from Marcel de Rooy --- Created attachment 125178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125178=edit Bug 27945: Move atomicupdate to new format It also removes the implicit dependency on bug 27946 by changing the AFTER column. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 [Bug 27947] Add default cancellation reasons to article requests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 [Bug 29083] Update article requests-related Koha::Patron methods to use relationships -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #78 from Tomás Cohen Arazi --- Rebased on top of bug 27944, fixed a problem introduced by a rebase, fixed the tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #77 from Tomás Cohen Arazi --- Created attachment 125152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125152=edit Bug 27945: (QA follow-up) Fix and move tests to proper file Koha::Patron methods tests belong to the t/db_dependent/Koha/Patron.t tests file. This patch moves the tests, and also acknowledges the fact that we can use Test::Exception instead of a try/catch block. It also fixes the tests so they actually trigger the ->request method, which is the one that raises the exception if the limit is reached. At some point, because of the dependency mess, this bug ended up with the exception throwing in the wrong method, and that's why tests were also failing. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t \ t/db_dependent/ArticleRequests.t => FAIL: Patron.t passes, ArticleRequests.t doesn't 2. Apply this patch 3. Repeat 1 => SUCCESS: Both pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #76 from Tomás Cohen Arazi --- Created attachment 125151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125151=edit Bug 27945: Move atomicupdate to new format It also removes the implicit dependency on bug 27946 by changing the AFTER column. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #75 from Tomás Cohen Arazi --- Created attachment 125150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125150=edit Bug 27945: (follow-up) Fix tests for the adjusted check Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #74 from Tomás Cohen Arazi --- Created attachment 125149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125149=edit Bug 27945: (QA follow-up) Terminology The term "Maximum article request limit" could be improved. In this patch we use 'Article request limit' to describe it more generic. On the field we say 'Maximum active article requests'. In the manual we need to explain that it is the sum of requests in Pending (Requested) or Processing stage and completed requests within the last 24 hours. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #73 from Tomás Cohen Arazi ---
Created attachment 125148
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125148=edit
Bug 27945: (QA follow-up) Fix limit check
Resolve:
[WARN] SQL::Abstract::belch(): [SQL::Abstract::_where_field_op_ARRAYREF]
Warning: A multi-element arrayref as an argument to the inequality op '!=' is
technically equivalent to an always-true 1=1 (you probably wanted to say ...{
$inequality_op => [ -and => @values ] }... instead) at
/usr/share/koha/Koha/Objects.pm line 601
In this case we can simply count the statuses PENDING and PROCESSING.
Note that bug 27944 will change that; PENDING should be replaced by
REQUESTED there.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #72 from Tomás Cohen Arazi --- Created attachment 125147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125147=edit Bug 27945: (follow-up) fix limit check in Patron.pm, regexp in categories.pl and removed unwanted use Koha::ArticleRequests in ArticleRequest.pm Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #71 from Tomás Cohen Arazi --- Created attachment 125146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125146=edit Bug 27945: (follow-up) Fix column header title and edit form label Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #70 from Tomás Cohen Arazi --- Created attachment 125145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125145=edit Bug 27945: (QA follow-up) Fix exception POD Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #69 from Tomás Cohen Arazi --- Created attachment 125144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125144=edit Bug 27945: Add limit article request feature This patch makes it possible to limit article requests per patron per day. To test: 1. Apply patches 2. updatedatabase 3. Enable ArticleRequests preference 4. Edit a patron category and set an article request limit to 1 CHECK => if you set the limit to anything else but a positive number or empty string, a warning appears 5. In staff search biblios and request an article for a patron of the modified category 6. Repeat step 5 SUCCESS => if limit is reached, when you select the user to request an article a warning appears saying that the limit was reached 7. Repeat steps 5 and 6 but this time in opac SUCCESS => Patron is not allowed to request another article if limit is reached 8. prove t/db_dependent/ArticleRequests.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #68 from Tomás Cohen Arazi --- Created attachment 125143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125143=edit Bug 27945: [DO NOT PUSH] Update DBIx schema Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #67 from Tomás Cohen Arazi --- Created attachment 125142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125142=edit Bug 27945: Add article_request_limit in categories table Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #66 from Tomás Cohen Arazi --- Created attachment 125140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125140=edit Bug 27945: Add tests Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124682|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124681|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124680|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124679|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124678|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124677|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124676|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124675|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124674|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124673|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Blocks|27944 | Depends on||27944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 [Bug 27944] Add new stages to the article request process -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #65 from Tomás Cohen Arazi --- Tests pass on its own, I've now set bugs dependencies, so if other bug breaks this, we will treat it in the specific bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 [Bug 27944] Add new stages to the article request process -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA CC||jonathan.druart+koha@gmail. ||com --- Comment #64 from Jonathan Druart --- If I apply patches from this bug (27945) and the ones from bug 27944 I am getting the following failures: t/db_dependent/ArticleRequests.t .. 22/55 # Failed test 'Limit is 1, so patron cannot request more articles' # at t/db_dependent/ArticleRequests.t line 292. # got: '1' # expected: '0' # Failed test 'There is still an AR, so patron cannot request more articles' # at t/db_dependent/ArticleRequests.t line 309. # got: '1' # expected: '0' # Failed test 'There is still one article request' # at t/db_dependent/ArticleRequests.t line 310. # got: '2' # expected: '1' # Failed test 'A new AR was created, so patron cannot request more articles' # at t/db_dependent/ArticleRequests.t line 329. # got: '1' # expected: '0' # Failed test 'There are 2 article requests' # at t/db_dependent/ArticleRequests.t line 330. # got: '3' # expected: '2' # Failed test 'There is an old AR but not completed or cancelled, so patron cannot request more articles' # at t/db_dependent/ArticleRequests.t line 347. # got: '1' # expected: '0' # Failed test 'There are 3 current article requests' # at t/db_dependent/ArticleRequests.t line 348. # got: '4' # expected: '3' # Looks like you planned 13 tests but ran 12. # Looks like you failed 7 tests of 12 run. t/db_dependent/ArticleRequests.t .. 55/55 # Failed test 'article request limit' # at t/db_dependent/ArticleRequests.t line 350. There are 3 PQA bugs related to article requests (bug 27944, bug 27945 and bug 27947). Please make sure they don't conflict with each others and that the tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #63 from Marcel de Rooy --- (In reply to Agustín Moyano from comment #52) > Created attachment 124633 [details] [review] > Bug 27945: (follow-up) Fix tests for the adjusted check Thx Agustin. Looks good to me now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Attachment #124633|0 |1 is obsolete|| --- Comment #62 from Marcel de Rooy --- Created attachment 124682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124682=edit Bug 27945: (follow-up) Fix tests for the adjusted check Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Attachment #124285|0 |1 is obsolete|| --- Comment #61 from Marcel de Rooy --- Created attachment 124681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124681=edit Bug 27945: (QA follow-up) Terminology The term "Maximum article request limit" could be improved. In this patch we use 'Article request limit' to describe it more generic. On the field we say 'Maximum active article requests'. In the manual we need to explain that it is the sum of requests in Pending (Requested) or Processing stage and completed requests within the last 24 hours. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Marcel de Rooy changed:
What|Removed |Added
Attachment #124284|0 |1
is obsolete||
--- Comment #60 from Marcel de Rooy ---
Created attachment 124680
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124680=edit
Bug 27945: (QA follow-up) Fix limit check
Resolve:
[WARN] SQL::Abstract::belch(): [SQL::Abstract::_where_field_op_ARRAYREF]
Warning: A multi-element arrayref as an argument to the inequality op '!=' is
technically equivalent to an always-true 1=1 (you probably wanted to say ...{
$inequality_op => [ -and => @values ] }... instead) at
/usr/share/koha/Koha/Objects.pm line 601
In this case we can simply count the statuses PENDING and PROCESSING.
Note that bug 27944 will change that; PENDING should be replaced by
REQUESTED there.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Attachment #124079|0 |1 is obsolete|| --- Comment #59 from Marcel de Rooy --- Created attachment 124679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124679=edit Bug 27945: (follow-up) fix limit check in Patron.pm, regexp in categories.pl and removed unwanted use Koha::ArticleRequests in ArticleRequest.pm Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Attachment #124077|0 |1 is obsolete|| --- Comment #58 from Marcel de Rooy --- Created attachment 124678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124678=edit Bug 27945: (follow-up) Fix column header title and edit form label Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Attachment #124076|0 |1 is obsolete|| --- Comment #57 from Marcel de Rooy --- Created attachment 124677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124677=edit Bug 27945: (QA follow-up) Fix exception POD Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Attachment #124075|0 |1 is obsolete|| --- Comment #56 from Marcel de Rooy --- Created attachment 124676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124676=edit Bug 27945: Add limit article request feature This patch makes it possible to limit article requests per patron per day. To test: 1. Apply patches 2. updatedatabase 3. Enable ArticleRequests preference 4. Edit a patron category and set an article request limit to 1 CHECK => if you set the limit to anything else but a positive number or empty string, a warning appears 5. In staff search biblios and request an article for a patron of the modified category 6. Repeat step 5 SUCCESS => if limit is reached, when you select the user to request an article a warning appears saying that the limit was reached 7. Repeat steps 5 and 6 but this time in opac SUCCESS => Patron is not allowed to request another article if limit is reached 8. prove t/db_dependent/ArticleRequests.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Attachment #124074|0 |1 is obsolete|| --- Comment #55 from Marcel de Rooy --- Created attachment 124675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124675=edit Bug 27945: [DO NOT PUSH] Update DBIx schema Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Attachment #124073|0 |1 is obsolete|| --- Comment #54 from Marcel de Rooy --- Created attachment 124674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124674=edit Bug 27945: Add article_request_limit in categories table Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What|Removed |Added Attachment #124072|0 |1 is obsolete|| --- Comment #53 from Marcel de Rooy --- Created attachment 124673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124673=edit Bug 27945: Add tests Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
