[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Caroline Cyr La Rose changed: What|Removed |Added Resolution|--- |FIXED CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs documenting |RESOLVED Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/665 Documentation||Caroline Cyr La Rose contact|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Text to go in the||This patch adds a new release notes||system preference: ||autoControlNumber || ||The ||systempreference has two ||options, Control Number ||(001) is: || - generated as ||biblionumber: will set ||field 001 to the ||biblionumber when you ||create a new record or edit ||an existing record and ||clear the 001 field. If a ||value is present in 001 ||when saving the record it ||will be preserved.When ||duplicating a record the ||pre-existing 001 will be ||removed. || - not generated ||automatically: the 001 ||field will not be touched -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Katrin Fischer changed: What|Removed |Added CC||glask...@gmail.com --- Comment #80 from Katrin Fischer --- *** Bug 29694 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #79 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #78 from Tomás Cohen Arazi --- Created attachment 140502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140502=edit Bug 27981: (QA follow-up) GetMarcBiblio was removed from codebase Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #77 from Andrew Nugged --- Future development note, but this is not in the scope of the CURRENT TICKET: Our librarians also noted that there's a 003 field which might also be auto-filled with some hardcoded value for this autofilled 001. They also noted that "However, it should be the case that the combination of 001 and 003 is always unique."). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #76 from Andrew Nugged --- This bugfix code (including my last patch) was already used in our productions for more than a month as a hotfix, and works well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #75 from Andrew Nugged --- Did QA & Rebased to the latest master. Also added 1 final patch (small polishing step) to use true/false everywhere to unify JS because, KohaBackend.GetRecord( id, remove_control_num, callback ); called in one place with remove_control_num to be 0 or 1, and in another place: KohaBackend.GetRecord( id, "", callback ); let's have it true/false, so the next developer will get from the context that this variable is only boolean. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #74 from Andrew Nugged --- Created attachment 140097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140097=edit Bug 27981: (QA follow-up) Unify JavaScript to false/true from 0/1/"" Make remove_control_num var and JS KohaBackend.GetRecord calls to have only false/true instead of mixed 0,1, and "" in different places. Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #73 from Andrew Nugged --- Created attachment 140096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140096=edit Bug 27981: (follow-up) Fix tests Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #72 from Andrew Nugged --- Created attachment 140095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140095=edit Bug 27981: (follow-up) Correct variable Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #71 from Andrew Nugged --- Created attachment 140094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140094=edit Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950 Signed-off-by: Thomas Klausner Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #70 from Andrew Nugged --- Created attachment 140093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140093=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record and clear the 001 field. If a value is present in 001 when saving the record it will be preserved. If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To test duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save Signed-off-by: Marcel de Rooy Signed-off-by: Thomas Klausner Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Andrew Nugged changed: What|Removed |Added Attachment #134536|0 |1 is obsolete|| Attachment #134537|0 |1 is obsolete|| Attachment #134538|0 |1 is obsolete|| Attachment #134539|0 |1 is obsolete|| Attachment #136022|0 |1 is obsolete|| --- Comment #69 from Andrew Nugged --- Created attachment 140092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140092=edit Bug 27981: DB update Signed-off-by: Thomas Klausner Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Andrew Nugged changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Katrin Fischer changed: What|Removed |Added Blocks||28685 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28685 [Bug 28685] Should AutoControlNumber also overwrite 003 field ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Katrin Fischer changed: What|Removed |Added CC||ha...@orex.es --- Comment #68 from Katrin Fischer --- *** Bug 23832 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #67 from Nick Clemens --- Created attachment 136022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136022=edit Bug 27981: (follow-up) Fix tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #66 from Katrin Fischer ---
This is a really interesting dev I've been often asked about. But: Tests are
currently failing:
prove t/db_dependent/Biblio.t
t/db_dependent/Biblio.t .. 8/15 # Looks like you planned 3 tests but ran 1.
# Failed test 'autoControlNumber tests'
# at t/db_dependent/Biblio.t line 846.
Can't use string ("1") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/C4/Biblio.pm line 362.
# Looks like your test exited with 255 just after 15.
t/db_dependent/Biblio.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/15 subtests
Test Summary Report
---
t/db_dependent/Biblio.t (Wstat: 65280 Tests: 15 Failed: 1)
Failed test: 15
Non-zero exit status: 255
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #65 from Katrin Fischer --- Thx Nick for adding the sign-off lines :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #64 from Nick Clemens --- Created attachment 134539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134539=edit Bug 27981: (follow-up) Correct variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Attachment #132036|0 |1 is obsolete|| --- Comment #63 from Nick Clemens --- Created attachment 134538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134538=edit Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950 Signed-off-by: Thomas Klausner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Attachment #132035|0 |1 is obsolete|| --- Comment #62 from Nick Clemens --- Created attachment 134537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134537=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record and clear the 001 field. If a value is present in 001 when saving the record it will be preserved. If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To test duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save Signed-off-by: Marcel de Rooy Signed-off-by: Thomas Klausner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Attachment #132034|0 |1 is obsolete|| --- Comment #61 from Nick Clemens --- Created attachment 134536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134536=edit Bug 27981: DB update Signed-off-by: Thomas Klausner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Thomas Klausner changed: What|Removed |Added CC||d...@plix.at --- Comment #60 from Thomas Klausner --- I tested this feature, everything works as expected / documented, but I (currently) don't have time to set up a proper sign-off workflow ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #59 from Nick Clemens --- Created attachment 132036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132036=edit Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #58 from Nick Clemens --- Created attachment 132035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132035=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record and clear the 001 field. If a value is present in 001 when saving the record it will be preserved. If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To test duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Attachment #128223|0 |1 is obsolete|| Attachment #128224|0 |1 is obsolete|| Attachment #128225|0 |1 is obsolete|| --- Comment #57 from Nick Clemens --- Created attachment 132034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132034=edit Bug 27981: DB update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #56 from Nick Clemens --- Created attachment 128225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128225=edit Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #55 from Nick Clemens --- Created attachment 128224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128224=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record and clear the 001 field. If a value is present in 001 when saving the record it will be preserved. If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To test duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Attachment #124279|0 |1 is obsolete|| Attachment #124280|0 |1 is obsolete|| Attachment #124281|0 |1 is obsolete|| --- Comment #54 from Nick Clemens --- Created attachment 128223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128223=edit Bug 27981: DB update Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #53 from Katrin Fischer --- Is the sequence of the attached patch files correct? (QA follow-up on top) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #52 from Marcel de Rooy --- I think this needs to be Needs Signoff. If someone signs off on the last patch, I probably could do the QA again ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #51 from Nick Clemens --- (In reply to David Cook from comment #46) > Thanks for working on this, Nick. This is a feature I've long wanted in Koha. > > I've just taken a quick peek at the code, so just going to ask for some > clarification. > > At a glance, it looks like a 001 will be assigned for original cataloguing > or copy cataloguing using the Cataloguing UI (even if it already has a 001), > is that right? That sounds good to me. > > I wonder about Staged MARC Imports though. At a glance, I think those will > retain their original 001 and won't get updated. I think that might be > problematic. > > Same goes for the APIs. Updated importing and svc/import_bibs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #50 from Nick Clemens --- (In reply to Marcel de Rooy from comment #45) > (In reply to Marcel de Rooy from comment #42) > > Commit promises: > > The option "biblionumber" will set field 001 to the biblionumber when you > > create a new record or edit an existing record > > > > Create works, modify does not. > > And it contradicts the test plan: > 14 - Edit a record with an existing 001 that is not the biblionumber > 15 - Save and confirm 001 is not updated Updated the commit message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #49 from Nick Clemens --- Created attachment 124281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124281=edit Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #48 from Nick Clemens --- Created attachment 124280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124280=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record and clear the 001 field. If a value is present in 001 when saving the record it will be preserved. If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To test duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Attachment #122674|0 |1 is obsolete|| Attachment #122675|0 |1 is obsolete|| --- Comment #47 from Nick Clemens --- Created attachment 124279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124279=edit Bug 27981: (QA follow-up) Adjust atomic update [1] Insert ignore. [2] Remove references to bug 9921. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #46 from David Cook --- Thanks for working on this, Nick. This is a feature I've long wanted in Koha. I've just taken a quick peek at the code, so just going to ask for some clarification. At a glance, it looks like a 001 will be assigned for original cataloguing or copy cataloguing using the Cataloguing UI (even if it already has a 001), is that right? That sounds good to me. I wonder about Staged MARC Imports though. At a glance, I think those will retain their original 001 and won't get updated. I think that might be problematic. Same goes for the APIs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #45 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #42) > Commit promises: > The option "biblionumber" will set field 001 to the biblionumber when you > create a new record or edit an existing record > > Create works, modify does not. And it contradicts the test plan: 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What|Removed |Added Attachment #122672|0 |1 is obsolete|| --- Comment #44 from Marcel de Rooy --- Created attachment 122675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122675=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To test duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What|Removed |Added Attachment #122356|0 |1 is obsolete|| --- Comment #43 from Marcel de Rooy --- Created attachment 122674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122674=edit Bug 27981: (QA follow-up) Adjust atomic update [1] Insert ignore. [2] Remove references to bug 9921. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #42 from Marcel de Rooy --- Commit promises: The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record Create works, modify does not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #41 from Marcel de Rooy --- (In reply to Nick Clemens from comment #40) > (In reply to Marcel de Rooy from comment #38) > > Nick: There is also another point still. If we update 001, we should update > > the orgcode too in 003. > > See also bug 28491 for authority counterpart. > > adding orgcode feels like scope creep - file another bug? Done. See also -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28685 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #40 from Nick Clemens --- (In reply to Marcel de Rooy from comment #38) > Nick: There is also another point still. If we update 001, we should update > the orgcode too in 003. > See also bug 28491 for authority counterpart. adding orgcode feels like scope creep - file another bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Attachment #122344|0 |1 is obsolete|| --- Comment #39 from Nick Clemens --- Created attachment 122672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122672=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To test duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #38 from Marcel de Rooy --- Nick: There is also another point still. If we update 001, we should update the orgcode too in 003. See also bug 28491 for authority counterpart. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #37 from Jonathan Druart --- Yes, that's definitely hacky and it will complicate the move when we will replace svc/bib with a REST API call. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #36 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #34) > (In reply to Nick Clemens from comment #32) > > I get the extra warning if i run the test before the DB update, but all is > > good after > > Still have it. Forget this one: strict sql mode stuff.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Status|Needs Signoff |Failed QA --- Comment #35 from Marcel de Rooy --- > A 'duplication' option is add to svc/bib and rancor passes the parameter, > the basic editor simply removes the field I dont think that we should go that way. The changes to svc/bib do not look good to me. The strange d parameter in the path svc/bib/d1 is rather hacky. Personally, I would rather go away from the whole path_info tric to get the biblionumber and just have a real biblionumber parameter. But we should not spend too much time on this old service script when we have an API. Instead of changing svc/bib, could you move the change to where rancor saves a duplicated record? Adding Jonathan to the discussion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #34 from Marcel de Rooy --- (In reply to Nick Clemens from comment #32) > I get the extra warning if i run the test before the DB update, but all is > good after Still have it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #33 from Marcel de Rooy --- Created attachment 122356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122356=edit Bug 27981: (QA follow-up) Adjust atomic update [1] Insert ignore. [2] Remove references to bug 9921. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #32 from Nick Clemens --- (In reply to Marcel de Rooy from comment #30) > Please cleanup your patches! > Please amend the first patch where you delete the buggy lines too ;) Patches squashed, back to NSO (In reply to Marcel de Rooy from comment #29) > # found warning: Use of uninitialized value in string eq at > /usr/share/koha/C4/Biblio.pm line 2632. > # found warning: My biblionumber is 130 and my frameworkcode is at > t/db_dependent/Biblio.t line 78. > # expected to find warning: (?^u:My biblionumber is \d+ and my > frameworkcode is ) > # Looks like you failed 5 tests of 5. > not ok 2 - AddBiblio I get the extra warning if i run the test before the DB update, but all is good after -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Attachment #119704|0 |1 is obsolete|| Attachment #121805|0 |1 is obsolete|| Attachment #122301|0 |1 is obsolete|| --- Comment #31 from Nick Clemens --- Created attachment 122344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122344=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set A 'duplication' option is add to svc/bib and rancor passes the parameter, the basic editor simply removes the field To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To testi duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #30 from Marcel de Rooy ---
Please cleanup your patches!
diff --git a/members/memberentry.pl b/members/memberentry.pl
index abae2ec53e..da8a324c78 100755
--- a/members/memberentry.pl
+++ b/members/memberentry.pl
@@ -109,9 +109,7 @@ $template->param( relationships => scalar
$patron->guarantor_relationships ) if
my @relations = split /\|/, C4::Context->preference('borrowerRelationship'),
-1;
@relations = ('') unless @relations;
-warn Data::Dumper::Dumper( \@relations );
my $empty_relationship_allowed = grep {$_ eq ""} @relations;
-warn $empty_relationship_allowed;
$template->param( empty_relationship_allowed => $empty_relationship_allowed );
my $guarantor_id = $input->param('guarantor_id');
This really does not need to be in any of these patches.
Please amend the first patch where you delete the buggy lines too ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #29 from Marcel de Rooy --- # Subtest: AddBiblio 1..5 not ok 1 - expected warnings when adding too long LCCN # Failed test 'expected warnings when adding too long LCCN' # at t/db_dependent/Biblio.t line 61. # found warning: Use of uninitialized value in string eq at /usr/share/koha/C4/Biblio.pm line 2632. # expected to find warning: (?^u:Data too long for column 'lccn') # expected to find warning: (?^u:Data too long for column 'lccn') not ok 2 - AddBiblio returns undef for biblionumber if something went wrong # Failed test 'AddBiblio returns undef for biblionumber if something went wrong' # at t/db_dependent/Biblio.t line 63. # got: '129' # expected: undef not ok 3 - AddBiblio returns undef for biblioitemnumber if something went wrong # Failed test 'AddBiblio returns undef for biblioitemnumber if something went wrong' # at t/db_dependent/Biblio.t line 65. # got: '129' # expected: undef not ok 4 - No biblio should have been added if something went wrong # Failed test 'No biblio should have been added if something went wrong' # at t/db_dependent/Biblio.t line 68. # got: '3' # expected: '2' not ok 5 - The biblionumber is correctly passed to BiblioAutoLink # Failed test 'The biblionumber is correctly passed to BiblioAutoLink' # at t/db_dependent/Biblio.t line 81. # found warning: Use of uninitialized value in string eq at /usr/share/koha/C4/Biblio.pm line 2632. # found warning: My biblionumber is 130 and my frameworkcode is at t/db_dependent/Biblio.t line 78. # expected to find warning: (?^u:My biblionumber is \d+ and my frameworkcode is ) # Looks like you failed 5 tests of 5. not ok 2 - AddBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |BLOCKED --- Comment #28 from Marcel de Rooy --- I will pickup QA again here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #27 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #25) > Hi Hakam, should this be switched to signed off? > > I notice you only reattached the last patch. Usually we will add sign-off > lines to all patches and then reattach them all with them. If you need help > on how to do so, please let us know. Oops it is somebody else :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #26 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #25) > Hi Hakam, should this be switched to signed off? > > I notice you only reattached the last patch. Usually we will add sign-off > lines to all patches and then reattach them all with them. If you need help > on how to do so, please let us know. Hakam signed off on two patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #25 from Katrin Fischer --- Hi Hakam, should this be switched to signed off? I notice you only reattached the last patch. Usually we will add sign-off lines to all patches and then reattach them all with them. If you need help on how to do so, please let us know. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Hakam Almotlak changed: What|Removed |Added Attachment #122280|0 |1 is obsolete|| --- Comment #24 from Hakam Almotlak --- Created attachment 122301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122301=edit Bug 27981: (follow-up) Handle duplciation and remove debug There were some additional lines in the commits on accident I add a 'duplication' option to svc/bib and pass the parameter from rancor to remove the 001 if autoControlNumber is set I add code to addbiblio.pl to remove 001 in standard editor To test: 1 - Follow above test plan 2 - Edit a record as duplicate when using the advanced editor 3 - Confirm the 001 does not load, but record saves correctly 4 - Edit the record 5 - Switch to 'basic editor' 6 - Save, then view record 7 - Edit as duplicate in basic editor 8 - Confirm the 001 is removed 9 - Confirm the 001 is added on save Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #23 from Nick Clemens --- (In reply to Marcel de Rooy from comment #18) > The problem with leaving a number might be when you are cloning records with > Edit as new. When you do not modify that 001, it is probably wrong. New patch, back to NSO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #22 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #20)
> +}elsif($record->field('001')->data() eq 'biblionumber'){
>
> How and when will the 001 ever be string biblionumber ?
Either I was thinking this would be a way to force it, or I was editing my
conditionals and got confused between syspref and record data. Removed in any
case
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #21 from Nick Clemens --- Created attachment 122280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122280=edit Bug 27981: (follow-up) Handle duplciation and remove debug There were some additional lines in the commits on accident I add a 'duplication' option to svc/bib and pass the parameter from rancor to remove the 001 if autoControlNumber is set I add code to addbiblio.pl to remove 001 in standard editor To test: 1 - Follow above test plan 2 - Edit a record as duplicate when using the advanced editor 3 - Confirm the 001 does not load, but record saves correctly 4 - Edit the record 5 - Switch to 'basic editor' 6 - Save, then view record 7 - Edit as duplicate in basic editor 8 - Confirm the 001 is removed 9 - Confirm the 001 is added on save -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #20 from Marcel de Rooy ---
+}elsif($record->field('001')->data() eq 'biblionumber'){
How and when will the 001 ever be string biblionumber ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #19 from Marcel de Rooy --- This still needs more attention, I am afraid? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #18 from Marcel de Rooy --- The problem with leaving a number might be when you are cloning records with Edit as new. When you do not modify that 001, it is probably wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #17 from Marcel de Rooy --- Might start to get what you mean btw.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #16 from Marcel de Rooy ---
(In reply to Nick Clemens from comment #15)
> (In reply to Marcel de Rooy from comment #14)
> > +unless($record->field('001')){
> > +$record->insert_fields_ordered(MARC::Field->new('001',
> > $biblionumber));
> > +}elsif($record->field('001')->data() eq 'biblionumber'){
> > +$record->field('001')->update($biblionumber);
> > +}
> >
> > Please explain.
> > Why do you test eq 'biblionumber' ??
> > Why not always overwrite 001 with $biblionumber if the pref is set ?
>
> Similar to autobarcode or automembernum - we will default, but if you force
> a new value we let it stand - I think allowing the librarian to force a
> different number allows for collections that fall outside the norm.
>
> It could be useful for an OAI set for instance
Maybe you do not understand my point?
Read this line:
> > +}elsif($record->field('001')->data() eq 'biblionumber'){
You are comparing with the string biblionumber !
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #15 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #14)
> +unless($record->field('001')){
> +$record->insert_fields_ordered(MARC::Field->new('001',
> $biblionumber));
> +}elsif($record->field('001')->data() eq 'biblionumber'){
> +$record->field('001')->update($biblionumber);
> +}
>
> Please explain.
> Why do you test eq 'biblionumber' ??
> Why not always overwrite 001 with $biblionumber if the pref is set ?
Similar to autobarcode or automembernum - we will default, but if you force a
new value we let it stand - I think allowing the librarian to force a different
number allows for collections that fall outside the norm.
It could be useful for an OAI set for instance
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #14 from Marcel de Rooy ---
+unless($record->field('001')){
+$record->insert_fields_ordered(MARC::Field->new('001',
$biblionumber));
+}elsif($record->field('001')->data() eq 'biblionumber'){
+$record->field('001')->update($biblionumber);
+}
Please explain.
Why do you test eq 'biblionumber' ??
Why not always overwrite 001 with $biblionumber if the pref is set ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #13 from Marcel de Rooy --- Note that the Biblio.t test already fails without this patch.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #12 from Marcel de Rooy --- Processing additional checks * Signed-off-by line 'Signed-off-by: Salman Ali ' seems invalid This email adress does not work, Salman ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #11 from Marcel de Rooy --- FAIL members/memberentry.pl OK critic FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 112) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Salman Ali changed: What|Removed |Added CC||salman@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Salman Ali changed: What|Removed |Added Attachment #119717|0 |1 is obsolete|| --- Comment #10 from Salman Ali --- Created attachment 121805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121805=edit Bug 27981: (follow-up) Set pref off for existing tests The patches applies now. I have tested it and can confirm that it works as intended. Signed-off-by: Frank Hansen Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Frank Hansen changed: What|Removed |Added Attachment #119705|0 |1 is obsolete|| --- Comment #9 from Frank Hansen --- Created attachment 119717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119717=edit Bug 27981: (follow-up) Set pref off for existing tests The patches applies now. I have tested it and can confirm that it works as intended. Signed-off-by: Frank Hansen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Frank Hansen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Attachment #118513|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 119705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119705=edit Bug 27981: (follow-up) Set pref off for existing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Attachment #118461|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 119704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119704=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record If set to 'OFF' the 001 field wil not be touched To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Frank Hansen changed: What|Removed |Added CC||frank.han...@ub.lu.se Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Frank Hansen --- The patch doesn't apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27981: Add option to automatically set 001 to the biblionumber Applying: Bug 27981: (follow-up) Set pref off for existing tests error: sha1 information is lacking or useless (members/memberentry.pl). error: could not build fake ancestor Patch failed at 0001 Bug 27981: (follow-up) Set pref off for existing tests Needs to be rebased? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #5 from Nick Clemens --- I don't recreate this, can you test against master too? I don't see how these changes would case these failures (In reply to Marcel de Rooy from comment #3) > # Failed test 'AddBiblio' > # at t/db_dependent/Biblio.t line 70. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #4 from Nick Clemens --- Created attachment 118513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118513=edit Bug 27981: (follow-up) Set pref off for existing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Marcel de Rooy --- # Subtest: AddBiblio 1..4 not ok 1 - expected warnings when adding too long LCCN # Failed test 'expected warnings when adding too long LCCN' # at t/db_dependent/Biblio.t line 61. # found warning: Use of uninitialized value in string eq at /usr/share/koha/C4/Biblio.pm line 2630. # expected to find warning: (?^u:Data too long for column 'lccn') # expected to find warning: (?^u:Data too long for column 'lccn') not ok 2 - AddBiblio returns undef for biblionumber if something went wrong # Failed test 'AddBiblio returns undef for biblionumber if something went wrong' # at t/db_dependent/Biblio.t line 63. # got: '1572' # expected: undef not ok 3 - AddBiblio returns undef for biblioitemnumber if something went wrong # Failed test 'AddBiblio returns undef for biblioitemnumber if something went wrong' # at t/db_dependent/Biblio.t line 65. # got: '1508' # expected: undef not ok 4 - No biblio should have been added if something went wrong # Failed test 'No biblio should have been added if something went wrong' # at t/db_dependent/Biblio.t line 68. # got: '1031' # expected: '1030' # Looks like you failed 4 tests of 4. not ok 2 - AddBiblio # Failed test 'AddBiblio' # at t/db_dependent/Biblio.t line 70. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
