[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Fridolin Somers changed: What|Removed |Added Blocks||36649 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36649 [Bug 36649] Adding recently added items to processing from waiting list does not work if processing includes information from database columns -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Angela Berrett changed: What|Removed |Added Blocks||36286 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36286 [Bug 36286] Add ability to upload files/images in Preservation Module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Tomás Cohen Arazi changed: What|Removed |Added Blocks||36629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36629 [Bug 36629] Wrong status when removing item from waiting list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Tomás Cohen Arazi changed: What|Removed |Added Blocks||36565 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 [Bug 36565] Fix API docs inconsistencies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Fridolin Somers changed: What|Removed |Added Blocks||35759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35759 [Bug 35759] Preservation module home yields a blank page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Katrin Fischer changed: What|Removed |Added Blocks||35477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 [Bug 35477] Can't add items to train, claims barcode unknown or in waiting list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Katrin Fischer changed: What|Removed |Added Blocks||35476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 [Bug 35476] Submit button for adding new processings is not translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Caroline Cyr La Rose changed: What|Removed |Added Blocks||35463 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 [Bug 35463] Link preservation module help to the manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Component|Tools |Preservation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Amaury GAU changed: What|Removed |Added Documentation||amaury@bulac.fr contact|| Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/756 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart changed: What|Removed |Added Blocks||35376 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35376 [Bug 35376] Rephrase: Be careful removing attribute to this processing, the items using it will be impacted as well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Tomás Cohen Arazi changed: What|Removed |Added Blocks||35387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387 [Bug 35387] Capitalization: 'name' label in preservation module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Fridolin Somers changed: What|Removed |Added Blocks||35377 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35377 [Bug 35377] Terminology: Callnumber shoudl be call number -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Amaury GAU changed: What|Removed |Added Text to go in the||This new module allows release notes||libraries to integrate ||preservation treatments ||into their workflow and ||monitor them. ||Its main goal ||is to attach data about the ||preservation treatments to ||items (contained in a new ||Koha table). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed | CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Tomás Cohen Arazi changed: What|Removed |Added Blocks||35230 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35230 [Bug 35230] `catalogue_item` missing description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart changed: What|Removed |Added Blocks||35201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35201 [Bug 35201] Cypress tests for the Preservation module are failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart changed: What|Removed |Added Attachment #157514|0 |1 is obsolete|| --- Comment #172 from Jonathan Druart --- Created attachment 157557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157557=edit Bug 30708: Adjust spec for train_item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #171 from Jonathan Druart --- Created attachment 157514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157514=edit Bug 30708: Adjust spec for train_item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #170 from Tomás Cohen Arazi --- Created attachment 157512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157512=edit Bug 30708: Last spec fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #169 from Jonathan Druart --- Created attachment 157508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157508=edit Bug 30708: Fix API specs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #168 from Tomás Cohen Arazi --- Created attachment 157506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157506=edit Bug 30708: Add missing koha_object(s)_class definitions Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #167 from Tomás Cohen Arazi --- Created attachment 157503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157503=edit Bug 30708: Some spec fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #166 from Tomás Cohen Arazi --- Created attachment 157502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157502=edit Bug 30708: Add 'preservation' to Makefile.PL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #165 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #164 from Katrin Fischer --- So with the amount of testing we got here - Nick also said he ran through the test plan I think - are we ready to push? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #163 from Jonathan Druart --- I have opened bug 35071 if we want to continue this discussion and find a better solution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart changed: What|Removed |Added Blocks||35071 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35071 [Bug 35071] Disambiguate "train" for translators -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 David Cook changed: What|Removed |Added Status|In Discussion |Passed QA --- Comment #162 from David Cook --- (In reply to Jonathan Druart from comment #160) > I don't mind changing everything, and retesting the whole thing. But maybe > it would be nice for the everybody's sanity (and especially mine here) to > wake up before things have passed the finish line?... In the interest of sanity, I think that it's probably too late to make a change from "train" to "batch". As Heather mentioned, I do think that people can become accustomed to the "train" terminology as being specifically part of Koha. Perhaps the documentation can address it by saying it is synonymous with batch. I suppose we'll see how translators go. > Please take a decision ASAP. > > I am in the "train" side (how/when do we vote?). I suppose we don't really have a good process for working out situations like this. But I've posed the question and no one seems to think it's a blocker so I'm moving back to "Passed QA". I suppose that this train will keep chugging along. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #161 from Katrin Fischer --- I am ok with keeping it as Heather confirmed as a native speaker that it makes sense to her. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #160 from Jonathan Druart --- Number of lines with "train" % git grep -i train|grep -vi constraint|wc -l 1443 They are almost all valid. That's the number of lines that I will need to change (not counting the number of files to rename). This "train" word is public since the beginning of the development, and we make sure to have people with interest in it onboard with us very soon (to avoid those kind of disagreement, lol!). I don't mind changing everything, and retesting the whole thing. But maybe it would be nice for the everybody's sanity (and especially mine here) to wake up before things have passed the finish line?... Please take a decision ASAP. I am in the "train" side (how/when do we vote?). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #159 from Katrin Fischer --- Hi Heather, I admit, I also stumbled on the train terminology - for translators I think it might be easier to use batch. I remember someone abbreviated category with 'cat' in the GUI once, and you can imagine how well that ended ;) *meow* But: I would not insist on changing it, knowing it's a term used in preservation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #158 from Jonathan Druart --- (In reply to Heather from comment #157) > (And am I the only one hearing the song, "C'mon N' Ride It (The Train)" > every time I think about this bug? "It's the choo choo! It's the choo > choo!!") I am glad you found THE point nobody will be able to counter-argument! :D Thanks for your input! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #157 from Heather --- Hi! I think the fact that the term "train" is a cognate in English and French, two widely used languages worldwide, is a strong argument in its favor. Although https://wiki.koha-community.org/wiki/Documentation_-_Content_Development_Guide states, "Language - US English (Simplified)," the word "train" is very common. Moreover, a "truck train" is a commonly understood term for a bunch of trailers attached to one cab--and a preservation "train" is a similar thing, with a bunch of items needing preservation treatments all going off together! Yes--"batch" is more commonly used in US English preservation work. And, yes, we are preferring US English in the Koha English interface (e.g., the button says "Cataloging" not "Cataloguing"), but, to me, that doesn't mean that one necessarily needs to select a more common term in a non-automated workflow when automating the workflow. I think the Preservation Module in Koha will be automating workflows in A LOT of libraries that have not had the opportunity to incorporate automated preservation workflows into their ILS, and so it will be easy to adapt to saying, e.g., "This batch that we used to represent on a spreadsheet will be represented in a Koha Train." (We all call "developments" "bugs" and got used to that, too!) (And am I the only one hearing the song, "C'mon N' Ride It (The Train)" every time I think about this bug? "It's the choo choo! It's the choo choo!!") A Koha Train. Makes sense to me! But I also would happily stand aside on the issue if others feel strongly about changing the language to "batch"--it's not a big deal for me. --USian Cataloger Who Also Does Preservation, h2:) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 David Cook changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #156 from David Cook --- Adding in Katrin as she might have some input from the translator perspective -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 David Cook changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #155 from David Cook --- Apologies for coming in this late, but I'm a bit concerned about the use of the term "train" here. Jonathan has explained the term at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708#c19 and I've briefly read through the "Utilisateurs"/"Users" specifications. The French PDF uses the term "Train" while the English PDF uses the term "Batch", which is a more common term in English and in Koha. I took a preservation course during my librarian degree and I'd never heard the term "train" used in the context of preservation, so I think librarians with previous preservation experience might be confused/confronted by preservation in Koha. I imagine that this might also cause some issues for translators? I've briefly moved the status from "Passed QA" to "In Discussion" as I'd like to gather some more feedback about this term... ...but at the same time I don't necessarily want to hold up this development. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Bug 30708 depends on bug 34418, which changed state. Bug 34418 Summary: Allow empty nodes in breadcrumb's elements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Bug 30708 depends on bug 34055, which changed state. Bug 34055 Summary: Add API client class to get items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34055 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Bug 30708 depends on bug 34215, which changed state. Bug 34215 Summary: Vue Toolbar component should be more flexible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34215 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #154 from Nick Clemens --- (In reply to Marcel de Rooy from comment #153) > See former comments. Looks good to me. Another set of QA eyes would not hurt > but I do not feel that it is a must. Feel free to change status back and > have another QA round if so. I didn't read the code, but I ran through the test plan to QA the notice slips, things work as expected and seems like a cool new workflow -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Nicolas Legrand changed: What|Removed |Added CC||nicolas.legr...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #153 from Marcel de Rooy --- See former comments. Looks good to me. Another set of QA eyes would not hurt but I do not feel that it is a must. Feel free to change status back and have another QA round if so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #156597|0 |1 is obsolete|| --- Comment #152 from Marcel de Rooy --- Created attachment 156675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156675=edit Bug 30708: Remove c->validation in API controllers Fixed conflict with bug 33556 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #156596|0 |1 is obsolete|| --- Comment #151 from Marcel de Rooy --- Created attachment 156674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156674=edit Bug 30708: Fix conflict with 34055 and 34219 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #156592|0 |1 is obsolete|| --- Comment #150 from Marcel de Rooy --- Created attachment 156673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156673=edit Bug 30708: Pass csrf_token to the Vue app It's needed since bug 34369 to POST to the syspref route Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154203|0 |1 is obsolete|| --- Comment #149 from Marcel de Rooy --- Created attachment 156672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156672=edit Bug 30708: Do not allow non-authorised users to edit the settings In case the logged in user does not have manage_sysprefs we should no display the form in the settings. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154202|0 |1 is obsolete|| --- Comment #148 from Marcel de Rooy --- Created attachment 156671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156671=edit Bug 30708: Rebase - Use a dedicated 'config' endpoint To retrieve the sysprefs, instead of using the svc script. See bug 33606. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154201|0 |1 is obsolete|| --- Comment #147 from Marcel de Rooy --- Created attachment 156670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156670=edit Bug 30708: Rebase - Adjust breadcrumbs To match what has been done on bug 33169 and bug 34418. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154200|0 |1 is obsolete|| --- Comment #146 from Marcel de Rooy --- Created attachment 156669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156669=edit Bug 30708: Rebase - Use name instead of url for router-links Adjust code to match changes done by bug 32932. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154199|0 |1 is obsolete|| --- Comment #145 from Marcel de Rooy --- Created attachment 156668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156668=edit Bug 30708: Rebase - Rewrite toolbar Bug 33417 has changed how we handle the toolbars in Vue apps, this patch is adjusting the 'Preservation' module code on top of it, but also adds to make it more flexible (see bug 34215). Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154198|0 |1 is obsolete|| --- Comment #144 from Marcel de Rooy --- Created attachment 156667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156667=edit Bug 30708: (bugfix) Redirect to train list view after the train is deleted Do not stay on the show train view. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154197|0 |1 is obsolete|| --- Comment #143 from Marcel de Rooy --- Created attachment 15 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15=edit Bug 30708: Remove q_header from specs It broke the REST API routes. Adjustement for bug 33971. Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154196|0 |1 is obsolete|| --- Comment #142 from Marcel de Rooy --- Created attachment 156665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156665=edit Bug 30708: Fix Trains.ts tests Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154195|0 |1 is obsolete|| --- Comment #141 from Marcel de Rooy --- Created attachment 156664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156664=edit Bug 30708: Deal with deleted authorised value categories If a AV category is renamed or deleted, the app will freeze with "TypeError: av_match is undefined" To prevent that we add an check to prevent the freeze and a warning in the settings. We could eventually add a FK on option_source, but the idea was to let it flexible in case we want to add another source. This bug can be considered a configuration error anyway. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154194|0 |1 is obsolete|| --- Comment #140 from Marcel de Rooy --- Created attachment 156663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156663=edit Bug 30708: Add missing action buttons for non-table view If items with different processings are in a train, there is only the "edit" action button. It's missing "Remove" and "Copy". Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154193|0 |1 is obsolete|| --- Comment #139 from Marcel de Rooy --- Created attachment 156662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156662=edit Bug 30708: Add a default sort for trains We want opened, closed, sent, then finally received trains. But ordering by desc for opened, and asc for the others. Which means the last opened will be first, but the closed, send and received will display oldest first. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154192|0 |1 is obsolete|| --- Comment #138 from Marcel de Rooy --- Created attachment 156661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156661=edit Bug 30708: Prevent dropdown list to be hidden behind the modal Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154191|0 |1 is obsolete|| --- Comment #137 from Marcel de Rooy --- Created attachment 156660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156660=edit Bug 30708: Add spacing for buttons Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154190|0 |1 is obsolete|| --- Comment #136 from Marcel de Rooy --- Created attachment 156659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156659=edit Bug 30708: Display AV descriptions instead of codes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154189|0 |1 is obsolete|| --- Comment #135 from Marcel de Rooy --- Created attachment 156658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156658=edit Bug 30708: Set default values for items added in batch to a train Technical notes: Ideally we would have split TrainsFormAddItem to make some part reusable, but it turned out into a complicated component that would have been hard to maintain. It seems easier to have two different components. Ideas to improve this area are welcome! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154188|0 |1 is obsolete|| --- Comment #134 from Marcel de Rooy --- Created attachment 156657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156657=edit Bug 30708: Allow modifying attribute linked with AV to another value If a value is not in the AV list, or if it differs slightly, they would like to force the modification of the value, without creating a new authorised value. Note that this could be a candidate for an option at the attribute level if there are different needs (ie. for some attributes we don't want to allow an other value). Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154187|0 |1 is obsolete|| --- Comment #133 from Marcel de Rooy --- Created attachment 156656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156656=edit Bug 30708: DBIC Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154186|0 |1 is obsolete|| --- Comment #132 from Marcel de Rooy --- Created attachment 156655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156655=edit Bug 30708: DO NOT PUSH - ONLY FOR DB UPDATE DURING TESTING STAGE Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154185|0 |1 is obsolete|| --- Comment #131 from Marcel de Rooy --- Created attachment 156654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156654=edit Bug 30708: Allow attributes to be multivalued This is not working as it, but we are going to fix the problem when working on the "Set default values for items added in batch to a train" Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154184|0 |1 is obsolete|| --- Comment #130 from Marcel de Rooy --- Created attachment 156653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156653=edit Bug 30708: DBIC specific Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154183|0 |1 is obsolete|| --- Comment #129 from Marcel de Rooy --- Created attachment 156652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156652=edit Bug 30708: DBIC schema changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154182|0 |1 is obsolete|| --- Comment #128 from Marcel de Rooy --- Created attachment 156651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156651=edit Bug 30708: Do not allow adding new items to a closed train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154181|0 |1 is obsolete|| --- Comment #127 from Marcel de Rooy --- Created attachment 156650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156650=edit Bug 30708: Do not allow copy item to a train if the item already exists in a non-received train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154180|0 |1 is obsolete|| --- Comment #126 from Marcel de Rooy --- Created attachment 156649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156649=edit Bug 30708: Do not allow deletion of processings that are used Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154179|0 |1 is obsolete|| --- Comment #125 from Marcel de Rooy --- Created attachment 156648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156648=edit Bug 30708: Duplicate/copy items to an opened train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154178|0 |1 is obsolete|| --- Comment #124 from Marcel de Rooy --- Created attachment 156647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156647=edit Bug 30708: Show the copy button right after the train is received Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154177|0 |1 is obsolete|| --- Comment #123 from Marcel de Rooy --- Created attachment 156646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156646=edit Bug 30708: Keep item attributes when editing a new processing Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154176|0 |1 is obsolete|| --- Comment #122 from Marcel de Rooy --- Created attachment 156645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156645=edit Bug 30708: Do not allow edition of 'status for item added to train' It does not seem useful to enforce it at lower level, it is not a condition that will break the feature, but it does not feel correct to allow the modification of this value Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154175|0 |1 is obsolete|| --- Comment #121 from Marcel de Rooy --- Created attachment 156644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156644=edit Bug 30708: Add user_train_item_id Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154174|0 |1 is obsolete|| --- Comment #120 from Marcel de Rooy --- Created attachment 156643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156643=edit Bug 30708: Koha controller script and template changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154173|0 |1 is obsolete|| --- Comment #119 from Marcel de Rooy --- Created attachment 156642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156642=edit Bug 30708: Add apache RewriteRule Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154172|0 |1 is obsolete|| --- Comment #118 from Marcel de Rooy --- Created attachment 156641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156641=edit Bug 30708: DB changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154171|0 |1 is obsolete|| --- Comment #117 from Marcel de Rooy --- Created attachment 156640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156640=edit Bug 30708: Vue app This commit contains the main commit message The description of the original need is described in documents attached by the sponsor on the bug report specifically "[En] Preservation module - Main principles". The idea is to develop a whole new module to track the status of the documents that are sent for processings/treatments in order to preserve them (eg. covering). This is a first step, more are certainly coming later. The author and sponsors have worked for several months before providing this MVP version. The different discussion and needs can be found at https://tree.taiga.io/project/joubu-koha-preservation-module/kanban Some ideas of the next steps are also listed. The first iterations have been done using the classic .pl/.tt Koha style but we finally switched to a new Vue module, for more fun. These patches made the following main changes: New files * Koha objects under Koha/Preservation * REST API controllers under Koha/REST/V1/Preservation * preservation/home.pl and preservation/home.tt * Vue components under js/vue/components/Preservation * tests under t/db_dependent/Koha/Preservation and t/db_dependent/api/v1/preservation_* * Cypress tests under t/cypress/integration/Preservation DB: * 3 new sysprefs PreservationModule, PreservationNotForLoanWaitingListIn, PreservationNotForLoanDefaultTrainIn * 1 new permission "preservation" (will be split into subpermissions later) * 5 new tables: - preservation_processings - preservation_trains - preservation_processing_attributes - preservation_trains_items - preservation_processing_attributes_items Terminology and workflow: *Processings* are the different treatments an item can receive during its stay in the preservation module A *processing* is defined by a list of *attributes*. To make the module as easy to use for the librarians in charge of the preservation area a list of processings will be defined when the module will be set up. An *attribute* is a name and a value. That's it. However it also has a type, to define what the value is coming from: *free text*, *authorised value* or *database column*. For instance if you are defining a processing that will handling the book cover you could have 3 *attributes*: - first named "Barcode" that will be automatically filled with "items.barcode" (type *database column*" - second attribute named "color" linked with a new PRES_COLOR authorised value category you would have previously defined with "red", "blue", "green", etc. (type *authorised value*) - third attribute named "notes", because librarians like notes (type *free text*) Important: Even if the attribute is linked with a DB column or AV category, the value will be automatically pre filled but will stay editable (could be a config option to restrict the edition, later, if needed). The *status* of an item will change during the preservation process. First it will arrive in the preservation area and be on a *waiting list*. It is not processed already but is not available anymore for the patrons of the library. That's why we are going to use the "not for loan" (items.notforloan) value for this. This *waiting list* is a fictional concept, it simply lists all the items in the library with a specific *status*. A *train* is... how they call that at the BULAC, a train (same in French!). And we quite like the word so we kept it. It is what it is: a list of items/waggons, one after each other. We could have picked "cart", "list", but the concepts were already used in different places. We are not strongly attached to the term and it can be modified (but it's spread all over the code already and will be tedious to modify!) if you have a very good suggestion :) So, a *train* is where items are going after they have been sent to the waiting list. It's a stack of items that will be sent to a provider. When you create a new train you will be asked for the "Status for item added to this train", that will be the "not for loan" value to set to the items added to this train, and a "Default processing" that will be the processing used. But keep in mind that a train can have items that have different processings (specific case, will see later). When all items have been added to a *train*, you can *close* it. You cannot add items anymore to it! Then you can *send* it, and finally *receive* it. They are just statuses to keep track of the dates, and filter trains by status. However when a train is received you can *copy* an item to another (opened) train. It means that you have the item on
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154170|0 |1 is obsolete|| --- Comment #116 from Marcel de Rooy --- Created attachment 156639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156639=edit Bug 30708: REST API specs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154169|0 |1 is obsolete|| --- Comment #115 from Marcel de Rooy --- Created attachment 156638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156638=edit Bug 30708: Add tests Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154168|0 |1 is obsolete|| --- Comment #114 from Marcel de Rooy --- Created attachment 156637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156637=edit Bug 30708: Add Koha Objects Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Attachment #154167|0 |1 is obsolete|| --- Comment #113 from Marcel de Rooy --- Created attachment 156636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156636=edit Bug 30708: Add REST API controllers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #112 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #105) > Seeing things like this in qa tools: > > DBIx::Class::Relationship::ManyToMany::many_to_many(): > *** > The many-to-many relationship 'bundle_items' is trying to create a utility > method > called set_bundle_items. > This will completely overwrite one such already existing method on class > Koha::Schema::Result::Item. "bundle_items", that's not related to this development. It happens between the "before" and "after" the patch, we reload the different module (and so the schema file), that's why you see the warnings. (In reply to Marcel de Rooy from comment #106) > * Signed-off-by line 'Signed-off-by: BULAC - http://www.bulac.fr/' > seems invalid We could add the whole team, but I think is what they want here. (In reply to Marcel de Rooy from comment #107) > $c->validation errors too in qa tools Fixed. Also fixed another bug. (In reply to Marcel de Rooy from comment #109) > And a few (innocent) notes during the process: > > But keep in mind that a train can have items that have different processings > (specific case, will see later). Hum? > RewriteRule ^/cgi-bin/koha/preservation/.*$ > /cgi-bin/koha/preservation/home.pl [PT] Yes? > ASK Shouldnt we have a few default NFL statuses added now ? I don't think so. It really depends on how the library will use the module. We could however add sample data in misc4dev. > POST /api/v1/preservation/waiting-list/items: unhandled exception > (Koha::Exceptions::Preservation::MissingSettings)< settings is required: PreservationNotForLoanWaitingListIn>> > POST /intranet/svc/config/systempreferences > Did not work at the start without warns or alerts.. Related to CSRF bug. Now > solved, but error checking could be improved. I don't think so. Discussed already in PM: this was a programming error, and a programmer/reviewer must have the JS console opened (especially if something wrong happened). It's a whole global Koha question anyway, absolutely nothing directly related to this bug. > Home page > Kind of weird to land at an empty page constantly. Please see the kanban, still lot of things in mind. https://tree.taiga.io/project/joubu-koha-preservation-module/us/2 Note that we have the same for ERM. > user_train_item_id => $max + 1, > Looking further, I wonder what is the exact use of this column? Cant really > see when git grepping on it. For display/info purpose. We want the items inside a given train to be numbered. This is the "ID" column displayed on the item table of the "show train" view. > If a value is not in the AV list, or if it differs slightly, they would like > to force the modification of the value, without creating a new authorised > value. > -value: "Paraguay", > => Not very clear. (This is referring to bug 30708: Allow modifying attribute linked with AV to another value) Before this patch it was not possible de force the value of a dropdown list, you had to select a value from the AV list. With this patch it's possible to enter another value. AV list is only there as suggestions, but not to force a choice. Hence the rest of the commit message: """ Note that this could be a candidate for an option at the attribute level if there are different needs (ie. for some attributes we don't want to allow an other value). """ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #111 from Jonathan Druart --- Created attachment 156597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156597=edit Bug 30708: Remove c->validation in API controllers Fixed conflict with bug 33556 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #110 from Jonathan Druart --- Created attachment 156596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156596=edit Bug 30708: Fix conflict with 34055 and 34219 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #109 from Marcel de Rooy --- And a few (innocent) notes during the process: But keep in mind that a train can have items that have different processings (specific case, will see later). RewriteRule ^/cgi-bin/koha/preservation/.*$ /cgi-bin/koha/preservation/home.pl [PT] ASK Shouldnt we have a few default NFL statuses added now ? POST /api/v1/preservation/waiting-list/items: unhandled exception (Koha::Exceptions::Preservation::MissingSettings)<> POST /intranet/svc/config/systempreferences Did not work at the start without warns or alerts.. Related to CSRF bug. Now solved, but error checking could be improved. Home page Kind of weird to land at an empty page constantly. user_train_item_id => $max + 1, Looking further, I wonder what is the exact use of this column? Cant really see when git grepping on it. If a value is not in the AV list, or if it differs slightly, they would like to force the modification of the value, without creating a new authorised value. -value: "Paraguay", => Not very clear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #108 from Marcel de Rooy --- I do not object to signoff and pass qa but it is just a rough visual check. I understand that there was a lot of test feedback though. The module is more or less separated from core features, so it wont hurt even if we should call it experimental or so. I like to hear feedback for the DBIC stuff still. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #107 from Marcel de Rooy --- $c->validation errors too in qa tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #106 from Marcel de Rooy --- * Signed-off-by line 'Signed-off-by: BULAC - http://www.bulac.fr/' seems invalid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #105 from Marcel de Rooy --- Seeing things like this in qa tools: DBIx::Class::Relationship::ManyToMany::many_to_many(): *** The many-to-many relationship 'bundle_items' is trying to create a utility method called set_bundle_items. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #104 from Jonathan Druart --- Created attachment 156592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156592=edit Bug 30708: Pass csrf_token to the Vue app It's needed since bug 34369 to POST to the syspref route -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #103 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #47) > Amaury (from BULAC) presented this development during a French conference > (Symposium Kohala), here are the slides: > https://drive.google.com/file/d/12IclGOcVrwivCNIg0KW1mBmaiukgpdp7/ > view?usp=sharing > > It contains some screenshots. French text :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #102 from Marcel de Rooy --- Still applies, looking here (no promise of a full QA yet given size) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #101 from Jonathan Druart --- Created attachment 154203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154203=edit Bug 30708: Do not allow non-authorised users to edit the settings In case the logged in user does not have manage_sysprefs we should no display the form in the settings. Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
