[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-05-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||This makes it possible to
  release notes||add patron attribute fields
   ||as dates. The field will
   ||then display as any other
   ||date field including the
   ||calendar widget.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-05-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to main  |Needs documenting

--- Comment #67 from Fridolin Somers  ---
Not backported to 23.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-05-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||36922


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922
[Bug 36922] Correct hint on date patron attributes not being repeatable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-05-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||36882


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36882
[Bug 36882] Flatpickr doesn't work for date patron attributes in overdues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Pedro Amorim  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36816

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-05-01 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|additional_work_needed, |
   |rel_24_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-05-01 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #66 from Martin Renvoize  ---
Thanks for the TestBuilder fix Tomas.. I had considered doing that but for some
reason git distracted and missed it :(.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-05-01 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #65 from Katrin Fischer  ---
(In reply to Tomás Cohen Arazi from comment #61)
> (In reply to Tomás Cohen Arazi from comment #60)
> > Created attachment 165925 [details] [review] [review]
> > Bug 32610: (follow-up) Adjust TestBuilder
> > 
> > Signed-off-by: Tomas Cohen Arazi 
> 
> Pushed this trivial follow-up to clear the failing tests. Any place using
> testbuilder to generate attribute types would explode.

Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-05-01 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #64 from Katrin Fischer  ---
(In reply to Shi Yao Wang from comment #59)
> (In reply to Katrin Fischer from comment #57)
> > (In reply to Katrin Fischer from comment #56)
> > > I am not sure there is a use case for the repeated text - maybe we could 
> > > do
> > > a really quick poll on Mattermost. I'll ask.
> > 
> > Discussed with Caroline at least and I think clearing the data makes more
> > sense and is (hopefully) also easy to do?
> 
> Looks like I'm a bit late, I just saw the message.
> 
> Why is this already pushed?
> Isn't there still formatting/save problems? Didn't we want to clear the date
> attributes when repeating it?

Just to explain: I had the option not to push it, but it didn't make things
explode badly and I trusted you to provide the follow-up as we had already
talked about it :) So I set the "additional_work_needed" keyword and pushed it.
The keyword indicates lose ends that we still need to take care of. You can
also put those follow-ups on the original bug report as long we haven't
released I will pick them from here. After we released we will always need
separate bug reports so the fixes show in releases notes etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

David Nind  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36738

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #165926|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #63 from Shi Yao Wang  ---
Sorry, wrong bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #62 from Shi Yao Wang  ---
Created attachment 165926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165926=edit
Bug 36738: Date attributes follow-ups

Make the repeatable date patron attribute empty when repeating the
inputs to avoid date formatting problems (and keeping past date value
after repeating is not something we want)

Test plan:
1- create a patron attribute type with is a date and repeatable checked
(administration -> patron attribute types)
2- add a couple of patron attribute of type date, notice the repeated
inputs contain previous data
3- Apply the patch
4- redo step 2 and notice the repeated inputs are empty

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Blocks||36738


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36738
[Bug 36738] Date attributes follow-ups
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #61 from Tomás Cohen Arazi  ---
(In reply to Tomás Cohen Arazi from comment #60)
> Created attachment 165925 [details] [review]
> Bug 32610: (follow-up) Adjust TestBuilder
> 
> Signed-off-by: Tomas Cohen Arazi 

Pushed this trivial follow-up to clear the failing tests. Any place using
testbuilder to generate attribute types would explode.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #60 from Tomás Cohen Arazi  ---
Created attachment 165925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165925=edit
Bug 32610: (follow-up) Adjust TestBuilder

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #59 from Shi Yao Wang  ---
(In reply to Katrin Fischer from comment #57)
> (In reply to Katrin Fischer from comment #56)
> > I am not sure there is a use case for the repeated text - maybe we could do
> > a really quick poll on Mattermost. I'll ask.
> 
> Discussed with Caroline at least and I think clearing the data makes more
> sense and is (hopefully) also easy to do?

Looks like I'm a bit late, I just saw the message.

Why is this already pushed?
Isn't there still formatting/save problems? Didn't we want to clear the date
attributes when repeating it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #58 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #57 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #56)
> I am not sure there is a use case for the repeated text - maybe we could do
> a really quick poll on Mattermost. I'll ask.

Discussed with Caroline at least and I think clearing the data makes more sense
and is (hopefully) also easy to do?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #56 from Katrin Fischer  ---
I am not sure there is a use case for the repeated text - maybe we could do a
really quick poll on Mattermost. I'll ask.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #55 from Shi Yao Wang  ---
It would be really easy to add a new empty field everytime, but I noticed the
contents of other non-date attributes are copied when we repeat them so I tried
to do the same with date attribute.

Do we still want to add empty dates or do we want to fix the formatting and
saving?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #54 from Katrin Fischer  ---
This requires a small follow-up: 

* Create a new repeatable date field
* Enter a date in the patron account
* Repeat the field: the data is repeated, but input field has wrong format:
  04/03/2024 turns into: 2024-04-03
  The wrong dates don't appear to save.

I believe the field should be empty/cleared when repeated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #53 from Martin Renvoize  ---
Created attachment 165865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165865=edit
Bug 32610: (QA follow-up) Tidy Koha::Patron::Attribute

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #52 from Martin Renvoize  ---
Created attachment 165864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165864=edit
Bug 32610: (QA follow-up) Tidy exceptions file

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #51 from Martin Renvoize  ---
Created attachment 165863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165863=edit
Bug 32610: (QA follow-up) Fix unit tests

With the introduction of data type checking based on the is_date flag we
need to update the tests to ensure we're setting the attribute types
consistently to not date when we're testing for other flags.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165750|0   |1
is obsolete||

--- Comment #50 from Martin Renvoize  ---
Created attachment 165862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165862=edit
Bug 32610: make date attributes repeatable

Test plan:
1- create a patron attribute type with is a date and repeatable checked
(administration -> patron attribute types)
2- add a couple of patron attribute of type date
3- Save
4- Edit to see if everything has been stored correctly

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165747|0   |1
is obsolete||

--- Comment #49 from Martin Renvoize  ---
Created attachment 165861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165861=edit
Bug 32610: Patron attribute is_date error handling and tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #159000|0   |1
is obsolete||

--- Comment #48 from Martin Renvoize  ---
Created attachment 165860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165860=edit
Bug 32610: Remove data-date_to and tweak comment

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158998|0   |1
is obsolete||

--- Comment #46 from Martin Renvoize  ---
Created attachment 165858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165858=edit
Bug 32610: Add date extended patron attributes to the OPAC

This makes sure that the attributes are handled correctly
when displayed and edited in the OPAC during address changes
or self registration.

To test:
  * You will need to test different configuration options for
extended patron attributes (PA) in combination with the date option:
* PA displays in OPAC, but is not editable
  * The date will show nicely formatted on the personal details tab.
* PA displays and is editable in the OPAC
  * The date can be edited using the calendar widget
* PA displays, is editabe and mandatory
  * The date is marked as required and you can't save without
it being set.
  * Test the form behaves correctly when requesting changes for an
existing patron account and when self registering.

Signed-off-by: Philip Orr 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158999|0   |1
is obsolete||

--- Comment #47 from Martin Renvoize  ---
Created attachment 165859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165859=edit
Bug 32610: Add date extended patron attribute handling to overdues report

This makes sure that the overdues report manages filters for
extended patron attributes of the type date correctly.

To test:
* Make sure you have at least one PA marked as 'searchable'
* Make sure your patron has at east one checked out item
* Go to circulation > overdues
* If you have no overdue items, check "Show any items currently checked out:"
* Verify the list of checkouts displays
* Verify the PA filter option displays with the calendar widget
* Limit to the date in your patron's record - list remains
* Limit to any other date - list empties

Signed-off-by: Philip Orr 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158997|0   |1
is obsolete||

--- Comment #45 from Martin Renvoize  ---
Created attachment 165857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165857=edit
Bug 32610: Add date extended patron attributes to patron module

This makes the necessary changes in the patron module of
the staff interface, so the new patron attribute appers and
behaves correctly when editing a patron record.

To test:
* You will need to test different configuration options for
  extended patron attributes (PA) in combination with the date option:
  * PA is a date and not mandatory
* Patron form should have the calendar widget to let you set the date.
  * PA is a date and mandatory
* Patron form shoudl have calendar widget and check that the date is
  set for allowing you to save the record.
  * PA is a date and unique
* For this set the date in one patron record and try to
  set the same date in another. You should not be able to save.
  * PA displays in brief patron information
* Make sure the date displays on the left formatted correctly
  * When the date PAs are saved, they should display nicely formatted
on the details tab.

Signed-off-by: Philip Orr 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158996|0   |1
is obsolete||

--- Comment #44 from Martin Renvoize  ---
Created attachment 165856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165856=edit
Bug 32610: Add date option to extended patron attributes administration page

With this page it will be possible to configure patron attributes
to be a date.

To test:
* Go to administration > patron attribute types
* Add a new patron attribute of type date
  * Dates cannot be repeatable or linked to an AV category, so:
  * Verify, if you check repeatable, date is disabled
  * Verify, if you select an AV category, date disabled
  * Verify, if you check date, AV category and repeatable are disabled
* Save the new patron attribute
* Edit the patron attribute
  * Verify all settings have been kept/stored correctly

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158995|0   |1
is obsolete||

--- Comment #43 from Martin Renvoize  ---
Created attachment 165855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165855=edit
Bug 32610: [DO NOT PUSH] DBIC Update

Signed-off-by: Philip Orr 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158994|0   |1
is obsolete||

--- Comment #42 from Martin Renvoize  ---
Created attachment 165854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165854=edit
Bug 32610: Add borrower_attribute_types.is_date to the database

* Change to kohastructure.sql for new installations
* Atomic database update to add the column for updating
  installations

Signed-off-by: Philip Orr 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_24_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #41 from Martin Renvoize  ---
I'm upgrading this back to 'Signed off' and will encourage the repeatable
nature to be tested properly during QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

   Assignee|katrin.fisc...@bsz-bw.de|shi-yao.w...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #40 from Katrin Fischer  ---
Thank a lot for your help! Would you like to add yourself as assignee? I won't
have time to continue working on this but would love to see it happen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #39 from Shi Yao Wang  ---
(In reply to Pedro Amorim from comment #33)
> Failing QA here:
> 
> - Missing tests
> - import_borrowers.tt should check if a given patron_attribute that's being
> added is is_date and validate the data accordingly, else the following bug
> may occur:
> 
> 1) Create a patron attribute type of is_date as per the original test plan,
> named 'date'
> 2) Import a patron, visit:
> /cgi-bin/koha/tools/import_borrowers.pl
> 3) Click "Download a Starter CSV file with all the columns." and add a
> cardnumber, categorycode, branchcode and on the patron_attributes column put
> date:test
> 4) Import, notice the import is successful, now visit that patron edit page
> (do a search for the imported cardnumber), e.g. example for patron id 289:
> /cgi-bin/koha/members/moremember.pl?borrowernumber=289
> 5) Notice it blows up with error:
> Template process failed: undef error - The given date (teste) does not match
> the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 205.
>  at /kohadevbox/koha/C4/Templates.pm line 127

- Added some tests
- Added error handling for date type patron attribute. Borrower import should
now skip patrons with invalid value of date type patron attribute.



(In reply to Pedro Amorim from comment #34)
> Not a blocker, but why the design decision of restricting a date attribute
> type to not be able to also be repeatable?
> 
> I can't find many good examples of how a repeatable date field would be
> useful, but I don't understand why we wouldn't allow it either.

It should be repeatable now


Putting to Needs Signoff for someone to test repeatable date attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #38 from Shi Yao Wang  ---
Created attachment 165750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165750=edit
Bug 32610: make date attributes repeatable

Test plan:
1- create a patron attribute type with is a date and repeatable checked
(administration -> patron attribute types)
2- add a couple of patron attribute of type date
3- Save
4- Edit to see if everything has been stored correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #37 from Shi Yao Wang  ---
Created attachment 165747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165747=edit
Bug 32610: Patron attribute is_date error handling and tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2024-04-01 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

  Change sponsored?|--- |Unsponsored

--- Comment #36 from Katrin Fischer  ---
I cannot continue here on my own - happy if someone wants to take over or
collaborate in some way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-12-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #35 from Katrin Fischer  ---
(In reply to Pedro Amorim from comment #34)
> Not a blocker, but why the design decision of restricting a date attribute
> type to not be able to also be repeatable?
> 
> I can't find many good examples of how a repeatable date field would be
> useful, but I don't understand why we wouldn't allow it either.

Mostly because I wanted to keep it a bit more simple and thought that could
still be done later if required. 

I had picked this up to work on in my free time, because it seemed something
that people were interested in, but it grew quickly and got more complicated
than I had first imagined. 

I think I'd definitely need some help to solve the import issue (good testing
btw!) and probably the tests as well.

I am also a bit worried about the batch patron edit - at the time of me writing
this patch set I had some trouble testing it because of a blocking bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-12-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #34 from Pedro Amorim  ---
Not a blocker, but why the design decision of restricting a date attribute type
to not be able to also be repeatable?

I can't find many good examples of how a repeatable date field would be useful,
but I don't understand why we wouldn't allow it either.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-12-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Pedro Amorim  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #33 from Pedro Amorim  ---
Failing QA here:

- Missing tests
- import_borrowers.tt should check if a given patron_attribute that's being
added is is_date and validate the data accordingly, else the following bug may
occur:

1) Create a patron attribute type of is_date as per the original test plan,
named 'date'
2) Import a patron, visit:
/cgi-bin/koha/tools/import_borrowers.pl
3) Click "Download a Starter CSV file with all the columns." and add a
cardnumber, categorycode, branchcode and on the patron_attributes column put
date:test
4) Import, notice the import is successful, now visit that patron edit page (do
a search for the imported cardnumber), e.g. example for patron id 289:
/cgi-bin/koha/members/moremember.pl?borrowernumber=289
5) Notice it blows up with error:
Template process failed: undef error - The given date (teste) does not match
the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 205.
 at /kohadevbox/koha/C4/Templates.pm line 127

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com,
   ||pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #32 from Shi Yao Wang  ---
rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #157868|0   |1
is obsolete||

--- Comment #31 from Shi Yao Wang  ---
Created attachment 159000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159000=edit
Bug 32610: Remove data-date_to and tweak comment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #157867|0   |1
is obsolete||

--- Comment #30 from Shi Yao Wang  ---
Created attachment 158999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158999=edit
Bug 32610: Add date extended patron attribute handling to overdues report

This makes sure that the overdues report manages filters for
extended patron attributes of the type date correctly.

To test:
* Make sure you have at least one PA marked as 'searchable'
* Make sure your patron has at east one checked out item
* Go to circulation > overdues
* If you have no overdue items, check "Show any items currently checked out:"
* Verify the list of checkouts displays
* Verify the PA filter option displays with the calendar widget
* Limit to the date in your patron's record - list remains
* Limit to any other date - list empties

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #157866|0   |1
is obsolete||

--- Comment #29 from Shi Yao Wang  ---
Created attachment 158998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158998=edit
Bug 32610: Add date extended patron attributes to the OPAC

This makes sure that the attributes are handled correctly
when displayed and edited in the OPAC during address changes
or self registration.

To test:
  * You will need to test different configuration options for
extended patron attributes (PA) in combination with the date option:
* PA displays in OPAC, but is not editable
  * The date will show nicely formatted on the personal details tab.
* PA displays and is editable in the OPAC
  * The date can be edited using the calendar widget
* PA displays, is editabe and mandatory
  * The date is marked as required and you can't save without
it being set.
  * Test the form behaves correctly when requesting changes for an
existing patron account and when self registering.

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #157865|0   |1
is obsolete||

--- Comment #28 from Shi Yao Wang  ---
Created attachment 158997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158997=edit
Bug 32610: Add date extended patron attributes to patron module

This makes the necessary changes in the patron module of
the staff interface, so the new patron attribute appers and
behaves correctly when editing a patron record.

To test:
* You will need to test different configuration options for
  extended patron attributes (PA) in combination with the date option:
  * PA is a date and not mandatory
* Patron form should have the calendar widget to let you set the date.
  * PA is a date and mandatory
* Patron form shoudl have calendar widget and check that the date is
  set for allowing you to save the record.
  * PA is a date and unique
* For this set the date in one patron record and try to
  set the same date in another. You should not be able to save.
  * PA displays in brief patron information
* Make sure the date displays on the left formatted correctly
  * When the date PAs are saved, they should display nicely formatted
on the details tab.

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #157864|0   |1
is obsolete||

--- Comment #27 from Shi Yao Wang  ---
Created attachment 158996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158996=edit
Bug 32610: Add date option to extended patron attributes administration page

With this page it will be possible to configure patron attributes
to be a date.

To test:
* Go to administration > patron attribute types
* Add a new patron attribute of type date
  * Dates cannot be repeatable or linked to an AV category, so:
  * Verify, if you check repeatable, date is disabled
  * Verify, if you select an AV category, date disabled
  * Verify, if you check date, AV category and repeatable are disabled
* Save the new patron attribute
* Edit the patron attribute
  * Verify all settings have been kept/stored correctly

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #157863|0   |1
is obsolete||

--- Comment #26 from Shi Yao Wang  ---
Created attachment 158995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158995=edit
Bug 32610: [DO NOT PUSH] DBIC Update

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #157862|0   |1
is obsolete||

--- Comment #25 from Shi Yao Wang  ---
Created attachment 158994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158994=edit
Bug 32610: Add borrower_attribute_types.is_date to the database

* Change to kohastructure.sql for new installations
* Atomic database update to add the column for updating
  installations

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #24 from Katrin Fischer  ---
Thanks a lot Shi Yao!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #23 from Shi Yao Wang  ---
Created attachment 157868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157868=edit
Bug 32610: Remove data-date_to and tweak comment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off
 CC||shi-yao.w...@inlibro.com

--- Comment #22 from Shi Yao Wang  ---
rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148830|0   |1
is obsolete||

--- Comment #21 from Shi Yao Wang  ---
Created attachment 157867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157867=edit
Bug 32610: Add date extended patron attribute handling to overdues report

This makes sure that the overdues report manages filters for
extended patron attributes of the type date correctly.

To test:
* Make sure you have at least one PA marked as 'searchable'
* Make sure your patron has at east one checked out item
* Go to circulation > overdues
* If you have no overdue items, check "Show any items currently checked out:"
* Verify the list of checkouts displays
* Verify the PA filter option displays with the calendar widget
* Limit to the date in your patron's record - list remains
* Limit to any other date - list empties

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148829|0   |1
is obsolete||

--- Comment #20 from Shi Yao Wang  ---
Created attachment 157866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157866=edit
Bug 32610: Add date extended patron attributes to the OPAC

This makes sure that the attributes are handled correctly
when displayed and edited in the OPAC during address changes
or self registration.

To test:
  * You will need to test different configuration options for
extended patron attributes (PA) in combination with the date option:
* PA displays in OPAC, but is not editable
  * The date will show nicely formatted on the personal details tab.
* PA displays and is editable in the OPAC
  * The date can be edited using the calendar widget
* PA displays, is editabe and mandatory
  * The date is marked as required and you can't save without
it being set.
  * Test the form behaves correctly when requesting changes for an
existing patron account and when self registering.

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148828|0   |1
is obsolete||

--- Comment #19 from Shi Yao Wang  ---
Created attachment 157865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157865=edit
Bug 32610: Add date extended patron attributes to patron module

This makes the necessary changes in the patron module of
the staff interface, so the new patron attribute appers and
behaves correctly when editing a patron record.

To test:
* You will need to test different configuration options for
  extended patron attributes (PA) in combination with the date option:
  * PA is a date and not mandatory
* Patron form should have the calendar widget to let you set the date.
  * PA is a date and mandatory
* Patron form shoudl have calendar widget and check that the date is
  set for allowing you to save the record.
  * PA is a date and unique
* For this set the date in one patron record and try to
  set the same date in another. You should not be able to save.
  * PA displays in brief patron information
* Make sure the date displays on the left formatted correctly
  * When the date PAs are saved, they should display nicely formatted
on the details tab.

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148827|0   |1
is obsolete||

--- Comment #18 from Shi Yao Wang  ---
Created attachment 157864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157864=edit
Bug 32610: Add date option to extended patron attributes administration page

With this page it will be possible to configure patron attributes
to be a date.

To test:
* Go to administration > patron attribute types
* Add a new patron attribute of type date
  * Dates cannot be repeatable or linked to an AV category, so:
  * Verify, if you check repeatable, date is disabled
  * Verify, if you select an AV category, date disabled
  * Verify, if you check date, AV category and repeatable are disabled
* Save the new patron attribute
* Edit the patron attribute
  * Verify all settings have been kept/stored correctly

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148826|0   |1
is obsolete||

--- Comment #17 from Shi Yao Wang  ---
Created attachment 157863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157863=edit
Bug 32610: [DO NOT PUSH] DBIC Update

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148825|0   |1
is obsolete||

--- Comment #16 from Shi Yao Wang  ---
Created attachment 157862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157862=edit
Bug 32610: Add borrower_attribute_types.is_date to the database

* Change to kohastructure.sql for new installations
* Atomic database update to add the column for updating
  installations

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20958

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #15 from Jonathan Druart  ---
I guess you should adjust the comment here

circ/overdue.pl:my @patron_attr_filter_loop;   # array of [ domid cgivalue
ismany isclone ordinal code description repeatable is_date
authorised_value_category ]

koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt:

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #14 from Jonathan Druart  ---
Why are you adding data-date_to="to" in memberentrygen?

Not blocker but it would have been more flexible (for future enhancements) to
have a datatype='date' column instead of is_date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148405|0   |1
is obsolete||

--- Comment #13 from Philip Orr  ---
Created attachment 148830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148830=edit
Bug 32610: Add date extended patron attribute handling to overdues report

This makes sure that the overdues report manages filters for
extended patron attributes of the type date correctly.

To test:
* Make sure you have at least one PA marked as 'searchable'
* Make sure your patron has at east one checked out item
* Go to circulation > overdues
* If you have no overdue items, check "Show any items currently checked out:"
* Verify the list of checkouts displays
* Verify the PA filter option displays with the calendar widget
* Limit to the date in your patron's record - list remains
* Limit to any other date - list empties

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148404|0   |1
is obsolete||

--- Comment #12 from Philip Orr  ---
Created attachment 148829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148829=edit
Bug 32610: Add date extended patron attributes to the OPAC

This makes sure that the attributes are handled correctly
when displayed and edited in the OPAC during address changes
or self registration.

To test:
  * You will need to test different configuration options for
extended patron attributes (PA) in combination with the date option:
* PA displays in OPAC, but is not editable
  * The date will show nicely formatted on the personal details tab.
* PA displays and is editable in the OPAC
  * The date can be edited using the calendar widget
* PA displays, is editabe and mandatory
  * The date is marked as required and you can't save without
it being set.
  * Test the form behaves correctly when requesting changes for an
existing patron account and when self registering.

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148403|0   |1
is obsolete||

--- Comment #11 from Philip Orr  ---
Created attachment 148828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148828=edit
Bug 32610: Add date extended patron attributes to patron module

This makes the necessary changes in the patron module of
the staff interface, so the new patron attribute appers and
behaves correctly when editing a patron record.

To test:
* You will need to test different configuration options for
  extended patron attributes (PA) in combination with the date option:
  * PA is a date and not mandatory
* Patron form should have the calendar widget to let you set the date.
  * PA is a date and mandatory
* Patron form shoudl have calendar widget and check that the date is
  set for allowing you to save the record.
  * PA is a date and unique
* For this set the date in one patron record and try to
  set the same date in another. You should not be able to save.
  * PA displays in brief patron information
* Make sure the date displays on the left formatted correctly
  * When the date PAs are saved, they should display nicely formatted
on the details tab.

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148402|0   |1
is obsolete||

--- Comment #10 from Philip Orr  ---
Created attachment 148827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148827=edit
Bug 32610: Add date option to extended patron attributes administration page

With this page it will be possible to configure patron attributes
to be a date.

To test:
* Go to administration > patron attribute types
* Add a new patron attribute of type date
  * Dates cannot be repeatable or linked to an AV category, so:
  * Verify, if you check repeatable, date is disabled
  * Verify, if you select an AV category, date disabled
  * Verify, if you check date, AV category and repeatable are disabled
* Save the new patron attribute
* Edit the patron attribute
  * Verify all settings have been kept/stored correctly

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148401|0   |1
is obsolete||

--- Comment #9 from Philip Orr  ---
Created attachment 148826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148826=edit
Bug 32610: [DO NOT PUSH] DBIC Update

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148400|0   |1
is obsolete||

--- Comment #8 from Philip Orr  ---
Created attachment 148825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148825=edit
Bug 32610: Add borrower_attribute_types.is_date to the database

* Change to kohastructure.sql for new installations
* Atomic database update to add the column for updating
  installations

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add ability to specify  |Add ability to specify
   |patron attribute as a date  |patron attribute as a date
   |and apply flatpickr |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #7 from Katrin Fischer  ---
Created attachment 148405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148405=edit
Bug 32610: Add date extended patron attribute handling to overdues report

This makes sure that the overdues report manages filters for
extended patron attributes of the type date correctly.

To test:
* Make sure you have at least one PA marked as 'searchable'
* Make sure your patron has at east one checked out item
* Go to circulation > overdues
* If you have no overdue items, check "Show any items currently checked out:"
* Verify the list of checkouts displays
* Verify the PA filter option displays with the calendar widget
* Limit to the date in your patron's record - list remains
* Limit to any other date - list empties

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #6 from Katrin Fischer  ---
Created attachment 148404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148404=edit
Bug 32610: Add date extended patron attributes to the OPAC

This makes sure that the attributes are handled correctly
when displayed and edited in the OPAC during address changes
or self registration.

To test:
  * You will need to test different configuration options for
extended patron attributes (PA) in combination with the date option:
* PA displays in OPAC, but is not editable
  * The date will show nicely formatted on the personal details tab.
* PA displays and is editable in the OPAC
  * The date can be edited using the calendar widget
* PA displays, is editabe and mandatory
  * The date is marked as required and you can't save without
it being set.
  * Test the form behaves correctly when requesting changes for an
existing patron account and when self registering.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #5 from Katrin Fischer  ---
Created attachment 148403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148403=edit
Bug 32610: Add date extended patron attributes to patron module

This makes the necessary changes in the patron module of
the staff interface, so the new patron attribute appers and
behaves correctly when editing a patron record.

To test:
* You will need to test different configuration options for
  extended patron attributes (PA) in combination with the date option:
  * PA is a date and not mandatory
* Patron form should have the calendar widget to let you set the date.
  * PA is a date and mandatory
* Patron form shoudl have calendar widget and check that the date is
  set for allowing you to save the record.
  * PA is a date and unique
* For this set the date in one patron record and try to
  set the same date in another. You should not be able to save.
  * PA displays in brief patron information
* Make sure the date displays on the left formatted correctly
  * When the date PAs are saved, they should display nicely formatted
on the details tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #4 from Katrin Fischer  ---
Created attachment 148402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148402=edit
Bug 32610: Add date option to extended patron attributes administration page

With this page it will be possible to configure patron attributes
to be a date.

To test:
* Go to administration > patron attribute types
* Add a new patron attribute of type date
  * Dates cannot be repeatable or linked to an AV category, so:
  * Verify, if you check repeatable, date is disabled
  * Verify, if you select an AV category, date disabled
  * Verify, if you check date, AV category and repeatable are disabled
* Save the new patron attribute
* Edit the patron attribute
  * Verify all settings have been kept/stored correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #3 from Katrin Fischer  ---
Created attachment 148401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148401=edit
Bug 32610: [DO NOT PUSH] DBIC Update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #2 from Katrin Fischer  ---
Created attachment 148400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148400=edit
Bug 32610: Add borrower_attribute_types.is_date to the database

* Change to kohastructure.sql for new installations
* Atomic database update to add the column for updating
  installations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in

--- Comment #1 from Katrin Fischer  ---
*** Bug 6339 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-03-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-03-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-03-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Katrin Fischer  changed:

   What|Removed |Added

Version|22.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date and apply flatpickr

2023-01-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/