[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele changed: What|Removed |Added Attachment #166736|0 |1 is obsolete|| --- Comment #23 from Hammat wele --- Created attachment 166742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166742=edit Bug 34978: (follow-up) Add exception when plugin to install is not found and fix unit test Signed-off-by: Hammat Wele -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele changed: What|Removed |Added Attachment #166576|0 |1 is obsolete|| --- Comment #22 from Hammat wele --- Created attachment 166741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166741=edit Bug 34978: (QA follow-up) Simplify code and make it stricter This patch simplifies the code a bit, removing duplicated pieces of code and making it slightly more readable. The main change is that it now just filters the `@plugin_classes` list as required, and leaves the original codebase for dealing with loading the plugins untouched. A BIG change it implements is that it now requires full class names. I don't see the use case for partial names, and I generally think we should be stricter in this area. If there's the need for partial class names, this should be handled with specific parameters, etc. It also makes it explicit that the `include` and `exclude` parameters are mutually exclusive. A minor idiomatic issue is fixed as well. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Hammat Wele -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele changed: What|Removed |Added Attachment #166562|0 |1 is obsolete|| --- Comment #21 from Hammat wele --- Created attachment 166740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166740=edit Bug 34978: Add new parameters to POD Signed-off-by: Tomas Cohen Arazi Signed-off-by: Hammat Wele -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele changed: What|Removed |Added Attachment #166561|0 |1 is obsolete|| --- Comment #20 from Hammat wele --- Created attachment 166739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166739=edit Bug 34978: (QA follow-up) Fix rebase issues - Rebased tests patch (62->51) - tidy - spelling ( paramater -> parameter ) Signed-off-by: Pedro Amorim Signed-off-by: Tomas Cohen Arazi Signed-off-by: Hammat Wele -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele changed: What|Removed |Added Attachment #166560|0 |1 is obsolete|| --- Comment #19 from Hammat wele --- Created attachment 166738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166738=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include --include " TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include --include " (Replace and with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude --exclude " 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful Signed-off-by: Pedro Amorim Signed-off-by: Tomas Cohen Arazi Signed-off-by: Hammat Wele -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #18 from Hammat wele --- Created attachment 166736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166736=edit Bug 34978: (follow-up) Add exception when plugin to install is not found and fix unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #17 from Tomás Cohen Arazi --- Hi, I attached a patch making this look what I believe it should. I'm failing it until we have the tests fixed by the authors. Notes: * The patchset introduces 'warn' calls on a package, which are not covered by tests. This should not be the case * We might need to revisit if `warn` plus `return` is the right thing to do here. I'm tempted to suggest it should just be an exception properly handled on the `install_plugins.pl` script. * My follow-up adds an exception for explicitly forbidding both `include` and `exclude` being used simultaneously. This... needs a test as well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 166576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166576=edit Bug 34978: (QA follow-up) Simplify code and make it stricter This patch simplifies the code a bit, removing duplicated pieces of code and making it slightly more readable. The main change is that it now just filters the `@plugin_classes` list as required, and leaves the original codebase for dealing with loading the plugins untouched. A BIG change it implements is that it now requires full class names. I don't see the use case for partial names, and I generally think we should be stricter in this area. If there's the need for partial class names, this should be handled with specific parameters, etc. It also makes it explicit that the `include` and `exclude` parameters are mutually exclusive. A minor idiomatic issue is fixed as well. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 166562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166562=edit Bug 34978: Add new parameters to POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 166561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166561=edit Bug 34978: (QA follow-up) Fix rebase issues - Rebased tests patch (62->51) - tidy - spelling ( paramater -> parameter ) Signed-off-by: Pedro Amorim Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #163800|0 |1 is obsolete|| Attachment #163801|0 |1 is obsolete|| --- Comment #13 from Tomás Cohen Arazi --- Created attachment 166560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166560=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include --include " TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include --include " (Replace and with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude --exclude " 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful Signed-off-by: Pedro Amorim Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #12 from Tomás Cohen Arazi --- I agree with Julian we should have a way to install things from the UI. Would be happy to help on a follow-up bug! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele changed: What|Removed |Added Attachment #160240|0 |1 is obsolete|| --- Comment #11 from Hammat wele --- Created attachment 163801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163801=edit Bug 34978: (QA follow-up): - Rebased tests patch (62->51) - tidy - spelling ( paramater -> parameter ) Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele changed: What|Removed |Added Attachment #160239|0 |1 is obsolete|| --- Comment #10 from Hammat wele --- Created attachment 163800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163800=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include --include " TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include --include " (Replace and with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude --exclude " 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #9 from Julian Maurice --- > What was the use case for install_plugins.pl ? Shouldn't people just use the > UI ? It would be nice to be able to install plugins from the UI (and by "install" I do not mean "upload and install", only "install") but I believe plugins don't even appear in the UI until misc/devel/install_plugins.pl is run. > We manage a hundred personnalized koha installations and we don't want to > manually install all the plugins. One option you have is to keep in $KOHA_CONF only the plugins that should be enabled for that Koha installation. You can still have all plugins in the same git repository. That way you also cannot install the wrong plugins by accident (by forgetting --exclude or --include) I'm not against --include and --exclude options, as they could be useful for testing/debugging purposes, but I'm not sure if it's the best solution for your use case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #8 from Blou --- We manage a hundred personnalized koha installations and we don't want to manually install all the plugins. Plus we have multiple in-house plugins, but not all of them go to all clients. It's much simpler for certain plugins to be in the koha git rather than floating in their standalone plugin in github, most of them because anyway they depend on a personnalised codebase. Some depend on the level of support the user has, etc... What was the use case for install_plugins.pl ? Shouldn't people just use the UI ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #7 from Julian Maurice --- What is the use case for this ? Why would you add plugins in the plugins path if you do not want to install them ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #6 from Pedro Amorim --- Created attachment 160240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160240=edit Bug 34978: (QA follow-up): - Rebased tests patch (62->51) - tidy - spelling ( paramater -> parameter ) Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Pedro Amorim changed: What|Removed |Added Attachment #160210|0 |1 is obsolete|| --- Comment #5 from Pedro Amorim --- Created attachment 160239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160239=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include --include " TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include --include " (Replace and with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude --exclude " 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Salah Ghedda changed: What|Removed |Added Attachment #156557|0 |1 is obsolete|| --- Comment #4 from Salah Ghedda --- Created attachment 160210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160210=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include --include " TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include --include " (Replace and with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude --exclude " 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur changed: What|Removed |Added Attachment #156555|0 |1 is obsolete|| --- Comment #3 from Émily-Rose Francoeur --- Created attachment 156557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156557=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include --include " TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include --include " (Replace and with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude --exclude " 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur changed: What|Removed |Added Attachment #156539|0 |1 is obsolete|| --- Comment #2 from Émily-Rose Francoeur --- Created attachment 156555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156555=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include --include " TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include --include " (Replace and with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude --exclude " 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #1 from Émily-Rose Francoeur --- Created attachment 156539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156539=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It’s possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include Test1 --include Koha::Plugin::Test2 TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command : "./misc/devel/install_plugins.pl --include --include " (Replace and with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project : "./misc/devel/install_plugins.pl --exclude --exclude ” 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||emily-rose.francoeur@inLibr ||o.com, ||philippe.blo...@inlibro.com Assignee|koha-b...@lists.koha-commun |emily-rose.francoeur@inLibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
