[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #34 from Lucas Gass --- Missing 23.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Bug 35392 depends on bug 34587, which changed state. Bug 34587 Summary: Add a Usage Statistics module to ERM https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|24.05.00|24.05.00,23.11.06 released in|| Status|Pushed to main |Pushed to stable --- Comment #33 from Fridolin Somers --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #32 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #31 from Jonathan Druart --- Created attachment 164475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164475=edit Bug 35392: Use the same selector as everywhere else for .message Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #30 from Jonathan Druart --- Created attachment 164474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164474=edit Bug 35392: Update tests Run: yarn cypress run --spec "t/cypress/integration/ERM/DataProviders_spec.ts" Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Jonathan Druart changed: What|Removed |Added Attachment #164466|0 |1 is obsolete|| Attachment #164467|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart --- Created attachment 164473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164473=edit Bug 35392: Fix HTML in translatable string Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #28 from David Nind --- Testing notes (using KTD): 1. Apply patch 2. yarn build 3. Run tests: yarn cypress run --spec "t/cypress/integration/ERM/DataProviders_spec.ts" 4. Tests pass! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 David Nind changed: What|Removed |Added Attachment #160513|0 |1 is obsolete|| --- Comment #27 from David Nind --- Created attachment 164467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164467=edit Bug 35392: Update tests Run: yarn cypress run --spec "t/cypress/integration/ERM/DataProviders_spec.ts" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 David Nind changed: What|Removed |Added Attachment #160512|0 |1 is obsolete|| --- Comment #26 from David Nind --- Created attachment 164466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164466=edit Bug 35392: Fix HTML in translatable string Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Severity|enhancement |trivial Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Caroline Cyr La Rose changed: What|Removed |Added CC||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added QA Contact||jonathan.druart+koha@gmail. ||com Assignee|matt.blenkinsop@ptfs-europe |pedro.amo...@ptfs-europe.co |.com|m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added CC||vic...@tuxayo.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #25 from Pedro Amorim --- Created attachment 160513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160513=edit Bug 35392: Update tests Run: yarn cypress run --spec "t/cypress/integration/ERM/DataProviders_spec.ts" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #24 from Pedro Amorim --- Created attachment 160512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160512=edit Bug 35392: Fix HTML in translatable string -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Attachment #160451|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Attachment #160450|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Attachment #159283|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Attachment #159281|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Attachment #159280|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Attachment #159279|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #23 from Jonathan Druart --- Can we get a simple version of this fix for backport, please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #22 from Pedro Amorim --- Created attachment 160451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160451=edit label demo (In reply to Katrin Fischer from comment #20) > This will make it 2 separate strings in the po file. This is often quite > hard to translate, maybe nicer with Weblate that keeps more of the sequence, > but they could end up in 2 different spots of a big file. That's why I was > suggesting to rephrase AND get rid of the click here the same time by making > the link something like "Check progress". Fair point, I've submitted a follow patch please take a look when convenient. Submitting a picture here of how it looks in the UI for both situations (new harvest job and file upload job). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #21 from Pedro Amorim --- Created attachment 160450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160450=edit Bug 35392: (QA follow-up): Fix 'click here' and 'to check its progress' being 2 seperate translatable strings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392
--- Comment #20 from Katrin Fischer ---
I would need to test this, but I think it's not unproblematic for translations:
+'" target="_blank">' +
+__("click here") +
+" " +
+__("to check its progress.") +
+""
This will make it 2 separate strings in the po file. This is often quite hard
to translate, maybe nicer with Weblate that keeps more of the sequence, but
they could end up in 2 different spots of a big file. That's why I was
suggesting to rephrase AND get rid of the click here the same time by making
the link something like "Check progress".
This bug is about improving translatability for a specific string, so I think
not totally out of scope.
> +{ short: "Mar", description: "March", value: 3, active: true },
> +{ short: "Apr", description: "April", value: 4, active: true },
For the second: I have no idea where it appears in the ERM module, so hard to
provide a test plan right now. The code just looked very suspicious. But
totally agree it should be on a separate bug.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392
--- Comment #19 from Pedro Amorim ---
(In reply to Katrin Fischer from comment #18)
> The translation is one issue, but there is another:
> For usability and accessibility we should always put the link on meaningful
> words, so no links like 'here' or 'click here'. People know that they can
> click links and screen readers will be happier reading something that
> reveals the purpose of a link.
>
> Maybe this would work?
>
> 'Job for uploaded file has been queued. href="/cgi-bin/koha/admin/background_jobs.pl?op=view=%s"
> target="_blank">Check progress'
>
> The span I think would break this into 2 strings for translation.
>
> Do we have another translation issue here?
>
> +{ short: "Jan", description: "January", value: 1, active: true
> },
> +{ short: "Feb", description: "February", value: 2, active: true
> },
> +{ short: "Mar", description: "March", value: 3, active: true },
> +{ short: "Apr", description: "April", value: 4, active: true },
Katrin, these are very good points, however can we please open one (or two?)
new bugs for these issues you mention?
The original problem here has to do with HTML being present in a translatable
string, whereas I believe what you're referring to are possibly different
problems:
1) Usability: "Click here" link in ERM usage statistics background job dialog
should be handled differently
2) Possible problem with month names translatability in ERM usage statistics
reports (please provide a test plan)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392
--- Comment #18 from Katrin Fischer ---
The translation is one issue, but there is another:
For usability and accessibility we should always put the link on meaningful
words, so no links like 'here' or 'click here'. People know that they can click
links and screen readers will be happier reading something that reveals the
purpose of a link.
Maybe this would work?
'Job for uploaded file has been queued.Check progress'
The span I think would break this into 2 strings for translation.
Do we have another translation issue here?
+{ short: "Jan", description: "January", value: 1, active: true },
+{ short: "Feb", description: "February", value: 2, active: true },
+{ short: "Mar", description: "March", value: 3, active: true },
+{ short: "Apr", description: "April", value: 4, active: true },
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #17 from Pedro Amorim --- @Joubu, are we able to move on here? I don't want my patches to be the cause of holding off this bug. Please advise. If you decide to obsolete my patches please note that they're also fixing Tomas' original patch: 1) Has a typo "$this." 2) Only addresses UsageStatisticsDataProvidersList.vue. Does not address UsageStatisticsDataProvidersFileImport.vue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #16 from Pedro Amorim --- (In reply to Jonathan Druart from comment #9) > But really, it's too late for such changes. We should only fix the > translation issue here. Hey, thanks for looking! Rebased. I wanted to make it easier to maintain going forward, whilst addressing Caroline's comment about the file upload, but I understand, please make obsolete if you don't agree! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Attachment #159265|0 |1 is obsolete|| --- Comment #15 from Pedro Amorim --- Created attachment 159283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159283=edit Bug 35392: Add missing file upload dialog cypress test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Attachment #159264|0 |1 is obsolete|| --- Comment #14 from Pedro Amorim --- Created attachment 159281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159281=edit Bug 35392: New getDialoJobEnqueueMessage DRY the dialog message shown when a background job is enqueued in ERM This takes Tomas work in UsageStatisticsDataProvidersList.vue, DRYs it and also applies it to UsageStatisticsDataProvidersFileImport.vue to address the issue mentioned by Caroline. To test: 1) Do a regular harvest, 2) Do a file upload 3) Notice in both cases the message is shown as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Attachment #159263|0 |1 is obsolete|| --- Comment #13 from Pedro Amorim --- Created attachment 159280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159280=edit Bug 35392: Move usage-reports store into erm store This is all ERM, no need to have it be separate store files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Pedro Amorim changed: What|Removed |Added Attachment #159256|0 |1 is obsolete|| --- Comment #12 from Pedro Amorim --- Created attachment 159279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159279=edit Bug 35392: Avoid HTML in translatable content -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > Well, maybe not, they seem related. > > I am getting a conflict on the second patch however > > Applying: Bug 35392: Move usage-reports store into erm store > error: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/js/vue/stores/usage-reports.js). It's actually on the third patch Applying: Bug 35392: New getDialoJobEnqueueMessage Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersList.vue Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersList.vue CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersList.vue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392
--- Comment #10 from Jonathan Druart ---
Not tested, but maybe this is better:
"Job for report type %s has been queued, %sclick here%s to check its
progress".format('%s'.format(job.report_type), ''.format(job.job_id), '')
What do you think?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #9 from Jonathan Druart --- But really, it's too late for such changes. We should only fix the translation issue here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Jonathan Druart --- Well, maybe not, they seem related. I am getting a conflict on the second patch however Applying: Bug 35392: Move usage-reports store into erm store error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/vue/stores/usage-reports.js). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #7 from Jonathan Druart --- Pedro, I think those patches should be on another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #6 from Pedro Amorim --- Created attachment 159265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159265=edit Bug 35392: Add missing file upload dialog cypress test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #5 from Pedro Amorim --- Created attachment 159264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159264=edit Bug 35392: New getDialoJobEnqueueMessage DRY the dialog message shown when a background job is enqueued in ERM This takes Tomas work in UsageStatisticsDataProvidersList.vue, DRYs it and also applies it to UsageStatisticsDataProvidersFileImport.vue to address the issue mentioned by Caroline. To test: 1) Do a regular harvest, 2) Do a file upload 3) Notice in both cases the message is shown as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #4 from Pedro Amorim --- Created attachment 159263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159263=edit Bug 35392: Move usage-reports store into erm store This is all ERM, no need to have it be separate store files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 159256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159256=edit Bug 35392: Avoid HTML in translatable content -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |matt.blenkinsop@ptfs-europe |com |.com Depends on||34587 --- Comment #2 from Jonathan Druart --- (In reply to Caroline Cyr La Rose from comment #1) > I found the same type of string again > > Job for report type %s has been queued, href="/cgi-bin/koha/admin/background_jobs.pl?op=view=%s" > target="_blank">click here to check its progress. > > at > > koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/ > UsageStatisticsDataProvidersList.vue:249 Yes, given the code that's expected: 248 message += this.$__( 249 'Job for report type %s has been queued, click here to check its progress.' 250 ).format(job.report_type, job.job_id) Could be improved however. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 [Bug 34587] Add a Usage Statistics module to ERM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #1 from Caroline Cyr La Rose --- I found the same type of string again Job for report type %s has been queued, click here to check its progress. at koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersList.vue:249 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
