[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Lari Taskula  changed:

   What|Removed |Added

 Blocks||18444


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444
[Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10572

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #21 from M. de Rooy m.de.r...@rijksmuseum.nl ---
[Mon Jun 18 09:43:38 2012] updatedatabase.pl: DBD::mysql::db do failed: Cannot
add or update a child row: a foreign key constraint fails
(`kohatest`.`message_transports`, CONSTRAINT `message_transports_ibfk_1`
FOREIGN KEY (`message_attribute_id`) REFERENCES `message_attributes`
(`message_attribute_id`) ON DELETE CASCADE ON UPDAT) at
/usr/share/koha/testclone/installer/data/mysql/updatedatabase.pl line 5359.

I checked and see that I do not have attribute 2 in my atts table?
You refer to it in:
 (2, 'phone', 0, 'circulation', 'PREDUE_PHONE')
Line 5362 insert on message_transports.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

--- Comment #17 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 10062
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10062action=edit
Talking Tech Support - Phase I - Followup 3 - Follow PBP

* Fixes violations of Perl Best Practices, where possible
* perltidy both scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #18 from Kyle M Hall kyle.m.h...@gmail.com ---
Setting to Passed QA as per Paul's comments.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

--- Comment #19 from Paul Poulain paul.poul...@biblibre.com ---
Trying to apply this patch, I get a SQL constraint error:

INSERT INTO message_transports
-  (message_attribute_id, message_transport_type, is_digest,
letter_module, letter_code) VALUES
-  (4, 'phone', 0, 'reserves', 'HOLD_PHONE'),
-  (2, 'phone', 0, 'circulation', 'PREDUE_PHONE')
- ;
ERROR 1452 (23000): Cannot add or update a child row: a foreign key constraint
fails (`lecannetdesmaures`.`message_transports`, CONSTRAINT
`message_transports_ibfk_1` FOREIGN KEY (`message_attribute_id`) REFERENCES
`message_attributes` (`message_attribute_id`) ON DELETE CASCADE)
portable lecannetdesmauresselect * from message_attributes;

Investigating a little show that the message_transports table does not contain
message_attribute_id 4 and 2

Investigating more, it's my sample database that is wrong.

Adding the values that I don't have fixes the problem

will push now

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_10

--- Comment #20 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed, but untested as I don't have Talking Tech subscription. Please
test again in case there's a problem !

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||paul.poul...@biblibre.com

--- Comment #16 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #15)
 Changing status back to signed off because the first patch needs QA from
 someone other than Ian, please.

Melia, when you say 1st patch, are you talking of 3.6.x or
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9487 (Talking Tech
Support - Phase I) ?

QA comments (considering the 3.6.x patch is irrelevant)
 1- the 3 patches (excludint 3.6.x one) apply smoothly on master
 2- I tested with the syspref OFF (default), no noticeable change, as expected
 3- the 2 new scripts does not pass perlcritic:
misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl: Two-argument open used
at line 63, column 4.  See page 207 of PBP.  (Severity: 5)
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: Bareword file handle
opened at line 87, column 4.  See pages 202,204 of PBP.  (Severity: 5)
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: Two-argument open
used at line 87, column 4.  See page 207 of PBP.  (Severity: 5)
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: Bareword file handle
opened at line 90, column 4.  See pages 202,204 of PBP.  (Severity: 5)

 4- You changed the signature of the Enqueueletter sub:
-return $result;
+return $dbh-last_insert_id(undef,undef,'message_queue', undef);
However, others use of this sub weren't managing any returned value, so that's
not a problem.

Please fix 3 and explain what should be done with the 3.6.x patch (obsoleted ?)
to earn passed QA status

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8639|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||me...@bywatersolutions.com

--- Comment #15 from Melia Meggs me...@bywatersolutions.com ---
Changing status back to signed off because the first patch needs QA from
someone other than Ian, please.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from Ian Walls koha.sek...@gmail.com ---
C4::Form::MessagingPreferences::set_form_values still uses
@{$pref-{'transports'}} syntax.

As does opac-userupdate.pl : @{$pref-{'transports'}}. 

Changing the return value from array to hash will break these instances;
marking Failed QA on followup patch.


As for the first patch, could another member of the QA team take a look, as I
have a large part in the authorship?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

--- Comment #14 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 9501
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9501action=edit
Talking Tech Support - Phase I - Followup 2 - Bugfix

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Attachment #8636|0   |1
is obsolete||

--- Comment #10 from Nicole C. Engard neng...@gmail.com ---
Created attachment 9487
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9487action=edit
[SIGNED-OFF] Talking Tech Support - Phase I

Implements support for Talking Tech I-tiva phone notification for OVERDUE,
PREDUE and HOLD notifications.
Overdues respect triggers as configured for the patron's branch.
Predue and Holds notifications respect patron's messaging preference choices.
A new column for phone notification is added if the
TalkingTechItivaPhoneNotification system preference is turned on

Record of phone messages being sent to patrons is added to the patron's Notices
tab; notice of success or failure can be retrieved from I-tiva.

See the TalkingTech.README for installation and set-up instructions.

Aside from the control system preference, and the necessary changes to
Messaging Preferences
forms to make use of phone notifications, the bulk of the code resides in
external
cronjobs.

TalkingTech_itiva_outbound.pl generates the Spec C file to send to I-tiva. 
Actual transmission
of the file must be handled by the system administrator.

TalkingTech_itiva_inbound.pl processes the received Results file from I-tiva. 
Getting the
file from I-tiva to Koha is the job of the system administrator, as well.

Both scripts have a --help option with full documentation.

The only necessary change to core Koha behavior is in
C4::Letters::EnqueueLetter.  The return
value was changed from 0 or 1 (successful addition of letter to message_queue
or not), to the actual
insert ID of the letter.  This was required by the outbound script to present a
unique Transaction ID
for the notice added to the patron's record (so a 'sent' or 'failed' status
could be updated).  Since
the dbh and sth are not shared, and the last_insert_id() command is
table-specific, this should be thread-safe.
No changes are necessary to any parts of Koha, as all usage of EnqueueLetter
currently ignores the return value.

To Test:

1. Turn on TalkingTechItivaPhoneNotification system preference
2. Verify that 'phone' is now a valid notification option for patrons on both
staff and OPAC side
3. Attempt to set a 'phone' preference for PREDUE or HOLD messaging; attempt
should succeed
4. Set up the patron for notices to triggers:
   a. include checked out items due in a range of days, including the value set
up in their messaging preferences.
   b. place several holds, some in position, others waiting for pickup, others
in transit.
   c. set the patron up to have overdues, overdue by a range of days that
includes the delay values for
the patrons branch and categorycode
5. Run TalkingTech_itiva_outbound.pl --type=RESERVE --type=PREOVERDUE
--type=OVERDUE --outfile=/tmp/talkingtechtest.csv

The resulting talkingtechtest.csv file should include all the items due on X
days (where X is the patrons' preference),
and none of the ones due in other increments.  Similarly, overdues messages
should be added for each item due by a delay
value as configured; overdues of other numbers of days should be ignore.  Holds
that are waiting pick up or in transit should
have messages, those still pending should not.

Messages should be added to the patron's notices tab for each issue sent. 
Verify these messages exist, and all Notices
tokens are replaced with appropriate information.

Repeat, this time with 4c making use of the default branch overdue triggers,
instead of branch-specific triggers.

To test the inbound script, create a CSV with rows in the format
Message_id,SUCCESS or FAIL
Message ID should correspond to the final column of the talkingtechtest.csv
file (the transaction id) for the message.

Primary Authorship: Ian Walls
Additional modifications: Kyle M Hall

http://bugs.koha-community.org/show_bug.cgi?id=4246
Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

Tested and in use in production by two public libraries : Middletown
and Washoe. Both have given their sign off, but don't have git to
actually sign off.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Attachment #8638|0   |1
is obsolete||

--- Comment #11 from Nicole C. Engard neng...@gmail.com ---
Created attachment 9488
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9488action=edit
[SIGNED-OFF] Talking Tech Support - Phase I - Followup - Fix Messaging
Preferences

There is a flaw in C4::Members::Messaging::GetMessagingPreferences where
the system assumes that every transport will use the same letter. This
is not necessarily true. Even with the default preferences of just
'email' and 'sms', we should be able to have different letters
for each, as one has a maximum character length ( sms ) and one
does not. GetMessagingPreferences currently uses the letter code
of the last result of its query as the letter code for every transport type.

The returned data is a hashref with a key 'transport_types' that is
an array of transport_types this borrower has selected for the given
alert.

This commit modifies GetMessagingPreferences such that the the
'transport_types' array is now a hash where the name of the transport
type is now a key to the value of the letter code set for that transport
type.

It also modifies code calling GetMessagingPreferences where necessary,
and as a side benefit will correctly get the letter codes for email
and sms correctly, if they are defined differently.

http://bugs.koha-community.org/show_bug.cgi?id=4246
Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

In use in production by two libraries: Middletown and Washoe
who give their sign off but don't have git to do so.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Curtis Yeatman curt...@talkingtech.com changed:

   What|Removed |Added

 CC||curt...@talkingtech.com

--- Comment #12 from Curtis Yeatman curt...@talkingtech.com ---
This development is working fine and has been in use on two libraries'
production servers (successfully) for several months.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8014|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8636
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8636action=edit
Talking Tech Support - Phase I

Implements support for Talking Tech I-tiva phone notification for OVERDUE,
PREDUE and HOLD notifications.
Overdues respect triggers as configured for the patron's branch.
Predue and Holds notifications respect patron's messaging preference choices.
A new column for phone notification is added if the
TalkingTechItivaPhoneNotification system preference is turned on

Record of phone messages being sent to patrons is added to the patron's Notices
tab; notice of success or failure can be retrieved from I-tiva.

See the TalkingTech.README for installation and set-up instructions.

Aside from the control system preference, and the necessary changes to
Messaging Preferences
forms to make use of phone notifications, the bulk of the code resides in
external
cronjobs.

TalkingTech_itiva_outbound.pl generates the Spec C file to send to I-tiva. 
Actual transmission
of the file must be handled by the system administrator.

TalkingTech_itiva_inbound.pl processes the received Results file from I-tiva. 
Getting the
file from I-tiva to Koha is the job of the system administrator, as well.

Both scripts have a --help option with full documentation.

The only necessary change to core Koha behavior is in
C4::Letters::EnqueueLetter.  The return
value was changed from 0 or 1 (successful addition of letter to message_queue
or not), to the actual
insert ID of the letter.  This was required by the outbound script to present a
unique Transaction ID
for the notice added to the patron's record (so a 'sent' or 'failed' status
could be updated).  Since
the dbh and sth are not shared, and the last_insert_id() command is
table-specific, this should be thread-safe.
No changes are necessary to any parts of Koha, as all usage of EnqueueLetter
currently ignores the return value.

To Test:

1. Turn on TalkingTechItivaPhoneNotification system preference
2. Verify that 'phone' is now a valid notification option for patrons on both
staff and OPAC side
3. Attempt to set a 'phone' preference for PREDUE or HOLD messaging; attempt
should succeed
4. Set up the patron for notices to triggers:
   a. include checked out items due in a range of days, including the value set
up in their messaging preferences.
   b. place several holds, some in position, others waiting for pickup, others
in transit.
   c. set the patron up to have overdues, overdue by a range of days that
includes the delay values for
the patrons branch and categorycode
5. Run TalkingTech_itiva_outbound.pl --type=RESERVE --type=PREOVERDUE
--type=OVERDUE --outfile=/tmp/talkingtechtest.csv

The resulting talkingtechtest.csv file should include all the items due on X
days (where X is the patrons' preference),
and none of the ones due in other increments.  Similarly, overdues messages
should be added for each item due by a delay
value as configured; overdues of other numbers of days should be ignore.  Holds
that are waiting pick up or in transit should
have messages, those still pending should not.

Messages should be added to the patron's notices tab for each issue sent. 
Verify these messages exist, and all Notices
tokens are replaced with appropriate information.

Repeat, this time with 4c making use of the default branch overdue triggers,
instead of branch-specific triggers.

To test the inbound script, create a CSV with rows in the format
Message_id,SUCCESS or FAIL
Message ID should correspond to the final column of the talkingtechtest.csv
file (the transaction id) for the message.

Primary Authorship: Ian Walls
Additional modifications: Kyle M Hall

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

--- Comment #7 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8637
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8637action=edit
Talking Tech Support - Phase I - Followup - Fix Messaging Preferences

There is a flaw in C4::Members::Messaging::GetMessagingPreferences where
the system assumes that every transport will use the same letter. This
is not necessarily true. Even with the default preferences of just
'email' and 'sms', we should be able to have different letters
for each, as one has a maximum character length ( sms ) and one
does not. GetMessagingPreferences currently uses the letter code
of the last result of its query as the letter code for every transport type.

The returned data is a hashref with a key 'transport_types' that is
an array of transport_types this borrower has selected for the given
alert.

This commit modifies GetMessagingPreferences such that the the
'transport_types' array is now a hash where the name of the transport
type is now a key to the value of the letter code set for that transport
type.

It also modifies code calling GetMessagingPreferences where necessary,
and as a side benefit will correctly get the letter codes for email
and sms correctly, if they are defined differently.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8637|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8638
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8638action=edit
Talking Tech Support - Phase I - Followup - Fix Messaging Preferences

There is a flaw in C4::Members::Messaging::GetMessagingPreferences where
the system assumes that every transport will use the same letter. This
is not necessarily true. Even with the default preferences of just
'email' and 'sms', we should be able to have different letters
for each, as one has a maximum character length ( sms ) and one
does not. GetMessagingPreferences currently uses the letter code
of the last result of its query as the letter code for every transport type.

The returned data is a hashref with a key 'transport_types' that is
an array of transport_types this borrower has selected for the given
alert.

This commit modifies GetMessagingPreferences such that the the
'transport_types' array is now a hash where the name of the transport
type is now a key to the value of the letter code set for that transport
type.

It also modifies code calling GetMessagingPreferences where necessary,
and as a side benefit will correctly get the letter codes for email
and sms correctly, if they are defined differently.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

--- Comment #9 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8639
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8639action=edit
3.6.x - Talking Tech Support - Phase I - Followup - Fix Messaging Preferences

There is a flaw in C4::Members::Messaging::GetMessagingPreferences where
the system assumes that every transport will use the same letter. This
is not necessarily true. Even with the default preferences of just
'email' and 'sms', we should be able to have different letters
for each, as one has a maximum character length ( sms ) and one
does not. GetMessagingPreferences currently uses the letter code
of the last result of its query as the letter code for every transport type.

The returned data is a hashref with a key 'transport_types' that is
an array of transport_types this borrower has selected for the given
alert.

This commit modifies GetMessagingPreferences such that the the
'transport_types' array is now a hash where the name of the transport
type is now a key to the value of the letter code set for that transport
type.

It also modifies code calling GetMessagingPreferences where necessary,
and as a side benefit will correctly get the letter codes for email
and sms correctly, if they are defined differently.

http://bugs.koha-community.org/show_bug.cgi?id=4246

Conflicts:

C4/Circulation.pm
C4/Reserves.pm

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

--- Comment #4 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8012
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8012action=edit
Talking Tech Support - Phase I

Implements support for Talking Tech I-tiva phone notification for OVERDUE,
PREDUE and HOLD notifications.
Overdues respect triggers as configured for the patron's branch.
Predue and Holds notifications respect patron's messaging preference choices.
A new column for phone notification is added if the
TalkingTechItivaPhoneNotification system preference is turned on

Record of phone messages being sent to patrons is added to the patron's Notices
tab; notice of success or failure can be retrieved from I-tiva.

See the TalkingTech.README for installation and set-up instructions.

Aside from the control system preference, and the necessary changes to
Messaging Preferences
forms to make use of phone notifications, the bulk of the code resides in
external
cronjobs.

TalkingTech_itiva_outbound.pl generates the Spec C file to send to I-tiva. 
Actual transmission
of the file must be handled by the system administrator.

TalkingTech_itiva_inbound.pl processes the received Results file from I-tiva. 
Getting the
file from I-tiva to Koha is the job of the system administrator, as well.

Both scripts have a --help option with full documentation.

The only necessary change to core Koha behavior is in
C4::Letters::EnqueueLetter.  The return
value was changed from 0 or 1 (successful addition of letter to message_queue
or not), to the actual
insert ID of the letter.  This was required by the outbound script to present a
unique Transaction ID
for the notice added to the patron's record (so a 'sent' or 'failed' status
could be updated).  Since
the dbh and sth are not shared, and the last_insert_id() command is
table-specific, this should be thread-safe.
No changes are necessary to any parts of Koha, as all usage of EnqueueLetter
currently ignores the return value.

To Test:

1. Turn on TalkingTechItivaPhoneNotification system preference
2. Verify that 'phone' is now a valid notification option for patrons on both
staff and OPAC side
3. Attempt to set a 'phone' preference for PREDUE or HOLD messaging; attempt
should succeed
4. Set up the patron for notices to triggers:
   a. include checked out items due in a range of days, including the value set
up in their messaging preferences.
   b. place several holds, some in position, others waiting for pickup, others
in transit.
   c. set the patron up to have overdues, overdue by a range of days that
includes the delay values for
the patrons branch and categorycode
5. Run TalkingTech_itiva_outbound.pl --type=RESERVE --type=PREOVERDUE
--type=OVERDUE --outfile=/tmp/talkingtechtest.csv

The resulting talkingtechtest.csv file should include all the items due on X
days (where X is the patrons' preference),
and none of the ones due in other increments.  Similarly, overdues messages
should be added for each item due by a delay
value as configured; overdues of other numbers of days should be ignore.  Holds
that are waiting pick up or in transit should
have messages, those still pending should not.

Messages should be added to the patron's notices tab for each issue sent. 
Verify these messages exist, and all Notices
tokens are replaced with appropriate information.

Repeat, this time with 4c making use of the default branch overdue triggers,
instead of branch-specific triggers.

To test the inbound script, create a CSV with rows in the format
Message_id,SUCCESS or FAIL
Message ID should correspond to the final column of the talkingtechtest.csv
file (the transaction id) for the message.

Primary Authorship: Ian Walls
Additional modifications: Kyle M Hall

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #7965|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8012|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8014
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8014action=edit
Talking Tech Support - Phase I

Implements support for Talking Tech I-tiva phone notification for OVERDUE,
PREDUE and HOLD notifications.
Overdues respect triggers as configured for the patron's branch.
Predue and Holds notifications respect patron's messaging preference choices.
A new column for phone notification is added if the
TalkingTechItivaPhoneNotification system preference is turned on

Record of phone messages being sent to patrons is added to the patron's Notices
tab; notice of success or failure can be retrieved from I-tiva.

See the TalkingTech.README for installation and set-up instructions.

Aside from the control system preference, and the necessary changes to
Messaging Preferences
forms to make use of phone notifications, the bulk of the code resides in
external
cronjobs.

TalkingTech_itiva_outbound.pl generates the Spec C file to send to I-tiva. 
Actual transmission
of the file must be handled by the system administrator.

TalkingTech_itiva_inbound.pl processes the received Results file from I-tiva. 
Getting the
file from I-tiva to Koha is the job of the system administrator, as well.

Both scripts have a --help option with full documentation.

The only necessary change to core Koha behavior is in
C4::Letters::EnqueueLetter.  The return
value was changed from 0 or 1 (successful addition of letter to message_queue
or not), to the actual
insert ID of the letter.  This was required by the outbound script to present a
unique Transaction ID
for the notice added to the patron's record (so a 'sent' or 'failed' status
could be updated).  Since
the dbh and sth are not shared, and the last_insert_id() command is
table-specific, this should be thread-safe.
No changes are necessary to any parts of Koha, as all usage of EnqueueLetter
currently ignores the return value.

To Test:

1. Turn on TalkingTechItivaPhoneNotification system preference
2. Verify that 'phone' is now a valid notification option for patrons on both
staff and OPAC side
3. Attempt to set a 'phone' preference for PREDUE or HOLD messaging; attempt
should succeed
4. Set up the patron for notices to triggers:
   a. include checked out items due in a range of days, including the value set
up in their messaging preferences.
   b. place several holds, some in position, others waiting for pickup, others
in transit.
   c. set the patron up to have overdues, overdue by a range of days that
includes the delay values for
the patrons branch and categorycode
5. Run TalkingTech_itiva_outbound.pl --type=RESERVE --type=PREOVERDUE
--type=OVERDUE --outfile=/tmp/talkingtechtest.csv

The resulting talkingtechtest.csv file should include all the items due on X
days (where X is the patrons' preference),
and none of the ones due in other increments.  Similarly, overdues messages
should be added for each item due by a delay
value as configured; overdues of other numbers of days should be ignore.  Holds
that are waiting pick up or in transit should
have messages, those still pending should not.

Messages should be added to the patron's notices tab for each issue sent. 
Verify these messages exist, and all Notices
tokens are replaced with appropriate information.

Repeat, this time with 4c making use of the default branch overdue triggers,
instead of branch-specific triggers.

To test the inbound script, create a CSV with rows in the format
Message_id,SUCCESS or FAIL
Message ID should correspond to the final column of the talkingtechtest.csv
file (the transaction id) for the message.

Primary Authorship: Ian Walls
Additional modifications: Kyle M Hall

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

--- Comment #2 from Kyle M Hall kyle.m.h...@gmail.com 2012-03-01 14:05:44 UTC 
---
Created attachment 7964
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7964
Implements support for Talking Tech I-tiva phone notification for OVERDUE,
PREDUE and HOLD notifications.  Overdues respect triggers as configured for the
patron's branch.  Predue and Holds notifications respect patron's messaging
preference choices.  A n

Record of phone messages being sent to patrons is added to the patron's Notices
tab; notice of success or failure can be retrieved from I-tiva.

See the TalkingTech.README for installation and set-up instructions.

Aside from the control system preference, and the necessary changes to
Messaging Preferences
forms to make use of phone notifications, the bulk of the code resides in
external
cronjobs.

TalkingTech_itiva_outbound.pl generates the Spec C file to send to I-tiva. 
Actual transmission
of the file must be handled by the system administrator.

TalkingTech_itiva_inbound.pl processes the received Results file from I-tiva. 
Getting the
file from I-tiva to Koha is the job of the system administrator, as well.

Both scripts have a --help option with full documentation.

The only necessary change to core Koha behavior is in
C4::Letters::EnqueueLetter.  The return
value was changed from 0 or 1 (successful addition of letter to message_queue
or not), to the actual
insert ID of the letter.  This was required by the outbound script to present a
unique Transaction ID
for the notice added to the patron's record (so a 'sent' or 'failed' status
could be updated).  Since
the dbh and sth are not shared, and the last_insert_id() command is
table-specific, this should be thread-safe.
No changes are necessary to any parts of Koha, as all usage of EnqueueLetter
currently ignores the return value.

To Test:

1. Turn on TalkingTechItivaPhoneNotification system preference
2. Verify that 'phone' is now a valid notification option for patrons on both
staff and OPAC side
3. Attempt to set a 'phone' preference for PREDUE or HOLD messaging; attempt
should succeed
4. Set up the patron for notices to triggers:
   a. include checked out items due in a range of days, including the value set
up in their messaging preferences.
   b. place several holds, some in position, others waiting for pickup, others
in transit.
   c. set the patron up to have overdues, overdue by a range of days that
includes the delay values for
the patrons branch and categorycode
5. Run TalkingTech_itiva_outbound.pl --type=RESERVE --type=PREOVERDUE
--type=OVERDUE --outfile=/tmp/talkingtechtest.csv

The resulting talkingtechtest.csv file should include all the items due on X
days (where X is the patrons' preference),
and none of the ones due in other increments.  Similarly, overdues messages
should be added for each item due by a delay
value as configured; overdues of other numbers of days should be ignore.  Holds
that are waiting pick up or in transit should
have messages, those still pending should not.

Messages should be added to the patron's notices tab for each issue sent. 
Verify these messages exist, and all Notices
tokens are replaced with appropriate information.

Repeat, this time with 4c making use of the default branch overdue triggers,
instead of branch-specific triggers.

To test the inbound script, create a CSV with rows in the format
Message_id,SUCCESS or FAIL
Message ID should correspond to the final column of the talkingtechtest.csv
file (the transaction id) for the message.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #7964|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall kyle.m.h...@gmail.com 2012-03-01 14:07:26 UTC 
---
Created attachment 7965
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7965
Talking Tech Support - Phase I

Implements support for Talking Tech I-tiva phone notification for OVERDUE,
PREDUE and HOLD notifications.
Overdues respect triggers as configured for the patron's branch.
Predue and Holds notifications respect patron's messaging preference choices.
A new column for phone notification is added if the
TalkingTechItivaPhoneNotification system preference is turned on

Record of phone messages being sent to patrons is added to the patron's Notices
tab; notice of success or failure can be retrieved from I-tiva.

See the TalkingTech.README for installation and set-up instructions.

Aside from the control system preference, and the necessary changes to
Messaging Preferences
forms to make use of phone notifications, the bulk of the code resides in
external
cronjobs.

TalkingTech_itiva_outbound.pl generates the Spec C file to send to I-tiva. 
Actual transmission
of the file must be handled by the system administrator.

TalkingTech_itiva_inbound.pl processes the received Results file from I-tiva. 
Getting the
file from I-tiva to Koha is the job of the system administrator, as well.

Both scripts have a --help option with full documentation.

The only necessary change to core Koha behavior is in
C4::Letters::EnqueueLetter.  The return
value was changed from 0 or 1 (successful addition of letter to message_queue
or not), to the actual
insert ID of the letter.  This was required by the outbound script to present a
unique Transaction ID
for the notice added to the patron's record (so a 'sent' or 'failed' status
could be updated).  Since
the dbh and sth are not shared, and the last_insert_id() command is
table-specific, this should be thread-safe.
No changes are necessary to any parts of Koha, as all usage of EnqueueLetter
currently ignores the return value.

To Test:

1. Turn on TalkingTechItivaPhoneNotification system preference
2. Verify that 'phone' is now a valid notification option for patrons on both
staff and OPAC side
3. Attempt to set a 'phone' preference for PREDUE or HOLD messaging; attempt
should succeed
4. Set up the patron for notices to triggers:
   a. include checked out items due in a range of days, including the value set
up in their messaging preferences.
   b. place several holds, some in position, others waiting for pickup, others
in transit.
   c. set the patron up to have overdues, overdue by a range of days that
includes the delay values for
the patrons branch and categorycode
5. Run TalkingTech_itiva_outbound.pl --type=RESERVE --type=PREOVERDUE
--type=OVERDUE --outfile=/tmp/talkingtechtest.csv

The resulting talkingtechtest.csv file should include all the items due on X
days (where X is the patrons' preference),
and none of the ones due in other increments.  Similarly, overdues messages
should be added for each item due by a delay
value as configured; overdues of other numbers of days should be ignore.  Holds
that are waiting pick up or in transit should
have messages, those still pending should not.

Messages should be added to the patron's notices tab for each issue sent. 
Verify these messages exist, and all Notices
tokens are replaced with appropriate information.

Repeat, this time with 4c making use of the default branch overdue triggers,
instead of branch-specific triggers.

To test the inbound script, create a CSV with rows in the format
Message_id,SUCCESS or FAIL
Message ID should correspond to the final column of the talkingtechtest.csv
file (the transaction id) for the message.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Does not apply

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/