[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-08-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #47 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Pushed to 3.10.x, will be in 3.10.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #46 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Bernardo and Marcel!

Note: I added an entry in updatedatabase.pl for 3.12.x, that tells the user
about this, just in case they want to apply it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #45 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Bernardo and Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #39 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Bernardo,
I received your new file. And will recreate your patch now. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #19371|0   |1
is obsolete||
  Attachment #19372|0   |1
is obsolete||
  Attachment #19373|0   |1
is obsolete||

--- Comment #40 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 19454
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19454action=edit
Bug 5858 - Default frameworks missing many MARC21 tags

This patch combines original patch and two followups (with thanks to Mason).
Patch has been recreated to recover from the whitespace errors coming back in
the followups.
The patch adds missing tags/subtags, or updates descriptions.

Does only apply to new installs. We will still find a way to have current
installs also/easier benefit from these changes too.

To test:
1) Delete MARC21 default framework
2) Apply patch
3) Test that new default framework loads without problem

Signed-off-by: Mason James m...@kohaaloha.com
Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Run this file with and without this patch.
This patch adds 24 tags (338 vs 314) and 323 subfields (3951 vs 3628).
Verified that last QA comments were incorporated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #41 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Final(?:) QA comment:
Looks good to me now, Bernardo. Good work again.
Refer to my former comment. Points have been incorporated.

Passed QA

The following points still need attention:

1. How do we translate? My proposal is here: do this via bug 10509; the i18n
proposal there will make life easier for the non-English installs.
BTW I waited for this patch to include the marc21 changes of this report.

2. How will current installs benefit?
Thinking out loud: Would it be an idea if we could Upgrade on the MARC
structure administration form? Upgrade would just run this file and try to
insert the new ones. (That could include translation with the i18n approach.
Run the file via load_sql.)
Will add a followup to replace INSERT by INSERT IGNORE. This allows you to run
the file on an existing install.

RM: With respect to the second question, it might be good to include a dbrev
that prints a message about the possibility to add new tags when upgrading by
running the script manually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #42 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 19455
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19455action=edit
Bug 5858: Followup for INSERT IGNOREs in marc21_framework_DEFAULT.sql

Changes 8 INSERTs into INSERT IGNOREs.
This allows current installs to benefit easier from the new tags/subfields.
Note that running with --force will not achieve the same! The multi-value
inserts will still be aborted, though execution continues.

Test plan:
Run the file or do a new install.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Ran the file on a current install manually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #43 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Last thought on the Upgrade idea:
Would be nice to do something like that. Since we still have the non-default
frameworks here too (with their redundancy..)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #44 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
My idea is rewrite marc21_simple_bib_frameworks.sql to create
bib frameworks like authtypes in Bug 10488.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #37 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Good work! 
The first patch contains a lot of mixups with repeatable and mandatory flag for
the MARC tags. (I see that you resolve them in the third patch.)
The second patch contains a subfield 046 $3. It is not in the list of LOC. So I
think that it should be removed until we are sure about it.
The second (and third?) patch also has some problem with whitespace. I tried
several things, but it keeps coming back in the lines around tag 082 - 086.

Tag 260: You remove (IMPRINT), I think it should stay. See LOC.

I checked all tags with LOC, but focused on mandatory/repeatable for the
subfields.

Rest looks good to me. Please make final corrections for:

a) 046 $3 and 260 [You can probably amend Mason's patch, plz mention in commit]
b) whitespace trouble

Changing status to reflect need for minor adjustments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #38 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
(In reply to M. de Rooy from comment #37)
 
 Rest looks good to me. Please make final corrections for:
 
 a) 046 $3 and 260 [You can probably amend Mason's patch, plz mention in
 commit]
 b) whitespace trouble
 
 Changing status to reflect need for minor adjustments.

Thanks for testing!!
I'll ammend and fix spaces and tags.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #28 from M. de Rooy m.de.r...@rijksmuseum.nl ---
fatal: sha1 information is lacking or useless
(installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 5858 - Update default MARC21 framework to Update No.
16 (April 2013)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #29 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
(In reply to M. de Rooy from comment #28)
 fatal: sha1 information is lacking or useless
 (installer/data/mysql/en/marcflavour/marc21/mandatory/
 marc21_framework_DEFAULT.sql).
 Repository lacks necessary blobs to fall back on 3-way merge.
 Cannot fall back to three-way merge.
 Patch failed at 0001 Bug 5858 - Update default MARC21 framework to Update
 No. 16 (April 2013)

Strange

~/kohaclone$ git pull
Already up-to-date.
~/kohaclone$ git checkout bug_5858-B
Switched to branch 'bug_5858-B'
Your branch is behind 'origin/master' by 11 commits, and can be fast-forwarded.
~/kohaclone$ git rebase master
First, rewinding head to replay your work on top of it...
Fast-forwarded bug_5858-B to master.
~/kohaclone$ git bz apply 5858
Bug 5858 - Update default MARC21 framework to Update No. 16 (April 2013)

Bug 5858 - Default frameworks missing many MARC21 tags
Apply? [yn] y

Applying: Bug 5858 - Default frameworks missing many MARC21 tags
[FOLLOWUP] Bug 5858 - Default frameworks missing many MARC21 tags
Apply? [yn] y

Applying: Bug 5858 - Default frameworks missing many MARC21 tags
[FOLLOWUP 2] Bug 5858 - Update default MARC21 framework
Apply? [yn] y

Applying: Bug 5858 - Update default MARC21 framework to Update No. 16 (April
2013)
~/kohaclone$

For me it's applying without problem, should I switch to Needs Singoff?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #30 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Bernardo:
Try to apply them on top of current master (with git-bz) ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #31 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Bernardo:
I am getting further with Mason's patch when I use --ignore-whitespace on the
patch file.
Shall I continue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #18584|0   |1
is obsolete||

--- Comment #33 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 19372
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19372action=edit
Bug 5858 - Default frameworks missing many MARC21 tags

This patch is a *followup* to the previous patch

Update MARC21 fields/subfields to version 16
http://www.loc.gov/marc/bibliographic/bdapndxg.html

Only to new installs.

To test:
1) Delete MARC21 default framework
2) Apply patch
3) Test that new default framework loads without problem

Rebased to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #32 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 19371
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19371action=edit
Bug 5858 - Default frameworks missing many MARC21 tags

This patch replaces previous ones.
Only adds missing tags/subtags or update descriptions.

Only to new installs.

To test:
1) Delete MARC21 default framework
2) Apply patch
3) Test that new default framework loads without problem

Rebased to master.

Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #35 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Sorry, couldn't wait. Yes, we are back in the air. Three patches applied. Will
have a look again :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #34 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 19373
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19373action=edit
Bug 5858 - Update default MARC21 framework to Update No. 16 (April 2013)

This is another followup.

It updates some missing tags/subtags, also corrects
and verify repeatable value for tags/subtags

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #19330|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #18585|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #36 from M. de Rooy m.de.r...@rijksmuseum.nl ---
I still need some time for these patches.
Will hopefully finish this tomorrow.
When squashing these patches, I again had the whitespace trouble. So we need
some care with this set of patches.

This is an impressive amount of work, Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #25 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Looking at this now..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #26 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Mason:
Something is wrong with your followup. 
Look here:

('383', 'NUMERIC DESIGNATION OF MUSICAL WORK', 'NUMERIC DESIGNATION OF
MUSICAL WORK', 0, 1, NULL, ''),
 0, 1, NULL, ''),
UDIENCE CHARACTERISTICS', 'AUDIENCE CHARACTERISTICS', 1, 0, NULL, ''),

Bernardo or Mason: please correct! 

Failed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #27 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 19330
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19330action=edit
[FOLLOWUP 2] Bug 5858 - Update default MARC21 framework

This is another followup.

It updates some missing tags/subtags, also corrects
and verify repeatable value for tags/subtags

Also rearrange some out of order entries(referenced on comment #26)

I think that now the update is correct and complete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-06-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #24 from Mason James m...@kohaaloha.com ---
(In reply to comment #23)
 (In reply to comment #20)
  Created attachment 18584 [details] [review] [review]
  Bug 5858 - Default frameworks missing many MARC21 tags
 
  Signed-off-by: Mason James m...@kohaaloha.com
 
 i've taken a look a Bernardo's patch, and tested it
 
 it looks good

i've signed-off on Bernardo's patch

just awaiting sign-off on my follow-up patch...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com
Summary|Default frameworks missing  |Update default MARC21
   |many MARC21 tags|framework to Update No. 16
   ||(April 2013)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #22 from Mason James m...@kohaaloha.com ---
(In reply to comment #9)
 I am not sure deleting them is a good idea - I would have to test it, but is
 there a chance we loose data if someone imports data that uses fields that
 are not defined in the default framework? I think I would prefer to see them
 hidden and marked [OBSOLETE] to be sure no data can be lost.

it looks like the official MARC21 spec does this too
- http://www.loc.gov/marc/bibliographic/ecbdlist.html

ie: it does not delete old fields/subfields, but just marks them [OBSOLETE]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #23 from Mason James m...@kohaaloha.com ---
(In reply to comment #20)
 Created attachment 18584 [details] [review]
 Bug 5858 - Default frameworks missing many MARC21 tags

 Signed-off-by: Mason James m...@kohaaloha.com

i've taken a look a Bernardo's patch, and tested it

it looks good

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/