[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15173


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173
[Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12176

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #112 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 33487
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33487action=edit
Bug 7673: (RM followup) typo in sysprefs.sql

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #111 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #32928|0   |1
is obsolete||

--- Comment #109 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 32962
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32962action=edit
Bug 7673 [Terminology follow-up] New patron permissions to manage items

This bug adds a new preference, SubfieldsToAllowForRestrictedEdition,
but the use of the term Edition in this context is incorrect. I think
it would be more clear to change the preference name to
SubfieldsToAllowForRestrictedEditing. This patch makes this change.

I realize this isn't a big issue since the preference has a good
description, but I thought that if we were going to make this as clear
as possible now would be the time to do it.

To test, start with a database which hasn't previously been used to test
Bug 7673. Apply all patches and run the database update. Follow the test
plan as described in the bug.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32962|0   |1
is obsolete||

--- Comment #110 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32993
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32993action=edit
[PASSED QA] Bug 7673 [Terminology follow-up] New patron permissions to manage
items

This bug adds a new preference, SubfieldsToAllowForRestrictedEdition,
but the use of the term Edition in this context is incorrect. I think
it would be more clear to change the preference name to
SubfieldsToAllowForRestrictedEditing. This patch makes this change.

I realize this isn't a big issue since the preference has a good
description, but I thought that if we were going to make this as clear
as possible now would be the time to do it.

To test, start with a database which hasn't previously been used to test
Bug 7673. Apply all patches and run the database update. Follow the test
plan as described in the bug.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works as described, change appears complete.
All tests and QA script still pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #108 from Owen Leonard oleon...@myacpl.org ---
Created attachment 32928
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32928action=edit
Bug 7673 [Terminology follow-up] New patron permissions to manage items

This bug adds a new preference, SubfieldsToAllowForRestrictedEdition,
but the use of the term Edition in this context is incorrect. I think
it would be more clear to change the preference name to
SubfieldsToAllowForRestrictedEditing. This patch makes this change.

I realize this isn't a big issue since the preference has a good
description, but I thought that if we were going to make this as clear
as possible now would be the time to do it.

To test, start with a database which hasn't previously been used to test
Bug 7673. Apply all patches and run the database update. Follow the test
plan as described in the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #95 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Jonathan, 

a few small things: 

1) The permission description for items_batchmod_restricted has some small
typos.
2) sysprefs.sql is missing.
3) If you have items_batchmod and items_batchmod_restricted both checked (which
   happens automatically with the database update - the items form is not
   showing up on batch modification, because the pref is empty by default.
   After rereading the description - maybe we should just not check the   
   permission on database update then it should not change any behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #96 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 32200
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32200action=edit
Bug 7673: add syspref in sysprefs.pl

Also fix a typo in the permission description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #97 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 32201
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32201action=edit
Bug 7673: Assume that all fields can be edited if the pref is empty

If the sysprefs are empty, we assume that the librarian can edit all
subfields, even if s/he has the restricted permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #98 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32215
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32215action=edit
[PASSED QA] Bug 7673 : New patron permissions

This patch adds the following permissions:

 - editcatalogue.limited_item_edition: Limit item modification to barcode,
status and note
 - editcatalogue.delete_all_items: Delete all items at once
 - tools.items_limited_batchmod: Limit batch item modification to item
status

The SubfieldsToAllowForLimitedEdition syspref is used to define which
subfields can be edited
when the editcatalogue.limited_item_edition permission is enabled.

In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define
which subfields
can be edited when the tools.items_limited_batchmod permission is enabled.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #100 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32219
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32219action=edit
[PASSED QA] Bug 7673: The delete all items link should only be displayed if
delete_all_items is set

This test had been lost in a rebase.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #99 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32217
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32217action=edit
[PASSED QA] Bug 7673: QA Followup: trailing whitespace and perlcritic issues

This patch fixes the following qa issues:

 FAIL   cataloguing/additem.pl
   FAIL   forbidden patterns
forbidden pattern: trailing space char (line 833)
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 2 violation(s).

 FAIL   tools/batchMod.pl
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 2 violation(s).

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #101 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32220
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32220action=edit
[PASSED QA] Bug 7673: the limitation on editing an item does not affect FA
framework

The pref SubfieldsToAllowForLimitedEdition should not affect Fast
cataloguing framework (FA).

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #102 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 3
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3action=edit
[PASSED QA] Bug 7673: Update syspref names in script

The both syspref names have been changed since the first patch.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #104 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32225
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32225action=edit
[PASSED QA] Bug 7673: Change the superlibrarian check

To know if the user is a superlibrarian, we have to call
C4::Context-IsSuperLibrarian

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #103 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32224
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32224action=edit
[PASSED QA] Bug 7673: Update permission names in script

Two permission names have been changed since the first patch.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #106 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32227
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32227action=edit
[PASSED QA] Bug 7673: Assume that all fields can be edited if the pref is empty

If the sysprefs are empty, we assume that the librarian can edit all
subfields, even if s/he has the restricted permission.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #107 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32228
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32228action=edit
[PASSED QA] Bug 7673: add syspref in sysprefs.pl

Also fix a typo in the permission description

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Patches pass QA script and tests.

Copying the test plan from the bug report:
Test plan:
1/ add the following permissions to the logged in patron:
edit_item, edit_items_restricted, delete_all_items,
items_batchmod, items_batchmod_restricted

2/ Fill the prefs SubfieldsToAllowForRestrictedEdition
and SubfieldsToAllowForRestrictedBatchmod with some
subfield (for instance 995$f 995$o and 995$o)

3/ Verify you are allowed to edit the item fields defined
in the pref SubfieldsToAllowForRestrictedEdition.

4/ Try to edit item in a batch and verify you are allowed
to edit the item fields defined in the pref
SubfieldsToAllowForRestrictedBatchmod.

5/ Try to delete all items of a record

Play with the pref/permissions and verify they are
correctly taken into account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #105 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32226
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32226action=edit
[PASSED QA] Bug 7673: DB changes - Add permissions

This patch adds:
3 permissions:
- edit_items_restricted
- delete_all_items
- items_batchmod_restricted

2 system preferences:
- SubfieldsToAllowForRestrictedEdition
- SubfieldsToAllowForRestrictedBatchmod.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #31010|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #31011|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #31012|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #31013|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #31015|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #31019|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #31016|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #31017|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32200|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32201|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #30910|0   |1
is obsolete||
  Attachment #30911|0   |1
is obsolete||
  Attachment #30912|0   |1
is obsolete||
  Attachment #30913|0   |1
is obsolete||
  Attachment #30914|0   |1
is obsolete||
  Attachment #30915|0   |1
is obsolete||
  Attachment #30916|0   |1
is obsolete||
  Attachment #30917|0   |1
is obsolete||
  Attachment #30918|0   |1
is obsolete||
  Attachment #30919|0   |1
is obsolete||

--- Comment #85 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31010
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31010action=edit
Bug 7673 : New patron permissions

This patch adds the following permissions:

 - editcatalogue.limited_item_edition: Limit item modification to barcode,
status and note
 - editcatalogue.delete_all_items: Delete all items at once
 - tools.items_limited_batchmod: Limit batch item modification to item
status

The SubfieldsToAllowForLimitedEdition syspref is used to define which
subfields can be edited
when the editcatalogue.limited_item_edition permission is enabled.

In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define
which subfields
can be edited when the tools.items_limited_batchmod permission is enabled.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #86 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31011
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31011action=edit
Bug 7673: QA Followup: trailing whitespace and perlcritic issues

This patch fixes the following qa issues:

 FAIL   cataloguing/additem.pl
   FAIL   forbidden patterns
forbidden pattern: trailing space char (line 833)
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 2 violation(s).

 FAIL   tools/batchMod.pl
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 2 violation(s).

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #87 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31012
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31012action=edit
Bug 7673: The delete all items link should only be displayed if
delete_all_items is set

This test had been lost in a rebase.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #89 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31015
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31015action=edit
Bug 7673: Update syspref names in script

The both syspref names have been changed since the first patch.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #88 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31013
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31013action=edit
Bug 7673: the limitation on editing an item does not affect FA framework

The pref SubfieldsToAllowForLimitedEdition should not affect Fast
cataloguing framework (FA).

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #92 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31019
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31019action=edit
Bug 7673: DB changes - Add permissions

This patch adds:
3 permissions:
- edit_items_restricted
- delete_all_items
- items_batchmod_restricted

2 system preferences:
- SubfieldsToAllowForRestrictedEdition
- SubfieldsToAllowForRestrictedBatchmod.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #90 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31016
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31016action=edit
Bug 7673: Update permission names in script

Two permission names have been changed since the first patch.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #91 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31017
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31017action=edit
Bug 7673: Change the superlibrarian check

To know if the user is a superlibrarian, we have to call
C4::Context-IsSuperLibrarian

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #93 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #82)
 From code review: 
 
 1) (normal) The descriptions for edit_items_restricted and
 items_bachmod_restricted are now no longer correct, since the preferences
 have been added to avoid hardcoding MARC fields - maybe refer to the prefs
 instead?

Done.

 2) (non blocker) Patch keeps(?) a CGI::scrolling_list instance - could be in
 conflict with one of Bernardo's patches there:
 additem.pl:
 $subfield_data{marc_value} =CGI::scrolling_list(@scrparam);

Yes, it will be in conflict, but seems quite easy to fix.

 3) (non blocker) Database updates could be merged.

Done.

 3) Suggestion: should we squash the patches (maybe 1-9 + )? Because the
 permissions got renamed and some other things that could avoid some
 confusion. 

I squashed DB patches. I would like to keep the history (especially because I'm
not the author of the first patch).

 Also an updated summary of the changes and a test plan would be great.

I forgot that...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

Summary|New patron permissions  |New patron permissions to
   ||manage items (edit,
   ||batchmod, delete all)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #94 from Jonathan Druart jonathan.dru...@biblibre.com ---
Test plan:
1/ add the following permissions to the logged in patron:
edit_item, edit_items_restricted, delete_all_items, items_batchmod,
items_batchmod_restricted
2/ Fill the prefs SubfieldsToAllowForRestrictedEdition and
SubfieldsToAllowForRestrictedBatchmod with some subfield (for instance 995$f
995$o and 995$o)
3/ Verify you are allowed to edit the item fields defined in the pref
SubfieldsToAllowForRestrictedEdition.
4/ Try to edit item in a batch and verify you are allowed to edit the item
fields defined in the pref SubfieldsToAllowForRestrictedBatchmod.
5/ Try to delete all items of a record

Play with the pref/permissions and verify they are correctly take into account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 CC|martin.renvoize@ptfs-europe |
   |.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28007|0   |1
is obsolete||

--- Comment #72 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30910
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30910action=edit
Bug 7673 : New patron permissions

This patch adds the following permissions:

 - editcatalogue.limited_item_edition: Limit item modification to barcode,
status and note
 - editcatalogue.delete_all_items: Delete all items at once
 - tools.items_limited_batchmod: Limit batch item modification to item
status

The SubfieldsToAllowForLimitedEdition syspref is used to define which
subfields can be edited
when the editcatalogue.limited_item_edition permission is enabled.

In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define
which subfields
can be edited when the tools.items_limited_batchmod permission is enabled.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28008|0   |1
is obsolete||

--- Comment #73 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30911
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30911action=edit
Bug 7673: QA Followup: trailing whitespace and perlcritic issues

This patch fixes the following qa issues:

 FAIL   cataloguing/additem.pl
   FAIL   forbidden patterns
forbidden pattern: trailing space char (line 833)
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 2 violation(s).

 FAIL   tools/batchMod.pl
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 2 violation(s).

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28009|0   |1
is obsolete||

--- Comment #74 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30912
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30912action=edit
Bug 7673: The delete all items link should only be displayed if
delete_all_items is set

This test had been lost in a rebase.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28010|0   |1
is obsolete||

--- Comment #75 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30913
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30913action=edit
Bug 7673: the limitation on editing an item does not affect FA framework

The pref SubfieldsToAllowForLimitedEdition should not affect Fast
cataloguing framework (FA).

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28014|0   |1
is obsolete||

--- Comment #79 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30917
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30917action=edit
Bug 7673: Change the superlibrarian check

To know if the user is a superlibrarian, we have to call
C4::Context-IsSuperLibrarian

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28015|0   |1
is obsolete||

--- Comment #80 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30918
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30918action=edit
Bug 7673: DB Changes - add system preferences

This patch the 2 system preferences SubfieldsToAllowForRestrictedEdition
and SubfieldsToAllowForRestrictedBatchmod.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28012|0   |1
is obsolete||

--- Comment #77 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30915
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30915action=edit
Bug 7673: DB changes - Add permissions

This patch adds 3 permissions:
- edit_items_restricted
- delete_all_items
- items_batchmod_restricted

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28013|0   |1
is obsolete||

--- Comment #78 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30916
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30916action=edit
Bug 7673: Update permission names in script

Two permission names have been changed since the first patch.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #29550|0   |1
is obsolete||

--- Comment #81 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30919
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30919action=edit
Bug 7673: DB changes - (follow-up) Add permissions

Add permissions for ru-RU and uk-UA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28011|0   |1
is obsolete||

--- Comment #76 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30914
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30914action=edit
Bug 7673: Update syspref names in script

The both syspref names have been changed since the first patch.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #82 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
From code review: 

1) (normal) The descriptions for edit_items_restricted and
items_bachmod_restricted are now no longer correct, since the preferences have
been added to avoid hardcoding MARC fields - maybe refer to the prefs instead?

2) (non blocker) Patch keeps(?) a CGI::scrolling_list instance - could be in
conflict with one of Bernardo's patches there:
additem.pl:
$subfield_data{marc_value} =CGI::scrolling_list(@scrparam);

3) (non blocker) Database updates could be merged.

3) Suggestion: should we squash the patches (maybe 1-9 + )? Because the
permissions got renamed and some other things that could avoid some confusion. 

Also an updated summary of the changes and a test plan would be great.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #83 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Some Minor comments to start the ball rolling.. Nothing fail worthy so far.

1. Z3950 references in the staff client. There are references to Z3950 in a
number of places in the staff client, for instance admin-home where we go to
configure z3950 targets should make it clear that we're now configuruing z3950
OR sru.. and 'Add new from z3950' under cataloguing should also be updated. 
Perhaps 'New from external database' or similar?
2. 'Database' on the 'Add Server' page is a required field, but it's also not
obviose what it expects
3. I'de like a more visual queue somewhere in the Add SRU server page that one
really aught to define the 'SRU Search fields mappings' else all searches will
be against the 'any' index on the remote server.  Maybe this is a documentation
thing.  Either a stronger hint to fill that stuff in.. or to drop the index
specific search boxes in the 'Add from ' popup when the sru server is
selected.. Hard call really.. we want people to map them to get sensible
results really.  Maybe set some sensible defaults and make it a required field?

Back to testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #84 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
poo.. worng bug for the above comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC|fridolyn.som...@biblibre.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #71 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am sorry, there is a conflict in additem.pl - I fixed it, but then can't get
some of the later patches to apply :(

Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Bug 7673: Update syspref names in script
fatal: sha1 information is lacking or useless (cataloguing/additem.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 7673: Update syspref names in script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #70 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29550
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29550action=edit
Bug 7673: DB changes - (follow-up) Add permissions

Add permissions for ru-RU and uk-UA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #69 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I fixed the conflicts, but don't want to make too many changes and maybe
mistakes. One of the tests fails:

#   Failed test 'No user permissions to add'
#   at xt/permissions.t line 95.
# User permissions to add in uk-UA/mandatory/permissions_and_user_flags.sql:
delete_all_items, edit_items_restricted, items_batchmod_restricted

#   Failed test 'No user permissions to add'
#   at xt/permissions.t line 95.
# User permissions to add in ru-RU/mandatory/permissions_and_user_flags.sql:
delete_all_items, edit_items_restricted, items_batchmod_restricted
# Looks like you failed 2 tests of 34.

Could you take a look Jonathan?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Heather Braum hbr...@nekls.org changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27631|0   |1
is obsolete||

--- Comment #59 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28007
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28007action=edit
Bug 7673 : New patron permissions

This patch adds the following permissions:

 - editcatalogue.limited_item_edition: Limit item modification to barcode,
status and note
 - editcatalogue.delete_all_items: Delete all items at once
 - tools.items_limited_batchmod: Limit batch item modification to item
status

The SubfieldsToAllowForLimitedEdition syspref is used to define which
subfields can be edited
when the editcatalogue.limited_item_edition permission is enabled.

In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define
which subfields
can be edited when the tools.items_limited_batchmod permission is enabled.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27632|0   |1
is obsolete||

--- Comment #60 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28008
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28008action=edit
Bug 7673: QA Followup: trailing whitespace and perlcritic issues

This patch fixes the following qa issues:

 FAIL   cataloguing/additem.pl
   FAIL   forbidden patterns
forbidden pattern: trailing space char (line 833)
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 2 violation(s).

 FAIL   tools/batchMod.pl
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 2 violation(s).

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27633|0   |1
is obsolete||

--- Comment #61 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28009
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28009action=edit
Bug 7673: The delete all items link should only be displayed if
delete_all_items is set

This test had been lost in a rebase.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27634|0   |1
is obsolete||

--- Comment #62 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28010
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28010action=edit
Bug 7673: the limitation on editing an item does not affect FA framework

The pref SubfieldsToAllowForLimitedEdition should not affect Fast
cataloguing framework (FA).

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #68 from Jonathan Druart jonathan.dru...@biblibre.com ---
I added the Koha Team AMU' signoff to the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27638|0   |1
is obsolete||

--- Comment #65 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28013
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28013action=edit
Bug 7673: Update permission names in script

Two permission names have been changed since the first patch.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27637|0   |1
is obsolete||

--- Comment #64 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28012
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28012action=edit
Bug 7673: DB changes - Add permissions

This patch adds 3 permissions:
- edit_items_restricted
- delete_all_items
- items_batchmod_restricted

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27641|0   |1
is obsolete||

--- Comment #67 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28015
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28015action=edit
Bug 7673: DB Changes - add system preferences

This patch the 2 system preferences SubfieldsToAllowForRestrictedEdition
and SubfieldsToAllowForRestrictedBatchmod.

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27640|0   |1
is obsolete||

--- Comment #66 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28014
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28014action=edit
Bug 7673: Change the superlibrarian check

To know if the user is a superlibrarian, we have to call
C4::Context-IsSuperLibrarian

Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Koha Team AMU koha.aixmarsei...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #58 from Koha Team AMU koha.aixmarsei...@gmail.com ---
I just test this part of the patch.

1/ delete_all-items : ok

2/ New test with these permissions:

- edit catalogue:
edit_catalogue Edit catalogue
edit_items Editer les exemplaires
fast_cataloging Fast cataloging
edit_items_restricted Limit item modification to barcode, status and note

- tools :
items_batchmod Perform batch modification of items
items_limited_batchmod resctricted : limit item modification to item status 

- sysprefs :
SubfieldsToAllowForRestrictedEdition : 995$f 995$o 995$u
SubfieldsToAllowForRestrictedBatchmod : 995 $o

test's result :

- ok : the modification of items is retricted to the subfilds definied in these
2 sysprefs.

- ok : The modification of all subfields of an item of a fast cataloging is ok.
The framework fast cataloging is not concerned by
SubfieldsToAllowForRestrictedEdition

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26008|0   |1
is obsolete||
  Attachment #26009|0   |1
is obsolete||
  Attachment #26704|0   |1
is obsolete||
  Attachment #26705|0   |1
is obsolete||
  Attachment #26722|0   |1
is obsolete||

--- Comment #47 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27631
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27631action=edit
Bug 7673 : New patron permissions

This patch adds the following permissions:

 - editcatalogue.limited_item_edition: Limit item modification to barcode,
status and note
 - editcatalogue.delete_all_items: Delete all items at once
 - tools.items_limited_batchmod: Limit batch item modification to item
status

The SubfieldsToAllowForLimitedEdition syspref is used to define which
subfields can be edited
when the editcatalogue.limited_item_edition permission is enabled.

In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define
which subfields
can be edited when the tools.items_limited_batchmod permission is enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #48 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27632
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27632action=edit
Bug 7673: QA Followup: trailing whitespace and perlcritic issues

This patch fixes the following qa issues:

 FAIL   cataloguing/additem.pl
   FAIL   forbidden patterns
forbidden pattern: trailing space char (line 833)
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 2 violation(s).

 FAIL   tools/batchMod.pl
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 2 violation(s).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #49 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27633
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27633action=edit
Bug 7673: The delete all items link should only be displayed if
delete_all_items is set

This test had been lost in a rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #53 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27637
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27637action=edit
Bug 7673: DB changes - Add permissions

This patch adds 3 permissions:
- edit_items_restricted
- delete_all_items
- items_batchmod_restricted

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #52 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27636
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27636action=edit
Bug 7673: Update syspref names in script

The both syspref names have been changed since the first patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #54 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27638
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27638action=edit
Bug 7673: Update permission names in script

Two permission names have been changed since the first patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #50 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27634
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27634action=edit
Bug 7673: the limitation on editing an item does not affect FA framework

The pref SubfieldsToAllowForLimitedEdition should not affect Fast
cataloguing framework (FA).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #51 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27635
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27635action=edit
Bug 7673: DB Changes - add system preferences

This patch the 2 system preferences SubfieldsToAllowForRestrictedEdition
and SubfieldsToAllowForRestrictedBatchmod.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #55 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27640
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27640action=edit
Bug 7673: Change the superlibrarian check

To know if the user is a superlibrarian, we have to call
C4::Context-IsSuperLibrarian

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27635|0   |1
is obsolete||

--- Comment #56 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27641
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27641action=edit
Bug 7673: DB Changes - add system preferences

This patch the 2 system preferences SubfieldsToAllowForRestrictedEdition
and SubfieldsToAllowForRestrictedBatchmod.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #57 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #42)

 1) I wonder about the names of the new permissions.
I think a limited edition would be something different - maybe we
can get a native speaker's opinion on this?

Done.


 2) Please include all .sql permission files, so new installations won't 
miss them. You can check with xt/permissions.t

Done.


 3) Fix sequence of system preferences

Done.

 4) If we are going to rewrite this bit of code, it would be good to 
remove the use of CGI::scrolling_list (bug 766):
 +$subfield_data{marc_value} =CGI::scrolling_list(@scrparam);

It will be done when bug 766 will be pushed.

 5) System preference description could be more clear. It should note that
the FA framework is excluded from the permission. Also it could include
a hint that the example is for UNIMARC and also include a MARC21 example
to avoid confusion. For us developers it's clear that we use different
item fields for both flavours, but not so much for librarians I guess.

Done.

 6) I have my doubts about the superlibrarian checks you used:
  $limitededition-{'superlibrarian'} eq 1);
 +$limitededition = 0 if ($limitededition != 0 
 $limitededition-{'superlibrarian'} eq 1);
We now have a specific method to check those:
 C4::Context::IsSuperLibrarian()

Done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Assignee|matthias.meusburger@biblibr |jonathan.dru...@biblibre.co
   |e.com   |m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #42 from Katrin Fischer katrin.fisc...@bsz-bw.de ---

Hi Julian,

I did some initial testing and code review:

1) I wonder about the names of the new permissions.
   I think a limited edition would be something different - maybe we
   can get a native speaker's opinion on this?
   My suggestion would be:
   - limited_item_edition = restricted_edit_items
   - items_limited_batchmod = restricted_item_batchmod

2) Please include all .sql permission files, so new installations won't 
   miss them. You can check with xt/permissions.t

3) Fix sequence of system preferences
 FAIL   installer/data/mysql/sysprefs.sql
   FAIL   sysprefs_order
Not blocker: Sysprefs SubfieldsToAllowForLimitedBatchmod 
is bad placed (see bug 10610)

4) If we are going to rewrite this bit of code, it would be good to 
   remove the use of CGI::scrolling_list (bug 766):
+$subfield_data{marc_value} =CGI::scrolling_list(@scrparam);

5) System preference description could be more clear. It should note that
   the FA framework is excluded from the permission. Also it could include
   a hint that the example is for UNIMARC and also include a MARC21 example
   to avoid confusion. For us developers it's clear that we use different
   item fields for both flavours, but not so much for librarians I guess.

6) I have my doubts about the superlibrarian checks you used:
 $limitededition-{'superlibrarian'} eq 1);
+$limitededition = 0 if ($limitededition != 0 
$limitededition-{'superlibrarian'} eq 1);
   We now have a specific method to check those:
C4::Context::IsSuperLibrarian()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 QA Contact|koha.sek...@gmail.com   |testo...@bugs.koha-communit
   ||y.org

--- Comment #43 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Sorry, I missed that this patch is from Matthias... and Jonathan?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #44 from Kyle M Hall k...@bywatersolutions.com ---
 1) I wonder about the names of the new permissions.
I think a limited edition would be something different - maybe we
can get a native speaker's opinion on this?
My suggestion would be:
- limited_item_edition = restricted_edit_items
- items_limited_batchmod = restricted_item_batchmod

I agree with Katrin on this. 

I would suggest limited_item_edition = edit_items_restricted so that it stays
right near edit_items on the permissions screen.

I would also suggest items_limited_batchmod = item_batchmod_restricted in case
item_batchmod becomes a permission, which I'm sure it will in the future.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #45 from Kyle M Hall k...@bywatersolutions.com ---
 I would also suggest items_limited_batchmod = item_batchmod_restricted in
 case item_batchmod becomes a permission, which I'm sure it will in the
 future.

Correction item_batchmod *is* a permission now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #46 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Kyle's suggestions sound good to me - valid point about the sorting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 26722
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26722action=edit
Bug 7673: the limitation on editing an item does not affect FA framework

The pref SubfieldsToAllowForLimitedEdition should not affect Fast
cataloguing framework (FA).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Koha Team AMU koha.aixmarsei...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #41 from Koha Team AMU koha.aixmarsei...@gmail.com ---
 - The pref SubfieldsToAllowForLimitedEdition should not affect Fast
cataloguing framework (FA) : ok the framework FA is exclued

- The delete_all_items is ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/