[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2017-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17277


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277
[Bug 17277] Current Location column in Holdings table showing empty under OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2016-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Blou  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15636

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2015-02-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||m...@kohaaloha.com
   Keywords|rel_3_16_candidate  |

--- Comment #69 from Mason James m...@kohaaloha.com ---
(In reply to Galen Charlton from comment #68)
 Pushed to master, along with follow-ups.  Thanks, Kyle!

Enhancement, skipping patch for 3.16.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2014-05-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
   Severity|minor   |enhancement

--- Comment #68 from Galen Charlton gmcha...@gmail.com ---
Pushed to master, along with follow-ups.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2014-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #22155|0   |1
is obsolete||

--- Comment #64 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28172
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28172action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Comment: Work as described. Tested all variations.
No koha-qa errors.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2014-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #22156|0   |1
is obsolete||

--- Comment #65 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28173
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28173action=edit
Bug 7720 - Ambiguity in OPAC Details location - QA Followup

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2014-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #66 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28175
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28175action=edit
Bug 7720 [QA Followup] - Update Bootstrap theme

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2014-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #67 from Kyle M Hall k...@bywatersolutions.com ---
Setting to Passed QA since the bootstrap followup appears to be the only
blocker for this. I've tested every combination of the system preferences for
the bootstrap followup, and it looks good!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||gmcha...@gmail.com

--- Comment #63 from Galen Charlton gmcha...@gmail.com ---
This needs a Bootstrap follow-up, and unfortunately that looks to be
non-trivial.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2014-04-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   Keywords||rel_3_16_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-10-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #21375|0   |1
is obsolete||

--- Comment #61 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22156
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22156action=edit
Bug 7720 - Ambiguity in OPAC Details location - QA Followup

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-10-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #21374|0   |1
is obsolete||

--- Comment #60 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22155
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22155action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Comment: Work as described. Tested all variations.
No koha-qa errors.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-10-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact||m.de.r...@rijksmuseum.nl

--- Comment #62 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Works as described. Code looks good to me. 
Passed QA

Just a few side-notes:
Can we prevent constructions like 
[% IF ( Branches.GetURL( ITEM_RESULT.homebranch ) ) %]
a href=[% Branches.GetURL( ITEM_RESULT.homebranch ) %][%
Branches.GetName( ITEM_RESULT.homebranch ) %]/a
making repeated calls to same function?

The code for showing shelf loc also relies heavily on having 1) the shelf loc
obviously, 2) having auth val LOC on that field and 3) in that particular
framework. I had something in location, but it would not show up until I
realized that the biblio was in another framework :)

GetURL includes a statement:
 return encode( 'UTF-8', $b-{'branchurl'} );
It works, but (outside the scope of this report) it would be even better if we
should not need them at that spot. Referring further to encoding
problems/discussions..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-09-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19658|0   |1
is obsolete||

--- Comment #58 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 21374
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21374action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Comment: Work as described. Tested all variations.
No koha-qa errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-09-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20217|0   |1
is obsolete||

--- Comment #59 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 21375
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21375action=edit
Bug 7720 - Ambiguity in OPAC Details location - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-09-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-09-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-09-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-09-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #57 from Jonathan Druart jonathan.dru...@biblibre.com ---
Kyle, first patch does not apply cleanly (conflicts in opac-detail.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-08-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-08-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #56 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20217
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20217action=edit
Bug 7720 - Ambiguity in OPAC Details location - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #55 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

Kyle, could you provide a version of this patch using the branches template
plugin? Like that, I think you could delete the sql query in
C4::Items::GetItemsInfo.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-07-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-07-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18622|0   |1
is obsolete||

--- Comment #54 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19658
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19658action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Comment: Work as described. Tested all variations.
No koha-qa errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-07-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 QA Contact|koha.sek...@gmail.com   |

--- Comment #53 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Kyle, could you take a look at the conflicts please and submit a new rebased
patch?

Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Bug 7720 - Ambiguity in OPAC Details location.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Failed to merge in the changes.
Patch failed at 0001 Bug 7720 - Ambiguity in OPAC Details location.
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-06-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-06-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-06-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15247|0   |1
is obsolete||

--- Comment #52 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18622
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18622action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Comment: Work as described. Tested all variations.
No koha-qa errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-05-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||ch...@bigballofwax.co.nz

--- Comment #51 from Chris Cormack ch...@bigballofwax.co.nz ---
#   both modified:  installer/data/mysql/sysprefs.sql
#   both modified:  installer/data/mysql/updatedatabase.pl
#   both modified:  koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt

Patch doesn't apply cleanly, I could fix the first 2 files, but unsure on the
3rd one, Kyle can you rebase and set back to signed off please

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-02-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15237|0   |1
is obsolete||

--- Comment #48 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15238
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15238action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

http://bugs.koha-community.org/show_bug.cgi?id=7220

http://bugs.koha-community.org/show_bug.cgi?id=3556

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-02-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15238|0   |1
is obsolete||

--- Comment #49 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15241
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15241action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-02-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-02-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #15241|0   |1
is obsolete||

--- Comment #50 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 15247
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15247action=edit
[SIGNED-OFF] Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Comment: Work as described. Tested all variations.
No koha-qa errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-02-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2013-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #46 from Owen Leonard oleon...@myacpl.org ---
This patch no longer applies.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-11-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #43 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Please look at: 
--- a/installer/data/mysql/sysprefs.sql
+++ b/installer/data/mysql/sysprefs.sql
+ HEAD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-11-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12389|0   |1
is obsolete||

--- Comment #44 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 13466
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13466action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

http://bugs.koha-community.org/show_bug.cgi?id=7220

http://bugs.koha-community.org/show_bug.cgi?id=3556

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-11-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #45 from Kyle M Hall k...@bywatersolutions.com ---
Fixed!

(In reply to comment #43)
 Please look at: 
 --- a/installer/data/mysql/sysprefs.sql
 +++ b/installer/data/mysql/sysprefs.sql
 + HEAD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-09-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11092|0   |1
is obsolete||

--- Comment #41 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12389
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12389action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

http://bugs.koha-community.org/show_bug.cgi?id=7220

http://bugs.koha-community.org/show_bug.cgi?id=3556

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-09-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #42 from Kyle M Hall k...@bywatersolutions.com ---
 - The column of item-level holds is not displayed. Even in cases where there
 is an item-level hold the column is empty.

I'm not sure what you are referring to here. Could you post an before/after
screenshot?

 - The patch violates capitalization guidelines (Bug 2780) (Current
 location and Home Library).

Fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-09-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-08-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #40 from Owen Leonard oleon...@myacpl.org ---
Tested these conditions:

OpacLocationBranchToDisplay = holding library
OpacLocationBranchToDisplayShelving  = holding library

- Only holding library displays, shelving location is shown

OpacLocationBranchToDisplay = holding library
OpacLocationBranchToDisplayShelving  = home and holding library

- Only holding library displays, shelving location is shown (same as previous)

OpacLocationBranchToDisplay = holding library
OpacLocationBranchToDisplayShelving  = home library

- Only holding library displays, shelving location is not shown

OpacLocationBranchToDisplay = home library
OpacLocationBranchToDisplayShelving  = holding library

- Only home library displays, shelving location is not shown

OpacLocationBranchToDisplay = home library
OpacLocationBranchToDisplayShelving  = home and holding library

- Only home library displays, shelving location is shown

OpacLocationBranchToDisplay = home library
OpacLocationBranchToDisplayShelving  = home library

- Only home library displays, shelving location is shown (same as previous)

OpacLocationBranchToDisplay = home and holding library
OpacLocationBranchToDisplayShelving  = holding library

- Home and holding libraries display, shelving location shown with holding

OpacLocationBranchToDisplay = home and holding library
OpacLocationBranchToDisplayShelving  = home and holding library

- Home and holding libraries display, shelving location shown with both

OpacLocationBranchToDisplay = home and holding library
OpacLocationBranchToDisplayShelving  = home library

- Home and holding libraries display, shelving location shown with home

Functionally this seems to be working as expected. There are a couple of
peripheral issues which need to be corrected:

- The column of item-level holds is not displayed. Even in cases where there is
an item-level hold the column is empty.

- The patch violates capitalization guidelines (Bug 2780) (Current location
and Home Library).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 CC||me...@bywatersolutions.com

--- Comment #39 from Melia Meggs me...@bywatersolutions.com ---
I think Kyle forgot to change the status... Changing status to needs signoff
for the new patch from 7/23.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #10149|0   |1
is obsolete||

--- Comment #37 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11091
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11091action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

http://bugs.koha-community.org/show_bug.cgi?id=7220

http://bugs.koha-community.org/show_bug.cgi?id=3556

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11091|0   |1
is obsolete||

--- Comment #38 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11092
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11092action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

http://bugs.koha-community.org/show_bug.cgi?id=7220

http://bugs.koha-community.org/show_bug.cgi?id=3556

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-07-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #36 from Owen Leonard oleon...@myacpl.org ---
This needs to be rebased. Also looks like there's a conflict marker somewhere?

+ HEAD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-06-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #9762|0   |1
is obsolete||

--- Comment #35 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 10149
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10149action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

http://bugs.koha-community.org/show_bug.cgi?id=7220

http://bugs.koha-community.org/show_bug.cgi?id=3556

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-06-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-06-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Francois Charbonnier francois.charbonn...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||francois.charbonnier@biblib
   ||re.com

--- Comment #34 from Francois Charbonnier francois.charbonn...@biblibre.com 
---
Patch doesn't apply :

Bug 7720 - Ambiguity in OPAC Details location.
Apply? [yn] y

Applying: Bug 7720 - Ambiguity in OPAC Details location.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Items.pm
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Auto-merging opac/opac-detail.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 7720 - Ambiguity in OPAC Details location.
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.
Patch left in /tmp/Bug-7720---Ambiguity-in-OPAC-Details-location-CmCdA1.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-06-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Francois Charbonnier francois.charbonn...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

delaye stephane.del...@biblibre.com changed:

   What|Removed |Added

 CC||stephane.del...@biblibre.co
   ||m

--- Comment #31 from delaye stephane.del...@biblibre.com ---
i try to apply this patch in a sandbox but i don't see the sys pref 
OpacLocationBranchToDisplay and OpacLocationBranchToDisplayShelving in my koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #9570|0   |1
is obsolete||

--- Comment #32 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 9762
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9762action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

http://bugs.koha-community.org/show_bug.cgi?id=7220

http://bugs.koha-community.org/show_bug.cgi?id=3556

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #33 from Kyle M Hall kyle.m.h...@gmail.com ---
The previous iteration of this patch ahd $DBversion = 3.07.00.XXX in
updatedatabase.pl, and thus the update was being skipped over. This new one
should work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8878|0   |1
is obsolete||

--- Comment #30 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 9570
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9570action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

http://bugs.koha-community.org/show_bug.cgi?id=7220

http://bugs.koha-community.org/show_bug.cgi?id=3556

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-05-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Liz Rea wizzy...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||wizzy...@gmail.com

--- Comment #29 from Liz Rea wizzy...@gmail.com ---
Patch will not apply - 

Falling back to patching base and 3-way merge...
Auto-merging opac/opac-detail.pl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging C4/Items.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 7720 - Ambiguity in OPAC Details location.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-04-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8825|0   |1
is obsolete||

--- Comment #27 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8868
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8868action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds the system preference OpacLocationBranchToDisplay which
allows a library to control whether to display the holding library,
the home library, or both for the opac details page.

http://bugs.koha-community.org/show_bug.cgi?id=7220

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-04-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8868|0   |1
is obsolete||

--- Comment #28 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8878
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8878action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

http://bugs.koha-community.org/show_bug.cgi?id=7220

http://bugs.koha-community.org/show_bug.cgi?id=3556

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-04-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8230|0   |1
is obsolete||
   Attachment #8245|0   |1
is obsolete||

--- Comment #26 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8825
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8825action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds the system preference OpacLocationBranchToDisplay which
allows a library to control whether to display the holding library,
the home library, or both for the opac details page.

http://bugs.koha-community.org/show_bug.cgi?id=7220

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-04-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comments: 

The patch does not apply on the current master.

Moreover, there is a lot of tabulation characters in your patch (in
opac-detail.tt). Please replace them with 4 spaces.

Marked as Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #8 from Nicole C. Engard neng...@gmail.com ---
Created attachment 8223
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8223action=edit
new screenshot of clearer display

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Attachment #8223|0   |1
is obsolete||

--- Comment #9 from Nicole C. Engard neng...@gmail.com ---
Created attachment 8224
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8224action=edit
new screenshot of clearer display

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8216|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8226
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8226action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |kyle.m.h...@gmail.com

--- Comment #12 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8229
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8229action=edit
Screenshot of OPAC with new columns.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Attachment #8226|0   |1
is obsolete||

--- Comment #13 from Nicole C. Engard neng...@gmail.com ---
Created attachment 8230
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8230action=edit
[SIGNED-OFF] Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

Searched in the OPAC and checked the details page for several titles.
All tests passed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #14 from Nicole C. Engard neng...@gmail.com ---
Much clearer. Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Nora Blake nbl...@masslibsystem.org changed:

   What|Removed |Added

 CC||nbl...@masslibsystem.org

--- Comment #15 from Nora Blake nbl...@masslibsystem.org ---
Hi All,

We're the ones that raised this issue and Kyle kindly created a first shot at a
fix.

We would rather just have the owning library listed in the OPAC and then list
it's availability status as the system does now.  So if the item is loaned from
Library A to Library B, it is still showing as owned by Library A, but checked
out or in transit or whatever stage of the hold fulfillment process it is
in.

It doesn't seem necessary to us to muddy the waters in the OPAC with the level
of detail of this is owned by Library A but being used by Library B right
now.  We can get that level of information from the staff side with the
Current Location and Home Library columns.  That seems like enough.

What we're finding is that patrons at our member libraries are getting confused
with the current display.  They're thinking that their library doesn't own an
item because it displays as having a 'current location' of another library when
it has been loaned to another library in the consortium.  So the patrons are
thinking that the library doesn't own the title and the libraries can come off
as looking bad, why don't we own a copy of 'The Help?' 

I have no idea if this is helpful, but we'd rather see the owning library as
the only library information listed in the OPAC.  We think providing the
current location information in the OPAC only makes for misinformation and
confusion with patrons.

Thanks,

Nora Blake
MassCat

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #16 from Nicole C. Engard neng...@gmail.com ---
Future enhancement idea for this - make it so that single branch systems can
hide the home library column in staff and opac :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #17 from Nicole C. Engard neng...@gmail.com ---
(In reply to comment #15)
 I have no idea if this is helpful, but we'd rather see the owning library as
 the only library information listed in the OPAC.  We think providing the
 current location information in the OPAC only makes for misinformation and
 confusion with patrons.


I don't think this is possible because so many libraries using Koha have had it
this way forever and so they're used to seeing the holding branch. They have
trained their patrons to know what they're seeing. I don't think we should
switch the view without a system preference to let the library choose. This way
at least lets you see what you want and the other libraries see what they want.

PS. I comment before this was written while you were writing yours :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #18 from Nora Blake nbl...@masslibsystem.org ---
So then what about a system pref that would allow libraries to choose to
display only owning library or holding library info?

Nora Blake
MassCat

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #19 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8237
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8237action=edit
Bug 7720 - Ambiguity in OPAC Details location - Followup - Add System
Preference

This commit adds the system preference OpacLocationBranchToDisplay which
allows a library to control whether to display the holding library,
the home library, or both for the opac details page.

http://bugs.koha-community.org/show_bug.cgi?id=7220

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8237|0   |1
is obsolete||

--- Comment #20 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8238
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8238action=edit
Bug 7720 - Ambiguity in OPAC Details location - Followup - Add System
Preference

This commit adds the system preference OpacLocationBranchToDisplay which
allows a library to control whether to display the holding library,
the home library, or both for the opac details page.

http://bugs.koha-community.org/show_bug.cgi?id=7220

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8238|0   |1
is obsolete||

--- Comment #22 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8243
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8243action=edit
Bug 7720 - Ambiguity in OPAC Details location - Followup - Add System
Preference

This commit adds the system preference OpacLocationBranchToDisplay which
allows a library to control whether to display the holding library,
the home library, or both for the opac details page.

http://bugs.koha-community.org/show_bug.cgi?id=7220

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #23 from Kyle M Hall kyle.m.h...@gmail.com ---
The new patch is a followup, so it will need to be applied on top of the
previous patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Attachment #8243|0   |1
is obsolete||

--- Comment #24 from Nicole C. Engard neng...@gmail.com ---
Created attachment 8245
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8245action=edit
[SIGNED-OFF] Bug 7720 - Ambiguity in OPAC Details location - Followup - Add
System Preference

This commit adds the system preference OpacLocationBranchToDisplay which
allows a library to control whether to display the holding library,
the home library, or both for the opac details page.

http://bugs.koha-community.org/show_bug.cgi?id=7220
Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com
tested preference with all values and it works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 8215
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8215action=edit
Screenshot showing updated interface

I agree that the current display is ambiguous. When we originally designed it
this way the goal was simplicity for the sake of patron-friendliness: Why show
the user information about where the item *isn't*? But it's obviously more
complicated than that for a lot of libraries and users.

I think a solution is needed but I'm not sure this is it. I find this a little
bit hard for my eye to scan. Is the patron going to understand what owned by
means in this context?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #3 from Ian Walls koha.sek...@gmail.com ---
Do we actually have any data collected from patrons about the usability of
these terms and layout, or are we just guessing?  I agree that it can be
confusing to have two libraries listed, as the item can only be one place at a
time, but I'd recommend we get some kind of hard data first before we go and
make this kind of change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think perhaps this is something we will need some configuraton options for. I
can imagine that for different library system different things can make sense. 
I would guess the patron wants to know where he can find the item. If we show
owning library and the library uses floating collections, so the item stays at
the library where it was last borrowed, the owning library will not be
interesting for the patron. If the book is always transfered back to the owning
library after filling a hold at another branch, it might only confuse the
patron to see where the item is right now. I think showing 2 branches only
makes sense under certain circumstances and not sure it will be confusing for
the patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #8213|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 8216
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8216action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

In the event that an item's homebranch and holding branch differ,
this commit will add an Owned by for the homebranch directly
below the current location branch. This also solves the shelving
location ambiguity, as the shelving location will now always
be below the library where the item's shelving location is used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-03-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

--- Comment #7 from Kyle M Hall kyle.m.h...@gmail.com ---
Just an fyi, but I've now had multiple libraries complain about the current
presentation of the location. I think this is a real usability issue that needs
to be addressed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/