[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 --- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #11) there are valid/legitimate situations both for production and dev/testing usage, where people may want to load a newer db onto an older Koha codebase. no problem. Hope that those people know what they are doing :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 17188 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17188action=edit Bug 7853 - opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding Signed-off-by: Owen Leonard oleon...@myacpl.org Works exactly as it should according to the test plan. This is a nice improvement. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Amended patch: Check OpacMaintenance! Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #17160|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA CC||m.de.r...@rijksmuseum.nl QA Contact||m.de.r...@rijksmuseum.nl --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: Not really anything to say. Nice patch. Now I just need to refresh and come back to opac as soon as maintenance finished. Just for the record and a formality: Jonathan, I would have preferred a followup adding the necessary OpacMaintenance test. (Have amended in the past too much too :) And if somebody likes to add a followup.. Why not say that kohaversion must be koha_db_version? In the very exceptional case that kohaversion=3.10 and db version= 3.12, something goes wrong. Wouldn't that be safe to go to maintenance as well? Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 --- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #9) And if somebody likes to add a followup.. Why not say that kohaversion must be koha_db_version? In the very exceptional case that kohaversion=3.10 and db version= 3.12, something goes wrong. Wouldn't that be safe to go to maintenance as well? Added note: I changed this in the code when testing. It is a different thing coming there.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 --- Comment #11 from Mason James m...@kohaaloha.com --- (In reply to comment #10) (In reply to comment #9) And if somebody likes to add a followup.. Why not say that kohaversion must be koha_db_version? In the very exceptional case that kohaversion=3.10 and db version= 3.12, something goes wrong. Wouldn't that be safe to go to maintenance as well? Added note: I changed this in the code when testing. It is a different thing coming there.. hmmm, a good question Marcel, but i think this is a bad idea... there are valid/legitimate situations both for production and dev/testing usage, where people may want to load a newer db onto an older Koha codebase. your proposed change would stop this from happening -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 --- Comment #12 from Mason James m...@kohaaloha.com --- (In reply to comment #5) QA comment: A use case is not supported: I am going to make a maintenance operation on a server, I switch on the syspref OpacMaintenance. opac-main redirects on opac-maintenance and opac-maintenance redirects to opac-main :) thanks for spotting this Jonathan, and the patch too :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m Assignee|gmcha...@gmail.com |m...@kohaaloha.com --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: A use case is not supported: I am going to make a maintenance operation on a server, I switch on the syspref OpacMaintenance. opac-main redirects on opac-maintenance and opac-maintenance redirects to opac-main :) Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- The fix is easy, I will provide a new patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #17131|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 17160 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17160action=edit Bug 7853 - opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding Signed-off-by: Owen Leonard oleon...@myacpl.org Works exactly as it should according to the test plan. This is a nice improvement. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Amended patch: Check OpacMaintenance! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 --- Comment #2 from Mason James m...@kohaaloha.com --- Created attachment 17112 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17112action=edit Bug 7853 - opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #3 from Mason James m...@kohaaloha.com --- (In reply to comment #2) Created attachment 17112 [details] [review] Bug 7853 - opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding to test, before patch is applied… 1/ edit your 'version' syspref and make your version just less that it currently is so from 3.1200202 to to 3.1200201, (your version number may be differnt to mine) 2/ load your OPAC url in a browser, you should be redirected to the 'OPAC maintenance' page (leave this window/tab open) 3/ change your version syspref back to the original number 4/ reload your 'OPAC maintenance' page, it should *not* return to OPAC page (fyi, this is the bug) 5/ apply patch 6/ repeat steps 1 thru 3 7/ reload your 'OPAC maintenance' page, it should now redirect to the OPAC page ( bug is now fixed) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #17112|0 |1 is obsolete|| --- Comment #4 from Owen Leonard oleon...@myacpl.org --- Created attachment 17131 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17131action=edit [SIGNED-OFF] Bug 7853 - opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding Signed-off-by: Owen Leonard oleon...@myacpl.org Works exactly as it should according to the test plan. This is a nice improvement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Component|OPAC|Architecture, internals, ||and plumbing Assignee|oleon...@myacpl.org |gmcha...@gmail.com QA Contact|koha.sek...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853 --- Comment #1 from Mason James m...@kohaaloha.com --- (In reply to comment #0) opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding because of this bug, it's possible for the system to appear unavailable after an update, when it is actually available a redirect from opac-maintance.pl would fix this problem :) oops, i speld 'maintenance' worng 3 times... :p -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
