[Koha-bugs] [Bug 20586] New: Infinite loop creation of issues when using multi receive or generate next serial
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20586 Bug ID: 20586 Summary: Infinite loop creation of issues when using multi receive or generate next serial Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: mbu...@yahoo.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com When using either "Multi receiving" or "Generate next", the result is Server error 500. Normal receving of 1 issue works. 10 or more issues are created (not checking what number I enter in the choice of how many I want to multi receive). Error in error.log [Mon Apr 16 08:54:27.438449 2018] [core:error] [pid 2776] [client 127.0.0.1:42792] AH00124: Request exceeded the limit of 10 internal redirects due to probable configuration error. Use 'LimitInternalRecursion' to increase the limit if necessary. Use 'LogLevel debug' to get a backtrace., referer: https://koha-1.lub.lu.se:8443/cgi-bin/koha/serials/serials-edit.pl?subscriptionid=4162282&serstatus=1,3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Depends on||7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwood changed: What|Removed |Added Blocks||20556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20556 [Bug 20556] Marking ILL request as complete results in "Internal server error" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwood changed: What|Removed |Added Blocks||20548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 [Bug 20548] Remove copyright clearance workflow from staff created ILL requests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood changed: What|Removed |Added Depends on||7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20556] Marking ILL request as complete results in "Internal server error"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20556 Andrew Isherwood changed: What|Removed |Added Depends on||7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwood changed: What|Removed |Added Blocks||20581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 [Bug 20581] Allow manual selection of custom ILL request statuses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwood changed: What|Removed |Added Blocks||20563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 [Bug 20563] ILL request list gives no indication of source and/or target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Andrew Isherwood changed: What|Removed |Added Depends on||7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application (?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #3 from Julian Maurice --- (In reply to Katrin Fischer from comment #2) > Hi Julian, a bit over my head here, but sounds like something that should go > on the mailing list or the next dev meeting agenda too. I wanted to but didn't have the time. I will try to write something later today -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #74014|0 |1 is obsolete|| --- Comment #212 from Martin Renvoize --- Created attachment 74201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74201&action=edit Bug 11897: (QA follow-up) Implement review feedback. - Update Table declarations - Add permissions checks - Remove unused code - Fix language & naming - Make templates translation friendly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #74012|0 |1 is obsolete|| --- Comment #210 from Martin Renvoize --- Created attachment 74199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74199&action=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #74013|0 |1 is obsolete|| --- Comment #211 from Martin Renvoize --- Created attachment 74200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74200&action=edit Bug 11897: Add bulk of Stockrotation module. This commit replaces a set of about 20 commits into one large commit. This makes working with the module way easier from bugzilla. As it stands the patches on this bug provide a fully functioning stock rotation feature set for Koha. All previous patches that added functionality were signed off, so I'm retaining that flag. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #74010|0 |1 is obsolete|| --- Comment #208 from Martin Renvoize --- Created attachment 74197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74197&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #74011|0 |1 is obsolete|| --- Comment #209 from Martin Renvoize --- Created attachment 74198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74198&action=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #74015|0 |1 is obsolete|| --- Comment #213 from Martin Renvoize --- Created attachment 74202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74202&action=edit Bug 11897: (follow-up) Fix rebasing issue with templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #74016|0 |1 is obsolete|| --- Comment #214 from Martin Renvoize --- Created attachment 74203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74203&action=edit Bug 11897: (QA follow-up) Fix Koha/Libraries test - merge issues corrected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #217 from Martin Renvoize --- Created attachment 74206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74206&action=edit Bug 11897: (QA follow-up) Add default notice template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #74017|0 |1 is obsolete|| --- Comment #215 from Martin Renvoize --- Created attachment 74204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74204&action=edit Bug 11897: (QA follow-up) Fix POD failures - add empty pod blocks for internal object_class methods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #216 from Martin Renvoize --- Created attachment 74205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74205&action=edit Bug 11897: (QA follow-up) Convert cronscript to use notices The cronscript originally used Koha::Email directly, this patch converts it to us the C4::Letters routines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Attachment #72721|0 |1 is obsolete|| --- Comment #99 from Julian Maurice --- Created attachment 74208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74208&action=edit Bug 12395: Add unit test to check created_by is correctly set Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Attachment #72722|0 |1 is obsolete|| --- Comment #100 from Julian Maurice --- Created attachment 74209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74209&action=edit Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, "no name" was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Attachment #72720|0 |1 is obsolete|| --- Comment #98 from Julian Maurice --- Created attachment 74207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74207&action=edit Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on "Order" link in column "More" (previously "View record") 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on "Receive" link 6/ Your name should appear in front of "Created by" label, to the right of the page. Patch updated with use of atomic update. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Attachment #72723|0 |1 is obsolete|| --- Comment #101 from Julian Maurice --- Created attachment 74210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74210&action=edit Bug 12395: Make received orders table consistent with pending orders table (links of More column) Also change "Created by" with "Ordered by" in receive page. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #104 from Julian Maurice --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Attachment #72724|0 |1 is obsolete|| --- Comment #102 from Julian Maurice --- Created attachment 74211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74211&action=edit Bug 12395: QA follow-up - Add class/id to body tag Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Attachment #72725|0 |1 is obsolete|| --- Comment #103 from Julian Maurice --- Created attachment 74212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74212&action=edit Bug 12395: Use standard + markup for showorder.tt Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Attachment #72693|0 |1 is obsolete|| --- Comment #207 from Julian Maurice --- Created attachment 74215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74215&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Attachment #72694|0 |1 is obsolete|| --- Comment #208 from Julian Maurice --- Created attachment 74216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74216&action=edit Bug 11708: Remove column aqbasketgroups.closed It is redundant with aqbasketgroups.closeddate Signed-off-by: Paola Rossi Patch updated: use atomic update Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Attachment #72692|0 |1 is obsolete|| --- Comment #206 from Julian Maurice --- Created attachment 74214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74214&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Attachment #72691|0 |1 is obsolete|| --- Comment #205 from Julian Maurice --- Created attachment 74213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74213&action=edit Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi Patch updated: Use atomic update Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Attachment #72695|0 |1 is obsolete|| --- Comment #209 from Julian Maurice --- Created attachment 74217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74217&action=edit Bug 11708: Place "Basket groups" menu entry on top of the side navigation Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Attachment #72698|0 |1 is obsolete|| --- Comment #212 from Julian Maurice --- Created attachment 74220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74220&action=edit Bug 11708: UT: Use DateTime instead of localtime+sprintf Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Attachment #72696|0 |1 is obsolete|| --- Comment #210 from Julian Maurice --- Created attachment 74218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74218&action=edit Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. In the process, this patch adds 4 new "Koha::Object" modules: - Koha::Bookseller(s) - Koha::Basket(s) - Koha::Basketgroup(s) - Koha::Order(s) It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Attachment #72697|0 |1 is obsolete|| --- Comment #211 from Julian Maurice --- Created attachment 74219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74219&action=edit Bug 11708: UT: Replace 'ok' by 'is' where appropriate Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #214 from Julian Maurice --- Created attachment 74222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74222&action=edit Bug 11708: Use Asset plugin in acqui/basketgroups.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #215 from Julian Maurice --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Attachment #72699|0 |1 is obsolete|| --- Comment #213 from Julian Maurice --- Created attachment 74221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74221&action=edit Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace and fix Koha::Acquisition::Order usage everywhere Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #73 from Benjamin Rokseth --- Created attachment 74223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74223&action=edit Bug 20271: atomicupdate - support mysql < 5.7 and address foreign key issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What|Removed |Added Attachment #72905|0 |1 is obsolete|| --- Comment #24 from Julian Maurice --- Created attachment 74224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74224&action=edit Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 Signed-off-by: Eric Gosselin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219
Julian Maurice changed:
What|Removed |Added
Attachment #72906|0 |1
is obsolete||
--- Comment #25 from Julian Maurice ---
Created attachment 74225
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74225&action=edit
Bug 15219: Fix date sorting when server-side processing is disabled
Use DataTables 'columns' option instead of 'aoColumns'
This allow more control on what data is used for display, sorting,
filtering, ...
A large part of this patch is about rewording things to better match the
DataTables documentation.
The real change is that
"mRender": renderingFunc
becomes
"render": {
"display": renderingFunc
}
So the return value of renderingFunc is now only used for display (not
for filtering, sorting, ...)
Signed-off-by: Eric Gosselin
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #26 from Julian Maurice --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20587] New: Add option to delete notices out of message queue via notices tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20587 Bug ID: 20587 Summary: Add option to delete notices out of message queue via notices tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Sometimes a library creates a notice by accident and wants to delete it before it's sent out with the next run of the messsage queue. It would be nice if we offered a 'delete' link in the notices tab for each message that would allow for that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20587] Add option to delete notices out of message queue via notices tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20587 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19008 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19008] More database cleanups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13667 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 --- Comment #2 from Fridolin SOMERS --- Bug 19008 adds an option on cron job cleanup_database.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Fridolin SOMERS changed: What|Removed |Added Blocks||19008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 [Bug 19008] More database cleanups -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19008] More database cleanups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Fridolin SOMERS changed: What|Removed |Added Depends on||18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19008] More database cleanups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Fridolin SOMERS changed: What|Removed |Added Blocks||18081 Depends on|18081 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Fridolin SOMERS changed: What|Removed |Added Blocks|19008 | Depends on||19008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 [Bug 19008] More database cleanups -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 Mike changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20545] Add multi-language support to SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #4 from Magnus Enger --- This hints at a bug in the SIP2 implementation in Koha. In the SIP2 standard that Katrin references in Comment 1, "language" is listed as a "3-char, fixed length required field". The contents of this field should be the 3-digit language codes that Katrin lists. As fas as I can tell, Koha uses the contents of the borrowers.lang database field for the language, using 000 if the field is not set: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/SIP/ILS/Patron.pm;h=23c576493fbc6214905efd1297225057a80c537a;hb=HEAD#l252 If a language code like nb-NO is used for the language in SIP2 the language info will have both the wrong length and the wrong format. As far as I can tell, we should have a mapping somewhere from the codes we use in borrowers.lang to the 3-digit codes required by SIP2. Not sure if it makes sense to fix this as part of the present bug or if it should be a separate bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Attachment #73605|0 |1 is obsolete|| --- Comment #37 from Ere Maijala --- Created attachment 74226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74226&action=edit Bug 14716: URI-encode URLs in xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14716 Test plan: 1. Catalog a record with series name "Series & more" 2. Find the record 3. Make sure clicking the "Series & more" link works and the ampersand is properly encoded in the URL. 4. Also try the attached test records and make sure their links work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Attachment #74226|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #38 from Ere Maijala --- Created attachment 74227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74227&action=edit Bug 14716: URI-encode URLs in MARC21 xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14716 Test plan: 1. Catalog a record with series name "Series & more" 2. Find the record 3. Make sure clicking the "Series & more" link works and the ampersand is properly encoded in the URL. 4. Also try the attached test records and make sure their links work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #39 from Ere Maijala --- Created attachment 74228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74228&action=edit Bug 14716: URI-encode URLs in UNIMARC xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14716 Test plan: 1. Catalog a record with series name "Series & more" 2. Find the record 3. Make sure clicking the "Series & more" link works and the ampersand is properly encoded in the URL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #40 from Ere Maijala --- Hi Katrin! You're right, I should have split this. I've now split this into MARC21 and UNIMARC changes and omitted NORMARC. 1. Thanks for catching the external url issue, it was definitely my bad. 2. The comma is a reserved character and should be encoded. See e.g. https://en.wikipedia.org/wiki/Percent-encoding#Types_of_URI_characters for a list of reserved characters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20554] New OPAC CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Claire Gravely changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20322] Circulation page layout and design update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #38 from Owen Leonard --- (In reply to Liz Rea from comment #36) > I feel like, as and when we have a desktop application that is actually > compiled and readily available for other platforms, it doesn't make sense to > change it. +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazi changed: What|Removed |Added Attachment #74179|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 74229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74229&action=edit Bug 20568: API keys management in interface This introduces the concept of API keys for use in the new REST API. A key is a string of 32 alphanumerical characters (32 is purely arbitrary, it can be changed easily). A user can have multiple keys (unlimited at the moment) Keys can be generated automatically, and then we have the possibility to delete or revoke each one individually. Test plan: 1/ Go to staff interface 2/ Go to a borrower page 3/ In toolbar, click on More -> Manage API keys 4/ Click on "Generate new key" multiple times, check that they are correctly displayed under the button, and they are active by default 5/ Revoke some keys, check that they are not active anymore 6/ Delete some keys, check that they disappear from table 7/ Go to opac interface, log in 8/ In your user account pages, you now have a new tab to the left "your API keys". Click on it. 9/ Repeat steps 4-6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 74231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74231&action=edit Bug 20568: Unit tests This patch adds unit tests for the introduced classes: Koha::ApiKey(s). To test: - Apply this patch - Run $ kshell k$ prove t/db_dependent/Koha/ApiKeys.t => FAIL: Tests fail because the feature is not implemented. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 74232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74232&action=edit Bug 20568: API key management for OPAC users This patch makes the OPAC interface for API keys management work with the new lib. Verify all actions work for a logged user. Users without login should be redirected to an error page. The AllowPatronsManageAPIKeysInOPAC syspref is added to control if the OPAC feature is enabled or not. To test: - Verify the syspref works - Verify users can manage their API keys -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazi changed: What|Removed |Added Attachment #74180|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 74230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74230&action=edit Bug 20568: Add mandatory description field for api keys This patch changes the table structure adding fields usually found on this kind of api management pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 Tomás Cohen Arazi changed: What|Removed |Added Blocks|20568 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 [Bug 20568] Add API key management interface for patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazi changed: What|Removed |Added Depends on|20402 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 [Bug 20402] Implement OAuth2 authentication for REST API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazi changed: What|Removed |Added Attachment #74230|0 |1 is obsolete|| --- Comment #10 from Tomás Cohen Arazi --- Created attachment 74234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74234&action=edit Bug 20568: Add mandatory description field for api keys This patch changes the table structure adding fields usually found on this kind of api management pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazi changed: What|Removed |Added Attachment #74232|0 |1 is obsolete|| --- Comment #12 from Tomás Cohen Arazi --- Created attachment 74236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74236&action=edit Bug 20568: API key management for OPAC users This patch makes the OPAC interface for API keys management work with the new lib. Verify all actions work for a logged user. Users without login should be redirected to an error page. The AllowPatronsManageAPIKeysInOPAC syspref is added to control if the OPAC feature is enabled or not. To test: - Verify the syspref works - Verify users can manage their API keys -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazi changed: What|Removed |Added Attachment #74231|0 |1 is obsolete|| --- Comment #11 from Tomás Cohen Arazi --- Created attachment 74235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74235&action=edit Bug 20568: Unit tests This patch adds unit tests for the introduced classes: Koha::ApiKey(s). To test: - Apply this patch - Run $ kshell k$ prove t/db_dependent/Koha/ApiKeys.t => FAIL: Tests fail because the feature is not implemented. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazi changed: What|Removed |Added Attachment #74229|0 |1 is obsolete|| --- Comment #9 from Tomás Cohen Arazi --- Created attachment 74233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74233&action=edit Bug 20568: API keys management in interface This introduces the concept of API keys for use in the new REST API. A key is a string of 32 alphanumerical characters (32 is purely arbitrary, it can be changed easily). A user can have multiple keys (unlimited at the moment) Keys can be generated automatically, and then we have the possibility to delete or revoke each one individually. Test plan: 1/ Go to staff interface 2/ Go to a borrower page 3/ In toolbar, click on More -> Manage API keys 4/ Click on "Generate new key" multiple times, check that they are correctly displayed under the button, and they are active by default 5/ Revoke some keys, check that they are not active anymore 6/ Delete some keys, check that they disappear from table 7/ Go to opac interface, log in 8/ In your user account pages, you now have a new tab to the left "your API keys". Click on it. 9/ Repeat steps 4-6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974
Nicolas Legrand changed:
What|Removed |Added
CC||nicolas.legr...@bulac.fr
--- Comment #43 from Nicolas Legrand ---
It seems to me the atomic dev fails because of the quote operator with "|"
delimiters while having "|" in the delimited strings. Works better with other
delimiters:
diff --git a/installer/data/mysql/atomicupdate/bug_19974.perl
b/installer/data/mysql/atomicupdate/bug_19974.perl
index 15f39e9..deea5de 100644
--- a/installer/data/mysql/atomicupdate/bug_19974.perl
+++ b/installer/data/mysql/atomicupdate/bug_19974.perl
@@ -4,21 +4,21 @@ if( CheckVersion( $DBversion ) ) {
SELECT value FROM systempreferences WHERE
variable="MarkLostItemsAsReturned"
|);
if ( $original_value and $original_value eq '1' ) {
-$dbh->do(q|
+$dbh->do(q/
UPDATE systempreferences
SET type="multiple",
options="batchmod|moredetail|cronjob|additem",
value="batchmod|moredetail|cronjob|additem"
WHERE variable="MarkLostItemsAsReturned"
-|);
+/);
} else {
-$dbh->do(q|
+$dbh->do(q/
UPDATE systempreferences
SET type="multiple",
options="batchmod|moredetail|cronjob|additem",
value=""
WHERE variable="MarkLostItemsAsReturned"
-|);
+/);
}
SetVersion( $DBversion );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Jonathan Druart changed: What|Removed |Added Keywords|Academy |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Josef Moravec changed: What|Removed |Added Attachment #74191|0 |1 is obsolete|| --- Comment #14 from Josef Moravec --- Created attachment 74237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74237&action=edit Bug 18007: Interface updates to notices and notice previews This patch makes changes to the form for adding and editing notices, and to the template for viewing a rendered preview of notices. - Preview now shows side-by-side comparisons - JavaScript has been movied out of template into separate file - Validation of the add/edit form improved through use of validation plugin To test, apply the patch on top of those for Bug 17981 - Add a new notice. - Confirm that the form can't be submitted without data in the "code" and "name" fields. - Confirm that the form can't be submitted without filling in at least one message template (subject and body). - Confirm that you cannot submit the form while using an existing notice code. - Follow Bug 17981's test plan for testing the preview function. Confirm that the preview loads correctly and looks correct. - Test both with old syntax messages which require conversion and messages in template-toolkit syntax. Signed-off-by: Katrin Fischer Fixed conflicts caused by bug 20538. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 Jonathan Druart changed: What|Removed |Added Attachment #74167|0 |1 is obsolete|| --- Comment #44 from Jonathan Druart --- Created attachment 74238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74238&action=edit Bug 19974: Make MarkLostItemsAsReturned multiple Given the confusion regarding this behaviour it sounds better to make it configurable. This pref will take 4 different values, 1 per place an item can be marked as lost. Test plan: Mark items as lost and confirm the item is returned or not, depending on the value of the system preference. - from the longoverdue cronjob (--mark-returned takes precedence if set) - from the batch item modification tool - when cataloguing an item - from the items tab of the catalog module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 --- Comment #45 from Jonathan Druart --- (In reply to Nicolas Legrand from comment #43) > It seems to me the atomic dev fails because of the quote operator with "|" > delimiters while having "|" in the delimited strings. Works better with > other delimiters: Indeed, thanks for catching that. I tried the queries directly in the MariaDB CLI. Fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13655] Can't save organisation type patron without entering userid/password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Josef Moravec --- When partially editing an organization patron and clean field username, it is expected the username will be regenerated (as when do full edit, or full and partial edit of normal patron), but the username is leaved unchanged! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13655] Can't save organisation type patron without entering userid/password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19882] Add Novelist Select staff client profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 --- Comment #14 from Jonathan Druart --- Created attachment 74239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74239&action=edit Bug 19882: Fix syntax issue in .pref file The translate script raised an error: Use of uninitialized value $pref_name in concatenation (.) or string at LangInstaller.pm line 190. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19882] Add Novelist Select staff client profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 --- Comment #15 from Jonathan Druart --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562 Josef Moravec changed: What|Removed |Added Attachment #74102|0 |1 is obsolete|| --- Comment #7 from Josef Moravec --- Created attachment 74240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74240&action=edit Bug 20562: issue_id is not stored in accountlines for rental fees Test Plan: 1) Apply this patch 2) Assign a charge to an item type 3) Checkout an item of that type to a patron 4) View the accountlines table for that patron SELECT * FROM accountlines WHERE accounttype='Rent' and borrowernumber=##; 5) Note there is an issue_id Or 1) Apply this patch 2) prove t/db_dependent/Circulation/issue.t Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #30 from Katrin Fischer --- We have another library complaining about this :( I think at the moment, we just need a quick fix that doesn't appear broken to the patron. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20588] New: Elasticsearch - Apply dataTable on search fields and mapping tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Bug ID: 20588 Summary: Elasticsearch - Apply dataTable on search fields and mapping tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arn...@biblibre.com Apply dataTable on search fields and mapping tables to be able to sort and filter data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 --- Comment #1 from Alex Arnaud --- Created attachment 74241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74241&action=edit Bug 20588 - Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Alex Arnaud changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Alex Arnaud changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What|Removed |Added Blocks||20588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Alex Arnaud changed: What|Removed |Added Depends on||20388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 [Bug 20388] Elasticsearch - Ability to add search fields from UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Josef Moravec changed: What|Removed |Added QA Contact||josef.mora...@gmail.com CC||josef.mora...@gmail.com Status|Signed Off |Patch doesn't apply --- Comment #60 from Josef Moravec --- Sorry, does not apply on current master... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19794] Rename RLIST - Routing list notice template as it's not related to routing lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19794 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19794] Rename RLIST - Routing list notice template as it's not related to routing lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19794 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19794] Rename RLIST - Routing list notice template as it's not related to routing lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19794 --- Comment #4 from Josef Moravec --- Created attachment 74243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74243&action=edit Bug 19794: (QA follow-up) Change tab to space Test plan: Run qa tools, it should be happy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19794] Rename RLIST - Routing list notice template as it's not related to routing lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19794 Josef Moravec changed: What|Removed |Added Attachment #72990|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 74242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74242&action=edit Bug 19794: Rename RLIST notice to SERIAL_ALERT to better reflect its purpose The RLIST sample notice is used to send an email to patrons who have subscribed to be notified when a new issue for a subscription arrives. This is a feature that is totally independent and not related to the use of routing lists. In the GUI however, this was misleading so far. - Rename RLIST to SERIAL_ALERT and fixes the sample notices - Fix explanations in the helf files - Fix name of the module in letters from 'serials (routing list)' to 'serials (new issue)' Note: There is no logic to be changed as the notice template to be used is defined for each subscriptions and this is just the sample notice. I've also opted against a database update, to not interfere with existing installations, reports etc. A patch to the manual will be submitted shortly after this passes QA. Signed-off-by: Brendan Gallagher Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18969] Elasticsearch - _all field is deprecated - should use copy_to to prepare for ES6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #15 from Nick Clemens --- (In reply to David Gustafsson from comment #14) > Ok! I actually think that would be a bad idea, mainly for the following > reasons: > > 1) Elasticsearch uses ranking function called Okapi BM25...If you put all > values in one field, average field length > and inverse document frequency will averaged out based on all fields, Ah, okay, I see this in the documentation: https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-all-field.html Built-in or constructed we pay a relevance price > 2) You will also not be able to use per field boosting, unless you add > boosted fields to "fields" as well, but then you might as well skip the > "_all_*" fields and pass along the full list of fields instead. Well, it does seem to work to only add boosted fields and boost those above all, but again, not as exact > 3) The index will be about 3x as big, increasing memory usage. This might > not a huge issue, but could be for us for example as we have several million > biblios and already quite a large index already. Agreed, I think we would need to compare with an without the all field to see exact impact > 4) To utilize the full power of Elasticsearch one would want to be able to > use different analyzers/normalizers and other useful mapping settings on a > per field basis, and nice query string query options like > "quote_field_suffix". With everything in one field, all data will be indexed > using the same mapping settings, and features like quote_field_suffix will > not work. I don't think I actually follow you here - we still specify different analyzers per field, but we also construct the _all field and use that for keyword searching only - this is what we currently do. So we can search specific fields, or use the all > I can actually see no benefits with using "all_*" fields, and no real > downside by instead generating a proper "fields" containing all searchable > fields. The only downside is listing all the fields individually so a small cost in construction of queries and query size, but not terrible I would think >I begun working on a patch today (one of the reasons was that we > need per field boosting), and it's actually not a very complicated change. > Might not be ready tomorrow, but at least some time in the beginning of next > week. Looking forward to it! :-) - have you seen bug 18316? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20589] New: Add field boosting and use elastic query fields parameter instead of depricated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Bug ID: 20589 Summary: Add field boosting and use elastic query fields parameter instead of depricated _all Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: glask...@gmail.com Generate a list of fields for the query_string query fields parameter, with possible boosts, instead of using "_all"-field. Also add "search" flag in search_marc_to_field table so that certain mappings can be excluded from searches. Add option to include/exclude fields in query_string "fields" parameter depending on searching in OPAC or staff client. Refactor code to remove all other dependencies on "_all"-field. (the atomicupdate sql-file is a bit obfuscated since had to be able to run in multiple time without error because of our local deploy-script, when moving this all procedure related code can be removed, only the "ALTER TABLE.."-lines are relevant.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
