Re: [Koha-devel] Koha 24.05 is here!

2024-05-28 Thread Tomas Cohen Arazi via Koha-devel
Congratulations, Katrina! Great job

El mar, 28 may 2024 a las 6:15, Fischer, Katrin via Koha-devel (<
koha-devel@lists.koha-community.org>) escribió:

> The Koha community is proud to announce the release of Koha 24.05.00.
>
> Koha 24.05.00 is a major release that comes with many new features.
>
> It includes 9 new features, 239 enhancements, 529 bugfixes.
>
> The full release notes are available here:
> https://koha-community.org/koha-24-05-00-released/ ‎
>
> Debian packages are available.
>
> --
> Katrin Fischer
> Bibliotheksservice-Zentrum Baden-Wuerttemberg (BSZ)
> 78457 Konstanz / Germany
> Phone: +49 7531 - 88 4934
> E-Mail: katrin.fisc...@bsz-bw.de
> http://bsz-bw.de
>
>
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Koha CSRF protection

2024-04-13 Thread Tomas Cohen Arazi via Koha-devel
The thing is we don't have a spec for each endpoint as we do for the API.
So people could be tricked to send a GET with a similar form, to an
endpoint (the .pl script) and bypass the generic CSRF check we do.

Also, this ways programmers and the QA team have a simpler way to detect
state-changing workflows that are unprotected: changes something? It needs
to be a POST with cus-, otherwise Koha will let you know you missed
something.

Hope it clarifies.

El sáb, 13 abr 2024 10:18, Julian Maurice via Koha-devel <
koha-devel@lists.koha-community.org> escribió:

> My point is: since all POST (and other unsafe methods) requests are
> protected and require a CSRF token, why does Koha have a requirement on
> the 'op' parameter for those requests ? It seems redundant and can cause
> unnecessary failure (I can't POST with 'op=search' even with a valid
> CSRF token, I don't understand why)
>
> And for safe methods (GET, HEAD, OPTIONS, TRACE), if someone identifies
> that it's doing a CUD operation, why modify the 'op' parameter since you
> need to also change the method to POST anyway ?
> This can be reworded as: How can we end up in a situation where 'op' has
> been fixed ("cud-" prefix added) but not the HTTP method ?
>
> Le 2024-04-12 20:41, Jonathan Druart a écrit :
> > We want to know which requests to protect (ie. Requiring a csrf token):
> > those having a op starting with cud-
> > Otherwise you could GET something that should be POSTed.
> > I've tried to describe this change as best as I could on the wiki,
> > please
> > adjust if it's not clear enough.
> > https://wiki.koha-community.org/wiki/Coding_Guidelines#CSRF_protection
> >
> > On Fri, 12 Apr 2024, 15:00 Julian Maurice via Koha-devel, <
> > koha-devel@lists.koha-community.org> wrote:
> >
> >> Hi,
> >>
> >> I'm a bit late on the topic but I had a look at the different bugs and
> >> patches during hackfest (mainly because it didn't work for me, I will
> >> open a new bug report for that).
> >>
> >> There is something in it that seems to cause bugs and I don't see a
> >> reason for it: it's the "cud-" thing.
> >>
> >> As I understand it, now every request that create/update/delete
> >> something should be POST (or PUT/DELETE/PATCH) requests and have an
> >> 'op'
> >> parameter whose value start with 'cud-' and all other requests should
> >> be
> >> GET (or OPTIONS/TRACE/HEAD) requests and if they have an 'op'
> >> parameter
> >> it should not start with "cud-".
> >> Why do we need the "cud-" prefix if we can use the HTTP method for
> >> detecting which requests need to be protected ?
> >>
> >> What seems strange is that the current implementation will allow a
> >> POST
> >> request without an 'op' parameter, but will block a POST request with
> >> an
> >> 'op' parameter that does not start with 'cud-'.
> >> It looks like we could get rid of this prefix check without losing
> >> anything. What did I miss ?
> >>
> >> Le 04/03/2024 à 08:37, Marcel de Rooy via Koha-devel a écrit :
> >> > Great work!
> >> >
> >> > *From:*Koha-devel  *On
> >> > Behalf Of *Nick Clemens via Koha-devel
> >> > *Sent:* Friday, March 1, 2024 2:26 PM
> >> > *To:* Koha Devel ; Koha
> >> > 
> >> > *Subject:* [Koha-devel] Koha CSRF protection
> >> >
> >> > Hello all!
> >> >
> >> > We have pushed the CSRF work from 34478 and related bugs today. We
> know
> >> > there are more follow-ups needed, and have filed a series of bugs
> under
> >> > an omnibus:
> >> >
> >> > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192
> >> > 
> >> >
> >> > We have a framapad where issues can be reported/found:
> >> >
> >> > https://annuel.framapad.org/p/koha_34478_remaining
> >> > 
> >> >
> >> > And we have bugs for each of the sections of the document. We need all
> >> > developers to submit patches when they encounter issues, and for other
> >> > users testing master to report found issues on the pad. Testers can
> >> > report issues on the pad as well.
> >> >
> >> > There is a new coding guideline - all POSTs to forms in Koha will need
> >> > to include a csrf token:
> >> >
> >> > https://wiki.koha-community.org/wiki/Coding_Guidelines#Security
> >> > 
> >> >
> >> > This has been a big work, many thanks to all involved, and there is
> >> > still work to be done, but this is an important fix that we must do.
> >> >
> >> > You can reach out to me on IRC (kidclamp) or via email and I will do
> my
> >> > best to help anyone contribute.
> >> >
> >> > Thanks,
> >> >
> >> > Nick
> >> >
> >> >
> >> > --
> >> >
> >> > Nick Clemens
> >> >
> >> > ByWater Solutions
> >> >
> >> > bywatersolutions.com 
> >> >
> >> > Phone: (888) 900-8944
> >> >
> >> > Pronouns: (he/him/his)
> >> > Timezone: Eastern
> >> >
> >> > Follow us:
> >> >
> >> > 
> >> > 

[Koha-devel] IMPORTANT: Koha hotfix

2024-04-11 Thread Tomas Cohen Arazi via Koha-devel
Hi everyone, we just identified an error on last week's releases and are
publishing a quick update.

Packages are generally available with the patched versions and should be
applied. Source tarballs are a bit delayed but will be published as well.

Thanks to all involved

-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] REST API : PUT for partial update

2024-03-21 Thread Tomas Cohen Arazi via Koha-devel
Setting a null value willl set it to null, if nullable. Yes!

El jue, 21 mar 2024 a las 10:07, Fridolin SOMERS via Koha-devel (<
koha-devel@lists.koha-community.org>) escribió:

>
>
> Le 21/03/2024 à 11:18, Fridolin SOMERS via Koha-devel a écrit :
> > OK
> >
> > But currently this means in PUT you need to add in body the required
> > fields (even when unchanged) and the fields you want to change.
> > Missing fields are kept unchanged right ?
> > So there is no way to blank a field ?
> Looks like we can use null (unquoted of course) :
> For example in PUT /libraries/ :
> --data-raw '{ "name": "toto", "library_id": "ID", "address1": null }'
>
> It blanks the address1
>
> Anyone confirm ?
>
> >
> > The need was updating patron expiration date.
> > So maybe better create a dedicated route with only PUT.
> > Like the one for privacy :
> > /public/patrons/{patron_id}/guarantors/can_see_charges
> >
> > We should add some text to wiki :
> > https://wiki.koha-community.org/wiki/Koha_REST_API_Users_Guide
> >
> >
> > Le 20/03/2024 à 16:45, Tomas Cohen Arazi a écrit :
> >> When we decided to implement the RESTful API, we agreed PUT is for
> >> 'replacing' resources, and PATCH for updating selected pieces of them.
> >>
> >> I personally never managed to wrap my mind around PATCH and how to
> >> validate what tiny bit is allowed to be patched or not. As OpenAPIv2
> >> is not that flexible.
> >>
> >> But I'm sure Jonathan has implemented PATCH on the ERM, and those
> >> controllers look exactly the same as those for PUT.
> >>
> >> That said, I think we could just implement PATCH on the spec, pointing
> >> to the same controllers (for now) on an as-needed basis.
> >>
> >> Beware validation of combined parameters, etc.
> >>
> >> Good luck!
> >>
> >> El mié, 20 mar 2024 a las 11:03, Fridolin SOMERS via Koha-devel
> >> ( >> <mailto:koha-devel@lists.koha-community.org>>) escribió:
> >>
> >> Hi,
> >>
> >> I've tried to use API for a PUT on patron.
> >>
> >> Looks like I can't do a partial update, I get error on mandatory
> >> datas
> >> like if it where a POST.
> >>
> >> I found this discussion :
> >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23285#c8
> >> <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23285#c8
> >
> >>
> >> Is this a bug ?
> >>
> >> Best regards,
> >>
> >> -- Fridolin SOMERS  >> <mailto:fridolin.som...@biblibre.com>>
> >> Software and system maintainer 濾
> >> BibLibre, France
> >> ___
> >> Koha-devel mailing list
> >> Koha-devel@lists.koha-community.org
> >> <mailto:Koha-devel@lists.koha-community.org>
> >>
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> >>
> >> <https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel>
> >> website : https://www.koha-community.org/
> >> <https://www.koha-community.org/>
> >> git : https://git.koha-community.org/
> >> <https://git.koha-community.org/>
> >> bugs : https://bugs.koha-community.org/
> >> <https://bugs.koha-community.org/>
> >>
> >>
> >>
> >> --
> >> Tomás Cohen Arazi
> >> Theke Solutions (https://theke.io <https://theke.io>)
> >> ✆ +54 9351 3513384
> >> GPG: B2F3C15F
> >
>
> --
> Fridolin SOMERS 
> Software and system maintainer 濾
> BibLibre, France
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] REST API : PUT for partial update

2024-03-20 Thread Tomas Cohen Arazi via Koha-devel
When we decided to implement the RESTful API, we agreed PUT is for
'replacing' resources, and PATCH for updating selected pieces of them.

I personally never managed to wrap my mind around PATCH and how to validate
what tiny bit is allowed to be patched or not. As OpenAPIv2 is not that
flexible.

But I'm sure Jonathan has implemented PATCH on the ERM, and those
controllers look exactly the same as those for PUT.

That said, I think we could just implement PATCH on the spec, pointing to
the same controllers (for now) on an as-needed basis.

Beware validation of combined parameters, etc.

Good luck!

El mié, 20 mar 2024 a las 11:03, Fridolin SOMERS via Koha-devel (<
koha-devel@lists.koha-community.org>) escribió:

> Hi,
>
> I've tried to use API for a PUT on patron.
>
> Looks like I can't do a partial update, I get error on mandatory datas
> like if it where a POST.
>
> I found this discussion :
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23285#c8
>
> Is this a bug ?
>
> Best regards,
>
> --
> Fridolin SOMERS 
> Software and system maintainer 濾
> BibLibre, France
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Koha CSRF protection

2024-03-01 Thread Tomas Cohen Arazi via Koha-devel
Congrats team!

El vie, 1 mar 2024 a las 10:26, Nick Clemens via Koha-devel (<
koha-devel@lists.koha-community.org>) escribió:

> Hello all!
>
> We have pushed the CSRF work from 34478 and related bugs today. We know
> there are more follow-ups needed, and have filed a series of bugs under an
> omnibus:
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192
>
> We have a framapad where issues can be reported/found:
> https://annuel.framapad.org/p/koha_34478_remaining
>
> And we have bugs for each of the sections of the document. We need all
> developers to submit patches when they encounter issues, and for other
> users testing master to report found issues on the pad. Testers can report
> issues on the pad as well.
>
> There is a new coding guideline - all POSTs to forms in Koha will need to
> include a csrf token:
> https://wiki.koha-community.org/wiki/Coding_Guidelines#Security
>
> This has been a big work, many thanks to all involved, and there is still
> work to be done, but this is an important fix that we must do.
>
> You can reach out to me on IRC (kidclamp) or via email and I will do my
> best to help anyone contribute.
>
> Thanks,
> Nick
>
> --
> Nick Clemens
> ByWater Solutions
> bywatersolutions.com
> Phone: (888) 900-8944
> Pronouns: (he/him/his)
> Timezone: Eastern
> Follow us:
> 
> 
> 
> 
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Session corruption in koha-testing-docker master

2024-02-13 Thread Tomas Cohen Arazi via Koha-devel
That's interesting! I've seen such situation on stuck STOMP messages, so I
guess we are breaking userenv somewhere!

El lun, 12 feb 2024 a las 21:36, David Cook via Koha-devel (<
koha-devel@lists.koha-community.org>) escribió:

> Hi all,
>
>
>
> The last two days I’ve noticed that my session is getting corrupted while
> I’m working on master in koha-testing-docker. I’m not touching the session
> myself, but seemingly randomly the session gets all kinds of DIBC data
> stuffed into it, and Koha seems to be parse it and Koha throws a fatal
> error, which can only be resolved by deleting the problematic session from
> the table.
>
>
>
> Just curious if anyone else is seeing this. I really don’t think it’s
> related to anything I’m working on, but I also can’t reliably reproduce it.
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Growing size of koha/koha-testing:master

2024-02-05 Thread Tomas Cohen Arazi via Koha-devel
I think it's related to having Cypress bundled. And maybe some mistake on
package cache cleanup.

El dom, 4 feb 2024 a las 19:30, David Cook via Koha-devel (<
koha-devel@lists.koha-community.org>) escribió:

> Hi all,
>
>
>
> I’ve noticed recently that koha/koha-testing:master has been steadily
> growing. At this point, it’s about 4.37GB in size. For 21.11 I think it
> used to be about 2GB and 22.11 was 3.5GB.
>
>
>
> Do we know what’s contributing to this?
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Koha 22.11.13 released

2024-01-02 Thread Tomas Cohen Arazi via Koha-devel
Great, Frederic!

El mar, 2 ene 2024 a las 9:59, Frédéric Demians via Koha-devel (<
koha-devel@lists.koha-community.org>) escribió:

> Hello everyone,
> and best wishes for the New Year,
>
> The Koha community is proud to announce the release
> of Koha 22.11.13:
> https://koha-community.org/koha-22-11-13-released/
>
> Debian packages are coming...
>
> Best,
> Frédéric Demians
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Koha 23.11.01 released

2024-01-02 Thread Tomas Cohen Arazi via Koha-devel
Yay!

El mar, 2 ene 2024 a las 7:37, Fridolin SOMERS via Koha-devel (<
koha-devel@lists.koha-community.org>) escribió:

> Hello everyone 珞
>
> The Koha community is proud to announce the release of Koha 23.11.01.
>
> It is a bugfix/maintenance release including 25 bugfixes.
>
> The full release notes are available here:
> https://koha-community.org/koha-23-11-01-released/
>
> Debian packages should be available soon 
>
> Best regards 邏
>
> --
> Fridolin SOMERS 
> Software and system maintainer 濾
> BibLibre, France
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] REMINDER: Development IRC meeting 13 December 2023

2023-12-12 Thread Tomas Cohen Arazi via Koha-devel
That'd be 13 UTC.

El mar, 12 dic 2023 a las 9:10, Marcel de Rooy via Koha-devel (<
koha-devel@lists.koha-community.org>) escribió:

> How late btw?
> --
> *Van:* Koha-devel  namens
> Fischer, Katrin via Koha-devel 
> *Verzonden:* dinsdag 12 december 2023 10:10
> *Aan:* koha-devel@lists.koha-community.org <
> koha-devel@lists.koha-community.org>
> *Onderwerp:* [Koha-devel] REMINDER: Development IRC meeting 13 December
> 2023
>
> Hi all,
>
> we have a development IRC meeting scheduled for tomorrow:
>
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwiki.koha-community.org%2Fwiki%2FDevelopment_IRC_meeting_13_December_202=05%7C02%7Cm.de.rooy%40rijksmuseum.nl%7C0fa2aa2e15174458edb208dbfaf235df%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638379690436207435%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C=E8wmDJ5TKdmztAA1P7fV9g0yHdU1I9z6lsYZTWoOI3E%3D=0
> 
> 3
>
> We will take time to talk about the roadmap for 24.05:
>
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwiki.koha-community.org%2Fwiki%2FRoad_map_24.05=05%7C02%7Cm.de.rooy%40rijksmuseum.nl%7C0fa2aa2e15174458edb208dbfaf235df%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638379690436207435%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C=ReNVFjGr63xi4p6Oa0T49k%2BBQ5Dh%2B%2Bh7m%2Frdaempv2k%3D=0
> 
>
> Please have a look and add your projects and support.
>
> See you tomorrow!
>
> Katrin
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] FW: [Koha] Koha 23.11 released

2023-12-05 Thread Tomas Cohen Arazi via Koha-devel
Thanks for all your support, Marcel

El mar, 5 dic 2023 12:59, Marcel de Rooy via Koha-devel <
koha-devel@lists.koha-community.org> escribió:

> Great, Tomas!
>
> Note btw that I still do not receive a lot of mails on koha-devel on my MS
> email address (like this one too).
> Yes, I know what you want to say 
>
> Marcel
>
> --
> *Van:* Marcel de Rooy
> *Verzonden:* dinsdag 5 december 2023 16:55
> *Aan:* Marcel de Rooy 
> *Onderwerp:* Fwd: [Koha] Koha 23.11 released
>
>
>
> ------ Forwarded message -
> Van: *Tomas Cohen Arazi* 
> Date: vr 1 dec 2023 om 14:29
> Subject: [Koha] Koha 23.11 released
> To: koha 
>
>
> The Koha community is proud to announce the release of Koha 23.11.00.
>
> Koha 23.11.00 is a major release that comes with many new features.
>
> It includes 10 new features, 330 enhancements, 573 bugfixes.
>
> The full release notes are available here:
> https://koha-community.org/koha-23-11-released/
>
> Debian packages should be available soon
>
> Best regards
>
> --
> Tomás Cohen Arazi
> Theke Solutions (https://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
> ___
>
> Koha mailing list  http://koha-community.org
> k...@lists.katipo.co.nz
> Unsubscribe: https://lists.katipo.co.nz/mailman/listinfo/koha
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Anybody still using tarballs?

2023-11-10 Thread Tomas Cohen Arazi via Koha-devel
Yes, you're correct. We need to spend some time reviewing our build
pipeline process and distribution mechanisms. I can spend time on that
right after the release.

Have a great weekend, and enjoy your holiday, US people.

El vie, 10 nov 2023 a las 12:15, Jonathan Druart (<
jonathan.dru...@bugs.koha-community.org>) escribió:

> But it won't embed po files.
> Please see my reply to Victor.
>
> Le vendredi 10 novembre 2023, Tomas Cohen Arazi  a
> écrit :
> > Gitlab allows you to download a tar.gz, and commits are GPG signed
> already.
> > Maybe we can change the workflow. We should take some time to think
> about it next cycle.
> > El mar, 7 nov 2023 a las 17:22, Jonathan Druart via Koha-devel (<
> koha-devel@lists.koha-community.org>) escribió:
> >>
> >> Hi,
> >> I am suggesting removing the tarball from our release process. I don't
> think anybody is using it anyway.
> >> It's extra work for RMaints, and it does not seem necessary.
> >> I am going to suggest removing the po files from the Koha src code
> starting from November releases, and that will require yet an extra
> (unnecessary?) step to embed the po files to generate the tarball.
> >> What do you think?
> >> Cheers,
> >> Jonathan
> >> ___
> >> Koha-devel mailing list
> >> Koha-devel@lists.koha-community.org
> >> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> >> website : https://www.koha-community.org/
> >> git : https://git.koha-community.org/
> >> bugs : https://bugs.koha-community.org/
> >
> >
> > --
> > Tomás Cohen Arazi
> > Theke Solutions (https://theke.io)
> > ✆ +54 9351 3513384
> > GPG: B2F3C15F



-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Anybody still using tarballs?

2023-11-10 Thread Tomas Cohen Arazi via Koha-devel
Gitlab allows you to download a tar.gz, and commits are GPG signed already.
Maybe we can change the workflow. We should take some time to think about
it next cycle.

El mar, 7 nov 2023 a las 17:22, Jonathan Druart via Koha-devel (<
koha-devel@lists.koha-community.org>) escribió:

> Hi,
>
> I am suggesting removing the tarball from our release process. I don't
> think anybody is using it anyway.
> It's extra work for RMaints, and it does not seem necessary.
> I am going to suggest removing the po files from the Koha src code
> starting from November releases, and that will require yet an extra
> (unnecessary?) step to embed the po files to generate the tarball.
>
> What do you think?
>
> Cheers,
> Jonathan
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Last month before the release

2023-11-06 Thread Tomas Cohen Arazi via Koha-devel
Hi all.

First of all, thanks everyone for looking after the problems. Things are
almost green.
About the 'random failure', I've gotta say it is pretty consistent the last
weeks.



El lun, 6 nov 2023 a las 11:06, Jonathan Druart via Koha-devel (<
koha-devel@lists.koha-community.org>) escribió:

> selenium/patrons_search.t has been failing randomly for a while.
> Failures should be reported on bug 31199.
>
> Le lun. 6 nov. 2023 à 07:03, David Cook  a
> écrit :
>
>> Also, regarding
>> https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/
>> :
>>
>>
>>
>> I’ve got a fix for “t_db_dependent_Koha_Patrons_Import_t.No warning
>> raised by import_patrons” at
>> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264
>>
>>
>>
>> It looks like Katrin fixed
>> “xt_author_valid_templates_t./kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/
>> circulation_batch_checkouts.tt”
>>
>>
>>
>> And I can’t reproduce the problem on master for
>> “t_db_dependent_selenium_patrons_search_t.Search patrons”, so I’m guessing
>> someone has already fixed that one?
>>
>>
>>
>> Hopefully the next run will be fail free :D
>>
>>
>>
>> David Cook
>>
>> Senior Software Engineer
>>
>> Prosentient Systems
>>
>> Suite 7.03
>>
>> 6a Glen St
>>
>> Milsons Point NSW 2061
>>
>> Australia
>>
>>
>>
>> Office: 02 9212 0899
>>
>> Online: 02 8005 0595
>>
>>
>>
>> *From:* David Cook 
>> *Sent:* Monday, 6 November 2023 10:32 AM
>> *To:* 'Jonathan Druart' 
>> *Cc:* 'Tomas Cohen Arazi' ; 'koha-devel' <
>> koha-devel@lists.koha-community.org>
>> *Subject:* RE: [Koha-devel] Last month before the release
>>
>>
>>
>> Thanks, Jonathan. Yeah, I think having a live chat sounds like a plan.
>> Communication is good.
>>
>>
>>
>> Timezones, especially mine, make it tough, but being able to point at
>> documentation for policies and procedures is helpful.
>>
>>
>>
>> David Cook
>>
>> Senior Software Engineer
>>
>> Prosentient Systems
>>
>> Suite 7.03
>>
>> 6a Glen St
>>
>> Milsons Point NSW 2061
>>
>> Australia
>>
>>
>>
>> Office: 02 9212 0899
>>
>> Online: 02 8005 0595
>>
>>
>>
>> *From:* Jonathan Druart 
>> *Sent:* Friday, 3 November 2023 7:10 PM
>> *To:* David Cook 
>> *Cc:* Tomas Cohen Arazi ; koha-devel <
>> koha-devel@lists.koha-community.org>
>> *Subject:* Re: [Koha-devel] Last month before the release
>>
>>
>>
>> David, if you don't know Jenkins and you are part of the QA team, I guess
>> you are not alone to be lost with our CI structure and it means we have a
>> big problem. Either motivation, or tools or communication.
>> I am not answering you now but maybe we need to document a bit better how
>> it works for the next release, responsibilize people (asking them to fix
>> what they broke instead of fixing for them) and finally maybe have a live
>> chat beginning of the cycle with RMaints and QA team to (re) explain how it
>> works.
>>
>> Le vendredi 3 novembre 2023, David Cook via Koha-devel <
>> koha-devel@lists.koha-community.org> a écrit :
>> > It’s not clear to me though how you look at Jenkins runs. Is it going
>> to https://dashboard.koha-community.org/ and then clicking on one of the
>> badges to go to Jenkins like
>> https://jenkins.koha-community.org/job/Koha_Master_U22/ and then
>> clicking on “Latest Test Result”?
>> >
>> >
>> >
>> > David Cook
>> >
>> > Senior Software Engineer
>> >
>> > Prosentient Systems
>> >
>> > Suite 7.03
>> >
>> > 6a Glen St
>> >
>> > Milsons Point NSW 2061
>> >
>> > Australia
>> >
>> >
>> >
>> > Office: 02 9212 0899
>> >
>> > Online: 02 8005 0595
>> >
>> >
>> >
>> > From: Tomas Cohen Arazi 
>> > Sent: Friday, 3 November 2023 11:25 AM
>> > To: David Cook 
>> > Cc: koha-devel 
>> > Subject: Re: [Koha-devel] Last month before the release
>> >
>> >
>> >
>> > The suggested sequence is:
>> >
>> >
>> >
>> > 1. You notice your stuff for pushed, yay!
>> >
>> > 2. You look at Jenkins runs for the 

Re: [Koha-devel] Last month before the release

2023-11-03 Thread Tomas Cohen Arazi via Koha-devel
Hi all, this is master's latest failures:

https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/

The selenium failure has been there for a while, and the other ones are
recent.

El jue, 2 nov 2023 a las 10:30, Tomas Cohen Arazi ()
escribió:

> Hi all.
>
> We are almost done with the release, a couple medium/big things to push
> today/tomorrow and then bug fixing.
>
> I wanted to ask y'all to please view the Jenkins tasks status anytime
> after your stuff has been pushed. I know I said this many times, but some
> devs clearly break some tests that are trivially fixable and the team needs
> you to take care of your breakages.
>
> I'm doing my best to track things and fix, but you should all be worried
> about that.
>
> --
> Tomás Cohen Arazi
> Theke Solutions (https://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Last month before the release

2023-11-02 Thread Tomas Cohen Arazi via Koha-devel
The suggested sequence is:

1. You notice your stuff for pushed, yay!
2. You look at Jenkins runs for the relevant branches (e.g. Koha_Master_*
tasks)
3. If some test gets broken that day, you try too see if it was you. Beware
sometimes it is not obvious.

Today there was a failure in the holds API tests, because of a bug that
didn't touch the API, but made the code stricter (?) so the loose tests we
had written had to be tweaked so they didn't trigger a silly error.

So the devs did right, didn't introduce a bug, but made the tests fail. But
it is all of us, specially those who got patches pushed, who should be
looking after those failures. Team work

Thanks!

El jue, 2 nov 2023 21:15, David Cook  escribió:

> What’s the best way to do this?
>
>
>
> I think Jenkins might send emails, but I think my mail server blocked it
> ages ago as spam.
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
>
> *From:* Koha-devel  *On
> Behalf Of *Tomas Cohen Arazi via Koha-devel
> *Sent:* Friday, 3 November 2023 12:31 AM
> *To:* koha-devel 
> *Subject:* [Koha-devel] Last month before the release
>
>
>
> Hi all.
>
>
>
> We are almost done with the release, a couple medium/big things to push
> today/tomorrow and then bug fixing.
>
>
>
> I wanted to ask y'all to please view the Jenkins tasks status anytime
> after your stuff has been pushed. I know I said this many times, but some
> devs clearly break some tests that are trivially fixable and the team needs
> you to take care of your breakages.
>
>
>
> I'm doing my best to track things and fix, but you should all be worried
> about that.
>
>
>
> --
>
> Tomás Cohen Arazi
>
> Theke Solutions (https://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Last month before the release

2023-11-02 Thread Tomas Cohen Arazi via Koha-devel
Hi all.

We are almost done with the release, a couple medium/big things to push
today/tomorrow and then bug fixing.

I wanted to ask y'all to please view the Jenkins tasks status anytime after
your stuff has been pushed. I know I said this many times, but some devs
clearly break some tests that are trivially fixable and the team needs you
to take care of your breakages.

I'm doing my best to track things and fix, but you should all be worried
about that.

-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Koha 23.11 - Release dates

2023-10-18 Thread Tomas Cohen Arazi via Koha-devel
Hi all,

This are the release dates:

* Oct 30th - "Soft" feature freeze, nothing big or with high risk of
side-effects will be included into the final release if not marked
as Passed QA
* Nov 5 - "Hard" feature freeze, nothing considered as an improvement will
be pushed if not marked as Passed QA
* Nov 10th - String freeze, draft of release notes published
* Nov 24th - Only bug fixes considered major, critical or blocker will be
pushed
* Nov 30th - Final release

PM me if you have any comments.

-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Background jobs in plugins

2023-10-15 Thread Tomas Cohen Arazi
Please file bug reports on your findings or ideas so they don't fall into
void.

El lun, 16 oct 2023 1:42, David Cook  escribió:

> Thanks for doing that, Tomas. That was really helpful.
>
>
>
> Even with your email and the Github example, it still wasn’t working for
> me…until I realized that I should restart the background job workers.
>
>
>
> In hindsight, it’s obvious that the Koha/BackgroundJob.pm would only load
> the plugin 1 time. It also appears that the product of
> “plugin_types_to_classes” is also cached too long. My background workers
> would’ve cached the bad code and bad mapping early in my testing.
>
>
>
> The mapping cache doesn’t have an invalidation mechanism, so if you
> already have 1 plugin with a background task, I don’t think it’ll allow a 2
> nd plugin to appear in the mapping if a task from the 1st plugin is
> processed before the 2nd plugin is loaded. I haven’t thoroughly
> investigated that though…
>
>
>
> Overall, probably best to require a restart of the background workers as
> well as Plack any time a plugin is added which contains a background job.
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
>
> *From:* Kyle Hall 
> *Sent:* Saturday, October 14, 2023 2:48 AM
> *To:* Tomas Cohen Arazi 
> *Cc:* David Cook ; Koha Devel <
> koha-devel@lists.koha-community.org>; Kyle Hall  >
> *Subject:* Re: [Koha-devel] Background jobs in plugins
>
>
>
> I love it Tomas!
>
>
>
> ---
>
> http://www.kylehall.info
> ByWater Solutions ( http://bywatersolutions.com )
> Meadville Public Library ( http://www.meadvillelibrary.org )
> Crawford County Federated Library System ( http://www.ccfls.org )
>
>
>
>
>
> On Fri, Oct 13, 2023 at 9:51 AM Tomas Cohen Arazi 
> wrote:
>
> Look at this commit:
>
>
>
>
> https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/commit/30d1446387fa864fe49f25cb53a2915b33ef73ce
>
>
>
> Best regards
>
>
>
> El vie, 13 oct 2023 a las 10:09, Tomas Cohen Arazi ()
> escribió:
>
> Hi all. I'm wrapping a KitchenSink patch to highlight how it would be used.
>
>
>
> The background jobs themselves work, but the template side I never looked
> at. I thought there was some default display showing all the report
> metadata, but it seems all descriptions are hardcoded and a dev is required
> to add the ability for plugins to advertise job descriptions and have them
> displayed as well.
>
>
>
>
>
> If you want a plugin background job, it works and you should look at the
> wiki (updated just now) and/or copy what I've done on the KitchenSink
> plugin.
>
>
>
> Regarding comments on IRC, the feature was submitted during the 2022's
> hackfest in an attempt to streamline the whole background jobs work by
> Jonathan, and was tested, QA and pushed by others. We succeeded in moving
> that forward, which Fridolin pushed for 22.05 and was a great improvement.
>
>
>
> Best regards
>
>
>
> El vie, 13 oct 2023 a las 3:25, David Cook ()
> escribió:
>
> Hi all,
>
>
>
> “Bug 30410 - Add a way for plugins to register background tasks” was
> pushed in Koha 22.05.00, but I can’t figure out how to make it work.
>
>
>
> Tomas, do you have a plugin where this works?
>
>
>
> I’ve gone through the patches, and it looks like I should have it right,
> but nothing I’m doing is working.
>
>
>
> When I enqueue the job, background_jobs.pl says “Unknown job type
> 'plugin_blah_blah'” even though “plugin_blah_blah” exists in
> Koha::BackgroundJob->new->type_class_mapping and in my plugin background
> job’s “job_type”.
>
>
>
> When I click “View” on the job, I get the following error: “Template
> process failed: file error - background_jobs/plugin_blah_blah.inc: not
> found at /kohadevbox/koha/C4/Templates.pm line 127”
>
>
>
> I’ll look next week at providing a simple plugin to illustrate the problem…
>
>
>
> Thanks,
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
>
>
>
>
> --
>
> Tomás Cohen Arazi
>
> Theke Solutions (https://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
>
>
>
>
> --
>
> Tomás Cohen Arazi
>
> Theke Solutions (https://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Background jobs in plugins

2023-10-13 Thread Tomas Cohen Arazi
Look at this commit:

https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/commit/30d1446387fa864fe49f25cb53a2915b33ef73ce

Best regards

El vie, 13 oct 2023 a las 10:09, Tomas Cohen Arazi ()
escribió:

> Hi all. I'm wrapping a KitchenSink patch to highlight how it would be used.
>
> The background jobs themselves work, but the template side I never looked
> at. I thought there was some default display showing all the report
> metadata, but it seems all descriptions are hardcoded and a dev is required
> to add the ability for plugins to advertise job descriptions and have them
> displayed as well.
>
> [image: image.png]
>
> If you want a plugin background job, it works and you should look at the
> wiki (updated just now) and/or copy what I've done on the KitchenSink
> plugin.
>
> Regarding comments on IRC, the feature was submitted during the 2022's
> hackfest in an attempt to streamline the whole background jobs work by
> Jonathan, and was tested, QA and pushed by others. We succeeded in moving
> that forward, which Fridolin pushed for 22.05 and was a great improvement.
>
> Best regards
>
> El vie, 13 oct 2023 a las 3:25, David Cook ()
> escribió:
>
>> Hi all,
>>
>>
>>
>> “Bug 30410 - Add a way for plugins to register background tasks” was
>> pushed in Koha 22.05.00, but I can’t figure out how to make it work.
>>
>>
>>
>> Tomas, do you have a plugin where this works?
>>
>>
>>
>> I’ve gone through the patches, and it looks like I should have it right,
>> but nothing I’m doing is working.
>>
>>
>>
>> When I enqueue the job, background_jobs.pl says “Unknown job type
>> 'plugin_blah_blah'” even though “plugin_blah_blah” exists in
>> Koha::BackgroundJob->new->type_class_mapping and in my plugin background
>> job’s “job_type”.
>>
>>
>>
>> When I click “View” on the job, I get the following error: “Template
>> process failed: file error - background_jobs/plugin_blah_blah.inc: not
>> found at /kohadevbox/koha/C4/Templates.pm line 127”
>>
>>
>>
>> I’ll look next week at providing a simple plugin to illustrate the
>> problem…
>>
>>
>>
>> Thanks,
>>
>>
>>
>> David Cook
>>
>> Senior Software Engineer
>>
>> Prosentient Systems
>>
>> Suite 7.03
>>
>> 6a Glen St
>>
>> Milsons Point NSW 2061
>>
>> Australia
>>
>>
>>
>> Office: 02 9212 0899
>>
>> Online: 02 8005 0595
>>
>>
>>
>
>
> --
> Tomás Cohen Arazi
> Theke Solutions (https://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Background jobs in plugins

2023-10-13 Thread Tomas Cohen Arazi
Hi all. I'm wrapping a KitchenSink patch to highlight how it would be used.

The background jobs themselves work, but the template side I never looked
at. I thought there was some default display showing all the report
metadata, but it seems all descriptions are hardcoded and a dev is required
to add the ability for plugins to advertise job descriptions and have them
displayed as well.

[image: image.png]

If you want a plugin background job, it works and you should look at the
wiki (updated just now) and/or copy what I've done on the KitchenSink
plugin.

Regarding comments on IRC, the feature was submitted during the 2022's
hackfest in an attempt to streamline the whole background jobs work by
Jonathan, and was tested, QA and pushed by others. We succeeded in moving
that forward, which Fridolin pushed for 22.05 and was a great improvement.

Best regards

El vie, 13 oct 2023 a las 3:25, David Cook ()
escribió:

> Hi all,
>
>
>
> “Bug 30410 - Add a way for plugins to register background tasks” was
> pushed in Koha 22.05.00, but I can’t figure out how to make it work.
>
>
>
> Tomas, do you have a plugin where this works?
>
>
>
> I’ve gone through the patches, and it looks like I should have it right,
> but nothing I’m doing is working.
>
>
>
> When I enqueue the job, background_jobs.pl says “Unknown job type
> 'plugin_blah_blah'” even though “plugin_blah_blah” exists in
> Koha::BackgroundJob->new->type_class_mapping and in my plugin background
> job’s “job_type”.
>
>
>
> When I click “View” on the job, I get the following error: “Template
> process failed: file error - background_jobs/plugin_blah_blah.inc: not
> found at /kohadevbox/koha/C4/Templates.pm line 127”
>
>
>
> I’ll look next week at providing a simple plugin to illustrate the problem…
>
>
>
> Thanks,
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] REST API and new defaults (Zeno Tajoli)

2023-10-06 Thread Tomas Cohen Arazi
El vie, 6 oct 2023 a las 11:03, Olli-Antti Hypernova (<
olli-antti.kivila...@hypernova.fi>) escribió:

> Good idea. Anything to disband the "SmartUI"-antipattern is good for me.
>
>
> We should add a new endpoint following established nomenclature.
>
> eg. PUT /biblios/123/merge/456   (PUT as it is modifying existing records)
>

POST /biblios/123/merges
{
"biblio_id": 456,
"rules": ?
}

-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] stuck emails to koha-devel?

2023-09-11 Thread Tomas Cohen Arazi
I see this email.

El lun, 11 sept 2023 a las 12:21, Philippe Blouin (<
philippe.blo...@inlibro.com>) escribió:

> Hi!
>
> Someone here (Shi Yao) has been trying to write to koha-devel starting two
> weeks ago.  The emails never got through, nor he got any followup from
> koha-devel-owner.
>
> Anyone could help?  That would be greatly appreciated.
> --
> Philippe Blouin,
> Directeur de la technologie
>
> Tél.  : (833) 465-4276, poste 230
> philippe.blo...@inlibro.com
> inLibro | pour esprit libre | www.inLibro.com
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Testing DB upgrades

2023-09-06 Thread Tomas Cohen Arazi
Hi all, we've recently run into issues on the stable branches with DB
upgrades failing.

Jonathan put together a proposal that will help us catch those beforehand,
as mentioned on [bug 34683](
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34683).

Please take a look ASAP and help us move it.

--
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Warning: KTD problems with latest master

2023-09-05 Thread Tomas Cohen Arazi
Hi all. Today we pushed to master a needed upgrade for Cypress. The new
Cypress configuration file that is included in the master branch IS NOT
COMPATIBLE with older Cypress versions, and thus you need to pull the
latest KTD image in order for things to work.

I didn't expect a `ktd up` to fail because of this, but that's where we are
at. If someone has the time/bandwidth to look for options to overcome this,
much appreciated! [1] Otherwise, just pull the latest images as usual:

`ktd pull`

Kind regards

[1] We could be running Cypress on a separate container instead, but it
requires some ideating as it would evolve refactoring how we run tests in
Jenkins as well i.e. a single run to launch the tests vs. launching KTD and
then sequentially running some tests and then the cypress ones. It should
be doable, but tricky and needs a lot of thinking.

-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] KTD testers needed

2023-08-31 Thread Tomas Cohen Arazi
Hi all, I've been working on making things easier on ARM64 processors (M1,
M2, and so on) on top of the great work from Mason.

Now we need help testing a branch [1].

I specially need non-ARM testers, so we are sure nothing gets broken with
the change.

To test:
1. On your KTD clone do:
$ git remote add theke
https://gitlab.com/thekesolutions/koha-tools/koha-testing-docker.git
$ git checkout theke/issue_396 -b issue_396
2. Then
a. (x86_64 users) do your usual stuff, try playing with --es7, --os1, etc
b. (arm64 users) try different option switches. Use docker ps to check
which images have been picked, etc
3. Comment on the issue [2]

CAVEATS: I did it in a way that wouldn't affect our test suite. Might
deserve some refactoring once we settle things.

[1]
https://gitlab.com/thekesolutions/koha-tools/koha-testing-docker/-/tree/issue_396
[2] https://gitlab.com/koha-community/koha-testing-docker/-/issues/396

-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] plugins on KohaDevboxes

2023-08-31 Thread Tomas Cohen Arazi
What plugin is that?

El jue, 31 ago 2023 a las 17:16, Philippe Blouin (<
philippe.blo...@inlibro.com>) escribió:

> Hi!
>
> Any suggestion onto why our plugin doesn't seem to work on (bywater's)
> Devboxes while being perfectly fine in 22,23 or master local installs ?
>
> The UI of the config is all damaged, like the dropbox not being
> clickable.  Below first is the devbox version, versus our installations
> right after.
>
> Any hint would be greatly appreciated.
>
> Thanks
> --
> Philippe Blouin,
> Directeur de la technologie
>
> Tél.  : (833) 465-4276, poste 230
> philippe.blo...@inlibro.com
> inLibro | pour esprit libre | www.inLibro.com
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Koha versions 23.05.02, 22.11.08, 22.05.15 and 21.11.23 released

2023-08-07 Thread Tomas Cohen Arazi
The Koha community is proud to announce the latest releases of the current
stable, oldstable, oldoldstable and lts versions of the software.

This is a security and maintenance release on all branches, so please update
at the earliest opportunity.

As always, you can update using the already available packages, or download
the release from https://download.koha-community.org

Thank you very much to all release maintainers and the whole team involved
in this release.

Release notes for respective branches are available online now at:

 * https://koha-community.org/koha-23-05-02-released/
 * https://koha-community.org/koha-22-11-08-released/
 * https://koha-community.org/koha-22-05-15-released/
 * https://koha-community.org/koha-21-11-23-released/

--
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Tidy your code! And run the QA script!

2023-07-13 Thread Tomas Cohen Arazi
Hi all. I've been trying to push as much as I can from the PQA queue, and
I'm finding that most of the patches haven't been tidied up yet or have
trivially caught issues (maybe not most, but a lot).

For example, this is what I find when I run an up to date KTD and the code
is not tidy:

```
kohadev-koha@kohadevbox:koha(master)$ qa -c 1 --run-tests
testing 1 commit(s) (applied to e0df163 'fcf Bug 33933: Only show use
restrict')

Processing files before patches
|>| 2 / 2 (100.00%)
Processing files after patches
|>| 2 / 2 (100.00%)

 WARN Koha/Recalls.pm
   WARN  tidiness
The file is less tidy than before (bad/messy lines before: 41, now: 42)

 WARN t/db_dependent/Koha/Recalls.t
   WARN  tidiness
The file is less tidy than before (bad/messy lines before: 100, now: 101)


Processing additional checks OK!

Running tests (1)
* Proving /kohadevbox/koha/t/db_dependent/Koha/Recalls.t OK!
```

This is probably because they were submitted *before* we decided to enforce
it on the QA tools, and it is understandable that, in some cases, it was
not caught by a not-up-to-date QA command.

As all testers and QA team members are encouraged to run the `qa` script
before signing patches, I assume the underlying problem is that their KTD
images are old and don't contain the latest QA tools version. So please
make sure your KTD images or qa-test-tools clone is up to date. And run the
tool, all the time!

So, to sumarize:
- Patch authors need to tidy the new blocks of code they introduce, or
modify.
- Instructions on setting perltidy on your favourite editor can be found on
the wiki [1]. If your editor is missing, ask for help on IRC, the mailing
list, or just use one from the documented ones.
- QA members need to run the QA scripts.
- You need to build the habit of pulling the latest KTD images every now
and then. In case important things changed. And also run `docker system
prune -a` (while KTD is running, so only the old images are cleared)
- The RM will start failing patches that the QA script says have issues.
Both authors and testers have the ability to run the script before
submission. Every extra minute it takes to be gentle and fix the patch
inline makes us have less time to push your next stuff!

If you read all this, thank you! You are awesome! And I'm really glad to be
working on this side-by-side with you! And I hope to share some beers and
cookies in Helsinki soon!

Cheers!

[1] https://wiki.koha-community.org/wiki/Perltidy


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Roadmap 23.11

2023-06-21 Thread Tomas Cohen Arazi
Hi all, better late than never, here's the roadmap site for the upcoming
23.11 release:

https://wiki.koha-community.org/wiki/Roadmap_for_23.11

As mentioned a few times already, that's where you should put your goals
for the cycle, and the things you're willing to participate on. That way
the release team knows who to reach and what to track. Enhancements and new
features outside the roadmap document will have lesser priority for our
non-infinite time.

Team work is expected to take place.

Best regards

-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Dockerized Koha

2023-06-21 Thread Tomas Cohen Arazi
Hi all. We actually *have* a Docker image building pipeline [1]. If someone
wants to join the effort of publishing an official docker image, please put
it in the Roadmap wiki. That reminds me I didn't send the email about the
roadmap last week. Doing it right now.

Best regards.

[1]  https://gitlab.com/koha-community/docker/koha-docker

El mié, 21 jun 2023 a las 4:12, Thomas Klausner () escribió:

> Hi!
>
> On Wed, Jun 21, 2023 at 11:05:56AM +1000, David Cook wrote:
>
> > Do we have any appetite for starting to create a production-ready
> Dockerized
> > Koha?
>
> ++
>
> And while I have a lot of experience with deploying Perl apps using
> containers like Docker or Podman, I did not manage to get a (usable)
> Dockerfile / docker-compose for Koha running (in a reasonable amount of
> time; and then discovered koha-testing-docker for localdev..)
>
> But I could definitely again try to spend some time on this!
>
> Greetings,
> domm
>
>
> --
> #!/usr/bin/perl https://domm.plix.at
> for(ref bless{},just'another'perl'hacker){s-:+-$"-g&$_.$/}
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (https://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] git-bz update

2023-06-15 Thread Tomas Cohen Arazi
Hi all, I wanted to mention that the 'apply_on_cascade' branch for git-bz
has been updated with a merge request from Andrii and Slava to upgrade it
to Python 3. It should be bundled in the latest KTD.

Kudos for them, and any issues you may find, please file a report on the
project site [1].

Best regards

[1] https://gitlab.com/koha-community/git-bz

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Integrating MarcEdit on Linux with Koha

2023-06-08 Thread Tomas Cohen Arazi
It would be cool. I wasn't lucky when I contacted them offering to provide
an API. Good luck!

El jue, 8 jun 2023 21:04, David Cook  escribió:

> Hi all,
>
>
>
> Recently, I’ve been running the MarcEdit CLI tool cmarcedit.exe on Linux
> (using mono) to run task automations that were created by librarians using
> MarcEdit on Windows.
>
>
>
> I’m hoping to put together a Koha plugin to allow librarians to upload the
> tasks and choose which Koha MARC records to run them on. (In this case, it
> will be for export purposes rather than in-place updates, but easy enough
> for someone to change.)
>
>
>
> Does anyone think that sounds interesting?
>
>
>
> (Once the Koha REST API builds up a bit more for biblios/items and search,
> I was thinking of getting in touch with Terry Reese to see about improving
> the Koha integration in MarcEdit as well.)
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] A case against our release dates

2023-06-01 Thread Tomas Cohen Arazi
My personal feeling is we should have a release right before the hackfest.
So the hackfest sets the path for the next cycle. That could mean moving
the hackfest a couple a bit later too

Add for the second part of the year, I'm not sure yet. I just have the
perception everyone is out in the months we are expected to do the bigger
changes, and we end up doing them close to the release date.

El jue, 1 jun 2023 12:46, Philippe Blouin 
escribió:

> Of course I'm coming with my northern hemisphere perspective, and have no
> horse in the race really as being far from RM, but I always thought those
> dates were the best available.
>
> Seems earlier (04, april) makes it closer to the hackfest you referred.
> Later makes it closer to summer holidays.
>
> Were you considering breaking the equal split in time, having a small and
> a big release each year?  November for the big, and march for the small,
> the hackfest starting the next cycle ?  Thinking outside the box...
>
>
> Philippe Blouin,
> Directeur de la technologie
>
> Tél.  : (833) 465-4276, poste 230
> philippe.blo...@inlibro.com
> inLibro | pour esprit libre | www.inLibro.com
> On 2023-06-01 07:35, Tomas Cohen Arazi wrote:
>
> Hi all. Having served as Release Manager for the project a couple times,
> I'd like to ask y'all to think about the dates we've chosen and have stuck
> to the last few years for our releases.
>
> I know they are somehow aligned with our regular yearly meetings, and one
> each semester. But my experience says:
>
> - We all want to implement things we discuss in the Hackfest, but the
> release is too close. So we either push too late in the cycle, or need to
> cool down our brains/ideas for 'after the release in two months'.
> - The other scenario, which I suffered a lot recently (and will soon) is
> summer holidays in the northern hemisphere: you're all out when we should
> be pushing the riskier things to have enough time to fix things, and we end
> up rushing things... on the last third of the cycle.
>
> I don't have a proposal right now, but wanted to say my perception is the
> dates are not ideal as-is. And hear back from you all.
>
> Cheers!
>
> --
> Tomás Cohen Arazi
> Theke Solutions (http://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
>
> ___
> Koha-devel mailing 
> listkoha-de...@lists.koha-community.orghttps://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] A case against our release dates

2023-06-01 Thread Tomas Cohen Arazi
Hi all. Having served as Release Manager for the project a couple times,
I'd like to ask y'all to think about the dates we've chosen and have stuck
to the last few years for our releases.

I know they are somehow aligned with our regular yearly meetings, and one
each semester. But my experience says:

- We all want to implement things we discuss in the Hackfest, but the
release is too close. So we either push too late in the cycle, or need to
cool down our brains/ideas for 'after the release in two months'.
- The other scenario, which I suffered a lot recently (and will soon) is
summer holidays in the northern hemisphere: you're all out when we should
be pushing the riskier things to have enough time to fix things, and we end
up rushing things... on the last third of the cycle.

I don't have a proposal right now, but wanted to say my perception is the
dates are not ideal as-is. And hear back from you all.

Cheers!

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Koha 23.05 released

2023-05-31 Thread Tomas Cohen Arazi
The Koha community is proud to announce the release of Koha 23.05.00.

Koha 23.05.00 is a major release, that comes with many new features.

It includes 26 new features, 145 enhancements, 701 bugfixes.

The full release notes are available here:
https://koha-community.org/koha-23-05-released/

Debian packages should be available soon

Best regards

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Issues sending a JSON request body in a GET request to REST API

2023-05-12 Thread Tomas Cohen Arazi
David, that's correct, you should use the query parameter in that case. We
really added the possibility of passing the query in the request body
because we were looking for examples and that's what ES does. But it is not
used in Koha, internally.

El vie, 12 may 2023 a las 3:58, David Cook ()
escribió:

> In the short term, it appears I’ve forgotten about the “q” parameter. It
> takes an unencoded argument, so that’s getting me where I need to go…
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
>
> *From:* David Cook 
> *Sent:* Friday, 12 May 2023 4:47 PM
> *To:* 'Koha Devel' 
> *Subject:* Issues sending a JSON request body in a GET request to REST API
>
>
>
> Hi all,
>
>
>
> With the Koha REST API, there’s “Advanced Matching” which uses a JSON body
> in a GET request:
>
>
>
> curl -u koha:koha --request GET 'http://127.0.0.1:8081/api/v1/patrons/'
> --header "Content-Type: application/json" --data-raw '{ "-or": [ {
> "surname": { "-like": "Acev%" } }, { "firstname": { "-like": "Hen%" } } ] }'
>
>
>
>
> https://wiki.koha-community.org/wiki/Koha_REST_API_Users_Guide#Advanced_Matching
>
>
>
> While this technically works, we really shouldn’t be sending a JSON
> request body in a GET request.
>
>
>
> I’m working on a third-party system, and it’s actually preventing me from
> sending GET requests with request bodies (since GET requests aren’t
> supposed to have request bodies), so I can’t actually use the API using
> that system’s built-ins. I’ll have to code a workaround.
>
>
>
> At some point, we should replace these GET requests with POSTed search
> queries I think.
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Koha 23.05 - Release dates

2023-05-03 Thread Tomas Cohen Arazi
Hi all, we are a bit past the release dates. Time flied :-D

This are the release dates

* May 10th - "Hard" feature freeze, nothing considered as an improvement
will be pushed if not marked as Passed QA
* May 17th - String freeze, draft of release notes published
* May 24th - Only bug fixes considered major, critical or blocker will be
pushed
* May 31st - Final release

I'll do my best to push all the things, but please be available to answer
RM requests timely. Otherwise things will get deferred for the next cycle.

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Bug 32609 and package building

2023-04-26 Thread Tomas Cohen Arazi
The original implementation installed yarn inside the pdebuilder image [1].
But THERE'S a yarn/nodejs BUG [2] that prevents it from detecting
networking is available and thus cannot be run.

Looking forward for enhancing pull requests :-D

[1]
https://gitlab.com/koha-community/koha-dpkg-docker/-/blob/bfdbbd326e9e1e59fb903953205c8fe122f596d4/pbuilder.sh#L47
[2] The error we got:

"/usr/bin/perl" build-resources.PL

yarn install v1.22.19

warning You don't appear to have an internet connection. Try the --offline
flag to use the cache for registry queries.

warning Skipping preferred cache folder "/nonexistent/.cache/yarn" because
it is not writable.
warning Selected the next writable cache folder in the list, will be
"/tmp/.yarn-cache-1234".
[1/4] Resolving packages...
[2/4] Fetching packages...
<https://github.com/bywatersolutions/bywater-koha-future/actions/runs/4688302412/jobs/8398838574#step:7:4400>
error An unexpected error occurred: "
https://registry.yarnpkg.com/minimatch/-/minimatch-3.0.4.tgz: getaddrinfo
EAI_AGAIN registry.yarnpkg.com registry.yarnpkg.com:443".



El mié, 26 abr 2023 a las 20:08, David Cook ()
escribió:

> This looks like a weird hack to me. When the package is built,
> build-resources.PL should be invoked via the Makefile.
>
>
>
> What’s the problem that’s leading to this workaround?
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
>
> *From:* Koha-devel  *On
> Behalf Of *Tomas Cohen Arazi
> *Sent:* Wednesday, 26 April 2023 11:25 PM
> *To:* koha-devel 
> *Subject:* [Koha-devel] Bug 32609 and package building
>
>
>
> There's a conversation going on on the bug, about how that change made the
> build process a bit more complicated (i.e. more steps).
>
>
>
> Kyle and I have been working on this:
>
>
>
> https://gitlab.com/koha-community/koha-dpkg-docker#usage
>
>
>
> which is a simple way to build packages, and considers that required step.
>
>
>
> Hope it helps.
>
>
>
> --
>
> Tomás Cohen Arazi
>
> Theke Solutions (http://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Roles for 23.11 are open

2023-04-26 Thread Tomas Cohen Arazi
A new cycle is about to start. It is time for you all to put your names for
the next release.

Here: https://wiki.koha-community.org/wiki/Roles_for_23.11

Best regards

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Bug 32609 and package building

2023-04-26 Thread Tomas Cohen Arazi
There's a conversation going on on the bug, about how that change made the
build process a bit more complicated (i.e. more steps).

Kyle and I have been working on this:

https://gitlab.com/koha-community/koha-dpkg-docker#usage

which is a simple way to build packages, and considers that required step.

Hope it helps.

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Interesting syscalls when Starman starting up

2023-04-26 Thread Tomas Cohen Arazi
Koha has been using the Swagger/OpenAPI plugin since... 2015.

The validation step is important, especially when there are API plugins.
Plugins can break the API, and we need to check that. I'd like to hear
opinions about that,  though. And I am open to changing my mind.

Best regards

El mié, 26 abr 2023 a las 4:13, David Cook ()
escribió:

> Hey all,
>
>
>
> Years ago, I chatted with the author of Mojolicious::Plugin::OpenAPI about
> skipping the schema validation as it was causing extremely high server load.
>
>
>
> He added a config option for it in a newer version, and that version is
> available for Koha 22.11. I’ve tried turning on that config option but not
> sure if it’s working. I have more exploring to do.
>
>
>
> When I startup Starman for Koha 22.11, I still see a huge server load, and
> when I use strace, I see a long loop of the following:
>
>
>
> newfstatat(AT_FDCWD, "/usr", {st_mode=S_IFDIR|0755, st_size=4096, ...},
> AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share", {st_mode=S_IFDIR|0755, st_size=4096,
> ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha", {st_mode=S_IFDIR|0755,
> st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha/api", {st_mode=S_IFDIR|0755,
> st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha/api/v1", {st_mode=S_IFDIR|0755,
> st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger",
> {st_mode=S_IFDIR|0755, st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger/swagger.yaml",
> {st_mode=S_IFREG|0644, st_size=27644, ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger/swagger.yaml",
> {st_mode=S_IFREG|0644, st_size=27644, ...}, 0) = 0
>
> newfstatat(AT_FDCWD, "/usr", {st_mode=S_IFDIR|0755, st_size=4096, ...},
> AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share", {st_mode=S_IFDIR|0755, st_size=4096,
> ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha", {st_mode=S_IFDIR|0755,
> st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha/api", {st_mode=S_IFDIR|0755,
> st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha/api/v1", {st_mode=S_IFDIR|0755,
> st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger",
> {st_mode=S_IFDIR|0755, st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger/swagger.yaml",
> {st_mode=S_IFREG|0644, st_size=27644, ...}, AT_SYMLINK_NOFOLLOW) = 0
>
> newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger/swagger.yaml",
> {st_mode=S_IFREG|0644, st_size=27644, ...}, 0) = 0
>
>
>
> I’m guessing that might be caused by the following lines:
>
>
>
> $schema->resolve( $spec_file );
>
> my $spec = $schema->bundle->data;
>
>
>
> But I’ll have to investigate more…
>
>
>
> Koha used to start up quickly and with minimal overhead. Back when I was
> looking at Mojolicious::Plugin::OpenAPI, if I skipped the validation, I
> could start up with minimal overhead as well. Looks like things have
> changed over the past few years to keep the problem happening…
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Git server maintenance

2023-04-04 Thread Tomas Cohen Arazi
Hi all, we will be performing a maintenance task on the Git server during
the next hours.

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Koha objects

2023-04-04 Thread Tomas Cohen Arazi
The Koha::Objects query syntax is passed through. I guess you need to make
a regular join but call ->get_columns or smth.

El mar, 4 abr 2023 a las 9:07, Marcel de Rooy ()
escribió:

> Hi,
>
> Just a dumb question. But what is the best way to get a column from a
> joined table in the results of a Koha objects search?
> Or is it entirely impossible and should I switch back to DBIx stuff with
> +columns and the like ?
>
> Thanks,
> Marcel
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Your patches => your matter

2023-03-31 Thread Tomas Cohen Arazi
Hi all :-D

I wanted to ask everyone contributing patches to Koha, that when you get
notified your patches have been pushed, at least two things need to happen:

- You get happy
- You keep an eye on the test suite [1]

You get happy because it means a lot of people reviewed your stuff, spent
time and energy on making it real, and we all love that feeling.

We usually only push things that are fully covered by tests, but also
reviewed by various expert community members on their way to the main
branch. Hopefully you already had feedback from QA team members you had to
respond to. So, congrats :-D

But shit happens :-D There are at least two common scenarios:

- Your 'little change' that is covered by tests and stuff breaks things in
other places
- There are poorly coded tests somewhere else (old, that relied on other
ways of Koha doing things ,etc) that fail because of your change, or
because you're changing a behavior and didn't notice (neither the QA step)
things had to be adjusted somewhere else. It might happen... to everyone.

In both cases, we [2] are expecting YOU to keep an eye on Jenkins being
green, and also that you ACT, and FIX the issues, or communicate your
thoughts on them if you cannot solve it. If you don't know who to contact,
just go back to your bug and comment there, or just post a comment on IRC
and there will be someone to talk to, almost all day hours.

Those failures might 'just be minor things in the tests' or serious
regressions for our libraries. So don't treat jenkins not being green
lightly. PLEASE

We are always available to help, so fear none, you are not alone and the
best results show up when we work together.

BONUS: we'll think of a reward on the next Kohacon for those who look after
jenkins and help fixing it just because they care. Stay tuned.

Thanks everyone for your contributions, and making Koha so great :-D

[1] https://jenkins.koha-community.org
[2] The Release Team

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Heya

2023-03-31 Thread Tomas Cohen Arazi
Hi, the hackfest is over, we had great time!

I wanted to thank everyone supporting our open source work, and Biblibre
for making this opportunity to meet in person real.

Thanks!

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Problem configuring apache with mpm_itk

2023-03-01 Thread Tomas Cohen Arazi
Hi. The message you posted contains a command you're suggested to run to
get Apache properly configured.

But beware 22.11 on Ubuntu 18.04 is not officially supported.

El mié, 1 mar 2023 21:59, Christian Calle Jahuira 
escribió:

> Hi all,
>
> I found the following detail when installing koha 22.11 on ubuntu 18.4.
>
> ##
> root@PC:/home/christianjcj# sudo koha-create --create-db biblioteca
>
> AH00558: apache2: Could not reliably determine the server's fully
> qualified domain name, using 127.0.1.1. Set the 'ServerName' directive
> globally to suppress this message
> AH00558: apache2: Could not reliably determine the server's fully
> qualified domain name, using 127.0.1.1. Set the 'ServerName' directive
> globally to suppress this message
>
> Koha requires mpm_itk to be enabled within Apache in order to run.
> Typically this can be enabled with:
>
> sudo a2dismod mpm_event ; sudo a2enmod mpm_itk
>
> root@PC:/home/christianjcj#
>
> ##
>
> Can you help me.
>
> Thank you
>
> --
> Christian Jhonny Calle Jahuira
> Consultor de Sistemas de Informacion
> Ingeniero de Sistemas - Bibliotecologia
> Email: christian...@gmail.com
> Cel: 7893
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Pull newer images today :-D

2023-02-22 Thread Tomas Cohen Arazi
Hi, we've just pushed a change to Koha, moving away from node-sass to
dart-sass, and older docker images will fail as all assets are
automatically built on startup and it will fail otherwise.

Best regards

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] CI and packaging

2023-02-15 Thread Tomas Cohen Arazi
Hi all, we've been talking for a while by different means (IRC, pm,
hackfests, etc) about the need to build a solid pipeline for our testing
infrastructure, package building and testing and also the docker images.

Several individuals have implemented different things over time, for
building the packages. Today we had a nice Zoom session with Kyle, and this
is the result of picking the best ideas from each thing we found:

https://gitlab.com/koha-community/koha-dpkg-docker

We are still working on the README, but basically, with:

- Docker
- A Koha clone
- An environment variable passed

we can build the Debian packages. I think this is a great achievement and
kudos to Kyle for his contribution.

Thanks Kyle! Now to integrate it!

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] KTD and (Linux) Docker Desktop issues

2023-02-15 Thread Tomas Cohen Arazi
Hi all, community members have reported permissions issues breaking ktd
initialization when launching it fresh.

It's been narrowed down to be an issue with the Docker Desktop for Linux
product.

Please use the Docker Engine/server install instructions as pointed by the
readme.
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Compiled files removal from source tree

2023-02-10 Thread Tomas Cohen Arazi
Hi all, there's been chatter and work about this subject in the last weeks.
This is something we postponed until after the 22.11 release, which
includes Vue files and forced us to rethink our build pipeline.

Today we've done two important things you need to be aware of:
* Compiled CSS and JS files of all sorts removed from the tree [1]
* misc4dev (hence KTD) will now recomplile things for you when you start
KTD or when you run `reset_all` [2]

>From now on, you will be able to run `yarn build` and all the things will
be built as required. Feel free to inspect the package.json file for more
fine-grained commands that have been added. Particularly, you might find
the *watch commands useful if you are developing. And there are *prod
commands that will be used by the release maintainers and packaging manager.

Any enhancements you might want to propose are welcome.

Kudos to Jonathan, David Cook, Martin and Mason for the great work they did.

[1] https://gitlab.com/joubu/Koha/-/commits/bug_32609
[2] https://gitlab.com/koha-community/koha-misc4dev/-/merge_requests/58

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] koha-testing-docker is now installing pre-commit git hooks

2023-02-07 Thread Tomas Cohen Arazi
Excellent, thanks Jonathan.

El mar, 7 feb 2023 a las 10:31, Jonathan Druart (<
jonathan.dru...@bugs.koha-community.org>) escribió:

> Hi,
>
> We have a pre-commit hook in the wiki but people forget to install it. And
> it was not easy to update and propagate the changes. We decided to embed it
> in koha-testing-docker and install it automatically.
>
> So if you see a message telling you your commit is missing something,
> don't ignore it ;)
>
> Note that you can force the commit with --no-verify.
>
> It's working inside and outside a ktd shell.
>
> Cheers,
> Jonathan
>
> original issue in misc4dev which was then moved to ktd:
> https://gitlab.com/koha-community/koha-misc4dev/-/issues/59
> https://gitlab.com/koha-community/koha-testing-docker/-/issues/347
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Trouble for the Gitea project: forked to Forgejo

2023-02-01 Thread Tomas Cohen Arazi
Yeah, I meant the not-self hosted Gitlab, which we don't need to maintain.

El mié, 1 feb 2023 a las 11:15, Jonathan Druart (<
jonathan.dru...@bugs.koha-community.org>) escribió:

> I like gitea, it's faster than gitlab and it's good to have a self-hosted
> solution that is not draining a 16G 8cores server resources (I just put
> random numbers here)
>
> Le mer. 1 févr. 2023 à 14:51, Tomas Cohen Arazi  a
> écrit :
>
>> Can't we just use Gitlab for now?
>>
>> El mié, 1 feb 2023 a las 6:08, Jonathan Druart (<
>> jonathan.dru...@bugs.koha-community.org>) escribió:
>>
>>> See https://codeberg.org/forgejo/forgejo and
>>> https://forgejo.org/2022-12-15-hello-forgejo/
>>> "To this end we are very proud that Codeberg e.V. has decided to become
>>> our project’s custodian."
>>>
>>> Le mer. 1 févr. 2023 à 09:44, Marc Véron  a écrit :
>>>
>>>> Hi everybody
>>>> Why not https://codeberg.org/ ?
>>>> Regards
>>>> Marc
>>>>
>>>> Am 25.01.23 um 03:45 schrieb Victor Grousset/tuxayo:
>>>> > Hi :)
>>>> >
>>>> > Thanks David Nind for sharing this info on the last dev meeting:
>>>> >
>>>> >> Use of Gitea: We use Gitea for git.koha-community.org. Gitea was
>>>> >> "forked" and is now Forgejo[1] - see the links update and related
>>>> >> links[2] (sounds eerily familiar 8-(.. ). The community needs to
>>>> look
>>>> >> at what to do next, such as whether to continue to use Gitea, update
>>>> >> to Forgejo, do something else (David Nind)
>>>> >> [1] https://forgejo.org/
>>>> > > [2] https://forgejo.org/2022-12-26-monthly-update
>>>> >
>>>> > Comments during the meeting:
>>>> >
>>>> >> forgejo is the 'good' one?
>>>> >
>>>> >> that's what it looks like ^^
>>>> >
>>>> >> "After Gitea Ltd confirmed the takeover of the Gitea project on 30
>>>> >> October 2022, a group of people proposed that Codeberg e.V. should
>>>> >> become the custodian of a fork of Gitea. The proposal was accepted
>>>> 16
>>>> >> November 2022" - e.V. is a German thing actually
>>>> >
>>>> > More details:
>>>> >
>>>> > e. V. is the legal form for associations in Germany and Codeberg
>>>> e. V.
>>>> > is known for their Gitea (well, now Forgejo) instance that became
>>>> host
>>>> > to a decent number of libre projects in the last two years.
>>>> > (likely they moved away from GitHub and not wanted the not libre
>>>> > GitLab instance at GitLab.com (open-core))
>>>> >
>>>> >
>>>> > Trivia:
>>>> > > Forgejo (pronounced /forˈd͡ʒe.jo/) is inspired by forĝejo, the
>>>> > Esperanto word for forge.
>>>> >
>>>> >  I knew the name spelling looked familiar!
>>>> >
>>>> >
>>>> > Cheers,
>>>> >
>>>> ___
>>>> Koha-devel mailing list
>>>> Koha-devel@lists.koha-community.org
>>>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>>>> website : https://www.koha-community.org/
>>>> git : https://git.koha-community.org/
>>>> bugs : https://bugs.koha-community.org/
>>>>
>>> ___
>>> Koha-devel mailing list
>>> Koha-devel@lists.koha-community.org
>>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>>> website : https://www.koha-community.org/
>>> git : https://git.koha-community.org/
>>> bugs : https://bugs.koha-community.org/
>>>
>>
>>
>> --
>> Tomás Cohen Arazi
>> Theke Solutions (http://theke.io)
>> ✆ +54 9351 3513384
>> GPG: B2F3C15F
>>
>

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Trouble for the Gitea project: forked to Forgejo

2023-02-01 Thread Tomas Cohen Arazi
Can't we just use Gitlab for now?

El mié, 1 feb 2023 a las 6:08, Jonathan Druart (<
jonathan.dru...@bugs.koha-community.org>) escribió:

> See https://codeberg.org/forgejo/forgejo and
> https://forgejo.org/2022-12-15-hello-forgejo/
> "To this end we are very proud that Codeberg e.V. has decided to become
> our project’s custodian."
>
> Le mer. 1 févr. 2023 à 09:44, Marc Véron  a écrit :
>
>> Hi everybody
>> Why not https://codeberg.org/ ?
>> Regards
>> Marc
>>
>> Am 25.01.23 um 03:45 schrieb Victor Grousset/tuxayo:
>> > Hi :)
>> >
>> > Thanks David Nind for sharing this info on the last dev meeting:
>> >
>> >> Use of Gitea: We use Gitea for git.koha-community.org. Gitea was
>> >> "forked" and is now Forgejo[1] - see the links update and related
>> >> links[2] (sounds eerily familiar 8-(.. ). The community needs to look
>> >> at what to do next, such as whether to continue to use Gitea, update
>> >> to Forgejo, do something else (David Nind)
>> >> [1] https://forgejo.org/
>> > > [2] https://forgejo.org/2022-12-26-monthly-update
>> >
>> > Comments during the meeting:
>> >
>> >> forgejo is the 'good' one?
>> >
>> >> that's what it looks like ^^
>> >
>> >> "After Gitea Ltd confirmed the takeover of the Gitea project on 30
>> >> October 2022, a group of people proposed that Codeberg e.V. should
>> >> become the custodian of a fork of Gitea. The proposal was accepted 16
>> >> November 2022" - e.V. is a German thing actually
>> >
>> > More details:
>> >
>> > e. V. is the legal form for associations in Germany and Codeberg e. V.
>> > is known for their Gitea (well, now Forgejo) instance that became host
>> > to a decent number of libre projects in the last two years.
>> > (likely they moved away from GitHub and not wanted the not libre
>> > GitLab instance at GitLab.com (open-core))
>> >
>> >
>> > Trivia:
>> > > Forgejo (pronounced /forˈd͡ʒe.jo/) is inspired by forĝejo, the
>> > Esperanto word for forge.
>> >
>> >  I knew the name spelling looked familiar!
>> >
>> >
>> > Cheers,
>> >
>> ___
>> Koha-devel mailing list
>> Koha-devel@lists.koha-community.org
>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>> website : https://www.koha-community.org/
>> git : https://git.koha-community.org/
>> bugs : https://bugs.koha-community.org/
>>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] KTD, permissions and stuff

2023-01-11 Thread Tomas Cohen Arazi
Hi all, after several comments from people struggling with permissions,
yarn build, etc; I've went ahead and tweaked the new `ktd` command so the
default behavior is to jump into the container, on the instance user. i.e.

# this command will put you in what we traditionally call 'kshell'
ktd --shell
# and this command will put you in a root shell as before
ktd --root --shell

In addition to this, the instance user has been granted (in newer images)
sudo permissions (passwordless) and some of the traditional 'root' aliases
have been copied into its profile. There's probably some tidy to be done,
but this is a start.

The README has been adjusted a bit, please help tidying it until we decide
if we keep the old docs.

See you soon!

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Upgrading bugs.koha-community.org (plus others)

2023-01-03 Thread Tomas Cohen Arazi
I've seen some errors on saved reports. But it looks like DB structure
changes won't be easy to fix manually.

El mar, 3 ene 2023 a las 14:43, David Nind () escribió:

> Hi Chris.
>
> Thanks for all your work in supporting and maintaining these!
>
> I get this message when trying to access the IRC logs at
> http://irc.koha-community.org/koha/today
> Software error:
>
> Can't locate Date/Simple.pm in @INC (you may need to install the Date::Simple 
> module) (@INC contains: /home/chrisc/ilbot/lib/ /etc/perl 
> /usr/local/lib/x86_64-linux-gnu/perl/5.30.0 /usr/local/share/perl/5.30.0 
> /usr/lib/x86_64-linux-gnu/perl5/5.30 /usr/share/perl5 
> /usr/lib/x86_64-linux-gnu/perl/5.30 /usr/share/perl/5.30 
> /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at 
> /home/chrisc/ilbot/cgi/out.pl line 6.
> BEGIN failed--compilation aborted at /home/chrisc/ilbot/cgi/out.pl line 6.
>
> For help, please send mail to the webmaster (ch...@bigballofwax.co.nz),
> giving this error message and the time and date of the error.
>
> There are also server errors when accessing some of the links from
> http://irc.koha-community.org/
>
> David
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Upgrading bugs.koha-community.org (plus others)

2023-01-02 Thread Tomas Cohen Arazi
Great, thanks!

El lun, 2 ene 2023 22:10, Chris Cormack  escribió:

> Hi again all
>
> Everything should be back now, please let me know if you spot anything off.
>
> For those that are interested, I resized the server, changed it from
> i386 to amd64 and upgraded from Ubuntu 18.04 to 20.04. (18.04 goes out
> of support in April).
> It should be slightly faster with more ram available.
>
> Happy new OS for new year :)
>
> Chris
>
> On Tue, 3 Jan 2023 at 12:55, Tomas Cohen Arazi 
> wrote:
> >
> > Thanks for letting us know! Good luck!
> >
> > El lun, 2 ene 2023 19:54, Chris Cormack 
> escribió:
> >>
> >> Hi All
> >>
> >> The linode that bugs, dashboard, splitter, download, plus the bots run
> >> on needs an OS upgrade.
> >>
> >> I am about to snapshot it and attempt that now. The server may or may
> >> not go down for various parts of the upgrade. I will let you know when
> >> it has been completed of I have to rollback.
> >>
> >> Chris
> >> ___
> >> Koha-devel mailing list
> >> Koha-devel@lists.koha-community.org
> >> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> >> website : https://www.koha-community.org/
> >> git : https://git.koha-community.org/
> >> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Upgrading bugs.koha-community.org (plus others)

2023-01-02 Thread Tomas Cohen Arazi
Thanks for letting us know! Good luck!

El lun, 2 ene 2023 19:54, Chris Cormack  escribió:

> Hi All
>
> The linode that bugs, dashboard, splitter, download, plus the bots run
> on needs an OS upgrade.
>
> I am about to snapshot it and attempt that now. The server may or may
> not go down for various parts of the upgrade. I will let you know when
> it has been completed of I have to rollback.
>
> Chris
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Roadmap for v23.05

2023-01-02 Thread Tomas Cohen Arazi
Hi all, last cycle we worked through a roadmap which was not 100% finished,
but we made good progress in many of the main milestones:

- Task queue streamlining (several improvements, progress bars, etc)
- ERM (done)
- Introduction of Vue (done)
- Dates handling (partially done)
- Circ, holds, biblios and items refactoring (partially done)
- New staff interface (done)
- API refinements (partially done)
- Wiki migration (done)

Now, it is time for us to build a new one ofr this cycle. Please fill with
the things you plan to work on this cycle, and put your name so we all know
and can help each other.

https://annuel.framapad.org/p/Roadmap_for_Koha_v23.05

Thanks in advance!

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] KTD - stable branches

2022-12-23 Thread Tomas Cohen Arazi
Hi all, I made some pushes to the stable branches (22.11, 22.05 and 21.11)
so the images are (internally) aligned with (master's) `ktd` command.

Please let me know if you encounter any issues.

Merry xmas everyone!

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] The many failings of background_jobs_worker.pl

2022-12-21 Thread Tomas Cohen Arazi
You need to understand that you have dangling messages on your .

Old messages that have invalid JSON, and ids that were picked by the hybrid
fallback mechanism so fail (which I agree it's not cool)

Stop Koha, stop the worker, stop rabbit, clean rabbit, start the worker,
let it exhaust already injected tasks. Stop the worker, start rabbit, start
the worker, start Koha.

Sounds too much, doesn't it?



El mié, 21 dic 2022 10:59, Philippe Blouin 
escribió:

> Good evening, David,
>
> Thanks for the response.  Yours and David's and Michael's.  I feel less
> alone...
>
> I validated, and yes all the patches you refer are in our pile.  And until
> the problems arose, there were no customizations around that code.
>
> So yeah, even at 22.05.06, I get the JSON error and the race condition (we
> use ES).  And the *abandonned* children.  So I surmise, or dare I say
> postulate, that those issues are not as resolved as some would presume.
>
> I will revert background_jobs_worker.pl to its default, and shutdown MQ
> everywhere, for now.  :(
> Philippe Blouin,
> Directeur de la technologie
>
> Tél.  : (833) 465-4276, poste 230
> philippe.blo...@inlibro.com
> inLibro | pour esprit libre | www.inLibro.com
> On 2022-12-20 17:55, David Cook wrote:
>
> Salut Philippe,
>
>
>
> That first issue should’ve been resolved in 22.05.00 by
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172. I
> haven’t had any problems like that since applying that patch. Are you
> running Koha with or without customizations?
>
>
>
> As you say, bug 30654 discusses that second issue. And I obviously have my
> own opinion on that one .
>
>
>
> That JSON issue should be fixed by Bug 31351 in Koha 22.05.06 as well I
> believe: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
>
>
>
> --
>
>
>
> The only issue I’ve had with the background jobs has been the one covered
> by Bug 30172. Otherwise, it’s been all fine for me, although I use Zebra
> rather than Elasticsearch. I think part of the reason I haven’t had issues
> is that I haven’t had many people using the background jobs either though.
>
>
>
> I’m actually planning on writing a background job system based on RabbitMQ
> for a different non-Koha system. The main difference is that I’ll reject or
> fail tasks where messages aren’t sent to RabbitMQ. I think that’ll make my
> system a bit more robust than Koha’s.
>
>
>
> The problem with the background jobs at the moment is that we haven’t
> fully committed to RabbitMQ. We’re trying to do this weird hybrid with the
> database fallback which is not the right direction in my mind. We should do
> one or the other but not try to do both.
>
>
>
> But that’s just my 2 cents.
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
>
> *From:* Koha-devel 
>  *On Behalf Of *Philippe
> Blouin
> *Sent:* Wednesday, 21 December 2022 6:13 AM
> *To:* koha-devel@lists.koha-community.org
> *Subject:* [Koha-devel] The many failings of background_jobs_worker.pl
>
>
>
> Howdy!
>
> Since moving a lot of our users to 22.05.06, we've installed the worker
> everywhere.  But the number of issues encountered is staggering.
>
> The first one was
>
> Can't call method "process" on an undefined value
>
> where the id received from MQ was not found in the DB, and the process is
> going straight to process_job and failing.  Absolutely no idea how that
> occurs, seems completely counterintuitive (the ID comes from the DB after
> all), but here it is.  Hacked the code to add a "sleep 1" to fix most of
> that one.
>
> Then came the fact that stored events were not checked if the connection
> to MQ was successful at startup.  Bug 30654 refers it.  Hacked a little
> "$init" in there to clear that up at startup.
>
> Then came the
>
> malformed UTF-8 character in JSON string, at character offset 296 (before
> "\x{e9}serv\x{e9} au ...")
>
> at decode_json that crashes the whole process.  And for some reason, it
> never gets over it, gets the same problem at every restart, like the event
> is never "eaten" from the queue.  Hacked an eval then a try-catch over it...
>
> After coding a monitor to alert when a background_jobs has been "new" over
> 5 minutes in the DB, I was inundated by messages.  There's alway one
> elasticsearch_update that escapes among the flurry, and they slowly add up.
>
> At this point, the only viable solution is to run the workers but disable
> RabbitMQ everywhere.  Are we really the only ones experiencing that?
>
> Regards,
>
> PS Our servers are well-above-average Debian 11 machines with lot of
> firepower (ram, cpu, i/o...).
>
> --
>
> Philippe Blouin,
> Directeur de la technologie
>
> Tél.  : (833) 465-4276, poste 230
> philippe.blo...@inlibro.com
>
> inLibro | pour esprit libre | www.inLibro.com
>
> ___
> Koha-devel mailing list
> 

[Koha-devel] ktd - enhancements

2022-12-19 Thread Tomas Cohen Arazi
Hi all, just wanted to let you know that we solved a long standing issue in
KTD [1] that made it awkward to switch from using ES or not with KTD
(required tweaking the .env file and would break if things didn't match).

The `ktd` command now takes advantage of this enhancement so, as a
reminder, if you want to run KTD with ES 7 [2] you just need to run:

$ ktd --es7 up

Any questions about it, just ask on IRC or on this thread.

Best regards

[1] https://gitlab.com/koha-community/koha-testing-docker/-/issues/306
[2] ktd --help will show you all the available options

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Jenkins notifications

2022-12-14 Thread Tomas Cohen Arazi
Hi all, I've (finally) restored jenkins notifications, and I plan to send
failure notifications to:

- Release maintainers
- QA team

Developers whose commits are suspected to have broken the tests will still
be notified.

I created two forwarding addresses to simplify notifications as well.

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] What's the definitive way to use Perl tidy in koha-testing-docker?

2022-12-11 Thread Tomas Cohen Arazi
I normally point vscode's perltidy extension to the shipped perltidyrc:

https://git.koha-community.org/Koha-community/Koha/src/branch/master/xt/perltidyrc

and do Ctrl+k-f on the region I'm editing.


El vie, 9 dic 2022 0:27, David Cook  escribió:

> Hi all,
>
>
>
> I’ve heard a few people saying lately that they wish people would use Perl
> tidy more.
>
>
>
> So I used the “:Tidy” command in koha-testing-docker on my visual
> selection and I got the following:
>
>
>
> +$this_item->{shelves} =
>
> +  Koha::Virtualshelves->get_shelves_containing_record(
>
> +{
>
> +biblionumber   => $biblionumber,
>
> +borrowernumber => $loggedinuser,
>
> +}
>
> +  );
>
>
>
> But that goes against the Indentation coding guidelines from
> https://wiki.koha-community.org/wiki/Coding_Guidelines#Indentation
>
>
>
> So… what are we supposed to be doing these days?
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Good enough?

2022-12-06 Thread Tomas Cohen Arazi
What is your dev environment like? a dev install? on the host OS or a VM?

We tried hard to make the misc4dev tools agnostic of KTD. Feedback is
welcome.

El mar, 6 dic 2022 a las 9:17, Marcel de Rooy ()
escribió:

> > As said in the email I am planning to integrate them into our dev
> env (via misc4dev), see
>
> Great but please note that 'our dev env' is not per definition KTD for
> everybody.
> What we do share is the git repo 
>
> Marcel
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Fundamental flaw in Koha REST API

2022-12-05 Thread Tomas Cohen Arazi
I recall we used the header at some point, to keep the base query clean
when adding new filters.

The only alternative is forcing the use of some form of ascii encoding
(base64?) But I agree we should better deprecate it.

It's use in the codebase on DT is tied to an option switch and probably not
used



El lun, 5 dic 2022 20:08, Galen Charlton  escribió:

> Hi,
>
> On Mon, Dec 5, 2022 at 5:40 PM David Cook 
> wrote:
> > At the moment, it’s not widely used by Koha itself, so I don’t think
> > it will be hard to remove from Koha, but any third-party integrations
> > would need to refactor to use a different option.
>
> This might not be a huge factor, though of course removing that header
> should go through a deprecation procedure.
>
> Specifically, upon skimming the results of a GitHub search of
> "x-koha-query", the only uses I found outside of Koha itself were in
> plugins published by a couple active community members.
>
> Regards,
>
> Galen
> --
> Galen Charlton
> Implementation and IT Manager
> Equinox Open Library Initiative
> g...@equinoxoli.org
> https://www.equinoxOLI.org
> phone: 877-OPEN-ILS (673-6457)
> direct: 770-709-5581
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Good enough?

2022-12-05 Thread Tomas Cohen Arazi
El lun, 5 dic 2022 a las 14:24, Julian Maurice ()
escribió:

> Yes it is expensive. But manual testing is much more expensive. I'd
> rather pay for some CPU time than do manually what a bot can do better
> and faster than me. Free services exist too (CircleCI, github actions, ...)
>

When you develop, you usually add some tests and run them, along with
related ones that could be broken because of the changes. Running the full
test suite is not mandatory.
Pushing to a branch somewhere there's CI setup to run the full test suite
sounds like a good idea.


>
> Pushing to a temporary master branch is not a bad idea (a never-broken
> master branch sounds nice), but I think it would happen too late.
> Patches would have already been rebased multiple times, tested and
> reviewed before we notice a test failure.
>

Agreed!


> koha-testing-docker feels more like a symptom of the difficulty to run
> tests than a satisfying solution. It is probably necessary in order to
> run complicated end-to-end tests, but it should not be mandatory to run
> simple unit tests.
> And ktd is not that easy to use. It can break, and it's not easy to
> debug for someone not familiar with docker.
>

I don't think it is mandatory, but it is the most convenient way to run in
a controlled environment that matches as much as possible the conditions in
production. That said, I'm pretty sure we could rely on carton or
local::lib to generate an environment to work locally.


> Don't you think it would be a lot easier if we could run `prove t` (or
> `npm test` or whatever) on any dev setup and have the same
> failures/successes as Jenkins (minus the complicated tests like those
> that require selenium) ?
> Of course making that happen is not an easy task, but it should be a
> long term goal IMO.
>
> Also I think no one wants to be the person that refuse a patch because a
> comment is misaligned, so if that kind of thing is not automated, "not
> good enough code" will continue to be pushed.
>
>
> Le 05/12/2022 à 14:55, Jonathan Druart a écrit :
> > I don't think we should run the whole test suite everytime we attach
> > patches, that would be very expensive in terms of resources.
> > However it would be interesting to have a temporary 'master' branch
> > that would become 'master' only if jenkins is happy.
> > "master" would never be broken :D
>

That would only save us some reverts if the authors fail to provide fixes.
But I don't think reverts happen so often we need  to change our workflow
to avoid them. And jenkins to fail is the goal of it. We don't need it
green all day, we need it to catch the errors (lots of errors are not
covered by tests, and that's something we need to invest time on) and devs
to take responsibility of fixing their breakages. I will take the blame
there, because Jenkins notifications are not reaching the devs inboxes, and
we need it fixed ASAP.

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Good enough?

2022-12-05 Thread Tomas Cohen Arazi
El vie, 2 dic 2022 a las 11:43, Jonathan Druart (<
jonathan.dru...@bugs.koha-community.org>) escribió:

> 10. CI should drive the pushes. No more push if CI is not green. The
> more we wait the harder it is to track down the origin of the problem.
> Last cycle some jobs have been red for months, and we released
> 22.11.00 with D10, D11, D12 marked unstable...
>

That assertion is not that precise. We've had lots of failures during the
cycle which were addressed sooner or later.
The only long standing one was a selenium test failure we couldn't
reproduce locally, and was more about the test suite setup than a Koh
failure.

And we only released once things were green :-D

I will answer about the rest of the email later. But I will mention that
everyone can:

$ ktd --selenium --es7 --sso up -d

and be able to test everything locally [1].

And I'm available to chat or troubleshoot that.

[1] With the exception of macOS + ARM users.

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] release-tools

2022-11-28 Thread Tomas Cohen Arazi
Yeah, I'm rewriting the script. Will do some cleanup after that, of course.

El lun, 28 nov 2022 a las 16:59, Renvoize, Martin (<
martin.renvo...@ptfs-europe.com>) escribió:

> Sounds solid to me.. I might have removed the bash script at the same time
> as introducing to functionality into the main script though. ;)
>
> Once I've got myself back up to speed on the release process from an
> rmaint view I'll be more than happy to help refine it 
>
> On Mon, 28 Nov 2022, 1:36 pm Tomas Cohen Arazi, 
> wrote:
>
>> Hi all this is for rmaints mostly, I've just added a new 'tarball' option
>> to koha-release. Please review and comment if you'd prefer some other way
>> to do this.
>>
>> Also, I think we should work on the release tools a bit so all parameters
>> are named and have option switches to simplify the code.
>>
>> Objections?
>>
>> --
>> Tomás Cohen Arazi
>> Theke Solutions (http://theke.io)
>> ✆ +54 9351 3513384
>> GPG: B2F3C15F
>> ___
>> Koha-devel mailing list
>> Koha-devel@lists.koha-community.org
>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>> website : https://www.koha-community.org/
>> git : https://git.koha-community.org/
>> bugs : https://bugs.koha-community.org/
>>
>

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] release-tools

2022-11-28 Thread Tomas Cohen Arazi
Hi all this is for rmaints mostly, I've just added a new 'tarball' option
to koha-release. Please review and comment if you'd prefer some other way
to do this.

Also, I think we should work on the release tools a bit so all parameters
are named and have option switches to simplify the code.

Objections?

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Koha 22.11.00 Rosalie released

2022-11-25 Thread Tomas Cohen Arazi
The Koha community is proud to announce the release of Koha 22.11.00.

Koha 22.11.00 is a major release, that comes with many new features.

It includes 13 new features, 351 enhancements, 3 security fixes, 551
bugfixes.

The full release notes are available here:
https://koha-community.org/koha-22-11-released/


Debian packages should be available soon

Best regards

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] [Koha] Some very sad news.

2022-11-18 Thread Tomas Cohen Arazi
Yeah! This release will be dedicated to Rosalie.

Great call!

El vie, 18 nov 2022 12:19, Paul Poulain 
escribió:

> Hi Chris,
>
> Sad news, let us know when the funerals are.
>
> @community : May I suggest that we name the next release "Koha 22.11
> Rosalie" ?
>
> Le 17/11/2022 à 08:09, Chris Cormack a écrit :
> > Tēnā koutou
> >
> > It is with great sadness that I pass on to you all the news that
> > Rosalie Blake has passed away.
> > Rosalie was the Head Librarian at Horowhenua Library Trust when Koha
> > was started and without her Koha would not exist.
> > But more than this Rosalie was an amazing person, a librarian who
> > always thought outside the box, a gifted potter, a friend to many and
> > a beloved mother and grandmother.
> >
> > Details around the funeral and memorial note should be available
> > tomorrow. But I am sure you will all join me holding Rosalie's family
> > and friends in your thoughts.
> >
> > Tiwhatiwha te pō, tiwhatiwha te ao.
> >
> > Chris
> >
> > ___
> > Koha-devel mailing list
> > Koha-devel@lists.koha-community.org
> > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> > website : https://www.koha-community.org/
> > git : https://git.koha-community.org/
> > bugs : https://bugs.koha-community.org/
>
> --
> Paul Poulain, Associé-gérant / co-owner
> BibLibre, Services en logiciels libres pour les bibliothèques
> BibLibre, Open Source software and services for libraries
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] OIDC client pushed to master!

2022-11-09 Thread Tomas Cohen Arazi
Thank you David for all your valuable input. Looking forward to those
follow-ups.

El mar, 8 nov 2022 a las 23:36, David Cook ()
escribió:

> I was pumped to see this morning that the OIDC client was pushed to master!
>
>
>
> I have 2 very easy follow-ups that I think are necessary before the
> feature is prod ready, so if someone could take a look at those, that would
> be awesome.
>
>
>
> Bug 32138 - OIDC client uses backwards default mapping
>
> Bug 32139 - "Update on login" setting not set when creating domain from
> new IdP page
>
>
>
> A nice to have would also be the following although not necessary from a
> functionality point of view:
>
> Bug 32141 - New and Edit Identity Provider UIs inconsistent
>
>
>
> Thanks!
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] ERM - workflow change

2022-11-09 Thread Tomas Cohen Arazi
Hi all, we pushed ERM but didn't communicate some decisions made:

- For running the ERM component (and in the future any other Vue-driven
thing) a build step needs to happen. Either:

$ yarn build_js

or (the dev-oriented version):

$ yarn watch_js

- We could've gone 'the SCSS' way, in which the RM(aint) compiles the thing
and pushes to Git along with the changes. But we decided it would have an
impact on the size of the repository pretty fast. So for now, the decision
is we will do it at release time. This is also common practice on Vue
projects.

- We could add the build as part of the 'reset_all' command KTD users are
familiar with. TBD

- Yes, now that running Koha requires a build step, we could just add SCSS
there, that's to be discussed early next cycle.

- We need a way to pre-bundle all the dependencies in KTD, so people can
fire up KTD while being offline. Agustín is wrapping up a proposal for
this. TBD

Please share your thoughts, and sorry for not communicating this earlier.

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] New pushes, new KTD images

2022-11-09 Thread Tomas Cohen Arazi
Hi all, both ERM and the OIDC/OAuth2 integration have been pushed. As some
of you noted, they have new dependencies. New KTD images have been built
before pushing to avoid issues, so please do the usual so things keep
working:

$ ktd pull

Best regards

PS: If you use other ktd flags, you can also pull like:

$ ktd --selenium --es7 --sso pull

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] KTD // SSO

2022-11-07 Thread Tomas Cohen Arazi
Hi all, time to git pull on your koha-testing-docker clone: we have just
added a docker-compose.sso.yml file that can be used for launching an IdP,
based on keycloak.

As usual, the `ktd` script options got a new `--sso` option switch for
enabling it. The keycloak server is running on port 8082.

This is how I launch things on my dev environment, if anyone is interested:

$ ktd --es7 --selenium --sso up -d

Kudos for David Cook, who provided the tools to build this.

Best regards

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] [Koha] Koha 22.05.04: Can't locate Koha/Script.pm in @INC

2022-10-29 Thread Tomas Cohen Arazi
Yeah, the docs are really generic, and there are several ways to install
Koha. Packages (i.e. having koha-shell) is one of them. Please file an
issue on the manual's project so we document it better.

Regarding the fact it worked before, have you changed the server? It is not
working because of the lack of some environment variables being set, which
is usually the case when we reinstall  on a new server and forgot all the
tweaks we did over time. I've been there, many times heh.

Regardless, running things as root can cause trouble with logs and lock
files permissions. Some default cronjobs can fail to run because of that,
hence the recommendation. There are also security concerns but that's out
of the scope here.

El sáb, 29 oct 2022 5:11, Michael Kuhn  escribió:

> Hi Thomas
>
> You wrote:
>
>  > Are you by chance running the command in the root shell?
>
> Yes I am, I always did (and it worked up to Koha 21.11).
>
> For now it worked using:
>
> # export KOHA_CONF=/etc/koha/sites/library/koha-conf.xml
> # export PERL5LIB=/usr/share/koha/lib
> # /usr/share/koha/bin/migration_tools/bulkmarcimport.pl -b -m marcxml
> -framework=ABC -file TITEL.marcxml -v 2
>
>  > You should always run it inside koha-shell
>
> OK - next time I'll try:
>
> $ sudo koha-shell -c
> "/usr/share/koha/bin/migration_tools/bulkmarcimport.pl -b -m marcxml
> -framework=ABC -file TITEL.marcxml -v 2" library
>
> Unfortunately
> https://perldoc.koha-community.org/misc/migration_tools/bulkmarcimport.html
> does not give the correct information how to run this script.
>
> Best wishes: Michael
> --
> Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis
> Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz
> T 0041 (0)61 261 55 61 · E m...@adminkuhn.ch · W www.adminkuhn.ch
>
>
> > El vie, 28 oct 2022 8:03, Michael Kuhn  > > escribió:
> >
> > Hi
> >
> > I am running a fresh installation of Koha 22.05.04 on Debian 11.
> >
> > I am trying to load some data using "bulkmarcimport.pl
> > ":
> >
> > # export KOHA_CONF=/etc/koha/sites/library/koha-conf.xml
> > # /usr/share/koha/bin/migration_tools/bulkmarcimport.pl
> >  -b -m marcxml
> > -framework=ABC -file TITEL.marcxml -v 2
> > Can't locate Koha/Script.pm in @INC (you may need to install the
> > Koha::Script module) (@INC contains: /etc/perl
> > /usr/local/lib/x86_64-linux-gnu/perl/5.32.1
> > /usr/local/share/perl/5.32.1
> > /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5
> > /usr/lib/x86_64-linux-gnu/perl-base
> /usr/lib/x86_64-linux-gnu/perl/5.32
> > /usr/share/perl/5.32 /usr/local/lib/site_perl) at
> > /usr/share/koha/bin/migration_tools/bulkmarcimport.pl
> >  line 13.
> > BEGIN failed--compilation aborted at
> > /usr/share/koha/bin/migration_tools/bulkmarcimport.pl
> >  line 13.
> >
> > "Script.pm" seems to be there:
> >
> > # ls -al /usr/share/koha/lib/Koha/Script.pm
> > -rw-r--r-- 1 root root 4129 24. Aug 07:51
> > /usr/share/koha/lib/Koha/Script.pm
> >
> > How can I get script "bulkmarcimport.pl "
> > to actually run?
> >
> > Best wishes: Michael
> > --
> > Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg.
> Fachausweis
> > Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz
> > T 0041 (0)61 261 55 61 · E m...@adminkuhn.ch
> >  · W www.adminkuhn.ch <
> http://www.adminkuhn.ch>
> > ___
> >
> > Koha mailing list http://koha-community.org <
> http://koha-community.org>
> > k...@lists.katipo.co.nz 
> > Unsubscribe: https://lists.katipo.co.nz/mailman/listinfo/koha
> > 
> >
>
>
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] [Koha] Koha 22.05.04: Can't locate Koha/Script.pm in @INC

2022-10-29 Thread Tomas Cohen Arazi
Are you by chance running the command in the root shell? You should always
run it inside koha-shell

El vie, 28 oct 2022 8:03, Michael Kuhn  escribió:

> Hi
>
> I am running a fresh installation of Koha 22.05.04 on Debian 11.
>
> I am trying to load some data using "bulkmarcimport.pl":
>
> # export KOHA_CONF=/etc/koha/sites/library/koha-conf.xml
> # /usr/share/koha/bin/migration_tools/bulkmarcimport.pl -b -m marcxml
> -framework=ABC -file TITEL.marcxml -v 2
> Can't locate Koha/Script.pm in @INC (you may need to install the
> Koha::Script module) (@INC contains: /etc/perl
> /usr/local/lib/x86_64-linux-gnu/perl/5.32.1 /usr/local/share/perl/5.32.1
> /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5
> /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32
> /usr/share/perl/5.32 /usr/local/lib/site_perl) at
> /usr/share/koha/bin/migration_tools/bulkmarcimport.pl line 13.
> BEGIN failed--compilation aborted at
> /usr/share/koha/bin/migration_tools/bulkmarcimport.pl line 13.
>
> "Script.pm" seems to be there:
>
> # ls -al /usr/share/koha/lib/Koha/Script.pm
> -rw-r--r-- 1 root root 4129 24. Aug 07:51
> /usr/share/koha/lib/Koha/Script.pm
>
> How can I get script "bulkmarcimport.pl" to actually run?
>
> Best wishes: Michael
> --
> Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis
> Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz
> T 0041 (0)61 261 55 61 · E m...@adminkuhn.ch · W www.adminkuhn.ch
> ___
>
> Koha mailing list  http://koha-community.org
> k...@lists.katipo.co.nz
> Unsubscribe: https://lists.katipo.co.nz/mailman/listinfo/koha
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Koha Wiki migrated and upgraded

2022-10-27 Thread Tomas Cohen Arazi
Excellent work Thomas!

Congratulations for getting it done so well.

Thanks!!!

El jue, 27 oct 2022 a las 9:29, Thomas Dukleth ()
escribió:

> [For those not subscribed or giving attention to the Koha mailing list, I
> repeat the announcement here without in message cross-posting.]
>
> The Koha Wiki now running MediaWiki Canasta has been up for a few hours at
> the usual DNS subdomain https://wiki.test.koha-community.org .  The wiki
> is now up to date with MediaWiki 1.35.07 long term stable using a MySQL
> database and ElasticSearch with many fine enhancements such as
> xVisualEditor, customised AdvancedSearch, and dynamic archiving of
> obsolete pages (which often still have useful information).  Please see
> further below for details.
>
> Unfortunately, the mail system on the server for the wiki for resetting
> wiki login passwords, or creating new login users, etc. had previously
> become broken and was missed for fixing amidst all the work which people
> have been doing for releasing a new Koha version.  Someone will send a
> message when the mail system is fixed.  If you know your Koha wiki login
> username and password from previously, they will work.
>
> There are problably many problems with result set relvance for search
> queries within the wiki.  We will fix them over time and relevance ranking
> should automatically improve with use, although, maintenance changes may
> often count as use eroding recently updated relevance.  The wiki is now
> using ElasticSearch which is used by Wikipedia and has better extension
> support than database based indexing.  See some details about the
> customised AdvancedSearch and the need for careful consideration in
> improving search query indexing further below.
>
> Sitemap creation, which assists Google and other web indexing systems in
> indexing the Koha wiki, may not be working correctly in the way in which
> we have configured the MediaWiki Canasta Docker container.  Google and
> others can still index the content without the sitemap but the process
> functions better with a sitemap.  The Canasta Docker container does some
> things differently than the way they would function in a standard
> environment such that less effort should be required for maintenance tasks
> but we need a little more time to examine how some things such as sitemap
> creation are intended to function in Canasta.  We should always be able to
> use methods ordinarily used for sitemap creation in a standard environment
> if necessary.
>
> The Koha MediaWiki Canasta test instance should continue to be available
> for first testing significant changes and bug fixes, at
> https://wiki.test.koha-community.org .  Please do not make wiki
> contributions that you want to save in the MediaWiki Canasta test instance
> as they will not be carried over to the production wiki.  Continue to make
> lasting contributions to the production wiki at
> https://wiki.koha-community.org .
>
> Please read below for an understanding of what to expect before reporting
> issues about which we are already aware, such as the test database is not
> a current copy of the wiki and the mail system for resetting login
> passwords and creating new login users is not working.
>
> You may report bugs to the bug "wiki needs updating to a later version",
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 .
>
> WIKI DATABASE MIGRATION, UPGRADE, AND CONTAINER MANAGEMENT.
>
> Migrating the Koha MediaWiki database from Postgres to MySQL and upgrading
> to MediaWiki 1.35.07, the current long term stable version used a
> repeatable process managed with a set of scripts which I developed in
> bash, Perl, and Python as appropriate for the task and previous code in
> the case of Python.  Choosing Postgres as the database for a test instance
> for MediaWiki had left us with a mistake in database choice complicating
> compatibility and future upgrades when the MediaWiki test suddenly became
> the only Koha wiki running when the previous Koha wiki went down in the
> midst of a community schism with LibLime long ago.  The database migration
> and upgrade process has been developed and progressively tested over the
> course over time from 2019 for ensuring that the database is migrated
> correctly, etc.  I built the database migration process upon the
> originally incomplete and sometimes mistaken Python script of Philipp
> Spitzer which was a fantastic proven starting point without which the task
> may have been some degree too much.
>
> Mason James ran a web crawl and diff test to verify that the production
> and another test database migration and upgrade of the wiki had the same
> content except for evident changes where the production wiki had been
> updated with new content.
>
> The database was imported to MediaWiki Canasta which Tomás Cohen Arazi
> identified and customised to connect to the Koha Portainer Docker
> container management to provide MediaWiki in a Docker container with a
> large set of important 

Re: [Koha-devel] [Koha] Koha 22.05.06 is here!

2022-10-25 Thread Tomas Cohen Arazi
:-D

El mar, 25 oct 2022 a las 15:33, Lucas Gass ()
escribió:

> Hello, Hola, Bonjour, Guten tag, Olá!
>
> The Koha community is proud to announce the release of Koha 22.05.06!
>
> Koha 22.05.06 includes 8 enhancements, 42 bugfixes, and 1 security fix.
>
> The full release notes can be found here:
> https://koha-community.org/koha-22-05-06-released/
> 
>
> Debian packages should be available shortly!
>
>
>
> --
> Lucas Gass
> Web Developer
> ___
>
> Koha mailing list  http://koha-community.org
> k...@lists.katipo.co.nz
> Unsubscribe: https://lists.katipo.co.nz/mailman/listinfo/koha
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] [Koha] OAI-PMH harvester

2022-10-25 Thread Tomas Cohen Arazi
I think with background jobs we have most of the framework that is needed
to deal with this within Koha.

Best regards

El mar, 25 oct 2022 7:08, BOUIS Sonia  escribió:

> Hi,
> KohaLA would like to finance an OAI-PMH client in Koha but, we have
> questions that we want to raise to the community.
> There was already tries to propose an OAI-PMH client :
> - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 : it's
> an old project that doesnt seem compatible with the current version of Koha
> - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25905 : the
> scope is more to use an external OAI-PMH client and to connect it to Koha
>
> Our main question is about the way to handle this. Do you think that it's
> a better idea to use an external software or PERL routine and to find a way
> to connect it to Koha. Or would it be better to a new module in Koha from
> scratch and that Koha have his own OAI-PMH client.
>
> Please, let us hear your toughts about this projet.
>
> Kind regards
>
> Sonia
>
> Sonia BOUIS
> --
> Responsable du Service informatique documentaire
> Département d'Appui à la Recherche et aux Projets (DARP)
> Bibliothèques universitaires
> Université Jean Moulin Lyon 3
> ADRESSE GÉOGRAPHIQUE > Manufacture des Tabacs | 6 cours Albert Thomas |
> LYON 8e
> ADRESSE POSTALE > Bibliothèque de la Manufacture | 1C avenue des Frères
> Lumière | CS 78242 - 69372 LYON CEDEX 08
>
> Ligne directe : 33 (0)4 78 78 79 03
>
> http://bu.univ-lyon3.fr| Suivez-nous > Facebook<
> https://www.facebook.com/bulyon3/> | Twitter|
> Instagram
>
> ___
>
> Koha mailing list  http://koha-community.org
> k...@lists.katipo.co.nz
> Unsubscribe: https://lists.katipo.co.nz/mailman/listinfo/koha
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


[Koha-devel] Koha 22.11 - Release dates

2022-10-17 Thread Tomas Cohen Arazi
Hi all, this cycle has been very busy and all of a sudden, it is ending!

This are the preliminary dates so you are aware of:

* Oct 28th - "Soft" feature freeze, nothing big or with high risk of
side-effects will be included into the final release if not marked
as Passed QA
* Nov 3-5 - "Hard" feature freeze, nothing considered as an improvement
will be pushed if not marked as Passed QA
* Nov 10th - String freeze, draft of release notes published
* Nov 17th - Only bug fixes considered major, critical or blocker will be
pushed
* Nov 25th - Final release

PM me if you have any comments.

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] an SMS Send issue - wondering if it is possible to do with Koha

2022-10-02 Thread Tomas Cohen Arazi
I'd say we could add a hook for plugins to inject variables for notices.



El dom, 2 oct 2022 4:01, Indranil Das Gupta  escribió:

> Hi all,
>
> I've written a new SMS::Send driver module for NIC SMS service (a
> federal IT service provider to Govt agencies in India). It's working
> fine on its own.
>
> India's current anti-spam rules demands that every message template
> (e.g. "Dear member {#var#} you have checked out {#var#}") must have to
> its unique 19 digit identifier mapped against the designated sender
> (e.g. the library) in the federal blockchain system for SMS
>
>
> https://smsgw.sms.gov.in/failsafe/HttpLink?username==x=This
> is a test
> message=91XX=sender_id_entity_id=xxx_template_id=xxx
>
> That last part - dlt_template_id will be different for each message
> template mapped against a specific dlt_entity_id. The sender_id and
> dlt_entity_id is easily taken care of via yaml (bug 13029).
>
> I can map the letter_code against dlt_template_id using the yaml, but
> is there a way by which I can push it to SMS.pm?
>
> thanks in advance.
>
> --
> Indranil Das Gupta
> L2C2 Technologies
>
> Phone : +91-98300-20971
> WWW : http://www.l2c2.co.in
> Blog: http://blog.l2c2.co.in
> IRC : indradg on irc://irc.freenode.net
> Twitter : indradg
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] A guide for testing Koha's REST API

2022-09-15 Thread Tomas Cohen Arazi
Thank you!!

El jue, 15 sept 2022 6:48, Mason James  escribió:

> hi folks
>
> i've made a guide here...
>
>   https://wiki.koha-community.org/wiki/REST_API_Debug
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Enable libraries to moderate OPAC self-registrations

2022-09-12 Thread Tomas Cohen Arazi
I'm not planning to work on that in a short term.

El lun, 12 sept 2022 a las 5:20, Alex Buckley ()
escribió:

> Good point Tomas.
>
> An unmoderated patron registration would be like a staged (but not
> imported) patron record.
>
> I see you created a bug report for that functionality on
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20916
>
> Were you planning on working on that or is it available for others to work
> on it?
>
>
> On 7/09/22 03:04, Tomas Cohen Arazi wrote:
>
> I think we need to resurrect the idea of a patron import staging + import
> step. This one being a particular use case.
>
> El mar, 6 sept 2022 a las 7:43, Katrin Fischer ()
> escribió:
>
>> Hi all,
>>
>> I think the feature would be useful. :)
>>
>> I feel there has been some misunderstanding about the
>> borrower_modifications table. It doesn't require a valid borrowernumber as
>> the table is used for at least 2 purposes already:
>>
>> * Patron data modification requests from the OPAC (borrowernumber of
>> patron)
>>
>> * Patron self registrations with required email verification
>> (borrowernumber = 0)
>>
>> It's used as a temporary storage for patron data and I am not sure if a
>> separate table would makes sense as the table structure would probably be
>> really similar. We already need to keep 3 tables in sync when adding
>> columns: borrowers, deletedborrowers, borrower_modifications. We might also
>> want to think about how the data will move when email verification is used
>> in addition to moderation.
>>
>> Hope this helps,
>>
>> Katrin
>> On 31.08.22 04:35, Tomas Cohen Arazi wrote:
>>
>> Please, use a separate table. And think of the request workflow handling
>> in the db, the statuses (as enum), how it will be handled at library or
>> library group level. Even if not implemented at this stage. Also, maybe you
>> need more than one table, don't fear adding tables if they make sense and
>> give us a cleaner implementation.
>>
>> Moderation should be traceable, etc.
>>
>> Thinking of API routes for the process usually clears the design issues
>> as it points to the classes you will need.
>>
>> El lun, 29 ago 2022 19:46, Alex Buckley 
>> escribió:
>>
>>> Kia ora/Hello Koha community,
>>>
>>> I am currently working on reviving bug 25090
>>> <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090> ( Moderate
>>> OPAC self-registrations before a patron account is created ).
>>>
>>> *New proposed functionality:*
>>>
>>> Step 1: The library enables both the new
>>> 'PatronSelfRegistrationModeration' syspref and the existing
>>> 'OpacResetPassword' syspref.
>>>
>>> Step 2: When a user submits an OPAC self-registration their Koha patron
>>> account is not created immediately - i.e. they cannot yet log into the OPAC.
>>>
>>> Step 3: A pending registration link appears at the bottom of the staff
>>> client home page (like what's currently done with new purchase suggestions,
>>> or OPAC patron modification requests).
>>>
>>> Step 4: Librarians can click on the link to go to a page to approve or
>>> decline the registration.
>>>
>>> Step 4a: If approved the user is sent an email notice, containing their
>>> Koha username and an OPAC reset password link.
>>>
>>> Step 4b: If declined the user is sent a different email notice.
>>>
>>> *The rationale for adding this feature:*
>>> You can currently limit the circulation of self-registered patrons - by
>>> using the PatronSelfRegistrationDefaultCategory syspref and creating
>>> circulation rule(s) for that category.
>>>
>>> However, users only need an OPAC login (without the ability to
>>> circulate) to access electronic content providers (integrated with Koha via
>>> STunnel/SIP2). Some electronic content providers charge libraries based on
>>> their usage. Meaning it might not be optimal having anyone from around the
>>> world self-registering for a library OPAC login and accessing electronic
>>> content from some providers, therefore, incurring extra costs for the
>>> library.
>>>
>>> Bug 25090 was originally developed in the early days of the pandemic to
>>> ensure new self-registering OPAC users accessing 3rd party databases were
>>> coming from acceptable locations i.e. they were members of the organisation
>>> the library is in.
>>>
>>> More detail

Re: [Koha-devel] Elasticsearch not auto-updating after cataloguing

2022-09-11 Thread Tomas Cohen Arazi
Is koha-worker running?

El vie, 9 sept 2022 12:42, Philippe Blouin 
escribió:

> Hello kohaers!
>
> Simply put: our production servers installation work very fine, each
> change into a record is immediately reindexed into ES.
>
> BUT on laptop (ubuntu 20 or 22), the reindexing never occurs.  We have to
> call rebuild_elasticsearch.pl manually so the search finds anything.  The
> configuration refers to a remote ES server (instead of localhost like the
> prod servers), but I don't see how that would make a difference since that
> works once rebuilt.
>
> Any clue on what I'm missing would be greatly appreciated.
>
> Best regards,
> --
> Philippe Blouin,
> Directeur de la technologie
>
> Tél.  : (833) 465-4276, poste 230
> philippe.blo...@inlibro.com
> inLibro | pour esprit libre | www.inLibro.com
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Enable libraries to moderate OPAC self-registrations

2022-09-06 Thread Tomas Cohen Arazi
I think we need to resurrect the idea of a patron import staging + import
step. This one being a particular use case.

El mar, 6 sept 2022 a las 7:43, Katrin Fischer ()
escribió:

> Hi all,
>
> I think the feature would be useful. :)
>
> I feel there has been some misunderstanding about the
> borrower_modifications table. It doesn't require a valid borrowernumber as
> the table is used for at least 2 purposes already:
>
> * Patron data modification requests from the OPAC (borrowernumber of
> patron)
>
> * Patron self registrations with required email verification
> (borrowernumber = 0)
>
> It's used as a temporary storage for patron data and I am not sure if a
> separate table would makes sense as the table structure would probably be
> really similar. We already need to keep 3 tables in sync when adding
> columns: borrowers, deletedborrowers, borrower_modifications. We might also
> want to think about how the data will move when email verification is used
> in addition to moderation.
>
> Hope this helps,
>
> Katrin
> On 31.08.22 04:35, Tomas Cohen Arazi wrote:
>
> Please, use a separate table. And think of the request workflow handling
> in the db, the statuses (as enum), how it will be handled at library or
> library group level. Even if not implemented at this stage. Also, maybe you
> need more than one table, don't fear adding tables if they make sense and
> give us a cleaner implementation.
>
> Moderation should be traceable, etc.
>
> Thinking of API routes for the process usually clears the design issues as
> it points to the classes you will need.
>
> El lun, 29 ago 2022 19:46, Alex Buckley 
> escribió:
>
>> Kia ora/Hello Koha community,
>>
>> I am currently working on reviving bug 25090
>> <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090> ( Moderate
>> OPAC self-registrations before a patron account is created ).
>>
>> *New proposed functionality:*
>>
>> Step 1: The library enables both the new
>> 'PatronSelfRegistrationModeration' syspref and the existing
>> 'OpacResetPassword' syspref.
>>
>> Step 2: When a user submits an OPAC self-registration their Koha patron
>> account is not created immediately - i.e. they cannot yet log into the OPAC.
>>
>> Step 3: A pending registration link appears at the bottom of the staff
>> client home page (like what's currently done with new purchase suggestions,
>> or OPAC patron modification requests).
>>
>> Step 4: Librarians can click on the link to go to a page to approve or
>> decline the registration.
>>
>> Step 4a: If approved the user is sent an email notice, containing their
>> Koha username and an OPAC reset password link.
>>
>> Step 4b: If declined the user is sent a different email notice.
>>
>> *The rationale for adding this feature:*
>> You can currently limit the circulation of self-registered patrons - by
>> using the PatronSelfRegistrationDefaultCategory syspref and creating
>> circulation rule(s) for that category.
>>
>> However, users only need an OPAC login (without the ability to circulate)
>> to access electronic content providers (integrated with Koha via
>> STunnel/SIP2). Some electronic content providers charge libraries based on
>> their usage. Meaning it might not be optimal having anyone from around the
>> world self-registering for a library OPAC login and accessing electronic
>> content from some providers, therefore, incurring extra costs for the
>> library.
>>
>> Bug 25090 was originally developed in the early days of the pandemic to
>> ensure new self-registering OPAC users accessing 3rd party databases were
>> coming from acceptable locations i.e. they were members of the organisation
>> the library is in.
>>
>> More details can be found here:
>> https://www.catalyst.net.nz/blog/mental-health-education-resource-library-now-offers-online-self-registration
>> *Questions I would like to hear your thoughts on please:*
>>
>> Q1: Are you in favour of this as a new feature in Koha?
>>
>> Q2: Would you prefer a new database table be added for self-registrations
>> awaiting approval, or should I use the borrowers_modifications table - as
>> is used by OPAC patron modification requests?
>>
>> Q3: How would you envisage this self-registration moderation feature
>> fitting in with the existing  PatronSelfRegistrationVerifyByEmail and 
>> PatronSelfRegistrationDefaultCategory
>> sysprefs?
>>
>> Any thoughts much appreciated.
>>
>> Kind regards,
>>
>> Alex
>> ___

Re: [Koha-devel] Enable libraries to moderate OPAC self-registrations

2022-08-30 Thread Tomas Cohen Arazi
Please, use a separate table. And think of the request workflow handling in
the db, the statuses (as enum), how it will be handled at library or
library group level. Even if not implemented at this stage. Also, maybe you
need more than one table, don't fear adding tables if they make sense and
give us a cleaner implementation.

Moderation should be traceable, etc.

Thinking of API routes for the process usually clears the design issues as
it points to the classes you will need.

El lun, 29 ago 2022 19:46, Alex Buckley 
escribió:

> Kia ora/Hello Koha community,
>
> I am currently working on reviving bug 25090
>  ( Moderate
> OPAC self-registrations before a patron account is created ).
>
> *New proposed functionality:*
>
> Step 1: The library enables both the new
> 'PatronSelfRegistrationModeration' syspref and the existing
> 'OpacResetPassword' syspref.
>
> Step 2: When a user submits an OPAC self-registration their Koha patron
> account is not created immediately - i.e. they cannot yet log into the OPAC.
>
> Step 3: A pending registration link appears at the bottom of the staff
> client home page (like what's currently done with new purchase suggestions,
> or OPAC patron modification requests).
>
> Step 4: Librarians can click on the link to go to a page to approve or
> decline the registration.
>
> Step 4a: If approved the user is sent an email notice, containing their
> Koha username and an OPAC reset password link.
>
> Step 4b: If declined the user is sent a different email notice.
>
> *The rationale for adding this feature:*
> You can currently limit the circulation of self-registered patrons - by
> using the PatronSelfRegistrationDefaultCategory syspref and creating
> circulation rule(s) for that category.
>
> However, users only need an OPAC login (without the ability to circulate)
> to access electronic content providers (integrated with Koha via
> STunnel/SIP2). Some electronic content providers charge libraries based on
> their usage. Meaning it might not be optimal having anyone from around the
> world self-registering for a library OPAC login and accessing electronic
> content from some providers, therefore, incurring extra costs for the
> library.
>
> Bug 25090 was originally developed in the early days of the pandemic to
> ensure new self-registering OPAC users accessing 3rd party databases were
> coming from acceptable locations i.e. they were members of the organisation
> the library is in.
>
> More details can be found here:
> https://www.catalyst.net.nz/blog/mental-health-education-resource-library-now-offers-online-self-registration
> *Questions I would like to hear your thoughts on please:*
>
> Q1: Are you in favour of this as a new feature in Koha?
>
> Q2: Would you prefer a new database table be added for self-registrations
> awaiting approval, or should I use the borrowers_modifications table - as
> is used by OPAC patron modification requests?
>
> Q3: How would you envisage this self-registration moderation feature
> fitting in with the existing  PatronSelfRegistrationVerifyByEmail and 
> PatronSelfRegistrationDefaultCategory
> sysprefs?
>
> Any thoughts much appreciated.
>
> Kind regards,
>
> Alex
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Difficulties with JSON::Validator after upgrading to 22.05

2022-08-26 Thread Tomas Cohen Arazi
I think it is failing to import something and THEN failing due to that. But
yeah, solved. Now to develop great things

El vie, 26 ago 2022 15:46, Philippe Blouin 
escribió:

> Well, you got that right!  Upgrading to 22.04 made the error disappear.
>
> But from a programming standpoint, I still don't get why the errors.
>
> Oh well, I just hope JSON::Validator / Mojolicious libraries errors are
> behind us now.
>
> Thanks again!
> Philippe Blouin,
> Directeur de la technologie
>
> Tél.  : (833) 465-4276, poste 230
> philippe.blo...@inlibro.com
> inLibro | pour esprit libre | www.inLibro.com
> On 2022-08-26 13:32, Tomas Cohen Arazi wrote:
>
> You've got the wrong library version.
>
> Ubuntu 20.04 is old in terms of the Debian version of is based on. I'm
> pretty sure you can append 'focal' to the repository configuration line and
> it will pull the right dependencies.
>
> El vie, 26 ago 2022 14:08, Philippe Blouin 
> escribió:
>
>> Hi folks!
>>
>> Got a really weird error in my logs right now:
>>
>> "is_bool" is not exported by the JSON::Validator::Util module
>>  "is_num" is not exported by the JSON::Validator::Util module
>>  "str2data" is not exported by the JSON::Validator::Util module
>> Can't continue after import errors at 
>> /usr/share/perl5/JSON/Validator/Schema.pm line 7.
>> BEGIN failed--compilation aborted at 
>> /usr/share/perl5/JSON/Validator/Schema.pm line 7.
>> Compilation failed in require at /usr/share/perl5/Mojo/Base.pm line 134.
>> BEGIN failed--compilation aborted at 
>> /usr/share/perl5/JSON/Validator/Schema/Draft4.pm line 2.
>> Compilation failed in require at /usr/share/perl5/Mojo/Base.pm line 134.
>> BEGIN failed--compilation aborted at 
>> /usr/share/perl5/JSON/Validator/Schema/OpenAPIv2.pm line 2.
>> Compilation failed in require at 
>> /inlibro/git/koha-v22-dev-blou/Koha/REST/V1.pm line 25.
>> BEGIN failed--compilation aborted at 
>> /inlibro/git/koha-v22-dev-blou/Koha/REST/V1.pm line 25.
>> Compilation failed in require at (eval 22) line 1.
>>
>> Which ruins most table displays.
>>
>> The error is weird in many ways, including the fact that
>> /usr/share/perl5/JSON/Validator/Util.pm DOES export is_bool and friend in
>> its header.
>>
>> cpan tells me I have the latest version, etc...
>>
>> I have Ubuntu 20.04, which I'm upgrading now to 22.04, but I don't expect
>> much to change there considering the error.
>>
>>
>> Any suggestion?
>>
>>
>> Best regards,
>> --
>> Philippe Blouin,
>> Directeur de la technologie
>>
>> Tél.  : (833) 465-4276, poste 230
>> philippe.blo...@inlibro.com
>> inLibro | pour esprit libre | www.inLibro.com
>> ___
>> Koha-devel mailing list
>> Koha-devel@lists.koha-community.org
>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>> website : https://www.koha-community.org/
>> git : https://git.koha-community.org/
>> bugs : https://bugs.koha-community.org/
>>
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Difficulties with JSON::Validator after upgrading to 22.05

2022-08-26 Thread Tomas Cohen Arazi
You've got the wrong library version.

Ubuntu 20.04 is old in terms of the Debian version of is based on. I'm
pretty sure you can append 'focal' to the repository configuration line and
it will pull the right dependencies.

El vie, 26 ago 2022 14:08, Philippe Blouin 
escribió:

> Hi folks!
>
> Got a really weird error in my logs right now:
>
> "is_bool" is not exported by the JSON::Validator::Util module
>  "is_num" is not exported by the JSON::Validator::Util module
>  "str2data" is not exported by the JSON::Validator::Util module
> Can't continue after import errors at 
> /usr/share/perl5/JSON/Validator/Schema.pm line 7.
> BEGIN failed--compilation aborted at 
> /usr/share/perl5/JSON/Validator/Schema.pm line 7.
> Compilation failed in require at /usr/share/perl5/Mojo/Base.pm line 134.
> BEGIN failed--compilation aborted at 
> /usr/share/perl5/JSON/Validator/Schema/Draft4.pm line 2.
> Compilation failed in require at /usr/share/perl5/Mojo/Base.pm line 134.
> BEGIN failed--compilation aborted at 
> /usr/share/perl5/JSON/Validator/Schema/OpenAPIv2.pm line 2.
> Compilation failed in require at 
> /inlibro/git/koha-v22-dev-blou/Koha/REST/V1.pm line 25.
> BEGIN failed--compilation aborted at 
> /inlibro/git/koha-v22-dev-blou/Koha/REST/V1.pm line 25.
> Compilation failed in require at (eval 22) line 1.
>
> Which ruins most table displays.
>
> The error is weird in many ways, including the fact that
> /usr/share/perl5/JSON/Validator/Util.pm DOES export is_bool and friend in
> its header.
>
> cpan tells me I have the latest version, etc...
>
> I have Ubuntu 20.04, which I'm upgrading now to 22.04, but I don't expect
> much to change there considering the error.
>
>
> Any suggestion?
>
>
> Best regards,
> --
> Philippe Blouin,
> Directeur de la technologie
>
> Tél.  : (833) 465-4276, poste 230
> philippe.blo...@inlibro.com
> inLibro | pour esprit libre | www.inLibro.com
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Getting "count" when using REST API

2022-08-05 Thread Tomas Cohen Arazi
I'll file a bug for that. I'm thinking we could reconsider the return value
for objects.search at this point (i.e. just return the resultset and let
the controller call ->to_api). It feels it would be more consistent too.

Nice one!

El vie, 5 ago 2022 11:42, Renvoize, Martin 
escribió:

> We should probably implement this as a HEAD request.. i.e. instead of
> doing a special ?_page=1&_per_page=1, we should just allow requesting the
> HEAD on whatever the request was and then you can read the X-Total-Count
> header.. in the Koha side we can handle such a request with performance in
> mind and not both fetching all the data to return etc.
>
> *Martin Renvoize, MPhys (Hons)*
>
> <https://www.ptfs-europe.com>
>
> Head of Development and Community Engagement
>
>
>
> *Phone:* +44 (0) 1483 378728
>
> *Mobile:* +44 (0) 7725 985 636
>
> *Email:* martin.renvo...@ptfs-europe.com
>
> www.ptfs-europe.com
>
>
> *Sign up for our newsletters here <http://eepurl.com/dPjjkn> or by
> scanning the QR code*
>
>
>
> Registered in the United Kingdom No. 06416372   VAT Reg No. 925 7211 30
>
> The information contained in this email message may be privileged,
> confidential and protected from disclosure. If you are not the intended
> recipient, any dissemination, distribution or copying is strictly
> prohibited. If you think that you have received this email message in
> error, please email the sender at i...@ptfs-europe.com
>
>
> On Fri, 5 Aug 2022 at 01:31,  wrote:
>
>> How do you mean?
>>
>>
>>
>> In my case, I’m improving how my Keycloak User Storage extension works
>> with Koha. It fetches the count of users and then sends an API request
>> using an offset and that count to handle the paging. Their internal API
>> breaks it into 2 steps, so I have to hit the database twice anyway.
>>
>>
>>
>> David Cook
>>
>> Senior Software Engineer
>>
>> Prosentient Systems
>>
>> Suite 7.03
>>
>> 6a Glen St
>>
>> Milsons Point NSW 2061
>>
>> Australia
>>
>>
>>
>> Office: 02 9212 0899
>>
>> Online: 02 8005 0595
>>
>>
>>
>> *From:* Tomas Cohen Arazi 
>> *Sent:* Friday, 5 August 2022 10:26 AM
>> *To:* David Cook 
>> *Cc:* Jonathan Druart ; Koha Devel <
>> koha-devel@lists.koha-community.org>
>> *Subject:* Re: [Koha-devel] Getting "count" when using REST API
>>
>>
>>
>> That's a smart trick!
>>
>>
>>
>> We should not be lazy though, and add a generic way to retrieve the count
>> without making several DB hits.
>>
>>
>>
>> El jue, 4 ago 2022 20:56,  escribió:
>>
>> Jonathan, you are a champion! That'll work perfectly for me!
>>
>> David Cook
>> Senior Software Engineer
>> Prosentient Systems
>> Suite 7.03
>> 6a Glen St
>> Milsons Point NSW 2061
>> Australia
>>
>> Office: 02 9212 0899
>> Online: 02 8005 0595
>>
>> -Original Message-
>> From: Jonathan Druart 
>> Sent: Thursday, 4 August 2022 10:17 PM
>> To: Tomas Cohen Arazi 
>> Cc: David Cook ; Koha Devel <
>> koha-devel@lists.koha-community.org>
>> Subject: Re: [Koha-devel] Getting "count" when using REST API
>>
>>  I needed that for ERM and I did a GET with _page=1 and _per_page=1 (to
>> retrieve only 1 result) then read the X-Total-Count value from the header's
>> response ;)
>>
>> Le jeu. 4 août 2022 à 12:33, Tomas Cohen Arazi  a
>> écrit :
>> >
>> > Only with x-koha-embed
>> >
>> >
>> > El jue, 4 ago 2022 3:54,  escribió:
>> >>
>> >> Hi all,
>> >>
>> >>
>> >>
>> >> Is there a method for getting a “count” using the REST API without
>> fetching every record?
>> >>
>> >>
>> >>
>> >> When building a paging lookup outside of Koha, it would be useful to
>> get a total record count and then just fetch the page of records that you
>> need.
>> >>
>> >>
>> >>
>> >> Thanks!
>> >>
>> >>
>> >>
>> >> David Cook
>> >>
>> >> Senior Software Engineer
>> >>
>> >> Prosentient Systems
>> >>
>> >> Suite 7.03
>> >>
>> >> 6a Glen St
>> >>
>> >> Milsons Point NSW 2061
>> >>
>> >> Australia
>> >>
>> >>
>> >>
>> >> Office: 02 9212 0899
>> >>
>> >> Online: 02 8005 0595
>> >>
>> >>
>> >
>> > ___
>> > Koha-devel mailing list
>> > Koha-devel@lists.koha-community.org
>> > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>> > website : https://www.koha-community.org/ git :
>> > https://git.koha-community.org/ bugs :
>> > https://bugs.koha-community.org/
>>
>> ___
>> Koha-devel mailing list
>> Koha-devel@lists.koha-community.org
>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>> website : https://www.koha-community.org/
>> git : https://git.koha-community.org/
>> bugs : https://bugs.koha-community.org/
>>
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Getting "count" when using REST API

2022-08-04 Thread Tomas Cohen Arazi
That's a smart trick!

We should not be lazy though, and add a generic way to retrieve the count
without making several DB hits.

El jue, 4 ago 2022 20:56,  escribió:

> Jonathan, you are a champion! That'll work perfectly for me!
>
> David Cook
> Senior Software Engineer
> Prosentient Systems
> Suite 7.03
> 6a Glen St
> Milsons Point NSW 2061
> Australia
>
> Office: 02 9212 0899
> Online: 02 8005 0595
>
> -Original Message-
> From: Jonathan Druart 
> Sent: Thursday, 4 August 2022 10:17 PM
> To: Tomas Cohen Arazi 
> Cc: David Cook ; Koha Devel <
> koha-devel@lists.koha-community.org>
> Subject: Re: [Koha-devel] Getting "count" when using REST API
>
>  I needed that for ERM and I did a GET with _page=1 and _per_page=1 (to
> retrieve only 1 result) then read the X-Total-Count value from the header's
> response ;)
>
> Le jeu. 4 août 2022 à 12:33, Tomas Cohen Arazi  a
> écrit :
> >
> > Only with x-koha-embed
> >
> >
> > El jue, 4 ago 2022 3:54,  escribió:
> >>
> >> Hi all,
> >>
> >>
> >>
> >> Is there a method for getting a “count” using the REST API without
> fetching every record?
> >>
> >>
> >>
> >> When building a paging lookup outside of Koha, it would be useful to
> get a total record count and then just fetch the page of records that you
> need.
> >>
> >>
> >>
> >> Thanks!
> >>
> >>
> >>
> >> David Cook
> >>
> >> Senior Software Engineer
> >>
> >> Prosentient Systems
> >>
> >> Suite 7.03
> >>
> >> 6a Glen St
> >>
> >> Milsons Point NSW 2061
> >>
> >> Australia
> >>
> >>
> >>
> >> Office: 02 9212 0899
> >>
> >> Online: 02 8005 0595
> >>
> >>
> >
> > ___
> > Koha-devel mailing list
> > Koha-devel@lists.koha-community.org
> > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> > website : https://www.koha-community.org/ git :
> > https://git.koha-community.org/ bugs :
> > https://bugs.koha-community.org/
>
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Getting "count" when using REST API

2022-08-04 Thread Tomas Cohen Arazi
Only with x-koha-embed


El jue, 4 ago 2022 3:54,  escribió:

> Hi all,
>
>
>
> Is there a method for getting a “count” using the REST API without
> fetching every record?
>
>
>
> When building a paging lookup outside of Koha, it would be useful to get a
> total record count and then just fetch the page of records that you need.
>
>
>
> Thanks!
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Who runs the koha-jenkins IRC bot?

2022-08-02 Thread Tomas Cohen Arazi
Hi, koha-jenkins is now sending to #koha-ci only. Will move it to #koha-bots

El mar, 2 ago 2022 21:06, Victor Grousset/tuxayo 
escribió:

> Hi :)
>
> It's about the move of automated output to #koha-bots
>
> Cheers,
>
> --
> Victor Grousset/tuxayo
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Debian 9 LTS EOL

2022-07-29 Thread Tomas Cohen Arazi
On Jenkins, which is what the dashboard pulls that info from, the 18.04
task is run only so stable branches know in advance if backports could
break support. I actually removed the 18.04 from the 'Suported' panel for
master in Jenkins.

We should discuss actions on this. I think before the 22.05 release we
decided to drop support for older distros, but as Mason managed to have all
packaging sorted (new Mojolicious, etc) we mistakenly kept the 'support'.


El mié, 27 jul 2022 20:35,  escribió:

> That’s good to know!
>
>
>
> Looking at https://dashboard.koha-community.org/, it looks like we still
> have CI running for Debian 8 and Debian 9 as well as Ubuntu 16 and Ubuntu
> 18. Perhaps those should all be retired?
>
>
>
> I suppose we could drop Debian 8 and Ubuntu 18.04 off
> https://wiki.koha-community.org/wiki/System_requirements_and_recommendations
> in any case since they’re not “recommendations” anymore? Actually the wiki
> looks pretty outdated/inconsistent with the dashboard…
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
>
> *From:* Tomas Cohen Arazi 
> *Sent:* Wednesday, 27 July 2022 11:36 PM
> *To:* David Cook 
> *Cc:* Koha Devel 
> *Subject:* Re: [Koha-devel] Debian 9 LTS EOL
>
>
>
> I'm pretty sure we don't support Debian 9 anymore. And Ubuntu 18.04 is in
> the same situation.
>
>
>
> Using those old MariaDB and MySQL versions is problematic and thus
> discouraged.
>
>
>
> El mié, 27 jul 2022 2:15,  escribió:
>
> Hi all,
>
>
>
> While commenting on Bug 28267, I decided to review what versions of Debian
> we support, and I noticed that Debian 9 (Stretch) actually met it’s LTS EOL
> on 2022-06-30, so it probably makes sense for us to drop support for it at
> some point in the near future too.
>
>
>
> Debian 10 (Buster) will be regular EOL in the next couple of months, and
> then it will get a LTS period of another couple extra years. (Interesting
> to note that Debian LTS isn’t actually handled by the Debian Security team
> but rather a separate group of volunteers.)
>
>
>
> It looks like Ubuntu 18.04 will end its “standard support” in April 2023,
> so we nearly have 1 more year on it.
>
>
>
> It looks like Debian 9 (Stretch) and Ubuntu 18.04 (Bionic) both have
> MariaDB 10.1.x, so I suppose we can’t drop support for that DB version
> until both OSes are no longer supported.
>
>
>
>
> https://wiki.koha-community.org/wiki/System_requirements_and_recommendations
>
> https://wiki.debian.org/LTS
>
> https://wiki.debian.org/DebianReleases
>
> https://wiki.ubuntu.com/Releases
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Debian 9 LTS EOL

2022-07-28 Thread Tomas Cohen Arazi
I'm pretty sure we don't support Debian 9 anymore. And Ubuntu 18.04 is in
the same situation.

Using those old MariaDB and MySQL versions is problematic and thus
discouraged.

El mié, 27 jul 2022 2:15,  escribió:

> Hi all,
>
>
>
> While commenting on Bug 28267, I decided to review what versions of Debian
> we support, and I noticed that Debian 9 (Stretch) actually met it’s LTS EOL
> on 2022-06-30, so it probably makes sense for us to drop support for it at
> some point in the near future too.
>
>
>
> Debian 10 (Buster) will be regular EOL in the next couple of months, and
> then it will get a LTS period of another couple extra years. (Interesting
> to note that Debian LTS isn’t actually handled by the Debian Security team
> but rather a separate group of volunteers.)
>
>
>
> It looks like Ubuntu 18.04 will end its “standard support” in April 2023,
> so we nearly have 1 more year on it.
>
>
>
> It looks like Debian 9 (Stretch) and Ubuntu 18.04 (Bionic) both have
> MariaDB 10.1.x, so I suppose we can’t drop support for that DB version
> until both OSes are no longer supported.
>
>
>
>
> https://wiki.koha-community.org/wiki/System_requirements_and_recommendations
>
> https://wiki.debian.org/LTS
>
> https://wiki.debian.org/DebianReleases
>
> https://wiki.ubuntu.com/Releases
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Staff interface redesign is ready to be tested

2022-07-26 Thread Tomas Cohen Arazi
+1

Is it possible to apply branches to a sandbox also? Or it just interacts
with BZ?

El mar, 26 jul 2022 a las 12:43, Katrin Fischer ()
escribió:

> I  still think a dedicated sandbox would be really helpful. What Victor
> says is certainly true for smaller patch sets, but this is a big patch
> set that touches a lot of files and will conflict very often. So this
> could get quite frustrating to set up fast. It would be easier to have a
> sandbox 'frozen' with the patch set applied and updated after changes.
>
> Katrin
>
> On 20.07.22 23:57, Victor Grousset/tuxayo wrote:
> > On 22-07-08 20:33, Cab Vinton wrote:
> >> It's
> >> probably a tiny minority of end-users that are used to setting up
> >> their own sandboxes from scratch.
> >
> > Indeed, but with a direct link to
> > https://sandbox.bywatersolutions.com/create
> > and a few phrases to explain what to fill in the form and then tell to
> > wait and refresh until the "Staff" button is visible should be enough
> > to make it accessible to most end-users wanting to check it out.
> >
> > Cheers,
> >
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] QA for Bug 30988 - Add generic OpenIDConnect client implementation

2022-07-23 Thread Tomas Cohen Arazi
Hi, David. I meant to answer your first email. I'm submitting (immediately)
an alternative implementation I've been working on but failed to wrap up
sooner.

I've read the one you pointed and if fairly similar to the google oaidc
implementation for OPAC, so it is correct.

My plan is to do it for staff as well, using libraries.

El vie, 22 jul 2022 7:03,  escribió:

> Hi all,
>
>
>
> Just wondering if anyone has time to QA “Bug 30988 - Add generic
> OpenIDConnect client implementation”. It would be great to get this
> additional authentication option into Koha as it would really round out
> Koha’s AuthN offerings.
>
>
>
> I could do some testing for bugs of the QAer’s choice if that helps.
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


Re: [Koha-devel] Updating SCSS lint process to use stylelint

2022-07-21 Thread Tomas Cohen Arazi
Hi Owen!

If the tool is deprecated, let's find another one. I'll follow your lead on
this matter.

El mié, 20 jul 2022 7:34, Renvoize, Martin 
escribió:

> I'm in a similar camp to David, though I have touched it a few times here
> and there.. I wasn't aware of a linter, but would take your lead Owen, I
> like linters and tidies in general.. having consistent code is clearer code
> in my book.
>
> On Tue, 19 Jul 2022, 4:36 pm BFL Catalog,  wrote:
>
>> What exactly is stylelint? Is this what you get after washing clothes too
>> many times? You know the laundry lint builds up so much it cramps your
>> style!
>>
>> Wendy Sharkey
>> Head of Circulation/ Cataloging and IT
>> Bennington Free Library
>> 101 Silver Street
>> Bennington, VT 05201
>> (802) 442-9051
>>
>>
>> On Tue, Jul 19, 2022 at 4:29 AM Paul Derscheid <
>> paul.dersch...@lmscloud.de> wrote:
>>
>>> Hi Owen,
>>>
>>> I recently played around with the SCSS to create a more minimalist
>>> version of the bootstrap OPAC for LMSCloud.
>>> I used the predefined rules and I think they’re reasonable choices
>>> (Although I didn’t cross every rule for sure).
>>>
>>> Looking forward to stylint in Koha which I already use for some projects
>>> where I use stylus instead of SCSS. It’s a great tool.
>>>
>>> Kind regards
>>>
>>> Paul
>>>
>>> --
>>> LMSCloud GmbH
>>> Paul Derscheid - Software Engineer
>>> Konrad-Zuse-Platz 8 - D-81829 München
>>> m +49 174 2436308
>>> e paul.dersch...@lmscloud.de
>>> w www.lmscloud.de
>>>
>>> > On 18. Jul 2022, at 16:32, Owen Leonard  wrote:
>>> >
>>> > Hi all,
>>> >
>>> > Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I
>>> > added a linting configuration, .scss-lint.yml. I've always configured
>>> > my editor to automatically lint SCSS using this configuration. I don't
>>> > know if anyone else does this too.
>>> >
>>> > In VS Code I was using scss-lint for this, but it's now deprecated.
>>> > They suggest stylelint instead: https://stylelint.io. I'd like to
>>> > propose replacing .scss-lint.yml with .stylelintrc.json, transferring
>>> > most of the same rules.
>>> >
>>> > It could be left up to the individual to install the dependencies, or
>>> > I could update package.json. One nice thing about stylelint is that it
>>> > has a "--fix" feature for some simple rules. This could be build into
>>> > our gulp tasks.
>>> >
>>> > Has anyone else been linting SCSS? If so, does anyone have opinions
>>> > about how our current rule set is working?
>>> >
>>> > -- Owen
>>> >
>>> > --
>>> > Web Developer
>>> > Athens County Public Libraries
>>> > (740) 737-6006
>>> > https://www.myacpl.org
>>> > ___
>>> > Koha-devel mailing list
>>> > Koha-devel@lists.koha-community.org
>>> > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>>> > website : https://www.koha-community.org/
>>> > git : https://git.koha-community.org/
>>> > bugs : https://bugs.koha-community.org/
>>>
>>> ___
>>> Koha-devel mailing list
>>> Koha-devel@lists.koha-community.org
>>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>>> website : https://www.koha-community.org/
>>> git : https://git.koha-community.org/
>>> bugs : https://bugs.koha-community.org/
>>>
>> ___
>> Koha-devel mailing list
>> Koha-devel@lists.koha-community.org
>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>> website : https://www.koha-community.org/
>> git : https://git.koha-community.org/
>> bugs : https://bugs.koha-community.org/
>>
> ___
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


  1   2   3   4   5   6   7   8   >