Re: [Koha-patches] [PATCH] (bug #3412) fix double encoded guided report
-binmode STDOUT, ':utf8'; - [1] I have not been able to reproduce the double-encoding problem - a report on biblio.title looks OK for titles that include diacritics. Please add more information about how to reproduce the problem to the bug. [2] The two lines that this patch removes were lines that you yourself added in commit f6027eb4 to ensure correct UTF-8 text in CSV downloads. Removing these lines would cause a regression for CSV output, would it not? Those utf8 issues are very strange. I don't understand the logic. I confirm I had also to suppress this line to avoid corrupted reports. My 'feeling' is that binmode should be avoided at all. If characters are correctly handled in Perl script, explicitly specifying output file encoding is not required anymore. If you began doing binmode on files, you also need to encode-decode strings, and at the end of the day you get Nahuel double-encoding problems. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches
[Koha-patches] No Koha Uninstall Script.
Much of the logic of this is described within the documentation within the script itself. But, in short, without some form of priviledge-escalation utility in action the koha user will have no luck in running such commands. And in any case, the koha user is one of the users who would be removed. Removing users and groups, dropping the database and so on are not a central part of the behaviour. They're added as tidyup functions. And they're also interactive. Not only that, but when you run the script in standard, SAFE mode, which is the default, removing groups and users and dropping the database isn't even offered as an option. In standard, SAFE mode, the script analyses your koha installation and tells you where the koha files are, as well as writing its findings to a tempoary file, and then exits. It's upto you, the administrator you remove whatever you want to remove. (ie unless you edit the script itself, you can't make it delete anything.) - Original Message - From: MJ Ray m...@phonecoop.coop To: patr...@bookscape.co.uk; patc...@koha.org Sent: Friday, July 10, 2009 11:08 AM Subject: Re: [Koha-patches] No Koha Uninstall Script. Patrick Mackeown patr...@bookscape.co.uk wrote: [1] I've taken Galen's suggestion and added support for multiple machine architectures. Ostensibly this is to support unixes and variants who do not use /usr/sbin to store userdel groupdel commands. Should the Koha Uninstall be running userdel and groupdel? Last I saw, the Koha Install didn't run useradd and groupadd. Confused, -- MJ Ray (slef) LMS developer and webmaster at | software www.software.coop http://mjr.towers.org.uk| co Notice http://mjr.towers.org.uk/email.html| op ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches
Re: [Koha-patches] [PATCH] [followup](bug #3370) fix the Get function name
Hi, Le Fri, 10 Jul 2009 10:47:47 -0500, Galen Charlton galen.charl...@liblime.com a écrit : Hi Nahuel, On Thu, Jul 9, 2009 at 9:01 AM, Nahuel ANGELINETTInahuel.angeline...@biblibre.com wrote: Le Wed, 8 Jul 2009 11:25:05 -0400, Joe Atzberger joe.atzber...@liblime.com a écrit : Wasn't there anywhere that used this function that needs to be updated too? I'm guessing there must be. But if not, we should just delete it! This is a followup of my previous patch that integrate the mapping between keyword and framework fields, from your previous suggestion. I think what's missing is any code that actually makes use of the new C4::Biblio function. Some code will be send soon, but this is more generic for all uses in Koha. I didn't want to merge 2 stuff totally independent. bests, -- Nahuel ANGELINETTI ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches
[Koha-patches] [PATCH] [ReplacePrevious](bug #3398) fix unimarc 210c plugin
this add some args to SearchAuthority();
Fix the pagination, and fix javascript script.
---
cataloguing/value_builder/unimarc_field_210c.pl|9 ---
.../value_builder/unimarc_field_210c.tmpl | 24 +++
2 files changed, 24 insertions(+), 9 deletions(-)
diff --git a/cataloguing/value_builder/unimarc_field_210c.pl
b/cataloguing/value_builder/unimarc_field_210c.pl
index 27ced19..ffbf644 100755
--- a/cataloguing/value_builder/unimarc_field_210c.pl
+++ b/cataloguing/value_builder/unimarc_field_210c.pl
@@ -162,7 +162,8 @@ my ($input) = @_;
my @excluding = $query-param('excluding');
my @operator = $query-param('operator');
my @value = $query-param('value');
-
+my $orderby = $query-param('orderby');
+
$resultsperpage= $query-param('resultsperpage');
$resultsperpage = 19 if(!defined $resultsperpage);
@@ -171,8 +172,8 @@ my ($input) = @_;
my ($results,$total) = SearchAuthorities( \...@tags,\...@and_or,
\...@excluding, \...@operator,
\...@value,
-$startfrom*$resultsperpage,
$resultsperpage,$authtypecode);# $orderby);
-
+$startfrom*$resultsperpage,
$resultsperpage,$authtypecode, $orderby);
+
($template, $loggedinuser, $cookie)
= get_template_and_user({template_name =
cataloguing/value_builder/unimarc_field_210c.tmpl,
query = $query,
@@ -211,7 +212,7 @@ my ($input) = @_;
} else {
$to = (($startfrom+1)*$resultsperpage);
}
-my
$link=../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_210c.plamp;authtypecode=EDITORSand_or=andoperator=contains.join(,map
{value=.$_} @value).op=do_searchtype=intranetindex=$index;
+my
$link=../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_210c.plamp;authtypecode=EDITORSand_or=$and_oramp;marclist=$marclistamp;operator=$operatoramp;orderby=$orderbyamp;excluding=$excludingamp;.join(amp;,map
{value=.$_} @value).amp;op=do_searchamp;type=intranetamp;index=$index;
warn $link ,.getnbpages($total, $resultsperpage);
$template-param(result = $results) if $results;
$template-param('index' = $query-param('index'));
diff --git
a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tmpl
b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tmpl
index 4948ca3..8da1f39 100644
---
a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tmpl
+++
b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tmpl
@@ -21,6 +21,20 @@
input type=hidden name=index value=!--TMPL_VAR
Name=index--
input type=hidden name=authtypecode value=EDITORS
input type=hidden name=q value=!-- TMPL_VAR
NAME=index --
+input type=hidden name=marclist value=all /
+input type=hidden name=and_or value=and /
+input type=hidden name=excluding value= /
+ select name=orderby
+ option value=None/option
+ option value=HeadingAsc
selected=selectedHeading A-Z/option
+ option value=HeadingDscHeading Z-A/option
+ /select
+ select name=operator
+ option value=containscontains/option
+ option value=startstarts with/option
+ option value=isis exactly/option
+ /select
+
/p
p
input type=submit value=Start search class=button
authority
@@ -53,7 +67,7 @@
td!-- TMPL_VAR NAME=summary --/td
td!-- TMPL_VAR NAME=used -- times/td
td
-a href=javascript:report('!-- TMPL_VAR
NAME=index --','!-- TMPL_VAR name=summary ESCAPE=JS --')img
alt=choose src=!-- TMPL_VAR NAME=interface --/!-- TMPL_VAR NAME=theme
--/images/arrow.gif width=32 hspace=0 vspace=0 border=0/a
+a href=javascript:report('!-- TMPL_VAR
name=summary ESCAPE=JS --')img alt=choose src=!-- TMPL_VAR
NAME=interface --/!-- TMPL_VAR NAME=theme --/images/arrow.gif
width=32 hspace=0 vspace=0 border=0/a
/td
/tr
!-- /TMPL_LOOP --
@@ -70,14 +84,14 @@
script language=JavaScript type=text/javascript
-function report(index,summary)
+function report(summary)
{
-var regexp= /(\d* -+ *)(.*)/;
+var regexp= /--\s*(.*)/;
var
[Koha-patches] [PATCH] Bug 3418: Fixes the alpha order of the system preference tags.
--- .../prog/en/includes/sysprefs-menu.inc |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-menu.inc index 5187edd..7709da5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-menu.inc @@ -2,10 +2,10 @@ ul !-- TMPL_IF NAME=Admin --li class=active!-- TMPL_ELSE --li!-- /TMPL_IF --a title=Administration href=/cgi-bin/koha/admin/systempreferences.pl?tab=AdminAdmin/a/li !-- TMPL_IF NAME=Acquisitions --li class=active!-- TMPL_ELSE --li!-- /TMPL_IF --a title=Acquisitions href=/cgi-bin/koha/admin/systempreferences.pl?tab=AcquisitionsAcquisitions/a/li -!-- TMPL_IF NAME=EnhancedContent --li class=active!-- TMPL_ELSE --li!-- /TMPL_IF --a title=Enhanced content settings href=/cgi-bin/koha/admin/systempreferences.pl?tab=EnhancedContentEnhanced Content/a/li !-- TMPL_IF NAME=Authorities --li class=active!-- TMPL_ELSE --li!-- /TMPL_IF --a title=Authority Control href=/cgi-bin/koha/admin/systempreferences.pl?tab=AuthoritiesAuthorities/a/li !-- TMPL_IF NAME=Cataloging --li class=active!-- TMPL_ELSE --li!-- /TMPL_IF --a title=Cataloging href=/cgi-bin/koha/admin/systempreferences.pl?tab=CatalogingCataloging/a/li !-- TMPL_IF NAME=Circulation --li class=active!-- TMPL_ELSE --li!-- /TMPL_IF --a title=Circulation href=/cgi-bin/koha/admin/systempreferences.pl?tab=CirculationCirculation/a/li +!-- TMPL_IF NAME=EnhancedContent --li class=active!-- TMPL_ELSE --li!-- /TMPL_IF --a title=Enhanced content settings href=/cgi-bin/koha/admin/systempreferences.pl?tab=EnhancedContentEnhanced Content/a/li !-- TMPL_IF NAME=I18N/L10N --li class=active!-- TMPL_ELSE --li!-- /TMPL_IF --a title=Internationalization and Localization href=/cgi-bin/koha/admin/systempreferences.pl?tab=I18N/L10NI18N/L10N/a/li !-- TMPL_IF NAME=Logs --li class=active!-- TMPL_ELSE --li!-- /TMPL_IF --a title=Transaction Logs href=/cgi-bin/koha/admin/systempreferences.pl?tab=LogsLogs/a/li !-- TMPL_IF NAME=OAI-PMH --li class=active!-- TMPL_ELSE --li!-- /TMPL_IF --a title=OAI-PMH href=/cgi-bin/koha/admin/systempreferences.pl?tab=OAI-PMHOAI-PMH/a/li -- 1.5.6.5 ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches
