Re: [Koha-patches] [PATCH] (bug #3412) fix double encoded guided report

[Frédéric DEMIANS]

 -binmode STDOUT, ':utf8';
 -

 [1] I have not been able to reproduce the double-encoding problem - a
 report on biblio.title looks OK for titles that include diacritics.
 Please add more information about how to reproduce the problem to the
 bug.

 [2] The two lines that this patch removes were lines that you yourself
 added in commit f6027eb4 to ensure correct UTF-8 text in CSV
 downloads. Removing these lines would cause a regression for CSV
 output, would it not?

Those utf8 issues are very strange. I don't understand the logic. I 
confirm I had also to suppress this line to avoid corrupted reports. My 
'feeling' is that binmode should be avoided at all. If characters are 
correctly handled in Perl script, explicitly specifying output file 
encoding is not required anymore. If you began doing binmode on files, 
you also need to encode-decode strings, and at the end of the day you 
get Nahuel double-encoding problems.

-- 
Frédéric DEMIANS
http://www.tamil.fr/u/fdemians.html
___
Koha-patches mailing list
Koha-patches@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-patches

[Koha-patches] [PATCH] (bug #3412) fix double encoded guided report

[Nahuel ANGELINETTI]

---
 reports/guided_reports.pl |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
index 89b4bfc..e9a31bf 100755
--- a/reports/guided_reports.pl
+++ b/reports/guided_reports.pl
@@ -340,8 +340,6 @@ elsif ( $phase eq 'Save Report' ) {
 }
 
 elsif ($phase eq 'Run this report'){
-binmode STDOUT, ':utf8';
-
 # execute a saved report
 my $limit  = 20;# page size. # TODO: move to DB or syspref?
 my $offset = 0;
-- 
1.6.0.4

___
Koha-patches mailing list
Koha-patches@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-patches