Re: XMPP Patches
On Friday 02 February 2018 13:00:12 Shawn Sörbom wrote: > On Friday, February 2, 2018 12:41:41 PM PST Pali Rohár wrote: > > On Friday 02 February 2018 12:25:18 Shawn Sörbom wrote: > > > find_qjson.diff: Xmpp was missing a required dependency in its build > > > script - I added it. > > > > Seems this patch is not needed anymore. Wrong/old configuration for > > QJSON was already removed from kopete git. > > At the time, I wrote these patches against kf5-master, which has since been > merged(?) Wasn't aware the issue has been fixed. I will pull and rebuild :) Fix is by Michael Palimaka and it was committed at 2018-02-02 13:47:36. So its new change. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature
Re: XMPP Patches
On Friday 02 February 2018 21:41:41 Pali Rohár wrote: > > disable-libjingle: Unfortunately fixing the xmpp issue also enabled > > libjingle, > > which caused the compiler to error out, so I set the default to disabled. > > I'm going to look at this problem. libjingle should build fine. Should be fixed in git master. Compilation with libjingle should work fine. I tested voice call on localhost with two jabber accounts and I sound works too! -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature
Re: XMPP Patches
On Friday, February 2, 2018 12:41:41 PM PST Pali Rohár wrote: > Hi! > > On Friday 02 February 2018 12:25:18 Shawn Sörbom wrote: > > Hi, > > My mail to kde.org keeps getting bounced, but I would like to have this on > > record anyway. I found some issues with Jabber in kopetes build scripts. > > Im > > including the patches to fix them. > > > > find_qjson.diff: Xmpp was missing a required dependency in its build > > script - I added it. > > Seems this patch is not needed anymore. Wrong/old configuration for > QJSON was already removed from kopete git. > > > disable-libjingle: Unfortunately fixing the xmpp issue also enabled > > libjingle, which caused the compiler to error out, so I set the default > > to disabled. > I'm going to look at this problem. libjingle should build fine. > > > XMPP Now builds! Vive open chat protocols! At the time, I wrote these patches against kf5-master, which has since been merged(?) Wasn't aware the issue has been fixed. I will pull and rebuild :)
Re: XMPP Patches
Hi! On Friday 02 February 2018 12:25:18 Shawn Sörbom wrote: > Hi, > My mail to kde.org keeps getting bounced, but I would like to have this on > record anyway. I found some issues with Jabber in kopetes build scripts. Im > including the patches to fix them. > > find_qjson.diff: Xmpp was missing a required dependency in its build script - > I > added it. Seems this patch is not needed anymore. Wrong/old configuration for QJSON was already removed from kopete git. > disable-libjingle: Unfortunately fixing the xmpp issue also enabled > libjingle, > which caused the compiler to error out, so I set the default to disabled. I'm going to look at this problem. libjingle should build fine. > XMPP Now builds! Vive open chat protocols! -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature
XMPP Patches
Hi, My mail to kde.org keeps getting bounced, but I would like to have this on record anyway. I found some issues with Jabber in kopetes build scripts. Im including the patches to fix them. find_qjson.diff: Xmpp was missing a required dependency in its build script - I added it. disable-libjingle: Unfortunately fixing the xmpp issue also enabled libjingle, which caused the compiler to error out, so I set the default to disabled. XMPP Now builds! Vive open chat protocols! --- a/protocols/CMakeLists.txt +++ b/protocols/CMakeLists.txt @@ -7,7 +7,7 @@ option(WITH_winpopup "Enable Kopete winpopup protocol" ON) option(WITH_gadu "Enable Kopete Gadu-Gadu protocol" ON) option(WITH_jabber "Enable Kopete Jabber protocol" ON) -option(WITH_libjingle "Enable Kopete Jabber libjingle support" ON) +option(WITH_libjingle "Enable Kopete Jabber libjingle support" OFF) option(WITH_bonjour "Enable Kopete Bonjour protocol" ON) option(WITH_wlm "Enable Window Live Messenger support" ON) option(WITH_WLM_MEDIASTREAMER "Enable Windows Live Messenger voice clip support" ON) --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -145,6 +145,8 @@ find_package(Xmms QUIET) set_package_properties(Xmms PROPERTIES DESCRIPTION "X Multimedia System development libraries" URL "http://www.xmms.org/"; TYPE OPTIONAL PURPOSE "Required for the Nowlistening plugin with XMMS player support") +find_package(QJSON QUIET) + find_package(ZLIB QUIET) set_package_properties(ZLIB PROPERTIES DESCRIPTION "Zlib is a library implementing the deflate compression method" URL "http://zlib.net/"; TYPE OPTIONAL PURPOSE "Required for the GroupWise and Jabber protocols")
D10160: Test for Crypt in QQ Protocol
himanshuvishwakarma updated this revision to Diff 26380. himanshuvishwakarma added a comment. struct is removed CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10160?vs=26299&id=26380 REVISION DETAIL https://phabricator.kde.org/D10160 AFFECTED FILES tests/protocols/CMakeLists.txt tests/protocols/qq/CMakeLists.txt tests/protocols/qq/qqcrypttest.cpp To: himanshuvishwakarma, vijaykrishnavanshi, pali, #kopete Cc: kopete-devel, cochise
