Re: [libav-devel] [PATCH 09/11] cbs: Add some read/write tests

2017-09-21 Thread Diego Biurrun 
On Wed, Sep 20, 2017 at 09:03:40PM +0100, Mark Thompson wrote:
> On 20/09/17 19:48, Diego Biurrun wrote:
> > On Sun, Sep 10, 2017 at 12:09:13AM +0100, Mark Thompson wrote:
> >> --- /dev/null
> >> +++ b/tests/fate/cbs.mak
> >> @@ -0,0 +1,74 @@
> >> +
> >> +define FATE_CBS_TEST
> >> +# (codec, test_name, sample_file, output_format)
> >> +FATE_CBS_$(1) += fate-cbs-$(1)-$(2)
> >> +fate-cbs-$(1)-$(2): CMD = md5 -i $(TARGET_SAMPLES)/$(3) -c:v copy -bsf:v 
> >> $(1)_metadata -f $(4)
> >> +endef
> >> +
> >> +$(foreach N,$(FATE_CBS_H264_SAMPLES),$(eval $(call 
> >> FATE_CBS_TEST,h264,$(basename $(N)),h264-conformance/$(N),h264)))
> >> +
> >> +$(foreach N,$(FATE_CBS_HEVC_SAMPLES),$(eval $(call 
> >> FATE_CBS_TEST,hevc,$(basename $(N)),hevc-conformance/$(N),hevc)))
> > 
> > The 1st and 4th arguments are identical. If you wanted, you could get rid
> > of the prefix of the third argument by integrating it into CMD.
> 
> Further down the file there is also:
> 
> >> +$(foreach N,$(FATE_CBS_MPEG2_SAMPLES),$(eval $(call 
> >> FATE_CBS_TEST,mpeg2,$(basename $(N)),mpeg2/$(N),mpeg2video)))
> 
> which doesn't admit either of those changes.

Sorry, I misread. Probably because the mpeg2 tests used a different macro
previously I think. Whatever ...

LGTM then.

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 09/11] cbs: Add some read/write tests

2017-09-20 Thread Mark Thompson 
On 20/09/17 19:48, Diego Biurrun wrote:
> On Sun, Sep 10, 2017 at 12:09:13AM +0100, Mark Thompson wrote:
>> --- /dev/null
>> +++ b/tests/fate/cbs.mak
>> @@ -0,0 +1,74 @@
>> +
>> +define FATE_CBS_TEST
>> +# (codec, test_name, sample_file, output_format)
>> +FATE_CBS_$(1) += fate-cbs-$(1)-$(2)
>> +fate-cbs-$(1)-$(2): CMD = md5 -i $(TARGET_SAMPLES)/$(3) -c:v copy -bsf:v 
>> $(1)_metadata -f $(4)
>> +endef
>> +
>> +$(foreach N,$(FATE_CBS_H264_SAMPLES),$(eval $(call 
>> FATE_CBS_TEST,h264,$(basename $(N)),h264-conformance/$(N),h264)))
>> +
>> +$(foreach N,$(FATE_CBS_HEVC_SAMPLES),$(eval $(call 
>> FATE_CBS_TEST,hevc,$(basename $(N)),hevc-conformance/$(N),hevc)))
> 
> The 1st and 4th arguments are identical. If you wanted, you could get rid
> of the prefix of the third argument by integrating it into CMD.

Further down the file there is also:

>> +$(foreach N,$(FATE_CBS_MPEG2_SAMPLES),$(eval $(call 
>> FATE_CBS_TEST,mpeg2,$(basename $(N)),mpeg2/$(N),mpeg2video)))

which doesn't admit either of those changes.

Thanks,

- Mark
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 09/11] cbs: Add some read/write tests

2017-09-20 Thread Diego Biurrun 
On Sun, Sep 10, 2017 at 12:09:13AM +0100, Mark Thompson wrote:
> --- /dev/null
> +++ b/tests/fate/cbs.mak
> @@ -0,0 +1,74 @@
> +
> +define FATE_CBS_TEST
> +# (codec, test_name, sample_file, output_format)
> +FATE_CBS_$(1) += fate-cbs-$(1)-$(2)
> +fate-cbs-$(1)-$(2): CMD = md5 -i $(TARGET_SAMPLES)/$(3) -c:v copy -bsf:v 
> $(1)_metadata -f $(4)
> +endef
> +
> +$(foreach N,$(FATE_CBS_H264_SAMPLES),$(eval $(call 
> FATE_CBS_TEST,h264,$(basename $(N)),h264-conformance/$(N),h264)))
> +
> +$(foreach N,$(FATE_CBS_HEVC_SAMPLES),$(eval $(call 
> FATE_CBS_TEST,hevc,$(basename $(N)),hevc-conformance/$(N),hevc)))

The 1st and 4th arguments are identical. If you wanted, you could get rid
of the prefix of the third argument by integrating it into CMD.

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 09/11] cbs: Add some read/write tests

2017-09-11 Thread Luca Barbato 

On 10/09/2017 01:09, Mark Thompson wrote:

Use the appropriate metadata filter for each codec - in the absence of any
options to modify the stream, the output bitstream should be identical to
the input (though the output file may differ in padding).

All tests use conformance bitstreams, the MPEG-2 streams are newly added
from the conformance test streams

---
Exact files to add to the samples are at 
, or can be found at the 
link above.

They probably want to separately have an MPEG-2 decode test as well.



OK.

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 09/11] cbs: Add some read/write tests

2017-09-09 Thread Mark Thompson 
Use the appropriate metadata filter for each codec - in the absence of any
options to modify the stream, the output bitstream should be identical to
the input (though the output file may differ in padding).

All tests use conformance bitstreams, the MPEG-2 streams are newly added
from the conformance test streams

---
Exact files to add to the samples are at 
, or can be found at the 
link above.

They probably want to separately have an MPEG-2 decode test as well.


 tests/Makefile|  1 +
 tests/fate/cbs.mak| 74 +++
 tests/ref/fate/cbs-h264-AUD_MW_E  |  1 +
 tests/ref/fate/cbs-h264-BASQP1_Sony_C |  1 +
 tests/ref/fate/cbs-h264-CABACI3_Sony_B|  1 +
 tests/ref/fate/cbs-h264-CVBS3_Sony_C  |  1 +
 tests/ref/fate/cbs-h264-CVFC1_Sony_C  |  1 +
 tests/ref/fate/cbs-h264-CVMANL1_TOSHIBA_B |  1 +
 tests/ref/fate/cbs-h264-CVNLFI1_Sony_C|  1 +
 tests/ref/fate/cbs-h264-CVSE2_Sony_B  |  1 +
 tests/ref/fate/cbs-h264-CVWP1_TOSHIBA_E   |  1 +
 tests/ref/fate/cbs-h264-FM1_BT_B  |  1 +
 tests/ref/fate/cbs-h264-MR1_BT_A  |  1 +
 tests/ref/fate/cbs-h264-SVA_Base_B|  1 +
 tests/ref/fate/cbs-h264-Sharp_MP_PAFF_1r2 |  1 +
 tests/ref/fate/cbs-h264-sp1_bt_a  |  1 +
 tests/ref/fate/cbs-hevc-CAINIT_E_SHARP_3  |  1 +
 tests/ref/fate/cbs-hevc-CAINIT_H_SHARP_3  |  1 +
 tests/ref/fate/cbs-hevc-CONFWIN_A_Sony_1  |  1 +
 tests/ref/fate/cbs-hevc-HRD_A_Fujitsu_2   |  1 +
 tests/ref/fate/cbs-hevc-LTRPSPS_A_Qualcomm_1  |  1 +
 tests/ref/fate/cbs-hevc-NUT_A_ericsson_5  |  1 +
 tests/ref/fate/cbs-hevc-PICSIZE_A_Bossen_1|  1 +
 tests/ref/fate/cbs-hevc-PICSIZE_B_Bossen_1|  1 +
 tests/ref/fate/cbs-hevc-RPLM_A_qualcomm_4 |  1 +
 tests/ref/fate/cbs-hevc-RPS_A_docomo_4|  1 +
 tests/ref/fate/cbs-hevc-RPS_E_qualcomm_5  |  1 +
 tests/ref/fate/cbs-hevc-SLIST_A_Sony_4|  1 +
 tests/ref/fate/cbs-hevc-SLIST_D_Sony_9|  1 +
 tests/ref/fate/cbs-hevc-STRUCT_A_Samsung_5|  1 +
 tests/ref/fate/cbs-hevc-TILES_B_Cisco_1   |  1 +
 tests/ref/fate/cbs-hevc-WPP_A_ericsson_MAIN_2 |  1 +
 tests/ref/fate/cbs-hevc-WPP_F_ericsson_MAIN_2 |  1 +
 tests/ref/fate/cbs-hevc-WP_A_Toshiba_3|  1 +
 tests/ref/fate/cbs-hevc-ipcm_E_NEC_2  |  1 +
 tests/ref/fate/cbs-mpeg2-hhi_burst_422_short  |  1 +
 tests/ref/fate/cbs-mpeg2-sony-ct3 |  1 +
 tests/ref/fate/cbs-mpeg2-tcela-6  |  1 +
 38 files changed, 111 insertions(+)
 create mode 100644 tests/fate/cbs.mak
 create mode 100644 tests/ref/fate/cbs-h264-AUD_MW_E
 create mode 100644 tests/ref/fate/cbs-h264-BASQP1_Sony_C
 create mode 100644 tests/ref/fate/cbs-h264-CABACI3_Sony_B
 create mode 100644 tests/ref/fate/cbs-h264-CVBS3_Sony_C
 create mode 100644 tests/ref/fate/cbs-h264-CVFC1_Sony_C
 create mode 100644 tests/ref/fate/cbs-h264-CVMANL1_TOSHIBA_B
 create mode 100644 tests/ref/fate/cbs-h264-CVNLFI1_Sony_C
 create mode 100644 tests/ref/fate/cbs-h264-CVSE2_Sony_B
 create mode 100644 tests/ref/fate/cbs-h264-CVWP1_TOSHIBA_E
 create mode 100644 tests/ref/fate/cbs-h264-FM1_BT_B
 create mode 100644 tests/ref/fate/cbs-h264-MR1_BT_A
 create mode 100644 tests/ref/fate/cbs-h264-SVA_Base_B
 create mode 100644 tests/ref/fate/cbs-h264-Sharp_MP_PAFF_1r2
 create mode 100644 tests/ref/fate/cbs-h264-sp1_bt_a
 create mode 100644 tests/ref/fate/cbs-hevc-CAINIT_E_SHARP_3
 create mode 100644 tests/ref/fate/cbs-hevc-CAINIT_H_SHARP_3
 create mode 100644 tests/ref/fate/cbs-hevc-CONFWIN_A_Sony_1
 create mode 100644 tests/ref/fate/cbs-hevc-HRD_A_Fujitsu_2
 create mode 100644 tests/ref/fate/cbs-hevc-LTRPSPS_A_Qualcomm_1
 create mode 100644 tests/ref/fate/cbs-hevc-NUT_A_ericsson_5
 create mode 100644 tests/ref/fate/cbs-hevc-PICSIZE_A_Bossen_1
 create mode 100644 tests/ref/fate/cbs-hevc-PICSIZE_B_Bossen_1
 create mode 100644 tests/ref/fate/cbs-hevc-RPLM_A_qualcomm_4
 create mode 100644 tests/ref/fate/cbs-hevc-RPS_A_docomo_4
 create mode 100644 tests/ref/fate/cbs-hevc-RPS_E_qualcomm_5
 create mode 100644 tests/ref/fate/cbs-hevc-SLIST_A_Sony_4
 create mode 100644 tests/ref/fate/cbs-hevc-SLIST_D_Sony_9
 create mode 100644 tests/ref/fate/cbs-hevc-STRUCT_A_Samsung_5
 create mode 100644 tests/ref/fate/cbs-hevc-TILES_B_Cisco_1
 create mode 100644 tests/ref/fate/cbs-hevc-WPP_A_ericsson_MAIN_2
 create mode 100644 tests/ref/fate/cbs-hevc-WPP_F_ericsson_MAIN_2
 create mode 100644 tests/ref/fate/cbs-hevc-WP_A_Toshiba_3
 create mode 100644 tests/ref/fate/cbs-hevc-ipcm_E_NEC_2
 create mode 100644 tests/ref/fate/cbs-mpeg2-hhi_burst_422_short
 create mode 100644 tests/ref/fate/cbs-mpeg2-sony-ct3
 create mode 100644 tests/ref/fate/cbs-mpeg2-tcela-6

diff --git a/tests/Makefile b/tests/Makefile
index d3f11efaa..9fec13211