[Libdbi-drivers-devel] dbd_sqlite3 things

2013-10-05 Thread markus . hoenicka 
Jan Engelhardt writes:
  
  The find_result_field_types function in dbd_sqlite3.c
  tests for total( abs( and round( twice, which seems redundant.
  
   if ( strstr(curr_field_lower,avg() ||
strstr(curr_field_lower,sum() ||
strstr(curr_field_lower,total() ||
strstr(curr_field_lower,abs() ||
strstr(curr_field_lower,round() ) {
 return FIELD_TYPE_FLOAT;
   }
   ...
   if ( strstr(curr_field_lower,randomblob() ||
strstr(curr_field_lower,zeroblob() ||
strstr(curr_field_lower,total() ||
strstr(curr_field_lower,abs() ||
strstr(curr_field_lower,round() ) {
 return FIELD_TYPE_BLOB;
   }

Hi,

the second occurrences of these checks were indeed never reached
during execution. I've checked in a fix (revision 1.51).

thanks
Markus

-- 
Markus Hoenicka
http://www.mhoenicka.de
AQ score 38

--
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register 
http://pubads.g.doubleclick.net/gampad/clk?id=60134791iu=/4140/ostg.clktrk
___
Libdbi-drivers-devel mailing list
Libdbi-drivers-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libdbi-drivers-devel

[Libdbi-drivers-devel] dbd_sqlite3 things

2013-09-20 Thread Jan Engelhardt 

The find_result_field_types function in dbd_sqlite3.c
tests for total( abs( and round( twice, which seems redundant.

if ( strstr(curr_field_lower,avg() ||
 strstr(curr_field_lower,sum() ||
 strstr(curr_field_lower,total() ||
 strstr(curr_field_lower,abs() ||
 strstr(curr_field_lower,round() ) {
  return FIELD_TYPE_FLOAT;
}
...
if ( strstr(curr_field_lower,randomblob() ||
 strstr(curr_field_lower,zeroblob() ||
 strstr(curr_field_lower,total() ||
 strstr(curr_field_lower,abs() ||
 strstr(curr_field_lower,round() ) {
  return FIELD_TYPE_BLOB;
}

--
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. 
http://pubads.g.doubleclick.net/gampad/clk?id=58041151iu=/4140/ostg.clktrk
___
Libdbi-drivers-devel mailing list
Libdbi-drivers-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libdbi-drivers-devel