[Libreoffice] LibreOffice for OI or OSOL
Good day. Will ever LibreOffice available for operating system OpenIndiana_x86 or OpenSolaris_x86? Thank you for your reply. Komarek. -- View this message in context: http://nabble.documentfoundation.org/LibreOffice-for-OI-or-OSOL-tp2352396p2352396.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Build error on l10ntools
Hi all, The error occur while I was building LibreOffice on windows. It's on master branch. /MAP /OPT:NOREF -safeseh -nxcompat -dynamicbase -NODEFAULTLIB -RELEASE -DEBUG -INCREMENTAL:NO /SUBSYSTEM:CONSOLE /DLL -out:../../ wntmsci12.pro/bin/helplinkermi.dll -map:../../ wntmsci12.pro/misc/helplinkermi.map ../../wntmsci12.pro/lib/ihelplinker.exp../../ wntmsci12.pro/slo/helplinker_dflt_version.o bj ../../wntmsci12.pro/slb/HelpLinker.lib isal.lib libdb47.lib libxslt.lib libxml2.lib expat_xmltok.lib ascii_expat_xmlparse.lib msvcrt.lib uwinapi.lib kernel32.lib user32.lib oldnames.lib stlport_vc71.lib ../../ wntmsci12.pro/misc/helplinkermi.res LINK : fatal error LNK1181: cannot open input file 'libdb47.lib' dmake: Error code 2, while making '../../wntmsci12.pro/bin/helplinkermi.dll ' Anyone have any ideas? -- _/|\_ Tantai Thanakanok. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Translation of comments (minor, 6 files) in sw/inc
From 9e0f8f0b3d1678862b3f261eed398c9825acaadd Mon Sep 17 00:00:00 2001
From: Christoph Herzog rho...@googlemail.com
Date: Wed, 26 Jan 2011 10:38:06 +0100
Subject: [PATCH] Translation of comments (minor, 6 files) in sw/inc
(LGPLv3+ / MPL)
From 9e0f8f0b3d1678862b3f261eed398c9825acaadd Mon Sep 17 00:00:00 2001
From: Christoph Herzog rho...@googlemail.com
Date: Wed, 26 Jan 2011 10:38:06 +0100
Subject: [PATCH] Translation of comments (minor, 6 files) in sw/inc
---
sw/inc/fldbas.hxx | 111 ---
sw/inc/flddat.hxx | 11 +-
sw/inc/fldinit.hxx |4 +-
sw/inc/flyenum.hxx | 17
sw/inc/flypos.hxx | 11 +++--
sw/inc/fmtanchr.hxx | 12 ++---
6 files changed, 65 insertions(+), 101 deletions(-)
diff --git a/sw/inc/fldbas.hxx b/sw/inc/fldbas.hxx
index a3a89bb..1602d3f 100644
--- a/sw/inc/fldbas.hxx
+++ b/sw/inc/fldbas.hxx
@@ -43,13 +43,9 @@ class SvNumberFormatter;
#endif // FIELDIDS_ONLY
-/*
-Beschreibung: die ID's fuer die Feldtypen
- */
-
enum RES_FIELDS
{
-// Fuer die alten Dokumente muessen die Field-Which IDS erhalten bleiben
+// For old documents the Field-Which IDs must be preserved !!!
RES_FIELDS_BEGIN,
RES_DBFLD = RES_FIELDS_BEGIN,
RES_USERFLD,
@@ -94,10 +90,7 @@ enum RES_FIELDS
RES_FIELDS_END
};
-/*
-Beschreibung: Liste der FieldTypes am UI
- */
-
+// List of FieldTypes at UI.
enum SwFldTypesEnum
{
TYP_BEGIN,
@@ -163,28 +156,28 @@ enum SwFileNameFormat
enum SwVarFormat
{
-VVF_CMD = 0x0010, // Kommando anzeigen
-VVF_INVISIBLE = 0x0040, // unsichtbar
+VVF_CMD = 0x0010, // Show command.
+VVF_INVISIBLE = 0x0040, // Invisible.
VVF_XXP = 0x0400, // 1234%
VVF_XX_XXP = 0x0800, // 1.234,56%
VVF_CLEAR = 0x000f,
-// ab hier neue Formate
-VVF_SYS = 0x2000, //Zahlenformat aus der Systemeinstellung
+// From here new formats:
+VVF_SYS = 0x2000, // Format for numbers from system.
VVF_X = 0x2100, // 1234
-VVF_X_X = 0x2200, // 1234,5
-VVF_X_XX = 0x2300, // 1245,56
-VVF_XX_X = 0x2400, // 1.234,5
-VVF_XX_XX = 0x2500, // 1.234,56
-VVF_XX_XXX = 0x2600, // 1.234,567
-VVF_SYS_CUR = 0x2700, // W???hrungsformat aus der Systemeinstellung
-VVF_CUR_X = 0x2800, // DM 1234
-VVF_CUR_XX_XX = 0x2900, // DM 1234,56 DM 1234,00
-VVF_CUR_XX_X0 = 0x2a00, // DM 1234,56 DM 1234,--
-VVF_X_CUR = 0x2b00, // 1234 DM
-VVF_XX_XX_CUR = 0x2c00, // 1234,56 DM 1234,00 DM
-VVF_XX_X0_CUR = 0x2d00,// 1234,56 DM 1234,-- DM
-// Kompatibilitaet:
+VVF_X_X = 0x2200, // 1234.5
+VVF_X_XX = 0x2300, // 1245.56
+VVF_XX_X = 0x2400, // 1.234.5
+VVF_XX_XX = 0x2500, // 1.234.56
+VVF_XX_XXX = 0x2600, // 1.234.567
+VVF_SYS_CUR = 0x2700, // Format for currency from system.
+VVF_CUR_X = 0x2800, // EUR 1234
+VVF_CUR_XX_XX = 0x2900, // EUR 1234.56 EUR 1234.00
+VVF_CUR_XX_X0 = 0x2a00, // EUR 1234.56 EUR 1234.--
+VVF_X_CUR = 0x2b00, // 1234 EUR
+VVF_XX_XX_CUR = 0x2c00, // 1234.56 EUR 1234.00 EUR
+VVF_XX_X0_CUR = 0x2d00, // 1234.56 EUR 1234.-- EUR
+// Compatibility:
VF_CMD = VVF_CMD,
VF_INVISIBLE= VVF_INVISIBLE,
VF_XXP = VVF_XXP,
@@ -204,16 +197,15 @@ namespace nsSwGetSetExpType
const SwGetSetExpType GSE_EXPR = 0x0002; // Expression
const SwGetSetExpType GSE_INP = 0x0004; // InputField
const SwGetSetExpType GSE_SEQ = 0x0008; // Sequence
-const SwGetSetExpType GSE_FORMULA = 0x0010; // Formel
+const SwGetSetExpType GSE_FORMULA = 0x0010; // Formula
}
typedef USHORT SwExtendedSubType;
namespace nsSwExtendedSubType
{
-const SwExtendedSubType SUB_CMD = 0x0100; // Kommando anzeigen
-const SwExtendedSubType SUB_INVISIBLE = 0x0200; // unsichtbar
-const SwExtendedSubType SUB_OWN_FMT = 0x0400; // SwDBField: Uebernimmt Formatierung nicht
-// aus Datenbank
+const SwExtendedSubType SUB_CMD = 0x0100; // Show command.
+const SwExtendedSubType SUB_INVISIBLE = 0x0200; // Invisible.
+const SwExtendedSubType SUB_OWN_FMT = 0x0400; // SwDBField: Don't accept formating from database.
}
enum SwInputFieldSubType
@@ -242,34 +234,27 @@ enum SwDateTimeSubType
extern USHORT aTypeTab[];
-/*
-Beschreibung: Allgemeine Tools
- */
-
+// General tools.
String GetResult(double nVal, sal_uInt32 nNumFmt, USHORT nLang = LANGUAGE_SYSTEM);
voidSetErrorStr(const
Re: [Libreoffice] Build error on l10ntools
I problem have been solved by rebuilding the berkeleydb. On Wed, Jan 26, 2011 at 4:25 PM, Tantai Tanakanok tan...@osdev.co.thwrote: Hi all, The error occur while I was building LibreOffice on windows. It's on master branch. /MAP /OPT:NOREF -safeseh -nxcompat -dynamicbase -NODEFAULTLIB -RELEASE -DEBUG -INCREMENTAL:NO /SUBSYSTEM:CONSOLE /DLL -out:../../ wntmsci12.pro/bin/helplinkermi.dll -map:../../ wntmsci12.pro/misc/helplinkermi.map ../../ wntmsci12.pro/lib/ihelplinker.exp ../../ wntmsci12.pro/slo/helplinker_dflt_version.o bj ../../wntmsci12.pro/slb/HelpLinker.lib isal.lib libdb47.lib libxslt.lib libxml2.lib expat_xmltok.lib ascii_expat_xmlparse.lib msvcrt.lib uwinapi.lib kernel32.lib user32.lib oldnames.lib stlport_vc71.lib ../../ wntmsci12.pro/misc/helplinkermi.res LINK : fatal error LNK1181: cannot open input file 'libdb47.lib' dmake: Error code 2, while making '../../ wntmsci12.pro/bin/helplinkermi.dll' Anyone have any ideas? -- _/|\_ Tantai Thanakanok. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ -- _/|\_ Tantai Thanakanok. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] development summary: year 2011, week 3
Hi, this time a brief summary of what happened during the 3nd week in 2011 on LibreOffice repositories and the living branches: + master:hot LO-3.4 development + libreoffice-3-3: fixes for next LO-3.3.x bug fix release + libreoffice-3-3-0: final stabilization for LO-3.3.0 release[*] There are two logs for each branch: + bugfixes-branch-year-week.txt lists all commits that reference a proper bug id from a variety of trackers, i.e. #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla + commit-log-branch-year-week.txt lists all relevant commits on the actual source repositories [*] libreoffice-3-3-0 branch is not longer living because 3.3.0rc4 has been marked as final the next 3.3.1 release will be based on libreoffice-3-3 branch Many thanks to all contributors - you make all the difference! Let's celebrate our first baby, the 3.3.0 release - it would not happen without you! Best Regards, Petr + base: + i#116187: report left/right page margin setting ignored on Unix 64 bit [Lionel Elie Mamane] + libs-core: + calc65: #i116371# fix backgrounds for polypolygons in metafile [Philipp Lohmann [pl]] + Sun Microsystems - The Document Foundation in desktop file fdo#31191 [Andras Timar] + libs-gui: + calc65: #i116318# Fixed the painting of axial gradients. [Andre Fischer] + do not mix unrelated X11 Visuals (fdo#33108) [Luboš Luňák] + build: + install bash completion for oo* wrappers when enabled (bnc#665402) [Petr Mladek] + calc: + Fixed incorrect page number in page preview mode. (fdo#33155) [Kohei Yoshida] + filters: + fdo#33237# fix ole object import for writer (docx) [Noel Power] + fdo#33237 remove debug line [Noel Power] + libs-core: + calc65: #i116371# fix backgrounds for polypolygons in metafile [Philipp Lohmann [pl]] + Sun Microsystems - The Document Foundation in desktop file fdo#31191 [Andras Timar] + libs-gui: + calc65: #i116318# Fixed the painting of axial gradients. [Andre Fischer] + cleanup into one patch: do not mix unrelated X11 Visuals (fdo#33108) [Luboš Luňák] + Default currency for Estonia should be Euro - fdo#33160 [Andras Timar] + paint toolbar handle positioned properly (fdo#32558) [Luboš Luňák] + writer: + bnc#660816 improve formfield checkbox binary export ( and import ) [Noel Power] + common: + fix KDE3 library search order (fdo#32797) [Luboš Luňák] + bootstrap: + removed ms, ps, and ur from postset.mk - fdo#33103 [Andras Timar] + calc: + Better cell anchoring. (fdo#33205) [Caolán McNamara] + Fixed incorrect page number in page preview mode. (fdo#33155) [Kohei Yoshida] + filters: + fdo#33237# fix ole object import for writer (docx) [Noel Power] + fdo#33237 remove debug line [Noel Power] + fix default bullet size, n#656934 [Radek Doulik] + set characters encoding for symbol fonts, n#656934 [Radek Doulik] + libs-core: + fix COMMON_OUTDIR/COMMON_OUTPUT typo (fdo#33096) [Luboš Luňák] + Improve the 'Update all links?' message, fdo#32548. [Jan Holesovsky] + readme formatting - fdo#32741 [Andras Timar] + Related: rhbz#668057 use default server-side permissions for copied files [Caolán McNamara] + Sun Microsystems - The Document Foundation in desktop file fdo#31191 [Andras Timar] + libs-gui: + do not mix unrelated X11 Visuals (fdo#33108) [Luboš Luňák] + paint toolbar handle positioned properly (fdo#32558) [Luboš Luňák] + build bits: + build with libpng 1.5.0 (fdo#33231) [Luboš Luňák] + Related: rhbz#670895 don't halt build if zenity crashes [Caolán McNamara] + common: + Version 3.3.0.4, tag libreoffice-3.3.0.4 (3.3-rc4) [Petr Mladek] + base: + i#116187: report left/right page margin setting ignored on Unix 64 bit [Lionel Elie Mamane] + bootstrap: + Added ca_XV and ast name and description [Andras Timar] + removed language code 'kid' [Andras Timar] + build: + ast and ca_XV name/desc has been added to pot [Andras Timar] + (DebianBaseOnly) openoffice.org-java-common - libreoffice-java-common [Rene Engelhard] + fix a typo in distro defaults [Fridrich Štrba] + make reportdesign-mention-package-l10n.diff apply again [Rene Engelhard] + Putting relevant configure options into distro config files [Fridrich Štrba] + remove Koshin, because 'kid' is not Koshin in LibreOffice [Andras Timar] + Slovenian (sl) translation update [Martin Srebotnjak] + update Debian-only parts of package-ooo for new lo*/libreoffice* [Rene Engelhard] + Updated translations [Andras Timar] + filters: + Fix a typo SolarMuexGuard - SolarMutexGuard [Fridrich Štrba] + libs-core: + calc65: #i116371# fix backgrounds for polypolygons in metafile [Philipp Lohmann [pl]] + Sun Microsystems - The Document Foundation in desktop file fdo#31191 [Andras Timar] + libs-gui: + Avoid GetHelpText() call
Re: [Libreoffice] Address Books
Norbert Thiebaud wrote: for info: http://hg.services.openoffice.org/cws/dba34a/rev/d5b3bb5ca529 Cherry-picked on master. -- Thorsten pgpWAroYOTVbj.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] configure: WARNING: Your gcc is not -fvisibility=hidden safe. Disabling visibility
On Wed, 2011-01-26 at 13:56 +, Caolán McNamara wrote: Actually I think that warning might be bogus. Digging back into gcc PR26905 I see they specifically don't regress test for this bug on Darwin. Following that logic I've moved the test for us too. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] bootstrap - added script to search for unnecessary newlines
Michael Koch wrote: The script recursively searches directories for consecutive empty line(s) - code line groups. (discussed with mmeeks) Hi Michael, cool, nice script - pushed! What would you be interested in next? Thanks, -- Thorsten pgpXeeRfOZ4y7.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [REVIEW] Fix KDE3 support (fdo#32797)
Lubos Lunak wrote: Could somebody please ACK these two commits for backport? Thanks. Cherry-picked for -3-3. -- Thorsten pgpizIlzQBr4R.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Accept using a bin/java that is a symlink
Lionel Elie Mamane wrote: I use Debian. A self-compiled libreoffice refuses to use my GNU Java (gij), saying the directory does not contain a JRE. The Debian package of libreoffice actually autodetects it and happily uses it, but I have not easily identified the Debian patch that is responsible for this. Good question - maybe one of the jvmfwk*.diff ones in http://cgit.freedesktop.org/libreoffice/build/tree/patches/dev300 adds the specific path? Rene/Petr, something that we'd better merge? Thanks, -- Thorsten pgpfFN1s79DnQ.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] Make CC/CXX configurable again (there's a gcc-4.0 incompat on mac)
Hi, this is for libreoffice-3-3 - I have a local fix in place to be able to build in the first place, on OSX 10.6 with latest XCode. I cannot see a reason why to clobber CC/CXX, FWIW, in master, this code is gone for good anyway - Michael, do you recall? Cheers, -- Thorsten From 528c110931e9c517e81ad89dcc28a76e7a5cf5b7 Mon Sep 17 00:00:00 2001 From: Thorsten Behrens tbehr...@novell.com Date: Sat, 15 Jan 2011 22:32:10 +0100 Subject: [PATCH] Make CC/CXX configurable again (there's a gcc-4.0 incompat on mac) --- bin/setup.in |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/bin/setup.in b/bin/setup.in index f2508a3..5136075 100755 --- a/bin/setup.in +++ b/bin/setup.in @@ -140,10 +140,6 @@ test z$DESTDIR = z || OODESTDIR=$DESTDIR # clobber bogus env vars. they badly screw things up unset DESTDIR; -unset CC; -unset CXX; -unset CPP; -unset CXXCPP; unset ERROR_FLAGS; unset MAKE unset WARN_CFLAGS -- 1.7.3.4 pgpiI9ZYp3iYF.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Accept using a bin/java that is a symlink
On Wed, 2011-01-26 at 16:20 +0100, Thorsten Behrens wrote: Lionel Elie Mamane wrote: I use Debian. A self-compiled libreoffice refuses to use my GNU Java (gij), saying the directory does not contain a JRE. The Debian package of libreoffice actually autodetects it and happily uses it, but I have not easily identified the Debian patch that is responsible for this. Good question. *shrug* our /path/to/java-gcj/jre/bin/java is also a symlink to ../../../.../bin/gij and it all works fine under Fedora out-of-the-box. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [REVIEW] Fix KDE3 support (fdo#32797)
On Wed, 2011-01-26 at 16:04 +0100, Thorsten Behrens wrote: Lubos Lunak wrote: Could somebody please ACK these two commits for backport? Thanks. Cherry-picked for -3-3. What linker command line to gcc does this end up giving for the enable kde case ? There was a bug previously where if an x86 Ubuntu developer has a /usr/lib/libstlport_gcc.so and builds the x86 OOo which has its own internal stlport then some KDE linker flags were placed such that OOo incorrectly linked to /usr/lib/libstlport C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build issue with cppu
On Wed, 2011-01-26 at 11:51 +0530, Surendran Mahendran wrote: All these were the changes in the ure folder which had cppu. Reckon any one of this could have fixed my issue ? I wouldn't *think* so, would have to check again without --enable-symbols to see if the failure comes back :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] unit tests and DT_RPATH/DT_RUNPATH ?
So, I added a unit test for fdo#31271 and I see a little wrinkle with out rpath stuff. We set LD_LIBRARY_PATH to something like ../unxlngx.pro/lib:/path/to/solver/lib to try and pick up the just-built library for testing purposes. But when testing a uno component like i18npool.uno.so we dlopen it through some intermediate libraries in /path/to/solver/lib and the LD_LIBRARY_PATH is apparently not checked before the DT_RPATH in that case, the intermediate libs DT_RPATH is used instead so the i18npool.uno.so from /path/to/solver/lib is tested. That's not quite what we want. So, the attached sets DT_RUNPATH which does what we want, i.e. LD_LIBRARY_PATH override the rpath in that case. Anyone see anything that could go wrong with doing this :-) ? C. diff --git a/solenv/inc/unxgcc.mk b/solenv/inc/unxgcc.mk index c090024..1f99cfc 100644 --- a/solenv/inc/unxgcc.mk +++ b/solenv/inc/unxgcc.mk @@ -160,14 +160,14 @@ LINKC*=$(CC) # default linker flags LINKFLAGSDEFS*=-Wl,-z,defs -LINKFLAGSRUNPATH_URELIB=-Wl,-rpath,\''$$ORIGIN'\' -LINKFLAGSRUNPATH_UREBIN=-Wl,-rpath,\''$$ORIGIN/../lib:$$ORIGIN'\' +LINKFLAGSRUNPATH_URELIB=-Wl,-rpath,\''$$ORIGIN'\',--enable-new-dtags +LINKFLAGSRUNPATH_UREBIN=-Wl,-rpath,\''$$ORIGIN/../lib:$$ORIGIN'\',--enable-new-dtags #TODO: drop $ORIGIN once no URE executable is also shipped in OOo -LINKFLAGSRUNPATH_OOO=-Wl,-rpath,\''$$ORIGIN:$$ORIGIN/../ure-link/lib'\' -LINKFLAGSRUNPATH_SDK=-Wl,-rpath,\''$$ORIGIN/../../ure-link/lib'\' -LINKFLAGSRUNPATH_BRAND=-Wl,-rpath,\''$$ORIGIN:$$ORIGIN/../basis-link/program:$$ORIGIN/../basis-link/ure-link/lib'\' +LINKFLAGSRUNPATH_OOO=-Wl,-rpath,\''$$ORIGIN:$$ORIGIN/../ure-link/lib'\',--enable-new-dtags +LINKFLAGSRUNPATH_SDK=-Wl,-rpath,\''$$ORIGIN/../../ure-link/lib'\',--enable-new-dtags +LINKFLAGSRUNPATH_BRAND=-Wl,-rpath,\''$$ORIGIN:$$ORIGIN/../basis-link/program:$$ORIGIN/../basis-link/ure-link/lib'\',--enable-new-dtags LINKFLAGSRUNPATH_OXT= -LINKFLAGSRUNPATH_BOXT=-Wl,-rpath,\''$$ORIGIN/../../../basis-link/program'\' +LINKFLAGSRUNPATH_BOXT=-Wl,-rpath,\''$$ORIGIN/../../../basis-link/program'\',--enable-new-dtags LINKFLAGSRUNPATH_NONE= # flag -Wl,-z,noexecstack sets the NX bit on the stack LINKFLAGS=-Wl,-z,noexecstack -Wl,-z,combreloc $(LINKFLAGSDEFS) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Cpp Cleanliness: check for assignment to self
On Tue, 2011-01-25 at 17:50 +0100, Kenneth Venken wrote: Hi, released under LGPLv3 These all look good. Though would you agree that these are submitted under the LGPLv3+ or MPL combo that we recommend ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=32894 --- Comment #10 from clio fyv...@ya.ru 2011-01-26 09:01:36 PST --- Please, consider bug 32575 (specific LibO bug) and http://qa.openoffice.org/issues/show_bug.cgi?id=108689 (and the bugs referenced there) - the Standard panel in the Basic IDE is broken - buttons Cut, Copy, Undo, Redo, Save not working properly. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Horizontal glyph adjustments are ignored with ICU layout
On Wed, 2011-01-26 at 11:22 +0100, Jan Holesovsky wrote: Anybody here with ideas what we can do so that the patch helps Khaled, and is as safe as possible? - so that we can commit it, and fix the consequences later if anything happens? Where things are most likely to go wrong are with e.g. Indic text. What's ideally needed is some before and after tests with e.g. Hindi, Tamil, text that needs (the infamous) reordering processing. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Langpack installation on Mac, window focus, Issue 33056 and corrected script file
Alexander Thurgood wrote: I found that the error lies in the script not activating the window dialog. I changed the script by adding one word activate in front of the dialog initialisation. This now brings the installation window to the foreground. I enclosed a modified script file with the bug report. Hi Alex, wow, good stuff - approved pushed for -3-3. Obviously, 3.3.0 was too late. ;) Cheers, -- Thorsten pgpd8CVKRBH3e.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=32894 --- Comment #11 from Noel Power nopo...@novell.com 2011-01-26 09:22:30 PST --- (In reply to comment #10) Please, consider bug 32575 (specific LibO bug) and http://qa.openoffice.org/issues/show_bug.cgi?id=108689 (and the bugs referenced there) - the Standard panel in the Basic IDE is broken - buttons Cut, Copy, Undo, Redo, Save not working properly. I don't think something that has probably ( never ) been working at least according to the oracle bug ( since 2.2 ) could ever be considered a blocker? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Base / connectivity / sqlite
On 20/01/11 17:06, Michael Meeks wrote: I've fixed renaming all the functions I could find, but I'm now getting C++ compile errors that are beyond my current C++-fu - I'm a C programmer. .. All help welcomed - please stick sqlite in the subject line of any mails to the list so's I can filter them :-) I'm missing a makefile.mk - did you forget to git add / commit / push that ? And the rest :-) I've messed about (recreated the branch by pulling it anew :-) and it tries to compile okay now. I've fixed a couple of compilation errors in sqlite_connection.cxx by deleting the offending lines (you'll see my comments) but there's some stuff I can't fix. (I wanted to get this done quicker - sorry - but every time it climbed up the todo list, something else pushed it back down :-) Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Cpp Cleanliness: memleaks
Fixes two memleaks.
-- Kenneth
From 4cd88904ea50619dbc0965ea2683ea270a74013b Mon Sep 17 00:00:00 2001
From: Kenneth Venken kenneth.ven...@gmail.com
Date: Wed, 26 Jan 2011 19:39:13 +0100
Subject: [PATCH] cpp cleanliness: fixed some memleaks
---
fpicker/source/unx/kde/kdecommandthread.cxx |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fpicker/source/unx/kde/kdecommandthread.cxx b/fpicker/source/unx/kde/kdecommandthread.cxx
index 499c3ad..1eef244 100644
--- a/fpicker/source/unx/kde/kdecommandthread.cxx
+++ b/fpicker/source/unx/kde/kdecommandthread.cxx
@@ -128,6 +128,7 @@ void KDECommandThread::handleCommand( const QString rString, bool bQuit )
bQuit = true;
kapp-exit();
kapp-wakeUpGuiThread();
+delete pTokens, pTokens = NULL;
}
else
kapp-postEvent( m_pObject, new KDECommandEvent( qCommand, pTokens ) );
--
1.7.1
From 736d39d19d4c0bb6e6f973efdf5d3091e41d3741 Mon Sep 17 00:00:00 2001
From: Kenneth Venken kenneth.ven...@gmail.com
Date: Wed, 26 Jan 2011 20:38:17 +0100
Subject: [PATCH] cpp cleanliness: fixed some memleaks
---
i18npool/source/breakiterator/gendict.cxx | 24
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/i18npool/source/breakiterator/gendict.cxx b/i18npool/source/breakiterator/gendict.cxx
index 31aaeaa..f035da3 100644
--- a/i18npool/source/breakiterator/gendict.cxx
+++ b/i18npool/source/breakiterator/gendict.cxx
@@ -36,6 +36,8 @@
#include sal/types.h
#include rtl/strbuf.hxx
#include rtl/ustring.hxx
+#include vector
+using std::vector;
using namespace ::rtl;
@@ -71,7 +73,8 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv)
fprintf(cfp, extern \C\ {\n);
sal_Int32 count, i, j;
-sal_Int32 lenArrayCurr = 0, lenArrayCount = 0, lenArrayLen = 0, *lenArray = NULL, charArray[0x1];
+sal_Int32 lenArrayCurr = 0, charArray[0x1];
+vectorsal_Int32 lenArray;
sal_Bool exist[0x1];
for (i = 0; i 0x1; i++) {
exist[i] = sal_False;
@@ -97,15 +100,13 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv)
if (*u != current) {
if (*u current)
-printf(u %x, current %x, count %d, lenArrayCount %d\n, *u, current,
-sal::static_int_castint(count), sal::static_int_castint(lenArrayCount));
+printf(u %x, current %x, count %d, lenArray.size() %d\n, *u, current,
+sal::static_int_castint(count), sal::static_int_castint(lenArray.size()));
current = *u;
-charArray[current] = lenArrayCount;
+charArray[current] = lenArray.size();
}
-if (lenArrayLen = lenArrayCount+1)
-lenArray = (sal_Int32*) realloc(lenArray, (lenArrayLen += 1000) * sizeof(sal_Int32));
-lenArray[lenArrayCount++] = lenArrayCurr;
+lenArray.push_back(lenArrayCurr);
exist[u[0]] = sal_True;
for (i = 1; i len; i++) { // start from second character,
@@ -116,15 +117,16 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv)
fprintf(cfp, 0x%04x, , u[i]);
}
}
-lenArray[lenArrayCount++] = lenArrayCurr; // store last ending pointer
-charArray[current+1] = lenArrayCount;
+lenArray.push_back( lenArrayCurr ); // store last ending pointer
+
+charArray[current+1] = lenArray.size();
fprintf(cfp, \n};\n);
// generate lenArray
fprintf(cfp, static const sal_Int32 lenArray[] = {\n\t);
count = 1;
fprintf(cfp, 0x%x, , 0); // insert one slat for skipping 0 in index2 array.
-for (i = 0; i lenArrayCount; i++) {
+for (i = 0; i lenArray.size(); i++) {
fprintf(cfp, 0x%lx, , static_castlong unsigned int(lenArray[i]));
if (count == 0xf) {
count = 0;
@@ -133,8 +135,6 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv)
}
fprintf(cfp, \n};\n);
-free(lenArray);
-
// generate index1 array
fprintf (cfp, static const sal_Int16 index1[] = {\n\t);
sal_Int16 set[0x100];
--
1.7.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Cpp Cleanliness: check for assignment to self
On Wed, 2011-01-26 at 16:57 +, Caolán McNamara wrote: On Tue, 2011-01-25 at 17:50 +0100, Kenneth Venken wrote: Hi, released under LGPLv3 These all look good. Though would you agree that these are submitted under the LGPLv3+ or MPL combo that we recommend ? off-list: yes, i agree. For these and future patches submitted to this list. Great, thanks for these, pushed now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Cpp Cleanliness: redundant assignment to self
On Tue, 2011-01-25 at 18:45 +0100, Kenneth Venken wrote: Hi, these patches solve some of the 'redundant assignment to self' warnings. Looks good. Thanks for these, all pushed. re: 0001-Cpp-cleanliness-redundant-assignment-to-s.components.patch, I suppose we could catch those exceptions by const reference in general, but I generally don't bother myself either. re: 0001-Cpp-cleanliness-redundant-assignment-to-self.ure.patch, FWIW for those parameter used in one ifdef vs another personally I typically stick (void) parameter in the #else branch to silence the compiler and cppcheck and friends. re: 0001-Cpp-cleanliness-redundant-assignment-to-se.libs-core.patch looking at that, the whole nPos thing seems useless as far as I can see and we can remove it completely. Did that additionally as well re: 0001-Cpp-cleanliness-redundant-assignment-to-sel.libs-gui.patch, this is a good one, clear bug since 2001. A very good catch. For it to have remained undiscovered this code must never be called. I'll see if we can remove it entirely. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [Patch] Translation of German comments in sfx2/ (part 2/4)
On Wed, 2011-01-19 at 23:17 +0100, Albert Thuswaldner wrote: Part 2 So, a load of work there, finally went through it and pushed the vast majority of it. Thanks for this :-), now pushed What I left out was... There is one place where we have... nFormat = SotExchange::RegisterFormatName( String::CreateFromAscii( RTL_CONSTASCII_STRINGPARAM( StatusInfo vom SvxInternalLink ))); Off the top of my head I'm not sure it's safe to translate that string to English, it probably is, but there are potential side-effects so I dropped that bit. Otherwise I tweaked one Advise to Advice, and one öike to like, and the odd missing , and dropped the chunks that only changed whitespace. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED, partial] Re: [PATCH] Cpp Cleanliness: memleaks
On Wed, 2011-01-26 at 20:43 +0100, Kenneth Venken wrote: Fixes two memleaks. Pushed the first second one, looks good, thanks for these. Lubos: could you look at the first patch there about pTokens in the kde fpicker. That is a leak right ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] some cppcheck cleaning in basctl
Hello, Here is a patch for some cppcheck cleaning in basctl Compiling was ok My git account is now created but I don't know what to do next to push my commit. If someone could help me, ideally i need a quick tutorial step by step. I do this : ssh serval2...@git.freedesktop.org but I don't know what password to give (mykey-fdo, mykey-fdo.pub, another thing ?) Julien (LGPLv3+ / MPL) __ Do You Yahoo!? En finir avec le spam? Yahoo! Mail vous offre la meilleure protection possible contre les messages non sollicités http://mail.yahoo.fr Yahoo! Mail ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=32894 --- Comment #12 from clio fyv...@ya.ru 2011-01-26 13:47:48 PST --- I just filed the bug 33552 - Standard panel is broken in Basic IDE. IMHO, a fix wouldn't be risky, because the same commands work properly in the menu. Undo/Redo worked fine in 3.1.1, Cut/Copy seem to be older. The Save button not disabled on Windows after first save - not sure how old is this. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [Patch] Translation of German comments in sfx2/ (part 2/4)
On Jan 26, 2011 10:07pm, Caolán McNamara caol...@redhat.com wrote: On Wed, 2011-01-19 at 23:17 +0100, Albert Thuswaldner wrote: Part 2 So, a load of work there, finally went through it and pushed the vast majority of it. Thanks for this :-), now pushed That is great to hear! Just to make sure, what patch did you push? Did you use the two parts which I uploaded in this bugreport. https://bugs.freedesktop.org/show_bug.cgi?id=33424 Sorry for the confusion, I was not sure at first how to go about this so I tried first to upload the patch to the maillinglist. Then given the comments I got there I cleaned up the patch and uploaded it again in the bugreport. /Albert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] some cppcheck cleaning in basctl
On 1/26/11 10:24 PM, Julien Nabet wrote: Hello, Here is a patch for some cppcheck cleaning in basctl Compiling was ok My git account is now created but I don't know what to do next to push my commit. If someone could help me, ideally i need a quick tutorial step by step. I do this : ssh serval2...@git.freedesktop.org but I don't know what password to give (mykey-fdo, mykey-fdo.pub, another thing ?) Julien (LGPLv3+ / MPL) __ Do You Yahoo!? En finir avec le spam? Yahoo! Mail vous offre la meilleure protection possible contre les messages non sollicités http://mail.yahoo.fr Yahoo! Mail ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Most likely the git repos is using ssh keys and those when you generate them you need to provide a password for it. its the password you used for the key. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Crash in master: Sum button in sc
Thanks for the answer. I now used gdb to locate the segfault, and
found it to happen when ScViewFunc called ScRangeList.front() with an
empty range list, which resulted in a segfault while trying to
retrieve the first element of the list. I have prepared the attached
patch, adding a check for empty list in ScViewFunc. (As it here
opposed to ScRangeList, was possible to check that not returning an
element was handled ok.) This removes the crash, and the sum button
seems to work fine again. Although it maybe still would make sense to
check the other uses of ScRangeList.front() for similar problems, I
will try to look into this later on, but this patch shoul at least
make this use safe.
Regards
Sören Möller
(LGPLv3+ / MPL)
2011/1/26 Kohei Yoshida kyosh...@novell.com:
Hi Soeren,
On Tue, 2011-01-25 at 23:13 +0100, Soeren Moeller wrote:
Hi
I just noticed a bug in master (pull about 1h ago):
When I in calc press the sum button (shaped like a sigma), then calc
crashes instantly and without any message. This seems to happen only
when calc doesn't guess a sum area by itself. (E.g. if there are
numbers in the cells above the marked cell, calc suggest those cells
as a sum area, and it works fine, but if there are no cells with
numbers nearby it crashes). Using the sum function through the
Function Wizard works fine, though.
Well, I'm not surprised; after all it's master where things are fairly
unstable, and crashes are common occurrences. :-)
Having said that, it's good to catch these nasty crashes early, and I'm
glad you brought this issue to light.
Are you familiar with getting stack traces with gdb? That would be the
first step when investigating a crash. To get a meaningful stack trace
you need to re-build the sc module with debug symbol compiled in.
http://wiki.documentfoundation.org/Development/Native_Build#Partial_debug_build
Once done, start Calc, attach gdb, reproduce the crash and get a
backtrace in gdb. That will give you the location of the crash from
which you can sniff around the code to see what's going wrong.
I'm just getting used to the codebase, so it would be nice if someone
who is more into it would take a look, and check if the error can be
reproduced by others. I can reproduce it even after a make clean; ./g
pull; make; make dev-install.
Yup, this is perfectly reproducible.
Anyway, it would be great if you could get a backtrace output from gdb
to see where the crash occurs.
Let me know if you need additional help.
Best,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
From cc930a1a9ee473bc6b827f5456bf33126b728cc3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=B6ren=20M=C3=B6ller?= soerenmoeller2...@gmail.com
Date: Wed, 26 Jan 2011 23:48:33 +0100
Subject: [PATCH] Added check for empty rRangeList in ScViewFunc
This fixes a crash, which occured when the sum function was called, without
beeing able to generate an automatic range.
---
sc/source/ui/view/viewfun2.cxx | 24 +---
1 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx
index 99a5c9c..34e7694 100644
--- a/sc/source/ui/view/viewfun2.cxx
+++ b/sc/source/ui/view/viewfun2.cxx
@@ -744,17 +744,19 @@ String ScViewFunc::GetAutoSumFormula( const ScRangeList rRangeList, bool bSubTo
pArray-AddOpCode(ocSep);
}
-ScRangeList aRangeList = rRangeList;
-const ScRange* pFirst = aRangeList.front();
-size_t ListSize = aRangeList.size();
-for ( size_t i = 0; i ListSize; ++i )
-{
-const ScRange* p = aRangeList[i];
-if (p != pFirst)
-pArray-AddOpCode(ocSep);
-ScComplexRefData aRef;
-aRef.InitRangeRel(*p, rAddr);
-pArray-AddDoubleReference(aRef);
+if(!rRangeList.empty()){
+ScRangeList aRangeList = rRangeList;
+const ScRange* pFirst = aRangeList.front();
+size_t ListSize = aRangeList.size();
+for ( size_t i = 0; i ListSize; ++i )
+{
+const ScRange* p = aRangeList[i];
+if (p != pFirst)
+pArray-AddOpCode(ocSep);
+ScComplexRefData aRef;
+aRef.InitRangeRel(*p, rAddr);
+pArray-AddDoubleReference(aRef);
+}
}
pArray-AddOpCode(ocClose);
--
1.7.0.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] Accelerate Perl installer builder
Hi!
I found this on the easy hacks page:
http://wiki.documentfoundation.org/Development/Easy_Hacks
The attached patch makes make_installer.pl save up to 25% time on my
linux machine.
I'm going to do some more patching on make_installer.pl. Is it okay
to post my patches on this mailing list?
From 9aae3df44545965681254655fae5c9c69c4e0b34 Mon Sep 17 00:00:00 2001
From: Jan Darmochwal jdarmoch...@gmx.de
Date: Thu, 27 Jan 2011 00:41:19 +0100
Subject: [PATCH] Accelerate Perl installer builder
speed up collect_directories_from_filesarray
eg use $a .= $b instead of $a = $a . $b
---
solenv/bin/modules/installer/scriptitems.pm | 79 +++
1 files changed, 19 insertions(+), 60 deletions(-)
diff --git a/solenv/bin/modules/installer/scriptitems.pm b/solenv/bin/modules/installer/scriptitems.pm
index 3c436eb..a83e377 100644
--- a/solenv/bin/modules/installer/scriptitems.pm
+++ b/solenv/bin/modules/installer/scriptitems.pm
@@ -2093,17 +2093,13 @@ sub optimize_list
{
my ( $longlist ) = @_;
my %tmpHash;
-my $shortlist = ;
-$longlist =~ s/^\s*|\s*$//g;
+$longlist =~ s/^\s+//;
+$longlist =~ s/\s+$//;
$longlist =~ s/\s*,\s*/,/g;
-foreach ( split /,/, $longlist ) { $tmpHash{$_} = 1; }
-
-foreach (sort keys %tmpHash ) { $shortlist .= $_,; }
-chop( $shortlist );
-
-return $shortlist;
+@tmpHash{split /,/, $longlist} = ();
+return join(,, sort keys %tmpHash);
}
###
@@ -2126,7 +2122,6 @@ sub collect_directories_from_filesarray
my %alldirectoryhash = ();
my $predefinedprogdir_added = 0;
-my $alreadyincluded = 0;
# Preparing this already as hash, although the only needed value at the moment is the HostName
# But also adding: specificlanguage and Dir (for instance gid_Dir_Program)
@@ -2138,62 +2133,26 @@ sub collect_directories_from_filesarray
installer::pathanalyzer::get_path_from_fullqualifiedname(\$destinationpath);
$destinationpath =~ s/\Q$installer::globals::separator\E\s*$//; # removing ending slashes or backslashes
-$alreadyincluded = 0;
-if ( exists($alldirectoryhash{$destinationpath}) ) { $alreadyincluded = 1; }
-
-if (!($alreadyincluded))
+do
{
-my %directoryhash = ();
-$directoryhash{'HostName'} = $destinationpath;
-$directoryhash{'specificlanguage'} = $onefile-{'specificlanguage'};
-$directoryhash{'Dir'} = $onefile-{'Dir'};
-$directoryhash{'modules'} = $onefile-{'modules'}; # NEW, saving modules
+if (!exists($alldirectoryhash{$destinationpath}))
+{
+my %directoryhash = ();
+$directoryhash{'HostName'} = $destinationpath;
+$directoryhash{'specificlanguage'} = $onefile-{'specificlanguage'};
+$directoryhash{'Dir'} = $onefile-{'Dir'};
+$directoryhash{'modules'} = $onefile-{'modules'}; # NEW, saving modules
-if ( $onefile-{'Dir'} eq PREDEFINED_PROGDIR ) { $predefinedprogdir_added = 1; }
-
-$alldirectoryhash{$destinationpath} = \%directoryhash;
-
-# Problem: The $destinationpath can be share/registry/schema/org/openoffice
-# but not all directories contain files and will be added to this list.
-# Therefore the path has to be analyzed.
-
-while ( $destinationpath =~ /(^.*\S)\Q$installer::globals::separator\E(\S.*?)\s*$/ ) # as long as the path contains slashes
-{
-$destinationpath = $1;
-
-$alreadyincluded = 0;
-if ( exists($alldirectoryhash{$destinationpath}) ) { $alreadyincluded = 1; }
-
-if (!($alreadyincluded))
-{
-my %directoryhash = ();
-
-$directoryhash{'HostName'} = $destinationpath;
-$directoryhash{'specificlanguage'} = $onefile-{'specificlanguage'};
-$directoryhash{'Dir'} = $onefile-{'Dir'};
-$directoryhash{'modules'} = $onefile-{'modules'}; # NEW, saving modules
+$predefinedprogdir_added ||= $onefile-{'Dir'} eq PREDEFINED_PROGDIR;
-$alldirectoryhash{$destinationpath} = \%directoryhash;
-}
-else
-{
-# Adding the modules to the module list!
-$alldirectoryhash{$destinationpath}-{'modules'} = $alldirectoryhash{$destinationpath}-{'modules'} . , . $onefile-{'modules'};
-}
+$alldirectoryhash{$destinationpath} = \%directoryhash;
}
-}
-else
-{
-# Adding the modules to the module list!
-$alldirectoryhash{$destinationpath}-{'modules'} = $alldirectoryhash{$destinationpath}-{'modules'} . , .
Re: [Libreoffice] [PUSHED] Crash in master: Sum button in sc
On Wed, 2011-01-26 at 23:59 +0100, Soeren Moeller wrote: Thanks for the answer. I now used gdb to locate the segfault, and found it to happen when ScViewFunc called ScRangeList.front() with an empty range list, which resulted in a segfault while trying to retrieve the first element of the list. I have prepared the attached patch, adding a check for empty list in ScViewFunc. (As it here opposed to ScRangeList, was possible to check that not returning an element was handled ok.) This removes the crash, and the sum button seems to work fine again. Although it maybe still would make sense to check the other uses of ScRangeList.front() for similar problems, I will try to look into this later on, but this patch shoul at least make this use safe. Good work, Soeren! Very impressive. :-) Needless to say that I've pushed your patch. I only changed the bracket style much our coding style, but I've committed the rest as-is. And yes, let's hunt for other similar cases. There may be more. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Libreoffice-build-3.3.0.4 - scp2-user-config-ooo3.diff patch fails
I downloaded the libreoffice-build-3.3.0.4 tarball and attempted to build LO 3.3.0 from source. I passed the following options to the configure script: --with-distro=Slackware and --without-git. The source tarballs downloaded successfully and were unpacked successfully. Some of the patches were applied. However, the build stopped when the scp2-user-config-ooo3.diff patch was being applied. Here is the relevant output from the console: scp2-user-config-ooo3.diff: testing... /home/john/Downloads/tmp/libreoffice-build-3.3.0.4/patches/dev300/./scp2-user-config-ooo3.diff sed 's/^\(@.*\)\r$/\1/' | patch --fuzz=0 -l -p0 -d /home/john/Downloads/tmp/libreoffice-build-3.3.0.4/build/libreoffice-3.3.0.4 --dry-run patching file officecfg/registry/data/org/openoffice/Setup.xcu Hunk #1 FAILED at 788. 1 out of 1 hunk FAILED -- saving rejects to file officecfg/registry/data/org/openoffice/Setup.xcu.rej patching file scp2/source/ooo/common_brand.scp Hunk #1 succeeded at 972 (offset 198 lines). Testing patch scp2-user-config-ooo3.diff failed. at /home/john/Downloads/tmp/libreoffice-build-3.3.0.4/patches/apply.pl line 98. make: *** [stamp/patch.apply] Error 1 Any hints on how to deal with this error? Thanks very much. John Babiak johnb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] compilation fail for branch feature/gnumake2.1
On Tue, Jan 25, 2011 at 3:51 PM, Julien Nabet serval2...@yahoo.fr wrote: Hello, I made a make clean yesterday evening. I git updated even today followed with an autogen.sh and the compilation fails with this : build -- version: 275224 = Building module libwpd = Entering /home/maryline/gnumakelibreoffice/libo/libwpd dmake: Error: -- `./unxlngi6.pro/misc/5ff846847dab351604ad859e2fd4ed3c-libwpd-0.9.1.unpack' not found, and can't be made Forcing regeneration of dependency info nothing to do here... dmake: Error: -- `./unxlngi6.pro/misc/5ff846847dab351604ad859e2fd4ed3c-libwpd-0.9.1.unpack' not found, and can't be made Retrying /home/maryline/gnumakelibreoffice/libo/libwpd dmake: Error: -- `./unxlngi6.pro/misc/5ff846847dab351604ad859e2fd4ed3c-libwpd-0.9.1.unpack' not found, and can't be made --- Oh dear - something failed during the build - sorry ! For more help with debugging build errors, please see the section in: http://wiki.documentfoundation.org/Development it seems that the error is inside 'libwpd', please re-run build inside this module to isolate the error and/or test your fix: Even if i do a : rm -Rf /home/maryline/gnumakelibreoffice/libo/libwpd/unxlngi6.pro then a build, I've got the same thing. sorry for the late reply... I could not reproduce, but the symptom remind me of src/* issue I've encounter before. What happened to me was that my bash environment got messed up and somehow I was picking up the src/* file from somewhere else than need be I also have had issue switch branch where some file that were created on the original branch but did not exist in the branch switched to would cause some trouble. One way to eliminate these cause of trouble: open a brand new terminal, go to you bootstrap repo checkout the branch you need (or at least make sure that 'all' the git repos are on the branch you think they should be (./g branch) ./g reset --hard and ./g clean -f to make sure that there is no ghost then make clean; autogen; make I have built that branch on Linux and MacOS, in both mode. the regular mode yield good functional product on both platform, the gnumake also, except that starmath doesn't launch on Linux. Since then, a few issue with Windows were found, and I have an un-published yet gnumake2.2 branch that contains fix for these and is rebased on a more recent master. We are about to kick start the 3.4 dev cycle, merging a lot of stuff from OOo, including a lot of gnumake2 work that was done there. It is unclear yet if I am going to merge my feature branch or just tweak things after we merge DEV300... In any case, thanks for your help with this. Norbert Julien. (Debian testing updated, gcc (Debian 4.4.5-8) on Intel x86) __ Do You Yahoo!? En finir avec le spam? Yahoo! Mail vous offre la meilleure protection possible contre les messages non sollicités http://mail.yahoo.fr Yahoo! Mail ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] build error on lingucomponent
Hi all, I have an error when build (master repo) on windows. Anyone have any idea how to fix this. lingucomponent deliver Module 'lingucomponent' delivered successfully. 0 files copied, 20 files unchanged Compiling: connectivity/source/drivers/odbcbase/OTools.cxx Compiling: connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx Compiling: connectivity/source/drivers/odbcbase/ODatabaseMetaData.cxx Compiling: connectivity/source/drivers/odbcbase/ODriver.cxx Compiling: connectivity/source/drivers/odbcbase/OConnection.cxx Making:odbcbase.lib Making:module definition file odbcbasemi.def LIB-NT File Dumper v4.00 (C) 2000 Sun Microsystems, Inc. ../../../wntmsci12.pro/misc/odbcbasemi.direct Making:iodbcbase.lib lib -machine:IX86 @C:/cygwin/tmp/mksupsLK Microsoft (R) Library Manager Version 9.00.21022.08 Copyright (C) Microsoft Corporation. All rights reserved. -out:../../../wntmsci12.pro/lib/iodbcbase.lib -def:../../../ wntmsci12.pro/misc/odbcbasemi.def Creating library ../../../wntmsci12.pro/lib/iodbcbase.lib and object ../../../wntmsci12.pro/lib/iodbcbase.exp Making:odbcbasemi.dll Microsoft (R) Windows (R) Resource Compiler Version 6.0.5724.0 Copyright (C) Microsoft Corporation. All rights reserved. Microsoft (R) Incremental Linker Version 9.00.21022.08 Copyright (C) Microsoft Corporation. All rights reserved. /MAP /OPT:NOREF -safeseh -nxcompat -dynamicbase -NODEFAULTLIB -RELEASE -DEBUG -INCREMENTAL:NO /SUBSYSTEM:CONSOLE /DLL -o ut:../../../wntmsci12.pro/bin/odbcbasemi.dll -map:../../../ wntmsci12.pro/misc/odbcbasemi.map -implib:../../../wntmsci12. pro/lib/iodbcbase.lib ../../../wntmsci12.pro/slo/OPreparedStatement.obj../../../ wntmsci12.pro/slo/OStatement.obj ../../ ../wntmsci12.pro/slo/OResultSetMetaData.obj ../../../ wntmsci12.pro/slo/OResultSet.obj ../../../wntmsci12.pro/slo/OTools. obj ../../../wntmsci12.pro/slo/ODatabaseMetaDataResultSet.obj ../../../ wntmsci12.pro/slo/ODatabaseMetaData.obj ../../../ wntmsci12.pro/slo/ODriver.obj ../../../wntmsci12.pro/slo/OConnection.obj../../../ wntmsci12.pro/slo/odbcbase_dflt_versio n.obj idbtools.lib icomphelp.lib icppuhelper.lib icppu.lib isal.lib isalhelper.lib msvcrt.lib uwinapi.lib kernel32.lib user32. lib oldnames.lib stlport_vc71.lib ../../../wntmsci12.pro/misc/odbcbasemi.res LINK : warning LNK4103: import of deleting destructor 'protected: virtual void * __thiscall connectivity::ODatabaseMetaD ataResultSet::`vector deleting destructor'(unsigned int)'; image may not run correctly LINK : warning LNK4103: import of deleting destructor 'public: virtual void * __thiscall connectivity::OResultSetPrivile ges::`vector deleting destructor'(unsigned int)'; image may not run correctly LINK : warning LNK4103: import of deleting destructor 'public: virtual void * __thiscall connectivity::ORowSetValueDecor ator::`vector deleting destructor'(unsigned int)'; image may not run correctly Creating library ../../../wntmsci12.pro/lib/iodbcbase.lib and object ../../../wntmsci12.pro/lib/iodbcbase.exp linking ../../../wntmsci12.pro/bin/odbcbasemi.dll.manifest ... Making:all_odbcbase.dpslo -- _/|\_ Tantai Thanakanok. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch][Pushed] Accelerate Perl installer builder
On Wed, Jan 26, 2011 at 7:21 PM, Jan Darmochwal jdarmoch...@gmx.de wrote: Hi! I found this on the easy hacks page: http://wiki.documentfoundation.org/Development/Easy_Hacks The attached patch makes make_installer.pl save up to 25% time on my linux machine. Whoa, that is impressive. How did you measure it ? Looks good to me, I think the second chunk change slightly the logic, (there is a 'shortcut while loop that is not shortcut-ted anymore, but I think the result is the same... although a second pair of eyes is welcomed) Still, Pushed. I'm going to do some more patching on make_installer.pl. Is it okay to post my patches on this mailing list? Sure, keep them coming :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
