[Libreoffice] LibO-3.4.0_beta1_win_w86: GUI
PNG-images are not displayed in the GUI OS Windows_XP_ (Pro_sp3_ru; x64_sp2_enu + mui_ru). Program forgotten how to work with ZIP-archives? Look here - http://forumooo.ru/index.php/topic,75.msg11210.html#msg11210: -- View this message in context: http://nabble.documentfoundation.org/LibO-3-4-0-beta1-win-w86-GUI-tp2819346p2819346.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Excel 2003 XML format
Hi Cedric, thanks a lot for the intro. Am 13.04.2011 um 09:52 schrieb Cedric Bosdonnat cbosdon...@novell.com: Then the code for the filter is sitting in two places: * import is in the writerfilter module * export sits in sw/source/filter/ww8 Ok. There are quite some bugs on that and they aren't necessarily easy to handle. A nice start would be to fix some of the differences between OOXML ISO standard and OOXML Ecma v1 standard: those differences often include easy to hack things. Ok, thanks. If you have questions, feel free to ping me on IRC; my nick is cbosdonnat. Ok, I'll try that. What times are best in general to get you on irc? Regards, -- Cedric Bosdonnat Thanks and regards, Peter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] When can we import xml data
Hi Fernand, Am 13.04.2011 17:23, schrieb Fernand Vanrie: Peter , Do you mean that your extension only can been used to export' some date from a spreadsheet ? (what i found after installing ) If it also can been used to import , please give us some more info if you don't need an extension, you can use the mechanism of a packaging the filter into an jar-File (Tools / XSLT Filter Settings / Save/Load as package) Peter Thanks anyhow Fernand Hi, Am 13.04.2011 10:15, schrieb Thorsten Behrens: Fernand Vanrie wrote: For some years there was a Java made extension StarXpert_XML2Calc (with limitations) to Import XML data into Calc. Sinds 3.3 this extention is broken and the French makers seems no longer interested in this project. So please who can made this basic XML import happen. Hi Fernand, um, best file a (preferrably detailed) bug report - with pointers to the source code, what is broken exactly - or maybe you could have a look into this yourself? XML Import should be done with a xslt-Filter, which can be deployed as extension, but this behavior seems to be buggy (http://openoffice.org/bugzilla/show_bug.cgi?id=117317) (sorry Thorsten for the first mail) Regards Peter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Nightly Build on Mac from 20110414 - application launch failure and crash rep
Hi all, For those who may be interested, I am enclosing an Apple crash rep of the attempted launch of the nightly Mac build from master dated 20110414. Alex Process: soffice [1836] Path:/Applications/LibreOffice.app/Contents/MacOS/soffice Identifier: org.libreoffice.script Version: 3.4.0 (???) Code Type: X86 (Native) Parent Process: launchd [270] Date/Time: 2011-04-14 09:37:48.347 +0200 OS Version: Mac OS X 10.6.7 (10J869) Report Version: 6 Interval Since Last Report: 300594 sec Crashes Since Last Report: 233 Per-App Interval Since Last Report: 21 sec Per-App Crashes Since Last Report: 1 Anonymous UUID: 08D0F8A4-52F3-4773-9B37-FEBF28327F33 Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x0005 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 libvclmxi.dylib 0x017ce616 ImplFontCharMap::DeReference() const + 54 1 libvclmxi.dylib 0x017ceb54 FontCharMap::~FontCharMap() + 20 2 libvclmxi.dylib 0x017ed8ee OutputDevice::HasGlyphs(Font const, String const, unsigned short, unsigned short) const + 190 3 libvclmxi.dylib 0x0197ff99 Window::IsMouseCaptured() const + 729 4 libvclmxi.dylib 0x01991327 Window::doLazyDelete() + 4023 5 libvclmxi.dylib 0x0175edf7 Application::MergeSystemSettings(AllSettings) + 71 6 libsvtmxi.dylib 0x00a5166c SvtTabAppearanceCfg::SetApplicationDefaults(Application*) + 412 7 libsofficeapp.dylib 0x0006a0c6 0x58000 + 73926 8 libvclmxi.dylib 0x01766b18 DeInitVCL() + 3624 9 libvclmxi.dylib 0x01a6a26b component_getFactory + 209515 10 libvclmxi.dylib 0x01a6f69b SalGetDesktopEnvironment() + 20891 11 com.apple.AppKit0x98ee92a7 -[NSApplication run] + 917 12 com.apple.AppKit0x98ee12d9 NSApplicationMain + 574 13 libvclmxi.dylib 0x01a6aff7 SalGetDesktopEnvironment() + 2807 14 libvclmxi.dylib 0x01766bc1 SVMain() + 17 15 libsofficeapp.dylib 0x00096d95 soffice_main + 245 16 org.libreoffice.script 0x1ebe main + 30 17 org.libreoffice.script 0x1822 start + 258 18 org.libreoffice.script 0x1749 start + 41 Thread 1: 0 libSystem.B.dylib 0x912990fa semaphore_timedwait_signal_trap + 10 1 libSystem.B.dylib 0x912c6c85 _pthread_cond_wait + 1066 2 libSystem.B.dylib 0x9130f66c pthread_cond_timedwait + 47 3 libuno_sal.dylib.3 0x00035e18 rtl_cache_create + 728 4 libSystem.B.dylib 0x912c67fd _pthread_start + 345 5 libSystem.B.dylib 0x912c6682 thread_start + 34 Thread 2: Dispatch queue: com.apple.libdispatch-manager 0 libSystem.B.dylib 0x912bf922 kevent + 10 1 libSystem.B.dylib 0x912c003c _dispatch_mgr_invoke + 215 2 libSystem.B.dylib 0x912bf4f9 _dispatch_queue_invoke + 163 3 libSystem.B.dylib 0x912bf29e _dispatch_worker_thread2 + 240 4 libSystem.B.dylib 0x912bed21 _pthread_wqthread + 390 5 libSystem.B.dylib 0x912beb66 start_wqthread + 30 Thread 3: 0 libSystem.B.dylib 0x9136041e accept$NOCANCEL$UNIX2003 + 10 1 libSystem.B.dylib 0x9135f286 accept + 32 2 libuno_sal.dylib.3 0x00011d5a osl_acceptPipe + 58 3 libsofficeapp.dylib 0x00092b5e 0x58000 + 240478 4 libsofficeapp.dylib 0x00095ad2 0x58000 + 252626 5 libuno_sal.dylib.3 0xc1b9 osl_setThreadName + 569 6 libSystem.B.dylib 0x912c67fd _pthread_start + 345 7 libSystem.B.dylib 0x912c6682 thread_start + 34 Thread 4: 0 libSystem.B.dylib 0x912be9b2 __workq_kernreturn + 10 1 libSystem.B.dylib 0x912bef48 _pthread_wqthread + 941 2 libSystem.B.dylib 0x912beb66 start_wqthread + 30 Thread 0 crashed with X86 Thread State (32-bit): eax: 0x0001 ebx: 0x0197fe40 ecx: 0x005a edx: 0x17fb0d60 edi: 0x0033 esi: 0xb178 ebp: 0xb108 esp: 0xb108 ss: 0x0023 efl: 0x00010206 eip: 0x017ce616 cs: 0x001b ds: 0x0023 es: 0x0023 fs: 0x gs: 0x000f cr2: 0x0005 Binary Images: 0x1000 - 0x1ff7 +org.libreoffice.script 3.4.0 (???) 8D38ED52-0788-1BB7-5A00-5E884D2870F1 /Applications/LibreOffice.app/Contents/MacOS/soffice 0x5000 -0x45ffb +libuno_sal.dylib.3 ??? (???) BDC9B0E7-DC22-DA36-DACF-993EDD41CD2E /Applications/LibreOffice.app/Contents/basis-link/ure
Re: [Libreoffice] CTL settings for Hebrew (ctl_he.xcd)
On Wed, Apr 13, 2011 at 2:21 PM, Caolán McNamara caol...@redhat.com wrote: On Wed, 2011-04-13 at 14:07 +0300, Lior Kaplan wrote: I'm not sure how to change the the CTLSequenceChecking only for Hebrew (see http://openoffice.org/bugzilla/show_bug.cgi?id=61863). Any help appreciated. IMO that CTLSequenceChecking should only be turned on for e.g. Thai, and not generically on for all CTL languages. You can find it at http://opengrok.libreoffice.org/xref/libs-core/officecfg/registry/data/org/openoffice/Office/Common.xcu We should turn of *off* by default, and change install:module=ctl to install:module=thai and have a little thai-specific one to turn it *on* for that case. See the korea one for an example. Following your hint, here's the patch to fix #i61863. It disables squence checking for CTL languages and enables it for Thai. --- a/officecfg/registry/data/org/openoffice/Office/Common.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu @@ -173,6 +173,17 @@ value true/value /prop prop oor:name=CTLSequenceChecking +value false/value + /prop + prop oor:name=CTLSequenceCheckingRestricted +value false/value + /prop + prop oor:name=CTLSequenceCheckingTypeAndReplace +value false/value + /prop +/node +node oor:name=CTL install:module=thai + prop oor:name=CTLSequenceChecking value true/value /prop prop oor:name=CTLSequenceCheckingRestricted ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] update service
Just to let you know, I've updated the wiki page to link to this mail thread. It would be cool to add any other informations about this feature. Michaël -- View this message in context: http://nabble.documentfoundation.org/update-service-tp2479818p2819485.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] update service
I've found this library for Windows http://winsparkle.org/ . I think It could easier to implement this feature with. Good. Are you volunteering to experiment with that and testing how it could be used then? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Cross-references to numbered paragraphs: remove trailing dots at the end of a cross-reference, or where they precede an open parenthesis that starts the next paragraph level in t
---
sw/source/core/doc/number.cxx | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index 95ea5c8..d7df858 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -770,7 +770,15 @@ String SwNumRule::MakeRefNumString( const SwNodeNum
rNodeNum,
pWorkingNodeNum-GetTxtNode()
pWorkingNodeNum-GetTxtNode()-HasNumber() ) )
{
-aRefNumStr.Insert( MakeNumString(
pWorkingNodeNum-GetNumberVector() ), 0 );
+String aPrevStr = MakeNumString(
pWorkingNodeNum-GetNumberVector() );
+intnLen = aPrevStr.Len();
+
+if ( nLen 0 aPrevStr.GetChar(nLen - 1) == '.'
+ ( aRefNumStr.Len() == 0 ||
+ aRefNumStr.GetChar(0) == '(' )
+ )
+aPrevStr.Erase( nLen - 1, 1 );
+aRefNumStr.Insert( aPrevStr, 0 );
}
else if ( aRefNumStr.Len() 0 )
{
--
1.7.2.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||35017 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||33915 --- Comment #20 from Petr Mladek pmla...@suse.cz 2011-04-14 01:57:44 PDT --- Add bug 33915: user settings get lost after several restarts; It is quite annoying. Unfortunately, it is hard to fix because we still do not have a reasonable way to reproduce it. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] remove dead code and uncompiled code in 'sd' module
cocofan wrote: Attached is a patch for the Easy Hack removing commented out code (dead or uncompiled code). Hi cocofan, cool, many thanks for that cleanup - pushed with a few tweaks: * stuff commented out with a todo-mark - paraphrased intent into one-liner todo statement, we usually want to keep those reminders * references to bug ids (#i35937 mostly) - we also usually want to keep those ids around, of course without loads of disabled code alongside * whitespace-only changes - elided them, as they make merging unnecessarily painful **Note to Thorsten: In the next few days I'm going email a partially-working patch of the old Autolayout code from 2009. It's going to take some doing as the old patch doesn't apply at all to the new build (the directories are different) and I'm manually separating out the code and adding it gradually (there's quite a bit of rewriting to do). Should I send this to you directly instead of the mailing list as its not something that will be added to the main repository right now? Wow, looking forward to that - please mail to this list, we love sharing and public discussions. :) Cheers, -- Thorsten pgpaiN8o8z6fa.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Libo 3.4 - writer insert fields other : 2 bugs
Hi Kendy, Le 14/04/11 07:30, Jan Holesovsky a écrit : Hi Robert, On 2011-04-11 at 01:49 +0200, Robert Dargaud wrote: 3.4 on Ubuntu 10.4 Win7 Writer insert fieds other first bug : Condition = sat_True instead of True Monday, I've started to have a look on this bug. The result of my investigation seems show that this user interface problem appears not only in this dialog box but also in svl module. I base this constat on this search result : http://opengrok.libreoffice.org/search?q=RTL_CONSTASCII_STRINGPARAM%5C%28%5C+%5C%22sal_True%5C%22%5C+%5C%29+OR+RTL_CONSTASCII_STRINGPARAM%5C%28%5C+%5C%22sal_False%5C%22%5C+%5C%29project=artworkproject=baseproject=bootstrapproject=calcproject=componentsproject=extensionsproject=extrasproject=filtersproject=impressproject=libs-cor eproject=libs-externproject=libs-extern-sysproject=libs-guiproject=postprocessproject=sdkproject=ureproject=writerdefs=refs=path=hist= sw and svl are impacted by this problem. I've not investigate more. Maybe that my research is incomplete ... Oh, thanks for noticing! I think http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4id=6ccd6981635845e9fd9ba2aef2a3ce3e46171f9b Should fix that :-) I am just about to check for more of these. Yes, I think also that your patch fix this bug. But, I've notice that 'TRUE' 'FALSE' are not in tune with help document. In help, TRUE and FALSE are localized : (see below an extract of french help screen) La méthode la plus simple pour définir une condition consiste à saisir l'expression logique directement dans une zone *Condition* à l'aide des valeurs suivantes : VRAI La condition est toujours remplie. Il est également possible d'entrer une valeur quelconque différente de zéro comme texte conditionnel. FAUX La condition n'est pas remplie. À la place, vous pouvez aussi spécifier la valeur 0. I dont know if it is easy to use localized constant strings to display 'VRAI' 'FAUX' (for ex in french) in user interface. second bug : 1) Clic on Condition 2) Clic on Record number result : 2 text cursors in the same time ! (see picture below) I did not look at this one. You mean that you have not see this problem ? It's strange. On my computer I've this bug on all dialog boxes having more than one text field. The same bug on 2 plateforms : - my buid from master (Ubuntu 10.10) - nightly builds http://dev-builds.libreoffice.org/daily/Windows_Relese_Configuration/libreoffice-3-4/current/libreoffice-3-4~20110413_LibO_3.4.0beta1_Win_x86_install_multi.exe on the same computer (core i5) I can't try on Mac because 3.4 installation fail I wait somebody confirm before register this bug on bugs.freedesktop.org Regard Bob ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Nightly Build on Mac from 20110414 - application launch failure and crash rep
Hi Alex All, I've the same problem with 2 times with different nightly builds (last report in attachment) Regard Bob Le 14/04/11 09:54, Alexander Thurgood a écrit : Hi all, For those who may be interested, I am enclosing an Apple crash rep of the attempted launch of the nightly Mac build from master dated 20110414. Alex __ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Process: soffice [2381] Path:/Applications/LibreOffice.app/Contents/MacOS/soffice Identifier: org.libreoffice.script Version: 3.4.0 (???) Code Type: X86 (Native) Parent Process: launchd [255] Date/Time: 2011-04-14 09:42:06.145 +0200 OS Version: Mac OS X 10.6.6 (10J567) Report Version: 6 Interval Since Last Report: 115918 sec Crashes Since Last Report: 5 Per-App Interval Since Last Report: 38 sec Per-App Crashes Since Last Report: 3 Anonymous UUID: 962B3BFC-A0D2-4DAA-9196-E0B4A636E7E7 Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x0005 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 libvclmxi.dylib 0x017d6606 ImplFontCharMap::DeReference() const + 54 1 libvclmxi.dylib 0x017d6b44 FontCharMap::~FontCharMap() + 20 2 libvclmxi.dylib 0x017f58de OutputDevice::HasGlyphs(Font const, String const, unsigned short, unsigned short) const + 190 3 libvclmxi.dylib 0x01987f89 Window::IsMouseCaptured() const + 729 4 libvclmxi.dylib 0x01999317 Window::doLazyDelete() + 4023 5 libvclmxi.dylib 0x01766de7 Application::MergeSystemSettings(AllSettings) + 71 6 libsvtmxi.dylib 0x00a564ac SvtTabAppearanceCfg::SetApplicationDefaults(Application*) + 412 7 libsofficeapp.dylib 0x0006aff6 0x59000 + 73718 8 libvclmxi.dylib 0x0176eb08 DeInitVCL() + 3624 9 libvclmxi.dylib 0x01a7225b component_getFactory + 209515 10 libvclmxi.dylib 0x01a7768b SalGetDesktopEnvironment() + 20891 11 com.apple.AppKit0x9702d2a7 -[NSApplication run] + 917 12 com.apple.AppKit0x970252d9 NSApplicationMain + 574 13 libvclmxi.dylib 0x01a72fe7 SalGetDesktopEnvironment() + 2807 14 libvclmxi.dylib 0x0176ebb1 SVMain() + 17 15 libsofficeapp.dylib 0x00097d65 soffice_main + 245 16 org.libreoffice.script 0x1ebe main + 30 17 org.libreoffice.script 0x1822 start + 258 18 org.libreoffice.script 0x1749 start + 41 Thread 1: 0 libSystem.B.dylib 0x9000415a semaphore_timedwait_signal_trap + 10 1 libSystem.B.dylib 0x90031ce5 _pthread_cond_wait + 1066 2 libSystem.B.dylib 0x9007a67c pthread_cond_timedwait + 47 3 libuno_sal.dylib.3 0x000367c8 rtl_cache_create + 696 4 libSystem.B.dylib 0x9003185d _pthread_start + 345 5 libSystem.B.dylib 0x900316e2 thread_start + 34 Thread 2: Dispatch queue: com.apple.libdispatch-manager 0 libSystem.B.dylib 0x9002a982 kevent + 10 1 libSystem.B.dylib 0x9002b09c _dispatch_mgr_invoke + 215 2 libSystem.B.dylib 0x9002a559 _dispatch_queue_invoke + 163 3 libSystem.B.dylib 0x9002a2fe _dispatch_worker_thread2 + 240 4 libSystem.B.dylib 0x90029d81 _pthread_wqthread + 390 5 libSystem.B.dylib 0x90029bc6 start_wqthread + 30 Thread 3: 0 libSystem.B.dylib 0x90029a12 __workq_kernreturn + 10 1 libSystem.B.dylib 0x90029fa8 _pthread_wqthread + 941 2 libSystem.B.dylib 0x90029bc6 start_wqthread + 30 Thread 4: 0 libSystem.B.dylib 0x900cb422 accept$NOCANCEL$UNIX2003 + 10 1 libSystem.B.dylib 0x900ca28a accept + 32 2 libuno_sal.dylib.3 0x0001275a osl_acceptPipe + 58 3 libsofficeapp.dylib 0x00093afe 0x59000 + 240382 4 libsofficeapp.dylib 0x00096a72 0x59000 + 252530 5 libuno_sal.dylib.3 0xcbb9 osl_setThreadName + 569 6 libSystem.B.dylib 0x9003185d _pthread_start + 345 7 libSystem.B.dylib 0x900316e2 thread_start + 34 Thread 0 crashed with X86 Thread State (32-bit): eax: 0x0001 ebx: 0x01987e30 ecx: 0x0070 edx: 0x16c90f70 edi: 0x0033 esi: 0xb2f8 ebp: 0xb288 esp: 0xb288 ss: 0x001f efl: 0x00010202 eip: 0x017d6606 cs: 0x0017 ds: 0x001f es: 0x001f fs: 0x gs
Re: [Libreoffice] Libreoffice QA process outline - a coarse draft.
Yifan Jiang píše v St 13. 04. 2011 v 17:29 +0800: Collect the results on the wiki may be more easier for every body to participate. It might be enough to show them in Litmus if they are well visible there. It looks a report page for a specific run can be generated as: https://tcm.documentfoundation.org/test_run_report.cgi?test_run_id=3 Clicking the last column with non-zero inside would show the detailed result. Is it good enough for sharing info between QA team and release team? The page looks fine. Well, there might be some problems: + the sample test cases are described in German; some people need not understand what the failed tests were about; it might get even more complicated i there are tests for other localizations + I am not sure how to distinguish how serious an error is; if it is a known bug or a regression in a core functionality + I am not sure how many test cases and test runs we would have. If we have too many, it might be quite complicated to do the Go/No-go decision by analyzing all the pages/numbers. In this case, we need to find a better way how QA people would inform about blockers, most annoying bugs. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Nightly Build on Mac from 20110414 - application launch failure and crash rep
Le 14/04/11 11:56, Robert Dargaud a écrit : Hi Robert, I've the same problem with 2 times with different nightly builds (last report in attachment) I had the same thing too with my own build of LO from master dating back to around the same time. Since then, judging by the logs, none of the nightly builds for Mac have been successful. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Excel 2003 XML format
Hi Petr, On Thu, 2011-04-14 at 09:30 +0200, Peter Jentsch wrote: Ok, I'll try that. What times are best in general to get you on irc? As I'm located in France and seldomly hacking at night, the usual office hours for europe are OK. After it's quite unreliable ;) Regards, -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCHES] Fixed some CLang++ errors/warnings in sal
Julien Chaffraix wrote: Subject: [PATCH 1/5] Added error handling for pthread_mutexattr_settype. Handled slightly different, to avoid duplication retain the pthread_mutexattr_destroy call. Subject: [PATCH 2/5] Added handling for the write errors in receiveFdPipe. Applied - would you want to look into the TODO case as well? A rather nasty cause for errors ... Subject: [PATCH 3/5] Fixed a potential null-dereferencing error in osl_closeProfile Subject: [PATCH 4/5] Fixed some false positives 'dead assignments' seen in CLang++ Subject: [PATCH 5/5] No need to check out execv return value. Applied - the extra ifs in 4/5 are a lesser evil than those warns, I agree. Many thanks for your fixes - pushed to the -3-4 branch, you're fixing real bugs here. Cheers, -- Thorsten pgpwSzQuj0dnS.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Kill Pos_XXX in favour of osl_Pos_XXX
All 'Kill Pos_XXX in favour of osl_Pos_XXX' pushed - many thanks again for your cleanup work! Please, could you confirm that all your submissions are under LGPLv3+ / MPL license? Cheers, -- Thorsten pgpjpvBohVuOR.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] sal_{Bool, True, False} to bool, true, false.
Kayo Hamid wrote:
Hello, I asked at #libreoffice-dev if we have to see some special
condition to change sal_Bool to bool and so on, unanswered.
@@ -69,10 +69,10 @@ using namespace ::com::sun::star;
struct ImplColorListData
{
Color aColor;
-sal_BoolbColor;
+boolbColor;
-ImplColorListData() : aColor( COL_BLACK ) { bColor =
sal_False; }
-ImplColorListData( const Color rColor ) : aColor( rColor )
{ bColor = sal_True; }
+ImplColorListData() : aColor( COL_BLACK ) { bColor = false; }
+ImplColorListData( const Color rColor ) : aColor( rColor )
{ bColor = true; }
};
Hi Kayo,
the above change is clearly useful - an internal bool, not
used/exposed elsewhere.
-EnableUserDraw( sal_True );
+EnableUserDraw( true );
etc. - not sure if we really want to manually hunt all those down -
I suggest to go for one of the other easy hacks (this one is not
listed there FWICT), until we have a clear plan here.
Cheers,
-- Thorsten
pgpn8kbjO8APL.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Kill Pos_XXX in favour of osl_Pos_XXX
Dammit, I forget about license one more time ;) Submit under LGPLv3+ / MPL license ! Forgive me for the 9 patches to push. I've just commited on local repository #define by #define. That gave me 3 patches for a single file. I definitively have to learn more about git usage. On Thu, Apr 14, 2011 at 12:52 PM, Thorsten Behrens t...@documentfoundation.org wrote: All 'Kill Pos_XXX in favour of osl_Pos_XXX' pushed - many thanks again for your cleanup work! Please, could you confirm that all your submissions are under LGPLv3+ / MPL license? Cheers, -- Thorsten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Remove CVER
On Tue, Apr 12, 2011 at 11:26:13AM +0200, Francois Tigeot wrote: On Wed, Apr 06, 2011 at 10:31:09PM +0200, Francois Tigeot wrote: CVER is defined in set_solenv.in and propagated in form of defines to the entire source tree. The attached patch removes it from the build infrastructure. Patch pushed today. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Cross-references to numbered paragraphs: remove trailing dots at the end of a cross-reference, or where they precede an open parenthesis that starts the next paragraph level
Hi Troy,
Many thanks for your nice patch: you found out the right place to hack!
However I have some concerns here...
On Thu, 2011-04-14 at 18:04 +1000, Troy Rollo wrote:
+if ( nLen 0 aPrevStr.GetChar(nLen - 1) == '.'
This is quite restrictive as it only clears the ending '.' I think that
the same should apply whatever the suffix is.. Would one want to have
[1-] as the reference?
You could either hack the MakeNumString itself or get inspired of it to
get the suffix to remove.
+ ( aRefNumStr.Len() == 0 ||
+ aRefNumStr.GetChar(0) == '(' )
Why that test for strings starting with '(' ?
Don't hesitate to ask for help if you need some to improve the patch and
keep doing nice work like this one.
Regards,
--
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Easy Hack completed - All bogus comments removed
Hi friends,
This patch removes all bogus comments laying around. If you are searching
for one of the following, you could stop. ;-)
/* -04.12.00 16:26
and
#include svx/svxdlg.hxx //CHINA001
and
// -- OD 2008-01-08 #newlistlevelattrs#
I did it using regex, so one or another replacement discards a piece of
comment when it is in a block, for example:
// -- OD 2008-01-08 #i1234# first line comment
// continuing in the second line
// ...
The regex will remove first line comment in that case, but will keep the
Bug ID as Thorsten requested me in another email.
Could i mark this Easy Hack as completed in the Wiki?
Regards,
Júlio.
From 58c58d23c3f5f089b8d640c6791bf713ecb24e2e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=BAlio=20Hoffimann?= julio.hoffim...@gmail.com
Date: Thu, 14 Apr 2011 08:09:11 -0300
Subject: [PATCH] all bogus comments removed by regular expressions
---
framework/source/layoutmanager/helpers.cxx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/framework/source/layoutmanager/helpers.cxx b/framework/source/layoutmanager/helpers.cxx
index 652cf15..aeab496 100644
--- a/framework/source/layoutmanager/helpers.cxx
+++ b/framework/source/layoutmanager/helpers.cxx
@@ -339,7 +339,7 @@ sal_Bool implts_isFrameOrWindowTop( const uno::Reference frame::XFrame xFram
uno::Reference awt::XTopWindow xWindowCheck(xFrame-getContainerWindow(), uno::UNO_QUERY); // dont use _THROW here ... its a check only
if (xWindowCheck.is())
{
-// -- PB 2007-06-18 #i76867# top and system window is required.
+// #i76867#
SolarMutexGuard aGuard;
uno::Reference awt::XWindow xWindow( xWindowCheck, uno::UNO_QUERY );
Window* pWindow = VCLUnoHelper::GetWindow( xWindow );
--
1.7.0.4
From 5c755c4bc25cd8c0d703124de4bf85a2003dca89 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=BAlio=20Hoffimann?= julio.hoffim...@gmail.com
Date: Thu, 14 Apr 2011 08:12:27 -0300
Subject: [PATCH] all bogus comments removed by regular expressions
---
comphelper/source/misc/accessiblewrapper.cxx |2 +-
svtools/source/control/ruler.cxx |2 +-
toolkit/source/helper/unowrapper.cxx |2 +-
vcl/inc/vcl/ptrstyle.hxx |4 ++--
vcl/inc/vcl/vclevent.hxx |2 +-
vcl/os2/source/window/salframe.cxx |4 ++--
vcl/unx/gtk/a11y/atklistener.cxx |2 +-
vcl/unx/gtk/a11y/atktextattributes.cxx |2 +-
vcl/unx/gtk/app/gtkdata.cxx |4 ++--
vcl/win/source/gdi/winlayout.cxx |4 ++--
vcl/win/source/window/salframe.cxx |4 ++--
11 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/comphelper/source/misc/accessiblewrapper.cxx b/comphelper/source/misc/accessiblewrapper.cxx
index 60103cc..8b072d8 100644
--- a/comphelper/source/misc/accessiblewrapper.cxx
+++ b/comphelper/source/misc/accessiblewrapper.cxx
@@ -241,7 +241,7 @@ namespace comphelper
case AccessibleEventId::TABLE_ROW_DESCRIPTION_CHANGED:
case AccessibleEventId::TABLE_ROW_HEADER_CHANGED:
case AccessibleEventId::TABLE_SUMMARY_CHANGED:
-// -- PB 2006-03-21 #130798# EventId TEXT_SELECTION_CHANGED was missed
+// #130798#
// these Ids are also missed: SUB_WINDOW_OF_RELATION_CHANGED TEXT_ATTRIBUTE_CHANGED
case AccessibleEventId::TEXT_SELECTION_CHANGED:
// --
diff --git a/svtools/source/control/ruler.cxx b/svtools/source/control/ruler.cxx
index a93207d..2202d3e 100644
--- a/svtools/source/control/ruler.cxx
+++ b/svtools/source/control/ruler.cxx
@@ -1679,7 +1679,7 @@ sal_Bool Ruler::ImplHitTest( const Point rPos, ImplRulerHitTest* pHitTest,
}
nHitBottom = mnVirHeight+(RULER_OFF*2);
-// -- FME 2004-08-05 #i32608#
+// #i32608#
pHitTest-nAryPos = 0;
pHitTest-mnDragSize = 0;
pHitTest-bSize = sal_False;
diff --git a/toolkit/source/helper/unowrapper.cxx b/toolkit/source/helper/unowrapper.cxx
index 54269ce..50b90b3 100644
--- a/toolkit/source/helper/unowrapper.cxx
+++ b/toolkit/source/helper/unowrapper.cxx
@@ -64,7 +64,7 @@ using namespace ::com::sun::star;
case WINDOW_OKBUTTON:
case WINDOW_CANCELBUTTON: return new VCLXButton;
case WINDOW_CHECKBOX: return new VCLXCheckBox;
-// -- OD 2009-06-29 #i95042#
+// #i95042#
// A Window of type MetricBox is inherited from type ComboBox.
// Thus, it does make more sense to return a VCLXComboBox instance
// instead of only a VCLXWindow instance, especially regarding its
diff --git a/vcl/inc/vcl/ptrstyle.hxx b/vcl/inc/vcl/ptrstyle.hxx
index 680c6b7..a1cf690 100644
--- a/vcl/inc/vcl/ptrstyle.hxx
+++ b/vcl/inc/vcl/ptrstyle.hxx
@@ -126,7 +126,7 @@ typedef sal_uInt16 PointerStyle;
#define POINTER_TEXT_VERTICAL ((PointerStyle)86)
#define POINTER_PIVOT_DELETE ((PointerStyle)87)
Re: [Libreoffice] Easy Hack completed - All bogus comments removed
... and the last and big one. ;-) https://bugs.freedesktop.org/show_bug.cgi?id=36234 https://bugs.freedesktop.org/show_bug.cgi?id=36234Regards, Júlio. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] complete
Maybe this task should be moved to “completed”?
http://wiki.documentfoundation.org/Easy_Hacks#Make_python_.2F_mail-merge_debuggable
Am Montag, den 11.04.2011, 21:26 +0200 schrieb Timo:
Hi Michael,
MessageBoxButtons as well as XSCRIPTCONTEXT do not exist for me. Python
doesn´t find them and they are documented as “not published” [1]. I
think it would be nice to use createMessageBox() and to have a dynamic
size and a nice error icon. But with the use of Laurent´s implementation
I could solve the task. [2]
With the modified mailmerge.py I get the expected pythonerror in a
messagebox after closing the MsgBox. [3] In fact all pythonerrors are
reported like this on my computer. What does it look like on nonfree
platforms? In fact it is better to display only one error message.
Not all python errors are reported in a message by default. If there are
syntax errors at the beginning of the file, office remains silent. This
is problem.
When there is a MsgBox that works for everybody I suggest to implement
it into pythonscript.py so that it is being used for all exceptions.
regards,
Timo
[1]
http://api.openoffice.org/docs/common/ref/com/sun/star/awt/MessageBoxButtons.html#BUTTONS_OK
[2] see mailmerge.py and MsgBox.py from the attachments
[3] see screenshot Bildschirmfoto.png
Am Montag, den 11.04.2011, 17:01 +0100 schrieb Michael Meeks:
Hi Timo,
On Sat, 2011-04-09 at 02:22 +0200, Timo wrote:
Is there a way to test the pythonfile within office? At the moment each
time i kill soffice, restart writer and click
So - after a bit more digging; I got to here:
class MessageBox:
def __init__(self, XParentWindow):
try:
if XParentWindow is None:
frame = XSCRIPTCONTEXT.getDesktop().getCurrentFrame()
XParentWindow = frame.getContainerWindow()
self.Parent = XParentWindow
self.Toolkit = XParentWindow.getToolkit()
except:
raise AttributeError, 'Did not get a valid parent window'
def msgbox(self, message='', flag=0, title=''):
'''Wrapper for com.sun.star.awt.XMessageBoxFactory.'''
rect = uno.createUnoStruct('com.sun.star.awt.Rectangle')
dlg = self.Toolkit.createMessageBox(self.Parent, rect, errorbox,
1, title, message)
dlg.execute()
Which at least works for me, though I couldn't see why the
com.sun.star.awt.MessageBoxButtons set of constants wouldn't work nicely
for me.
When I whack that into my system's TableSample.py and add:
box = MessageBox(None)
box.msgbox (What is this ?)
to createTable() - I get a nice message-box first :-) I bound running
that macro to F4 to make it quicker to loop iterate / check the code
The UNO API is pretty fearsome to use, it can help to read the
interface comments in offapi/ but it is not for the faint hearted,
clearly :-)
I guess, seeing how broken the C++ side is - with helpful comments
like:
if(!bIsLoggedIn)
{
OSL_FAIL(create error message);
return;
}
that simply don't create an error message, or do anything useful -
perhaps a chunk of the work needed is on the C++ side anyway.
HTH,
Michael.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCHES] Fixed some CLang++ errors/warnings in sal
Applied - would you want to look into the TODO case as well? A rather nasty cause for errors ... While it is theoretically possible to hit this, I doubt in practice that writing an int to a file descriptor will ever do a partial write. It may just be better to change that to an OSL_ASSERT instead of adding a for loop. Thoughts? Thanks, Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [LibreOffice] [PATCH] [GSOC 2011] Hack: Store/Restore font dropdown MRU
Hi all, Store/Restore font dropdown MRU is the required hack I worked on. I attached the related patch. From the Easy Hack web page: Background: When you open a new document, use the font dropdown and select a number of different fonts then the 5 or so most recently used fonts are shown at the top of the list. But when you open a new document then the dropdown resets again. It would be nice to retain the MRU list when opening a new document, and also save and restore the MRU on exit and restart. Code for the dropdown is in svtools/source/control/ctrlbox.cxx, see vcl/unx/source/fontmanager.cxx and m_aCacheFile for a sample of the APIs to save/load from/to a file in the users config directories. My work: Now when you close a window where a FontNameBox control is provided the most recent used (mru) entries for the font control are stored in a file, the previous saved entry list is discarded; when a document is opened or created the mru entry list of the FontNameBox control is populated with the one saved in the file. The file is saved under UserPath/config and is named fontnameboxmruentries (is there a better place/name ?) A possible enhancement could be to save the font name box mru entries for the last 5/10 openened documents. (How can I get the name of the current document/window ?) While I was working on this hack I noticed that when two or more documents are opened spurious resetting of the FontNameBox mru entry list may happen, I did not get the cause of that, anyway as a workaround I added a call to FontNameBox::GetMRUEntries at the begin of the FontNameBox::Fill method and a call to FontNameBox::SetMRUEntries to the end of the same method in this way even with spurious calls to the FontNameBox::Fill method the font mru entries are preserved. Cheers, Marco -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ binJ9DCXjY2vZ.bin Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [LibreOffice] [PATCH] [GSOC 2011] Hack: Store/Restore font dropdown MRU
On Thu, 2011-04-14 at 19:07 +0200, Marco wrote: Hi all, Store/Restore font dropdown MRU is the required hack I worked on. I attached the related patch. oh cool, one little thing, I wouldn't bother with using the osl_getThreadTextEncoding() (which is just the system encoding) and instead just use RTL_TEXTENCODING_UTF8, that way we don't run into problems munging e.g. CJK font names into ? if the system text encoding is some 8bit foo. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Easy Hack completed - All bogus comments removed
I forget to mention... This patch is under the LGPLv3+ / MPL license. 2011/4/14 Júlio Hoffimann julio.hoffim...@gmail.com ... and the last and big one. ;-) https://bugs.freedesktop.org/show_bug.cgi?id=36234 https://bugs.freedesktop.org/show_bug.cgi?id=36234Regards, Júlio. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] -conver-to on master
Hi, On -3-3, the following works fine: libreoffice -nologo -convert-to rtf -outdir /home/vmiklos/git/libreoffice/lo-test-files/writer/bug/35985/out /home/vmiklos/git/libreoffice/lo-test-files/writer/bug/35985/test.rtf On master, I tried: ./soffice.bin --nologo --convert-to rtf --outdir /home/vmiklos/git/libreoffice/lo-test-files/writer/bug/35985/out /home/vmiklos/git/libreoffice/lo-test-files/writer/bug/35985/test.rtf and it does the conversion, but it also fires up a window and it does not exit when the conversion finished. Muthu, do you have an idea what went wrong? Thanks. pgpJPe5REUhq4.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] update service
On 14/04/11 06:42, Hossein Noorikhah wrote: I think it's a good assumption that updating is only needed on Windows. Look at Mozilla Firedox update. Update mechanism is available for Linux, but most distros disable it because they have their own update mechanism. I don't know exactly about Mac, but most of its uers have NeoOffice installed. I think I'm confused as to what we're talking about. Is updating any different than packaging? I assume we're looking for a system that manages both. I disagree with leaving things to the distros - giving *nix users the ability to update and get the most recent fixes / features should be /our/ responsibility, not left to distro maintainers (and I for one use Firefox's update mechanism on Ubuntu, 'cause I don't like the changes the distro maints make :-) And ought we not to aim to merge the NeoOffice / LibreOffice communities eventually, as with the http://go-oo.org/ project? I don't know, maybe there are politics of which I'm unaware. In other news, I've found several other possible tool candidates, and some more information about the Firefox update system, and added it to the wiki: http://wiki.documentfoundation.org/Development/Enterprises_nice-to-have Bests, -r ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Document( header=table, body=table )
Normally, a header is a single line. For some documents, part of that single line could be an image (preferably vector). The document I am playing with, is guaranteed to be composed of 12 or more lines of content in the header (typically as 4 tables on top of each other). All examples I've seen, have the header being less than half a page, but no guarantee on that. Obviously, if the header is more than 1 page long, there is no way to typeset things as the page is too small. I have (effectively) reproduced the document in LaTeX. It is not trivial. The parent documents are .doc. I can get content using various Perl modules, getting structured content doesn't seem to be possible. I can save at least 1 of these documents as ODT. As ODT is nominally all text (if compressed), I thought that perhaps turning a document into a template (by changing specific data into known strings) might work. I suppose people familiar with ODT will not be surprised to hear that I cannot find my known strings in either content.xml or manifest.zip (my hope was it is content.xml). I had loaded up a document into perl using OpenOffice::OODoc, and generated the XPath object. The file is nominally 35kB, getting an almost 8 MB dump of the XPath object wasn't expected. How should a person use an ODT document as a template to produce versions of the document? Thanks, Gord ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] How to create get an XWorksheet from a XSpreadsheet?
Hi Noel, here is the patch without the conversion from XSpreadsheet to XWorksheet. I found some nice Code in ScVbaWorkbook::getActiveSheet() where nearly the same thing was done. But the following attempt didn't work, and created always an error message in getDocUnoModule() uno::Referenceframe::XModel xNewModel( getCurrentExcelDoc( mxContext ), uno::UNO_SET_THROW ); ScDocShell* pShell = excel::getDocShell( xNewModel ); if( !pShell ) throw uno::RuntimeException(); ScDocument* pDoc = pShell-GetDocument(); String aCodeName; pDoc-GetCodeName((SCTAB)0 ,aCodeName); return uno::Reference excel::XWorksheet ( getUnoDocModule( aCodeName, pShell ), uno::UNO_QUERY_THROW ); With a debugger you see that pShell points to the correct ScDocShell and aCodeName points to the CodeName of the ScTable but it still won't work. Perhabs you know why my idea won't work. Nearly the same code works fine with ScVbaWorkbook::getActiveSheet() Patch is under LGPLv3+/MPL. Regards, Markus P.S. Even some really strange ways of using the setUpDocumentModules(const uno::Reference sheet::XSpreadsheetDocument ) of vbaworkbooks.cxx produces an error. But this seems a good way to solve the problem. If you can give me any hints why this won't work I will try again on the conversion 2011/4/14 Noel Power nopo...@novell.com Hi Markus On 14/04/11 00:49, Markus Mohrhard wrote: Hello, I have reworked most of the Code but have now the problem that I have an instance of XSpreadsheet but need the corresponding XWorksheet object. I found one of these conversions at ScVbaWorksheet::getSheetAtOffset but it needs to call getParent, which will not work in my case because it is for the new method createSheetCopyInNewDoc. Do you know any way to resolve this problem? aha very good!! I didn't think of that, nice catch. Ok, here is what I propose, I think you have suffered enough with this so-called easy hack, just pass null as the parent and lets get the patch reviewed and in. Please do put a #TODO #FIXME in the code where the parent is (NOT) created. The parent should be a Workbook object, problem here is that when you create a new document, just creating a workbook object isn't enough as those parents are by a weakreference and the workbook object you would create would only be temporary. If the new document was created correctly ( e.g. in vba mode ) then we could use the getUnoDocModule() to access the correct Workbook instance and pass that instead. I think we need to tweak the existing code more to do that ( some stuff like this is already done in ScWorkbooks::Add ). if you are interested I'd give you some advice/hints on how that should be done and you could do that as a separate hack ( let me know if you are interested in doing that ) Otherwise just open a bug for that part and assign it to me and I will either fix it or create another easy hack from that. thanks for you continued efforts Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] How to create get an XWorksheet from a XSpreadsheet?
And again with the patches. 2011/4/15 Markus Mohrhard markus.mohrh...@googlemail.com Hi Noel, here is the patch without the conversion from XSpreadsheet to XWorksheet. I found some nice Code in ScVbaWorkbook::getActiveSheet() where nearly the same thing was done. But the following attempt didn't work, and created always an error message in getDocUnoModule() uno::Referenceframe::XModel xNewModel( getCurrentExcelDoc( mxContext ), uno::UNO_SET_THROW ); ScDocShell* pShell = excel::getDocShell( xNewModel ); if( !pShell ) throw uno::RuntimeException(); ScDocument* pDoc = pShell-GetDocument(); String aCodeName; pDoc-GetCodeName((SCTAB)0 ,aCodeName); return uno::Reference excel::XWorksheet ( getUnoDocModule( aCodeName, pShell ), uno::UNO_QUERY_THROW ); With a debugger you see that pShell points to the correct ScDocShell and aCodeName points to the CodeName of the ScTable but it still won't work. Perhabs you know why my idea won't work. Nearly the same code works fine with ScVbaWorkbook::getActiveSheet() Patch is under LGPLv3+/MPL. Regards, Markus P.S. Even some really strange ways of using the setUpDocumentModules(const uno::Reference sheet::XSpreadsheetDocument ) of vbaworkbooks.cxx produces an error. But this seems a good way to solve the problem. If you can give me any hints why this won't work I will try again on the conversion 2011/4/14 Noel Power nopo...@novell.com Hi Markus On 14/04/11 00:49, Markus Mohrhard wrote: Hello, I have reworked most of the Code but have now the problem that I have an instance of XSpreadsheet but need the corresponding XWorksheet object. I found one of these conversions at ScVbaWorksheet::getSheetAtOffset but it needs to call getParent, which will not work in my case because it is for the new method createSheetCopyInNewDoc. Do you know any way to resolve this problem? aha very good!! I didn't think of that, nice catch. Ok, here is what I propose, I think you have suffered enough with this so-called easy hack, just pass null as the parent and lets get the patch reviewed and in. Please do put a #TODO #FIXME in the code where the parent is (NOT) created. The parent should be a Workbook object, problem here is that when you create a new document, just creating a workbook object isn't enough as those parents are by a weakreference and the workbook object you would create would only be temporary. If the new document was created correctly ( e.g. in vba mode ) then we could use the getUnoDocModule() to access the correct Workbook instance and pass that instead. I think we need to tweak the existing code more to do that ( some stuff like this is already done in ScWorkbooks::Add ). if you are interested I'd give you some advice/hints on how that should be done and you could do that as a separate hack ( let me know if you are interested in doing that ) Otherwise just open a bug for that part and assign it to me and I will either fix it or create another easy hack from that. thanks for you continued efforts Noel 0001-add-method-Copy-to-ScVbaWorksheets.patch Description: Binary data 0002-added-method-Copy-to-XWorksheets.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
