[Libreoffice] [GSoC] [rtfimport] 6th week
Hi, Last week starts here: http://cgit.freedesktop.org/~vmiklos/lo-gsoc/tree/README#n774 In short, it was about: - headers/footers - section borders - footnotes - line numbering - bookmarks - redlines Miklos pgprjW8D6usbB.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] fix for fdo#37482 - selecting text box after editing gives rotation handles
Hi,
Attached is a patch to fix fdo#37482. Could this be reviewed pushed?
Kind regards,
Luke.
From e7e9e5fb3bfa117a2f30d8d070d3705980e59dae Mon Sep 17 00:00:00 2001
From: Luke Symes allsy...@gmail.com
Date: Mon, 4 Jul 2011 19:08:09 +1200
Subject: [PATCH] Fix fdo#37482 (selecting text box after editing gives
rotation handles)
---
sd/source/ui/func/futext.cxx |7 ++-
sd/source/ui/inc/futext.hxx |1 +
2 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx
index 281645d..f683370 100644
--- a/sd/source/ui/func/futext.cxx
+++ b/sd/source/ui/func/futext.cxx
@@ -140,6 +140,7 @@ static sal_Bool bTestText = 0;
FuText::FuText( ViewShell* pViewSh, ::sd::Window* pWin, ::sd::View* pView, SdDrawDocument* pDoc, SfxRequest rReq )
: FuConstruct(pViewSh, pWin, pView, pDoc, rReq)
, bFirstObjCreated(sal_False)
+, bJustEndedEdit(false)
, rRequest (rReq)
{
}
@@ -400,6 +401,7 @@ sal_Bool FuText::MouseButtonDown(const MouseEvent rMEvt)
if( mpView-IsTextEdit() )
{
mpView-SdrEndTextEdit();
+bJustEndedEdit = true;
if(aVEvt.pHdl)
{
@@ -682,7 +684,7 @@ sal_Bool FuText::MouseButtonUp(const MouseEvent rMEvt)
sal_uInt16 nDrgLog = sal_uInt16 ( mpWindow-PixelToLogic(Size(DRGPIX,0)).Width() );
-if ( mpView-IsRotateAllowed() mpViewShell-GetFrameView()-IsClickChangeRotation() (rMEvt.GetClicks() != 2)
+if ( mpView-IsRotateAllowed() mpViewShell-GetFrameView()-IsClickChangeRotation() (rMEvt.GetClicks() != 2) !bJustEndedEdit
!rMEvt.IsShift() !rMEvt.IsMod1() !rMEvt.IsMod2() !rMEvt.IsRight()
Abs(aPnt.X() - aMDPos.X()) nDrgLog
Abs(aPnt.Y() - aMDPos.Y()) nDrgLog)
@@ -690,6 +692,9 @@ sal_Bool FuText::MouseButtonUp(const MouseEvent rMEvt)
// toggle to rotation mode
mpViewShell-GetViewFrame()-GetDispatcher()-Execute( SID_OBJECT_ROTATE, SFX_CALLMODE_ASYNCHRON | SFX_CALLMODE_RECORD );
}
+
+if( bJustEndedEdit )
+bJustEndedEdit = false;
}
else if( mpView mpView-IsCreateObj() rMEvt.IsLeft())
{
diff --git a/sd/source/ui/inc/futext.hxx b/sd/source/ui/inc/futext.hxx
index ea5b309..a792a03 100644
--- a/sd/source/ui/inc/futext.hxx
+++ b/sd/source/ui/inc/futext.hxx
@@ -98,6 +98,7 @@ protected:
SdrObjectWeakRef mxTextObj;
LinkaOldLink;
sal_BoolbFirstObjCreated;
+boolbJustEndedEdit;
SfxRequest rRequest;
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] rtl::O[U]StringBuffer now has a remove method
On Saturday 02 of July 2011, Caolán McNamara wrote: On Fri, 2011-07-01 at 17:53 +0200, Lubos Lunak wrote: On Thursday 30 of June 2011, Caolán McNamara wrote: Do we have a preference ?, I'm easy either way. Since nobody seems to have a preference, I'd like to point out that also std::string uses start+len (even though there one could expect start,end to match the iterator variants) and Qt uses start+len. IMO we should not try to be consistent with Java just because the idea for the class comes from Java. Yeah, given that the other additional methods that were added take length arguments, its best to use lengths throughouts. Ok to push the attached patch? No objection, fine by me. Ok, pushed. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC][PATCH] Multiline inputbar
Hi Anurag, As discussed on IRC I had hoped to see the patch you promised to send. The one that rename's your class, restores ScTextWnd and removes the unnecessary changes and does some cleanup of the existing code, is there some problem? everything ok? I need those changes to integrate your code into master. On 26/06/11 18:23, Anurag Jain wrote: yes as soon as I get things placed in right place I'll be working on switching from single line to multiline mode on the button click. Is there any update regarding with size switching, any chance of a patch for the above?, it would be great to get those changes in addition to the work above into master ( would give people a better idea and feel for what you are doing, without the resize changes the visual difference with the work sofar isn't so obvious ) So, time is fast running out on this, I need the patches already promised asap, if you can provide the extra parts that's even better. Thanks Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC][PATCH] Multiline inputbar
Hello Noel, Yes I have made some changes as you mentioned this weekend. There are certain thing I'm not getting properly. 1: I'm able to toggle the height of ScMultiBar and ScInputBarGroup on button click. But the increment happens inside the ScInputWindow i.e. the excess window size do not appear. It toggles inside the ScInputWindow. To make it look the height of complete panel should be varied.So in order to do that will it be a good idea to add a ScInputWindow object in ScInputBarGroup and use it to vary the whole panel's height ? 2: Also one more thing, when button is clicked twice , the position window, and other formula images all disappears leaving a blank on left side of panel. I guess the ScInputBarGroup changes its vertical position. I tried resetting it always to (nLeft,0) but the LO did not start for some reason. As of now I'm trying to fix that. I'll discuss about these problems today in IRC and things required to be improved a little bit before putting it in master branch. On Mon, Jul 4, 2011 at 3:29 PM, Noel Power nopo...@novell.com wrote: Hi Anurag, As discussed on IRC I had hoped to see the patch you promised to send. The one that rename's your class, restores ScTextWnd and removes the unnecessary changes and does some cleanup of the existing code, is there some problem? everything ok? I need those changes to integrate your code into master. On 26/06/11 18:23, Anurag Jain wrote: yes as soon as I get things placed in right place I'll be working on switching from single line to multiline mode on the button click. Is there any update regarding with size switching, any chance of a patch for the above?, it would be great to get those changes in addition to the work above into master ( would give people a better idea and feel for what you are doing, without the resize changes the visual difference with the work sofar isn't so obvious ) So, time is fast running out on this, I need the patches already promised asap, if you can provide the extra parts that's even better. Thanks Noel Thanks and regards. -- Anurag Jain Final yr B.Tech CSE SASTRA University Thanjavur(T.N.)-613402 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Java screws el reg ...
Hi Francois, On Fri, 2011-07-01 at 18:07 +0200, Francois Tigeot wrote: I'm not running MacOS X, but all my LibreOffice builds are done without Java and the only obvious broken feature is the Contributor Credits link accessible from the help/about menu. Oh - that is curious indeed - that should just launch a web browser to take you there which shouldn't really involve java at all - most odd. Can we get an strace of that not working ? :-) perhaps it is just your browser being configured incorrectly. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC] Report #5. Wizards
Hi Xisco, Peter - Xisco is working on re-writing the wizards in Java :-) On Fri, 2011-07-01 at 16:05 +0200, Xisco Faulí wrote: Michael wrote: Weelll - so you're both right; but really we need to grub about inside the templates themselves to add some improved translation scheme I think; now we have fast native XSLTs - I guess we could use the native XSLT filters to allow the templates to be self-standing, and yet adapt to the locale nicely. But - your task is primarily the Java - python conversion I guess :-) Xisco wrote: Yes, you're right but if I have some time before gsoc finishes (or even after) I'd like to take a look to it. Who should I get in contact with in order to get my feet wet ? Ah - so the XSLT expert is Peter Jentsch who has done a load of great work in this area, writing the much faster / smaller native C++ filter etc. He can prolly help out with some code pointers, and/or perhaps some simple example XSLTs that might be useful for translating attributes / elements (?), and ways to get feed the required data to them elegantly. HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC] Report #5. Wizards
On Fri, 2011-07-01 at 16:32 +0200, Laurent Godard wrote: IIRC, templates can be deployed with extension mechanism Sounds fun :-) so why not use this and package language based extension when building the installer ? so, you may find more easily maintainers of these files Ah - so the problem is that we have tens if not more of Mb of entirely duplicated template files in our download and install - and that that is pretty pointless - when the changes are small between templates. Worse - since ~anything can be changed in a template, not just translation (and perhaps a few well flagged attributes), people tweak all manner of random stuff making cross-language consistency hard, and almost impossible to detect problems with (try diffing the formatted XML between two old-style apparently identical-but-for-l10n templates) :-) i think your proposal is intellectually the good one, but seems overkill to me regarding the efforts needed when the files will have to be updated Heh - sure, but using LibreOffice itself as a translation tool is somewhat fraught with difficulty ;-) cf. above - no doubt we could try to fix that: to expose language-adaptive document functionality in the UI, but I'd prefer to have some background heavy lifting just for our internal templates as of now :-) ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Possibilities of Webdav
Hi Christian, On Thu, 2011-06-30 at 10:57 +0200, Christian Andersson wrote: Hi there I hope someone could help me answering a question regarding the webdav implementation of Libreoffice. Hah - so, my experience with webdav is that testing it is a nightmare, and there are no good easy-to-use implementations out there that I could use to do so ;-) [ that includes the non-functional webdav.org stuff too ]. Now I have tried searching in libreoffice websites for some information, with little or no luck at all.. I have also read thsi docuement, but it does not give me any clarity either What I would do is to read the code instead; it is probably (somewhat) simpler - actually, hmm, no the UCB IDL interface is baroque in the extreme: methods are involved via string names everything passed as 'Any's but ... now question, can I with a plugin in openoffice get a hold of these headers after the document has been saved? I fthat is possible somehow, then I might be able to replace the other editor with openoffice.org I assume you mean LibreOffice :-) but yes, this is Free Software - anything is possible; if you can help add the feature - we'd gladly review accept the patch if it's good, and ship it. Code kicks around here: http://cgit.freedesktop.org/libreoffice/libs-core/tree/ucb/source/ucp/webdav/webdavcontent.cxx#n600 But perhaps you really want 'open' - the string names are coming from the LibO core for commands, and it is possible you'd want to hook stuff to the webdav stream interface somehow. Then again, with a quick scan, I didn't see the write support there - but dig around in ucp/webdev/ It'd be great to have you using LibreOffice ! :-) HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Unused files in the impress repository
Hi François, *, On Sat, Jul 2, 2011 at 10:12 PM, Francois Tigeot ftig...@wolfpond.org wrote: Hi, The following files seem to be unused: impress/sd/source/filter/eppt/eppt.cxx impress/sd/source/filter/html/htmlex.cxx With the attached patch, I could succesfully complete a build. Howewer, I'm not 100% sure these files have no purpose whatsoever. Well, stating the obvious (hopefully it is obvious for you as well): As htmlex is dealing with html export - is html export still available and working in Impress? Same with ppt export. And regarding completing a build with the changes: A full, clean build from scratch, or a do a build, do the change, run make again build? The latter is not a guarantee to report success after removing files. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] fix for fdo#30800: Option to display calc gridlines on colored cells
Hey there,
this is a patch to fix fdo#30800.
A tiny specification, what has been implemented is at the wiki:
http://wiki.documentfoundation.org/User:Andreschnabel/Spec_Calc_grid_lines_
on_colored_background
Comments and questions are welcome, as this is the first time that I
actually *add* some code.
Well done! Attached is a small modification to the code (and the function)
I've made. I.e. it makes sense to allow user to define grid colour (and thus
enable fixed text related listbox) in both cases when the grid is enabled --
in both show and show on colored cells case.
Also, before I really push the patch -- may I suggest some change to the
wording being used?
Show on colored cells sounds slghtly misleading to me, as the grid is
shown everywhere (all over the sheet), not only over the cells filled by some
colour. Something along Show always on top or Show in the foreground line
would imao describe its function much better ... Consequently, the option name
would become GridOnTop, or GridInForeground, but that's just nitpicking ...
B.
--
\ Katarina Machalkova
\\\__o LibO developer
__\\\'/_ hedgehog painter
diff --git a/sc/source/ui/optdlg/tpview.cxx b/sc/source/ui/optdlg/tpview.cxx
index 197169e..8fc3b23 100644
--- a/sc/source/ui/optdlg/tpview.cxx
+++ b/sc/source/ui/optdlg/tpview.cxx
@@ -315,7 +315,7 @@ void ScTpContentOptions::InitGridOpt()
sal_BoolbGridOnTop = pLocalOptions-GetOption( VOPT_GRID_ONTOP );
sal_uInt16 nSelPos = 0;
-if ( bGrid )
+if ( bGrid || bGridOnTop )
{
aColorFT.Enable(), aColorLB.Enable();
if ( !bGridOnTop )
@@ -395,8 +395,8 @@ IMPL_LINK( ScTpContentOptions, GridHdl, ListBox*, pLb )
sal_BoolbGrid = ( nSelPos = 1 );
sal_BoolbGridOnTop = ( nSelPos == 1 );
-aColorFT.Enable(bGridOnTop);
-aColorLB.Enable(bGridOnTop);
+aColorFT.Enable(bGrid);
+aColorLB.Enable(bGrid);
pLocalOptions-SetOption( VOPT_GRID, bGrid );
pLocalOptions-SetOption( VOPT_GRID_ONTOP, bGridOnTop );
return 0;
signature.asc
Description: This is a digitally signed message part.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] [PATCH] Writer: Bug 36181 - EasyHack: Replace with Notes option doesn't work with text selected
On Sun, 2011-07-03 at 23:07 +0200, Benoit Dolives wrote: Yup, patch fixes fixes the problem. Thanks for this. Pushed now to master. Can you confirm that this is under our preferred LGPLv3+/MPL license combo ? Concerning your open question, the proposed patch checks if the searched string belongs to the selection by using the same mechanism as the common search command. Therefore it should have the same behaviour as the search command in both cases (common or advanced search/replace). Hmm, if I stick e.g. Apple banana in there, select nothing, search and replace with regular expression of b.*a to match banana but where the search string has a different length to the text it will match, with comments enabled, then that one doesn't replace. AFAICS that length is the same branch is just an optimization. When removed everything works as I would expect, so I pushed that as a follow up fix. Would be good if you could double-check my changes there, and if the equal length code is based on some other code elsewhere, there might be an additional fix needed for the legacy stuff too. There's probably a few more gotchas with search and replace in writer, (e.g. how come I can't use replace all when comments are selected) if you dig around bugzilla for them :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Debug-mode getline-using sal unittest crashes, triggered by _GLIBCXX_DEBUG
On Fri, 2011-07-01 at 18:59 +0200, Julien Nabet wrote: Le 30/06/2011 14:26, Nigel Hawkins a écrit : On Wed, 2011-06-29 at 23:26 +0200, Julien Nabet wrote: diff --git a/sal/qa/osl/process/osl_process.cxx b/sal/qa/osl/process/osl_process.cxx index 2535c4c..8695d79 100644 --- a/sal/qa/osl/process/osl_process.cxx +++ b/sal/qa/osl/process/osl_process.cxx @@ -477,6 +477,7 @@ public: ); std::string line; + line.reserve(1); while (std::getline(file, line, '\0')) env_container-push_back(line); tidy_container(*env_container); That change fixes the problem here. Hello, Can i push this patch as a workaround or do you think about a better solution ? Presumably this works because the string is sufficiently big that it doesn't need to be resized by getline so some realloc is skipped in the other chunk of code compiled with different and apparently incompatible settings. Seeing as this thread is dragging on and and we don't have a stand-alone reproducer to blame on anyone in particular, feel free to stick a reserve in here. Pick a number that's a reasonably small power of 2 which works for you, e.g. 1024, 4096, 8192 or something and we can justify it as a micro-optimization :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Unused files in the impress repository
Hi Christian, On Mon, Jul 04, 2011 at 01:22:21PM +0200, Christian Lohmaier wrote: On Sat, Jul 2, 2011 at 10:12 PM, Francois Tigeot ftig...@wolfpond.org wrote: The following files seem to be unused: impress/sd/source/filter/eppt/eppt.cxx impress/sd/source/filter/html/htmlex.cxx With the attached patch, I could succesfully complete a build. Howewer, I'm not 100% sure these files have no purpose whatsoever. Well, stating the obvious (hopefully it is obvious for you as well): As htmlex is dealing with html export - is html export still available and working in Impress? Same with ppt export. Good question, I had not done an installation in a while ;) The html and ppt save/export options are still available And they are not working anymore: Trying to export as html crashes LibreOffice: /usr/libexec/ld-elf.so.2: /usr/local/LibreOffice/program/../basis-link/program/libsdlo.so: Undefined symbol _ZN10HtmlExportC1EN3rtl8OUStringERKN3com3sun4star3uno8SequenceINS4_5beans13PropertyValueEEEP14SdDrawDocumentPN2sd12DrawDocShellE Saving a file as .ppt opens a dialog box: Error saving the document Presentation: Write Error. The file could not be written. [OK] And regarding completing a build with the changes: A full, clean build from scratch, or a do a build, do the change, run make again build? The latter is not a guarantee to report success after removing files. It was a build from scratch. I now see that I was mistaken: even though none of the symbols from these files are directly used in LibreOffice, the binary containing them is loaded explicitely at run time, bypassing the normal shared library linking mechanism. I thought UNO was a sort of interface for external plugins but these export functions also use it :-( -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC][PATCH] Multiline inputbar
On 04/07/11 11:29, Anurag Jain wrote: Hello Noel, I'm sending the inputwin.cxx with the changes I've made in ScInputBargroup. Do not push it as of now. I'd be making some more changes as mentioned in above mail before it can be pushed. I guess it really isn't usable without a header file :-( I really was looking for a patch that addressed the issues we talked about previously that would allow me to at least start to try and integrate your work. On Mon, Jul 4, 2011 at 3:53 PM, Anurag Jainanuragjain...@gmail.com wrote: Hello Noel, Yes I have made some changes as you mentioned this weekend. There are certain thing I'm not getting properly. 1: I'm able to toggle the height of ScMultiBar and ScInputBarGroup on button click. But the increment happens inside the ScInputWindow i.e. the excess window size do not appear. It toggles inside the ScInputWindow. To make it look the height of complete panel should be varied.So in order to do that will it be a good idea to add a ScInputWindow object in ScInputBarGroup and use it to vary the whole panel's height ? hmm, it seems that somehow the toolbar doesn't resize as expected, don't know why, might be worth doing some debugging in vcl/source/window/toolbox.cxx 2: Also one more thing, when button is clicked twice , the position window, and other formula images all disappears leaving a blank on left side of panel. I guess the ScInputBarGroup changes its vertical position. I tried resetting it always to (nLeft,0) but the LO did not start for some reason. As of now I'm trying to fix that. I'll discuss about these problems today in IRC and things required to be improved a little bit before putting it in master branch. no idea at all about that, it sounds like either a paint problem ( but that's easy to check by forcing repaint but moving the window offscreen and back ) or the controls have been repositioned somehow, again some debugging of the size and position attributes of the toolbar items should give you an idea I am going to try to integrate the code as it was before whatever new work you have done because I there is little time left, it is better to have some code integrated rather than none :-). I didn't look at the inputwin.cxx that you attached in any great detail but I don't like the name of the new textbox ScMultiBar, it is I think misleading, I liked some of the other alternatives you suggested better ( e.g. ScMultiText ). I know I suggested that you rename the class to something new but I thought maybe you could reuse the old one ( e.g. inherit from it ) to avoid duplicating *all* the code there. My main concern was to separate the new from old code ( without excessive logic ( if/then ) branches in the code especially with the requirement of having some code in master )... I will try to fix that when integrating the code Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice browser detection
Hi Michael, On Mon, Jul 04, 2011 at 11:36:44AM +0100, Michael Meeks wrote: On Fri, 2011-07-01 at 18:07 +0200, Francois Tigeot wrote: I'm not running MacOS X, but all my LibreOffice builds are done without Java and the only obvious broken feature is the Contributor Credits link accessible from the help/about menu. Oh - that is curious indeed - that should just launch a web browser to take you there which shouldn't really involve java at all - most odd. Can we get an strace of that not working ? :-) perhaps it is just your browser being configured incorrectly. I've found the cause: the browser configuration is a hardcoded list of browser names ;-) Look for firefox in : http://opengrok.libreoffice.org/xref/libs-core/shell/source/unix/misc/open-url.sh None of them are installed on my machine, it's no wonder the link didn't work (besides, who runs netscape or mozilla these days ?). Simply making a symbolic link from one of the installed browsers (seamonkey) to 'firefox' was enough to fix the dialog box. The implementation of open-url.sh has to be fixed but besides changing the program names to more modern equivalents, I've no real idea how it should be done. Oh, and by the way there are some Internet related options accessible from the Tools / Options menu : - choice of proxy - search engine (with preselected choices from the 90s: Altavista, ...) - choice of email program - browser plugin Besides the choice of email program, I don't see what they could be used for. Did StarOffice include a complete web browser at one time ?? -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] fix for fdo#30800: Option to display calc gridlines on colored cells
Hi, Am 04.07.2011 15:32, schrieb Katarina Machalkova: Well done! Attached is a small modification to the code (and the function) I've made. I.e. it makes sense to allow user to define grid colour (and thus enable fixed text related listbox) in both cases when the grid is enabled -- in both show and show on colored cells case. Yes, please apply with the modifications. While -if ( bGrid ) +if ( bGrid || bGridOnTop ) just makes more obvious, what happens - the other one -aColorFT.Enable(bGridOnTop); -aColorLB.Enable(bGridOnTop); +aColorFT.Enable(bGrid); +aColorLB.Enable(bGrid); is a real error :( Also, before I really push the patch -- may I suggest some change to the wording being used? Show on colored cells sounds slghtly misleading to me, as the grid is shown everywhere (all over the sheet), not only over the cells filled by some colour. Something along Show always on top or Show in the foreground line would imao describe its function much better ... Consequently, the option name would become GridOnTop, or GridInForeground, but that's just nitpicking ... This had been discussed at some point (actually I did prefer on top as you see in the implementation). But comments showed that on top or in foreground is not a much better description. The grid is not really on top, as it is still behind drawing elements, notes ... So I'd rather stay with the current strings. thanks and regards, André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [MHST] Problem with make on fedora 15
Thank you Miklos. I've applied the patch and everything is ok now. Again, thank you very much tatung On 07/02/2011 06:46 PM, Miklos Vajna wrote: On Sat, Jul 02, 2011 at 01:16:09PM +0700, Ta Duc Tungtatung2...@gmail.com wrote: Thank you for replying soon. Can you show me how to apply that patch? [1] http://pkgs.fedoraproject.org/gitweb/?p=libreoffice.git;a=blob_plain;f=vbahelper.visibility.patch;hb=HEAD Try: patch -p0 vbahelper.visibility.patch. See man patch. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Remove CREDITS.odt?
Hi, I've seen the latest About LibreOffice window from master, which is pretty awesome. There is a link Contributer credits to the online version of the credits. At Help-LibreOffice Credits there is a link to the offline CREDITS.odt which is out of sync with the online version. Question is: Is Help-Libreoffice Credits menu entry necessary at all if there's a link to it within the about window? I don't think so. If we remove it, we could remove CREDITS.odt as well. Or at least we need to sync them. Any comments? Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Writer: Bug 36181 - EasyHack: Replace with Notes option doesn't work with text selected
Hi Caolán, all, Thanks for your review. The patch is indeed under LGPLv3+/MPL license. I will have a look to your additional patch as soon as possible, thanks a lot. I indeed saw some troubles with the current search and replace mechanism of writer. For example the Find in selection is not working properly : if you select a text after having opened the search and replace dialog, this text will not be taken in account by the Find in selection, and some others bugs. I intend to work on it, patch after patch after ... Cheers, Benoit 2011/7/4 Caolán McNamara caol...@redhat.com On Sun, 2011-07-03 at 23:07 +0200, Benoit Dolives wrote: Yup, patch fixes fixes the problem. Thanks for this. Pushed now to master. Can you confirm that this is under our preferred LGPLv3+/MPL license combo ? Concerning your open question, the proposed patch checks if the searched string belongs to the selection by using the same mechanism as the common search command. Therefore it should have the same behaviour as the search command in both cases (common or advanced search/replace). Hmm, if I stick e.g. Apple banana in there, select nothing, search and replace with regular expression of b.*a to match banana but where the search string has a different length to the text it will match, with comments enabled, then that one doesn't replace. AFAICS that length is the same branch is just an optimization. When removed everything works as I would expect, so I pushed that as a follow up fix. Would be good if you could double-check my changes there, and if the equal length code is based on some other code elsewhere, there might be an additional fix needed for the legacy stuff too. There's probably a few more gotchas with search and replace in writer, (e.g. how come I can't use replace all when comments are selected) if you dig around bugzilla for them :-) C. -- Benoit Dolives ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Writer: Bug 36181 - EasyHack: Replace with Notes option doesn't work with text selected
On Mon, 2011-07-04 at 19:35 +0200, Benoit Dolives wrote: I indeed saw some troubles with the current search and replace mechanism of writer. For example the Find in selection is not working properly : if you select a text after having opened the search and replace dialog, this text will not be taken in account by the Find in selection, and some others bugs. I intend to work on it, patch after patch after ... Excellent, something else worth considering, in order to *keep* bugs fixed, is adding e.g. search/replace regression tests to sw/qa/core. Not always pain-free for the higher level UI stuff, but suitable for SwDocShell and under level stuff C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Single Git repository migration plan
Hi all, [please follow up on projects@ list] There is an planed effort to reduce and consolidate the number of git repositories in use (up to 20 currently) and migrate them using a git fetch, however it has some drawbacks with history being unusable. A clean up will be necessary too (the main one being tab/space clean-up). You'll find a C program for that indicated on the wiki page bellow. As a result also, the development pages will need to be updated on the wiki, so you'll have to monitor the changes done there. The script onegit.sh, which is located in contrib/dev-tools, implement the steps described above. The migration is intrusive so please, pay attention to what will be done and the schedule (not confirm yet) on this page http://wiki.documentfoundation.org/Development/One_Git_Conversion Thanks in advance for your help, your feedback and your monitoring on this. If you have any question, don't hesitate to ask (I am for sure the wrong person to answer but I know where the resource is hiding :) Kind regards Sophie -- Founding member of The Document Foundation ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove CREDITS.odt?
Thomas Arnhold wrote: Question is: Is Help-Libreoffice Credits menu entry necessary at all if there's a link to it within the about window? I don't think so. If we remove it, we could remove CREDITS.odt as well. Or at least we need to sync them. Hm, given the wide range of environments LibreOffice is deployed, I'd think a offline version has its charme - would you maybe want to sync with spaetz on updating the credits.odt every once in a while? Thanks for catching this, -- Thorsten pgphuJihDGu5v.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] RTF support
Using the downloaded source dated June 19th and 20th of 2011. Except for the RTFScanner.lex file (dated June 19th, 2011) which had RTF Controls listed, I ended up searching for the string RTF_ and assumed that the uppercase alpha characters that followed are RTF controls (that appeared to be the pattern anyway). Of the 1807 RTF Controls found in the March 2008 1.9.1 Specification, 1,333 need to be added to the Import Routine and 1,419 need to be added to the Export Routine (see attached). 66 controls used in the import and/or export routine require definition because they do not appear in the March 2008 1.9.1 Specification (see attached). FYI, Tracey Miklos Vajna [via Document Foundation Mail Archive] wrote: On Fri, Jul 01, 2011 at 06:57:16AM -0700, tracey002 [hidden email] /user/SendEmail.jtp?type=nodenode=3135042i=0 wrote: I did not find what I anything that looked applicable. However I did download the source code from the download page contained in tar.bz2 files. I assume these are zip files. No, these are tar.bz2 files. Can you tell me what file name for which I am looking and the containing zip file name? The export filter lives under /sw/source/filter/ww8, the current importer is under /sw/source/filter/rtf, the work-in-progress new importer (which is enabled in experimental mode only) is under /writerfilter/source/rtftok/. The sw dir is in the writer tarball, writerfilter is in filters. ___ LibreOffice mailing list [hidden email] /user/SendEmail.jtp?type=nodenode=3135042i=1 http://lists.freedesktop.org/mailman/listinfo/libreoffice *attachment0* (205 bytes) Download Attachment /attachment/3135042/0/attachment0 If you reply to this email, your message will be added to the discussion below: http://nabble.documentfoundation.org/RTF-support-tp3114982p3135042.html To unsubscribe from RTF support, click here http://nabble.documentfoundation.org/template/NamlServlet.jtp?macro=unsubscribe_by_codenode=3114982code=d3BpaXNAZ3RlLm5ldHwzMTE0OTgyfDg1NDMxMTYz. No virus found in this incoming message. Checked by AVG - www.avg.com Version: 9.0.901 / Virus Database: 271.1.1/3741 - Release Date: 07/03/11 01:34:00 No virus found in this outgoing message. Checked by AVG - www.avg.com Version: 9.0.901 / Virus Database: 271.1.1/3743 - Release Date: 07/04/11 01:35:00 -- View this message in context: http://nabble.documentfoundation.org/RTF-support-tp3114982p3138719.html Sent from the Dev mailing list archive at Nabble.com.___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSoC] about removing productregistration.uno.component
Hi Matus, On Mon, 2011-07-04 at 16:29 +0200, Matúš Kukan wrote: The patches look lovely to me. Did we kill the OEM mess too ? I didn't send those, so here they are. But you must first apply the one about socomp and then preload cleaning. Hope it will be apply-able. Lovely :-) I am hoping you are going to push these to master yourself - right ? I always love code removal that does things like: -#ifdef TIMEBOMB ;-) Lets get it in ... Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [Libreoffice-ux-advise] Reordering of Impress/Draw main context menu
Astron wrote: I recently noticed that the main Impress/Draw context menus (those that open when clicking on an empty spot in the document) are full of separators. One after each element in Draw, in fact. Thus I opened https://bugs.freedesktop.org/show_bug.cgi?id=38671 . I already attached a pseudo-patch in the bug (sorry, I am git-impaired, but promise to try and cure my condition). Thanks to some great preliminary testing by André Schnabel [1], we know it even works. Confirmed, thx for the fix! Committed to master - can you please confirm your contribution is licensed under LGPLv3+/MPL? Good stuff, any other usability issues you'd be interested to tackle next? Cheers, -- Thorsten pgpKfv6ANG860.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [GSOC] Report #6. Wizards
Hello, I've been working this week on converting the letter wizard and as Cedric suggested me in the last report, I merged the feature branch into master. You can find the code in the component repository. Fax and Letter wizards aren't fully functional yet but I'd appreciate if someone gives it a try and give me some feedbacks. Greetings ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Unused files in the impress repository
On Mon, Jul 04, 2011 at 05:09:26PM +0200, Francois Tigeot ftig...@wolfpond.org wrote: The html and ppt save/export options are still available And they are not working anymore: Trying to export as html crashes LibreOffice: /usr/libexec/ld-elf.so.2: /usr/local/LibreOffice/program/../basis-link/program/libsdlo.so: Undefined symbol _ZN10HtmlExportC1EN3rtl8OUStringERKN3com3sun4star3uno8SequenceINS4_5beans13PropertyValueEEEP14SdDrawDocumentPN2sd12DrawDocShellE Saving a file as .ppt opens a dialog box: Error saving the document Presentation: Write Error. The file could not be written. [OK] That's exactly why you should not remove them. ;) I thought UNO was a sort of interface for external plugins but these export functions also use it :-( Not all filters are using UNO, only the newer ones. pgpvhZOkh92kN.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] RTF support
On Mon, Jul 04, 2011 at 12:54:58PM -0700, tracey002 wp...@gte.net wrote: Using the downloaded source dated June 19th and 20th of 2011. Except for the RTFScanner.lex file (dated June 19th, 2011) which had RTF Controls listed, I ended up searching for the string RTF_ and assumed that the uppercase alpha characters that followed are RTF controls (that appeared to be the pattern anyway). Yep, both the old and the new import filter uses RTF_FOO to parse \foo. The exporter uses OOO_STRING_SVTOOLS_RTF_FOO. Of the 1807 RTF Controls found in the March 2008 1.9.1 Specification, 1,333 need to be added to the Import Routine and 1,419 need to be added to the Export Routine (see attached). Nah, just adding them is easy - the real trick is to implement them. Is there any area where you would be interested to help? I would suggest contributing to the exporter, as that one is not under heavy development. 66 controls used in the import and/or export routine require definition because they do not appear in the March 2008 1.9.1 Specification (see attached). Attachement stripped - probably you need to get an email client instead of nabble if you want to send attachements. Still, if you could put a table to the wiki containing those 66 keywords, then we could start writing oneliner documentations for them - that would be a great start. pgp6htxwaN5EH.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC][PATCH] Multiline inputbar
Hello Noel,
As you asked I'm sending a patch here with most of the changes
incorporated. I've done total rework again and made a bit more
modular, removed unnecessary things and now it look way better than
what i was getting yesterday. Please have a look before you make
changes on you end and if you think this is good enough to be pushed
into Master please do so. I guess I'd be better if you make the
runtime decision thing above this patch.
As of now there are might be some printf's lying around so ignore them
as of now.
Awaiting your feedback on this.
Thanks and regards
On Mon, Jul 4, 2011 at 9:09 PM, Noel Power nopo...@novell.com wrote:
On 04/07/11 11:29, Anurag Jain wrote:
Hello Noel,
I'm sending the inputwin.cxx with the changes I've made in
ScInputBargroup. Do not push it as of now. I'd be making some more
changes as mentioned in above mail before it can be pushed.
I guess it really isn't usable without a header file :-( I really was
looking for a patch that addressed the issues we talked about previously
that would allow me to at least start to try and integrate your work.
On Mon, Jul 4, 2011 at 3:53 PM, Anurag Jainanuragjain...@gmail.com
wrote:
Hello Noel,
Yes I have made some changes as you mentioned this weekend. There are
certain thing I'm not getting properly.
1: I'm able to toggle the height of ScMultiBar and ScInputBarGroup on
button click. But the increment happens inside the ScInputWindow i.e.
the excess window size do not appear. It toggles inside the
ScInputWindow. To make it look the height of complete panel should be
varied.So in order to do that will it be a good idea to add a
ScInputWindow object in ScInputBarGroup and use it to vary the whole
panel's height ?
hmm, it seems that somehow the toolbar doesn't resize as expected, don't
know why, might be worth doing some debugging in
vcl/source/window/toolbox.cxx
2: Also one more thing, when button is clicked twice , the position
window, and other formula images all disappears leaving a blank on
left side of panel. I guess the ScInputBarGroup changes its vertical
position. I tried resetting it always to (nLeft,0) but the LO did not
start for some reason. As of now I'm trying to fix that. I'll discuss
about these problems today in IRC and things required to be improved a
little bit before putting it in master branch.
no idea at all about that, it sounds like either a paint problem ( but
that's easy to check by forcing repaint but moving the window offscreen and
back ) or the controls have been repositioned somehow, again some debugging
of the size and position attributes of the toolbar items should give you an
idea
I am going to try to integrate the code as it was before whatever new work
you have done because I there is little time left, it is better to have some
code integrated rather than none :-). I didn't look at the inputwin.cxx that
you attached in any great detail but I don't like the name of the new
textbox ScMultiBar, it is I think misleading, I liked some of the other
alternatives you suggested better ( e.g. ScMultiText ).
I know I suggested that you rename the class to something new but I thought
maybe you could reuse the old one ( e.g. inherit from it ) to avoid
duplicating *all* the code there. My main concern was to separate the new
from old code ( without excessive logic ( if/then ) branches in the code
especially with the requirement of having some code in master )... I will
try to fix that when integrating the code
Noel
--
Anurag Jain
Final yr B.Tech CSE
SASTRA University
Thanjavur(T.N.)-613402
diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index dc12376..ede8585 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -172,12 +172,10 @@ ScInputWindow::ScInputWindow( Window* pParent, SfxBindings* pBind ) :
InsertItem ( SID_INPUT_EQUAL, IMAGE( SID_INPUT_EQUAL ), 0,4 );
InsertSeparator ( 5 );
InsertWindow( 7, aBarGroup, 0, 6 );
-// InsertWindow( 8, maScrollBar, 0, 8 );
+printf(Ctor ScInputWindow\n);
aWndPos .SetQuickHelpText( ScResId( SCSTR_QHELP_POSWND ) );
aWndPos.SetHelpId ( HID_INSWIN_POS );
-//aTextWindow.SetQuickHelpText( ScResId( SCSTR_QHELP_INPUTWND ) );
-//aTextWindow.SetHelpId ( HID_INSWIN_INPUT );
// kein SetHelpText, die Hilfetexte kommen aus der Hilfe
@@ -193,8 +191,7 @@ ScInputWindow::ScInputWindow( Window* pParent, SfxBindings* pBind ) :
SetHelpId( HID_SC_INPUTWIN ); // fuer die ganze Eingabezeile
aWndPos .Show();
-// maScrollBar .Show();
-aBarGroup .Show();
+//aBarGroup .Show();
pInputHdl = SC_MOD()-GetInputHdl( pViewSh, false );// use own handler even if ref-handler is set
if (pInputHdl)
@@ -487,15 +484,22 @@ void ScInputWindow::Select()
void ScInputWindow::Resize()
{
[Libreoffice] Shipping
Title: Dear Sirs, Dear Sirs, Thuong Phat Logistic Company Limited is a well-established and experience shipping forwarding company, and it is diversified total logistics provider with mainstream activities in forwarding / Customs clearance, interstate and local bonded / non-bonded trucking, international air / ocean freighting, etc.. Our office is established in Hochiminh city and we are providing network all over the world. With branches and associates, has many professional staffs and some of them are the Sales Marketing Department who are competitive salesmen and are knowledgeable to the shipping markets. We are very specialized in the flowing works: -Air and Sea Freight Forwarding - Customs brokerage / Clearance - Complete logistics provider - Personal effects/ Commercial Cargo handling - Packing, Crating - Door to door services - Import Export services -Consolidation - Project cargo handling - Inland-trucking We can assure you that we can handle and assist with all your shipment requirements both AIR and SEA shipments ensuring to give them more priorities and provide necessary follow ups as needed and required. We like to build up a strong biz relationship with your esteemed firm, and We are awaiting for a positive reply from you soon. Thanks best regards, Mr.Duc Thuong Phat Logistic Company Limited 114 Vo Duy Ninh Str., Ward 22, Binh Thanh District, Hochiminh City, Vietnam Tel: 848.629 44 322 / 38403347 Fax: 848.3 514 0711 E-mail: ad...@thuongphatlogistic.com Website: www.thuongphatlogistic.com Skype name: ngocducle YM: ngocducle75 Attn: Mr.Duc H/P: 84 908 103 114 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
