[Libreoffice-commits] Changes to 'feature/kill_String'
New branch 'feature/kill_String' available with the following commits: commit 1cd4a2b245410b0028a61c23da422490b9c87615 Author: Norbert Thiebaud nthieb...@gmail.com Date: Fri Nov 2 00:33:31 2012 -0500 String-OUString in unotools and fall-out Change-Id: I42176ac7cf34979be830d71f6b6dbcd56d37cbac commit 252fcdf74c22d91781f77b9cb444f4856c84ca56 Author: Norbert Thiebaud nthieb...@gmail.com Date: Mon Oct 29 16:00:29 2012 +0100 basic: kill String Change-Id: Ifa7b10de915ebd3d41b44f8ad8af46afdae73192 commit 63f77ddcdd265d1c5e9406da689bf55187c1b50a Author: Norbert Thiebaud nthieb...@gmail.com Date: Sat Oct 27 18:50:22 2012 +0200 WaE uno any conversion does not like int Change-Id: I54abaf2cd4dd896b39b4b6993d6d2f7c37f35e18 commit 0064a446f7361274d546642b6f092b22594f2350 Author: Norbert Thiebaud nthieb...@gmail.com Date: Sat Oct 27 15:11:45 2012 +0200 vcl: OUString for GetText() and SetText() and associated changes Change-Id: I3a4668a28fb7bc4119094dc11c788f38c0d4e7c8 commit 7c9aaff93508920351d3c59dadd2c1eb34f1de56 Author: Norbert Thiebaud nthieb...@gmail.com Date: Fri Oct 26 10:13:18 2012 +0200 basic: OUStringification of ddectrl Change-Id: I2af40d7c8117aff8ce62a8ea0eec579664f8bdeb commit ed2a0b8f3736602bfd072d3e0c8d8de590c55bfb Author: Norbert Thiebaud nthieb...@gmail.com Date: Fri Oct 26 09:26:36 2012 +0200 basic migration to OUString Change-Id: I1f9403174b3779801d91ba20d846191ed9a09eed commit 45aaa52228e35740e982866f58a61f566783db99 Author: Norbert Thiebaud nthieb...@gmail.com Date: Fri Oct 26 09:25:34 2012 +0200 basic: convert StepPAD to OUString Change-Id: I19d05f455767c973a47d0233b3af20af1ac3a20a commit 088d4658f363064990d03ca530ffbc4e50818b9f Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 23 23:04:35 2012 +0200 simplify and use OUString for StepLOADNC Change-Id: I92c86f672cc79506c2c7c56bb3402b4436f71c98 commit f4448ccb8fa3671f329529e9261960c5ddb7c355 Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 23 22:56:10 2012 +0200 basic: use OUString in DimAsNewRecoverItem Change-Id: Icfecff549161c3c429524549b65752671792a94f commit b3df9a023079b0bcabeaa9ab69dcd67157b5d675 Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 23 22:52:06 2012 +0200 basic: unnecessary round-trip via String Change-Id: I691a59b8ab9e6352a9257dac35b8e378e6ef9666 commit fdac3ab0edcaac590cce38a396de53bdd2a07bee Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 23 22:48:10 2012 +0200 basic: avoid StringOUString issue by by-passing them completely Change-Id: If741661f1151950a2180fa5c6504957b44a7e998 commit f96abee18872969b8188bff178dfe62753d1cd43 Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 23 21:09:43 2012 +0200 basic: clean-up String from eventatt.cxx Change-Id: I78f39310dbb0a024af4268f503a6150451f12778 commit f55ea2050b885f9ad652194f552208f2396583c5 Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 23 15:35:12 2012 +0200 basic: String - OUString in basicmanager Change-Id: I6607bfe8b6bf4d29ffd01cd88a19af5e53d616b5 commit 02cc2b5179d44dd3041a1e34057bb11c93246acf Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 23 08:57:23 2012 +0200 basic add a generic cppunitest to be exempended to do code coverage Change-Id: I6a05ae27cb1ee027995343bd4a79799f121e53a5 commit 7bd6b0b70d11b13e16b019338daa5fd38000f3fe Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 23 08:56:26 2012 +0200 svformatter already accept OUString input Change-Id: Icca8c40db4a4449876e115a0746319f3f893e846 commit 561e02e4587a9750e5161420ddffe3ea1c4426f5 Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 23 06:53:22 2012 +0200 gbuild: add beginning of gcov support Change-Id: If5b551c46de4afae2393a6320d08c191feafc358 commit 35d2800f8838130dd10ac7b3c47543ec9ab772ef Author: Norbert Thiebaud nthieb...@gmail.com Date: Mon Oct 22 21:01:14 2012 +0200 basic: use OUString internaly for error messages Change-Id: I9ea243f93b7477814037deca2f332c3359ce527d commit e39c86937ea944a604d512e70b4424c316bafa1a Author: Norbert Thiebaud nthieb...@gmail.com Date: Mon Oct 22 12:24:23 2012 +0200 cosmetic prep-work Change-Id: I732a8506a25f48c89cd0dc590e7305d355aa0762 commit c947c79c8e0a9b5ecbbaee2bb6582cfdb8470575 Author: Norbert Thiebaud nthieb...@gmail.com Date: Mon Oct 22 10:51:51 2012 +0200 use OUString for intermediary result in PrepareNumberFormatter Change-Id: I9435d926beb2fd7ebe350f61634673eed7228fbe commit 14107d6be0074b8131b147246daa7c9918d56409 Author: Norbert Thiebaud nthieb...@gmail.com Date: Mon Oct 22 10:40:32 2012 +0200 defensive code. use safe_delete Change-Id: Ibfd32dc1a8b8c3b75760a5f88d594795a8fa4101 commit cf5a8232df1ba348cf9cc5ea6211a6aefb85d918 Author: Norbert Thiebaud
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 52022, which changed state. Bug 52022 Summary: CONFIGURATION: Part of data in userdir is lost on 3.5 - 3.6 upgrade https://bugs.freedesktop.org/show_bug.cgi?id=52022 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sal/inc sd/source
sal/inc/sal/log-areas.dox |1 +
sd/source/filter/html/HtmlOptionsDialog.cxx |4 +---
sd/source/filter/html/htmlex.cxx|8 +---
3 files changed, 3 insertions(+), 10 deletions(-)
New commits:
commit 61128761b27beea9d6f550d8eaa23eefa2750108
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 2 08:24:23 2012 +
loplugin: unused UniStrings
Change-Id: Ia6a10bf30685f25a13c091f04566c62888524c94
diff --git a/sal/inc/sal/log-areas.dox b/sal/inc/sal/log-areas.dox
index 54597a5..777994e 100644
--- a/sal/inc/sal/log-areas.dox
+++ b/sal/inc/sal/log-areas.dox
@@ -59,6 +59,7 @@ certain functionality.
@section Draw
+@li @c sd
@li @c sd.fwk
@li @c sd.sls
@li @c sd.tools
diff --git a/sd/source/filter/html/HtmlOptionsDialog.cxx
b/sd/source/filter/html/HtmlOptionsDialog.cxx
index bc39ae8..cf2f9e4 100644
--- a/sd/source/filter/html/HtmlOptionsDialog.cxx
+++ b/sd/source/filter/html/HtmlOptionsDialog.cxx
@@ -261,9 +261,7 @@ void SdHtmlOptionsDialog::setSourceDocument( const
Reference XComponent xDoc
throw ( IllegalArgumentException, RuntimeException )
{
// try to set the corresponding metric unit
-String aConfigPath;
-Reference XServiceInfo xServiceInfo
-( xDoc, UNO_QUERY );
+Reference XServiceInfo xServiceInfo(xDoc, UNO_QUERY);
if ( xServiceInfo.is() )
{
if ( xServiceInfo-supportsService(
com.sun.star.presentation.PresentationDocument ) )
diff --git a/sd/source/filter/html/htmlex.cxx b/sd/source/filter/html/htmlex.cxx
index babb586..f63fb5e 100644
--- a/sd/source/filter/html/htmlex.cxx
+++ b/sd/source/filter/html/htmlex.cxx
@@ -877,7 +877,6 @@ void HtmlExport::ExportWebCast()
CreateFileNames();
-String aEmpty;
if(maCGIPath.Len() == 0)
maCGIPath.Assign( sal_Unicode('.') );
@@ -890,7 +889,6 @@ void HtmlExport::ExportWebCast()
}
else
{
- String aEmpty2;
if(maURLPath.Len() == 0)
maURLPath.Assign( sal_Unicode('.') );
@@ -1858,9 +1856,6 @@ bool HtmlExport::CreateHtmlForPresPages()
// =
bool HtmlExport::CreateContentPage()
{
-// Parameter
-String aEmpty;
-
if( mbDocColors )
SetDocColors();
@@ -2287,9 +2282,8 @@ bool HtmlExport::CreateFrames()
if(mbNotes)
{
-String aEmpty;
String aSlash( RTL_CONSTASCII_USTRINGPARAM( // ) );
-aFunction.SearchAndReplaceAll( aSlash, aEmpty);
+aFunction.SearchAndReplaceAll(aSlash, OUString());
}
// substitute HTML file extension
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sdext/source
sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx |4 +++- sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx |8 +--- 2 files changed, 8 insertions(+), 4 deletions(-) New commits: commit 1296db324d5962ff904c0ed488a62132dd36a66f Author: Rene Engelhard r...@debian.org Date: Wed Oct 31 18:00:18 2012 +0100 fix sdext build with poppler = 0.19.x Conflicts: configure.ac Change-Id: I655e8e15c7f7a8c292b3a1820ee48c29e847d05a Signed-off-by: Tomas Chvatal tchva...@suse.cz diff --git a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx index 87c0ab2..9d38e9b 100644 --- a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx +++ b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx @@ -497,7 +497,9 @@ void PDFOutDev::endPage() printf(endPage\n); } -#if POPPLER_CHECK_VERSION(0, 17, 0) +#if POPPLER_CHECK_VERSION(0, 19, 0) +void PDFOutDev::processLink(AnnotLink *link) +#elif POPPLER_CHECK_VERSION(0, 17, 0) void PDFOutDev::processLink(AnnotLink *link, Catalog *) #else void PDFOutDev::processLink(Link* link, Catalog*) diff --git a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx index bba8f58..1911d57 100644 --- a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx +++ b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx @@ -201,10 +201,12 @@ namespace pdfi // virtual void cvtDevToUser(double dx, double dy, double *ux, double *uy); // virtual void cvtUserToDev(double ux, double uy, int *dx, int *dy); -#if POPPLER_CHECK_VERSION(0, 17, 0) -virtual void processLink(AnnotLink *link, Catalog *catalog); -#else //- link borders + #if POPPLER_CHECK_VERSION(0, 19, 0) +virtual void processLink(AnnotLink *link); +#elif POPPLER_CHECK_VERSION(0, 17, 0) + virtual void processLink(AnnotLink *link, Catalog *catalog); +#else virtual void processLink(Link *link, Catalog *catalog); #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: GTK theming: oxygen-gtk support broken
Hi Ruslan, On 01.11.2012 23:48, Ruslan Kabatsayev wrote: Some time after my commits, which enabled almost fully correct oxygen-gtk support (latest commit was on Jul 8 2012), this support was broken. See screenshots at [1], [2], [3] and [4] for details. The problem at [1] is due to the following commits https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=50a20f94 https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=681e894b which take logic from _gtk_entry_get_borders http://git.gnome.org/browse/gtk+/tree/gtk/gtkentry.c?h=gtk-2-24#n2874 I have no idea of what is wrong with those commits. Regards, Ivan [1] Edit field and combo button sizes mismatch: http://i.imgur.com/lnvfS.png [2] Background gradient not rendered: http://i.imgur.com/lRPLY.png [3] Text line entry clips text to the left too much http://i.imgur.com/sV10D.png [4] Menu expansion arrows are clipped at top: http://i.imgur.com/Gn67Z.png ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] detect even more memory mismanagement on glibc
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/940 -- To view, visit https://gerrit.libreoffice.org/940 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idba21b12582e9ae7d240d9d3527f9ac5893252f7 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu Gerrit-Reviewer: Caolán McNamara caol...@redhat.com Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu Gerrit-Reviewer: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Change in core[libreoffice-3-6]: Don't abort when column has no (Catalog|Schema|Table)Name
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/968 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/968/1 Don't abort when column has no (Catalog|Schema|Table)Name Especially since the rest of the function is prepared to handle no/empty (Catalog|Schema|Table)Name. Change-Id: Ic0bb59ead5789e671c90887ef850588f4924f5e7 --- M dbaccess/source/core/api/SingleSelectQueryComposer.cxx 1 file changed, 6 insertions(+), 3 deletions(-) -- To view, visit https://gerrit.libreoffice.org/968 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0bb59ead5789e671c90887ef850588f4924f5e7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: solenv/bin
solenv/bin/linkoo | 13 -
1 file changed, 13 deletions(-)
New commits:
commit b76d45e3153f47125f841c8d6c5827291d1536b8
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Fri Nov 2 11:04:47 2012 +0100
Revert detect even more memory mismanagement on glibc
Intended to push a whole series of things, but *not* this one.
Was still under discussion at gerrit.
This reverts commit fcee486849c2e5a07c0eef630beb427742f54d8e.
diff --git a/solenv/bin/linkoo b/solenv/bin/linkoo
index 7820234..c97df91 100755
--- a/solenv/bin/linkoo
+++ b/solenv/bin/linkoo
@@ -54,19 +54,6 @@ export STAR_RESOURCEPATH=$thisdir/resource
export SAL_DISABLE_FLOATGRAB=1
export G_SLICE=always-malloc
export MALLOC_CHECK_=2
-#get some random value between 0 and 255
-rndbyte=$RANDOM
-if test -n ${rndbyte}; then
- rndbyte=$(( $rndbyte % 256 ))
-else
- if test -r /dev/urandom; then
-rndbyte=$(dd if=/dev/urandom bs=1 count=1 2/dev/null | od -tu1 | cut -s
-d -f2)
- else
-rndbyte=$(( (( $(date +%S) + 1 ) * $$ ) % 255 ))
- fi
-fi
-export MALLOC_PERTURB_=${rndbyte}
-unset rndbyte
export OOO_DISABLE_RECOVERY=1
export SAL_ALLOW_LINKOO_SYMLINKS=1
';
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: connectivity/source
connectivity/source/drivers/mork/MColumns.cxx | 13 ++---
connectivity/source/drivers/mork/MPreparedStatement.cxx |5 -
2 files changed, 14 insertions(+), 4 deletions(-)
New commits:
commit faddfd35e2c11554a6892300c3d3540ea4e6be22
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Fri Nov 2 11:13:12 2012 +0100
connectivity: port mork driver to new OColumn, too
Change-Id: I2433bd2cc289b9ded1c825ea3dbe1db2ccf4bae9
diff --git a/connectivity/source/drivers/mork/MColumns.cxx
b/connectivity/source/drivers/mork/MColumns.cxx
index 852bb4d..d35151d 100644
--- a/connectivity/source/drivers/mork/MColumns.cxx
+++ b/connectivity/source/drivers/mork/MColumns.cxx
@@ -42,8 +42,12 @@ using namespace ::com::sun::star::lang;
sdbcx::ObjectType OColumns::createObject(const ::rtl::OUString _rName)
{
-Reference XResultSet xResult =
m_pTable-getConnection()-getMetaData()-getColumns(Any(),
-m_pTable-getSchema(),m_pTable-getTableName(),_rName);
+const Any aCatalog;
+const ::rtl::OUString sCatalogName;
+const ::rtl::OUString sSchemaName(m_pTable-getSchema());
+const ::rtl::OUString sTableName(m_pTable-getTableName());
+Reference XResultSet xResult =
m_pTable-getConnection()-getMetaData()-getColumns(
+aCatalog, sSchemaName, sTableName, _rName);
sdbcx::ObjectType xRet = NULL;
if(xResult.is())
@@ -65,7 +69,10 @@ sdbcx::ObjectType OColumns::createObject(const
::rtl::OUString _rName)
nPrec,
xRow-getInt(9),
nType,
-
sal_False,sal_False,sal_False,sal_True);
+
sal_False,sal_False,sal_False,sal_True,
+sCatalogName,
+sSchemaName,
+sTableName));
xRet = pRet;
break;
}
diff --git a/connectivity/source/drivers/mork/MPreparedStatement.cxx
b/connectivity/source/drivers/mork/MPreparedStatement.cxx
index c34de94..803b960 100644
--- a/connectivity/source/drivers/mork/MPreparedStatement.cxx
+++ b/connectivity/source/drivers/mork/MPreparedStatement.cxx
@@ -442,7 +442,10 @@ size_t OPreparedStatement::AddParameter(OSQLParseNode *
pParameter, const Refere
,sal_False
,sal_False
,sal_False
-
,m_pSQLIterator-isCaseSensitive());
+
,m_pSQLIterator-isCaseSensitive()
+,::rtl::OUString()
+,::rtl::OUString()
+,::rtl::OUString());
m_xParamColumns-get().push_back(xParaColumn);
return nParameter;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: connectivity/source
connectivity/source/drivers/mork/MColumns.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f2a7c93d7b970b654c41140bb6e24eb967698982 Author: Caolán McNamara caol...@redhat.com Date: Fri Nov 2 10:20:08 2012 + stray ) Change-Id: Ib0573685773745ac8698d76faa5ebe2cd1a109b3 diff --git a/connectivity/source/drivers/mork/MColumns.cxx b/connectivity/source/drivers/mork/MColumns.cxx index d35151d..22a2dd7 100644 --- a/connectivity/source/drivers/mork/MColumns.cxx +++ b/connectivity/source/drivers/mork/MColumns.cxx @@ -72,7 +72,7 @@ sdbcx::ObjectType OColumns::createObject(const ::rtl::OUString _rName) sal_False,sal_False,sal_False,sal_True, sCatalogName, sSchemaName, -sTableName)); +sTableName); xRet = pRet; break; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source
sc/source/core/data/column.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4499ed3b610ee9c7762ed5b9c082a37e48d98c8e Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Nov 1 20:36:25 2012 -0400 Remove the correct range, or else maItems would end up with invalid pointer. nStopPos is non-inclusive, and STL's erase() method also expects a non-inclusive end position (like any other STL methods do). It's wrong to -1 here which would end up not erasing the last element containing a pointer to the deleted cell instance. Change-Id: Ic09ab4a6bb03d0f56bb854a91bf93a99be867116 diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx index eebb17a..79bf31f 100644 --- a/sc/source/core/data/column.cxx +++ b/sc/source/core/data/column.cxx @@ -1555,7 +1555,7 @@ void ScColumn::MoveTo(SCROW nStartRow, SCROW nEndRow, ScColumn rCol) rAddress.SetRow( maItems[i].nRow ); pDocument-AreaBroadcast( aHint ); } -maItems.erase(maItems.begin() + nStartPos, maItems.begin() + nStopPos - 1); +maItems.erase(maItems.begin() + nStartPos, maItems.begin() + nStopPos); } pNoteCell-Delete(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PUSHED][REVIEW 3-6] Fix for Calc crasher
On 02/11/12 00:42, Kohei Yoshida wrote: Hi there, I'd like the attached patch pushed to the 3-6 branch. Without this patch, doing the following 1. Create a new Calc document. 2. Type some stuff into Cell D5. 3. Move the cursor to Cell C5. 4. Ctrl-+ to launch the Insert Cells dialog. Select Shift cell right and hit OK. 5. Ctrl-Z to undo. Would crash Calc right away. I'm actually surprised this has not been reported in bugzilla yet. Or perhaps it's there but never confirmed? I don't know which is the case. I just happened to have noticed this while testing Calc for something else. yup, makes sense to me, pushed it Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: connectivity/source
connectivity/source/drivers/kab/KColumns.cxx | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
New commits:
commit e3b12f1762c4a7237e0c085484359dbe47ca76e0
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Fri Nov 2 11:52:35 2012 +0100
connectivity: port kab driver to new OColumn, too
Change-Id: I19657ee92b5d0e1e51d11dd2aa69191fdb0f4f50
diff --git a/connectivity/source/drivers/kab/KColumns.cxx
b/connectivity/source/drivers/kab/KColumns.cxx
index a047d1a..5ab9598 100644
--- a/connectivity/source/drivers/kab/KColumns.cxx
+++ b/connectivity/source/drivers/kab/KColumns.cxx
@@ -37,11 +37,12 @@ using namespace ::com::sun::star::lang;
// -
sdbcx::ObjectType KabColumns::createObject(const ::rtl::OUString _rName)
{
+const Any aCatalog;
+const ::rtl::OUString sCatalogName;
+const ::rtl::OUString sSchemaName(m_pTable-getSchema());
+const ::rtl::OUString sTableName(m_pTable-getTableName());
Reference XResultSet xResult =
m_pTable-getConnection()-getMetaData()-getColumns(
-Any(),
-m_pTable-getSchema(),
-m_pTable-getTableName(),
-_rName);
+aCatalog, sSchemaName, sTableName, _rName);
sdbcx::ObjectType xRet = NULL;
if (xResult.is())
@@ -64,7 +65,10 @@ sdbcx::ObjectType KabColumns::createObject(const
::rtl::OUString _rName)
sal_False,
sal_False,
sal_False,
-sal_True);
+sal_True,
+sCatalogName,
+sSchemaName,
+sTableName);
xRet = pRet;
break;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - connectivity/source dbaccess/source
connectivity/source/drivers/macab/MacabColumns.cxx | 14 +-
dbaccess/source/core/api/definitioncolumn.cxx |1 +
2 files changed, 10 insertions(+), 5 deletions(-)
New commits:
commit 3b6ba84a21f90bd161cf2445c62c71124513
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Fri Nov 2 12:24:35 2012 +0100
connectivity: port macab driver to new OColumn, too
Change-Id: I88a64a19d9f2812a77f0a71f31fe8314732ec44f
diff --git a/connectivity/source/drivers/macab/MacabColumns.cxx
b/connectivity/source/drivers/macab/MacabColumns.cxx
index 4d0b064..107ab45 100644
--- a/connectivity/source/drivers/macab/MacabColumns.cxx
+++ b/connectivity/source/drivers/macab/MacabColumns.cxx
@@ -37,11 +37,12 @@ using namespace ::com::sun::star::lang;
// -
sdbcx::ObjectType MacabColumns::createObject(const ::rtl::OUString _rName)
{
+const Any aCatalog;
+const ::rtl::OUString sCatalogName;
+const ::rtl::OUString sSchemaName(m_pTable-getSchema());
+const ::rtl::OUString sTableName(m_pTable-getTableName());
Reference XResultSet xResult =
m_pTable-getConnection()-getMetaData()-getColumns(
-Any(),
-m_pTable-getSchema(),
-m_pTable-getTableName(),
-_rName);
+aCatalog, sSchemaName, sTableName, _rName);
sdbcx::ObjectType xRet = NULL;
if (xResult.is())
@@ -64,7 +65,10 @@ sdbcx::ObjectType MacabColumns::createObject(const
::rtl::OUString _rName)
sal_False,
sal_False,
sal_False,
-sal_True);
+sal_True,
+sCatalogName,
+sSchemaName,
+sTableName);
xRet = pRet;
break;
}
commit 25a868011c15cb51e38566deff116b01fa8419cf
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Fri Nov 2 12:21:47 2012 +0100
include stl headers for used features
Change-Id: I6b0d3b3feea88b6e3605f751df9e1154e4231127
diff --git a/dbaccess/source/core/api/definitioncolumn.cxx
b/dbaccess/source/core/api/definitioncolumn.cxx
index e8e0acd..df9a92a 100644
--- a/dbaccess/source/core/api/definitioncolumn.cxx
+++ b/dbaccess/source/core/api/definitioncolumn.cxx
@@ -17,6 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include bitset
#include apitools.hxx
#include dbastrings.hrc
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Remove commented code from dtrans
Arnaud Versini has abandoned this change. Change subject: Remove commented code from dtrans .. Patch Set 2: Abandoned keep it in place for a future uncomment of this code. -- To view, visit https://gerrit.libreoffice.org/962 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1ef4abb5b561107df257279708f619a1715e72c2 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: connectivity/workben
connectivity/workben/postgresql/ddl.py | 179 --- connectivity/workben/postgresql/main.py | 84 - connectivity/workben/postgresql/makefile.mk | 97 -- connectivity/workben/postgresql/metadata.py | 145 - connectivity/workben/postgresql/preparedstatement.py | 222 -- connectivity/workben/postgresql/sdbcx.py | 300 --- connectivity/workben/postgresql/statement.py | 271 - 7 files changed, 1298 deletions(-) New commits: commit 3cdd4964f086f2c771237be7ad70b68f6e9e92cc Author: Caolán McNamara caol...@redhat.com Date: Fri Nov 2 12:19:00 2012 + ditch SISSL using workben code Change-Id: I9a55180e0a0ef1bc14ce7c84265fb3d5508bd541 diff --git a/connectivity/workben/postgresql/ddl.py b/connectivity/workben/postgresql/ddl.py deleted file mode 100644 index 151f0b8..000 --- a/connectivity/workben/postgresql/ddl.py +++ /dev/null @@ -1,179 +0,0 @@ -#* -# -# The Contents of this file are made available subject to the terms of -# either of the following licenses -# -# - GNU Lesser General Public License Version 2.1 -# - Sun Industry Standards Source License Version 1.1 -# -# Sun Microsystems Inc., October, 2000 -# -# GNU Lesser General Public License Version 2.1 -# = -# Copyright 2000 by Sun Microsystems, Inc. -# 901 San Antonio Road, Palo Alto, CA 94303, USA -# -# This library is free software; you can redistribute it and/or -# modify it under the terms of the GNU Lesser General Public -# License version 2.1, as published by the Free Software Foundation. -# -# This library is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -# Lesser General Public License for more details. -# -# You should have received a copy of the GNU Lesser General Public -# License along with this library; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# -# -# Sun Industry Standards Source License Version 1.1 -# = -# The contents of this file are subject to the Sun Industry Standards -# Source License Version 1.1 (the License); You may not use this file -# except in compliance with the License. You may obtain a copy of the -# License at http://www.openoffice.org/license.html. -# -# Software provided under this License is provided on an AS IS basis, -# WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, -# WITHOUT LIMITATION, WARRANTIES THAT THE SOFTWARE IS FREE OF DEFECTS, -# MERCHANTABLE, FIT FOR A PARTICULAR PURPOSE, OR NON-INFRINGING. -# See the License for the specific provisions governing your rights and -# obligations concerning the Software. -# -# The Initial Developer of the Original Code is: Ralph Thomas -# -# Copyright: 2000 by Sun Microsystems, Inc. -# -# All Rights Reserved. -# -# Contributor(s): Ralph Thomas, Joerg Budischewski -# -#* -from com.sun.star.sdbc import SQLException -import sys - -def dumpResultSet( rs ): -meta = rs.getMetaData() -for i in range(1, meta.getColumnCount()+1): -sys.stdout.write(meta.getColumnName( i ) + \t) -sys.stdout.write( \n ) -while rs.next(): -for i in range( 1, meta.getColumnCount()+1): -sys.stdout.write( rs.getString( i ) + \t ) -sys.stdout.write( \n ) -rs.beforeFirst() - - - -def executeIgnoringException( stmt, sql ): -try: -stmt.executeUpdate(sql) -except SQLException: -pass - -def cleanGroupsAndUsers( stmt ): -rs = stmt.executeQuery(SELECT groname FROM pg_group WHERE groname LIKE 'pqsdbc_%' ) -stmt2 = stmt.getConnection().createStatement() -while rs.next(): -stmt2.executeUpdate(DROP GROUP + rs.getString(1) ) - -rs.close() -rs = stmt.executeQuery( SELECT usename FROM pg_user WHERE usename LIKE 'pqsdbc_%' ) -while rs.next(): -stmt2.executeUpdate( DROP USER + rs.getString(1) ) - - - - -def executeDDLs( connection ): - -stmt = connection.createStatement() - - -executeIgnoringException( stmt, DROP VIEW customer2 ) -executeIgnoringException( stmt, DROP TABLE orderpos ) -executeIgnoringException( stmt, DROP TABLE ordertab ) -executeIgnoringException( stmt, DROP TABLE product ) -executeIgnoringException( stmt, DROP TABLE customer ) -executeIgnoringException( stmt, DROP TABLE blub ) -executeIgnoringException( stmt, DROP TABLE foo ) -executeIgnoringException( stmt, DROP TABLE nooid ) -executeIgnoringException( stmt, DROP TABLE nooid2 ) -
Re: [REVIEW 3-6] Fix for Calc crasher
Le 02/11/2012 01:42, Kohei Yoshida a écrit : Hi there, I'd like the attached patch pushed to the 3-6 branch. Without this patch, doing the following 1. Create a new Calc document. 2. Type some stuff into Cell D5. 3. Move the cursor to Cell C5. 4. Ctrl-+ to launch the Insert Cells dialog. Select Shift cell right and hit OK. 5. Ctrl-Z to undo. Would crash Calc right away. I'm actually surprised this has not been reported in bugzilla yet. Or perhaps it's there but never confirmed? I don't know which is the case. I just happened to have noticed this while testing Calc for something else. Hi Kohei, I do not reproduce the crash with LO 3.6.3.2 under Ubuntu 12.04 x86_64 But I reproduce the crash on LO 3.6.4.0+ if I revert your commit. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
minutes of ESC call ...
* Present: + Kendy, Stephan, Eike, Markus, Michael M, Petr, Lubos, Norbert, Thorsten, Caolan, Ahmad. + bad week for US overlap; regrets from Joel etc. * Completed Action Items + issues to look into if we can + fdo#34548 - review Michael's patch (Thorsten) + not happy, not pushing + get more details wrt. new hardware connect (Norbert / Sophie) + ongoing. + re-order / update the HardHacks page (Joel) + adding fdo#40594 - to the live list of five. * Pending Action Items + create a new AmbitiousHacks wiki page, based on GSOC page (Michael M) + audit set of new / built-in fonts (Caolan) + poke UX advise wrt. how to improve color management UI team (Markus) + issues to look into if we can + fdo#55360 - mac specific text issue (Thorsten) + fdo#51023 - impress DD crasher - (Radek) + set updater to get 3.5.0..2 - 3.6.2 (Kendy) + instead re-direct to 3.6.3 - but delay until tomorrow to avoid un-synched mirror load. + create script / suggestions to parse Meeks minutes (Bjoern) + font bundling and gerrit fun with Astron (Andras) + patch / improvements coming from Astron + provide a new palette based on Tango (Alex?) + minimal triage for good mentors for proposed easy hacks (Bjoern) + setup call for designs for FOSDEM T-shirts (Astron) + needs feedback from Kendy - Mirek * Release Engineering update (Petr) + Petr back and mostly recovered from honeymoon + 3.6.3 retrospective + sadly missing a11y fix queued for 3.6.4 AI: + add a11y issue to release notes (Thorsten) + thanks to all for fixing reviews + 3.6.4 rc1 branch deadline is Nov 12th + on-line update / full switch-over go/no-go + delay for one week. + 3.7 timeline: Dec 3rd - week 47 + feature-freeze 4 weeks out. * Motah introduction (Ahmad) + KACST - government sponsored institute + first project to improve Arabic LibreOffice support + fix bugs, errors around RTL, Arabic translation etc. + feature work planned further out + Arabic wiki + documentation work is done + open-source engineer, on LibreOffice for four months * 4.0 decision + preference for simple rules, not specifics (Kendy) + minimise the impact on all users / ext'n developers + smaller ongoing changes - with bigger revisions / compatibility code, deprecations etc. + more details / solvable individual case-by-case issues to be discussed on the lists. + proceeding with plans. + two different issues (Stephan) + handling incompatibility in 4.0 ? + are we in-time to switch 3.7 to 4.0 ? + are we in-time to switch to 4.0 ? + never a good time to switch with incremental time-based releases (Kendy) + hence ~never having a big bang, introducing small changes over time. + why decide now, not at the outset of the release ? if we know six months in advance - we'll release 4.0, more room for manoever. + we've discussed this for months with no decision + now we agree - what's in there / how to break it why not delay one release ? (Norbert) + had a plan for this for over a year - cf. wiki page (Kendy) + if we don't do big breakage - why wait ? (Michael) + ABI breakage is not a binary thing (mst, Norbert) + not able to do the work in the wiki in in 4 weeks (mst) + ~none of us has done much of the 4.0 page yet (Stephan) + are there are more things to do for a 4.0 ? (Stephan) + higher quality / better feature-set. + alternative - summer release of 4.0 + still have issues getting it all done, can we can continue to break things in 4.1 ? + is it better to have a 4.0 with lots of new features and little breakage ? or not. + desire to keep changes as small as possible whatever (Stephan) + user-installation changes required (Stephan) + can we clean that up in advance ? + should we stick with the /3 directory ? + how about berkelydb removal - does that break things anyway ? + we can't do all the changes we want to do in one release (Lubos) + could we plan to do 5.0 after a couple of releases ? + if so engrave those dates in stone to avoid
[Libreoffice-commits] .: ucb/source
ucb/source/ucp/webdav/SerfInputStream.cxx |6 +++---
ucb/source/ucp/webdav/SerfSession.cxx |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 62e18c4f3c202c5caca6ed5efa61c4e1985240b9
Author: Arnaud Versini arnaud.vers...@gmail.com
Date: Thu Nov 1 17:47:44 2012 +0100
Use memcpy instead of rtl_copyMemory in ucb
Change-Id: I1bdb02c6d607a10fee03d3044bad20cb811e9939
Reviewed-on: https://gerrit.libreoffice.org/961
Reviewed-by: Arnaud Versini arnaud.vers...@gmail.com
Tested-by: Arnaud Versini arnaud.vers...@gmail.com
diff --git a/ucb/source/ucp/webdav/SerfInputStream.cxx
b/ucb/source/ucp/webdav/SerfInputStream.cxx
index d8c7222..a6b97eb 100644
--- a/ucb/source/ucp/webdav/SerfInputStream.cxx
+++ b/ucb/source/ucp/webdav/SerfInputStream.cxx
@@ -22,7 +22,7 @@
// MARKER(update_precomp.py): autogen include statement, do not remove
#include precompiled_ucb.hxx
#include SerfInputStream.hxx
-#include rtl/memory.h
+#include string.h
using namespace cppu;
using namespace rtl;
@@ -54,7 +54,7 @@ SerfInputStream::~SerfInputStream( void )
void SerfInputStream::AddToStream( const char * inBuf, sal_Int32 inLen )
{
mInputBuffer.realloc( sal::static_int_castsal_Int32(mLen) + inLen );
-rtl_copyMemory( mInputBuffer.getArray() + mLen, inBuf, inLen );
+memcpy( mInputBuffer.getArray() + mLen, inBuf, inLen );
mLen += inLen;
}
@@ -91,7 +91,7 @@ sal_Int32 SAL_CALL SerfInputStream::readBytes(
aData.realloc( theBytes2Read );
// Write the data
-rtl_copyMemory(
+memcpy(
aData.getArray(), mInputBuffer.getConstArray() + mPos, theBytes2Read );
// Update our stream position for next time
diff --git a/ucb/source/ucp/webdav/SerfSession.cxx
b/ucb/source/ucp/webdav/SerfSession.cxx
index bd858b4..16984f0 100644
--- a/ucb/source/ucp/webdav/SerfSession.cxx
+++ b/ucb/source/ucp/webdav/SerfSession.cxx
@@ -1509,7 +1509,7 @@ SerfSession::getDataFromInputStream(
rData.realloc( nPos + nRead );
aBuffer.realloc( nRead );
-rtl_copyMemory( (void*)( rData.getArray() + nPos ),
+memcpy( (void*)( rData.getArray() + nPos ),
(const void*)aBuffer.getConstArray(),
nRead );
nPos += nRead;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Use memcpy instead of rtl_copyMemory in ucb
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/961 Approvals: Arnaud Versini: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/961 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bdb02c6d607a10fee03d3044bad20cb811e9939 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - configure.ac oowintool
configure.ac |2 +- oowintool|2 -- 2 files changed, 1 insertion(+), 3 deletions(-) New commits: commit 85b7df9800d8aded628a424ec7e19220a2967966 Author: Tor Lillqvist tlillqv...@suse.com Date: Fri Nov 2 15:22:37 2012 +0200 Bin help for nonexistent switch --msvc-find-msms-vc100 Change-Id: I14fb49acdbd242c0e68957ec72cba558df273c4a diff --git a/oowintool b/oowintool index c81d81f..f32113d 100755 --- a/oowintool +++ b/oowintool @@ -47,8 +47,6 @@ sub print_syntax() print commands:\n; print--msvc-ver - print version of MSVC eg. 6.0\n; print--msvc-copy-dlls dest - copy msvc[pr]??.dlls into dest/msvcp??/\n; -print--msvc-find-msms-vc100 - exit with 0 if Microsoft_VC100_CRT_x86.msm\n; -print is available\n; print--msvc-copy-msms dest - copy mscrt merge modules to dest/msm90/\n; print--msvc-copy-msms-64 ds- copy the x64 mscrt merge modules to ds/msm90/\n; print--msvc-productdir - print productdir\n; commit 6474d8cb2e9d3a890a10593b4d6213f6895026e8 Author: Tor Lillqvist tlillqv...@suse.com Date: Fri Nov 2 12:46:25 2012 +0200 There is no --with-zip-home option Change-Id: I560b4504263c824154f488aab2fa62c1d26e03bb diff --git a/configure.ac b/configure.ac index e1598e7..9a9689a 100644 --- a/configure.ac +++ b/configure.ac @@ -9347,7 +9347,7 @@ dnl === AC_PATH_PROG(ZIP, zip) test -z $ZIP AC_MSG_ERROR([zip is required]) if ! $ZIP --filesync /dev/null 2/dev/null /dev/null; then -AC_MSG_ERROR([Zip version 3.0 or newer is required to build, please install or use --with-zip-home],,) +AC_MSG_ERROR([Zip version 3.0 or newer is required to build, please install it and make sure it is the one found first in PATH],,) fi AC_PATH_PROG(UNZIP, unzip) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [REVIEW 3-6] Fix for Calc crasher
Hi JB, On Fri, Nov 2, 2012 at 8:24 AM, Jean-Baptiste Faure jbf.fa...@sud-ouest.org wrote: Le 02/11/2012 01:42, Kohei Yoshida a écrit : Hi there, I'd like the attached patchpushed to the 3-6 branch. Without this patch, doing the following 1. Create a new Calc document. 2. Type some stuff into Cell D5. 3. Move the cursor to Cell C5. 4. Ctrl-+ to launch the Insert Cells dialog. Select Shift cell right and hit OK. 5. Ctrl-Z to undo. Would crash Calc right away. Hi Kohei, I do not reproduce the crash with LO 3.6.3.2 under Ubuntu 12.04 x86_64 But I reproduce the crash on LO 3.6.4.0+ if I revert your commit. So, this is a memory corruption, where a stale pointer would point to a non-existent cell instance. That means that sometimes you may get lucky and don't see the crash if the memory space the pointer is pointing to contains the right value by chance. I think with the version of 3.6.3.2 that you used you just got lucky. That wrong code had been there way before the initial 3.6.0 release; it's not something that was introduced between the 3.6.x releases. But even if you couldn't reproduce this very crasher, it would have caused other, hard-to-reproduce crasher somewhere else. Anyway, thanks for your test. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: cui/source svx/inc
cui/source/dialogs/cuifmsearch.cxx |2 +- cui/source/factory/dlgfact.cxx |2 +- cui/source/factory/dlgfact.hxx |2 +- cui/source/inc/cuifmsearch.hxx |2 +- svx/inc/svx/svxdlg.hxx |2 +- 5 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 89519528563a0e740fe22acaf9ab90f83af99695 Author: Ricardo Montania rica...@linuxafundo.com.br Date: Thu Nov 1 16:53:51 2012 -0200 fdo#38838 UniString replacement Change-Id: I1323b2caf395c10b34e7467284402c0e3082f6a7 Reviewed-on: https://gerrit.libreoffice.org/965 Tested-by: Caolán McNamara caol...@redhat.com Reviewed-by: Caolán McNamara caol...@redhat.com diff --git a/cui/source/dialogs/cuifmsearch.cxx b/cui/source/dialogs/cuifmsearch.cxx index 0e6ace4..225523b 100644 --- a/cui/source/dialogs/cuifmsearch.cxx +++ b/cui/source/dialogs/cuifmsearch.cxx @@ -83,7 +83,7 @@ void FmSearchDialog::initCommon( const Reference XResultSet _rxCursor ) } // -FmSearchDialog::FmSearchDialog(Window* pParent, const UniString sInitialText, const ::std::vector String _rContexts, sal_Int16 nInitialContext, +FmSearchDialog::FmSearchDialog(Window* pParent, const OUString sInitialText, const ::std::vector String _rContexts, sal_Int16 nInitialContext, const Link lnkContextSupplier) :ModalDialog(pParent, CUI_RES(RID_SVXDLG_SEARCHFORM)) ,m_flSearchFor (this, CUI_RES(FL_SEARCHFOR)) diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx index ebd3d64..41124d6 100644 --- a/cui/source/factory/dlgfact.cxx +++ b/cui/source/factory/dlgfact.cxx @@ -1503,7 +1503,7 @@ AbstractSvxHpLinkDlg * AbstractDialogFactory_Impl::CreateSvxHpLinkDlg (Window* p } AbstractFmSearchDialog* AbstractDialogFactory_Impl::CreateFmSearchDialog(Window* pParent, //add for FmSearchDialog -const String strInitialText, +const OUString strInitialText, const ::std::vector String _rContexts, sal_Int16 nInitialContext, const Link lnkContextSupplier) diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx index d85f923..3c97f2b 100644 --- a/cui/source/factory/dlgfact.hxx +++ b/cui/source/factory/dlgfact.hxx @@ -709,7 +709,7 @@ public: SfxBindings* pBindings, sal_uInt32 nResId); virtual AbstractFmSearchDialog* CreateFmSearchDialog(Window* pParent, //add for FmSearchDialog -const String strInitialText, +const OUString strInitialText, const ::std::vector String _rContexts, sal_Int16 nInitialContext, const Link lnkContextSupplier); diff --git a/cui/source/inc/cuifmsearch.hxx b/cui/source/inc/cuifmsearch.hxx index 36e5e0d..a220495 100644 --- a/cui/source/inc/cuifmsearch.hxx +++ b/cui/source/inc/cuifmsearch.hxx @@ -114,7 +114,7 @@ public: (of course needed : the string number i in strUsedFields of a context must correspond with the interface number i in the arrFields of the context) */ -FmSearchDialog(Window* pParent, const String strInitialText, const ::std::vector String _rContexts, sal_Int16 nInitialContext, +FmSearchDialog(Window* pParent, const OUString strInitialText, const ::std::vector String _rContexts, sal_Int16 nInitialContext, const Link lnkContextSupplier); virtual ~FmSearchDialog(); diff --git a/svx/inc/svx/svxdlg.hxx b/svx/inc/svx/svxdlg.hxx index fdb75d3..05c952d 100644 --- a/svx/inc/svx/svxdlg.hxx +++ b/svx/inc/svx/svxdlg.hxx @@ -429,7 +429,7 @@ public: SfxBindings* pBindings, sal_uInt32 nResId)=0; virtual AbstractFmSearchDialog* CreateFmSearchDialog(Window* pParent, //add for FmSearchDialog -const String strInitialText, +const OUString strInitialText, const ::std::vector String _rContexts, sal_Int16 nInitialContext, const Link lnkContextSupplier)=0; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org
[PUSHED] fdo#38838 UniString replacement
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/965 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/965 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1323b2caf395c10b34e7467284402c0e3082f6a7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br Gerrit-Reviewer: Caolán McNamara caol...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: i18npool/source
i18npool/source/localedata/data/he_IL.xml | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 087f8ca17e94ffb3b1525a4d6e9be1c6b81184f7 Author: Lior Kaplan kaplanl...@gmail.com Date: Thu Nov 1 18:11:51 2012 +0200 Consolidate ⪠appearances to a CURRENCY template Change-Id: Ibde3ac38e27e5abb42aa5d538762a3a5a7401f2b Reviewed-on: https://gerrit.libreoffice.org/966 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/i18npool/source/localedata/data/he_IL.xml b/i18npool/source/localedata/data/he_IL.xml index 378b489..e8ddb3e 100644 --- a/i18npool/source/localedata/data/he_IL.xml +++ b/i18npool/source/localedata/data/he_IL.xml @@ -51,7 +51,7 @@ TimePMPM/TimePM MeasurementSystemmetric/MeasurementSystem /LC_CTYPE - LC_FORMAT + LC_FORMAT replaceFrom=[CURRENCY] replaceTo=[$âª-40D] DateAcceptancePatternD/M/DateAcceptancePattern FormatElement msgid=DateFormatskey1 default=true type=short usage=DATE formatindex=18 FormatCodeD/M/YY/FormatCode @@ -172,22 +172,22 @@ FormatCode#,###.00/FormatCode /FormatElement FormatElement msgid=CurrencyFormatskey1 default=true type=short usage=CURRENCY formatindex=12 - FormatCode[$âª-40D] #,##0;[$âª-40D] -#,##0/FormatCode + FormatCode[CURRENCY] #,##0;[CURRENCY] -#,##0/FormatCode /FormatElement FormatElement msgid=CurrencyFormatskey2 default=false type=medium usage=CURRENCY formatindex=13 - FormatCode[$âª-40D] #,##0.00;[$âª-40D] -#,##0.00/FormatCode + FormatCode[CURRENCY] #,##0.00;[CURRENCY] -#,##0.00/FormatCode /FormatElement FormatElement msgid=CurrencyFormatskey3 default=false type=medium usage=CURRENCY formatindex=14 - FormatCode[$âª-40D] #,##0;[RED][$âª-40D] -#,##0/FormatCode + FormatCode[CURRENCY] #,##0;[RED][CURRENCY] -#,##0/FormatCode /FormatElement FormatElement msgid=CurrencyFormatskey4 default=true type=medium usage=CURRENCY formatindex=15 - FormatCode[$âª-40D] #,##0.00;[RED][$âª-40D] -#,##0.00/FormatCode + FormatCode[CURRENCY] #,##0.00;[RED][CURRENCY] -#,##0.00/FormatCode /FormatElement FormatElement msgid=CurrencyFormatskey5 default=false type=medium usage=CURRENCY formatindex=16 FormatCode#,##0.00 CCC/FormatCode /FormatElement FormatElement msgid=CurrencyFormatskey6 default=false type=medium usage=CURRENCY formatindex=17 - FormatCode[$âª-40D] #,##0.--;[RED][$âª-40D] -#,##0.--/FormatCode + FormatCode[CURRENCY] #,##0.--;[RED][CURRENCY] -#,##0.--/FormatCode /FormatElement FormatElement msgid=PercentFormatskey1 default=true type=short usage=PERCENT_NUMBER formatindex=8 FormatCode0%/FormatCode ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Change in core[master]: Consolidate ₪ appearances to a CURRENCY template
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/966 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/966 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibde3ac38e27e5abb42aa5d538762a3a5a7401f2b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Lior Kaplan kaplanl...@gmail.com Gerrit-Reviewer: Caolán McNamara caol...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
License
All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Louis Possoz www.quelfutur.org http://www.quelfutur.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: CPPUNIT road map, recent changes etc.
Markus, Markus Mohrhard markus.mohrh...@googlemail.com wrote: 2012/10/30 John McCabe j...@assen.demon.co.uk: Just found this fork but a bit disappointed with the lack of information on the wiki. Is there a road map? What are the changes between 1.12.1 and the latest release? Has documentation been updated? You can find the updates for 1.13.0 in http://cgit.freedesktop.org/libreoffice/cppunit/tree/NEWS?h=cppunit-1-13 and about the two fixes that went in for 1.13.1 at http://mmohrhard.wordpress.com/2012/09/25/cppunit-1-13-1-libreoffice-version-released/ Basically we have mostly upstreamed our patches and fixed some bugs. I'm currently planning some more changes but this is only on paper and nothing written as code yet. You can find a documentation generated from my latest master build at http://people.freedesktop.org/~mmohrhard/cppunit/ Thank you for those links, they're very useful. Can they be added to the wiki page easily? Much appreciated. John. -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - connectivity/source
connectivity/source/drivers/ado/AColumn.cxx |2 +-
connectivity/source/drivers/ado/ATable.cxx |2 +-
connectivity/source/drivers/ado/Awrapado.cxx |4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 09c38e8ffdd24862e885810adc610bfc3e51ff6e
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Fri Nov 2 15:17:37 2012 +0100
connectivity: port ado driver to new OColumn, too
Since the ADO driver does not support CatalogSchema, just leave it empty
Change-Id: Iff9a5105e70a7b9a23f24263b0e74b4fc6d91332
diff --git a/connectivity/source/drivers/ado/AColumn.cxx
b/connectivity/source/drivers/ado/AColumn.cxx
index 7780447..4c4e4f2 100644
--- a/connectivity/source/drivers/ado/AColumn.cxx
+++ b/connectivity/source/drivers/ado/AColumn.cxx
@@ -57,7 +57,7 @@ void WpADOColumn::Create()
}
// -
OAdoColumn::OAdoColumn(sal_Bool _bCase,OConnection* _pConnection,_ADOColumn*
_pColumn)
-:
connectivity::sdbcx::OColumn(::rtl::OUString(),::rtl::OUString(),::rtl::OUString(),::rtl::OUString(),0,0,0,0,sal_False,sal_False,sal_False,_bCase)
+: connectivity::sdbcx::OColumn(_bCase)
,m_pConnection(_pConnection)
{
construct();
diff --git a/connectivity/source/drivers/ado/ATable.cxx
b/connectivity/source/drivers/ado/ATable.cxx
index f2ae573..2b31601 100644
--- a/connectivity/source/drivers/ado/ATable.cxx
+++ b/connectivity/source/drivers/ado/ATable.cxx
@@ -48,7 +48,7 @@ using namespace com::sun::star::lang;
// -
OAdoTable::OAdoTable(sdbcx::OCollection* _pTables,sal_Bool _bCase,OCatalog*
_pCatalog,_ADOTable* _pTable)
-: OTable_TYPEDEF(_pTables,_bCase,::rtl::OUString(),::rtl::OUString())
+: OTable_TYPEDEF(_pTables,_bCase)
,m_pCatalog(_pCatalog)
{
construct();
commit b71c8a455689216ed030fa6715a94f29f224f967
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Fri Nov 2 15:16:30 2012 +0100
janitorial: spacing
Change-Id: If8600f1b3d9346c54ffbba77826ff5ac4f1ed15f
diff --git a/connectivity/source/drivers/ado/Awrapado.cxx
b/connectivity/source/drivers/ado/Awrapado.cxx
index b4eb397..e760874 100644
--- a/connectivity/source/drivers/ado/Awrapado.cxx
+++ b/connectivity/source/drivers/ado/Awrapado.cxx
@@ -1031,9 +1031,9 @@ sal_Bool WpADOParameter::put_Size(const sal_Int32 _nSize)
return (SUCCEEDED(pInterface-put_Size(_nSize)));
}
- ::rtl::OUString WpADOColumn::get_Name() const
+::rtl::OUString WpADOColumn::get_Name() const
{
- OSL_ENSURE(pInterface,Interface is null!);
+OSL_ENSURE(pInterface,Interface is null!);
OLEString aBSTR;
pInterface-get_Name(aBSTR);
return aBSTR;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - dbaccess/source
dbaccess/source/core/api/SingleSelectQueryComposer.cxx |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
New commits:
commit af7141ee109ea9fa73866d3663ef5f1b73dfc30a
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Thu Nov 1 09:56:58 2012 +0100
Don't abort when column has no (Catalog|Schema|Table)Name
Especially since the rest of the function is prepared to handle
no/empty (Catalog|Schema|Table)Name.
Change-Id: Ic0bb59ead5789e671c90887ef850588f4924f5e7
Reviewed-on: https://gerrit.libreoffice.org/968
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
index 01d8cbd..7b1cd80 100644
--- a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
+++ b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
@@ -1301,9 +1301,12 @@ sal_Bool
OSingleSelectQueryComposer::setComparsionPredicate(OSQLParseNode * pCon
if(m_pTables m_pTables-getCount() 1)
{
::rtl::OUString aCatalog,aSchema,aTable,aComposedName,aColumnName;
-column-getPropertyValue(PROPERTY_CATALOGNAME) = aCatalog;
-column-getPropertyValue(PROPERTY_SCHEMANAME) = aSchema;
-column-getPropertyValue(PROPERTY_TABLENAME)= aTable;
+
if(column-getPropertySetInfo()-hasPropertyByName(PROPERTY_CATALOGNAME))
+column-getPropertyValue(PROPERTY_CATALOGNAME) = aCatalog;
+
if(column-getPropertySetInfo()-hasPropertyByName(PROPERTY_SCHEMANAME))
+column-getPropertyValue(PROPERTY_SCHEMANAME) = aSchema;
+if(column-getPropertySetInfo()-hasPropertyByName(PROPERTY_TABLENAME))
+column-getPropertyValue(PROPERTY_TABLENAME)= aTable;
column-getPropertyValue(PROPERTY_NAME) = aColumnName;
Sequence ::rtl::OUString aNames(m_pTables-getElementNames());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Change in core[libreoffice-3-6]: Don't abort when column has no (Catalog|Schema|Table)Name
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/968 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/968 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0bb59ead5789e671c90887ef850588f4924f5e7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu Gerrit-Reviewer: Caolán McNamara caol...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] #fdo36324 #fdo42929 - option to ignore system input language changes
Hi, This is an enhancement to deal with the following issues: https://bugs.freedesktop.org/show_bug.cgi?id=36324 https://bugs.freedesktop.org/show_bug.cgi?id=42929 Files modified: cui\source\options\optgdlg.cxx cui\source\options\optgdlg.hrc cui\source\options\optgdlg.hxx cui\source\options\optgdlg.src officecfg\registry\schema\org\openoffice\Setup.xcs sw\source\ui\docvw\edtwin.cxx unotools\source\config\syslocaleoptions.cxx unotools\inc\unotools\syslocaleoptions.hxx Changes made: Created a new checkbox on the Languages options page: [] Ignore system input language This is unchecked by default so that the current behavior is the default - i.e. newly entered text will be flagged as the whatever the current system input language is. When checked however, this instructs LibreOffice to ignore the system language (on Windows for example, the language from the Language Bar) when determining the language for newly entered text. This is handled in the lcl_isNonDefaultLanguage method of sw\source\ui\docvw\edtwin.cxx. The option is also saved in registrymodifications.xcu There are two main use cases: 1. This allows someone to use a single international keyboard on Windows to type in multiple languages, (e.g. English, French, and Spanish) without changing the system keyboard. The person is then responsible for setting the language of each word or run of text themselves using the Tools-Lanuage-For Selection/For Paragraph/For all Text menu items. This seems to be the preferred workflow for some translators and some educators developing language materials. 2. This allows someone writing in a minority language that is not represented in one of Windows' locale options to still be able to type in their language using a keyboard in another language. Once they set the language in LibreOffice (to Teke-Eboo [ebo_CG] for example), they can type with a keyboard tagged as being for English or French, but still succeed in entering new text in their language. This allows spell-checking to work properly, without them having to select each new word they enter and reset the language of that word to Teke-Eboo, as is currently the case. I tried to follow the code for the DecimalSeparatorAsLocale checkbox on the language page as I made this patch. Hopefully I've done all right. It's been tested on Windows 7. I think there is no expected behavior change on most Linux distros because if I understand right, those systems don't report a language to LibreOffice. Thanks, Jeremy 0001-Fix-fdo36324-fdo42929-option-to-ignore-system-input-.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 3 commits - sc/qa sc/source
sc/qa/unit/ucalc.cxx | 26 --
sc/source/core/data/table2.cxx | 10 --
2 files changed, 28 insertions(+), 8 deletions(-)
New commits:
commit e8487c8a3f3ece74143928352e1e8a7dfb72d424
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Nov 2 11:01:15 2012 -0400
Fix incorrect shifting of cell notes upon cell insertion / deletion.
Steps to reproduce:
1) Insert a comment at D5.
2) Move cursor to C4.
3) Right-click and select Insert.
4) Choose shift cells down.
5) The comment gets shifted down but it shouldn't.
The same thing happens when deleting a cell and shifting content.
Change-Id: I5a71845cca6abde6b7c940e152e155da26343cef
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index 193e7f0..8bfb0e6 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -171,6 +171,7 @@ void ScTable::InsertRow( SCCOL nStartCol, SCCOL nEndCol,
SCROW nStartRow, SCSIZE
for (SCCOL j=nStartCol; j=nEndCol; j++)
aCol[j].InsertRow( nStartRow, nSize );
+// Transfer those notes that will get shifted into another container.
ScNotes aNotes(pDocument);
ScNotes::iterator itr = maNotes.begin();
while( itr != maNotes.end() )
@@ -180,13 +181,14 @@ void ScTable::InsertRow( SCCOL nStartCol, SCCOL nEndCol,
SCROW nStartRow, SCSIZE
ScPostIt* pPostIt = itr-second;
++itr;
-if (nRow = nStartRow)
+if (nStartRow = nRow nStartCol = nCol nCol = nEndCol)
{
aNotes.insert(nCol, nRow + nSize, pPostIt);
maNotes.ReleaseNote(nCol, nRow);
}
}
+// Re-insert the shifted notes.
itr = aNotes.begin();
while( itr != aNotes.end() )
{
@@ -247,6 +249,7 @@ void ScTable::DeleteRow( SCCOL nStartCol, SCCOL nEndCol,
SCROW nStartRow, SCSIZE
}
}
+// Transfer those notes that will get shifted into another container.
ScNotes aNotes(pDocument);
ScNotes::iterator itr = maNotes.begin();
while( itr != maNotes.end() )
@@ -256,18 +259,21 @@ void ScTable::DeleteRow( SCCOL nStartCol, SCCOL nEndCol,
SCROW nStartRow, SCSIZE
ScPostIt* pPostIt = itr-second;
++itr;
-if (nRow = nStartRow)
+if (nStartRow = nRow nStartCol = nCol nCol = nEndCol)
{
if(nRow - nStartRow static_castSCROW(nSize))
{
+// This note will get shifted.
aNotes.insert(nCol, nRow - nSize, pPostIt);
maNotes.ReleaseNote(nCol, nRow);
}
else
+// Note is in the deleted area. Remove it.
maNotes.erase(nCol, nRow);
}
}
+// Re-insert the shifted notes.
itr = aNotes.begin();
while( itr != aNotes.end() )
{
commit e127cb937698938e233e7b469a10e35585ddb88f
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Nov 2 10:40:14 2012 -0400
Added comment for the note test code added test for new scenario.
The new test currently fails due to bug.
Change-Id: I447f43039f32c33eb55c182515e826a8250d7525
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 66ad169..62e98c6 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -4242,7 +4242,7 @@ void Test::testPostIts()
rtl::OUString aTabName2(Table2);
m_pDoc-InsertTab(0, aTabName);
-ScAddress rAddr(2, 2, 0);
+ScAddress rAddr(2, 2, 0); // cell C3
ScPostIt *pNote = m_pDoc-GetNotes(rAddr.Tab())-GetOrCreateNote(rAddr);
pNote-SetText(rAddr, aHello);
pNote-SetAuthor(aJimBob);
@@ -4250,29 +4250,41 @@ void Test::testPostIts()
ScPostIt *pGetNote = m_pDoc-GetNotes(rAddr.Tab())-findByAddress(rAddr);
CPPUNIT_ASSERT_MESSAGE(note should be itself, pGetNote == pNote );
-bool bInsertRow = m_pDoc-InsertRow( 0, 0, 100, 0, 1, 1 );
+// Insert one row at row 1.
+bool bInsertRow = m_pDoc-InsertRow(0, 0, MAXCOL, 0, 1, 1);
CPPUNIT_ASSERT_MESSAGE(failed to insert row, bInsertRow );
CPPUNIT_ASSERT_MESSAGE(note hasn't moved,
m_pDoc-GetNotes(rAddr.Tab())-findByAddress(rAddr) == NULL);
-rAddr.IncRow();
+rAddr.IncRow(); // cell C4
CPPUNIT_ASSERT_MESSAGE(note not there,
m_pDoc-GetNotes(rAddr.Tab())-findByAddress(rAddr) == pNote);
-bool bInsertCol = m_pDoc-InsertCol( 0, 0, 100, 0, 1, 1 );
+// Insert column at column 1.
+bool bInsertCol = m_pDoc-InsertCol(0, 0, MAXROW, 0, 1, 1);
CPPUNIT_ASSERT_MESSAGE(failed to insert column, bInsertCol );
CPPUNIT_ASSERT_MESSAGE(note hasn't moved,
m_pDoc-GetNotes(rAddr.Tab())-findByAddress(rAddr) == NULL);
-rAddr.IncCol();
+rAddr.IncCol(); // cell D4
CPPUNIT_ASSERT_MESSAGE(note not there,
m_pDoc-GetNotes(rAddr.Tab())-findByAddress(rAddr) == pNote);
+// Insert a new sheet to shift the current sheet to the right.
m_pDoc-InsertTab(0, aTabName2);
[REVIEW 3-6] Fix incorrect shifting of cell notes.
Hi there, Please review and cherry-pick https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=e8487c8a3f3ece74143928352e1e8a7dfb72d424 to the 3-6 branch. This fixes incorrect shifting of cell notes when inserting or removing cell(s) and shifting up and down cells below the inserted/removed region. I haven't checked the bugzilla yet to see if this has been reported, but I've discovered this by chance while testing Calc for something else. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] detect even more memory mismanagement on glibc
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/969 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/969/1 detect even more memory mismanagement on glibc Change-Id: I3a06e5970638c755e89f8ffdf96b68d3c6cdbe61 --- M solenv/bin/linkoo 1 file changed, 16 insertions(+), 0 deletions(-) -- To view, visit https://gerrit.libreoffice.org/969 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3a06e5970638c755e89f8ffdf96b68d3c6cdbe61 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
docx export: if table has no width use w:tblW 'auto' type
Pierre-Eric Pelloux-Prayer has abandoned this change. Change subject: docx export: if table has no width use w:tblW 'auto' type .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/657 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I085febf04205181e7c4488bc948f346f92070fe2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz Gerrit-Reviewer: Noel Power noel.po...@suse.com Gerrit-Reviewer: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - cui/AllLangResTarget_cui.mk cui/source cui/uiconfig cui/UI_cui.mk
cui/AllLangResTarget_cui.mk|1
cui/UI_cui.mk |1
cui/source/dialogs/cuires.src | 14 +-
cui/source/dialogs/insrc.cxx | 26 +--
cui/source/dialogs/insrc.hrc | 31
cui/source/dialogs/insrc.src | 109
cui/source/inc/cuires.hrc |7 -
cui/source/inc/insrc.hxx | 13 -
cui/uiconfig/ui/insertrowcolumn.ui | 252 +
9 files changed, 280 insertions(+), 174 deletions(-)
New commits:
commit 0633cd04b8739436fe1a10a67a4804ecdb724198
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 2 15:23:16 2012 +
tidy dialog a bit
Change-Id: I301e24aeb3f8b49dbf9902b7fb00c2992ece5e42
diff --git a/cui/AllLangResTarget_cui.mk b/cui/AllLangResTarget_cui.mk
index 4128699..9ec65f9 100644
--- a/cui/AllLangResTarget_cui.mk
+++ b/cui/AllLangResTarget_cui.mk
@@ -66,7 +66,6 @@ $(eval $(call gb_SrsTarget_add_files,cui/res,\
cui/source/dialogs/hlmarkwn.src \
cui/source/dialogs/hyperdlg.src \
cui/source/dialogs/iconcdlg.src \
-cui/source/dialogs/insrc.src \
cui/source/dialogs/multipat.src \
cui/source/dialogs/newtabledlg.src \
cui/source/dialogs/passwdomdlg.src \
diff --git a/cui/UI_cui.mk b/cui/UI_cui.mk
index 9e4f844..a4df7be 100644
--- a/cui/UI_cui.mk
+++ b/cui/UI_cui.mk
@@ -16,7 +16,7 @@ $(eval $(call gb_UI_add_uifiles,cui,\
cui/uiconfig/ui/insertfloatingframe \
cui/uiconfig/ui/insertoleobject \
cui/uiconfig/ui/insertplugin \
- cui/uiconfig/ui/insrc \
+ cui/uiconfig/ui/insertrowcolumn \
cui/uiconfig/ui/macroselectordialog \
cui/uiconfig/ui/positionpage \
cui/uiconfig/ui/specialcharacters \
diff --git a/cui/source/dialogs/cuires.src b/cui/source/dialogs/cuires.src
index 2e6e6ed..8fa9695 100644
--- a/cui/source/dialogs/cuires.src
+++ b/cui/source/dialogs/cuires.src
@@ -31,12 +31,22 @@ String RID_SVXSTR_PRODMACROS
String RID_SVXSTR_SELECTOR_ADD_COMMANDS
{
- TEXT [ en-US ] = Add Commands ;
+TEXT [ en-US ] = Add Commands ;
};
String RID_SVXSTR_SELECTOR_RUN
{
- TEXT [ en-US ] = Run ;
+TEXT [ en-US ] = Run ;
+};
+
+String RID_SVXSTR_ROW
+{
+Text [ en-US ] = Insert Rows ;
+};
+
+String RID_SVXSTR_COL
+{
+Text [ en-US ] = Insert Columns ;
};
#define MASKCOLOR MaskColor = \
diff --git a/cui/source/dialogs/insrc.cxx b/cui/source/dialogs/insrc.cxx
index e48a8eb..7efbc48 100644
--- a/cui/source/dialogs/insrc.cxx
+++ b/cui/source/dialogs/insrc.cxx
@@ -21,7 +21,6 @@
#include svx/svxdlg.hxx
#include cuires.hrc
#include insrc.hxx
-#include insrc.hrc
bool SvxInsRowColDlg::isInsertBefore() const
{
@@ -34,10 +33,10 @@ sal_uInt16 SvxInsRowColDlg::getInsertCount() const
}
SvxInsRowColDlg::SvxInsRowColDlg(Window* pParent, bool bCol, const
rtl::OString sHelpId )
-: ModalDialog( pParent, insert_row_dialog, cui/ui/insrc.ui ),
-aRow(CUI_RESSTR(STR_ROW)),
-aCol(CUI_RESSTR(STR_COL)),
-bColumn( bCol )
+: ModalDialog(pParent, InsertRowColumnDialog,
cui/ui/insertrowcolumn.ui)
+, aRow(CUI_RESSTR(RID_SVXSTR_ROW))
+, aCol(CUI_RESSTR(RID_SVXSTR_COL))
+, bColumn(bCol)
{
get(m_pCountEdit, insert_number);
get(m_pBeforeBtn, insert_before);
diff --git a/cui/source/dialogs/insrc.hrc b/cui/source/dialogs/insrc.hrc
deleted file mode 100644
index d024cfe..000
--- a/cui/source/dialogs/insrc.hrc
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the License); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-#define FT_COUNT1
-#define ED_COUNT2
-#define FL_INS 3
-
-#define CB_POS_BEFORE 10
-#define CB_POS_AFTER11
-#define FL_POS 12
-
-#define STR_ROW 20
-#define STR_COL 21
-
-#define BT_OK 100
-#define BT_CANCEL 101
-#define BT_HELP 102
diff --git a/cui/source/dialogs/insrc.src b/cui/source/dialogs/insrc.src
deleted file mode 100644
index 101dca6..000
--- a/cui/source/dialogs/insrc.src
+++ /dev/null
@@ -1,109 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- *
[PUSHED] WIP: first stab at converting the insert-row dialog
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/893 -- To view, visit https://gerrit.libreoffice.org/893 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b1888f667b31b6ca22d1eca57aeb9da7ce45b71 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Kaluza fl...@ghostroute.eu Gerrit-Reviewer: Caolán McNamara caol...@redhat.com Gerrit-Reviewer: Philipp Kaluza fl...@ghostroute.eu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
unusedcode.easy cleanup
Ricardo Montania has abandoned this change. Change subject: unusedcode.easy cleanup .. Patch Set 1: Abandoned Method needed for windows build -- To view, visit https://gerrit.libreoffice.org/942 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia16a0571f253faa0364eec78bb29e4f13485a584 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br Gerrit-Reviewer: Caolán McNamara caol...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/rb7' - vcl/source
vcl/source/app/brand.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit fb4e9dd6235aacaf5ce512ccf9f10accdc4b637d Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Fri Nov 2 17:15:11 2012 +0100 Don't suck in rendergraphic.hxx by backdoor Change-Id: I0ba4609fb4dfc3afe7ec28d22e1fe94d611e4b8a diff --git a/vcl/source/app/brand.cxx b/vcl/source/app/brand.cxx index 65af0d3..99dd78b 100644 --- a/vcl/source/app/brand.cxx +++ b/vcl/source/app/brand.cxx @@ -24,7 +24,6 @@ #include tools/urlobj.hxx #include tools/stream.hxx #include vcl/pngread.hxx -#include vcl/svgread.hxx #include vcl/svapp.hxx #ifdef FIXME_REMOVE_WHEN_RE_BASE_COMPLETE #include vcl/rendergraphicrasterizer.hxx ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] fdo#38838 UniString removal
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/970 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/970/1 fdo#38838 UniString removal Change-Id: Id1a17001caa0f6350de10d8af016630f4c76a55b --- M cui/source/dialogs/cuifmsearch.cxx M cui/source/inc/cuifmsearch.hxx 2 files changed, 10 insertions(+), 10 deletions(-) -- To view, visit https://gerrit.libreoffice.org/970 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id1a17001caa0f6350de10d8af016630f4c76a55b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 52022, which changed state. Bug 52022 Summary: CONFIGURATION: Part of data in userdir is lost on 3.5 - 3.6 upgrade https://bugs.freedesktop.org/show_bug.cgi?id=52022 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ANNOUNCE] Policy change regarding API and ABI stability
Hi,
As you might have seen in the ESC minutes, we were thoroughly discussing
how to call the next version, and what to do regarding our API / ABI
policy. In the end, we came to the following conclusion:
The next version (so far called 3.7) will become 4.0. With this
version, our approach to API and ABI stability changes - from now on,
changes will be possible on case-by-case basis between versions, as long
as the following rules apply:
* best effort to _not_ to break API / ABI, ie. think twice before you
attempt to change anything interfacing the outside world in an
incompatible way
* only small / local incompatible changes where necessary are possible
(to minimize impact on the outside world, mainly on the extensions
developers)
* incompatible changes must be documented in the wiki immediately when
introduced (dedicated page will be set up) and announced on the
development mailing list with [API] in the mail subject
* the changes are veto-able by ESC case-by-case ('forced' revert)
* larger incompatible changes are possible as long as a smooth
transition path is provided (with appropriate deprecation first, like
warnings when used via the SDK, and removal later, eg. in LibreOffice
5.0)
This explicitly means:
* there might be API / ABI changes in 4.0, but we will do our best to
minimize them (or their impact) to bare minimum, or even defer them
to 4.x
* there might be subsequent API / ABI changes in 4.1, 4.2, etc.
I hope I did not forget anything substantial. Additions / improvements
of the policy of course appreciated :-)
There might be follow-up questions, like is my change XYZ big or
small, when am I actually supposed to do my big change XYZ, if at
all?, etc. - I believe the best approach is to present the exact change
first on the ML, discuss it there, and then decide together (on the ML
or via ESC) on the concrete plan.
And of course - if you notice that somebody did an incompatible change
and did not announce it properly (as outlined above), bring it to the ML
as soon as you notice that, to check if it was deliberate or not.
All the best,
Kendy
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - sc/qa sc/source
sc/qa/unit/ucalc.cxx | 12 +++-
sc/source/core/data/table2.cxx | 16
2 files changed, 23 insertions(+), 5 deletions(-)
New commits:
commit d3344dd85ee31b195a3709d16e734245e1d0a4b6
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Nov 2 13:27:31 2012 -0400
Correctly handle cell note shifting when immediate row/column is deleted.
Currently, having a note e.g. at D5, and deleting cell D4 and shifting
the cells below upward will remove the note at D5. But the correct behavior
is to shift that note up to D4. This change fixes it.
Change-Id: Ia37f1ce67a003deab424f2b805a2ce333fc10ed4
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index 8bfb0e6..69e2f02 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -261,7 +261,8 @@ void ScTable::DeleteRow( SCCOL nStartCol, SCCOL nEndCol,
SCROW nStartRow, SCSIZE
if (nStartRow = nRow nStartCol = nCol nCol = nEndCol)
{
-if(nRow - nStartRow static_castSCROW(nSize))
+SCROW nEndRow = nStartRow + nSize - 1; // last row of deleted
region
+if (nEndRow nRow)
{
// This note will get shifted.
aNotes.insert(nCol, nRow - nSize, pPostIt);
@@ -365,6 +366,7 @@ void ScTable::InsertCol( SCCOL nStartCol, SCROW nStartRow,
SCROW nEndRow, SCSIZE
aCol[MAXCOL - nSize - i].MoveTo(nStartRow, nEndRow, aCol[MAXCOL -
i]);
}
+// Transfer those notes that will get shifted into another container.
ScNotes aNotes(pDocument);
ScNotes::iterator itr = maNotes.begin();
while( itr != maNotes.end() )
@@ -374,13 +376,14 @@ void ScTable::InsertCol( SCCOL nStartCol, SCROW
nStartRow, SCROW nEndRow, SCSIZE
ScPostIt* pPostIt = itr-second;
++itr;
-if (nCol = nStartCol)
+if (nStartCol = nCol nStartRow = nRow nRow = nEndRow)
{
aNotes.insert(nCol + nSize, nRow, pPostIt);
maNotes.ReleaseNote(nCol, nRow);
}
}
+// Re-insert the shifted notes.
itr = aNotes.begin();
while( itr != aNotes.end() )
{
@@ -471,6 +474,7 @@ void ScTable::DeleteCol( SCCOL nStartCol, SCROW nStartRow,
SCROW nEndRow, SCSIZE
aCol[nStartCol + nSize + i].MoveTo(nStartRow, nEndRow,
aCol[nStartCol + i]);
}
+// Transfer those notes that will get shifted into another container.
ScNotes aNotes(pDocument);
ScNotes::iterator itr = maNotes.begin();
while( itr != maNotes.end() )
@@ -480,18 +484,22 @@ void ScTable::DeleteCol( SCCOL nStartCol, SCROW
nStartRow, SCROW nEndRow, SCSIZE
ScPostIt* pPostIt = itr-second;
++itr;
-if (nCol = nStartCol)
+if (nStartCol = nCol nStartRow = nRow nRow = nEndRow)
{
-if(nCol - nStartCol static_castSCCOL(nSize))
+SCCOL nEndCol = nStartCol + nSize - 1;
+if (nEndCol nCol)
{
+// This note will get shifted.
aNotes.insert(nCol - nSize, nRow, pPostIt);
maNotes.ReleaseNote(nCol, nRow);
}
else
+// The note is in the deleted region. Remove it.
maNotes.erase(nCol, nRow);
}
}
+// Re-insert the shifted notes.
itr = aNotes.begin();
while( itr != aNotes.end() )
{
commit 6bac39f309e11a515a2b2ecdf43a4b49ccd53502
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Nov 2 13:23:58 2012 -0400
More test cases for cell notes that currently fail.
Change-Id: I23a5a39ab13106a27a02adbec0ff1ab64a43abef
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 62e98c6..ce8ea86 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -4258,7 +4258,7 @@ void Test::testPostIts()
rAddr.IncRow(); // cell C4
CPPUNIT_ASSERT_MESSAGE(note not there,
m_pDoc-GetNotes(rAddr.Tab())-findByAddress(rAddr) == pNote);
-// Insert column at column 1.
+// Insert column at column A.
bool bInsertCol = m_pDoc-InsertCol(0, 0, MAXROW, 0, 1, 1);
CPPUNIT_ASSERT_MESSAGE(failed to insert column, bInsertCol );
@@ -4285,6 +4285,16 @@ void Test::testPostIts()
m_pDoc-DeleteRow(2, 0, 2, 0, 3, 1);
CPPUNIT_ASSERT_MESSAGE(Note shouldn't have moved but it has.,
m_pDoc-GetNotes(rAddr.Tab())-findByAddress(rAddr) == pNote);
+// Now, with the note at D4, delete cell D3. This should shift the note
one cell up.
+m_pDoc-DeleteRow(3, 0, 3, 0, 2, 1);
+rAddr.IncRow(-1); // cell D3
+CPPUNIT_ASSERT_MESSAGE(Note at D4 should have shifted up to D3.,
m_pDoc-GetNotes(rAddr.Tab())-findByAddress(rAddr) == pNote);
+
+// Delete column C. This should shift the note one cell left.
+m_pDoc-DeleteCol(0, 0, MAXROW, 0, 2, 1);
+rAddr.IncCol(-1); // cell C3
+CPPUNIT_ASSERT_MESSAGE(Note at D3 should have shifted left to C3.,
Re: [REVIEW 3-6] Fix incorrect shifting of cell notes.
On Fri, Nov 2, 2012 at 11:09 AM, Kohei Yoshida kohei.yosh...@gmail.comwrote: Hi there, Please review and cherry-pick https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=e8487c8a3f3ece74143928352e1e8a7dfb72d424 to the 3-6 branch. This fixes incorrect shifting of cell notes when inserting or removing cell(s) and shifting up and down cells below the inserted/removed region. There is another one https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=d3344dd85ee31b195a3709d16e734245e1d0a4b6 This one should also be cherry-picked. So far I haven't encountered any other issues with cell notes repositioning. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#38838 UniString removal
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/971 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/971/1 fdo#38838 UniString removal Change-Id: I7bf9b0e94bff9047544f6aba9669b8e0a3d3a2a5 --- M cui/source/tabpages/chardlg.cxx M cui/source/tabpages/grfpage.cxx 2 files changed, 15 insertions(+), 14 deletions(-) -- To view, visit https://gerrit.libreoffice.org/971 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7bf9b0e94bff9047544f6aba9669b8e0a3d3a2a5 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sal/inc sw/source
sal/inc/sal/log-areas.dox |1
sw/source/filter/ww8/WW8Sttbf.cxx | 10 ---
sw/source/filter/ww8/WW8TableInfo.cxx | 91 +-
sw/source/filter/ww8/rtfexport.cxx| 11
sw/source/filter/ww8/wrtw8nds.cxx | 13 +---
sw/source/filter/ww8/wrtww8.cxx | 74 ---
sw/source/filter/ww8/ww8par.cxx |4 -
7 files changed, 56 insertions(+), 148 deletions(-)
New commits:
commit 091b9e46ece9bb94a67c8867e0d33f4e4bee6fad
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Fri Nov 2 19:18:57 2012 +0100
change std::clog debug output to SAL_INFO, so that it can be turned off
Change-Id: I92af860af6ac82302458cdd894f3ad038a863b49
diff --git a/sal/inc/sal/log-areas.dox b/sal/inc/sal/log-areas.dox
index 777994e..b6af6f8 100644
--- a/sal/inc/sal/log-areas.dox
+++ b/sal/inc/sal/log-areas.dox
@@ -183,6 +183,7 @@ certain functionality.
@li @c sw.rtf - .rtf export filter
@li @c sw.uno - Writer UNO interfaces
@li @c sw.ww8 - .doc/.docx export filter, .doc import filter (not writerfilter)
+@li @c sw.ww8.level2 - further info for sw.ww8
@section xmloff
diff --git a/sw/source/filter/ww8/WW8Sttbf.cxx
b/sw/source/filter/ww8/WW8Sttbf.cxx
index 4280a0a..5762722 100644
--- a/sw/source/filter/ww8/WW8Sttbf.cxx
+++ b/sw/source/filter/ww8/WW8Sttbf.cxx
@@ -98,14 +98,8 @@ namespace ww8
#endif
}
-#if OSL_DEBUG_LEVEL 1
-char sBuffer[256];
-snprintf(sBuffer, sizeof(sBuffer), offset=\% SAL_PRIuUINT32 \
count=\% SAL_PRIuUINT32 \,
- nOffset, nCount);
-::std::clog WW8Struct-getUString sBuffer
- rtl::OUStringToOString( aResult, RTL_TEXTENCODING_UTF8
).getStr() /WW8Struct-getUString
- ::std::endl;
-#endif
+SAL_INFO( sw.ww8.level2, WW8Struct-getUString offset=\
nOffset
+ \ count=\ nCount \aResult
/WW8Struct-getUString );
return aResult;
diff --git a/sw/source/filter/ww8/WW8TableInfo.cxx
b/sw/source/filter/ww8/WW8TableInfo.cxx
index 1a30749..c8b4636 100644
--- a/sw/source/filter/ww8/WW8TableInfo.cxx
+++ b/sw/source/filter/ww8/WW8TableInfo.cxx
@@ -393,8 +393,7 @@ void WW8TableNodeInfo::setEndOfLine(bool bEndOfLine)
pInner-setEndOfLine(bEndOfLine);
#ifdef DBG_UTIL
-::std::clog endOfLine depth=\ mnDepth \
- toString() /endOfLine ::std::endl;
+SAL_INFO( sw.ww8, endOfLine depth=\ mnDepth \
toString() /endOfLine );
#endif
}
@@ -404,8 +403,7 @@ void WW8TableNodeInfo::setEndOfCell(bool bEndOfCell)
pInner-setEndOfCell(bEndOfCell);
#ifdef DBG_UTIL
-::std::clog endOfCell depth=\ mnDepth \
- toString() /endOfCell ::std::endl;
+SAL_INFO( sw.ww8, endOfCell depth=\ mnDepth \
toString() /endOfCell );
#endif
}
@@ -416,8 +414,7 @@ void WW8TableNodeInfo::setFirstInTable(bool bFirstInTable)
pInner-setFirstInTable(bFirstInTable);
#ifdef DBG_UTIL
-::std::clog firstInTable depth=\ mnDepth \
- toString() /firstInTable ::std::endl;
+SAL_INFO( sw.ww8, firstInTable depth=\ mnDepth \
toString() /firstInTable );
#endif
}
@@ -427,10 +424,8 @@ void WW8TableNodeInfo::setVertMerge(bool bVertMerge)
pInner-setVertMerge(bVertMerge);
-
#ifdef DBG_UTIL
-::std::clog vertMerge depth=\ mnDepth \
- toString() /vertMerge ::std::endl;
+SAL_INFO( sw.ww8, vertMerge depth=\ mnDepth \
toString() /vertMerge );
#endif
}
@@ -449,9 +444,7 @@ void WW8TableNodeInfo::setNext(WW8TableNodeInfo * pNext)
mpNext = pNext;
#ifdef DBG_UTIL
-::std::clog setnextfrom toString() /fromto
- pNext-toString() /to/setnext
- ::std::endl;
+SAL_INFO( sw.ww8, setnextfrom toString() /fromto
pNext-toString() /to/setnext );
#endif
}
@@ -576,15 +569,9 @@ WW8TableInfo::processSwTableByLayout(const SwTable *
pTable)
{
SwRect aRect = aTableCellInfo.getRect();
-#ifdef DBG_UTIL
-static char sBuffer[1024];
-::std::clog CellFrm ::std::endl;
-
-snprintf(sBuffer, sizeof(sBuffer),
- rect top=\%ld\ bottom=\%ld\ left=\%ld\
right=\%ld\/,
- aRect.Top(), aRect.Bottom(), aRect.Left(), aRect.Right());
-::std::clog sBuffer ::std::endl;
-#endif
+SAL_INFO( sw.ww8, CellFrm );
+SAL_INFO( sw.ww8, rect top=\ aRect.Top() \ bottom=\
aRect.Bottom()
+ \ left=\ aRect.Left() \ right=\ aRect.Right()
\/ );
const SwTableBox * pTableBox = aTableCellInfo.getTableBox();
const SwStartNode * pSttNd = pTableBox-GetSttNd();
@@ -613,9 +600,7 @@ WW8TableInfo::processSwTableByLayout(const SwTable * pTable)
while (!bDone);
}
-#ifdef DBG_UTIL
-::std::clog /CellFrm ::std::endl;
-#endif
+SAL_INFO( sw.ww8, /CellFrm );
}
pPrev = reorderByLayout(pTable);
@@ -625,9 +610,7 @@ WW8TableInfo::processSwTableByLayout(const SwTable *
[Libreoffice-commits] .: svx/inc svx/source
svx/inc/svx/svdhdl.hxx |2 +-
svx/source/svdraw/svdhdl.cxx |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 46aec3014b16286df97ed0c7a47f509fffb564c9
Author: Thorsten Behrens tbehr...@suse.com
Date: Fri Nov 2 19:42:47 2012 +0100
Fix crash during polygon handle travelling.
Improving on 7d5922ca8f04604aba57708ee20fb4cdeaea2e44 wrt. bound
checking and non-truncation of index magic values.
Change-Id: If33495075472fdf242b2de0893fd44109ec7bc83
diff --git a/svx/inc/svx/svdhdl.hxx b/svx/inc/svx/svdhdl.hxx
index 3a44b92..10fcc84 100644
--- a/svx/inc/svx/svdhdl.hxx
+++ b/svx/inc/svx/svdhdl.hxx
@@ -480,7 +480,7 @@ public:
// 3.Level Position (x+y)
void Sort();
sal_uIntPtrGetHdlCount() const { return
aList.size(); }
-SdrHdl* GetHdl(sal_uIntPtr nNum) const { return
aList[nNum]; }
+SdrHdl* GetHdl(sal_uIntPtr nNum) const { return nNum !=
CONTAINER_ENTRY_NOTFOUND ? aList[nNum] : NULL; }
sal_uIntPtrGetHdlNum(const SdrHdl* pHdl) const;
void SetHdlSize(sal_uInt16 nSiz);
sal_uInt16 GetHdlSize() const{ return nHdlSize; }
diff --git a/svx/source/svdraw/svdhdl.cxx b/svx/source/svdraw/svdhdl.cxx
index 7931db8..7b7548f 100644
--- a/svx/source/svdraw/svdhdl.cxx
+++ b/svx/source/svdraw/svdhdl.cxx
@@ -1911,7 +1911,7 @@ void SdrHdlList::TravelFocusHdl(sal_Bool bForward)
}
// build new HdlNum
-sal_uInt32 nNewHdlNum(nNewHdl);
+sal_uIntPtr nNewHdlNum(nNewHdl);
// look for old num in sorted array
if(nNewHdl != CONTAINER_ENTRY_NOTFOUND)
@@ -2020,7 +2020,7 @@ void SdrHdlList::SetHdlSize(sal_uInt16 nSiz)
nHdlSize = nSiz;
// propagate change to IAOs
-for(sal_uInt32 i=0; iGetHdlCount(); i++)
+for(sal_uIntPtr i=0; iGetHdlCount(); i++)
{
SdrHdl* pHdl = GetHdl(i);
pHdl-Touch();
@@ -2036,7 +2036,7 @@ void SdrHdlList::SetMoveOutside(sal_Bool bOn)
bMoveOutside = bOn;
// propagate change to IAOs
-for(sal_uInt32 i=0; iGetHdlCount(); i++)
+for(sal_uIntPtr i=0; iGetHdlCount(); i++)
{
SdrHdl* pHdl = GetHdl(i);
pHdl-Touch();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - sc/source
sc/source/ui/cctrl/checklistmenu.cxx | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
New commits:
commit 0770e163ecf753004f73273f6caf060a02b65173
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Nov 2 15:27:27 2012 -0400
Set initial focus to the check list box.
This is so that when launching the autofilter popup via key stroke,
the user can immediately type-ahead to find a match within the check
list box.
Change-Id: I8a33a52afc6005b4a7428d5f7046eff986da80d2
diff --git a/sc/source/ui/cctrl/checklistmenu.cxx
b/sc/source/ui/cctrl/checklistmenu.cxx
index 4a4066b..96708d5 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -1368,6 +1368,7 @@ void ScCheckListMenuWindow::launch(const Rectangle rRect)
}
StartPopupMode(aRect, (FLOATWIN_POPUPMODE_DOWN |
FLOATWIN_POPUPMODE_GRABFOCUS));
+cycleFocus(); // Set initial focus to the check list box.
}
void ScCheckListMenuWindow::close(bool bOK)
commit e3250b90677fc7ae449cb3ff887ed3da35b4532f
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Nov 2 15:21:41 2012 -0400
Enable type-ahead search in the check list box in the autofilter popup.
Many people have asked me for this. This is also enabled in the pivot
table field popup (since the two basically share the same code).
Change-Id: I99255839353d62c0760dd4f3a66cc7e9924ce1c3
diff --git a/sc/source/ui/cctrl/checklistmenu.cxx
b/sc/source/ui/cctrl/checklistmenu.cxx
index 7d30e02..4a4066b 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -914,6 +914,9 @@ ScCheckListMenuWindow::ScCheckListMenuWindow(Window*
pParent, ScDocument* pDoc)
maTabStopCtrls.push_back(maBtnUnselectSingle);
maTabStopCtrls.push_back(maBtnOk);
maTabStopCtrls.push_back(maBtnCancel);
+
+// Enable type-ahead search in the check list box.
+maChecks.SetStyle(maChecks.GetStyle() | WB_QUICK_SEARCH);
}
ScCheckListMenuWindow::~ScCheckListMenuWindow()
commit 94fdd16062ca6fae8e18352ae0a7547e6b65fd61
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Nov 2 14:51:35 2012 -0400
Launch pop-up right-aligned in case the cell is wider than the popup.
Or else the popup and the popup button would get separated.
Change-Id: I4c8dda2bf5cebe0fe0e0ce64c9c213e2926d9570
diff --git a/sc/source/ui/cctrl/checklistmenu.cxx
b/sc/source/ui/cctrl/checklistmenu.cxx
index d82329d..7d30e02 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -1354,7 +1354,17 @@ void ScCheckListMenuWindow::launch(const Rectangle
rRect)
// We need to have at least one member selected.
maBtnOk.Enable(maChecks.GetCheckedEntryCount() != 0);
-StartPopupMode(rRect, (FLOATWIN_POPUPMODE_DOWN |
FLOATWIN_POPUPMODE_GRABFOCUS));
+Rectangle aRect(rRect);
+if (maWndSize.Width() aRect.GetWidth())
+{
+// Target rectangle (i.e. cell width) is wider than the window.
+// Simulate right-aligned launch by modifying the target rectangle
+// size.
+long nDiff = aRect.GetWidth() - maWndSize.Width();
+aRect.Left() += nDiff;
+}
+
+StartPopupMode(aRect, (FLOATWIN_POPUPMODE_DOWN |
FLOATWIN_POPUPMODE_GRABFOCUS));
}
void ScCheckListMenuWindow::close(bool bOK)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: svtools/source
svtools/source/svhtml/parhtml.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9fdf86df4eb65a0cd2a178998daf751afc34805e Author: Louis Possoz louis.pos...@quelfutur.org Date: Fri Oct 26 16:18:34 2012 +0200 Fix bug 50931 : Cannot import HTML br/ and hr/ Change-Id: Ia4932c2e1f451ae45675a32de42a5cf971224211 Reviewed-on: https://gerrit.libreoffice.org/915 Tested-by: Michael Stahl mst...@redhat.com Reviewed-by: Michael Stahl mst...@redhat.com diff --git a/svtools/source/svhtml/parhtml.cxx b/svtools/source/svhtml/parhtml.cxx index 2cf6ebb..743ecec 100644 --- a/svtools/source/svhtml/parhtml.cxx +++ b/svtools/source/svhtml/parhtml.cxx @@ -1115,7 +1115,7 @@ int HTMLParser::_GetNextToken() if( MAX_LEN == sTmpBuffer.getLength() ) aToken += String(sTmpBuffer.makeStringAndClear()); nNextCh = GetNextChar(); -} while( '' != nNextCh !HTML_ISSPACE( nNextCh ) +} while( '' != nNextCh '/' != nNextCh !HTML_ISSPACE( nNextCh ) IsParserWorking() !rInput.IsEof() ); if( sTmpBuffer.getLength() ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: no functional TinderBox for master/3-7 full Windows builds
On 01.11.2012 19:25, V Stuart Foote wrote: Rats, working with David O's VC 2010 build of LOdev master, no improvement using the WRITE_REGISTRY=1 during installtion, nor with manually setting a SAL_ACCESSIBILITY_ENABLED environment variable. The Use Assistive Tools checkbox still won't hold its state. now it does: https://ci.idaia.de/job/LO-Win2008-VC2010/6/ Regards David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Fix bug 50931 : Cannot import HTML br/ and hr/
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/915 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/915 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4932c2e1f451ae45675a32de42a5cf971224211 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Louis Possoz louis.pos...@quelfutur.org Gerrit-Reviewer: Michael Stahl mst...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sal/inc
sal/inc/sal/mathconf.h |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 19bce817279c7fd150af0422c224975e57ff9f41
Author: Tor Lillqvist t...@iki.fi
Date: Fri Nov 2 22:25:47 2012 +0200
Try to use isfinite() for iOS
Change-Id: Ia333afbefa4c112f478d2619efbe032e70925417
diff --git a/sal/inc/sal/mathconf.h b/sal/inc/sal/mathconf.h
index f92d8b4..5a49e0b 100644
--- a/sal/inc/sal/mathconf.h
+++ b/sal/inc/sal/mathconf.h
@@ -67,6 +67,8 @@ extern C {
defined(__cplusplus) \
( defined(__GXX_EXPERIMENTAL_CXX0X__) || __cplusplus
= 201103L )
#define SAL_MATH_FINITE(d) std::isfinite(d)
+#elif defined( IOS )
+#define SAL_MATH_FINITE(d) isfinite(d)
#elif defined( WNT)
#define SAL_MATH_FINITE(d) _finite(d)
#elif defined LINUX || defined UNX
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: accessibility/source
accessibility/source/extended/textwindowaccessibility.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 465ab1c1263b76e3284f18219678e46a211c5605
Author: Julien Nabet serval2...@yahoo.fr
Date: Thu Nov 1 20:19:55 2012 +0100
Related: fdo#56473 IDE: Crash when inserting a simple macro
After having discussed with Michael Meeks, a better way would be to be
iterator free
Now, should all textwindowaccessibility part be iterator free?
Change-Id: I8079b3ffbc9d37bc2c3b9ede088485dd3a7e410e
diff --git a/accessibility/source/extended/textwindowaccessibility.cxx
b/accessibility/source/extended/textwindowaccessibility.cxx
index 620ff0f..1e2da2e 100644
--- a/accessibility/source/extended/textwindowaccessibility.cxx
+++ b/accessibility/source/extended/textwindowaccessibility.cxx
@@ -2127,11 +2127,11 @@ void Document::notifySelectionChange( sal_Int32 nFirst,
sal_Int32 nLast )
if ( nFirst nLast )
{
Paragraphs::iterator aItBound1 = m_xParagraphs-begin();
-for (sal_Int32 i = 0; i nLast aItBound1 != m_xParagraphs-end()
; ++aItBound1);
+for (sal_Int32 i = 0; i nLast aItBound1 != m_xParagraphs-end()
; ++aItBound1, ++i);
Paragraphs::iterator aEnd( ::std::min( aItBound1, m_aVisibleEnd ) );
Paragraphs::iterator aItBound2 = m_xParagraphs-begin();
-for (sal_Int32 i = 0; i nFirst aItBound2 != m_xParagraphs-end()
; ++aItBound2);
+for (sal_Int32 i = 0; i nFirst aItBound2 != m_xParagraphs-end()
; ++aItBound2, ++i);
for ( Paragraphs::iterator aIt = ::std::max( aItBound2,
m_aVisibleBegin ); aIt != aEnd; ++aIt )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - sc/inc sc/source
sc/inc/attarray.hxx | 15 +---
sc/inc/column.hxx| 70 ---
sc/source/core/data/attarray.cxx | 14 ---
sc/source/core/data/column.cxx | 29
sc/source/core/data/column2.cxx | 39 +
sc/source/core/data/column3.cxx |3 +
6 files changed, 89 insertions(+), 81 deletions(-)
New commits:
commit 0712695c970371bce2a2f5074a7028ef97cdb715
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Nov 2 17:53:12 2012 -0400
More methods that can be marked const.
Change-Id: Ia3eb38ae6500463c41e6935a169fa1ac08edc681
diff --git a/sc/inc/attarray.hxx b/sc/inc/attarray.hxx
index 3af278f..7379bbf 100644
--- a/sc/inc/attarray.hxx
+++ b/sc/inc/attarray.hxx
@@ -148,10 +148,13 @@ public:
SCsROW GetNextUnprotected( SCsROW nRow, bool bUp ) const;
/// May return -1 if not found
-SCsROW SearchStyle( SCsROW nRow, const ScStyleSheet* pSearchStyle,
-bool bUp, ScMarkArray* pMarkArray = NULL );
-boolSearchStyleRange( SCsROW rRow, SCsROW rEndRow, const
ScStyleSheet* pSearchStyle,
-bool bUp, ScMarkArray* pMarkArray = NULL );
+SCsROW SearchStyle(
+SCsROW nRow, const ScStyleSheet* pSearchStyle, bool bUp,
+const ScMarkArray* pMarkArray = NULL) const;
+
+bool SearchStyleRange(
+SCsROW rRow, SCsROW rEndRow, const ScStyleSheet* pSearchStyle, bool
bUp,
+const ScMarkArray* pMarkArray = NULL) const;
boolApplyFlags( SCROW nStartRow, SCROW nEndRow, sal_Int16 nFlags );
boolRemoveFlags( SCROW nStartRow, SCROW nEndRow, sal_Int16 nFlags );
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index 2ef0b02..402d62f 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -199,20 +199,20 @@ public:
SCCOL GetCol() const { return nCol; }
// UpdateSelectionFunction: multi-select
-void UpdateSelectionFunction( const ScMarkData rMark,
-ScFunctionData rData,
-ScFlatBoolRowSegments rHiddenRows,
-bool bDoExclude, SCROW nExStartRow, SCROW
nExEndRow );
-voidUpdateAreaFunction( ScFunctionData rData,
-ScFlatBoolRowSegments rHiddenRows,
-SCROW nStartRow, SCROW nEndRow );
+void UpdateSelectionFunction(
+const ScMarkData rMark, ScFunctionData rData, ScFlatBoolRowSegments
rHiddenRows,
+bool bDoExclude, SCROW nExStartRow, SCROW nExEndRow ) const;
+
+void UpdateAreaFunction(
+ScFunctionData rData, ScFlatBoolRowSegments rHiddenRows, SCROW
nStartRow, SCROW nEndRow) const;
void CopyToColumn(
SCROW nRow1, SCROW nRow2, sal_uInt16 nFlags, bool bMarked,
ScColumn rColumn, const ScMarkData* pMarkData = NULL, bool bAsLink =
false) const;
-voidUndoToColumn(SCROW nRow1, SCROW nRow2, sal_uInt16 nFlags, bool
bMarked,
-ScColumn rColumn, const ScMarkData* pMarkData
= NULL );
+void UndoToColumn(
+SCROW nRow1, SCROW nRow2, sal_uInt16 nFlags, bool bMarked,
+ScColumn rColumn, const ScMarkData* pMarkData = NULL) const;
voidCopyScenarioFrom( const ScColumn rSrcCol );
voidCopyScenarioTo( ScColumn rDestCol ) const;
@@ -318,10 +318,13 @@ public:
boolIsStyleSheetUsed( const ScStyleSheet rStyle, bool
bGatherAllStyles ) const;
/// May return -1 if not found
-SCsROW SearchStyle( SCsROW nRow, const ScStyleSheet* pSearchStyle,
-bool bUp, bool bInSelection, const ScMarkData
rMark );
-boolSearchStyleRange( SCsROW rRow, SCsROW rEndRow, const
ScStyleSheet* pSearchStyle,
-bool bUp, bool bInSelection, const
ScMarkData rMark );
+SCsROW SearchStyle(
+SCsROW nRow, const ScStyleSheet* pSearchStyle, bool bUp, bool
bInSelection,
+const ScMarkData rMark) const;
+
+bool SearchStyleRange(
+SCsROW rRow, SCsROW rEndRow, const ScStyleSheet* pSearchStyle, bool
bUp,
+bool bInSelection, const ScMarkData rMark) const;
boolApplyFlags( SCROW nStartRow, SCROW nEndRow, sal_Int16 nFlags );
boolRemoveFlags( SCROW nStartRow, SCROW nEndRow, sal_Int16 nFlags );
@@ -335,20 +338,20 @@ public:
voidClearSelectionItems( const sal_uInt16* pWhich, const
ScMarkData rMark );
voidChangeSelectionIndent( bool bIncrement, const ScMarkData
rMark );
-longGetNeededSize( SCROW nRow, OutputDevice* pDev,
-double nPPTX, double nPPTY,
-const Fraction rZoomX, const Fraction
rZoomY,
-bool bWidth, const ScNeededSizeOptions
rOptions );
-
[Libreoffice-commits] .: more_fonts/fonts
more_fonts/fonts/ttf_amt/makefile.mk | 59 --- more_fonts/fonts/ttf_dejavu/makefile.mk| 61 more_fonts/fonts/ttf_gentium/makefile.mk | 61 more_fonts/fonts/ttf_liberation/makefile.mk| 52 - more_fonts/fonts/ttf_liberation_narrow/makefile.mk | 63 - more_fonts/fonts/ttf_linlibertineg/makefile.mk | 60 6 files changed, 356 deletions(-) New commits: commit c3c6fab79bfd33fbc170b8dca86a480f4676ba35 Author: Andras Timar ati...@suse.com Date: Fri Nov 2 23:11:46 2012 +0100 remove dmake files from more_fonts module Change-Id: I25fa2d5e89614177ecc87e74a85ece4852f032a6 diff --git a/more_fonts/fonts/ttf_amt/makefile.mk b/more_fonts/fonts/ttf_amt/makefile.mk deleted file mode 100644 index 6e54dc7..000 --- a/more_fonts/fonts/ttf_amt/makefile.mk +++ /dev/null @@ -1,59 +0,0 @@ -#* -# -# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. -# -# Copyright 2000, 2010 Oracle and/or its affiliates. -# -# OpenOffice.org - a multi-platform office productivity suite -# -# This file is part of OpenOffice.org. -# -# OpenOffice.org is free software: you can redistribute it and/or modify -# it under the terms of the GNU Lesser General Public License version 3 -# only, as published by the Free Software Foundation. -# -# OpenOffice.org is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU Lesser General Public License version 3 for more details -# (a copy is included in the LICENSE file that accompanied this code). -# -# You should have received a copy of the GNU Lesser General Public License -# version 3 along with OpenOffice.org. If not, see -# http://www.openoffice.org/license.html -# for a copy of the LGPLv3 License. -# -#* - -PRJ=..$/.. - -PRJNAME=more_fonts -TARGET=ttf_amt - -# --- Settings - - -.INCLUDE : settings.mk - -# --- Files - -TARFILE_NAME=agfa-monotype-fonts -TARFILE_MD5=9bad41ce5c3fd069b87f28aeac70314d -TARFILE_ROOTDIR=agfa-monotype-fonts - -PATCH_FILES= - -CONFIGURE_DIR= -CONFIGURE_ACTION= - -BUILD_DIR= -BUILD_ACTION= -BUILD_FLAGS= - -# --- Targets -- - -.INCLUDE : set_ext.mk -.INCLUDE : target.mk - -.IF $(WITH_AGFA_MONOTYPE_FONTS) == YES -.INCLUDE : tg_ext.mk -.ENDIF diff --git a/more_fonts/fonts/ttf_dejavu/makefile.mk b/more_fonts/fonts/ttf_dejavu/makefile.mk deleted file mode 100644 index 499086b..000 --- a/more_fonts/fonts/ttf_dejavu/makefile.mk +++ /dev/null @@ -1,61 +0,0 @@ -#* -# -# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. -# -# Copyright 2000, 2010 Oracle and/or its affiliates. -# -# OpenOffice.org - a multi-platform office productivity suite -# -# This file is part of OpenOffice.org. -# -# OpenOffice.org is free software: you can redistribute it and/or modify -# it under the terms of the GNU Lesser General Public License version 3 -# only, as published by the Free Software Foundation. -# -# OpenOffice.org is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU Lesser General Public License version 3 for more details -# (a copy is included in the LICENSE file that accompanied this code). -# -# You should have received a copy of the GNU Lesser General Public License -# version 3 along with OpenOffice.org. If not, see -# http://www.openoffice.org/license.html -# for a copy of the LGPLv3 License. -# -#* - -PRJ=..$/.. - -PRJNAME=more_fonts -TARGET=ttf_dejavu - -# --- Settings - - -.INCLUDE : settings.mk - -# --- Files - -TARFILE_NAME=dejavu-fonts-ttf-2.33 -TARFILE_MD5=f872f4ac066433d8ff92f5e316b36ff9 -TARFILE_ROOTDIR=dejavu-fonts-ttf-2.33 - -PATCH_FILES= - - -CONFIGURE_DIR= -CONFIGURE_ACTION= - -BUILD_DIR= -BUILD_ACTION= -BUILD_FLAGS= - -# --- Targets -- - -.INCLUDE : set_ext.mk -.INCLUDE : target.mk - -.IF $(WITH_FONTS)!=NO -.INCLUDE : tg_ext.mk -.ENDIF - diff --git a/more_fonts/fonts/ttf_gentium/makefile.mk b/more_fonts/fonts/ttf_gentium/makefile.mk deleted file mode 100644 index 53177e8..000 --- a/more_fonts/fonts/ttf_gentium/makefile.mk +++ /dev/null @@ -1,61 +0,0 @@
[Libreoffice-commits] .: 2 commits - config_host.mk.in configure.ac hsqldb/UnpackedTarball_hsqldb.mk hsqldb/version.mk librsvg/Library_librsvg-2-2.mk ooo.lst.in ucpp/UnpackedTarball_ucpp.mk
config_host.mk.in|4 +++- configure.ac |4 hsqldb/UnpackedTarball_hsqldb.mk |4 +--- hsqldb/version.mk|6 -- librsvg/Library_librsvg-2-2.mk |9 +++-- ooo.lst.in |6 +++--- ucpp/UnpackedTarball_ucpp.mk |2 +- 7 files changed, 19 insertions(+), 16 deletions(-) New commits: commit 56e40f3c602f7c85f61e5a196e3d820935b0c139 Author: Matúš Kukan matus.ku...@gmail.com Date: Sat Nov 3 00:23:14 2012 +0100 librsvg: selectively export symbols we need Change-Id: I892bea3b3a30ef84937e410b10f37a814213363b diff --git a/librsvg/Library_librsvg-2-2.mk b/librsvg/Library_librsvg-2-2.mk index 2dfb2bc..66e1d12 100644 --- a/librsvg/Library_librsvg-2-2.mk +++ b/librsvg/Library_librsvg-2-2.mk @@ -24,10 +24,15 @@ $(eval $(call gb_Library_use_externals,librsvg-2-2,\ pixbuf \ )) -# Generate a import library +ifeq ($(COM),MSC) $(eval $(call gb_Library_add_ldflags,librsvg-2-2,\ - -EXPORT:GetVersionInfo \ + /EXPORT:rsvg_init \ + /EXPORT:rsvg_handle_new_from_data \ + /EXPORT:rsvg_handle_set_dpi_x_y \ + /EXPORT:rsvg_handle_get_dimensions \ + /EXPORT:rsvg_handle_render_cairo \ )) +endif $(eval $(call gb_Library_add_defs,librsvg-2-2,\ -DHAVE_GSF \ commit d281a19e1d06856f863788f3344ad42ed159 Author: Matúš Kukan matus.ku...@gmail.com Date: Thu Nov 1 22:11:56 2012 +0100 these have been converted; use _tarball variables Change-Id: I9215fbfaf5c2e5d40e7257cd52d8d9544599ea63 diff --git a/config_host.mk.in b/config_host.mk.in index 0317bef..08d1bed 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -259,6 +259,7 @@ export HAVE_READDIR_R=@HAVE_READDIR_R@ export HAVE_THREADSAFE_STATICS=@HAVE_THREADSAFE_STATICS@ export HOST_PLATFORM=@host@ export HSQLDB_JAR=@HSQLDB_JAR@ +export HSQLDB_TARBALL=@HSQLDB_TARBALL@ export HSQLDB_USE_JDBC_4_1=@HSQLDB_USE_JDBC_4_1@ export HUNART_EXTENSION_PACK=@HUNART_EXTENSION_PACK@ export HUNSPELL_TARBALL=@HUNSPELL_TARBALL@ @@ -626,6 +627,7 @@ export SYSTEM_REDLAND=@SYSTEM_REDLAND@ export SYSTEM_RHINO=@SYSTEM_RHINO@ export SYSTEM_SERVLETAPI=@SYSTEM_SERVLETAPI@ export SYSTEM_STDLIBS=@SYSTEM_STDLIBS@ +export SYSTEM_UCPP=@SYSTEM_UCPP@ export SYSTEM_VIGRA=@SYSTEM_VIGRA@ export SYSTEM_ZLIB=@SYSTEM_ZLIB@ export TARFILE_LOCATION=@TARFILE_LOCATION@ @@ -636,7 +638,7 @@ export THES_SYSTEM_DIR=@THES_SYSTEM_DIR@ export TMPDIR=@TEMP_DIRECTORY@ export TOMCAT_TARBALL=@TOMCAT_TARBALL@ export TYPO_EXTENSION_PACK=@TYPO_EXTENSION_PACK@ -export SYSTEM_UCPP=@SYSTEM_UCPP@ +export UCPP_TARBALL=@UCPP_TARBALL@ export UNIXWRAPPERNAME=@UNIXWRAPPERNAME@ export UNOWINREG_DLL=@UNOWINREG_DLL@ export UPD=@UPD@ diff --git a/configure.ac b/configure.ac index 9a9689a..f6a7fec 100644 --- a/configure.ac +++ b/configure.ac @@ -6553,10 +6553,12 @@ else AC_PATH_PROG(SYSTEM_UCPP, ucpp) else AC_MSG_RESULT([internal]) +UCPP_TARBALL=0168229624cfac409e766913506961a8-ucpp-1.3.2.tar.gz BUILD_TYPE=$BUILD_TYPE UCPP fi fi AC_SUBST(SYSTEM_UCPP) +AC_SUBST(UCPP_TARBALL) dnl === dnl Check for epm (not needed for Windows) @@ -7678,6 +7680,7 @@ if test $with_system_hsqldb = yes; then else AC_MSG_RESULT([internal]) SYSTEM_HSQLDB=NO +HSQLDB_TARBALL=17410483b5b5f267aa18b7e00b65e6e0-hsqldb_1_8_0.zip BUILD_TYPE=$BUILD_TYPE HSQLDB AC_MSG_CHECKING([whether hsqldb should be built with JDBC 4.1]) javanumver=`$JAVAINTERPRETER -version 21 | $AWK -v num=true -f $SRC_ROOT/solenv/bin/getcompver.awk` @@ -7690,6 +7693,7 @@ else fi AC_SUBST(SYSTEM_HSQLDB) AC_SUBST(HSQLDB_JAR) +AC_SUBST(HSQLDB_TARBALL) AC_SUBST([HSQLDB_USE_JDBC_4_1]) fi diff --git a/hsqldb/UnpackedTarball_hsqldb.mk b/hsqldb/UnpackedTarball_hsqldb.mk index 186b491..af78834 100644 --- a/hsqldb/UnpackedTarball_hsqldb.mk +++ b/hsqldb/UnpackedTarball_hsqldb.mk @@ -7,11 +7,9 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. # -include $(SRCDIR)/hsqldb/version.mk - $(eval $(call gb_UnpackedTarball_UnpackedTarball,hsqldb)) -$(eval $(call gb_UnpackedTarball_set_tarball,hsqldb,17410483b5b5f267aa18b7e00b65e6e0-hsqldb_$(HSQLDB_VERSION).zip)) +$(eval $(call gb_UnpackedTarball_set_tarball,hsqldb,$(HSQLDB_TARBALL))) $(eval $(call gb_UnpackedTarball_fix_end_of_line,hsqldb,\ build/build.xml \ diff --git a/hsqldb/version.mk b/hsqldb/version.mk deleted file mode 100644 index 36ab376..000 --- a/hsqldb/version.mk +++ /dev/null @@ -1,6 +0,0 @@ -# when you want to change the HSQLDB version, you must update the d.lst -# in the HSQLDB_thon project accordingly !!! -HSQLDB_MAJOR=1 -HSQLDB_MINOR=8 -HSQLDB_MICRO=0 -HSQLDB_VERSION=$(HSQLDB_MAJOR)_$(HSQLDB_MINOR)_$(HSQLDB_MICRO) diff --git a/ooo.lst.in b/ooo.lst.in index 8f50cd2..44caf08 100644 --- a/ooo.lst.in +++ b/ooo.lst.in @@ -3,7 +3,6 @@
[Libreoffice-commits] .: l10ntools/source
l10ntools/source/lngmerge.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit c1b4077d1ffa57d325bf1149ac198d91cf981e3b Author: Andras Timar ati...@suse.com Date: Sat Nov 3 00:35:14 2012 +0100 escape quotes, unescape double escaped quotes fdo#56648 Change-Id: Id4135db2ec40865cddab533da15b2705dc7b73d5 diff --git a/l10ntools/source/lngmerge.cxx b/l10ntools/source/lngmerge.cxx index b0282f5..00a58d2 100644 --- a/l10ntools/source/lngmerge.cxx +++ b/l10ntools/source/lngmerge.cxx @@ -264,7 +264,8 @@ sal_Bool LngParser::Merge( rtl::OString sText1( sLang ); sText1 += = \; -sText1 += sNewText; +// escape quotes, unescape double escaped quotes fdo#56648 +sText1 += sNewText.replaceAll(\,\\\).replaceAll(\,\\\); sText1 += \; *pLine = sText1; Text[ sLang ] = sNewText; @@ -299,7 +300,8 @@ sal_Bool LngParser::Merge( rtl::OString sLine; sLine += sCur; sLine += = \; -sLine += sNewText; +// escape quotes, unescape double escaped quotes fdo#56648 +sLine += sNewText.replaceAll(\,\\\).replaceAll(\,\\\); sLine += \; nLastLangPos++; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Change in core[libreoffice-3-6]: escape quotes, unescape double escaped quotes fdo#56648
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/972 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/972/1 escape quotes, unescape double escaped quotes fdo#56648 Change-Id: Id24d0ec9d2c8c908fca8e4b9083bf73951dc3637 --- M l10ntools/source/lngmerge.cxx 1 file changed, 4 insertions(+), 2 deletions(-) -- To view, visit https://gerrit.libreoffice.org/972 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id24d0ec9d2c8c908fca8e4b9083bf73951dc3637 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Andras Timar ati...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: connectivity/source
connectivity/source/inc/ado/Aolewrap.hxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit ac2cfed553b8c9303f86758e9fe8b70911db00cd
Author: David Ostrovsky da...@ostrovsky.org
Date: Sat Nov 3 01:09:35 2012 +0100
fdo#53070 fix access violation
Through that different initialization pIUnknown
got random address. The consequence was that
if (pIUnknown)
pIUnknown-Release();
ends with access viloation in
WpBase WpBase::operator=(const WpBase rhs)
Change-Id: I8b3c5de233d0868fea052c990cc83aed917117ae
diff --git a/connectivity/source/inc/ado/Aolewrap.hxx
b/connectivity/source/inc/ado/Aolewrap.hxx
index 6f428bf..4e1debe 100644
--- a/connectivity/source/inc/ado/Aolewrap.hxx
+++ b/connectivity/source/inc/ado/Aolewrap.hxx
@@ -94,9 +94,8 @@ namespace connectivity
}
WpOLEBase(const WpOLEBaseT aWrapper)
-: WpBase(aWrapper)
-, pInterface(aWrapper.pInterface)
{
+operator=(aWrapper);
}
virtual ~WpOLEBase()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 53070, which changed state. Bug 53070 Summary: freeze/hang when connecting to ADO source (e.g. MS Access 2003 mdb / 2007 accdb) https://bugs.freedesktop.org/show_bug.cgi?id=53070 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: no functional TinderBox for master/3-7 full Windows builds
Stuart, i am glad it worked for you ... and yes it was a debug build ;-) On 03.11.2012 01:01, V Stuart Foote wrote: With that minor work around--I'm comfortable saying your Windows build is a workable alternative to a Tinderbox:) The user setting is not 100% reliable, and I have some input on what I'm seeing. So I'm going to open a new thread on the EnableATToolSupport registry value, hope you are OK with that. Just put me on CC for that. Regards David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[BUG 56704] a11y - EnableATToolSupport registry setting unreliable, sporadic Java Accessibility AT support for Windows users
With a working MSVC 2010 build of master /3-7 for Windows now able to finally get into the a11y support for Java Accessibility in Windows with Java Access Bridge. Two open BUGs fdo#39833 https://bugs.freedesktop.org/show_bug.cgi?id=39833 and fdo#56704 https://bugs.freedesktop.org/show_bug.cgi?id=56704 fdo#39833 was an enhancement to add a check box to the Windows installer to support assistive technology tools with a single well exposed action for Windows users requiring AT. fdo#56704 is initial results of a MSVC 2010 build of master /3-7 for windows, reporting that while Java Access Bridge mapping into Java Accessibility was exposing AT roles enabling JAB and the assistive technology tools for windows was not happening consistently. And that the fdo#39833 enhancement of the support assistive technology tools check box selection during installation was not really working well. Kind of hope others with working Windows builds of master can confirm the errant configuration and behavior using both methods of setting the libreoffice registry stanzas for EnableATToolSupport and the truncated user profiles. -- View this message in context: http://nabble.documentfoundation.org/BUG-56704-a11y-EnableATToolSupport-registry-setting-unreliable-sporadic-Java-Accessibility-AT-suppors-tp4016596.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - sw/inc sw/source
sw/inc/doc.hxx | 20 ++-- sw/inc/editsh.hxx |8 sw/inc/list.hxx|2 +- sw/source/core/crsr/crsrsh.cxx |4 ++-- sw/source/core/doc/doclay.cxx |4 ++-- sw/source/core/doc/docnum.cxx | 26 +- sw/source/core/doc/list.cxx|6 +++--- sw/source/core/doc/poolfmt.cxx |2 +- sw/source/core/edit/ednumber.cxx | 14 +++--- sw/source/core/undo/SwUndoFmt.cxx |4 ++-- sw/source/core/undo/unnum.cxx |4 ++-- sw/source/core/unocore/unosett.cxx |2 +- sw/source/filter/rtf/rtfnum.cxx|8 sw/source/filter/ww8/ww8par2.cxx |4 ++-- sw/source/filter/ww8/ww8par3.cxx |2 +- sw/source/ui/app/docstyle.cxx |2 +- sw/source/ui/docvw/edtwin.cxx |2 +- 17 files changed, 57 insertions(+), 57 deletions(-) New commits: commit 2a9fd5d68304beebcffd2f6a66e65c95eb433c40 Author: Takeshi Abe t...@fixedpoint.jp Date: Sat Nov 3 12:18:57 2012 +0900 sal_Bool to bool Change-Id: I35412e2d2e36e3eabdff2a6692bf6edc68a2d724 diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx index 86f90b5..372f8b6 100644 --- a/sw/inc/doc.hxx +++ b/sw/inc/doc.hxx @@ -1515,7 +1515,7 @@ public: /// add optional parameter eDefaultNumberFormatPositionAndSpaceMode sal_uInt16 MakeNumRule( const String rName, const SwNumRule* pCpy = 0, -sal_Bool bBroadcast = sal_False, +bool bBroadcast = false, const SvxNumberFormat::SvxNumPositionAndSpaceMode eDefaultNumberFormatPositionAndSpaceMode = SvxNumberFormat::LABEL_WIDTH_AND_POSITION ); sal_uInt16 FindNumRule( const String rName ) const; @@ -1525,7 +1525,7 @@ public: bool RenameNumRule(const String aOldName, const String aNewName, bool bBroadcast = false); bool DelNumRule( const String rName, bool bBroadCast = false ); -String GetUniqueNumRuleName( const String* pChkStr = 0, sal_Bool bAutoNum = sal_True ) const; +String GetUniqueNumRuleName( const String* pChkStr = 0, bool bAutoNum = true ) const; void UpdateNumRule(); /// Update all invalids. void ChgNumRuleFmts( const SwNumRule rRule, const String * pOldName = 0 ); @@ -1584,7 +1584,7 @@ public: according to offsets. (if negative: go to doc start). */ bool MoveParagraph( const SwPaM, long nOffset = 1, bool bIsOutlMv = false ); -sal_Bool NumOrNoNum( const SwNodeIndex rIdx, sal_Bool bDel = sal_False); +bool NumOrNoNum( const SwNodeIndex rIdx, sal_Bool bDel = sal_False); void StopNumRuleAnimations( OutputDevice* ); @@ -1971,12 +1971,12 @@ public: @param sListIdlist Id of the list whose level has to be marked/unmarked @param nListLevel level to mark -@param bValue - sal_True mark the level - - sal_False unmark the level +@param bValue - true mark the level + - false unmark the level */ void MarkListLevel( const String sListId, const int nListLevel, -const sal_Bool bValue ); +const bool bValue ); /** Marks/Unmarks a list level of a certain list @@ -1984,12 +1984,12 @@ public: @param rList list whose level has to be marked/unmarked @param nListLevel level to mark -@param bValue - sal_True mark the level - - sal_False unmark the level +@param bValue - true mark the level + - false unmark the level */ void MarkListLevel( SwList rList, const int nListLevel, -const sal_Bool bValue ); +const bool bValue ); /// Change a format undoable. void ChgFmt(SwFmt rFmt, const SfxItemSet rSet); @@ -2019,7 +2019,7 @@ public: */ String GetPaMDescr(const SwPaM rPaM) const; -sal_Bool IsFirstOfNumRule(SwPosition rPos); +bool IsFirstOfNumRule(SwPosition rPos); // access methods for XForms model(s) diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx index add80c3..65c19b8 100644 --- a/sw/inc/editsh.hxx +++ b/sw/inc/editsh.hxx @@ -502,7 +502,7 @@ public: bool MoveNumParas( bool bUpperLower, bool bUpperLeft ); /// Switch on/off of numbering via Delete/Backspace. -sal_Bool NumOrNoNum( sal_Bool bDelete = sal_False, sal_Bool bChkStart = sal_True); +bool NumOrNoNum( sal_Bool bDelete = sal_False, bool bChkStart = true); // #i23726# // #i90078# @@ -511,8 +511,8 @@ public: void ChangeIndentOfAllListLevels( short nDiff ); // Adjust method name void SetIndent(short nIndent, const SwPosition rPos); -sal_Bool IsFirstOfNumRule() const; -sal_Bool IsFirstOfNumRule(const SwPaM rPaM) const; +bool IsFirstOfNumRule() const; +bool IsFirstOfNumRule(const SwPaM
Re: [Libreoffice-qa] 3.7 bug hunt party ?
Cor Nouws schrieb: a - hunting bugs in 3.7 Hi Cor, intensive Bug wrangling always is good, but currently I have more concerns how to get a working 3.6.3 (at least for me that's completely unusable). 3 Weeks ago (or so) I was frustrated that we still had nearby 300 UNCONFIRMED 3.6. possible regressions, now we have more than 430 [1], and I think reviewing these Bugs currently is the most important task to be done. Best Regards Rainer Hyperlinks: [1] https://bugs.freedesktop.org/buglist.cgi?cmdtype=doremremaction=runnamedcmd=362triagesharer_id=19321list_id=156183 ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] 3.7 bug hunt party ?
Hi Rainer, Rainer Bielefeld wrote (02-11-12 09:18) Cor Nouws schrieb: a - hunting bugs in 3.7 intensive Bug wrangling always is good, but [...] 3 Weeks ago (or so) I was frustrated that we still had nearby 300 UNCONFIRMED 3.6. possible regressions, now we have more than 430 [1], and I think reviewing these Bugs currently is the most important task to be done. So then I suggest that we make triage of open bugs a goal as well, under the flag of 3.7-bug hunt party - which hopefully will attract lots of hands. Best, -- - Cor - http://nl.libreoffice.org - www.librelex.org ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] 3.6 Features webpage -- update Most Annoying Bugs section
Hi Marc, On Fri, 2012-11-02 at 05:25 -0400, Marc Paré wrote: Unless I am mistaken, all the bugs mentioned in the Most Annoying Bugs section (bottom of page) of our 3.6 Features webpage have been resolved? Can I go ahead and update that section with strike-throughs and mark them as resolved?[1] Sounds good to me; I imagine completely removing them would be a good idea. IMHO it'd be good to have the windows/a11y nasty there at least until we ship 3.6.4. Good to leave the MAB link I guess :-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Online update testing
Hi Pedro, On Wed, 2012-10-24 at 03:20 -0700, Pedro wrote: ol klaus-jürgen weghorn wrote my 3.6.2.1 is up to date. Shouldn't be so. My 3.5.7.1 install reports LibreOffice 3.5 is up to date. Shouldn't be so. Sorry - I've not published the ESC minutes yet; Kendy is pulling the lever to upgrade 3.5.0-3 to 3.6.3 - and we planned to wait a week to see if there are any user-horror stories before promoting 3.6.3 to everyone as the upgrade path. Does that make sense ? ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] minutes of ESC call ...
* Present: + Kendy, Stephan, Eike, Markus, Michael M, Petr, Lubos, Norbert, Thorsten, Caolan, Ahmad. + bad week for US overlap; regrets from Joel etc. * Completed Action Items + issues to look into if we can + fdo#34548 - review Michael's patch (Thorsten) + not happy, not pushing + get more details wrt. new hardware connect (Norbert / Sophie) + ongoing. + re-order / update the HardHacks page (Joel) + adding fdo#40594 - to the live list of five. * Pending Action Items + create a new AmbitiousHacks wiki page, based on GSOC page (Michael M) + audit set of new / built-in fonts (Caolan) + poke UX advise wrt. how to improve color management UI team (Markus) + issues to look into if we can + fdo#55360 - mac specific text issue (Thorsten) + fdo#51023 - impress DD crasher - (Radek) + set updater to get 3.5.0..2 - 3.6.2 (Kendy) + instead re-direct to 3.6.3 - but delay until tomorrow to avoid un-synched mirror load. + create script / suggestions to parse Meeks minutes (Bjoern) + font bundling and gerrit fun with Astron (Andras) + patch / improvements coming from Astron + provide a new palette based on Tango (Alex?) + minimal triage for good mentors for proposed easy hacks (Bjoern) + setup call for designs for FOSDEM T-shirts (Astron) + needs feedback from Kendy - Mirek * Release Engineering update (Petr) + Petr back and mostly recovered from honeymoon + 3.6.3 retrospective + sadly missing a11y fix queued for 3.6.4 AI: + add a11y issue to release notes (Thorsten) + thanks to all for fixing reviews + 3.6.4 rc1 branch deadline is Nov 12th + on-line update / full switch-over go/no-go + delay for one week. + 3.7 timeline: Dec 3rd - week 47 + feature-freeze 4 weeks out. * Motah introduction (Ahmad) + KACST - government sponsored institute + first project to improve Arabic LibreOffice support + fix bugs, errors around RTL, Arabic translation etc. + feature work planned further out + Arabic wiki + documentation work is done + open-source engineer, on LibreOffice for four months * 4.0 decision + preference for simple rules, not specifics (Kendy) + minimise the impact on all users / ext'n developers + smaller ongoing changes - with bigger revisions / compatibility code, deprecations etc. + more details / solvable individual case-by-case issues to be discussed on the lists. + proceeding with plans. + two different issues (Stephan) + handling incompatibility in 4.0 ? + are we in-time to switch 3.7 to 4.0 ? + are we in-time to switch to 4.0 ? + never a good time to switch with incremental time-based releases (Kendy) + hence ~never having a big bang, introducing small changes over time. + why decide now, not at the outset of the release ? if we know six months in advance - we'll release 4.0, more room for manoever. + we've discussed this for months with no decision + now we agree - what's in there / how to break it why not delay one release ? (Norbert) + had a plan for this for over a year - cf. wiki page (Kendy) + if we don't do big breakage - why wait ? (Michael) + ABI breakage is not a binary thing (mst, Norbert) + not able to do the work in the wiki in in 4 weeks (mst) + ~none of us has done much of the 4.0 page yet (Stephan) + are there are more things to do for a 4.0 ? (Stephan) + higher quality / better feature-set. + alternative - summer release of 4.0 + still have issues getting it all done, can we can continue to break things in 4.1 ? + is it better to have a 4.0 with lots of new features and little breakage ? or not. + desire to keep changes as small as possible whatever (Stephan) + user-installation changes required (Stephan) + can we clean that up in advance ? + should we stick with the /3 directory ? + how about berkelydb removal - does that break things anyway ? + we can't do all the changes we want to do in one release (Lubos) + could we plan to do 5.0 after a couple of releases ? + if so engrave those dates in stone to avoid
Re: [Libreoffice-qa] minutes of the QA Call tomorrow, Tuesday 1300UTC
Sophie Gautier píše v St 31. 10. 2012 v 18:18 +0100: On 31/10/2012 16:36, Florian Effenberger wrote: Hi, Petr Mladek wrote on 2012-10-31 15:35: I have seen that people put large test documents into wiki and mentioned links in bugzilla or E-mails. Another solution would be a write-only annonymous ftp. It would be easier for clean up. I am not sure how complicated would be a secure and usable setup. what exactly would you need? Some way to only send files (like anonymous FTP upload without public download), or a way to share documents? In the latter case, I'd rather use some web service, so we are not abused as file sharing platform... I wonder if wiki is good for this purpose or it there is a better solutions. I am afraid that we could not increase the limit in bugzilla easily. A simple way for users who want to report a bug to send example documents to our QA team. May be you can simply allow to send attachments to the q...@fr.libreoffice.org list? Are attachments completely disabled on the q...@fr.libreoffice.org mailing list? IMHO, a good practice is to allow attachments up to 100kB. Large documents should wait for moderator approval. In general, big attachments are not a good idea because of the multiplication effect (too many receivers). Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of the QA Call tomorrow, Tuesday 1300UTC
Hi, Petr Mladek wrote on 2012-11-02 14:12: I wonder if wiki is good for this purpose or it there is a better solutions. I am afraid that we could not increase the limit in bugzilla easily. the wiki is used for that, lacking alternatives, but it is definitely not optimal. :/ If you let me know what you need, I can see if we can set up e.g. a web service for doing so. Anonymous FTP is a risk becuase everyone can abuse us as filehoster then, but would something with authentication people can sign up via email, like done on the wiki, be sufficient? Are attachments completely disabled on the q...@fr.libreoffice.org mailing list? IMHO, a good practice is to allow attachments up to 100kB. Large documents should wait for moderator approval. In general, big attachments are not a good idea because of the multiplication effect (too many receivers). They're fully disabled on purpose. I'd be hesitant enabling them, especially because it also requires some development work on our side regarding the filters. Right now it's all or nothing, i.e. no attachments or all attachments... Florian -- Florian Effenberger, Chairman of the Board (Vorstandsvorsitzender) Tel: +49 8341 99660880 | Mobile: +49 151 14424108 The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts Legal details: http://www.documentfoundation.org/imprint ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of the QA Call tomorrow, Tuesday 1300UTC
On 02/11/2012 16:13, Florian Effenberger wrote: Hi, Petr Mladek wrote on 2012-11-02 14:12: I wonder if wiki is good for this purpose or it there is a better solutions. I am afraid that we could not increase the limit in bugzilla easily. the wiki is used for that, lacking alternatives, but it is definitely not optimal. :/ If you let me know what you need, I can see if we can set up e.g. a web service for doing so. Anonymous FTP is a risk becuase everyone can abuse us as filehoster then, but would something with authentication people can sign up via email, like done on the wiki, be sufficient? What we need is a very simple way for a French user to send an attachment. If he needs to subscribe or register elsewhere and elsewhere again, I fear we'll just have to close the bug because he will never come back. Are attachments completely disabled on the q...@fr.libreoffice.org mailing list? IMHO, a good practice is to allow attachments up to 100kB. Large documents should wait for moderator approval. In general, big attachments are not a good idea because of the multiplication effect (too many receivers). They're fully disabled on purpose. I'd be hesitant enabling them, especially because it also requires some development work on our side regarding the filters. Right now it's all or nothing, i.e. no attachments or all attachments... For a list like QA@fr and the process we try to put in place it could be a good solution however. Kind regards Sophie -- Sophie Gautier sophie.gaut...@documentfoundation.org Tel:+33683901545 Membership Certification Committee Member - Co-founder The Document Foundation ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of the QA Call tomorrow, Tuesday 1300UTC
Florian Effenberger píše v Pá 02. 11. 2012 v 16:13 +0100: Hi, Petr Mladek wrote on 2012-11-02 14:12: I wonder if wiki is good for this purpose or it there is a better solutions. I am afraid that we could not increase the limit in bugzilla easily. the wiki is used for that, lacking alternatives, but it is definitely not optimal. :/ If you let me know what you need, I can see if we can set up e.g. a web service for doing so. Anonymous FTP is a risk becuase everyone can abuse us as filehoster then, but would something with authentication people can sign up via email, like done on the wiki, be sufficient? We need a place where to share test documents that are needed for reproducing bugs. It would be useful in different scenarios: * discussing problems on regional or global mailing lists; such files could get limited lifetime * too big documents that are not allowed in Freedesktop bugzilla; they should stay until the bug is fixed, verified and even longer; ideally forever * test documents for manual testing in Moztrap; it should stay until the test is active; ideally forever I think that we need something like pastebin.com but for files. Of course, there are many public systems where you could store files but there is usually a limited download. Are attachments completely disabled on the q...@fr.libreoffice.org mailing list? IMHO, a good practice is to allow attachments up to 100kB. Large documents should wait for moderator approval. In general, big attachments are not a good idea because of the multiplication effect (too many receivers). They're fully disabled on purpose. I'd be hesitant enabling them, especially because it also requires some development work on our side regarding the filters. Right now it's all or nothing, i.e. no attachments or all attachments... I see. I think that this default is reasonable. I would not want to get big files into my mailbox. Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of the QA Call tomorrow, Tuesday 1300UTC
Hi Sophie, *, On Fri, Nov 2, 2012 at 4:19 PM, Sophie Gautier gautier.sop...@gmail.com wrote: [...] What we need is a very simple way for a French user to send an attachment. If he needs to subscribe or register elsewhere and elsewhere again, I fear we'll just have to close the bug because he will never come back. Depends on what you call simple, but I like sendspace.com - it is a filehoster that has a sane amount of ads, and is quite simple to use (and requires no registration, but registration gives you some additional features). http://www.sendspace.com/ - just drag a file into your browser or use the browse button - wait of the upload to finish, then copy'n'paste the link. Pretty easy for the uploader. Only downloaders have to pay attention that they use the download from sendspace link, and don't hit instead any of the ads that might look like a download-button. Drawback: files get removed after a month of inactivity. I.e. if a file is not downloaded for 30 days, it is deleted. For screenshots, you could use http://frupic.frubar.net HTH ciao Christian ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Online update testing
Hi Michael, all Michael Meeks-2 wrote Sorry - I've not published the ESC minutes yet; Kendy is pulling the lever to upgrade 3.5.0-3 to 3.6.3 - and we planned to wait a week to see if there are any user-horror stories before promoting 3.6.3 to everyone as the upgrade path. Does that make sense ? I think that as there are quite a few regressions between 3.5 and 3.6 maybe the update path should be to 3.5.7 and provide the information that 3.6.3 which is considered recommended by TDF is available and provide a link. Maybe nagging people to switch from 3.5.x to 3.6.3 is too premature? In any case I believe there should be a stable channel and beta/development/QA channel for updates as in Mozilla, as suggested here https://bugs.freedesktop.org/show_bug.cgi?id=48369 This would allow any user to choose the QA channel to be notified of 3.6.4 rc1 or 3.7.0 rc3 regardless if the installed build is a stable or an rc build Just my usual 2 cents :) Best, Pedro -- View this message in context: http://nabble.documentfoundation.org/Libreoffice-qa-Online-update-testing-tp4001812p4016532.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of the QA Call tomorrow, Tuesday 1300UTC
Hi, Petr Mladek wrote on 2012-11-02 16:38: We need a place where to share test documents that are needed for reproducing bugs. It would be useful in different scenarios: * discussing problems on regional or global mailing lists; such files could get limited lifetime * too big documents that are not allowed in Freedesktop bugzilla; they should stay until the bug is fixed, verified and even longer; ideally forever * test documents for manual testing in Moztrap; it should stay until the test is active; ideally forever I think that we need something like pastebin.com but for files. Of course, there are many public systems where you could store files but there is usually a limited download. does anyone know if Etherpad has support for files, or is this strictly for writing? Florian -- Florian Effenberger, Chairman of the Board (Vorstandsvorsitzender) Tel: +49 8341 99660880 | Mobile: +49 151 14424108 The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts Legal details: http://www.documentfoundation.org/imprint ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 39956] Implement the IAccessible2 accessibility API [accessibility]
https://bugs.freedesktop.org/show_bug.cgi?id=39956 --- Comment #9 from James Teh ja...@nvaccess.org --- (In reply to comment #0) Unfortunately, the Java Accessibility API is badly supported by screen readers on Windows (... the open source NVDA It's worth noting that we've done our best to support the Java Access Bridge (JAB) in NVDA. However, JAB is difficult for users to set up, enforces dependency on Java and has severe limitations and bugs as an API. To give one example, it's not possible to communicate a great deal of formatting information with JAB. Supporting IAccessible2 would definitely be a huge leap forward for LibreOffice accessibility and allows for future improvements not possible with JAB. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56655] New: Chart labels incorrect by default
https://bugs.freedesktop.org/show_bug.cgi?id=56655 Priority: medium Bug ID: 56655 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Chart labels incorrect by default Severity: minor Classification: Unclassified OS: All Reporter: s...@adamnorman.com Hardware: All Status: UNCONFIRMED Version: unspecified Component: Chart Product: LibreOffice Created attachment 69409 -- https://bugs.freedesktop.org/attachment.cgi?id=69409action=edit Incorrectly labeled chart On a horizontal bar chart, it would make sense to have the top bar correspond to the top entry in the legend. Spreadsheet doesn't do this. It seems to label the charts in a most unintuitive way--the top bar is on the bottom of the legend, and the bottom bar is on the top of the legend. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56656] New: No idea why, but I keep crashing Spreadsheet.
https://bugs.freedesktop.org/show_bug.cgi?id=56656 Priority: medium Bug ID: 56656 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: No idea why, but I keep crashing Spreadsheet. Severity: normal Classification: Unclassified OS: Mac OS X (All) Reporter: s...@adamnorman.com Hardware: x86 (IA32) Status: UNCONFIRMED Version: unspecified Component: Spreadsheet Product: LibreOffice Created attachment 69410 -- https://bugs.freedesktop.org/attachment.cgi?id=69410action=edit Crash report It's not a big spreadsheet or anything. I have no idea why. Crash report attached, since it happened at the very same time I was submitting another bug! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56656] Spreadsheet keeps crashing
https://bugs.freedesktop.org/show_bug.cgi?id=56656 Adam s...@adamnorman.com changed: What|Removed |Added Summary|No idea why, but I keep |Spreadsheet keeps crashing |crashing Spreadsheet. | --- Comment #1 from Adam s...@adamnorman.com --- Sorry I'm useless. I wish I could be of more help. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56647] Arabic text (laam-alif) rendered differently in pointing (copying, reading) cell than in cell pointed to
https://bugs.freedesktop.org/show_bug.cgi?id=56647 Urmas davian...@gmail.com changed: What|Removed |Added Attachment #69402|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56646] : Minimization Loses access to open files.
https://bugs.freedesktop.org/show_bug.cgi?id=56646 Urmas davian...@gmail.com changed: What|Removed |Added OS|All |Linux (All) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54806] Reading .xlsx format drops leading zeros of value dispite text cell format
https://bugs.freedesktop.org/show_bug.cgi?id=54806 --- Comment #9 from fox72 konquer...@gmail.com --- Created attachment 69413 -- https://bugs.freedesktop.org/attachment.cgi?id=69413action=edit xlsx file formatwith leading zeros disappearing -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56660] New: FILESAVE
https://bugs.freedesktop.org/show_bug.cgi?id=56660 Priority: medium Bug ID: 56660 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILESAVE Severity: normal Classification: Unclassified OS: Linux (All) Reporter: johannes.bergm...@gmail.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 3.5.4 release Component: Spreadsheet Product: LibreOffice Created attachment 69416 -- https://bugs.freedesktop.org/attachment.cgi?id=69416action=edit Contains gdbtrace.log, valgrind.log, strace.log and a .xlsx file which the bug appears on. LibreOffice freezes and needs to be killed when saving a complicated Microsoft 2010 .xlsx document. I.e. opening test.xlsx, make a tiny change, save the file, and LibreOffice freezes. This only occurs in this special document. A working solution is to save as Microsoft 2003 .xls document. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56661] New: : Cannot open multiple documents
https://bugs.freedesktop.org/show_bug.cgi?id=56661 Priority: medium Bug ID: 56661 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: : Cannot open multiple documents Severity: normal Classification: Unclassified OS: All Reporter: aosd...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 3.6.3.2 release Component: Libreoffice Product: LibreOffice Created attachment 69417 -- https://bugs.freedesktop.org/attachment.cgi?id=69417action=edit Report following attempt to open two documents. Problem description: When I select 2 or more documents (odt) and attempt to Open with… none of the documents open and a window appears with a list of their filepaths plus a not following the last listed document to the effect that it does not exist. Steps to reproduce: 1. Select 2 or more files 2. Choose Open with… LibreOffice 3. Current behavior: Files do not open Expected behavior: The files to open. Platform (if different from the browser): Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:16.0) Gecko/20100101 Firefox/16.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39956] Implement the IAccessible2 accessibility API [accessibility]
https://bugs.freedesktop.org/show_bug.cgi?id=39956 --- Comment #10 from V Stuart Foote vstuart.fo...@utsa.edu --- Yes moving to IAccessible2 should help in eliminating the JAB mappings of UNO Accessibility API. The IBM Symphony \winaccessibility contribution to Apache Open Office is tantalizingly close as a framework for achieving the IAccessible2 implementation--seems like we are just waiting for a IBM/Appache signoff on stamping the code contribution with the ALv2 license. I think though, that even if the licensing were released today, until work starts on LibreOffice 4.0 and Apache OpenOffice 4.0, the Windows OSs and NVDA will remain dependent on the Java Accessibility with Java Access Bridge mappings. So, I am curious if the JAB provided support is really that incomplete? Or is it just that it has lacked needed attention in both OpenOffice and LibreOffice implementations? The Java AWT/Swing components of Java Accessibility API seem pretty comprehensive, as do the UNO Accessibility a11y roles and trees. What I don't have a feel for is the fidelity of role mappings achieved by the JAB, and issues of exposing a documents accessibility tree to AT. Can emerging a11y ATK 3.0 efforts like the ATK::collection interface be implemented in UNO Accessibility and mapped across the JAB to the Java Accessibility API? As I reported in NVDA#2753 - ( http://www.nvda-project.org/ticket/2753 ) the JAB based implementations are loosing AT focus within an NVDA session. Several other structural issues with AT document trees and inadequacies of UNO Accessibility roles suggest there is considerable room to improve how UNO Accessibility in general annotates elements with accessibility details. And while the scrub in preparation for LOdev 4.0 and AOoDev 4.0 begins, it would make sense to put some work into improving UNO Accessibility mappings into Java Accessibility API across the JAB. https://bugs.freedesktop.org/show_bug.cgi?id=35652 https://bugzilla.gnome.org/show_bug.cgi?id=345750 https://bugzilla.gnome.org/show_bug.cgi?id=652548 https://bugs.freedesktop.org/show_bug.cgi?id=36549 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56583] Impress crashes when presentation starts (dual-head, no Xinerama)
https://bugs.freedesktop.org/show_bug.cgi?id=56583 --- Comment #14 from Johan Vromans jvrom...@squirrel.nl --- Just to keep you informed... I backported 3.6.3 from Fedora 18 to Fedora 17. Unfortunately, the build did not contain debugging symbols. I'm trying to find out why. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43489] [Task] Incorrect behavior using existing User Profile for upgrade
https://bugs.freedesktop.org/show_bug.cgi?id=43489 Bug 43489 depends on bug 52022, which changed state. Bug 52022 Summary: CONFIGURATION: Part of data in userdir is lost on 3.5 - 3.6 upgrade https://bugs.freedesktop.org/show_bug.cgi?id=52022 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 52022, which changed state. Bug 52022 Summary: CONFIGURATION: Part of data in userdir is lost on 3.5 - 3.6 upgrade https://bugs.freedesktop.org/show_bug.cgi?id=52022 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56665] New: FORMATTING: Office Open XML page header rendering does not conform to ECMA-376 standard.
https://bugs.freedesktop.org/show_bug.cgi?id=56665 Priority: medium Bug ID: 56665 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FORMATTING: Office Open XML page header rendering does not conform to ECMA-376 standard. Severity: normal Classification: Unclassified OS: All Reporter: rfre...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 3.6.3.2 release Component: Writer Product: LibreOffice Created attachment 69422 -- https://bugs.freedesktop.org/attachment.cgi?id=69422action=edit A comparison of the first page header vs the default header. They render differently even though they are styled identically. Problem description: I am writing and application that produces DOCX files using ECMA-376 3rd ed. standard. In the document final section properties (ECMA-376 Section 17.6.17), there can be more than one headerReference element (ECMA-376 Section 17.10.5): one for the first page, one for odd pages, and one for even pages. I specified a first and default (left) page reference. I also specified that there shall be a title page using titlePg (ECMA-376 Section 17.10.6), so my document final section properties look like so: w:sectPr w:headerReference r:id=rId2 w:type=first / w:headerReference r:id=rId3 w:type=default / w:pgNumType w:fmt=decimal / w:pgMar w:bottom=1440 w:footer=0 w:gutter=0 w:header=0 w:left=1440 w:right=1440 w:top=1440 / w:pgSz w:h=15840 w:w=12240 / w:textDirection w:val=lr / w:titlePg w:val=1 / w:type w:val=nextPage / /w:sectPr I have also styled my headers in the style part of the document to be vertically centered in the top margin of the page. The default header renders correctly, however, the first page header renders incorrectly. Current behavior: The title page, or first page, header is incorrectly displayed. See attached screen shots. Expected behavior: When multiple headers are specified in the document final section properties, they should both be displayed correctly. Platform (if different from the browser): Win 7 Home Browser: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.4 (KHTML, like Gecko) Chrome/22.0.1229.94 Safari/537.4 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46278] FILESAVE: visibility settings of comments for cells are not read / written correctly to/from the .xlsx format
https://bugs.freedesktop.org/show_bug.cgi?id=46278 Roman Eisele b...@eikota.de changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #14 from Roman Eisele b...@eikota.de --- (In reply to comment #13) I tested it in LibreOffice 3.6.3 and it works fine. Thank you Thank you for testing! So we can change the status to VERIFIED/FIXED. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56460] CRASH when closing specific .odg files
https://bugs.freedesktop.org/show_bug.cgi?id=56460 --- Comment #5 from Roman Eisele b...@eikota.de --- (In reply to comment #2) Rainer/Roman: would you have some time to try to reproduce this? I'd like to know if it concerns only Linux (my config only?) or not? Sorry for the delay! I was mostly away this week. Well, Rainer has already confirmed this bug (thanks!). So only for the record: NOT reproducible with Rainer’s sample file (from comment #4) and LOdev 3.7.0.0.alpha0+ (Build ID: ce2690; pull time: 2012-10-30 00:06:37) on Mac OS X 10.6.8 (Intel). No crash occurs when closing the sample document and/or the complete application. - Bug seems limited to Windows and Linux. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56583] Impress crashes when presentation starts (dual-head, no Xinerama)
https://bugs.freedesktop.org/show_bug.cgi?id=56583 David Tardon dtar...@redhat.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED CC||dtar...@redhat.com Ever confirmed|1 |0 --- Comment #15 from David Tardon dtar...@redhat.com --- (In reply to comment #14) Just to keep you informed... I backported 3.6.3 from Fedora 18 to Fedora 17. Unfortunately, the build did not contain debugging symbols. I'm trying to find out why. This had been broken since the first 3.6 import. It should be fixed now. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc
https://bugs.freedesktop.org/show_bug.cgi?id=50916 Steffen Moeller steffen_moel...@gmx.de changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) OS|All |Linux (All) Status|UNCONFIRMED |NEW Priority|medium |high Version|3.5.4 release |3.6.3.1 rc Ever confirmed|0 |1 --- Comment #2 from Steffen Moeller steffen_moel...@gmx.de --- I had a colleague of mine send her data twice, in different formats, assuming a file corruption. This was because LibreOffice Calc does not even warn when it encounters a file with more columns than it can deal with. This is a bit embarassing, not? For your internal priorisation, please be aware that today, with many research lab are equipped with machines to perform high throughput analyses, files with 1500 columns (which typically host attributes in statistics) are no longer exceptional. Excel once was sucking badly with 256 columns, but they got that one fixed for a reason. Together with this functionality of thousands of columns there will be new interfaces developing alongside for the filtering of such. Time will bring it. Just now, please fix this behaviour. I offer 100 Euros from my very private pocket for this feature. The missing notice of losing data I tend to see as a bug. Concerning the dynamic container comment below I suggest to think about sparse formats. There is tons of sparse data out there in scientific data and to have a regular desktop tool prepared to handle that efficiently would be exciting. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56570] not possible to set the Cursor in a section
https://bugs.freedesktop.org/show_bug.cgi?id=56570 --- Comment #3 from manj_k courrier.oou.fr@googlemail.com --- Correction due to https://bugs.freedesktop.org/show_bug.cgi?id=55842#c11 : Duplicate of 'Bug 55842 - no focus on frame outside of page margins for editing'. *** This bug has been marked as a duplicate of bug 55842 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55842] no focus on frame outside of page margins for editing
https://bugs.freedesktop.org/show_bug.cgi?id=55842 manj_k courrier.oou.fr@googlemail.com changed: What|Removed |Added CC||karsten.henning@blb.branden ||burg.de --- Comment #13 from manj_k courrier.oou.fr@googlemail.com --- *** Bug 56570 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50284] FILEOPEN .doc/.docx (MSO2007) Bullet lists show wrong bullet symbols MacOS X
https://bugs.freedesktop.org/show_bug.cgi?id=50284 --- Comment #48 from mi...@filmsi.net --- Although bug 55959 is a duplicate bug of this one do not forget the attachments to it, they may come in handy checking if the patch works. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 30571] DRAW: 'graphics Mode' icon without function in vertical toolbar arrangement
https://bugs.freedesktop.org/show_bug.cgi?id=30571 Frank Winklmeier fr...@winklmeier.name changed: What|Removed |Added CC||fr...@winklmeier.name --- Comment #24 from Frank Winklmeier fr...@winklmeier.name --- @Rainer Bielefeld: I observe this problem for both vertical and horizontal toolbars. Should I submit a new bug report for this or is it the same issue? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56642] EDITING: unable to set cursor in Frames
https://bugs.freedesktop.org/show_bug.cgi?id=56642 manj_k courrier.oou.fr@googlemail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||courrier.oou.fr.mjk@googlem ||ail.com Ever confirmed|0 |1 --- Comment #1 from manj_k courrier.oou.fr@googlemail.com --- @Karsten Henning: What is the difference to your reported bug 56570, with attachment 69286 (marked as duplicate of bug 55842)? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56606] : it is not possible to ste the Cursor in a section
https://bugs.freedesktop.org/show_bug.cgi?id=56606 manj_k courrier.oou.fr@googlemail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||courrier.oou.fr.mjk@googlem ||ail.com Ever confirmed|0 |1 --- Comment #2 from manj_k courrier.oou.fr@googlemail.com --- @Karsten Henning: What is the difference to your reported bug 56570, with attachment 69286 (marked as duplicate of bug 55842)? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
