[Libreoffice-commits] .: writerfilter/source
writerfilter/source/dmapper/DomainMapper.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 73731b01cd65defdf9b42a9754bede3ba84221d7
Author: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com
Date: Thu Dec 20 15:39:37 2012 +0100
docx import: don't apply complex font size to non-complex font
OOXML spec says:
[szCs] specifies the font size which shall be applied to all
complex script characters in the contents of this run when displayed
Change-Id: I0faf599e38ef5a2e2005bb6f98874639be7d8287
Reviewed-on: https://gerrit.libreoffice.org/1454
Reviewed-by: Miklos Vajna vmik...@suse.cz
Tested-by: Miklos Vajna vmik...@suse.cz
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index dd61686..84f344e 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -2130,8 +2130,6 @@ void DomainMapper::sprmWithProps( Sprm rSprm,
PropertyMapPtr rContext, SprmType
if( NS_sprm::LN_CHpsBi == nSprmId )
{
rContext-Insert( PROP_CHAR_HEIGHT_COMPLEX, true, aVal );
-// Also set Western, but don't overwrite it.
-rContext-Insert( PROP_CHAR_HEIGHT, true, aVal, false );
}
else
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] docx import: don't apply complex font size to non-complex fo...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1454 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1454 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0faf599e38ef5a2e2005bb6f98874639be7d8287 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [SOLVED] Re: Question about operator = overloaded in reportdesign module
On Sun, Dec 30, 2012 at 09:58:30PM +0100, Julien Nabet wrote: On 30/12/2012 21:48, Markus Mohrhard wrote: Cppcheck reported this: [reportdesign/source/filter/xml/xmlComponent.hxx:37]: (style) 'OXMLComponent::operator=' should return 'OXMLComponent'. [reportdesign/source/filter/xml/xmlFunction.hxx:41]: (style) 'OXMLFunction::operator=' should return 'OXMLFunction'. [reportdesign/source/filter/xml/xmlGroup.hxx:38]: (style) 'OXMLGroup::operator=' should return 'OXMLGroup'. [reportdesign/source/filter/xml/xmlCell.hxx:41]: (style) 'OXMLCell::operator=' should return 'OXMLCell'. By trying to fix these, I noticed that none of them was implemented. So can they just be removed, is it another C++ trick, or something obvious I missed? You can't remove them. They are declared there to prevent the default operator= and copy c'tor. If you don't declare them private and leave out the implementation the compiler will generate a default operator= (the same is true for the copy c'tor). I didn't think that one's want prevent default behaviour without overloading The intent is to *forbid* copying of objects of this type. The canonical example is a smart pointer that deletes what it points to when it goes out of scope (when it is destructed). This is a kind of primitive garbage collector / automatic memory management, that does not require any collaboration from the managed object (the pointer pointed to), as opposed to reference counting (which needs the object to have an integer member for the reference count and a mutex member to handle changing / reading the reference count). C++11 has a specific syntax to achieve mostly the same effect more cleanly: OXMLCell operator =(const OXMLCell) = delete; That's slightly better since it tells the compiler that this class should have *no* assignment operator. So any code that tries to use it will have an error message no such operator. The private + unimplemented trick tells the compiler the operator exists, but only the class itself is allowed to use it. So, if some non-member function code tries to use the operator, it will get an error message like this operator is private, which is nearly as good as this operator does not exist... if the user knows of this trick, but is arguably less clear. If a member class function tries to use that operator, the compiler will accept it, and produce no error. The error will only come at the linker stage, something like undefined reference to operator=. Which could be caused by a forgotten .o in the linker command line rather than by design, so is a rather poor error message for this situation. (We cannot yet use C++11 in LibreOffice because not all platforms we want to support have good (any?) support for C++11) -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW] domain-mapper import speedup patch ...
Hi Michael, On Fri, Dec 21, 2012 at 04:55:44PM +, Michael Meeks michael.me...@suse.com wrote: I attach a prototype patch. It passes make check and make slowcheck in sw/ (not tried subsequentcheck). That makes a lot of sense, we also do something similar for section properties in http://opengrok.libreoffice.org/xref/core/writerfilter/source/dmapper/PropertyMap.cxx#1062 +// FIXME: we should have some nice way of merging ranges surely ? +aWhichPairs.push_back(pEntry-nWID); +aWhichPairs.push_back(pEntry-nWID); +} +aEntries.push_back(pEntry); I'm not sure if we have something like that -- Björn? :-) Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Paren fix for Ubu 10.04 build (and fdo#58417 ?)
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1531
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/1531/1
Paren fix for Ubu 10.04 build (and fdo#58417 ?)
The form: OuterCtor( InnerCtor(array[i]).method() )
with explicit ctor(s), unused optional arg on ctor+method
-- error 'parameter can not have variably modified type'
gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5.1).
Min fix: force precedence/associativity in type resolution.
fdo#58417 BTs inside 1 of these ctor calls.
Change-Id: I4d8b979df0fc827758b1e9a336031671425486ea
---
M linguistic/source/lngsvcmgr.cxx
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/linguistic/source/lngsvcmgr.cxx b/linguistic/source/lngsvcmgr.cxx
index 4f68407..a8e9763 100644
--- a/linguistic/source/lngsvcmgr.cxx
+++ b/linguistic/source/lngsvcmgr.cxx
@@ -744,7 +744,7 @@
const OUString *pNodeName = aNodeNames.getConstArray();
for (i = 0; i nNodeNames; ++i)
{
-Locale aLocale( LanguageTag( pNodeName[i]).getLocale() );
+Locale aLocale( (LanguageTag(pNodeName[i])).getLocale() );
Sequence OUString aCfgSvcs( getConfiguredServices( aService,
aLocale ));
Sequence OUString aAvailSvcs( getAvailableServices( aService,
aLocale ));
@@ -763,7 +763,7 @@
const Locale *pAvailLocale = aAvailLocales.getConstArray();
for (i = 0; i nAvailLocales; ++i)
{
-OUString aCfgLocaleStr( LanguageTag( pAvailLocale[i] ).getBcp47()
);
+OUString aCfgLocaleStr( (LanguageTag(pAvailLocale[i])).getBcp47()
);
Sequence OUString aAvailSvcs( getAvailableServices( aService,
pAvailLocale[i] ));
@@ -863,7 +863,7 @@
if (0 == rName.compareTo( aSpellCheckerList,
aSpellCheckerList.getLength() ))
{
// delete old cached data, needs to be acquired new on demand
- clearSvcInfoArray(pAvailSpellSvcs);
+clearSvcInfoArray(pAvailSpellSvcs);
OUString aNode( aSpellCheckerList );
if (lcl_SeqHasString( aSpellCheckerListEntries, aKeyText ))
@@ -888,7 +888,7 @@
else if (0 == rName.compareTo( aGrammarCheckerList,
aGrammarCheckerList.getLength() ))
{
// delete old cached data, needs to be acquired new on demand
- clearSvcInfoArray(pAvailGrammarSvcs);
+clearSvcInfoArray(pAvailGrammarSvcs);
OUString aNode( aGrammarCheckerList );
if (lcl_SeqHasString( aGrammarCheckerListEntries, aKeyText ))
@@ -916,7 +916,7 @@
else if (0 == rName.compareTo( aHyphenatorList,
aHyphenatorList.getLength() ))
{
// delete old cached data, needs to be acquired new on demand
- clearSvcInfoArray(pAvailHyphSvcs);
+clearSvcInfoArray(pAvailHyphSvcs);
OUString aNode( aHyphenatorList );
if (lcl_SeqHasString( aHyphenatorListEntries, aKeyText ))
@@ -941,7 +941,7 @@
else if (0 == rName.compareTo( aThesaurusList,
aThesaurusList.getLength() ))
{
// delete old cached data, needs to be acquired new on demand
- clearSvcInfoArray(pAvailThesSvcs);
+clearSvcInfoArray(pAvailThesSvcs);
OUString aNode( aThesaurusList );
if (lcl_SeqHasString( aThesaurusListEntries, aKeyText ))
@@ -1840,7 +1840,7 @@
aCfgAny = aSvcImplNames;
DBG_ASSERT( aCfgAny.hasValue(), missing value for 'Any' type );
-OUString aCfgLocaleStr( LanguageTag( pLocale[i] ).getBcp47() );
+OUString aCfgLocaleStr( (LanguageTag(pLocale[i])).getBcp47() );
pValue-Value = aCfgAny;
pValue-Name = aNodeName;
pValue-Name += OUString::valueOf( (sal_Unicode) '/' );
--
To view, visit https://gerrit.libreoffice.org/1531
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d8b979df0fc827758b1e9a336031671425486ea
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: LeMoyne Castle lemoyne.cas...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: linux / solaris vs other *nix file handling in sal/osl/unx/file.c
Il 01/01/2013 14:36, Riccardo Magliocchetti ha scritto:
Hello,
does anyone know why linux and solaris are using pread / pwrite syscalls
while other unixes are using read + lseek? The code is at least
FileHandle_Impl::writeAt which AFAIU is the base for the osl_* file
functions.
[snip]
If the idea is sound i can cook a patch, but i'd like to have some
feedback from *BSD / MacOS X people that will compile the new code path.
Patch attached if anyone on these plaforms want to give it a try.
thanks,
riccardo
From b574788b119f62e0446eb66d78cf99c21f1ca58f Mon Sep 17 00:00:00 2001
From: Riccardo Magliocchetti riccardo.magliocche...@gmail.com
Date: Wed, 2 Jan 2013 11:54:08 +0100
Subject: [PATCH] sal: use pread / pwrite on every *nix
pread / pwrite don't look as a Linux and Solaris privilege.
Change-Id: Ifb2e88445d4064c13a406007bfd523ae0caa38e5
---
sal/osl/unx/file.cxx | 36
1 file changed, 36 deletions(-)
diff --git a/sal/osl/unx/file.cxx b/sal/osl/unx/file.cxx
index 2f1a99a..d1840a3 100644
--- a/sal/osl/unx/file.cxx
+++ b/sal/osl/unx/file.cxx
@@ -379,8 +379,6 @@ oslFileError FileHandle_Impl::readAt (
return osl_File_E_None;
}
-#if defined(LINUX) || defined(SOLARIS)
-
ssize_t nBytes = ::pread (m_fd, pBuffer, nBytesRequested, nOffset);
if ((-1 == nBytes) (EOVERFLOW == errno))
{
@@ -393,22 +391,6 @@ oslFileError FileHandle_Impl::readAt (
if (-1 == nBytes)
return oslTranslateFileError (OSL_FET_ERROR, errno);
-#else /* !(LINUX || SOLARIS) */
-
-if (nOffset != m_offset)
-{
-if (-1 == ::lseek (m_fd, nOffset, SEEK_SET))
-return oslTranslateFileError (OSL_FET_ERROR, errno);
-m_offset = nOffset;
-}
-
-ssize_t nBytes = ::read (m_fd, pBuffer, nBytesRequested);
-if (-1 == nBytes)
-return oslTranslateFileError (OSL_FET_ERROR, errno);
-m_offset += nBytes;
-
-#endif /* !(LINUX || SOLARIS) */
-
OSL_FILE_TRACE(FileHandle_Impl::readAt(%d, %lld, %ld), m_fd, nOffset, nBytes);
*pBytesRead = nBytes;
return osl_File_E_None;
@@ -428,28 +410,10 @@ oslFileError FileHandle_Impl::writeAt (
if (!(m_state STATE_WRITEABLE))
return osl_File_E_BADF;
-#if defined(LINUX) || defined(SOLARIS)
-
ssize_t nBytes = ::pwrite (m_fd, pBuffer, nBytesToWrite, nOffset);
if (-1 == nBytes)
return oslTranslateFileError (OSL_FET_ERROR, errno);
-#else /* !(LINUX || SOLARIS) */
-
-if (nOffset != m_offset)
-{
-if (-1 == ::lseek (m_fd, nOffset, SEEK_SET))
-return oslTranslateFileError (OSL_FET_ERROR, errno);
-m_offset = nOffset;
-}
-
-ssize_t nBytes = ::write (m_fd, pBuffer, nBytesToWrite);
-if (-1 == nBytes)
-return oslTranslateFileError (OSL_FET_ERROR, errno);
-m_offset += nBytes;
-
-#endif /* !(LINUX || SOLARIS) */
-
OSL_FILE_TRACE(FileHandle_Impl::writeAt(%d, %lld, %ld), m_fd, nOffset, nBytes);
m_size = std::max (m_size, sal::static_int_cast sal_uInt64 (nOffset + nBytes));
--
1.7.10.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: linguistic/source
linguistic/source/lngsvcmgr.cxx | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 252136551f2c032b62f9650a06389f2b4fe6e6c1
Author: LeMoyne Castle lemoyne.cas...@gmail.com
Date: Tue Jan 1 12:47:35 2013 -0700
Paren fix for Ubu 10.04 build (and fdo#58417 ?)
The form: OuterCtor( InnerCtor(array[i]).method() )
with explicit ctor(s), unused optional arg on ctor+method
-- error 'parameter can not have variably modified type'
gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5.1).
Min fix: force precedence/associativity in type resolution.
fdo#58417 BTs inside 1 of these ctor calls.
Change-Id: I4d8b979df0fc827758b1e9a336031671425486ea
Reviewed-on: https://gerrit.libreoffice.org/1531
Reviewed-by: Tor Lillqvist t...@iki.fi
Tested-by: Tor Lillqvist t...@iki.fi
diff --git a/linguistic/source/lngsvcmgr.cxx b/linguistic/source/lngsvcmgr.cxx
index 4f68407..a8e9763 100644
--- a/linguistic/source/lngsvcmgr.cxx
+++ b/linguistic/source/lngsvcmgr.cxx
@@ -744,7 +744,7 @@ void LngSvcMgr::UpdateAll()
const OUString *pNodeName = aNodeNames.getConstArray();
for (i = 0; i nNodeNames; ++i)
{
-Locale aLocale( LanguageTag( pNodeName[i]).getLocale() );
+Locale aLocale( (LanguageTag(pNodeName[i])).getLocale() );
Sequence OUString aCfgSvcs( getConfiguredServices( aService,
aLocale ));
Sequence OUString aAvailSvcs( getAvailableServices( aService,
aLocale ));
@@ -763,7 +763,7 @@ void LngSvcMgr::UpdateAll()
const Locale *pAvailLocale = aAvailLocales.getConstArray();
for (i = 0; i nAvailLocales; ++i)
{
-OUString aCfgLocaleStr( LanguageTag( pAvailLocale[i] ).getBcp47()
);
+OUString aCfgLocaleStr( (LanguageTag(pAvailLocale[i])).getBcp47()
);
Sequence OUString aAvailSvcs( getAvailableServices( aService,
pAvailLocale[i] ));
@@ -863,7 +863,7 @@ void LngSvcMgr::Notify( const uno::Sequence OUString
rPropertyNames )
if (0 == rName.compareTo( aSpellCheckerList,
aSpellCheckerList.getLength() ))
{
// delete old cached data, needs to be acquired new on demand
- clearSvcInfoArray(pAvailSpellSvcs);
+clearSvcInfoArray(pAvailSpellSvcs);
OUString aNode( aSpellCheckerList );
if (lcl_SeqHasString( aSpellCheckerListEntries, aKeyText ))
@@ -888,7 +888,7 @@ void LngSvcMgr::Notify( const uno::Sequence OUString
rPropertyNames )
else if (0 == rName.compareTo( aGrammarCheckerList,
aGrammarCheckerList.getLength() ))
{
// delete old cached data, needs to be acquired new on demand
- clearSvcInfoArray(pAvailGrammarSvcs);
+clearSvcInfoArray(pAvailGrammarSvcs);
OUString aNode( aGrammarCheckerList );
if (lcl_SeqHasString( aGrammarCheckerListEntries, aKeyText ))
@@ -916,7 +916,7 @@ void LngSvcMgr::Notify( const uno::Sequence OUString
rPropertyNames )
else if (0 == rName.compareTo( aHyphenatorList,
aHyphenatorList.getLength() ))
{
// delete old cached data, needs to be acquired new on demand
- clearSvcInfoArray(pAvailHyphSvcs);
+clearSvcInfoArray(pAvailHyphSvcs);
OUString aNode( aHyphenatorList );
if (lcl_SeqHasString( aHyphenatorListEntries, aKeyText ))
@@ -941,7 +941,7 @@ void LngSvcMgr::Notify( const uno::Sequence OUString
rPropertyNames )
else if (0 == rName.compareTo( aThesaurusList,
aThesaurusList.getLength() ))
{
// delete old cached data, needs to be acquired new on demand
- clearSvcInfoArray(pAvailThesSvcs);
+clearSvcInfoArray(pAvailThesSvcs);
OUString aNode( aThesaurusList );
if (lcl_SeqHasString( aThesaurusListEntries, aKeyText ))
@@ -1840,7 +1840,7 @@ sal_Bool LngSvcMgr::SaveCfgSvcs( const String
rServiceName )
aCfgAny = aSvcImplNames;
DBG_ASSERT( aCfgAny.hasValue(), missing value for 'Any' type );
-OUString aCfgLocaleStr( LanguageTag( pLocale[i] ).getBcp47() );
+OUString aCfgLocaleStr( (LanguageTag(pLocale[i])).getBcp47() );
pValue-Value = aCfgAny;
pValue-Name = aNodeName;
pValue-Name += OUString::valueOf( (sal_Unicode) '/' );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Paren fix for Ubu 10.04 build (and fdo#58417 ?)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1531 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1531 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d8b979df0fc827758b1e9a336031671425486ea Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: LeMoyne Castle lemoyne.cas...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fix 'DEBUGCPPUNIT=TRUE make subsequenttest'
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1532 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/1532/1 fix 'DEBUGCPPUNIT=TRUE make subsequenttest' When running a unit test under GDB, we do not want to prefix the cppunittester executable with the LD_LIBRARY_PATH, because that has already happened before the gdb --args part of the command line. Change-Id: If3f81ba3fc3e5260142d7e9c2d4a78e9ca63382c --- M solenv/gbuild/CppunitTest.mk 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/solenv/gbuild/CppunitTest.mk b/solenv/gbuild/CppunitTest.mk index 9c145b6..47c8687 100644 --- a/solenv/gbuild/CppunitTest.mk +++ b/solenv/gbuild/CppunitTest.mk @@ -53,7 +53,13 @@ # DBGSV_ERROR_OUT = in non-product builds, ensure that tools-based assertions do not pop up as message box, but are routed to the shell ifneq ($(CROSS_COMPILING),YES) gb_CppunitTest_CPPTESTDEPS := $(call gb_Executable_get_runtime_dependencies,cppunit/cppunittester) -gb_CppunitTest_CPPTESTCOMMAND := $(call gb_Executable_get_command,cppunit/cppunittester) +ifeq ($(strip $(DEBUGCPPUNIT)),TRUE) +gb_CppunitTest_CPPTESTCOMMAND := $(call gb_Executable_get_target_for_build,cppunit/cppunittester) +else ifneq ($(strip $(GDBCPPUNITTRACE)),) +gb_CppunitTest_CPPTESTCOMMAND := $(call gb_Executable_get_target_for_build,cppunit/cppunittester) +else +gb_CppunitTest_CPPTESTCOMMAND := $(gb_Helper_set_ld_path) $(call gb_Executable_get_target_for_build,cppunit/cppunittester) +endif endif gb_CppunitTest__get_linktargetname = CppunitTest/$(call gb_CppunitTest_get_filename,$(1)) -- To view, visit https://gerrit.libreoffice.org/1532 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If3f81ba3fc3e5260142d7e9c2d4a78e9ca63382c Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Noel Grandin noelgran...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/CppunitTest.mk |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit 265feeb31ffc08cd4ccbe48398cd41d9cf1e2a25 Author: Noel Grandin n...@peralex.com Date: Wed Jan 2 13:32:09 2013 +0200 fix 'DEBUGCPPUNIT=TRUE make subsequenttest' When running a unit test under GDB, we do not want to prefix the cppunittester executable with the LD_LIBRARY_PATH, because that has already happened before the gdb --args part of the command line. Change-Id: If3f81ba3fc3e5260142d7e9c2d4a78e9ca63382c Reviewed-on: https://gerrit.libreoffice.org/1532 Reviewed-by: Tor Lillqvist t...@iki.fi Tested-by: Tor Lillqvist t...@iki.fi diff --git a/solenv/gbuild/CppunitTest.mk b/solenv/gbuild/CppunitTest.mk index 9c145b6..47c8687 100644 --- a/solenv/gbuild/CppunitTest.mk +++ b/solenv/gbuild/CppunitTest.mk @@ -53,7 +53,13 @@ endif # DBGSV_ERROR_OUT = in non-product builds, ensure that tools-based assertions do not pop up as message box, but are routed to the shell ifneq ($(CROSS_COMPILING),YES) gb_CppunitTest_CPPTESTDEPS := $(call gb_Executable_get_runtime_dependencies,cppunit/cppunittester) -gb_CppunitTest_CPPTESTCOMMAND := $(call gb_Executable_get_command,cppunit/cppunittester) +ifeq ($(strip $(DEBUGCPPUNIT)),TRUE) +gb_CppunitTest_CPPTESTCOMMAND := $(call gb_Executable_get_target_for_build,cppunit/cppunittester) +else ifneq ($(strip $(GDBCPPUNITTRACE)),) +gb_CppunitTest_CPPTESTCOMMAND := $(call gb_Executable_get_target_for_build,cppunit/cppunittester) +else +gb_CppunitTest_CPPTESTCOMMAND := $(gb_Helper_set_ld_path) $(call gb_Executable_get_target_for_build,cppunit/cppunittester) +endif endif gb_CppunitTest__get_linktargetname = CppunitTest/$(call gb_CppunitTest_get_filename,$(1)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.ac
configure.ac |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 8620f8b51dcc2c9f50364d42e756fd8b11bdc1e3
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Wed Jan 2 13:09:00 2013 +0100
fix use of MINGW_SYSROOT
This got broken in a084ea60680372efb7998f7369c9fc99eb85c50a.
diff --git a/configure.ac b/configure.ac
index 68723f4..1e6327a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7529,9 +7529,9 @@ if test $enable_python = system; then
dnl How to find out the cross-compilation Python installation path?
dnl Let's hardocode what we know for different distributions for now...
for python_version in 2.6; do
-if test -f
${MINGW_SYSROOT}/include/python${python_version}/Python.h; then
-
PYTHON_CFLAGS=-I${MINGW_SYSROOT}/include/python$python_version
-PYTHON_LIBS=-L${MINGW_SYSROOT}lib -lpython$python_version
$python_libs
+if test -f
${MINGW_SYSROOT}/mingw/include/python${python_version}/Python.h; then
+
PYTHON_CFLAGS=-I${MINGW_SYSROOT}/mingw/include/python$python_version
+PYTHON_LIBS=-L${MINGW_SYSROOT}/mingw/lib
-lpython$python_version $python_libs
AC_MSG_CHECKING([for python.exe])
AS_IF([test -f $MINGW_SYSROOT/mingw/bin/python.exe],
[AC_MSG_RESULT([$MINGW_SYSROOT/mingw/bin/python.exe])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] fix 'DEBUGCPPUNIT=TRUE make subsequenttest'
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1532 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1532 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3f81ba3fc3e5260142d7e9c2d4a78e9ca63382c Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Noel Grandin noelgran...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 --- Comment #66 from mike.h...@onepoyle.net --- Would like to suggest adding https://bugs.freedesktop.org/show_bug.cgi?id=58943 This regression results in significant visual differences where a user has depended on derived formats for calculated cells. The intention in 4.0.0.0B2 is obviously to follow what happened in 3.6.n.n as the expected derived formats do appear when sheet layout is changed - see issue report for details -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - vcl/win
vcl/win/source/gdi/winlayout.cxx |9 +
1 file changed, 9 insertions(+)
New commits:
commit 49dcb4794c838d5f1cf61060f216fc67f36c1618
Author: Michael Stahl mst...@redhat.com
Date: Sat Dec 22 01:53:09 2012 +0100
fdo#47553: UniscribeLayout: adjust mnSubStringMin
... to actual minimum so that the fix for fdo#33090 in
UniscribeLayout::GetNextGlyphs subtracts exactly the right number.
The original value of mnSubStringMin is guessed and may be up to 8
smaller than the actual start of the first VisualItem.
For the bugdoc it happens that sometimes it's too small by 8 and then
the wrong entries in mpGlyphs2Chars are initialized and then apparently
there are single glyphs that represent multiple characters and so
GetNextGlyphs returns a -1 character which is invalid.
-GetNextGlyphs dir 1 36 mnSubStringMin 28
-GetNextGlyphs g2c #1 [8] = 36
-GetNextGlyphs g2c #1 [9] = 37
-GetNextGlyphs g2c #1 [10] = 38
-GetNextGlyphs g2c #1 [11] = 39
-GetNextGlyphs g2c #1 [12] = 40
-GetNextGlyphs g2c #2 [4] = 40
-GetNextGlyphs g2c #2 [3] = 39
-GetNextGlyphs g2c #2 [1] = 38
-GetNextGlyphs g2c #2 [1] = 37
-GetNextGlyphs g2c #2 [0] = 36
...
-GetNextGlyphs init nCharPos -1
-GetNextGlyphs g2c [2] nCharPos -1
-GetNextGlyphs set pCharPosAry -1
layout[0]-GetNextGlyphs 768,1024 a1800 c-1 0
Change-Id: Ie33ec797a412aa898bec3f4e8f97b88dcfed4d11
(cherry picked from commit cec68bceba9aa1e984d74897fcd7bf4db702d14b)
Reviewed-on: https://gerrit.libreoffice.org/1467
Reviewed-by: Miklos Vajna vmik...@suse.cz
Tested-by: Miklos Vajna vmik...@suse.cz
diff --git a/vcl/win/source/gdi/winlayout.cxx b/vcl/win/source/gdi/winlayout.cxx
index 1df1a75..4ebdd06 100644
--- a/vcl/win/source/gdi/winlayout.cxx
+++ b/vcl/win/source/gdi/winlayout.cxx
@@ -1339,6 +1339,12 @@ bool UniscribeLayout::LayoutText( ImplLayoutArgs rArgs )
{
for( int j = rVisualItem.mnMinCharPos; j
rVisualItem.mnEndCharPos; ++j )
mpLogClusters[j] = sal::static_int_castWORD(~0U);
+if (rArgs.mnMinCharPos = rVisualItem.mnEndCharPos)
+{ // fdo#47553 adjust guessed min (maybe up to -8 off) to
+// actual min so it can be used properly in GetNextGlyphs
+assert(mnSubStringMin = rVisualItem.mnEndCharPos);
+mnSubStringMin = rVisualItem.mnEndCharPos;
+}
continue;
}
@@ -1793,7 +1799,10 @@ int UniscribeLayout::GetNextGlyphs( int nLen,
sal_GlyphId* pGlyphs, Point rPos,
int nGlyphWidth = pGlyphWidths[ nStart ];
int nCharPos = -1;// no need to determine charpos
if( mpGlyphs2Chars ) // unless explicitly requested+provided
+{
nCharPos = mpGlyphs2Chars[ nStart ];
+assert(-1 != nCharPos);
+}
// inject kashida glyphs if needed
if( !mbDisableGlyphInjection
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Stop disabling graphite on non-WINNT and non-Linux platforms
configure.ac checks if the operating system family is Linux or WINNT and refuses to enable graphite support if this is not the case. I'm using graphite on DragonFly and FreeBSD ports also enable it with a local patch; the Linux or WINNT check should be removed. Patch vs -master attached. -- Francois Tigeot From 9d033067bb7854c19b36bc21cba230eaa3d5815c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Tigeot?= ftig...@wolfpond.org Date: Wed, 2 Jan 2013 13:06:11 +0100 Subject: [PATCH] configure: graphite can be used on non-Linux, non-WINNT platforms Change-Id: I9e4b041273c07e39824e173ee06f125d2fbf937c --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 68723f4..9eefb03 100644 --- a/configure.ac +++ b/configure.ac @@ -8445,7 +8445,7 @@ dnl Graphite dnl === AC_MSG_CHECKING([whether to enable graphite support]) -if test $_os = WINNT -o $_os = Linux test $enable_graphite = -o $enable_graphite != no; then +if test $enable_graphite = -o $enable_graphite != no; then AC_MSG_RESULT([yes]) ENABLE_GRAPHITE=TRUE AC_DEFINE(ENABLE_GRAPHITE) -- 1.7.12 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Change in core[libreoffice-3-6]: fdo#47553: UniscribeLayout: adjust mnSubStringMin
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1467 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1467 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie33ec797a412aa898bec3f4e8f97b88dcfed4d11 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[libreoffice-dev] - ScalcBT.cxx C++ using new uno bootsrap is slow
Hi , Hope this is the right forum for the question below. If not, please point me in the right direction. I have written a new version of Scalc.java in C++, this time using UNO bootstrap mentioned in examples/DevelopersGuide/Components/CppComponents. The last version I wrote used examples/cpp/DocumentLoader and examples/java/Scalc.java. It expected soffice listening on a port and was too slow. Even this version is not as fast as I would have expected, and I would like to know what may be done to speed it up. The 500x12 cell updated 120 times in 60sec. I used gettimeofday to measure time for 3 cases writing same amount of data : A) write 5000 rows of 12 cols (~60sec) B) write 5000x12 entries to a single cell (~40sec) C) write 10 rows of 50 cols, 120 times (~60sec) If I read a file with 100,000x12 cell from disk, it takes 20 seconds - so I am hopeful that this example can be speeded up. The box is running RHEL 6.3, 2 cpu with 4 cores and 16GB of RAM. The attached files can be dropped into any cpp example dir and built. The makefile is copied from DocumentLoaded. Any pointers/googlable keywords/web links would be highly appreciated. Thanks Neeraj Makefile Description: Makefile SCalcBT.cxx Description: SCalcBT.cxx ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Addin exceptions in SvStream
On 30/12/12 15:41, Marc-André Laverdière wrote: @Lubos. I started writing a plug-in. I have a problem with compiling, however. It somehow doesn't find the headers on my system. This is the autogen.sh I use (I tried with and without --includedir, and --includedir=/usr/) ./autogen.sh CC=clang CXX=clang++ --includedir=/usr/include/ --enable-compiler-plugins I get this in the output: checking clang/AST/RecursiveASTVisitor.h usability... no checking clang/AST/RecursiveASTVisitor.h presence... no checking for clang/AST/RecursiveASTVisitor.h... no configure: error: Cannot find Clang headers to build compiler plugins. Yet... $ ls /usr/include/clang/AST/RecursiveASTVisitor.h /usr/include/clang/AST/RecursiveASTVisitor.h I am on Linux Mint 14. Any clue what is going on? IIRC it needs llvm headers that *buntu puts in /usr/lib eg. /usr/lib/llvm-3.0/include Didn't know how I should patch the configure file tho ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Questions about function lcl_GetMergeRange sc/source/core/data/fillinfo.cxx
On 29/12/2012 19:31, Markus Mohrhard wrote: Hey, In function lcl_GetMergeRange sc/source/core/data/fillinfo.cxx, what's the use to process bHOver variable in while (bVOver) ? It is unused. Just copy pasted code from the bHOver case. Ok, here's the change: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=26a0979711f89915508359a9804765d934631ec2 I thought about these too: - declaring nOverlap before the 2 loops, it would avoid to declare it each time in the else of both loops. - bVOver treatment is useless in first loop, only last loop is relevant Please don't. These two steps fall under micro-optimization. A compiler is in the end much better in optimizing the code than we can do manually so unless profiling shows that we have a performance problem we should write clean and easy code. Variables should be defined as late as possible and trying to optimise bVOver will make the code much more complicated for most likely no measurable gain. If you really want to improve the performance the right way is to take a slow operation and use callgrind to get an idea where to optimise at much higher level than these assignments. Ok then Thank you Markus for your support! Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
RE: [libreoffice-dev] - ScalcBT.cxx C++ using new uno bootsrap is slow
Hi Guys,
I tried to modified my original slow example to use array updates
(setDataArray) based on the example in the wiki.
http://wiki.openoffice.org/wiki/Calc/API/Programming
When I call setDataArray(arr1), the program terminates with error on screen
***Error couldn't get sheet
The relevant portion of code is pasted below. I get CellRangeData. I prepare a
sequence of sequence and call cellrangedata-setDataArray(SofS)
Would someone be able to point out what is wrong here?
Thanks
Neeraj
portion of attached code giving me problems:
void fillLines (Reference XSpreadsheetDocument myDoc)
{
printf(Fill the lines\n);
Reference XSpreadsheets xSheets = myDoc-getSheets() ;
Reference XIndexAccess oIndexSheets ( xSheets, UNO_QUERY);
Any any = oIndexSheets-getByIndex(0);
Reference XSpreadsheet xSheet ( any, UNO_QUERY);
//Reference XCellRange xCellRange = xSheet-getCellRangeByPosition
(0, 0, X, Y);
//Reference XCellRangeData xCellRangeData (xCellRange, UNO_QUERY);
Reference XModel rSpreadsheetModel (myDoc, UNO_QUERY);
Reference XInterface rInterface =
rSpreadsheetModel-getCurrentSelection();
Reference XCellRange xCellRange(rInterface,UNO_QUERY);
Reference XCellRangeData xCellRangeData(xCellRange, UNO_QUERY);
Sequence Sequence Any arr1 (X+1);
Sequence Any arr2 (Y+1);
for (int ii=0; ii 120; ++ii)
{
for (int jj=0; jj X; ++jj)
{
for (int kk=0; kk Y; ++kk)
{
int val = jj+kk+ii+2;
arr2[kk+1] = val;
}
arr1[jj+1] = arr2;
}
printf([%d] b4 set data array\n, ii);
xCellRangeData-setDataArray(arr1);
printf([%d] set data array\n, ii);
}
//***
}
-Original Message-
From: Rai, Neeraj [ICG-MKTS]
Sent: Friday, December 28, 2012 3:56 PM
To: 'libreoffice@lists.freedesktop.org'
Subject: [libreoffice-dev] - ScalcBT.cxx C++ using new uno bootsrap is slow
Hi ,
Hope this is the right forum for the question below. If not, please point me in
the right direction.
I have written a new version of Scalc.java in C++, this time using UNO
bootstrap mentioned in examples/DevelopersGuide/Components/CppComponents.
The last version I wrote used examples/cpp/DocumentLoader and
examples/java/Scalc.java. It expected soffice listening on a port and was too
slow.
Even this version is not as fast as I would have expected, and I would like to
know what may be done to speed it up.
The 500x12 cell updated 120 times in 60sec. I used gettimeofday to measure time
for 3 cases writing same amount of data :
A) write 5000 rows of 12 cols (~60sec)
B) write 5000x12 entries to a single cell (~40sec)
C) write 10 rows of 50 cols, 120 times (~60sec)
If I read a file with 100,000x12 cell from disk, it takes 20 seconds - so I am
hopeful that this example can be speeded up.
The box is running RHEL 6.3, 2 cpu with 4 cores and 16GB of RAM.
The attached files can be dropped into any cpp example dir and built. The
makefile is copied from DocumentLoaded.
Any pointers/googlable keywords/web links would be highly appreciated.
Thanks
Neeraj
Makefile
Description: Makefile
SCalcBT.cxx
Description: SCalcBT.cxx
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: linux / solaris vs other *nix file handling in sal/osl/unx/file.c
Hi, On Wed, Jan 02, 2013 at 12:03:16PM +0100, Riccardo Magliocchetti wrote: Il 01/01/2013 14:36, Riccardo Magliocchetti ha scritto: does anyone know why linux and solaris are using pread / pwrite syscalls while other unixes are using read + lseek? The code is at least FileHandle_Impl::writeAt which AFAIU is the base for the osl_* file functions. Patch attached if anyone on these plaforms want to give it a try. I tried a patched out LibreOffice-3.6.4 on DragonFly; it worked like a charm. Reading and opening files even seemed a bit faster. There is absolutely no justification for the linux+solaris check. HPUX support has been removed along with OS/2 and other dead or dying platforms anyway. I encountered many #if defined(OPERATING_SYSTEM_FOO) checks while porting LibreOffice to a new platform and can't help to think they were badly written in the first place. They should have checked for particular features if anything, not operating system names. configure.ac contains at least one similar bug; I'll send patches in another thread. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Wrong platform check for Xinerama support
configure.in / configure.ac also contains some fishy platform checks in the Xinerama support check: ... elif test $_os = Linux -o $_os = FreeBSD; then if test $x_libraries = default_x_libraries; then XINERAMALIB=`$PKG_CONFIG --variable=libdir xinerama` ... I'm not too sure of why this line was added but Linux and FreeBSD are not the only operating systems which can use Xorg. Maybe this should be changed to something like this ? elif test $_os != WINNT; then I'm reluctant to add all current Unix operating systems using Xorg to the elif line. Does someone know what was the intended goal for this check ? -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/UI.mk | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) New commits: commit 76091d814ca084ba66fcb9db8bc4565c47ee16a5 Author: David Tardon dtar...@redhat.com Date: Wed Jan 2 13:51:20 2013 +0100 only package .ui translations that can be produced That means that there is corresponding .po file for given language. As a slight optimization, do not even try to run uiex if _no_ translation would be produced. Change-Id: I901e88b20edfb55e4f8bc661bacf8218b603bdcb diff --git a/solenv/gbuild/UI.mk b/solenv/gbuild/UI.mk index 16624813..5e28464 100644 --- a/solenv/gbuild/UI.mk +++ b/solenv/gbuild/UI.mk @@ -148,6 +148,34 @@ $(call gb_UI__package_uifile,$(1),$(1)_ui_localized,res/$(3)/$(notdir $(2)),$(2) endef +# gb_UI__add_translations_impl target uifile langs +define gb_UI__add_translations_impl +$(call gb_UILocalizeTarget_UILocalizeTarget,$(2)) +$(call gb_UI_get_target,$(1)) : $(call gb_UILocalizeTarget_get_target,$(2)) +$(call gb_UI_get_clean_target,$(1)) : $(call gb_UILocalizeTarget_get_clean_target,$(2)) +$(call gb_Package_get_preparation_target,$(1)_ui_localized) : $(call gb_UILocalizeTarget_get_target,$(2)) +$(foreach lang,$(3),$(call gb_UI__add_uifile_for_lang,$(1),$(2),$(lang))) + +endef + +# gb_UI__add_translations target uifile langs +define gb_UI__add_translations +$(if $(strip $(3)),$(call gb_UI__add_translations_impl,$(1),$(2),$(3))) + +endef + +# Adds translations for languages that have corresponding .po file +# +# gb_UI__add_uifile_translations target uifile +define gb_UI__add_uifile_translations +$(call gb_UI__add_translations,$(1),$(2),\ + $(foreach lang,$(gb_UI_LANGS),\ + $(if $(wildcard $(gb_POLOCATION)/$(lang)/$(patsubst %/,%,$(dir $(2))).po),$(lang)) \ + ) \ +) + +endef + # Adds .ui file to the package # # The file is relative to $(SRCDIR) and without extension. @@ -157,11 +185,7 @@ define gb_UI_add_uifile $(call gb_UI__add_uifile,$(1),$(2)) ifneq ($(gb_UI_LANGS),) -$(call gb_UILocalizeTarget_UILocalizeTarget,$(2)) -$(call gb_UI_get_target,$(1)) : $(call gb_UILocalizeTarget_get_target,$(2)) -$(call gb_UI_get_clean_target,$(1)) : $(call gb_UILocalizeTarget_get_clean_target,$(2)) -$(call gb_Package_get_preparation_target,$(1)_ui_localized) : $(call gb_UILocalizeTarget_get_target,$(2)) -$(foreach lang,$(gb_UI_LANGS),$(call gb_UI__add_uifile_for_lang,$(1),$(2),$(lang))) +$(call gb_UI__add_uifile_translations,$(1),$(2)) endif endef ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - solenv/gbuild
solenv/gbuild/UI.mk | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) New commits: commit afa240330b51fb3607cfa6390aeb4e085cd1c525 Author: David Tardon dtar...@redhat.com Date: Wed Jan 2 13:51:20 2013 +0100 only package .ui translations that can be produced That means that there is corresponding .po file for given language. As a slight optimization, do not even try to run uiex if _no_ translation would be produced. Change-Id: I901e88b20edfb55e4f8bc661bacf8218b603bdcb (cherry picked from commit 76091d814ca084ba66fcb9db8bc4565c47ee16a5) Signed-off-by: David Tardon dtar...@redhat.com diff --git a/solenv/gbuild/UI.mk b/solenv/gbuild/UI.mk index 00572b0..f6f4e00 100644 --- a/solenv/gbuild/UI.mk +++ b/solenv/gbuild/UI.mk @@ -147,6 +147,34 @@ $(call gb_UI__package_uifile,$(1),$(1)_ui_localized,res/$(3)/$(notdir $(2)),$(2) endef +# gb_UI__add_translations_impl target uifile langs +define gb_UI__add_translations_impl +$(call gb_UILocalizeTarget_UILocalizeTarget,$(2)) +$(call gb_UI_get_target,$(1)) : $(call gb_UILocalizeTarget_get_target,$(2)) +$(call gb_UI_get_clean_target,$(1)) : $(call gb_UILocalizeTarget_get_clean_target,$(2)) +$(call gb_Package_get_preparation_target,$(1)_ui_localized) : $(call gb_UILocalizeTarget_get_target,$(2)) +$(foreach lang,$(3),$(call gb_UI__add_uifile_for_lang,$(1),$(2),$(lang))) + +endef + +# gb_UI__add_translations target uifile langs +define gb_UI__add_translations +$(if $(strip $(3)),$(call gb_UI__add_translations_impl,$(1),$(2),$(3))) + +endef + +# Adds translations for languages that have corresponding .po file +# +# gb_UI__add_uifile_translations target uifile +define gb_UI__add_uifile_translations +$(call gb_UI__add_translations,$(1),$(2),\ + $(foreach lang,$(gb_UI_LANGS),\ + $(if $(wildcard $(gb_POLOCATION)/$(lang)/$(patsubst %/,%,$(dir $(2))).po),$(lang)) \ + ) \ +) + +endef + # Adds .ui file to the package # # The file is relative to $(SRCDIR) and without extension. @@ -156,11 +184,7 @@ define gb_UI_add_uifile $(call gb_UI__add_uifile,$(1),$(2)) ifneq ($(gb_UI_LANGS),) -$(call gb_UILocalizeTarget_UILocalizeTarget,$(2)) -$(call gb_UI_get_target,$(1)) : $(call gb_UILocalizeTarget_get_target,$(2)) -$(call gb_UI_get_clean_target,$(1)) : $(call gb_UILocalizeTarget_get_clean_target,$(2)) -$(call gb_Package_get_preparation_target,$(1)_ui_localized) : $(call gb_UILocalizeTarget_get_target,$(2)) -$(foreach lang,$(gb_UI_LANGS),$(call gb_UI__add_uifile_for_lang,$(1),$(2),$(lang))) +$(call gb_UI__add_uifile_translations,$(1),$(2)) endif endef ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] Stop disabling graphite on non-WINNT and non-Linux platforms
Il 02/01/2013 13:22, Francois Tigeot ha scritto: configure.ac checks if the operating system family is Linux or WINNT and refuses to enable graphite support if this is not the case. I'm using graphite on DragonFly and FreeBSD ports also enable it with a local patch; the Linux or WINNT check should be removed. Patch vs -master attached. +if test $enable_graphite = -o $enable_graphite != no; then Isn't the second check enough? What about MacOS X / Android? I suppose both don't want graphite. riccardo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||58943 --- Comment #67 from Petr Mladek pmla...@suse.cz --- (In reply to comment #66) Would like to suggest adding https://bugs.freedesktop.org/show_bug.cgi?id=58943 This regression results in significant visual differences where a user has depended on derived formats for calculated cells. The intention in 4.0.0.0B2 is obviously to follow what happened in 3.6.n.n as the expected derived formats do appear when sheet layout is changed - see issue report for details Yup, it sounds like an important regression. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: svx/source
svx/source/items/pageitem.cxx | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
New commits:
commit ce9deff347ebdb1ab6faced894e8de9979eabb0e
Author: Werner Koerner wk66...@gmail.com
Date: Sat Dec 29 12:56:02 2012 +0100
Change if-statements to switch
The bit-values do overlap, 3rd and 4th case were never reached.
Change-Id: Iaaf39a11811c4e28c34260a7eab7fa0476165d1b
Reviewed-on: https://gerrit.libreoffice.org/1497
Reviewed-by: Tomáš Chvátal tchva...@suse.cz
Tested-by: Tomáš Chvátal tchva...@suse.cz
diff --git a/svx/source/items/pageitem.cxx b/svx/source/items/pageitem.cxx
index e7062ee..67d491d 100644
--- a/svx/source/items/pageitem.cxx
+++ b/svx/source/items/pageitem.cxx
@@ -84,15 +84,14 @@ int SvxPageItem::operator==( const SfxPoolItem rAttr )
const
inline XubString GetUsageText( const sal_uInt16 eU )
{
-if ( eU SVX_PAGE_LEFT )
-return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_LEFT);
-if ( eU SVX_PAGE_RIGHT )
-return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_RIGHT);
-if ( eU SVX_PAGE_ALL )
-return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_ALL);
-if ( eU SVX_PAGE_MIRROR )
-return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_MIRROR);
-return String();
+switch( eU 0x000f )
+{
+case SVX_PAGE_LEFT : return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_LEFT);
+case SVX_PAGE_RIGHT : return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_RIGHT);
+case SVX_PAGE_ALL : return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_ALL);
+case SVX_PAGE_MIRROR: return
SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_MIRROR);
+default: return String();
+}
}
//
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||58863 --- Comment #68 from Petr Mladek pmla...@suse.cz --- (In reply to comment #64) Add Bug 58863 - FILEOPEN .xlsx: IF condition not calculated: very basic function, additional functions might be affected. Really added ;-) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Change if-statements to switch
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1497 Approvals: Tomáš Chvátal: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1497 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaf39a11811c4e28c34260a7eab7fa0476165d1b Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Werner Körner wk66...@gmail.com Gerrit-Reviewer: Tomáš Chvátal tchva...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: linux / solaris vs other *nix file handling in sal/osl/unx/file.c
Hi, Il 02/01/2013 12:39, Francois Tigeot ha scritto: Hi, On Wed, Jan 02, 2013 at 12:03:16PM +0100, Riccardo Magliocchetti wrote: Il 01/01/2013 14:36, Riccardo Magliocchetti ha scritto: does anyone know why linux and solaris are using pread / pwrite syscalls while other unixes are using read + lseek? The code is at least FileHandle_Impl::writeAt which AFAIU is the base for the osl_* file functions. Patch attached if anyone on these plaforms want to give it a try. I tried a patched out LibreOffice-3.6.4 on DragonFly; it worked like a charm. Reading and opening files even seemed a bit faster. Nice, thanks! Now if only a MacOS X guy shows up... thanks, riccardo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: config_host.mk.in
config_host.mk.in |1 - 1 file changed, 1 deletion(-) New commits: commit ca3aba4cdf766cf33b0dbbe495c9e6f57f069822 Author: Tor Lillqvist t...@iki.fi Date: Wed Jan 2 15:59:00 2013 +0200 DBGHELP_DLL is set in download.lst included at the end Change-Id: I5465c9176b0b53f9a148fe50373f38c71f179746 diff --git a/config_host.mk.in b/config_host.mk.in index 08f6a85..f99e3e4 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -88,7 +88,6 @@ export CXX_X64_BINARY=@CXX_X64_BINARY@ @x_CXXFLAGS@ export CXXFLAGS=@CXXFLAGS@ export CXXFLAGS_CXX11=@CXXFLAGS_CXX11@ export DATADIR=@DATADIR@ -export DBGHELP_DLL=@DBGHELP_DLL@ export DBUSMENUGTK_CFLAGS=$(gb_SPACE)@DBUSMENUGTK_CFLAGS@ export DBUSMENUGTK_LIBS=$(gb_SPACE)@DBUSMENUGTK_LIBS@ export DBUS_CFLAGS=$(gb_SPACE)@DBUS_CFLAGS@ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Joren De Cuyper joren.libreoff...@telenet.be changed: What|Removed |Added CC||joren.libreoffice@telenet.b ||e Depends on||54264 --- Comment #191 from Joren De Cuyper joren.libreoff...@telenet.be --- I add Bug 54264 - FILEOPEN: LO cannot open more than one file at a time from Mac Finder because of the regression with 3.5 branch. It's quite annoying when you need to open all files one by one, when you try to open multiple documents at once. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source
sc/source/ui/docshell/docfunc.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit fbbbcdde585636aea0db1741a0a0ddcc7e0358f3
Author: Julien Nabet serval2...@yahoo.fr
Date: Tue Jan 1 16:23:16 2013 +0100
fdo#47466 FORMATTING: Autoformat empty rows causes app to crash
Thank you John LeMoyne Castle for your support
http://nabble.documentfoundation.org/Wrong-indentation-which-leads-to-segfault-in-sc-source-ui-docshell-docfunc-cxx-td4026726.html
However, the weird thing is I reproduced the crash with master sources but
didn't with 4.0 branch nor with 3.5.4.2 Debian packages
Change-Id: Ia5366f479a1066106551b77b5a6315fb78e1bf7d
diff --git a/sc/source/ui/docshell/docfunc.cxx
b/sc/source/ui/docshell/docfunc.cxx
index abcd66d..bbd6c96 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -3739,10 +3739,12 @@ bool ScDocFunc::AutoFormat( const ScRange rRange,
const ScMarkData* pTabMark,
ScMarkData::iterator itr = aMark.begin(), itrEnd = aMark.end();
for (; itr != itrEnd *itr nTabCount; ++itr)
+{
SetWidthOrHeight( sal_True, 1,nCols, *itr, SC_SIZE_VISOPT,
STD_EXTRA_WIDTH, false, sal_True);
SetWidthOrHeight( false,1,nRows, *itr, SC_SIZE_VISOPT, 0,
false, false);
rDocShell.PostPaint( 0,0,*itr, MAXCOL,MAXROW,*itr,
PAINT_GRID | PAINT_LEFT | PAINT_TOP );
+}
}
else
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - sc/source
sc/source/ui/docshell/docfunc.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 10536938a1f96c985b6deb6683ff1e1b64d040e7
Author: Julien Nabet serval2...@yahoo.fr
Date: Tue Jan 1 16:23:16 2013 +0100
fdo#47466 FORMATTING: Autoformat empty rows causes app to crash
Thank you John LeMoyne Castle for your support
http://nabble.documentfoundation.org/Wrong-indentation-which-leads-to-segfault-in-sc-source-ui-docshell-docfunc-cxx-td4026726.html
However, the weird thing is I reproduced the crash with master sources but
didn't with 4.0 branch nor with 3.5.4.2 Debian packages
Change-Id: Ia5366f479a1066106551b77b5a6315fb78e1bf7d
diff --git a/sc/source/ui/docshell/docfunc.cxx
b/sc/source/ui/docshell/docfunc.cxx
index c3cb2ca..2ed13d6 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -3734,10 +3734,12 @@ bool ScDocFunc::AutoFormat( const ScRange rRange,
const ScMarkData* pTabMark,
ScMarkData::iterator itr = aMark.begin(), itrEnd = aMark.end();
for (; itr != itrEnd *itr nTabCount; ++itr)
+{
SetWidthOrHeight( sal_True, 1,nCols, *itr, SC_SIZE_VISOPT,
STD_EXTRA_WIDTH, false, sal_True);
SetWidthOrHeight( false,1,nRows, *itr, SC_SIZE_VISOPT, 0,
false, false);
rDocShell.PostPaint( 0,0,*itr, MAXCOL,MAXROW,*itr,
PAINT_GRID | PAINT_LEFT | PAINT_TOP );
+}
}
else
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source
sc/source/ui/docshell/docfunc.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 5fe2b0eee8058a64745a7a51fdd2ac5e102300ee
Author: Julien Nabet serval2...@yahoo.fr
Date: Tue Jan 1 16:23:16 2013 +0100
fdo#47466 FORMATTING: Autoformat empty rows causes app to crash
Thank you John LeMoyne Castle for your support
http://nabble.documentfoundation.org/Wrong-indentation-which-leads-to-segfault-in-sc-source-ui-docshell-docfunc-cxx-td4026726.html
However, the weird thing is I reproduced the crash with master sources but
didn't with 4.0 branch nor with 3.5.4.2 Debian packages
Change-Id: Ia5366f479a1066106551b77b5a6315fb78e1bf7d
diff --git a/sc/source/ui/docshell/docfunc.cxx
b/sc/source/ui/docshell/docfunc.cxx
index c3cb2ca..2ed13d6 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -3734,10 +3734,12 @@ bool ScDocFunc::AutoFormat( const ScRange rRange,
const ScMarkData* pTabMark,
ScMarkData::iterator itr = aMark.begin(), itrEnd = aMark.end();
for (; itr != itrEnd *itr nTabCount; ++itr)
+{
SetWidthOrHeight( sal_True, 1,nCols, *itr, SC_SIZE_VISOPT,
STD_EXTRA_WIDTH, false, sal_True);
SetWidthOrHeight( false,1,nRows, *itr, SC_SIZE_VISOPT, 0,
false, false);
rDocShell.PostPaint( 0,0,*itr, MAXCOL,MAXROW,*itr,
PAINT_GRID | PAINT_LEFT | PAINT_TOP );
+}
}
else
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PUSHED: 4.0, 3.6] fdo#47466 FORMATTING: Autoformat empty rows causes app to crash
julien2412 píše v Út 01. 01. 2013 v 10:37 -0800: Hello, I don't reproduce the problem with 4.0 sources (I don't know why) but I can reproduce it with 3.6 sources. I guess that you are just lucky with 4.0. It probably modifies an allocated memory, so it does not crash but it might cause another funny random effects anywhere else. Anyway, would it be possible to cherry-pick f843850ee9994653673ef5591aae875d7fb22fed ? (it's just some 2 lacking braces) Yup, it makes sense = cherry picked into both 3-6 and 4-0 branches, see http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6id=5fe2b0eee8058a64745a7a51fdd2ac5e102300ee http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-0id=fbbbcdde585636aea0db1741a0a0ddcc7e0358f3 Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: configure.ac external/Package_mingw_dlls.mk m4/mingw.m4
configure.ac | 14 +++---
external/Package_mingw_dlls.mk |2 +-
m4/mingw.m4|2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
New commits:
commit dc277bc6a1c357fe725db2c567d3e1cf16fb7806
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Wed Jan 2 17:04:34 2013 +0100
use MINGW_SYSROOT consistently
Restore all cases to expect /mingw/ included in the path.
diff --git a/configure.ac b/configure.ac
index 1e6327a..59e20c0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5315,8 +5315,8 @@ dnl
===
if test $WITH_MINGW = yes; then
AC_MSG_CHECKING([for MinGW sysroot])
sysroot=`$CC -print-sysroot`
-AS_IF([test -d $sysroot],
- [MINGW_SYSROOT=$sysroot
+AS_IF([test -d $sysroot/mingw],
+ [MINGW_SYSROOT=$sysroot/mingw
AC_MSG_RESULT([$MINGW_SYSROOT])],
[AC_MSG_RESULT([not found])
AC_MSG_ERROR([cannot determine MinGW sysroot])])
@@ -7529,12 +7529,12 @@ if test $enable_python = system; then
dnl How to find out the cross-compilation Python installation path?
dnl Let's hardocode what we know for different distributions for now...
for python_version in 2.6; do
-if test -f
${MINGW_SYSROOT}/mingw/include/python${python_version}/Python.h; then
-
PYTHON_CFLAGS=-I${MINGW_SYSROOT}/mingw/include/python$python_version
-PYTHON_LIBS=-L${MINGW_SYSROOT}/mingw/lib
-lpython$python_version $python_libs
+if test -f
${MINGW_SYSROOT}/include/python${python_version}/Python.h; then
+
PYTHON_CFLAGS=-I${MINGW_SYSROOT}/include/python$python_version
+PYTHON_LIBS=-L${MINGW_SYSROOT}/lib -lpython$python_version
$python_libs
AC_MSG_CHECKING([for python.exe])
-AS_IF([test -f $MINGW_SYSROOT/mingw/bin/python.exe],
- [AC_MSG_RESULT([$MINGW_SYSROOT/mingw/bin/python.exe])
+AS_IF([test -f $MINGW_SYSROOT/bin/python.exe],
+ [AC_MSG_RESULT([$MINGW_SYSROOT/bin/python.exe])
MINGW_PYTHON_EXE=python.exe],
[AC_MSG_RESULT([not found])
AC_MSG_ERROR([could not find python.exe])])
diff --git a/external/Package_mingw_dlls.mk b/external/Package_mingw_dlls.mk
index 6b613d1..50a8cda 100644
--- a/external/Package_mingw_dlls.mk
+++ b/external/Package_mingw_dlls.mk
@@ -7,7 +7,7 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
-$(eval $(call gb_Package_Package,mingw_dlls,$(MINGW_SYSROOT)/mingw/bin))
+$(eval $(call gb_Package_Package,mingw_dlls,$(MINGW_SYSROOT)/bin))
$(eval $(call gb_Package_add_files,mingw_dlls,bin,\
$(MINGW_BOOST_DATE_TIME_DLL) \
diff --git a/m4/mingw.m4 b/m4/mingw.m4
index eb2dadb..d7aecbd 100644
--- a/m4/mingw.m4
+++ b/m4/mingw.m4
@@ -47,7 +47,7 @@ AC_DEFUN([libo_MINGW_CHECK_DLL],
[AC_ARG_VAR([MINGW_][$1][_DLL],[output variable containing the found dll
name])dnl
if test -n $WITH_MINGW; then
-_libo_mingw_dlldir=[$MINGW_SYSROOT]/mingw/bin
+_libo_mingw_dlldir=[$MINGW_SYSROOT]/bin
_libo_mingw_dllname=
AC_MSG_CHECKING([for $2 dll])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Wrong indentation which leads to segfault in sc/source/ui/docshell/docfunc.cxx
On Tuesday 01 of January 2013, John LeMoyne Castle wrote: Julien, Looks to me like a very nice catch ... ... The next version (2011.07.05) http://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docfunc.cxx ?r=2b88f6d32f572792597ccbb15276b9db52db7d10 is a commit labelled quot;change remaining manual loops to ScMarkData::iterator quot; and the braces disappear on just one of the loops. Because the braces were once there and, especially because the else block has ~ same action within the braces, I say that they should definitely come back. Even though, I am not at all clear what this code is doing (whilst autoformatting selected cells in Calc)... this is an obvious oopsie within a greater code cleanup that should be corrected. ... I note that, for all its type mushiness, BASIC will not allow this kind of mistake. The then-clause must either be all on one line (can do IF test THEN StmtA : StmtB : StmtC) and a multi-line then-clause must be terminated with End If or Else. http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTERfull-log=1356992414.21678#20458 : 20458 In file included from stdin:1: 20459 /home/tinderbox/clang-master-build/sc/source/ui/docshell/docfunc.cxx:3743:17: warning: statement aligned as second statement in for body but not in a statement block [loplugin] 20460 SetWidthOrHeight( false,1,nRows, *itr, SC_SIZE_VISOPT, 0, false, false); 20461 ^ 20462 /home/tinderbox/clang-master-build/sc/source/ui/docshell/docfunc.cxx:3742:17: note: for body statement is here [loplugin] 20463 SetWidthOrHeight( sal_True, 1,nCols, *itr, SC_SIZE_VISOPT, STD_EXTRA_WIDTH, false, sal_True); 20464 ^ 20465 1 warning generated. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: config_host.mk.in configure.ac libxmlsec/xmlsec1-configure.patch nss/ExternalPackage_nss.mk nss/ExternalProject_nss.mk nss/Makefile nss/makefile.mk nss/Module_nss.mk nss/nss-c
RepositoryExternal.mk| 10 -
config_host.mk.in|3
configure.ac |6
libxmlsec/xmlsec1-configure.patch| 21 ++
nss/ExternalPackage_nss.mk | 78 ++
nss/ExternalProject_nss.mk | 80 ++
nss/Makefile |7
nss/Module_nss.mk| 22 ++
nss/UnpackedTarball_nss.mk | 24 +++
nss/makefile.mk | 269 ---
nss/nss-config.in| 147 +++
nss/nss-config.patch | 150 ---
nss/nss.mingw.patch | 128
nss/nss.patch.mingw | 128
nss/prj/build.lst|3
nss/prj/d.lst| 34
openldap/ExternalProject_openldap.mk |4
17 files changed, 523 insertions(+), 591 deletions(-)
New commits:
commit c003d25d24786073229d0f8e545b2863c27fa282
Author: Peter Foley pefol...@verizon.net
Date: Tue Jan 1 09:39:36 2013 -0500
convert nss to gbuild
Change-Id: I59edc4c437abccc201823d97f1cbec230d273b05
Reviewed-on: https://gerrit.libreoffice.org/1529
Reviewed-by: LuboÅ¡ LuÅák l.lu...@suse.cz
Tested-by: LuboÅ¡ LuÅák l.lu...@suse.cz
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index cb63693..0b3fc76 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -2206,9 +2206,7 @@ endif # GUIBASE=unx
ifeq (,$(filter DESKTOP,$(BUILD_TYPE)))
-define gb_LinkTarget__use_nss3
-
-endef
+gb_LinkTarget__use_nss3:=
else
@@ -2245,10 +2243,11 @@ $(eval $(call
gb_Helper_register_libraries,PLAINLIBS_OOO,\
))
define gb_LinkTarget__use_nss3
+$(call gb_LinkTarget_use_package,$(1),nss)
$(call gb_LinkTarget_set_include,$(1),\
$$(INCLUDE) \
- -I$(OUTDIR)/inc/mozilla/nspr \
- -I$(OUTDIR)/inc/mozilla/nss \
+ -I$(call gb_UnpackedTarball_get_dir,nss)/mozilla/dist/public/nss \
+ -I$(call gb_UnpackedTarball_get_dir,nss)/mozilla/dist/out/include \
)
$(call gb_LinkTarget_use_libraries,$(1),\
@@ -2260,6 +2259,7 @@ $(call gb_LinkTarget_use_libraries,$(1),\
endef
define gb_LinkTarget__use_plc4
+$(call gb_LinkTarget_use_package,$(1),nss)
$(call gb_LinkTarget_use_libraries,$(1),\
plc4 \
)
diff --git a/config_host.mk.in b/config_host.mk.in
index f99e3e4..f99205d 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -404,6 +404,9 @@ export NEON_LIBS=$(gb_SPACE)@NEON_LIBS@
export NEON_VERSION=@NEON_VERSION@
export NM=@NM@
export nodep=@nodep@
+export NSS_MAJOR=@NSS_MAJOR@
+export NSS_MINOR=@NSS_MINOR@
+export NSS_PATCH=@NSS_PATCH@
export NSS_CFLAGS=$(gb_SPACE)@NSS_CFLAGS@
export NSS_LIBS=$(gb_SPACE)@NSS_LIBS@
export NSSBUILDTOOLS=@NSSBUILDTOOLS@
diff --git a/configure.ac b/configure.ac
index 59e20c0..dbcaf66 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8255,6 +8255,9 @@ if test $with_system_nss = yes; then
libo_MINGW_CHECK_DLL([SSL3], [ssl3])
else
SYSTEM_NSS=NO
+ NSS_MAJOR=3
+ NSS_MINOR=13
+ NSS_PATCH=5
BUILD_TYPE=$BUILD_TYPE NSS
AC_MSG_RESULT([internal])
if test $build_os = cygwin; then
@@ -8275,6 +8278,9 @@ from
http://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32])
fi
fi # system nss
AC_SUBST(SYSTEM_NSS)
+AC_SUBST(NSS_MAJOR)
+AC_SUBST(NSS_MINOR)
+AC_SUBST(NSS_PATCH)
AC_SUBST(NSS_CFLAGS)
AC_SUBST(NSS_LIBS)
AC_SUBST(NSSBUILDTOOLS)
diff --git a/libxmlsec/xmlsec1-configure.patch
b/libxmlsec/xmlsec1-configure.patch
index ead9050..2db0426 100644
--- a/libxmlsec/xmlsec1-configure.patch
+++ b/libxmlsec/xmlsec1-configure.patch
@@ -97,10 +97,29 @@
-ac_nss_lib_dir=/usr/lib /usr/lib64 /usr/local/lib
/usr/lib/$ac_mozilla_name /usr/local/lib/$ac_mozilla_name
-ac_nss_inc_dir=/usr/include /usr/include/mozilla /usr/local/include
/usr/local/include/mozilla /usr/include/$ac_mozilla_name
/usr/local/include/$ac_mozilla_name
+ac_nss_lib_dir=${SOLARVERSION}/${INPATH}/lib${UPDMINOREXT}
-+ac_nss_inc_dir=${SOLARVERSION}/${INPATH}/inc${UPDMINOREXT}/mozilla
++ac_nss_inc_dir=${WORKDIR}/UnpackedTarball/nss/mozilla/dist/out/include
${WORKDIR}/UnpackedTarball/nss/mozilla/dist/public
AC_MSG_CHECKING(for nspr libraries = $NSPR_MIN_VERSION)
NSPR_INCLUDES_FOUND=no
+@@ -637,15 +660,15 @@
+ NSPR_PRINIT_H=$with_nspr/include/prinit.h
+ else
+ for dir in $ac_nss_inc_dir ; do
+- if test -f $dir/nspr/prinit.h ; then
++ if test -f $dir/prinit.h ; then
+ dnl do not add -I/usr/include because compiler does it anyway
+ if test z$dir = z/usr/include ; then
+ NSPR_CFLAGS=
+ else
+- NSPR_CFLAGS=-I$dir/nspr
++ NSPR_CFLAGS=-I$dir
+ fi
+ NSPR_INCLUDES_FOUND=yes
+- NSPR_PRINIT_H=$dir/nspr/prinit.h
++
[PUSHED] convert nss to gbuild
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1529 Approvals: Luboš Luňák: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1529 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59edc4c437abccc201823d97f1cbec230d273b05 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: Luboš Luňák l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-commits] .: 2 commits - pyuno/CustomTarget_python_shell.mk pyuno/CustomTarget_pyversion.mk pyuno/Executable_python_wrapper.mk pyuno/Module_pyuno.mk pyuno/zipcore
On Tuesday 01 of January 2013, Libreoffice Gerrit user wrote: commit 085e0adf53baff298059980a54758d81b08bb059 Author: David Tardon dtar...@redhat.com Date: Tue Jan 1 11:47:56 2013 +0100 just pass the define through -D I am constantly amazed at the creativity of the original makefile writers. An extra header file, processed by sed, rather then adding one item to CDEFS? Really? Please use config_xxx.h files rather than -D flags whenever possible (which, interestingly, is an extra header file, processed by sed, rather than adding one item to CDEFS). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: nss/ExternalPackage_nss.mk
nss/ExternalPackage_nss.mk | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) New commits: commit e912ea714ec40c5046d1c1425c1e58fd6e689df1 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Wed Jan 2 18:06:18 2013 +0100 try to fix nss on macosx diff --git a/nss/ExternalPackage_nss.mk b/nss/ExternalPackage_nss.mk index ae28d98..2d2a9f1 100644 --- a/nss/ExternalPackage_nss.mk +++ b/nss/ExternalPackage_nss.mk @@ -16,7 +16,24 @@ $(eval $(call gb_ExternalPackage_add_files,nss,bin,\ config/nss-config \ )) -ifeq ($(OS),WNT) +ifeq ($(OS),MACOSX) +$(eval $(call gb_ExternalPackage_add_files,nss,lib,\ + mozilla/dist/out/lib/libcrmf.a \ + mozilla/dist/out/lib/libfreebl3.dylib \ + mozilla/dist/out/lib/libnspr4.dylib \ + mozilla/dist/out/lib/libnss3.dylib \ + mozilla/dist/out/lib/libnssckbi.dylib \ + mozilla/dist/out/lib/libnssdbm3.dylib \ + mozilla/dist/out/lib/libnsssysinit.dylib \ + mozilla/dist/out/lib/libnssutil3.dylib \ + mozilla/dist/out/lib/libplc4.dylib \ + mozilla/dist/out/lib/libplds4.dylib \ + mozilla/dist/out/lib/libsmime3.dylib \ + mozilla/dist/out/lib/libsoftokn3.dylib \ + mozilla/dist/out/lib/libsqlite3.dylib \ + mozilla/dist/out/lib/libssl3.dylib \ +)) +else ifeq ($(OS),WNT) ifeq ($(COM),MSC) $(eval $(call gb_ExternalPackage_add_files,nss,lib,\ mozilla/dist/out/lib/nspr4.lib \ @@ -56,7 +73,7 @@ $(eval $(call gb_ExternalPackage_add_files,nss,bin,\ mozilla/dist/out/lib/sqlite3.dll \ mozilla/dist/out/lib/ssl3.dll \ )) -else # OS!=WNT +else # OS!=WNT/MACOSX $(eval $(call gb_ExternalPackage_add_files,nss,lib,\ mozilla/dist/out/lib/libcrmf.a \ mozilla/dist/out/lib/libfreebl3.so \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sal/inc
sal/inc/sal/log-areas.dox |1 + 1 file changed, 1 insertion(+) New commits: commit 49fc6c6b85e4902dc9b776d82ec17ea7c01a8dd1 Author: Miklos Vajna vmik...@suse.cz Date: Wed Jan 2 18:07:52 2013 +0100 sal: missing jvmfwk in log-areas diff --git a/sal/inc/sal/log-areas.dox b/sal/inc/sal/log-areas.dox index c167267..428c7fb 100644 --- a/sal/inc/sal/log-areas.dox +++ b/sal/inc/sal/log-areas.dox @@ -221,6 +221,7 @@ certain functionality. @li @c editeng @li @c framework @li @c helpcompiler +@li @c jvmfwk @li @c linguistic @li @c oox @li @c rsc ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.ac
configure.ac | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) New commits: commit 2210bade74626de68e51adb9759b81f62d7c0b01 Author: Tor Lillqvist t...@iki.fi Date: Wed Jan 2 15:18:11 2013 +0200 Check also for a (self-built) 64-bit NDK tool-chain Also make the --with-android-ndk-toolchain-version option mandatory. Otherwise it would be possible to leave it out and that would appear to work in the configure phase but in fact mix stuff up when using a self-built 64-bit tool-chain merged into a r8b,c,d NDK. Sigh, maybe we shouldn't even try to have the configury generic enough to work with any NDK version (which probably it doesn't anyway), but explicitly accept only a small set of NDKs, like r8b,c,d (which probably are the only that we work with anyway). Change-Id: Iecdf3a2d841e7b29598228ae49f48eca9640a82c diff --git a/configure.ac b/configure.ac index dbcaf66..af1b786 100644 --- a/configure.ac +++ b/configure.ac @@ -154,7 +154,24 @@ if test -n $with_android_ndk; then android_cpu=x86 fi -ANDROID_ABI_PREBUILT_BIN=`echo $ANDROID_NDK_HOME/toolchains/$android_cpu*-*$with_android_ndk_toolchain_version/prebuilt/*/bin` +# Check if there is a (self-built) 64-bit tool-chain +toolchain_system='*' +if test $build_os = linux-gnu; then +case $build_cpu in +x86_64) +case `echo $ANDROID_NDK_HOME/toolchains/$android_cpu*-*$with_android_ndk_toolchain_version/prebuilt/linux-x86_64/bin` in +*/bin|*/bin\ */bin*) +toolchain_system=linux-x86_64 +;; +esac +;; +i?86|x86) +toolchain_system=linux-x86 +;; +esac +fi + +ANDROID_ABI_PREBUILT_BIN=`echo $ANDROID_NDK_HOME/toolchains/$android_cpu*-*$with_android_ndk_toolchain_version/prebuilt/$toolchain_system/bin` # Check if there are several toolchain versions case $ANDROID_ABI_PREBUILT_BIN in */bin\ */bin*) @@ -489,6 +506,10 @@ linux-android*) AC_MSG_ERROR([the --with-android-ndk option is mandatory]) fi +if test -z $with_android_ndk_toolchain_version; then +AC_MSG_ERROR([the --with-android-ndk-toolchain-version option is mandatory]) +fi + if test -z $with_android_sdk; then AC_MSG_ERROR([the --with-android-sdk option is mandatory]) fi ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: nss/ExternalPackage_nss.mk
nss/ExternalPackage_nss.mk |1 - 1 file changed, 1 deletion(-) New commits: commit 3b1102ad193d55b98c7c72e706173353c35bb1b6 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Wed Jan 2 18:25:31 2013 +0100 looks like libnsssysinit is linux-only diff --git a/nss/ExternalPackage_nss.mk b/nss/ExternalPackage_nss.mk index 2d2a9f1..ce19727 100644 --- a/nss/ExternalPackage_nss.mk +++ b/nss/ExternalPackage_nss.mk @@ -24,7 +24,6 @@ $(eval $(call gb_ExternalPackage_add_files,nss,lib,\ mozilla/dist/out/lib/libnss3.dylib \ mozilla/dist/out/lib/libnssckbi.dylib \ mozilla/dist/out/lib/libnssdbm3.dylib \ - mozilla/dist/out/lib/libnsssysinit.dylib \ mozilla/dist/out/lib/libnssutil3.dylib \ mozilla/dist/out/lib/libplc4.dylib \ mozilla/dist/out/lib/libplds4.dylib \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: config_host.mk.in configure.ac i18npool/CustomTarget_breakiterator.mk i18npool/qa i18npool/source
config_host.mk.in |2 ++ configure.ac|8 i18npool/CustomTarget_breakiterator.mk | 18 +- i18npool/qa/cppunit/test_breakiterator.cxx |7 +++ i18npool/source/breakiterator/data/line.txt |3 ++- 5 files changed, 36 insertions(+), 2 deletions(-) New commits: commit 79a3c9b186534c5e3adde2266d3e7fd6527b11b9 Author: Eike Rathke er...@redhat.com Date: Wed Jan 2 19:03:51 2013 +0100 partly revert 92a9b7780c6e13a4da3b12794342edbc4c09ef51 for ICU 49 Re-enable build with ICU 4.6 and 4.8 ICU versions prior to 49 don't know Conditional_Japanese_Starter and Hebrew_Letter Also, the change in i18npool/CustomTarget_breakiterator.mk - -e s#\[:LineBreak = Close_Punctuation:\]#\[ \[:LineBreak = Close_Parenthesis:\]\]# \ with i18npool/source/breakiterator/data/line.txt -$CL = [:LineBreak = Close_Punctuation:] ; +$CL = [:LineBreak = Close_Parenthesis:]; did not produce equivalent results. Instead use $CP = [:LineBreak = Close_Parenthesis:]; $CL = [[:LineBreak = Close_Punctuation:] $CP]; Change-Id: I14fc14319ea34f23393264560452a79bb49fc3a7 diff --git a/config_host.mk.in b/config_host.mk.in index f99205d..70f8c4e 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -251,6 +251,8 @@ export ICU_MAJOR=@ICU_MAJOR@ export ICU_MICRO=@ICU_MICRO@ export ICU_MINOR=@ICU_MINOR@ export ICU_RECLASSIFIED_PREPEND_SET_EMPTY=@ICU_RECLASSIFIED_PREPEND_SET_EMPTY@ +export ICU_RECLASSIFIED_CONDITIONAL_JAPANESE_STARTER=@ICU_RECLASSIFIED_CONDITIONAL_JAPANESE_STARTER@ +export ICU_RECLASSIFIED_HEBREW_LETTER=@ICU_RECLASSIFIED_HEBREW_LETTER@ export ILIB=@ILIB@ export INPATH=@INPATH@ export INPATH_FOR_BUILD=@INPATH_FOR_BUILD@ diff --git a/configure.ac b/configure.ac index af1b786..f3e69ac 100644 --- a/configure.ac +++ b/configure.ac @@ -8381,6 +8381,8 @@ ICU_MAJOR=49 ICU_MINOR=1 ICU_MICRO=1 ICU_RECLASSIFIED_PREPEND_SET_EMPTY=YES +ICU_RECLASSIFIED_CONDITIONAL_JAPANESE_STARTER=YES +ICU_RECLASSIFIED_HEBREW_LETTER=YES AC_MSG_CHECKING([which icu to use]) if test $with_system_icu = yes; then AC_MSG_RESULT([external]) @@ -8442,8 +8444,12 @@ You can use --with-system-icu-for-build=force to use it anyway.]) fi if test $ICU_MAJOR -ge 49; then ICU_RECLASSIFIED_PREPEND_SET_EMPTY=YES +ICU_RECLASSIFIED_CONDITIONAL_JAPANESE_STARTER=YES +ICU_RECLASSIFIED_HEBREW_LETTER=YES else ICU_RECLASSIFIED_PREPEND_SET_EMPTY=NO +ICU_RECLASSIFIED_CONDITIONAL_JAPANESE_STARTER=NO +ICU_RECLASSIFIED_HEBREW_LETTER=NO fi fi @@ -8463,6 +8469,8 @@ AC_SUBST(ICU_MAJOR) AC_SUBST(ICU_MINOR) AC_SUBST(ICU_MICRO) AC_SUBST(ICU_RECLASSIFIED_PREPEND_SET_EMPTY) +AC_SUBST(ICU_RECLASSIFIED_CONDITIONAL_JAPANESE_STARTER) +AC_SUBST(ICU_RECLASSIFIED_HEBREW_LETTER) AC_SUBST([MINGW_ICUDATA_DLL]) AC_SUBST([MINGW_ICUI18N_DLL]) AC_SUBST([MINGW_ICUUC_DLL]) diff --git a/i18npool/CustomTarget_breakiterator.mk b/i18npool/CustomTarget_breakiterator.mk index a8fe3bd..da3c224 100644 --- a/i18npool/CustomTarget_breakiterator.mk +++ b/i18npool/CustomTarget_breakiterator.mk @@ -88,13 +88,29 @@ $(i18npool_BIDIR)/%.brk : $(i18npool_BIDIR)/%.txt $(call gb_ExternalExecutable_g $(call gb_ExternalExecutable_get_command,genbrk) -r $ -o $@ $(if $(findstring s,$(MAKEFLAGS)), /dev/null)) # fdo#31271 ) reclassified in more recent Unicode Standards / ICU 4.4 -# * Prepend set empty as of Unicode Version 6.1 / ICU 4.9, which bails out if used. +# * Prepend set empty as of Unicode Version 6.1 / ICU 49, which bails out if used. # NOTE: strips every line with _word_ 'Prepend', including $Prepend +# * Conditional_Japanese_Starter does not exist in ICU 49, which bail out if used. +# * Hebrew_Letter does not exist in ICU 49, which bail out if used. # NOTE: I sincerely hope there is a better way to avoid problems than this abominable # sed substitution... $(i18npool_BIDIR)/%.txt : \ $(SRCDIR)/i18npool/source/breakiterator/data/%.txt | $(i18npool_BIDIR)/.dir sed -e ': dummy' \ + $(if $(filter-out YES,$(ICU_RECLASSIFIED_CONDITIONAL_JAPANESE_STARTER)),\ + -e '/\[:LineBreak = Conditional_Japanese_Starter:\]/d' \ + -e 's# $$CJ##' \ + ) \ + $(if $(filter-out YES,$(ICU_RECLASSIFIED_HEBREW_LETTER)),\ + -e '/\[:LineBreak = Hebrew_Letter:\]/d' \ + -e '/^$$HLcm =/d' \ + -e '/^$$HLcm $$NUcm;/d' \ + -e '/^$$NUcm $$HLcm;/d' \ + -e '/^$$HL $$CM+;/d' \ + -e 's# | $$HL\(cm\)\?##g' \ + -e 's#$$HLcm ##g' \ + -e 's# $$HL##g' \ + ) \ $(if $(filter
Re: build failure with ICU 4.8
Hi Ivan, On Monday, 2012-12-31 12:20:13 +0400, Ivan Timofeev wrote: ICU 4.8 does not know Conditional_Japanese_Starter (only ICU 49 does), I think we should put that conditional stuff from http://cgit.freedesktop.org/libreoffice/core/commit/?id=92a9b7780c6e13a4da3b12794342edbc4c09ef51 back. Partly reverted with http://cgit.freedesktop.org/libreoffice/core/commit/?id=79a3c9b186534c5e3adde2266d3e7fd6527b11b9 Builds with system ICU 4.6 again. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD Support the FSFE, care about Free Software! https://fsfe.org/support/?erack pgpjzFJGnbjfr.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - configure.ac python3/ExternalProject_python3.mk
configure.ac |4 +++- python3/ExternalProject_python3.mk |2 +- 2 files changed, 4 insertions(+), 2 deletions(-) New commits: commit b24f82fda9558a8b07a6df9ac898d0e166113a10 Author: Tor Lillqvist t...@iki.fi Date: Wed Jan 2 20:53:59 2013 +0200 Can't build the NPAPI plugin stuff as 64-bit for OS X It uses QuickTime and Carbon. diff --git a/configure.ac b/configure.ac index f3e69ac..d5ed79d 100644 --- a/configure.ac +++ b/configure.ac @@ -8508,7 +8508,9 @@ dnl === dnl Check for NPAPI interface to plug browser plugins into LibreOffice documents dnl === AC_MSG_CHECKING([whether to plug browser plugins into LibreOffice documents]) -if test $_os != Android -a $_os != iOS +# Obviously no such thing on iOS or Android. Also not possible when building +# 64-bit OS X code as the plugin code uses QuickTime and Carbon. +if test $_os != Android -a $_os != iOS -a \( $_os != Darwin -o $BITNESS_OVERRIDE = \) then AC_MSG_RESULT([yes]) ENABLE_NPAPI_FROM_BROWSER=YES commit 0f6f38b5d7288dd71a26040aee04b1ca4f6e0bcf Author: Tor Lillqvist t...@iki.fi Date: Wed Jan 2 17:51:37 2013 +0200 Fix 64-bit OS X build: don't try any universalness diff --git a/python3/ExternalProject_python3.mk b/python3/ExternalProject_python3.mk index e2ea53a..a2dbb09 100644 --- a/python3/ExternalProject_python3.mk +++ b/python3/ExternalProject_python3.mk @@ -74,7 +74,7 @@ $(call gb_ExternalProject_get_state_target,python3,build) : $(if $(filter AIX,$(OS)),--disable-ipv6 --with-threads) \ $(if $(filter WNT-GCC,$(OS)-$(COM)),--with-threads ac_cv_printf_zd_format=no) \ $(if $(filter MACOSX,$(OS)), \ - --enable-universalsdk=$(MACOSX_SDK_PATH) --with-universal-archs=32-bit --enable-framework=/@__OOO --with-framework-name=LibreOfficePython, \ + $(if $(filter INTEL POWERPC,$(CPUNAME)),--enable-universalsdk=$(MACOSX_SDK_PATH) --with-universal-archs=32-bit) --enable-framework=/@__OOO --with-framework-name=LibreOfficePython, \ --enable-shared \ ) \ CC=$(strip $(CC) \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
First steps finding regression bug(s)
Hi,
I'm not that familiar with the source code of LibreOffice. The last past
weeks I'm helping the QA-team.
I try now to take a little step forward and try to comprehend a bit of
the source code. I would like to help core developers point at
regressions (find the erroneous commit). In first instance just point to
it, maybe in a later stage try to fix it on my own.
Said that I'm now intrigued by bug/regression
https://bugs.freedesktop.org/show_bug.cgi?id=54264 (I'm a Mac OSX user).
Quote (Roman Eisele):
If I select two or more files which should open with LibreOffice (e.g., .odt
or .rtf or .xls files) in the Finder and press Command + O or drag both/all files on
the LibreOffice application icon, LibreOffice does not open the files (as expected),
but shows an alert which says path of 1st documentpath of 2nd document does not
exist..
Following the alert, I can search for the string 'does not exists.'. I
found it here:
http://opengrok.libreoffice.org/xref/core/fpicker/source/office/iodlg.src#286
:
String RID_FILEOPEN_INVALIDFOLDER
{
Text [ en-US ] = $name$ does not exist.;
};
So my search goes further ... by what is this string triggered/where is
it defined?
http://opengrok.libreoffice.org/xref/core/fpicker/source/office/OfficeFilePicker.hrc#39
:
#define RID_FILEOPEN_INVALIDFOLDER (RID_FPICKER_START+23)
Now I need to search for 'RID_FPICKER_START' ... and I found it here:
http://opengrok.libreoffice.org/xref/core/svl/inc/svl/solar.hrc#63
#define RID_FPICKER_START (RID_LIB_START+6370)
and on line 36 of that file (solar.hrc)
#define RID_LIB_START 1
Ok... Now I found this ... Can I 'conclude' that my string is at
'position' 16393 (=23 + 6370 + 1). That's 0x4009 in hex notation. I
searched for 0x4009 and 16393; but I can't find anything relevant where
this could be triggered. On top of 'solar.hrc' (line 27 and 28) there is
a function:
#define CREATERESMGR_NAME( Name ) #Name
#define CREATERESMGR( Name )ResMgr::CreateResMgr( CREATERESMGR_NAME(
Name ) )
As far I can comprehend I guess ResMgr::CreateResMgr (found here
http://opengrok.libreoffice.org/xref/core/tools/source/rc/resmgr.cxx#CreateResMgr)
is the function that chooses the correct string... And there I'm stuck I
think :s. Because the bug is a regression bug 3.5 vs 3.6, and the source
code of 3.6 is frozen on Week 23, Jun 4 - Jun 10, 2012 I compared the
current version of resmgr.cxx with a version at the beginning of 2012
(to be sure not overlook something)... But I couldn't find something.
Otherwise with this information I still can't find the code that
triggers the string.
1) Is this information useful for a developer? (should I add that
information to the bug report?)
2) Am I'm doing it right?
Thanks in advance,
Joren
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sal/inc sw/qa sw/source
sal/inc/sal/log-areas.dox|1 +
sw/qa/extras/rtfimport/rtfimport.cxx |1 -
sw/source/core/crsr/crstrvl.cxx |2 +-
sw/source/core/unocore/unostyle.cxx |2 +-
sw/source/ui/app/docsh2.cxx |1 -
sw/source/ui/ribbar/workctrl.cxx |4 +---
6 files changed, 4 insertions(+), 7 deletions(-)
New commits:
commit 8275c8fc33b63aa40a0a8a8c215f32b9986edab6
Author: Miklos Vajna vmik...@suse.cz
Date: Wed Jan 2 19:55:34 2013 +0100
sw: fix loplugin warnings
Change-Id: I090a51c112c960b8cc9b208bc7378a5aa3754552
diff --git a/sal/inc/sal/log-areas.dox b/sal/inc/sal/log-areas.dox
index 428c7fb..5232778 100644
--- a/sal/inc/sal/log-areas.dox
+++ b/sal/inc/sal/log-areas.dox
@@ -182,6 +182,7 @@ certain functionality.
@section Writer
@li @c sw
+@li @c sw.level2
@li @c sw.core - Writer core
@li @c sw.rtf - .rtf export filter
@li @c sw.uno - Writer UNO interfaces
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx
b/sw/qa/extras/rtfimport/rtfimport.cxx
index be8c34d..88e6797 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -527,7 +527,6 @@ void Test::testFdo48356()
uno::Referencetext::XTextDocument xTextDocument(mxComponent,
uno::UNO_QUERY);
uno::Referencecontainer::XEnumerationAccess
xParaEnumAccess(xTextDocument-getText(), uno::UNO_QUERY);
uno::Referencecontainer::XEnumeration xParaEnum =
xParaEnumAccess-createEnumeration();
-OUStringBuffer aBuf;
int i = 0;
while (xParaEnum-hasMoreElements())
{
diff --git a/sw/source/core/crsr/crstrvl.cxx b/sw/source/core/crsr/crstrvl.cxx
index 5229fc9..040e998 100644
--- a/sw/source/core/crsr/crstrvl.cxx
+++ b/sw/source/core/crsr/crstrvl.cxx
@@ -1377,7 +1377,7 @@ sal_Bool SwCrsrShell::GetContentAtPos( const Point rPt,
rCntntAtPos.eCntntAtPos =
SwContentAtPos::SW_TABLEBOXVALUE;
else
#endif
-((SwTblBoxFormula*)pItem)-PtrToBoxNm(
pTblNd-GetTable() );
+((SwTblBoxFormula*)pItem)-PtrToBoxNm(
pTblNd-GetTable() );
bRet = sal_True;
if( bSetCrsr )
diff --git a/sw/source/core/unocore/unostyle.cxx
b/sw/source/core/unocore/unostyle.cxx
index 71e7d72..7dc7524 100644
--- a/sw/source/core/unocore/unostyle.cxx
+++ b/sw/source/core/unocore/unostyle.cxx
@@ -873,7 +873,7 @@ void SwXStyleFamily::insertByName(const OUString rName,
const uno::Any rElemen
#if OSL_DEBUG_LEVEL 1
SfxStyleSheetBase rNewBase =
#endif
-pBasePool-Make(sStyleName, eFamily, nMask);
+pBasePool-Make(sStyleName, eFamily, nMask);
pNewStyle-SetDoc(pDocShell-GetDoc(), pBasePool);
pNewStyle-SetStyleName(sStyleName);
String sParentStyleName(pNewStyle-GetParentStyleName());
diff --git a/sw/source/ui/app/docsh2.cxx b/sw/source/ui/app/docsh2.cxx
index f3cbb08..58bbd6d 100644
--- a/sw/source/ui/app/docsh2.cxx
+++ b/sw/source/ui/app/docsh2.cxx
@@ -1691,7 +1691,6 @@ sal_uLong SwDocShell::LoadStylesFromFile( const String
rURL,
// Create a URL from filename
INetURLObject aURLObj( rURL );
-String sURL( aURLObj.GetMainURL( INetURLObject::NO_DECODE ) );
// Set filter:
String
sFactory(rtl::OUString::createFromAscii(SwDocShell::Factory().GetShortName()));
diff --git a/sw/source/ui/ribbar/workctrl.cxx b/sw/source/ui/ribbar/workctrl.cxx
index 4e21205..41088d1 100644
--- a/sw/source/ui/ribbar/workctrl.cxx
+++ b/sw/source/ui/ribbar/workctrl.cxx
@@ -208,13 +208,12 @@ SfxPopupWindow* SwTbxAutoTextCtrl::CreatePopupWindow()
{
// Gruppenname mit Pfad-Extension besorgen
String sTitle;
-String sGroupName = pGlossaryList-GetGroupName(i - 1,
sal_False, sTitle);
sal_uInt16 nBlockCount = pGlossaryList-GetBlockCount(i
-1);
if(nBlockCount)
{
sal_uInt16 nIndex = 100 * (i);
// aber ohne extension einfuegen
-pPopup-InsertItem( i,
sTitle);//sGroupName.GetToken(0, GLOS_DELIM));
+pPopup-InsertItem( i, sTitle);
PopupMenu* pSub = new PopupMenu;
pSub-SetSelectHdl(aLnk);
pPopup-SetPopupMenu(i, pSub);
@@ -306,7 +305,6 @@ IMPL_LINK(SwTbxAutoTextCtrl, PopupHdl, PopupMenu*, pMenu)
SwGlossaryList* pGlossaryList = ::GetGlossaryList();
String sShortName;
String sGroup = pGlossaryList-GetGroupName(nBlock - 1, sal_False);
-String sLongName(pGlossaryList-GetBlockName(nBlock - 1, nId - (100 *
nBlock) - 1, sShortName));
SwGlossaryHdl* pGlosHdl = pView-GetGlosHdl();
SwAbstractDialogFactory* pFact = SwAbstractDialogFactory::Create();
[Libreoffice-commits] .: sc/qa
sc/qa/unit/ucalc.cxx | 34 ++
1 file changed, 34 insertions(+)
New commits:
commit c1f9efa4ac8a406cf10f3b5585f45ee0114621e4
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Wed Jan 2 14:07:09 2013 -0500
fdo#56278: Write a unit test for this.
The reported bug description was very concise and unit-testable. We
should turn it into a real test.
Change-Id: I7383316e8fcf799a59b1c32a1722fd4b6b224d1c
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 55b8b9c..4b7e4fd 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -121,7 +121,16 @@ public:
*/
void testSheetsFunc();
void testVolatileFunc();
+
+/**
+ * Basic test for formula dependency tracking.
+ */
void testFormulaDepTracking();
+
+/**
+ * Another test for formula dependency tracking, inspired by fdo#56278.
+ */
+void testFormulaDepTracking2();
void testFuncParam();
void testNamedRange();
void testCSV();
@@ -248,6 +257,7 @@ public:
CPPUNIT_TEST(testSheetsFunc);
CPPUNIT_TEST(testVolatileFunc);
CPPUNIT_TEST(testFormulaDepTracking);
+CPPUNIT_TEST(testFormulaDepTracking2);
CPPUNIT_TEST(testFuncParam);
CPPUNIT_TEST(testNamedRange);
CPPUNIT_TEST(testCSV);
@@ -1223,6 +1233,30 @@ void Test::testFormulaDepTracking()
m_pDoc-DeleteTab(0);
}
+void Test::testFormulaDepTracking2()
+{
+CPPUNIT_ASSERT_MESSAGE (failed to insert sheet, m_pDoc-InsertTab (0,
foo));
+
+AutoCalcSwitch aACSwitch(m_pDoc, true); // turn on auto calculation.
+
+double val = 2.0;
+m_pDoc-SetValue(0, 0, 0, val);
+val = 4.0;
+m_pDoc-SetValue(1, 0, 0, val);
+val = 5.0;
+m_pDoc-SetValue(0, 1, 0, val);
+m_pDoc-SetString(2, 0, 0, =A1/B1);
+m_pDoc-SetString(1, 1, 0, =B1*C1);
+
+CPPUNIT_ASSERT_EQUAL(2.0, m_pDoc-GetValue(1, 1, 0)); // B2 should equal 2.
+
+clearRange(m_pDoc, ScAddress(2, 0, 0)); // Delete C1.
+
+CPPUNIT_ASSERT_EQUAL(0.0, m_pDoc-GetValue(1, 1, 0)); // B2 should now
equal 0.
+
+m_pDoc-DeleteTab(0);
+}
+
void Test::testFuncParam()
{
rtl::OUString aTabName(foo);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] fdo#40465 fix to maintain focus whilst zooming
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1533
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/1533/1
fdo#40465 fix to maintain focus whilst zooming
Change-Id: I3fab5d62d8f479a5efe242693d2fbe33375206f8
---
M dictionaries
M helpcontent2
M sw/source/ui/uiview/viewmdi.cxx
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/dictionaries b/dictionaries
index f0c914a..1595bf1 16
--- a/dictionaries
+++ b/dictionaries
-Subproject commit f0c914a43e7e6540300da25c935a77aebb672094
+Subproject commit 1595bf11e295d96123fcb327ba9919307aa5b127
diff --git a/helpcontent2 b/helpcontent2
index d5d84f0..1909df0 16
--- a/helpcontent2
+++ b/helpcontent2
-Subproject commit d5d84f0ec4584e32147eeab355d0ab73e7dd9172
+Subproject commit 1909df07cbd54bf753514cc6dc4137b7b69af63c
diff --git a/sw/source/ui/uiview/viewmdi.cxx b/sw/source/ui/uiview/viewmdi.cxx
index 286435e..17a1ac5 100644
--- a/sw/source/ui/uiview/viewmdi.cxx
+++ b/sw/source/ui/uiview/viewmdi.cxx
@@ -65,6 +65,9 @@
void SwView::SetZoom( SvxZoomType eZoomType, short nFactor, sal_Bool bViewOnly
)
{
_SetZoom( GetEditWin().GetOutputSizePixel(), eZoomType, nFactor, bViewOnly
);
+
+//fdo40465 force the cursor to stay in view whilst zooming
+pWrtShell-ShowCrsr();
}
void SwView::_SetZoom( const Size rEditSize, SvxZoomType eZoomType,
--
To view, visit https://gerrit.libreoffice.org/1533
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fab5d62d8f479a5efe242693d2fbe33375206f8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/qa sc/source
sc/qa/unit/ucalc.cxx | 10 ++
sc/source/core/tool/scmatrix.cxx |2 ++
2 files changed, 12 insertions(+)
New commits:
commit 79f1ef44e77074d8f5a1d32e0447118e5b9c4e70
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Wed Jan 2 15:49:24 2013 -0500
fdo#58539: Resizing matrix should also resize the flag storage too.
Or else resizing and then putting empty elements may crash. The flag
storage is used only for empty elements.
Change-Id: I1ada8f795a01336af185e6180bc03247c44472ba
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 4b7e4fd..6a8af5d 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -1548,6 +1548,16 @@ void Test::testMatrix()
pMat-PutString(aStr, 8, 2);
pMat-PutEmptyPath(8, 11);
checkMatrixElementsPartiallyFilledEmptyMatrix(*pMat);
+
+// Test resizing.
+pMat = new ScMatrix(0, 0);
+pMat-Resize(2, 2, 1.5);
+pMat-PutEmpty(1, 1);
+
+CPPUNIT_ASSERT_EQUAL(1.5, pMat-GetDouble(0, 0));
+CPPUNIT_ASSERT_EQUAL(1.5, pMat-GetDouble(0, 1));
+CPPUNIT_ASSERT_EQUAL(1.5, pMat-GetDouble(1, 0));
+CPPUNIT_ASSERT_MESSAGE(PutEmpty() call failed., pMat-IsEmpty(1, 1));
}
void Test::testEnterMixedMatrix()
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 66dcb2f..0a92ffc 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -418,11 +418,13 @@ bool ScMatrixImpl::IsImmutable() const
void ScMatrixImpl::Resize(SCSIZE nC, SCSIZE nR)
{
maMat.resize(nR, nC);
+maMatFlag.resize(nR, nC);
}
void ScMatrixImpl::Resize(SCSIZE nC, SCSIZE nR, double fVal)
{
maMat.resize(nR, nC, fVal);
+maMatFlag.resize(nR, nC);
}
void ScMatrixImpl::SetErrorInterpreter( ScInterpreter* p)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: nss/ExternalPackage_nss.mk
nss/ExternalPackage_nss.mk |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) New commits: commit ebaaefcbf34d037aa8091ffbef3b7f8adc7a9ac5 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Wed Jan 2 21:56:30 2013 +0100 try to sort out libsqlite3 handling in nss diff --git a/nss/ExternalPackage_nss.mk b/nss/ExternalPackage_nss.mk index ce19727..6f106af 100644 --- a/nss/ExternalPackage_nss.mk +++ b/nss/ExternalPackage_nss.mk @@ -29,9 +29,11 @@ $(eval $(call gb_ExternalPackage_add_files,nss,lib,\ mozilla/dist/out/lib/libplds4.dylib \ mozilla/dist/out/lib/libsmime3.dylib \ mozilla/dist/out/lib/libsoftokn3.dylib \ - mozilla/dist/out/lib/libsqlite3.dylib \ mozilla/dist/out/lib/libssl3.dylib \ )) +$(eval $(call gb_ExternalPackage_add_files,nss,lib/sqlite,\ + $(if $(filter 1060 1070 1080,$(MAC_OS_X_VERSION_MIN_REQUIRED)),,mozilla/dist/out/lib/libsqlite3.dylib) \ +)) else ifeq ($(OS),WNT) ifeq ($(COM),MSC) $(eval $(call gb_ExternalPackage_add_files,nss,lib,\ @@ -86,9 +88,11 @@ $(eval $(call gb_ExternalPackage_add_files,nss,lib,\ mozilla/dist/out/lib/libplds4.so \ mozilla/dist/out/lib/libsmime3.so \ mozilla/dist/out/lib/libsoftokn3.so \ - mozilla/dist/out/lib/libsqlite3.so \ mozilla/dist/out/lib/libssl3.so \ )) +$(eval $(call gb_ExternalPackage_add_files,nss,lib/sqlite,\ + mozilla/dist/out/lib/libsqlite3.so \ +)) endif # vim: set noet sw=4 ts=4: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/ui/unoobj/dapiuno.cxx | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
New commits:
commit c27e334661b62897a81a450ea9188f80e053261e
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Wed Jan 2 16:03:35 2013 -0500
fdo#58539: Avoid throwing exception not specified in the signature.
This should fix the crasher with the fdo#45266 document.
Change-Id: I41cf02f211e289b85c31b2d2d60e0c4d849b7e8e
diff --git a/sc/source/ui/unoobj/dapiuno.cxx b/sc/source/ui/unoobj/dapiuno.cxx
index feb8b4c..07c2693 100644
--- a/sc/source/ui/unoobj/dapiuno.cxx
+++ b/sc/source/ui/unoobj/dapiuno.cxx
@@ -2697,8 +2697,16 @@ Reference XDataPilotField SAL_CALL
ScDataPilotFieldObj::createNameGroup( cons
Reference XNameAccess xFields(mrParent.getDataPilotFields(),
UNO_QUERY);
if (xFields.is())
{
-xRet.set(xFields-getByName(sNewDim), UNO_QUERY);
-OSL_ENSURE(xRet.is(), there is a name, so there should be also a
field);
+try
+{
+xRet.set(xFields-getByName(sNewDim), UNO_QUERY);
+OSL_ENSURE(xRet.is(), there is a name, so there should be
also a field);
+}
+catch (const container::NoSuchElementException)
+{
+// Avoid throwing exception that's not specified in the method
signature.
+throw RuntimeException();
+}
}
}
return xRet;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
How to set the temp directory when building LibreOffice ?
Hi all, When building LibreOffice, a lot of files are created in the standard temp directory (/tmp for me under Ubuntu). Many of these files are not removed when the build has been completed with success. I think it would be cleaner if these temporary files was created in a subdirectory of /tmp. Is there an option to set the temp directory ? I did not find such an option in the options list of autogen.sh. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Get rid of nsinstall hackery
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1534 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/1534/1 Get rid of nsinstall hackery This removes the need for using NSS Build Tools on windows. It also removes the nees to build nss for the build system while cross compiling. Change-Id: I13c9fdb575223f2940d3e4eda00e77ba9158f2b7 --- M Makefile.in M config_host.mk.in M configure.ac M nss/ExternalProject_nss.mk M nss/Module_nss.mk M nss/nsinstall.py 6 files changed, 9 insertions(+), 35 deletions(-) diff --git a/Makefile.in b/Makefile.in index 2a56db0..0b54e3b 100644 --- a/Makefile.in +++ b/Makefile.in @@ -298,13 +298,6 @@ $(GNUMAKE) gb_Side=build icu # cd cross_toolset $(GNUMAKE) -j $(PARALLELISM) $(GMAKE_OPTIONS) -# -ifneq (,$(filter DESKTOP,$(BUILD_TYPE))) -ifneq (WNT,$(OS)) -# We need to build nss for nsinstall... See NSINSTALL=... in nss/makefile.mk - $(GNUMAKE) gb_Side=build nss -endif -endif # # Install diff --git a/config_host.mk.in b/config_host.mk.in index 70f8c4e..1c98744 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -411,7 +411,6 @@ export NSS_PATCH=@NSS_PATCH@ export NSS_CFLAGS=$(gb_SPACE)@NSS_CFLAGS@ export NSS_LIBS=$(gb_SPACE)@NSS_LIBS@ -export NSSBUILDTOOLS=@NSSBUILDTOOLS@ export NUMBERTEXT_EXTENSION_PACK=@NUMBERTEXT_EXTENSION_PACK@ @x_OBJCFLAGS@ export OBJCFLAGS=@OBJCFLAGS@ @x_OBJCXXFLAGS@ export OBJCXXFLAGS=@OBJCXXFLAGS@ diff --git a/configure.ac b/configure.ac index c60ae01..4b32e6b 100644 --- a/configure.ac +++ b/configure.ac @@ -8281,22 +8281,6 @@ NSS_PATCH=5 BUILD_TYPE=$BUILD_TYPE NSS AC_MSG_RESULT([internal]) -if test $build_os = cygwin; then -AC_MSG_CHECKING([for nss build tooling]) # coming from mozilla -if test -z $NSSBUILDTOOLS; then -AC_MSG_ERROR([nss build tooling not provided -Use the --with-nss-build-tools option after installing the tools obtained -from http://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32]) -else -if test \( $WITH_MINGW = yes -a ! -d $NSSBUILDTOOLS \) \ --o ! -d $NSSBUILDTOOLS/moztools \ --o ! -d $NSSBUILDTOOLS/msys ; then -AC_MSG_ERROR([nss build tooling incomplete!]) -else -AC_MSG_RESULT([ok]) -fi -fi -fi fi # system nss AC_SUBST(SYSTEM_NSS) AC_SUBST(NSS_MAJOR) @@ -8304,7 +8288,6 @@ AC_SUBST(NSS_PATCH) AC_SUBST(NSS_CFLAGS) AC_SUBST(NSS_LIBS) -AC_SUBST(NSSBUILDTOOLS) AC_SUBST(MINGW_SMIME3_DLL) dnl === diff --git a/nss/ExternalProject_nss.mk b/nss/ExternalProject_nss.mk index 330a6e6..7ddbcae 100644 --- a/nss/ExternalProject_nss.mk +++ b/nss/ExternalProject_nss.mk @@ -34,15 +34,15 @@ ifeq ($(OS),WNT) ifeq ($(COM),MSC) -$(call gb_ExternalProject_get_state_target,nss,build): $(call gb_ExternalProject_get_state_target,nss,configure) +$(call gb_ExternalProject_get_state_target,nss,build): $(call gb_ExternalProject_get_state_target,nss,configure) $(call gb_ExternalExecutable_get_dependencies,python) cd $(EXTERNAL_WORKDIR)/mozilla/security/nss \ $(if $(debug),,BUILD_OPT=1) \ MOZ_MSVCVERSION=9 OS_TARGET=WIN95 \ - PATH=$(NSSBUILDTOOLS)/msys/bin:$(NSSBUILDTOOLS)/moztools/bin:$(PATH) \ $(if $(filter X,$(CPU)),USE_64=1) \ LIB=$(ILIB) \ XCFLAGS=$(SOLARINC) \ $(MAKE) -j1 nss_build_all RC=rc.exe $(SOLARINC) \ + NSINSTALL='$(call gb_ExternalExecutable_get_command,python) $(SRCDIR)/nss/nsinstall.py' \ touch $@ @@ -53,7 +53,7 @@ CXX=$(CXX) $(if $(filter YES,$(MINGW_SHARED_GCCLIB)),-shared-libgcc) \ OS_LIBS=-ladvapi32 -lws2_32 -lmwsock -lwinm $(if $(filter YES,$(MINGW_SHARED_GXXLIB)),$(MINGW_SHARED_LIBSTDCPP)) \ OS_TARGET=WINNT RC=$(WINDRES) OS_RELEASE=5.0 \ - PATH=$(NSSBUILDTOOLS)/bin:$(PATH) IMPORT_LIB_SUFFIX=dll.a \ + IMPORT_LIB_SUFFIX=dll.a \ NSPR_CONFIGURE_OPTS=--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM) --enable-shared --disable-static \ NSINSTALL=$(PYTHON_FOR_BUILD) $(SRCDIR)/nss/nsinstall.py \ $(MAKE) -j1 nss_build_all \ @@ -69,10 +69,9 @@ $(if $(filter SOLARIS,$(OS)),NS_USE_GCC=1) \ $(if $(filter YES,$(CROSS_COMPILING)),\ $(if $(filter MACOSXP,$(OS)$(CPU)),CPU_ARCH=ppc) \ - NSINSTALL=$(subst $(INPATH),$(INPATH_FOR_BUILD),\ - $(call gb_UnpackedTarball_get_dir,nss)/mozilla/security/coreconf/nsinstall/out/nsinstall)) \ + NSINSTALL=$(PYTHON_FOR_BUILD) $(SRCDIR)/nss/nsinstall.py) \ NSDISTMODE=copy \ - $(MAKE) -j1 $(if $(filter build,$(gb_Side)),build_coreconf,nss_build_all) \ + $(MAKE) -j1 nss_build_all \ touch $@ endif diff --git a/nss/Module_nss.mk b/nss/Module_nss.mk index 5455fc0..c1619ff 100644 --- a/nss/Module_nss.mk +++ b/nss/Module_nss.mk @@ -13,7
[Libreoffice-commits] .: 2 commits - distro-configs/LibreOfficeMinGW.conf sc/Library_scfilt.mk
distro-configs/LibreOfficeMinGW.conf |1 + sc/Library_scfilt.mk |2 +- 2 files changed, 2 insertions(+), 1 deletion(-) New commits: commit 669c27ca0575e046b37db7ecc0a3d24ed2001a62 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Thu Jan 3 00:39:02 2013 +0100 system-zlib for mingw diff --git a/distro-configs/LibreOfficeMinGW.conf b/distro-configs/LibreOfficeMinGW.conf index 039ce78..e14e993 100644 --- a/distro-configs/LibreOfficeMinGW.conf +++ b/distro-configs/LibreOfficeMinGW.conf @@ -18,6 +18,7 @@ --with-system-openssl --with-system-poppler --with-system-redland +--with-system-zlib --without-junit --without-myspell-dicts --disable-activex commit ec51a95936499cdab17e5b892cc8abb648fc710d Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Thu Jan 3 00:38:09 2013 +0100 libs should be listed after the libs that require them diff --git a/sc/Library_scfilt.mk b/sc/Library_scfilt.mk index bdb99ca..3901091 100644 --- a/sc/Library_scfilt.mk +++ b/sc/Library_scfilt.mk @@ -65,8 +65,8 @@ $(eval $(call gb_Library_use_libraries,scfilt,\ )) $(eval $(call gb_Library_use_externals,scfilt,\ - zlib \ orcus \ + zlib \ )) $(eval $(call gb_Library_add_exception_objects,scfilt,\ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/filter/xml/xmlsubti.cxx |2 ++
sc/source/filter/xml/xmlsubti.hxx |2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
New commits:
commit fa1b00095011def26cc291e74948817632e3545d
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Thu Jan 3 01:41:45 2013 +0100
don't overflow column number during import, fdo#58539
This should fix the crash with kde#245919
Change-Id: I7c3af01e27233d2f94d5585247c59e7d5b6ea8ca
diff --git a/sc/source/filter/xml/xmlsubti.cxx
b/sc/source/filter/xml/xmlsubti.cxx
index 2dddb90..1950e3c 100644
--- a/sc/source/filter/xml/xmlsubti.cxx
+++ b/sc/source/filter/xml/xmlsubti.cxx
@@ -220,6 +220,8 @@ void ScMyTables::AddColStyle(const sal_Int32 nRepeat, const
rtl::OUString rCell
{
rImport.GetStylesImportHelper()-AddColumnStyle(rCellStyleName,
nCurrentColCount, nRepeat);
nCurrentColCount += nRepeat;
+SAL_WARN_IF(nCurrentColCount MAXCOL, sc, more columns than fit into
SCCOL);
+nCurrentColCount = std::minsal_Int32( nCurrentColCount, MAXCOL );
}
uno::Reference drawing::XDrawPage ScMyTables::GetCurrentXDrawPage()
diff --git a/sc/source/filter/xml/xmlsubti.hxx
b/sc/source/filter/xml/xmlsubti.hxx
index 2cdea77..b770771 100644
--- a/sc/source/filter/xml/xmlsubti.hxx
+++ b/sc/source/filter/xml/xmlsubti.hxx
@@ -87,7 +87,7 @@ public:
ScXMLTabProtectionData GetCurrentProtectionData() { return
maProtectionData; }
rtl::OUString GetCurrentSheetName() const { return
sCurrentSheetName; }
SCTAB GetCurrentSheet() const { return
(maCurrentCellPos.Tab() = 0) ? maCurrentCellPos.Tab() : 0; }
-SCCOL GetCurrentColCount() const { return
nCurrentColCount; }
+SCCOL GetCurrentColCount() const { return
std::minsal_Int32(nCurrentColCount, MAXCOL); }
SCROW GetCurrentRow() const { return
(maCurrentCellPos.Row() = 0) ? maCurrentCellPos.Row() : 0; }
::com::sun::star::uno::Reference ::com::sun::star::sheet::XSpreadsheet
GetCurrentXSheet() const { return
xCurrentSheet; }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: nss/ExternalPackage_nss.mk
nss/ExternalPackage_nss.mk |2 ++ 1 file changed, 2 insertions(+) New commits: commit 96e7e3564b473944218ea2f5440c70399e978e14 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Thu Jan 3 02:00:58 2013 +0100 add missing nss windows libs diff --git a/nss/ExternalPackage_nss.mk b/nss/ExternalPackage_nss.mk index 6f106af..7c8ffdb 100644 --- a/nss/ExternalPackage_nss.mk +++ b/nss/ExternalPackage_nss.mk @@ -63,8 +63,10 @@ $(eval $(call gb_ExternalPackage_add_files,nss,lib,\ )) endif $(eval $(call gb_ExternalPackage_add_files,nss,bin,\ + mozilla/dist/out/lib/freebl3.dll \ mozilla/dist/out/lib/nspr4.dll \ mozilla/dist/out/lib/nss3.dll \ + mozilla/dist/out/lib/nssckbi.dll \ mozilla/dist/out/lib/nssdbm3.dll \ mozilla/dist/out/lib/nssutil3.dll \ mozilla/dist/out/lib/plc4.dll \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: How to set the temp directory when building LibreOffice ?
Hi, I've just sent a message on similar topic :) On Thu, Jan 3, 2013 at 1:11 AM, Jean-Baptiste Faure jbf.fa...@sud-ouest.org wrote: Hi all, When building LibreOffice, a lot of files are created in the standard temp directory (/tmp for me under Ubuntu). Many of these files are not removed when the build has been completed with success. I think it would be cleaner if these temporary files was created in a subdirectory of /tmp. Is there an option to set the temp directory ? I did not find such an option in the options list of autogen.sh. If anything, you can always use standard TMPDIR environment variable. Regards, Ruslan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: xmloff/source
xmloff/source/style/xmlnumfi.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 5693934456f917861af7cb02734578b049a46940
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Thu Jan 3 02:18:25 2013 +0100
limit the number of imported digits, fdo#58539
This should fix the crash with gnome#627420.
Change-Id: Ibfff498282dc1c6fe9124ced645392107ef8829f
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index 7b0799c..8b57734 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -916,6 +916,8 @@ static void lcl_EnquoteIfNecessary( rtl::OUStringBuffer
rContent, const SvXMLNu
// SvXMLNumFmtElementContext
//
+const sal_Int32 MAX_SECOND_DIGITS = 20; // fdo#58539 gnome#627420: limit
number of digits during import
+
SvXMLNumFmtElementContext::SvXMLNumFmtElementContext( SvXMLImport rImport,
sal_uInt16 nPrfx, const rtl::OUString
rLName,
SvXMLNumFormatContext rParentContext,
sal_uInt16 nNewType,
@@ -948,7 +950,7 @@ SvXMLNumFmtElementContext::SvXMLNumFmtElementContext(
SvXMLImport rImport,
{
case XML_TOK_ELEM_ATTR_DECIMAL_PLACES:
if (::sax::Converter::convertNumber( nAttrVal, sValue, 0 ))
-aNumInfo.nDecimals = nAttrVal;
+aNumInfo.nDecimals = std::minsal_Int32(nAttrVal,
MAX_SECOND_DIGITS);
break;
case XML_TOK_ELEM_ATTR_MIN_INTEGER_DIGITS:
if (::sax::Converter::convertNumber( nAttrVal, sValue, 0 ))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: nss/nss.windows.patch nss/UnpackedTarball_nss.mk
nss/UnpackedTarball_nss.mk |1 + nss/nss.windows.patch | 11 +++ 2 files changed, 12 insertions(+) New commits: commit dfbcb34441fed0d38e7c86f32d659ba8ab52640f Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Thu Jan 3 02:35:40 2013 +0100 force nss build to pass windows path to cl.exe Not sure what's wrong exactly, but on one tinderbox cl fails because of unknown argument (unix path to the source file). Work it around by explicitly converting the path to windows path. diff --git a/nss/UnpackedTarball_nss.mk b/nss/UnpackedTarball_nss.mk index 6e9ad7b..44b9d14 100644 --- a/nss/UnpackedTarball_nss.mk +++ b/nss/UnpackedTarball_nss.mk @@ -16,6 +16,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,nss,\ nss/nss.aix.patch \ nss/nss-3.13.5-zlib-werror.patch \ $(if $(filter MACOSX,$(OS)),nss/nss_macosx.patch) \ + $(if $(filter WNTMSC,$(OS)$(COM)),nss/nss.windows.patch) \ $(if $(filter WNTGCC,$(OS)$(COM)),nss/nspr-4.9-build.patch \ nss/nss-3.13.3-build.patch \ nss/nss.mingw.patch) \ diff --git a/nss/nss.windows.patch b/nss/nss.windows.patch new file mode 100644 index 000..935943b --- /dev/null +++ b/nss/nss.windows.patch @@ -0,0 +1,11 @@ +--- misc/nss-3.13.5/mozilla/nsprpub/config/rules.mk2008-12-03 00:24:39.0 +0100 misc/build/nss-3.13.5/mozilla/nsprpub/config/rules.mk 2009-11-27 13:36:22.662753328 +0100 +@@ -415,7 +415,7 @@ + + ifdef NEED_ABSOLUTE_PATH + # The quotes allow absolute paths to contain spaces. +-pr_abspath = $(if $(findstring :,$(1)),$(1),$(if $(filter /%,$(1)),$(1),$(CURDIR)/$(1))) ++pr_abspath = $(if $(findstring :,$(1)),$(1),$(if $(filter /%,$(shell cygpath -m $(1))),$(1),$(shell cygpath -m $(CURDIR)/$(1 + endif + + $(OBJDIR)/%.$(OBJ_SUFFIX): %.cpp ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: nss/nss.windows.patch
nss/nss.windows.patch | 11 +++ 1 file changed, 11 insertions(+) New commits: commit 58e76a64b46791406277d574deecb081f230b910 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Thu Jan 3 02:52:50 2013 +0100 one more place for forcing windows path in nss build diff --git a/nss/nss.windows.patch b/nss/nss.windows.patch index 935943b..0d4ce1b 100644 --- a/nss/nss.windows.patch +++ b/nss/nss.windows.patch @@ -9,3 +9,14 @@ endif $(OBJDIR)/%.$(OBJ_SUFFIX): %.cpp +--- misc/nss-3.13.5/mozilla/security/coreconf/rules.mk 2008-12-03 00:24:39.0 +0100 misc/build/nss-3.13.5/mozilla/security/coreconf/rules.mk 2009-11-27 13:36:22.662753328 +0100 +@@ -411,7 +411,7 @@ + endif + + # The quotes allow absolute paths to contain spaces. +-core_abspath = $(if $(findstring :,$(1)),$(1),$(if $(filter /%,$(1)),$(1),$(PWD)/$(1))) ++core_abspath = $(if $(findstring :,$(1)),$(1),$(if $(filter /%,$(shell cygpath -m $(1))),$(1),$(shell cygpath -m $(PWD)/$(1 + + $(OBJDIR)/$(PROG_PREFIX)%$(OBJ_SUFFIX): %.c + @$(MAKE_OBJDIR) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 3 commits - sc/qa sc/source
sc/qa/unit/ucalc.cxx | 44 +++
sc/source/core/tool/scmatrix.cxx |2 +
sc/source/ui/unoobj/dapiuno.cxx | 12 --
3 files changed, 56 insertions(+), 2 deletions(-)
New commits:
commit b060b43f093dce23222fd99375b1c6bd433703d9
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Wed Jan 2 16:03:35 2013 -0500
fdo#58539: Avoid throwing exception not specified in the signature.
This should fix the crasher with the fdo#45266 document.
Change-Id: I41cf02f211e289b85c31b2d2d60e0c4d849b7e8e
diff --git a/sc/source/ui/unoobj/dapiuno.cxx b/sc/source/ui/unoobj/dapiuno.cxx
index feb8b4c..07c2693 100644
--- a/sc/source/ui/unoobj/dapiuno.cxx
+++ b/sc/source/ui/unoobj/dapiuno.cxx
@@ -2697,8 +2697,16 @@ Reference XDataPilotField SAL_CALL
ScDataPilotFieldObj::createNameGroup( cons
Reference XNameAccess xFields(mrParent.getDataPilotFields(),
UNO_QUERY);
if (xFields.is())
{
-xRet.set(xFields-getByName(sNewDim), UNO_QUERY);
-OSL_ENSURE(xRet.is(), there is a name, so there should be also a
field);
+try
+{
+xRet.set(xFields-getByName(sNewDim), UNO_QUERY);
+OSL_ENSURE(xRet.is(), there is a name, so there should be
also a field);
+}
+catch (const container::NoSuchElementException)
+{
+// Avoid throwing exception that's not specified in the method
signature.
+throw RuntimeException();
+}
}
}
return xRet;
commit 30285360e5d1fbb14bb6bf54e55a3a9f9b7619e7
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Wed Jan 2 15:49:24 2013 -0500
fdo#58539: Resizing matrix should also resize the flag storage too.
Or else resizing and then putting empty elements may crash. The flag
storage is used only for empty elements.
Change-Id: I1ada8f795a01336af185e6180bc03247c44472ba
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 4b7e4fd..6a8af5d 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -1548,6 +1548,16 @@ void Test::testMatrix()
pMat-PutString(aStr, 8, 2);
pMat-PutEmptyPath(8, 11);
checkMatrixElementsPartiallyFilledEmptyMatrix(*pMat);
+
+// Test resizing.
+pMat = new ScMatrix(0, 0);
+pMat-Resize(2, 2, 1.5);
+pMat-PutEmpty(1, 1);
+
+CPPUNIT_ASSERT_EQUAL(1.5, pMat-GetDouble(0, 0));
+CPPUNIT_ASSERT_EQUAL(1.5, pMat-GetDouble(0, 1));
+CPPUNIT_ASSERT_EQUAL(1.5, pMat-GetDouble(1, 0));
+CPPUNIT_ASSERT_MESSAGE(PutEmpty() call failed., pMat-IsEmpty(1, 1));
}
void Test::testEnterMixedMatrix()
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 66dcb2f..0a92ffc 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -418,11 +418,13 @@ bool ScMatrixImpl::IsImmutable() const
void ScMatrixImpl::Resize(SCSIZE nC, SCSIZE nR)
{
maMat.resize(nR, nC);
+maMatFlag.resize(nR, nC);
}
void ScMatrixImpl::Resize(SCSIZE nC, SCSIZE nR, double fVal)
{
maMat.resize(nR, nC, fVal);
+maMatFlag.resize(nR, nC);
}
void ScMatrixImpl::SetErrorInterpreter( ScInterpreter* p)
commit e2b91f39f7162e031c07235a60bfe04f26fee53a
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Wed Jan 2 14:07:09 2013 -0500
fdo#56278: Write a unit test for this.
The reported bug description was very concise and unit-testable. We
should turn it into a real test.
Change-Id: I7383316e8fcf799a59b1c32a1722fd4b6b224d1c
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 55b8b9c..4b7e4fd 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -121,7 +121,16 @@ public:
*/
void testSheetsFunc();
void testVolatileFunc();
+
+/**
+ * Basic test for formula dependency tracking.
+ */
void testFormulaDepTracking();
+
+/**
+ * Another test for formula dependency tracking, inspired by fdo#56278.
+ */
+void testFormulaDepTracking2();
void testFuncParam();
void testNamedRange();
void testCSV();
@@ -248,6 +257,7 @@ public:
CPPUNIT_TEST(testSheetsFunc);
CPPUNIT_TEST(testVolatileFunc);
CPPUNIT_TEST(testFormulaDepTracking);
+CPPUNIT_TEST(testFormulaDepTracking2);
CPPUNIT_TEST(testFuncParam);
CPPUNIT_TEST(testNamedRange);
CPPUNIT_TEST(testCSV);
@@ -1223,6 +1233,30 @@ void Test::testFormulaDepTracking()
m_pDoc-DeleteTab(0);
}
+void Test::testFormulaDepTracking2()
+{
+CPPUNIT_ASSERT_MESSAGE (failed to insert sheet, m_pDoc-InsertTab (0,
foo));
+
+AutoCalcSwitch aACSwitch(m_pDoc, true); // turn on auto calculation.
+
+double val = 2.0;
+m_pDoc-SetValue(0, 0, 0, val);
+val = 4.0;
+m_pDoc-SetValue(1, 0, 0, val);
+val = 5.0;
+m_pDoc-SetValue(0, 1, 0, val);
+m_pDoc-SetString(2, 0, 0, =A1/B1);
+m_pDoc-SetString(1, 1, 0, =B1*C1);
+
+
Re: [PATCH] Get rid of nsinstall hackery
Hi Peter, Two caveats I want to submit : what happens if --disable-python is here ? And this thread [1] has never come to a solution about ssl API, but your change may conflict with one of the scenarios if the python version is not enough. [1] http://lists.freedesktop.org/archives/libreoffice/2012-May/031198.html -- Regards Mat M Le Thu, 03 Jan 2013 00:25:21 +0100, Peter Foley (via Code Review) ger...@gerrit.libreoffice.org a écrit: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1534 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/1534/1 Get rid of nsinstall hackery This removes the need for using NSS Build Tools on windows. It also removes the nees to build nss for the build system while cross compiling. Change-Id: I13c9fdb575223f2940d3e4eda00e77ba9158f2b7 --- M Makefile.in M config_host.mk.in M configure.ac M nss/ExternalProject_nss.mk M nss/Module_nss.mk M nss/nsinstall.py 6 files changed, 9 insertions(+), 35 deletions(-) diff --git a/Makefile.in b/Makefile.in index 2a56db0..0b54e3b 100644 --- a/Makefile.in +++ b/Makefile.in @@ -298,13 +298,6 @@ $(GNUMAKE) gb_Side=build icu # cd cross_toolset $(GNUMAKE) -j $(PARALLELISM) $(GMAKE_OPTIONS) -# -ifneq (,$(filter DESKTOP,$(BUILD_TYPE))) -ifneq (WNT,$(OS)) -# We need to build nss for nsinstall... See NSINSTALL=... in nss/makefile.mk - $(GNUMAKE) gb_Side=build nss -endif -endif # # Install diff --git a/config_host.mk.in b/config_host.mk.in index 70f8c4e..1c98744 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -411,7 +411,6 @@ export NSS_PATCH=@NSS_PATCH@ export NSS_CFLAGS=$(gb_SPACE)@NSS_CFLAGS@ export NSS_LIBS=$(gb_SPACE)@NSS_LIBS@ -export NSSBUILDTOOLS=@NSSBUILDTOOLS@ export NUMBERTEXT_EXTENSION_PACK=@NUMBERTEXT_EXTENSION_PACK@ @x_OBJCFLAGS@ export OBJCFLAGS=@OBJCFLAGS@ @x_OBJCXXFLAGS@ export OBJCXXFLAGS=@OBJCXXFLAGS@ diff --git a/configure.ac b/configure.ac index c60ae01..4b32e6b 100644 --- a/configure.ac +++ b/configure.ac @@ -8281,22 +8281,6 @@ NSS_PATCH=5 BUILD_TYPE=$BUILD_TYPE NSS AC_MSG_RESULT([internal]) -if test $build_os = cygwin; then -AC_MSG_CHECKING([for nss build tooling]) # coming from mozilla -if test -z $NSSBUILDTOOLS; then -AC_MSG_ERROR([nss build tooling not provided -Use the --with-nss-build-tools option after installing the tools obtained -from http://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32]) -else -if test \( $WITH_MINGW = yes -a ! -d $NSSBUILDTOOLS \) \ --o ! -d $NSSBUILDTOOLS/moztools \ --o ! -d $NSSBUILDTOOLS/msys ; then -AC_MSG_ERROR([nss build tooling incomplete!]) -else -AC_MSG_RESULT([ok]) -fi -fi -fi fi # system nss AC_SUBST(SYSTEM_NSS) AC_SUBST(NSS_MAJOR) @@ -8304,7 +8288,6 @@ AC_SUBST(NSS_PATCH) AC_SUBST(NSS_CFLAGS) AC_SUBST(NSS_LIBS) -AC_SUBST(NSSBUILDTOOLS) AC_SUBST(MINGW_SMIME3_DLL) dnl === diff --git a/nss/ExternalProject_nss.mk b/nss/ExternalProject_nss.mk index 330a6e6..7ddbcae 100644 --- a/nss/ExternalProject_nss.mk +++ b/nss/ExternalProject_nss.mk @@ -34,15 +34,15 @@ ifeq ($(OS),WNT) ifeq ($(COM),MSC) -$(call gb_ExternalProject_get_state_target,nss,build): $(call gb_ExternalProject_get_state_target,nss,configure) +$(call gb_ExternalProject_get_state_target,nss,build): $(call gb_ExternalProject_get_state_target,nss,configure) $(call gb_ExternalExecutable_get_dependencies,python) cd $(EXTERNAL_WORKDIR)/mozilla/security/nss \ $(if $(debug),,BUILD_OPT=1) \ MOZ_MSVCVERSION=9 OS_TARGET=WIN95 \ - PATH=$(NSSBUILDTOOLS)/msys/bin:$(NSSBUILDTOOLS)/moztools/bin:$(PATH) \ $(if $(filter X,$(CPU)),USE_64=1) \ LIB=$(ILIB) \ XCFLAGS=$(SOLARINC) \ $(MAKE) -j1 nss_build_all RC=rc.exe $(SOLARINC) \ + NSINSTALL='$(call gb_ExternalExecutable_get_command,python) $(SRCDIR)/nss/nsinstall.py' \ touch $@ @@ -53,7 +53,7 @@ CXX=$(CXX) $(if $(filter YES,$(MINGW_SHARED_GCCLIB)),-shared-libgcc) \ OS_LIBS=-ladvapi32 -lws2_32 -lmwsock -lwinm $(if $(filter YES,$(MINGW_SHARED_GXXLIB)),$(MINGW_SHARED_LIBSTDCPP)) \ OS_TARGET=WINNT RC=$(WINDRES) OS_RELEASE=5.0 \ - PATH=$(NSSBUILDTOOLS)/bin:$(PATH) IMPORT_LIB_SUFFIX=dll.a \ + IMPORT_LIB_SUFFIX=dll.a \ NSPR_CONFIGURE_OPTS=--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM) --enable-shared --disable-static \ NSINSTALL=$(PYTHON_FOR_BUILD) $(SRCDIR)/nss/nsinstall.py \ $(MAKE) -j1 nss_build_all \ @@ -69,10 +69,9 @@ $(if $(filter SOLARIS,$(OS)),NS_USE_GCC=1) \ $(if $(filter YES,$(CROSS_COMPILING)),\ $(if $(filter MACOSXP,$(OS)$(CPU)),CPU_ARCH=ppc) \ - NSINSTALL=$(subst $(INPATH),$(INPATH_FOR_BUILD),\ - $(call
[Libreoffice-commits] .: sc/source
sc/source/filter/oox/defnamesbuffer.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 7a8a3e46978b3397ca8aba38917bd5dbc808c9b8 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Wed Jan 2 23:56:43 2013 -0500 fdo#58539: Properly initialize a member pointer value. Or else it would crash when loading the doc from fdo#55174. Change-Id: I21eb77f97dcab467c185dacaf9f00753bb4fc18c diff --git a/sc/source/filter/oox/defnamesbuffer.cxx b/sc/source/filter/oox/defnamesbuffer.cxx index d735ac4..488b7e3 100644 --- a/sc/source/filter/oox/defnamesbuffer.cxx +++ b/sc/source/filter/oox/defnamesbuffer.cxx @@ -285,6 +285,7 @@ ApiTokenSequence DefinedNameBase::importBiffFormula( sal_Int16 nBaseSheet, BiffI DefinedName::DefinedName( const WorkbookHelper rHelper ) : DefinedNameBase( rHelper ), +mpScRangeData(NULL), mnTokenIndex( -1 ), mcBuiltinId( BIFF_DEFNAME_UNKNOWN ), mnFmlaSize( 0 ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/filter/excel/xichart.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 329f3cd02546dfe58bf00f6ad3b71bc84a8d4320
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Jan 3 00:27:08 2013 -0500
fdo#58539: Check for mxValueLink being NULL before dereferencing.
Or else Calc would crash while loading the xls document from
gnome519788.
As an aside, this xls document appears to be corrupt. Trying to
open it in Excel (XP and 2007) causes Excel to offer to repair it,
while fails in both versions. Excel XP is somehow able to open it
with some content preserved. No such luck with Excel 2007.
Change-Id: I04616a4c926862461a2efdd99ccabe36122d6825
diff --git a/sc/source/filter/excel/xichart.cxx
b/sc/source/filter/excel/xichart.cxx
index 1aa9d45..8310deb 100644
--- a/sc/source/filter/excel/xichart.cxx
+++ b/sc/source/filter/excel/xichart.cxx
@@ -2057,7 +2057,7 @@ Reference XDataSeries
XclImpChSeries::CreateDataSeries() const
aSeriesProp.SetBoolProperty( EXC_CHPROP_VARYCOLORSBY,
rTypeInfo.meTypeCateg == EXC_CHTYPECATEG_PIE );
#endif
// #i91271# always set area formatting for every point in pie/doughnut
charts
-if( mxSeriesFmt ((bVarPointFmt mxSeriesFmt-IsAutoArea()) ||
(rTypeInfo.meTypeCateg == EXC_CHTYPECATEG_PIE)) )
+if (mxSeriesFmt mxValueLink ((bVarPointFmt
mxSeriesFmt-IsAutoArea()) || (rTypeInfo.meTypeCateg == EXC_CHTYPECATEG_PIE)))
{
for( sal_uInt16 nPointIdx = 0, nPointCount =
mxValueLink-GetCellCount(); nPointIdx nPointCount; ++nPointIdx )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - sc/source
sc/source/filter/excel/xichart.cxx |2 +-
sc/source/filter/oox/defnamesbuffer.cxx |1 +
2 files changed, 2 insertions(+), 1 deletion(-)
New commits:
commit f204cd9b52ec7af3e0d20f5c88f09737b38b9e7d
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Jan 3 00:27:08 2013 -0500
fdo#58539: Check for mxValueLink being NULL before dereferencing.
Or else Calc would crash while loading the xls document from
gnome519788.
As an aside, this xls document appears to be corrupt. Trying to
open it in Excel (XP and 2007) causes Excel to offer to repair it,
while fails in both versions. Excel XP is somehow able to open it
with some content preserved. No such luck with Excel 2007.
Change-Id: I04616a4c926862461a2efdd99ccabe36122d6825
diff --git a/sc/source/filter/excel/xichart.cxx
b/sc/source/filter/excel/xichart.cxx
index 1aa9d45..8310deb 100644
--- a/sc/source/filter/excel/xichart.cxx
+++ b/sc/source/filter/excel/xichart.cxx
@@ -2057,7 +2057,7 @@ Reference XDataSeries
XclImpChSeries::CreateDataSeries() const
aSeriesProp.SetBoolProperty( EXC_CHPROP_VARYCOLORSBY,
rTypeInfo.meTypeCateg == EXC_CHTYPECATEG_PIE );
#endif
// #i91271# always set area formatting for every point in pie/doughnut
charts
-if( mxSeriesFmt ((bVarPointFmt mxSeriesFmt-IsAutoArea()) ||
(rTypeInfo.meTypeCateg == EXC_CHTYPECATEG_PIE)) )
+if (mxSeriesFmt mxValueLink ((bVarPointFmt
mxSeriesFmt-IsAutoArea()) || (rTypeInfo.meTypeCateg == EXC_CHTYPECATEG_PIE)))
{
for( sal_uInt16 nPointIdx = 0, nPointCount =
mxValueLink-GetCellCount(); nPointIdx nPointCount; ++nPointIdx )
{
commit eee87edf551f7a9f8c4da4267e5710edafd1725d
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Wed Jan 2 23:56:43 2013 -0500
fdo#58539: Properly initialize a member pointer value.
Or else it would crash when loading the doc from fdo#55174.
Change-Id: I21eb77f97dcab467c185dacaf9f00753bb4fc18c
diff --git a/sc/source/filter/oox/defnamesbuffer.cxx
b/sc/source/filter/oox/defnamesbuffer.cxx
index d735ac4..488b7e3 100644
--- a/sc/source/filter/oox/defnamesbuffer.cxx
+++ b/sc/source/filter/oox/defnamesbuffer.cxx
@@ -285,6 +285,7 @@ ApiTokenSequence DefinedNameBase::importBiffFormula(
sal_Int16 nBaseSheet, BiffI
DefinedName::DefinedName( const WorkbookHelper rHelper ) :
DefinedNameBase( rHelper ),
+mpScRangeData(NULL),
mnTokenIndex( -1 ),
mcBuiltinId( BIFF_DEFNAME_UNKNOWN ),
mnFmlaSize( 0 )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Wrong platform check for Xinerama support
On Wed, Jan 02, 2013 at 01:50:33PM +0100, Francois Tigeot wrote: configure.in / configure.ac also contains some fishy platform checks in the Xinerama support check: ... elif test $_os = Linux -o $_os = FreeBSD; then if test $x_libraries = default_x_libraries; then XINERAMALIB=`$PKG_CONFIG --variable=libdir xinerama` ... I'm not too sure of why this line was added but Linux and FreeBSD are not the only operating systems which can use Xorg. We should probably have a generic test for traditional Unix-like with X11, which is probably the intended meaning of many Linux or Linux or FreeBSD tests. Also in reference to your previous thread (graphite was reserved for Linux and Windows NT). Something like this early in configure.ac: if test $_os = Linux -o $_os = FreeBSD -o $_os = MirBSD -o $_os = OpenBSD #etc, etc; UNIX_X11=true || POSIX_OS=true fi and then test UNIX_X11 (or POSIX_OS). So when we add support for yet-another of these Unix/POSIX/SuSvN variants, there is not that much to change. As gravy, this way, if someone for whatever reason ever wants to compile e.g. for MacOS X using the X11 server (instead of native Aqua / Carbon / I lost track), they can set UNIX_X11 and have a good start :) -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Wrong platform check for Xinerama support
if test $_os = Linux -o $_os = FreeBSD -o $_os = MirBSD -o $_os = OpenBSD #etc, etc; UNIX_X11=true || POSIX_OS=true fi and then test UNIX_X11 (or POSIX_OS). I doubt we need any separate flag for POSIXness, because basically anything that isn't Windows is POSIX, surely. Actually, POSIX or not is a bit too wide a test; after all the non-desktop OSes (iOS and Android) have most of the normal POSIX system calls, but one sure is not supposed/allowed to for instance fork() in an app on them. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Wrong platform check for Xinerama support
On Thu, Jan 03, 2013 at 09:12:12AM +0200, Tor Lillqvist wrote: if test $_os = Linux -o $_os = FreeBSD -o $_os = MirBSD -o $_os = OpenBSD #etc, etc; UNIX_X11=true || POSIX_OS=true fi and then test UNIX_X11 (or POSIX_OS). I doubt we need any separate flag for POSIXness, because basically anything that isn't Windows is POSIX, surely. And even Windows NT has a POSIX layer... OK, then POSIX_OS is not the right name choice for what I want this variable to mean. UNIX_X11 is maybe the better name. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Wrong platform check for Xinerama support
The XINE check from here: http://xine.cvs.sourceforge.net/viewvc/xine/xine-ui/configure.ac?revision=1.134view=markup looks like this: dnl dnl Checks for Xinerama extension dnl AC_ARG_ENABLE([xinerama], AS_HELP_STRING([--disable-xinerama], [Don't build support for xinerama (default: check)])) if test x$enable_xinerama != xno; then PKG_CHECK_MODULES([XINERAMA], [xinerama], [ac_have_xinerama=yes], [ AC_CHECK_LIB(Xinerama, XineramaQueryExtension, XINERAMA_LIBS=-lXinerama ac_have_xinerama=yes,, $X_LIBS $X_PRE_LIBS -lXext $X_EXTRA_LIBS) ]) if test x$ac_have_xinerama = xyes; then X_PRE_LIBS=$X_PRE_LIBS $XINERAMA_LIBS AC_DEFINE(HAVE_XINERAMA,,[Define this if you have libXinerama installed]) fi fi AM_CONDITIONAL(HAVE_XINERAMA, test x$ac_have_xinerama = xyes) Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Wrong platform check for Xinerama support
And even Windows NT has a POSIX layer... You mean subsystem. (It's not as if there was a POSIX layer hiding below the Win32 layer or something.) Nowadays it is called the Subsystem for Unix applications (SUA), but LibreOffice has nothing to do with that, and can't have. SUA can be completely ignored here. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 40907] FILEOPEN - concurrent access to AFP shared files impossible - total lock on file
https://bugs.freedesktop.org/show_bug.cgi?id=40907 --- Comment #13 from fabien.mic...@hespul.org --- For information, we have paid someone to work on this issue. We hope it will be resolved soon. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58085] =Wert! after 2242 rows
https://bugs.freedesktop.org/show_bug.cgi?id=58085
Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:
What|Removed |Added
Status|NEW |NEEDINFO
Severity|trivial |normal
Priority|highest |medium
CC||LibreOffice@bielefeldundbus
||s.de
Component|Libreoffice |Spreadsheet
--- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
A trivial problem with highest importance? Strange!
NOT [Reproducible] with parallel installation of LOdev 4.0.0.0.alpha1 -
ENGLISH UI / German Locale [Build ID: dec8fe)] {tinderbox: @6, pull time
2012-11-13 06:07:28} on German WIN7 Home Premium (64bit) with separate /4 User
Profile for Master Branch
@reporter:
Thank you for your report – unfortunately important information is missing.
May be hints on http://wiki.documentfoundation.org/BugReport will help you to
find out what information will be useful to reproduce your problem? If you
believe that that is really sophisticated please as for Help on a user mailing
list
Please:
- Write a meaningful Summary describing exactly what the problem is
Really =Wert!? Not #Wert!?
- Attach a sample document (not only screenshot) or refer to an existing
sample document in an other Bug with a link; to attach a file to this
bug report, just click on Add an attachment right on this page.
- Attach screenshots with comments if you believe that that might explain the
problem better than a text comment. Best way is to insert your screenshots
into a DRAW document and to add comments that explain what you want to show
(attachment 68877, attachment 68490)
- Contribute a document related step by step instruction containing every
key press and every mouse click how to reproduce your problem
(similar to example in Bug 43431)
– if possible contribute an instruction how to create a sample document
from the scratch
- add information
-- what EXACTLY is unexpected
-- and WHY do you believe it's unexpected (cite Help or Documentation!)
-- concerning your PC
-- concerning your OS (Version, Distribution, Language)
-- concerning your LibO localization (UI language, Locale setting)
–- Libo settings that might be related to your problems
-- how you launch LibO and how you opened the sample document
–- Whether your problem persists when you renamed your user profile
before you launch LibO (please see
https://wiki.documentfoundation.org/UserProfile#User_profile_location)
-- everything else crossing your mind after you read linked texts
Even if you can not provide all demanded information, every little new
information might bring the breakthrough.
May be you want to test https://www.libreoffice.org/get-help/bug/ for
submitting bug reports? You reach that Bug Submission Assistant via LibO menu
'Help - Feedback / Bug Report'. The assistant will collect and insert such
information automatically.
Please submit Bug reports with status UNCONFIRMED if your are not absolutely
sure that you contributed all required background information, that the problem
will be reproducible with information you can provide or that your enhancement
request will be accepted! Thank you!
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54165] Unable to localize key names
https://bugs.freedesktop.org/show_bug.cgi?id=54165 --- Comment #6 from jmontane j...@montane.cat --- Created attachment 72375 -- https://bugs.freedesktop.org/attachment.cgi?id=72375action=edit Screenshots of several programs Screenshots showing shortcut names, using Catalan UI in all programs but with and Spanish keyboard. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54165] Unable to localize key names
https://bugs.freedesktop.org/show_bug.cgi?id=54165 --- Comment #7 from jmontane j...@montane.cat --- I've done some searching, Adobe Reader, Chrome, Firefox, MS Office, Thunderbird and Windows Live localize key name according language UI of program. 7-zip, IE Explorer, PDFCreator, SumatraPDF and WinRAR shows key name in English, *not* as provided by keyboard layout LibreOffice, OpenOffice and Keyboard (embedded program of Windows) shows key names as provides by keyboard layout. More on, according to bug 50415, in Linux LibO the key names are showed by language UI, why doing diffent in Windows LibO? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58939] New: FORMATTING: Working with vertical text [Writer, Calc]
https://bugs.freedesktop.org/show_bug.cgi?id=58939 Priority: medium Bug ID: 58939 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FORMATTING: Working with vertical text [Writer, Calc] Severity: normal Classification: Unclassified OS: All Reporter: minnigalie...@yandex.ru Hardware: All Status: UNCONFIRMED Version: unspecified Component: Spreadsheet Product: LibreOffice Once again trying to work with vertical text in a Calc document and the tables Writer decided to ask other people from the Russian community of Ubuntu, what they think on this issue. Convinced that no one I work LO vertical text seems uncomfortable and not completed. Some points that require further development: 1. Vertical text direction should set the same way in Calc and Writer. 2. The transition to a new line in a given direction should be carried out according to Enter. 3. Should remove the horizontal cursor with the height of the length of the vertical text, when you put it in the beginning of the line of vertical text. 4. Should do understandable navigation cursors in vertical text. Dear developers, just try to work with vertical text in Calc and Writer and you will see many small troubles that make a difficult to work with office! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40907] FILEOPEN - concurrent access to AFP shared files impossible - total lock on file
https://bugs.freedesktop.org/show_bug.cgi?id=40907 --- Comment #14 from Roman Eisele b...@eikota.de --- (In reply to comment #13) For information, we have paid someone to work on this issue. We hope it will be resolved soon. Thank you very much! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58888] EDITING: Copying and Inserting Lines
https://bugs.freedesktop.org/show_bug.cgi?id=5 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||LibreOffice@bielefeldundbus ||s.de Summary|EDITING: Verb Bad Usability |EDITING: Copying and |Problem - Copying and |Inserting Lines |Inserting Lines | Ever confirmed|0 |1 --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Not a valid bug report, I have no idea what reporter thinks what a typical lline item is and what reporter's problem might be. @reporter: Thank you for your report – unfortunately important information is missing. May be hints on http://wiki.documentfoundation.org/BugReport will help you to find out what information will be useful to reproduce your problem? If you believe that that is really sophisticated please as for Help on a user mailing list Please: - Write a meaningful Summary describing exactly what the problem is - Attach a sample document (not only screenshot) or refer to an existing sample document in an other Bug with a link; to attach a file to this bug report, just click on Add an attachment right on this page. - Attach screenshots with comments if you believe that that might explain the problem better than a text comment. Best way is to insert your screenshots into a DRAW document and to add comments that explain what you want to show (attachment 68877, attachment 68490) - Contribute a document related step by step instruction containing every key press and every mouse click how to reproduce your problem (similar to example in Bug 43431) – if possible contribute an instruction how to create a sample document from the scratch - add information -- what EXACTLY is unexpected -- and WHY do you believe it's unexpected (cite Help or Documentation!) -- concerning your PC -- concerning your OS (Version, Distribution, Language) -- concerning your localization (UI language, Locale setting) –- Libo settings that might be related to your problems -- how you launch LibO and how you opened the sample document –- Whether your problem persists when you renamed your user profile before you launch LibO (please see https://wiki.documentfoundation.org/UserProfile#User_profile_location) –- If you can contribute an AOOo Issue that might be useful -- everything else crossing your mind after you read linked texts Even if you can not provide all demanded information, every little new information might bring the breakthrough. May be you want to test https://www.libreoffice.org/get-help/bug/ for submitting bug reports? You reach that Bug Submission Assistant via LibO menu 'Help - Feedback / Bug Report'. The assistant will collect and insert such information automatically. May be you can test http://wiki.documentfoundation.org/BugReport_Details for submitting bug reports? Please submit Bug reports with status UNCONFIRMED if your are not absolutely sure that you contributed all required background information, that the problem will be reproducible with information you can provide or that your enhancement request will be accepted! Thank you! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56963] FILEOPEN, EDITING: Stability degrades with large document
https://bugs.freedesktop.org/show_bug.cgi?id=56963 --- Comment #12 from David genericinet+libreoffice@gmail.com --- Have you tried version 3.4.6 with the display options off? I haven't actually tried seeing what happens in later versions with my document and this error because of another bug which is preventing me from upgrading. Another thing I've found that worked until I closed the document and re-opened it was to create a new document and insert the old one using the File command from the insert menu. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58889] EDITING: Inputting Data ???
https://bugs.freedesktop.org/show_bug.cgi?id=58889 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Severity|normal |enhancement CC||LibreOffice@bielefeldundbus ||s.de Summary|EDITING: Usability Problem |EDITING: Inputting Data ??? |- Inputting Data| Ever confirmed|0 |1 --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- I can't imagine what the problem might be. @Kim: please follow my advice in Bug 5 ! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50928] EDITING: Copying and Inserting Lines - needs redesigning
https://bugs.freedesktop.org/show_bug.cgi?id=50928 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|NEW |NEEDINFO CC||LibreOffice@bielefeldundbus ||s.de --- Comment #5 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- I can't imagine what the problem might be. BTW, If I want to proceed reporter's example in comment 4, I 1. Click row heading 1 to select first row 2. control+c 3. Click row heading 2 to select second row 4. shift + click on row heading 42 5. Click 'Insert row' Icon 6. control+v for paste all new lines are filled That's simple, and there exist many alternatives (record a macro, ...) Currently I can't see any urgency for a redesign. @Kim: please follow my advice in Bug 5! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58750] FORMATTING: Crash when Format Columns
https://bugs.freedesktop.org/show_bug.cgi?id=58750 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it --- Comment #3 from tommy27 ba...@quipo.it --- NOT reproducible on Windows Vista 64bit using: Version 4.0.0.0.beta2+ (Build ID: 350ae8294a8df78403fd8cdce56b9aeb8178e13) @manj_k do you still reproduce it with current LibO 4.0 beta2? if not we shall close this bug report -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58750] FORMATTING: Crash when Format Columns
https://bugs.freedesktop.org/show_bug.cgi?id=58750 --- Comment #4 from tommy27 ba...@quipo.it --- oooppsss... sorry... did not notice that the bug refers to master (future 4.1) however my test shows that the bug is not present in the 4.0 branch -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50929] BUGZILLAASSISTANT: You Need a Sign Off button
https://bugs.freedesktop.org/show_bug.cgi?id=50929 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE CC||LibreOffice@bielefeldundbus ||s.de Summary|: You Need a My Bugs button |BUGZILLAASSISTANT: You Need |and a Sign Off button |a Sign Off button --- Comment #7 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- I think the Sign off button request is a DUP of Bug 41627 - BUGZILLAASSISTANT: No possibility to log out. I reduce this bug to that problem My Bugs can be found easily on the Bugzilla page you can reach after you reported a bug. The BSA is mainly for newcomers who do not have (many) My bugs, so currently I can't see evidence for that request. @Kim: Only one issue per report! http://wiki.documentfoundation.org/BugReport#General_information item 4 Your reports are much too imprecise, please follow my advice in Bug 5! Please feel free to submit a new report for the My Bugs request if you can contribute evidence why the link in Bugzilla is not sufficient. *** This bug has been marked as a duplicate of bug 41627 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41627] BUGZILLAASSISTANT: No possibility to log out
https://bugs.freedesktop.org/show_bug.cgi?id=41627 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||libreoffic...@wrldcomp.com --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- *** Bug 50929 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50932] EDITING: Double Thickness Cell Borders are Not Displayed
https://bugs.freedesktop.org/show_bug.cgi?id=50932 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Resolution|FIXED |WORKSFORME CC||LibreOffice@bielefeldundbus ||s.de --- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- @Kim: Please contribute precise info, but do not touch the status picker. With what version did you see the improvement? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50933] EDITING: Zooming Happening Automatically
https://bugs.freedesktop.org/show_bug.cgi?id=50933 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME CC||LibreOffice@bielefeldundbus ||s.de --- Comment #4 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- @Kim: I am pretty sure that you accidently did a mouse zoom. I also have this problem from time to time using a Laptop with touch pad. Please feel free to reopen this bug if you find evidence that we have a real LibO bug here. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57626] Macro assigned to print event does not execute
https://bugs.freedesktop.org/show_bug.cgi?id=57626 LeMoyne Castle lemoyne.cas...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from LeMoyne Castle lemoyne.cas...@gmail.com --- Dup of Bug 58269 which has patch merged to master that reinstates Print event registration code. *** This bug has been marked as a duplicate of bug 58269 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58816] Macros: basic script / module error
https://bugs.freedesktop.org/show_bug.cgi?id=58816 LeMoyne Castle lemoyne.cas...@gmail.com changed: What|Removed |Added See Also|https://bugs.freedesktop.or | |g/show_bug.cgi?id=58269 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58541] BASIC: BASIC runtime error '423' OnSheetActivate
https://bugs.freedesktop.org/show_bug.cgi?id=58541 LeMoyne Castle lemoyne.cas...@gmail.com changed: What|Removed |Added See Also|https://bugs.freedesktop.or | |g/show_bug.cgi?id=58269 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58750] FORMATTING: Crash when Format Columns
https://bugs.freedesktop.org/show_bug.cgi?id=58750 --- Comment #5 from manj_k courrier.oou.fr@googlemail.com --- (In reply to comment #4) [...] however my test shows that the bug is not present in the 4.0 branch Yes, I know. ;) Please, could you test it with the current master build? My latest test: Reproducible (on WinXP 32b) with LibO-Dev_4.1.0.0.alpha0+ tinderbox: Win-x86@6 MASTER pull time 2012-12-31 19:23:06 core:dd9655868e60af0f67de715f1f04aa0989b6b58b The bug occurred for the first time on 2012-12-21, worked well with master build 2012-12-20 (see Description). [ See also: bug 58749 · bug 58751 · bug 58752 · bug 58760 ] -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58913] Crash when creating a form with Wizard - Linux JRE 7
https://bugs.freedesktop.org/show_bug.cgi?id=58913 --- Comment #7 from rob...@familiegrosskopf.de --- (In reply to comment #6) Created attachment 72367 [details] bt + console logs on master Hello Julien, I couldn't see anything about JRE. Which Java-version do you use? I can't confirm any crash with the form wizard, LO 4.0.0.0.beta2+ (28.12.2012) on a Linux-rpm-32bit-system. LO works right with Java 1.6.0_29. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58940] New: CONFIGURATION: Can not change paths used by LibreOffice
https://bugs.freedesktop.org/show_bug.cgi?id=58940 Priority: medium Bug ID: 58940 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: CONFIGURATION: Can not change paths used by LibreOffice Severity: normal Classification: Unclassified OS: Linux (All) Reporter: brucey...@live.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 3.6.4.3 release Component: Writer Product: LibreOffice Problem description: Can not change the paths used by LO in Linux Mint 14 Steps to reproduce: 1. Tools Options 2. LibreOffice Paths 3. Select 'My Documents' Edit 4. Select new folder, OK Current behavior: Path reverts to /home/username/ Expected behavior: New path should save Operating System: Linux (Other) Version: 3.6.4.3 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58921] FORMATTING: New cells conditional format missing after save and load file
https://bugs.freedesktop.org/show_bug.cgi?id=58921 Francisco Lloret fcollo...@terra.es changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58921] FORMATTING: New cells conditional format missing after save and load file
https://bugs.freedesktop.org/show_bug.cgi?id=58921 --- Comment #1 from Francisco Lloret fcollo...@terra.es --- 3.5.5.3 version works OK. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58417] Libreoffice 4.0 crashes in LanguageTag constructor at start on Ubuntu 12.10 64bit
https://bugs.freedesktop.org/show_bug.cgi?id=58417 --- Comment #12 from LeMoyne Castle lemoyne.cas...@gmail.com --- I submitted the min fix patch to fix a compile error I was having on Ubu 10.04 with gcc-4.4.3 Compile time type resolution was failing inside a complex nested constructor call. It is possible that the errors here are from a similar compiler problem that doesn't error out at compile time, but writes junk and errors at run-time. A bit of a shot in the dark, but the BTs here go right through at least one of the patched lines. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58941] New: Support optional smartfont features
https://bugs.freedesktop.org/show_bug.cgi?id=58941 Priority: medium Bug ID: 58941 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Support optional smartfont features Severity: enhancement Classification: Unclassified OS: All Reporter: g.duff...@gmail.com Hardware: All Status: UNCONFIRMED Version: 4.0.0.0.beta2 Component: UI Product: LibreOffice LO should provide an interface to enable optional smartfont features like liga, sups etc. and also to disable optional features that are enabled by default like calt etc. Ideally this interface covers all three smartfont technologies (Opentype, Graphite and AAT). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
