date:20140507

LibreOffice Gerrit News for submodules on 2014-05-07

2014-05-07 Thread gerrit

Moin!



~~ Project dictionaries ~~

Nothing moved in the project for the last 25 hours

~~ Project translations ~~

Nothing moved in the project for the last 25 hours

~~ Project help ~~

* Open changes on master for project help changed in the last 25 hours:

None

* Merged changes on master for project help changed in the last 25 hours:

+ add comments in margins option to PDF export
  in https://gerrit.libreoffice.org/9243 from Stanislav Horáček
+ fdo#70998 change terms graphics/picture to image
  in https://gerrit.libreoffice.org/9244 from Stanislav Horáček


* Abandoned changes on master for project help changed in the last 25 hours:

None

* Open changes needing tweaks, but being untouched for more than a week:

None

Best,

Your friendly LibreOffice Gerrit Digest Mailer

Note: The bot generating this message can be found and improved here:
   
https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

LibreOffice Gerrit News for core on 2014-05-07

2014-05-07 Thread gerrit

Moin!

* Open changes on master for project core changed in the last 25 hours:

+ Translate German comments, fix some ws
  in https://gerrit.libreoffice.org/9263 from Philipp Weissenbacher
  about module sc
+ fdo#43157 [API CHANGE] Remove OSL_POSTCOND, prefer SAL_WARN_IF
  in https://gerrit.libreoffice.org/8883 from Michaël Lefèvre
  about module basic, dbaccess, fpicker, include, sal, shell, store
+ move INetContentTypes::scan() to INetURLObject::scanContentType()
  in https://gerrit.libreoffice.org/9212 from Christina Roßmanith
  about module include, svl, tools


* Merged changes on master for project core changed in the last 25 hours:

+ fdo#77739 UI trendline: limit max values of Degree and Period
  in https://gerrit.libreoffice.org/9116 from Laurent BP
+ fdo#78241 PDF Import: add dashes support
  in https://gerrit.libreoffice.org/9246 from Vort
+ Avoid the annoying line wrapping
  in https://gerrit.libreoffice.org/9258 from Tor Lillqvist
+ fdo#77887 :  Floating Table positions are not preserved when doing Export
  in https://gerrit.libreoffice.org/9185 from Ravindra Vidhate


* Abandoned changes on master for project core changed in the last 25 hours:

None

* Open changes needing tweaks, but being untouched for more than a week:

+ external: revert java 1.6 stuff (at least until we'd get a real check in 
  in https://gerrit.libreoffice.org/8801 from Douglas Mencken
+ cppunittest_filter_xslt: fix fdo#77893
  in https://gerrit.libreoffice.org/9177 from Douglas Mencken
+ DrawWaveLine/ImplDrawWaveLine fixes:   - try to avoid huge looping due to
  in https://gerrit.libreoffice.org/9174 from Douglas Mencken
+ FDO#74886: Data labels are not preserved for Column Chart in RT file
  in https://gerrit.libreoffice.org/8098 from Umesh Kadam
+ move inettype.{hc}xx from svl to tools
  in https://gerrit.libreoffice.org/8926 from Christina Roßmanith
+ new method INetURLObject::getData() for data urls
  in https://gerrit.libreoffice.org/8737 from Christina Roßmanith
+ fdo#67544 Slide transistion sound(other sound) is not included in present
  in https://gerrit.libreoffice.org/8700 from Vishv Brahmbhatt
+ fdo#57950: Replace chained O(U)StringBuffer::append() with operator+
  in https://gerrit.libreoffice.org/8699 from Tharindu Lakmal
+ Refactored
  in https://gerrit.libreoffice.org/8683 from Tharindu Lakmal
+ fdo#75757 Remove inheritance to std::map from PropertyMap
  in https://gerrit.libreoffice.org/8656 from Krisztian Pinter
+ Remove visual noise from ios
  in https://gerrit.libreoffice.org/8274 from Alexander Wilms
+ FDO#75205 : Charts - Up Down bars are getting added to Line Chart.
  in https://gerrit.libreoffice.org/8360 from Umesh Kadam
+ WIP: Converting ExtensionUpdate dialog for new format
  in https://gerrit.libreoffice.org/8506 from Rodolfo Ribeiro Gomes
+ Refactored swooxmlexport tests cases. Added function to check contents.
  in https://gerrit.libreoffice.org/8390 from Nikhil Walvekar
+ fdo#71984 fix first line indentation in footnotes for MS Word documents
  in https://gerrit.libreoffice.org/8160 from Andras Timar
+ Lots of changes to Tango icons
  in https://gerrit.libreoffice.org/7987 from Miroslav Mazel
+ sw/docx export: fix handling of document with header and section(s)
  in https://gerrit.libreoffice.org/6248 from Pierre-Eric Pelloux-Prayer
+ fdo#51525 Fix duplicate Paste Special entries in Calc.
  in https://gerrit.libreoffice.org/7784 from Andrzej Hunt
+ fdo#72661: Check ‘Hyphenation active’ automatically
  in https://gerrit.libreoffice.org/7291 from Jiwoong Youn
+ WIP fdo#72987 Use firebird backup format for .odb
  in https://gerrit.libreoffice.org/7299 from Andrzej Hunt
+ WIP: fdo#33980 Preserve selection across all slide sorters.
  in https://gerrit.libreoffice.org/6633 from Andrzej Hunt


Best,

Your friendly LibreOffice Gerrit Digest Mailer

Note: The bot generating this message can be found and improved here:
   
https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [patch] [solved] build failure

2014-05-07 Thread David Tardon

Hi,

On Tue, May 06, 2014 at 03:35:32AM -0700, julien2412 wrote:
 Sorry Terrence, my fault here :-(
 Thanks to Kohei, I could fix these at the beginning of the morning (UTC+2)
 
 It could be useful to force building in C++98 or at least put an option in
 autogen.input.

You do not need an option for that. All you need is to add

CXX=g++ -std=c++98

to autogen.input. Or run

export CXX='g++ -std=c++98'

before ./autogen.sh .

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: chart2/source

2014-05-07 Thread Tomaž Vajngerl

 chart2/source/controller/dialogs/dlg_ObjectProperties.cxx |2 
 chart2/source/inc/RegressionCalculationHelper.hxx |  123 ++
 chart2/source/tools/RegressionCalculationHelper.hxx   |  123 --
 3 files changed, 124 insertions(+), 124 deletions(-)

New commits:
commit 65f127f687916c8166d483a2769d2c344b0314e6
Author: TomaÅ¾ Vajngerl tomaz.vajng...@collabora.com
Date:   Wed May 7 09:28:01 2014 +0200

chart2: move RegressionCalculationHelper.hxx to inc

Change-Id: Ie49a9e20f72c8e2f81b2d169f5fd19964811c193

diff --git a/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx 
b/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
index 9e707cb..b279f05 100644
--- a/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
+++ b/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
@@ -46,7 +46,7 @@
 #include ExplicitCategoriesProvider.hxx
 #include ChartModel.hxx
 #include CommonConverters.hxx
-#include ../../tools/RegressionCalculationHelper.hxx
+#include RegressionCalculationHelper.hxx
 
 #include com/sun/star/chart2/XAxis.hpp
 #include com/sun/star/chart2/XChartType.hpp
diff --git a/chart2/source/tools/RegressionCalculationHelper.hxx 
b/chart2/source/inc/RegressionCalculationHelper.hxx
similarity index 100%
rename from chart2/source/tools/RegressionCalculationHelper.hxx
rename to chart2/source/inc/RegressionCalculationHelper.hxx
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa sw/source

2014-05-07 Thread Pallavi Jadhav

 sw/qa/extras/ooxmlexport/data/fdo77812.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport.cxx|   17 +
 sw/source/filter/ww8/wrtww8.cxx |   15 +++
 3 files changed, 32 insertions(+)

New commits:
commit f6eb92406bd366c557bc07810649e7ab3d1db614
Author: Pallavi Jadhav pallavi.jad...@synerzip.com
Date:   Tue Apr 29 18:44:16 2014 +0530

fdo#77812 :FILESAVE :DOCX : Extra Section Break gets added in file

Issue :
LO was exporting DOCX containing MultiColumns with additional
Section break Continuos.

Implementation :
1] Added check for Column_count in MSWordExportBase::WriteText()
   If Column_count  1 and Text node is empty then do not
   export Section Break.
2] Written Export unit test case.

Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
https://gerrit.libreoffice.org/9200

Change-Id: Ibf3e6bd2d4827aa77a659b1600939cc56d65a63b

diff --git a/sw/qa/extras/ooxmlexport/data/fdo77812.docx 
b/sw/qa/extras/ooxmlexport/data/fdo77812.docx
new file mode 100644
index 000..48fb498
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/fdo77812.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index 8c99382..acd3d06 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -3215,7 +3215,24 @@ DECLARE_OOXMLEXPORT_TEST(testFDO77725, fdo77725.docx)
 assertXPath(pXmlFootnotes, 
//w:footnotes[1]/w:footnote[3]/w:p[3]/w:r[1]/w:br[1], 0);
 assertXPath(pXmlFootnotes, 
//w:footnotes[1]/w:footnote[3]/w:p[3]/w:r[1]/w:br[2], 0);
 assertXPath(pXmlFootnotes, 
//w:footnotes[1]/w:footnote[3]/w:p[3]/w:r[1]/w:br[3], 0);
+}
+
+DECLARE_OOXMLEXPORT_TEST(testFDO77812, fdo77812.docx)
+{
+/* Additional sectPr was getting inserted and hence Column properties
+ * were getting added into this additional sectPr instead of Default setPr.
+ */
+xmlDocPtr pXmlDoc = parseExport(word/document.xml);
+if (!pXmlDoc)
+return;
+
+// Check no additional section break is inserted.
+assertXPath(pXmlDoc, /w:document/w:body/w:p[6]/w:pPr/w:sectPr, 0);
 
+// Check w:cols comes under Default sectPr
+assertXPath(pXmlDoc, /w:document/w:body/w:sectPr/w:cols, num, 2);
+assertXPath(pXmlDoc, /w:document/w:body/w:sectPr/w:cols/w:col[1], 1);
+assertXPath(pXmlDoc, /w:document/w:body/w:sectPr/w:cols/w:col[2], 1);
 }
 
 DECLARE_OOXMLEXPORT_TEST(testContentTypeOLE, fdo77759.docx)
diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index 718761a..916d33f 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -114,6 +114,7 @@
 #include editeng/charrotateitem.hxx
 #include WW8FibData.hxx
 #include numrule.hxx
+#include fmtclds.hxx
 
 using namespace css;
 using namespace sw::util;
@@ -2597,6 +2598,20 @@ void MSWordExportBase::WriteText()
 }
 }
 }
+else
+{
+/* Do not export Section Break in case DOCX containing 
MultiColumn and
+ * aIdx.GetNode().IsTxtNode() is False i.e. Text node is 
NULL.
+ */
+const SwFrmFmt* pPgFmt = rSect.GetFmt();
+const SwFmtCol rCol = pPgFmt-GetCol();
+sal_uInt16 nColumnCount = rCol.GetNumCols();
+if(nColumnCount  1)
+{
+bNeedExportBreakHere = sal_False;
+}
+}
+
 if (bNeedExportBreakHere)  //#120140# End of check
 {
 ReplaceCr( (char)0xc ); // indicator for Page/Section-Break
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/source

2014-05-07 Thread Thomas Arnhold

 sc/inc/drawattr.hxx|8 -
 sc/source/ui/view/drawattr.cxx |   61 -
 sc/source/ui/view/tabvwsh.cxx  |1 
 3 files changed, 70 deletions(-)

New commits:
commit a7a2fa9303c226aef409ac032272908c6c08e4ee
Author: Thomas Arnhold tho...@arnhold.org
Date:   Wed May 7 09:51:58 2014 +0200

remove uncompiled source files

Maybe this can be completely replaced by SfxEnumItem

Change-Id: I049dcd3e5a03f859f8b1dddad801db4ca772ef6a

diff --git a/sc/inc/drawattr.hxx b/sc/inc/drawattr.hxx
index 8f9237f..a908277 100644
--- a/sc/inc/drawattr.hxx
+++ b/sc/inc/drawattr.hxx
@@ -33,17 +33,9 @@ public:
 SvxDrawToolItem(sal_uInt16 nWhichP) : SfxEnumItem(nWhichP){}
 
 
-virtual OUStringGetValueText() const;
-
-
-virtual OUStringGetValueText(sal_uInt16 nVal) const;
 virtual sal_uInt16  GetValueCount() const SAL_OVERRIDE
 {return((sal_uInt16)SVX_SNAP_DRAW_TEXT);}
 
-virtual SfxPoolItem*Clone( SfxItemPool *pPool = 0 ) const 
SAL_OVERRIDE;
-
-virtual SfxPoolItem*Create( SvStream rStream, sal_uInt16 nVer ) 
const SAL_OVERRIDE;
-
 inline SvxDrawToolItem operator=(const  SvxDrawToolItem
 rDrawTool)
 {
diff --git a/sc/source/ui/view/drawattr.cxx b/sc/source/ui/view/drawattr.cxx
deleted file mode 100644
index 653b1b8..000
--- a/sc/source/ui/view/drawattr.cxx
+++ /dev/null
@@ -1,61 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the License); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#include drawattr.hxx
-#include global.hxx
-
-OUString SvxDrawToolItem::GetValueText() const
-{
-return GetValueText(GetValue());
-}
-
-OUString SvxDrawToolItem::GetValueText( sal_uInt16 nVal ) const
-{
-const sal_Char* p;
-
-switch (nVal)
-{
-case 0  : p = SVX_SNAP_DRAW_SELECT; break;
-
-case 1  : p = SVX_SNAP_DRAW_LINE  ; break;
-case 2  : p = SVX_SNAP_DRAW_RECT  ; break;
-case 3  : p = SVX_SNAP_DRAW_ELLIPSE   ; break;
-case 4  : p = SVX_SNAP_DRAW_POLYGON   ; break;
-case 5  : p = SVX_SNAP_DRAW_ARC   ; break;
-case 6  : p = SVX_SNAP_DRAW_PIE   ; break;
-case 7  : p = SVX_SNAP_DRAW_CIRCLECUT ; break;
-case 8  : p = SVX_SNAP_DRAW_TEXT  ; break;
-default : return EMPTY_OUSTRING;
-}
-return OUString::createFromAscii( p );
-}
-
-SfxPoolItem* SvxDrawToolItem::Clone( SfxItemPool * ) const
-{
-return new SvxDrawToolItem(*this);
-}
-
-SfxPoolItem* SvxDrawToolItem::Create( SvStream rStream, sal_uInt16 nVer ) 
const
-{
-sal_uInt16 nVal;
-rStream  nVal;
-return new SvxDrawToolItem(nVal);
-}
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/view/tabvwsh.cxx b/sc/source/ui/view/tabvwsh.cxx
index 7dc93c8..42baf8d 100644
--- a/sc/source/ui/view/tabvwsh.cxx
+++ b/sc/source/ui/view/tabvwsh.cxx
@@ -38,7 +38,6 @@
 #include scresid.hxx
 #include dwfunctr.hxx
 #include sc.hrc
-#include drawattr.hxx
 #include spelldialog.hxx
 
 #define ScTabViewShell
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: fdo#63315: sign windows binaries during build

2014-05-07 Thread David Tardon

Hi,

On Tue, May 06, 2014 at 02:24:15PM +0200, Christian Lohmaier wrote:
Hi *,

On Tue, May 6, 2014 at 11:23 AM, Andras Timar tima...@gmail.com wrote:
Hi,

On Tue, May 6, 2014 at 1:56 AM, Mathias MICHEL
mathias-mic...@laposte.net wrote:

See https://bugs.freedesktop.org/show_bug.cgi?id=63315
From the Cloph's comment it seems the issue is fixed but with room for
improvement.

The room for improvement is in the general build, not specific to
signing (i.e. copying files individually instead of using for example
tar, or at least copy with multiple files at once/recursive copy,
touching lots and lots of files,...) calling cp x times (creating a
process that often), instead of once for x files is slow as hell on
windows/cygwin.

I would strongly object to any change that improves performance of the
release builds at the expense of incremental builds, e.g., by dropping
precise dependencies in order to copy more files at once. I really do
not want to go back to the world of compatible vs. incompatible
builds...

LO's patched version of make did make some touch and cp builtin
functionality, but since gbuildification those rules don't match the
majority of cases.

I do not really understand that... Does that mean there is something
that actively prevents make to use the builtin functions?

Should we close it or not ?

I'm interested in stability in this area and the current functionality
is good enough for me, so I'd say let's close it.

Yes, close it.

Signing needs exclusive lock on the file, so signing will fail when
the file is opened by another process - so this is another problem
that would likely occur if the signing was done after each creation.

No, it would not. It is the current state, which does the signing at
arbitrary time, that has this inherent problem. The proposal in that
easy hack is to sign every library during linking; _nothing_ can be
using the library at that point, unless there are missing dependencies.

(see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea391abb3f2eb0ffaa892f9d7437dcf33bda6440
that made singing depend on slowchecks being done, as otherwise
signing would fail)

And I strongly suspect the next stop will be gallery creation, as gengal
is internal tool which needs a zillion libraries... If we really want to
continue to use this script for signing, IMHO it should be done as a
separate step after build.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

2014-05-07 Thread Thomas Arnhold

 sw/source/ui/fldui/javaedit.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 710da5b12d52abfd96527b43f5959ae31b8e7407
Author: Thomas Arnhold tho...@arnhold.org
Date:   Wed May 7 09:42:18 2014 +0200

WaE: C4389: '!=' : signed/unsigned mismatch

Change-Id: I6a2e0992077b185107f8d7190478d95f8d898e9e
Reviewed-on: https://gerrit.libreoffice.org/9266
Reviewed-by: Stephan Bergmann sberg...@redhat.com
Tested-by: Stephan Bergmann sberg...@redhat.com

diff --git a/sw/source/ui/fldui/javaedit.cxx b/sw/source/ui/fldui/javaedit.cxx
index bbc4f00..6841271 100644
--- a/sw/source/ui/fldui/javaedit.cxx
+++ b/sw/source/ui/fldui/javaedit.cxx
@@ -219,7 +219,7 @@ void SwJavaEditDialog::SetFld()
 
 bool SwJavaEditDialog::IsUpdate() const
 {
-return pFld  ( (bIsUrl ? 1 : 0) != pFld-GetFormat() || pFld-GetPar2() 
!= aType || pFld-GetPar1() != aText );
+return pFld  ( sal_uInt32(bIsUrl ? 1 : 0) != pFld-GetFormat() || 
pFld-GetPar2() != aType || pFld-GetPar1() != aText );
 }
 
 IMPL_LINK_NOARG(SwJavaEditDialog, RadioButtonHdl)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: fdo#63315: sign windows binaries during build

2014-05-07 Thread Christian Lohmaier

Hi David, *,

On Wed, May 7, 2014 at 10:17 AM, David Tardon dtar...@redhat.com wrote:
On Tue, May 06, 2014 at 02:24:15PM +0200, Christian Lohmaier wrote:
On Tue, May 6, 2014 at 11:23 AM, Andras Timar tima...@gmail.com wrote:
On Tue, May 6, 2014 at 1:56 AM, Mathias MICHEL
mathias-mic...@laposte.net wrote:

See https://bugs.freedesktop.org/show_bug.cgi?id=63315
From the Cloph's comment it seems the issue is fixed but with room for
improvement.

I would strongly object to any change that improves performance of the
release builds at the expense of incremental builds, e.g., by dropping
precise dependencies in order to copy more files at once.

Building SDK or Helpcontent or translations is not affected by
incremental builds usually. And of course you won't lose dependencies
by copying multiple stuff at once. You might waste some time doing i/o
by shoving around files that weren't changed, but for stuff like sdk
documentation that is created by doxygen that injects timestamps into
every file (i.e. stuff is always changed) this doesn't matter from my
POV.
Same for help. Changing help means regenerating index, so everything
will be looked up anyway, so having it in the filesystem cache doesn't
hurt for linux. But copying this in one go will help the build on
linux.

I really do
not want to go back to the world of compatible vs. incompatible
builds...

That won't be the case. Copying more stuff at once for those will not
mess with dependendencies. It might result in more disk-activity, but
the areas where it matters most (sdk, help, translations) aren't
touched in everyday development, aren't even enabled in everyday
development builds.

LO's patched version of make did make some touch and cp builtin
functionality, but since gbuildification those rules don't match the
majority of cases.

I do not really understand that... Does that mean there is something
that actively prevents make to use the builtin functions?

No, not preventing. The code that identifies candidates that could be
handled by patched make just need adjustments to match.

https://gerrit.libreoffice.org/gitweb?p=gnu-make-lo.git;a=blob;f=runbuiltin.c;hb=refs/heads/gnu-make-lo-3.82#l454

But this is only a workaround to hide the problem with the many
processes. Removing the tons of touch calls would be real
improvement. And I don't see a reason why a stuff need to depend on a
touch-pseudo-target the created object itself.

[...]
(see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea391abb3f2eb0ffaa892f9d7437dcf33bda6440
that made singing depend on slowchecks being done, as otherwise
signing would fail)

And I strongly suspect the next stop will be gallery creation, as gengal
is internal tool which needs a zillion libraries...

Well, even if rhetorical: If that turns out to be a problem: Yes.
Still preferred over spawning zillions of processes on windows.

If we really want to
continue to use this script for signing, IMHO it should be done as a
separate step after build.

Which in effect it is. After slowcheck it is more or less separate.
Having it after the build as separate /manual step is pointless, as
then you woudn't only need to sign, but also rebuild the installsets.

And building installests on windows also is slow. So I object to
making it an after make finished thing.

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

2014-05-07 Thread Tor Lillqvist

 sw/source/filter/ww8/wrtww8.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit eac9586b22ca1cddaa80a0b040c57fbed3616420
Author: Tor Lillqvist t...@collabora.com
Date:   Wed May 7 11:52:57 2014 +0300

WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'

Change-Id: Ia02481046640248bc8a62ab0f93bf4e0bb49cca8

diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index 916d33f..bbf5af0 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -2608,7 +2608,7 @@ void MSWordExportBase::WriteText()
 sal_uInt16 nColumnCount = rCol.GetNumCols();
 if(nColumnCount  1)
 {
-bNeedExportBreakHere = sal_False;
+bNeedExportBreakHere = false;
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

1 2 3 >

1 - 100 of 251 matches

Mail list logo