date:20140726

 libreofficekit/qa/unit/tiledrendering.cxx |4 ++--
 sw/inc/viewsh.hxx |1 -
 sw/source/core/draw/dflyobj.cxx   |4 +---
 sw/source/core/view/viewsh.cxx|7 +--
 4 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit e5dd2e8826433566e223d0572ed73f21d0b992f1
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Thu Jul 24 21:38:12 2014 +0200

We're using the same rectangle for both calls, let's reuse it.

Change-Id: I884832fc92e0fe9c10711d9fdaf103076a05f721

diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index daf5304..e545651 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -1785,6 +1785,9 @@ void SwViewShell::PaintTile(VirtualDevice rDevice, int 
contextWidth, int contex
 Imp()-GetDrawView()-AddWindowToPaintView(rDevice);
 }
 
+Rectangle aOutRect = Rectangle(Point(tilePosX, tilePosY),
+   rDevice.PixelToLogic(Size(contextWidth, 
contextHeight)));
+
 // Make the requested area visible -- we can't use MakeVisible as that will
 // only scroll the contents, but won't zoom/resize if needed.
 // Without this, items/text that are outside the visible area (in the 
SwView)
@@ -1792,10 +1795,10 @@ void SwViewShell::PaintTile(VirtualDevice rDevice, int 
contextWidth, int contex
 // tiledrendering app, or the gtktiledviewer) -- although ultimately we
 // probably want to fix things so that the SwView's area doesn't affect
 // tiled rendering?
-VisPortChgd(SwRect(Point(tilePosX, tilePosY), 
rDevice.PixelToLogic(Size(contextWidth, contextHeight;
+VisPortChgd(SwRect(aOutRect));
 
 // draw - works in logic coordinates
-Paint(Rectangle(Point(tilePosX, tilePosY), 
rDevice.PixelToLogic(Size(contextWidth, contextHeight;
+Paint(aOutRect);
 
 // Remove this device in DrawLayer
 if (Imp()-GetDrawView())
commit bfad9f5b7bbcb93af46cae535120795ead1f4f0a
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Thu Jul 24 21:27:43 2014 +0200

libreofficekit_tilederendering: test all 4 tiles.

The use of VisPortChgd ensures that the tiles all render as
expected, i.e. that the pixels match 1:1 irrespective of actual tile
size (for identical zoom factors and document areas).

Change-Id: Ib1e1df4f8257546c2f7993a8160c309a52037d8b

diff --git a/libreofficekit/qa/unit/tiledrendering.cxx 
b/libreofficekit/qa/unit/tiledrendering.cxx
index cec35ed..b231eb0 100644
--- a/libreofficekit/qa/unit/tiledrendering.cxx
+++ b/libreofficekit/qa/unit/tiledrendering.cxx
@@ -134,9 +134,9 @@ void TiledRenderingTest::testOverlay()
 // Iterate over our array of tiles
 // However for now we only bother with the top-left
 // tile as the other ones don't match yet...
-for ( int x = 0; x  1; x++ )
+for ( int x = 0; x  2; x++ )
 {
-for ( int y = 0; y  1; y++ )
+for ( int y = 0; y  2; y++ )
 {
 int xLarge = (x * (4 * nTotalWidthPix / 2)) + xSmall;
 int yLarge = (y * (nTotalHeightPix / 2)) + ySmall;
commit 94c720830c0f95bd9776ea3f21623bb949b9bbfe
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Thu Jul 24 21:15:49 2014 +0200

Tiled Rendering: ensure rendered area is visible correctly.

Using SetVisArea can cause problems due to various internal
state getting confused, however this gives correct output
without viewport assertion problems or missing content.

Change-Id: I8d206ab201167ea96a0ac853187861e8c3d541e5

diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index 6ffdbbf..daf5304 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -1785,8 +1785,14 @@ void SwViewShell::PaintTile(VirtualDevice rDevice, int 
contextWidth, int contex
 Imp()-GetDrawView()-AddWindowToPaintView(rDevice);
 }
 
-// scroll the requested area into view if necessary
-MakeVisible(SwRect(Point(tilePosX, tilePosY), 
rDevice.PixelToLogic(Size(contextWidth, contextHeight;
+// Make the requested area visible -- we can't use MakeVisible as that will
+// only scroll the contents, but won't zoom/resize if needed.
+// Without this, items/text that are outside the visible area (in the 
SwView)
+// won't be painted when rendering tiles (at least when using either the
+// tiledrendering app, or the gtktiledviewer) -- although ultimately we
+// probably want to fix things so that the SwView's area doesn't affect
+// tiled rendering?
+VisPortChgd(SwRect(Point(tilePosX, tilePosY), 
rDevice.PixelToLogic(Size(contextWidth, contextHeight;
 
 // draw - works in logic coordinates
 Paint(Rectangle(Point(tilePosX, tilePosY), 
rDevice.PixelToLogic(Size(contextWidth, contextHeight;
commit 7bf98caddda048db0f39048af178621294aa0665
Author: Andrzej Hunt

[Libreoffice-commits] core.git: 2 commits - svgio/inc svgio/source

 svgio/inc/svgio/svgreader/svgnode.hxx  |   22 ++
 svgio/source/svgreader/svgcirclenode.cxx   |2 
 svgio/source/svgreader/svgclippathnode.cxx |2 
 svgio/source/svgreader/svgellipsenode.cxx  |2 
 svgio/source/svgreader/svggnode.cxx|2 
 svgio/source/svgreader/svggradientnode.cxx |9 
 svgio/source/svgreader/svggradientstopnode.cxx |6 
 svgio/source/svgreader/svgimagenode.cxx|2 
 svgio/source/svgreader/svglinenode.cxx |2 
 svgio/source/svgreader/svgmarkernode.cxx   |2 
 svgio/source/svgreader/svgmasknode.cxx |2 
 svgio/source/svgreader/svgnode.cxx |  236 ++---
 svgio/source/svgreader/svgpathnode.cxx |2 
 svgio/source/svgreader/svgpatternnode.cxx  |2 
 svgio/source/svgreader/svgpolynode.cxx |2 
 svgio/source/svgreader/svgrectnode.cxx |2 
 svgio/source/svgreader/svgstyleattributes.cxx  |   34 +++
 svgio/source/svgreader/svgstylenode.cxx|   53 -
 svgio/source/svgreader/svgsvgnode.cxx  |   21 +-
 svgio/source/svgreader/svgsymbolnode.cxx   |2 
 svgio/source/svgreader/svgtextnode.cxx |2 
 svgio/source/svgreader/svgtextpathnode.cxx |2 
 svgio/source/svgreader/svgtrefnode.cxx |2 
 svgio/source/svgreader/svgtspannode.cxx|2 
 svgio/source/svgreader/svgusenode.cxx  |2 
 25 files changed, 280 insertions(+), 137 deletions(-)

New commits:
commit 7eba2d637334f67ab8a6e7883d9aecb1c3c31e93
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Sat Jul 26 14:50:59 2014 +0100

drop rtl:: and statics

Change-Id: I6108efad77cf1c21dea3826ae149f3750552b0ed

diff --git a/svgio/inc/svgio/svgreader/svgnode.hxx 
b/svgio/inc/svgio/svgreader/svgnode.hxx
index 6a5217c..4793ddf 100644
--- a/svgio/inc/svgio/svgreader/svgnode.hxx
+++ b/svgio/inc/svgio/svgreader/svgnode.hxx
@@ -82,7 +82,7 @@ namespace svgio
 // helper to convert a string associated with a token of type 
SVGTokenDisplay
 // to the enum Display. Empty trings return the default 
'Display_inline' with
 // which members should be initialized
-Display getDisplayFromContent(const rtl::OUString aContent);
+Display getDisplayFromContent(const OUString aContent);
 
 class SvgNode : private boost::noncopyable, public InfoProvider
 {
@@ -122,10 +122,10 @@ namespace svgio
 
 protected:
 /// helper to evtl. link to css style
-const SvgStyleAttributes* checkForCssStyle(const rtl::OUString 
rClassStr, const SvgStyleAttributes rOriginal) const;
+const SvgStyleAttributes* checkForCssStyle(const OUString 
rClassStr, const SvgStyleAttributes rOriginal) const;
 
 /// helper for filling the CssStyle vector once dependent on 
mbCssStyleVectorBuilt
-void fillCssStyleVector(const rtl::OUString rClassStr);
+void fillCssStyleVector(const OUString rClassStr);
 
 public:
 SvgNode(
@@ -135,7 +135,7 @@ namespace svgio
 virtual ~SvgNode();
 
 /// scan helper to read and interpret a local CssStyle to 
mpLocalCssStyle
-void readLocalCssStyle(const rtl::OUString aContent);
+void readLocalCssStyle(const OUString aContent);
 
 /// style helpers
 void parseAttributes(const com::sun::star::uno::Reference 
com::sun::star::xml::sax::XAttributeList  xAttribs);
diff --git a/svgio/source/svgreader/svggradientnode.cxx 
b/svgio/source/svgreader/svggradientnode.cxx
index 92ea5b5..d31979b 100644
--- a/svgio/source/svgreader/svggradientnode.cxx
+++ b/svgio/source/svgreader/svggradientnode.cxx
@@ -65,8 +65,8 @@ namespace svgio
 
 const SvgStyleAttributes* SvgGradientNode::getSvgStyleAttributes() 
const
 {
-static rtl::OUString 
aClassStrA(rtl::OUString::createFromAscii(linearGradient));
-static rtl::OUString 
aClassStrB(rtl::OUString::createFromAscii(radialGradient));
+OUString aClassStrA(linearGradient);
+OUString aClassStrB(radialGradient);
 
 return checkForCssStyle(
 SVGTokenLinearGradient == getType() ? aClassStrA : aClassStrB,
diff --git a/svgio/source/svgreader/svggradientstopnode.cxx 
b/svgio/source/svgreader/svggradientstopnode.cxx
index 6c6d758..a1ce201 100644
--- a/svgio/source/svgreader/svggradientstopnode.cxx
+++ b/svgio/source/svgreader/svggradientstopnode.cxx
@@ -38,7 +38,7 @@ namespace svgio
 
 const SvgStyleAttributes* SvgGradientStopNode::getSvgStyleAttributes() 
const
 {
-static rtl::OUString 
aClassStr(rtl::OUString::createFromAscii(stop));
+OUString aClassStr(stop);
 
 return checkForCssStyle(aClassStr, maSvgStyleAttributes);
 }
diff --git a/svgio/source/svgreader/svgnode.cxx 
b/svgio/source/svgreader/svgnode.cxx
index 24decd3..1652a25 100644
---

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - f0/0d6d2ea3e73e687edb1da4c32c0960eaf5010b

 f0/0d6d2ea3e73e687edb1da4c32c0960eaf5010b |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 2f8cd1735f4c7ee51a85f9b948c4cd3f95870930
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Sat Jul 26 14:52:09 2014 +0100

Notes added by 'git notes add'

diff --git a/f0/0d6d2ea3e73e687edb1da4c32c0960eaf5010b 
b/f0/0d6d2ea3e73e687edb1da4c32c0960eaf5010b
new file mode 100644
index 000..2edfcf9
--- /dev/null
+++ b/f0/0d6d2ea3e73e687edb1da4c32c0960eaf5010b
@@ -0,0 +1 @@
+merged as: 0347e5c77d281e4a25f79660aafb625691c4f883
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'feature/calctiledrendering5'

New branch 'feature/calctiledrendering5' available with the following commits:
commit d3fca838b2af585a38f48ae4c389e15075e766a6
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 25 21:03:19 2014 +0200

Make sure LOK is actually headless.

This prevents e.g. the document recovery dialog from trying to be shown.

Change-Id: I253720f7fa1abd1c053670434f8394473517b670

commit 579b5a3da20218cf786ee0cc17feec7c1a26e3e4
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 25 20:56:18 2014 +0200

Don't fail on --protector.

If we have any unknown command line arguments Desktop init will fail,
however our LOK Tiled Rendering test uses Desktop (via soffice_main).
(Other unit tests don't use soffice_main hence this check never
comes into play.) It looks like it's most reliable simply to ignore
--protector here, rather than try to filter it out elsewhere (which
is difficult as it is passed to osl via SAL_IMPLEMENT_MAIN).

Change-Id: I95d047892851ba2cf9edd2e26bacc6efa0320f71

commit 54e6731ac839250ab2dba68cfaae4489067f21fc
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 25 20:54:40 2014 +0200

Revert DON'T USE: ignore unknown args instead of failure.

This reverts commit 8ffe7f2b93620112319981957ab6bc27c0d4738d.

commit 3e49397b1a76b00209e5887b8c2f5119b8082e32
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Thu Jul 24 21:38:12 2014 +0200

We're using the same rectangle for both calls, lets reuse it.

Change-Id: I884832fc92e0fe9c10711d9fdaf103076a05f721

commit 799d1a7c36e3a031e06c286e3a6c19cfe78d5c82
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Thu Jul 24 21:27:43 2014 +0200

libreofficekit_tilederendering: test all 4 tiles.

The use of VisPortChgd ensures that the tiles all render as
expected, i.e. that the pixels match 1:1 irrespective of actual tile
size (for identical zoom factors and document areas).

Change-Id: Ib1e1df4f8257546c2f7993a8160c309a52037d8b

commit b5cb3cf52674d6f3562fd5344e593012f260749f
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Thu Jul 24 21:15:49 2014 +0200

Tiled Rendering: ensure rendered area is visible without repaint.

Change-Id: I8d206ab201167ea96a0ac853187861e8c3d541e5

commit 6f5f85300d853a34a6ada3057ec0281481bfb370
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Thu Jul 24 14:34:49 2014 +0200

Revert Tiled Rendering: ensure rendered area is visible.

This reverts commit ff6a38b76df80d0f907f2f92cb851dea43c91d81.

commit 05f082dd45deb23d76410685c6c38e58d2a2d7fb
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Wed Jul 23 20:17:11 2014 +0200

Revert Use DLPre/PostPaint2 for Tiled Rendering (ensures viewport is set).

This reverts commit 1deb9f267d0cfe29d88166121f9dd4dd2416f5dc.

commit 1deb9f267d0cfe29d88166121f9dd4dd2416f5dc
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Wed Jul 23 08:03:45 2014 +0200

Use DLPre/PostPaint2 for Tiled Rendering (ensures viewport is set).

Without this we don't necessarily set the correct rendering region for
our underlying SDRPageWindow, which can cause problems with rendering
(i.e. the same region might not be painted identically for two
 overlapping tiles -- specifically the page borders seem to be drawn
 differently depending on whether the redraw region is set to be the
 same as the tile area -- with correctly set region, the page borders
 are always drawn the same and thus match as expected ).

This was also causing an assert to fire when sometimes we would
end up with an empty redraw region (and thus empty viewport in
SwVirtFlyDrawObj).

See:
fb0b42b89af95b42cc6caadf8c22321e5c9386e8
(now reverted)

Change-Id: Ie0e46e571414f282699899371d3df8c7056021f6

commit bf42c36dcd45818f8efde5df59929e94290f68a0
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 21:16:09 2014 +0200

Don't start Impress Remote server in headless mode.

Change-Id: Ibafe57413a60745e949dc3146fbc843c52c029d6

commit 6d7981074b2cde4d305e4c71ee77ad5d676bd645
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 21:15:39 2014 +0200

Lets not roll our own twip/mm100 conversions.

Change-Id: Id1d0c2bed0359c35086d963dcfe9b765b6232b09

commit ef583698d9508eeea29bf52f745673ecd49206d3
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 21:13:15 2014 +0200

Add Point and Size versions of convertMm100ToTwip/TwipToMm100.

There seem to be quite a few cases where the individual components
are being converted, this way we can just conver the entire
object as one.

Change-Id: I0043b6f40520d7497e6edc185187706b255f2354

commit 8ffe7f2b93620112319981957ab6bc27c0d4738d
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 19:46:16 2014 +0200

DON'T USE: ignore unknown args instead of

[Libreoffice-commits] core.git: Changes to 'feature/lok_sofficemain'

New branch 'feature/lok_sofficemain' available with the following commits:
commit 45bc5d5eeca0b54e0954b659c514993c241ad71d
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 25 21:03:19 2014 +0200

Make sure LOK is actually headless.

This prevents e.g. the document recovery dialog from trying to be shown.

Change-Id: I253720f7fa1abd1c053670434f8394473517b670

commit 701383b17e4ad0aebd3c55d69ac1b169e6628b1f
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 25 20:56:18 2014 +0200

Don't fail on --protector.

If we have any unknown command line arguments Desktop init will fail,
however our LOK Tiled Rendering test uses Desktop (via soffice_main).
(Other unit tests don't use soffice_main hence this check never
comes into play.) It looks like it's most reliable simply to ignore
--protector here, rather than try to filter it out elsewhere (which
is difficult as it is passed to osl via SAL_IMPLEMENT_MAIN).

Change-Id: I95d047892851ba2cf9edd2e26bacc6efa0320f71

commit 226de15e06136d3ab01c4662754d67b74b83fded
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 21:16:09 2014 +0200

Don't start Impress Remote server in headless mode.

Change-Id: Ibafe57413a60745e949dc3146fbc843c52c029d6

commit 7b7a8f5fdecb5c9363f3c2aca562a131e2970c7b
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 19:36:11 2014 +0200

Use gb_CppunitTest_use_confpreinit for LOK tiled rendering.

Now that we use the event loop for LOK we need to make sure that
it is able to run successfully first time, as unit tests start
with a completely clean config.

Change-Id: If9ddcb75fe8286381d71ecdc76ac7eb3697960d0

commit 9eb4338b2e79e0f0e28eb719c07dd5ade3592504
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 19:35:13 2014 +0200

Add gb_CppunitTest_use_confpreinit:

For unit tests that use the VCL event loop we can use this to
avoid the otherwise required restart.

Change-Id: I48265d7e7188a4efaa6f87432c762320331c0c78

commit 373e15e8b32b12e09ed8323cd71adeaf94210c81
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 19:34:09 2014 +0200

Implement lokconf_init.

This is a simple executable which can be used to ensure there is a
pe-pared configuration for unit-tests to avoid the usually required
re-start on the first run.

Change-Id: I49b706e8daa93bc34db508a24615b63b9babddba

commit 64c1c9efdc4da6af58e5b753e16f1ff452e6d79f
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 18 13:12:25 2014 +0200

Fail LOK initialisation if restart is required.

Change-Id: Ia13a3523666147f002b5a5177fd6962d6f56

commit 33f2c3a0e5b64c2542a84d81955f89846d9c2a69
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 18 13:10:14 2014 +0200

Add OfficeIPCThread::IsEnabled.

This lets us easily check whether Desktop::Main has shut down,
i.e. which happens on the first restart-requiring initialisation.

Change-Id: I7fe5699a4bf59e2c3b891ac73abd9b147773d22e

commit 14277ea063cf91e09eba2dd306101b8ea005209d
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 18 10:02:48 2014 +0200

Use OfficeIPCThread::WaitForReady rather than sleeping.

This way we actually continue when we're ready to, rather than
dumbly hoping we wait for long enough.

This isn't entirely unproblematic though -- if we have no config
pre-prepared (i.e. first-run), then we just end up hanging on this
since soffice_main exits without doing anything to the OfficeIPCThread.
(Which is especially problematic for unit tests which specifically run
 on an empty config.)

Change-Id: I064fb500a224cfe37a0d3ba24b6154ffd72a71a3

commit 114320d1cca5d3c8ee234ad8e161fbf7b79ee870
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 18 10:00:42 2014 +0200

Bin outdated / incorrect comment.

Change-Id: I7b8f97377b9606a2228f172f772d8051a64703d2

commit 17b7e635ff2cfa135eff0c74172c80e598406085
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 18 09:48:47 2014 +0200

Add OfficeIPCThread::WaitForReady.

For LibreOfficeKit we need to start up the event loop, and can't continue
initialisation until all the related (VCL etc.) setup is complete -- the
OfficeIPCThread is also enabled as one of the last items, and can be
used to indicate whether or not we can start actually working with VCL.

Change-Id: I0450b65584ddf6e8d02ce0c6e66e06f47841d1b7

commit 124b6e03707ad47c8662652eb8121375fb4c73d1
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Thu Jul 17 16:13:49 2014 +0200

DO NOT MERGE YET: hack soffice_main into LOK.

Change-Id: I86e13192ddb5904afabca38d3a201f17f145de09

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

Re: Some dialogs don't work in OS X (master branch)

2014-07-26 Thread julien2412

I could reproduce this with master sources updated today and MacOs 10.9.4.
Would it be possible you submit a new bugtracker by using this link:
https://www.libreoffice.org/get-help/bug/
?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Some-dialogs-don-t-work-in-OS-X-master-branch-tp4116738p4116811.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'feature/lok_sofficemain' - 12 commits - desktop/Library_sofficeapp.mk desktop/source libreofficekit/CppunitTest_libreofficekit_tiledrendering.mk libreofficekit/

Rebased ref, commits from common ancestor:
commit f412bf91a5f3c60197168b7baef1a8f058f6236b
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 25 21:03:19 2014 +0200

Make sure LOK is actually headless.

This prevents e.g. the document recovery dialog from trying to be shown.

Change-Id: I253720f7fa1abd1c053670434f8394473517b670

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 567f5ae..b73e4e2 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -626,13 +626,24 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath)
 
 try
 {
+// We specifically need to make sure we have the headless
+// command arg set (various code specifically checks via
+// CommandLineArgs). We could alternatively add some other
+// flag elsewhere to indicate headlessness, which would
+// then be set from here or via CommandLineArgs.
+// (The first argument is treated specially by osl_setCommandArgs
+// however it is valid to make it \0 instead.)
+char sName[] = ;
+char sHeadless[] = --headless;
+char* pArgs[2] = { sName, sHeadless };
+
 // If we've set up the command args elsewhere then we cannot do it
 // again (as an assert will fire), this will be the case e.g.
 // for unit tests (and possibly if UNO is being used in addition
 // to LOK in an external program).
 if (!osl_areCommandArgsSet())
 {
-osl_setCommandArgs(0, NULL);
+osl_setCommandArgs(2, pArgs);
 }
 initialize_uno(aAppURL);
 force_c_locale();
commit ceda3f60f3ba92b4e99651d0ba9da310e0cb081c
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 25 20:56:18 2014 +0200

Don't fail on --protector.

If we have any unknown command line arguments Desktop init will fail,
however our LOK Tiled Rendering test uses Desktop (via soffice_main).
(Other unit tests don't use soffice_main hence this check never
comes into play.) It looks like it's most reliable simply to ignore
--protector here, rather than try to filter it out elsewhere (which
is difficult as it is passed to osl via SAL_IMPLEMENT_MAIN).

Change-Id: I95d047892851ba2cf9edd2e26bacc6efa0320f71

diff --git a/desktop/source/app/cmdlineargs.cxx 
b/desktop/source/app/cmdlineargs.cxx
index 5f98e07..a0eefbe 100644
--- a/desktop/source/app/cmdlineargs.cxx
+++ b/desktop/source/app/cmdlineargs.cxx
@@ -252,6 +252,18 @@ void CommandLineArgs::ParseCommandLine_Impl( Supplier 
supplier )
 {
 m_helpmath = true;
 }
+else if ( oArg == protector )
+{
+// Not relevant for us here, but can be used in unit tests.
+// Usually unit tests would not end up here, but e.g. the
+// LOK Tiled Rendering tests end up running a full soffice
+// process, and we can't bail on the use of --protector.
+
+// We specifically need to consume the following 2 arguments
+// for --protector
+assert( supplier.next( aArg ) );
+assert( supplier.next( aArg ) );
+}
 else if ( oArg == version )
 {
 m_version = true;
commit d62e9fa1df9b948b3583ce6b7f6508f15215a31a
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 21:16:09 2014 +0200

Don't start Impress Remote server in headless mode.

Change-Id: Ibafe57413a60745e949dc3146fbc843c52c029d6

diff --git a/sd/source/ui/remotecontrol/Server.cxx 
b/sd/source/ui/remotecontrol/Server.cxx
index 5ec1184..69e5292 100644
--- a/sd/source/ui/remotecontrol/Server.cxx
+++ b/sd/source/ui/remotecontrol/Server.cxx
@@ -360,6 +360,21 @@ void RemoteServer::deauthoriseClient( ::boost::shared_ptr 
ClientInfo  pClient
 void SdDLL::RegisterRemotes()
 {
 SAL_INFO( sdremote, SdDLL::RegisterRemotes called );
+
+// The remote server is likely of no use in headless mode. And as only
+// one instance of the server can actually own the appropriate ports its
+// probably best to not even try to do so from our headless instance
+// (i.e. as to avoid blocking expected usage).
+// It could perhaps be argued that we would still need the remote
+// server for tiled rendering of presentations, but even then this
+// implementation would not be of much use, i.e. would be controlling
+// the purely imaginary headless presentation -- instead we'd need
+// to have some sort of mechanism of plugging in our tiled rendering
+// client to be controlled by the remote server, or provide an
+// alternative implementation.
+if ( Application::IsHeadlessModeEnabled() )
+return;
+
 uno::Reference uno::XComponentContext  xContext = 
comphelper::getProcessComponentContext();
 if ( xContext.is()

[Libreoffice-commits] core.git: Branch 'feature/calctiledrendering5' - 794 commits - accessibility/source android/abs-lib android/Bootstrap android/experimental avmedia/source basctl/source basic/inc

Rebased ref, commits from common ancestor:
commit c8a5011174101dea2e381ae5b5a8269aecc941f7
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jul 25 20:54:40 2014 +0200

Revert DON'T USE: ignore unknown args instead of failure.

This reverts commit 8ffe7f2b93620112319981957ab6bc27c0d4738d.

diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index 7eed070..46fbebe 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -656,7 +656,7 @@ void Desktop::Init()
 // 2nd office startup should terminate after sending cmdlineargs 
through pipe
 SetBootstrapStatus(BS_TERMINATE);
 }
-else if ( (!rCmdLineArgs.GetUnknown().isEmpty()  false)
+else if ( !rCmdLineArgs.GetUnknown().isEmpty()
   || rCmdLineArgs.IsHelp() || rCmdLineArgs.IsVersion() )
 {
 // disable IPC thread in an instance that is just showing a help 
message
commit 80dedd6a85abbe040d18b50fa51574818ef63c9f
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 21:15:39 2014 +0200

Lets not roll our own twip/mm100 conversions.

Change-Id: Id1d0c2bed0359c35086d963dcfe9b765b6232b09

diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 08b8013..60a6f47 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -27,6 +27,7 @@
 #include editeng/scripttypeitem.hxx
 #include sfx2/bindings.hxx
 #include sfx2/printer.hxx
+#include tools/mapunit.hxx
 #include vcl/settings.hxx
 
 #include svx/svdpage.hxx
@@ -424,9 +425,8 @@ Size ScGridWindow::GetDataAreaSize()
 SdrPage* pPage = pPageView-GetPage();
 Rectangle aDrawDataArea = pPage-GetAllObjBoundRect();
 // Draw layer works in 100th mm, whereas we're working with TWIPs.
-aDrawDataArea.SetPos( aDrawDataArea.TopLeft() * 1440 / 2540 );
-aDrawDataArea.SetSize( Size( aDrawDataArea.GetSize().Width() * 1440 / 2540,
- aDrawDataArea.GetSize().Height() * 1440 / 
2540 ) );
+aDrawDataArea.SetPos( convertMm100ToTwip(aDrawDataArea.TopLeft() ) );
+aDrawDataArea.SetSize( convertMm100ToTwip( aDrawDataArea.GetSize() ) );
 
 // We specifically keep iterating until we have covered both the
 // data area AND the drawing layer area. We also make sure that
@@ -641,7 +641,7 @@ void ScGridWindow::Draw( SCCOL nX1, SCROW nY1, SCCOL nX2, 
SCROW nY2, ScUpdateMod
 MapMode aDrawMode = pOutDev-GetMapMode();
 Point aOrigin = aDrawMode.GetOrigin();
 aDrawMode.SetMapUnit( MAP_100TH_MM );
-aDrawMode.SetOrigin( (aOrigin * 2540l) / 1440l );
+aDrawMode.SetOrigin( convertTwipToMm100( aOrigin ) );
 Rectangle aDrawingRectLogic;
 
 {
commit f22df48af246f71c1185fb3ca7b319e1f31af078
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 21:13:15 2014 +0200

Add Point and Size versions of convertMm100ToTwip/TwipToMm100.

There seem to be quite a few cases where the individual components
are being converted, this way we can just conver the entire
object as one.

Change-Id: I0043b6f40520d7497e6edc185187706b255f2354

diff --git a/include/tools/mapunit.hxx b/include/tools/mapunit.hxx
index a68b6b4..af3eaa9 100644
--- a/include/tools/mapunit.hxx
+++ b/include/tools/mapunit.hxx
@@ -20,6 +20,8 @@
 #ifndef INCLUDED_TOOLS_MAPUNIT_HXX
 #define INCLUDED_TOOLS_MAPUNIT_HXX
 
+#include gen.hxx
+
 enum MapUnit { MAP_100TH_MM, MAP_10TH_MM, MAP_MM, MAP_CM,
MAP_1000TH_INCH, MAP_100TH_INCH, MAP_10TH_INCH, MAP_INCH,
MAP_POINT, MAP_TWIP, MAP_PIXEL, MAP_SYSFONT, MAP_APPFONT,
@@ -33,6 +35,18 @@ inline sal_Int64 convertTwipToMm100(sal_Int64 n)
 return (n*127-36)/72;
 }
 
+inline Point convertTwipToMm100(const Point rPoint)
+{
+return Point(convertTwipToMm100(rPoint.getX()),
+ convertTwipToMm100(rPoint.getY()));
+}
+
+inline Size convertTwipToMm100(const Size rSize)
+{
+return Size(convertTwipToMm100(rSize.getWidth()),
+convertTwipToMm100(rSize.getHeight()));
+}
+
 inline sal_Int64 convertMm100ToTwip(sal_Int64 n)
 {
 if (n = 0)
@@ -41,6 +55,18 @@ inline sal_Int64 convertMm100ToTwip(sal_Int64 n)
 return (n*72-63)/127;
 }
 
+inline Point convertMm100ToTwip(const Point rPoint)
+{
+return Point(convertMm100ToTwip(rPoint.getX()),
+ convertMm100ToTwip(rPoint.getY()));
+}
+
+inline Size convertMm100ToTwip(const Size rSize)
+{
+return Size(convertMm100ToTwip(rSize.getWidth()),
+convertMm100ToTwip(rSize.getHeight()));
+}
+
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 4d8e24b481002d807c488a1b0031dc14fd3197e3
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 19:46:16 2014 +0200

DON'T USE: ignore unknown args instead of failure.

The --protector flag ends up here in unit tests, which causes things
to fail -- either we need to make --protector known, or filter

[Libreoffice-commits] core.git: Branch 'feature/calctiledrendering5' - 2 commits - include/tools sc/source

Rebased ref, commits from common ancestor:
commit 632d7dad8b9e4ea5fc81cba98398bf6ae374c00b
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 21:15:39 2014 +0200

Lets not roll our own twip/mm100 conversions.

Change-Id: Id1d0c2bed0359c35086d963dcfe9b765b6232b09

diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 08b8013..60a6f47 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -27,6 +27,7 @@
 #include editeng/scripttypeitem.hxx
 #include sfx2/bindings.hxx
 #include sfx2/printer.hxx
+#include tools/mapunit.hxx
 #include vcl/settings.hxx
 
 #include svx/svdpage.hxx
@@ -424,9 +425,8 @@ Size ScGridWindow::GetDataAreaSize()
 SdrPage* pPage = pPageView-GetPage();
 Rectangle aDrawDataArea = pPage-GetAllObjBoundRect();
 // Draw layer works in 100th mm, whereas we're working with TWIPs.
-aDrawDataArea.SetPos( aDrawDataArea.TopLeft() * 1440 / 2540 );
-aDrawDataArea.SetSize( Size( aDrawDataArea.GetSize().Width() * 1440 / 2540,
- aDrawDataArea.GetSize().Height() * 1440 / 
2540 ) );
+aDrawDataArea.SetPos( convertMm100ToTwip(aDrawDataArea.TopLeft() ) );
+aDrawDataArea.SetSize( convertMm100ToTwip( aDrawDataArea.GetSize() ) );
 
 // We specifically keep iterating until we have covered both the
 // data area AND the drawing layer area. We also make sure that
@@ -641,7 +641,7 @@ void ScGridWindow::Draw( SCCOL nX1, SCROW nY1, SCCOL nX2, 
SCROW nY2, ScUpdateMod
 MapMode aDrawMode = pOutDev-GetMapMode();
 Point aOrigin = aDrawMode.GetOrigin();
 aDrawMode.SetMapUnit( MAP_100TH_MM );
-aDrawMode.SetOrigin( (aOrigin * 2540l) / 1440l );
+aDrawMode.SetOrigin( convertTwipToMm100( aOrigin ) );
 Rectangle aDrawingRectLogic;
 
 {
commit 047bdf304a48a126f840933df0e54dd9f79afbbb
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Mon Jul 21 21:13:15 2014 +0200

Add Point and Size versions of convertMm100ToTwip/TwipToMm100.

There seem to be quite a few cases where the individual components
are being converted, this way we can just conver the entire
object as one.

Change-Id: I0043b6f40520d7497e6edc185187706b255f2354

diff --git a/include/tools/mapunit.hxx b/include/tools/mapunit.hxx
index a68b6b4..af3eaa9 100644
--- a/include/tools/mapunit.hxx
+++ b/include/tools/mapunit.hxx
@@ -20,6 +20,8 @@
 #ifndef INCLUDED_TOOLS_MAPUNIT_HXX
 #define INCLUDED_TOOLS_MAPUNIT_HXX
 
+#include gen.hxx
+
 enum MapUnit { MAP_100TH_MM, MAP_10TH_MM, MAP_MM, MAP_CM,
MAP_1000TH_INCH, MAP_100TH_INCH, MAP_10TH_INCH, MAP_INCH,
MAP_POINT, MAP_TWIP, MAP_PIXEL, MAP_SYSFONT, MAP_APPFONT,
@@ -33,6 +35,18 @@ inline sal_Int64 convertTwipToMm100(sal_Int64 n)
 return (n*127-36)/72;
 }
 
+inline Point convertTwipToMm100(const Point rPoint)
+{
+return Point(convertTwipToMm100(rPoint.getX()),
+ convertTwipToMm100(rPoint.getY()));
+}
+
+inline Size convertTwipToMm100(const Size rSize)
+{
+return Size(convertTwipToMm100(rSize.getWidth()),
+convertTwipToMm100(rSize.getHeight()));
+}
+
 inline sal_Int64 convertMm100ToTwip(sal_Int64 n)
 {
 if (n = 0)
@@ -41,6 +55,18 @@ inline sal_Int64 convertMm100ToTwip(sal_Int64 n)
 return (n*72-63)/127;
 }
 
+inline Point convertMm100ToTwip(const Point rPoint)
+{
+return Point(convertMm100ToTwip(rPoint.getX()),
+ convertMm100ToTwip(rPoint.getY()));
+}
+
+inline Size convertMm100ToTwip(const Size rSize)
+{
+return Size(convertMm100ToTwip(rSize.getWidth()),
+convertMm100ToTwip(rSize.getHeight()));
+}
+
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - codemaker/source forms/source package/source

 codemaker/source/codemaker/typemanager.cxx |2 +-
 forms/source/inc/InterfaceContainer.hxx|2 +-
 forms/source/misc/InterfaceContainer.cxx   |   13 -
 package/source/xstor/xstorage.cxx  |2 +-
 4 files changed, 11 insertions(+), 8 deletions(-)

New commits:
commit 8ec047030f5ff5b8235b68eed06c7ed68ddeecfe
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Sat Jul 26 15:22:46 2014 +0100

coverity#706541 Uncaught exception

and

coverity#706537 Uncaught exception

Change-Id: I403d83bb7aa4cf82edf1b6c608f9daac31576208

diff --git a/forms/source/inc/InterfaceContainer.hxx 
b/forms/source/inc/InterfaceContainer.hxx
index a75f392..36a219a 100644
--- a/forms/source/inc/InterfaceContainer.hxx
+++ b/forms/source/inc/InterfaceContainer.hxx
@@ -119,7 +119,7 @@ public:
 OInterfaceContainer( ::osl::Mutex _rMutex, const OInterfaceContainer 
_cloneSource );
 
 // late constructor for cloning
-void clonedFrom( const OInterfaceContainer _cloneSource );
+void clonedFrom(const OInterfaceContainer _cloneSource) 
throw(css::uno::RuntimeException, std::exception);
 
 protected:
 virtual ~OInterfaceContainer();
diff --git a/forms/source/misc/InterfaceContainer.cxx 
b/forms/source/misc/InterfaceContainer.cxx
index 27b246d..ea989e3 100644
--- a/forms/source/misc/InterfaceContainer.cxx
+++ b/forms/source/misc/InterfaceContainer.cxx
@@ -29,6 +29,7 @@
 #include com/sun/star/container/XNamed.hpp
 #include com/sun/star/io/WrongFormatException.hpp
 #include com/sun/star/io/XMarkableStream.hpp
+#include com/sun/star/lang/WrappedTargetRuntimeException.hpp
 #include com/sun/star/lang/XComponent.hpp
 #include com/sun/star/util/XCloneable.hpp
 #include com/sun/star/form/XForm.hpp
@@ -199,8 +200,7 @@ OInterfaceContainer::OInterfaceContainer( ::osl::Mutex 
_rMutex, const OInterfac
 impl_createEventAttacher_nothrow();
 }
 
-
-void OInterfaceContainer::clonedFrom( const OInterfaceContainer _cloneSource )
+void OInterfaceContainer::clonedFrom(const OInterfaceContainer _cloneSource) 
throw(RuntimeException, std::exception)
 {
 try
 {
@@ -213,9 +213,13 @@ void OInterfaceContainer::clonedFrom( const 
OInterfaceContainer _cloneSource )
 insertByIndex( i, makeAny( xClone ) );
 }
 }
-catch( const Exception )
+catch (const RuntimeException)
+{
+throw;
+}
+catch (const Exception)
 {
-throw WrappedTargetException(
+throw WrappedTargetRuntimeException(
 Could not clone the given interface hierarchy.,
 static_cast XIndexContainer* ( const_cast OInterfaceContainer* 
( _cloneSource ) ),
 ::cppu::getCaughtException()
@@ -223,7 +227,6 @@ void OInterfaceContainer::clonedFrom( const 
OInterfaceContainer _cloneSource )
 }
 }
 
-
 void OInterfaceContainer::impl_createEventAttacher_nothrow()
 {
 try
commit 850be5e3d14b91f1097be9ac9c12ef85c13b55f8
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Sat Jul 26 15:10:37 2014 +0100

coverity#706577 Uncaught exception

Change-Id: Ifc4c7f3e7a19bad2ae420c0ebab54cf56404de51

diff --git a/package/source/xstor/xstorage.cxx 
b/package/source/xstor/xstorage.cxx
index f7a8b6e..d19e9d2 100644
--- a/package/source/xstor/xstorage.cxx
+++ b/package/source/xstor/xstorage.cxx
@@ -3874,7 +3874,7 @@ void SAL_CALL OStorage::insertRawEncrStreamElement( const 
OUString aStreamName,
 }
 
 if ( m_pData-m_nStorageType != embed::StorageFormats::PACKAGE )
-throw packages::NoEncryptionException( THROW_WHERE );
+throw embed::InvalidStorageException( THROW_WHERE );
 
 if ( aStreamName.isEmpty() || 
!::comphelper::OStorageHelper::IsValidZipEntryFileName( aStreamName, false ) )
 throw lang::IllegalArgumentException( THROW_WHERE Unexpected entry 
name syntax., uno::Reference uno::XInterface (), 1 );
commit bcba2088ab6e2b762800b8c11e0bce25185b369a
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Sat Jul 26 15:02:45 2014 +0100

coverity#1019323 Unchecked dynamic_cast

Change-Id: I3d8b598e86339fdd51af48e62393550821b6278d

diff --git a/codemaker/source/codemaker/typemanager.cxx 
b/codemaker/source/codemaker/typemanager.cxx
index d2e346d..3d1bd83 100644
--- a/codemaker/source/codemaker/typemanager.cxx
+++ b/codemaker/source/codemaker/typemanager.cxx
@@ -180,7 +180,7 @@ codemaker::UnoType::Sort TypeManager::decompose(
 switch (s) {
 case codemaker::UnoType::SORT_TYPEDEF:
 if (resolveTypedefs) {
-n = dynamic_cast unoidl::TypedefEntity * (ent.get())-
+n = dynamic_castunoidl::TypedefEntity(*ent.get()).
 getType();
 while (n.startsWith([])) {
 ++k; //TODO: overflow
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: desktop/inc desktop/source

2014-07-26 Thread Takeshi Abe

 desktop/inc/app.hxx|4 
 desktop/source/app/appinit.cxx |3 +++
 2 files changed, 3 insertions(+), 4 deletions(-)

New commits:
commit d3293105512a3c25c5a17799a3bab6e0c7ff929d
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Sat Jul 26 23:47:19 2014 +0900

fdo#75757: remove inheritance to std::map

Typedef'ing AcceptorMap in appinit.cxx is enough.

Change-Id: Ia26e119562c87b11d8dd81f49b72d825739162b2
Reviewed-on: https://gerrit.libreoffice.org/10555
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/desktop/inc/app.hxx b/desktop/inc/app.hxx
index b067ae6..33e7c0c 100644
--- a/desktop/inc/app.hxx
+++ b/desktop/inc/app.hxx
@@ -20,8 +20,6 @@
 #ifndef INCLUDED_DESKTOP_INC_APP_HXX
 #define INCLUDED_DESKTOP_INC_APP_HXX
 
-// stl includes first
-#include map
 #include boost/optional.hpp
 #include boost/scoped_ptr.hpp
 #include com/sun/star/lang/XMultiServiceFactory.hpp
@@ -29,7 +27,6 @@
 #include vcl/timer.hxx
 #include tools/resmgr.hxx
 #include unotools/bootstrap.hxx
-#include com/sun/star/lang/XInitialization.hpp
 #include com/sun/star/task/XStatusIndicator.hpp
 #include com/sun/star/uno/Reference.h
 #include osl/mutex.hxx
@@ -46,7 +43,6 @@ namespace desktop
  */
 class CommandLineArgs;
 class Lockfile;
-class AcceptorMap : public std::map OUString, 
css::uno::Referencecss::lang::XInitialization  {};
 struct ConvertData;
 class Desktop : public Application
 {
diff --git a/desktop/source/app/appinit.cxx b/desktop/source/app/appinit.cxx
index 221afef..02478a4 100644
--- a/desktop/source/app/appinit.cxx
+++ b/desktop/source/app/appinit.cxx
@@ -53,6 +53,7 @@
 #include unotools/tempfile.hxx
 #include vcl/svapp.hxx
 #include unotools/pathoptions.hxx
+#include map
 
 using namespace desktop;
 using namespace ::com::sun::star::uno;
@@ -154,6 +155,8 @@ void Desktop::RegisterServices(Reference XComponentContext 
 const  context)
 }
 }
 
+typedef std::map OUString, css::uno::Referencecss::lang::XInitialization  
AcceptorMap;
+
 namespace
 {
 struct acceptorMap : public rtl::Static AcceptorMap, acceptorMap  {};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 75757] remove inheritance to std::map and std::vector

https://bugs.freedesktop.org/show_bug.cgi?id=75757

--- Comment #11 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d3293105512a3c25c5a17799a3bab6e0c7ff929d

fdo#75757: remove inheritance to std::map



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: external/jfreereport

2014-07-26 Thread rbuj

 external/jfreereport/patches/libloader-1.1.6-deprecated.patch |   23 ++
 1 file changed, 23 insertions(+)

New commits:
commit 66f4347aff8210c209d54320e3cdef3bcc55f2b1
Author: rbuj robert@gmail.com
Date:   Thu Jul 24 15:21:05 2014 +0200

jfreereport_libloader: [deprecation] toURL() in File has been deprecated

http://docs.oracle.com/javase/6/docs/api/java/io/File.html#toURL()

Change-Id: I5ff457cdbeff0049a9e31d6aa66dd973289d5f05
Reviewed-on: https://gerrit.libreoffice.org/10506
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/external/jfreereport/patches/libloader-1.1.6-deprecated.patch 
b/external/jfreereport/patches/libloader-1.1.6-deprecated.patch
index c098906..79fa046 100644
--- a/external/jfreereport/patches/libloader-1.1.6-deprecated.patch
+++ b/external/jfreereport/patches/libloader-1.1.6-deprecated.patch
@@ -9,3 +9,26 @@
}
  
/**
+--- 
misc/libloader-1.1.6/source/org/pentaho/reporting/libraries/resourceloader/loader/file/FileResourceLoader.java
 2010-04-27 16:07:00.0 +0200
 
misc/build/libloader-1.1.6/source/org/pentaho/reporting/libraries/resourceloader/loader/file/FileResourceLoader.java
   2014-07-24 15:11:26.0 +0200
+@@ -19,6 +19,7 @@
+ 
+ import java.io.File;
+ import java.io.IOException;
++import java.lang.SecurityException;
+ import java.net.MalformedURLException;
+ import java.net.URL;
+ import java.util.HashMap;
+@@ -170,7 +171,11 @@
+ final File file = (File) key.getIdentifier();
+ try
+ {
+-  return file.toURL();
++  return file.toURI().toURL();
++}
++catch (SecurityException e)
++{
++  return null;
+ }
+ catch (MalformedURLException e)
+ {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/jfreereport

2014-07-26 Thread rbuj

 external/jfreereport/patches/librepository-1.1.6-deprecated.patch |   26 
++
 1 file changed, 26 insertions(+)

New commits:
commit 02085703db494183b75da3ae59d25b907d6bea54
Author: rbuj robert@gmail.com
Date:   Fri Jul 25 11:34:36 2014 +0200

jfreereport_librepository: [deprecation] toURL() in File has been deprecated

http://docs.oracle.com/javase/6/docs/api/java/io/File.html#toURL()

Change-Id: I27d67f930ab15b69319a733b4bdedde834aba48d
Reviewed-on: https://gerrit.libreoffice.org/10530
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/external/jfreereport/patches/librepository-1.1.6-deprecated.patch 
b/external/jfreereport/patches/librepository-1.1.6-deprecated.patch
index a266efc..324a8f4 100644
--- a/external/jfreereport/patches/librepository-1.1.6-deprecated.patch
+++ b/external/jfreereport/patches/librepository-1.1.6-deprecated.patch
@@ -9,3 +9,29 @@
}
  
/**
+--- 
misc/librepository-1.1.6/source/org/pentaho/reporting/libraries/repository/file/FileRepository.java
2010-04-27 16:04:50.0 +0200
 
misc/build/librepository-1.1.6/source/org/pentaho/reporting/libraries/repository/file/FileRepository.java
  2014-07-25 11:21:51.0 +0200
+@@ -19,7 +19,9 @@
+ 
+ import java.io.File;
+ import java.io.Serializable;
++import java.lang.SecurityException;
+ import java.net.MalformedURLException;
++import java.net.URI;
+ import java.net.URL;
+ 
+ import org.pentaho.reporting.libraries.repository.ContentIOException;
+@@ -104,6 +106,11 @@
+*/
+   public URL getURL() throws MalformedURLException
+   {
+-return root.getBackend().toURL();
++try {
++  URI uri = root.getBackend().toURI();
++  return uri.toURL();
++} catch (SecurityException e) {
++  throw new MalformedURLException(impossible + e);
++}
+   }
+ }
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source

2014-07-26 Thread Takeshi Abe

 cui/source/customize/cfg.cxx   |   46 ++---
 cui/source/customize/macropg.cxx   |4 +--
 cui/source/dialogs/SpellDialog.cxx |   22 +++--
 3 files changed, 24 insertions(+), 48 deletions(-)

New commits:
commit 77b74fe9def6fa37d09600e81f9d88c3a3b4293b
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Sun Jul 27 02:13:34 2014 +0900

Avoid possible memory leaks in case of exceptions

Change-Id: I4c9d1746d43642e1be2dd1e72a1b689d3fae1ae6

diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index bf0f657..8d10cce 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -94,6 +94,7 @@
 #include com/sun/star/util/thePathSettings.hpp
 
 #include dlgname.hxx
+#include boost/scoped_ptr.hpp
 
 #define PRTSTR(x) OUStringToOString(x, RTL_TEXTENCODING_ASCII_US).pData-buffer
 
@@ -2403,7 +2404,7 @@ IMPL_LINK( SvxMenuConfigPage, MenuSelectHdl, MenuButton 
*, pButton )
 OUString aNewName( stripHotKey( pMenuData-GetName() ) );
 OUString aDesc = CUI_RESSTR( RID_SVXSTR_LABEL_NEW_NAME );
 
-SvxNameDialog* pNameDialog = new SvxNameDialog( this, aNewName, aDesc 
);
+boost::scoped_ptrSvxNameDialog pNameDialog(new SvxNameDialog( this, 
aNewName, aDesc ));
 pNameDialog-SetHelpId( HID_SVX_CONFIG_RENAME_MENU );
 pNameDialog-SetText( CUI_RESSTR( RID_SVXSTR_RENAME_MENU ) );
 
@@ -2415,17 +2416,14 @@ IMPL_LINK( SvxMenuConfigPage, MenuSelectHdl, MenuButton 
*, pButton )
 
 GetSaveInData()-SetModified( true );
 }
-
-// #i68101# Memory leak (!)
-delete pNameDialog;
 }
 else if (sIdent == move)
 {
 SvxConfigEntry* pMenuData = GetTopLevelSelection();
 
-SvxMainMenuOrganizerDialog* pDialog =
+boost::scoped_ptrSvxMainMenuOrganizerDialog pDialog(
 new SvxMainMenuOrganizerDialog( this,
-GetSaveInData()-GetEntries(), pMenuData );
+GetSaveInData()-GetEntries(), pMenuData ));
 
 if ( pDialog-Execute() == RET_OK )
 {
@@ -2435,8 +2433,6 @@ IMPL_LINK( SvxMenuConfigPage, MenuSelectHdl, MenuButton 
*, pButton )
 
 GetSaveInData()-SetModified( true );
 }
-
-delete pDialog;
 }
 else
 return sal_False;
@@ -2451,7 +2447,7 @@ IMPL_LINK( SvxMenuConfigPage, EntrySelectHdl, MenuButton 
*, pButton )
 OUString aNewName;
 OUString aDesc = CUI_RESSTR( RID_SVXSTR_SUBMENU_NAME );
 
-SvxNameDialog* pNameDialog = new SvxNameDialog( this, aNewName, aDesc 
);
+boost::scoped_ptrSvxNameDialog pNameDialog(new SvxNameDialog( this, 
aNewName, aDesc ));
 pNameDialog-SetHelpId( HID_SVX_CONFIG_NAME_SUBMENU );
 pNameDialog-SetText( CUI_RESSTR( RID_SVXSTR_ADD_SUBMENU ) );
 
@@ -2468,8 +2464,6 @@ IMPL_LINK( SvxMenuConfigPage, EntrySelectHdl, MenuButton 
*, pButton )
 
 GetSaveInData()-SetModified( true );
 }
-
-delete pNameDialog;
 }
 else if (sIdent == addseparator)
 {
@@ -2490,7 +2484,7 @@ IMPL_LINK( SvxMenuConfigPage, EntrySelectHdl, MenuButton 
*, pButton )
 OUString aNewName( stripHotKey( pEntry-GetName() ) );
 OUString aDesc = CUI_RESSTR( RID_SVXSTR_LABEL_NEW_NAME );
 
-SvxNameDialog* pNameDialog = new SvxNameDialog( this, aNewName, aDesc 
);
+boost::scoped_ptrSvxNameDialog pNameDialog(new SvxNameDialog( this, 
aNewName, aDesc ));
 pNameDialog-SetHelpId( HID_SVX_CONFIG_RENAME_MENU_ITEM );
 pNameDialog-SetText( CUI_RESSTR( RID_SVXSTR_RENAME_MENU ) );
 
@@ -2502,8 +2496,6 @@ IMPL_LINK( SvxMenuConfigPage, EntrySelectHdl, MenuButton 
*, pButton )
 
 GetSaveInData()-SetModified( true );
 }
-
-delete pNameDialog;
 }
 else
 {
@@ -2532,9 +2524,9 @@ IMPL_LINK( SvxMenuConfigPage, NewMenuHdl, Button *, 
pButton )
 {
 (void)pButton;
 
-SvxMainMenuOrganizerDialog* pDialog =
+boost::scoped_ptrSvxMainMenuOrganizerDialog pDialog(
 new SvxMainMenuOrganizerDialog( 0,
-GetSaveInData()-GetEntries(), NULL, true );
+GetSaveInData()-GetEntries(), NULL, true ));
 
 if ( pDialog-Execute() == RET_OK )
 {
@@ -2543,8 +2535,6 @@ IMPL_LINK( SvxMenuConfigPage, NewMenuHdl, Button *, 
pButton )
 GetSaveInData()-SetModified( true );
 }
 
-delete pDialog;
-
 return 0;
 }
 
@@ -3062,7 +3052,7 @@ IMPL_LINK( SvxToolbarConfigPage, ToolbarSelectHdl, 
MenuButton *, pButton )
 OUString aNewName( stripHotKey( pToolbar-GetName() ) );
 OUString aDesc = CUI_RESSTR( RID_SVXSTR_LABEL_NEW_NAME );
 
-SvxNameDialog* pNameDialog = new SvxNameDialog( this, aNewName, 
aDesc );
+boost::scoped_ptrSvxNameDialog pNameDialog(new SvxNameDialog( 
this, aNewName, aDesc ));
 pNameDialog-SetHelpId( HID_SVX_CONFIG_RENAME_TOOLBAR );
 pNameDialog-SetText( CUI_RESSTR( RID_SVXSTR_RENAME_TOOLBAR ) );
 
@@

Matthew Pottage license statement

2014-07-26 Thread Matthew Pottage

All of my past  future contributions to LibreOffice may be licensed under the 
MPLv2/LGPLv3+ dual license.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: writerfilter/source

2014-07-26 Thread Jeff Stedfast

 writerfilter/source/ooxml/OOXMLFactory.cxx|2 -
 writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |8 +
 writerfilter/source/ooxml/OOXMLPropertySetImpl.cxx|   28 ++
 writerfilter/source/ooxml/OOXMLPropertySetImpl.hxx|3 +
 4 files changed, 30 insertions(+), 11 deletions(-)

New commits:
commit b3d434a9701daab054981c891c645eefe1685b51
Author: Jeff Stedfast j...@xamarin.com
Date:   Sat Jul 26 13:51:59 2014 -0400

fdo#80908 - avoid lots of alloc/free of 2x boolean values.

Change-Id: I04c680813e997b98d8c1aae70953a61e5c28c4cd

diff --git a/writerfilter/source/ooxml/OOXMLFactory.cxx 
b/writerfilter/source/ooxml/OOXMLFactory.cxx
index eb5e4b4..7546096 100644
--- a/writerfilter/source/ooxml/OOXMLFactory.cxx
+++ b/writerfilter/source/ooxml/OOXMLFactory.cxx
@@ -149,7 +149,7 @@ void OOXMLFactory::attributes(OOXMLFastContextHandler * 
pHandler,
 {
 const char *pValue = ;
 pAttribs-getAsChar(nToken, pValue);
-OOXMLValue::Pointer_t xValue(new 
OOXMLBooleanValue(pValue));
+OOXMLValue::Pointer_t 
xValue(OOXMLBooleanValue::Create(pValue));
 pHandler-newProperty(nId, xValue);
 pFactory-attributeAction(pHandler, nToken, xValue);
 }
diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx 
b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
index c66d190..be6319f 100644
--- a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
+++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
@@ -1298,7 +1298,7 @@ void 
OOXMLFastContextHandlerValue::setDefaultBooleanValue()
 {
 if (mpValue.get() == NULL)
 {
-OOXMLValue::Pointer_t pValue(new OOXMLBooleanValue(true));
+OOXMLValue::Pointer_t pValue = OOXMLBooleanValue::Create(true);
 setValue(pValue);
 }
 }
@@ -1482,8 +1482,7 @@ void OOXMLFastContextHandlerTextTableCell::endCell()
 pProps-add(pProp);
 }
 {
-OOXMLValue::Pointer_t pVal
-(new OOXMLBooleanValue(mnTableDepth  0));
+OOXMLValue::Pointer_t pVal = 
OOXMLBooleanValue::Create(mnTableDepth  0);
 OOXMLProperty::Pointer_t pProp
 (new OOXMLPropertyImpl(NS_ooxml::LN_tblCell, pVal, 
OOXMLPropertyImpl::SPRM));
 pProps-add(pProp);
@@ -1582,8 +1581,7 @@ void 
OOXMLFastContextHandlerTextTableRow::handleGridBefore( OOXMLValue::Pointer_
 pProps-add(pProp);
 }
 {
-OOXMLValue::Pointer_t pVal
-(new OOXMLBooleanValue(mnTableDepth  0));
+OOXMLValue::Pointer_t pVal = 
OOXMLBooleanValue::Create(mnTableDepth  0);
 OOXMLProperty::Pointer_t pProp
 (new OOXMLPropertyImpl(NS_ooxml::LN_tblCell, pVal, 
OOXMLPropertyImpl::SPRM));
 pProps-add(pProp);
diff --git a/writerfilter/source/ooxml/OOXMLPropertySetImpl.cxx 
b/writerfilter/source/ooxml/OOXMLPropertySetImpl.cxx
index 4061de2..2589225 100644
--- a/writerfilter/source/ooxml/OOXMLPropertySetImpl.cxx
+++ b/writerfilter/source/ooxml/OOXMLPropertySetImpl.cxx
@@ -259,6 +259,28 @@ OOXMLValue * OOXMLBinaryValue::clone() const
   class OOXMLBooleanValue
 */
 
+static bool GetBooleanValue(const char *pValue)
+{
+return !strcmp(pValue, true)
+   || !strcmp(pValue, True)
+   || !strcmp(pValue, 1)
+   || !strcmp(pValue, on)
+   || !strcmp(pValue, On);
+}
+
+OOXMLValue::Pointer_t OOXMLBooleanValue::Create(bool bValue)
+{
+static OOXMLValue::Pointer_t False(new OOXMLBooleanValue (false));
+static OOXMLValue::Pointer_t True(new OOXMLBooleanValue (true));
+
+return bValue ? True : False;
+}
+
+OOXMLValue::Pointer_t OOXMLBooleanValue::Create(const char *pValue)
+{
+return Create (GetBooleanValue(pValue));
+}
+
 OOXMLBooleanValue::OOXMLBooleanValue(bool bValue)
 : mbValue(bValue)
 {
@@ -267,11 +289,7 @@ OOXMLBooleanValue::OOXMLBooleanValue(bool bValue)
 OOXMLBooleanValue::OOXMLBooleanValue(const char *pValue)
 : mbValue(false)
 {
-mbValue = !strcmp(pValue, true)
-   || !strcmp(pValue, True)
-   || !strcmp(pValue, 1)
-   || !strcmp(pValue, on)
-   || !strcmp(pValue, On);
+mbValue = GetBooleanValue(pValue);
 }
 
 OOXMLBooleanValue::~OOXMLBooleanValue()
diff --git a/writerfilter/source/ooxml/OOXMLPropertySetImpl.hxx 
b/writerfilter/source/ooxml/OOXMLPropertySetImpl.hxx
index 96197b6..bade784 100644
--- a/writerfilter/source/ooxml/OOXMLPropertySetImpl.hxx
+++ b/writerfilter/source/ooxml/OOXMLPropertySetImpl.hxx
@@ -104,6 +104,9 @@ class OOXMLBooleanValue : public OOXMLValue
 protected:
 bool mbValue;
 public:
+static OOXMLValue::Pointer_t Create (bool bValue);
+static OOXMLValue::Pointer_t Create (const char *pValue);
+
 explicit OOXMLBooleanValue(bool bValue);

[Libreoffice-commits] core.git: writerfilter/source

2014-07-26 Thread Jeffrey Stedfast

 writerfilter/source/ooxml/OOXMLFactory.cxx|4 -
 writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |   41 ++
 writerfilter/source/ooxml/OOXMLFastHelper.hxx |2 
 writerfilter/source/ooxml/OOXMLPropertySetImpl.cxx|   32 ++
 writerfilter/source/ooxml/OOXMLPropertySetImpl.hxx|7 +--
 5 files changed, 54 insertions(+), 32 deletions(-)

New commits:
commit 84aa4d1ff29004b0aa28068b7beb21f7ebfdb239
Author: Jeffrey Stedfast j...@xamarin.com
Date:   Sat Jul 26 15:56:45 2014 -0400

fdo#80908 - avoid lots of alloc/free of common integer values.

Change-Id: Ie170d44af062ec8c8b412b7de271e96a106971aa
Reviewed-on: https://gerrit.libreoffice.org/10559
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com

diff --git a/writerfilter/source/ooxml/OOXMLFactory.cxx 
b/writerfilter/source/ooxml/OOXMLFactory.cxx
index 7546096..2e73930 100644
--- a/writerfilter/source/ooxml/OOXMLFactory.cxx
+++ b/writerfilter/source/ooxml/OOXMLFactory.cxx
@@ -166,7 +166,7 @@ void OOXMLFactory::attributes(OOXMLFastContextHandler * 
pHandler,
 {
 sal_Int32 nValue;
 pAttribs-getAsInteger(nToken,nValue);
-OOXMLValue::Pointer_t xValue(new 
OOXMLIntegerValue(nValue));
+OOXMLValue::Pointer_t xValue = 
OOXMLIntegerValue::Create(nValue);
 pHandler-newProperty(nId, xValue);
 pFactory-attributeAction(pHandler, nToken, xValue);
 }
@@ -198,7 +198,7 @@ void OOXMLFactory::attributes(OOXMLFastContextHandler * 
pHandler,
 {
 OUString aValue(Attribs-getValue(nToken));
 sal_uInt32 nValue = (*pListValueMap)[aValue];
-OOXMLValue::Pointer_t xValue(new 
OOXMLIntegerValue(nValue));
+OOXMLValue::Pointer_t xValue = 
OOXMLIntegerValue::Create(nValue);
 pHandler-newProperty(nId, xValue);
 pFactory-attributeAction(pHandler, nToken, 
xValue);
 }
diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx 
b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
index be6319f..4e85d64 100644
--- a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
+++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
@@ -452,15 +452,13 @@ void OOXMLFastContextHandler::sendTableDepth() const
 {
 OOXMLPropertySet * pProps = new OOXMLPropertySetImpl();
 {
-OOXMLValue::Pointer_t pVal
-(new OOXMLIntegerValue(mnTableDepth));
+OOXMLValue::Pointer_t pVal = 
OOXMLIntegerValue::Create(mnTableDepth);
 OOXMLProperty::Pointer_t pProp
 (new OOXMLPropertyImpl(NS_ooxml::LN_tblDepth, pVal, 
OOXMLPropertyImpl::SPRM));
 pProps-add(pProp);
 }
 {
-OOXMLValue::Pointer_t pVal
-(new OOXMLIntegerValue(1));
+OOXMLValue::Pointer_t pVal = OOXMLIntegerValue::Create(1);
 OOXMLProperty::Pointer_t pProp
 (new OOXMLPropertyImpl(NS_ooxml::LN_inTbl, pVal, 
OOXMLPropertyImpl::SPRM));
 pProps-add(pProp);
@@ -540,7 +538,7 @@ void OOXMLFastContextHandler::endParagraphGroup()
 void OOXMLFastContextHandler::startSdt()
 {
 OOXMLPropertySet * pProps = new OOXMLPropertySetImpl();
-OOXMLValue::Pointer_t pVal(new OOXMLIntegerValue(1));
+OOXMLValue::Pointer_t pVal = OOXMLIntegerValue::Create(1);
 OOXMLProperty::Pointer_t pProp(new 
OOXMLPropertyImpl(NS_ooxml::LN_CT_SdtBlock_sdtContent, pVal, 
OOXMLPropertyImpl::ATTRIBUTE));
 pProps-add(pProp);
 mpStream-props(writerfilter::ReferenceProperties::Pointer_t(pProps));
@@ -549,7 +547,7 @@ void OOXMLFastContextHandler::startSdt()
 void OOXMLFastContextHandler::endSdt()
 {
 OOXMLPropertySet * pProps = new OOXMLPropertySetImpl();
-OOXMLValue::Pointer_t pVal(new OOXMLIntegerValue(1));
+OOXMLValue::Pointer_t pVal = OOXMLIntegerValue::Create(1);
 OOXMLProperty::Pointer_t pProp(new 
OOXMLPropertyImpl(NS_ooxml::LN_CT_SdtBlock_sdtEndContent, pVal, 
OOXMLPropertyImpl::ATTRIBUTE));
 pProps-add(pProp);
 mpStream-props(writerfilter::ReferenceProperties::Pointer_t(pProps));
@@ -1307,7 +1305,7 @@ void 
OOXMLFastContextHandlerValue::setDefaultIntegerValue()
 {
 if (mpValue.get() == NULL)
 {
-OOXMLValue::Pointer_t pValue(new OOXMLIntegerValue(0));
+OOXMLValue::Pointer_t pValue = OOXMLIntegerValue::Create(0);
 setValue(pValue);
 }
 }
@@ -1468,15 +1466,13 @@ void OOXMLFastContextHandlerTextTableCell::endCell()
 {
 OOXMLPropertySet * pProps = new OOXMLPropertySetImpl();
 {
-OOXMLValue::Pointer_t pVal
-(new OOXMLIntegerValue(mnTableDepth));

[Libreoffice-commits] core.git: 3 commits - chart2/inc chart2/Library_chartcontroller.mk chart2/source include/oox include/xmloff oox/source xmloff/source

2014-07-26 Thread Kohei Yoshida

 chart2/Library_chartcontroller.mk   |1 
 chart2/inc/unonames.hxx |7 
 chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx |   35 
 chart2/source/controller/dialogs/dlg_ObjectProperties.cxx   |1 
 chart2/source/controller/inc/TextLabelItemConverter.hxx |   73 +
 chart2/source/controller/itemsetwrapper/SchWhichPairs.hxx   |   16 
 chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx  |  615 
++
 chart2/source/controller/main/ChartController_Properties.cxx|   32 
 chart2/source/model/main/DataPointProperties.cxx|   93 +
 chart2/source/model/main/DataPointProperties.hxx|   14 
 chart2/source/view/inc/PropertyMapper.hxx   |1 
 chart2/source/view/main/PropertyMapper.cxx  |   21 
 include/oox/export/chartexport.hxx  |4 
 include/oox/export/utils.hxx|1 
 include/xmloff/xmltoken.hxx |4 
 oox/source/drawingml/chart/seriesconverter.cxx  |   28 
 oox/source/export/chartexport.cxx   |  219 +--
 oox/source/token/properties.txt |3 
 xmloff/source/chart/PropertyMap.hxx |7 
 xmloff/source/chart/PropertyMaps.cxx|   21 
 xmloff/source/core/xmltoken.cxx |4 
 21 files changed, 1029 insertions(+), 171 deletions(-)

New commits:
commit 6c2c974dd3f0b21a23bc3bc5560487d28bbe0fad
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Sat Jul 26 14:44:38 2014 -0400

bnc#885825: Handle ODF import and export of data label border properties.

Change-Id: Ic8c7bc873768008537cd52a3fd4b11031b403139

diff --git 
a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
index e69042b..a897eb7 100644
--- a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
@@ -80,7 +80,11 @@ enum
 PROP_SERIES_DATAPOINT_LABEL_PLACEMENT,
 //other series properties
 PROP_SERIES_ATTACHED_AXIS,
-PROP_SERIES_DATAPOINT_TEXT_ROTATION
+PROP_SERIES_DATAPOINT_TEXT_ROTATION,
+PROP_SERIES_DATAPOINT_LABEL_BORDER_STYLE,
+PROP_SERIES_DATAPOINT_LABEL_BORDER_WIDTH,
+PROP_SERIES_DATAPOINT_LABEL_BORDER_COLOR,
+PROP_SERIES_DATAPOINT_LABEL_BORDER_TRANS
 };
 
 void lcl_AddPropertiesToVector_PointProperties(
@@ -142,6 +146,35 @@ void lcl_AddPropertiesToVector_PointProperties(
   cppu::UnoTypesal_Int32::get(),
   beans::PropertyAttribute::BOUND
   | beans::PropertyAttribute::MAYBEDEFAULT ));
+
+rOutProperties.push_back(
+Property( CHART_UNONAME_LABEL_BORDER_STYLE,
+  PROP_SERIES_DATAPOINT_LABEL_BORDER_STYLE,
+  cppu::UnoTypedrawing::LineStyle::get(),
+  beans::PropertyAttribute::BOUND
+  | beans::PropertyAttribute::MAYBEDEFAULT ));
+
+rOutProperties.push_back(
+Property( CHART_UNONAME_LABEL_BORDER_WIDTH,
+  PROP_SERIES_DATAPOINT_LABEL_BORDER_WIDTH,
+  cppu::UnoTypesal_Int32::get(),
+  beans::PropertyAttribute::BOUND
+  | beans::PropertyAttribute::MAYBEDEFAULT ));
+
+rOutProperties.push_back(
+Property( CHART_UNONAME_LABEL_BORDER_COLOR,
+  PROP_SERIES_DATAPOINT_LABEL_BORDER_COLOR,
+  cppu::UnoTypesal_Int32::get(),
+  beans::PropertyAttribute::BOUND
+  | beans::PropertyAttribute::MAYBEVOID // maybe auto
+  | beans::PropertyAttribute::MAYBEDEFAULT ));
+
+rOutProperties.push_back(
+Property( CHART_UNONAME_LABEL_BORDER_TRANS,
+  PROP_SERIES_DATAPOINT_LABEL_BORDER_TRANS,
+  cppu::UnoTypesal_Int16::get(),
+  beans::PropertyAttribute::BOUND
+  | beans::PropertyAttribute::MAYBEDEFAULT ));
 }
 
 void lcl_AddPropertiesToVector_SeriesOnly(
diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx
index 9e206d8..e03dcfd 100644
--- a/include/xmloff/xmltoken.hxx
+++ b/include/xmloff/xmltoken.hxx
@@ -1067,6 +1067,10 @@ namespace xmloff { namespace token {
 XML_LABEL_RANGE,
 XML_LABEL_RANGES,
 XML_LABEL_STRING,
+XML_LABEL_STROKE,
+XML_LABEL_STROKE_COLOR,
+XML_LABEL_STROKE_OPACITY,
+XML_LABEL_STROKE_WIDTH,
 XML_LAMBDA,
 XML_LANDSCAPE,
 XML_LANGUAGE,
diff --git a/xmloff/source/chart/PropertyMap.hxx 
b/xmloff/source/chart/PropertyMap.hxx
index

[Libreoffice-commits] core.git: 14 commits - connectivity/source cui/source framework/source package/source sc/source sd/source sw/source vcl/source writerfilter/source

 connectivity/source/drivers/dbase/DTable.cxx|   15 +--
 connectivity/source/drivers/firebird/Util.cxx   |   16 +++-
 cui/source/dialogs/hangulhanjadlg.cxx   |   13 -
 cui/source/inc/hangulhanjadlg.hxx   |2 +-
 framework/source/layoutmanager/toolbarlayoutmanager.cxx |2 +-
 package/source/zippackage/zipfileaccess.cxx |   14 +-
 sc/source/ui/drawfunc/fusel.cxx |2 +-
 sc/source/ui/miscdlgs/conflictsdlg.cxx  |2 +-
 sd/source/ui/func/fucopy.cxx|   16 
 sd/source/ui/func/fupage.cxx|2 +-
 sd/source/ui/func/futempl.cxx   |4 ++--
 sw/source/core/attr/format.cxx  |3 ++-
 sw/source/core/doc/CntntIdxStore.cxx|2 +-
 vcl/source/outdev/map.cxx   |8 
 writerfilter/source/dmapper/PropertyMap.cxx |2 +-
 15 files changed, 72 insertions(+), 31 deletions(-)

New commits:
commit 5b40565e6a47b8f3a655d1c10adc61b71de29d6b
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Sat Jul 26 21:23:08 2014 +0100

coverity#706594 Uncaught exception

Change-Id: Iad8f124706789299f36127f0d0fd0a47db07bace

diff --git a/package/source/zippackage/zipfileaccess.cxx 
b/package/source/zippackage/zipfileaccess.cxx
index a660d3e..688f389 100644
--- a/package/source/zippackage/zipfileaccess.cxx
+++ b/package/source/zippackage/zipfileaccess.cxx
@@ -252,7 +252,19 @@ uno::Any SAL_CALL OZipFileAccess::getByName( const 
OUString aName )
   false,
   m_aMutexHolder);
 }
-catch (const io::IOException e)
+catch (const container::NoSuchElementException)
+{
+throw;
+}
+catch (const lang::WrappedTargetException)
+{
+throw;
+}
+catch (const uno::RuntimeException)
+{
+throw;
+}
+catch (const uno::Exception e)
 {
 throw lang::WrappedTargetException( This package is unusable!,
   static_cast  OWeakObject *  ( this ),
commit 6b5fb7ef6ab6e3bf555fa707f53e68dd07da9125
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Sat Jul 26 21:18:12 2014 +0100

coverity#706301 Uncaught exception

Change-Id: I6c81df21c7c8713e3d409fb9418e6d6bcca48d68

diff --git a/connectivity/source/drivers/dbase/DTable.cxx 
b/connectivity/source/drivers/dbase/DTable.cxx
index b408f39..5d04f13 100644
--- a/connectivity/source/drivers/dbase/DTable.cxx
+++ b/connectivity/source/drivers/dbase/DTable.cxx
@@ -1102,8 +1102,19 @@ bool ODbaseTable::CreateImpl()
 if (!CreateMemoFile(aURL))
 {
 aURL.setExtension(aExt);  // kill dbf file
-Content 
aMemoContent(aURL.GetMainURL(INetURLObject::NO_DECODE),ReferenceXCommandEnvironment(),
 comphelper::getProcessComponentContext());
-aMemoContent.executeCommand( delete, css::uno::Any( true ) );
+try
+{
+Content 
aMemoContent(aURL.GetMainURL(INetURLObject::NO_DECODE),ReferenceXCommandEnvironment(),
 comphelper::getProcessComponentContext());
+aMemoContent.executeCommand( delete, css::uno::Any( true ) );
+}
+catch(const ContentCreationException)
+{
+const OUString sError( 
getConnection()-getResources().getResourceStringWithSubstitution(
+STR_COULD_NOT_DELETE_FILE,
+$name$, aName
+ ) );
+::dbtools::throwGenericSQLException( sError, *this );
+}
 return false;
 }
 m_aHeader.db_typ = dBaseIIIMemo;
commit b418b70f0b168ca03242106d669d3c305ea151fc
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Sat Jul 26 21:16:21 2014 +0100

coverity#704848 Dereference after null check

Change-Id: I1e0cc28ca52ebabb680d59e3a693a6cefd2e2f9a

diff --git a/sw/source/core/attr/format.cxx b/sw/source/core/attr/format.cxx
index 54ececf..ddd183e 100644
--- a/sw/source/core/attr/format.cxx
+++ b/sw/source/core/attr/format.cxx
@@ -304,7 +304,8 @@ void SwFmt::Modify( const SfxPoolItem* pOldValue, const 
SfxPoolItem* pNewValue )
 // the new one
 
 // skip my own Modify
-if( ((SwFmtChg*)pOldValue)-pChangedFmt != this 
+if ( pOldValue  pNewValue 
+((SwFmtChg*)pOldValue)-pChangedFmt != this 
 ((SwFmtChg*)pNewValue)-pChangedFmt == DerivedFrom() )
 {
 // attach Set to new parent
commit 7ce763089b221cd603bba70054e6efb5bdeecbf4
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Sat Jul 26 21:13:21 2014 +0100

coverity#704759 Dereference after null check

Change-Id: I1f41d2bc43391175a4587f501f02775adc43bc8e

diff --git

[Libreoffice-commits] core.git: sfx2/source

2014-07-26 Thread Jeffrey Stedfast

 sfx2/source/menu/mnumgr.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 3f8e114bae8bb3ef45a08ced3434e7a9669ed4f9
Author: Jeffrey Stedfast j...@xamarin.com
Date:   Sat Jul 26 17:31:20 2014 -0400

fdo#71770 Fixed Cut/Copy/Paste popup menu items to appear at the top

Change-Id: I14b3ad87536b2cf7e2e21ba00cb2afa18c2c95a3
Reviewed-on: https://gerrit.libreoffice.org/10564
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com

diff --git a/sfx2/source/menu/mnumgr.cxx b/sfx2/source/menu/mnumgr.cxx
index b2cbdce..6f2f5db 100644
--- a/sfx2/source/menu/mnumgr.cxx
+++ b/sfx2/source/menu/mnumgr.cxx
@@ -298,13 +298,13 @@ SfxPopupMenuManager* SfxPopupMenuManager::Popup( const 
ResId rResId, SfxViewFra
 {
 PopupMenu aPop( SfxResId( MN_CLIPBOARDFUNCS ) );
 nCount = aPop.GetItemCount();
-pSVMenu-InsertSeparator();
 for ( n=0; nnCount; n++ )
 {
 sal_uInt16 nId = aPop.GetItemId( n );
-pSVMenu-InsertItem( nId, aPop.GetItemText( nId ), 
aPop.GetItemBits( nId ) );
+pSVMenu-InsertItem( nId, aPop.GetItemText( nId ), 
aPop.GetItemBits( nId ), OString(), n );
 pSVMenu-SetHelpId( nId, aPop.GetHelpId( nId ));
 }
+pSVMenu-InsertSeparator( OString(), n );
 }
 
 InsertVerbs_Impl( pFrame-GetBindings(), 
pFrame-GetViewShell()-GetVerbs(), pSVMenu );
@@ -348,13 +348,13 @@ void SfxPopupMenuManager::ExecutePopup( const ResId 
rResId, SfxViewFrame* pFram
 {
 PopupMenu aPop( SfxResId( MN_CLIPBOARDFUNCS ) );
 nCount = aPop.GetItemCount();
-pSVMenu-InsertSeparator();
 for ( n=0; nnCount; n++ )
 {
 sal_uInt16 nId = aPop.GetItemId( n );
-pSVMenu-InsertItem( nId, aPop.GetItemText( nId ), 
aPop.GetItemBits( nId ) );
+pSVMenu-InsertItem( nId, aPop.GetItemText( nId ), 
aPop.GetItemBits( nId ), OString(), n );
 pSVMenu-SetHelpId( nId, aPop.GetHelpId( nId ));
 }
+pSVMenu-InsertSeparator( OString(), n );
 }
 
 InsertVerbs_Impl( pFrame-GetBindings(), 
pFrame-GetViewShell()-GetVerbs(), pSVMenu );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 39428] audit / remove SvStream long operators

https://bugs.freedesktop.org/show_bug.cgi?id=39428

Michael Meeks michael.me...@collabora.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
 CC||noelgran...@gmail.com

--- Comment #18 from Michael Meeks michael.me...@collabora.com ---
Noel kindly nailed this in: 16a2e903356520c90a9bf91c47265f79be12e74a

Awesome work - thanks for that ! = closing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 60698] kill pointless one-file library ...

https://bugs.freedesktop.org/show_bug.cgi?id=60698

Michael Meeks michael.me...@collabora.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #25 from Michael Meeks michael.me...@collabora.com ---
The original single file library is now fixed - closing the Easy Hack =)
Thanks for the great work !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - 3 commits - chart2/inc chart2/Library_chartcontroller.mk chart2/source include/oox include/xmloff oox/source xmloff/source

2014-07-26 Thread Kohei Yoshida

 chart2/Library_chartcontroller.mk   |1 
 chart2/inc/unonames.hxx |   33 
 chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx |   37 
 chart2/source/controller/dialogs/dlg_ObjectProperties.cxx   |1 
 chart2/source/controller/inc/TextLabelItemConverter.hxx |   74 +
 chart2/source/controller/itemsetwrapper/SchWhichPairs.hxx   |   16 
 chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx  |  617 
++
 chart2/source/controller/main/ChartController_Properties.cxx|   32 
 chart2/source/model/main/DataPointProperties.cxx|   66 -
 chart2/source/model/main/DataPointProperties.hxx|   14 
 chart2/source/view/inc/PropertyMapper.hxx   |1 
 chart2/source/view/main/PropertyMapper.cxx  |   21 
 include/oox/export/chartexport.hxx  |4 
 include/oox/export/utils.hxx|1 
 include/xmloff/xmltoken.hxx |4 
 oox/source/drawingml/chart/seriesconverter.cxx  |   31 
 oox/source/export/chartexport.cxx   |  198 +--
 oox/source/token/properties.txt |3 
 xmloff/source/chart/PropertyMap.hxx |8 
 xmloff/source/chart/PropertyMaps.cxx|   21 
 xmloff/source/core/xmltoken.cxx |4 
 21 files changed, 1051 insertions(+), 136 deletions(-)

New commits:
commit aaa18a45c6f5e4f2b5fb1ee2deee510ea3353053
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Sat Jul 26 14:44:38 2014 -0400

bnc#885825: Handle ODF import and export of data label border properties.

(cherry picked from commit 6c2c974dd3f0b21a23bc3bc5560487d28bbe0fad)

Conflicts:
include/xmloff/xmltoken.hxx
xmloff/source/chart/PropertyMap.hxx
xmloff/source/core/xmltoken.cxx

Change-Id: Ic8c7bc873768008537cd52a3fd4b11031b403139

diff --git 
a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
index 7bad448..5aec6bf 100644
--- a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
@@ -80,7 +80,11 @@ enum
 PROP_SERIES_DATAPOINT_LABEL_PLACEMENT,
 //other series properties
 PROP_SERIES_ATTACHED_AXIS,
-PROP_SERIES_DATAPOINT_TEXT_ROTATION
+PROP_SERIES_DATAPOINT_TEXT_ROTATION,
+PROP_SERIES_DATAPOINT_LABEL_BORDER_STYLE,
+PROP_SERIES_DATAPOINT_LABEL_BORDER_WIDTH,
+PROP_SERIES_DATAPOINT_LABEL_BORDER_COLOR,
+PROP_SERIES_DATAPOINT_LABEL_BORDER_TRANS
 };
 
 void lcl_AddPropertiesToVector_PointProperties(
@@ -142,6 +146,35 @@ void lcl_AddPropertiesToVector_PointProperties(
   ::getCppuType( reinterpret_cast const sal_Int32 * (0)),
   beans::PropertyAttribute::BOUND
   | beans::PropertyAttribute::MAYBEDEFAULT ));
+
+rOutProperties.push_back(
+Property( CHART_UNONAME_LABEL_BORDER_STYLE,
+  PROP_SERIES_DATAPOINT_LABEL_BORDER_STYLE,
+  cppu::UnoTypedrawing::LineStyle::get(),
+  beans::PropertyAttribute::BOUND
+  | beans::PropertyAttribute::MAYBEDEFAULT ));
+
+rOutProperties.push_back(
+Property( CHART_UNONAME_LABEL_BORDER_WIDTH,
+  PROP_SERIES_DATAPOINT_LABEL_BORDER_WIDTH,
+  cppu::UnoTypesal_Int32::get(),
+  beans::PropertyAttribute::BOUND
+  | beans::PropertyAttribute::MAYBEDEFAULT ));
+
+rOutProperties.push_back(
+Property( CHART_UNONAME_LABEL_BORDER_COLOR,
+  PROP_SERIES_DATAPOINT_LABEL_BORDER_COLOR,
+  cppu::UnoTypesal_Int32::get(),
+  beans::PropertyAttribute::BOUND
+  | beans::PropertyAttribute::MAYBEVOID // maybe auto
+  | beans::PropertyAttribute::MAYBEDEFAULT ));
+
+rOutProperties.push_back(
+Property( CHART_UNONAME_LABEL_BORDER_TRANS,
+  PROP_SERIES_DATAPOINT_LABEL_BORDER_TRANS,
+  cppu::UnoTypesal_Int16::get(),
+  beans::PropertyAttribute::BOUND
+  | beans::PropertyAttribute::MAYBEDEFAULT ));
 }
 
 void lcl_AddPropertiesToVector_SeriesOnly(
diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx
index 09bc908..6dd7d1c 100644
--- a/include/xmloff/xmltoken.hxx
+++ b/include/xmloff/xmltoken.hxx
@@ -1063,6 +1063,10 @@ namespace xmloff { namespace token {
 XML_LABEL_CELL_RANGE_ADDRESS,
 XML_LABEL_RANGE,
 XML_LABEL_RANGES,
+XML_LABEL_STROKE,
+

[Bug 45408] use new gdk_screen_get_monitor_workarea method ...

https://bugs.freedesktop.org/show_bug.cgi?id=45408

Martin Owens docto...@gmail.com changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Martin Owens docto...@gmail.com ---
The code appears to have moved and now exists here:

vcl/unx/gtk/window/gtksalframe.cxx:2105

The code appears to take account of gtk3 and it may already be fixed. 

For gtk2 we have a dummy 1024x768 rect being returned with a warning. Is the
gtk2 implementation the problem or has it been fixed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: chart2/qa

2014-07-26 Thread Kohei Yoshida

 chart2/qa/extras/chart2export.cxx  |  103 +
 chart2/qa/extras/data/docx/data-label-borders.docx |binary
 2 files changed, 103 insertions(+)

New commits:
commit c2fd8c4492e9eb12375f78ceb188c87d8fac41b7
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Sat Jul 26 23:07:47 2014 -0400

bnc#885825: Write test for this.

Originally it was a pptx document, but switched to docx because reloading
an impress document in cppunit currently mysteriously crashes.

Change-Id: I3e9ba6b9a4dc7d3c0ca1d59a073dc8a4cca4008c

diff --git a/chart2/qa/extras/chart2export.cxx 
b/chart2/qa/extras/chart2export.cxx
index b92e565..0c31f22 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -17,6 +17,7 @@
 #include com/sun/star/packages/zip/ZipFileAccess.hpp
 #include com/sun/star/text/XTextDocument.hpp
 #include com/sun/star/text/XTextFramesSupplier.hpp
+#include com/sun/star/drawing/LineStyle.hpp
 
 #include unotools/ucbstreamhelper.hxx
 #include rtl/strbuf.hxx
@@ -68,6 +69,7 @@ public:
 void testFdo78290ScatterChartMarkerX();
 void testFdo78290CombinationChartMarkerX();
 void testAxisNumberFormatODS();
+void testDataLabelBordersDOCX();
 
 CPPUNIT_TEST_SUITE(Chart2ExportTest);
 CPPUNIT_TEST(test);
@@ -102,6 +104,7 @@ public:
 CPPUNIT_TEST(testFdo78290ScatterChartMarkerX);
 CPPUNIT_TEST(testFdo78290CombinationChartMarkerX);
 CPPUNIT_TEST(testAxisNumberFormatODS);
+CPPUNIT_TEST(testDataLabelBordersDOCX);
 CPPUNIT_TEST_SUITE_END();
 
 protected:
@@ -688,6 +691,106 @@ void Chart2ExportTest::testAxisNumberFormatODS()
 aTest.check(xChartDoc);
 }
 
+void Chart2ExportTest::testDataLabelBordersDOCX()
+{
+struct Check
+{
+sal_Int32 mnIndex;
+css::drawing::LineStyle meStyle;
+sal_Int32 mnColor;
+};
+
+struct
+{
+/**
+ * Chart 1 has 4 bars of which 1st and 3rd have labels with borders
+ * around them.
+ */
+void checkObject1( const Referencechart2::XChartDocument xChartDoc )
+{
+CPPUNIT_ASSERT(xChartDoc.is());
+
+Referencechart2::XDataSeries xDataSeries = 
getDataSeriesFromDoc(xChartDoc, 0);
+CPPUNIT_ASSERT(xDataSeries.is());
+
+// Check to make sure that data points 0 and 2 have local 
properties.
+Referencebeans::XPropertySet xPropSet(xDataSeries, 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xPropSet.is());
+
+Sequencesal_Int32 aIndices;
+xPropSet-getPropertyValue(AttributedDataPoints) = aIndices;
+CPPUNIT_ASSERT_MESSAGE(There should be 2 data points with local 
properties., aIndices.getLength() == 2);
+CPPUNIT_ASSERT(aIndices[0] == 0);
+CPPUNIT_ASSERT(aIndices[1] == 2);
+
+const Check aDataPoints[] =
+{
+{ 0, css::drawing::LineStyle_SOLID, 0x0000 }, // solid 
yellow
+{ 2, css::drawing::LineStyle_SOLID, 0x00FF }  // solid red
+};
+
+for (size_t i = 0, n = SAL_N_ELEMENTS(aDataPoints); i  n; ++i)
+{
+xPropSet = 
xDataSeries-getDataPointByIndex(aDataPoints[i].mnIndex);
+CPPUNIT_ASSERT(xPropSet.is());
+
+css::drawing::LineStyle eLineStyle = 
css::drawing::LineStyle_NONE;
+xPropSet-getPropertyValue(CHART_UNONAME_LABEL_BORDER_STYLE) 
= eLineStyle;
+CPPUNIT_ASSERT(eLineStyle == aDataPoints[i].meStyle);
+
+sal_Int32 nWidth = -1;
+xPropSet-getPropertyValue(CHART_UNONAME_LABEL_BORDER_WIDTH) 
= nWidth;
+CPPUNIT_ASSERT(nWidth  0);
+
+sal_Int32 nColor = -1;
+xPropSet-getPropertyValue(CHART_UNONAME_LABEL_BORDER_COLOR) 
= nColor;
+CPPUNIT_ASSERT_MESSAGE(Border color is wrong., nColor == 
aDataPoints[i].mnColor);
+}
+}
+
+/**
+ * Chart 2 has all its data labels with identical borders.
+ */
+void checkObject2( const Referencechart2::XChartDocument xChartDoc )
+{
+CPPUNIT_ASSERT(xChartDoc.is());
+
+Referencechart2::XDataSeries xDataSeries = 
getDataSeriesFromDoc(xChartDoc, 0);
+CPPUNIT_ASSERT(xDataSeries.is());
+
+Referencebeans::XPropertySet xPropSet(xDataSeries, 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xPropSet.is());
+
+css::drawing::LineStyle eLineStyle = css::drawing::LineStyle_NONE;
+xPropSet-getPropertyValue(CHART_UNONAME_LABEL_BORDER_STYLE) = 
eLineStyle;
+CPPUNIT_ASSERT(eLineStyle == css::drawing::LineStyle_SOLID);
+
+sal_Int32 nWidth = -1;
+xPropSet-getPropertyValue(CHART_UNONAME_LABEL_BORDER_WIDTH) = 
nWidth;
+CPPUNIT_ASSERT(nWidth  0);
+
+sal_Int32 nColor = -1;
+

[Libreoffice-commits] core.git: sw/uiconfig

2014-07-26 Thread Martin Owens

 sw/uiconfig/swriter/toolbar/previewobjectbar.xml |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 70599252873c3dbe03e36083ad093aedfdb8b923
Author: Martin Owens docto...@gmail.com
Date:   Sun Jul 27 03:26:32 2014 +

fdo#30425 - button should be print, not print preview

Change-Id: I1b72fcc9d2134b9fb089db307d42d317017f4089

diff --git a/sw/uiconfig/swriter/toolbar/previewobjectbar.xml 
b/sw/uiconfig/swriter/toolbar/previewobjectbar.xml
index 9a1e05f..e50a23c 100644
--- a/sw/uiconfig/swriter/toolbar/previewobjectbar.xml
+++ b/sw/uiconfig/swriter/toolbar/previewobjectbar.xml
@@ -36,7 +36,7 @@
  toolbar:toolbaritem xlink:href=.uno:ZoomMinus toolbar:helpid=10098/
  toolbar:toolbarseparator/
  toolbar:toolbaritem xlink:href=.uno:FullScreen toolbar:helpid=5627/
- toolbar:toolbaritem xlink:href=.uno:PrintPagePreview 
toolbar:helpid=21253/
+ toolbar:toolbaritem xlink:href=.uno:Print toolbar:helpid=21253/
  toolbar:toolbarseparator/
  toolbar:toolbaritem xlink:href=.uno:ClosePreview toolbar:helpid=5325/
 /toolbar:toolbar
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 30425] Making Icon Themes is Far too Difficult

https://bugs.freedesktop.org/show_bug.cgi?id=30425

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner
   |SkillScript TopicUi |SkillScript TopicUi
   ||target:4.4.0

--- Comment #9 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Martin Owens committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=70599252873c3dbe03e36083ad093aedfdb8b923

fdo#30425 - button should be print, not print preview



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Copyright Statement

2014-07-26 Thread Martin Owens

All of my past  future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: formula/source include/formula

2014-07-26 Thread Jeffrey Stedfast

 formula/source/core/api/token.cxx |   66 +-
 include/formula/tokenarray.hxx|   24 ++---
 2 files changed, 43 insertions(+), 47 deletions(-)

New commits:
commit ce4e7a830d5350848d3c83b872f916a7b1691266
Author: Jeffrey Stedfast j...@xamarin.com
Date:   Sat Jul 26 21:25:38 2014 -0400

fdo#81038 Fixed FormulaTokenIterator to use std::vector instead of linked 
list

Change-Id: I09f9adfa52b64732cc6200a0dbeb6263435c7c07
Reviewed-on: https://gerrit.libreoffice.org/10565
Reviewed-by: Kohei Yoshida libreoff...@kohei.us
Tested-by: Kohei Yoshida libreoff...@kohei.us

diff --git a/formula/source/core/api/token.cxx 
b/formula/source/core/api/token.cxx
index 0dd8d5c..3e37c28 100644
--- a/formula/source/core/api/token.cxx
+++ b/formula/source/core/api/token.cxx
@@ -35,9 +35,6 @@
 namespace formula
 {
 using namespace com::sun::star;
-// ImpTokenIterator wird je Interpreter angelegt, mehrfache auch durch
-// SubCode via FormulaTokenIterator Push/Pop moeglich
-IMPL_FIXEDMEMPOOL_NEWDEL( ImpTokenIterator )
 
 // Align MemPools on 4k boundaries - 64 bytes (4k is a MUST for OS/2)
 
@@ -1285,49 +1282,46 @@ FormulaToken* FormulaTokenArray::AddOpCode( OpCode eOp )
 
 /*--*/
 
+FormulaTokenIterator::Item::Item(const FormulaTokenArray* pArray, short pc, 
short stop) :
+pArr(pArray), nPC(pc), nStop(stop)
+{
+}
+
 FormulaTokenIterator::FormulaTokenIterator( const FormulaTokenArray rArr )
 {
-pCur = NULL;
+maStack = new std::vectorFormulaTokenIterator::Item ();
 Push( rArr );
 }
 
 FormulaTokenIterator::~FormulaTokenIterator()
 {
-while( pCur )
-Pop();
+delete maStack;
 }
 
 void FormulaTokenIterator::Push( const FormulaTokenArray* pArr )
 {
-ImpTokenIterator* p = new ImpTokenIterator;
-p-pArr  = pArr;
-p-nPC   = -1;
-p-nStop = SHRT_MAX;
-p-pNext = pCur;
-pCur = p;
+FormulaTokenIterator::Item item(pArr, -1, SHRT_MAX);
+
+maStack-push_back(item);
 }
 
 void FormulaTokenIterator::Pop()
 {
-ImpTokenIterator* p = pCur;
-if( p )
-{
-pCur = p-pNext;
-delete p;
-}
+maStack-pop_back();
 }
 
 void FormulaTokenIterator::Reset()
 {
-while( pCur-pNext )
-Pop();
-pCur-nPC = -1;
+while( maStack-size()  1 )
+maStack-pop_back();
+
+maStack-back().nPC = -1;
 }
 
 const FormulaToken* FormulaTokenIterator::Next()
 {
-const FormulaToken* t = GetNonEndOfPathToken( ++pCur-nPC );
-if( !t  pCur-pNext )
+const FormulaToken* t = GetNonEndOfPathToken( ++maStack-back().nPC );
+if( !t  maStack-size()  1 )
 {
 Pop();
 t = Next();
@@ -1338,18 +1332,18 @@ const FormulaToken* FormulaTokenIterator::Next()
 const FormulaToken* FormulaTokenIterator::PeekNextOperator()
 {
 const FormulaToken* t = NULL;
-short nIdx = pCur-nPC;
+short nIdx = maStack-back().nPC;
 while (!t  ((t = GetNonEndOfPathToken( ++nIdx)) != NULL))
 {
 if (t-GetOpCode() == ocPush)
 t = NULL;   // ignore operands
 }
-if (!t  pCur-pNext)
+if (!t  maStack-size()  1)
 {
-ImpTokenIterator* pHere = pCur;
-pCur = pCur-pNext;
+FormulaTokenIterator::Item pHere = maStack-back();
+maStack-pop_back();
 t = PeekNextOperator();
-pCur = pHere;
+maStack-push_back(pHere);
 }
 return t;
 }
@@ -1358,20 +1352,22 @@ const FormulaToken* 
FormulaTokenIterator::PeekNextOperator()
 
 void FormulaTokenIterator::Jump( short nStart, short nNext, short nStop )
 {
-pCur-nPC = nNext;
+maStack-back().nPC = nNext;
 if( nStart != nNext )
 {
-Push( pCur-pArr );
-pCur-nPC = nStart;
-pCur-nStop = nStop;
+Push( maStack-back().pArr );
+maStack-back().nPC = nStart;
+maStack-back().nStop = nStop;
 }
 }
 
 const FormulaToken* FormulaTokenIterator::GetNonEndOfPathToken( short nIdx ) 
const
 {
-if (nIdx  pCur-pArr-nRPN  nIdx  pCur-nStop)
+FormulaTokenIterator::Item cur = maStack-back();
+
+if (nIdx  cur.pArr-nRPN  nIdx  cur.nStop)
 {
-const FormulaToken* t = pCur-pArr-pRPN[ nIdx ];
+const FormulaToken* t = cur.pArr-pRPN[ nIdx ];
 // such an OpCode ends an IF() or CHOOSE() path
 return (t-GetOpCode() == ocSep || t-GetOpCode() == ocClose) ? NULL : 
t;
 }
@@ -1380,7 +1376,7 @@ const FormulaToken* 
FormulaTokenIterator::GetNonEndOfPathToken( short nIdx ) con
 
 bool FormulaTokenIterator::IsEndOfPath() const
 {
-return GetNonEndOfPathToken( pCur-nPC + 1) == NULL;
+return GetNonEndOfPathToken( maStack-back().nPC + 1) == NULL;
 }
 
 
diff --git a/include/formula/tokenarray.hxx b/include/formula/tokenarray.hxx
index dcc8dc9..e20d578 100644
--- a/include/formula/tokenarray.hxx
+++ b/include/formula/tokenarray.hxx
@@ -257,19 +257,19 @@ inline OpCode FormulaTokenArray::GetOuterFuncOpCode()
 return

Re: [Libreoffice-qa] Toolbar Proposal Completed

2014-07-26 Thread Jochen Schiffers


Hi Jay,

good work. Great suggestions. My 2 cents are...

During the installation of LO respectively Tools - Options - View 
offer two options:

1) proposal asimage 3 and
2) proposal as image 4
Reason: some people want simple, some people want full informations. 
Everyone now has the opportunity to decide between the two versions and 
then adjust the view according to his ideas.


Maybe it even makes sense to offer all four proposals as a selection

Regards

Jochen



Am 26.07.2014 06:08, schrieb Jay Philips:

Hi All,

As i have just completed the toolbar proposal that i've been working
heavily on since the beginning of this month, i wanted to share with you
all images of how it has turned out.

Image 1: Removal of less used buttons
https://www.libreoffice.org/bugzilla/attachment.cgi?id=103115

Image 2: Grouping similar items together
https://www.libreoffice.org/bugzilla/attachment.cgi?id=103175

Image 3: Addition of buttons of highly used features
https://www.libreoffice.org/bugzilla/attachment.cgi?id=103420

Image 4: Final mockup with alternative
https://www.libreoffice.org/bugzilla/attachment.cgi?id=103484

It is now in the hands of the UX team to comment on. For those that
would like to read more about it, check bug 81475. Hopefully you guys
can benefit from these findings by customizing your toolbars for QA work. :)



___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Toolbar Proposal Completed

2014-07-26 Thread Tommy

On Sat, 26 Jul 2014 06:08:28 +0200, Jay Philips philip...@hotmail.com  
wrote:



Hi All,

As i have just completed the toolbar proposal that i've been working
heavily on since the beginning of this month, i wanted to share with you
all images of how it has turned out.

Image 1: Removal of less used buttons
https://www.libreoffice.org/bugzilla/attachment.cgi?id=103115


I think it's up to the user to decide which button he needs and which he  
doesn't.
since anyone can easily customize the toolbar to fit it needs I'm against  
changing the status quo because of arbitrary less used / most used  
statistics.



Image 2: Grouping similar items together
https://www.libreoffice.org/bugzilla/attachment.cgi?id=103175


some people would like the grouping, others won't.

for example I prefer to have separate items for each of the text alignment  
rather which I can hit in a single click rather than click on group and  
then click on desired alignment.


if the proposal is to add an additional grouped button I can agree (even  
if I would not use it) but I'm against changing the separate items to a  
single grouped button.


IMHO anytime you wanna change something in the UI, you should always allow  
the user to have an option to keep the old behaviour.




Image 3: Addition of buttons of highly used features
https://www.libreoffice.org/bugzilla/attachment.cgi?id=103420


same situation of first screenshot. if you have a favourite button you can  
already add it to your toolbar.




Image 4: Final mockup with alternative
https://www.libreoffice.org/bugzilla/attachment.cgi?id=103484

It is now in the hands of the UX team to comment on. For those that
would like to read more about it, check bug 81475. Hopefully you guys
can benefit from these findings by customizing your toolbars for QA  
work. :)


 my bottomline is that there's no need to change the current toolbar UI  
setup since it's already easy to customize it to fit your personal needs.


here's a screenshot of my heavily customized toolbar.:  
http://6g6.eu/sih0-toolbar.png


most of your proposal would have little impact on me.

that's only my 2 cents. don't take it personally.

bye, Tommy

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Toolbar Proposal Completed

2014-07-26 Thread Jay Philips

Hi All,

I guess i should have been clearer with my initial email. :)

The purpose of my toolbar proposal is to provide most users a good set
of default toolbar buttons, as most users dont customize their toolbar.
And when users dont find the necessary buttons in the toolbar, they go
through the menus looking for the functionality.

My use of the word 'remove' means that it should not be shown by
default, not that it be wiped away. I would never suggest that users who
didnt like the UI arent able to return the buttons that they preferred
to have.

Detailed reasoning of every button that i have suggested their
removal/hiding or addition can be found in fdo#81475
https://bugs.freedesktop.org/show_bug.cgi?id=81475 , along with
statistics on their toolbar usage. Would love to hear feedback from
those who have read the proposal, as of course the images werent able to
fully explain it all.

Thanks Tommy for your customized toolbar, as it has many of the buttons
i have suggested. It also has a suggestion that wasnt included in the
proposal images, removal of the cut/copy/paste buttons. :)

Would love to see customized toolbars from any others in the team, if
you dont mind sharing them. :)

Regards,
Jay Philips

On 07/26/2014 08:26 PM, V Stuart Foote wrote:
Jay forgot to add it, but his work up on this is an active BZ issue--
fdo#81475 https://bugs.freedesktop.org/show_bug.cgi?id=81475 . More on
the proposal is detailed there.

Stuart

--
View this message in context:
http://nabble.documentfoundation.org/Libreoffice-qa-Toolbar-Proposal-Completed-tp4116760p4116825.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems?
http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Toolbar Proposal Completed

2014-07-26 Thread Jochen Schiffers


Hi Jay,

Am 27.07.2014 00:22, schrieb Jay Philips:

Would love to see customized toolbars from any others in the team snip


see www.file-upload.net/download-9277728/toolbar_Jochen_german.png.html

Regards

Jochen (German)
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Toolbar Proposal Completed

2014-07-26 Thread Jay Philips

Hi Jochen,

Tried to get access to the file but all i get is stupid ads. If you
could upload it to imgur.com, that would be great.

Regards,
Jay Philips

On 07/27/2014 02:45 AM, Jochen Schiffers wrote:
 Hi Jay,
 
 Am 27.07.2014 00:22, schrieb Jay Philips:
 Would love to see customized toolbars from any others in the team snip
 
 see www.file-upload.net/download-9277728/toolbar_Jochen_german.png.html
 
 Regards
 
 Jochen (German)
 ___
 List Name: Libreoffice-qa mailing list
 Mail address: Libreoffice-qa@lists.freedesktop.org
 Change settings:
 http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
 Problems?
 http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
 Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
 List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 81757] Calculations order do not follow cell dependencies

https://bugs.freedesktop.org/show_bug.cgi?id=81757

--- Comment #1 from ign_christian ign_christ...@yahoo.com ---
Hi.. Please provide step by step procedure so others can easily test  triage
the issue, for example: https://bugs.freedesktop.org/show_bug.cgi?id=73678#c0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81558] VIEWING: Word 2003 offered a Blue background, white text screen-only for readability

https://bugs.freedesktop.org/show_bug.cgi?id=81558

--- Comment #6 from Christopher Chavez chrischa...@gmx.us ---
(In reply to comment #5)
 Libreoffice color scheme changes the printed document (and the page preview)
 not screen-only.
I cannot confirm whether that is the case or not on Windows. On OS X and Linux,
however, the color scheme does not apply when printed or exported.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81741] Orientation should be a button, not a menu

https://bugs.freedesktop.org/show_bug.cgi?id=81741

--- Comment #3 from Daniel Hulse simplecontr...@gmail.com ---
So long as the implementation is good, this seems like a fairly commmon-sense
ux improvement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81757] Calculations order do not follow cell dependencies

https://bugs.freedesktop.org/show_bug.cgi?id=81757

GerardF gerard.farg...@orange.fr changed:

   What|Removed |Added

 Attachment #103462|text/plain  |application/vnd.oasis.opend
  mime type||ocument.spreadsheet

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81772] FILEOPEN: Libreoffice crashes when opening file via open command line

https://bugs.freedesktop.org/show_bug.cgi?id=81772

--- Comment #1 from Christopher Chavez chrischa...@gmx.us ---
I am able to use open … on .odt or any other type for LibreOffice 4.3.0.3
(aka RC3), OS X 10.9.4.
What version of OS X are you using specifically? Does actually double-clicking
the file result in a crash?

[QA: should this be set to NEEDINFO?]

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32964] with gcj, report uses derived table (subquery), but automatic ORDER BY clause uses table names from within the subquery; breaks PostgreSQL, HSQLDB, MySQL

https://bugs.freedesktop.org/show_bug.cgi?id=32964

--- Comment #26 from Julien Nabet serval2...@yahoo.fr ---
Created attachment 103490
  -- https://bugs.freedesktop.org/attachment.cgi?id=103490action=edit
backtrace with master sources

Just to give an updated, I could reproduce the problem with master sources
updated yesterday + gcj 4.9

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81772] FILEOPEN: Libreoffice crashes when opening file via open command line

https://bugs.freedesktop.org/show_bug.cgi?id=81772

--- Comment #2 from Christopher Chavez chrischa...@gmx.us ---
possible duplicate of bug 74447?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32964] with gcj, report uses derived table (subquery), but automatic ORDER BY clause uses table names from within the subquery; breaks PostgreSQL, HSQLDB, MySQL

https://bugs.freedesktop.org/show_bug.cgi?id=32964

--- Comment #27 from Julien Nabet serval2...@yahoo.fr ---
Created attachment 103491
  -- https://bugs.freedesktop.org/attachment.cgi?id=103491action=edit
backtrace from breakpoint

I put a breakpoint at the location where it triggers the popup:
Impossible to open the document Assets.

[jni_uno bridge error] UNO calling Java method activate:
java.lang.NullPointerException
java stack trace:
java.lang.NullPointerException
  at java.lang.reflect.Method.getType(libgcj.so.15)
  at java.lang.reflect.Method.toString(libgcj.so.15)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32964] with gcj, report uses derived table (subquery), but automatic ORDER BY clause uses table names from within the subquery; breaks PostgreSQL, HSQLDB, MySQL

https://bugs.freedesktop.org/show_bug.cgi?id=32964

--- Comment #28 from Julien Nabet serval2...@yahoo.fr ---
As a noteside, trying to open the table in gdb session (still with gcj), I've
got a lot of these:
Program received signal SIGPWR, Power fail/restart.
[Switching to Thread 0x2aaad42c5700 (LWP 6549)]
pthread_cond_wait@@GLIBC_2.3.2 () at
../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
185../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S: Aucun
fichier ou dossier de ce type.
(gdb) c
Continuing.

Program received signal SIGXCPU, CPU time limit exceeded.
0x2b29a782 in do_sigsuspend (set=0x2aaad4045680) at
../sysdeps/unix/sysv/linux/sigsuspend.c:31
31../sysdeps/unix/sysv/linux/sigsuspend.c: Aucun fichier ou dossier de ce
type.
(gdb) c
Continuing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44081] EDITING - A form set to open in read-only mode can never be switched back

https://bugs.freedesktop.org/show_bug.cgi?id=44081

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||lio...@mamane.lu,
   ||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet serval2...@yahoo.fr ---
I gave a try with master sources updated yesterday, indeed I can't uncheck
Read-only since the checkbox is disabled.
I also tried from File/properties in Edit Form in from Base (instead of from
Writer).

Trying in gdb session, it seems the problem might be here:
http://opengrok.libreoffice.org/xref/core/sfx2/source/dialog/securitypage.cxx#241
SfxSecurityPage_Impl::Reset_Impl
May there be some confusion between:
- pCurDocShell-IsReadOnly()
- pCurDocShell-HasSecurityOptOpenReadOnly()
- pCurDocShell-IsSecurityOptOpenReadOnly()

I don't find the way the checkboxes could be enabled with readonly checkbox
checked.

Lionel/Caolan: any idea?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81759] the Speech Editor Siri of MAC OS 10.9.4 does not work with Libreoffice 4.3.0.3

https://bugs.freedesktop.org/show_bug.cgi?id=81759

Uwe Altmann l...@altsys.de changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
 Status|UNCONFIRMED |NEW
 CC||l...@altsys.de
 Ever confirmed|0   |1

--- Comment #1 from Uwe Altmann l...@altsys.de ---
Seems the keyboard strokes to start Siri (which is a double fn key by
default, but others don't work either) is not passed to the OS?
This is new in 4.3 - 4.2.5 works like it should.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77301] 4.2.3 Release stops editing

https://bugs.freedesktop.org/show_bug.cgi?id=77301

Christopher Chavez chrischa...@gmx.us changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME
 CC||chrischa...@gmx.us

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81756] Crasher in Format:Page... menu item

https://bugs.freedesktop.org/show_bug.cgi?id=81756

Christopher Chavez chrischa...@gmx.us changed:

   What|Removed |Added

 Attachment #103461|text/plain  |application/zip
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81716] EDITING: All windows not active after closing Help window.

https://bugs.freedesktop.org/show_bug.cgi?id=81716

--- Comment #3 from Christopher Chavez chrischa...@gmx.us ---
Was not able to reproduce using 4.3.0.3 (aka RC3, 64-bit version for 10.8+) on
OS X 10.9.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70611] Resizing with tab sizes and tables, etc.

https://bugs.freedesktop.org/show_bug.cgi?id=70611

--- Comment #6 from Zoltán Hegedüs x...@hdsnet.hu ---
(In reply to comment #5)
 Is it possible for you to supply us a document, which we can test against,
 to see the enhancement that you wish to suggest.

Use any text document. Make half all the sizes in document: fontsize, default
and custom tabulator positions, tables, pictures, etc. If required, make double
the number of columns, for example, from 1 to 2. This will be the example
document. The case: for example, there is a document with fontsize 5 and 6,
what is very little. If I set the fontsize to 10 and 12, I must set it for each
paragraph style separately, and the tables will fall apart (dissolve),
including really tables and text formated with tabulators. The solution:
enlarging like a lens: for example, doubling all sizes in one time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79652] Mouse not visible

https://bugs.freedesktop.org/show_bug.cgi?id=79652

--- Comment #3 from Christopher Chavez chrischa...@gmx.us ---
Sounds like bug 71278, although that was supposedly specific to impress
(presentation application).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81052] problem opening xlsx file

https://bugs.freedesktop.org/show_bug.cgi?id=81052

--- Comment #9 from Christopher Chavez chrischa...@gmx.us ---
I cannot reproduce using 4.3.0.3 (aka RC3, 64-bit) on OS X 10.9.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80416] EDITING: Cannot change type/format of date/time fields from context menu

https://bugs.freedesktop.org/show_bug.cgi?id=80416

Christopher Chavez chrischa...@gmx.us changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||chrischa...@gmx.us
Summary|EDITING: Cannot change  |EDITING: Cannot change
   |format of date field|type/format of date/time
   ||fields from context menu
 Ever confirmed|0   |1

--- Comment #3 from Christopher Chavez chrischa...@gmx.us ---
Reproduced using 4.3.0.3 (aka RC3, 64-bit) on OS X 10.9.4. The same applies to
time fields (inserted from Insert  Fields), and applies to both fixed and
variable fields.

A workaround is to highlight only the inserted field and go to Edit  Fields…
and choose the field type and format.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80416] EDITING: Cannot change type/format of date/time fields from context menu

https://bugs.freedesktop.org/show_bug.cgi?id=80416

Christopher Chavez chrischa...@gmx.us changed:

   What|Removed |Added

   Hardware|Other   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81594] FILESAVE: After save The Excel file by Libreoffice is changing still and printed area when open MS Office

https://bugs.freedesktop.org/show_bug.cgi?id=81594

Christopher Chavez chrischa...@gmx.us changed:

   What|Removed |Added

 Attachment #103181|application/octet-stream|application/vnd.openxmlform
  mime type||ats-officedocument.spreadsh
   ||eetml.sheet

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81351] UNDO: Calc crashes after undo from a sort

https://bugs.freedesktop.org/show_bug.cgi?id=81351

Christopher Chavez chrischa...@gmx.us changed:

   What|Removed |Added

 Attachment #102976|application/octet-stream|text/x-log
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81002] FORMATTING: LO freezing when using Character Strikeout (for certain characters) on form check boxes.

https://bugs.freedesktop.org/show_bug.cgi?id=81002

Christopher Chavez chrischa...@gmx.us changed:

   What|Removed |Added

 Attachment #102406|application/octet-stream|application/vnd.oasis.opend
  mime type||ocument.text-template

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81396] XLSX IMPORT: Data plots in chart not visible when cells have formula, needs Ctrl+Shift+F9 (Steps in Comment 5)

https://bugs.freedesktop.org/show_bug.cgi?id=81396

Christopher Chavez chrischa...@gmx.us changed:

   What|Removed |Added

 Attachment #103297|application/octet-stream|application/xml
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81752] PDF: PDF input/output error

https://bugs.freedesktop.org/show_bug.cgi?id=81752

saramal...@mail.ru changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #2 from saramal...@mail.ru ---
Impossible. File will be sent privately to assigned developer only.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81752] PDF: PDF input/output error

https://bugs.freedesktop.org/show_bug.cgi?id=81752

ign_christian ign_christ...@yahoo.com changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from ign_christian ign_christ...@yahoo.com ---
Hi.. Joel is core QA team: https://wiki.documentfoundation.org/QA/Team

Please don't mark your own report as NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45633] Viewing: Will not view (open) LWP (Lotus WordPro) files as advertized

https://bugs.freedesktop.org/show_bug.cgi?id=45633

Owen Genat owen.ge...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Owen Genat owen.ge...@gmail.com ---
For reference, here is a comparison of the headers of the attachment in bug
41702 (Unteress_test.lwp) and the attachment for this bug (CALVARY.LWP):

$ hexdump -n50 -C Unteress_test.lwp 
  57 6f 72 64 50 72 6f 0d  fb 00 00 00 00 00 00 00  |WordPro.|
0010  00 05 98 5c 81 72 03 00  40 cc c1 bf ff bd f9 50  |...\.r..@..P|
0020  99 89 03 0a 00 bc 1a d8  4e 02 00 7a dc b4 d1 11  |N..z|
0030  00 00 |..|
0032
$ hexdump -n50 -C CALVARY.LWP 
  57 6f 72 64 50 72 6f 0d  fb 00 00 00 00 00 00 00  |WordPro.|
0010  00 05 98 5c 81 72 03 00  40 cc c1 bf ff bd f9 50  |...\.r..@..P|
0020  99 89 03 09 00 08 12 98  0b 79 08 08 c0 08 00 00  |.y..|
0030  03 00 |..|
0032

Here is a dump of the header for a WordPro file that does open:

$ hexdump -n50 -C finanzen\ 2013.lwp 
  57 6f 72 64 50 72 6f 00  00 00 00 00 00 00 00 00  |WordPro.|
0010  4c 57 50 37 00 00 00 00  00 00 00 00 00 00 00 00  |LWP7|
0020  00 00 ff ff ff ff 00 00  00 00 2e 00 00 00 01 07  ||
0030  0f 00 |..|
0032

There is a note in the source code indicating that Word Pro 96 and previous
versions are unsupported, which may be related to why the attachment to this
bug does not open.

*** This bug has been marked as a duplicate of bug 41702 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41702] FILEOPEN: Lotus Word Pro (.lwp) document opens as empty in LibO

https://bugs.freedesktop.org/show_bug.cgi?id=41702

Owen Genat owen.ge...@gmail.com changed:

   What|Removed |Added

 CC||glf.libreoff...@gmail.com

--- Comment #9 from Owen Genat owen.ge...@gmail.com ---
*** Bug 45633 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81768] editing index match function

https://bugs.freedesktop.org/show_bug.cgi?id=81768

ign_christian ign_christ...@yahoo.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #1 from ign_christian ign_christ...@yahoo.com ---
Not reproducible with LO 4.2.6.2 - Ubuntu 12.04 x86

PLease upgrade to latest stable release since 3.5 branch not supported anymore. 

If issue still occur after upgrading, please attach sample file. Then change
status of this bug to UNCONFIRMED.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 33713] FORMATTING, FILEOPEN: Spacing above and below paragraph (.lwp)

https://bugs.freedesktop.org/show_bug.cgi?id=33713

Owen Genat owen.ge...@gmail.com changed:

   What|Removed |Added

   Severity|enhancement |normal

--- Comment #9 from Owen Genat owen.ge...@gmail.com ---
Not sure why this bug is set as an enhancement when related bug 33787 and bug
33838 are not. Severity set to normal. Import of the content in the provided
example has regressed since the originally reported v3.3. All versions I have
tested (3.5.7.2, 4.1.6.2, 4.2.5.2, 4.3.0.3, and 4.4.0.0alpha+) now only import
unformatted text.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70783] Crash on FILEOPEN odp file (win only)

https://bugs.freedesktop.org/show_bug.cgi?id=70783

--- Comment #13 from Mr. MD b...@spam.vlsi.gr ---

Problem still persists.
Downloaded the latest verion
4.4.0.0.alpha0+
Build ID: fed7294029f07ff407765b568266084d9e8d365c
TinderBox: Win-x86@39, Branch:master, Time: 2014-07-26_03:04:49

Tested on Windows 7 Ultimate , 32 bit Operating System.

Same behaviour. As soon as the presentation is going to be shown, it crashes to
desktop. I will upload the debugging symbols and the minidump.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37806] Support WordPro document tabs and window viewing

https://bugs.freedesktop.org/show_bug.cgi?id=37806

Owen Genat owen.ge...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Owen Genat owen.ge...@gmail.com ---


*** This bug has been marked as a duplicate of bug 33173 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70783] Crash on FILEOPEN odp file (win only)

https://bugs.freedesktop.org/show_bug.cgi?id=70783

--- Comment #14 from Mr. MD b...@spam.vlsi.gr ---
Created attachment 103493
  -- https://bugs.freedesktop.org/attachment.cgi?id=103493action=edit
4.4.0.0.alpha0+ Windbg Debugger Output

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 33173] Functionality request for Writer: add tabs like in Lotus Wordpro Type Tabbed Divisions

https://bugs.freedesktop.org/show_bug.cgi?id=33173

Owen Genat owen.ge...@gmail.com changed:

   What|Removed |Added

 CC||rol...@logikalsolutions.com

--- Comment #17 from Owen Genat owen.ge...@gmail.com ---
*** Bug 37806 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70783] Crash on FILEOPEN odp file (win only)

https://bugs.freedesktop.org/show_bug.cgi?id=70783

--- Comment #15 from Mr. MD b...@spam.vlsi.gr ---
Created attachment 103494
  -- https://bugs.freedesktop.org/attachment.cgi?id=103494action=edit
4.4.0.0.alpha0+ Debugger output using procdump

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70783] Crash on FILEOPEN odp file (win only)

https://bugs.freedesktop.org/show_bug.cgi?id=70783

--- Comment #16 from Mr. MD b...@spam.vlsi.gr ---
Created attachment 103495
  -- https://bugs.freedesktop.org/attachment.cgi?id=103495action=edit
4.4.0.0.alpha0+ MiniDump file from procdump

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81776] New: Other: Extension Manager is blank

https://bugs.freedesktop.org/show_bug.cgi?id=81776

  Priority: medium
Bug ID: 81776
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: Other: Extension Manager is blank
  Severity: normal
Classification: Unclassified
OS: Linux (All)
  Reporter: j...@encremento.com
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 4.2.4.2 release
 Component: Writer
   Product: LibreOffice

Problem description: 

I jus installed Ubuntu 14.04 and wanted to add extensions to LibreOffice.
However, when I open the Tools/Extension Manager there are no extensions to
install. It's just a blank box.

Steps to reproduce:
1. Open Tools/Extension Manager
2. 
3. 

Current behavior:

Expected behavior:
I think I should be getting a list of possible extensions to install

Operating System: Ubuntu
Version: 4.2.4.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81752] PDF: PDF input/output error

https://bugs.freedesktop.org/show_bug.cgi?id=81752

--- Comment #4 from saramal...@mail.ru ---
password SfSJkK8YT

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81765] FILEOPEN: slow loading of .ods and .xlsx

https://bugs.freedesktop.org/show_bug.cgi?id=81765

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@quipo.it
Summary|FILEOPEN: Open slow |FILEOPEN: slow loading of
   ||.ods and .xlsx
 Ever confirmed|0   |1

--- Comment #1 from tommy27 ba...@quipo.it ---
very slow loading of both the .ods and .xlsx version of that file.
tested under Win7x64 using LibO 4.2.5.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81763] BASIC: System slows down badly

https://bugs.freedesktop.org/show_bug.cgi?id=81763

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@quipo.it
 Ever confirmed|0   |1

--- Comment #1 from tommy27 ba...@quipo.it ---
I'm not on Linux so I cannot confirm.
anyway you are using an old unstable LibO release (4.1.0.4) and you are
strongly encouraged to upgrade to current LibO 4.2.5.2 which is a much mature
release.

to give you an idea probably more than a thousand bugs have been fixed from
4.1.0 to 4.2.5...

set status to NEEDINFO.
after you upgrade give us feedback. 
if issue is still there, feel free to REOPEN, otherwise set status to RESOLVED
WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81763] System slows down badly when opening any LibO application

https://bugs.freedesktop.org/show_bug.cgi?id=81763

tommy27 ba...@quipo.it changed:

   What|Removed |Added

Summary|BASIC: System slows down|System slows down badly
   |badly   |when opening any LibO
   ||application
  Component|BASIC   |Libreoffice

--- Comment #2 from tommy27 ba...@quipo.it ---
edited summary notes and component since this has nothing to do with the BASIC
component.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81736] Writer cannot import fields from .doc

https://bugs.freedesktop.org/show_bug.cgi?id=81736

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 CC||ba...@quipo.it
Summary|LO Writer-4.2.5 cannot  |Writer cannot import fields
   |import fields from .doc |from .doc
Version|unspecified |4.2.5.2 release

--- Comment #6 from tommy27 ba...@quipo.it ---
@Pablo
do you see the same issue either on Linux or Windows?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81778] New: EDITING: Cannot place use MOD(A1, ...

https://bugs.freedesktop.org/show_bug.cgi?id=81778

  Priority: medium
Bug ID: 81778
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: EDITING: Cannot place use MOD(A1,...
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: seles...@hotmail.com
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 4.2.5.2 release
 Component: Spreadsheet
   Product: LibreOffice

Problem description: 
I try to use the formula to do modulus on the cell A1, but LibreOffice replaces
A1 by A10. This happens every time, in every cell.
Steps to reproduce:
1. Open Spreadsheet
2. Edit a cell
3. Type '=MOD(A1,2)' (or another number than 2)
4. confirm edit in any way

Current behavior:
The content of the cell is replaced by '=MOD(A10,2)'. Yielding 'Err:509'
probably because A10 is an empty cell.

Expected behavior:
The cell keeps its content and calculates the modulus of A1.
Note that for other cells than A1, spreadsheet behaves as it should.

Operating System: Windows 8
Version: 4.2.5.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81778] EDITING: Cannot place/use MOD(A1, ...

https://bugs.freedesktop.org/show_bug.cgi?id=81778

seles...@hotmail.com changed:

   What|Removed |Added

Summary|EDITING: Cannot place use   |EDITING: Cannot place/use
   |MOD(A1,...  |MOD(A1,...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81779] New: cut and undo operations don't remove the image attached to the last paragraph of the document

https://bugs.freedesktop.org/show_bug.cgi?id=81779

  Priority: medium
Bug ID: 81779
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: cut and undo operations don't remove the image
attached to the last paragraph of the document
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: nem...@numbertext.org
  Hardware: Other
Status: NEW
   Version: 3.3.0 release
 Component: Writer
   Product: LibreOffice

Created attachment 103498
  -- https://bugs.freedesktop.org/attachment.cgi?id=103498action=edit
test document with multiple images

Testing shows the problem(s) (introduced by OpenOffice.org, yet):

1. Open the attached test file, and press the following keys:
2. Ctrl-A
3. Ctrl-X (first problem: there are all images in the clipboard, but last image
doesn't removed from the document)
4. Ctrl-N
5. Ctrl-V
6. Ctrl-Z (second problem: all images are inserted in the new file, but undo
operation doesn't removes the last one).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81771] Ordenar no recalcula valores en celdas ver 4.2.4.2 ; 4.2.5.2

https://bugs.freedesktop.org/show_bug.cgi?id=81771

Urmas davian...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #3 from Urmas davian...@gmail.com ---
This bugtracker is English-only.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81740] Toolbars Should Not Contain Checkboxes

https://bugs.freedesktop.org/show_bug.cgi?id=81740

Urmas davian...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81780] New: FORMATTING: Left Justified Cells Not Displaying Properly

https://bugs.freedesktop.org/show_bug.cgi?id=81780

  Priority: medium
Bug ID: 81780
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: FORMATTING: Left Justified Cells Not Displaying
Properly
  Severity: normal
Classification: Unclassified
OS: Mac OS X (All)
  Reporter: bugzill...@gmail.com
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 4.2.5.2 release
 Component: Spreadsheet
   Product: LibreOffice

Problem description: 

When I enter text in a Left Justified cell it is truncated at the border with
the cell to the right even though that cell is empty. In other spreadsheets the
trucation only occurs when the adjacent cell has actual data in it.

Steps to reproduce:
1. Format a cell as Left justified making certain the adjacent cell on the left
is empty
2. Enter some text that exceeds the length of the cell


Current behavior: Truncation

Expected behavior: Continued Text Visibility which also shows as WYSIWYG on
printing.

This behavior is defacto for MS Office for Mac 2004 and 2011


Operating System: Mac OS X
Version: 4.2.5.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81736] Writer cannot import fields from .doc

https://bugs.freedesktop.org/show_bug.cgi?id=81736

--- Comment #7 from Pablo Rodríguez freedesk...@pragmata.tk ---
(In reply to comment #6)
 @Pablo
 do you see the same issue either on Linux or Windows?

I cannot test the issue on Windows, since I don’t have administration rights on
the Windows computer I can use.

Maybe I can check the bug against the latest stable version in Windows next
week.

Sorry, but I only own a computer with Linux inside.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81736] Writer cannot import fields from .doc

https://bugs.freedesktop.org/show_bug.cgi?id=81736

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 OS|All |Linux (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81782] New: MAILMERGE: Default fields for topic and subject are only printed to the first document

https://bugs.freedesktop.org/show_bug.cgi?id=81782

  Priority: medium
Bug ID: 81782
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: MAILMERGE: Default fields for topic and subject are
only printed to the first document
  Severity: normal
Classification: Unclassified
OS: Mac OS X (All)
  Reporter: s...@zenmotion.de
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 4.2.5.2 release
 Component: Writer
   Product: LibreOffice

Problem description: 

The default fields for topic and subject (document properties) are only printed
to the first document by using the mail merge assistant.

Steps to reproduce:
1. define the document properties topic and subject (file-properties)
2. insert the fields to the document (tab document info)
3. generate a mail merge document

Current behavior:
the inserted fields are only printed to the first document. In the followed
documents there are only whitespace instead the expected content.

Expected behavior:
I would expect that these fields are printed to every document during the mail
merge process.

Subject name of the conversation in the mailing list:
MAIL MERGE: Default fields Topic and Subject are only printed in first
document

regards,
Sven
Operating System: Mac OS X
Version: 4.2.5.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61914] [META] Start Center -- Tweak the new template manager to act as a start center

https://bugs.freedesktop.org/show_bug.cgi?id=61914

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

--- Comment #26 from V Stuart Foote vstuart.fo...@utsa.edu ---
Going to reopen an comment that this is a meta for tracking issues related to
the enhancement of the still developing Start Center feature. It could be
retitled if that makes folks more comfortable, but it remains valid to
associate the UI and UX issues of the Start Center in one active BZ issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61914] [META] Start Center -- Tweak the new template manager to act as a start center

https://bugs.freedesktop.org/show_bug.cgi?id=61914

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 Status|REOPENED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61914] [META] Start Center -- implementation UI and UX

https://bugs.freedesktop.org/show_bug.cgi?id=61914

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

Summary|[META] Start Center --  |[META] Start Center --
   |Tweak the new template  |implementation UI and UX
   |manager to act as a start   |
   |center  |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63570] FILESAVE Writer does not evaluate formulas when converting to pdf or printing by command line

https://bugs.freedesktop.org/show_bug.cgi?id=63570

--- Comment #4 from Milos Sramek msrame...@gmail.com ---
(In reply to comment #3)
 The problem of the formulas in the red row not totalling correctly (and not
 being referenced correctly in the yellow row) seems to be fixed in all these
 versions under GNU/Linux:
 
 - v4.1.6.2 Build ID: 40ff705089295be5be0aae9b15123f687c05b0a
 - v4.2.5.2 Build ID: 61cb170a04bb1f12e77c884eab9192be736ec5f5
 - v4.3.0.3 Build ID: 08ebe52789a201dd7d38ef653ef7a48925e7f9f7
 - v4.4.0.0.alpha0+ Build ID: 4aa9b041de3129f19b48e66d349f48657b73f33e
 (2014-07-19)
 
 Milos if you can confirm this, we may be able to finally mark this bug as
 RESOLVED and WORKSFORME (unless an identifiable fix can be located, in which
 case it can be marked FIXED).

Hi,
it still does not work for me. I've tested
Verzia: 4.2.6.1  5fdddf655fba363e34f755715238d0943a44857e
Verzia: 4.3.0.3  08ebe52789a201dd7d38ef653ef7a48925e7f9f7

Did you run the conversion from command line? This way?
/opt/libreoffice4.2/program/soffice --headless --convert-to pdf t.odt
--
m

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76231] Tamil letters wrong display in latha font

https://bugs.freedesktop.org/show_bug.cgi?id=76231

--- Comment #7 from Oppili sripathy...@gmail.com ---
Created attachment 103501
  -- https://bugs.freedesktop.org/attachment.cgi?id=103501action=edit
Latha Font

Latha font attached. The display has not been rectified so far.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81733] incompatibility with Java

https://bugs.freedesktop.org/show_bug.cgi?id=81733

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote vstuart.fo...@utsa.edu ---
Please verify that you have a 32-bit JRE available on path and specified for
LibreOffice to use.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81783] New: Libre Office Writer with French localisation does not set French as default language for spellcheck