[Libreoffice-bugs] [Bug 88755] LibreOffice Calc - Conditional Format - Color Bar functionality desperately needs improvements and corrections
https://bugs.freedesktop.org/show_bug.cgi?id=88755 --- Comment #1 from icerabbit icerabbi...@gmail.com --- Created attachment 112733 -- https://bugs.freedesktop.org/attachment.cgi?id=112733action=edit Column exhibiting value 1-60 yellow green 4 to red 2 = black in the middle Color Scale example value 1-60 yellow green 4 to red 2 with unexpected black in the middle, rendering text unreadable. Brown would be expectable, but maybe there should also be an option to % darken / lighten the background effect. PS: forgot to say LIVE PREVIEW of chosen settings in color scale would be nice, so you can adjust before you apply. It is tedious to have to redo this, with same selection, back into the menu etc to get something that works. As there's no edit last adjustment made, to just change one color. Only CLEAR or UNDO which means starting over making selections :( -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56953] The Insertion point changes its format on Backspace
https://bugs.freedesktop.org/show_bug.cgi?id=56953 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #5 from Beluga todven...@suomi24.fi --- Doesn't happen anymore (space+backspace) - WFM. Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ Build ID: 07e84cae983c08afdba03018413a19d01abb3006 TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-19_06:15:38 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sc/source
sc/source/ui/dbgui/tpsort.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit e38af030dae49c725b52e925a2e4f68cc280c842
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jan 23 14:42:28 2015 +
Resolves: fdo#88735 crash after calling sort after subtotal removal
Change-Id: Ia30271426ea47b7bf5af85d16591a02e6d52b3d9
(cherry picked from commit 0442cd217645aa4fdd924e4c2e4f90a77f1fbbad)
Reviewed-on: https://gerrit.libreoffice.org/14140
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
diff --git a/sc/source/ui/dbgui/tpsort.cxx b/sc/source/ui/dbgui/tpsort.cxx
index a9a793c..1f21119 100644
--- a/sc/source/ui/dbgui/tpsort.cxx
+++ b/sc/source/ui/dbgui/tpsort.cxx
@@ -151,7 +151,7 @@ void ScTabPageSortFields::Reset( const SfxItemSet /*
rArgSet */ )
FillFieldLists(0);
// ListBox selection:
-if ( aSortData.maKeyState[0].bDoSort )
+if (!aSortData.maKeyState.empty() aSortData.maKeyState[0].bDoSort)
{
// Make sure that the all sort keys are reset
for ( sal_uInt16 i=nSortKeyCount; iaSortData.GetSortKeyCount(); i++ )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88757] New: Display of Windows “Styles and Formatting” and “Gallery” is not Possible without Displaying the Sidebar Icons
https://bugs.freedesktop.org/show_bug.cgi?id=88757 Bug ID: 88757 Summary: Display of Windows “Styles and Formatting” and “Gallery” is not Possible without Displaying the Sidebar Icons Product: LibreOffice Version: 4.4.0.2 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: harald.koes...@mail.de If you display the “Gallery” or the “Styles and Formatting” window, always the icons of the sidebar are displayed too. Especially if you need the full width of your monitor, e.g. with a laptop or if 2 pages or 2 windows of different apps should be displayed, this is disadvantageous. To my opinion this is a regression to former versions. Hence it should be possible to close and/or to hide the bar with the sidebar icons even if the Gallery or the Styles window is displayed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76231] Tamil letters wrong display in latha font
https://bugs.freedesktop.org/show_bug.cgi?id=76231 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #103501|application/octet-stream|application/x-font-ttf mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75565] CRASH: LO crash when copypaste a column from Calc to Writer as formated text (rtf)
https://bugs.freedesktop.org/show_bug.cgi?id=75565 --- Comment #10 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolán McNamara committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=0efbd9931ea854cf71c4c54ca3f3d55d6db1fa13 Resolves: fdo#75565 reduce block on pasting rtf like we do for html It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75565] CRASH: LO crash when copypaste a column from Calc to Writer as formated text (rtf)
https://bugs.freedesktop.org/show_bug.cgi?id=75565 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|BSA |BSA target:4.5.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88702] The orca screen reader no longer announces information about bold, italic, and underline
https://bugs.freedesktop.org/show_bug.cgi?id=88702 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Blocks||36549 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36549] ACCESSIBILITY: Tracking bug for issues affecting a11y ATK and GNOME Orca screen reader support
https://bugs.freedesktop.org/show_bug.cgi?id=36549 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||88702 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76234] Spreadsheet (tables html)
https://bugs.freedesktop.org/show_bug.cgi?id=76234 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #95893|application/octet-stream|application/vnd.ms-excel mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - sw/inc sw/source
sw/inc/viewsh.hxx |1 +
sw/source/core/view/viewsh.cxx | 10 +++---
sw/source/core/view/vnew.cxx |2 ++
3 files changed, 10 insertions(+), 3 deletions(-)
New commits:
commit 05df28f0404fb788c2d494ab3caea8842c0a7681
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Jan 23 18:38:55 2015 +0100
LOK: don't ignore all callback events when we're in the callback already
There are two conflicting requirements here:
- if there was an invalidation event, and PaintTile() is called due to
that, then we're not interested in invalidation events generated by
PaintTile() itself.
- we do want other event types all the time like the cursor rectangle
Change SwViewShell::libreOfficeKitCallback(), so that it doesn't ignore
all callbacks when we're in the callback already, just the so far only
problematic type: tile invalidation.
Change-Id: Idcaedbbe0fe2b5b1aa9bafbfe33a81c8011fe148
diff --git a/sw/inc/viewsh.hxx b/sw/inc/viewsh.hxx
index 25a50bc..3416f9b 100644
--- a/sw/inc/viewsh.hxx
+++ b/sw/inc/viewsh.hxx
@@ -197,6 +197,7 @@ protected:
LibreOfficeKitCallback mpLibreOfficeKitCallback;
void* mpLibreOfficeKitData;
+bool mbInLibreOfficeKitCallback;
public:
TYPEINFO();
diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index 964cf83..4c17e95 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -125,6 +125,11 @@ void
SwViewShell::registerLibreOfficeKitCallback(LibreOfficeKitCallback pCallbac
void SwViewShell::libreOfficeKitCallback(int nType, const char* pPayload) const
{
+if (mbInLibreOfficeKitCallback nType == LOK_CALLBACK_INVALIDATE_TILES)
+// Make sure no more invalidation events are issued when we're in the
+// callback already.
+return;
+
if (mpLibreOfficeKitCallback)
mpLibreOfficeKitCallback(nType, pPayload, mpLibreOfficeKitData);
}
@@ -1778,8 +1783,7 @@ void SwViewShell::PaintTile(VirtualDevice rDevice, int
contextWidth, int contex
OutputDevice *pSaveOut = mpOut;
bool bTiledRendering = mbTiledRendering;
mbTiledRendering = true;
-LibreOfficeKitCallback pCallback = mpLibreOfficeKitCallback;
-mpLibreOfficeKitCallback = 0;
+mbInLibreOfficeKitCallback = true;
mpOut = rDevice;
// resizes the virtual device so to contain the entrie context
@@ -1827,7 +1831,7 @@ void SwViewShell::PaintTile(VirtualDevice rDevice, int
contextWidth, int contex
// SwViewShell's output device tear down
mpOut = pSaveOut;
-mpLibreOfficeKitCallback = pCallback;
+mbInLibreOfficeKitCallback = false;
mbTiledRendering = bTiledRendering;
static bool bDebug = getenv(SW_DEBUG_TILEDRENDERING) != 0;
diff --git a/sw/source/core/view/vnew.cxx b/sw/source/core/view/vnew.cxx
index 6fef158..986bb3e 100644
--- a/sw/source/core/view/vnew.cxx
+++ b/sw/source/core/view/vnew.cxx
@@ -171,6 +171,7 @@ SwViewShell::SwViewShell( SwDoc rDocument, vcl::Window
*pWindow,
mbSelectAll(false),
mpLibreOfficeKitCallback(0),
mpLibreOfficeKitData(0),
+mbInLibreOfficeKitCallback(false),
mpPrePostOutDev(0), // #i72754#
maPrePostMapMode()
{
@@ -249,6 +250,7 @@ SwViewShell::SwViewShell( SwViewShell rShell, vcl::Window
*pWindow,
mbSelectAll(false),
mpLibreOfficeKitCallback(0),
mpLibreOfficeKitData(0),
+mbInLibreOfficeKitCallback(false),
mpPrePostOutDev(0), // #i72754#
maPrePostMapMode()
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Libreoffice Compile back
Hello! Compile Libreoffice back for WXP Pro x64 is a good idea. With king regards!___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 53891] UI: Right clicking a picture and selecting crop picture shows complex dialog.
https://bugs.freedesktop.org/show_bug.cgi?id=53891 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #3 from Beluga todven...@suomi24.fi --- Well, 4.5 has a more intuitive crop tool without the dialog. Setting to WFM. Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ Build ID: 07e84cae983c08afdba03018413a19d01abb3006 TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-19_06:15:38 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53208] FORMULAEDITOR: Overlines are not at consistent heights
https://bugs.freedesktop.org/show_bug.cgi?id=53208 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #4 from Beluga todven...@suomi24.fi --- Now they are correctly aligned - WFM. Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ Build ID: 07e84cae983c08afdba03018413a19d01abb3006 TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-19_06:15:38 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61270] FILEOPEN: Writer Opens Documents with many Form Controls very Slow
https://bugs.freedesktop.org/show_bug.cgi?id=61270 Harald Koester harald.koes...@mail.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #18 from Harald Koester harald.koes...@mail.de --- I checked the bug again with version 4.3.5 and 4.4.0.2. With version 4.3.5 it still exist. But with 4.4.0.2 it WORKSFORME. With the first example document the load time is now about 1 second with and without displayed Navigator (Win7, 32 Bit). It seemed that the fix has not been backported to version 4.3.3 as stated in comment 13. But nevertheless from my point of view this bug can be closed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88755] New: LibreOffice Calc - Conditional Format - Color Bar functionality desperately needs improvements and corrections
https://bugs.freedesktop.org/show_bug.cgi?id=88755 Bug ID: 88755 Summary: LibreOffice Calc - Conditional Format - Color Bar functionality desperately needs improvements and corrections Product: LibreOffice Version: 4.3.5.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Libreoffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: icerabbi...@gmail.com Working on a quick table to analyze some information and figuring Conditional Format - Color bars would be great. Just green to red. It is a struggle to pick the same colors over time for several sets of data, because: - you can only see three colors at a time in a scrolling menu request a larger UI window with 24-36 or so most common quick picks - see for example the font or background color picker - like colors are not grouped, for instance no grouping of greens reds blues etc they're all over the list - some of the colors are imo grossly unusable or non-existent some of the reds for instance are just black on screen, one sees this in the font and background color picker too, but it is easier to ignore. - there are also problems whereby a green to red scale turns certain cells black, which I cannot figure out. I have a simple 0 - 60 value bar and the exact middles turn black??? Added problem here is that when the cell turns dark, there is no automatic switching to white font, so you could actually read the value in the cell. So you'd need an additional conditional format or systemwide preference, if cell is shaded above a certain value and contrast between cell shade and font color is less than x then switch default text color from black to white. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88702] The orca screen reader no longer announces information about bold, italic, and underline
https://bugs.freedesktop.org/show_bug.cgi?id=88702 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added URL||http://nabble.documentfound ||ation.org/libreoffice-acces ||sibility-style-announcement ||-regression-when-using-orca ||-on-linux-tp4137203.html Whiteboard||a11y -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88757] Display of Windows “Styles and Formatting” and “Gallery” is not Possible without Displaying the Sidebar Icons
https://bugs.freedesktop.org/show_bug.cgi?id=88757 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added CC||c...@nouenoff.nl --- Comment #1 from Cor Nouws c...@nouenoff.nl --- Hi Harald, (In reply to Harald Koester from comment #0) If you display the “Gallery” or the “Styles and Formatting” window, always the icons of the sidebar are displayed too. Especially if you need the full width of your monitor, e.g. with a laptop or if 2 pages or 2 windows of different apps should be displayed, this is disadvantageous. Styles and Formatting was vertical - anyway for me ;) But you can make the side bar floating. Does that help? ... To my opinion this is a regression to former versions. Hence it should be possible to close and/or to hide the bar with the sidebar icons even if the Gallery or the Styles window is displayed. Hmm. has been chosen to be this way by the UX team. I hope floating side bar is fine enough. Apart from that- future plans for all floating and customising panels are there too... Cheers - Cor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39316] Data corruption in array formulas
https://bugs.freedesktop.org/show_bug.cgi?id=39316 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #11 from Beluga todven...@suomi24.fi --- Confirmed. Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ Build ID: 07e84cae983c08afdba03018413a19d01abb3006 TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-19_06:15:38 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52247] WMF file renders with inverted colors when added as shape fill.
https://bugs.freedesktop.org/show_bug.cgi?id=52247 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #3 from Beluga todven...@suomi24.fi --- It now imports correctly - WFM. Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ Build ID: 07e84cae983c08afdba03018413a19d01abb3006 TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-19_06:15:38 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88754] tooltips are not displayed in tracked changes
https://bugs.freedesktop.org/show_bug.cgi?id=88754 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added CC||c...@nouenoff.nl --- Comment #2 from Cor Nouws c...@nouenoff.nl --- Hi Reinhard, Thanks for reporting... I cannot confirm however. 4.4.0.2 Ubuntu 32 bits: the tool tips are just there when I hover the recorded changes.. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76231] Tamil letters wrong display in latha font
https://bugs.freedesktop.org/show_bug.cgi?id=76231 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #103502|application/octet-stream|application/x-font-ttf mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 30716] Engineering Notation
https://bugs.freedesktop.org/show_bug.cgi?id=30716 --- Comment #25 from mos...@nc.rr.com --- No progress in Linux x64 4.3.5.2. Still missing. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47349] EDITING: Can't point and select cell from sheet with freeze window
https://bugs.freedesktop.org/show_bug.cgi?id=47349 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #7 from Beluga todven...@suomi24.fi --- No problem anymore. Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ Build ID: 07e84cae983c08afdba03018413a19d01abb3006 TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-19_06:15:38 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sc/source
sc/source/ui/dbgui/tpsort.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 726ffc4334112069d6cc65f908b1425a3cf9d69e
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jan 23 14:42:28 2015 +
Resolves: fdo#88735 crash after calling sort after subtotal removal
Change-Id: Ia30271426ea47b7bf5af85d16591a02e6d52b3d9
(cherry picked from commit 0442cd217645aa4fdd924e4c2e4f90a77f1fbbad)
Reviewed-on: https://gerrit.libreoffice.org/14139
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
diff --git a/sc/source/ui/dbgui/tpsort.cxx b/sc/source/ui/dbgui/tpsort.cxx
index b6e3a52..83bb2b6 100644
--- a/sc/source/ui/dbgui/tpsort.cxx
+++ b/sc/source/ui/dbgui/tpsort.cxx
@@ -150,7 +150,7 @@ void ScTabPageSortFields::Reset( const SfxItemSet* /*
rArgSet */ )
FillFieldLists(0);
// ListBox selection:
-if ( aSortData.maKeyState[0].bDoSort )
+if (!aSortData.maKeyState.empty() aSortData.maKeyState[0].bDoSort)
{
// Make sure that the all sort keys are reset
for ( sal_uInt16 i=nSortKeyCount; iaSortData.GetSortKeyCount(); i++ )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/app/transobj.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 0efbd9931ea854cf71c4c54ca3f3d55d6db1fa13
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jan 23 16:45:51 2015 +
Resolves: fdo#75565 reduce block on pasting rtf like we do for html
Change-Id: I74a9748a2e4981dc5d1677f06db7eceed9e4b108
diff --git a/sc/source/ui/app/transobj.cxx b/sc/source/ui/app/transobj.cxx
index 1d7f57c..f76f3b9 100644
--- a/sc/source/ui/app/transobj.cxx
+++ b/sc/source/ui/app/transobj.cxx
@@ -287,8 +287,9 @@ bool ScTransferObj::GetData( const
datatransfer::DataFlavor rFlavor, const OUSt
bool bIncludeFiltered = pDoc-IsCutMode() || bUsedForLink;
+bool bReduceBlockFormat = nFormat == SOT_FORMATSTR_ID_HTML ||
nFormat == SOT_FORMAT_RTF;
ScRange aReducedBlock = aBlock;
-if ( nFormat == SOT_FORMATSTR_ID_HTML (aBlock.aEnd.Col() ==
MAXCOL || aBlock.aEnd.Row() == MAXROW) aBlock.aStart.Tab() ==
aBlock.aEnd.Tab() )
+if (bReduceBlockFormat (aBlock.aEnd.Col() == MAXCOL ||
aBlock.aEnd.Row() == MAXROW) aBlock.aStart.Tab() == aBlock.aEnd.Tab())
{
bool bShrunk = false;
//shrink the area to allow pasting to external applications
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 42139] PDF export adopts the theme of the Desktop Environment
https://bugs.freedesktop.org/show_bug.cgi?id=42139 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #4 from Beluga todven...@suomi24.fi --- I can't reproduce, but I don't get a dark background in Draw with a dark theme (Ambiance-Blackout). Ubuntu 14.10 64-bit Version: 4.3.3.2 Build ID: 430m0(Build:2) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - ucb/source
ucb/source/ucp/webdav/SerfCallbacks.hxx|2 +-
ucb/source/ucp/webdav/SerfCopyReqProcImpl.cxx |2 +-
ucb/source/ucp/webdav/SerfDeleteReqProcImpl.cxx|2 +-
ucb/source/ucp/webdav/SerfMkColReqProcImpl.cxx |2 +-
ucb/source/ucp/webdav/SerfMoveReqProcImpl.cxx |2 +-
ucb/source/ucp/webdav/SerfPostReqProcImpl.cxx |2 +-
ucb/source/ucp/webdav/SerfPutReqProcImpl.cxx |2 +-
ucb/source/ucp/webdav/SerfRequestProcessor.hxx |2 +-
ucb/source/ucp/webdav/SerfRequestProcessorImpl.hxx |2 +-
ucb/source/ucp/webdav/SerfSession.cxx |2 +-
ucb/source/ucp/webdav/SerfTypes.hxx|2 +-
ucb/source/ucp/webdav/SerfUri.hxx |2 +-
12 files changed, 12 insertions(+), 12 deletions(-)
New commits:
commit 44fda43ca6846b25201eaa7812eb90fc7f79faac
Author: Pedro Giffuni p...@apache.org
Date: Fri Jan 23 17:44:53 2015 +
Fix webdav build with external serf.
Building with external serf (which is recommended) has been
broken for a while. Restore the proper include paths for
the external serf to work.
While testing this change, I noticed that downloading the old serf
can fail breaking the build but this is unrelated to this patch.
Authors:Don Lewis, maho@
Obtained from: FreeBSD port
diff --git a/ucb/source/ucp/webdav/SerfCallbacks.hxx
b/ucb/source/ucp/webdav/SerfCallbacks.hxx
index 0f94c6a..840e3a3 100644
--- a/ucb/source/ucp/webdav/SerfCallbacks.hxx
+++ b/ucb/source/ucp/webdav/SerfCallbacks.hxx
@@ -23,7 +23,7 @@
#ifndef INCLUDED_CALLBACKS_HXX
#define INCLUDED_CALLBACKS_HXX
-#include serf/serf.h
+#include serf.h
extern C apr_status_t Serf_ConnectSetup( apr_socket_t *skt,
serf_bucket_t **read_bkt,
diff --git a/ucb/source/ucp/webdav/SerfCopyReqProcImpl.cxx
b/ucb/source/ucp/webdav/SerfCopyReqProcImpl.cxx
index a883e2c..4cb0796 100644
--- a/ucb/source/ucp/webdav/SerfCopyReqProcImpl.cxx
+++ b/ucb/source/ucp/webdav/SerfCopyReqProcImpl.cxx
@@ -24,7 +24,7 @@
#include SerfCopyReqProcImpl.hxx
-#include serf/serf.h
+#include serf.h
namespace http_dav_ucp
{
diff --git a/ucb/source/ucp/webdav/SerfDeleteReqProcImpl.cxx
b/ucb/source/ucp/webdav/SerfDeleteReqProcImpl.cxx
index 11148d8..54b7190 100644
--- a/ucb/source/ucp/webdav/SerfDeleteReqProcImpl.cxx
+++ b/ucb/source/ucp/webdav/SerfDeleteReqProcImpl.cxx
@@ -24,7 +24,7 @@
#include SerfDeleteReqProcImpl.hxx
-#include serf/serf.h
+#include serf.h
namespace http_dav_ucp
{
diff --git a/ucb/source/ucp/webdav/SerfMkColReqProcImpl.cxx
b/ucb/source/ucp/webdav/SerfMkColReqProcImpl.cxx
index 9b73e9c..14692e1 100644
--- a/ucb/source/ucp/webdav/SerfMkColReqProcImpl.cxx
+++ b/ucb/source/ucp/webdav/SerfMkColReqProcImpl.cxx
@@ -24,7 +24,7 @@
#include SerfMkColReqProcImpl.hxx
-#include serf/serf.h
+#include serf.h
namespace http_dav_ucp
{
diff --git a/ucb/source/ucp/webdav/SerfMoveReqProcImpl.cxx
b/ucb/source/ucp/webdav/SerfMoveReqProcImpl.cxx
index 91a5463..391313f 100644
--- a/ucb/source/ucp/webdav/SerfMoveReqProcImpl.cxx
+++ b/ucb/source/ucp/webdav/SerfMoveReqProcImpl.cxx
@@ -24,7 +24,7 @@
#include SerfMoveReqProcImpl.hxx
-#include serf/serf.h
+#include serf.h
namespace http_dav_ucp
{
diff --git a/ucb/source/ucp/webdav/SerfPostReqProcImpl.cxx
b/ucb/source/ucp/webdav/SerfPostReqProcImpl.cxx
index 5d5e71d..e9a55d0 100644
--- a/ucb/source/ucp/webdav/SerfPostReqProcImpl.cxx
+++ b/ucb/source/ucp/webdav/SerfPostReqProcImpl.cxx
@@ -24,7 +24,7 @@
#include SerfPostReqProcImpl.hxx
-#include serf/serf.h
+#include serf.h
using namespace com::sun::star;
diff --git a/ucb/source/ucp/webdav/SerfPutReqProcImpl.cxx
b/ucb/source/ucp/webdav/SerfPutReqProcImpl.cxx
index a3f5fba..f24f68d 100644
--- a/ucb/source/ucp/webdav/SerfPutReqProcImpl.cxx
+++ b/ucb/source/ucp/webdav/SerfPutReqProcImpl.cxx
@@ -26,7 +26,7 @@
#include SerfPutReqProcImpl.hxx
-#include serf/serf.h
+#include serf.h
namespace http_dav_ucp
{
diff --git a/ucb/source/ucp/webdav/SerfRequestProcessor.hxx
b/ucb/source/ucp/webdav/SerfRequestProcessor.hxx
index c2ab235..673eb39 100644
--- a/ucb/source/ucp/webdav/SerfRequestProcessor.hxx
+++ b/ucb/source/ucp/webdav/SerfRequestProcessor.hxx
@@ -26,7 +26,7 @@
#include apr_errno.h
#include apr_pools.h
-#include serf/serf.h
+#include serf.h
#include DAVTypes.hxx
#include DAVResource.hxx
diff --git a/ucb/source/ucp/webdav/SerfRequestProcessorImpl.hxx
b/ucb/source/ucp/webdav/SerfRequestProcessorImpl.hxx
index 57611ec..96b0d51 100644
--- a/ucb/source/ucp/webdav/SerfRequestProcessorImpl.hxx
+++ b/ucb/source/ucp/webdav/SerfRequestProcessorImpl.hxx
@@ -22,7 +22,7 @@
#ifndef INCLUDED_SERFREQUESTPROCESSORIMPL_HXX
#define INCLUDED_SERFREQUESTPROCESSORIMPL_HXX
-#include serf/serf.h
+#include serf.h
#include sal/types.h
#include DAVRequestEnvironment.hxx
diff --git a/ucb/source/ucp/webdav/SerfSession.cxx
[Libreoffice-bugs] [Bug 37327] Bad alignment when topMargin of a formula change
https://bugs.freedesktop.org/show_bug.cgi?id=37327 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #4 from Beluga todven...@suomi24.fi --- Reproduced using the Step into (F8) through the whole macro in the macro editor. Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ Build ID: 07e84cae983c08afdba03018413a19d01abb3006 TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-19_06:15:38 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - configure.ac
configure.ac |2 ++ 1 file changed, 2 insertions(+) New commits: commit af30252902520375255ed01ba9d8fae3706fd691 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jan 23 15:55:24 2015 +0100 Related rhbz#1185307: One more location to look for Hamcrest jar Change-Id: I307a009c14dd5cd946b39fbfb80ffc3962a7739b (cherry picked from commit 8419fa8c28dd9c5f64a72d28d561b3817d781232) Reviewed-on: https://gerrit.libreoffice.org/14143 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/configure.ac b/configure.ac index 4a1ac6f..42dc3b4 100644 --- a/configure.ac +++ b/configure.ac @@ -12059,6 +12059,8 @@ if test $ENABLE_JAVA != -a $with_junit != no; then if test $with_hamcrest = yes; then if test -e /usr/share/lib/java/hamcrest.jar; then HAMCREST_JAR=/usr/share/lib/java/hamcrest.jar +elif test -e /usr/share/java/hamcrest/core.jar; then +HAMCREST_JAR=/usr/share/java/hamcrest/core.jar else HAMCREST_JAR=/usr/share/java/hamcrest.jar fi ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 75565] CRASH: LO crash when copypaste a column from Calc to Writer as formated text (rtf)
https://bugs.freedesktop.org/show_bug.cgi?id=75565 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Caolán McNamara caol...@redhat.com --- We shrink the block for html paste already, so extended it for rtf too -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40472] FORMATTING: Cannot format the DataPilot headers
https://bugs.freedesktop.org/show_bug.cgi?id=40472 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #5 from Beluga todven...@suomi24.fi --- Yep, the colors disappear after sorting in attachment 59808. Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ Build ID: 07e84cae983c08afdba03018413a19d01abb3006 TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-19_06:15:38 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 34555] Make cropping handles for images (as in Draw/Impress) available for all LibreOffice applications
https://bugs.freedesktop.org/show_bug.cgi?id=34555 --- Comment #50 from Laurent Charrière lcharri...@gmail.com --- (In reply to wepmaschda from comment #14) The files (draw) http://cgit.freedesktop.org/libreoffice/core/tree/svx/source/tbxctrls/ grafctrl.cxx and (writer) http://cgit.freedesktop.org/libreoffice/core/tree/sw/source/ui/shells/grfsh. cxx are quite similar. There are blocks labeled SID_ATTR_GRAF_CROP in SvxGrafAttrHelper::ExecuteGrafAttr() and SvxGrafAttrHelper::GetGrafAttrState() in the first file. So I started looking into this, and I think that SID_ATTR_GRAF_CROP is used when cropping with the dialog, but I don't think it's used when doing an interactive crop. I added debug statements here and there when doing a crop in Draw, and the relevant SID is SID_OBJECT_CROP. Unfortunately this is not used in Writer. I'm able to add a new 'Crop Image' option in the context menu for inserted images in Writer, but then the problem becomes that Writer and Draw don't seem to use the same data structure to insert graphics, and it looks like only the one in Draw supports interactive crop. Details follow: In Draw, once SID_OBJECT_CROP is sent, eventually what happens is that FuSelection::Activate() sets the drag mode SDRDRAG_CROP on mpView. SdrMarkView::SetDragMode get called. In turns, it calls SdrMarkView::SetMarkHandles(). In that method, there is to test to see if pMarkedObj is an instance of SdrGrafObj. When true, the instance of SdrGrafObj is responsible for handling crop (according to the comments). This is true in Draw, but not in Writer. In Writer, pMarkedObj is a SwVirtFlyDrawObj. I'm stuck at this point. I don't know how to make the SwVirtFlyDrawObj draw the crop handles. Interestingly enough, while the handles are not drawn, the corner of an inserted image are draggable, and the cursor is changed to the cropping cursor. But there is no visible cropping taking place as in Draw. As a side note, OpenOffice.org has a whole page devoted to an ongoing refactoring of Writer's usage of the Drawing layer at https://wiki.openoffice.org/wiki/Refactoring_of_Writer%27s_usage_of_the_Drawing_layer. I think this may be related. I would appreciate any pointers on how to keep proceeding with this bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 34555] Make cropping handles for images (as in Draw/Impress) available for all LibreOffice applications
https://bugs.freedesktop.org/show_bug.cgi?id=34555 --- Comment #50 from Laurent Charrière lcharri...@gmail.com --- (In reply to wepmaschda from comment #14) The files (draw) http://cgit.freedesktop.org/libreoffice/core/tree/svx/source/tbxctrls/ grafctrl.cxx and (writer) http://cgit.freedesktop.org/libreoffice/core/tree/sw/source/ui/shells/grfsh. cxx are quite similar. There are blocks labeled SID_ATTR_GRAF_CROP in SvxGrafAttrHelper::ExecuteGrafAttr() and SvxGrafAttrHelper::GetGrafAttrState() in the first file. So I started looking into this, and I think that SID_ATTR_GRAF_CROP is used when cropping with the dialog, but I don't think it's used when doing an interactive crop. I added debug statements here and there when doing a crop in Draw, and the relevant SID is SID_OBJECT_CROP. Unfortunately this is not used in Writer. I'm able to add a new 'Crop Image' option in the context menu for inserted images in Writer, but then the problem becomes that Writer and Draw don't seem to use the same data structure to insert graphics, and it looks like only the one in Draw supports interactive crop. Details follow: In Draw, once SID_OBJECT_CROP is sent, eventually what happens is that FuSelection::Activate() sets the drag mode SDRDRAG_CROP on mpView. SdrMarkView::SetDragMode get called. In turns, it calls SdrMarkView::SetMarkHandles(). In that method, there is to test to see if pMarkedObj is an instance of SdrGrafObj. When true, the instance of SdrGrafObj is responsible for handling crop (according to the comments). This is true in Draw, but not in Writer. In Writer, pMarkedObj is a SwVirtFlyDrawObj. I'm stuck at this point. I don't know how to make the SwVirtFlyDrawObj draw the crop handles. Interestingly enough, while the handles are not drawn, the corner of an inserted image are draggable, and the cursor is changed to the cropping cursor. But there is no visible cropping taking place as in Draw. As a side note, OpenOffice.org has a whole page devoted to an ongoing refactoring of Writer's usage of the Drawing layer at https://wiki.openoffice.org/wiki/Refactoring_of_Writer%27s_usage_of_the_Drawing_layer. I think this may be related. I would appreciate any pointers on how to keep proceeding with this bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88760] Accessibility: Calc crashes when Orca speaks some cells
https://bugs.freedesktop.org/show_bug.cgi?id=88760 --- Comment #1 from Jean-Philippe MENGUAL te...@accelibreinfo.eu --- Created attachment 112741 -- https://bugs.freedesktop.org/attachment.cgi?id=112741action=edit Test file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88743] type of border lines of cells changes when saved in .xls format
https://bugs.freedesktop.org/show_bug.cgi?id=88743 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|unspecified |4.3.5.2 release Ever confirmed|0 |1 --- Comment #4 from raal r...@post.cz --- I can confirm with Version: 4.5.0.0.alpha0+ Build ID: 60143f4f7bc50054dcef923218b8c7c3bc154933 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-01-21_04:58:34 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88760] New: Accessibility: Calc crashes when Orca speaks some cells
https://bugs.freedesktop.org/show_bug.cgi?id=88760 Bug ID: 88760 Summary: Accessibility: Calc crashes when Orca speaks some cells Product: LibreOffice Version: 4.3.3.2 release Hardware: Other OS: Linux (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Spreadsheet Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: te...@accelibreinfo.eu Created attachment 112738 -- https://bugs.freedesktop.org/attachment.cgi?id=112738action=edit Test file Hi, From LO 4.3.3, Orca 3.14, steps to reproduce: 1. Open the attach file with Orca enabled. 2. ctrl-home 3. Down arrow key, until A11 When the speech synthetiser is enabled, on A11, LO crashes. Without speech, it's not systematic. I attach the traceback too. Regards, -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87467] Writer Locks up on Save As if that's the first command after opening a doc
https://bugs.freedesktop.org/show_bug.cgi?id=87467 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #4 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to whomovedmywineandcheese from comment #0) When opening an existing document, making changes and then trying to Save As, the Save As dialog box opens up, then then becomes unresponsive and never works. I then have to shut Writer down through Task Manager, reopen Writer and try to recover the document, but none of my edits are ever saved. Hi who*, LO 4.2 is now EOL, so it would be great if you could grab LO 4.3.x or 4.4.x and see if you can still reproduce the problem with a more recent build. https://www.libreoffice.org/download/ Status - NEEDINFO (please change status back to UNCONFIRMED after you test. thanks!) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - external_deps.lst
external_deps.lst |1 + 1 file changed, 1 insertion(+) New commits: commit 1c1efea327d26d61e3feccbd0ee0275707ba997d Author: Pedro Giffuni p...@apache.org Date: Fri Jan 23 18:45:39 2015 + Update URL2 for croscorefonts. We have been carrying the newer fonts for a while in the backup repository along with other candidates. diff --git a/external_deps.lst b/external_deps.lst index 8395e7c..c679394 100644 --- a/external_deps.lst +++ b/external_deps.lst @@ -243,6 +243,7 @@ if (WITH_CATA_FONTS==YES) MD5 = cfa8bec07bf5b6856dd20f0cb28b3929 name = croscorefonts-1.23.0.tar.gz URL1 = http://gsdview.appspot.com/chromeos-localmirror/distfiles/$(name) +URL2 = $(OOO_EXTRAS)$(MD5)-$(name) if ( true ) MD5 = fdb27bfe2dbe2e7b57ae194d9bf36bab ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3-6' - sc/source
sc/source/core/data/documen4.cxx |3 ++-
sc/source/core/data/documentimport.cxx |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
New commits:
commit 8c191fa956ec650296a351695ff10f8f8e536ca9
Author: Eike Rathke er...@redhat.com
Date: Fri Jan 23 14:28:54 2015 +0100
fix abuse of OUStringBuffer(int) ctor
Partial backport of 853c2fc71a96755a9dee629fd5d0e1cff9a48034
Change-Id: I14e26da332a829c6381ee9e07571171ebebe0ac0
Reviewed-on: https://gerrit.libreoffice.org/14134
Tested-by: Caolán McNamara caol...@redhat.com
Reviewed-by: Michael Stahl mst...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
diff --git a/sc/source/core/data/documen4.cxx b/sc/source/core/data/documen4.cxx
index 6e0da40..17b54985 100644
--- a/sc/source/core/data/documen4.cxx
+++ b/sc/source/core/data/documen4.cxx
@@ -375,7 +375,8 @@ void ScDocument::InsertTableOp(const ScTabOpParam rParam,
// Mehrfachopera
}
ScRefAddress aRef;
-OUStringBuffer aForString('=');
+OUStringBuffer aForString;
+aForString.append('=');
aForString.append(ScCompiler::GetNativeSymbol(ocTableOp));
aForString.append(ScCompiler::GetNativeSymbol( ocOpen));
diff --git a/sc/source/core/data/documentimport.cxx
b/sc/source/core/data/documentimport.cxx
index 32ff6fb..5f285cb 100644
--- a/sc/source/core/data/documentimport.cxx
+++ b/sc/source/core/data/documentimport.cxx
@@ -333,7 +333,8 @@ void ScDocumentImport::setTableOpCells(const ScRange
rRange, const ScTabOpParam
ScDocument* pDoc = mpImpl-mrDoc;
ScRefAddress aRef;
-OUStringBuffer aFormulaBuf('=');
+OUStringBuffer aFormulaBuf;
+aFormulaBuf.append('=');
aFormulaBuf.append(ScCompiler::GetNativeSymbol(ocTableOp));
aFormulaBuf.append(ScCompiler::GetNativeSymbol(ocOpen));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3-6' - sc/source
sc/source/ui/dbgui/PivotLayoutTreeList.cxx | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
New commits:
commit 44ee9731b6ac11699cb9066a8577aba32cab7ab9
Author: Caolán McNamara caol...@redhat.com
Date: Thu Jan 22 13:39:21 2015 +
Resolves: fdo#88455 delete in empty data field crashes
Change-Id: I399bf576fe89283f839842959f06b8fe83f13b2b
(cherry picked from commit 66df4d7d309ce237e4979d57b1069659ece1e3a5)
Reviewed-on: https://gerrit.libreoffice.org/14110
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sc/source/ui/dbgui/PivotLayoutTreeList.cxx
b/sc/source/ui/dbgui/PivotLayoutTreeList.cxx
index 32c55ce..4c6121e 100644
--- a/sc/source/ui/dbgui/PivotLayoutTreeList.cxx
+++ b/sc/source/ui/dbgui/PivotLayoutTreeList.cxx
@@ -38,7 +38,11 @@ void ScPivotLayoutTreeList::Setup(ScPivotLayoutDialog*
pParent, SvPivotTreeListT
bool ScPivotLayoutTreeList::DoubleClickHdl()
{
-ScItemValue* pCurrentItemValue = (ScItemValue*)
GetCurEntry()-GetUserData();
+SvTreeListEntry* pEntry = GetCurEntry();
+if (!pEntry)
+return false;
+
+ScItemValue* pCurrentItemValue = (ScItemValue*) pEntry-GetUserData();
ScPivotFuncData rCurrentFunctionData = pCurrentItemValue-maFunctionData;
if (mpParent-IsDataElement(rCurrentFunctionData.mnCol))
@@ -105,11 +109,12 @@ void ScPivotLayoutTreeList::KeyInput(const KeyEvent
rKeyEvent)
KeyCode aCode = rKeyEvent.GetKeyCode();
sal_uInt16 nCode = aCode.GetCode();
-switch (nCode)
+if (nCode == KEY_DELETE)
{
-case KEY_DELETE:
-GetModel()-Remove(GetCurEntry());
-return;
+const SvTreeListEntry* pEntry = GetCurEntry();
+if (pEntry)
+GetModel()-Remove(pEntry);
+return;
}
SvTreeListBox::KeyInput(rKeyEvent);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sc/source
sc/source/ui/view/gridwin.cxx | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
New commits:
commit a93e7bcfa6498dc8aa6c2cc69148664cd210554a
Author: Eike Rathke er...@redhat.com
Date: Mon Jan 12 14:52:47 2015 +0100
make this work also for an overlapping merge range, fdo#87382 follow-up
... if the merged range ends behind the visble range.
(cherry picked from commit e4fea6e67a05256c3ce6336bf054004015936310)
get rid of C-style cast, fdo#87382 follow-up
(cherry picked from commit 5865ab6bd27425912e2752020a966e2aac3279e5)
86dd6a96f69d9bedeabeebc04f953b9f22476543
Change-Id: Ib5e9ae57299614f42c9200da5641922dfd90ab60
Reviewed-on: https://gerrit.libreoffice.org/13877
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 9ea1d21..031cd0e 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -5741,17 +5741,28 @@ void ScGridWindow::UpdateCursorOverlay()
SCROW nY = pViewData-GetCurY();
ScDocument* pDoc = pViewData-GetDocument();
-const ScMergeAttr* pMerge = (const ScMergeAttr*) pDoc-GetAttr(nX, nY,
nTab, ATTR_MERGE);
+const ScPatternAttr* pPattern = pDoc-GetPattern(nX,nY,nTab);
-// fdo#87382 Also display the cell cursor for the visible part of merged
-// cells if the cell position is part of merged cells.
-if (!(maVisibleRange.isInside(nX, nY) ||
-maVisibleRange.isInside(nX + pMerge-GetColMerge(), nY +
pMerge-GetRowMerge(
-return;
+if (!maVisibleRange.isInside(nX, nY))
+{
+if (maVisibleRange.mnCol2 nX || maVisibleRange.mnRow2 nY)
+return; // no further check needed, nothing visible
+
+// fdo#87382 Also display the cell cursor for the visible part of
+// merged cells if the view position is part of merged cells.
+const ScMergeAttr rMerge = static_castconst
ScMergeAttr(pPattern-GetItem(ATTR_MERGE));
+if (rMerge.GetColMerge() = 1 rMerge.GetRowMerge() = 1)
+return; // not merged and invisible
+
+SCCOL nX2 = nX + rMerge.GetColMerge() - 1;
+SCROW nY2 = nY + rMerge.GetRowMerge() - 1;
+// Check if the middle or tail of the merged range is visible.
+if (!(maVisibleRange.mnCol1 = nX2 maVisibleRange.mnRow1 = nY2))
+return; // no visible part
+}
// don't show the cursor in overlapped cells
-const ScPatternAttr* pPattern = pDoc-GetPattern(nX,nY,nTab);
const ScMergeFlagAttr rMergeFlag = static_castconst ScMergeFlagAttr(
pPattern-GetItem(ATTR_MERGE_FLAG) );
bool bOverlapped = rMergeFlag.IsOverlapped();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - dbaccess/source
dbaccess/source/core/api/RowSetBase.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 2e44619d919b60fabf0fc528d6e0ac5c997069c0 Author: Lionel Elie Mamane lio...@mamane.lu Date: Thu Jan 22 13:42:13 2015 +0100 fdo#88475 RowSetBase: reposition cache before interrogating it This partially reverts: commit d20232a77565f46fedc0b556f4d50addff4d3559 Author: Lionel Elie Mamane lio...@mamane.lu Date: Thu Dec 6 13:22:06 2012 +0100 Don't force refresh when higher up code did not request it Change-Id: I0f415c96fc05c1d776d14885751aef020c42f4ae which did not take into account that the cache is shared with the clones. This is not a cherry-pick from master, but a more conservative version of commit d7c9a1d9d65fe8b1a56c5c280d2ca6640a549d2f. Change-Id: I1fa5c3169806760d35dd07e1fc1b8d5522dd3641 Reviewed-on: https://gerrit.libreoffice.org/14102 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/dbaccess/source/core/api/RowSetBase.cxx b/dbaccess/source/core/api/RowSetBase.cxx index 57a3dc1..584bb02 100644 --- a/dbaccess/source/core/api/RowSetBase.cxx +++ b/dbaccess/source/core/api/RowSetBase.cxx @@ -657,6 +657,7 @@ sal_Bool SAL_CALL ORowSetBase::isFirst( ) throw(SQLException, RuntimeException, if ( impl_rowDeleted() ) return ( m_nDeletedPosition == 1 ); +positionCache( MOVE_NONE_REFRESH_ONLY ); bool bIsFirst = m_pCache-isFirst(); SAL_INFO(dbaccess, ORowSetBase::isFirst() = bIsFirst Clone = m_bClone); @@ -686,6 +687,7 @@ sal_Bool SAL_CALL ORowSetBase::isLast( ) throw(SQLException, RuntimeException, return ( m_nDeletedPosition == impl_getRowCount() ); } +positionCache( MOVE_NONE_REFRESH_ONLY ); bool bIsLast = m_pCache-isLast(); SAL_INFO(dbaccess, ORowSetBase::isLast() = bIsLast Clone = m_bClone); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 87382] Improper display of selected merged cells when left most cell is not in the visible window.
https://bugs.freedesktop.org/show_bug.cgi?id=87382 --- Comment #8 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Eike Rathke committed a patch related to this issue. It has been pushed to libreoffice-4-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a93e7bcfa6498dc8aa6c2cc69148664cd210554ah=libreoffice-4-4 make this work also for an overlapping merge range, fdo#87382 follow-up It will be available in 4.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basic/qa
basic/qa/basic_coverage/test_mid_CountNegative_3args.vb| 15 + basic/qa/basic_coverage/test_mid_StartOutOfBounds_2args.vb | 15 + 2 files changed, 30 insertions(+) New commits: commit 4e00df4f0b05b3d6c8f185e08499d40964e7182f Author: Julien Nabet serval2...@yahoo.fr Date: Tue Dec 30 22:23:51 2014 +0100 Related fdo#87834: add 2 unit tests Change-Id: I4735b15c9535dc17665629510fdafe3dd4086e0b Reviewed-on: https://gerrit.libreoffice.org/13708 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/basic/qa/basic_coverage/test_mid_CountNegative_3args.vb b/basic/qa/basic_coverage/test_mid_CountNegative_3args.vb new file mode 100644 index 000..d673706 --- /dev/null +++ b/basic/qa/basic_coverage/test_mid_CountNegative_3args.vb @@ -0,0 +1,15 @@ +' +' This file is part of the LibreOffice project. +' +' This Source Code Form is subject to the terms of the Mozilla Public +' License, v. 2.0. If a copy of the MPL was not distributed with this +' file, You can obtain one at http://mozilla.org/MPL/2.0/. +' + +Function doUnitTest as Integer +If (Mid(abc, 5, -3) = ) Then +doUnitTest = 1 +Else +doUnitTest = 0 +End If +End Function diff --git a/basic/qa/basic_coverage/test_mid_StartOutOfBounds_2args.vb b/basic/qa/basic_coverage/test_mid_StartOutOfBounds_2args.vb new file mode 100644 index 000..5ab01f9 --- /dev/null +++ b/basic/qa/basic_coverage/test_mid_StartOutOfBounds_2args.vb @@ -0,0 +1,15 @@ +' +' This file is part of the LibreOffice project. +' +' This Source Code Form is subject to the terms of the Mozilla Public +' License, v. 2.0. If a copy of the MPL was not distributed with this +' file, You can obtain one at http://mozilla.org/MPL/2.0/. +' + +Function doUnitTest as Integer +If (Mid(abc, 5) = ) Then +doUnitTest = 1 +Else +doUnitTest = 0 +End If +End Function ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: basic/source
basic/source/runtime/methods.cxx | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
New commits:
commit b7d02d7a5a374da3e01e0abc4022fba35daa1840
Author: Julien Nabet serval2...@yahoo.fr
Date: Tue Dec 30 21:48:21 2014 +0100
Resolves fdo#87834: strange behavior of mid()-function
See https://bugs.freedesktop.org/show_bug.cgi?id=87834
Thank you Michael Büssow for pointing these cases
Change-Id: I3a9b58360ddab529d1fb2f7eeba7f1c7ae69ba7c
Reviewed-on: https://gerrit.libreoffice.org/13707
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index 2817815..d3928a5 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -1205,7 +1205,7 @@ RTLFUNC(Mid)
}
OUString aArgStr = rPar.Get(1)-GetOUString();
sal_Int32 nStartPos = rPar.Get(2)-GetLong();
-if ( nStartPos == 0 )
+if ( nStartPos 1 )
{
StarBASIC::Error( SbERR_BAD_ARGUMENT );
}
@@ -1279,12 +1279,18 @@ RTLFUNC(Mid)
else
{
OUString aResultStr;
-if(nLen 0)
+if (nStartPos aArgStr.getLength())
+{
+aResultStr = ;
+}
+else if(nArgCount == 2)
{
aResultStr = aArgStr.copy( nStartPos);
}
else
{
+if (nLen 0)
+nLen = 0;
if(nStartPos + nLen aArgStr.getLength())
{
nLen = aArgStr.getLength() - nStartPos;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 87834] strange behavior of mid()-function
https://bugs.freedesktop.org/show_bug.cgi?id=87834 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:4.5.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88760] Accessibility: Calc crashes when Orca speaks some cells
https://bugs.freedesktop.org/show_bug.cgi?id=88760 Arnaud Versini arnaud.vers...@libreoffice.org changed: What|Removed |Added Attachment #112738|Test file |Crash backtrace description|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68840] PDF printing with ghostscript: (OUTFILE) is no longer replaced by the intended file name
https://bugs.freedesktop.org/show_bug.cgi?id=68840 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED CC||caol...@redhat.com Ever confirmed|1 |0 --- Comment #11 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Stefan from comment #10) Sorry for the confusion. The correct naming is PDF converter not exporter. And this Command line ist not intended to be run in a terminal but to be used as input in the input field of the dialog Choose a command line in the Add Printer window of the spadmin program. Ah, okay. Now I have a clearer picture of what you're trying to do. AFAIK, as of v4.3 the spadmin program has been removed in lieu of the system printing tools: https://wiki.documentfoundation.org/ReleaseNotes/4.3#CUPS.2C_fax_machines_and_spadmin cc: Caolan -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70268] FILEOPEN: a possible defect in accessing an embedded link to a site that requires authentication
https://bugs.freedesktop.org/show_bug.cgi?id=70268 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to GAJ from comment #7) I would like to let you know that the original report... is no longer an issue for me [etc..] Great! Status - RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - dbaccess/source
dbaccess/source/core/api/RowSetBase.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit db4be3fee9369d8a0bb2df07c25564f19eb564ed Author: Lionel Elie Mamane lio...@mamane.lu Date: Thu Jan 22 13:42:13 2015 +0100 fdo#88475 RowSetBase: reposition cache before interrogating it This partially reverts: commit d20232a77565f46fedc0b556f4d50addff4d3559 Author: Lionel Elie Mamane lio...@mamane.lu Date: Thu Dec 6 13:22:06 2012 +0100 Don't force refresh when higher up code did not request it Change-Id: I0f415c96fc05c1d776d14885751aef020c42f4ae which did not take into account that the cache is shared with the clones. This is not a cherry-pick from master, but a more conservative version of commit d7c9a1d9d65fe8b1a56c5c280d2ca6640a549d2f. Change-Id: I1fa5c3169806760d35dd07e1fc1b8d5522dd3641 Reviewed-on: https://gerrit.libreoffice.org/14104 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/dbaccess/source/core/api/RowSetBase.cxx b/dbaccess/source/core/api/RowSetBase.cxx index 5d9438e..47342a2 100644 --- a/dbaccess/source/core/api/RowSetBase.cxx +++ b/dbaccess/source/core/api/RowSetBase.cxx @@ -657,6 +657,7 @@ sal_Bool SAL_CALL ORowSetBase::isFirst( ) throw(SQLException, RuntimeException, if ( impl_rowDeleted() ) return ( m_nDeletedPosition == 1 ); +positionCache( MOVE_NONE_REFRESH_ONLY ); bool bIsFirst = m_pCache-isFirst(); SAL_INFO(dbaccess, ORowSetBase::isFirst() = bIsFirst Clone = m_bClone); @@ -686,6 +687,7 @@ sal_Bool SAL_CALL ORowSetBase::isLast( ) throw(SQLException, RuntimeException, return ( m_nDeletedPosition == impl_getRowCount() ); } +positionCache( MOVE_NONE_REFRESH_ONLY ); bool bIsLast = m_pCache-isLast(); SAL_INFO(dbaccess, ORowSetBase::isLast() = bIsLast Clone = m_bClone); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dev-tools.git: cppcheck/cppcheck-report.sh
cppcheck/cppcheck-report.sh | 65 +++-
1 file changed, 58 insertions(+), 7 deletions(-)
New commits:
commit ec1c1ddcc8eb03b71e8e69c5c2644a4d80947730
Author: Maarten Hoes hoes.maar...@gmail.com
Date: Wed Jan 21 14:13:11 2015 +0100
redirect output to file, mail it to list on error if mailx is present.
Change-Id: I4e6829cab888376290541adc2a4e03270cabd8ce
Reviewed-on: https://gerrit.libreoffice.org/14074
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/cppcheck/cppcheck-report.sh b/cppcheck/cppcheck-report.sh
index fc9ea32..f018770 100755
--- a/cppcheck/cppcheck-report.sh
+++ b/cppcheck/cppcheck-report.sh
@@ -10,6 +10,13 @@
[ $DEBUG ] set -xv
+# save stdout and stderr
+exec 31 42 /tmp/foo.log 21
+
+# redirect to log file
+exec /tmp/cppcheck-report.log
+exec 21
+
#
# Functions
#
@@ -18,7 +25,9 @@ die()
{
[ $DEBUG ] set -xv
-echo Error: $@ 2
+MESSAGE=$@
+echo Error: ${MESSAGE?} 2
+mail_failure ${MESSAGE?}
exit -1;
}
@@ -108,7 +117,6 @@ get_commit_cppcheck()
popd /dev/null || die Failed to change directory out of
${CPPCHECK_DIR?}
}
-
upload_report()
{
[ $DEBUG ] set -xv
@@ -118,16 +126,57 @@ upload_report()
scp -r ${HTML_DIR?}/*
upl...@dev-builds.libreoffice.org:${UPLOAD_DIR?}/ || die Failed to upload
report to ${UPLOAD_DIR?}
}
+mail_success()
+{
+[ $DEBUG ] set -xv
-#
-# Main
-#
+which mailx /dev/null 21
+if [ $? = 0 ] ; then
+
+mailx -s CppCheck Report update ${MAILTO?} EOF
+
+A new cppcheck report is available at :
http://dev-builds.libreoffice.org/cppcheck_reports/master/
+
+This job was run at `date +%Y-%d-%m_%H:%M:%S` with user `whoami` at host `cat
/etc/hostname` as $MY_NAME
+
+EOF
+
+fi
+}
+mail_failure()
+{
+[ $DEBUG ] set -xv
+MESSAGE=$@
+
+if [ -f /tmp/cppcheck-report.log ] ; then
+cp -f /tmp/cppcheck-report.log ~/cppcheck-report.log
+rm -f ~/cppcheck-report.log.gz
+gzip ~/cppcheck-report.log
+fi
+
+which mailx /dev/null 21
+if [ $? = 0 ] ; then
+
+mailx -s CppCheck Report: Failure ${MAILTO?} EOF
+`uuencode /home/buildslave/cppcheck-report.log.gz
/home/buildslave/cppcheck-report.log.gz`
+
+The cppcheck job failed with message: ${MESSAGE?}
+
+This job was run at `date +%Y-%d-%m_%H:%M:%S` with user `whoami` at host `cat
/etc/hostname` as $MY_NAME
+
+EOF
+
+fi
+}
usage()
{
[ $DEBUG ] set -xv
+# restore stdout and stderr
+exec 13 24
+
echo 2 Usage: lcov-report.sh -s [DIRECTORY] -w [DIRECTORY]
-ssource code directory
-whtml (www) directory
@@ -150,7 +199,9 @@ DATA_DIR=/tmp
CPPCHECK_GIT_URL=git://github.com/danmar/cppcheck.git
LO_GIT_URL=git://anongit.freedesktop.org/libreoffice/core.git
UPLOAD_DIR=/srv/www/dev-builds.libreoffice.org/cppcheck_reports/master
-
+MAILTO=libreoffice@lists.freedesktop.org
+MY_NAME=`dirname $0`
+MESSAGE=
while getopts :s:w:c: opt ; do
case $opt in
@@ -177,4 +228,4 @@ get_commit_lo
build_cppcheck
run_cppcheck
upload_report
-
+mail_success
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 81168] Remove placeholder names for accessible objects
https://bugs.freedesktop.org/show_bug.cgi?id=81168 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||qu...@runcibility.com Component|UI |ux-advise Ever confirmed|0 |1 Whiteboard||a11y Severity|normal |enhancement --- Comment #5 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Christophe Strobbe from comment #1) Anyway, the current behaviour is that LibreOffice always fills in the frame's name (attribute draw:name); when you delete the name and save the file, then reopen the frame options, you will find that LibreOffice has filled in a name. Is there a better way of dealing with this issue than removing the placeholder names? I am thinking specifically of prompting the user to provide a meaningful name when inserting a frame. This would also be useful for many other types of objects. Sounds like a UI/UX discussion about best way to improve a11y, so Status - NEW Component - ux-advise Severity - enhancement -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 81168] Remove placeholder names for accessible objects
https://bugs.freedesktop.org/show_bug.cgi?id=81168 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||qu...@runcibility.com Component|UI |ux-advise Ever confirmed|0 |1 Whiteboard||a11y Severity|normal |enhancement --- Comment #5 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Christophe Strobbe from comment #1) Anyway, the current behaviour is that LibreOffice always fills in the frame's name (attribute draw:name); when you delete the name and save the file, then reopen the frame options, you will find that LibreOffice has filled in a name. Is there a better way of dealing with this issue than removing the placeholder names? I am thinking specifically of prompting the user to provide a meaningful name when inserting a frame. This would also be useful for many other types of objects. Sounds like a UI/UX discussion about best way to improve a11y, so Status - NEW Component - ux-advise Severity - enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87834] strange behavior of mid()-function
https://bugs.freedesktop.org/show_bug.cgi?id=87834 --- Comment #14 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Julien Nabet committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7d02d7a5a374da3e01e0abc4022fba35daa1840 Resolves fdo#87834: strange behavior of mid()-function It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87834] strange behavior of mid()-function
https://bugs.freedesktop.org/show_bug.cgi?id=87834 --- Comment #15 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Julien Nabet committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=4e00df4f0b05b3d6c8f185e08499d40964e7182f Related fdo#87834: add 2 unit tests It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87834] strange behavior of mid()-function
https://bugs.freedesktop.org/show_bug.cgi?id=87834 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88761] New: the Orca screen reader has trouble reading the auto correct dialog box
https://bugs.freedesktop.org/show_bug.cgi?id=88761 Bug ID: 88761 Summary: the Orca screen reader has trouble reading the auto correct dialog box Product: LibreOffice Version: 4.3.5.2 release Hardware: Other OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: am_d...@fastmail.fm When opening the auto-correct dialog and moving to the options tabb orca has trouble reading the replacements and exceptions list box. I notice some checkboxes, however, orca does not tell me what these are when I use the arrow keys to move between them. It only announces the state of the control and not its label. I can see the labels by using the flat review function of orca, however, this isn't the most ideal way to know which setting is being changed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88740] Draw and Impress do not accept changes behind the decimal point in angel of rotation in the sidebar
https://bugs.freedesktop.org/show_bug.cgi?id=88740 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #2 from A (Andy) stgohi-lob...@yahoo.de --- Reproducible with LO 4.4.0.0.beta1, but not reproducible with LO 4.3.5.2, Win 8.1. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88749] EditDelete Contents should not allow to delete Pivot Table
https://bugs.freedesktop.org/show_bug.cgi?id=88749 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 OS|Windows (All) |All --- Comment #2 from raal r...@post.cz --- I can confirm with Version: 4.5.0.0.alpha0+ Build ID: 60143f4f7bc50054dcef923218b8c7c3bc154933 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-01-21_04:58:34 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73933] TABLE: Numbers are shown from left to right in Number range variable when used in RTL scripts.
https://bugs.freedesktop.org/show_bug.cgi?id=73933 --- Comment #6 from safa alfulaij safa1996alful...@gmail.com --- A workaround can be by an option to make LibreOffice reverse the rendering of the numbers. I mean instead of adding 1 then 2, It adds 2 then 1. It's must be an option in everything use placeholders, The numbering lists also. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 15 commits - sw/inc sw/source
sw/inc/viewsh.hxx|8
sw/source/core/crsr/crsrsh.cxx | 10 -
sw/source/core/crsr/viscrs.cxx | 36 ++--
sw/source/core/doc/DocumentDeviceManager.cxx |8 +---
sw/source/core/doc/DocumentStatisticsManager.cxx | 19 --
sw/source/core/doc/docdesc.cxx | 22 ++--
sw/source/core/doc/doclay.cxx| 32 +++---
sw/source/core/doc/notxtfrm.cxx | 40 ++-
sw/source/core/draw/dcontact.cxx | 28
sw/source/core/draw/dpage.cxx| 14 +---
sw/source/core/layout/newfrm.cxx | 12 ++
sw/source/core/text/frmcrsr.cxx |2 -
sw/source/core/view/viewsh.cxx |9 +
sw/source/core/view/vnew.cxx | 16 +++--
sw/source/core/view/vprint.cxx |2 -
15 files changed, 133 insertions(+), 125 deletions(-)
New commits:
commit 0a77c9f15bbb38d8c281daef4512d570683d2cb7
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date: Fri Jan 23 23:11:32 2015 +0100
remove manual iteration in SwViewShell
Change-Id: Id7bd121067e86e4f8e4c3fe584cac05a85f47060
diff --git a/sw/inc/viewsh.hxx b/sw/inc/viewsh.hxx
index 89ebbc6..6a73d55 100644
--- a/sw/inc/viewsh.hxx
+++ b/sw/inc/viewsh.hxx
@@ -586,14 +586,6 @@ public:
/// Are we doing tiled rendering?
bool isTiledRendering();
-SwViewShell* GetNext()
-{ return GetNextInRing(); }
-const SwViewShell* GetNext() const
-{ return GetNextInRing(); }
-SwViewShell* GetPrev()
-{ return GetPrevInRing(); }
-const SwViewShell* GetPrev() const
-{ return GetPrevInRing(); }
};
// manages global ShellPointer
commit 3dbd1e69b94b6e91db5ddc36ed6808d7be0a418c
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date: Fri Jan 23 23:10:43 2015 +0100
do not use manual iteration
Change-Id: If456086bc6195c04794178df22d9c937bb7073b4
diff --git a/sw/source/core/text/frmcrsr.cxx b/sw/source/core/text/frmcrsr.cxx
index c5dead7..4c23e0d 100644
--- a/sw/source/core/text/frmcrsr.cxx
+++ b/sw/source/core/text/frmcrsr.cxx
@@ -119,7 +119,7 @@ bool sw_ChangeOffset( SwTxtFrm* pFrm, sal_Int32 nNew )
SwViewShell* pVsh = pFrm-getRootFrm()-GetCurrShell();
if( pVsh )
{
-if( pVsh-GetNext() != pVsh ||
+if( pVsh-GetRingContainer().size() 1 ||
( pFrm-GetDrawObjs() pFrm-GetDrawObjs()-size() ) )
{
if( !pFrm-GetOfst() )
commit 6bb2f330daab558730c0a1a267ac6d09c746d5ef
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date: Fri Jan 23 23:09:40 2015 +0100
do not use manual iteration
Change-Id: Ia7afbea8872618d070dbdf6029cef3cec2425f2c
diff --git a/sw/source/core/view/vprint.cxx b/sw/source/core/view/vprint.cxx
index ef1d456..80ba9ce16 100644
--- a/sw/source/core/view/vprint.cxx
+++ b/sw/source/core/view/vprint.cxx
@@ -601,7 +601,7 @@ void SwViewShell::PrtOle2( SwDoc *pDoc, const SwViewOption
*pOpt, const SwPrintD
pSh-maVisArea = aSwRect;
if ( pSh-GetViewOptions()-getBrowseMode()
- pSh-GetNext() == pSh )
+ pSh-GetRingContainer().size() == 1 )
{
pSh-CheckBrowseView( false );
pSh-GetLayout()-Lower()-InvalidateSize();
commit f5c6391b2e3ef703bc4d4efd691f79f1605d5283
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date: Fri Jan 23 23:07:01 2015 +0100
do not use manual iteration
Change-Id: I1911b1dec2acd89c104c2b226fb212b7deb40c3b
diff --git a/sw/source/core/view/vnew.cxx b/sw/source/core/view/vnew.cxx
index 31d0de4..6a951a1 100644
--- a/sw/source/core/view/vnew.cxx
+++ b/sw/source/core/view/vnew.cxx
@@ -360,9 +360,19 @@ SwViewShell::~SwViewShell()
if ( mpDoc )
{
GetLayout()-DeRegisterShell( this );
-if(mpDoc-getIDocumentLayoutAccess().GetCurrentViewShell()==this)
-mpDoc-getIDocumentLayoutAccess().SetCurrentViewShell(
this-GetNext()!=this ?
-this-GetNext() : nullptr );
+auto rLayoutAccess(mpDoc-getIDocumentLayoutAccess());
+if(rLayoutAccess.GetCurrentViewShell()==this)
+{
+rLayoutAccess.SetCurrentViewShell(nullptr);
+for(SwViewShell rShell : GetRingContainer())
+{
+if(rShell != this)
+{
+rLayoutAccess.SetCurrentViewShell(rShell);
+break;
+}
+}
+}
}
delete mpTmpRef;
commit 512f85f07dc1483ea3ab328597092ec3170fbeaa
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date: Fri Jan 23 23:06:26 2015 +0100
do not use manual iteration
Change-Id:
[Libreoffice-bugs] [Bug 88706] Tabs not being correctly formatted
https://bugs.freedesktop.org/show_bug.cgi?id=88706 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|unspecified |4.5.0.0.alpha0+ Master Ever confirmed|0 |1 --- Comment #2 from Robinson Tryon (qubit) qu...@runcibility.com --- TESTING with Android 4.4.4 + LO 4.5-master tinderbox: buildname: Android-ARM@24-Bytemark-Hosting tinderbox: tree: MASTER tinderbox: pull time 2015-01-21 08:36:57 tinderbox: git sha1s core:7fe28b2c7b9a1fd5718e1f5b6562cf93902d6be0 (In reply to gips...@gmail.com from comment #0) REPRO Steps: First checking with LO 4.4.0.2 on Ubuntu 14.04 1) Open attachment 112667 2) Check to see if the columns align The columns do appear to align correctly (that eye-burning blue color in the second row is hard to look at!) Now testing on Android 1) Open attachment 112667 2) Check to see if the columns align Using LO 4.5-master (as described above), columns do NOT align, so CONFIRMED. Status - NEW RESULT: The attached file does not align the columns correctly, probably because the tabs are not correctly interpreted. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58434] Display gray background for non-breaking characters only when displaying non-printing characters
https://bugs.freedesktop.org/show_bug.cgi?id=58434 --- Comment #17 from Harald Koester harald.koes...@mail.de --- Created attachment 112753 -- https://bugs.freedesktop.org/attachment.cgi?id=112753action=edit More detailed information about these kind of special characters Meanwhile I found the following sentence in the help: “Field Shadings: Shows or hides field shadings in your document, including non-breaking spaces, custom hyphens, indexes, and footnotes.” If the function will be changed also this text has to be changed. So it seems that it was intended to use the field shading also for formatting marks and hence it would not be a bug in a narrower sense. But to my opinion it is still rather mistakable. So I would appreciate if formatting marks would be highlighted in a different way. In order to get an impression how the different non-printing characters and formatting marks are treated, I examined the current behaviour and created a list with the results. You can find this list inside a document which I will attach to this bug report. My impression is, that there is no clear direction how these special characters are treated. I think the list is not complete, because there are special characters which are used in languages which I do not know. In the list there are also some question marks where I did not know or examine the behaviour. Feel free if you like to complete or enhance the list. Hence the situation is a bit complicated, a more general approach should be considered. Therefore some questions should be answered. In the attached document I added a list with, what I think are the relevant questions together with some more aspects. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36549] ACCESSIBILITY: Tracking bug for issues affecting a11y ATK and GNOME Orca screen reader support
https://bugs.freedesktop.org/show_bug.cgi?id=36549 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||88763 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88763] New: The orca screen reader does not speak control names when navigating in the outline numbering dialog box
https://bugs.freedesktop.org/show_bug.cgi?id=88763 Bug ID: 88763 Summary: The orca screen reader does not speak control names when navigating in the outline numbering dialog box Product: LibreOffice Version: 4.3.5.2 release Hardware: Other OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: am_d...@fastmail.fm When opening the outline numbering dialog box from the tools menu, orca does not speak field names as I tab and shift + tab through the controls. Orca should speak the name of each control as the user navigates between them in this manner. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88754] tooltips are not displayed in tracked changes
https://bugs.freedesktop.org/show_bug.cgi?id=88754 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Cor Nouws c...@nouenoff.nl --- Hi Reinhard, Looking in the options, I see that Options LibreOffice General .. Help tips also toggles this one ;) So I set as WorksForMe. OK? Cor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88764] New: The orca screen reader does not consistantly speak control names when navigating in the paragraph dialog box
https://bugs.freedesktop.org/show_bug.cgi?id=88764 Bug ID: 88764 Summary: The orca screen reader does not consistantly speak control names when navigating in the paragraph dialog box Product: LibreOffice Version: 4.3.5.2 release Hardware: Other OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: am_d...@fastmail.fm When navigating with the tab and shift + tab keyboard commands in the paragraph dialog box, orca does not always speak the control names. It seems to happen more likely when using the shift + tab command, but both seem inconsistant. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88706] Tabs not being correctly formatted
https://bugs.freedesktop.org/show_bug.cgi?id=88706 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Attachment #112667|text/plain |application/vnd.oasis.opend mime type||ocument.text CC||qu...@runcibility.com --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- Comment on attachment 112667 -- https://bugs.freedesktop.org/attachment.cgi?id=112667 File contains 5x4 block repeats of the 100 letters in a Scrabble set fix mimetype -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 44/fda43ca6846b25201eaa7812eb90fc7f79faac
44/fda43ca6846b25201eaa7812eb90fc7f79faac |1 + 1 file changed, 1 insertion(+) New commits: commit 0d20c855ede98f098939f05b3795acda3045fb3b Author: Caolán McNamara caol...@redhat.com Date: Fri Jan 23 20:51:23 2015 + Notes added by 'git notes add' diff --git a/44/fda43ca6846b25201eaa7812eb90fc7f79faac b/44/fda43ca6846b25201eaa7812eb90fc7f79faac new file mode 100644 index 000..87e6e6c --- /dev/null +++ b/44/fda43ca6846b25201eaa7812eb90fc7f79faac @@ -0,0 +1 @@ +prefer: f9f70d95a19f7c139c2f9093e033edd9e6dcf45e ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88760] Accessibility: Calc crashes when Orca speaks some cells
https://bugs.freedesktop.org/show_bug.cgi?id=88760 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #2 from raal r...@post.cz --- I can not confirm with Version: 4.5.0.0.alpha0+ Build ID: 60143f4f7bc50054dcef923218b8c7c3bc154933 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-01-21_04:58:34 Locale: cs_CZ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [libo-marketing-priv] Announcing Pebble Smartwatch Application for LibreOffice Impress
Hi 2015-01-05 22:15 GMT+02:00 Sophie Gautier gautier.sop...@gmail.com: Cloph once done, could we have the project on Pootle so the L10n team take care of it? pebble-remote's pot file is under [1] directory. It would be great to put it on the Document Foundation's Pootle server. Best regards [1] https://gerrit.libreoffice.org/gitweb?p=impress_remote.git;a=tree;f=pebble/po;h=d772e68d66ebc520b0296bd0966be769ce50464a;hb=HEAD -- *Gülşah Köse* *about.me http://about.me/gulsahkose* ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 88702] The orca screen reader no longer announces information about bold, italic, and underline
https://bugs.freedesktop.org/show_bug.cgi?id=88702 --- Comment #1 from Niklas Johansson sleeping.pil...@gmail.com --- I can verify the problem that the toggle buttons always seem to be set to off which clearly is a bug. Note that you can find out if the text at the current position is bold, italic and so on by querying text formatting. Normally that is done by the key combination Orca + F. I'll try to find some time to look at this as soon as possible and get back here with what I find. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
300 new defect(s) introduced to LibreOffice found with Coverity Scan.
16 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 300 defect(s)
** CID 704751: Explicit null dereferenced (FORWARD_NULL)
/sd/source/ui/func/fuoaprms.cxx: 660 in
sd::FuObjectAnimationParameters::DoExecute(SfxRequest )()
** CID 1202761: Unchecked return value (CHECKED_RETURN)
/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx: 827 in
GtkSalGraphics::hitTestNativeControl(unsigned int, unsigned int, const
Rectangle , const Point , bool )()
/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx: 829 in
GtkSalGraphics::hitTestNativeControl(unsigned int, unsigned int, const
Rectangle , const Point , bool )()
/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx: 834 in
GtkSalGraphics::hitTestNativeControl(unsigned int, unsigned int, const
Rectangle , const Point , bool )()
/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx: 836 in
GtkSalGraphics::hitTestNativeControl(unsigned int, unsigned int, const
Rectangle , const Point , bool )()
** CID 1265791: Unchecked return value (CHECKED_RETURN)
/oox/source/export/drawingml.cxx: 871 in
oox::drawingml::DrawingML::WriteImage(const Graphic , bool)()
/oox/source/export/drawingml.cxx: 877 in
oox::drawingml::DrawingML::WriteImage(const Graphic , bool)()
** CID 1265792: Dereference after null check (FORWARD_NULL)
/sw/source/core/text/itrtxt.hxx: 76 in SwTxtIter::SwTxtIter(SwTxtFrm *,
SwTxtInfo *)()
** CID 1265793: Dereference after null check (FORWARD_NULL)
/sw/source/core/text/itrtxt.hxx: 176 in SwTxtMargin::SwTxtMargin(SwTxtFrm *,
SwTxtSizeInfo *)()
** CID 1265794: Dereference null return value (NULL_RETURNS)
/sc/source/ui/app/scmod.cxx: 776 in ScModule::RecentFunctionsChanged()()
** CID 1265795: Dereference null return value (NULL_RETURNS)
** CID 1265796: Dereference null return value (NULL_RETURNS)
** CID 1265797: Dereference null return value (NULL_RETURNS)
** CID 1265798: Dereference null return value (NULL_RETURNS)
** CID 1265799: Dereference null return value (NULL_RETURNS)
** CID 1265800: Dereference null return value (NULL_RETURNS)
/sw/source/uibase/shells/textdrw.cxx: 75 in SwBaseShell::InsertURLButton(const
rtl::OUString , const rtl::OUString , const rtl::OUString )()
** CID 1265801: Dereference null return value (NULL_RETURNS)
** CID 1265802: Dereference null return value (NULL_RETURNS)
** CID 1265803: Dereference null return value (NULL_RETURNS)
** CID 1265804: Dereference null return value (NULL_RETURNS)
** CID 1265805: Dereference null return value (NULL_RETURNS)
** CID 1265806: Dereference null return value (NULL_RETURNS)
** CID 1265807: Dereference null return value (NULL_RETURNS)
** CID 1265808: Dereference null return value (NULL_RETURNS)
*** CID 704751: Explicit null dereferenced (FORWARD_NULL)
/sd/source/ui/func/fuoaprms.cxx: 660 in
sd::FuObjectAnimationParameters::DoExecute(SfxRequest )()
654 pRunningObj = pObject1;
655 }
656
657 DBG_ASSERT(pPath, no curve found);
658
659 // push the running object to the end of the curve
CID 704751: Explicit null dereferenced (FORWARD_NULL)
Passing null pointer pRunningObj to GetLogicRect, which
dereferences it. (The dereference happens because this is a virtual
function call.)
660 Rectangle aCurRect(pRunningObj-GetLogicRect());
661 Point aCurCenter(aCurRect.Center());
662 const ::basegfx::B2DPolyPolygon rPolyPolygon =
pPath-GetPathPoly();
663 sal_uInt32 nNoOfPolygons(rPolyPolygon.count());
664 const ::basegfx::B2DPolygon
aPolygon(rPolyPolygon.getB2DPolygon(nNoOfPolygons - 1L));
665 sal_uInt32 nPoints(aPolygon.count());
*** CID 1202761: Unchecked return value (CHECKED_RETURN)
/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx: 827 in
GtkSalGraphics::hitTestNativeControl(unsigned int, unsigned int, const
Rectangle , const Point , bool )()
821 aForward.Move( aForward.GetWidth() / 2, 0 );
822 }
823
824 if ( ( nPart == PART_BUTTON_UP ) || ( nPart == PART_BUTTON_LEFT
) )
825 {
826 if ( has_backward )
CID 1202761: Unchecked return value (CHECKED_RETURN)
Calling IsInside without checking return value (as is done elsewhere
280 out of 322 times).
827 rIsInside |= aBackward.IsInside( aPos );
828 if ( has_backward2 )
829 rIsInside |= aForward.IsInside( aPos );
[Libreoffice-bugs] [Bug 88754] tooltips are not displayed in tracked changes
https://bugs.freedesktop.org/show_bug.cgi?id=88754 --- Comment #3 from Reinhard Lamsfuss rlamsf...@muenster.de --- Hi Cor, Thank you for the feed back, I may be due to my system, but the question is: Why does LibreOffice 3.5.4.2 (Build-ID: 350m1(Build:2)) on the same system display the tool-tips? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88762] New: Orca incorrectly announces paragraph indentation when using the get attributes orca+f keyboard shortcut
https://bugs.freedesktop.org/show_bug.cgi?id=88762 Bug ID: 88762 Summary: Orca incorrectly announces paragraph indentation when using the get attributes orca+f keyboard shortcut Product: LibreOffice Version: 4.3.5.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: am_d...@fastmail.fm When indenting the first line of a paragraph through the paragraph settings dialog in the format menu, orca says the text is indented when I use the orca+f keyboard command even if I am not on the first line of the paragraph. Orca should only announce this indent when on the first line of the paragraph. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88762] Orca incorrectly announces paragraph indentation when using the get attributes orca+f keyboard shortcut
https://bugs.freedesktop.org/show_bug.cgi?id=88762 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Blocks||36549 Whiteboard||a11y -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36549] ACCESSIBILITY: Tracking bug for issues affecting a11y ATK and GNOME Orca screen reader support
https://bugs.freedesktop.org/show_bug.cgi?id=36549 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||88761 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36549] ACCESSIBILITY: Tracking bug for issues affecting a11y ATK and GNOME Orca screen reader support
https://bugs.freedesktop.org/show_bug.cgi?id=36549 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||88762 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88761] the Orca screen reader has trouble reading the auto correct dialog box
https://bugs.freedesktop.org/show_bug.cgi?id=88761 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Blocks||36549 Whiteboard||a11y -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36549] ACCESSIBILITY: Tracking bug for issues affecting a11y ATK and GNOME Orca screen reader support
https://bugs.freedesktop.org/show_bug.cgi?id=36549 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||88764 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88763] The orca screen reader does not speak control names when navigating in the outline numbering dialog box
https://bugs.freedesktop.org/show_bug.cgi?id=88763 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Blocks||36549 Whiteboard||a11y -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88764] The orca screen reader does not consistantly speak control names when navigating in the paragraph dialog box
https://bugs.freedesktop.org/show_bug.cgi?id=88764 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Blocks||36549 Whiteboard||a11y -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 1c/1efea327d26d61e3feccbd0ee0275707ba997d
1c/1efea327d26d61e3feccbd0ee0275707ba997d |1 + 1 file changed, 1 insertion(+) New commits: commit 9757cf9080e35ff5a33ed88027db8806596b1f3d Author: Caolán McNamara caol...@redhat.com Date: Fri Jan 23 20:50:29 2015 + Notes added by 'git notes add' diff --git a/1c/1efea327d26d61e3feccbd0ee0275707ba997d b/1c/1efea327d26d61e3feccbd0ee0275707ba997d new file mode 100644 index 000..8e5c182 --- /dev/null +++ b/1c/1efea327d26d61e3feccbd0ee0275707ba997d @@ -0,0 +1 @@ +ignore: aoo ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88709] Multiple references to one footnote doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=88709 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added CC||stgohi-lob...@yahoo.de --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- For me not reproducible with LO 4.3.5.2, Win 8.1. Did you the same steps as I? Which operating are you using? Steps Done: 1. Open WRITER 2. Write two lines of text 3. Insert a footnote to line 1 (put the cursor there and go to INSERT - FOOTNOTE/ENDNOTE, select CHARACTER in the NUMBERING section and select a character and press OK) 4. Select the superscripted footnote character and copy it with CTRL+C 5. Go to the second line and press CTRL+V to insert the copied footnote Result: The footnote is copied as expected. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34555] Make cropping handles for images (as in Draw/Impress) available for all LibreOffice applications
https://bugs.freedesktop.org/show_bug.cgi?id=34555 --- Comment #51 from Philippe Jung phil.j...@free.fr --- Hello, I tried to work on this bug last year and I had something nearly working. But, during this time, the code base changed (a lot) and I have no time for the moment to rework it. So I would like to share what I found. I will attach the patch as is to this ticket. It is not working at all with current trunk. Basically, you have to use a virtual NbcCrop function on a parent that is common to SwVirtDraw and SdrGraph I am not going to detail every change I made in this ticket. Please read the patch and if you have any question feel free to ask. The crop code was in SdrDragCrop::EndSdrDrag. You have to move this code in SdrGraphObj. Now in SdrDragCrop::EndSdrDrag call the crop virtual = getSdrDragView().CropMarkedObj Now the problems I am facing: 1) cropping code has changed a lot in EndSdrDrag. Mine uses the old code. You will have to adapt it 2) Regarding links, you can also consider Armin Le Grand web page https://wiki.openoffice.org/wiki/Aw080_documentation. This explains the mathematical logic using transformation matrixes (If you git blame the cropping code, this will point to alg). If I am not mistaken, these changes come from evolution of OpenOffice merged into Libre Office. 3) I tried to contact alg and his advice is I would suggest to *not* touch SwVirtFlyDrawObj at all, it's dead code. It's a kind of proxy, try to get the original SdrObject from it and modify that instead. Or better: just tunnel your call to the original object. Philippe -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 34555] Make cropping handles for images (as in Draw/Impress) available for all LibreOffice applications
https://bugs.freedesktop.org/show_bug.cgi?id=34555 --- Comment #51 from Philippe Jung phil.j...@free.fr --- Hello, I tried to work on this bug last year and I had something nearly working. But, during this time, the code base changed (a lot) and I have no time for the moment to rework it. So I would like to share what I found. I will attach the patch as is to this ticket. It is not working at all with current trunk. Basically, you have to use a virtual NbcCrop function on a parent that is common to SwVirtDraw and SdrGraph I am not going to detail every change I made in this ticket. Please read the patch and if you have any question feel free to ask. The crop code was in SdrDragCrop::EndSdrDrag. You have to move this code in SdrGraphObj. Now in SdrDragCrop::EndSdrDrag call the crop virtual = getSdrDragView().CropMarkedObj Now the problems I am facing: 1) cropping code has changed a lot in EndSdrDrag. Mine uses the old code. You will have to adapt it 2) Regarding links, you can also consider Armin Le Grand web page https://wiki.openoffice.org/wiki/Aw080_documentation. This explains the mathematical logic using transformation matrixes (If you git blame the cropping code, this will point to alg). If I am not mistaken, these changes come from evolution of OpenOffice merged into Libre Office. 3) I tried to contact alg and his advice is I would suggest to *not* touch SwVirtFlyDrawObj at all, it's dead code. It's a kind of proxy, try to get the original SdrObject from it and modify that instead. Or better: just tunnel your call to the original object. Philippe -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 34555] Make cropping handles for images (as in Draw/Impress) available for all LibreOffice applications
https://bugs.freedesktop.org/show_bug.cgi?id=34555 --- Comment #52 from Philippe Jung phil.j...@free.fr --- Created attachment 112751 -- https://bugs.freedesktop.org/attachment.cgi?id=112751action=edit A patch that nearly worked but cannot be applied on current trunk This patch relates to the previous comment -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 34555] Make cropping handles for images (as in Draw/Impress) available for all LibreOffice applications
https://bugs.freedesktop.org/show_bug.cgi?id=34555 --- Comment #52 from Philippe Jung phil.j...@free.fr --- Created attachment 112751 -- https://bugs.freedesktop.org/attachment.cgi?id=112751action=edit A patch that nearly worked but cannot be applied on current trunk This patch relates to the previous comment -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 88743] type of border lines of cells changes when saved in .xls format
https://bugs.freedesktop.org/show_bug.cgi?id=88743 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #3 from raal r...@post.cz --- Created attachment 112718 -- https://bugs.freedesktop.org/attachment.cgi?id=112718action=edit test file I can confirm with LO 4.3.5, win7. I'll test later with dev builds. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74705] VIEWING: Chart Legend Area Fill in foreground hiding text
https://bugs.freedesktop.org/show_bug.cgi?id=74705 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #93644|application/octet-stream|application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/rtl
include/rtl/strbuf.hxx |6 ++
include/rtl/ustrbuf.hxx |6 ++
2 files changed, 12 insertions(+)
New commits:
commit 102b259754060005a11a82b4fcb2c65e7b0617ce
Author: Michael Stahl mst...@redhat.com
Date: Fri Jan 23 14:28:39 2015 +0100
sal: try to fix prematurely pushed 853c2fc71a96755a9dee629fd5d0e1cff9a48034
Change-Id: Id00e2579edcc9856c0fa3985e34c4a2f3e7ae5ec
diff --git a/include/rtl/strbuf.hxx b/include/rtl/strbuf.hxx
index 5450472..7c8abf0 100644
--- a/include/rtl/strbuf.hxx
+++ b/include/rtl/strbuf.hxx
@@ -97,10 +97,14 @@ public:
rtl_string_new_WithLength( pData, length );
}
#if __cplusplus = 201103L
+// GCC 4.6 lacks delegating ctors
+#if defined(__clang__) || !defined(__GNUC__) || (__GNUC__ 4) ||
(__GNUC_MINOR__ 6)
explicit OStringBuffer(unsigned int length)
: OStringBuffer(static_castint(length))
{
}
+#if SAL_TYPES_SIZEOFLONG == 4
+// additional overloads for sal_Int32 sal_uInt32
explicit OStringBuffer(long length)
: OStringBuffer(static_castint(length))
{
@@ -109,10 +113,12 @@ public:
: OStringBuffer(static_castint(length))
{
}
+#endif
// avoid obvious bugs
explicit OStringBuffer(char) = delete;
explicit OStringBuffer(sal_Unicode) = delete;
#endif
+#endif
/**
Constructs a string buffer so that it represents the same
diff --git a/include/rtl/ustrbuf.hxx b/include/rtl/ustrbuf.hxx
index 0240557..d205c63 100644
--- a/include/rtl/ustrbuf.hxx
+++ b/include/rtl/ustrbuf.hxx
@@ -92,10 +92,14 @@ public:
rtl_uString_new_WithLength( pData, length );
}
#if __cplusplus = 201103L
+// GCC 4.6 lacks delegating ctors
+#if defined(__clang__) || !defined(__GNUC__) || (__GNUC__ 4) ||
(__GNUC_MINOR__ 6)
explicit OUStringBuffer(unsigned int length)
: OUStringBuffer(static_castint(length))
{
}
+#if SAL_TYPES_SIZEOFLONG == 4
+// additional overloads for sal_Int32 sal_uInt32
explicit OUStringBuffer(long length)
: OUStringBuffer(static_castint(length))
{
@@ -104,10 +108,12 @@ public:
: OUStringBuffer(static_castint(length))
{
}
+#endif
// avoid obvious bugs
explicit OUStringBuffer(char) = delete;
explicit OUStringBuffer(sal_Unicode) = delete;
#endif
+#endif
/**
Constructs a string buffer so that it represents the same
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88592] VIEWING: Green display bug; picture with zero width [xlsx]
https://bugs.freedesktop.org/show_bug.cgi?id=88592 --- Comment #12 from raal r...@post.cz --- (In reply to MM from comment #11) That's fine, but wouldn't it be even better if you'd get an info window saying LO found some images that should be fixed ?! At least it would save some reports about missing images. Should be as in .ods format with 0 width pictures - red word Picture.. which disappears after scrolling. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/docnode/ndtbl.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 162c72d64077d9e0dae820d881ce2b56a5b2040c
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jan 23 13:17:39 2015 +
Related: fdo#78599 ensure RegisterFormat is called before SetModified
TextToTable is called which calls lcl_SetTableBoxWidths2 which calls
SwDoc::MakeTableBoxFmt which calls SetModified.
there happens to be a listener on modified which tries to get an updated
preview for embedded objects which draws the page to a metafile, but this
SwTableNode in SwTableNode::MakeFrm doesn't have a FrmFmt set on it yet, so
falls over and dies.
Move the RegisterFormat into SwNodes::TextToTable before the tablebox widths
are set to avoid this
Change-Id: I3e5141c9901ff0f473e2eaab3e5cd9be61f810bd
diff --git a/sw/source/core/docnode/ndtbl.cxx b/sw/source/core/docnode/ndtbl.cxx
index 1c1c30b..9636edf 100644
--- a/sw/source/core/docnode/ndtbl.cxx
+++ b/sw/source/core/docnode/ndtbl.cxx
@@ -459,7 +459,6 @@ const SwTable* SwDoc::InsertTable( const
SwInsertTableOptions rInsTblOpts,
}
SwTable rNdTbl = pTblNd-GetTable();
-rNdTbl.RegisterToFormat( *pTableFmt );
rNdTbl.SetRowsToRepeat( nRowsToRepeat );
rNdTbl.SetTableModel( bNewModel );
@@ -744,7 +743,6 @@ const SwTable* SwDoc::TextToTable( const
SwInsertTableOptions rInsTblOpts,
// Set Orientation in the Table's Fmt
pTableFmt-SetFmtAttr( SwFmtHoriOrient( 0, eAdjust ) );
-rNdTbl.RegisterToFormat(*pTableFmt);
if( pTAFmt || ( rInsTblOpts.mnInsMode tabopts::DEFAULT_BORDER) )
{
@@ -1107,6 +1105,7 @@ SwTableNode* SwNodes::TextToTable( const SwNodeRange
rRange, sal_Unicode cCh,
lcl_BalanceTable(rTable, nMaxBoxes, *pTblNd, *pBoxFmt, *pTxtColl,
pUndo, aPosArr);
+rTable.RegisterToFormat(*pTblFmt);
lcl_SetTableBoxWidths(rTable, nMaxBoxes, *pBoxFmt, *pDoc, aPosArr);
return pTblNd;
@@ -1402,6 +1401,7 @@ SwTableNode* SwNodes::TextToTable( const
SwNodes::TableRanges_t rTableNodes,
nMaxBoxes = nBoxes;
}
+rTable.RegisterToFormat(*pTblFmt);
lcl_SetTableBoxWidths2(rTable, nMaxBoxes, *pBoxFmt, *pDoc);
return pTblNd;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 87467] Writer Locks up on Save As if that's the first command after opening a doc
https://bugs.freedesktop.org/show_bug.cgi?id=87467 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #3 from raal r...@post.cz --- I can not confirm with LO 4.3.5, win7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: scripting/java sd/source
scripting/java/com/sun/star/script/framework/container/UnoPkgContainer.java |
4 ++--
sd/source/ui/inc/ViewShell.hxx |
2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit b55ef81671d441d5e8b7c30bb2b2a1af48c46bcc
Author: Andras Timar andras.ti...@collabora.com
Date: Fri Jan 23 15:00:54 2015 +0100
typo: langugage - language
Change-Id: Ifabd5a7851946b3e4109e22e6e9a1ff34575c1e5
diff --git
a/scripting/java/com/sun/star/script/framework/container/UnoPkgContainer.java
b/scripting/java/com/sun/star/script/framework/container/UnoPkgContainer.java
index 29d059d..dfbac7c 100644
---
a/scripting/java/com/sun/star/script/framework/container/UnoPkgContainer.java
+++
b/scripting/java/com/sun/star/script/framework/container/UnoPkgContainer.java
@@ -63,7 +63,7 @@ public class UnoPkgContainer extends ParcelContainer {
LogUtils.DEBUG(** getRegisterPackage ctx = + containerUrl);
LogUtils.DEBUG(** getRegisterPackage for uri + url);
-LogUtils.DEBUG(** getRegisterPackage for langugage + language);
+LogUtils.DEBUG(** getRegisterPackage for language + language);
ParcelContainer result = registeredPackages.get(url);
LogUtils.DEBUG(getRegisterPackage result is + result);
@@ -400,4 +400,4 @@ public class UnoPkgContainer extends ParcelContainer {
registerPackageContainer(uri, this);
}
}
-}
\ No newline at end of file
+}
diff --git a/sd/source/ui/inc/ViewShell.hxx b/sd/source/ui/inc/ViewShell.hxx
index 8aa15c4..352b6f9 100644
--- a/sd/source/ui/inc/ViewShell.hxx
+++ b/sd/source/ui/inc/ViewShell.hxx
@@ -563,7 +563,7 @@ protected:
private:
::vcl::Window* mpParentWindow;
/** This window updater is used to keep all relevant windows up to date
-with reference to the digit langugage used to display digits in text
+with reference to the digit language used to display digits in text
shapes.
*/
::std::unique_ptr ::sd::WindowUpdater mpWindowUpdater;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 74965] FORMATTING: Wrong chart axis text using date values as text
https://bugs.freedesktop.org/show_bug.cgi?id=74965 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #94049|application/octet-stream|application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87013] LO performance when network drive is mounted over slow link
https://bugs.freedesktop.org/show_bug.cgi?id=87013 --- Comment #10 from nickl...@gmail.com --- Have tried some more now, and in my case it is completely related. If I clear my history and reopens the document from the share(therefore having only one item in the recent list), the periodical freezing is very short, perhaps a second or two. But if I then clear the list completely, all freezing goes away and LO becomes as responsive as one would expect. And this while editing a document I have on the network share(so *that's* not related). So I would agree with previous reporters that this is related to the recent-list. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75000] FILESAVE: Formatting lost when saving as .pptx
https://bugs.freedesktop.org/show_bug.cgi?id=75000 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #94097|application/octet-stream|application/vnd.openxmlform mime type||ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57492] no keyboard input after opening password protected .ods
https://bugs.freedesktop.org/show_bug.cgi?id=57492 --- Comment #31 from r.stiltskin cuny...@gmail.com --- Strangely, after a couple of weeks and for no apparent reason it began working correctly again. For at least the last 5 weeks I've been able to open and edit password-protected files without any problems. I have no idea how this happened -- certainly nothing that I did consciously. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
