Re: [Libreoffice-qa] [LibreOffice Bugzilla Migration] We're done! Please visit the new site to reset your password!

2015-01-27 Thread Michael Stahl
On 27.01.2015 08:12, Robinson Tryon wrote:
 On Tue, Jan 27, 2015 at 1:20 AM, Tommy ba...@quipo.it wrote:
 +1. we really need to remove a lot of those useless keywords
 
 Here's the current list of keywords:
 
 ALL: What should go?
 
 
 
 bisected (255)
 The bug has been successfully connected to a code commit that
 introduced the bug (such as with git bisect).

useful, keep

 bisect_pending (0)
 The bug seems likely to benefit from bisecting, (such as easy to
 reproduce, etc.), but the bisect has not yet been performed. See also
 the bisected keyword.

this sounds similar to BibisectRequest - which one to keep?

 cleanup0407 (2)
 April 2007 bug cleanup.

DELETE

 have-backtrace (232)
 bugs that have a useful backtrace

useful, keep

 i18n (26)
 Xorg Internationalisation issues (i18n)

sounds potentially useful, we don't have a component with similar
scope (but if we keep it the description needs to remove Xorg and it
should be merged with l10 as they seem very similar)

 janitor (9)
 Cleanup bugs, usually trivial.

sounds like EasyHack? DELETE

 l10n (51)
 Xorg/X11 Localisation issues

see i18n above

 licence (2)
 Files with licence problems (e.g. mixing incompatible licences,
 missing/non-permissive copyrights, et al)

not sure if we want this, best to get BoD's opinion on that...

 love (8)
 Marking a bug with this keyword means that you're willing to help
 someone fix the bug, or that it should be fixable by a beginner
 without any help. This should ONLY be set by a maintainer or people
 familiar with the code base, and ONLY when it looks like a project
 suitable for a new developer looking for a task.

covered by EasyHack - DELETE

 movetoxkc (0)
 Bugs that should be moved to xkeyboard-config, if still applicable.

DELETE

 NEEDINFO (51)
 The bug does not have enough information in order to solve the
 problem. Please read the comments and add the relevant information
 required to aid in solving the problem.

this is a status, so doesn't need to be a keyword too?

 notourbug (2)
 It's not really our bug, but we might work around it anyway.

RESOLVED NOTOURBUG - DELETE?

 patch (21)
 Bugs with a valid patch.

the patch attachment should have the patch flag set which can be
queried so why do we need this?

 regression (3392)
 Xorg bug regressions (issues previously fixed but somehow broken again)

keep the all-time favorite, remove Xorg from description though

 security (6)
 Security-sensitive bugs

sure, let's keep them in the public bug tracker :D

 want-backtrace (13)
 Bugs whose triage could be greatly accelerated with the addition of a
 backtrace from the crash.

hmm sounds like it could be useful...

 x12 (0)
 Bugs that require a protocol version bump.

DELETE

 and add some [keywords]
 that are nore useful.
 
 We have a number of tags that we put in the Whiteboard right now
 https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard
 (also see advanced page)
 
 Many of those could become keywords.
 
 ALL: Proposals on which ones?

confirmedRegression never served any purpose and should be summarily
DELETED

possibleRegression could be a keyword, unless it's considered too
transient a state... is that a criterion? hmmm... why not just add it...

confirmed:VERSION:OS noRepro:VERSION:OS needsSOFTWARE
needsHARDWARE target:X.Y summary:comment# are not fixed so cannot
be keyword

bibisected should be keyword

odf and odf_validation should be keywords

a11y sounds useful as a keyword

perf sounds useful as a keyword

interoperability could be a keyword too, although perhaps a better
name is required that indicates this is about Microsoft Office and its
formats in particular (MSOinterop? MSO? MSinterop? MSOffice?).

there are *lots* of easy-hack related ones... not sure about those?
perhaps better leave them in the whiteboard since we may often add
additional ones etc. and the keyword list may become cluttered?




___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 88821] Import HTML file into Calc wrongly assumes source code-page is Windows-1252

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88821

--- Comment #1 from grofaty grof...@hotmail.com ---
Created attachment 112822
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112822action=edit
slovenian_utf-8.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88821] New: Import HTML file into Calc wrongly assumes source code-page is Windows-1252

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88821

Bug ID: 88821
   Summary: Import HTML file into Calc wrongly assumes source
code-page is Windows-1252
   Product: LibreOffice
   Version: 4.3.5.2 release
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Spreadsheet
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: grof...@hotmail.com

Created attachment 112821
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112821action=edit
slovenian_utf-8.csv

n LibreOffice Calc 4.3.5.2 on Windows 7 I see Calc wrongly assumes that HTML
input file is ALWAYS in Windows-1252 code page.

MY SETTINGS:
1. Tools | Options | Language Settings | Languages
a) User interface: English (USA)
b) Locale settings: Slovenian
See attachment Tools_Options_Language_settings.png


TEST 1:
1. Start Calc.
2. File | Open
3. Select slovenian_utf-8.csv
4. Text Import dialog opens.
4a. Character set: Unicode (UTF-8).
4b. Language selection: Slovenian.
4c. Separated by: Semicolon
4d. Check: Quoted field as text and check Detect special numbers.
4e. Click on Open button.
Result: WORKS FINE. Non-English characters in Text field are correctly
recognized as UTF-8 (setting 4a), Decimal settings is correctly recognized as
comma separator (setting 4b) and Date (setting 4b) field is correctly
recognized as date.


TEST 2:
The same as Test 1 except:
3. Select slovenian_windows-1250.csv
4a.  Character set: Eastern Europe Windows-1250.
Result: WORKS FINE. Non-English characters in Text field are correctly
recognized as Windows-1250 code page.


TEST 3:
The same as Test 1 expect:
3. Select slovenian_utf-8.html
4. The source of the problem is probably Import Options dialog. There is no
option to select character set. The only option is language selection. I
selected Custom: Slovenian.
Result: PROBLEM. Non-English characters in A2 field are corrupted.

If the same file is opened (File | Open File) by Firefox 35 web browser and
non-English characters are correctly opened – there is HTML tag in file:  meta
charset=UTF-8 so browser correctly recognizes the character set. But now in
Firefox select menu View | Character Encoding | Western and you will get the
same corrupted non-English text as in LibreOffice. So LibreOffice just assumes
that input HTML file is ALWAYS in Windows-1252 (Western) code page.


TEST 4:
The same as Test 1 expect:
3. Select: slovenian_windows-1250.html
4. The same problem as in Test 3, the Import options dialog does not contain
a character set option to select from. So I just selected Custom: Slovenian.
Result: PROBLEM. Non-English characters in A2 field are corrupted.

If the same file is opened by Firefox 25 web browser and non-English characters
are correctly recognized as Windows-1250 code page (because of HTML meta
charset tag). Now change encoding: View | Character Encoding | Western and you
will get the same corrupted data for non-English characers like in LibreOffice.
So LibreOffice just assumes that input HTML file is ALWAYS in Windows-1252
(Western) code page.


In my humble opinion the problem of importing HTML file is that LibreOffice
assumes that source HTML file is ALWAYS encoded in Western (Windows-1252) code
page.


How should be a problem fixed:

Quick fix: By statistics see e.g. https://en.wikipedia.org/wiki/UTF-8 most of
the web pages nowdays are UTF-8 encoded. UTF-8 is also universal code page for
ANY language in the world. Set default Calc import filter code page to UTF-8.


Permanent fix. Create the same import dialog for HTML files just like it is at
importing CSV files (or at least add Character set option). But in this case
please check the meta charset tag in HTML file and set default code-page
selection to HTML meta tag if exists. If meta tag does not exists then default
to UTF-8.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: xmlscript/source

2015-01-27 Thread Tor Lillqvist
 xmlscript/source/xmldlg_imexp/xmldlg_export.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ad3e0989d137ef765d634cb07a7a7a46ecc774ff
Author: Tor Lillqvist t...@collabora.com
Date:   Tue Jan 27 15:01:14 2015 +0200

WaE: implicit conversion of literal of type 'int' to 'bool'

Change-Id: Ie12339760904329d690bbe4863286e005ebde380

diff --git a/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx 
b/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx
index e45ce96..ab9049f 100644
--- a/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx
+++ b/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx
@@ -1034,7 +1034,7 @@ void ElementDescriptor::readImageScaleModeAttr( OUString 
const  rPropName, OUSt
 addAttribute( rAttrName, OUString( anisotropic ) );
 break;
 default:
-OSL_ENSURE( 0, ### illegal image scale mode value.);
+OSL_ENSURE( false, ### illegal image scale mode value.);
 break;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/inc sc/source

2015-01-27 Thread László Németh
 sc/inc/address.hxx  |6 +++
 sc/source/core/tool/address.cxx |   62 
 sc/source/filter/excel/xeroot.cxx   |1 
 sc/source/filter/excel/xestream.cxx |   10 +
 sc/source/filter/excel/xetable.cxx  |   10 +++--
 sc/source/filter/inc/xeroot.hxx |5 ++
 sc/source/filter/inc/xestream.hxx   |3 +
 7 files changed, 93 insertions(+), 4 deletions(-)

New commits:
commit 779581feed4886313746a71e9e738d736977be1b
Author: László Németh laszlo.nem...@collabora.com
Date:   Tue Jan 27 09:17:50 2015 +0100

tdf#88810 avoid unnecessary massive O(U)String allocations in XLSX export

Using OStringBuffer instead of fixed size character arrays.

Change-Id: I06b705e2159a1ef5990f9eb0ffedd20fe277c616

diff --git a/sc/inc/address.hxx b/sc/inc/address.hxx
index 06c450b..a745c73 100644
--- a/sc/inc/address.hxx
+++ b/sc/inc/address.hxx
@@ -22,6 +22,7 @@
 
 #include tools/stream.hxx
 #include rtl/ustrbuf.hxx
+#include rtl/strbuf.hxx
 #include osl/endian.h
 
 #include limits
@@ -325,6 +326,9 @@ public:
 ExternalInfo* pExtInfo = NULL,
 const css::uno::Sequencecss::sheet::ExternalLinkInfo* 
pExternalLinks = NULL );
 
+SC_DLLPUBLIC bool TryFormat( OStringBuffer s, sal_uInt16 nFlags = 0,
+  const ScDocument* pDocument = NULL,
+  const Details rDetails = detailsOOOa1) 
const;
 SC_DLLPUBLIC OUString Format( sal_uInt16 nFlags = 0,
   const ScDocument* pDocument = NULL,
   const Details rDetails = detailsOOOa1) 
const;
@@ -888,6 +892,8 @@ bool ConvertDoubleRef( ScDocument* pDocument, const 
OUString rRefString,
 /// append alpha representation of column to buffer
 SC_DLLPUBLIC void ScColToAlpha( OUStringBuffer rBuffer, SCCOL nCol);
 
+SC_DLLPUBLIC void ScColToAlpha( OStringBuffer rBuffer, SCCOL nCol);
+
 inline void ScColToAlpha( OUString rStr, SCCOL nCol)
 {
 OUStringBuffer aBuf(2);
diff --git a/sc/source/core/tool/address.cxx b/sc/source/core/tool/address.cxx
index 39fc9a4..36cdb92 100644
--- a/sc/source/core/tool/address.cxx
+++ b/sc/source/core/tool/address.cxx
@@ -1745,6 +1745,40 @@ static OUString getFileNameFromDoc( const ScDocument* 
pDoc )
 return sFileName;
 }
 
+/** Tries to obtain a simple address without OUString/OString allocation
+ *
+ *  @returns TRUE at success (it is enough to call OUString Format() at FALSE)
+ *
+ */
+
+bool ScAddress::TryFormat(OStringBuffer s, sal_uInt16 nFlags, const 
ScDocument* pDoc,
+   const Details rDetails) const
+{
+if( nFlags  SCA_VALID )
+nFlags |= ( SCA_VALID_ROW | SCA_VALID_COL | SCA_VALID_TAB );
+if(( pDoc  (nFlags  SCA_VALID_TAB )  ( nTab = pDoc-GetTableCount() 
|| ( nFlags  SCA_TAB_3D ))) ||
+ ! (nFlags  SCA_VALID_COL) || ! (nFlags  SCA_VALID_ROW) ||
+(nFlags  SCA_COL_ABSOLUTE) != 0 || (nFlags  SCA_ROW_ABSOLUTE) != 
0 )
+{
+   return false;
+}
+
+switch( rDetails.eConv )
+{
+default :
+case formula::FormulaGrammar::CONV_OOO:
+case formula::FormulaGrammar::CONV_XL_A1:
+case formula::FormulaGrammar::CONV_XL_OOX:
+ScColToAlpha( s, nCol );
+s.append( OString::number(nRow+1) );
+break;
+case formula::FormulaGrammar::CONV_XL_R1C1:
+// not used in XLSX export
+return false;
+}
+return true;
+}
+
 OUString ScAddress::Format(sal_uInt16 nFlags, const ScDocument* pDoc,
const Details rDetails) const
 {
@@ -2102,6 +2136,34 @@ void ScColToAlpha( OUStringBuffer rBuf, SCCOL nCol )
 }
 }
 
+void ScColToAlpha( OStringBuffer rBuf, SCCOL nCol )
+{
+if (nCol  26*26)
+{
+if (nCol  26)
+rBuf.append( static_castchar( 'A' + nCol ));
+else
+{
+rBuf.append( static_castchar( 'A' + nCol / 26 - 1 ));
+rBuf.append( static_castchar( 'A' + nCol % 26 ));
+}
+}
+else
+{
+OString aStr;
+while (nCol = 26)
+{
+SCCOL nC = nCol % 26;
+aStr += OString( static_castchar ( 'A' + nC ));
+nCol = sal::static_int_castSCCOL( nCol - nC );
+nCol = nCol / 26 - 1;
+}
+aStr += OString( static_castchar ( 'A' + nCol ));
+rBuf.append(comphelper::string::reverseString(aStr));
+}
+}
+
+
 bool AlphaToCol( SCCOL rCol, const OUString rStr)
 {
 SCCOL nResult = 0;
diff --git a/sc/source/filter/excel/xeroot.cxx 
b/sc/source/filter/excel/xeroot.cxx
index 819fe93..29f6551 100644
--- a/sc/source/filter/excel/xeroot.cxx
+++ b/sc/source/filter/excel/xeroot.cxx
@@ -57,6 +57,7 @@ XclExpRootData::XclExpRootData( XclBiff eBiff, SfxMedium 
rMedium,
 {
 SvtSaveOptions aSaveOpt;
 mbRelUrl = mrMedium.IsRemote() ? aSaveOpt.IsSaveRelINet() : 
aSaveOpt.IsSaveRelFSys();
+maStringBuf = OStringBuffer(10); // for simple 

[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - include/LibreOfficeKit libreofficekit/source

2015-01-27 Thread Miklos Vajna
 include/LibreOfficeKit/LibreOfficeKitGtk.h |2 ++
 libreofficekit/source/gtk/lokdocview.c |   25 +++--
 2 files changed, 25 insertions(+), 2 deletions(-)

New commits:
commit ba5011bcffc83bcf9e6e55f96b6d56e60d81c676
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Tue Jan 27 14:36:12 2015 +0100

lokdocview: let the cursor blink

Change-Id: I935fe7f09a5a6efcbfd246b0f24eba5226f61fb2

diff --git a/include/LibreOfficeKit/LibreOfficeKitGtk.h 
b/include/LibreOfficeKit/LibreOfficeKitGtk.h
index 75278e7..ea9c9de 100644
--- a/include/LibreOfficeKit/LibreOfficeKitGtk.h
+++ b/include/LibreOfficeKit/LibreOfficeKitGtk.h
@@ -45,6 +45,8 @@ struct _LOKDocView
 gboolean m_bEdit;
 /// Position and size of the visible cursor.
 GdkRectangle m_aVisibleCursor;
+/// Cursor is visible or hidden (for blinking).
+gboolean m_bCursorVisible;
 };
 
 struct _LOKDocViewClass
diff --git a/libreofficekit/source/gtk/lokdocview.c 
b/libreofficekit/source/gtk/lokdocview.c
index e9a440e..40fe474 100644
--- a/libreofficekit/source/gtk/lokdocview.c
+++ b/libreofficekit/source/gtk/lokdocview.c
@@ -16,8 +16,9 @@
 
 #include LibreOfficeKit/LibreOfficeKitGtk.h
 
-#ifndef G_SOURCE_REMOVE
+#if !GLIB_CHECK_VERSION(2,32,0)
 #define G_SOURCE_REMOVE FALSE
+#define G_SOURCE_CONTINUE TRUE
 #endif
 
 static void lok_docview_class_init( LOKDocViewClass* pClass );
@@ -111,6 +112,7 @@ static void lok_docview_init( LOKDocView* pDocView )
 pDocView-fZoom = 1;
 pDocView-m_bEdit = FALSE;
 memset(pDocView-m_aVisibleCursor, 0, sizeof(pDocView-m_aVisibleCursor));
+pDocView-m_bCursorVisible = FALSE;
 
 gtk_signal_connect( GTK_OBJECT(pDocView), destroy,
 GTK_SIGNAL_FUNC(lcl_onDestroy), NULL );
@@ -145,6 +147,23 @@ static gboolean lcl_isEmptyRectangle(GdkRectangle* 
pRectangle)
 return pRectangle-x == 0  pRectangle-y == 0  pRectangle-width == 0 
 pRectangle-height == 0;
 }
 
+/// Takes care of the blinking cursor.
+static gboolean lcl_handleTimeout(gpointer pData)
+{
+LOKDocView* pDocView = pData;
+
+if (pDocView-m_bEdit)
+{
+if (pDocView-m_bCursorVisible)
+pDocView-m_bCursorVisible = FALSE;
+else
+pDocView-m_bCursorVisible = TRUE;
+gtk_widget_queue_draw(GTK_WIDGET(pDocView-pEventBox));
+}
+
+return G_SOURCE_CONTINUE;
+}
+
 static gboolean renderOverlay(GtkWidget* pWidget, GdkEventExpose* pEvent, 
gpointer pData)
 {
 LOKDocView* pDocView = pData;
@@ -153,7 +172,7 @@ static gboolean renderOverlay(GtkWidget* pWidget, 
GdkEventExpose* pEvent, gpoint
 (void)pEvent;
 pCairo = gdk_cairo_create(gtk_widget_get_window(pWidget));
 
-if (!lcl_isEmptyRectangle(pDocView-m_aVisibleCursor))
+if (pDocView-m_bCursorVisible  
!lcl_isEmptyRectangle(pDocView-m_aVisibleCursor))
 {
 if (pDocView-m_aVisibleCursor.width == 0)
 // Set a minimal width if it would be 0.
@@ -331,6 +350,7 @@ static gboolean lok_docview_callback(gpointer pData)
 case LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR:
 {
 pCallback-m_pDocView-m_aVisibleCursor = 
lcl_payloadToRectangle(pCallback-m_pPayload);
+pCallback-m_pDocView-m_bCursorVisible = TRUE;
 gtk_widget_queue_draw(GTK_WIDGET(pCallback-m_pDocView-pEventBox));
 }
 break;
@@ -437,6 +457,7 @@ SAL_DLLPUBLIC_EXPORT void lok_docview_set_edit( LOKDocView* 
pDocView,
 {
 g_info(lok_docview_set_edit: entering edit mode, registering 
callback);
 pDocView-pDocument-pClass-registerCallback(pDocView-pDocument, 
lok_docview_callback_worker, pDocView);
+g_timeout_add(600, lcl_handleTimeout, pDocView);
 }
 pDocView-m_bEdit = bEdit;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 88822] APK needs helpful ChromeOS settings ...

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88822

Michael Meeks michael.me...@collabora.com changed:

   What|Removed |Added

 Blocks||84726
 Whiteboard||EasyHack DifficultyBeginner
   ||SkillScript TopicCleanup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3-6' - dbaccess/source

2015-01-27 Thread Lionel Elie Mamane
 dbaccess/source/core/api/RowSetBase.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 1f11b3cc091e7d5d5719e1309fb810da3f25242a
Author: Lionel Elie Mamane lio...@mamane.lu
Date:   Thu Jan 22 13:42:13 2015 +0100

fdo#88475 RowSetBase: reposition cache before interrogating it

This partially reverts:

  commit d20232a77565f46fedc0b556f4d50addff4d3559
  Author: Lionel Elie Mamane lio...@mamane.lu
  Date:   Thu Dec 6 13:22:06 2012 +0100

  Don't force refresh when higher up code did not request it

  Change-Id: I0f415c96fc05c1d776d14885751aef020c42f4ae

which did not take into account that the cache is shared with the
clones.

This is not a cherry-pick from master, but a more conservative
version of commit d7c9a1d9d65fe8b1a56c5c280d2ca6640a549d2f.

Change-Id: I1fa5c3169806760d35dd07e1fc1b8d5522dd3641
Reviewed-on: https://gerrit.libreoffice.org/14105
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
Tested-by: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Reviewed-by: Christian Lohmaier lohmaier+libreoff...@googlemail.com

diff --git a/dbaccess/source/core/api/RowSetBase.cxx 
b/dbaccess/source/core/api/RowSetBase.cxx
index 5d9438e..47342a2 100644
--- a/dbaccess/source/core/api/RowSetBase.cxx
+++ b/dbaccess/source/core/api/RowSetBase.cxx
@@ -657,6 +657,7 @@ sal_Bool SAL_CALL ORowSetBase::isFirst(  ) 
throw(SQLException, RuntimeException,
 if ( impl_rowDeleted() )
 return ( m_nDeletedPosition == 1 );
 
+positionCache( MOVE_NONE_REFRESH_ONLY );
 bool bIsFirst = m_pCache-isFirst();
 
 SAL_INFO(dbaccess, ORowSetBase::isFirst() =   bIsFirst   Clone = 
  m_bClone);
@@ -686,6 +687,7 @@ sal_Bool SAL_CALL ORowSetBase::isLast(  ) 
throw(SQLException, RuntimeException,
 return ( m_nDeletedPosition == impl_getRowCount() );
 }
 
+positionCache( MOVE_NONE_REFRESH_ONLY );
 bool bIsLast = m_pCache-isLast();
 
 SAL_INFO(dbaccess, ORowSetBase::isLast() =   bIsLast   Clone =  
 m_bClone);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 88810] FILESAVE: avoid unnecessary massive OUString/OString allocations in XLSX export

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88810

--- Comment #5 from László Németh nem...@numbertext.org ---
Created attachment 112826
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112826action=edit
kcachegrind profile - OStringBuffer version cleanup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'aoo/trunk' - sc/inc sc/source

2015-01-27 Thread Tsutomu Uchino
 sc/inc/ViewSettingsSequenceDefines.hxx |   17 +
 sc/source/ui/view/viewdata.cxx |4 
 2 files changed, 13 insertions(+), 8 deletions(-)

New commits:
commit d3fb83cbaea17418def1ace6e868d8892d64d85d
Author: Tsutomu Uchino ha...@apache.org
Date:   Tue Jan 27 13:25:47 2015 +

#i85241# store settings about value highlighting in document

diff --git a/sc/inc/ViewSettingsSequenceDefines.hxx 
b/sc/inc/ViewSettingsSequenceDefines.hxx
index bb45344..a77303a 100644
--- a/sc/inc/ViewSettingsSequenceDefines.hxx
+++ b/sc/inc/ViewSettingsSequenceDefines.hxx
@@ -27,7 +27,7 @@
 // this are the defines for the position of the settings in the
 // ViewSettingsSequence
 
-#define SC_VIEWSETTINGS_COUNT   23
+#define SC_VIEWSETTINGS_COUNT   24
 
 #define SC_VIEW_ID  0
 #define SC_TABLE_VIEWSETTINGS   1
@@ -45,13 +45,14 @@
 #define SC_COLROWHDR13
 #define SC_SHEETTABS14
 #define SC_OUTLSYMB 15
-#define SC_SNAPTORASTER 16
-#define SC_RASTERVIS17
-#define SC_RASTERRESX   18
-#define SC_RASTERRESY   19
-#define SC_RASTERSUBX   20
-#define SC_RASTERSUBY   21
-#define SC_RASTERSYNC   22
+#define SC_VALUE_HIGHLIGHTING   16
+#define SC_SNAPTORASTER 17
+#define SC_RASTERVIS18
+#define SC_RASTERRESX   19
+#define SC_RASTERRESY   20
+#define SC_RASTERSUBX   21
+#define SC_RASTERSUBY   22
+#define SC_RASTERSYNC   23
 
 
 // this are the defines for the position of the settings in the
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 8c09eee..1ef28b5 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -2766,6 +2766,8 @@ void ScViewData::WriteUserDataSequence(uno::Sequence 
beans::PropertyValue rSe
 ScUnoHelpFunctions::SetBoolInAny( pSettings[SC_SHEETTABS].Value, 
pOptions-GetOption( VOPT_TABCONTROLS ) );
 pSettings[SC_OUTLSYMB].Name = 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(SC_UNO_OUTLSYMB));
 ScUnoHelpFunctions::SetBoolInAny( pSettings[SC_OUTLSYMB].Value, 
pOptions-GetOption( VOPT_OUTLINER ) );
+pSettings[SC_VALUE_HIGHLIGHTING].Name = rtl::OUString( 
RTL_CONSTASCII_USTRINGPARAM( SC_UNO_VALUEHIGH ) );
+ScUnoHelpFunctions::SetBoolInAny( 
pSettings[SC_VALUE_HIGHLIGHTING].Value, pOptions-GetOption( VOPT_SYNTAX ) );
 
 const ScGridOptions aGridOpt = pOptions-GetGridOptions();
 pSettings[SC_SNAPTORASTER].Name = 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(SC_UNO_SNAPTORASTER));
@@ -2916,6 +2918,8 @@ void ScViewData::ReadUserDataSequence(const uno::Sequence 
beans::PropertyValue
 if ( rSettings[i].Value = nTemp16 )
 pOptions-SetObjMode( VOBJ_TYPE_DRAW, (nTemp16 == 1) ? 
VOBJ_MODE_HIDE : VOBJ_MODE_SHOW );
 }
+else if ( sName.compareToAscii( SC_UNO_VALUEHIGH ) == 0 )
+pOptions-SetOption( VOPT_SYNTAX, 
ScUnoHelpFunctions::GetBoolFromAny( rSettings[i].Value ) );
 else
 {
 ScGridOptions aGridOpt(pOptions-GetGridOptions());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 88823] Useless graph and UI slow when selecting full column except one cell

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88823

Milan Bouchet-Valat nalimi...@club.fr changed:

   What|Removed |Added

   Severity|major   |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Asan test results

2015-01-27 Thread Crash Testing
Hey,

attached is the asan test result from the weekend. Please note that most
import issues have been fixed by Caolan already.

Regards,
Markus
Crash:/srv/crashtestdata/files/html/novell232420-1.html through disposed
Crash:/srv/crashtestdata/files/docx/fdo73574-3.docx through disposed
Crash:/srv/crashtestdata/files/docx/fdo68332-2.docx through disposed
Crash:/srv/crashtestdata/files/html/rhbz499052-1.html through disposed
Crash:/srv/crashtestdata/files/docx/fdo61410-3.docx through disposed
Crash:/srv/crashtestdata/files/docx/fdo73573-1.docx through disposed
Crash:/srv/crashtestdata/files/docx/fdo73572-1.docx through disposed
Crash:/srv/crashtestdata/files/docx/fdo78599-1.docx through disposed
Crash:/srv/crashtestdata/files/docx/fdo81650-2.docx through disposed
Crash:/srv/crashtestdata/files/html/novell171063-1.html through disposed
Crash:/srv/crashtestdata/files/html/novell181856-1.html through disposed
Crash:/srv/crashtestdata/files/html/rhbz564174-1.html through disposed
Crash:/srv/crashtestdata/files/ppt/ooo57429-4.ppt 
Crash:/srv/crashtestdata/files/cloudon/File_1292.docx through disposed
Crash:/srv/crashtestdata/files/cloudon/File_953.docx through disposed
Crash:/srv/crashtestdata/files/html/ooo58742-1.html 
Crash:/srv/crashtestdata/files/html/novell149824-5.html through disposed
Crash:/srv/crashtestdata/files/odt/fdo66601-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo72452-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/ooo113993-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo55650-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo75607-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo65357-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo72971-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo34800-5.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo71645-6.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo72626-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo67093-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo73118-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo81814-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo60886-3.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo43765-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo55651-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo55983-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo66440-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo83291-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo66196-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo59714-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo81603-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo78049-3.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo58864-3.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo62768-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo80605-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/kde311924-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo69464-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo48343-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo65459-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo77519-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo69412-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/lp1156815-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo57712-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo60161-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo61711-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo63740-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo65107-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo79217-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo51169-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo54393-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo69895-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo66578-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/lp1156815-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo85644-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo66487-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo53227-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo60886-5.odt through disposed
Crash:/srv/crashtestdata/files/odt/kde328609-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo79426-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo82788-5.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo66601-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo80206-2.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo65372-1.odt through disposed
Crash:/srv/crashtestdata/files/odt/fdo74340-2.odt through disposed

[Libreoffice-commits] core.git: Branch 'libreoffice-4-3-6' - sw/qa sw/source

2015-01-27 Thread Caolán McNamara
 sw/qa/core/data/html/pass/fdo87601-1.html |  100 ++
 sw/source/filter/html/swhtml.cxx  |2 
 2 files changed, 101 insertions(+), 1 deletion(-)

New commits:
commit 7236b323b448678d6794b91f3bfe4fce0a1f8e2c
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Jan 21 15:25:03 2015 +

Resolves: fdo#87601 specific html doc hangs on load

Change-Id: I67f472d72efe123b533d4d94be0084986c0e8349
(cherry picked from commit 6acd5c45c764d81aea1539e66adbfadb51df0aa3)
Reviewed-on: https://gerrit.libreoffice.org/14082
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Reviewed-by: Christian Lohmaier lohmaier+libreoff...@googlemail.com

diff --git a/sw/qa/core/data/html/pass/fdo87601-1.html 
b/sw/qa/core/data/html/pass/fdo87601-1.html
new file mode 100644
index 000..b33f11c
--- /dev/null
+++ b/sw/qa/core/data/html/pass/fdo87601-1.html
@@ -0,0 +1,100 @@
+
+   html xmlns:v=urn:schemas-microsoft-com:vml
+   xmlns:o=urn:schemas-microsoft-com:office:office
+   xmlns:w=urn:schemas-microsoft-com:office:word
+   
xmlns:m=http://schemas.microsoft.com/office/2006/01/omml;
+   xmlns=http://www.w3.org/TR/REC-html40;
+   head
+   meta http-equiv=Content-Type content=text/html; 
charset=utf-8
+   style
+   v\:* {behavior:url(#default#VML);}
+   o\:* {behavior:url(#default#VML);}
+   w\:* {behavior:url(#default#VML);}
+   .shape {behavior:url(#default#VML);}
+   /style
+   style
+   @page
+   {
+   mso-page-orientation: portrait;
+   size:21cm 29.7cm;margin:1cm 1cm 1cm 
1cm;
+   }
+   @page Section1 {
+   mso-header-margin:.5in;
+   mso-footer-margin:.5in;
+   mso-header: h1;
+   mso-footer: f1;
+   mso-bidi-font:Arial;
+   }
+   div.Section1 { page:Section1; }
+   table {
+   border-spacing: 0;
+   border-collapse: collapse;
+   font-size: 10.0pt;
+   }
+   td
+   {
+   border: 1px solid #000;
+   font-size:10.0pt;
+   font-family:Verdana,sans-serif;
+   margin-bottom:0.000cm;
+   vertical-align:top;
+   }
+   p.MsoFooter, li.MsoFooter, div.MsoFooter
+   {
+   margin:0in;
+   margin-bottom:.0001pt;
+   mso-pagination:widow-orphan;
+   tab-stops:center 3.0in right 6.0in;
+   font-size:10.0pt;
+   }
+   /style
+   xml
+   w:WordDocument
+   w:ViewPrint/w:View
+   w:Zoom100/w:Zoom
+   w:DoNotOptimizeForBrowsertc2ms/
+   /w:WordDocument
+   /xml
+   /head
+   body style=width:21.001cm;
+   div class=Section1
+   br
+   br
+   h1 
style=mso-element:header;font-size:24.0pt;font-weight:normal;font-family:Verdana,sans-serif;color:#f00;
 id=h1
+   p class=MsoHeader
+   Your bug here
+   /p
+   /h1
+   br
+   table width=700 cellpadding=6 
style=border-collapse:collapse;
+   tr
+   td width=200 border=1 
style=font-weight:bold;x/td
+   td width=500 style=font-weight:bold;x/td
+   /tr
+   tr
+   td style=font-weight:bold;x/td
+   td style=font-weight:bold;x/td
+   /tr
+   

[Libreoffice-commits] core.git: Branch 'libreoffice-4-3-6' - sw/source

2015-01-27 Thread Caolán McNamara
 sw/source/filter/html/wrthtml.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 3069971d1cca8660fe251c7295ae4afe40f2cb81
Author: Caolán McNamara caol...@redhat.com
Date:   Sun Jan 25 14:12:22 2015 +

coverity#1266508 Useless call (gold)

regression from

commit 832e5aadbff006ec24959162c29756fe2b1982be
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Oct 8 10:06:59 2013 +0100
Related: fdo#38838 remove UniString::SearchAndReplaceAll

(cherry picked from commit 6cde3ff3dd646f51f37f2342863371db8de9087a)

Conflicts:
sw/source/filter/html/wrthtml.cxx

Change-Id: If792925eddc9c640584a2e8fa313a4297a32c74c
Reviewed-on: https://gerrit.libreoffice.org/14173
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Christian Lohmaier lohmaier+libreoff...@googlemail.com

diff --git a/sw/source/filter/html/wrthtml.cxx 
b/sw/source/filter/html/wrthtml.cxx
index b9464f6..b5f7848 100644
--- a/sw/source/filter/html/wrthtml.cxx
+++ b/sw/source/filter/html/wrthtml.cxx
@@ -1134,8 +1134,7 @@ void SwHTMLWriter::OutImplicitMark( const OUString rMark,
 {
 if( !rMark.isEmpty()  !aImplicitMarks.empty() )
 {
-OUString sMark( rMark );
-sMark + OUString(cMarkSeparator) + 
OUString::createFromAscii(pMarkType);
+OUString sMark(rMark + OUString(cMarkSeparator) + 
OUString::createFromAscii(pMarkType));
 if( 0 != aImplicitMarks.erase( sMark ) )
 {
 OutAnchor(sMark.replace('?', '_')); // '?' causes problems in 
IE/Netscape 5
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 2 commits - vcl/generic vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2015-01-27 Thread Michael Stahl
 vcl/generic/fontmanager/fontmanager.cxx |   25 ++-
 vcl/generic/print/genpspgraphics.cxx|8 +++
 vcl/headless/svptext.cxx|4 +--
 vcl/inc/cairotextrender.hxx |2 -
 vcl/inc/fontmanager.hxx |7 +-
 vcl/inc/generic/genpspgraphics.h|6 +++--
 vcl/inc/headless/svpgdi.hxx |2 -
 vcl/inc/quartz/salgdi.h |2 -
 vcl/inc/salgdi.hxx  |4 ++-
 vcl/inc/textrender.hxx  |2 -
 vcl/inc/unx/salgdi.h|2 -
 vcl/inc/win/salgdi.h|2 -
 vcl/quartz/salgdi.cxx   |2 -
 vcl/source/gdi/pdfwriter_impl.cxx   |   34 
 vcl/unx/generic/gdi/cairotextrender.cxx |4 +--
 vcl/unx/generic/gdi/salgdi3.cxx |4 +--
 vcl/win/source/gdi/salgdi3.cxx  |2 -
 17 files changed, 85 insertions(+), 27 deletions(-)

New commits:
commit 5cb69b6653097b0772e112f0979fc9ee7da18fa8
Author: Michael Stahl mst...@redhat.com
Date:   Tue Jan 27 13:52:54 2015 +0100

vcl: PDF export: AFM may contain 16-bit code points, unlikely to work...

Change-Id: If7d67cd92a878bd1cfcc838ec9b7c9303975b255

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 950bd96..1c798ea 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -3125,6 +3125,7 @@ std::map sal_Int32, sal_Int32  
PDFWriterImpl::emitEmbeddedFont( const Physical
 if(it-second == -1)
 continue;
 sal_Int32 nCode = (sal_Int32)(it-second  0x00ff);
+SAL_WARN_IF(nCode != it-second, vcl.gdi, emitEmbeddedFont: 
FIXME: cannot handle Type 1 font with code points  256);
 //We're not doing this right here. We have taken a 
unicode-to-font_index map
 //and are trying to generate a font_index-to-unicode mapping from 
it
 //Which assumes that there is a 1-to-1 mapping there, but that 
might not be
commit 5183910a90e97cafc3cfaaad40acdaec0b792f6d
Author: Michael Stahl mst...@redhat.com
Date:   Tue Jan 27 00:20:58 2015 +0100

rhbz#1177022: vcl: fix PDF embedding of Type 1 fonts

Problem is that for the CM Typewriter font the Width for space (32)
is exported as 0 instead of 525, which is the correct value in the AFM.

The reason is that PDFWriterImpl::emitEmbeddedFont() has various arrays
to map from font code points to Unicode code points, and there are
duplicate mappings, so the 160-32 mapping overrides 32-32.

The PrintFontManager::PrintFont::readAfmMetrics() actually creates a
Unicode to font code mapping (which may legitimately be n:1) that is
then inverted; add an additional hack to store a set of preferred
Unicodes so that PDFWriterImpl can pick the right Unicode.

Presumably the code that is stored explicitly via C or CH in the
AFM should take priority over more generic mappings.

Change-Id: Id4205a1cd45ba6a0a5facee1e39f70c3535e7dd4

diff --git a/vcl/generic/fontmanager/fontmanager.cxx 
b/vcl/generic/fontmanager/fontmanager.cxx
index 736513a..c6ee6ec 100644
--- a/vcl/generic/fontmanager/fontmanager.cxx
+++ b/vcl/generic/fontmanager/fontmanager.cxx
@@ -289,6 +289,7 @@ bool PrintFontManager::PrintFont::readAfmMetrics( 
MultiAtomProvider* pProvider,
 }
 
 m_aEncodingVector.clear();
+m_aEncodingVectorPriority.clear();
 // fill in global info
 
 // PSName
@@ -502,7 +503,10 @@ bool PrintFontManager::PrintFont::readAfmMetrics( 
MultiAtomProvider* pProvider,
 {
 pUnicodes[i] = pChar-code + 0xf000;
 if( bFillEncodingvector )
+{
 m_aEncodingVector[ pUnicodes[i] ] = pChar-code;
+m_aEncodingVectorPriority.insert(pUnicodes[i]);
+}
 continue;
 }
 
@@ -563,7 +567,10 @@ bool PrintFontManager::PrintFont::readAfmMetrics( 
MultiAtomProvider* pProvider,
 {
 m_pMetrics-m_aMetrics[ pUnicodes[i] ] = aMetric;
 if( bFillEncodingvector )
+{
 m_aEncodingVector[ pUnicodes[i] ] = pChar-code;
+m_aEncodingVectorPriority.insert(pUnicodes[i]);
+}
 }
 else if( pChar-name )
 {
@@ -591,13 +598,21 @@ bool PrintFontManager::PrintFont::readAfmMetrics( 
MultiAtomProvider* pProvider,
 ::std::pair std::unordered_multimap sal_uInt8, 
sal_Unicode ::const_iterator,
   std::unordered_multimap sal_uInt8, sal_Unicode 
::const_iterator 
   aCodes = rManager.getUnicodeFromAdobeCode( 
pChar-code );
+bool bFirst = true;
 while( aCodes.first != 

[Libreoffice-bugs] [Bug 88822] New: APK needs helpful ChromeOS settings ...

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88822

Bug ID: 88822
   Summary: APK needs helpful ChromeOS settings ...
   Product: LibreOffice
   Version: unspecified
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: michael.me...@collabora.com

I talked with Simon Phipps who pointed me at:

http://lifehacker.com/how-to-run-android-apps-inside-chrome-on-any-desktop-op-1637564101

Apparently to make our APK run nicely on Chrome out of the box we need to add a
cbz file to the APK and play with / require / install the chromeos-apk-tool.

Would be great if someone could look into that - hopefully it's not too hard to
add to the flow in:

android/experimental/LOAndroid3

=)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - include/vcl sd/qa vcl/inc vcl/source

2015-01-27 Thread Caolán McNamara
 include/vcl/outdev.hxx|9 +
 sd/qa/unit/data/odp/pass/test-embedded-dejavu.odp |binary
 vcl/inc/outdev.h  |2 +
 vcl/source/gdi/embeddedfontshelper.cxx|5 +-
 vcl/source/outdev/font.cxx|   39 ++
 5 files changed, 47 insertions(+), 8 deletions(-)

New commits:
commit 2e9e1b2785223f862d52ec75d303566f3a859215
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Jan 20 11:24:26 2015 +

font cache gets broken on adding an embedded font

Change-Id: I665cde5d4c89443238efb283c86277dedf621197
(cherry picked from commit 20142afafc809890d5e8dcfd4103c46319a488df)
Reviewed-on: https://gerrit.libreoffice.org/14045
Tested-by: Michael Stahl mst...@redhat.com
Reviewed-by: Michael Stahl mst...@redhat.com

diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 806e501..9abd9e9 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1181,6 +1181,15 @@ public:
 
 SAL_DLLPRIVATE void ImplInitFontList() const;
 SAL_DLLPRIVATE void ImplUpdateFontData( bool bNewFontLists );
+
+//drop font data for all outputdevices.
+//If bNewFontLists is true then empty lists of system fonts
+SAL_DLLPRIVATE static void  ImplClearAllFontData( bool bNewFontLists );
+//fetch font data for all outputdevices
+//If bNewFontLists is true then fetch lists of system fonts
+SAL_DLLPRIVATE static void  ImplRefreshAllFontData( bool bNewFontLists );
+//drop and fetch font data for all outputdevices
+//If bNewFontLists is true then drop and refetch lists of system fonts
 SAL_DLLPRIVATE static void  ImplUpdateAllFontData( bool bNewFontLists );
 
 protected:
diff --git a/sd/qa/unit/data/odp/pass/test-embedded-dejavu.odp 
b/sd/qa/unit/data/odp/pass/test-embedded-dejavu.odp
new file mode 100644
index 000..d539e8c
Binary files /dev/null and b/sd/qa/unit/data/odp/pass/test-embedded-dejavu.odp 
differ
diff --git a/vcl/inc/outdev.h b/vcl/inc/outdev.h
index c878d8b2..5581fe1 100644
--- a/vcl/inc/outdev.h
+++ b/vcl/inc/outdev.h
@@ -143,6 +143,8 @@ private:
 typedef 
::boost::unordered_mapFontSelectPattern,ImplFontEntry*,IFSD_Hash,IFSD_Equal  
FontInstanceList;
 FontInstanceListmaFontInstanceList;
 
+int CountUnreferencedEntries() const;
+
 public:
 ImplFontCache();
 ~ImplFontCache();
diff --git a/vcl/source/gdi/embeddedfontshelper.cxx 
b/vcl/source/gdi/embeddedfontshelper.cxx
index 5706022..4c8d907 100644
--- a/vcl/source/gdi/embeddedfontshelper.cxx
+++ b/vcl/source/gdi/embeddedfontshelper.cxx
@@ -181,8 +181,9 @@ OUString EmbeddedFontsHelper::fileUrlForTemporaryFont( 
const OUString fontName,
 void EmbeddedFontsHelper::activateFont( const OUString fontName, const 
OUString fileUrl )
 {
 OutputDevice *pDevice = Application::GetDefaultDevice();
-pDevice-AddTempDevFont( fileUrl, fontName );
-OutputDevice::ImplUpdateAllFontData( true );
+OutputDevice::ImplClearAllFontData(true);
+pDevice-AddTempDevFont(fileUrl, fontName);
+OutputDevice::ImplRefreshAllFontData(true);
 }
 
 // Check if it's (legally) allowed to embed the font file into a document
diff --git a/vcl/source/outdev/font.cxx b/vcl/source/outdev/font.cxx
index b7d044c..b04a318 100644
--- a/vcl/source/outdev/font.cxx
+++ b/vcl/source/outdev/font.cxx
@@ -154,6 +154,7 @@ bool OutputDevice::AddTempDevFont( const OUString 
rFileURL, const OUString rFo
 if( mpAlphaVDev )
 mpAlphaVDev-AddTempDevFont( rFileURL, rFontName );
 
+ImplClearFontData(true);
 mpFontCache-Invalidate();
 return true;
 }
@@ -571,7 +572,7 @@ void OutputDevice::ImplUpdateFontData( bool bNewFontLists )
 ImplRefreshFontData( bNewFontLists );
 }
 
-void OutputDevice::ImplUpdateAllFontData( bool bNewFontLists )
+void OutputDevice::ImplClearAllFontData(bool bNewFontLists)
 {
 ImplSVData* pSVData = ImplGetSVData();
 
@@ -594,10 +595,19 @@ void OutputDevice::ImplUpdateAllFontData( bool 
bNewFontLists )
 }
 }
 }
+}
 
+void OutputDevice::ImplRefreshAllFontData(bool bNewFontLists)
+{
 ImplUpdateFontDataForAllFrames( OutputDevice::ImplRefreshFontData, 
bNewFontLists );
 }
 
+void OutputDevice::ImplUpdateAllFontData(bool bNewFontLists)
+{
+OutputDevice::ImplClearAllFontData(bNewFontLists);
+OutputDevice::ImplRefreshAllFontData(bNewFontLists);
+}
+
 void OutputDevice::ImplUpdateFontDataForAllFrames( const FontUpdateHandler_t 
pHdl, const bool bNewFontLists )
 {
 ImplSVData* const pSVData = ImplGetSVData();
@@ -1362,11 +1372,11 @@ void ImplFontCache::Release( ImplFontEntry* pEntry )
 {
 static const int FONTCACHE_MAX = 50;
 
-DBG_ASSERT( (pEntry-mnRefCount  0), ImplFontCache::Release() - font 
refcount underflow );
+assert(pEntry-mnRefCount  0  ImplFontCache::Release() - font refcount 
underflow);
 if( --pEntry-mnRefCount  0 )
 

[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - include/vcl vcl/inc vcl/source

2015-01-27 Thread Caolán McNamara
 include/vcl/outdev.hxx |9 +++
 vcl/inc/outdev.h   |2 +
 vcl/source/gdi/embeddedfontshelper.cxx |5 ++--
 vcl/source/outdev/font.cxx |   39 +++--
 4 files changed, 47 insertions(+), 8 deletions(-)

New commits:
commit c8833f7b2ad56070af813a0605df7b52823cbb29
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Jan 20 11:24:26 2015 +

font cache gets broken on adding an embedded font

(cherry picked from commit 20142afafc809890d5e8dcfd4103c46319a488df)

Conflicts:
vcl/source/gdi/embeddedfontshelper.cxx

Change-Id: I665cde5d4c89443238efb283c86277dedf621197
Reviewed-on: https://gerrit.libreoffice.org/14047
Tested-by: Michael Stahl mst...@redhat.com
Reviewed-by: Michael Stahl mst...@redhat.com

diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 3e98666..21f5931 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1133,6 +1133,15 @@ public:
 
 SAL_DLLPRIVATE void ImplInitFontList() const;
 SAL_DLLPRIVATE void ImplUpdateFontData( bool bNewFontLists );
+
+//drop font data for all outputdevices.
+//If bNewFontLists is true then empty lists of system fonts
+SAL_DLLPRIVATE static void  ImplClearAllFontData( bool bNewFontLists );
+//fetch font data for all outputdevices
+//If bNewFontLists is true then fetch lists of system fonts
+SAL_DLLPRIVATE static void  ImplRefreshAllFontData( bool bNewFontLists );
+//drop and fetch font data for all outputdevices
+//If bNewFontLists is true then drop and refetch lists of system fonts
 SAL_DLLPRIVATE static void  ImplUpdateAllFontData( bool bNewFontLists );
 
 protected:
diff --git a/vcl/inc/outdev.h b/vcl/inc/outdev.h
index dcde57c..a2f3b09 100644
--- a/vcl/inc/outdev.h
+++ b/vcl/inc/outdev.h
@@ -143,6 +143,8 @@ private:
 typedef 
::boost::unordered_mapFontSelectPattern,ImplFontEntry*,IFSD_Hash,IFSD_Equal  
FontInstanceList;
 FontInstanceListmaFontInstanceList;
 
+int CountUnreferencedEntries() const;
+
 public:
 ImplFontCache();
 ~ImplFontCache();
diff --git a/vcl/source/gdi/embeddedfontshelper.cxx 
b/vcl/source/gdi/embeddedfontshelper.cxx
index 1eca07e..4c8d907 100644
--- a/vcl/source/gdi/embeddedfontshelper.cxx
+++ b/vcl/source/gdi/embeddedfontshelper.cxx
@@ -181,8 +181,9 @@ OUString EmbeddedFontsHelper::fileUrlForTemporaryFont( 
const OUString fontName,
 void EmbeddedFontsHelper::activateFont( const OUString fontName, const 
OUString fileUrl )
 {
 OutputDevice *pDevice = Application::GetDefaultDevice();
-pDevice-AddTempDevFont( fileUrl, fontName );
-pDevice-ImplUpdateAllFontData( true );
+OutputDevice::ImplClearAllFontData(true);
+pDevice-AddTempDevFont(fileUrl, fontName);
+OutputDevice::ImplRefreshAllFontData(true);
 }
 
 // Check if it's (legally) allowed to embed the font file into a document
diff --git a/vcl/source/outdev/font.cxx b/vcl/source/outdev/font.cxx
index 7104caa..9df60e3 100644
--- a/vcl/source/outdev/font.cxx
+++ b/vcl/source/outdev/font.cxx
@@ -154,6 +154,7 @@ bool OutputDevice::AddTempDevFont( const OUString 
rFileURL, const OUString rFo
 if( mpAlphaVDev )
 mpAlphaVDev-AddTempDevFont( rFileURL, rFontName );
 
+ImplClearFontData(true);
 mpFontCache-Invalidate();
 return true;
 }
@@ -568,7 +569,7 @@ void OutputDevice::ImplUpdateFontData( bool bNewFontLists )
 ImplRefreshFontData( bNewFontLists );
 }
 
-void OutputDevice::ImplUpdateAllFontData( bool bNewFontLists )
+void OutputDevice::ImplClearAllFontData(bool bNewFontLists)
 {
 ImplSVData* pSVData = ImplGetSVData();
 
@@ -591,10 +592,19 @@ void OutputDevice::ImplUpdateAllFontData( bool 
bNewFontLists )
 }
 }
 }
+}
 
+void OutputDevice::ImplRefreshAllFontData(bool bNewFontLists)
+{
 ImplUpdateFontDataForAllFrames( OutputDevice::ImplRefreshFontData, 
bNewFontLists );
 }
 
+void OutputDevice::ImplUpdateAllFontData(bool bNewFontLists)
+{
+OutputDevice::ImplClearAllFontData(bNewFontLists);
+OutputDevice::ImplRefreshAllFontData(bNewFontLists);
+}
+
 void OutputDevice::ImplUpdateFontDataForAllFrames( const FontUpdateHandler_t 
pHdl, const bool bNewFontLists )
 {
 ImplSVData* const pSVData = ImplGetSVData();
@@ -1364,11 +1374,11 @@ void ImplFontCache::Release( ImplFontEntry* pEntry )
 {
 static const int FONTCACHE_MAX = 50;
 
-DBG_ASSERT( (pEntry-mnRefCount  0), ImplFontCache::Release() - font 
refcount underflow );
+assert(pEntry-mnRefCount  0  ImplFontCache::Release() - font refcount 
underflow);
 if( --pEntry-mnRefCount  0 )
 return;
 
-if( ++mnRef0Count  FONTCACHE_MAX )
+if (++mnRef0Count  FONTCACHE_MAX)
 return;
 
 // remove unused entries from font instance cache
@@ -1383,17 +1393,34 @@ void ImplFontCache::Release( ImplFontEntry* pEntry )
 

[Libreoffice-bugs] [Bug 84726] LibreOffice for Android most annoying bugs

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84726

Michael Meeks michael.me...@collabora.com changed:

   What|Removed |Added

 Depends on||88822

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88822] APK needs helpful ChromeOS settings ...

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88822

Michael Meeks michael.me...@collabora.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: svx/source

2015-01-27 Thread Stephan Bergmann
 svx/source/form/fmshimp.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit c072bd1df9bd01b34b99fbff50ee09bd5f5ac6ee
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Jan 27 12:16:59 2015 +0100

Lock SolarMutex around fmFormShell::DetermineForms calls

At least in JunitTest_forms_unoapi there are calls via URP of

 SfxShell::UIFeatureChanged
 FmFormShell::DetermineForms
 FmXFormShell::elementInserted
 cppu::OInterfaceContainerHelper::NotifySingleListener...::operator()
 cppu::OInterfaceContainerHelper::forEach...
 cppu::OInterfaceContainerHelper::notifyEach...
 frm::OInterfaceContainer::implInsert
 frm::OInterfaceContainer::insertByName
 frm::OFormsCollection::insertByName
 ...

where SfxShell::UIFeatureChanged does an svtools::AsynchronLink::Call, and 
there
are notorious crashes during JunitTest_forms_unoapi in

 vcl::Window::ImplRemoveDel
 Application::RemoveUserEvent
 svtools::AsynchronLink::~AsynchronLink
 SfxShell_Impl::~SfxShell_Impl
 SfxShell::~SfxShell
 FmFomrShell::~FmFormShell
 ...

and the naive hope is that the former's unlocked operations cause some
corruption that make the latter operate on a dangling 
AsynchronLink::_nEventId.

(As always, the question is at which level to lock the solar mutex;
frm::OFormsCollection et al appear to be properly mutex'ed, FmXFormShell 
appears
to be virtually un-mutex'ed, except for some smelly m_aInvalidationSafety 
and
m_aAsyncSafety, and FmFormShell and SfxShell appear to run under the 
assumption
that the solar mutex is always locked.  So stick the guards into 
FmXFormShell---
which is the only place calling DetermineForms---under the assumption that 
that
is the most likely place needing general mutex clean-up in the future, and 
thus
bears the highest chance the potentially becoming redundant guards will be
noticed again.)

Change-Id: Iad0f4bd9af2bf62330e26ac50edd170f470e79c4

diff --git a/svx/source/form/fmshimp.cxx b/svx/source/form/fmshimp.cxx
index 3ba69cc..e76c4f1 100644
--- a/svx/source/form/fmshimp.cxx
+++ b/svx/source/form/fmshimp.cxx
@@ -2548,6 +2548,8 @@ void FmXFormShell::elementInserted(const ContainerEvent 
evt) throw(::com::sun::
 Reference XInterface xTemp;
 evt.Element = xTemp;
 AddElement(xTemp);
+
+SolarMutexGuard g;
 m_pShell-DetermineForms(true);
 }
 
@@ -2573,6 +2575,8 @@ void FmXFormShell::elementRemoved(const ContainerEvent 
evt) throw(::com::sun::s
 Reference XInterface xTemp;
 evt.Element = xTemp;
 RemoveElement(xTemp);
+
+SolarMutexGuard g;
 m_pShell-DetermineForms(true);
 }
 
@@ -2598,6 +2602,7 @@ void FmXFormShell::UpdateForms( bool _bInvalidate )
 AddElement( m_xForms );
 }
 
+SolarMutexGuard g;
 m_pShell-DetermineForms( _bInvalidate );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3-6' - sc/source

2015-01-27 Thread Caolán McNamara
 sc/source/ui/cctrl/checklistmenu.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 5193f7fd1d4bbabc783621c7707075f09d679ad6
Author: Caolán McNamara caol...@redhat.com
Date:   Sat Jan 24 20:37:36 2015 +

Resolves: tdf#81124 crash on setting autofilter on column with no content

Change-Id: Id53e589789144d892427a8a4ec1af1926aa97b52
(cherry picked from commit 3a5fa612b4afb72b5f91877a5c52e25c7604ae1a)
Reviewed-on: https://gerrit.libreoffice.org/14160
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Reviewed-by: Christian Lohmaier lohmaier+libreoff...@googlemail.com

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx 
b/sc/source/ui/cctrl/checklistmenu.cxx
index 1b05eff..51166aa 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -1091,6 +1091,8 @@ void ScCheckListMenuWindow::selectCurrentMemberOnly(bool 
bSet)
 {
 setAllMemberState(!bSet);
 SvTreeListEntry* pEntry = maChecks.GetCurEntry();
+if (!pEntry)
+return;
 maChecks.CheckEntry(pEntry, bSet );
 }
 
@@ -1486,7 +1488,6 @@ void ScCheckListBox::KeyInput( const KeyEvent rKEvt )
 if ( rKey.GetCode() == KEY_RETURN || rKey.GetCode() == KEY_SPACE )
 {
 SvTreeListEntry* pEntry = GetCurEntry();
-
 if ( pEntry )
 {
 bool bCheck = ( GetCheckButtonState( pEntry ) == SV_BUTTON_CHECKED 
);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 88810] FILESAVE: avoid unnecessary massive OUString/OString allocations in XLSX export

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88810

László Németh nem...@numbertext.org changed:

   What|Removed |Added

 Attachment #112808|0   |1
is obsolete||
 Attachment #112818|0   |1
is obsolete||
 Attachment #112826|0   |1
is obsolete||

--- Comment #6 from László Németh nem...@numbertext.org ---
Created attachment 112827
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112827action=edit
kcachegrind profile - OStringBuffer version cleanup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88823] New: Useless graph and UI slow when selecting full column except one cell

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88823

Bug ID: 88823
   Summary: Useless graph and UI slow when selecting full column
except one cell
   Product: LibreOffice
   Version: 4.3.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: major
  Priority: medium
 Component: Spreadsheet
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nalimi...@club.fr

Created attachment 112828
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112828action=edit
ODS file to reproduce the problem

With the attached document, if you click on the header A to select the whole
column, hold Ctrl and click on the first cell of the column to unselect it,
then go to Insert-Object-Chart, the created chart is not correct, or at least
not useful. More precisely, it seems to include all empty cells below the
actual data, which makes it unreadable. It would be more useful to create the
same graph as if the whole column was selected (i.e. without unselecting
manually the first cell).

This situation arises in practical cases when the first cell contains some text
that you don't want to include in the legend (even more so if there are several
cells before the data).

Also, probably due to the fact that all cells below the data are used for the
chart, operation is very slow and RAM usage very high, to the point that
closing the chart dialog can takes a minute, thus giving the impression that
Calc crashed. This could lead to data loss if the user kills the app, or if the
systems runs out of memory.


This is with LO 4.3.5.2-11 on Fedora 21.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88824] New: Open/Create a report in Base causes LO to freeze

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88824

Bug ID: 88824
   Summary: Open/Create a report in Base causes LO to freeze
   Product: LibreOffice
   Version: 4.4.0.3 rc
  Hardware: Other
OS: Windows (All)
Status: UNCONFIRMED
  Severity: major
  Priority: medium
 Component: Database
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hl...@gmx.at

When trying to create a new report in LO Base, Lo freezes. The same happens
when trying to open/run an already existing report. This makes the reporting in
Base completetely unuseable

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3-6' - sw/source

2015-01-27 Thread Caolán McNamara
 sw/source/filter/html/htmlcss1.cxx |4 +++-
 sw/source/filter/html/swhtml.cxx   |7 ++-
 sw/source/filter/html/swhtml.hxx   |2 +-
 3 files changed, 10 insertions(+), 3 deletions(-)

New commits:
commit ce5ba3daffb6f4d109f5c02d49db3c7c08e101ed
Author: Caolán McNamara caol...@redhat.com
Date:   Fri Jan 23 11:45:14 2015 +

valgrind invalid read after delete in rhbz499052-1.html

Change-Id: Iecada2f8b6d977cc3f76814e4b2f38895873c362
(cherry picked from commit ae5410086e6cbe30b8a650b10b4d2250e5e017ec)
Reviewed-on: https://gerrit.libreoffice.org/14131
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Reviewed-by: Christian Lohmaier lohmaier+libreoff...@googlemail.com

diff --git a/sw/source/filter/html/htmlcss1.cxx 
b/sw/source/filter/html/htmlcss1.cxx
index e4628b6..c09cc86 100644
--- a/sw/source/filter/html/htmlcss1.cxx
+++ b/sw/source/filter/html/htmlcss1.cxx
@@ -2299,7 +2299,9 @@ void SwHTMLParser::InsertParaAttrs( const SfxItemSet 
rItemSet )
 if( RES_PARATR_BEGIN  nWhich )
 (*ppAttr)-SetLikePara();
 aParaAttrs.push_back( *ppAttr );
-EndAttr( *ppAttr, 0, false );
+bool bSuccess = EndAttr( *ppAttr, 0, false );
+if (!bSuccess)
+aParaAttrs.pop_back();
 }
 
 pItem = aIter.NextItem();
diff --git a/sw/source/filter/html/swhtml.cxx b/sw/source/filter/html/swhtml.cxx
index f6e3e39..0ab6909 100644
--- a/sw/source/filter/html/swhtml.cxx
+++ b/sw/source/filter/html/swhtml.cxx
@@ -2986,9 +2986,11 @@ void SwHTMLParser::NewAttr( _HTMLAttr **ppAttr, const 
SfxPoolItem rItem )
 (*ppAttr) = new _HTMLAttr( *pPam-GetPoint(), rItem, ppAttr );
 }
 
-void SwHTMLParser::EndAttr( _HTMLAttr* pAttr, _HTMLAttr **ppDepAttr,
+bool SwHTMLParser::EndAttr( _HTMLAttr* pAttr, _HTMLAttr **ppDepAttr,
 bool bChkEmpty )
 {
+bool bRet = true;
+
 OSL_ENSURE( !ppDepAttr, SwHTMLParser::EndAttr: ppDepAttr-Feature 
ungetestet? );
 // Der Listenkopf ist im Attribut gespeichert
 _HTMLAttr **ppHead = pAttr-ppHead;
@@ -3123,6 +3125,7 @@ void SwHTMLParser::EndAttr( _HTMLAttr* pAttr, _HTMLAttr 
**ppDepAttr,
 // leere Attribute in der Prev-Liste befinden, die dann trotzdem
 // gesetzt werden muessen
 _HTMLAttr *pPrev = pAttr-GetPrev();
+bRet = false;
 delete pAttr;
 
 if( pPrev )
@@ -3150,6 +3153,8 @@ void SwHTMLParser::EndAttr( _HTMLAttr* pAttr, _HTMLAttr 
**ppDepAttr,
 
 if( bMoveBack )
 pPam-Move( fnMoveForward );
+
+return bRet;
 }
 
 void SwHTMLParser::DeleteAttr( _HTMLAttr* pAttr )
diff --git a/sw/source/filter/html/swhtml.hxx b/sw/source/filter/html/swhtml.hxx
index cd97cad..39878b0 100644
--- a/sw/source/filter/html/swhtml.hxx
+++ b/sw/source/filter/html/swhtml.hxx
@@ -507,7 +507,7 @@ class SwHTMLParser : public SfxHTMLParser, public SwClient
 // ppDepAttr gibt einen Attribut-Tabellen-Eintrag an, dessen Attribute
 // gesetzt sein muessen, bevor das Attribut beendet werden darf
 void NewAttr( _HTMLAttr **ppAttr, const SfxPoolItem rItem );
-void EndAttr( _HTMLAttr *pAttr, _HTMLAttr **ppDepAttr=0,
+bool EndAttr( _HTMLAttr *pAttr, _HTMLAttr **ppDepAttr=0,
   bool bChkEmpty=true );
 void DeleteAttr( _HTMLAttr* pAttr );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 88824] Open/Create a report in Base causes LO to freeze

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88824

--- Comment #3 from Helmut Leininger hl...@gmx.at ---
Created attachment 112834
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112834action=edit
small database with a report defined

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 54741] Word count lost on toggling fullscreen

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=54741

Beluga todven...@suomi24.fi changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #3 from Beluga todven...@suomi24.fi ---
Reproduced.

Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+
Build ID: 784d069cc1d9f1d6e6a4e543a278376ab483d1eb
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-25_23:07:36

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 54741] Word count lost on toggling fullscreen

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=54741

Beluga todven...@suomi24.fi changed:

   What|Removed |Added

 OS|Linux (All) |All
   Severity|normal  |minor

--- Comment #4 from Beluga todven...@suomi24.fi ---
Let's lower severity to minor while we're at it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88824] Open/Create a report in Base causes LO to freeze

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88824

--- Comment #7 from Helmut Leininger hl...@gmx.at ---
Downloaded 4.4.0.3-3 and installed on Ubuntu and made another test with
Hausadressen1.odb (second attachment)

Summary of testing results:
Ubuntu an LO 4.4.0.3-3: everything seems to work.

Windows 8.1, LO 4.4.0.2:
New reports cannot be created (freeze).
Report Ansicht_Häuser_Adressen (added in Ubuntu with LO 4.3.3) can be executed
and modified.
Report Haeuser (created with older version of LO in Windows) can neither be
executed nor opend for modification (freeze).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - dbaccess/source

2015-01-27 Thread Lionel Elie Mamane
 dbaccess/source/core/misc/dsntypes.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ce7017cdbe5af3f75cded806f69c1040857b557f
Author: Lionel Elie Mamane lio...@mamane.lu
Date:   Mon Jan 26 04:44:08 2015 +0100

tdf#70236 propertly recognise full Access 2007 URL

Change-Id: If1f4986cfffada6a6ab507296a54589bdd5404ff
Reviewed-on: https://gerrit.libreoffice.org/14213
Tested-by: Michael Stahl mst...@redhat.com
Reviewed-by: Michael Stahl mst...@redhat.com

diff --git a/dbaccess/source/core/misc/dsntypes.cxx 
b/dbaccess/source/core/misc/dsntypes.cxx
index 7524ff2..835dbd3 100644
--- a/dbaccess/source/core/misc/dsntypes.cxx
+++ b/dbaccess/source/core/misc/dsntypes.cxx
@@ -368,7 +368,7 @@ DATASOURCE_TYPE ODsnTypeCollection::determineType(const 
OUString _rDsn) const
 {
 if (sDsn.startsWithIgnoreAsciiCase(sdbc:ado:access))
 {
-if 
(sDsn.equalsIgnoreAsciiCase(sdbc:ado:access:Provider=Microsoft.ACE.OLEDB.12.0;))
+if 
(sDsn.startsWithIgnoreAsciiCase(sdbc:ado:access:Provider=Microsoft.ACE.OLEDB.12.0;))
 return DST_MSACCESS_2007;
 else
 return DST_MSACCESS;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - dbaccess/source

2015-01-27 Thread Lionel Elie Mamane
 dbaccess/source/core/misc/dsntypes.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 73a1dd0ab850e089260e2c9af63f1998144bbebf
Author: Lionel Elie Mamane lio...@mamane.lu
Date:   Mon Jan 26 04:44:08 2015 +0100

tdf#70236 propertly recognise full Access 2007 URL

Change-Id: If1f4986cfffada6a6ab507296a54589bdd5404ff
Reviewed-on: https://gerrit.libreoffice.org/14212
Tested-by: Michael Stahl mst...@redhat.com
Reviewed-by: Michael Stahl mst...@redhat.com

diff --git a/dbaccess/source/core/misc/dsntypes.cxx 
b/dbaccess/source/core/misc/dsntypes.cxx
index c6b2419..f731a2e 100644
--- a/dbaccess/source/core/misc/dsntypes.cxx
+++ b/dbaccess/source/core/misc/dsntypes.cxx
@@ -360,7 +360,7 @@ DATASOURCE_TYPE ODsnTypeCollection::determineType(const 
OUString _rDsn) const
 {
 if (sDsn.startsWithIgnoreAsciiCase(sdbc:ado:access))
 {
-if 
(sDsn.equalsIgnoreAsciiCase(sdbc:ado:access:Provider=Microsoft.ACE.OLEDB.12.0;))
+if 
(sDsn.startsWithIgnoreAsciiCase(sdbc:ado:access:Provider=Microsoft.ACE.OLEDB.12.0;))
 return DST_MSACCESS_2007;
 else
 return DST_MSACCESS;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: CppCheck Report Failure

2015-01-27 Thread julien2412
Hi,

Just for information, I git updated LO sources (master branch) and cppcheck
today, ~/cppcheck/cppcheck/htmlreport/cppcheck-htmlreport didn't complain
about encoding problem.

I must say that I use Python 2.7.8 + I filter unusedFunction
Here are the lines I use:
cppcheck  -i external/ -i dictionaries/ --xml  --enable=all ./ 2 ./err.xml
~/cppcheck/cppcheck/htmlreport/cppcheck-htmlreport  --title=LibreOffice
--file=err.xml --report-dir=cppcheck_reports --source-dir=.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/CppCheck-Report-Failure-tp4137343p4137770.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 88796] Enhancement - Mysql native connector extension - add automatic reconnect to server capability in connector code after idle timeout

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88796

--- Comment #3 from hc.stoellin...@aon.at ---
Hello Alex,
You are right, the autoReconnect-feature depends on the type of connection. I
use the JDBC-version and it works NEARLY perfectly (see my enhancement
request). As you say, the native C++-connector might not have the necessary API
available. This would be a pity, since - after all - it performs better and
isn't there also a tendency in LO to want to become independent of Java? Again,
the Linux command-line client works o.k., just the way it should work. I don't
know its internals, but - isn't it maybe reasonable to assume it might be
written in c++ or at least c? Regards from snowed-in Salzburg...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - configure.ac

2015-01-27 Thread Andras Timar
 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit faf1498e0e2d1ab60eb7d88bced8cebe49584d28
Author: Andras Timar andras.ti...@collabora.com
Date:   Tue Jan 27 11:04:50 2015 -0800

Bump version to 4.2-23

Change-Id: Ica66c89fe86c18c436290a03849aa5ebfb4e8bc3

diff --git a/configure.ac b/configure.ac
index 3edc486..d996ab6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[4.2.10.22],[],[],[https://libreoffice-from-collabora.com/])
+AC_INIT([LibreOffice],[4.2.10.23],[],[],[https://libreoffice-from-collabora.com/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 88814] VIEWING: Subform linked to Addressbook results in parameter count error

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88814

--- Comment #7 from Tony tanta...@gmx.net ---
@Alex:

Sorry, I was under the impression, that the linking can be seen in the attached
form. All dtabase connections and subform/mainform links are done in design
mode using the form navigator and the form properties/data dialogs. 

1. The main form is connected to the ODB name database by selecting the
filename of the database and then the corresponding table.
2. To connect the subform to the previously registered address book I select it
as data source in the drop down list of the subform property/data tab.

On Ubuntu I have to use another address book of course. I chose the Thunderbird
one. My aim is to get it working on the Mac; I only used Ubuntu for test
purpose to narrow down the error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88831] When Set OpenGL, ComboBox Does Not Shows DownArrows Nor Verifying Marks Seem Correct

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88831

--- Comment #1 from morvan morvan...@gmail.com ---
Created attachment 112837
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112837action=edit
Verifying marks, when active OpenGL rendering, are inverted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [libreoffice-l10n] Re: Workflow between dev, UX and l10n teams

2015-01-27 Thread Rimas Kudelis
Hi Jan,


2015.01.26 16:43, Jan Holesovsky rašė:
 Mihovil Stanić píše v Po 26. 01. 2015 v 10:25 +0100:

 Cosmetic changes (~ to _ or Status to Status: or ... to … or those 
 different quote styles I don't even have on my keyboard) and anything 
 similliar - NOT OK if you don't script it for all languages
 Cosmetic changes (Big brown fox - Big Brown Fox) - NOT OK at all, 
 change just for en_us, don't change my strings and don't even notify me 
 you did it in en_us
 I see 2 problems here:

 1) There is no tool that would detect these trivial changes, and would
act accordingly.


 Regarding 1) - I thought that Pootle is detecting the trivial changes
 some way, and offering the original translation.  Is it not?  What can
 be done to improve that, so that for translators it is just a matter of
 checking; not a matter of translating?  [Or even what you suggest - that
 it would just update the source strings without touching the
 translations?]

Pootle does offer the original translation, but the localizer still has
to approve it.

Furthermore, Pootle does not apply any automatic changes. If you had
e.g. Some ~string, and you change it to Some _string, Pootle will
show the original translation as a hint, but the user will still have to
port this trivial change to the translation manually.

Needless to say, sometimes these minor differences avoid being noticed
by the localizers, which results in errors in the locale (I've seen
incorrect access key identifiers in the menus at least once).

However, while you are correct that there is no tool to detect these
changes, I don't think there has to be. The person who implements the
change knows better than anyone whether or not it can be automated,
perhaps they even automated it themselves. For example, I seriously
doubt that somebody went over all L10n files and changed triple dots to
ellipses manually, this was most likely a scripted change. Same, or very
similar, script would have probably worked with all other locales, but I
guess that person simply didn't think about it.

Similarly, changes in used quote characters most likely could have been
isolated and transplanted to locales.

Adding colons to certain strings only would probably have been slightly
more difficult, but still scriptable.

And none of that requires any tool to detect trivial changes... ;)


 2) The texts for translations are updated in big 'code' drops, without
possibility for translators to affect the process in any way - for
them it is too late.


 Regarding 2) - I'm glad that you say that the strings will be now
 getting to Pootle immediately after the code / string changes in master.
 I think it is important that the translators will be able to deal with
 the changes immediately, not several months later, so that they can
 cooperate, and not only react.

 In general, I don't think that setting extremely strict rules works,
 unless you have means how to enforce them - like via a commit hook or so
 (and it is extremely unpopular way to do things).

 It is always much better to communicate - if you see a developer who
 commits a change that causes you grief, please _do_ tell _him/her_
 immediately, and - if possible - in a friendly way.  I'm sure he/she
 will do much better the next time.

 Unfortunately I did not see any signs of notice that this or that change
 was problematic for localization on the development mailing list - were
 there such warnings there?  Like commit XY caused AB - please don't do
 such things, unless we agree how to do that effectively / without pain?
 Or was it impossible so far because the strings in Pootle were not
 synced with master?

I fully agree with you here, and yes, so far communicating these issues
was really difficult because these massive changes appeared in front of
the localizers' eyes way too late in the process.

Regards,
Rimas

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 88824] Open/Create a report in Base causes LO to freeze

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88824

--- Comment #5 from Helmut Leininger hl...@gmx.at ---
Created attachment 112835
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112835action=edit
DB with new report created with LO 4.3.3

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87537] COLOR PICKER: Always show scrollbar

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87537

--- Comment #4 from Jay Philips philip...@hotmail.com ---
(In reply to V Stuart Foote from comment #3)
 Sure, but isn't the issue that we are allowing the color swatches of a
 pallet to resize? I assume they are being calculated as percentage of the
 available width within the containing UI frame.  tango.soc are rectangular,
 standard.soc are square.

I believe that the colors being resizable is part of the problem, but that
problem is likely needed to be addressed when we want to deal with color
palettes that dont fit well in the 12 entries per row that we force color
palettes to be put in.

 As the color picker is non user resizable, couldn't the color swatches be
 set fixed width?

I think if we fixed it in tango.soc (as an example) it would put 13 entries per
row rather than 12, if the scrollbar is invisible.

 With fixed swatch sizes we could leave the vertical scroll present but
 dimmed inactive for smaller pallets. 

Yes this was what i was suggesting, that it be dimmed when it is not needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [Libreoffice-qa] Informations and help for a bug report

2015-01-27 Thread Terrence Enger
Marina,

Thank you for taking the time to help us improve LibreOffice.

A bug report would be good, please.  Please add me
lo_bugs@iseries-guru-com to the CC.  I can confirm the bug, and I
hope to do a bibisect.

More comments in-line.

Terry.

On Tue, 2015-01-27 at 17:10 +0100, Marina Latini wrote:
 Hi all,
 
 I'm writing here because I need to report a bug but I have some
problem to write the correct report.

This looks wonderful.  

 
 I have a business xlsx file with complex formulas. In particular there
are:
 * matrix with nested indirect references
 * formulas that refer to a query from Excel.

My old LibreOffice complains

This file contains links to other files.  Should they be updated?

When I click No it displays the file, but pegs the CPU for the few
minutes that I waited for it.

I presume that you have the linked-to file(s).  Do you get the same
result when you do and do not update the links?

 
 I can't open the document with a LibreOffice version bigger then
3.6.7.2. All the 4.X versions hang during opening while LibreOffice
3.6.7.2 opens the file with some errors.
 
 I can provide the xlsx file and 3 screenshots of the document opened
with Office365 and LibreOffice 3.6.7.2.
 I tested the files on my Ubuntu 14.04 x86_64 and on Windows Server
2012 R2
 
 I don't know what LibreOffice version set in the report but I'm sure
that 3.6.7.2 opens the file.

Set the earliest version which you have observed to fail to open the
file.  Anybody who finds an earlier failing version will adjust the
LibreOffice version to the earlier version.

 
 file to test: https://www.dropbox.com/s/4rmc162mgjisd4a/01%
20CLEAN.xlsx?dl=0
 
 Screenshot from Office365:
https://www.dropbox.com/s/ws8rr3mj6juouuo/01Clean_Office365.png?dl=0
 Screenshot from LibreOffice 3.6.7.2 (query):
https://www.dropbox.com/s/00xnspejrrk1nfd/01CleanLibO-query3672.png?dl=0
 Screenshot from LibreOffice 3.6.7.2 (matrix with indirect):
https://www.dropbox.com/s/h5qtxf6ji9u71n2/01CleanLibO-indirect3672.png?dl=0
 
 
 Best,
 Marina


___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [libreoffice-l10n] Re: Workflow between dev, UX and l10n teams

2015-01-27 Thread Sophie Gautier
Hi Rimas, all

Le 27 janv. 2015 19:32, Rimas Kudelis r...@akl.lt a écrit :

 Hi Jan,


 2015.01.26 16:43, Jan Holesovsky rašė:
  Mihovil Stanić píše v Po 26. 01. 2015 v 10:25 +0100:
 
  Cosmetic changes (~ to _ or Status to Status: or ... to … or those
  different quote styles I don't even have on my keyboard) and anything
  similliar - NOT OK if you don't script it for all languages
  Cosmetic changes (Big brown fox - Big Brown Fox) - NOT OK at all,
  change just for en_us, don't change my strings and don't even notify me
  you did it in en_us
  I see 2 problems here:
 
  1) There is no tool that would detect these trivial changes, and would
 act accordingly.
 
 
  Regarding 1) - I thought that Pootle is detecting the trivial changes
  some way, and offering the original translation.  Is it not?  What can
  be done to improve that, so that for translators it is just a matter of
  checking; not a matter of translating?  [Or even what you suggest - that
  it would just update the source strings without touching the
  translations?]

 Pootle does offer the original translation, but the localizer still has
 to approve it.

 Furthermore, Pootle does not apply any automatic changes. If you had
 e.g. Some ~string, and you change it to Some _string, Pootle will
 show the original translation as a hint, but the user will still have to
 port this trivial change to the translation manually.

 Needless to say, sometimes these minor differences avoid being noticed
 by the localizers, which results in errors in the locale (I've seen
 incorrect access key identifiers in the menus at least once).

 However, while you are correct that there is no tool to detect these
 changes, I don't think there has to be. The person who implements the
 change knows better than anyone whether or not it can be automated,
 perhaps they even automated it themselves. For example, I seriously
 doubt that somebody went over all L10n files and changed triple dots to
 ellipses manually, this was most likely a scripted change. Same, or very
 similar, script would have probably worked with all other locales, but I
 guess that person simply didn't think about it.

 Similarly, changes in used quote characters most likely could have been
 isolated and transplanted to locales.

 Adding colons to certain strings only would probably have been slightly
 more difficult, but still scriptable.

 And none of that requires any tool to detect trivial changes... ;)

That's the point of this discussion, thanks Rimas to make it :-)
L10n team can always react, and earlier now, but making the scripting part
of the commit or part of the 'one making the change' is more natural in the
workflow.  In other words, our product is not en_US only.


  2) The texts for translations are updated in big 'code' drops, without
 possibility for translators to affect the process in any way - for
 them it is too late.
 
 
  Regarding 2) - I'm glad that you say that the strings will be now
  getting to Pootle immediately after the code / string changes in master.
  I think it is important that the translators will be able to deal with
  the changes immediately, not several months later, so that they can
  cooperate, and not only react.
 
  In general, I don't think that setting extremely strict rules works,
  unless you have means how to enforce them - like via a commit hook or so
  (and it is extremely unpopular way to do things).
 
  It is always much better to communicate - if you see a developer who
  commits a change that causes you grief, please _do_ tell _him/her_
  immediately, and - if possible - in a friendly way.  I'm sure he/she
  will do much better the next time.
 
  Unfortunately I did not see any signs of notice that this or that change
  was problematic for localization on the development mailing list - were
  there such warnings there?  Like commit XY caused AB - please don't do
  such things, unless we agree how to do that effectively / without pain?
  Or was it impossible so far because the strings in Pootle were not
  synced with master?

 I fully agree with you here, and yes, so far communicating these issues
 was really difficult because these massive changes appeared in front of
 the localizers' eyes way too late in the process.

What we should take care though is to not over complicate the work of l10n
team by relying on this fact. So as I already said, it should be a shared
work and vigilance by the concerned teams.
Cheers
Sophie
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: feature/barcode feedback sought ...

2015-01-27 Thread jonathon
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 26/01/15 21:31, Michael Meeks wrote:

 draw:custom-shape draw:style-name=gr1 draw:text-style-name=P1
 draw:layer=layout svg:width=8.128cm svg:height=6.35cm
 svg:x=5.445cm svg:y=5.064cm
 
draw:engine=org.libreoffice.draw.barcode draw:data=LibreOffice
 prototype, native QR code rendering, thanks to Collabora
 ...
 /draw:custom-shape
 
   It -looks- like this code was intended to add a rather sexy extension
 point for custom shapes via the drawing::XCustomShapeEngine IDL file.
 Usually I love to hate UNO - but in this case it looks like what could
 be possible there is rather sexy.
 
   My -hope- is that this with minimal tweaking would allow me to have
 arbitrary python plugins rendering interesting document content - and
 also serializing their rendered state as an OLE-style preview to the
 XML.

It seems to me that you are saying that with the appropriate tweaking,
this can be used to generate other, non-barcode images.
A heraldic construction kit, for example. ^1


Am I reading too much into what you wrote?



^1: This is only an example. I fully sympathize with those individuals
and groups that are horrified by the thought of Joe Sixpack creating
their own crest, without any idea of what they are doing, much less why
they are doing so.

jonathon
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUx+O0AAoJEKG7hs8nSMR7IQ4QAJYeukOsJ8OoC9SZ/u+iy6gQ
lDh6Kf7hMQMGUt201EBpLilj2XK/p8WqqCTi9RVdnoCgBOI3olLsx78s+iDyWFQi
ncQ1utTyqiX1931wnXl2TbGrKKCotitYqgfo0f0u0Fqk6jbaY7kARaB0wvBi2c6J
KOLXcuE7kpoZwQxY2M1Rr9hQWCdHRpFdvIgLLSysv6KB83silMfH217kvGDMTx0K
peEaVvIXSoY5dQ46Fi91D4CAaunqqNMM76aZhPWKB1AY0fL8orWMD9OymA9S+kin
fGkm7MiWGvk+xdxvuW9WMstsW5ALf7pOQbW2kHB555S2RCoE8OGAIjovTc3GBSpF
f+NL9c2Gd59btfgM34nzmy+neJus3wGSj18gxjnWQJg9V3skpXdTkr8GBR6GBH7n
8h6MtqKzp6l32e4HelhO3YBALk3mbpyEXCP/Ir5IjeX9I109bJepAg8Njc9w5NXO
s/ain6jbCkPNcXX656Xt35gQBNWM/lpLnjx2io2WqZj4Yy4wA4CQdqsJSEMNi/o5
2DZuVrf5QA9H/MuYBCQDv2ugtRIkBcxqz9WE6Jd9+pT8FyEsyhqQYGdcoz3GP2Ie
ERjG9RvaGfdUF8lxdDJikT0A7RFqmjjhT3/TF9Kd1Hus9RLvell+mPZ5AY5fl4XI
W/R+KJ7t3G912KnDguoO
=w7pF
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 88831] When Set OpenGL, ComboBox Does Not Shows DownArrows Nor Verifying Marks Seem Correct

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88831

--- Comment #2 from morvan morvan...@gmail.com ---
When I speak to files, please read it two files. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88833] New: UI: Checkbox misaligned on high DPI screen (searchreplace bar at the bottom)

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88833

Bug ID: 88833
   Summary: UI: Checkbox misaligned on high DPI screen
(searchreplace bar at the bottom)
   Product: LibreOffice
   Version: 4.3.5.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Spreadsheet
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cyc...@gmx.net

Created attachment 112838
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112838action=edit
Screenshot showing the misaligned checkbox at the bottom.

The checkbox at the bottom saying Groß/Kleinschreibung (case sensitive
search) is misaligned at the top of the searchreplace bar. It should be
aligned with Alle suchen (search all) in the middle.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88832] New: Paramètres régionaux et interface utilisateur

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88832

Bug ID: 88832
   Summary: Paramètres régionaux et interface utilisateur
   Product: LibreOffice
   Version: 4.3.5.2 release
  Hardware: Other
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Linguistic
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zazaraig...@gmail.com

Je vis au Canada, au Québec plus précisément. Les formats de papier utilisés en
Amérique du nord sont tous Impériaux. Aussi je trouve particulièrement chiant
(excusez la grossièreté du mot, il exprime cependant très bien mon sentiment)
de ne pouvoir afficher qu'en système métrique. Il est beaucoup plus facile pour
moi de calculer les marges en pouces et fractions de pouce pour un page qui
sera de toutes façons en pouces à la sortie de l'imprimante.

J'ignore si vous aimeriez travailler avec une page ayant pour mesure 21,58cm
sur 27,94cm. Moi pas! Et même si les marges sont par défaut à 2 cm bien juste,
la largeur de la colonne de texte, elle, n'en est pas moins d'une largeur bien
chiante.

Ho! et tant que j'y pense, une fois le accommodations faites, n'oubliez pas que
les mesures de marge par défaut doivent elles aussi arriver à une mesure juste
de un demi pouce et pas à 0,49 pouce... sinon, je viens vous mordre! Naaannn!
j'exagère. Mais je manifesterai surement mon désappointement. 

J'ai l'air bougon comme ça, mais je tiens juste à vous faire remarquer que chez
Microsoft ils ont le même genre de problème... et je me disais, comme ça, que
ce serait bien que Libre Office offre à ses utilisateurs ce petit quelque chose
de plus que les grands ne font pas...

Parce que j'aime bien Libre Office et l'utilise même quand Ms Office est
présent sur mon ordi... ce qui n'est pas le cas présentement. 

Je veux mes pouces! Je suis née avec eux et j'y tiens! Les centimètres c'est
bon pour le format A4 (et tous les autres A de la création). Le format Lettre
américain, ça vient en pouces!

Merci d'avoir pris le temps de lire ma demande.

Isabelle Côté
Rimouski, Québec, Canada

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87876] DIALOG: View tab crushed by new strings

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87876

Adolfo Jayme f...@libreoffice.org changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|
  Component|ux-advise   |UI

--- Comment #9 from Adolfo Jayme f...@libreoffice.org ---
Will have a look.

Please don’t use UX-Advise for these obvious bugs…

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 70236] FILEOPEN: Cannot connect to .accdb file in LibreOffice 4.1

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=70236

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|BSA target:4.5.0|BSA target:4.5.0
   |target:4.3.7|target:4.3.7 target:4.4.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 70236] FILEOPEN: Cannot connect to .accdb file in LibreOffice 4.1

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=70236

--- Comment #16 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Lionel Elie Mamane committed a patch related to this issue.
It has been pushed to libreoffice-4-4:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=73a1dd0ab850e089260e2c9af63f1998144bbebfh=libreoffice-4-4

tdf#70236 propertly recognise full Access 2007 URL

It will be available in 4.4.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87876] DIALOG: View tab crushed by new strings

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87876

Adolfo Jayme f...@libreoffice.org changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |f...@libreoffice.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: minutes of ESC call ...

2015-01-27 Thread Cedric Bosdonnat
Hi there

On Thu, 2015-01-22 at 17:00 +, Michael Meeks wrote:
 * GSoC (Kendy)
 + February, 9th: Mentoring organizations can begin submitting 
 applications to Google.

It will be hard for me to join the call during the next month... but
that doesn't alter my capability to handle the admin side of GSoc this
year.

--
Cedric
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 70236] FILEOPEN: Cannot connect to .accdb file in LibreOffice 4.1

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=70236

--- Comment #15 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Lionel Elie Mamane committed a patch related to this issue.
It has been pushed to libreoffice-4-3:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ce7017cdbe5af3f75cded806f69c1040857b557fh=libreoffice-4-3

tdf#70236 propertly recognise full Access 2007 URL

It will be available in 4.3.7.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 70236] FILEOPEN: Cannot connect to .accdb file in LibreOffice 4.1

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=70236

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|BSA target:4.5.0|BSA target:4.5.0
   ||target:4.3.7

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/inc sw/source

2015-01-27 Thread Miklos Vajna
 sw/inc/pam.hxx   |1 +
 sw/source/core/crsr/pam.cxx  |8 
 sw/source/core/doc/docbm.cxx |   30 ++
 3 files changed, 27 insertions(+), 12 deletions(-)

New commits:
commit 58a50c3dc74cc9bd298d6b4156e45a8dbbffc116
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Tue Jan 27 09:09:10 2015 +0100

Extract SwPosition::dumpAsXml() from MarkManager

Change-Id: I7832f484861d32b01c8d5edd1adc4a80072cf7e2

diff --git a/sw/inc/pam.hxx b/sw/inc/pam.hxx
index 26d847f..616a45a 100644
--- a/sw/inc/pam.hxx
+++ b/sw/inc/pam.hxx
@@ -74,6 +74,7 @@ struct SW_DLLPUBLIC SwPosition
 bool operator =(const SwPosition ) const;
 bool operator ==(const SwPosition ) const;
 bool operator !=(const SwPosition ) const;
+void dumpAsXml(struct _xmlTextWriter* pWriter) const;
 };
 
 std::ostream operator (std::ostream s, const SwPosition position);
diff --git a/sw/source/core/crsr/pam.cxx b/sw/source/core/crsr/pam.cxx
index 68cbcff..b8dc0a6 100644
--- a/sw/source/core/crsr/pam.cxx
+++ b/sw/source/core/crsr/pam.cxx
@@ -190,6 +190,14 @@ SwDoc * SwPosition::GetDoc() const
 return nNode.GetNode().GetDoc();
 }
 
+void SwPosition::dumpAsXml(xmlTextWriterPtr pWriter) const
+{
+xmlTextWriterStartElement(pWriter, BAD_CAST(swPosition));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST(nNode), 
BAD_CAST(OString::number(nNode.GetIndex()).getStr()));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST(nContent), 
BAD_CAST(OString::number(nContent.GetIndex()).getStr()));
+xmlTextWriterEndElement(pWriter);
+}
+
 std::ostream operator (std::ostream s, const SwPosition position)
 {
 return s  SwPosition (node   position.nNode.GetIndex()  , offset 
  position.nContent.GetIndex()  );
diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index b3272a5..95e2956 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -1149,11 +1149,13 @@ void MarkManager::dumpAsXml(xmlTextWriterPtr pWriter) 
const
 {
 pMark_t pMark = *it;
 xmlTextWriterStartElement(pWriter, BAD_CAST(bookmark));
-xmlTextWriterWriteAttribute(pWriter, BAD_CAST(startNode), 
BAD_CAST(OString::number(pMark-GetMarkStart().nNode.GetIndex()).getStr()));
-xmlTextWriterWriteAttribute(pWriter, BAD_CAST(startOffset), 
BAD_CAST(OString::number(pMark-GetMarkStart().nContent.GetIndex()).getStr()));
-xmlTextWriterWriteAttribute(pWriter, BAD_CAST(endNode), 
BAD_CAST(OString::number(pMark-GetMarkEnd().nNode.GetIndex()).getStr()));
-xmlTextWriterWriteAttribute(pWriter, BAD_CAST(endOffset), 
BAD_CAST(OString::number(pMark-GetMarkEnd().nContent.GetIndex()).getStr()));
 xmlTextWriterWriteAttribute(pWriter, BAD_CAST(name), 
BAD_CAST(pMark-GetName().toUtf8().getStr()));
+xmlTextWriterStartElement(pWriter, BAD_CAST(markPos));
+pMark-GetMarkPos().dumpAsXml(pWriter);
+xmlTextWriterEndElement(pWriter);
+xmlTextWriterStartElement(pWriter, BAD_CAST(otherMarkPos));
+pMark-GetOtherMarkPos().dumpAsXml(pWriter);
+xmlTextWriterEndElement(pWriter);
 xmlTextWriterEndElement(pWriter);
 }
 xmlTextWriterEndElement(pWriter);
@@ -1166,11 +1168,13 @@ void MarkManager::dumpAsXml(xmlTextWriterPtr pWriter) 
const
 {
 pMark_t pMark = *it;
 xmlTextWriterStartElement(pWriter, BAD_CAST(fieldmark));
-xmlTextWriterWriteAttribute(pWriter, BAD_CAST(startNode), 
BAD_CAST(OString::number(pMark-GetMarkStart().nNode.GetIndex()).getStr()));
-xmlTextWriterWriteAttribute(pWriter, BAD_CAST(startOffset), 
BAD_CAST(OString::number(pMark-GetMarkStart().nContent.GetIndex()).getStr()));
-xmlTextWriterWriteAttribute(pWriter, BAD_CAST(endNode), 
BAD_CAST(OString::number(pMark-GetMarkEnd().nNode.GetIndex()).getStr()));
-xmlTextWriterWriteAttribute(pWriter, BAD_CAST(endOffset), 
BAD_CAST(OString::number(pMark-GetMarkEnd().nContent.GetIndex()).getStr()));
 xmlTextWriterWriteAttribute(pWriter, BAD_CAST(name), 
BAD_CAST(pMark-GetName().toUtf8().getStr()));
+xmlTextWriterStartElement(pWriter, BAD_CAST(markPos));
+pMark-GetMarkPos().dumpAsXml(pWriter);
+xmlTextWriterEndElement(pWriter);
+xmlTextWriterStartElement(pWriter, BAD_CAST(otherMarkPos));
+pMark-GetOtherMarkPos().dumpAsXml(pWriter);
+xmlTextWriterEndElement(pWriter);
 if (sw::mark::IFieldmark* pFieldmark = 
dynamic_castsw::mark::IFieldmark*(pMark.get()))
 {
 sw::mark::IFieldmark::parameter_map_t* pParameters = 
pFieldmark-GetParameters();
@@ -1199,11 +1203,13 @@ void MarkManager::dumpAsXml(xmlTextWriterPtr pWriter) 
const
 {
 pMark_t pMark = *it;
 xmlTextWriterStartElement(pWriter, BAD_CAST(annotationmark));
-

[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - 2 commits - include/LibreOfficeKit libreofficekit/source sw/source

2015-01-27 Thread Miklos Vajna
 include/LibreOfficeKit/LibreOfficeKit.h|8 -
 include/LibreOfficeKit/LibreOfficeKitGtk.h |2 +
 libreofficekit/source/gtk/lokdocview.c |   42 +
 sw/source/core/crsr/viscrs.cxx |9 ++
 4 files changed, 60 insertions(+), 1 deletion(-)

New commits:
commit 5ba05541e0cbb1dee712781f7d09c2d2038e9f08
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Tue Jan 27 09:34:04 2015 +0100

lokdocview: initial overlay on top of the tiles

It currently contains a non-blinking cursor caret in case at least one
character is typed.

Change-Id: I476bb1e8434a5df8c97054d670d68bc79721914e

diff --git a/include/LibreOfficeKit/LibreOfficeKitGtk.h 
b/include/LibreOfficeKit/LibreOfficeKitGtk.h
index b3cd304..75278e7 100644
--- a/include/LibreOfficeKit/LibreOfficeKitGtk.h
+++ b/include/LibreOfficeKit/LibreOfficeKitGtk.h
@@ -43,6 +43,8 @@ struct _LOKDocView
 LibreOfficeKitDocument* pDocument;
 /// View or edit mode.
 gboolean m_bEdit;
+/// Position and size of the visible cursor.
+GdkRectangle m_aVisibleCursor;
 };
 
 struct _LOKDocViewClass
diff --git a/libreofficekit/source/gtk/lokdocview.c 
b/libreofficekit/source/gtk/lokdocview.c
index bb2444c..e9a440e 100644
--- a/libreofficekit/source/gtk/lokdocview.c
+++ b/libreofficekit/source/gtk/lokdocview.c
@@ -23,6 +23,7 @@
 static void lok_docview_class_init( LOKDocViewClass* pClass );
 static void lok_docview_init( LOKDocView* pDocView );
 static float pixelToTwip(float nInput);
+static gboolean renderOverlay(GtkWidget* pWidget, GdkEventExpose* pEvent, 
gpointer pData);
 
 // We specifically need to destroy the document when closing in order to ensure
 // that lock files etc. are cleaned up.
@@ -109,9 +110,12 @@ static void lok_docview_init( LOKDocView* pDocView )
 
 pDocView-fZoom = 1;
 pDocView-m_bEdit = FALSE;
+memset(pDocView-m_aVisibleCursor, 0, sizeof(pDocView-m_aVisibleCursor));
 
 gtk_signal_connect( GTK_OBJECT(pDocView), destroy,
 GTK_SIGNAL_FUNC(lcl_onDestroy), NULL );
+g_signal_connect_after(pDocView-pEventBox, expose-event,
+   G_CALLBACK(renderOverlay), pDocView);
 }
 
 SAL_DLLPUBLIC_EXPORT GtkWidget* lok_docview_new( LibreOfficeKit* pOffice )
@@ -136,6 +140,38 @@ static float pixelToTwip(float nInput)
 return (nInput / g_nDPI) * 1440.0f;
 }
 
+static gboolean lcl_isEmptyRectangle(GdkRectangle* pRectangle)
+{
+return pRectangle-x == 0  pRectangle-y == 0  pRectangle-width == 0 
 pRectangle-height == 0;
+}
+
+static gboolean renderOverlay(GtkWidget* pWidget, GdkEventExpose* pEvent, 
gpointer pData)
+{
+LOKDocView* pDocView = pData;
+cairo_t* pCairo;
+
+(void)pEvent;
+pCairo = gdk_cairo_create(gtk_widget_get_window(pWidget));
+
+if (!lcl_isEmptyRectangle(pDocView-m_aVisibleCursor))
+{
+if (pDocView-m_aVisibleCursor.width == 0)
+// Set a minimal width if it would be 0.
+pDocView-m_aVisibleCursor.width = 30;
+
+cairo_set_source_rgb(pCairo, 0, 0, 0);
+cairo_rectangle(pCairo,
+twipToPixel(pDocView-m_aVisibleCursor.x),
+twipToPixel(pDocView-m_aVisibleCursor.y),
+twipToPixel(pDocView-m_aVisibleCursor.width),
+twipToPixel(pDocView-m_aVisibleCursor.height));
+cairo_fill(pCairo);
+}
+
+cairo_destroy(pCairo);
+return FALSE;
+}
+
 void renderDocument(LOKDocView* pDocView, GdkRectangle* pPartial)
 {
 long nDocumentWidthTwips, nDocumentHeightTwips, nDocumentWidthPixels, 
nDocumentHeightPixels;
@@ -292,6 +328,12 @@ static gboolean lok_docview_callback(gpointer pData)
 renderDocument(pCallback-m_pDocView, NULL);
 }
 break;
+case LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR:
+{
+pCallback-m_pDocView-m_aVisibleCursor = 
lcl_payloadToRectangle(pCallback-m_pPayload);
+gtk_widget_queue_draw(GTK_WIDGET(pCallback-m_pDocView-pEventBox));
+}
+break;
 default:
 break;
 }
commit 06b5aa80eb9cb4b2cbc77f41c83c0b7b0fe64a57
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Tue Jan 27 09:32:43 2015 +0100

Add LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR

So that clients can draw a blinking cursor at the cursor position if
they want so.

Change-Id: I662b8d28d7054f89c381c14333a51e1dc222f93d

diff --git a/include/LibreOfficeKit/LibreOfficeKit.h 
b/include/LibreOfficeKit/LibreOfficeKit.h
index 991fae4..d3b80cd 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/include/LibreOfficeKit/LibreOfficeKit.h
@@ -60,7 +60,13 @@ typedef enum
  * Rectangle format: width,height,x,y, where all numbers are document
  * coordinates, in twips.
  */
-LOK_CALLBACK_INVALIDATE_TILES
+LOK_CALLBACK_INVALIDATE_TILES,
+/**
+ * The size and/or the position of the visible cursor changed.
+ *
+ * Rectangle format is the same as 

[Libreoffice-bugs] [Bug 88051] Linux Libertine G ligature followed by tab: strange behavior

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88051

László Németh nem...@numbertext.org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from László Németh nem...@numbertext.org ---
Fixed in the master: 

http://cgit.freedesktop.org/libreoffice/core/commit/?id=06679dc5fa35fd0ac0e9c18427b869225435c581

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88819] Printing using Postscript hangs

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88819

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

   Keywords||bisected
 Status|UNCONFIRMED |NEW
 CC||caol...@redhat.com
 Ever confirmed|0   |1

--- Comment #3 from Matthew Francis fdb...@neosheffield.co.uk ---
(Having identified the commit in question, I am taking the liberty of setting
this to NEW)

The hang seems to have been introduced by the below commit.
Adding Cc: to caol...@redhat.com; Could you possibly take a look at this?
Thanks


commit bbf3aa7f92c194c9cc4546c95706e6b28e0c070c
Author: Caolán McNamara caol...@redhat.com
Date:   Fri Nov 14 11:06:44 2014 +

coverity#705989 silence Insecure temporary file

and

coverity#705983 Insecure temporary file

Change-Id: I2a501f8114ddf8968381e1880263abaf9d1bdc6f

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 71732] META: Bugs related to text rendering, typography and font features in LO

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 88051, which changed state.

Bug 88051 Summary: Linux Libertine G ligature followed by tab: strange behavior
https://bugs.documentfoundation.org/show_bug.cgi?id=88051

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88819] New: Printing using Postscript hangs

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88819

Bug ID: 88819
   Summary: Printing using Postscript hangs
   Product: LibreOffice
   Version: 4.4.0.2 rc
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fdb...@neosheffield.co.uk

Observed on Ubuntu 14.04 / LO 4.4.0.2. Not reproduced on LO 4.3.5.2

This was observed using a cups-pdf virtual PDF printer, but I don't believe
that it is specific to this.

Steps to reproduce
1. Create a blank Writer document
2. Type any small amount of random text
3. Open File - Print and select a printer
4. Open Properties... in the General tab
5. In the Device tab, set Printer language type to Postscript Level 3
6. Click OK in the Properties dialog
7. Click OK in the Print dialog

Expected result
- File prints

Actual result
- LO hangs with a Printing progress dialog open

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/source

2015-01-27 Thread László Németh
 vcl/source/glyphs/graphite_layout.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 06679dc5fa35fd0ac0e9c18427b869225435c581
Author: László Németh laszlo.nem...@collabora.com
Date:   Tue Jan 27 10:15:05 2015 +0100

tdf#88051 fix Graphite layout at Linux Libertine G ligature followed by tab

Change-Id: Iecedb87f6329c1cddcaa4cd939b349924e58d256

diff --git a/vcl/source/glyphs/graphite_layout.cxx 
b/vcl/source/glyphs/graphite_layout.cxx
index f72b780..cb481c5 100644
--- a/vcl/source/glyphs/graphite_layout.cxx
+++ b/vcl/source/glyphs/graphite_layout.cxx
@@ -591,7 +591,7 @@ gr_segment * GraphiteLayout::CreateSegment(ImplLayoutArgs 
rArgs)
 if ( !xCharClass.is() )
 xCharClass = vcl::unohelper::CreateCharacterClassification();
 size_t numchars2 = rArgs.mnEndCharPos - mnSegCharOffset; // fdo#52540, 
fdo#68313, fdo#70666 avoid bad ligature replacement
-if (numchars  numchars2  xCharClass-getType(rArgs.mpStr, numchars2 
+ 1) == ::com::sun::star::i18n::UnicodeType::LOWERCASE_LETTER)
+if (numchars  numchars2  (rArgs.mpStr[numchars2] == '\t' || 
xCharClass-getType(rArgs.mpStr, numchars2 + 1) == 
::com::sun::star::i18n::UnicodeType::LOWERCASE_LETTER))
 numchars = numchars2;
 if (mpFeatures)
 pSegment = gr_make_seg(mpFont, mpFace, 0, mpFeatures-values(), 
gr_utf16,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] buildbot.git: lcov-report/lcov-report.sh lcov-report/README lcov-report/tinderbox

2015-01-27 Thread Maarten Hoes
 lcov-report/README   |6 +++---
 lcov-report/lcov-report.sh   |2 +-
 lcov-report/tinderbox/.tb/profiles/lcov-make-check/phases.sh |4 ++--
 lcov-report/tinderbox/README.tb  |2 ++
 4 files changed, 8 insertions(+), 6 deletions(-)

New commits:
commit 45c3803ace2a9e17bae6f5d537bc29df81c8af0e
Author: Maarten Hoes hoes.maar...@gmail.com
Date:   Mon Jan 26 12:54:08 2015 +0100

Added 'gb_GCOV=YES' to make commands.

Change-Id: I88f43377c4614e14d4cc34aace0c8b2e3544a302
Reviewed-on: https://gerrit.libreoffice.org/14183
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/lcov-report/README b/lcov-report/README
index 735bbd6..f8afd82 100644
--- a/lcov-report/README
+++ b/lcov-report/README
@@ -96,14 +96,14 @@ EXAMPLE
 
 lcov-report.sh -b -C /home/user/build -t \
 /home/user/traces -s /home/user/src/libreoffice \
-   -d make check
+-d make check
 
 
 3.) Run tests.
 
 Now you can run the tests for which you want to report
-code coverage. This could be as simple as 'make check'
-in the build directory.
+code coverage. This could be as simple as 
+'gb_GCOV=YES make check' in the build directory.
 
 
 4.) Run 'lcov-report.sh -a'.
diff --git a/lcov-report/lcov-report.sh b/lcov-report/lcov-report.sh
index 20cd233..78f29ec 100755
--- a/lcov-report/lcov-report.sh
+++ b/lcov-report/lcov-report.sh
@@ -128,7 +128,7 @@ source_build()
 ${SRC_DIR?}/autogen.sh --enable-python=internal --disable-online-update 
--without-system-libs --without-system-headers \
 || die autogen.sh failed.
 
-make build-nocheck || die make build-nocheck failed.
+gb_GCOV=YES make build-nocheck || die make build-nocheck failed.
 
 cd -
 }
diff --git a/lcov-report/tinderbox/.tb/profiles/lcov-make-check/phases.sh 
b/lcov-report/tinderbox/.tb/profiles/lcov-make-check/phases.sh
index 3a2b5f8..f4218be 100644
--- a/lcov-report/tinderbox/.tb/profiles/lcov-make-check/phases.sh
+++ b/lcov-report/tinderbox/.tb/profiles/lcov-make-check/phases.sh
@@ -6,7 +6,7 @@ lcov-make-check_do_make()
 if [ ${R} = 0 ] ; then
 # we for MAKE_RESTARTS=1 because 1/ we know that Makefile is up to date
 # and 2/ the 'restart' mechanism in make is messed-up by the fact that 
we trap SIGINT
-if ! ${TB_NICE} ${TB_WATCHDOG} ${MAKE?} MAKE_RESTARTS=1 build-nocheck 
 tb_${P?}_build-nocheck.log 21 ; then
+if ! ${TB_NICE} ${TB_WATCHDOG} ${MAKE?} MAKE_RESTARTS=1 gb_GCOV=YES 
build-nocheck  tb_${P?}_build-nocheck.log 21 ; then
 tb_REPORT_LOG=tb_${P?}_build-nocheck.log
 tb_REPORT_MSGS=build failed - error is:
 [ $V ]  echo make failed :
@@ -20,7 +20,7 @@ lcov-make-check_do_make()
 [ $V ]  cat tb_${P?}_build-nocheck.log
 R=1
 else
-if ! ${TB_NICE} ${TB_WATCHDOG} ${MAKE?} MAKE_RESTARTS=1 check 
 tb_${P?}_build-nocheck.log 21 ; then
+if ! ${TB_NICE} ${TB_WATCHDOG} ${MAKE?} MAKE_RESTARTS=1 
gb_GCOV=YES check  tb_${P?}_build-nocheck.log 21 ; then
 tb_REPORT_LOG=tb_${P?}_build-nocheck.log
 tb_REPORT_MSGS=make check failed - error is:
 [ $V ]  echo make failed :
diff --git a/lcov-report/tinderbox/README.tb b/lcov-report/tinderbox/README.tb
index e525527..d6b7d94 100644
--- a/lcov-report/tinderbox/README.tb
+++ b/lcov-report/tinderbox/README.tb
@@ -20,3 +20,5 @@ directory tree to your existing ~/.tb tree, and add the 
profile
 also need to set 'TB_BRANCH', 'TB_BUILD_DIR', and 'TB_GIT_DIR'
 there. Additionally, you need to modify the 'TB_LCOV_*' variables in
 './.tb/profiles/lcov-make-check/config' to reflect your situation.
+
+You can then start tinderbox like so: debug=1 ./tb -p lcov-make-check -v
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - sw/source

2015-01-27 Thread Caolán McNamara
 sw/source/filter/html/wrthtml.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit f609239187e73059b63f9f5121b8ff5448311f62
Author: Caolán McNamara caol...@redhat.com
Date:   Sun Jan 25 14:12:22 2015 +

coverity#1266508 Useless call (gold)

regression from

commit 832e5aadbff006ec24959162c29756fe2b1982be
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Oct 8 10:06:59 2013 +0100
Related: fdo#38838 remove UniString::SearchAndReplaceAll

(cherry picked from commit 6cde3ff3dd646f51f37f2342863371db8de9087a)

Conflicts:
sw/source/filter/html/wrthtml.cxx

Change-Id: If792925eddc9c640584a2e8fa313a4297a32c74c
Reviewed-on: https://gerrit.libreoffice.org/14172
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com

diff --git a/sw/source/filter/html/wrthtml.cxx 
b/sw/source/filter/html/wrthtml.cxx
index 796dbe0..4d28937 100644
--- a/sw/source/filter/html/wrthtml.cxx
+++ b/sw/source/filter/html/wrthtml.cxx
@@ -1068,8 +1068,7 @@ void SwHTMLWriter::OutImplicitMark( const OUString rMark,
 {
 if( !rMark.isEmpty()  !aImplicitMarks.empty() )
 {
-OUString sMark( rMark );
-sMark + OUString(cMarkSeparator) + 
OUString::createFromAscii(pMarkType);
+OUString sMark(rMark + OUString(cMarkSeparator) + 
OUString::createFromAscii(pMarkType));
 if( 0 != aImplicitMarks.erase( sMark ) )
 {
 OutAnchor(sMark.replace('?', '_')); // '?' causes problems in 
IE/Netscape 5
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 87876] DIALOG: View tab crushed by new strings

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87876

--- Comment #8 from Harald Koester harald.koes...@mail.de ---
Oh, I forgot to mention the LO version and my system: Ver. 4.4.0.3, Win7.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88820] New: Lack of option to set spacing to contents at cell level

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88820

Bug ID: 88820
   Summary: Lack of option to set spacing to contents at cell
level
   Product: LibreOffice
   Version: 4.3.5.2 release
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: daniel.grigo...@movidius.com

I want to set a different spacing to contents for a cell, but I just can't. The
spacing to contents seems to work and apply only at global level.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [libreoffice-marketing] Re: [libreoffice-website] [LibreOffice Bugzilla Migration] We're done! Please visit the new site to reset your password!

2015-01-27 Thread Tom Davies
Hi :)
A big
+1
from me!  I guess there might be teething problems but hopefully we
can all be patient with those and just enjoy the advantages of the new
system more and more :)

Many thanks and regards from
Tom :)





On 25 January 2015 at 09:22, Florian Effenberger
flo...@documentfoundation.org wrote:
 Hi,

 Robinson Tryon wrote on 2015-01-24 at 21:50:

 The migration was a great success. All of our bugs are now happily living
 at

https://bugs.documentfoundation.org/


 thanks a lot to everyone involved, especially Robinson, Cloph and Alex -
 great work, and happy to finally have BugZilla in our own infrastructure!
 Thanks for the extra work during the weekend, you rock! ;-)

 Florian

 --
 To unsubscribe e-mail to: marketing+unsubscr...@global.libreoffice.org
 Problems?
 http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
 Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
 List archive: http://listarchives.libreoffice.org/global/marketing/

 All messages sent to this list will be publicly archived and cannot be
 deleted
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 88819] Printing using Postscript hangs

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88819

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

 CC||fdb...@neosheffield.co.uk

--- Comment #1 from Matthew Francis fdb...@neosheffield.co.uk ---
Created attachment 112819
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112819action=edit
Backtrace (4.5 master)

Breaking in with gdb gives the attached backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-qa] And then there were two...

2015-01-27 Thread Robinson Tryon
Bugzilla Products Table (bug counts):

  Impress Remote - 1
  LibreOffice - 33642

:-)

--

I've stubbed-in the basics for the Impress Remote product. Before we
jump in and move-over all of the bugs, let's get our ducks in a row
and our fields set up properly.

1) Are we missing any version #'s?

(Should those all be 'X.y.z alpha' or 'X.y.z final' ? Looks like
that's the naming convention so far, right Cloph?)

2) What Components should this product have?

Here's a start:
- Documentation
- General
- Localization
- UI

3) What's the difference between the Android and iOS ports?

NOTE: Both Android and iOS have been added to the 'OS' field (this is
a global field for all products). Please set this field when
migrating-over bug reports.

4) FirefoxOS? There's some code in there... have we ever built it?

https://gerrit.libreoffice.org/gitweb?p=impress_remote.git;a=history;f=firefoxos/sdremote;hb=HEAD

5) How about the Pebble remote? Should this have its own component?

(Gülşah: you're the expert here :-)


Thanks!
--R

-- 
Robinson Tryon
QA Engineer - The Document Foundation
LibreOffice Community Outreach Herald
qu...@libreoffice.org
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: cppuhelper/source include/cppuhelper

2015-01-27 Thread Stephan Bergmann
 cppuhelper/source/propshlp.cxx  |3 -
 cppuhelper/source/unourl.cxx|   73 ++--
 include/cppuhelper/propshlp.hxx |3 -
 include/cppuhelper/unourl.hxx   |   11 ++
 4 files changed, 40 insertions(+), 50 deletions(-)

New commits:
commit 0866023fafe4665f488eaea65a32cd1364e21594
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Jan 27 10:03:01 2015 +0100

Get rid of std::auto_ptr in stable URE interface

...the deprecation-warning noise is getting ever louder, and eventually 
auto_ptr
will just disappear.  Just surrender and use good-old plain pointer and 
deletion
in dtor---it's probably the best to do in this stable interface.

The change is backwards compatible.  For one, in all relevant standard 
libraries
(libstdc++, even in debug mode; libc++; msvcrt) sizeof(auto_ptrT) equals
sizeof(T*).  And for another, the removed UnoUrlDescriptor ctor was only 
called
from within cppuhelper and had deliberately been left out of
cppuhelper/source/gcc3.map (so isn't exported at least on Linux)---marking 
it
SAL_DLLPRIVATE had probably just been forgotten when retrofitting cppuhelper
with CPPUHELPER_DLLPUBLIC annotations.

Change-Id: Ic8bce29d93938f2b2e0a264baee85132668e1294

diff --git a/cppuhelper/source/propshlp.cxx b/cppuhelper/source/propshlp.cxx
index 509019c..0f1239d 100644
--- a/cppuhelper/source/propshlp.cxx
+++ b/cppuhelper/source/propshlp.cxx
@@ -199,6 +199,7 @@ OPropertySetHelper2::OPropertySetHelper2(
  */
 OPropertySetHelper::~OPropertySetHelper()
 {
+delete m_pReserved;
 }
 OPropertySetHelper2::~OPropertySetHelper2()
 {
@@ -631,8 +632,6 @@ void OPropertySetHelper::fire
 sal_Bool bVetoable
 )
 {
-OSL_ENSURE( m_pReserved.get(), No OPropertySetHelper::Impl );
-
 if (! m_pReserved-m_bFireEvents)
 return;
 
diff --git a/cppuhelper/source/unourl.cxx b/cppuhelper/source/unourl.cxx
index 14bde29..b73f176 100644
--- a/cppuhelper/source/unourl.cxx
+++ b/cppuhelper/source/unourl.cxx
@@ -31,6 +31,7 @@
 #include sal/types.h
 
 #include map
+#include memory
 
 using cppu::UnoUrl;
 using cppu::UnoUrlDescriptor;
@@ -137,49 +138,47 @@ inline UnoUrlDescriptor::Impl::Impl(rtl::OUString const  
rDescriptor)
 }
 
 UnoUrlDescriptor::UnoUrlDescriptor(rtl::OUString const  rDescriptor):
-m_xImpl(new Impl(rDescriptor))
+m_pImpl(new Impl(rDescriptor))
 {}
 
-SAL_WNODEPRECATED_DECLARATIONS_PUSH
-UnoUrlDescriptor::UnoUrlDescriptor(std::auto_ptr Impl   rImpl):
-m_xImpl(rImpl)
-{}
-SAL_WNODEPRECATED_DECLARATIONS_POP
-
 UnoUrlDescriptor::UnoUrlDescriptor(UnoUrlDescriptor const  rOther):
-m_xImpl(rOther.m_xImpl-clone())
+m_pImpl(rOther.m_pImpl-clone())
 {}
 
 UnoUrlDescriptor::~UnoUrlDescriptor()
-{}
+{
+delete m_pImpl;
+}
 
 UnoUrlDescriptor  UnoUrlDescriptor::operator =(UnoUrlDescriptor const  
rOther)
 {
-m_xImpl.reset(rOther.m_xImpl-clone());
+std::unique_ptrImpl newImpl(rOther.m_pImpl-clone());
+delete m_pImpl;
+m_pImpl = newImpl.release();
 return *this;
 }
 
 rtl::OUString const  UnoUrlDescriptor::getDescriptor() const
 {
-return m_xImpl-m_aDescriptor;
+return m_pImpl-m_aDescriptor;
 }
 
 rtl::OUString const  UnoUrlDescriptor::getName() const
 {
-return m_xImpl-m_aName;
+return m_pImpl-m_aName;
 }
 
 bool UnoUrlDescriptor::hasParameter(rtl::OUString const  rKey) const
 {
-return m_xImpl-m_aParameters.find(rKey.toAsciiLowerCase())
-!= m_xImpl-m_aParameters.end();
+return m_pImpl-m_aParameters.find(rKey.toAsciiLowerCase())
+!= m_pImpl-m_aParameters.end();
 }
 
 rtl::OUString UnoUrlDescriptor::getParameter(rtl::OUString const  rKey) const
 {
 Impl::Parameters::const_iterator
-aIt(m_xImpl-m_aParameters.find(rKey.toAsciiLowerCase()));
-return aIt == m_xImpl-m_aParameters.end() ? rtl::OUString() : aIt-second;
+aIt(m_pImpl-m_aParameters.find(rKey.toAsciiLowerCase()));
+return aIt == m_pImpl-m_aParameters.end() ? rtl::OUString() : aIt-second;
 }
 
 class UnoUrl::Impl
@@ -196,15 +195,13 @@ public:
 static inline Impl * create(rtl::OUString const  rUrl);
 
 private:
-SAL_WNODEPRECATED_DECLARATIONS_PUSH
-Impl(std::auto_ptr UnoUrlDescriptor::Impl   rConnection,
-  std::auto_ptr UnoUrlDescriptor::Impl   
rProtocol,
-  rtl::OUString const  rObjectName):
-m_aConnection(rConnection),
-m_aProtocol(rProtocol),
+Impl(rtl::OUString const  rConnectionDescriptor,
+ rtl::OUString const  rProtocolDescriptor,
+ rtl::OUString const  rObjectName):
+m_aConnection(rConnectionDescriptor),
+m_aProtocol(rProtocolDescriptor),
 m_aObjectName(rObjectName)
 {}
-SAL_WNODEPRECATED_DECLARATIONS_POP
 };
 
 inline UnoUrl::Impl * UnoUrl::Impl::create(rtl::OUString const  rUrl)
@@ -217,19 +214,13 @@ inline UnoUrl::Impl * UnoUrl::Impl::create(rtl::OUString 
const  rUrl)
 if (j  0)
 throw 

[Libreoffice-commits] core.git: accessibility/source vcl/source

2015-01-27 Thread Niklas Johansson
 accessibility/source/standard/vclxaccessibletoolbox.cxx |7 +++
 vcl/source/window/toolbox2.cxx  |3 +--
 2 files changed, 4 insertions(+), 6 deletions(-)

New commits:
commit 9b7b1774459edb93f2d3a11b2441851f4355a613
Author: Niklas Johansson sleeping.pil...@gmail.com
Date:   Mon Jan 26 23:16:07 2015 +0100

tdf#88702 ACCESSIBILITY Toggle buttons state not reliably updated

We need to adapt the accessibility code to handle 
VCLEVENT_TOOLBOX_ITEMUPDATED,
since it is now sent from vcl/source/window/toolbox2.cxx.
I have tested the patch successfully on Windows and Fedora.

Change-Id: Ia4328d3c34547cc28ce9a3946f90223442ee84e3
Reviewed-on: https://gerrit.libreoffice.org/14190
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/accessibility/source/standard/vclxaccessibletoolbox.cxx 
b/accessibility/source/standard/vclxaccessibletoolbox.cxx
index c3042fb..a8a7cdf 100644
--- a/accessibility/source/standard/vclxaccessibletoolbox.cxx
+++ b/accessibility/source/standard/vclxaccessibletoolbox.cxx
@@ -551,18 +551,17 @@ void VCLXAccessibleToolBox::ProcessWindowEvent( const 
VclWindowEvent rVclWindow
 case VCLEVENT_TOOLBOX_DEACTIVATE:
 //case VCLEVENT_TOOLBOX_SELECT:
 break;
-// IA2 CWS. MT: Still using VCLEVENT_TOOLBOX_CLICK, see comment in 
vcl/source/window/toolbox2.cxx
-/*
+
 case VCLEVENT_TOOLBOX_ITEMUPDATED:
 {
 if ( rVclWindowEvent.GetData() )
 {
 UpdateChecked_Impl( TOOLBOX_ITEM_NOTFOUND );
-UpdateIndeterminate_Impl( (sal_Int32)rVclWindowEvent.GetData() 
);
+UpdateIndeterminate_Impl( 
(sal_Int32)reinterpret_castsal_IntPtr(rVclWindowEvent.GetData()) );
 }
 break;
 }
-*/
+
 case VCLEVENT_TOOLBOX_HIGHLIGHT:
 UpdateFocus_Impl();
 break;
diff --git a/vcl/source/window/toolbox2.cxx b/vcl/source/window/toolbox2.cxx
index e1cad51..247aaef 100644
--- a/vcl/source/window/toolbox2.cxx
+++ b/vcl/source/window/toolbox2.cxx
@@ -1458,8 +1458,7 @@ void ToolBox::SetItemState( sal_uInt16 nItemId, TriState 
eState )
 // Notify button changed event to prepare accessibility bridge
 CallEventListeners( VCLEVENT_TOOLBOX_BUTTONSTATECHANGED, 
reinterpret_cast void* ( nPos ) );
 
-// Notify
-//Solution:Call accessible listener to notify state_changed event
+// Call accessible listener to notify state_changed event
 CallEventListeners( VCLEVENT_TOOLBOX_ITEMUPDATED, 
reinterpret_cast void* (nPos) );
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - external/firebird

2015-01-27 Thread Julien Nabet
 external/firebird/UnpackedTarball_firebird.mk|1 
 external/firebird/firebird.disable-ib-util-not-found.patch.1 |   19 +++
 2 files changed, 20 insertions(+)

New commits:
commit 3c2dd3d5b94c6bfa2dc1c87b3f45562f60b41136
Author: Julien Nabet serval2...@yahoo.fr
Date:   Fri Jan 23 22:28:55 2015 +0100

Resolves fdo#72543: ib_util not found when creating or accessing new 
firebird

... embedded database
See https://bugs.freedesktop.org/show_bug.cgi?id=72543#c8
and https://bugs.freedesktop.org/show_bug.cgi?id=72543#c13

Change-Id: I299ab19f43ff9aa87362adf76d3a362279fc
Reviewed-on: https://gerrit.libreoffice.org/14146
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Lionel Elie Mamane lio...@mamane.lu
(cherry picked from commit e3c0025461bdf55e62a308a76c3aa0a35109f076)
Reviewed-on: https://gerrit.libreoffice.org/14149
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/external/firebird/UnpackedTarball_firebird.mk 
b/external/firebird/UnpackedTarball_firebird.mk
index 4e3aec4..ee29b09 100644
--- a/external/firebird/UnpackedTarball_firebird.mk
+++ b/external/firebird/UnpackedTarball_firebird.mk
@@ -17,6 +17,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,firebird,\
external/firebird/firebird-c++11.patch.1 \
external/firebird/firebird-c++11replfn.patch.0 \
external/firebird/firebird-no-open-temp-on-shutdown.patch.1 \
+external/firebird/firebird.disable-ib-util-not-found.patch.1 \
 ))
 
 ifeq ($(OS)-$(COM),WNT-MSC)
diff --git a/external/firebird/firebird.disable-ib-util-not-found.patch.1 
b/external/firebird/firebird.disable-ib-util-not-found.patch.1
new file mode 100644
index 000..c0c4bb6
--- /dev/null
+++ b/external/firebird/firebird.disable-ib-util-not-found.patch.1
@@ -0,0 +1,19 @@
+--- firebird.org/src/jrd/fun.epp   2015-01-23 22:11:26.751475044 +0100
 firebird/src/jrd/fun.epp   2015-01-23 22:16:42.507322568 +0100
+@@ -160,10 +160,14 @@
+   if (tryLibrary(LIBNAME, message[3]))
+   return;
+ 
++/* fdo#72543: quote from 
https://bugs.freedesktop.org/show_bug.cgi?id=72543#c8
++   we don't need UDF support for embedded firebird,
++ hence the lack of ib_util isn't an issue and can safely be 
ignored
+   // all failed - log error
+   gds__log(ib_util init failed, UDFs can't be used - looks like firebird 
misconfigured\n
+\t%s\n\t%s\n\t%s\n\t%s, message[0].c_str(), 
message[1].c_str(),
+  
message[2].c_str(), message[3].c_str());
++*/
+ #endif// !BOOT_BUILD
+ }
+ 
+Seulement dans firebird/src/misc: codes.cpp
+Seulement dans firebird: temp
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - vcl/source

2015-01-27 Thread László Németh
 vcl/source/glyphs/graphite_layout.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e3e3a8e3f13d79814f6b0e8b6e4efc14b65971c9
Author: László Németh laszlo.nem...@collabora.com
Date:   Tue Jan 27 10:15:05 2015 +0100

tdf#88051 fix Graphite layout at Linux Libertine G ligature followed by tab

Change-Id: Iecedb87f6329c1cddcaa4cd939b349924e58d256

diff --git a/vcl/source/glyphs/graphite_layout.cxx 
b/vcl/source/glyphs/graphite_layout.cxx
index 230583b..50e2a2d 100644
--- a/vcl/source/glyphs/graphite_layout.cxx
+++ b/vcl/source/glyphs/graphite_layout.cxx
@@ -600,7 +600,7 @@ gr_segment * GraphiteLayout::CreateSegment(ImplLayoutArgs 
rArgs)
 if ( !xCharClass.is() )
 xCharClass = vcl::unohelper::CreateCharacterClassification();
 size_t numchars2 = rArgs.mnEndCharPos - mnSegCharOffset; // fdo#52540, 
fdo#68313, fdo#70666 avoid bad ligature replacement
-if (numchars  numchars2  xCharClass-getType(rArgs.mpStr, numchars2 
+ 1) == ::com::sun::star::i18n::UnicodeType::LOWERCASE_LETTER)
+if (numchars  numchars2  (rArgs.mpStr[numchars2] == '\t' || 
xCharClass-getType(rArgs.mpStr, numchars2 + 1) == 
::com::sun::star::i18n::UnicodeType::LOWERCASE_LETTER))
 numchars = numchars2;
 if (mpFeatures)
 pSegment = gr_make_seg(mpFont, mpFace, 0, mpFeatures-values(), 
gr_utf16,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 88660] Can not change font color of date/time field

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88660

--- Comment #7 from Alex Finch a.fi...@lancaster.ac.uk ---

OK, and I assume it actually changed the color in normal view? Your screenshot
shows what I try to do, and it just doesn't work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 46507] Quickstarter also should be used for FILEOPEN from File Explorer

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=46507

Zoran zo...@zoran.cz changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Zoran zo...@zoran.cz ---
I have tried the quickstarter in LO 4.4.0.3 / Win32
and it WORKED!

Starting Writer (new document from desktop icon or opening existing document
from file explorer, not from quickstartet popup menu)
quickstarter off - 7-8 seconds
quickstarter on - 2-3 seconds!

As far asi I can tell, the bug has been solved, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88819] Printing using Postscript hangs

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88819

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

   Keywords||regression
 Whiteboard||bibisected

--- Comment #2 from Matthew Francis fdb...@neosheffield.co.uk ---
Bibisect results from 44:

cbd5e771b8289518f03bcaee7f10db42736533d7 is the first bad commit
commit cbd5e771b8289518f03bcaee7f10db42736533d7
Author: Robinson Tryon qu...@runcibility.com
Date:   Tue Dec 2 16:44:28 2014 +0100

source-hash-f9da47eb6a9affb7bb42eafe6637b8059a3b0015

commit f9da47eb6a9affb7bb42eafe6637b8059a3b0015

# bad: [4a3091e95fa263d3e2dd81e56e83996f0bb12287]
source-hash-2b5b04e1e62914bf0902dfd7943cdc44499c47a6
# good: [812c4a492375ac47b3557fbb32f5637fc89d60d9]
source-hash-dea4a3b9d7182700abeb4dc756a24a9e8dea8474
git bisect start 'latest' 'oldest'
# good: [5d0dfb8e62ae61a240f8313c594d4560e7c8e048]
source-hash-0c6cd530de13f80795881f61064f1bf1dcc4ea81
git bisect good 5d0dfb8e62ae61a240f8313c594d4560e7c8e048
# good: [7dfacd0b8bd828331d74c0f79de6e8924bc4e6a5]
source-hash-f93ce4f7eb90093d0ea3115d0a1c614612676dbd
git bisect good 7dfacd0b8bd828331d74c0f79de6e8924bc4e6a5
# good: [a42da134cd542144fca7ba14cce86c2b409fc18a]
source-hash-beadebc0f7eb5582fcb8dcb082d19afdf2751876
git bisect good a42da134cd542144fca7ba14cce86c2b409fc18a
# good: [038f586bf711ad77856916be954b6c02a5717eb1]
source-hash-2ec4c8b07427af868e32e14aaefd20649c1135d6
git bisect good 038f586bf711ad77856916be954b6c02a5717eb1
# skip: [1c1bb47aa932531a0486c1af5460f7f7f3de510a]
source-hash-16068663e2aa984388be5f774b8f1917c12bf6f3
git bisect skip 1c1bb47aa932531a0486c1af5460f7f7f3de510a
# skip: [3eb627eb6d3e4f8e40b2154b4eba649ebce8873b]
source-hash-ec8688fa2a311ce5fb463ce7c321757d1c2d8a3b
git bisect skip 3eb627eb6d3e4f8e40b2154b4eba649ebce8873b
# good: [777b702a1fa5888067aad38d44751220dc0bf5cc]
source-hash-f18fd73e287b781e953a3c4bfa05b55f39880a35
git bisect good 777b702a1fa5888067aad38d44751220dc0bf5cc
# good: [46e5c194e9f596dcd076c2c77e4c7136212b8758]
source-hash-36ff1527c9cb20542d3097d123d221c40a356795
git bisect good 46e5c194e9f596dcd076c2c77e4c7136212b8758
# bad: [817d17c44366e01a42fb4cab3caed54d5d5d3b57]
source-hash-272d330cec558040d87f8386aa7aaab67f8adab6
git bisect bad 817d17c44366e01a42fb4cab3caed54d5d5d3b57
# good: [34a0be9c37c982a3cb6aa39ae34e62beabdd2040]
source-hash-06458fdeb862dc483dcac8107a5cc8c2da01a3f0
git bisect good 34a0be9c37c982a3cb6aa39ae34e62beabdd2040
# bad: [5e3b82d0ec3ad9bd56157084cd18d4d0427d388e]
source-hash-30123b9559e2fb74c9db7d530c538a1c6dc7e32c
git bisect bad 5e3b82d0ec3ad9bd56157084cd18d4d0427d388e
# bad: [cbd5e771b8289518f03bcaee7f10db42736533d7]
source-hash-f9da47eb6a9affb7bb42eafe6637b8059a3b0015
git bisect bad cbd5e771b8289518f03bcaee7f10db42736533d7
# first bad commit: [cbd5e771b8289518f03bcaee7f10db42736533d7]
source-hash-f9da47eb6a9affb7bb42eafe6637b8059a3b0015

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [Libreoffice-qa] [LibreOffice Bugzilla Migration] We're done! Please visit the new site to reset your password!

2015-01-27 Thread Robinson Tryon
On Mon, Jan 26, 2015 at 3:17 PM, Michael Stahl mst...@redhat.com wrote:
 if i go to Saved Searches there are a whole bunch of XOrg and GPU
 driver related ones imported from FDO; somebody with sufficient
 privileges needs to clean up there.

HIya,
I cleaned up some of the obvious queries. Are there any more that
should be removed?

Thanks,
--R


-- 
Robinson Tryon
QA Engineer - The Document Foundation
LibreOffice Community Outreach Herald
qu...@libreoffice.org
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: starmath/source

2015-01-27 Thread Takeshi Abe
 starmath/source/node.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9efb04dfbf70e123da1755adcede8199eabf0d9a
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Tue Jan 27 12:33:02 2015 +0900

Fix a single quote slipped in

See void SmNodeToTextVisitor::Visit( SmFontNode* pNode ) for comparison.

Change-Id: Id7e58fef3b715ef2a4bcb4e1a1d390aadf917b5f
Reviewed-on: https://gerrit.libreoffice.org/14193
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index 8cc7f0b..083e3dc 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -2046,7 +2046,7 @@ void SmFontNode::CreateTextFromNode(OUString rText)
 rText += -;
 break;
 case FNTSIZ_MULTIPLY:
-rText += *';
+rText += *;
 break;
 case FNTSIZ_DIVIDE:
 rText += /;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - starmath/source

2015-01-27 Thread Takeshi Abe
 starmath/source/node.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 32e7fc9e82e0e62e872611482d97f745bac3899a
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Tue Jan 27 12:33:02 2015 +0900

Fix a single quote slipped in

See void SmNodeToTextVisitor::Visit( SmFontNode* pNode ) for comparison.

Change-Id: Id7e58fef3b715ef2a4bcb4e1a1d390aadf917b5f
Reviewed-on: https://gerrit.libreoffice.org/14193
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
(cherry picked from commit 9efb04dfbf70e123da1755adcede8199eabf0d9a)
Reviewed-on: https://gerrit.libreoffice.org/14198

diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index 41a74b5..9da0d21 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -2052,7 +2052,7 @@ void SmFontNode::CreateTextFromNode(OUString rText)
 rText += -;
 break;
 case FNTSIZ_MULTIPLY:
-rText += *';
+rText += *;
 break;
 case FNTSIZ_DIVIDE:
 rText += /;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2015-01-27 Thread Philipp Weissenbacher
 sw/source/core/text/porexp.cxx  |   51 +++
 sw/source/core/text/porfld.cxx  |  136 +---
 sw/source/core/text/porfld.hxx  |   27 ---
 sw/source/core/text/porfly.cxx  |   69 ++--
 sw/source/core/text/porfly.hxx  |6 -
 sw/source/core/text/porglue.cxx |   24 ---
 sw/source/core/text/txtdrop.cxx |   10 +-
 sw/source/core/text/txthyph.cxx |   74 +++--
 8 files changed, 212 insertions(+), 185 deletions(-)

New commits:
commit acabab05c1f99f9bd47638b9d3899d2e64aca1de
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Sun Jan 25 17:35:00 2015 +0100

fdo#39468 Translate German comments - sw/source/core/text

Change-Id: Idee941019e87f4e132110adf566e432f99df79ce
Reviewed-on: https://gerrit.libreoffice.org/14174
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/sw/source/core/text/porexp.cxx b/sw/source/core/text/porexp.cxx
index 50f2370..5e9e10a 100644
--- a/sw/source/core/text/porexp.cxx
+++ b/sw/source/core/text/porexp.cxx
@@ -28,8 +28,8 @@ sal_Int32 SwExpandPortion::GetCrsrOfst( const sal_uInt16 
nOfst ) const
 bool SwExpandPortion::GetExpTxt( const SwTxtSizeInfo, OUString rTxt ) const
 {
 rTxt.clear();
-// Nicht etwa: return 0 != rTxt.Len();
-// Weil: leere Felder ersetzen CH_TXTATR gegen einen Leerstring
+// Do not do: return 0 != rTxt.Len();
+// Reason being: empty fields replace CH_TXTATR with an empty string
 return true;
 }
 
@@ -44,19 +44,17 @@ SwPosSize SwExpandPortion::GetTxtSize( const SwTxtSizeInfo 
rInf ) const
 return rInf.GetTxtSize();
 }
 
-// 5010: Exp und Tabs
-
 bool SwExpandPortion::Format( SwTxtFormatInfo rInf )
 {
 SwTxtSlot aDiffTxt( rInf, this, true, false );
 const sal_Int32 nFullLen = rInf.GetLen();
 
-// So komisch es aussieht, die Abfrage auf GetLen() muss wegen der
-// ExpandPortions _hinter_ aDiffTxt (vgl. SoftHyphs)
-// false returnen wegen SetFull ...
+// As odd as it may seem: the query for GetLen() must return
+// false due to the ExpandPortions _after_ the aDiffTxt (see SoftHyphs)
+// caused by the SetFull ...
 if( !nFullLen )
 {
-// nicht Init(), weil wir Hoehe und Ascent brauchen
+// Do not Init(), because we need height and ascent
 Width(0);
 return false;
 }
@@ -75,7 +73,7 @@ void SwExpandPortion::Paint( const SwTxtPaintInfo rInf ) 
const
 rInf.DrawBackBrush( *this );
 rInf.DrawBorder( *this );
 
-// do we have to repaint a post it portion?
+// Do we have to repaint a post it portion?
 if( rInf.OnWin()  pPortion  !pPortion-Width() )
 pPortion-PrePaint( rInf, this );
 
@@ -98,11 +96,11 @@ void SwExpandPortion::Paint( const SwTxtPaintInfo rInf ) 
const
 
 SwLinePortion *SwBlankPortion::Compress() { return this; }
 
-// 5497: Es gibt schon Gemeinheiten auf der Welt...
-// Wenn eine Zeile voll mit HardBlanks ist und diese ueberlaeuft,
-// dann duerfen keine Underflows generiert werden!
-// Komplikationen bei Flys...
-
+/**
+ * If a Line is full of HardBlanks and overflows, we must not generate
+ * underflows!
+ * Causes problems with Fly
+ */
 sal_uInt16 SwBlankPortion::MayUnderflow( const SwTxtFormatInfo rInf,
 sal_Int32 nIdx, bool bUnderflow ) const
 {
@@ -114,9 +112,10 @@ sal_uInt16 SwBlankPortion::MayUnderflow( const 
SwTxtFormatInfo rInf,
 while( pPos  pPos-IsBlankPortion() )
 pPos = pPos-GetPortion();
 if( !pPos || !rInf.GetIdx() || ( !pPos-GetLen()  pPos == rInf.GetRoot() 
) )
-return 0; // Nur noch BlankPortions unterwegs
-// Wenn vor uns ein Blank ist, brauchen wir kein Underflow ausloesen,
-// wenn hinter uns ein Blank ist, brauchen wir kein Underflow weiterreichen
+return 0; // There are just BlankPortions left
+
+// If a Blank is preceding us, we do not need to trigger underflow
+// If a Blank is succeeding us, we do not need to pass on the underflow
 if (bUnderflow  nIdx + 1  rInf.GetTxt().getLength()  CH_BLANK == 
rInf.GetTxt()[nIdx + 1])
 return 0;
 if( nIdx  !const_castSwTxtFormatInfo(rInf).GetFly() )
@@ -125,9 +124,9 @@ sal_uInt16 SwBlankPortion::MayUnderflow( const 
SwTxtFormatInfo rInf,
 pPos = pPos-GetPortion();
 if( !pPos )
 {
-//Hier wird ueberprueft, ob es in dieser Zeile noch sinnvolle Umbrueche
-//gibt, Blanks oder Felder etc., wenn nicht, kein Underflow.
-//Wenn Flys im Spiel sind, lassen wir das Underflow trotzdem zu.
+// We check to see if there are useful line breaks, blanks or fields 
etc. left
+// In case there still are some, no underflow
+// If there are Flys, we still allow the underflow
 sal_Int32 nBlank = nIdx;
 while( --nBlank  rInf.GetLineStart() )
 {
@@ -149,7 +148,9 @@ sal_uInt16 SwBlankPortion::MayUnderflow( const 
SwTxtFormatInfo rInf,
 return 

[Libreoffice-bugs] [Bug 66544] Other: can't connect to laptop

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=66544

Robinson Tryon (qubit) qu...@runcibility.com changed:

   What|Removed |Added

 CC||qu...@runcibility.com
  Component|Impress Remote  |Impress Remote
Version|4.1.0.1 rc  |unspecified
Product|LibreOffice |Impress Remote

--- Comment #4 from Robinson Tryon (qubit) qu...@runcibility.com ---
Move Impress Remote bugs to new 'Impress Remote' product.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88815] macro-ify duplicate code ...

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88815

--- Comment #1 from Stephan Bergmann sberg...@redhat.com ---
there is already include/comphelper/servicedecl.hxx implementing that

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - starmath/source

2015-01-27 Thread Takeshi Abe
 starmath/source/node.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 98b73b331918e3e9213992980048e3c3c8441b93
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Tue Jan 27 12:33:02 2015 +0900

Fix a single quote slipped in

See void SmNodeToTextVisitor::Visit( SmFontNode* pNode ) for comparison.

Change-Id: Id7e58fef3b715ef2a4bcb4e1a1d390aadf917b5f
Reviewed-on: https://gerrit.libreoffice.org/14193
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
Reviewed-on: https://gerrit.libreoffice.org/14197

diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index bb2006a..97fd34a 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -2046,7 +2046,7 @@ void SmFontNode::CreateTextFromNode(OUString rText)
 rText += -;
 break;
 case FNTSIZ_MULTIPLY:
-rText += *';
+rText += *;
 break;
 case FNTSIZ_DIVIDE:
 rText += /;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: dbaccess/source

2015-01-27 Thread Lionel Elie Mamane
 dbaccess/source/core/misc/dsntypes.cxx |   23 ++-
 1 file changed, 18 insertions(+), 5 deletions(-)

New commits:
commit 42685b663388dd81fed5d6a6f2c0168a22e84f02
Author: Lionel Elie Mamane lio...@mamane.lu
Date:   Mon Jan 26 05:22:12 2015 +0100

fix damage done by OUString conversion

OUString equalsIgnoreAsciiCaseAsciiL and
String EqualsIgnoreAsciiCaseAsciiL
do *not* have the same semantics.

This seems to be the intent of the code,
and hopefully what it was doing before the OUString conversion.

Change-Id: Ib1686254876f2b3105275a7f7c53eef1e20c39b6
Reviewed-on: https://gerrit.libreoffice.org/14180
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/dbaccess/source/core/misc/dsntypes.cxx 
b/dbaccess/source/core/misc/dsntypes.cxx
index f2a99f6..13b2cfa 100644
--- a/dbaccess/source/core/misc/dsntypes.cxx
+++ b/dbaccess/source/core/misc/dsntypes.cxx
@@ -371,16 +371,28 @@ DATASOURCE_TYPE ODsnTypeCollection::determineType(const 
OUString _rDsn) const
 
 struct KnownPrefix
 {
-const sal_Char* pAsciiPrefix;
+const OUString  sPrefix;
 const DATASOURCE_TYPE   eType;
 const bool  bMatchComplete;
 
-KnownPrefix( const sal_Char* _p, const DATASOURCE_TYPE _t, const bool 
_m )
-:pAsciiPrefix( _p )
+KnownPrefix( const OUString _s, const DATASOURCE_TYPE _t, const bool 
_m )
+:sPrefix( _s )
 ,eType ( _t )
 ,bMatchComplete( _m )
 {
 }
+
+bool match( const OUString url)
+{
+if(bMatchComplete)
+{
+return url.equalsIgnoreAsciiCase(sPrefix);
+}
+else
+{
+return url.startsWithIgnoreAsciiCase(sPrefix);
+}
+}
 };
 KnownPrefix aKnowPrefixes[] =
 {
@@ -408,9 +420,10 @@ DATASOURCE_TYPE ODsnTypeCollection::determineType(const 
OUString _rDsn) const
 
 for ( size_t i=0; i  sizeof( aKnowPrefixes ) / sizeof( aKnowPrefixes[0] 
); ++i )
 {
-sal_uInt16 nMatchLen = aKnowPrefixes[i].bMatchComplete ? 
sDsn.getLength() : (sal_uInt16)rtl_str_getLength( aKnowPrefixes[i].pAsciiPrefix 
);
-if ( sDsn.equalsIgnoreAsciiCaseAsciiL( aKnowPrefixes[i].pAsciiPrefix, 
nMatchLen ) )
+if( aKnowPrefixes[i].match(sDsn) )
+{
 return aKnowPrefixes[i].eType;
+}
 }
 
 return DST_UNKNOWN;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - 5 commits - sc/source starmath/source sw/qa sw/source

2015-01-27 Thread Caolán McNamara
 sc/source/ui/cctrl/checklistmenu.cxx  |3 
 sc/source/ui/dbgui/tpsort.cxx |2 
 starmath/source/node.cxx  |2 
 sw/qa/core/data/html/pass/fdo87601-1.html |  100 ++
 sw/source/filter/html/swhtml.cxx  |2 
 sw/source/filter/xml/xmltexti.cxx |   18 +++--
 6 files changed, 116 insertions(+), 11 deletions(-)

New commits:
commit 27aee569d57815acf564b6e47e55caefbb164f8c
Author: Caolán McNamara caol...@redhat.com
Date:   Tue Jan 20 16:17:07 2015 +

Resolves: fdo#84943 make fodt non crashy like odt for formulas inside shapes

where odt checks for a null pTxtCrsr and skips the object and fodt
just ploughed ahead. i.e. make fodt equally useless as odt (fdo#84942)

(cherry picked from commit 4345a3de0e5a600685fef5dc9fa422fe6849a0a3)

Conflicts:
sw/source/filter/xml/xmltexti.cxx

Change-Id: I915cc1f7c065ea83377e895a932636c82698cf1f
Reviewed-on: https://gerrit.libreoffice.org/14058
Tested-by: Michael Stahl mst...@redhat.com
Reviewed-by: Michael Stahl mst...@redhat.com

diff --git a/sw/source/filter/xml/xmltexti.cxx 
b/sw/source/filter/xml/xmltexti.cxx
index fb968ac..8ae40ff 100644
--- a/sw/source/filter/xml/xmltexti.cxx
+++ b/sw/source/filter/xml/xmltexti.cxx
@@ -235,7 +235,7 @@ uno::Reference XPropertySet  
SwXMLTextImportHelper::createAndInsertOLEObject(
 OSL_ENSURE( xCrsrTunnel.is(), missing XUnoTunnel for Cursor );
 OTextCursorHelper *pTxtCrsr = reinterpret_cast OTextCursorHelper * (
 sal::static_int_cast sal_IntPtr ( xCrsrTunnel-getSomething( 
OTextCursorHelper::getUnoTunnelId() )));
-OSL_ENSURE( pTxtCrsr, SwXTextCursor missing );
+SAL_WARN_IF(!pTxtCrsr, sw.uno, SwXTextCursor missing);
 SwDoc *pDoc = SwImport::GetDocFromXMLImport( rImport );
 
 SfxItemSet aItemSet( pDoc-GetAttrPool(), RES_FRMATR_BEGIN,
@@ -289,12 +289,16 @@ uno::Reference XPropertySet  
SwXMLTextImportHelper::createAndInsertOLEObject(
 lcl_setObjectVisualArea( xObj, nAspect, aTwipSize, 
MAP_TWIP );
 }
 
-pFrmFmt = pDoc-Insert( *pTxtCrsr-GetPaM(),
-::svt::EmbeddedObjectRef( xObj, 
embed::Aspects::MSOLE_CONTENT ),
-aItemSet,
-NULL,
-NULL );
-pOLENd = lcl_GetOLENode( pFrmFmt );
+if( pTxtCrsr )
+{
+pFrmFmt = pDoc-Insert( *pTxtCrsr-GetPaM(),
+::svt::EmbeddedObjectRef( xObj, 
embed::Aspects::MSOLE_CONTENT ),
+aItemSet,
+NULL,
+NULL );
+pOLENd = lcl_GetOLENode( pFrmFmt );
+}
+
 if( pOLENd )
 aObjName = pOLENd-GetOLEObj().GetCurrentPersistName();
 }
commit c9054070ffc9223d05c3f4903179e3e3fd409b17
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Jan 21 15:25:03 2015 +

Resolves: fdo#87601 specific html doc hangs on load

Change-Id: I67f472d72efe123b533d4d94be0084986c0e8349
(cherry picked from commit 6acd5c45c764d81aea1539e66adbfadb51df0aa3)
Reviewed-on: https://gerrit.libreoffice.org/14081
Tested-by: Michael Stahl mst...@redhat.com
Reviewed-by: Michael Stahl mst...@redhat.com

diff --git a/sw/qa/core/data/html/pass/fdo87601-1.html 
b/sw/qa/core/data/html/pass/fdo87601-1.html
new file mode 100644
index 000..b33f11c
--- /dev/null
+++ b/sw/qa/core/data/html/pass/fdo87601-1.html
@@ -0,0 +1,100 @@
+
+   html xmlns:v=urn:schemas-microsoft-com:vml
+   xmlns:o=urn:schemas-microsoft-com:office:office
+   xmlns:w=urn:schemas-microsoft-com:office:word
+   
xmlns:m=http://schemas.microsoft.com/office/2006/01/omml;
+   xmlns=http://www.w3.org/TR/REC-html40;
+   head
+   meta http-equiv=Content-Type content=text/html; 
charset=utf-8
+   style
+   v\:* {behavior:url(#default#VML);}
+   o\:* {behavior:url(#default#VML);}
+   w\:* {behavior:url(#default#VML);}
+   .shape {behavior:url(#default#VML);}
+   /style
+   style
+   @page
+   {
+   mso-page-orientation: portrait;
+   size:21cm 29.7cm;margin:1cm 1cm 1cm 
1cm;
+   }
+   @page Section1 {
+   mso-header-margin:.5in;
+ 

[Libreoffice-commits] core.git: dbaccess/source

2015-01-27 Thread Lionel Elie Mamane
 dbaccess/source/core/misc/dsntypes.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b5dd15832a0d88e407511e408d833ebf5c764534
Author: Lionel Elie Mamane lio...@mamane.lu
Date:   Mon Jan 26 05:19:58 2015 +0100

this seems to be the intent of the code

and what it did prior to the OUString conversion

Change-Id: I97aba7e51f56e77101f591d7e9849b7243d6c90b
Reviewed-on: https://gerrit.libreoffice.org/14179
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/dbaccess/source/core/misc/dsntypes.cxx 
b/dbaccess/source/core/misc/dsntypes.cxx
index 13b2cfa..a88bd28 100644
--- a/dbaccess/source/core/misc/dsntypes.cxx
+++ b/dbaccess/source/core/misc/dsntypes.cxx
@@ -359,7 +359,7 @@ DATASOURCE_TYPE ODsnTypeCollection::determineType(const 
OUString _rDsn) const
 
 if (sDsn.startsWithIgnoreAsciiCase(sdbc:ado:))
 {
-if (sDsn.startsWithIgnoreAsciiCase(sdbc:ado:access))
+if (sDsn.startsWithIgnoreAsciiCase(sdbc:ado:access:))
 {
 if 
(sDsn.startsWithIgnoreAsciiCase(sdbc:ado:access:Provider=Microsoft.ACE.OLEDB.12.0;))
 return DST_MSACCESS_2007;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 87876] DIALOG: View tab crushed by new strings

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87876

Harald Koester harald.koes...@mail.de changed:

   What|Removed |Added

 CC||harald.koes...@mail.de

--- Comment #7 from Harald Koester harald.koes...@mail.de ---
Created attachment 112820
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112820action=edit
Options Dialogue with German Localisation

The situation is even worse in the German localisation. Have a look to the
attached screen shot.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88796] Enhancement - Mysql native connector extension - add automatic reconnect to server capability in connector code after idle timeout

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88796

--- Comment #4 from Julien Nabet serval2...@yahoo.fr ---
What's the precise message for JDBC?

For the rest, I prefer waiting by the global use of MariaDB before trying to
investigate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88825] CRASH - editing ODT form containing grid control bound to referenced, but absent datasource causes exception / abort

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88825

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

   Priority|medium  |high
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 OS|Mac OS X (All)  |All
   Severity|normal  |major

--- Comment #3 from Julien Nabet serval2...@yahoo.fr ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

Here are console logs:
warn:legacy.osl:4348:1:forms/source/component/DatabaseForm.cxx:2843: caught an
exception!
in function:bool frm::ODatabaseForm::implEnsureConnection()
type: com.sun.star.lang.WrappedTargetException
message: file:///home/hanspeter/Documents/In%20Bearbeitung/TestAdressen.odb
context: N8dbaccess16ODatabaseContextE

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83606] Data ranges in chart inside spreadsheet can't be modified/updated in the data range window

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83606

--- Comment #16 from Laurent BP jumbo4...@yahoo.fr ---
Bug confirmed with LibO Version: 4.3.5.2.0+
Build ID: 430m0(Build:2)

Bug REMOVED in LibO 4.3.6.1 :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88825] CRASH - editing ODT form containing grid control bound to referenced, but absent datasource causes exception / abort

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88825

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

   Keywords||have-backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88825] CRASH - editing ODT form containing grid control bound to referenced, but absent datasource causes exception / abort

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88825

--- Comment #4 from Julien Nabet serval2...@yahoo.fr ---
Created attachment 112840
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112840action=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I could retrieve a bt by
putting catch throw and gdb + some patience

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83801] Librelogo crashes Writer

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83801

--- Comment #5 from Björn Michaelsen bjoern.michael...@canonical.com ---
A backtrace for this issue would help esp. since its Windows only:
https://wiki.documentfoundation.org/Backtrace#Windows

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88825] CRASH - editing ODT form containing grid control bound to referenced, but absent datasource causes exception / abort

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88825

--- Comment #5 from Julien Nabet serval2...@yahoo.fr ---
I noticed in bt the call of this function
dbtools::getConnection_allowException but no method should take care of the
exception, which one should do it?
Or should we call getConnection_withFeedback? (see
http://opengrok.libreoffice.org/xref/core/connectivity/source/commontools/dbtools.cxx#311)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82524] SIDEBAR: Incorrect selection of line width while Line width itself is correct (Draw and Impress)

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82524

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|bibisected  |bibisected target:4.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82524] SIDEBAR: Incorrect selection of line width while Line width itself is correct (Draw and Impress)

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82524

--- Comment #13 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8fd9c25ac66dd238d4c68be3974241a18cb21705

tdf#82524: Mismatch of ValueSet and metric field values

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88740] Draw and Impress do not accept changes behind the decimal point in angle of rotation in the sidebar

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88740

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=82
   ||524

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88740] Draw and Impress do not accept changes behind the decimal point in angle of rotation in the sidebar

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88740

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

 CC||er...@redhat.com
  Component|Drawing |UI
   Severity|normal  |major

--- Comment #10 from Julien Nabet serval2...@yahoo.fr ---
I made further tests and I saw that if I used . instead of , (whereas I use
French UI!) to type the value, decimal typing was ok.

It's not only on Draw but also on Calc and Writer=general UI problem

Eike: I thought you might have an idea about this ./, decimal problem.

https://bugs.documentfoundation.org/buglist.cgi?bug_status=__open__content=decimallist_id=519054order=Importanceproduct=LibreOfficequery_format=specific
seems to show there's a general problem with decimal separator and UI settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87085] LibreLogo Help: Use clearer example of RECTANGLE command

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87085

Andras Timar tima...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |tima...@gmail.com
   |desktop.org |

--- Comment #5 from Andras Timar tima...@gmail.com ---
http://cgit.freedesktop.org/libreoffice/help/commit/?id=74dd3c43533373b51f53f58e4697d1df76e3ec32

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84806] EDITING: Moving selected table leaves behind an empty table

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84806

--- Comment #10 from Jay Philips philip...@hotmail.com ---
Created attachment 112839
  -- https://bugs.documentfoundation.org/attachment.cgi?id=112839action=edit
entire row selected in word 2010

@manj_k: Thanks for finding the duplicates. My searchfoo must be bad. :D

(In reply to Cor Nouws from comment #5)
 Of course when a paragraph beforeafter the table are selected too, the
 behaviour is normal.

Well it also works if its a paragraph before or after. :D

Cutting and pasting the selected table (either by selecting the cells of the
table, clicking the select table button in the table toolbar, or clicking when
the cursor changes to a southeast pointing arrow when you move the mouse
northwest of the left corner of the table) also leaves the table behind as
well. So movement it with drag and drop with the mouse (bug 40893) and moving
it with cut and paste both dont work correctly.

I noticed in MS Word and WPS/Kingsoft Writer than when you select an entire row
or table, it also selects the empty space to the right of the row(s) to
differentiate between selecting the row cells or the entire row. So when you
cut when the entire row is selected, it removes that row and when you cut when
the cells of the row are selected, it only cuts the cell contents.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Bug 64075: code pointer needed

2015-01-27 Thread Christina Roßmanith
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

opening homenet.svg (attached to the bug) shows the circles without a
filling but filled circles would be correct. The reason (I guess) is
that each circle is represented as 4 bezier curves which make it a
manually closed polygon but not a closed polygon.

So my question is: Where can I find the code responsible for filling
polygons (and where probably polygons are being tested as being closed
but not manually closed)?

Christina
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQEcBAEBAgAGBQJUx/wgAAoJEN/hiApPuw9SH0AH/RMZRqLH068qwwR7zAy2+gp4
2Pa6lv1JA9G1J9PlbEqTpXCMTD5BzumLIEOxOgDa2hgCUha2zoulMTsiOTSFHnXk
p6s/CQwn9zzuIgWrluix/5l8tjJArqK49pT0F16vweRqWleAUx4IgMhZOdBCnn4Z
N5bJk+uYC7mEirA8OY8CQ9Mb8FGLFALTPhrft4f3pt0ZW682FOiZ7pcb4oZdVS+5
hfAsFq9TeMqUGt6WQ7dIYgzEoI/WQv+GmoSVo+haPT1SsAwf/DqEMjkEDRypNa4e
XMALoUlkOBrgJZ4A3l9WOvqOC0IXs71683JHcKOBmaE/sV69GGGAS+CenoYz0Xw=
=do1t
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 83523] UI: Ruler background only changes according to application background setting *after* closing and restarting writer

2015-01-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83523

Björn Michaelsen bjoern.michael...@canonical.com changed:

   What|Removed |Added

   Priority|medium  |low
   Severity|normal  |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >