[Libreoffice-bugs] [Bug 89970] Large fonts not shown if antialiasing is off
https://bugs.documentfoundation.org/show_bug.cgi?id=89970 --- Comment #5 from istvanabadsza...@gmail.com --- Comment 3 and 4 are the same, sorry. All-in-all, fonts and letters work very fine with the these settings: http://imgur.com/B5QP5yW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90173] FILESAVE: PPTX export color property for bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=90173 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Version|4.5.0.0.alpha0+ Master |4.4.1.2 rc Ever confirmed|0 |1 --- Comment #2 from raal r...@post.cz --- I can confirm with LO 4.4.1.2 ID build: 45e2de17089c24a1fa810c8f975a7171ba4cd432 Red color is black after save. When open in powerpoint2010, the program says the file is corrupted and want to repair this file. After repair powerpoint is unable to open this file. Setting to NEW. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48047] Impress FILEOPEN: pptx with table, formatting of table is lost
https://bugs.documentfoundation.org/show_bug.cgi?id=48047 --- Comment #9 from Yogesh Bharate yogesh.bhar...@synerzip.com --- - Table contents empty row i.e row without text. - Row height increase due to the its add the text height in empty row height. - This issue is solved. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90128] rich quotes saved or loaded from RTF incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=90128 Tomislav Nakic-Alfirevic na...@gmx.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from Tomislav Nakic-Alfirevic na...@gmx.com --- (In reply to Andy from comment #1) For me not reproducible with LO 4.4.1.2 (Win 8.1) with simple quotation marks. Maybe a Linux only issue? If you do not mean quotation marks, what did you mean with rich quotes? I don't know if it's a Linux-only issue: I don't have a different OS at hand to try it out elsewhere. As for rich quotes, I mean quotation marks which do not use the same symbol as the beginning and the end of the quotation, but 2 different symbols. (In reply to Beluga from comment #2) Please attach an .odt file so we can quickly test. Set to NEEDINFO. Change back to UNCONFIRMED after you have provided the document. Attached file after removing sensitive contents. Unfortunately, the comment where I could previously observe the problem now also contains the letter ÿ at the beginning and the end of the quoted text, which was previously not present (compare with previously attached screenshot). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 30920] Closing License (WRITER-) document closes LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=30920 Pedro pedl...@gmail.com changed: What|Removed |Added Summary|Closing Credits or License |Closing License (WRITER-) |(WRITER-) document closes |document closes LibreOffice |LibreOffice | --- Comment #34 from Pedro pedl...@gmail.com --- (In reply to Adolfo Jayme from comment #33) Funnily enough, I am not able to reproduce it in LibreOffice 4.4.2.1 under Windows and Ubuntu. I tried both closing with Ctrl+W and by clicking the Close button in the window title bar, and with a document opened and without. You are indeed correct that the description of the bug is outdated. The Credits option doesn't open any document since branch 3.6 and therefore doesn't cause this problem. Since branch 3.6 this only applies to the License Information. I modified the title of the bug to reflect this change. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48047] Impress FILEOPEN: pptx with table, formatting of table is lost
https://bugs.documentfoundation.org/show_bug.cgi?id=48047 --- Comment #10 from Yogesh Bharate yogesh.bhar...@synerzip.com --- - Table contents empty row i.e row without text. - Row height increase due to the its add the text height in empty row height. - This issue is solved. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/Library_vclplug_gtk3.mk vcl/unx
vcl/Library_vclplug_gtk3.mk |1
vcl/inc/unx/gtk/gtkframe.hxx |2
vcl/inc/unx/gtk/gtkgdi.hxx|7 +
vcl/unx/gtk/window/gtksalframe.cxx| 12 ++
vcl/unx/gtk3/gdi/cairo_gtk3_cairo.cxx | 117 ++
vcl/unx/gtk3/gdi/cairo_gtk3_cairo.hxx | 51 +++
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 24 +
7 files changed, 208 insertions(+), 6 deletions(-)
New commits:
commit 707a8bc1e47b57421412de3f1f47ec31be28c5a9
Author: Caolán McNamara caol...@redhat.com
Date: Wed Mar 18 09:57:41 2015 +
enable gtk3 to support cairo canvas
Change-Id: Ie6edf155288d1514ce7a0c859ba751cdebc93391
diff --git a/vcl/Library_vclplug_gtk3.mk b/vcl/Library_vclplug_gtk3.mk
index 5ba5722..515a81c 100644
--- a/vcl/Library_vclplug_gtk3.mk
+++ b/vcl/Library_vclplug_gtk3.mk
@@ -102,6 +102,7 @@ $(eval $(call
gb_Library_add_exception_objects,vclplug_gtk3,\
vcl/unx/gtk3/app/gtk3gtkinst \
vcl/unx/gtk3/app/gtk3gtksys \
vcl/unx/gtk3/app/gtk3fpicker \
+vcl/unx/gtk3/gdi/cairo_gtk3_cairo \
vcl/unx/gtk3/gdi/gtk3cairotextrender \
vcl/unx/gtk3/gdi/gtk3gtkprintwrapper \
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk \
diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index 56225cc..d5148b7 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -343,7 +343,7 @@ public:
#if GTK_CHECK_VERSION(3,0,0)
// only for gtk3 ...
-cairo_t* getCairoContext();
+cairo_t* getCairoContext() const;
void damaged (const basegfx::B2IBox rDamageRect);
#endif
virtual ~GtkSalFrame();
diff --git a/vcl/inc/unx/gtk/gtkgdi.hxx b/vcl/inc/unx/gtk/gtkgdi.hxx
index 26f2efb..2c8a8dc 100644
--- a/vcl/inc/unx/gtk/gtkgdi.hxx
+++ b/vcl/inc/unx/gtk/gtkgdi.hxx
@@ -49,11 +49,16 @@ public:
const OUString rCaption,
Rectangle
rNativeBoundingRegion,
Rectangle
rNativeContentRegion ) SAL_OVERRIDE;
+virtual boolSupportsCairo() const SAL_OVERRIDE;
+virtual cairo::SurfaceSharedPtr CreateSurface(const
cairo::CairoSurfaceSharedPtr rSurface) const SAL_OVERRIDE;
+virtual cairo::SurfaceSharedPtr CreateSurface(const OutputDevice
rRefDevice, int x, int y, int width, int height) const SAL_OVERRIDE;
+void WidgetQueueDraw() const;
+
void updateSettings( AllSettings rSettings );
static void refreshFontconfig( GtkSettings *pSettings );
static void signalSettingsNotify( GObject*, GParamSpec *pSpec, gpointer );
-cairo_t* getCairoContext();
+cairo_t* getCairoContext() const;
void clipRegion(cairo_t* cr);
diff --git a/vcl/unx/gtk/window/gtksalframe.cxx
b/vcl/unx/gtk/window/gtksalframe.cxx
index 9d1021a..b678d81 100644
--- a/vcl/unx/gtk/window/gtksalframe.cxx
+++ b/vcl/unx/gtk/window/gtksalframe.cxx
@@ -3356,7 +3356,7 @@ gboolean GtkSalFrame::signalCrossing( GtkWidget*,
GdkEventCrossing* pEvent, gpoi
#if GTK_CHECK_VERSION(3,0,0)
-cairo_t* GtkSalFrame::getCairoContext()
+cairo_t* GtkSalFrame::getCairoContext() const
{
basebmp::RawMemorySharedArray data = m_aFrame-getBuffer();
basegfx::B2IVector size = m_aFrame-getSize();
@@ -3391,7 +3391,9 @@ void GtkSalFrame::damaged (const basegfx::B2IBox
rDamageRect)
{
static int frame;
OString tmp(/tmp/frame + OString::number(frame++) + .png);
-cairo_surface_write_to_png(cairo_get_target(getCairoContext()),
tmp.getStr());
+cairo_t* cr = getCairoContext();
+cairo_surface_write_to_png(cairo_get_target(cr), tmp.getStr());
+cairo_destroy(cr);
}
gtk_widget_queue_draw_area(m_pWindow,
@@ -3408,11 +3410,15 @@ gboolean GtkSalFrame::signalDraw( GtkWidget*, cairo_t
*cr, gpointer frame )
cairo_save(cr);
-cairo_surface_t *pSurface = cairo_get_target(pThis-getCairoContext());
+cairo_t* source = pThis-getCairoContext();
+cairo_surface_t *pSurface = cairo_get_target(source);
+
cairo_set_operator( cr, CAIRO_OPERATOR_OVER );
cairo_set_source_surface(cr, pSurface, 0, 0);
cairo_paint(cr);
+cairo_destroy(source);
+
cairo_restore(cr);
cairo_surface_flush(cairo_get_target(cr));
diff --git a/vcl/unx/gtk3/gdi/cairo_gtk3_cairo.cxx
b/vcl/unx/gtk3/gdi/cairo_gtk3_cairo.cxx
new file mode 100644
index 000..6917596
--- /dev/null
+++ b/vcl/unx/gtk3/gdi/cairo_gtk3_cairo.cxx
@@ -0,0 +1,117 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include utility
+
+#include cairo_cairo.hxx
+#include
[Libreoffice-bugs] [Bug 53861] TDF libreoffice rpm / deb packages missing glu and xinerama dependencies
https://bugs.documentfoundation.org/show_bug.cgi?id=53861 Christian Lohmaier cl...@documentfoundation.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #10 from Christian Lohmaier cl...@documentfoundation.org --- as builds for 4.4.2 rc1 are already available, setting to fixed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/generic/gdi/cairo_xlib_cairo.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9bce474064e876ced20a8e1f2f1cc189ab6ba989 Author: Tor Lillqvist t...@collabora.com Date: Mon Mar 23 14:03:48 2015 +0200 WaE: struct/class inconsistence Change-Id: If4788e606900703253780108119c397cca59604b diff --git a/vcl/unx/generic/gdi/cairo_xlib_cairo.hxx b/vcl/unx/generic/gdi/cairo_xlib_cairo.hxx index 076f34f..166ebaf 100644 --- a/vcl/unx/generic/gdi/cairo_xlib_cairo.hxx +++ b/vcl/unx/generic/gdi/cairo_xlib_cairo.hxx @@ -26,7 +26,7 @@ #include vcl/cairo.hxx -class BitmapSystemData; +struct BitmapSystemData; struct SystemEnvData; struct SystemGraphicsData; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90128] rich quotes saved or loaded from RTF incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=90128 --- Comment #3 from Tomislav Nakic-Alfirevic na...@gmx.com --- Created attachment 114273 -- https://bugs.documentfoundation.org/attachment.cgi?id=114273action=edit minimal sample demonstrating behaviour -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46884] Calc: Font rendering problem, text becomes wrapped in cell when printed
https://bugs.documentfoundation.org/show_bug.cgi?id=46884 --- Comment #27 from parchd parchd+documentfoundat...@archlinux.info --- Still present: Version: 4.4.1.2 Build ID: 4.4.1.2 Arch Linux build-2 I suggest that this bug be classed as major. In my case, it causes the content of one cell to appear in the cell above it (or sometimes overlapping an adjacant cell). The text apearing in the wrong cell without overlap can be extremely misleading. The problem is not apparent when editing, but is apparent in both print preview and exported PDFs. The spreadsheet I am working with is created from scratch in LibreOffice Calc, not exported from any other software. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/htmlexport/htmlexport.cxx |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit 772d8c5a2b46d7feca348723090e39aa235d05e0
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Mon Mar 23 19:17:02 2015 +0900
disable asserts for some HTML export image properties values
The values are DPI dependent and the test fails if the system DPI
is set to anything else than 96.
Change-Id: I548a193b3c98dc5181539eca40064a52ec15efe7
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 44cf0b9..30e9263 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -203,13 +203,15 @@ DECLARE_HTMLEXPORT_TEST(testExportImageProperties,
HTMLImage.odt)
//
// It would make sense to switch to use CSS and use real world units
instead
// i.e. (style=margin: 0cm 1.5cm; width: 1cm; height: 1cm)
-#if !defined(MACOSX) !defined(_WIN64)
+
+#if 0 // disabled as it depends that the system DPI is set to 96
assertXPath(pDoc, /html/body/p/a/font/img, hspace, 38);
assertXPath(pDoc, /html/body/p/a/font/img, vspace, 19);
assertXPath(pDoc, /html/body/p/a/font/img, width, 222);
assertXPath(pDoc, /html/body/p/a/font/img, height, 222);
assertXPath(pDoc, /html/body/p/a/font/img, border, 3);
#endif
+
assertXPath(pDoc, /html/body/p/a/font/img, usemap, #map1);
}
@@ -237,7 +239,7 @@ DECLARE_HTMLEXPORT_TEST(testExportUrlEncoding,
tdf76291.odt)
{
htmlDocPtr pDoc = parseHtml(maTempFile);
CPPUNIT_ASSERT(pDoc);
-
+
// Test URI encoded hyperlink with Chinese characters
assertXPath(pDoc, /html/body/p/a, href,
http://www.youtube.com/results?search_query=%E7%B2%B5%E8%AA%9Emvsm=12;);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90165] round corners in tables
https://bugs.documentfoundation.org/show_bug.cgi?id=90165 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||philip...@hotmail.com, ||qu...@runcibility.com Ever confirmed|0 |1 --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to jlbraga from comment #0) HI. How about to make round corners in tables possible ? Hi jlbraga, Thanks for the suggestion! Could you explain a little more about what you'd expect regarding round corners? Are you thinking about tables in Writer, or use in other components as well? Would the corner parameters be configurable? Status - NEEDINFO In the meantime, please note that there are some workarounds that might be helpful: http://en.libreofficeforum.org/node/5707 [cc: jay, as he might have some good insight here] -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90170] Incorrect export of this figure to svg
https://bugs.documentfoundation.org/show_bug.cgi?id=90170 --- Comment #2 from Christina Rossmanith chrrossman...@web.de --- Created attachment 114270 -- https://bugs.documentfoundation.org/attachment.cgi?id=114270action=edit Screenshot of sample file exported to SVG displayed in inkscape -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90059] Serial letter will not correct created
https://bugs.documentfoundation.org/show_bug.cgi?id=90059 --- Comment #7 from Beluga todven...@suomi24.fi --- Could not reproduce. I get 22.05.14 in the Datum cells of the outputted document. Your outputted document had empty Datum cells starting from 2nd page. Please try with LibreOffice 4.4.x. Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED WORKSFORME, if the problem went away. Win 7 Pro 64-bit, LibO Version: 4.4.1.2 Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - canvas/Library_cairocanvas.mk canvas/source config_host/config_cairo_canvas.h.in configure.ac include/svl include/vcl svl/source vcl/generic vcl/headless vc
canvas/Library_cairocanvas.mk| 32 -- canvas/source/cairo/cairo_cachedbitmap.hxx |2 canvas/source/cairo/cairo_cairo.cxx | 48 --- canvas/source/cairo/cairo_cairo.hxx | 89 - canvas/source/cairo/cairo_canvas.cxx |2 canvas/source/cairo/cairo_canvas.hxx |2 canvas/source/cairo/cairo_canvasbitmap.cxx | 65 canvas/source/cairo/cairo_canvasbitmap.hxx |3 canvas/source/cairo/cairo_canvascustomsprite.cxx |2 canvas/source/cairo/cairo_canvascustomsprite.hxx |5 canvas/source/cairo/cairo_canvashelper.cxx | 42 +- canvas/source/cairo/cairo_canvashelper.hxx |6 canvas/source/cairo/cairo_devicehelper.cxx | 20 - canvas/source/cairo/cairo_devicehelper.hxx |3 canvas/source/cairo/cairo_quartz_cairo.cxx | 331 - canvas/source/cairo/cairo_quartz_cairo.hxx | 70 canvas/source/cairo/cairo_repainttarget.hxx |2 canvas/source/cairo/cairo_sprite.hxx |2 canvas/source/cairo/cairo_spritecanvas.cxx |2 canvas/source/cairo/cairo_spritecanvas.hxx |2 canvas/source/cairo/cairo_spritecanvashelper.hxx |2 canvas/source/cairo/cairo_spritedevicehelper.cxx | 11 canvas/source/cairo/cairo_spritedevicehelper.hxx |4 canvas/source/cairo/cairo_surfaceprovider.hxx|5 canvas/source/cairo/cairo_textlayout.cxx |2 canvas/source/cairo/cairo_textlayout.hxx |2 canvas/source/cairo/cairo_win32_cairo.cxx| 258 canvas/source/cairo/cairo_win32_cairo.hxx| 56 --- canvas/source/cairo/cairo_xlib_cairo.cxx | 362 --- canvas/source/cairo/cairo_xlib_cairo.hxx | 104 -- config_host/config_cairo_canvas.h.in |6 configure.ac |2 include/svl/zformat.hxx |6 include/vcl/cairo.hxx| 67 include/vcl/outdev.hxx | 12 svl/source/numbers/zformat.cxx | 36 +- vcl/Library_vcl.mk |3 vcl/Library_vclplug_gen.mk |1 vcl/generic/print/genpspgraphics.cxx | 20 + vcl/headless/svpgdi.cxx | 20 + vcl/inc/cairo_cairo.hxx | 36 ++ vcl/inc/generic/genpspgraphics.h |4 vcl/inc/headless/svpgdi.hxx |4 vcl/inc/quartz/salgdi.h |4 vcl/inc/salgdi.hxx |7 vcl/inc/unx/salgdi.h |4 vcl/inc/win/salgdi.h |4 vcl/quartz/cairo_quartz_cairo.cxx| 260 vcl/quartz/cairo_quartz_cairo.hxx| 70 vcl/quartz/salgdicommon.cxx | 113 +++ vcl/source/outdev/outdev.cxx | 46 ++ vcl/source/window/cairo_cairo.cxx| 51 +++ vcl/unx/generic/gdi/cairo_xlib_cairo.cxx | 311 +++ vcl/unx/generic/gdi/cairo_xlib_cairo.hxx | 105 ++ vcl/unx/generic/gdi/salgdi.cxx | 70 vcl/win/source/gdi/cairo_win32_cairo.cxx | 187 +++ vcl/win/source/gdi/cairo_win32_cairo.hxx | 56 +++ vcl/win/source/gdi/salgdi.cxx| 134 58 files changed, 1687 insertions(+), 1488 deletions(-) New commits: commit e510a208b01c87a341b43d74d8d901f992379b84 Author: Caolán McNamara caol...@redhat.com Date: Thu Mar 19 14:43:08 2015 + move cairo helpers to vcl and make per-plug Change-Id: I4de4d5c3a191784598e93a8cf70e45a3f59ae857 Reviewed-on: https://gerrit.libreoffice.org/14907 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/canvas/Library_cairocanvas.mk b/canvas/Library_cairocanvas.mk index 72d1b8d..f786fe1 100644 --- a/canvas/Library_cairocanvas.mk +++ b/canvas/Library_cairocanvas.mk @@ -47,7 +47,6 @@ $(eval $(call gb_Library_use_libraries,cairocanvas,\ $(eval $(call gb_Library_add_exception_objects,cairocanvas,\ canvas/source/cairo/cairo_cachedbitmap \ - canvas/source/cairo/cairo_cairo \ canvas/source/cairo/cairo_canvas \ canvas/source/cairo/cairo_canvasbitmap \ canvas/source/cairo/cairo_canvascustomsprite \ @@ -68,35 +67,4 @@ $(eval $(call gb_Library_use_externals,cairocanvas,\ cairo \ )) -ifeq ($(OS),WNT) - -$(eval $(call gb_Library_add_exception_objects,cairocanvas,\ - canvas/source/cairo/cairo_win32_cairo \ -)) -$(eval $(call gb_Library_use_libraries,cairocanvas,\ - gdi32 \ -)) - -else - -ifneq (,$(filter MACOSX IOS,$(OS))) -$(eval $(call gb_Library_add_exception_objects,cairocanvas,\ -
[Libreoffice-bugs] [Bug 90059] Serial letter will not correct created
https://bugs.documentfoundation.org/show_bug.cgi?id=90059 Fritz Heinrichmeyer fritz.heinrichme...@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #8 from Fritz Heinrichmeyer fritz.heinrichme...@gmail.com --- LibreOffice_4.4.1: Change to RESOLVED WORKS FOR ME, the problem went away -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90174] New: FILESAVE: PPTX export color property for bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=90174 Bug ID: 90174 Summary: FILESAVE: PPTX export color property for bullet Product: LibreOffice Version: 4.5.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: priyanka.gaik...@synerzip.com Problem description: The color of the bullet points on a presenation slide is not exported after saved as pptx in LibreOffice. Steps to reproduce: 1. open attached pptx in Libre Office - fomat looks as expected 2. save the file as pptx 3. close LibreOffice 4. Open the saved file again Current behavior: After the document has been saved in LO the bullet color gets destroyed. Expected behavior: The color of the bullet point should export properly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90059] Serial letter will not correct created
https://bugs.documentfoundation.org/show_bug.cgi?id=90059 Beluga todven...@suomi24.fi changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #9 from Beluga todven...@suomi24.fi --- Thanks for testing! Tweaked the status to WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89970] Large fonts not shown if antialiasing is off
https://bugs.documentfoundation.org/show_bug.cgi?id=89970 --- Comment #3 from istvanabadsza...@gmail.com --- Hi, Thanks a lot for having a look at this problem. I think, I have figured it out actually. It looks to me that Libreoffice does not care too much about its own View settings if there is a fonts.conf in the ~\.config\fontconfig folder. There (fonts.conf) I have made an adjustment for anti-aliasing: !-- 1) general anti-alias: OFF -- match target=font edit mode=assign name=antialias boolflase/bool /edit /match !-- 2) size dependent anti-alias: ON -- match target=font test compare=more_eq name=pixelsize qual=any double42.7/double /test edit mode=assign name=antialias booltrue/bool /edit /match In addition, previously in my XFCE settings I have turned OFF anti-aliasing ( http://imgur.com/AcY43ob ). I have it turned ON now. At the moment all anti-aliasing turned OFF in Libreoffice's View ( http://imgur.com/yjnvwir ), but still large letters get anti-aliasing when zooming in, hence do not disappear. I am using Version: 4.4.1.2, Build ID: 40m0(Build:2) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90173] FILESAVE: PPTX export color property for bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=90173 --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- *** Bug 90174 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86793] [Regression] Hang when moving pointer when document contains Zotero references
https://bugs.documentfoundation.org/show_bug.cgi?id=86793 Milan Bouchet-Valat nalimi...@club.fr changed: What|Removed |Added OS|Linux (All) |All --- Comment #8 from Milan Bouchet-Valat nalimi...@club.fr --- Interesting. Could you post a file reproducing the issue with only links to external images? Not requiring Zotero could help debugging. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - 2 commits - libreofficekit/source vcl/source
libreofficekit/source/gtk/lokdocview.cxx | 71 +++
vcl/source/window/paint.cxx |2
2 files changed, 37 insertions(+), 36 deletions(-)
New commits:
commit 3e4d05621b04b7f30393e155e69c78b3fc4b79aa
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Mar 23 12:09:03 2015 +0100
lokdocview: add LOKDocView_Impl ctor
It simplifies lok_docview_init() a lot and makes harder to add a
LOKDocView_Impl member without initializing it.
Change-Id: I02d91b97fecd86896c11facca98fabd6a79157e5
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index db61812..66568ca 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -92,6 +92,42 @@ struct LOKDocView_Impl
/// If we are in the middle of a drag of a graphic selection handle.
bool m_bInDragGraphicHandles[8];
///@}
+
+LOKDocView_Impl()
+: m_pEventBox(gtk_event_box_new()),
+m_pTable(0),
+m_pCanvas(0),
+m_fZoom(1),
+m_pOffice(0),
+m_pDocument(0),
+m_bEdit(false),
+m_aVisibleCursor({0, 0, 0, 0}),
+m_bCursorOverlayVisible(false),
+m_bCursorVisible(true),
+m_nLastButtonPressTime(0),
+m_nLastButtonReleaseTime(0),
+m_pTextSelectionRectangles(0),
+m_aTextSelectionStart({0, 0, 0, 0}),
+m_aTextSelectionEnd({0, 0, 0, 0}),
+m_aGraphicSelection({0, 0, 0, 0}),
+m_bInDragGraphicSelection(false),
+
+// Start/middle/end handle.
+m_pHandleStart(0),
+m_aHandleStartRect({0, 0, 0, 0}),
+m_bInDragStartHandle(false),
+m_pHandleMiddle(0),
+m_aHandleMiddleRect({0, 0, 0, 0}),
+m_bInDragMiddleHandle(false),
+m_pHandleEnd(0),
+m_aHandleEndRect({0, 0, 0, 0}),
+m_bInDragEndHandle(false),
+
+m_pGraphicHandle(0)
+{
+memset(m_aGraphicHandleRects, 0, sizeof(m_aGraphicHandleRects));
+memset(m_bInDragGraphicHandles, 0, sizeof(m_bInDragGraphicHandles));
+}
};
static void lok_docview_class_init( gpointer );
@@ -412,7 +448,6 @@ static void lok_docview_init( GTypeInstance* pInstance,
gpointer )
gtk_scrolled_window_set_vadjustment( GTK_SCROLLED_WINDOW( pDocView ), NULL
);
pDocView-m_pImpl = new LOKDocView_Impl();
-pDocView-m_pImpl-m_pEventBox = gtk_event_box_new();
gtk_scrolled_window_add_with_viewport( GTK_SCROLLED_WINDOW(pDocView),
pDocView-m_pImpl-m_pEventBox );
@@ -423,40 +458,6 @@ static void lok_docview_init( GTypeInstance* pInstance,
gpointer )
gtk_widget_show( pDocView-m_pImpl-m_pEventBox );
-pDocView-m_pImpl-m_pTable = 0;
-pDocView-m_pImpl-m_pCanvas = 0;
-
-pDocView-m_pImpl-m_pOffice = 0;
-pDocView-m_pImpl-m_pDocument = 0;
-
-pDocView-m_pImpl-m_fZoom = 1;
-pDocView-m_pImpl-m_bEdit = false;
-memset(pDocView-m_pImpl-m_aVisibleCursor, 0,
sizeof(pDocView-m_pImpl-m_aVisibleCursor));
-pDocView-m_pImpl-m_bCursorOverlayVisible = false;
-pDocView-m_pImpl-m_bCursorVisible = true;
-pDocView-m_pImpl-m_nLastButtonPressTime = 0;
-pDocView-m_pImpl-m_nLastButtonReleaseTime = 0;
-pDocView-m_pImpl-m_pTextSelectionRectangles = 0;
-memset(pDocView-m_pImpl-m_aTextSelectionStart, 0,
sizeof(pDocView-m_pImpl-m_aTextSelectionStart));
-memset(pDocView-m_pImpl-m_aTextSelectionEnd, 0,
sizeof(pDocView-m_pImpl-m_aTextSelectionEnd));
-memset(pDocView-m_pImpl-m_aGraphicSelection, 0,
sizeof(pDocView-m_pImpl-m_aGraphicSelection));
-pDocView-m_pImpl-m_bInDragGraphicSelection = false;
-
-// Start/middle/end handle.
-pDocView-m_pImpl-m_pHandleStart = 0;
-memset(pDocView-m_pImpl-m_aHandleStartRect, 0,
sizeof(pDocView-m_pImpl-m_aHandleStartRect));
-pDocView-m_pImpl-m_bInDragStartHandle = false;
-pDocView-m_pImpl-m_pHandleMiddle = 0;
-memset(pDocView-m_pImpl-m_aHandleMiddleRect, 0,
sizeof(pDocView-m_pImpl-m_aHandleMiddleRect));
-pDocView-m_pImpl-m_bInDragMiddleHandle = false;
-pDocView-m_pImpl-m_pHandleEnd = 0;
-memset(pDocView-m_pImpl-m_aHandleEndRect, 0,
sizeof(pDocView-m_pImpl-m_aHandleEndRect));
-pDocView-m_pImpl-m_bInDragEndHandle = false;
-
-pDocView-m_pImpl-m_pGraphicHandle = 0;
-memset(pDocView-m_pImpl-m_aGraphicHandleRects, 0,
sizeof(pDocView-m_pImpl-m_aGraphicHandleRects));
-memset(pDocView-m_pImpl-m_bInDragGraphicHandles, 0,
sizeof(pDocView-m_pImpl-m_bInDragGraphicHandles));
-
gtk_signal_connect( GTK_OBJECT(pDocView), destroy,
GTK_SIGNAL_FUNC(lcl_onDestroy), NULL );
g_signal_connect_after(pDocView-m_pImpl-m_pEventBox, expose-event,
commit 81714838ee629fd61addc8e5df61b8abc9b5bf59
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Mar 23 11:44:50 2015 +0100
vcl tiled rendering: fix invalidation callback in Impress
Even if map mode is disabled,
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/unittest-failed.sh | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) New commits: commit 09f399d13d65b9aafa3108cb006b55b92d4bbbca Author: Jan Holesovsky ke...@collabora.com Date: Mon Mar 23 12:39:39 2015 +0100 unittest-failed.sh: Actually just one variable is enough here. diff --git a/solenv/bin/unittest-failed.sh b/solenv/bin/unittest-failed.sh index 784a7f9..0d11b2a 100755 --- a/solenv/bin/unittest-failed.sh +++ b/solenv/bin/unittest-failed.sh @@ -17,31 +17,31 @@ # except in compliance with the License. You may obtain a copy of # the License at http://www.apache.org/licenses/LICENSE-2.0 . -ECHECKING= DEBUGGING= -MCHECKING= if [ $3 = WNT ]; then -DEBUGGING='export CPPUNITTRACE=\[full path to devenv.exe]\ /debugexe # for interactive debugging in Visual Studio' -MCHECKING='export CPPUNITTRACE=drmemory -free_max_frames 20# for memory checking (install Dr.Memory first, and put it to your PATH)' +DEBUGGING=' +export CPPUNITTRACE=\[full path to devenv.exe]\ /debugexe # for interactive debugging in Visual Studio +export CPPUNITTRACE=drmemory -free_max_frames 20# for memory checking (install Dr.Memory first, and put it to your PATH) +' elif [ $3 = MACOSX ]; then -DEBUGGING='export CPPUNITTRACE=lldb -- # for interactive debugging on OS X' -MCHECKING='export VALGRIND=memcheck# for memory checking' +DEBUGGING=' +export CPPUNITTRACE=lldb -- # for interactive debugging on OS X +export VALGRIND=memcheck# for memory checking +' else -ECHECKING='export DEBUGCPPUNIT=TRUE# for exception catching' -DEBUGGING='export CPPUNITTRACE=gdb --args# for interactive debugging on Linux' -MCHECKING='export VALGRIND=memcheck# for memory checking' +DEBUGGING=' +export DEBUGCPPUNIT=TRUE# for exception catching +export CPPUNITTRACE=gdb --args# for interactive debugging on Linux +export VALGRIND=memcheck# for memory checking +' fi # print the actual error message cat EOF Error: a unit test failed, please do one of: - -$ECHECKING $DEBUGGING -$MCHECKING - and retry using: make $1Test_$2 EOF ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/vclref' - 3 commits - canvas/source framework/source include/sfx2 include/vcl sd/source sfx2/source sw/source
canvas/source/vcl/bitmapbackbuffer.cxx|3 +--
framework/source/uielement/fontsizemenucontroller.cxx |2 +-
include/sfx2/printer.hxx |1 +
include/sfx2/viewsh.hxx |2 +-
include/vcl/outdev.hxx|2 ++
include/vcl/vclptr.hxx|1 +
sd/source/ui/presenter/PresenterTextView.cxx |7 +++
sfx2/source/view/printer.cxx |6 ++
sfx2/source/view/viewprn.cxx |4 ++--
sw/source/ui/dialog/ascfldlg.cxx |4 ++--
10 files changed, 20 insertions(+), 12 deletions(-)
New commits:
commit a304135e156d0b616766570790106879d783262e
Author: Noel Grandin n...@peralex.com
Date: Mon Mar 23 13:47:50 2015 +0200
vclwidget: some small fixes
Change-Id: I094163c894ff9accf70050d5a4fab83e905a282b
diff --git a/framework/source/uielement/fontsizemenucontroller.cxx
b/framework/source/uielement/fontsizemenucontroller.cxx
index 3e09765..1c0af14 100644
--- a/framework/source/uielement/fontsizemenucontroller.cxx
+++ b/framework/source/uielement/fontsizemenucontroller.cxx
@@ -135,7 +135,7 @@ void FontSizeMenuController::fillPopupMenu( Reference
css::awt::XPopupMenu r
if ( pVCLPopupMenu )
{
boost::scoped_ptrFontList pFontList;
-boost::scoped_ptrPrinter pInfoPrinter;
+ScopedVclPtrPrinter pInfoPrinter;
OUString aPrinterName;
SolarMutexGuard aSolarMutexGuard;
diff --git a/include/sfx2/printer.hxx b/include/sfx2/printer.hxx
index f07a135..694e2e8 100644
--- a/include/sfx2/printer.hxx
+++ b/include/sfx2/printer.hxx
@@ -51,6 +51,7 @@ public:
const JobSetup rTheOrigJobSetup );
SfxPrinter( const SfxPrinter rPrinter );
virtual ~SfxPrinter();
+virtual voiddispose() SAL_OVERRIDE;
SfxPrinter* Clone() const;
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index a9347ad..29fba0d 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -285,7 +285,7 @@ public:
SAL_DLLPRIVATE void ResetAllClients_Impl( SfxInPlaceClient *pIP );
SAL_DLLPRIVATE void DiscardClients_Impl();
-SAL_DLLPRIVATE SfxPrinter* SetPrinter_Impl( SfxPrinter *pNewPrinter );
+SAL_DLLPRIVATE SfxPrinter* SetPrinter_Impl( VclPtrSfxPrinter
pNewPrinter );
SAL_DLLPRIVATE bool IsShowView_Impl() const;
SAL_DLLPRIVATE bool HandleNotifyEvent_Impl( NotifyEvent rEvent );
diff --git a/sd/source/ui/presenter/PresenterTextView.cxx
b/sd/source/ui/presenter/PresenterTextView.cxx
index 4f2e6ca..7a9f18e 100644
--- a/sd/source/ui/presenter/PresenterTextView.cxx
+++ b/sd/source/ui/presenter/PresenterTextView.cxx
@@ -101,7 +101,7 @@ public:
private:
Referencerendering::XBitmap mxBitmap;
cppcanvas::CanvasSharedPtr mpCanvas;
-VirtualDevice* mpOutputDevice;
+VclPtrVirtualDevice mpOutputDevice;
EditEngine* mpEditEngine;
SfxItemPool* mpEditEngineItemPool;
Size maSize;
@@ -280,7 +280,7 @@ PresenterTextView::Implementation::~Implementation (void)
{
delete mpEditEngine;
SfxItemPool::Free(mpEditEngineItemPool);
-delete mpOutputDevice;
+mpOutputDevice.disposeAndClear();
}
EditEngine * PresenterTextView::Implementation::GetEditEngine (void)
@@ -473,8 +473,7 @@ Referencerendering::XBitmap
PresenterTextView::Implementation::GetBitmap (void
if ( ! mxBitmap.is())
{
-if (mpOutputDevice != NULL)
-delete mpOutputDevice;
+mpOutputDevice.disposeAndClear();
mpOutputDevice = new VirtualDevice(*Application::GetDefaultDevice(),
0, 0);
mpOutputDevice-SetMapMode(MAP_PIXEL);
mpOutputDevice-SetOutputSizePixel(maSize, true);
diff --git a/sfx2/source/view/printer.cxx b/sfx2/source/view/printer.cxx
index ee08f4d..add92b0 100644
--- a/sfx2/source/view/printer.cxx
+++ b/sfx2/source/view/printer.cxx
@@ -189,8 +189,14 @@ SfxPrinter* SfxPrinter::Clone() const
SfxPrinter::~SfxPrinter()
{
+disposeOnce();
+}
+
+void SfxPrinter::dispose()
+{
delete pOptions;
delete pImpl;
+Printer::dispose();
}
diff --git a/sfx2/source/view/viewprn.cxx b/sfx2/source/view/viewprn.cxx
index 7e13153..44f2731 100644
--- a/sfx2/source/view/viewprn.cxx
+++ b/sfx2/source/view/viewprn.cxx
@@ -471,7 +471,7 @@ IMPL_LINK_NOARG(SfxDialogExecutor_Impl, Execute)
Internal method for setting the differences between 'pNewPrinter' to the
current printer. pNewPrinter is either taken over or deleted.
*/
-SfxPrinter* SfxViewShell::SetPrinter_Impl( SfxPrinter *pNewPrinter )
+SfxPrinter* SfxViewShell::SetPrinter_Impl( VclPtrSfxPrinter pNewPrinter )
{
// get current Printer
SfxPrinter *pDocPrinter = GetPrinter();
@@ -560,7 +560,7 @@ SfxPrinter* SfxViewShell::SetPrinter_Impl( SfxPrinter
*pNewPrinter )
[Libreoffice-bugs] [Bug 90096] Lines in a multilateral flowchart in Draw change on the pages that are not in the focus
https://bugs.documentfoundation.org/show_bug.cgi?id=90096 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEEDINFO|NEW Version|unspecified |4.4.1.2 rc --- Comment #5 from Beluga todven...@suomi24.fi --- (In reply to Jens Scheidtweiler from comment #3) Created attachment 114265 [details] After editing another page it sometimes looks like this The image is from page 4. I can confirm that when I straightened out the line between: UMS D1 - UMS D2 saved reloaded, the line had turned back into that cornered version. Win 7 Pro 64-bit, LibO Version: 4.4.1.2 Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90168] Importing SVG to Draw ignores clipping path
https://bugs.documentfoundation.org/show_bug.cgi?id=90168 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #2 from Beluga todven...@suomi24.fi --- Confirmed. Win 7 Pro 64-bit, LibO Version: 4.4.1.2 Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90096] Lines in a multilateral flowchart in Draw change on the pages that are not in the focus
https://bugs.documentfoundation.org/show_bug.cgi?id=90096 --- Comment #6 from Jens Scheidtweiler jens.scheidtwei...@caseris.de --- I have seen the behavior on my two computers. 1.) Win 8.1 Prof (64Bit) LibreOffice 4.4.1.2 2.) Win 7 Prof (64Bit) LibreOffice 4.4.1.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90174] FILESAVE: PPTX export color property for bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=90174 Priyanka Gaikwad priyanka.gaik...@synerzip.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |priyanka.gaikwad@synerzip.c |desktop.org |om --- Comment #1 from Priyanka Gaikwad priyanka.gaik...@synerzip.com --- Created attachment 114272 -- https://bugs.documentfoundation.org/attachment.cgi?id=114272action=edit pptx with bullet color red -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48047] Impress FILEOPEN: pptx with table, formatting of table is lost
https://bugs.documentfoundation.org/show_bug.cgi?id=48047 Yogesh Bharate yogesh.bhar...@synerzip.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Yogesh Bharate yogesh.bhar...@synerzip.com --- *** This bug has been marked as a duplicate of bug 80340 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/edit/edtab.cxx |2 +-
sw/source/core/fields/cellfml.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit d2a8991423506c64c027dc0dda49b08e56ca6acc
Author: Tor Lillqvist t...@collabora.com
Date: Mon Mar 23 12:52:31 2015 +0200
WaE: comparison between signed and unsigned integer expressions
Change-Id: Ia5c5b1926a73c54a38662b5ac737dbe1ff3cef50
diff --git a/sw/source/core/edit/edtab.cxx b/sw/source/core/edit/edtab.cxx
index c334ee4..8d5bbc7 100644
--- a/sw/source/core/edit/edtab.cxx
+++ b/sw/source/core/edit/edtab.cxx
@@ -393,7 +393,7 @@ bool SwEditShell::IsTableBoxTextFormat() const
{
nFmt = static_castconst SwTblBoxNumFormat*(pItem)-GetValue();
return GetDoc()-GetNumberFormatter()-IsTextFormat( nFmt ) ||
-css::util::NumberFormat::TEXT == nFmt;
+static_castsal_uInt32(css::util::NumberFormat::TEXT) == nFmt;
}
sal_uLong nNd = pBox-IsValidNumTxtNd();
diff --git a/sw/source/core/fields/cellfml.cxx
b/sw/source/core/fields/cellfml.cxx
index 7b18c53..2b0b686 100644
--- a/sw/source/core/fields/cellfml.cxx
+++ b/sw/source/core/fields/cellfml.cxx
@@ -217,7 +217,7 @@ double SwTableBox::GetValue( SwTblCalcPara rCalcPara )
const
SvNumberFormatter* pNumFmtr = pDoc-GetNumberFormatter();
-if( css::util::NumberFormat::TEXT == nFmtIndex )
+if( static_castsal_uInt32(css::util::NumberFormat::TEXT) ==
nFmtIndex )
nFmtIndex = 0;
// JP 22.04.98: Bug 49659 - special treatment for percentages
else if( !sTxt.isEmpty()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - editeng/source
editeng/source/editeng/impedit.cxx |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
New commits:
commit 58afab1123d16af5270a97cafb05d13fd9538a68
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Mar 23 12:17:29 2015 +0100
editeng tiled rendering: fix selection overlay in Impress
The map mode is twips in Writer, that's why it worked there. For
Impress, we need a conversion to always have twips output.
Change-Id: I53c64b961180b6ff9b4ee75e3c5aa775416e7ae7
diff --git a/editeng/source/editeng/impedit.cxx
b/editeng/source/editeng/impedit.cxx
index 7593b80..8c86f0a 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -324,6 +324,7 @@ void ImpEditView::DrawSelection( EditSelection aTmpSel,
vcl::Region* pRegion, Ou
if (isTiledRendering())
{
+bool bMm100ToTwip = pOutWin-GetMapMode().GetMapUnit() ==
MAP_100TH_MM;
OString sRectangle;
// If we are not in selection mode, then the exported selection
should be empty.
if (pEditEngine-pImpEditEngine-IsInSelectionMode())
@@ -335,19 +336,25 @@ void ImpEditView::DrawSelection( EditSelection aTmpSel,
vcl::Region* pRegion, Ou
{
Rectangle rStart = aRectangles.front();
Rectangle aStart = Rectangle(rStart.Left(), rStart.Top(),
rStart.Left() + 1, rStart.Bottom());
+if (bMm100ToTwip)
+aStart = OutputDevice::LogicToLogic(aStart,
MAP_100TH_MM, MAP_TWIP);
libreOfficeKitCallback(LOK_CALLBACK_TEXT_SELECTION_START,
aStart.toString().getStr());
Rectangle rEnd = aRectangles.back();
Rectangle aEnd = Rectangle(rEnd.Right() - 1, rEnd.Top(),
rEnd.Right(), rEnd.Bottom());
+if (bMm100ToTwip)
+aEnd = OutputDevice::LogicToLogic(aEnd, MAP_100TH_MM,
MAP_TWIP);
libreOfficeKitCallback(LOK_CALLBACK_TEXT_SELECTION_END,
aEnd.toString().getStr());
}
std::stringstream ss;
for (size_t i = 0; i aRectangles.size(); ++i)
{
-const Rectangle rRectangle = aRectangles[i];
+Rectangle rRectangle = aRectangles[i];
if (i)
ss ; ;
+if (bMm100ToTwip)
+rRectangle = OutputDevice::LogicToLogic(rRectangle,
MAP_100TH_MM, MAP_TWIP);
ss rRectangle.toString().getStr();
}
sRectangle = ss.str().c_str();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 32248] FILEOPEN SVG no TEXT visible
https://bugs.documentfoundation.org/show_bug.cgi?id=32248 Jacques Guilleron guillero...@aol.com changed: What|Removed |Added CC||parrenin@gmail.com --- Comment #50 from Jacques Guilleron guillero...@aol.com --- *** Bug 90170 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: GSoC 2015
Hi Thorsten, I already sent my solution to gerrit [1] and put a -1 to it as you said. I've been working on my master's thesis for a few days. So in this week I can continue to work on this bug. Thanks. [1] https://gerrit.libreoffice.org/#/c/14912/ On Sun, Mar 22, 2015 at 5:38 PM, Thorsten Behrens t...@documentfoundation.org wrote: Enes Ateş wrote: I am currently working on EasyHack #64575 to better understand LibreOffice code. I finished calculation of image size and I tried with many images which have different sizes. I got good results for all of them but I could not finish implementation yet. I have some problems with crop function. I will continue to work on it. Hi Enes, great to hear you intend to apply! Even if you're not 100% satisfied with your fix, feel free to upload to gerrit (and, depending how unhappy you are with the solution, put a -1 to it yourself). If you have specific questions, feel free to ask here, or on irc. Cheers, -- Thorsten -- Enes Ateş ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 90170] Incorrect export of this figure to svg
https://bugs.documentfoundation.org/show_bug.cgi?id=90170 Jacques Guilleron guillero...@aol.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jacques Guilleron guillero...@aol.com --- Hi Frederic, Known issue since Bug 32248 - FILEOPEN SVG no TEXT visible, not solved however. I set Status to DUPLICATE. Regards, Jacques *** This bug has been marked as a duplicate of bug 32248 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: GSOC 2015
On 22.03.2015 20:24, Huzaifa Iftikhar wrote: Hi, I am Huzaifa Iftikhar and currently I am pursuing B.Tech. from Maharaja Agrasen Institute of Technology (GGSIPU, New Delhi). I would like to contribute to Libre in this Google Summer of Code 2015. I am confident enough that I will surely make a positive contribution to the community. I am interested in C and C++ Programming languages. I have shared my project on Github which was made by me as a part of my school project. I am currently working on EasyHack #75280 and am trying to understand and learn LibreOffice code and get used to it. I will ask questions if in doubt and will commit changes as soon I feel that I have fixed the bug. I checked project ideas for GSoC 2015 and would like to work on the idea More and better tests. I find this idea interesting and would love to learn more about it by /Michael Stahl./ I will to my best this summer and will contribute to LibreOffice with my full efforts and dedication. I may also work on the other ideas but I might require additional information by the mentors. I don't have any other major commitments anywhere else during the summer. hi Huzaifa, great to hear you are interested in writing tests! since you already started on an easy-hack i assume you have already done a build successfully. when you are done, submit a patch to gerrit; that should make you familiar with the tools and workflows used (git, gerrit, make, ...). start reading here: http://www.libreoffice.org/developers/ https://wiki.documentfoundation.org/Development https://wiki.documentfoundation.org/Git_For_LibreOffice_Developers https://wiki.documentfoundation.org/Easy_Hacks some notes for GSoC applicants are here: https://wiki.documentfoundation.org/Development/GSoC/2015 note that there are usually more GSoC applicants than available mentors, and the most important thing to get accepted is to show that you can get useful work done - we have certain bugs marked as EasyHack that should be easy for somebody not familiar with the code base to solve; once you have a trivial patch accepted we can give you a small task related to the GSoC topic, to see how you fare on that. please don't hesitate to get onto the IRC channel and ask questions (but do read available documentation before asking questions). regards, michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 42789] Writer FILESAVE: when saving to doc format, option AutoSize of frame is lost
https://bugs.documentfoundation.org/show_bug.cgi?id=42789 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #5 from Beluga todven...@suomi24.fi --- Reproduced. Win 7 Pro 64-bit, LibO Version: 4.4.1.2 Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90170] Incorrect export of this figure to svg
https://bugs.documentfoundation.org/show_bug.cgi?id=90170 --- Comment #3 from Christina Rossmanith chrrossman...@web.de --- Frederic reports that the text isn't visible in inkscape which means that the text isn't even exported. That is different from being imported incorrectly in LibO. However, exporting to SVG and viewing in inkscape works fine for me with Version: 4.5.0.0.alpha0+ Build ID: 48bb2913a7459edb17a5f62c2f6e6fbc4f1051e2 Locale: C_ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90081] FORMATTING: Document index style has changed and can't be set to the previous one
https://bugs.documentfoundation.org/show_bug.cgi?id=90081 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Beluga todven...@suomi24.fi --- Confirmed, got same-looking results as in your After.png screenie. Win 7 Pro 64-bit, LibO Version: 4.4.1.2 Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63848] default formatting / user editing / pain
https://bugs.documentfoundation.org/show_bug.cgi?id=63848 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #4 from Beluga todven...@suomi24.fi --- Reproduced. Win 7 Pro 64-bit, LibO Version: 4.4.1.2 Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53861] TDF libreoffice rpm / deb packages missing glu and xinerama dependencies
https://bugs.documentfoundation.org/show_bug.cgi?id=53861 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||fdb...@neosheffield.co.uk Ever confirmed|0 |1 --- Comment #9 from Matthew Francis fdb...@neosheffield.co.uk --- At the point that patches have been committed, I think this can be at least - NEW already -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53074] Index entry duplicated by copy and paste within source text of entry
https://bugs.documentfoundation.org/show_bug.cgi?id=53074 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Summary|index entry corrupted by|Index entry duplicated by |copy and paste within entry |copy and paste within ||source text of entry Ever confirmed|0 |1 --- Comment #10 from Matthew Francis fdb...@neosheffield.co.uk --- Reproduced as follows on current 4.5 master: - Open attachment 114267 - Cut (Ctrl+X) the word TEST on the first line - Paste (Ctrl+V) it one word to the right (after index) - Right click on the index below, and Update Index/Table Expected result: - The original index entry is updated Actual result: - A second entry is additionally created for TEST Setting - NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90059] Serial letter will not correct created
https://bugs.documentfoundation.org/show_bug.cgi?id=90059 --- Comment #6 from Fritz Heinrichmeyer fritz.heinrichme...@gmail.com --- Created attachment 114269 -- https://bugs.documentfoundation.org/attachment.cgi?id=114269action=edit Data Source excel-tabelle -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90172] New: Capitalize first letter of every sentence doesn't work at all.
https://bugs.documentfoundation.org/show_bug.cgi?id=90172 Bug ID: 90172 Summary: Capitalize first letter of every sentence doesn't work at all. Product: LibreOffice Version: 4.4.1.2 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lister...@gmail.com ubuntu trusty 14.04 english Capitalize first letter of every sentence doesn't work at all. The box in settings is checked. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - 2 commits - android/README connectivity/source
android/README | 23 +
connectivity/source/commontools/parameters.cxx |5
connectivity/source/commontools/propertyids.cxx | 193
++
connectivity/source/drivers/mork/MCatalog.cxx |3
connectivity/source/drivers/mork/MConnection.hxx|2
connectivity/source/drivers/mork/MQueryHelper.cxx |5
connectivity/source/drivers/mork/MQueryHelper.hxx |1
connectivity/source/drivers/mork/MResultSet.cxx | 72 ++-
connectivity/source/drivers/mork/MResultSet.hxx |2
connectivity/source/drivers/mork/MResultSetMetaData.cxx |2
connectivity/source/drivers/mork/MStatement.cxx | 49 ++
connectivity/source/drivers/mork/MStatement.hxx |3
connectivity/source/drivers/mork/MTable.hxx |2
connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx | 21 +
connectivity/source/drivers/odbc/OResultSet.cxx |5
connectivity/source/drivers/postgresql/pq_databasemetadata.cxx | 20 +
connectivity/source/drivers/postgresql/pq_databasemetadata.hxx |1
connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx | 10
connectivity/source/drivers/postgresql/pq_resultsetmetadata.hxx |2
connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx | 11
connectivity/source/inc/odbc/OResultSet.hxx |3
21 files changed, 347 insertions(+), 88 deletions(-)
New commits:
commit 2df9e97f37e4d134e21a9603ad505ea0090b1c8b
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Mar 23 11:41:20 2015 +0100
android: add doc on how to set up jdb
Change-Id: I15427518bc82e3da147b74c01bb2e0480fc32f25
diff --git a/android/README b/android/README
index 4094ef2..5e8db7c 100644
--- a/android/README
+++ b/android/README
@@ -69,6 +69,29 @@ ERROR: Could not extract package's data directory. Are you
sure that
(gdb) python sys.path.insert(0, /master/solenv/gdb)
(gdb) source /master/instdir/program/libuno_sal.so.3-gdb.py
+* Debuggint the Java part
+
+At the moment the code is not organized in a way that would make Eclipse or
+Android Studio happy as-is, so the quickest way is to use the jdb command-line
+debugger. Steps to use it:
+
+1) Find out the JDWP ID of a debuggable application:
+
+ adb jdwp
+
+From the list of currently active JDWP processes, the last number is the just
+started debuggable application.
+
+2) Forward the remote JDWP port/process ID to a local port:
+
+ adb forward tcp: jdwp:31739
+
+3) Connect to the running application:
+
+ jdb -sourcepath src/java/ -attach localhost:
+
+Assuming that you're already in the LOAndroid3 directory in your shell.
+
* Common Errors / Gotchas
lo_dlneeds: Could not read ELF header of /data/data/org.libreoffice...libfoo.so
commit 483ee909c33e7c1b419384c272e60f6f2e87ce8e
Author: Noel Grandin n...@peralex.com
Date: Mon Mar 23 10:50:14 2015 +0200
Revert loplugin:constantfunction: connectivity
it seems to be causing unit-test and build failures
This reverts commit 5cbb51c009fa266e8418ef93799ac64e431c22f5.
Change-Id: Idc6372f98200b23828aa19b22a75b6b2b640d1ab
(cherry picked from commit 3e8a7ce7dffcf46a692e5da0b281a104df8d4d95)
diff --git a/connectivity/source/commontools/parameters.cxx
b/connectivity/source/commontools/parameters.cxx
index 1b512a0..d520e37 100644
--- a/connectivity/source/commontools/parameters.cxx
+++ b/connectivity/source/commontools/parameters.cxx
@@ -115,6 +115,11 @@ namespace dbtools
}
+void ParameterManager::disposing( const EventObject /*_rDisposingEvent*/ )
+{
+}
+
+
void ParameterManager::setAllParametersNull()
{
OSL_PRECOND( isAlive(), ParameterManager::setAllParametersNull: not
initialized, or already disposed! );
diff --git a/connectivity/source/commontools/propertyids.cxx
b/connectivity/source/commontools/propertyids.cxx
index 9f0635e..5b3d635 100644
--- a/connectivity/source/commontools/propertyids.cxx
+++ b/connectivity/source/commontools/propertyids.cxx
@@ -22,6 +22,77 @@
namespace dbtools
{
+const sal_Char* getPROPERTY_QUERYTIMEOUT() { return
QueryTimeOut; }
+const sal_Char* getPROPERTY_MAXFIELDSIZE() { return
MaxFieldSize; }
+const sal_Char* getPROPERTY_MAXROWS() { return
MaxRows; }
+const sal_Char* getPROPERTY_CURSORNAME(){ return
CursorName; }
+const sal_Char* getPROPERTY_RESULTSETCONCURRENCY() { return
ResultSetConcurrency; }
+const sal_Char* getPROPERTY_RESULTSETTYPE() { return
ResultSetType; }
+const sal_Char* getPROPERTY_FETCHDIRECTION(){ return
FetchDirection; }
+const sal_Char* getPROPERTY_FETCHSIZE() { return
[Libreoffice-bugs] [Bug 90173] New: FILESAVE: PPTX export color property for bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=90173 Bug ID: 90173 Summary: FILESAVE: PPTX export color property for bullet Product: LibreOffice Version: 4.5.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: priyanka.gaik...@synerzip.com Created attachment 114271 -- https://bugs.documentfoundation.org/attachment.cgi?id=114271action=edit pptx with bullet color red Problem description: The color of the bullet points on a presenation slide is not exported after saved as pptx in LibreOffice. Steps to reproduce: 1. open attached pptx in Libre Office - fomat looks as expected 2. save the file as pptx 3. close LibreOffice 4. Open the file again Current behavior: After the document has ben saved in LO the bullet color gets destroyed. Expected behavior: The color of the bullet point should export properly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89970] Large fonts not shown if antialiasing is off
https://bugs.documentfoundation.org/show_bug.cgi?id=89970 --- Comment #4 from istvanabadsza...@gmail.com --- Hi, Thanks a lot for having a look at this problem. I think, I have figured it out actually. It looks to me that Libreoffice does not care too much about its own View settings if there is a fonts.conf in the ~\.config\fontconfig folder. There (fonts.conf) I have made an adjustment for anti-aliasing: !-- 1) general anti-alias: OFF -- match target=font edit mode=assign name=antialias boolflase/bool /edit /match !-- 2) size dependent anti-alias: ON -- match target=font test compare=more_eq name=pixelsize qual=any double42.7/double /test edit mode=assign name=antialias booltrue/bool /edit /match In addition, previously in my XFCE settings I have turned OFF anti-aliasing ( http://imgur.com/AcY43ob ). I have it turned ON now. At the moment all anti-aliasing turned OFF in Libreoffice's View ( http://imgur.com/yjnvwir ), but still large letters get anti-aliasing when zooming in, hence do not disappear. I am using Version: 4.4.1.2, Build ID: 40m0(Build:2) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 90175] New: Deactivating Bullets Removes Set Ruler Margins
https://bugs.documentfoundation.org/show_bug.cgi?id=90175 Bug ID: 90175 Summary: Deactivating Bullets Removes Set Ruler Margins Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: ux-advise Assignee: libreoffice-b...@lists.freedesktop.org Reporter: jmadero@gmail.com CC: libreoffice-ux-advise@lists.freedesktop.org Leave this to UX to decide if this is desired behavior. Steps: 1. Open writer; 2. Set ruler margin (using bottom triangle marker) to 1 (or just greater than 0); 3. Activate bullets; 4. Deactivate bullets Observed: Ruler marker goes away, margin goes back to default Expected: I'm not sure why deactivating the bullet would/should have an impact on the ruler marker that was set before activating the bullet. Again - I'm not sure this is a bug - requesting UX-Advise. Thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 90175] New: Deactivating Bullets Removes Set Ruler Margins
https://bugs.documentfoundation.org/show_bug.cgi?id=90175 Bug ID: 90175 Summary: Deactivating Bullets Removes Set Ruler Margins Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: ux-advise Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmadero@gmail.com CC: libreoffice-ux-adv...@lists.freedesktop.org Leave this to UX to decide if this is desired behavior. Steps: 1. Open writer; 2. Set ruler margin (using bottom triangle marker) to 1 (or just greater than 0); 3. Activate bullets; 4. Deactivate bullets Observed: Ruler marker goes away, margin goes back to default Expected: I'm not sure why deactivating the bullet would/should have an impact on the ruler marker that was set before activating the bullet. Again - I'm not sure this is a bug - requesting UX-Advise. Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 67465] EPS rendering: locating pstoedit on Mac a problem
https://bugs.documentfoundation.org/show_bug.cgi?id=67465 --- Comment #19 from Michael Stahl mst...@redhat.com --- why isn't this whole EPS filter an extension, bundling the horrible pstoedit thing or whatever else it needs so it actually works when users install it? imho the current implementation is an unsupportable anti-feature. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 88117] Selected Draw elements are truncated in bounding and extent when exported to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=88117 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Whiteboard|repro:4.4.2.1:Windows |repro:4.4.2.1:Windows ||repro:4.3.6.2:Windows --- Comment #12 from V Stuart Foote vstuart.fo...@utsa.edu --- STR 1. Create a graphic in Draw or use https://bugs.documentfoundation.org/attachment.cgi?id=111858 2. File - Export: select type as SVG 3. verify SVG is full extent of Draw image 4. result -- correct bounding box for graphic and full extent of image. 5. As compared with... back in Draw, use same graphic 6. select graphic (left mouse drag to encompass entire graphic), results with 8 frame handles showing at edges of image and all Draw elements included--shown in Status bar. 7. File - Export: select type as SVG select checkbox selection 8. result - SVG does not encompass full extent of selected graphic --Expected-- since the full graphic is selected, the resulting export to SVG would contain at least the same bounding box extents for the image portion as the full drawing exports. Instead portions of the graphic are being truncated, not all draw elements have been included in the new SVG. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88117] Selected Draw elements are truncated in bounding and extent when exported to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=88117 --- Comment #13 from Frederic Parrenin parrenin@gmail.com --- V Stuart Foote, I am exporting only the selection to avoid margins. I am happy to see somebody is able to reproduce the issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88117] Selected Draw elements are truncated in bounding and extent when exported to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=88117 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Status|NEEDINFO|NEW Summary|image truncated when|Selected Draw elements are |exported to svg |truncated in bounding and ||extent when exported to SVG Whiteboard|noRepro:4.3.4.1:Windows7|repro:4.4.2.1:Windows |noRepro:4.4.0.1:Windows7| |noRepro:4.3.6.2:Fedora21| |norepro:4.5.0alpha0+| |needs:Debian8 | --- Comment #11 from V Stuart Foote vstuart.fo...@utsa.edu --- Frederic, Any reason you are selecting poritions of the graphic? Normally, the whole ODG will be exported by default, adjust margins and image size using page settings and then simply export. So, it could be processing the selected checkbox that is causing the miscue. And, yup, just verified that on a Windows build of 4.4.2.1 pre-release. So suspect that to be the case on all the builds, setting NEW and adjusting summary. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: canvas/source
canvas/source/directx/dx_winstuff.hxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 79754dee2e2c0f4c8b05ae7db62b089912d6aa6d Author: Stephan Bergmann sberg...@redhat.com Date: Mon Mar 23 16:05:33 2015 +0100 More Windows define whack-a-mole Change-Id: I09bf1cfe22a65b8dbbcc7139cd1055f0e829210d diff --git a/canvas/source/directx/dx_winstuff.hxx b/canvas/source/directx/dx_winstuff.hxx index 7b7f3c2..7cf2ba8 100644 --- a/canvas/source/directx/dx_winstuff.hxx +++ b/canvas/source/directx/dx_winstuff.hxx @@ -176,7 +176,8 @@ namespace dxcanvas #endif #undef DELETE -#undef PolyPolygon +#undef GradientStyle_RECT +#undef Polygon #endif // INCLUDED_CANVAS_SOURCE_DIRECTX_DX_WINSTUFF_HXX ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 67465] EPS rendering: locating pstoedit on Mac a problem
https://bugs.documentfoundation.org/show_bug.cgi?id=67465 --- Comment #19 from Michael Stahl mst...@redhat.com --- why isn't this whole EPS filter an extension, bundling the horrible pstoedit thing or whatever else it needs so it actually works when users install it? imho the current implementation is an unsupportable anti-feature. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88117] Selected Draw elements are truncated in bounding and extent when exported to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=88117 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added OS|other |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 67465] EPS rendering: locating pstoedit on Mac a problem
https://bugs.documentfoundation.org/show_bug.cgi?id=67465 --- Comment #20 from fel...@felipegasper.com --- This used to work; then, it stopped working. By definition, this is a regression, and IMO one that, all things being equal, should be fixed. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 90096] Lines in a multilateral flowchart in Draw change on the pages that are not in the focus
https://bugs.documentfoundation.org/show_bug.cgi?id=90096 --- Comment #2 from Jens Scheidtweiler jens.scheidtwei...@caseris.de --- I see I did not describe the problem right. It does not happen any time but it is not only the color of a line to change. Most of the time it happens when I change the layout of the flowchart and then save it to disk. That means I connect the lines with other parts of the flowchart on page one. After saving this changes to disk the layout of other pages have changed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: pdfwriter_impl.cxx: No break at the end of case
and 11012? That one certainly looks like a bug, yes. But reading the code a bit, and especially this comment earlier in the same function: // LO internal gradient - PDF shading type: // * GradientStyle_LINEAR: axial shading, using sampled-function with 2 samples // [t=0:colorStart, t=1:colorEnd] // * GradientStyle_AXIAL: axial shading, using sampled-function with 3 samples // [t=0:colorEnd, t=0.5:colorStart, t=1:colorEnd] I think it is obvious that the missing break in fact is intentional there. Testing would have indicated that, I guess. (Whether translating LO gradients to PDF shading types in the way indicated makes sense or not is a totally different question... Would you want to work on that?) What do we learn from this? Don't immediately assume that what you or your editor think is a bug is not intentional. Instead, think harder, and if necessary, test what the code actually does at run-time. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 90149] Popclip not working
https://bugs.documentfoundation.org/show_bug.cgi?id=90149 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Priority|medium |low -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82855] MAILMERGE: Mail Merge Wizard not working anymore (freezes) when a data source exists
https://bugs.documentfoundation.org/show_bug.cgi?id=82855 --- Comment #24 from Claudio Negri ngr...@gmail.com --- (In reply to Jan-Marek Glogowski from comment #21) Does this problem occur with the documents provided by Marcus? Yes Can you please test current development build? I re-tested with this installer: master~2015-03-23_01.50.30_LibreOfficeDev_4.5.0.0.alpha0_Win_x86_en-US_de_ar_ja_ru_qtz.msi Program version: Version: 4.5.0.0.alpha0+ Build ID: ea59d42d2098e8be8b3ab9667922e8427ee4b714 TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-03-23_01:50:30 Locale: it_IT (installed after deleting the configuration folder and Addresses0.odb) and the problem persists. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: some notes on SwClient and SwModify
Hi Bjoern, First -- thanks for the summary, I got only part of this big picture from your commit messages. :) One part of your changes is that now SwModify::GetDepends() returns a const sw::WriterListener*, while it returned a const SwClient* in the past. We had code that casted away the const-ness using a C style cast: while( 0 != ( pDep = (SwClient*)aCallMod.GetDepends()) ) (sw/source/core/doc/docfmt.cxx:657) I'm not sure why loplugin:cstylecast did not catch these earlier, but now it does: /home/vmiklos/git/libreoffice/master-clang/sw/source/core/doc/docfmt.cxx:657:26: error: c-style cast, type=5, from='const sw::WriterListener *', to='SwClient *', recommendedFix=static_cast [loplugin:cstylecast] while( 0 != ( pDep = (SwClient*)aCallMod.GetDepends()) ) ^~~~ 1 error generated. Additional problem is that SwClient now inherits privately from ::sw::WriterListener, so not even a static_cast + const_cast will make the compiler happy. Could do const_cast + reinterpret_cast, but it doesn't sound like the right fix. What is the correct fix here? ;-) Thanks, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/commontools/parameters.cxx |5
connectivity/source/commontools/propertyids.cxx | 193
++
connectivity/source/drivers/mork/MCatalog.cxx |3
connectivity/source/drivers/mork/MConnection.hxx|2
connectivity/source/drivers/mork/MQueryHelper.cxx |5
connectivity/source/drivers/mork/MQueryHelper.hxx |1
connectivity/source/drivers/mork/MResultSet.cxx | 72 ++-
connectivity/source/drivers/mork/MResultSet.hxx |2
connectivity/source/drivers/mork/MResultSetMetaData.cxx |2
connectivity/source/drivers/mork/MStatement.cxx | 49 ++
connectivity/source/drivers/mork/MStatement.hxx |3
connectivity/source/drivers/mork/MTable.hxx |2
connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx | 21 +
connectivity/source/drivers/odbc/OResultSet.cxx |5
connectivity/source/drivers/postgresql/pq_databasemetadata.cxx | 20 +
connectivity/source/drivers/postgresql/pq_databasemetadata.hxx |1
connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx | 10
connectivity/source/drivers/postgresql/pq_resultsetmetadata.hxx |2
connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx | 11
connectivity/source/inc/odbc/OResultSet.hxx |3
20 files changed, 324 insertions(+), 88 deletions(-)
New commits:
commit 3e8a7ce7dffcf46a692e5da0b281a104df8d4d95
Author: Noel Grandin n...@peralex.com
Date: Mon Mar 23 10:50:14 2015 +0200
Revert loplugin:constantfunction: connectivity
it seems to be causing unit-test and build failures
This reverts commit 5cbb51c009fa266e8418ef93799ac64e431c22f5.
Change-Id: Idc6372f98200b23828aa19b22a75b6b2b640d1ab
diff --git a/connectivity/source/commontools/parameters.cxx
b/connectivity/source/commontools/parameters.cxx
index 1b512a0..d520e37 100644
--- a/connectivity/source/commontools/parameters.cxx
+++ b/connectivity/source/commontools/parameters.cxx
@@ -115,6 +115,11 @@ namespace dbtools
}
+void ParameterManager::disposing( const EventObject /*_rDisposingEvent*/ )
+{
+}
+
+
void ParameterManager::setAllParametersNull()
{
OSL_PRECOND( isAlive(), ParameterManager::setAllParametersNull: not
initialized, or already disposed! );
diff --git a/connectivity/source/commontools/propertyids.cxx
b/connectivity/source/commontools/propertyids.cxx
index 9f0635e..5b3d635 100644
--- a/connectivity/source/commontools/propertyids.cxx
+++ b/connectivity/source/commontools/propertyids.cxx
@@ -22,6 +22,77 @@
namespace dbtools
{
+const sal_Char* getPROPERTY_QUERYTIMEOUT() { return
QueryTimeOut; }
+const sal_Char* getPROPERTY_MAXFIELDSIZE() { return
MaxFieldSize; }
+const sal_Char* getPROPERTY_MAXROWS() { return
MaxRows; }
+const sal_Char* getPROPERTY_CURSORNAME(){ return
CursorName; }
+const sal_Char* getPROPERTY_RESULTSETCONCURRENCY() { return
ResultSetConcurrency; }
+const sal_Char* getPROPERTY_RESULTSETTYPE() { return
ResultSetType; }
+const sal_Char* getPROPERTY_FETCHDIRECTION(){ return
FetchDirection; }
+const sal_Char* getPROPERTY_FETCHSIZE() { return
FetchSize; }
+const sal_Char* getPROPERTY_ESCAPEPROCESSING() { return
EscapeProcessing; }
+const sal_Char* getPROPERTY_USEBOOKMARKS() { return
UseBookmarks; }
+
+const sal_Char* getPROPERTY_NAME() { return
Name; }
+const sal_Char* getPROPERTY_TYPE() { return
Type; }
+const sal_Char* getPROPERTY_TYPENAME() { return
TypeName; }
+const sal_Char* getPROPERTY_PRECISION() { return
Precision; }
+const sal_Char* getPROPERTY_SCALE() { return
Scale; }
+const sal_Char* getPROPERTY_ISNULLABLE(){ return
IsNullable; }
+const sal_Char* getPROPERTY_ISAUTOINCREMENT() { return
IsAutoIncrement; }
+const sal_Char* getPROPERTY_ISROWVERSION() { return
IsRowVersion; }
+const sal_Char* getPROPERTY_DESCRIPTION() { return
Description; }
+const sal_Char* getPROPERTY_DEFAULTVALUE() { return
DefaultValue; }
+
+const sal_Char* getPROPERTY_REFERENCEDTABLE() { return
ReferencedTable; }
+const sal_Char* getPROPERTY_UPDATERULE(){ return
UpdateRule; }
+const sal_Char* getPROPERTY_DELETERULE(){ return
DeleteRule; }
+const sal_Char* getPROPERTY_CATALOG() { return
Catalog; }
+const sal_Char* getPROPERTY_ISUNIQUE() { return
IsUnique; }
+
[Libreoffice-bugs] [Bug 90149] ACCESSIBILITY - Popclip not working
https://bugs.documentfoundation.org/show_bug.cgi?id=90149 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|Popclip not working |ACCESSIBILITY - Popclip not ||working -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/connectivity
include/connectivity/FValue.hxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 047d9818dd77046ae4de266f5f5fed221ecf0557
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Mar 23 10:17:35 2015 +0100
Catch accidental mis-conversions from pointer to bool
Change-Id: I3f6ec3bd951d45b973880be1ae19e167c5e99d20
diff --git a/include/connectivity/FValue.hxx b/include/connectivity/FValue.hxx
index db1b289..2408eaf 100644
--- a/include/connectivity/FValue.hxx
+++ b/include/connectivity/FValue.hxx
@@ -268,6 +268,9 @@ namespace connectivity
operator=(_rRH);
}
+// Avoid accidental uses of ORowSetValue(bool const ):
+templatetypename T ORowSetValue(T const *) = delete;
+
~ORowSetValue()
{
free();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: some notes on SwClient and SwModify
Hi Miklos On Mon, Mar 23, 2015 at 09:54:45AM +0100, Miklos Vajna wrote: /home/vmiklos/git/libreoffice/master-clang/sw/source/core/doc/docfmt.cxx:657:26: error: c-style cast, type=5, from='const sw::WriterListener *', to='SwClient *', recommendedFix=static_cast [loplugin:cstylecast] while( 0 != ( pDep = (SwClient*)aCallMod.GetDepends()) ) ^~~~ 1 error generated. Additional problem is that SwClient now inherits privately from ::sw::WriterListener, so not even a static_cast + const_cast will make the compiler happy. Could do const_cast + reinterpret_cast, but it doesn't sound like the right fix. What is the correct fix here? ;-) Doing a: SwIteratorSwClient,SwModify aIter(aCallMod); for(SwClient* pClient = aIter.First(); pClient; pClient=aIter.Next()) aCallMod.Remove(pClient); should work: SwIterator is required to handle removal of Client gracefully (and there is a unittest for that now). Also, when doing more than a plain Remove(), something like a SwIteratorSwFrm,SwModify etc. takes care of most of the casting for you internally. So for now, SwIterator should help getting rid of the cast errors: IMHO GetDepends() is an implementation detail that shouldnt be public anyway. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 90170] New: Incorrect export of this figure to svg
https://bugs.documentfoundation.org/show_bug.cgi?id=90170 Bug ID: 90170 Summary: Incorrect export of this figure to svg Product: LibreOffice Version: 4.3.3.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: parrenin@gmail.com Created attachment 114264 -- https://bugs.documentfoundation.org/attachment.cgi?id=114264action=edit .odg file to reproduce the problem Steps to reproduce: - open this .odg file - select all items (Ctrl-A) - go to FileExport - Check Selection and select svg format - Save to toto.svg - now open the file in a svg viewer (e.g., inkscape) = the text of the figure has disappeared -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/templatedlg.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 093846124b06961daa400735eaf0d50115cf8690
Author: Michael Horn hornmicha...@gmail.com
Date: Fri Mar 20 19:21:51 2015 -0700
tdf#90095 Fixed wrong behavior of template delete dialog
The template delete dialog was coded in such a way that the default behavior
was to delete the template/folder unless the user pressed no. This
caused the template to be deleted if the dialog was closed using the x
button. I changed the logic so that the dialog will only delete the
template if the user presses yes. Any other button press will do nothing
but close the dialog.
Change-Id: I7977fd48b3e0cc440cc1e15056b448e7ae23476f
Reviewed-on: https://gerrit.libreoffice.org/14937
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sfx2/source/doc/templatedlg.cxx b/sfx2/source/doc/templatedlg.cxx
index 2c3bd55..a584a7d 100644
--- a/sfx2/source/doc/templatedlg.cxx
+++ b/sfx2/source/doc/templatedlg.cxx
@@ -1160,7 +1160,7 @@ void SfxTemplateManagerDlg::OnTemplateDelete ()
{
MessageDialog aQueryDlg(this, SfxResId(STR_QMSG_SEL_TEMPLATE_DELETE),
VCL_MESSAGE_QUESTION, VCL_BUTTONS_YES_NO);
-if ( aQueryDlg.Execute() == RET_NO )
+if ( aQueryDlg.Execute() != RET_YES )
return;
OUString aTemplateList;
@@ -1245,7 +1245,7 @@ void SfxTemplateManagerDlg::OnFolderDelete()
{
MessageDialog aQueryDlg(this, SfxResId(STR_QMSG_SEL_FOLDER_DELETE),
VCL_MESSAGE_QUESTION, VCL_BUTTONS_YES_NO);
-if ( aQueryDlg.Execute() == RET_NO )
+if ( aQueryDlg.Execute() != RET_YES )
return;
OUString aFolderList;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 44152] Duplicate alphabetical-index-mark entries
https://bugs.documentfoundation.org/show_bug.cgi?id=44152 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||fdb...@neosheffield.co.uk Ever confirmed|0 |1 --- Comment #6 from Matthew Francis fdb...@neosheffield.co.uk --- Took a while to work this one out. Reproduced with the following exact steps: With language set to English, 1. New Writer document 2. Type dtF3 3. Insert - Indexes and Tables - Indexes and Tables... 4. Set Type: Alphabetical Index, Concordance file: Yes 5. Still within the dialog, beneath the checkbox for Concordance file, select File - New 6. Close the dialogs and save the document (select .fodt to make it easier later) 7. Close the document 8. Reload the document 9. Context menu - Edit Index/Table on the index that was inserted 10. Within the dialog, beneath the checkbox for Concordance file, select File - Edit 11. Add an entry with Search term: greenbacks, Alternative term: Greenbacks, Match case: Yes 13. Save the document 14. Close the document 15. Reload the document 16. Context menu - Edit Index/Table on the index that was inserted 17. Within the dialog, beneath the checkbox for Concordance file, select File - Edit 18. Add an entry with Search term: crook, Alternative term: Crook, Match case: Yes 19. Save the document 20. Examine the document's XML - the text:alphabetical-index-mark text:string-value=Greenbacks/ is duplicated Setting to NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86793] [Regression] Hang when moving pointer when document contains Zotero references
https://bugs.documentfoundation.org/show_bug.cgi?id=86793 --- Comment #9 from andis.lazd...@gmail.com --- Hi! This problem appears and the solution works also in 4.3.6.2 under Ubuntu 14.04 32 bit with MATE desktop environment. It is 100% reproducible with multiple Zotero citations. Regards -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68022] table cell of type float: uses value or body depending on body
https://bugs.documentfoundation.org/show_bug.cgi?id=68022 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||fdb...@neosheffield.co.uk Ever confirmed|0 |1 --- Comment #3 from Matthew Francis fdb...@neosheffield.co.uk --- Advice has been received in comment 2, so removing Whiteboard:NeedsAdvice and setting - NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/postwin.h include/vcl vcl/win
include/postwin.h | 127 -
include/vcl/sysdata.hxx|2
vcl/win/source/window/salframe.cxx |2
3 files changed, 3 insertions(+), 128 deletions(-)
New commits:
commit 8edf711eb2f39c7779f2d39938d786befea1c49b
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Mar 23 15:36:47 2015 +0100
Avoid KeyFuncType::DELETE shadowed by a macro on Windows
...required to remove the WIN_* defines from postwin.h, so that the latter
can
be included multiple times; the WIN_* defines appeared to be unused except
for
one use of WND_FindWindow anyway
Change-Id: I2080225c74c196fbc1b7d4f20b636b44e1e12150
diff --git a/include/postwin.h b/include/postwin.h
index 6fa0c36..555478d 100644
--- a/include/postwin.h
+++ b/include/postwin.h
@@ -37,160 +37,33 @@
#undef GetObject
-#ifdef SetPrinter
#undef SetPrinter
-#ifdef UNICODE
-#define WIN_SetPrinter SetPrinterW
-#else
-#define WIN_SetPrinter SetPrinterA
-#endif
-#else
-#define WIN_SetPrinter SetPrinter
-#endif
-#ifdef GetPrinter
#undef GetPrinter
-#ifdef UNICODE
-#define WIN_GetPrinter GetPrinterW
-#else
-#define WIN_GetPrinter GetPrinterA
-#endif
-#else
-#define WIN_GetPrinter GetPrinter
-#endif
-#ifdef DrawText
#undef DrawText
-#ifdef UNICODE
-#define WIN_DrawTextDrawTextW
-#else
-#define WIN_DrawTextDrawTextA
-#endif
-#else
-#define WIN_DrawTextDrawText
-#endif
-#ifdef mciSetCommand
#undef mciSetCommand
-#ifdef UNICODE
-#define WIN_mciSetCommand mciSetCommandW
-#else
-#define WIN_mciSetCommand mciSetCommandA
-#endif
-#else
-#define mciSetCommand mciSetCommand
-#endif
-#ifdef SetPort
#undef SetPort
-#ifdef UNICODE
-#define WIN_SetPort SetPortW
-#else
-#define WIN_SetPort SetPortA
-#endif
-#else
-#define WIN_SetPort SetPort
-#endif
-#ifdef CopyFile
#undef CopyFile
-#ifdef UNICODE
-#define WIN_CopyFileCopyFileW
-#else
-#define WIN_CopyFileCopyFileA
-#endif
-#else
-#define WIN_CopyFileCopyFile
-#endif
-
-#ifdef GetUserName
#undef GetUserName
-#ifdef UNICODE
-#define WIN_GetUserName GetUserNameW
-#else
-#define WIN_GetUserName GetUserNameA
-#endif
-#else
-#define WIN_GetUserName GetUserName
-#endif
-#ifdef GetClassName
#undef GetClassName
-#ifdef UNICODE
-#define WIN_GetClassName GetClassNameW
-#else
-#define WIN_GetClassName GetClassNameA
-#endif
-#else
-#define WIN_GetClassName GetClassName
-#endif
-#ifdef GetCharWidth
#undef GetCharWidth
-#ifdef UNICODE
-#define WIN_GetCharWidth GetCharWidthW
-#else
-#define WIN_GetCharWidth GetCharWidthA
-#endif
-#else
-#define WIN_GetCharWidth GetCharWidth
-#endif
-#ifdef GetMetaFile
#undef GetMetaFile
-#ifdef UNICODE
-#define WIN_GetMetaFile GetMetaFileW
-#else
-#define WIN_GetMetaFile GetMetaFileA
-#endif
-#else
-#define WIN_GetMetaFile GetMetaFile
-#endif
-#ifdef GetNumberFormat
#undef GetNumberFormat
-#ifdef UNICODE
-#define WIN_GetNumberFormat GetNumberFormatW
-#else
-#define WIN_GetNumberFormat GetNumberFormatA
-#endif
-#else
-#define WIN_GetNumberFormat GetNumberFormat
-#endif
-#ifdef GetGlyphOutline
#undef GetGlyphOutline
-#ifdef UNICODE
-#define WIN_GetGlyphOutline GetGlyphOutlineW
-#else
-#define WIN_GetGlyphOutline GetGlyphOutlineA
-#endif
-#else
-#define WIN_GetGlyphOutline GetGlyphOutline
-#endif
-#ifdef GetKerningPairs
#undef GetKerningPairs
-#ifdef UNICODE
-#define WIN_GetKerningPairs GetKerningPairsW
-#else
-#define WIN_GetKerningPairs GetKerningPairsA
-#endif
-#else
-#define WIN_GetKerningPairs GetKerningPairs
-#endif
-#ifdef FindWindow
#undef FindWindow
-#ifdef UNICODE
-#define WIN_FindWindow FindWindowW
-#else
-#define WIN_FindWindow FindWindowA
-#endif
-#else
-#define WIN_FindWindow FindWindow
-#endif
#undef Yield
diff --git a/include/vcl/sysdata.hxx b/include/vcl/sysdata.hxx
index e8b7a25..a4fad69 100644
--- a/include/vcl/sysdata.hxx
+++ b/include/vcl/sysdata.hxx
@@ -41,7 +41,9 @@ typedef struct CGContext *CGContextRef;
#endif
#if defined( WNT )
+#include prewin.h
#include windef.h
+#include postwin.h
#endif
struct SystemEnvData
diff --git a/vcl/win/source/window/salframe.cxx
b/vcl/win/source/window/salframe.cxx
index fbd82f0..1544b2f 100644
--- a/vcl/win/source/window/salframe.cxx
+++ b/vcl/win/source/window/salframe.cxx
@@ -678,7 +678,7 @@ static const sal_uInt16 aImplTranslateKeyTab[KEY_TAB_SIZE] =
static UINT ImplSalGetWheelScrollLines()
{
UINT nScrLines = 0;
-HWND hWndMsWheel = WIN_FindWindow( MSH_WHEELMODULE_CLASS,
MSH_WHEELMODULE_TITLE );
+HWND hWndMsWheel = FindWindowA( MSH_WHEELMODULE_CLASS,
MSH_WHEELMODULE_TITLE );
if ( hWndMsWheel )
{
UINT nGetScrollLinesMsgId = RegisterWindowMessage( MSH_SCROLL_LINES );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88117] image truncated when exported to svg
https://bugs.documentfoundation.org/show_bug.cgi?id=88117 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Whiteboard|noRepro:4.3.4.1:Windows7|noRepro:4.3.4.1:Windows7 |noRepro:4.4.0.1:Windows7|noRepro:4.4.0.1:Windows7 ||noRepro:4.3.6.2:Fedora21 ||norepro:4.5.0alpha0+ --- Comment #10 from V Stuart Foote vstuart.fo...@utsa.edu --- On Fedora 21, 32-bit w/LXDE No issues with exported SVG being cropped with current master Version: 4.5.0.0.alpha0+ Build ID: c3087d969671e62182eb049850479e77190ccff4 TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2015-03-22_02:33:12 Locale: en_US nor with 4.3.6.2 release RPM Version: 4.3.6.2 Build ID: d50a87b2e514536ed401c18000dad4660b6a169e So, it could be an issue unique to your Debian distro. Will bump the QA and Users ML -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88117] image truncated when exported to svg
https://bugs.documentfoundation.org/show_bug.cgi?id=88117 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Hardware|Other |All Version|unspecified |4.3.3.2 release Whiteboard|noRepro:4.3.4.1:Windows7|noRepro:4.3.4.1:Windows7 |noRepro:4.4.0.1:Windows7|noRepro:4.4.0.1:Windows7 |noRepro:4.3.6.2:Fedora21|noRepro:4.3.6.2:Fedora21 |norepro:4.5.0alpha0+|norepro:4.5.0alpha0+ ||needs:Debian8 OS|All |other -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86793] [Regression] Hang when moving pointer when document contains Zotero references
https://bugs.documentfoundation.org/show_bug.cgi?id=86793 Milan Bouchet-Valat nalimi...@club.fr changed: What|Removed |Added Hardware|x86-64 (AMD64) |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Subject: Popa Adrian Marius license statement
All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] help from Debian distro user on tdf#88117
Could someone running Debian 7 or 8, have a look at tdf#88117 - image truncated when exported to svg https://bugs.documentfoundation.org/show_bug.cgi?id=88117 . Can't repro any mix of Windows, Fedora, or RHEL -- so possibly Debian distro specific. Thanks. Stuart -- View this message in context: http://nabble.documentfoundation.org/help-from-Debian-distro-user-on-tdf-88117-tp4144178.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
i18npool/source/search/textsearch.cxx TransliterationModules bug?
this is a bit suspicious: static const sal_Int32 COMPLEX_TRANS_MASK = COMPLEX_TRANS_MASK_TMP | TransliterationModules_IGNORE_KANA | TransliterationModules_FULLWIDTH_HALFWIDTH; the FULLWIDTH_HALFWIDTH value is 4 and the TransliterationModules enum is very odd in that it is basically split into 2 ranges and values 0xFF are not to be used as bitflags, whereas values 0xFF are always defined as single bits. using FULLWIDTH_HALFWIDTH in the mask looks like it would affect the value NumToTextFormalLower_ko = 12 as well which is probably not intentional? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - sw/CppunitTest_sw_ooxmlimport.mk sw/qa vcl/quartz
sw/CppunitTest_sw_ooxmlimport.mk | 12
sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 15 +++
vcl/quartz/salgdicommon.cxx |7 +++
3 files changed, 34 insertions(+)
New commits:
commit ce4412b52f50957117af5c472ca16974a51b2936
Author: Tor Lillqvist t...@collabora.com
Date: Mon Mar 23 15:32:30 2015 +0200
Quick hack to bypass a test that fails on a Retina Mac
Change-Id: If4bda345cae62b8f7c809ea8bd56913d436602b6
diff --git a/sw/CppunitTest_sw_ooxmlimport.mk b/sw/CppunitTest_sw_ooxmlimport.mk
index 6ee96e3..5aae15d 100644
--- a/sw/CppunitTest_sw_ooxmlimport.mk
+++ b/sw/CppunitTest_sw_ooxmlimport.mk
@@ -42,6 +42,18 @@ $(eval $(call gb_CppunitTest_set_include,sw_ooxmlimport,\
$$(INCLUDE) \
))
+ifeq ($(OS),MACOSX)
+
+$(eval $(call gb_CppunitTest_add_cxxflags,sw_ooxmlimport,\
+$(gb_OBJCXXFLAGS) \
+))
+
+$(eval $(call gb_CppunitTest_use_system_darwin_frameworks,sw_ooxmlimport,\
+ AppKit \
+))
+
+endif
+
$(eval $(call gb_CppunitTest_use_api,sw_ooxmlimport,\
offapi \
udkapi \
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 7ceb756..c9360f4 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -9,6 +9,13 @@
#include config_test.h
+#ifdef MACOSX
+#define __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES 0
+#include premac.h
+#include AppKit/AppKit.h
+#include postmac.h
+#endif
+
#include swmodeltestbase.hxx
#if !defined(WNT)
@@ -1758,6 +1765,14 @@ DECLARE_OOXMLIMPORT_TEST(textboxWpsOnly,
textbox-wps-only.docx)
// Position was the default (hori center, vert top) for the textbox.
xFrame.set(getShape(2), uno::UNO_QUERY);
CPPUNIT_ASSERT_EQUAL(sal_Int32(2173), getPropertysal_Int32(xFrame,
HoriOrientPosition));
+#ifdef MACOSX
+// FIXME: The assert below fails wildly on a Retina display. So use some
(horrible)
+// heuristics. Note that for instance on the 5K Retina iMac, [NSScreen
mainScreen].frame.size is
+// 2560x1440, not the true display size 5120x2880. But whatever, I don't
have much time to spend
+// on this.
+if ([NSScreen mainScreen].frame.size.width 2000)
+return;
+#endif
CPPUNIT_ASSERT_EQUAL(sal_Int32(2805), getPropertysal_Int32(xFrame,
VertOrientPosition));
}
commit 4be86e71d607715dd602838f49aa19f478662147
Author: Tor Lillqvist t...@collabora.com
Date: Mon Mar 23 15:25:31 2015 +0200
Add comment about the DPI calculation
Change-Id: I791904a50db75ed94c166b0f84d9f08cb088bafe
diff --git a/vcl/quartz/salgdicommon.cxx b/vcl/quartz/salgdicommon.cxx
index febf2fd..f193122 100644
--- a/vcl/quartz/salgdicommon.cxx
+++ b/vcl/quartz/salgdicommon.cxx
@@ -1736,6 +1736,13 @@ void AquaSalGraphics::initResolution( NSWindow* )
{
mnRealDPIX = mnRealDPIY = nMinDPI;
}
+// Note that on a Retina display, the mnRealDPIX as
+// calculated above is not the true resolution of the display,
+// but the logical one, or whatever the correct terminology
+// is. (For instance on a 5K 27in iMac, it's 108.) So at
+// least currently, it won't be over 200. I don't know whether
+// this test is a sanity check, or whether there is some
+// real reason to limit this to 200.
static const int nMaxDPI = 200;
if( (mnRealDPIX nMaxDPI) || (mnRealDPIY nMaxDPI) )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...
https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #13 from Michael Meeks michael.me...@collabora.com --- The sw/ viewsh.cxx thing should be a stock SolarMutexGuard aGuard; I think =) rather than using this un-helpful API =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - 2 commits - include/svx include/vcl sw/inc
include/svx/svdmodel.hxx |3 ++-
include/vcl/ITiledRenderable.hxx |8 +++-
sw/inc/viewsh.hxx|3 ++-
3 files changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 084f73cbb278c291a917804d3c18c5c4a801
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Mar 23 13:57:44 2015 +0100
vcl::ITiledRenderable: can mark these methods as pure virtual
Change-Id: Ic6b594ee3ed668f5038a1f998ec9e514ecb75169
diff --git a/include/vcl/ITiledRenderable.hxx b/include/vcl/ITiledRenderable.hxx
index 5340f06..76a18f0 100644
--- a/include/vcl/ITiledRenderable.hxx
+++ b/include/vcl/ITiledRenderable.hxx
@@ -89,9 +89,7 @@ public:
* Setup various document properties that are needed for the document to
* be renderable via tiled rendering.
*/
-virtual void initializeForTiledRendering()
-{
-}
+virtual void initializeForTiledRendering() = 0;
/**
* Registers a callback that will be invoked whenever the tiled renderer
@@ -100,14 +98,14 @@ public:
* @param pCallBack is the callback function
* @param pData is private data of the client that will be sent back when
the callback is invoked
*/
-virtual void registerCallback(LibreOfficeKitCallback /*pCallback*/, void*
/*pData*/) { }
+virtual void registerCallback(LibreOfficeKitCallback pCallback, void*
pData) = 0;
/**
* Posts a mouse event on the document.
*
* @see lok::Document::postMouseEvent().
*/
-virtual void postMouseEvent(int /*nType*/, int /*nX*/, int /*nY*/, int
/*nCount*/) { }
+virtual void postMouseEvent(int nType, int nX, int nY, int nCount) = 0;
/**
* Sets the start or end of a text selection.
commit 24e0a35df5c47dba287b8df916b4d2dbeb0a3b7e
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Mar 23 13:57:18 2015 +0100
svx, sw: can avoid vcl/ITiledRenderable.hxx include here
Change-Id: I27f1770d0e1d3409d51887565f67d4d456ca9692
diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx
index 388e82e..4d238a2 100644
--- a/include/svx/svdmodel.hxx
+++ b/include/svx/svdmodel.hxx
@@ -37,7 +37,8 @@
#include svx/xtable.hxx
#include svx/pageitem.hxx
#include vcl/field.hxx
-#include vcl/ITiledRenderable.hxx
+#define LOK_USE_UNSTABLE_API
+#include LibreOfficeKit/LibreOfficeKitTypes.h
class OutputDevice;
#include svx/svdtypes.hxx
diff --git a/sw/inc/viewsh.hxx b/sw/inc/viewsh.hxx
index 2bc8260..994ef9e 100644
--- a/sw/inc/viewsh.hxx
+++ b/sw/inc/viewsh.hxx
@@ -30,7 +30,8 @@
#include stack
#include vcl/mapmod.hxx
#include vcl/print.hxx
-#include vcl/ITiledRenderable.hxx
+#define LOK_USE_UNSTABLE_API
+#include LibreOfficeKit/LibreOfficeKitTypes.h
namespace com { namespace sun { namespace star { namespace accessibility {
class XAccessible; } } } }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90172] Capitalize first letter of every sentence doesn't work at all.
https://bugs.documentfoundation.org/show_bug.cgi?id=90172 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal r...@post.cz --- Works OK with LO 4.4.1.2, ID build: 45e2de17089c24a1fa810c8f975a7171ba4cd432, Win7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...
https://bugs.documentfoundation.org/show_bug.cgi?id=88230 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added CC||sberg...@redhat.com --- Comment #12 from Michael Meeks michael.me...@collabora.com --- Lovely cleanup - thanks Pranav. Stephan - I agree that the 'clear' method is not ideal - for sure; then again it hardly looks necessary in the current code-base. Pranav - I'd love to get this guy closed; but I still see a few bits that could use some cleanup: fpicker/source/win32/filepicker/SolarMutex.hxx:void AcquireSolarMutex(int nAcquireCount); That thing seems torally bogus; there is no need for this fpicker wrapper - can we kill that ? sw/source/core/view/viewsh.cxx-// Creation, use and destruction of a VirtualDevice needs to be sw/source/core/view/viewsh.cxx-// protected by the SolarMutex, it seems. sw/source/core/view/viewsh.cxx:Application::AcquireSolarMutex(1); And after that I'd love to make the 'AcquireSolarMutex' and release method private methods - and add a 'friend' class for the SolarMutexReleaser and other methods that have a legimitate use for that. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...
https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #14 from Michael Meeks michael.me...@collabora.com --- Oh; and while I'm here - forget the 'friend' thing - we should just kill the crazy Application:: yielding functions, and move their implementation to non-in-line methods in the Releaser - since they use the global VCL backend state anyway so - no need to associate them with that class =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/win
vcl/win/source/gdi/salgdi.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit ca35a282d50bbc238c9975fdf7d77038676318ab Author: Tor Lillqvist t...@collabora.com Date: Mon Mar 23 16:02:26 2015 +0200 WaE: 'rRefDevice' : unreferenced formal parameter Change-Id: If45c91f04caef8cd4387f623c773913ee1a1154d diff --git a/vcl/win/source/gdi/salgdi.cxx b/vcl/win/source/gdi/salgdi.cxx index 66f95d9..a32bd9d 100644 --- a/vcl/win/source/gdi/salgdi.cxx +++ b/vcl/win/source/gdi/salgdi.cxx @@ -1134,6 +1134,7 @@ cairo::SurfaceSharedPtr WinSalGraphics::CreateSurface( const OutputDevice rRefD surf = cairo::SurfaceSharedPtr(new cairo::Win32Surface((HDC) aSysData.hDC, x, y)); } #else +(void)rRefDevice; (void)x; (void)y; #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 66065] VIEWING: Image anchor's position when moving is sometimes incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=66065 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added CC||fdb...@neosheffield.co.uk --- Comment #9 from Matthew Francis fdb...@neosheffield.co.uk --- Confirmed on Libreoffice 4.4.0.3 / OSX 10.10 Setting - NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90165] round corners in tables
https://bugs.documentfoundation.org/show_bug.cgi?id=90165 --- Comment #2 from jlbr...@portugalmail.com --- (In reply to Robinson Tryon (qubit) from comment #1) (In reply to jlbraga from comment #0) HI. How about to make round corners in tables possible ? Hi jlbraga, Thanks for the suggestion! Could you explain a little more about what you'd expect regarding round corners? Are you thinking about tables in Writer, or use in other components as well? Would the corner parameters be configurable? Status - NEEDINFO In the meantime, please note that there are some workarounds that might be helpful: http://en.libreofficeforum.org/node/5707 [cc: jay, as he might have some good insight here] Wherever it is possible to create tables, there should be a table and/or cell format option to make the corners round. Also, there could be an option to choose the curvature intensity (or percentage). It is possible to do this to cells and tables in HTML/CSS, why can't it be possible in an office suite?... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90087] Impossible to remove a Frame
https://bugs.documentfoundation.org/show_bug.cgi?id=90087 actionmystique actionmysti...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #4 from actionmystique actionmysti...@gmail.com --- I was finally able to select it and delete it. Thanks for your help though, you could confirm it was a frame. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89913] FILESAVE: Change color or bold for a part of the text in cell won't save (stay black)
https://bugs.documentfoundation.org/show_bug.cgi?id=89913 --- Comment #12 from Soufiane dardour.soufi...@gmail.com --- Hi everbody, Indeed there is no problem with the version 4.3.6 downloaded from TDF web site. But when I'm cloning the sources from git://anongit.freedesktop.org/libreoffice/core and try to build libreoffice I have this problem. Where did you get the sources to build libreffice ? Thanks in advance. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66065] VIEWING: Image anchor's position when moving is sometimes incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=66065 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67465] EPS rendering: locating pstoedit on Mac a problem
https://bugs.documentfoundation.org/show_bug.cgi?id=67465 --- Comment #20 from fel...@felipegasper.com --- This used to work; then, it stopped working. By definition, this is a regression, and IMO one that, all things being equal, should be fixed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Information about our work on Libreoffice
Hi Tobias, On Sun, Mar 15, 2015 at 11:40:28AM +0100, Miklos Vajna vmik...@collabora.co.uk wrote: Thanks for the recent improvements, the current master is much better than what it was right after the merge. :-) With bcefd5cda926f86db16b1bcf6838431b5b0d61b5 I still see one problem, though: 1) Start Writer. 2) Press F11 to open the styles sidebar 3) Right-click on e.g. heading 1, and select modify - repaint problem. Screenshot: http://people.freedesktop.org/~vmiklos/2015/heading1-repaint-problem.png This is still a problem -- please let me know if you prefer a bugreport instead. Thanks, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 82641] Currency drop-down ...
https://bugs.documentfoundation.org/show_bug.cgi?id=82641 --- Comment #26 from Rajat Vijay rajatvij...@gmail.com --- Tis is the error i am getting pls help-- /home/rajatvijay/libreoffice/workdir/CxxObject/sc/source/ui/app/scdll.o: In function `ScDLL::Init()': scdll.cxx:(.text+0x192): undefined reference to `SfxCurrencyListToolBoxControl::RegisterControl(unsigned short, SfxModule*)' collect2: error: ld returned 1 exit status make[1]: *** [/home/rajatvijay/libreoffice/instdir/program/libsclo.so] Error 1 make: *** [build] Error 2 Also need some help in understanding and writing code for CreatePopupWindow() for my new class , from the old one (as in class SfxRecentFilesToolBoxControl some names are difficult to understand) Pls reply asap as i have to register for GSoC 2105 Thanks in advance!!! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82641] Currency drop-down ...
https://bugs.documentfoundation.org/show_bug.cgi?id=82641 --- Comment #27 from Rajat Vijay rajatvij...@gmail.com --- Tis is the error i am getting pls help-- /home/rajatvijay/libreoffice/workdir/CxxObject/sc/source/ui/app/scdll.o: In function `ScDLL::Init()': scdll.cxx:(.text+0x192): undefined reference to `SfxCurrencyListToolBoxControl::RegisterControl(unsigned short, SfxModule*)' collect2: error: ld returned 1 exit status make[1]: *** [/home/rajatvijay/libreoffice/instdir/program/libsclo.so] Error 1 make: *** [build] Error 2 Also need some help in understanding and writing code for CreatePopupWindow() for my new class , from the old one (as in class SfxRecentFilesToolBoxControl some names are difficult to understand) Pls reply asap as i have to register for GSoC 2105 Thanks in advance!!! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88117] Selected Draw elements are truncated in bounding and extent when exported to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=88117 --- Comment #14 from Frederic Parrenin parrenin@gmail.com --- Sorry, reading back my initial description, I now see I forgot to mention that I checked the selection option in the export dialog. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90176] New: Sidebar won't dock on left
https://bugs.documentfoundation.org/show_bug.cgi?id=90176 Bug ID: 90176 Summary: Sidebar won't dock on left Product: LibreOffice Version: 4.4.1.2 rc Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hopman.t...@gmail.com Created attachment 114275 -- https://bugs.documentfoundation.org/attachment.cgi?id=114275action=edit Screenshot showing inability to dock sidebar on left Version: 4.4.1.2 Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432 Locale: en_CA When I undock the sidebar, I cannot re-dock it on the left. This seems to happen in all applications, whether the window is maximized or not. As the attached screenshot shows, the outline of the the floating sidebar doesn't turn grey when dragged to the left (or right) side. This worked in previous versions of LO, even with all the redraw problems caused by having the sidebar on the left. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88117] Selected Draw elements are truncated in bounding and extent when exported to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=88117 --- Comment #15 from V Stuart Foote vstuart.fo...@utsa.edu --- No, my fault. I routinely resize my Draw page and eliminate margins reducing size of the graphic down to what I want it to be--and then exporting the entire ODG. That works. What is not correct, and which I didn't consider is when selecting some number of Draw elements and then exporting just that selection. That is your usage but for the entire graphic, but would be an issue for any use case of some subset of Draw elements. Selection and export to SVG should honor the bounding/extent of what was selected. Export of selection to WMF, EMF, BMP all are correct--just the export to SVG is truncating right edge and bottom of extent. You can work around it as I'd been saying--but it is not otherwise correct handling (I suspect problem is in the creation of the SVG from the selected Draw elements, since the other vector formats are correct). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - sd/source
sd/source/ui/inc/ViewShell.hxx |2 ++
sd/source/ui/inc/unomodel.hxx|2 ++
sd/source/ui/unoidl/unomodel.cxx | 26 ++
sd/source/ui/view/viewshel.cxx | 13 +
4 files changed, 43 insertions(+)
New commits:
commit a26b23e9e6f33766d169519d52da98826e179cb0
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Mar 23 16:08:55 2015 +0100
SdXImpressDocument: implement setTextSelection()
With this, it's possible to adjust an Impress shape text selection,
using the selection handles already provided by editeng.
Change-Id: I16fe3222c9e1289a0a1b5bea9469c88513994e75
diff --git a/sd/source/ui/inc/ViewShell.hxx b/sd/source/ui/inc/ViewShell.hxx
index 710c722..767a113 100644
--- a/sd/source/ui/inc/ViewShell.hxx
+++ b/sd/source/ui/inc/ViewShell.hxx
@@ -447,6 +447,8 @@ public:
void LogicMouseButtonDown(const MouseEvent rMouseEvent);
/// Same as MouseButtonUp(), but coordinates are in logic unit.
void LogicMouseButtonUp(const MouseEvent rMouseEvent);
+/// Allows adjusting the point or mark of the selection to a document
coordinate.
+void SetCursorLogicPosition(const Point rPosition, bool bPoint, bool
bClearMark);
class Implementation;
diff --git a/sd/source/ui/inc/unomodel.hxx b/sd/source/ui/inc/unomodel.hxx
index 64080e7..7641e11 100644
--- a/sd/source/ui/inc/unomodel.hxx
+++ b/sd/source/ui/inc/unomodel.hxx
@@ -246,6 +246,8 @@ public:
virtual void registerCallback(LibreOfficeKitCallback pCallback, void*
pData) SAL_OVERRIDE;
/// @see vcl::ITiledRenderable::postMouseEvent().
virtual void postMouseEvent(int nType, int nX, int nY, int nCount)
SAL_OVERRIDE;
+/// @see vcl::ITiledRenderable::setTextSelection().
+virtual void setTextSelection(int nType, int nX, int nY) SAL_OVERRIDE;
// XComponent
diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx
index ac41220..4d32ced 100644
--- a/sd/source/ui/unoidl/unomodel.cxx
+++ b/sd/source/ui/unoidl/unomodel.cxx
@@ -2402,6 +2402,32 @@ void SdXImpressDocument::postMouseEvent(int nType, int
nX, int nY, int nCount)
}
}
+void SdXImpressDocument::setTextSelection(int nType, int nX, int nY)
+{
+SolarMutexGuard aGuard;
+
+DrawViewShell* pViewShell = GetViewShell();
+if (!pViewShell)
+return;
+
+Point aPoint(convertTwipToMm100(nX), convertTwipToMm100(nY));
+switch (nType)
+{
+case LOK_SETTEXTSELECTION_START:
+pViewShell-SetCursorLogicPosition(aPoint, /*bPoint=*/false,
/*bClearMark=*/false);
+break;
+case LOK_SETTEXTSELECTION_END:
+pViewShell-SetCursorLogicPosition(aPoint, /*bPoint=*/true,
/*bClearMark=*/false);
+break;
+case LOK_SETTEXTSELECTION_RESET:
+pViewShell-SetCursorLogicPosition(aPoint, /*bPoint=*/true,
/*bClearMark=*/true);
+break;
+default:
+assert(false);
+break;
+}
+}
+
uno::Reference i18n::XForbiddenCharacters
SdXImpressDocument::getForbiddenCharsTable()
{
uno::Reference i18n::XForbiddenCharacters xForb(mxForbidenCharacters);
diff --git a/sd/source/ui/view/viewshel.cxx b/sd/source/ui/view/viewshel.cxx
index ce01af2..9bbf61d 100644
--- a/sd/source/ui/view/viewshel.cxx
+++ b/sd/source/ui/view/viewshel.cxx
@@ -77,6 +77,7 @@
#include editeng/numitem.hxx
#include editeng/eeitem.hxx
+#include editeng/editview.hxx
#include svl/poolitem.hxx
#include glob.hrc
#include AccessibleDocumentViewBase.hxx
@@ -531,6 +532,18 @@ void ViewShell::LogicMouseButtonUp(const MouseEvent
rMouseEvent)
mpActiveWindow-SetPointerPosPixel(aPoint);
}
+void ViewShell::SetCursorLogicPosition(const Point rPosition, bool bPoint,
bool bClearMark)
+{
+if (SdrView* pSdrView = GetView())
+{
+if (pSdrView-GetTextEditObject())
+{
+EditView rEditView =
pSdrView-GetTextEditOutlinerView()-GetEditView();
+rEditView.SetCursorLogicPosition(rPosition, bPoint, bClearMark);
+}
+}
+}
+
void ViewShell::MouseMove(const MouseEvent rMEvt, ::sd::Window* pWin)
{
if (rMEvt.IsLeaveWindow())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gdi/cairo_gtk3_cairo.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit be4ca35ad7926a2783b1c599f632a8d2591cbeab
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Mar 23 16:58:54 2015 +0100
loplugin:saloverride
Change-Id: Ia41415272e12b47ae332c38badd323ad3ab6a5ad
diff --git a/vcl/unx/gtk3/gdi/cairo_gtk3_cairo.hxx
b/vcl/unx/gtk3/gdi/cairo_gtk3_cairo.hxx
index 1d6e36f..dee313f 100644
--- a/vcl/unx/gtk3/gdi/cairo_gtk3_cairo.hxx
+++ b/vcl/unx/gtk3/gdi/cairo_gtk3_cairo.hxx
@@ -41,7 +41,7 @@ namespace cairo {
virtual void flush() const SAL_OVERRIDE;
-~Gtk3Surface();
+virtual ~Gtk3Surface();
};
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/source
framework/source/helper/titlebarupdate.cxx | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) New commits: commit 9450d7e7089aab4b14a669bf947cc34ae0f6b892 Author: Caolán McNamara caol...@redhat.com Date: Mon Mar 23 10:41:21 2015 + Resolves: rhbz#1204244 group sdb windows together as 'base' Change-Id: Ie0d17e562b24a8108d79d13592fff3bf2b9a6713 diff --git a/framework/source/helper/titlebarupdate.cxx b/framework/source/helper/titlebarupdate.cxx index 7626309..b79b5b2 100644 --- a/framework/source/helper/titlebarupdate.cxx +++ b/framework/source/helper/titlebarupdate.cxx @@ -139,25 +139,17 @@ void TitleBarUpdate::impl_updateApplicationID(const css::uno::Reference css::fr OUString sDesktopName; OUString aModuleId = xModuleManager-identify(xFrame); -if ( aModuleId == com.sun.star.text.TextDocument || - aModuleId == com.sun.star.text.GlobalDocument || - aModuleId == com.sun.star.text.WebDocument || - aModuleId == com.sun.star.xforms.XMLFormDocument ) +if ( aModuleId.startsWith(com.sun.star.text.) || aModuleId.startsWith(com.sun.star.xforms.) ) sDesktopName = Writer; -else if ( aModuleId == com.sun.star.sheet.SpreadsheetDocument ) +else if ( aModuleId.startsWith(com.sun.star.sheet.) ) sDesktopName = Calc; -else if ( aModuleId == com.sun.star.presentation.PresentationDocument ) +else if ( aModuleId.startsWith(com.sun.star.presentation.) ) sDesktopName = Impress; -else if ( aModuleId == com.sun.star.drawing.DrawingDocument ) +else if ( aModuleId.startsWith(com.sun.star.drawing. ) ) sDesktopName = Draw; -else if ( aModuleId == com.sun.star.formula.FormulaProperties ) +else if ( aModuleId.startsWith(com.sun.star.formula. ) ) sDesktopName = Math; -else if ( aModuleId == com.sun.star.sdb.DatabaseDocument || - aModuleId == com.sun.star.sdb.OfficeDatabaseDocument || - aModuleId == com.sun.star.sdb.RelationDesign || - aModuleId == com.sun.star.sdb.QueryDesign || - aModuleId == com.sun.star.sdb.TableDesign || - aModuleId == com.sun.star.sdb.DataSourceBrowser ) +else if ( aModuleId.startsWith(com.sun.star.sdb.) ) sDesktopName = Base; else sDesktopName = Startcenter; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
