[Libreoffice-bugs] [Bug 92329] we can not go to a specific page via keyboard.
https://bugs.documentfoundation.org/show_bug.cgi?id=92329 --- Comment #2 from zahra nasrinkhaks...@gmail.com --- (In reply to Cor Nouws from comment #1) Hi Zahra, Please try Ctrl+Shft+F5 :) And for questions, there are user support options too. http://www.libreoffice.org/get-help/mailing-lists/ Kind regards, Cor hi cor. thanks extremely for your guide and very useful answer. your help solved a very big problem for me in using libreoffice and openoffice. thanks extremely again. best regards: zahra -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91221] Problem when sorting table if a header cell is empty
https://bugs.documentfoundation.org/show_bug.cgi?id=91221 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #3 from Beluga todven...@suomi24.fi --- NEEDINFO per comment 2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91526] [LOCALIZATION] Missing translations in UI for pt_BR and others
https://bugs.documentfoundation.org/show_bug.cgi?id=91526 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #5 from Beluga todven...@suomi24.fi --- (In reply to Olivier Hallot from comment #4) Created attachment 116064 [details] KeyID showing ellipsis in buttons where it should not KeyID shows that strings in master were not moved to translation. I don't see that with KeyID now. I see RGuXW||Browse... dfF6S||Password... Can you confirm? Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64) Build ID: a51ac4d2bb8c4f1ea1d4ea7569863e2fb6535b02 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-06-22_21:37:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92292] XComponent creates lu* /tmp files
https://bugs.documentfoundation.org/show_bug.cgi?id=92292 --- Comment #2 from Sugam suga...@gmail.com --- @Alex Thurgood : Yes thats right, This is not a bug. But I do get a lot the accumulated files in /tmp. All i am asking is how can I flush them all? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91172] No spelling/auto-correct when creating document via folder context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=91172 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||hughes1...@gmail.com --- Comment #3 from Beluga todven...@suomi24.fi --- *** Bug 91421 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91421] Spell checker seems not to work at all; installation as default mode today.
https://bugs.documentfoundation.org/show_bug.cgi?id=91421 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Beluga todven...@suomi24.fi --- *** This bug has been marked as a duplicate of bug 91172 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92343] New: Cannot insert in find textbox
https://bugs.documentfoundation.org/show_bug.cgi?id=92343 Bug ID: 92343 Summary: Cannot insert in find textbox Product: LibreOffice Version: 4.3.5.2 release Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: meister.fu...@gmail.com When pressing cmd-f to open the little search panel at the bottom, the textbox is focussed and I can enter some text via keyboard. But I cannot cmd-v to insert text copied before. Instead it overwrites the current cell. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/GridLayer.js | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
New commits:
commit 3dffe1ed624657bca5dd93a953c6485d35c5e9e0
Author: Mihai Varga mihai.va...@collabora.com
Date: Fri Jun 26 10:11:57 2015 +0300
This should handle doc resize caused by page deletion
diff --git a/loleaflet/src/layer/tile/GridLayer.js
b/loleaflet/src/layer/tile/GridLayer.js
index 4a8b5a6..64e3054 100644
--- a/loleaflet/src/layer/tile/GridLayer.js
+++ b/loleaflet/src/layer/tile/GridLayer.js
@@ -363,8 +363,8 @@ L.GridLayer = L.Layer.extend({
if (this._docWidthTwips === undefined || this._docHeightTwips
=== undefined) {
return;
}
- var docPixelLimits = new L.Point(this._docWidthTwips /
this._tileWidthTwips,
-
this._docHeightTwips / this._tileHeightTwips);
+ var docPixelLimits = new L.Point(this._docWidthTwips /
this.options.tileWidthTwips,
+
this._docHeightTwips / this.options.tileHeightTwips);
docPixelLimits = docPixelLimits.multiplyBy(this._tileSize);
var topLeft = new L.Point(0, 0);
@@ -377,10 +377,17 @@ L.GridLayer = L.Layer.extend({
this._map.setMaxBounds(new L.LatLngBounds(topLeft,
bottomRight));
}
else if (sizeChanged) {
+ // we just update the bounds without panning into the
new bounds,
+ // the scrollbars should handle that
this._map.options.maxBounds = new
L.LatLngBounds(topLeft, bottomRight);
}
- L.DomUtil.setStyle(this._map._mockDoc, 'width',
docPixelLimits.x + 'px');
- L.DomUtil.setStyle(this._map._mockDoc, 'height',
docPixelLimits.y + 'px');
+
+ var scrollPixelLimits = new L.Point(this._docWidthTwips /
this._tileWidthTwips,
+
this._docHeightTwips / this._tileHeightTwips);
+ scrollPixelLimits =
scrollPixelLimits.multiplyBy(this._tileSize);
+
+ L.DomUtil.setStyle(this._map._mockDoc, 'width',
scrollPixelLimits.x + 'px');
+ L.DomUtil.setStyle(this._map._mockDoc, 'height',
scrollPixelLimits.y + 'px');
},
_updateScrollOffset: function () {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91194] FILESAVE: xlsx doesn't retain spreadsheet dimension information (column characters)
https://bugs.documentfoundation.org/show_bug.cgi?id=91194 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #8 from Beluga todven...@suomi24.fi --- Daniel: can you comment on Carlos's findings? You can set this to NEW, if they match your issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/control/tabletree.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 63384060ec6610ef08af57b981d028c8a177a028
Author: Takeshi Abe t...@fixedpoint.jp
Date: Fri Jun 26 16:18:55 2015 +0900
no need to capture _rTables
Change-Id: I78b4051ffdb625481b238cc3a5313aa4d086b87e
diff --git a/dbaccess/source/ui/control/tabletree.cxx
b/dbaccess/source/ui/control/tabletree.cxx
index feb00aa..61db99b 100644
--- a/dbaccess/source/ui/control/tabletree.cxx
+++ b/dbaccess/source/ui/control/tabletree.cxx
@@ -262,10 +262,10 @@ void OTableTreeListBox::UpdateTableList( const Reference
XConnection _rxConn
{
OUString sRootEntryText;
if ( ::std::none_of(_rTables.begin(),_rTables.end(),
-[_rTables] (TNames::value_type name) { return
!name.second; }) )
+[] (TNames::value_type name) { return
!name.second; }) )
sRootEntryText = ModuleRes(STR_ALL_TABLES);
else if ( ::std::none_of(_rTables.begin(),_rTables.end(),
- [_rTables] (TNames::value_type name) {
return name.second; }) )
+ [] (TNames::value_type name) { return
name.second; }) )
sRootEntryText = ModuleRes(STR_ALL_VIEWS);
else
sRootEntryText = ModuleRes(STR_ALL_TABLES_AND_VIEWS);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - 19 commits - sw/source
sw/source/core/crsr/crsrsh.cxx |4 -
sw/source/core/crsr/viscrs.cxx |2
sw/source/core/doc/notxtfrm.cxx |2
sw/source/core/draw/dpage.cxx|2
sw/source/core/frmedt/fews.cxx |2
sw/source/core/inc/frmtool.hxx |2
sw/source/core/inc/layact.hxx|6 -
sw/source/core/inc/pagefrm.hxx |4 -
sw/source/core/inc/viewimp.hxx | 20 -
sw/source/core/layout/anchoreddrawobject.cxx |4 -
sw/source/core/layout/layact.cxx | 39 +--
sw/source/core/layout/pagechg.cxx|4 -
sw/source/core/layout/paintfrm.cxx | 93 +--
sw/source/core/text/frmform.cxx | 12 +--
sw/source/core/text/inftxt.cxx | 64 --
sw/source/core/text/inftxt.hxx | 49 ++
sw/source/core/text/txtfly.cxx |2
sw/source/core/text/txtfrm.cxx |8 +-
sw/source/core/text/txtftn.cxx |2
sw/source/core/text/txthyph.cxx |3
sw/source/core/unocore/unoflatpara.cxx |2
sw/source/core/view/pagepreviewlayout.cxx|8 +-
sw/source/core/view/viewimp.cxx | 22 +-
sw/source/core/view/viewsh.cxx | 18 ++---
sw/source/core/view/vprint.cxx |2
sw/source/uibase/docvw/PageBreakWin.cxx |2
26 files changed, 198 insertions(+), 180 deletions(-)
New commits:
commit 783361da4efa20422769dcda64c59b615c31c6d6
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Thu Jun 25 17:38:24 2015 +0200
SwTextFormatInfo::SwTextFormatInfo: use vcl::RenderContext
(cherry picked from commit 54106fae68149c0b1dbb4f6ece133fefacacc322)
Conflicts:
sw/source/core/text/frmform.cxx
Change-Id: I8ff1647bdf8c46d395c398c97b97066d7b128cdb
diff --git a/sw/source/core/text/frmform.cxx b/sw/source/core/text/frmform.cxx
index 1434a49..3f91ead 100644
--- a/sw/source/core/text/frmform.cxx
+++ b/sw/source/core/text/frmform.cxx
@@ -504,7 +504,7 @@ com::sun::star::uno::Sequence
::com::sun::star::style::TabStop SwTextFrm::Get
com::sun::star::uno::Sequence ::com::sun::star::style::TabStop tabs(1);
::com::sun::star::style::TabStop ts;
-SwTextFormatInfo aInf( this );
+SwTextFormatInfo aInf( getRootFrm()-GetCurrShell()-GetOut(), this );
SwTextFormatter aLine( this, aInf );
SwTextCursor TextCursor( this, aInf );
const Point aCharPos( TextCursor.GetTopLeft() );
@@ -868,8 +868,8 @@ bool SwTextFrm::CalcPreps()
SWAP_IF_NOT_SWAPPED( this )
-SwTextFormatInfo aInf( this );
-SwTextFormatter aLine( this, aInf );
+SwTextFormatInfo aInf( getRootFrm()-GetCurrShell()-GetOut(),
this );
+SwTextFormatter aLine( this, aInf );
WidowsAndOrphans aFrmBreak( this );
// Whatever the attributes say: we split the paragraph in
@@ -1665,7 +1665,7 @@ void SwTextFrm::_Format( SwParaPortion *pPara )
if ( IsVertical() )
SwapWidthAndHeight();
-SwTextFormatInfo aInf( this );
+SwTextFormatInfo aInf( getRootFrm()-GetCurrShell()-GetOut(), this );
SwTextFormatter aLine( this, aInf );
HideAndShowObjects();
@@ -1892,7 +1892,7 @@ bool SwTextFrm::FormatQuick( bool bForceQuickFormat )
SwFrmSwapper aSwapper( this, true );
TextFrmLockGuard aLock(this);
-SwTextFormatInfo aInf( this, false, true );
+SwTextFormatInfo aInf( getRootFrm()-GetCurrShell()-GetOut(), this,
false, true );
if( 0 != aInf.MaxHyph() ) // Respect MaxHyphen!
return false;
diff --git a/sw/source/core/text/inftxt.cxx b/sw/source/core/text/inftxt.cxx
index 741bef7..ae679c3 100644
--- a/sw/source/core/text/inftxt.cxx
+++ b/sw/source/core/text/inftxt.cxx
@@ -1467,10 +1467,10 @@ void SwTextFormatInfo::Init()
SetPaintOfst(0);
}
-SwTextFormatInfo::SwTextFormatInfo(SwTextFrm *pFrame, const bool bInterHyphL,
+SwTextFormatInfo::SwTextFormatInfo(OutputDevice* pRenderContext, SwTextFrm
*pFrame, const bool bInterHyphL,
const bool bQuickL, const bool bTst)
{
-CtorInitTextFormatInfo(pFrame-getRootFrm()-GetCurrShell()-GetOut(),
pFrame, bInterHyphL, bQuickL, bTst);
+CtorInitTextFormatInfo(pRenderContext, pFrame, bInterHyphL, bQuickL, bTst);
}
/**
diff --git a/sw/source/core/text/inftxt.hxx b/sw/source/core/text/inftxt.hxx
index fc28a0a..9c09bfc 100644
--- a/sw/source/core/text/inftxt.hxx
+++ b/sw/source/core/text/inftxt.hxx
@@ -563,7 +563,7 @@ class SwTextFormatInfo : public SwTextPaintInfo
public:
void CtorInitTextFormatInfo( OutputDevice* pRenderContext, SwTextFrm
*pFrm, const bool bInterHyph = false,
const bool bQuick = false, const bool bTst = false );
-SwTextFormatInfo(SwTextFrm *pFrame, const bool
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf89890.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport.cxx | 23 +++
sw/qa/extras/ooxmlexport/ooxmlexport4.cxx|2 +-
writerfilter/source/dmapper/NumberingManager.cxx | 14 ++
4 files changed, 38 insertions(+), 1 deletion(-)
New commits:
commit eab89b7f024a8c86decdcb3362c40c40a7df37df
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Jun 26 09:02:31 2015 +0200
tdf#89890 DOCX import: fix too large num pic bullet
Reading SwWW8ImplReader::CoreLoad()'s update graphic bullet
information block, it turns out that the numbering picture bullet's
height should be independent from the supplied bitmap, and only its
aspect ratio should be respected.
Change-Id: I1300aa0397a8098df2a3170af795fbba47fd2a9e
Reviewed-on: https://gerrit.libreoffice.org/16500
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
Tested-by: Jenkins c...@libreoffice.org
diff --git a/sw/qa/extras/ooxmlexport/data/tdf89890.docx
b/sw/qa/extras/ooxmlexport/data/tdf89890.docx
new file mode 100644
index 000..8b3e8eb
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf89890.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index fc05887..20be877 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -703,6 +703,29 @@ DECLARE_OOXMLEXPORT_TEST(testTdf79639, tdf79639.docx)
CPPUNIT_ASSERT_EQUAL(static_castsal_Int32(1), xDrawPage-getCount());
}
+DECLARE_OOXMLEXPORT_TEST(testTdf89890, tdf89890.docx)
+{
+// Numbering picture bullet was too large.
+uno::Referencebeans::XPropertySet
xPropertySet(getStyles(NumberingStyles)-getByName(WWNum1), uno::UNO_QUERY);
+uno::Referencecontainer::XIndexAccess
xLevels(xPropertySet-getPropertyValue(NumberingRules), uno::UNO_QUERY);
+uno::Sequencebeans::PropertyValue aProps;
+xLevels-getByIndex(0) = aProps; // 1st level
+
+bool bFound = false;
+for (int i = 0; i aProps.getLength(); ++i)
+{
+const beans::PropertyValue rProp = aProps[i];
+
+if (rProp.Name == GraphicSize)
+{
+// Height of the graphic was too large: 4382 after import, then
2485 after roundtrip.
+CPPUNIT_ASSERT_EQUAL(static_castsal_Int32(279),
rProp.Value.getawt::Size().Height);
+bFound = true;
+}
+}
+CPPUNIT_ASSERT(bFound);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
index cfeea16..f141900 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
@@ -353,7 +353,7 @@ DECLARE_OOXMLEXPORT_TEST(testFDO74215, FDO74215.docx)
xmlDocPtr pXmlDoc = parseExport(word/numbering.xml);
if (!pXmlDoc)
return;
-assertXPath(pXmlDoc, /w:numbering/w:numPicBullet[2]/w:pict/v:shape,
style, width:6.4pt;height:6.4pt);
+assertXPath(pXmlDoc, /w:numbering/w:numPicBullet[2]/w:pict/v:shape,
style, width:7.9pt;height:7.9pt);
}
DECLARE_OOXMLEXPORT_TEST(testColumnBreak_ColumnCountIsZero,fdo74153.docx)
diff --git a/writerfilter/source/dmapper/NumberingManager.cxx
b/writerfilter/source/dmapper/NumberingManager.cxx
index 4d4dae1..8d93fb8 100644
--- a/writerfilter/source/dmapper/NumberingManager.cxx
+++ b/writerfilter/source/dmapper/NumberingManager.cxx
@@ -859,6 +859,20 @@ void ListsManager::lcl_sprm( Sprm rSprm )
case NS_ooxml::LN_CT_NumPicBullet_pict:
{
uno::Referencedrawing::XShape xShape =
m_rDMapper.PopPendingShape();
+
+// Respect only the aspect ratio of the picture, not its size.
+awt::Size aPrefSize = xShape-getSize();
+// See SwDefBulletConfig::InitFont(), default height is 14.
+const int nFontHeight = 14;
+// Point - mm100.
+const int nHeight = nFontHeight * 35;
+if (aPrefSize.Height * aPrefSize.Width != 0)
+{
+int nWidth = (nHeight * aPrefSize.Width) /
aPrefSize.Height;
+awt::Size aSize(nWidth, nHeight);
+xShape-setSize(aSize);
+}
+
m_pCurrentNumPicBullet-SetShape(xShape);
}
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sc/inc sc/source
sc/inc/document.hxx |3 +++
sc/source/core/data/documen2.cxx | 15 +++
sc/source/ui/unoobj/docuno.cxx |2 +-
sc/source/ui/view/gridwin4.cxx |2 +-
4 files changed, 20 insertions(+), 2 deletions(-)
New commits:
commit 44a534ab8706f78dd812a4cf68123963a52035af
Author: Jan Holesovsky ke...@collabora.com
Date: Mon Jun 22 15:47:44 2015 +0200
sc tiled rendering: Set some minimal size of the document.
Let's default to 12x36 cells.
Change-Id: Ic39739ec036a6e5867d31b7e05b6da12ce2e46d2
Reviewed-on: https://gerrit.libreoffice.org/16413
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 7ea90f1..69e6f5b 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1157,6 +1157,9 @@ public:
SCROW rEndRow, bool bNotes = true )
const;
voidInvalidateTableArea();
+/// Return the number of colums / rows that should be visible for the
tiled rendering.
+SC_DLLPUBLIC bool GetTiledRenderingArea(SCTAB nTab, SCCOL
rEndCol, SCROW rEndRow) const;
+
SC_DLLPUBLIC bool GetDataStart( SCTAB nTab, SCCOL rStartCol,
SCROW rStartRow ) const;
/**
diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index eeec6ef..8d3e4e3 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -706,6 +706,21 @@ bool ScDocument::GetDataStart( SCTAB nTab, SCCOL
rStartCol, SCROW rStartRow )
return false;
}
+bool ScDocument::GetTiledRenderingArea(SCTAB nTab, SCCOL rEndCol, SCROW
rEndRow) const
+{
+if (!GetPrintArea(nTab, rEndCol, rEndRow, false))
+return false;
+
+// we need some reasonable minimal document size
+if (rEndCol 12)
+rEndCol = 12;
+
+if (rEndRow 36)
+rEndRow = 36;
+
+return true;
+}
+
bool ScDocument::MoveTab( SCTAB nOldPos, SCTAB nNewPos, ScProgress* pProgress )
{
if (nOldPos == nNewPos)
diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index a195b8a..5375176 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -523,7 +523,7 @@ Size ScModelObj::getDocumentSize()
SCROW nEndRow = 0;
const ScDocument rDoc = pDocShell-GetDocument();
-if (!rDoc.GetPrintArea( nTab, nEndCol, nEndRow, false ))
+if (!rDoc.GetTiledRenderingArea(nTab, nEndCol, nEndRow))
return aSize;
// convert to twips
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 3919ca5..ceaf3d8 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -971,7 +971,7 @@ void ScGridWindow::PaintTile( VirtualDevice rDevice,
SCROW nStartRow = 0, nEndRow = 0;
// size of the document including drawings, charts, etc.
-pDoc-GetPrintArea(nTab, nEndCol, nEndRow, false);
+pDoc-GetTiledRenderingArea(nTab, nEndCol, nEndRow);
double fPPTX = pViewData-GetPPTX();
double fPPTY = pViewData-GetPPTY();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - officecfg/registry
officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu |3 +++ 1 file changed, 3 insertions(+) New commits: commit 2e1d3b58f24d1ab97d9a9172b5125c162fcb5b7f Author: Yousuf Philips philip...@hotmail.com Date: Sat May 30 21:00:39 2015 +0400 Make track changes sidebar an experimental feature as its incomplete Change-Id: If373aa7a7efb338fd7a5305acbd19e95344a4bfc Reviewed-on: https://gerrit.libreoffice.org/15995 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com (cherry picked from commit d5a0cb563bdc538a60938ea421183e4b67c0656f) Reviewed-on: https://gerrit.libreoffice.org/16470 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu index 9a40006..504bf3b 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu @@ -203,6 +203,9 @@ prop oor:name=OrderIndex oor:type=xs:int value600/value /prop +prop oor:name=IsExperimental oor:type=xs:boolean + valuetrue/value +/prop /node node oor:name=DesignDeck oor:op=replace ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92344] New: Database connection Fails with -Options -Location update
https://bugs.documentfoundation.org/show_bug.cgi?id=92344 Bug ID: 92344 Summary: Database connection Fails with -Options -Location update Product: LibreOffice Version: 4.4.2.2 release Hardware: x86 (IA32) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: an...@macspares.co.za I got this error message : SQL Status: HY000 The connection could not be established. The database was created by a newer version of LibreOffice. During building Tables of a New Database I noticed LibeOffice was set to wrong location default, When I changed to My location and language ( from GB to South Africa ) on close and reopen all tables disappeared and the error shows (local Build in ubuntu 15.04 with all connection Ok : northwind.odb works fine ) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 92346] Copy functionality in the viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=92346 --- Comment #1 from Miklos Vajna vmik...@collabora.co.uk --- and it already can do searching. searching - copying -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91361] Batch conversion from XLSX to PDF sometimes stops in error
https://bugs.documentfoundation.org/show_bug.cgi?id=91361 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Summary|LibreOffice stopped working |Batch conversion from XLSX |XLSX to PDF conversion |to PDF sometimes stops in ||error Ever confirmed|1 |0 --- Comment #11 from Cor Nouws c...@nouenoff.nl --- Thanks, then I change the summary. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/qa sw/source
sw/qa/extras/ww8export/data/fdo66304-1.odt |binary
sw/qa/extras/ww8export/ww8export.cxx|5 +++
sw/source/core/doc/DocumentContentOperationsManager.cxx | 25
3 files changed, 30 insertions(+)
New commits:
commit f8bf452949881aecf64a6b68d596489c158dcf77
Author: Caolán McNamara caol...@redhat.com
Date: Wed Jun 24 15:57:03 2015 +0100
crashtesting: fix asserts on exporting fdo66304-1.odt to doc
Change-Id: Ia08207143d27f88d09bd45e64ba7c3c12cd2c1a1
(cherry picked from commit acdf113baf04263a03d574eac9a8c09f98598b7a)
Reviewed-on: https://gerrit.libreoffice.org/16468
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
diff --git a/sw/qa/extras/ww8export/data/fdo66304-1.odt
b/sw/qa/extras/ww8export/data/fdo66304-1.odt
new file mode 100644
index 000..c3fb9bc
Binary files /dev/null and b/sw/qa/extras/ww8export/data/fdo66304-1.odt differ
diff --git a/sw/qa/extras/ww8export/ww8export.cxx
b/sw/qa/extras/ww8export/ww8export.cxx
index 2347fdc..e1626cd 100644
--- a/sw/qa/extras/ww8export/ww8export.cxx
+++ b/sw/qa/extras/ww8export/ww8export.cxx
@@ -529,6 +529,11 @@ DECLARE_WW8EXPORT_TEST(testCommentExport,
comment-export.odt)
}
}
+DECLARE_WW8EXPORT_TEST(testMoveRange, fdo66304-1.odt)
+{
+//the save must survive without asserting
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 06c0c4c..4f1c396 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -1961,8 +1961,33 @@ bool DocumentContentOperationsManager::MoveRange( SwPaM
rPaM, SwPosition rPos,
const std::shared_ptrsw::mark::ContentIdxStore
pContentStore(sw::mark::ContentIdxStore::Create());
pContentStore-Save( m_rDoc, rPos.nNode.GetIndex(),
rPos.nContent.GetIndex(), true );
+SwTextNode * pOrigNode = pTNd;
+assert(*aSavePam.GetPoint() == *aSavePam.GetMark()
+ *aSavePam.GetPoint() == rPos);
+assert(aSavePam.GetPoint()-nContent.GetIdxReg() == pOrigNode);
+assert(aSavePam.GetPoint()-nNode == rPos.nNode.GetIndex());
+assert(rPos.nNode.GetIndex() == pOrigNode-GetIndex());
+
pTNd = pTNd-SplitContentNode( rPos )-GetTextNode();
+//A new node was inserted before the orig pTNd and the content up to
+//rPos moved into it. The old node is returned with the remainder
+//of the content in it.
+//
+//aSavePam was created with rPos, it continues to point to the
+//old node, but with the *original* content index into the node.
+//Seeing as all the orignode content before that index has
+//been removed, the new index into the original node should now be set
+//to 0 and the content index of rPos should also be adapted to the
+//truncated node
+assert(*aSavePam.GetPoint() == *aSavePam.GetMark()
+ *aSavePam.GetPoint() == rPos);
+assert(aSavePam.GetPoint()-nContent.GetIdxReg() == pOrigNode);
+assert(aSavePam.GetPoint()-nNode == rPos.nNode.GetIndex());
+assert(rPos.nNode.GetIndex() == pOrigNode-GetIndex());
+aSavePam.GetPoint()-nContent.Assign(pOrigNode, 0);
+rPos = *aSavePam.GetMark() = *aSavePam.GetPoint();
+
if( !pContentStore-Empty() )
pContentStore-Restore( m_rDoc, rPos.nNode.GetIndex()-1, 0, true
);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88941] Writer/Calc/Draw/Impress lose formatting for justified text when exporting to PDF on OS X builds
https://bugs.documentfoundation.org/show_bug.cgi?id=88941 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||fdb...@neosheffield.co.uk, ||nthieb...@gmail.com Whiteboard|noRepro:4.5.0.0alpha+:Win7 |noRepro:4.5.0.0alpha+:Win7 |noRepro:4.4.0.3:Win7|noRepro:4.4.0.3:Win7 |noRepo:4.4.1.0alpha+:Linux |noRepo:4.4.1.0alpha+:Linux |bibisectRequest |bibisected --- Comment #44 from Matthew Francis fdb...@neosheffield.co.uk --- This seems to have been introduced by the below commit. Adding Cc: to nthieb...@gmail.com; Could you possibly take a look at this one? Thanks commit cd3d26b7edbce67805259a71e4118223e02ebdd4 Author: Norbert Thiebaud nthieb...@gmail.com Date: Fri Jul 18 18:21:12 2014 +0200 vcl consitent use of long for corrdinate most of length in vcl are calculated in 'long' but array of X position tend to be in sal_Int32. As a prep work to be able to support 'double' as the base type of Device Coordinate, harmonize the use of 'long' for non-float coordinate. Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92345] New: Text Flow, paragraph to para and footnotes to para inserting blank page CANNOT save corrections to template
https://bugs.documentfoundation.org/show_bug.cgi?id=92345 Bug ID: 92345 Summary: Text Flow, paragraph to para and footnotes to para inserting blank page CANNOT save corrections to template Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: Other OS: Mac OS X (All) Status: UNCONFIRMED Severity: major Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jungs...@gmail.com page inserting itself after paragraph AND after footnote superscript even followed by a word writer asked Jun 21 '15 jungsoul gravatar image jungsoul 1 A drop-down to the next page or a blank page is inserting itself after a paragraph, as well as after an inserted footnote (the superscript number) even when there is a word in the same sentence inserted after the footnote number in the main text-body. I have read the manual and used Libre Office extensively -- but cannot overcome this problem unless I go through paragraph by paragraph and back-space between and then re-enter the 0.5 indentation each paragraph. AND I have to do the same after a footnote superscript is inserted. THEN the footnote style has a 12-point number in the footnote area itself, and this causes the 10-point font of the footnote message to drop down, often several lines, also shortening the text in the main body of the page above. No matter how many times I correct these annoying blanks, I canNOT prevent them happening again in the same document. FURTHERMORE, I canNOT get the DEFAULT STYLE to change to the ONE I USE! I have searched all these topics and do not find these problems -- ARE THEY BUGS? ONE ANSWER Please verify if there is a page break for the paragraph style. Thanks for the suggestion; here is the result: In order to set TEXT FLOW under Format paragraph, to keep with next paragraph -- I had to select the entire document (more than 200 pages). All the footnotes that occur in the middle of a sentence and therefore mid-paragraph, remained as new paragraphs. All the INSERT manual new page before ALL CHAPTERS then were wiped out. I can't find the way to edit the FOOTNOTE--TEXT BODY interacting style, nor the text within footnote. I HAVE BEEN USING THESE 2 HELP TOPICS -- BUT THESE PROBLEMS ARE SO BAD I CAN ONLY THINK OF IT AS A SERIOUS BUG IN LO, because you canNOT get to the TEMPLATE STYLE you want in the first place to SAVE AS TEMPLATE! The spaces show up only after you've saved your long document, not while you're writing it, so they too would be saved as template. Changing Default Templates When you open a new document with File - New, a blank document appears based on a LibreOffice template. You can edit, modify, or replace this template so that the new document contains your customized Styles or other contents. Modifying Default Templates First, open either an existing LibreOffice template and modify it, or open a new document and edit it as necessary to create the desired template. You can define a document template for each LibreOffice module. The following describes how to proceed for text documents. Save the document by choosing File - Save As Templateand saving the document in the My Templates category. Choose File - New - Templates. Double-click My Templates in the list. You will see the user-defined templates in the user directory specified under LibreOffice - Preferences - LibreOffice - Paths. Select the template you have just saved. Choose Set as default. The next time you open a new text document, the new document will be based on the new default template. Using Custom Templates There are several ways to make your work easier by using your own custom templates. Templates in the Template Folder You can save a new template with File - Save As Template or by selecting Template file type in any Save dialog. Save the template in the user directory specified under LibreOffice - Preferences - LibreOffice - Paths to be able to access the template from within the File - New - Templates dialog. To open the template for editing, choose File - New - Templates, select the template and click the Edit button. Related Topics Templates Changing the Default Template -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49853] EDITING: Attempting paste into find bar with Cmd-V on OS X pastes into document
https://bugs.documentfoundation.org/show_bug.cgi?id=49853 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||meister.fu...@gmail.com --- Comment #101 from Alex Thurgood ipla...@yahoo.co.uk --- *** Bug 92343 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92345] Text Flow, paragraph to para and footnotes to para inserting blank page CANNOT save corrections to template
https://bugs.documentfoundation.org/show_bug.cgi?id=92345 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- @Michell : there appear to be several different problems reported - please open up separate bug reports for each one. Also please provide, step-by-step detailed instructions that result in the repeatable behaviour. It would also be preferable if you could provide a document that displays the incorrect behaviour in the most minimal form possible to show that behaviour. At present, I don't know how to reproduce the problems you are experiencing. Setting to NEEDINFO until requested information is provided, please set back to UNCONFIRMED once you have done so. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92262] PIVOTTABLE: DEBUG BUILDS ONLY: crash when clicking on the autofilter arrow
https://bugs.documentfoundation.org/show_bug.cgi?id=92262 --- Comment #4 from Clément Lassieur clem...@lassieur.org --- (In reply to Julien Nabet from comment #3) First I noticed this: warn:legacy.osl:4339:1:sc/source/core/data/dptabsrc.cxx:2267: unknown property FYI this warning also occurs with commit 2b0be6c (= e8b97a5^), which doesn’t crash. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92346] New: Copy functionality in the viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=92346 Bug ID: 92346 Summary: Copy functionality in the viewer Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Android Viewer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vmik...@collabora.co.uk It would be nice to be able to copy text from the viewed document, just like on the desktop. It's not too hard to implement this today, either. The Android app uses the LibreOfficeKit API to talk to core. gtktiledviewer is a test program to show all the LOK API features implemented in core, and it already can do searching. The gtk app already supports exposting formatted text as HTML, with falling back to plain text if necessary. If it helps, the API also exposes RTF. Code pointers: - desktop/source/lib/lokandroid.cxx, Java_org_libreoffice_kit_Document_getTextSelection() currently that JNI wrapper is missing, has to be implemented. - libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx, doCopy() shows how to get the selection in HTML or plain text from core - android/source/ is the source code for the Java part of the Android app See https://wiki.documentfoundation.org/Development/Android in general on how to get an Android build. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92346] Copy functionality in the viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=92346 Miklos Vajna vmik...@collabora.co.uk changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org Whiteboard||easyHack ||difficultyInteresting ||skillJava topicUI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 92346] Copy functionality in the viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=92346 Miklos Vajna vmik...@collabora.co.uk changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org Whiteboard||easyHack ||difficultyInteresting ||skillJava topicUI -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92346] Copy functionality in the viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=92346 --- Comment #1 from Miklos Vajna vmik...@collabora.co.uk --- and it already can do searching. searching - copying -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92177] Bug Found: Cal Spreadsheet cursor issue: specifically in first row
https://bugs.documentfoundation.org/show_bug.cgi?id=92177 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |DUPLICATE --- Comment #2 from Beluga todven...@suomi24.fi --- *** This bug has been marked as a duplicate of bug 90927 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90927] Cursor shown double and at wrong location after double click into a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=90927 --- Comment #7 from Beluga todven...@suomi24.fi --- *** Bug 92177 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92357] New: Tab type switcher drawn incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=92357 Bug ID: 92357 Summary: Tab type switcher drawn incorrectly Product: LibreOffice Version: 5.0.0.1 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: major Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: meister.fu...@gmail.com Created attachment 116848 -- https://bugs.documentfoundation.org/attachment.cgi?id=116848action=edit look at the circle HI, when I repeatedly click on the tab type switcher in the ruler bar (left top) then it get's drawn incorrectly. Look at the screenshot. If I unfocus the window it's getting drawn correctly again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92282] Freeze when saving file as pptx
https://bugs.documentfoundation.org/show_bug.cgi?id=92282 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #2 from Beluga todven...@suomi24.fi --- Did not freeze. Only thought for a few secs and then was ok. Ubuntu 15.04 64-bit Version: 5.1.0.0.alpha1+ Build ID: 3ecef8cedb215e49237a11607197edc91639bfcd TinderBox: Linux-rpm_deb-x86_64@46-TDF-dbg, Branch:master, Time: 2015-06-20_00:06:19 Locale: en-US (en_US.UTF-8) Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64) Build ID: a51ac4d2bb8c4f1ea1d4ea7569863e2fb6535b02 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-06-22_21:37:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92359] New: UI on OS X looks ugly
https://bugs.documentfoundation.org/show_bug.cgi?id=92359 Bug ID: 92359 Summary: UI on OS X looks ugly Product: LibreOffice Version: 5.0.0.1 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: meister.fu...@gmail.com Created attachment 116850 -- https://bugs.documentfoundation.org/attachment.cgi?id=116850action=edit ugly UI issues. Hi, I really like to use open source software like libreoffice. But it's still so ugly on a Mac. Here some examples (look at the screenshot attached): 1) Why is there such an ugly line? remove the bright one, so it's consistent with the left content window (above the ruler) 2) why is there such a fat border just to collapse the view? Wouldn't it be better to have a little pin at the top right edge of the whole view? And to show it again, everyone knows what a menubar is and to look under View ... 3) Why are all comboboxes, textboxes and dropdown boxes so f*g ugly? Why all the grey stuff in the middle. It looks like you really just put it together in 5 minutes and never touched it again. It must be possible to either draw the grey everywhere or make it transparent? 4) again a very strange bright line, remove it. And the grey one from the status bar is not going to the window edge, but stops in the nowhere. 5) the little icon is not correctly vertically centered. And the right padding should be the same as top and bottom. 6) the vertical alignment of the statusbar text is also not perfect. Could go 1 or 2 pixels up. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/unx
vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
New commits:
commit fbd9069824ae8acd6f83ddac694c56021a2c1cba
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jun 26 15:27:02 2015 +0100
gtk3: fpicker, try removing both locations
Change-Id: I0f10d03c1e4481e8efa765e52b5264071c86a3cf
(cherry picked from commit ce07affe888db8d32315b18c851f860a270631ba)
diff --git a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
index b0b8573..8e6154f 100644
--- a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
@@ -419,29 +419,30 @@ shrinkFilterName( const OUString rFilterName, bool
bAllowNoStar = false )
}
static void
+dialog_remove_buttons(GtkWidget *pActionArea)
+{
+GList *pChildren =
+gtk_container_get_children( GTK_CONTAINER( pActionArea ) );
+
+for( GList *p = pChildren; p; p = p-next )
+gtk_widget_destroy( GTK_WIDGET( p-data ) );
+
+g_list_free( pChildren );
+}
+
+static void
dialog_remove_buttons( GtkDialog *pDialog )
{
g_return_if_fail( GTK_IS_DIALOG( pDialog ) );
-GtkWidget *pActionArea;
-
#if GTK_CHECK_VERSION(3,0,0)
#if GTK_CHECK_VERSION(3,12,0)
-pActionArea = gtk_dialog_get_header_bar(pDialog);
-#else
-pActionArea = gtk_dialog_get_action_area(pDialog);
+dialog_remove_buttons(gtk_dialog_get_header_bar(pDialog));
#endif
+dialog_remove_buttons(gtk_dialog_get_action_area(pDialog));
#else
-pActionArea = pDialog-action_area;
+dialog_remove_buttons(pDialog-action_area);
#endif
-
-GList *pChildren =
-gtk_container_get_children( GTK_CONTAINER( pActionArea ) );
-
-for( GList *p = pChildren; p; p = p-next )
-gtk_widget_destroy( GTK_WIDGET( p-data ) );
-
-g_list_free( pChildren );
}
namespace {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92297] Combobox not visible - Impress animation
https://bugs.documentfoundation.org/show_bug.cgi?id=92297 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #2 from raal r...@post.cz --- Cannot reproduce with Verze: 5.0.0.1 (x64) ID sestavení: 9a0b23dd0ab9652e0965484934309f2d49a7758e Scale 120%, sidebar maximum width, combo-boxes are visible -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92305] VIEWING: Multiple page view does not render properly when scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=92305 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal r...@post.cz --- Created attachment 116844 -- https://bugs.documentfoundation.org/attachment.cgi?id=116844action=edit printscreen I can confirm with Version: 5.1.0.0.alpha1+ Build ID: a7a95af74badcb745bb1c86c7f9a21444ca12c77 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-06-25_09:37:54 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90216] Implement lazy loading of linked images, when pasting from a HTML source
https://bugs.documentfoundation.org/show_bug.cgi?id=90216 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW Summary|slow to paste web page |Implement lazy loading of |contents|linked images, when pasting ||from a HTML source Ever confirmed|0 |1 OS|Linux (All) |All Severity|normal |enhancement --- Comment #5 from Beluga todven...@suomi24.fi --- Summary modified, changed to enhancement + NEW. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx |6 +-
vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx |3 +++
vcl/unx/gtk/fpicker/SalGtkPicker.cxx | 17 ++---
vcl/unx/gtk/fpicker/SalGtkPicker.hxx |1 +
4 files changed, 19 insertions(+), 8 deletions(-)
New commits:
commit 30a5b304f2c1c3d89a2e3b76ac44f2c6376ee65f
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jun 26 16:30:02 2015 +0100
gtk3: gtk_window_set_transient_for on overwrite warning dlg
Change-Id: I91d21e3d1663880de14792ded0a1e079d1a40f09
diff --git a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
index 9936f8c..2731162 100644
--- a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
@@ -918,6 +918,9 @@ sal_Int16 SAL_CALL SalGtkFilePicker::execute() throw(
uno::RuntimeException, std
frame::Desktop::create(m_xContext),
UNO_QUERY_THROW );
+GtkWindow *pParent = RunDialog::GetTransientFor();
+if (pParent)
+gtk_window_set_transient_for(GTK_WINDOW(m_pDialog), pParent);
RunDialog* pRunDialog = new RunDialog(m_pDialog, xToolkit, xDesktop);
uno::Reference awt::XTopWindowListener xLifeCycle(pRunDialog);
while( GTK_RESPONSE_NO == btn )
@@ -1005,7 +1008,8 @@ sal_Int16 SAL_CALL SalGtkFilePicker::execute() throw(
uno::RuntimeException, std
gtk_window_set_title( GTK_WINDOW( dlg ),
OUStringToOString(getResString(FILE_PICKER_TITLE_SAVE ),
RTL_TEXTENCODING_UTF8 ).getStr() );
-
+if (pParent)
+gtk_window_set_transient_for(GTK_WINDOW(dlg),
pParent);
RunDialog* pAnotherDialog = new RunDialog(dlg,
xToolkit, xDesktop);
uno::Reference awt::XTopWindowListener
xAnotherLifeCycle(pAnotherDialog);
btn = pAnotherDialog-run();
diff --git a/vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx
b/vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx
index 3a2fc6c..23efb79 100644
--- a/vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx
@@ -145,6 +145,9 @@ sal_Int16 SAL_CALL SalGtkFolderPicker::execute() throw(
uno::RuntimeException, s
uno::Reference frame::XDesktop xDesktop(
frame::Desktop::create(m_xContext), uno::UNO_QUERY);
+GtkWindow *pParent = RunDialog::GetTransientFor();
+if (pParent)
+gtk_window_set_transient_for(GTK_WINDOW(m_pDialog), pParent);
RunDialog* pRunDialog = new RunDialog(m_pDialog, xToolkit, xDesktop);
uno::Reference awt::XTopWindowListener xLifeCycle(pRunDialog);
gint nStatus = pRunDialog-run();
diff --git a/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
b/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
index 6ada45b..c53a80b 100644
--- a/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
@@ -103,10 +103,7 @@ extern C
}
}
-RunDialog::RunDialog( GtkWidget *pDialog, uno::Reference
awt::XExtendedToolkit rToolkit,
-uno::Reference frame::XDesktop rDesktop ) :
-cppu::WeakComponentImplHelper2 awt::XTopWindowListener,
frame::XTerminateListener ( maLock ),
-mpDialog(pDialog), mxToolkit(rToolkit), mxDesktop(rDesktop)
+GtkWindow* RunDialog::GetTransientFor()
{
GtkWindow *pParent = NULL;
@@ -117,8 +114,15 @@ RunDialog::RunDialog( GtkWidget *pDialog, uno::Reference
awt::XExtendedToolkit
if( pFrame )
pParent = GTK_WINDOW( pFrame-getWindow() );
}
-if (pParent)
-gtk_window_set_transient_for( GTK_WINDOW( mpDialog ), pParent );
+
+return pParent;
+}
+
+RunDialog::RunDialog( GtkWidget *pDialog, uno::Reference
awt::XExtendedToolkit rToolkit,
+uno::Reference frame::XDesktop rDesktop ) :
+cppu::WeakComponentImplHelper2 awt::XTopWindowListener,
frame::XTerminateListener ( maLock ),
+mpDialog(pDialog), mxToolkit(rToolkit), mxDesktop(rDesktop)
+{
}
RunDialog::~RunDialog()
@@ -132,7 +136,6 @@ void SAL_CALL RunDialog::windowOpened( const
::com::sun::star::lang::EventObject
throw (::com::sun::star::uno::RuntimeException, std::exception)
{
SolarMutexGuard g;
-
g_timeout_add_full(G_PRIORITY_HIGH_IDLE, 0,
reinterpret_castGSourceFunc(canceldialog), this, NULL);
}
diff --git a/vcl/unx/gtk/fpicker/SalGtkPicker.hxx
b/vcl/unx/gtk/fpicker/SalGtkPicker.hxx
index 78d810c..dd98b3a 100644
--- a/vcl/unx/gtk/fpicker/SalGtkPicker.hxx
+++ b/vcl/unx/gtk/fpicker/SalGtkPicker.hxx
@@ -115,6 +115,7 @@ public:
virtual ~RunDialog();
gint run();
void cancel();
+static GtkWindow* GetTransientFor();
};
#endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92262] PIVOTTABLE: DEBUG BUILDS ONLY: crash when clicking on the autofilter arrow
https://bugs.documentfoundation.org/show_bug.cgi?id=92262 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Blocks||91310 --- Comment #5 from Julien Nabet serval2...@yahoo.fr --- (In reply to Clément Lassieur from comment #4) (In reply to Julien Nabet from comment #3) First I noticed this: warn:legacy.osl:4339:1:sc/source/core/data/dptabsrc.cxx:2267: unknown property FYI this warning also occurs with commit 2b0be6c (= e8b97a5^), which doesn’t crash. Yep, I noticed it still crashed after having fixed this warning. According to bt, it could be linked to VclPtr -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77431] FILESAVE : Hiding first sheet is not possible in xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=77431 Katarina Behrens (CIB) katarina.behr...@cib.de changed: What|Removed |Added CC||m.due...@web.de --- Comment #6 from Katarina Behrens (CIB) katarina.behr...@cib.de --- *** Bug 92139 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92139] Calc XLSX: First tab reappears although hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=92139 Katarina Behrens (CIB) katarina.behr...@cib.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katarina Behrens (CIB) katarina.behr...@cib.de --- Known issue *** This bug has been marked as a duplicate of bug 77431 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc-tiled-rendering' - 24 commits - config_host.mk.in dbaccess/source download.lst external/libetonyek icon-themes/breeze include/LibreOfficeKit libreo
Rebased ref, commits from common ancestor:
commit 614485f2778476b45706455ed767114bb2a0f112
Author: Pranav Kant pran...@gnome.org
Date: Wed Jun 24 02:02:39 2015 +0530
lokdocview: Handle DELETE key
Change-Id: I58d0c36decf81c812c108458b449402416ebcc2d
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index ca7167b..62f1e61 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -245,6 +245,9 @@ signalKey (GtkWidget* pWidget, GdkEventKey* pEvent)
case GDK_KEY_BackSpace:
nKeyCode = com::sun::star::awt::Key::BACKSPACE;
break;
+case GDK_KEY_Delete:
+nKeyCode = com::sun::star::awt::Key::DELETE;
+break;
case GDK_KEY_Return:
nKeyCode = com::sun::star::awt::Key::RETURN;
break;
commit 2f6b0216649c07f98088d13a938179003c661bfb
Author: Pranav Kant pran...@gnome.org
Date: Tue Jun 23 14:37:09 2015 +0530
tilebuffer: Add timer to measure paintTile() call
Change-Id: I2645863c7445e17d77e2c4e2dc24e22f8685034e
diff --git a/libreofficekit/source/gtk/tilebuffer.cxx
b/libreofficekit/source/gtk/tilebuffer.cxx
index 3f22f98..60aa16f 100644
--- a/libreofficekit/source/gtk/tilebuffer.cxx
+++ b/libreofficekit/source/gtk/tilebuffer.cxx
@@ -91,7 +91,7 @@ Tile TileBuffer::getTile(int x, int y, float aZoom)
aTileRectangle.x = pixelToTwip(nTileSizePixels, aZoom) * y;
aTileRectangle.y = pixelToTwip(nTileSizePixels, aZoom) * x;
-g_info (Rendering (%d, %d), x, y);
+g_test_timer_start();
m_pLOKDocument-pClass-paintTile(m_pLOKDocument,
pBuffer,
nTileSizePixels, nTileSizePixels,
@@ -99,6 +99,9 @@ Tile TileBuffer::getTile(int x, int y, float aZoom)
pixelToTwip(nTileSizePixels, aZoom),
pixelToTwip(nTileSizePixels, aZoom));
+double elapsedTime = g_test_timer_elapsed();
+g_info (Rendered (%d, %d) in %f seconds, x, y, elapsedTime);
+
//create a mapping for it
m_mTiles[index].setPixbuf(pPixBuf);
m_mTiles[index].valid = true;
commit c31e0efbf65191e3e92e84347ec223ce4aa87c21
Author: Pranav Kant pran...@gnome.org
Date: Tue Jun 23 02:58:38 2015 +0530
lokdocview: Remove superfluous *_post_key()
Instead directly let LOKDocView handle the input.
Change-Id: I260a460df23c3e2e5c78d8b363bb864ae5c63dab
diff --git a/include/LibreOfficeKit/LibreOfficeKitGtk.h
b/include/LibreOfficeKit/LibreOfficeKitGtk.h
index 3a1628b..962f9d9 100644
--- a/include/LibreOfficeKit/LibreOfficeKitGtk.h
+++ b/include/LibreOfficeKit/LibreOfficeKitGtk.h
@@ -74,10 +74,6 @@ void lok_doc_view_post_command
(LOKDocView*
const
char* pCommand,
const
char* pArguments);
-/// Posts a keyboard event to LibreOfficeKit.
-void lok_doc_view_post_key
(LOKDocView* pDocView,
-GdkEvent*
pEvent);
-
float lok_doc_view_pixel_to_twip
(LOKDocView* pDocView,
float
fInput);
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index c854288..18815d6 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -191,19 +191,6 @@ static void getVisibleAreaTwips(GdkRectangle* pArea)
#endif
}
-
-/// Handles the key-press-event of the window.
-static gboolean signalKey(GtkWidget* /*pWidget*/, GdkEvent* pEvent, gpointer/*
pData*/)
-{
-LOKDocView* pLOKDocView = LOK_DOC_VIEW(pDocView);
-if (!gtk_widget_get_visible(pFindbar)
bool(lok_doc_view_get_edit(pLOKDocView)))
-{
-lok_doc_view_post_key(pLOKDocView, pEvent);
-return TRUE;
-}
-return FALSE;
-}
-
/// Searches for the next or previous text of pFindbarEntry.
static void doSearch(bool bBackwards)
{
@@ -541,10 +528,6 @@ int main( int argc, char* argv[] )
g_signal_connect(pDocView, part-changed, G_CALLBACK(signalPart), NULL);
g_signal_connect(pDocView, hyperlink-clicked,
G_CALLBACK(signalHyperlink), NULL);
-// Input handling.
-g_signal_connect(pWindow, key-press-event, G_CALLBACK(signalKey),
pDocView);
-g_signal_connect(pWindow, key-release-event, G_CALLBACK(signalKey),
pDocView);
-
// Scrolled window for DocView
pScrolledWindow = gtk_scrolled_window_new(0, 0);
gtk_widget_set_hexpand (pScrolledWindow, TRUE);
@@ -568,6 +551,11 @@ int main( int argc, char* argv[] )
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - RepositoryExternal.mk
RepositoryExternal.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6c7e8938e4458eff85e1b6710a537e950fc32cb2 Author: David Tardon dtar...@redhat.com Date: Wed Jun 24 15:08:48 2015 +0200 mdds is header-only Change-Id: I27e5ae913474001154fa6352a3ccefaee16e309c (cherry picked from commit 7fffbdc4c21f2c21d062a2f224b42e4b87beb6f0) Reviewed-on: https://gerrit.libreoffice.org/16504 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Michael Stahl mst...@redhat.com diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index 47e4d17..1d7b09c 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -132,7 +132,7 @@ endef else # !SYSTEM_MDDS define gb_ExternalProject__use_mdds_headers -$(call gb_ExternalProject_use_external_project,$(1),mdds) +$(call gb_ExternalProject_use_unpacked,$(1),mdds) endef ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/marker/Cursor.js |1 +
loleaflet/src/layer/tile/TileLayer.js |3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit bee60c69e89de101f916acea01e5797380c49a81
Author: Mihai Varga mihai.va...@collabora.com
Date: Fri Jun 26 14:34:18 2015 +0300
Move the cursor to the left by half its size
diff --git a/loleaflet/src/layer/marker/Cursor.js
b/loleaflet/src/layer/marker/Cursor.js
index 9c5b4f8..648f543 100644
--- a/loleaflet/src/layer/marker/Cursor.js
+++ b/loleaflet/src/layer/marker/Cursor.js
@@ -86,6 +86,7 @@ L.Cursor = L.Layer.extend({
setSize: function (size) {
this._container.style.lineHeight = size.y + 'px';
this._span.style.fontSize = size.y - 2 + 'px';
+ this._container.style.left = '-' +
this._container.clientWidth/2 + 'px';
}
});
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index 15b2d8b..d46617d 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -797,8 +797,7 @@ L.TileLayer = L.GridLayer.extend({
var pixBounds =
L.bounds(this._map.latLngToLayerPoint(this._visibleCursor.getSouthWest()),
this._map.latLngToLayerPoint(this._visibleCursor.getNorthEast()));
- var latBounds =
L.rectangle(this._visibleCursor).getLatLngs();
- this._cursorMarker = L.cursor(latBounds[2], {color:
'red'});
+ this._cursorMarker =
L.cursor(this._visibleCursor.getNorthWest());
this._map._bDisableKeyboard = true;
this._map.addLayer(this._cursorMarker);
this._cursorMarker.setSize(pixBounds.getSize());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - solenv/gbuild
solenv/gbuild/ExternalProject.mk | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) New commits: commit 975a62b4caa5fa1308ef300c549d45f5ffd4c455 Author: David Tardon dtar...@redhat.com Date: Wed Jun 24 15:08:16 2015 +0200 restore gb_ExternalProject_use_unpacked, with diff. purpose Change-Id: I7d7cbe85219615f80069155a954f917781bc5b71 (cherry picked from commit 3f040ce5ef691c1f93eb788eb67f3de8d772f07a) Reviewed-on: https://gerrit.libreoffice.org/16503 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Michael Stahl mst...@redhat.com diff --git a/solenv/gbuild/ExternalProject.mk b/solenv/gbuild/ExternalProject.mk index 59fc678..92bb7df 100644 --- a/solenv/gbuild/ExternalProject.mk +++ b/solenv/gbuild/ExternalProject.mk @@ -86,9 +86,15 @@ $(call gb_Helper_make_userfriendly_targets,$(1),ExternalProject) endef -# replaced by second parameter to ctor +# Depend on an unpacked tarball +# +# This is needed to express dependencies on header-only projects, which +# do not have any ExternalProject. +# +# gb_ExternalProject_use_unpacked project unpacked define gb_ExternalProject_use_unpacked -$(call gb_Output_error,gb_ExternalProject_use_unpacked was removed) +$(call gb_ExternalProject_get_preparation_target,$(1)) : $(call gb_UnpackedTarball_get_target,$(2)) + endef # Register a target in state directory ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - download.lst external/libetonyek
download.lst |4
external/libetonyek/0001-add-missing-breaks.patch.1 | 36
external/libetonyek/0001-add-missing-include.patch.1 | 25
external/libetonyek/0001-missing-include.patch.1 | 25
external/libetonyek/0001-try-to-fix-build-on-Windows.patch.1 | 45
external/libetonyek/0002-remove-surplus-breaks.patch.1 | 38
external/libetonyek/ExternalProject_libetonyek.mk|3
external/libetonyek/Library_etonyek.mk | 30
external/libetonyek/UnpackedTarball_libetonyek.mk|5
external/libetonyek/assert.patch | 11
external/libetonyek/generated/IWORKToken.inc | 721 ---
external/libetonyek/generated/KEY1Token.inc | 540
external/libetonyek/generated/KEY2Token.inc | 216 ---
external/libetonyek/generated/NUM1Token.inc | 147 --
external/libetonyek/generated/NUMToken.inc | 146 --
external/libetonyek/generated/PAG1Token.inc | 158 --
external/libetonyek/generated/PAGToken.inc | 158 --
external/libetonyek/ubsan.patch | 20
18 files changed, 114 insertions(+), 2214 deletions(-)
New commits:
commit 60e38140db23ce714b172f8e60d71da4e4c495e5
Author: David Tardon dtar...@redhat.com
Date: Tue Jun 2 17:49:48 2015 +0200
upload libetonyek 0.1.3
(cherry picked from commit ee3d40b30816a8fc6d4e8f984659c8dfac19ec3b)
Change-Id: I451f02ee93a798c9c1712082d59a7ff96b0d4a4e
Reviewed-on: https://gerrit.libreoffice.org/16508
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/download.lst b/download.lst
index 78b12c2..0896f3e 100644
--- a/download.lst
+++ b/download.lst
@@ -34,8 +34,8 @@ export DBGHELP_DLL :=
13fbc2e8b37ddf28181dd6d8081c2b8e-dbghelp.dll
export EBOOK_MD5SUM := 6b48eda57914e6343efebc9381027b78
export EBOOK_TARBALL := libe-book-0.1.2.tar.bz2
export EPM_TARBALL := 3ade8cfe7e59ca8e65052644fed9fca4-epm-3.7.tar.gz
-export ETONYEK_MD5SUM := 1704a75df7621d8073b921f8b6506951
-export ETONYEK_VERSION_MICRO := 2
+export ETONYEK_MD5SUM := e5947373dd7834f27e93f1636faa419f
+export ETONYEK_VERSION_MICRO := 3
export ETONYEK_TARBALL := libetonyek-0.1.$(ETONYEK_VERSION_MICRO).tar.bz2
export EXPAT_TARBALL := dd7dab7a5fea97d2a6a43f511449b7cd-expat-2.1.0.tar.gz
export FIREBIRD_MD5SUM := 21154d2004e025c8a325b0357bb5
diff --git a/external/libetonyek/0001-add-missing-breaks.patch.1
b/external/libetonyek/0001-add-missing-breaks.patch.1
deleted file mode 100644
index 7e11682..000
--- a/external/libetonyek/0001-add-missing-breaks.patch.1
+++ /dev/null
@@ -1,36 +0,0 @@
-From 54c63c653deb070c49621bea8acbc18f76118238 Mon Sep 17 00:00:00 2001
-From: David Tardon dtar...@redhat.com
-Date: Tue, 26 May 2015 16:56:56 +0200
-Subject: [PATCH 1/2] add missing breaks
-
-Change-Id: I6a6afd517e61aff89319348de5af3aa97093bd1d
- src/lib/KEY2Parser.cpp | 3 +++
- 1 file changed, 3 insertions(+)
-
-diff --git a/src/lib/KEY2Parser.cpp b/src/lib/KEY2Parser.cpp
-index bb58efd..4ba70d2 100644
a/src/lib/KEY2Parser.cpp
-+++ b/src/lib/KEY2Parser.cpp
-@@ -261,8 +261,10 @@ void PointElement::attribute(const int name, const char
*const value)
- {
- case IWORKToken::NS_URI_SFA | IWORKToken::x :
- m_point.first = lexical_castdouble(value);
-+break;
- case IWORKToken::NS_URI_SFA | IWORKToken::y :
- m_point.second = lexical_castdouble(value);
-+break;
- }
- }
-
-@@ -358,6 +360,7 @@ void PointPathElement::attribute(const int name, const
char *const value)
- ETONYEK_DEBUG_MSG((unknown point path type: %s\n, value));
- break;
- }
-+break;
- }
- default :
- KEY2XMLElementContextBase::attribute(name, value);
---
-2.4.1
-
diff --git a/external/libetonyek/0001-add-missing-include.patch.1
b/external/libetonyek/0001-add-missing-include.patch.1
new file mode 100644
index 000..9c80674
--- /dev/null
+++ b/external/libetonyek/0001-add-missing-include.patch.1
@@ -0,0 +1,25 @@
+From 00f7e36ce2a3996ebef672561014ab101eee7f3a Mon Sep 17 00:00:00 2001
+From: David Tardon dtar...@redhat.com
+Date: Thu, 25 Jun 2015 12:00:49 +0200
+Subject: [PATCH] add missing include
+
+Change-Id: I8bfcacb064b3d0f9d7d5db9d2f32108b0ceea792
+---
+ src/lib/IWORKTypes_fwd.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/lib/IWORKTypes_fwd.h b/src/lib/IWORKTypes_fwd.h
+index f7a4fb2..1096df8 100644
+--- a/src/lib/IWORKTypes_fwd.h
b/src/lib/IWORKTypes_fwd.h
+@@ -9,6 +9,7 @@
+ #ifndef IWORKTYPES_FWD_H_INCLUDED
+ #define IWORKTYPES_FWD_H_INCLUDED
+
++#include deque
+ #include string
+
+ #include boost/shared_ptr.hpp
+--
+2.4.2
+
diff --git a/external/libetonyek/0001-missing-include.patch.1
b/external/libetonyek/0001-missing-include.patch.1
deleted file mode 100644
index
[Libreoffice-commits] core.git: pyuno/source
pyuno/source/module/pyuno_iterator.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e29a7ff18771eea77b385efc517baa6204df37f9 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jun 26 14:04:43 2015 +0200 loplugin:salbool Change-Id: I9975a87f6df2b7a79c376130864e9eb54bc3452b diff --git a/pyuno/source/module/pyuno_iterator.cxx b/pyuno/source/module/pyuno_iterator.cxx index f9dd8d0..9fa7971 100644 --- a/pyuno/source/module/pyuno_iterator.cxx +++ b/pyuno/source/module/pyuno_iterator.cxx @@ -63,7 +63,7 @@ PyObject* PyUNO_iterator_next( PyObject *self ) PyUNO_iterator* me = reinterpret_castPyUNO_iterator*(self); Runtime runtime; -sal_Bool hasMoreElements = sal_False; +bool hasMoreElements = false; Any aRet; try ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92254] When the focus is in Notes pane, the highlight on current slide vanishes from the Slides pane.
https://bugs.documentfoundation.org/show_bug.cgi?id=92254 Beluga todven...@suomi24.fi changed: What|Removed |Added Attachment #116731|application/x-download |application/pdf mime type|| CC||todven...@suomi24.fi -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/address.cxx | 46
1 file changed, 42 insertions(+), 4 deletions(-)
New commits:
commit 0c8778ce1df92ca3bc2a8dd2f64568fb257e9e39
Author: Eike Rathke er...@redhat.com
Date: Fri Jun 26 15:12:46 2015 +0200
tdf#44419 allow A:A and 1:1 references also in Calc A1 and ODF syntax
They still get displayed as A1:A1048576 and A1:AMJ1 but are accepted as
input.
Change-Id: I6a44ce56767695af874e9f5122501a4c7925b0d6
diff --git a/sc/source/core/tool/address.cxx b/sc/source/core/tool/address.cxx
index 18087a4..dbcfb15 100644
--- a/sc/source/core/tool/address.cxx
+++ b/sc/source/core/tool/address.cxx
@@ -1031,14 +1031,21 @@ static sal_uInt16 lcl_ScRange_Parse_XL_A1( ScRange r,
/**
@param ppointer to null-terminated sal_Unicode string
+@param rRawRes returns SCA_... flags without the final check for full
+validity that is applied to the return value, with which
+two addresses that form a column or row singleton range,
+e.g. A:A or 1:1, can be detected. Used in
+lcl_ScRange_Parse_OOo().
@param pRange pointer to range where rAddr effectively is *pRange-aEnd,
used in conjunction with pExtInfo to determine the tab span
of a 3D reference.
*/
static sal_uInt16 lcl_ScAddress_Parse_OOo( const sal_Unicode* p, ScDocument*
pDoc, ScAddress rAddr,
+ sal_uInt16 rRawRes,
ScAddress::ExternalInfo* pExtInfo =
NULL, ScRange* pRange = NULL )
{
sal_uInt16 nRes = 0;
+rRawRes = 0;
OUString aDocName; // the pure Document Name
OUString aTab;
boolbExtDoc = false;
@@ -1263,6 +1270,8 @@ static sal_uInt16 lcl_ScAddress_Parse_OOo( const
sal_Unicode* p, ScDocument* pDo
}
}
+rRawRes |= nRes;
+
if ( !(nRes SCA_VALID_ROW) (nRes SCA_VALID_COL)
!( (nRes SCA_TAB_3D) (nRes SCA_VALID_TAB)) )
{ // no Row, no Tab, but Col = DM (...), B (...) et al
@@ -1309,7 +1318,8 @@ static sal_uInt16 lcl_ScAddress_Parse ( const
sal_Unicode* p, ScDocument* pDoc,
default :
case formula::FormulaGrammar::CONV_OOO:
{
-return lcl_ScAddress_Parse_OOo( p, pDoc, rAddr, pExtInfo, NULL );
+sal_uInt16 nRawRes = 0;
+return lcl_ScAddress_Parse_OOo( p, pDoc, rAddr, nRawRes, pExtInfo,
NULL );
}
}
}
@@ -1460,10 +1470,35 @@ static sal_uInt16 lcl_ScRange_Parse_OOo( ScRange
rRange,
OUStringBuffer aTmp(r);
aTmp[nPos] = 0;
const sal_Unicode* p = aTmp.getStr();
-if( (nRes1 = lcl_ScAddress_Parse_OOo( p, pDoc, rRange.aStart,
pExtInfo, NULL ) ) != 0 )
+sal_uInt16 nRawRes1 = 0;
+if (((nRes1 = lcl_ScAddress_Parse_OOo( p, pDoc, rRange.aStart,
nRawRes1, pExtInfo, NULL)) != 0) ||
+((nRawRes1 (SCA_VALID_COL | SCA_VALID_ROW)) (nRawRes1
SCA_VALID_TAB)))
{
rRange.aEnd = rRange.aStart; // sheet must be initialized
identical to first sheet
-if ( (nRes2 = lcl_ScAddress_Parse_OOo( p + nPos+ 1, pDoc,
rRange.aEnd, pExtInfo, rRange ) ) != 0 )
+sal_uInt16 nRawRes2 = 0;
+nRes2 = lcl_ScAddress_Parse_OOo( p + nPos+ 1, pDoc, rRange.aEnd,
nRawRes2, pExtInfo, rRange);
+if (!((nRes1 SCA_VALID) (nRes2 SCA_VALID))
+// If not fully valid addresses, check if both have a valid
+// column or row, and both have valid (or omitted) sheet
references.
+(nRawRes1 (SCA_VALID_COL | SCA_VALID_ROW)) (nRawRes1
SCA_VALID_TAB)
+(nRawRes2 (SCA_VALID_COL | SCA_VALID_ROW)) (nRawRes2
SCA_VALID_TAB)
+// Both must be column XOR row references, A:A or 1:1 but
not A:1 or 1:A
+((nRawRes1 (SCA_VALID_COL | SCA_VALID_ROW)) == (nRawRes2
(SCA_VALID_COL | SCA_VALID_ROW
+{
+nRes1 = nRawRes1 | SCA_VALID;
+nRes2 = nRawRes2 | SCA_VALID;
+if (nRawRes1 SCA_VALID_COL)
+{
+rRange.aStart.SetRow(0);
+rRange.aEnd.SetRow(MAXROW);
+}
+else
+{
+rRange.aStart.SetCol(0);
+rRange.aEnd.SetCol(MAXCOL);
+}
+}
+if (nRes1 nRes2)
{
// PutInOrder / Justify
sal_uInt16 nMask, nBits1, nBits2;
@@ -1503,7 +1538,10 @@ static sal_uInt16 lcl_ScRange_Parse_OOo( ScRange rRange,
nRes2 |= SCA_TAB_ABSOLUTE;
}
else
-nRes1 = 0; // keine Tokens aus halben Sachen
+{
+// Don't leave around valid half references.
+nRes1 =
[Libreoffice-ux-advise] [Bug 92317] Sidebar size is not constrained by its content
https://bugs.documentfoundation.org/show_bug.cgi?id=92317 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||vstuart.fo...@utsa.edu See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=90 ||374 Blocks|90374 |65138 Ever confirmed|0 |1 --- Comment #3 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to Heiko Tietze from comment #2) The sidebar content must not get cropped on resizing. Why? Therefore it has a minimum width that fit its content. Or at least it should... Not at all, the dialog/pane widget for the Sidebar Deck simply expands open or closed, and widgets for the objects in each Content Panel respond according to their packing. Shrinking hides widgets until reaching a minimum width--before the deck collapses--which is the minimum that fully displays a full button object. That minimum changes depending on the widgets exposed on each content panel. Alternative solutions are wrapping controls or to show a chevron like at the toolbar. UX should discuss the pro and cons... Or, provide a scroll bar for a pane calculated against the full packing of button objects for all Content Panels occupying the full Deck. Or, provide a scroll bar for each individual Content Panel (but that would add visual clutter) Or, complete work needed to provide stateful customization of the sidebar--start with reasonable defaults, and then allow user to set their preferred Deck exposure for working in documents with _each_ module. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92317] Sidebar size is not constrained by its content
https://bugs.documentfoundation.org/show_bug.cgi?id=92317 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||vstuart.fo...@utsa.edu See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=90 ||374 Blocks|90374 |65138 Ever confirmed|0 |1 --- Comment #3 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to Heiko Tietze from comment #2) The sidebar content must not get cropped on resizing. Why? Therefore it has a minimum width that fit its content. Or at least it should... Not at all, the dialog/pane widget for the Sidebar Deck simply expands open or closed, and widgets for the objects in each Content Panel respond according to their packing. Shrinking hides widgets until reaching a minimum width--before the deck collapses--which is the minimum that fully displays a full button object. That minimum changes depending on the widgets exposed on each content panel. Alternative solutions are wrapping controls or to show a chevron like at the toolbar. UX should discuss the pro and cons... Or, provide a scroll bar for a pane calculated against the full packing of button objects for all Content Panels occupying the full Deck. Or, provide a scroll bar for each individual Content Panel (but that would add visual clutter) Or, complete work needed to provide stateful customization of the sidebar--start with reasonable defaults, and then allow user to set their preferred Deck exposure for working in documents with _each_ module. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 90374] SIDEBAR: Having the sidebar with a fixed width across all tabs
https://bugs.documentfoundation.org/show_bug.cgi?id=90374 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on|92317 | See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||317 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 90374] SIDEBAR: Having the sidebar with a fixed width across all tabs
https://bugs.documentfoundation.org/show_bug.cgi?id=90374 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on|92317 | See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||317 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=65138 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||92317 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92352] New: Paragraph style is lost when dealing with direct formatting copied from DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=92352 Bug ID: 92352 Summary: Paragraph style is lost when dealing with direct formatting copied from DOCX Product: LibreOffice Version: 3.5.4 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stanislav.hora...@gmail.com Created attachment 116843 -- https://bugs.documentfoundation.org/attachment.cgi?id=116843action=edit DOCX for bug demonstration Under certain conditions (probably depending on import from DOCX and on direct formatting), paragraph style is lost after reopening a file. I face this bug quite often when processing files sent by MS Office users. Steps to reproduce: 1. Open the attached file sample.docx. (It contains two lines of Normal (web) style, however heading is formatted directly.) 2. Copy all content of the file (Ctrl+A, Ctrl+C). 3. Create a new file and paste the content to it (Ctrl+N, Ctrl+V). 4. Apply styles (of the default LO template) to the content: Default Style to the second line, Heading (not Heading 1 etc.) to the first line. The first line is still directly formatted and does not look like Heading. 5. Remove all direct formatting (Ctrl+A, Ctrl+M). The first line looks now as expected. 6. Save the file as ODT file. 7. Close the file and reopen it. Observed: The first line has Default Style set. Expected: The first line should have Heading style. Experienced in all versions I've tested, clean user profile applied: Ubuntu 14.10: 4.3.7.2, 4.4.4.3, 5.0.0.1 Windows 7: 4.4.3.2 to 3.5.4.2 (the earliest I have, bug probably inherited from OOo) Interesting change in 5.0: in step 4, applying the style on the first line removes direct formatting (contrary to earlier versions), so there is no need to remove them manually. However, after doing that, the bug still occurs. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91824] remove sidebar configuration icon and menu items to view sidebar menu entry
https://bugs.documentfoundation.org/show_bug.cgi?id=91824 --- Comment #9 from V Stuart Foote vstuart.fo...@utsa.edu --- You all are missing the point. The Sidebar is an adjunct GUI to Toolbars. With introduction of a SDK for flexible manipulation of Sidebar's layout and function (customizations and extensions)--the Sidebar will become a more relevant GUI option. As Jay observes, by HIG it does need to be fully exposed in Menu. But neutering customization of the GUI now just because it lacks function currently is not rational. When Andre Fischer took on tasks of integrating the Symphony Property panel expanding the OOo Task pane it was clear that rather than a static GUI, the new Sidebar was intended to be a dynamic framework. https://blogs.apache.org/OOo/entry/the_sidebar_new_and_improved LibreOffice has moved it forward considerably with .UI GTK stacking based organization of the GUI--but the flexible nature of the Sidebar to the GUI remains. Laurent Godard's work on bug 91806 -- Create a Sidebar UNO API, gets us further along in support for dynamic reconfiguration and addition by extension to the Sidebar. Before proposing these endless tweaks to the UI, consider the full potential of a fully implemented Sidebar--in that case Customization will very much be needed. Please, leave it be for now and allow the development to catch up. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92356] New: Insert Special Character - Regression
https://bugs.documentfoundation.org/show_bug.cgi?id=92356 Bug ID: 92356 Summary: Insert Special Character - Regression Product: LibreOffice Version: 5.0.0.1 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fobe...@enteract.com I'm using LibreOffice Version: 5.0.0.1; Build ID: 9a0b23dd0ab9652e0965484934309f2d49a7758e; Locale: en-US (en_US.UTF-8) running on 64 bit Ubuntu 14.04 LTS. When selecting the Insert Special Character menu item, the dialog correctly shows the name of the font in the Font: box, and the Subset choice seems to match the availability of scripts in whatever font is chosen, but the characters that are displayed are all from the same font (I believe it is my system font) regardless of whatever font is selected, and regardless of the script or font, the characters are all incorrect. Thus, if I choose a character from some other script, the result is that an upper ASCII (Latin) character is both displayed and entered into the document. At first I suspected I might have downloaded a 32 bit version by mistake, but I confirmed that I used LibreOffice_5.0.0.1_Linux_x86-64_deb.tar.gz and that this resulted in a LibreOffice_5.0.0.1_Linux_x86-64_deb directory. This may be specific to Ubuntu, as another 'quirk' I noticed was that if I use the Ctrl+Shift+u command to confirm that direct entry of Unicode characters was still possible, the underlined u that usually appears doesn't. This still works, so the characters can be entered - the user feedback (the underlined 'u' is sort of a prompt) provided by the OS is hidden by the new release of LibreOffice. Luckily I still had LibreOfficeDev 4.4 installed which I used to confirm that - as least as far as this Insert Special Character behavior is concerned - still works just fine. So while the bug (?) may be related to Ubuntu, I've never encountered it in previous versions of Writer. Luckily some new default icons (Breeze) have been introduced to make up for the loss of the ability to insert special characters. Even so, Properties and Design inexplicably use the same icon, so I returned to the Tango set. Sigh ... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92179] While moving from one block to another we can see the cursor hovering in the previous block (specifically in first row)
https://bugs.documentfoundation.org/show_bug.cgi?id=92179 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Beluga todven...@suomi24.fi --- *** This bug has been marked as a duplicate of bug 90927 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/compiler.cxx | 88 ---
1 file changed, 65 insertions(+), 23 deletions(-)
New commits:
commit eeea41e2e726dd5d69cd323909e1666efb9de472
Author: Eike Rathke er...@redhat.com
Date: Fri Jun 26 17:43:36 2015 +0200
tdf#44419 display entire column/row references as A:A/1:1
... if both anchors of the other axis are absolute. Now that we can
parse them as of commit 0c8778ce1df92ca3bc2a8dd2f64568fb257e9e39 (and
follow-up 4091b4fbdce40262eba46ab94653287b1fd928e8).
Change-Id: Ie67127fe2d7546e7e598ee1a4d89133c0862
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 9d0a03a..9251731 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -762,12 +762,25 @@ struct ConventionOOO_A1 : public Convention_A1
rBuf.append('.');
}
+enum SingletonDisplay
+{
+SINGLETON_NONE,
+SINGLETON_COL,
+SINGLETON_ROW
+};
+
static void MakeOneRefStrImpl(
OUStringBuffer rBuffer,
const OUString rErrRef, const std::vectorOUString rTabNames,
const ScSingleRefData rRef, const ScAddress rAbsRef,
-bool bForceTab, bool bODF )
+bool bForceTab, bool bODF, SingletonDisplay eSingletonDisplay )
{
+// For ODF override singleton so earlier releases still can read what
+// we write now as of 2015-06-26.
+/* TODO: we may want to change that in future in a few releases. */
+if (bODF)
+eSingletonDisplay = SINGLETON_NONE;
+
if( rRef.IsFlag3D() || bForceTab )
{
if (!ValidTab(rAbsRef.Tab()) || rRef.IsTabDeleted())
@@ -786,18 +799,45 @@ struct ConventionOOO_A1 : public Convention_A1
}
else if (bODF)
rBuffer.append('.');
-if (!rRef.IsColRel())
-rBuffer.append('$');
-if (!ValidCol(rAbsRef.Col()) || rRef.IsColDeleted())
-rBuffer.append(rErrRef);
-else
-MakeColStr(rBuffer, rAbsRef.Col());
-if (!rRef.IsRowRel())
-rBuffer.append('$');
-if (!ValidRow(rAbsRef.Row()) || rRef.IsRowDeleted())
-rBuffer.append(rErrRef);
-else
-MakeRowStr(rBuffer, rAbsRef.Row());
+
+if (eSingletonDisplay != SINGLETON_ROW)
+{
+if (!rRef.IsColRel())
+rBuffer.append('$');
+if (!ValidCol(rAbsRef.Col()) || rRef.IsColDeleted())
+rBuffer.append(rErrRef);
+else
+MakeColStr(rBuffer, rAbsRef.Col());
+}
+
+if (eSingletonDisplay != SINGLETON_COL)
+{
+if (!rRef.IsRowRel())
+rBuffer.append('$');
+if (!ValidRow(rAbsRef.Row()) || rRef.IsRowDeleted())
+rBuffer.append(rErrRef);
+else
+MakeRowStr(rBuffer, rAbsRef.Row());
+}
+}
+
+static SingletonDisplay getSingletonDisplay( const ScAddress rAbs1, const
ScAddress rAbs2,
+const ScComplexRefData rRef )
+{
+// If any part is error, display as such.
+if (!ValidCol(rAbs1.Col()) || rRef.Ref1.IsColDeleted() ||
!ValidRow(rAbs1.Row()) || rRef.Ref1.IsRowDeleted() ||
+!ValidCol(rAbs2.Col()) || rRef.Ref2.IsColDeleted() ||
!ValidRow(rAbs2.Row()) || rRef.Ref2.IsRowDeleted())
+return SINGLETON_NONE;
+
+// A:A or $A:$A or A:$A or $A:A, both row anchors must be absolute.
+if (rAbs1.Row() == 0 rAbs2.Row() == MAXROW !rRef.Ref1.IsRowRel()
!rRef.Ref2.IsRowRel())
+return SINGLETON_COL;
+
+// 1:1 or $1:$1 or 1:$1 or $1:1, both column anchors must be absolute.
+if (rAbs1.Col() == 0 rAbs2.Col() == MAXCOL !rRef.Ref1.IsColRel()
!rRef.Ref2.IsColRel())
+return SINGLETON_ROW;
+
+return SINGLETON_NONE;
}
virtual void makeRefStr( OUStringBuffer rBuffer,
@@ -808,18 +848,19 @@ struct ConventionOOO_A1 : public Convention_A1
bool bSingleRef,
bool /*bFromRangeName*/ ) const SAL_OVERRIDE
{
-ScComplexRefData aRef( rRef );
// In case absolute/relative positions weren't separately available:
// transform relative to absolute!
-ScAddress aAbs1 = aRef.Ref1.toAbs(rPos), aAbs2;
+ScAddress aAbs1 = rRef.Ref1.toAbs(rPos), aAbs2;
if( !bSingleRef )
-aAbs2 = aRef.Ref2.toAbs(rPos);
+aAbs2 = rRef.Ref2.toAbs(rPos);
-MakeOneRefStrImpl(rBuffer, rErrRef, rTabNames, aRef.Ref1, aAbs1,
false, false);
+SingletonDisplay eSingleton = bSingleRef ? SINGLETON_NONE :
getSingletonDisplay( aAbs1, aAbs2, rRef);
+MakeOneRefStrImpl(rBuffer, rErrRef, rTabNames, rRef.Ref1, aAbs1,
false, false, eSingleton);
if (!bSingleRef)
{
rBuffer.append(':');
-MakeOneRefStrImpl(rBuffer, rErrRef, rTabNames,
[Libreoffice-bugs] [Bug 90927] Cursor shown double and at wrong location after double click into a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=90927 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||dineshamarth...@gmail.com --- Comment #6 from Beluga todven...@suomi24.fi --- *** Bug 92179 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92284] Bad Allocation error problem in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=92284 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #3 from Beluga todven...@suomi24.fi --- Please try, if updating to LibreOffice 4.4 has any effect. If the crash occurs in 4.4, too, you could get a backtrace: https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg I'm assuming you can't share the presentation publicly. It would be great for testing, if you could, though :) Set to NEEDINFO. Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED WORKSFORME, if the problem went away. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/dist loleaflet/src
loleaflet/dist/leaflet.css|1 -
loleaflet/src/layer/tile/TileLayer.js | 14 +++---
loleaflet/src/map/Map.js |2 +-
loleaflet/src/map/handler/Map.Keyboard.js |8
4 files changed, 12 insertions(+), 13 deletions(-)
New commits:
commit 9a3e71bad8a415d026547d6650a0736a4538a2ec
Author: Mihai Varga mihai.va...@collabora.com
Date: Fri Jun 26 19:20:21 2015 +0300
Keyboard input is handled in a hidden textarea
We now have a hidden text area where the user's input actually goes,
but it also fires events that are caught by leaflet and are sent
to the server
diff --git a/loleaflet/dist/leaflet.css b/loleaflet/dist/leaflet.css
index 3c03665..25038ee 100644
--- a/loleaflet/dist/leaflet.css
+++ b/loleaflet/dist/leaflet.css
@@ -623,7 +623,6 @@
width: 0px;
height: 0px;
z-index: 100;
- display: none;
opacity: 0;
}
#clipboard {
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index d46617d..36e416e 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -154,6 +154,8 @@ L.TileLayer = L.GridLayer.extend({
}),
draggable: true
});
+ this._textArea = L.DomUtil.get('clipboard');
+ this._textArea.focus();
},
_initDocument: function () {
@@ -699,6 +701,7 @@ L.TileLayer = L.GridLayer.extend({
if (this._endMarker._icon) {
L.DomUtil.removeClass(this._endMarker._icon,
'leaflet-not-clickable');
}
+ this._textArea.focus();
}
else if (e.type === 'mousemove' this._selecting) {
if (this._holdStart) {
@@ -767,6 +770,14 @@ L.TileLayer = L.GridLayer.extend({
return;
}
+ if (e.originalEvent.ctrlKey) {
+ // we prepare for a copy event
+ this._textArea.value = 'dummy text';
+ this._textArea.focus();
+ this._textArea.select();
+ return;
+ }
+
var charCode = e.originalEvent.charCode;
var keyCode = e.originalEvent.keyCode;
if (e.type === 'keypress') {
@@ -903,9 +914,6 @@ L.TileLayer = L.GridLayer.extend({
}
else {
e.clipboardData.setData('text/plain',
this._selectionTextContent);
- var clipboardContainer =
L.DomUtil.get('clipboard-container');
- L.DomUtil.setStyle(clipboardContainer, 'display',
'none');
- this._map._container.focus();
}
}
});
diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index 85ab119..4f25698 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -584,7 +584,7 @@ L.Map = L.Evented.extend({
L.DomEvent[onOff](this._container, 'click dblclick mousedown
mouseup ' +
'mouseover mouseout mousemove contextmenu keydown
keypress keyup', this._handleDOMEvent, this);
- L.DomEvent[onOff](L.DomUtil.get('clipboard'), 'copy',
this._handleDOMEvent, this);
+ L.DomEvent[onOff](L.DomUtil.get('clipboard'), 'copy keydown
keypress keyup', this._handleDOMEvent, this);
if (this.options.trackResize) {
L.DomEvent[onOff](window, 'resize', this._onResize,
this);
diff --git a/loleaflet/src/map/handler/Map.Keyboard.js
b/loleaflet/src/map/handler/Map.Keyboard.js
index afc0763..e524ce8 100644
--- a/loleaflet/src/map/handler/Map.Keyboard.js
+++ b/loleaflet/src/map/handler/Map.Keyboard.js
@@ -125,14 +125,6 @@ L.Map.Keyboard = L.Handler.extend({
},
_onKeyDown: function (e) {
- if (e.ctrlKey) {
- var clipboardContainer =
L.DomUtil.get('clipboard-container');
- var textArea = L.DomUtil.get('clipboard');
- L.DomUtil.setStyle(clipboardContainer, 'display',
'inline');
- textArea.value = 'dummy text';
- textArea.focus();
- textArea.select();
- }
if (this._map._bDisableKeyboard || e.altKey || e.ctrlKey ||
e.metaKey) { return; }
var key = e.keyCode,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sc/source
sc/source/core/tool/compiler.cxx | 88 ---
1 file changed, 65 insertions(+), 23 deletions(-)
New commits:
commit 7511c2af96f9b0a6830c64d6a80cb4d6c8e7af8f
Author: Eike Rathke er...@redhat.com
Date: Fri Jun 26 17:43:36 2015 +0200
tdf#44419 display entire column/row references as A:A/1:1
... if both anchors of the other axis are absolute. Now that we can
parse them as of commit 0c8778ce1df92ca3bc2a8dd2f64568fb257e9e39 (and
follow-up 4091b4fbdce40262eba46ab94653287b1fd928e8).
Change-Id: Ie67127fe2d7546e7e598ee1a4d89133c0862
(cherry picked from commit eeea41e2e726dd5d69cd323909e1666efb9de472)
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index ec2e796..ad5b0ec 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -763,12 +763,25 @@ struct ConventionOOO_A1 : public Convention_A1
rBuf.append('.');
}
+enum SingletonDisplay
+{
+SINGLETON_NONE,
+SINGLETON_COL,
+SINGLETON_ROW
+};
+
static void MakeOneRefStrImpl(
OUStringBuffer rBuffer,
const OUString rErrRef, const std::vectorOUString rTabNames,
const ScSingleRefData rRef, const ScAddress rAbsRef,
-bool bForceTab, bool bODF )
+bool bForceTab, bool bODF, SingletonDisplay eSingletonDisplay )
{
+// For ODF override singleton so earlier releases still can read what
+// we write now as of 2015-06-26.
+/* TODO: we may want to change that in future in a few releases. */
+if (bODF)
+eSingletonDisplay = SINGLETON_NONE;
+
if( rRef.IsFlag3D() || bForceTab )
{
if (!ValidTab(rAbsRef.Tab()) || rRef.IsTabDeleted())
@@ -787,18 +800,45 @@ struct ConventionOOO_A1 : public Convention_A1
}
else if (bODF)
rBuffer.append('.');
-if (!rRef.IsColRel())
-rBuffer.append('$');
-if (!ValidCol(rAbsRef.Col()) || rRef.IsColDeleted())
-rBuffer.append(rErrRef);
-else
-MakeColStr(rBuffer, rAbsRef.Col());
-if (!rRef.IsRowRel())
-rBuffer.append('$');
-if (!ValidRow(rAbsRef.Row()) || rRef.IsRowDeleted())
-rBuffer.append(rErrRef);
-else
-MakeRowStr(rBuffer, rAbsRef.Row());
+
+if (eSingletonDisplay != SINGLETON_ROW)
+{
+if (!rRef.IsColRel())
+rBuffer.append('$');
+if (!ValidCol(rAbsRef.Col()) || rRef.IsColDeleted())
+rBuffer.append(rErrRef);
+else
+MakeColStr(rBuffer, rAbsRef.Col());
+}
+
+if (eSingletonDisplay != SINGLETON_COL)
+{
+if (!rRef.IsRowRel())
+rBuffer.append('$');
+if (!ValidRow(rAbsRef.Row()) || rRef.IsRowDeleted())
+rBuffer.append(rErrRef);
+else
+MakeRowStr(rBuffer, rAbsRef.Row());
+}
+}
+
+static SingletonDisplay getSingletonDisplay( const ScAddress rAbs1, const
ScAddress rAbs2,
+const ScComplexRefData rRef )
+{
+// If any part is error, display as such.
+if (!ValidCol(rAbs1.Col()) || rRef.Ref1.IsColDeleted() ||
!ValidRow(rAbs1.Row()) || rRef.Ref1.IsRowDeleted() ||
+!ValidCol(rAbs2.Col()) || rRef.Ref2.IsColDeleted() ||
!ValidRow(rAbs2.Row()) || rRef.Ref2.IsRowDeleted())
+return SINGLETON_NONE;
+
+// A:A or $A:$A or A:$A or $A:A, both row anchors must be absolute.
+if (rAbs1.Row() == 0 rAbs2.Row() == MAXROW !rRef.Ref1.IsRowRel()
!rRef.Ref2.IsRowRel())
+return SINGLETON_COL;
+
+// 1:1 or $1:$1 or 1:$1 or $1:1, both column anchors must be absolute.
+if (rAbs1.Col() == 0 rAbs2.Col() == MAXCOL !rRef.Ref1.IsColRel()
!rRef.Ref2.IsColRel())
+return SINGLETON_ROW;
+
+return SINGLETON_NONE;
}
virtual void makeRefStr( OUStringBuffer rBuffer,
@@ -809,18 +849,19 @@ struct ConventionOOO_A1 : public Convention_A1
bool bSingleRef,
bool /*bFromRangeName*/ ) const SAL_OVERRIDE
{
-ScComplexRefData aRef( rRef );
// In case absolute/relative positions weren't separately available:
// transform relative to absolute!
-ScAddress aAbs1 = aRef.Ref1.toAbs(rPos), aAbs2;
+ScAddress aAbs1 = rRef.Ref1.toAbs(rPos), aAbs2;
if( !bSingleRef )
-aAbs2 = aRef.Ref2.toAbs(rPos);
+aAbs2 = rRef.Ref2.toAbs(rPos);
-MakeOneRefStrImpl(rBuffer, rErrRef, rTabNames, aRef.Ref1, aAbs1,
false, false);
+SingletonDisplay eSingleton = bSingleRef ? SINGLETON_NONE :
getSingletonDisplay( aAbs1, aAbs2, rRef);
+MakeOneRefStrImpl(rBuffer, rErrRef, rTabNames, rRef.Ref1, aAbs1,
false, false, eSingleton);
if (!bSingleRef)
{
[Libreoffice-bugs] [Bug 85417] Full column ranges are not supported: Eg =match(foo, a:a, 0)
https://bugs.documentfoundation.org/show_bug.cgi?id=85417 Eike Rathke er...@redhat.com changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90927] Cursor shown double and at wrong location after double click into a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=90927 Pedro pedl...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||pedl...@gmail.com Ever confirmed|0 |1 --- Comment #5 from Pedro pedl...@gmail.com --- In my PC running v4.4.4.3 under Windows XP Pro x86 SP3, the event was replicated when I opened the document for the first time. Double clicking and also pressing F2 (edit) in cell F5 and G5 showed a second cursor in cells C2 and D2 respectively. I haven't been able to replicate a second time (even after resetting the Profile). This is a really odd bug... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60421] HTML: missing margin-top property on Save as
https://bugs.documentfoundation.org/show_bug.cgi?id=60421 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92283] UI: property sidebar is not up to substituting the line and fill toolbar with respect to line width
https://bugs.documentfoundation.org/show_bug.cgi?id=92283 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 OS|Linux (All) |All --- Comment #1 from Beluga todven...@suomi24.fi --- Fair enough - NEW. Can't repro that crash. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64) Build ID: a51ac4d2bb8c4f1ea1d4ea7569863e2fb6535b02 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-06-22_21:37:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60421] HTML: missing margin-top property on Save as
https://bugs.documentfoundation.org/show_bug.cgi?id=60421 --- Comment #15 from Beluga todven...@suomi24.fi --- Created attachment 116847 -- https://bugs.documentfoundation.org/attachment.cgi?id=116847action=edit Export as XHTML output Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64) Build ID: a51ac4d2bb8c4f1ea1d4ea7569863e2fb6535b02 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-06-22_21:37:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60421] HTML: missing margin-top property on Save as
https://bugs.documentfoundation.org/show_bug.cgi?id=60421 --- Comment #14 from Beluga todven...@suomi24.fi --- Created attachment 116846 -- https://bugs.documentfoundation.org/attachment.cgi?id=116846action=edit Save as HTML output Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64) Build ID: a51ac4d2bb8c4f1ea1d4ea7569863e2fb6535b02 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-06-22_21:37:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92358] New: SLIDESHOW with custom animations: sound is lost and some animations don't run as expected
https://bugs.documentfoundation.org/show_bug.cgi?id=92358 Bug ID: 92358 Summary: SLIDESHOW with custom animations: sound is lost and some animations don't run as expected Product: LibreOffice Version: 4.4.3.2 release Hardware: Other OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: richard.gre...@onera.fr Created attachment 116849 -- https://bugs.documentfoundation.org/attachment.cgi?id=116849action=edit Sample presentation for testing custom animation with sounds Hello Some problems with custom animations in slideshow on Linux although they are running fine on Windows. I attach a sample presentation showing two problems. 1. First slide: some text is hidden below two blue rectangles. Click to remove the first rectangle so as the text below becomes visible. The second text should remain hidden. Click again to remove the second rectangle, and the second text becomes visible. On Windows, all is OK, the second text remains hidden at first click. But on Linux, at first click, the text below the second rectangle comes on top of the rectangle. 2. Second slide: you should hear the apert sound from gallery at slide transition. You can hear this sound both on Windows and on Linux. Here again there is a text under a blue rectangle. When you click, the rectangle disappears and you should hear the falling sound from gallery. You can hear this second sound on Windows, but not on Linux. Maybe the sound problem is linked to bug 64199? Note: the sample document has been built on Windows with relative pathnames. When opened on Linux, no sound could be heard, and I had to re-assign sounds from gallery for custom animation and for slide transition (it seems that the relative Windows pathnames are not recognized by Linux?). This sample file is the one with re-assigned sounds on Linux. The slide transition sound can be heard on my two versions of Libre Office installed in parallel (4.0.4 and 4.4.3) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92360] New: CRASH after choosing Execute Macro
https://bugs.documentfoundation.org/show_bug.cgi?id=92360 Bug ID: 92360 Summary: CRASH after choosing Execute Macro Product: LibreOffice Version: 4.3.7.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: major Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: andreas.gruend...@freenet.de Created attachment 116851 -- https://bugs.documentfoundation.org/attachment.cgi?id=116851action=edit Recoveroption after restart Choosing the Menuitem Extras=Execute Macro the whole Suite (LO)crashes. This happens using CALC, WRITER or IMPRESS. After restarting the LO the Recovery-Dialog appears and after recover the Files are opened properly but the CRASH-Situation isn't eliminated. I am Using Win 8.1PRO with Java 8.45 SDK. The option Execute Macro works properly up today since several weeks and there are no changes on the OS or Software-Installation are made. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92047] icon and function format area disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=92047 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added CC||caol...@redhat.com --- Comment #4 from Michael Meeks michael.me...@collabora.com --- TBH I don't really understand this: sfx2/source/dialog/templdlg.cxx SfxCommonTemplateDialog_Impl::UpdateStyles_Impl(sal_uInt16 nFlags) if(!bWaterDisabled) //make sure the watercan is only activated when there is (only) one selection bWaterDisabled = pTreeBox || aFmtLb-GetSelectionCount() = 1; Looks like a plain logic bug to me; from: commit 38b8e742872b2cbdba93f4d1b84c8f09b5ab38ff Author: Caolán McNamara caol...@redhat.com Date: Tue Oct 29 13:42:31 2013 + Related: fdo#67461 consider hierarchical view Or perhaps I'm confused, its rather unclear to me what changed - but that single line above is apparently the source of the aggravation =) Anyhow - I'm adding a helpful helper to unwind whatever's going on there and clean up the duplicate logic here. hopefully that will help =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/GridLayer.js |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit fe4ff86335ff77ab03b4cc32696c4c70d1a0df89
Author: Mihai Varga mihai.va...@collabora.com
Date: Fri Jun 26 19:29:02 2015 +0300
Temporarily disable client cache
Until we invalidate tiles from all zoom levels
diff --git a/loleaflet/src/layer/tile/GridLayer.js
b/loleaflet/src/layer/tile/GridLayer.js
index 64e3054..6885a01 100644
--- a/loleaflet/src/layer/tile/GridLayer.js
+++ b/loleaflet/src/layer/tile/GridLayer.js
@@ -587,7 +587,7 @@ L.GridLayer = L.Layer.extend({
// FIXME: this _tileCache is used for prev/next slide; but it is
// dangerous in connection with typing / invalidation, so let's
// comment it out for now
- this._tileCache[key] = tile.el.src;
+ //this._tileCache[key] = tile.el.src;
L.DomUtil.remove(tile.el);
delete this._tiles[key];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Anytime builder VMs for devs (was: test infrastructure ideas appreciated ...)
Hi Björn, *, On Thu, Jun 18, 2015 at 11:14 AM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: On Wed, Jun 03, 2015 at 02:33:23PM +0100, Michael Meeks wrote: Constructive thoughts appreciated in reply here. Budget for 2-5 of our Hackfest VMs[1] to always be on standby for someone wanting to do a fast build, and provision for Cloph to be able to hand out log-ins at a quick ping on IRC. What is the suggested standby time? Creating a disk-image/EC2 virtual machine from a stored snapshot takes a while (20min). ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92167] Documents open with filemanager are not on top
https://bugs.documentfoundation.org/show_bug.cgi?id=92167 --- Comment #10 from Carlos Rodriguez carlos.rodrig...@tegnix.com --- Ok, got this bug with SolydK ISO live. Investigating I get through System Settings - Configure Desktop effect - General tab and uncheck Improved window management. Try it and tell me if you still are getting this issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: libreoffice-5-0 failure in [ CUT ] libreofficekit_tiledrendering
On Fri, Jun 26, 2015 at 02:00:51PM +0200, Lionel Elie Mamane wrote: On Mon, Jun 15, 2015 at 02:32:23PM +0200, Miklos Vajna wrote: On Wed, Jun 03, 2015 at 02:54:45PM +0200, Lionel Elie Mamane lio...@mamane.lu wrote: What are those autogen.input options? Can you follow the instructions of the failed test and get a backtrace? Both are attached. To me the backtrace looks unrelated to tile rendering, but then this is the only failing thing in a make check -k I only have an implicit --without-system-libs dbgutil build from libreoffice-5-0, and there I don't see this problem. It would be interesting to know if the failure is indeed conditional on --with-system-libs or it's something else. An other approach is to see if the branch point was good for you, if so, then bisect what commit broke the test with your build options. After further testing... I have two directories (checkouts): libreoffice-5-0 containing my working branch based on libreoffice-5-0 libreoffice-5-1 containing my working branch based on master The test fails in directory libreoffice-5-0 but succeeds in directory libreoffice-5-1. Now, what happens is that if I do: cd libreoffice-5-0 checkout master make CppunitTest_libreofficekit_tiledrendering The test still fails. So the failure seems to be related to something else than code... Maybe the contents of instdir/user? I deleted the instdir directory and it still fails. shrug -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - 2 commits - vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkframe.hxx |1 +
vcl/unx/gtk/a11y/atkbridge.cxx |5 +++--
vcl/unx/gtk/a11y/atkfactory.cxx|5 +
vcl/unx/gtk/a11y/atkutil.cxx | 12 ++--
vcl/unx/gtk/a11y/atkutil.hxx |1 +
vcl/unx/gtk/window/gtksalframe.cxx | 23 +++
6 files changed, 39 insertions(+), 8 deletions(-)
New commits:
commit dbba5f026cd94002fc76dc94a0d131d494bc4301
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jun 26 13:50:28 2015 +0100
Related: tdf#92293 gtk3 a11y: I suspect that all of this is redundant
in favor of hooking in via get_accessible
Change-Id: I8c265e0d9a5f8bdf02b7ba4be71fc58194cf5aa4
(cherry picked from commit aff0d4b29681ee8008ff438885c8cc2b461f4dd5)
diff --git a/vcl/unx/gtk/a11y/atkbridge.cxx b/vcl/unx/gtk/a11y/atkbridge.cxx
index 9a89a8f..c649c25 100644
--- a/vcl/unx/gtk/a11y/atkbridge.cxx
+++ b/vcl/unx/gtk/a11y/atkbridge.cxx
@@ -27,6 +27,9 @@
bool InitAtkBridge()
{
+#if GTK_CHECK_VERSION(3,0,0)
+ooo_atk_util_ensure_event_listener();
+#else
const char* pVersion = atk_get_toolkit_version();
if( ! pVersion )
return false;
@@ -56,13 +59,15 @@ bool InitAtkBridge()
AtkRegistry * registry = atk_get_default_registry();
if( registry )
atk_registry_set_factory_type( registry, OOO_TYPE_FIXED,
OOO_TYPE_WRAPPER_FACTORY );
-
+#endif
return true;
}
void DeInitAtkBridge()
{
+#if !GTK_CHECK_VERSION(3,0,0)
restore_gail_window_vtable();
+#endif
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/gtk/a11y/atkutil.cxx b/vcl/unx/gtk/a11y/atkutil.cxx
index 03f08e4..bb0a238 100644
--- a/vcl/unx/gtk/a11y/atkutil.cxx
+++ b/vcl/unx/gtk/a11y/atkutil.cxx
@@ -714,12 +714,20 @@ ooo_atk_util_class_init (AtkUtilClass *)
atk_class-get_toolkit_name = ooo_atk_util_get_toolkit_name;
atk_class-get_toolkit_version = ooo_atk_util_get_toolkit_version;
-Application::AddEventListener( g_aEventListenerLink );
+ooo_atk_util_ensure_event_listener();
}
} // extern C
-/*/
+void ooo_atk_util_ensure_event_listener()
+{
+static bool bInited;
+if (!bInited)
+{
+Application::AddEventListener( g_aEventListenerLink );
+bInited = true;
+}
+}
GType
ooo_atk_util_get_type()
diff --git a/vcl/unx/gtk/a11y/atkutil.hxx b/vcl/unx/gtk/a11y/atkutil.hxx
index 89cb61a..9524188 100644
--- a/vcl/unx/gtk/a11y/atkutil.hxx
+++ b/vcl/unx/gtk/a11y/atkutil.hxx
@@ -25,6 +25,7 @@
#define OOO_TYPE_ATK_UTIL ooo_atk_util_get_type()
GType ooo_atk_util_get_type();
+void ooo_atk_util_ensure_event_listener();
#endif
commit cfcae6481a9180d057a34e3a4a157dbc2f96918e
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jun 26 13:24:19 2015 +0100
Resolves: tdf#92293 gtk3: get a11y working
(cherry picked from commit 093d7b8142d0cb224fcf23506f3b36f7a3a10d2c)
Change-Id: I89cfde9b4c97852d36817b716ac08bd32096915b
diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index e0547ed..0adeecd 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -471,6 +471,7 @@ public:
extern C {
GType ooo_fixed_get_type();
+AtkObject* ooo_fixed_get_accessible(GtkWidget *obj);
} // extern C
diff --git a/vcl/unx/gtk/a11y/atkbridge.cxx b/vcl/unx/gtk/a11y/atkbridge.cxx
index e3ffdc6..9a89a8f 100644
--- a/vcl/unx/gtk/a11y/atkbridge.cxx
+++ b/vcl/unx/gtk/a11y/atkbridge.cxx
@@ -27,7 +27,6 @@
bool InitAtkBridge()
{
-#if !GTK_CHECK_VERSION(3,0,0)
const char* pVersion = atk_get_toolkit_version();
if( ! pVersion )
return false;
@@ -57,16 +56,13 @@ bool InitAtkBridge()
AtkRegistry * registry = atk_get_default_registry();
if( registry )
atk_registry_set_factory_type( registry, OOO_TYPE_FIXED,
OOO_TYPE_WRAPPER_FACTORY );
-#endif
return true;
}
void DeInitAtkBridge()
{
-#if !GTK_CHECK_VERSION(3,0,0)
restore_gail_window_vtable();
-#endif
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/gtk/a11y/atkfactory.cxx b/vcl/unx/gtk/a11y/atkfactory.cxx
index fb0cc77..99ed750 100644
--- a/vcl/unx/gtk/a11y/atkfactory.cxx
+++ b/vcl/unx/gtk/a11y/atkfactory.cxx
@@ -140,6 +140,11 @@ wrapper_factory_create_accessible( GObject *obj )
return NULL;
}
+AtkObject* ooo_fixed_get_accessible(GtkWidget *obj)
+{
+return wrapper_factory_create_accessible(G_OBJECT(obj));
+}
+
static void
wrapper_factory_class_init( AtkObjectFactoryClass *klass )
{
diff --git a/vcl/unx/gtk/window/gtksalframe.cxx
b/vcl/unx/gtk/window/gtksalframe.cxx
index a7b9b88..55fce4d 100644
--- a/vcl/unx/gtk/window/gtksalframe.cxx
+++ b/vcl/unx/gtk/window/gtksalframe.cxx
@@ -971,6 +971,17 @@ void GtkSalFrame::resizeWindow( long nWidth, long nHeight )
window_resize(nWidth, nHeight);
}
+#if GTK_CHECK_VERSION(3,2,0)
+
+static void
[Libreoffice-bugs] [Bug 36549] ACCESSIBILITY: Tracking bug for issues affecting a11y ATK and GNOME Orca screen reader support
https://bugs.documentfoundation.org/show_bug.cgi?id=36549 Bug 36549 depends on bug 92293, which changed state. Bug 92293 Summary: Accessibility completely broken with gtk3 plugin https://bugs.documentfoundation.org/show_bug.cgi?id=92293 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
New commits:
commit ce07affe888db8d32315b18c851f860a270631ba
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jun 26 15:27:02 2015 +0100
gtk3: fpicker, try removing both locations
Change-Id: I0f10d03c1e4481e8efa765e52b5264071c86a3cf
diff --git a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
index 6512434..9936f8c 100644
--- a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
@@ -419,29 +419,30 @@ shrinkFilterName( const OUString rFilterName, bool
bAllowNoStar = false )
}
static void
+dialog_remove_buttons(GtkWidget *pActionArea)
+{
+GList *pChildren =
+gtk_container_get_children( GTK_CONTAINER( pActionArea ) );
+
+for( GList *p = pChildren; p; p = p-next )
+gtk_widget_destroy( GTK_WIDGET( p-data ) );
+
+g_list_free( pChildren );
+}
+
+static void
dialog_remove_buttons( GtkDialog *pDialog )
{
g_return_if_fail( GTK_IS_DIALOG( pDialog ) );
-GtkWidget *pActionArea;
-
#if GTK_CHECK_VERSION(3,0,0)
#if GTK_CHECK_VERSION(3,12,0)
-pActionArea = gtk_dialog_get_header_bar(pDialog);
-#else
-pActionArea = gtk_dialog_get_action_area(pDialog);
+dialog_remove_buttons(gtk_dialog_get_header_bar(pDialog));
#endif
+dialog_remove_buttons(gtk_dialog_get_action_area(pDialog));
#else
-pActionArea = pDialog-action_area;
+dialog_remove_buttons(pDialog-action_area);
#endif
-
-GList *pChildren =
-gtk_container_get_children( GTK_CONTAINER( pActionArea ) );
-
-for( GList *p = pChildren; p; p = p-next )
-gtk_widget_destroy( GTK_WIDGET( p-data ) );
-
-g_list_free( pChildren );
}
namespace {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
DSN: failed (Good day)
This is a Delivery Status Notification (DSN). I was unable to deliver your message to marco.huggenber...@gmail.com. I said (end of message) And they gave me the error; 552-5.7.0 This message was blocked because its content presents a potential 552-5.7.0 security issue. Please visit 552-5.7.0 https://support.google.com/mail/answer/6590 to review our message 552 5.7.0 content and attachment content guidelines. om4si50824704pdb.237 - gsmtp Received: from lists.freedesktop.org ([151.42.215.110]) by by-night.ch for ma...@by-night.ch; Fri, 26 Jun 2015 07:56:05 -0700 From: libreoffice@lists.freedesktop.org To: ma...@by-night.ch Subject: Good day Date: Fri, 26 Jun 2015 16:56:08 +0200 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary==_NextPart_000_0001_EC01F6FB.DBC6E0AD X-Priority: 3 X-MSMail-Priority: Normal ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92305] VIEWING: Multiple page view does not render properly when scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=92305 raal r...@post.cz changed: What|Removed |Added Keywords||regression Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Whiteboard||bibisectRequest OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/inc/cuitabarea.hxx|6 --
cui/source/inc/cuitabline.hxx|3 ---
cui/source/tabpages/tparea.cxx |6 ++
cui/source/tabpages/tpbitmap.cxx |3 +--
cui/source/tabpages/tpgradnt.cxx |3 +--
cui/source/tabpages/tphatch.cxx |3 +--
cui/source/tabpages/tpline.cxx |3 +--
cui/source/tabpages/tplnedef.cxx |3 +--
cui/source/tabpages/tplneend.cxx |3 +--
cui/source/tabpages/tpshadow.cxx |3 +--
10 files changed, 9 insertions(+), 27 deletions(-)
New commits:
commit ce5711267c09a8c85decbd2ad043149d584f8fe7
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Jun 26 16:01:26 2015 +0200
-fsanitize=vptr: wrong, unnecessary downcasts
(and the pXPool members are not even necessary)
Change-Id: I321f06387ca1f1e98d8f731ec2b070212c82c28a
diff --git a/cui/source/inc/cuitabarea.hxx b/cui/source/inc/cuitabarea.hxx
index a25966a..4b00e3e 100644
--- a/cui/source/inc/cuitabarea.hxx
+++ b/cui/source/inc/cuitabarea.hxx
@@ -140,7 +140,6 @@ class SvxTransparenceTabPage : public SvxTabPage
VclPtrSvxXRectPreviewm_pCtlXRectPreview;
boolbBitmap;
-XOutdevItemPool*pXPool;
XFillAttrSetItemaXFillAttr;
SfxItemSet rXFSet;
@@ -253,7 +252,6 @@ private:
bool* pbAreaTP;
-XOutdevItemPool*pXPool;
XFillAttrSetItemaXFillAttr;
SfxItemSet rXFSet;
@@ -348,7 +346,6 @@ private:
boolbDisable;
-XOutdevItemPool*pXPool;
XFillAttrSetItemaXFillAttr;
SfxItemSet rXFSet;
SfxMapUnit ePoolUnit;
@@ -420,7 +417,6 @@ private:
sal_Int32* pPos;
bool* pbAreaTP;
-XOutdevItemPool*pXPool;
XFillStyleItem aXFStyleItem;
XFillGradientItem aXGradientItem;
XFillAttrSetItemaXFillAttr;
@@ -497,7 +493,6 @@ private:
sal_Int32* pPos;
bool* pbAreaTP;
-XOutdevItemPool*pXPool;
XFillStyleItem aXFStyleItem;
XFillHatchItem aXHatchItem;
XFillAttrSetItemaXFillAttr;
@@ -584,7 +579,6 @@ private:
boolbBmpChanged;
-XOutdevItemPool*pXPool;
XFillStyleItem aXFStyleItem;
XFillBitmapItem aXBitmapItem;
XFillAttrSetItemaXFillAttr;
diff --git a/cui/source/inc/cuitabline.hxx b/cui/source/inc/cuitabline.hxx
index 678042b..d659409 100644
--- a/cui/source/inc/cuitabline.hxx
+++ b/cui/source/inc/cuitabline.hxx
@@ -150,7 +150,6 @@ private:
RECT_POINT eRP;
boolbObjSelected;
-XOutdevItemPool*pXPool;
XLineStyleItem aXLStyle;
XLineWidthItem aXWidth;
XLineDashItem aXDash;
@@ -267,7 +266,6 @@ private:
XDash aDash;
boolbObjSelected;
-XOutdevItemPool*pXPool;
XLineStyleItem aXLStyle;
XLineWidthItem aXWidth;
XLineDashItem aXDash;
@@ -349,7 +347,6 @@ private:
const SdrObject*pPolyObj;
boolbObjSelected;
-XOutdevItemPool*pXPool;
XLineStyleItem aXLStyle;
XLineWidthItem aXWidth;
XLineColorItem aXColor;
diff --git a/cui/source/tabpages/tparea.cxx b/cui/source/tabpages/tparea.cxx
index ae3f3f3..538c4612 100644
--- a/cui/source/tabpages/tparea.cxx
+++ b/cui/source/tabpages/tparea.cxx
@@ -258,8 +258,7 @@ SvxTransparenceTabPage::SvxTransparenceTabPage(vcl::Window*
pParent, const SfxIt
nPageType (0),
nDlgType(0),
bBitmap ( false ),
-pXPool ( static_castXOutdevItemPool*(rInAttrs.GetPool()) ),
-aXFillAttr ( pXPool ),
+aXFillAttr ( rInAttrs.GetPool() ),
rXFSet ( aXFillAttr.GetItemSet() )
{
get(m_pRbtTransOff,RBT_TRANS_OFF);
@@ -624,8 +623,7 @@ SvxAreaTabPage::SvxAreaTabPage( vcl::Window* pParent, const
SfxItemSet rInAttrs
// init with pointer to fixed bool
pbAreaTP(maFixed_sal_Bool),
-pXPool ( static_castXOutdevItemPool*( rInAttrs.GetPool() )
),
-aXFillAttr ( pXPool ),
+aXFillAttr ( rInAttrs.GetPool() ),
rXFSet ( aXFillAttr.GetItemSet() ),
ePoolUnit(SFX_MAPUNIT_100TH_MM),
diff --git a/cui/source/tabpages/tpbitmap.cxx b/cui/source/tabpages/tpbitmap.cxx
index 71c23e6..8c3427d 100644
--- a/cui/source/tabpages/tpbitmap.cxx
+++ b/cui/source/tabpages/tpbitmap.cxx
@@ -67,10 +67,9 @@ SvxBitmapTabPage::SvxBitmapTabPage( vcl::Window* pParent,
const SfxItemSet rIn
bBmpChanged ( false ),
-pXPool ( static_castXOutdevItemPool*( rInAttrs.GetPool() )),
aXFStyleItem( drawing::FillStyle_BITMAP ),
aXBitmapItem( OUString(), Graphic() ),
-aXFillAttr ( pXPool ),
+aXFillAttr ( rInAttrs.GetPool() ),
rXFSet ( aXFillAttr.GetItemSet() )
{
get(m_pBxPixelEditor,maingrid);
[Libreoffice-commits] core.git: cui/source
cui/source/options/treeopt.cxx | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) New commits: commit b15019d84f52f546294c0336382ea6217f833ed2 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jun 26 16:37:09 2015 +0200 -fsanitize=vptr: SID_ATTR_*LANGUAGE are of type SvxLanguageItem Change-Id: If00273e3836aeb70adee36f49f0ef502b6a7aebb diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx index 7bfc713..9df70c3 100644 --- a/cui/source/options/treeopt.cxx +++ b/cui/source/options/treeopt.cxx @@ -1252,11 +1252,23 @@ SfxItemSet* OfaTreeOptionsDialog::CreateItemSet( sal_uInt16 nId ) const SfxPoolItem* pItem = NULL; SfxDispatcher* pDispatch = pViewFrame-GetDispatcher(); if(SfxItemState::DEFAULT = pDispatch-QueryState(SID_ATTR_LANGUAGE, pItem)) -pRet-Put(SfxUInt16Item(SID_ATTR_LANGUAGE, static_castconst SvxLanguageItem*(pItem)-GetLanguage())); +pRet-Put( +SvxLanguageItem( +(static_castconst SvxLanguageItem*(pItem) + -GetLanguage()), +SID_ATTR_LANGUAGE)); if(SfxItemState::DEFAULT = pDispatch-QueryState(SID_ATTR_CHAR_CJK_LANGUAGE, pItem)) -pRet-Put(SfxUInt16Item(SID_ATTR_CHAR_CJK_LANGUAGE, static_castconst SvxLanguageItem*(pItem)-GetLanguage())); +pRet-Put( +SvxLanguageItem( +(static_castconst SvxLanguageItem*(pItem) + -GetLanguage()), +SID_ATTR_CHAR_CJK_LANGUAGE)); if(SfxItemState::DEFAULT = pDispatch-QueryState(SID_ATTR_CHAR_CTL_LANGUAGE, pItem)) -pRet-Put(SfxUInt16Item(SID_ATTR_CHAR_CTL_LANGUAGE, static_castconst SvxLanguageItem*(pItem)-GetLanguage())); +pRet-Put( +SvxLanguageItem( +(static_castconst SvxLanguageItem*(pItem) + -GetLanguage()), +SID_ATTR_CHAR_CTL_LANGUAGE)); pRet-Put(aHyphen); if(SfxItemState::DEFAULT = pDispatch-QueryState(SID_AUTOSPELL_CHECK, pItem)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92354] Add UI to load / import .ase .gpl color palettes (Tools - Options - Colors - Load Color List)
https://bugs.documentfoundation.org/show_bug.cgi?id=92354 Gerry gerry.trep...@googlemail.com changed: What|Removed |Added Summary|Add UI to load / import |Add UI to load / import |color palettes (Tools -|.ase .gpl color palettes |Options - Colors - Load |(Tools - Options - Colors |Color List) |- Load Color List) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=65138 Bug 65138 depends on bug 92332, which changed state. Bug 92332 Summary: SIDEBAR: Customizing the sidebar tabs isn't saved between sessions https://bugs.documentfoundation.org/show_bug.cgi?id=92332 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92332] SIDEBAR: Customizing the sidebar tabs isn't saved between sessions
https://bugs.documentfoundation.org/show_bug.cgi?id=92332 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Status|NEW |RESOLVED CC||vstuart.fo...@utsa.edu Resolution|--- |DUPLICATE --- Comment #4 from V Stuart Foote vstuart.fo...@utsa.edu --- Please see https://bugs.documentfoundation.org/show_bug.cgi?id=67770#c4 *** This bug has been marked as a duplicate of bug 67770 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91824] remove sidebar configuration icon and menu items to view sidebar menu entry
https://bugs.documentfoundation.org/show_bug.cgi?id=91824 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||67770 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91824] remove sidebar configuration icon and menu items to view sidebar menu entry
https://bugs.documentfoundation.org/show_bug.cgi?id=91824 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||67770 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 67770] CONFIGURATION: Sidebar customization settings not remembered after reopening
https://bugs.documentfoundation.org/show_bug.cgi?id=67770 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||philip...@hotmail.com --- Comment #11 from V Stuart Foote vstuart.fo...@utsa.edu --- *** Bug 92332 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67770] CONFIGURATION: Sidebar customization settings not remembered after reopening
https://bugs.documentfoundation.org/show_bug.cgi?id=67770 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Blocks||91824 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 67770] CONFIGURATION: Sidebar customization settings not remembered after reopening
https://bugs.documentfoundation.org/show_bug.cgi?id=67770 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Blocks||65351 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 67770] CONFIGURATION: Sidebar customization settings not remembered after reopening
https://bugs.documentfoundation.org/show_bug.cgi?id=67770 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Blocks||65351 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65351] Sidebar: open pane that was active when last used
https://bugs.documentfoundation.org/show_bug.cgi?id=65351 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||67770 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60421] HTML: missing margin-top property on export
https://bugs.documentfoundation.org/show_bug.cgi?id=60421 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WORKSFORME --- Comment #12 from Beluga todven...@suomi24.fi --- (In reply to Ulf Zibis from comment #11) Save as html produces a different result. So LibO is still buggy -- REOPENED Yes, LibO is buggy, ~7000 bugs open, but this is not the topic of this particular report. This was about export and not about the differences between Save as vs. Export. Closing again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: bridges/source include/formula include/o3tl sw/inc
bridges/source/cpp_uno/gcc3_linux_intel/callvirtualmethod.cxx |2
bridges/source/cpp_uno/gcc3_macosx_x86-64/share.hxx |8
bridges/source/cpp_uno/mingw_intel/share.hxx | 13 -
bridges/source/cpp_uno/mingw_x86-64/share.hxx | 13 -
include/formula/tokenarray.hxx|4
include/o3tl/typed_flags_set.hxx | 115 --
include/o3tl/underlying_type.hxx | 32 --
sw/inc/ring.hxx |6
8 files changed, 57 insertions(+), 136 deletions(-)
New commits:
commit 3a68a7dcf49f7be95086b747c8426aa310307e49
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Jun 26 17:28:43 2015 +0200
Remove workarounds for no longer supported GCC 4.6
In bridges/source/cpp_uno/gcc3_macosx_x86-64/share.hxx, the #if also covered
Clang, which actually needs these declarations (for now; the right fix will
probably be to #include cxxabi.h).
Change-Id: I1eebd59e2371f3498d740ab78244927358c4f23f
diff --git a/bridges/source/cpp_uno/gcc3_linux_intel/callvirtualmethod.cxx
b/bridges/source/cpp_uno/gcc3_linux_intel/callvirtualmethod.cxx
index 15b357b..af20806 100644
--- a/bridges/source/cpp_uno/gcc3_linux_intel/callvirtualmethod.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_intel/callvirtualmethod.cxx
@@ -58,7 +58,7 @@ void CPPU_CURRENT_NAMESPACE::callVirtualMethod(
// unexpected size of int
assert(nStackLongs pStackLongs); // no stack
-#if defined __clang__ || __GNUC__ == 4 __GNUC_MINOR__ = 6
+#if defined __clang__
if (! pAdjustedThisPtr)
CPPU_CURRENT_NAMESPACE::dummy_can_throw_anything(xxx); // address something
#endif
diff --git a/bridges/source/cpp_uno/gcc3_macosx_x86-64/share.hxx
b/bridges/source/cpp_uno/gcc3_macosx_x86-64/share.hxx
index 0185a2c..0c7bbbf 100644
--- a/bridges/source/cpp_uno/gcc3_macosx_x86-64/share.hxx
+++ b/bridges/source/cpp_uno/gcc3_macosx_x86-64/share.hxx
@@ -133,18 +133,10 @@ extern C CPPU_CURRENT_NAMESPACE::__cxa_eh_globals
*__cxa_get_globals () throw(
namespace CPPU_CURRENT_NAMESPACE
{
-// The following are in cxxabi.h since GCC 4.7 (they are wrapped in
-// CPPU_CURRENT_NAMESPACE here as different GCC versions have slightly
different
-// declarations for them, e.g., with or without throw() specification, so would
-// complain about redeclarations of these somewhat implicitly declared
-// functions):
-#if __GNUC__ == 4 __GNUC_MINOR__ = 6
extern C void *__cxa_allocate_exception(
std::size_t thrown_size ) throw();
extern C void __cxa_throw (
void *thrown_exception, void *tinfo, void (*dest) (void *) )
__attribute__((noreturn));
-#endif
-
void raiseException(
uno_Any * pUnoExc, uno_Mapping * pUno2Cpp );
diff --git a/bridges/source/cpp_uno/mingw_intel/share.hxx
b/bridges/source/cpp_uno/mingw_intel/share.hxx
index b39ed6b..0ce7423 100644
--- a/bridges/source/cpp_uno/mingw_intel/share.hxx
+++ b/bridges/source/cpp_uno/mingw_intel/share.hxx
@@ -84,19 +84,6 @@ extern C CPPU_CURRENT_NAMESPACE::__cxa_eh_globals
*__cxa_get_globals () throw(
namespace CPPU_CURRENT_NAMESPACE
{
-// The following are in cxxabi.h since GCC 4.7 (they are wrapped in
-// CPPU_CURRENT_NAMESPACE here as different GCC versions have slightly
different
-// declarations for them, e.g., with or without throw() specification, so would
-// complain about redeclarations of these somewhat implicitly declared
-// functions):
-#if __GNUC__ == 4 __GNUC_MINOR__ = 6
-extern C void *__cxa_allocate_exception(
-std::size_t thrown_size ) throw();
-extern C void __cxa_throw (
-void *thrown_exception, void *tinfo, void (*dest) (void *) )
__attribute__((noreturn));
-#endif
-
-
void raiseException(
uno_Any * pUnoExc, uno_Mapping * pUno2Cpp );
diff --git a/bridges/source/cpp_uno/mingw_x86-64/share.hxx
b/bridges/source/cpp_uno/mingw_x86-64/share.hxx
index 61d278d..8093820 100644
--- a/bridges/source/cpp_uno/mingw_x86-64/share.hxx
+++ b/bridges/source/cpp_uno/mingw_x86-64/share.hxx
@@ -79,19 +79,6 @@ extern C CPPU_CURRENT_NAMESPACE::__cxa_eh_globals
*__cxa_get_globals () throw(
namespace CPPU_CURRENT_NAMESPACE
{
-// The following are in cxxabi.h since GCC 4.7 (they are wrapped in
-// CPPU_CURRENT_NAMESPACE here as different GCC versions have slightly
different
-// declarations for them, e.g., with or without throw() specification, so would
-// complain about redeclarations of these somewhat implicitly declared
-// functions):
-#if __GNUC__ == 4 __GNUC_MINOR__ = 6
-extern C void *__cxa_allocate_exception(
-std::size_t thrown_size ) throw();
-extern C void __cxa_throw (
-void *thrown_exception, void *tinfo, void (*dest) (void *) )
__attribute__((noreturn));
-#endif
-
-
void raiseException(
uno_Any * pUnoExc, uno_Mapping * pUno2Cpp );
diff --git a/include/formula/tokenarray.hxx b/include/formula/tokenarray.hxx
index 58bb092..6d577ea 100644
---
[Libreoffice-bugs] [Bug 86375] register-true causes extra blank lines
https://bugs.documentfoundation.org/show_bug.cgi?id=86375 Regina Henschel rb.hensc...@t-online.de changed: What|Removed |Added Status|NEW |RESOLVED CC||rb.hensc...@t-online.de Resolution|--- |WORKSFORME --- Comment #4 from Regina Henschel rb.hensc...@t-online.de --- Inside Step you have characters with hard formatting to 10,5pt. That makes them larger as the 10pt in the other text. The 10pt grid is not high enough for them, therefore register-true adds blank lines. Clear the wrong character size and the document will be OK. In addition when working with register-true, you should have a look at the settings Add paragraph and table spacing at tops of pages (in current document) and Do not add leading (extra space) between lines of text. Both are in Tools Options LibreOffice Writer Compatibility. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92167] Documents open with filemanager are not on top
https://bugs.documentfoundation.org/show_bug.cgi?id=92167 --- Comment #9 from wb4...@yahoo.com --- There is another way that this problem can be duplicated for you and I just tested it. Download a copy of Solydk-64 version 201505 (I presume you are using 64-bit) at: http://solydxk.com/downloads/solydk/ and create a live disk. Bring the system up and using the defaults except changing the mouse to single click, open LO and create a Writer file saving it in Documents. Then close out LO and open Dolphin to open the file in Documents. The behavior is there. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89904] tools-options-colors should enable load/save palette
https://bugs.documentfoundation.org/show_bug.cgi?id=89904 Gerry gerry.trep...@googlemail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||354 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91379] UI: Breeze icons appear in Sifr theme
https://bugs.documentfoundation.org/show_bug.cgi?id=91379 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added CC||ke...@collabora.com, ||philip...@hotmail.com --- Comment #3 from Yousuf (Jay) Philips philip...@hotmail.com --- There seems to be a problem here as icon fix didnt fix this problem. Version: 5.1.0.0.alpha1+ Build ID: ee3d40b30816a8fc6d4e8f984659c8dfac19ec3b TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-06-26_00:21:32 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/unx
vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx |6 +-
vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx |3 +++
vcl/unx/gtk/fpicker/SalGtkPicker.cxx | 17 ++---
vcl/unx/gtk/fpicker/SalGtkPicker.hxx |1 +
4 files changed, 19 insertions(+), 8 deletions(-)
New commits:
commit ce707c3283259a0351d622534e4eb4a313641063
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jun 26 16:30:02 2015 +0100
gtk3: gtk_window_set_transient_for on overwrite warning dlg
Change-Id: I91d21e3d1663880de14792ded0a1e079d1a40f09
(cherry picked from commit 30a5b304f2c1c3d89a2e3b76ac44f2c6376ee65f)
diff --git a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
index 8e6154f..cee1e3e 100644
--- a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
@@ -918,6 +918,9 @@ sal_Int16 SAL_CALL SalGtkFilePicker::execute() throw(
uno::RuntimeException, std
frame::Desktop::create(m_xContext),
UNO_QUERY_THROW );
+GtkWindow *pParent = RunDialog::GetTransientFor();
+if (pParent)
+gtk_window_set_transient_for(GTK_WINDOW(m_pDialog), pParent);
RunDialog* pRunDialog = new RunDialog(m_pDialog, xToolkit, xDesktop);
uno::Reference awt::XTopWindowListener xLifeCycle(pRunDialog);
while( GTK_RESPONSE_NO == btn )
@@ -1005,7 +1008,8 @@ sal_Int16 SAL_CALL SalGtkFilePicker::execute() throw(
uno::RuntimeException, std
gtk_window_set_title( GTK_WINDOW( dlg ),
OUStringToOString(getResString(FILE_PICKER_TITLE_SAVE ),
RTL_TEXTENCODING_UTF8 ).getStr() );
-
+if (pParent)
+gtk_window_set_transient_for(GTK_WINDOW(dlg),
pParent);
RunDialog* pAnotherDialog = new RunDialog(dlg,
xToolkit, xDesktop);
uno::Reference awt::XTopWindowListener
xAnotherLifeCycle(pAnotherDialog);
btn = pAnotherDialog-run();
diff --git a/vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx
b/vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx
index 0754101..bf90682 100644
--- a/vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx
@@ -145,6 +145,9 @@ sal_Int16 SAL_CALL SalGtkFolderPicker::execute() throw(
uno::RuntimeException, s
uno::Reference frame::XDesktop xDesktop(
frame::Desktop::create(m_xContext), uno::UNO_QUERY);
+GtkWindow *pParent = RunDialog::GetTransientFor();
+if (pParent)
+gtk_window_set_transient_for(GTK_WINDOW(m_pDialog), pParent);
RunDialog* pRunDialog = new RunDialog(m_pDialog, xToolkit, xDesktop);
uno::Reference awt::XTopWindowListener xLifeCycle(pRunDialog);
gint nStatus = pRunDialog-run();
diff --git a/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
b/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
index 4aaa69f..3069c2a 100644
--- a/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
@@ -104,10 +104,7 @@ extern C
}
}
-RunDialog::RunDialog( GtkWidget *pDialog, uno::Reference
awt::XExtendedToolkit rToolkit,
-uno::Reference frame::XDesktop rDesktop ) :
-cppu::WeakComponentImplHelper2 awt::XTopWindowListener,
frame::XTerminateListener ( maLock ),
-mpDialog(pDialog), mxToolkit(rToolkit), mxDesktop(rDesktop)
+GtkWindow* RunDialog::GetTransientFor()
{
GtkWindow *pParent = NULL;
@@ -118,8 +115,15 @@ RunDialog::RunDialog( GtkWidget *pDialog, uno::Reference
awt::XExtendedToolkit
if( pFrame )
pParent = GTK_WINDOW( pFrame-getWindow() );
}
-if (pParent)
-gtk_window_set_transient_for( GTK_WINDOW( mpDialog ), pParent );
+
+return pParent;
+}
+
+RunDialog::RunDialog( GtkWidget *pDialog, uno::Reference
awt::XExtendedToolkit rToolkit,
+uno::Reference frame::XDesktop rDesktop ) :
+cppu::WeakComponentImplHelper2 awt::XTopWindowListener,
frame::XTerminateListener ( maLock ),
+mpDialog(pDialog), mxToolkit(rToolkit), mxDesktop(rDesktop)
+{
}
RunDialog::~RunDialog()
@@ -133,7 +137,6 @@ void SAL_CALL RunDialog::windowOpened( const
::com::sun::star::lang::EventObject
throw (::com::sun::star::uno::RuntimeException, std::exception)
{
SolarMutexGuard g;
-
g_timeout_add_full(G_PRIORITY_HIGH_IDLE, 0,
reinterpret_castGSourceFunc(canceldialog), this, NULL);
}
diff --git a/vcl/unx/gtk/fpicker/SalGtkPicker.hxx
b/vcl/unx/gtk/fpicker/SalGtkPicker.hxx
index 78d810c..dd98b3a 100644
--- a/vcl/unx/gtk/fpicker/SalGtkPicker.hxx
+++ b/vcl/unx/gtk/fpicker/SalGtkPicker.hxx
@@ -115,6 +115,7 @@ public:
virtual ~RunDialog();
gint run();
void cancel();
+static GtkWindow* GetTransientFor();
};
#endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/core/doc/notxtfrm.cxx|2 +-
sw/source/core/inc/cntfrm.hxx |2 +-
sw/source/core/inc/flyfrms.hxx |6 +++---
sw/source/core/inc/frame.hxx |2 +-
sw/source/core/inc/layfrm.hxx |2 +-
sw/source/core/inc/notxtfrm.hxx|2 +-
sw/source/core/inc/pagefrm.hxx |2 +-
sw/source/core/inc/rootfrm.hxx |2 +-
sw/source/core/inc/rowfrm.hxx |2 +-
sw/source/core/inc/sectfrm.hxx |2 +-
sw/source/core/inc/tabfrm.hxx |2 +-
sw/source/core/layout/calcmove.cxx | 20 ++--
sw/source/core/layout/fly.cxx |8
sw/source/core/layout/flycnt.cxx |4 ++--
sw/source/core/layout/flyincnt.cxx |2 +-
sw/source/core/layout/flylay.cxx |2 +-
sw/source/core/layout/pagechg.cxx |2 +-
sw/source/core/layout/paintfrm.cxx |2 +-
sw/source/core/layout/sectfrm.cxx |4 ++--
sw/source/core/layout/tabfrm.cxx | 10 +-
20 files changed, 40 insertions(+), 40 deletions(-)
New commits:
commit 4cd3f9a7749b8ef285012a59d031dc9f2e4b5e43
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Jun 26 15:20:14 2015 +0200
fix crash on exporting kde140265-1.doc to ODT
properties.pSGlobalShell can be legitimately 0 here.
No testcase, for some reason the export does not crash if it's done by
CppunitTest_sw_filters_test or CppunitTest_sw_odfexport; but it does
crash with '--headless --convert-to odt kde140265-1.doc'.
Change-Id: I50936f9e5236763cc987aba14d8fc897c4b789bf
diff --git a/sw/source/core/layout/paintfrm.cxx
b/sw/source/core/layout/paintfrm.cxx
index 017389b..67e6e15 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -1510,7 +1510,7 @@ static void lcl_CalcBorderRect( SwRect rRect, const
SwFrm *pFrm,
}
}
-::SwAlignRect( rRect, properties.pSGlobalShell,
properties.pSGlobalShell-GetOut() );
+::SwAlignRect( rRect, properties.pSGlobalShell, properties.pSGlobalShell ?
properties.pSGlobalShell-GetOut() : 0 );
}
/**
commit a3413204d2eb0563a4a2e1104905951f81e417bc
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Jun 26 14:58:43 2015 +0200
SwPageFrm::MakeAll: use vcl::RenderContext
One tricky part is that in generic SwFrm methods SwRootFrm may not have
a shell and doesn't need a vcl::RenderContext, either; so check for that
situation explicitly where the frame may be a root one.
Change-Id: I48f39fb7195290393fca34f75d8798fb5f960f46
diff --git a/sw/source/core/doc/notxtfrm.cxx b/sw/source/core/doc/notxtfrm.cxx
index d040d35..811f97b 100644
--- a/sw/source/core/doc/notxtfrm.cxx
+++ b/sw/source/core/doc/notxtfrm.cxx
@@ -463,7 +463,7 @@ const Size SwNoTextFrm::GetSize() const
return pFly-Prt().SSize();
}
-void SwNoTextFrm::MakeAll()
+void SwNoTextFrm::MakeAll(vcl::RenderContext* /*pRenderContext*/)
{
SwContentNotify aNotify( this );
SwBorderAttrAccess aAccess( SwFrm::GetCache(), this );
diff --git a/sw/source/core/inc/cntfrm.hxx b/sw/source/core/inc/cntfrm.hxx
index 94a597a..18e137b 100644
--- a/sw/source/core/inc/cntfrm.hxx
+++ b/sw/source/core/inc/cntfrm.hxx
@@ -45,7 +45,7 @@ class SwContentFrm: public SwFrm, public SwFlowFrm
bool bTstMove,
const bool bObjsInNewUpper );
-virtual void MakeAll() SAL_OVERRIDE;
+virtual void MakeAll(vcl::RenderContext* pRenderContext) SAL_OVERRIDE;
void _UpdateAttr( const SfxPoolItem*, const SfxPoolItem*, sal_uInt8 ,
SwAttrSetChg *pa = 0, SwAttrSetChg *pb = 0 );
diff --git a/sw/source/core/inc/flyfrms.hxx b/sw/source/core/inc/flyfrms.hxx
index 4608577..c096a4b 100644
--- a/sw/source/core/inc/flyfrms.hxx
+++ b/sw/source/core/inc/flyfrms.hxx
@@ -71,7 +71,7 @@ public:
// #i28701#
TYPEINFO_OVERRIDE();
-virtual void MakeAll() SAL_OVERRIDE;
+virtual void MakeAll(vcl::RenderContext* pRenderContext) SAL_OVERRIDE;
// #i37068# - accessors for member mbNoMoveOnCheckClip
inline void SetNoMoveOnCheckClip( const bool _bNewNoMoveOnCheckClip )
@@ -138,7 +138,7 @@ protected:
class SwFlyAtCntFrm : public SwFlyFreeFrm
{
protected:
-virtual void MakeAll() SAL_OVERRIDE;
+virtual void MakeAll(vcl::RenderContext* pRenderContext) SAL_OVERRIDE;
// #i28701#
virtual bool _InvalidationAllowed( const InvalidationType _nInvalid )
const SAL_OVERRIDE;
@@ -186,7 +186,7 @@ class SwFlyInCntFrm : public SwFlyFrm
protected:
virtual void NotifyBackground( SwPageFrm *pPage,
const SwRect rRect, PrepareHint eHint)
SAL_OVERRIDE;
-virtual void MakeAll() SAL_OVERRIDE;
+virtual void MakeAll(vcl::RenderContext* pRenderContext) SAL_OVERRIDE;
virtual void Modify( const SfxPoolItem*, const SfxPoolItem* )
SAL_OVERRIDE;
public:
diff --git a/sw/source/core/inc/frame.hxx b/sw/source/core/inc/frame.hxx
index 9c9f76a..9677a5f 100644
---
