[Libreoffice-bugs] [Bug 94008] FILEOPEN: Crash opening password protected xlsx file

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94008

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #4 from raal  ---
I can not confirm with 5.0.1.2
ID build: 81898c9f5c0d43f3473ba111d7b351050be20261, win7

Please test with version 5.0.1.2, http://www.libreoffice.org/download/. Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: compilerplugins/clang mergeclasses.results

2015-09-08 Thread Noel Grandin
 compilerplugins/clang/mergeclasses.cxx |  199 +++
 compilerplugins/clang/mergeclasses.py  |   73 +++
 mergeclasses.results   |  334 +
 3 files changed, 606 insertions(+)

New commits:
commit d7efea29cdc2faa57d172d7e4d8def18fd49536c
Author: Noel Grandin 
Date:   Tue Sep 8 08:07:33 2015 +0200

new loplugin mergeclasses

Idea from Norbert (shm_get) - look for classes that are
(a) not instantiated
(b) have zero or one subclasses
and warn about them - would allow us to remove a bunch of abstract
classes that can be merged into one class and simplified

Change-Id: I4e43fdd2f549b5cbe25dcb7cee5e9dd3c1df8ba0

diff --git a/compilerplugins/clang/mergeclasses.cxx 
b/compilerplugins/clang/mergeclasses.cxx
new file mode 100644
index 000..b6fccfe
--- /dev/null
+++ b/compilerplugins/clang/mergeclasses.cxx
@@ -0,0 +1,199 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+#include 
+#include "plugin.hxx"
+#include "compat.hxx"
+#include 
+
+/**
+
+Idea from Norbert (shm_get) - look for classes that are
+(a) not instantiated
+(b) have zero or one subclasses
+and warn about them - would allow us to remove a bunch of abstract classes
+that can be merged into one class and simplified.
+
+Dump a list of
+- unique classes that exist (A)
+- unique classes that are instantiated (B)
+- unique class-subclass relationships (C)
+Then
+   let D = A minus B
+   for each class in D, look in C and count the entries, then dump it if 
no-entries == 1
+
+The process goes something like this:
+  $ make check
+  $ make FORCE_COMPILE_ALL=1 COMPILER_PLUGIN_TOOL='mergeclasses' check
+  $ ./compilerplugins/clang/mergeclasses.py > mergeclasses.results
+
+FIXME exclude 'static-only' classes, which some people may use/have used 
instead of a namespace to tie together a bunch of functions
+
+*/
+
+namespace {
+
+// try to limit the voluminous output a little
+static std::set instantiatedSet;
+static std::set > childToParentClassSet; // 
childClassName -> parentClassName
+static std::map definitionMap;  // className -> 
filename
+
+class MergeClasses:
+public RecursiveASTVisitor, public loplugin::Plugin
+{
+public:
+explicit MergeClasses(InstantiationData const & data): Plugin(data) {}
+
+virtual void run() override
+{
+TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
+
+// dump all our output in one write call - this is to try and limit IO 
"crosstalk" between multiple processes
+// writing to the same logfile
+std::string output;
+for (const std::string & s : instantiatedSet)
+output += "instantiated:\t" + s + "\n";
+for (const std::pair & s : 
childToParentClassSet)
+output += "has-subclass:\t" + s.first + "\t" + s.second + "\n";
+for (const std::pair & s : definitionMap)
+output += "definition:\t" + s.first + "\t" + s.second + "\n";
+ofstream myfile;
+myfile.open( SRCDIR "/mergeclasses.log", ios::app | ios::out);
+myfile << output;
+myfile.close();
+}
+
+bool VisitVarDecl(const VarDecl *);
+bool VisitFieldDecl(const FieldDecl *);
+bool VisitCXXConstructExpr( const CXXConstructExpr* var );
+bool VisitCXXRecordDecl( const CXXRecordDecl* decl);
+bool VisitFunctionDecl( const FunctionDecl* decl);
+bool VisitCallExpr(const CallExpr* decl);
+};
+
+static bool startsWith(const std::string& rStr, const char* pSubStr) {
+return rStr.compare(0, strlen(pSubStr), pSubStr) == 0;
+}
+
+static void addToInstantiatedSet(const std::string& s)
+{
+// ignore stuff in the standard library, and UNO stuff we can't touch.
+if (startsWith(s, "rtl::") || startsWith(s, "sal::") || startsWith(s, 
"com::sun::")
+|| startsWith(s, "std::") || startsWith(s, "boost::")
+|| s == "OString" || s == "OUString" || s == "bad_alloc")
+{
+return;
+}
+instantiatedSet.insert(s);
+}
+
+// check for implicit construction
+bool MergeClasses::VisitVarDecl( const VarDecl* pVarDecl )
+{
+if (ignoreLocation(pVarDecl)) {
+return true;
+}
+addToInstantiatedSet(pVarDecl->getType().getAsString());
+return true;
+}
+
+// check for implicit construction
+bool MergeClasses::VisitFieldDecl( const FieldDecl* pFieldDecl )
+{
+if (ignoreLocation(pFieldDecl)) {
+return true;
+}
+addToInstantiatedSet(pFieldDecl->getType().getAsString());
+return true;
+}
+
+bool 

[Libreoffice-commits] core.git: svtools/source

2015-09-08 Thread Stephan Bergmann
 svtools/source/filter/exportdialog.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f36f17f691903a389a7d98e85af12e08b75f6876
Author: Stephan Bergmann 
Date:   Tue Sep 8 08:53:49 2015 +0200

This shall presumably use nCompression, not a hardcoded "9"

...looks like a regression introduced with
333d1e3dcc2e819f8c62c9713cca96fbedaba3de, "impress186: #i4499# graphic 
dialog
reorganisation - added support of bitmap resolution," found with
clang-analyzer-deadcode.DeadStores

Change-Id: I86522b9e9a96e1de8ae35c77d779365b29f23f72

diff --git a/svtools/source/filter/exportdialog.cxx 
b/svtools/source/filter/exportdialog.cxx
index 3599863..e675a27 100644
--- a/svtools/source/filter/exportdialog.cxx
+++ b/svtools/source/filter/exportdialog.cxx
@@ -779,7 +779,7 @@ void ExportDialog::createFilterOptions()
 mpSbCompression->SetRangeMax( 9 );
 mpNfCompression->SetMin( 1 );
 mpNfCompression->SetMax( 9 );
-mpNfCompression->SetValue( 9 );
+mpNfCompression->SetValue( nCompression );
 mpNfCompression->SetStrictFormat( true );
 
 // Interlaced
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 93932] User can not enter a cell comment - insert comment creates a box and typing does not show the characters. Clicking on the box makes the box go away.

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93932

--- Comment #12 from Lani Gray  ---
Yes highlighting the comments (home, ctrl shift end) and then changing the
fonts worked.  What also worked was going to options-LibreOffice-Fonts and
using the replacement table to replace all MS Sans Serif with a font in the
list like Microsoft Sans Serif.  Thus eliminating visiting each blank comment
and making the font change.  Of course it changed every cell that was using MS
Sans Serif. Thanks a lot for helping me understand what was happening. As far
as I'm concern the issue is resolved and I'll continue with 5.0.1.2. Others can
decide if an automatic replacement should happen it a font is not available or
some kind of alert for the user.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94012] Constant crash after upgrade

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94012

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #4 from raal  ---
Hello,
for the test, could you rename your LibreOffice directory profile (see
https://wiki.documentfoundation.org/UserProfile) and give it a new try?

Log instructions: 
https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#GNU.2FLinux

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45589] Show bookmarks: make them visible in a document

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45589

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Whiteboard||needsDevEval topicUI

--- Comment #6 from Yousuf (Jay) Philips  ---
Dont think that it would be good to tie it in with non-printable characters, as
we would want this feature on by default and not all users toggle the "pi"
button. Google Docs is the only word processor that shows bookmarks and it does
so in the margins, similar to how we show line numbers (attachment 113660).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2015-09-08 Thread Miklos Vajna
 sw/source/core/doc/docfmt.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 965d27280bed1832d6424f378aa89525ccbff1f6
Author: Miklos Vajna 
Date:   Tue Sep 8 08:59:44 2015 +0200

sw: use std::unique_ptr<> in docfmt

Change-Id: I270785363bdd8e2242b185a26fa335e51bc2b8ce
Reviewed-on: https://gerrit.libreoffice.org/18400
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx
index f71186a..dbf47c0 100644
--- a/sw/source/core/doc/docfmt.cxx
+++ b/sw/source/core/doc/docfmt.cxx
@@ -79,7 +79,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 using namespace ::com::sun::star::i18n;
 using namespace ::com::sun::star::lang;
@@ -296,7 +296,7 @@ void SwDoc::ResetAttrs( const SwPaM ,
 }
 
 // #i96644#
-boost::scoped_ptr< SwDataChanged > xDataChanged;
+std::unique_ptr< SwDataChanged > xDataChanged;
 if ( bSendDataChangedEvents )
 {
 xDataChanged.reset( new SwDataChanged( *pPam ) );
@@ -1037,7 +1037,7 @@ static bool lcl_SetTextFormatColl( const SwNodePtr& 
rpNode, void* pArgs )
 
 if ( bChangeOfListStyleAtParagraph )
 {
-boost::scoped_ptr< SwRegHistory > pRegH;
+std::unique_ptr< SwRegHistory > pRegH;
 if ( pPara->pHistory )
 {
 pRegH.reset( new SwRegHistory( pTNd, *pTNd, 
pPara->pHistory ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: a deadlock question

2015-09-08 Thread Stephan Bergmann

On 09/08/2015 08:47 AM, meilin wrote:

Hi,I had send a same mail a few days ago. But I didn't receive some
helpful mails, So I use another mail address to send you a mail for help.


see 
 
"Re: deadlock question"

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 94012] New: Constant crash after upgrade

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94012

Bug ID: 94012
   Summary: Constant crash after upgrade
   Product: LibreOffice
   Version: 5.0.1.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: major
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vferra...@gmail.com

Hi, 
I have constant crashes after upgrade to Build ID: 5.0.1.2 Arch Linux build-
Inside spreadsheets, when trying to copy/paste cell format, or trying to work
on two files at once.

Can someone please instruct me how to file a .log file

Thanks for looking into it

Vittorio

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/source

2015-09-08 Thread Michael Stahl
 sw/source/uibase/app/docstyle.cxx |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit 1805b7549cd240009bf67eba3a030e19b4f6f046
Author: Michael Stahl 
Date:   Mon Sep 7 16:18:53 2015 +0200

tdf#90991: sw: fix style preview creating undo objects

SwDocStyleSheet::FillStyleSheet() already takes care to remove all
temporarily created styles, so assume that works and suppress the
creation of user-visible Undo objects.

Change-Id: I748f0e8304c42e767b331ebd22be0290b9c0d89d
(cherry picked from commit 779b547ca6271156a59965569fa44fbeb3f63ce5)
Reviewed-on: https://gerrit.libreoffice.org/18382
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/sw/source/uibase/app/docstyle.cxx 
b/sw/source/uibase/app/docstyle.cxx
index bb0f62f..016b1a1 100644
--- a/sw/source/uibase/app/docstyle.cxx
+++ b/sw/source/uibase/app/docstyle.cxx
@@ -1727,6 +1727,9 @@ bool SwDocStyleSheet::FillStyleSheet( FillStyleType 
eFType )
 bPhysical = 0 != pCharFormat;
 if( bFillOnlyInfo && !bPhysical )
 {
+// create style (plus all needed parents) and clean it up
+// later - without affecting the undo/redo stack
+::sw::UndoGuard const ug(rDoc.GetIDocumentUndoRedo());
 bDeleteInfo = true;
 ::lcl_SaveStyles( static_cast< sal_uInt16 >(nFamily), aDelArr, 
rDoc );
 pCharFormat = lcl_FindCharFormat(rDoc, aName, this, true );
@@ -1754,6 +1757,7 @@ bool SwDocStyleSheet::FillStyleSheet( FillStyleType 
eFType )
 bPhysical = 0 != pColl;
 if( bFillOnlyInfo && !bPhysical )
 {
+::sw::UndoGuard const ug(rDoc.GetIDocumentUndoRedo());
 bDeleteInfo = true;
 ::lcl_SaveStyles( static_cast< sal_uInt16 >(nFamily), aDelArr, 
rDoc );
 pColl = lcl_FindParaFormat(rDoc, aName, this, true );
@@ -1777,6 +1781,7 @@ bool SwDocStyleSheet::FillStyleSheet( FillStyleType 
eFType )
 bPhysical = 0 != pFrameFormat;
 if( bFillOnlyInfo && bPhysical )
 {
+::sw::UndoGuard const ug(rDoc.GetIDocumentUndoRedo());
 bDeleteInfo = true;
 ::lcl_SaveStyles( static_cast< sal_uInt16 >(nFamily), aDelArr, 
rDoc );
 pFrameFormat = lcl_FindFrameFormat(rDoc, aName, this, true );
@@ -1796,6 +1801,7 @@ bool SwDocStyleSheet::FillStyleSheet( FillStyleType 
eFType )
 bPhysical = 0 != pDesc;
 if( bFillOnlyInfo && !pDesc )
 {
+::sw::UndoGuard const ug(rDoc.GetIDocumentUndoRedo());
 bDeleteInfo = true;
 ::lcl_SaveStyles( static_cast< sal_uInt16 >(nFamily), aDelArr, 
rDoc );
 pDesc = lcl_FindPageDesc( rDoc, aName, this, true );
@@ -1824,6 +1830,7 @@ bool SwDocStyleSheet::FillStyleSheet( FillStyleType 
eFType )
 bPhysical = 0 != pNumRule;
 if( bFillOnlyInfo && !pNumRule )
 {
+::sw::UndoGuard const ug(rDoc.GetIDocumentUndoRedo());
 bDeleteInfo = true;
 ::lcl_SaveStyles( static_cast< sal_uInt16 >(nFamily), aDelArr, 
rDoc );
 pNumRule = lcl_FindNumRule( rDoc, aName, this, true );
@@ -1890,7 +1897,10 @@ bool SwDocStyleSheet::FillStyleSheet( FillStyleType 
eFType )
 SetMask( _nMask );
 }
 if( bDeleteInfo && bFillOnlyInfo )
+{
+::sw::UndoGuard const ug(rDoc.GetIDocumentUndoRedo());
 ::lcl_DeleteInfoStyles( static_cast< sal_uInt16 >(nFamily), aDelArr, 
rDoc );
+}
 return bRet;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88206

--- Comment #49 from Commit Notification 
 ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bfa5b13b42770fb709dc2af7cab7aff1942eaa50

toolkit: tdf#88206 replace cppu::WeakImplHelper* etc.

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: toolkit/source

2015-09-08 Thread Takeshi Abe
 toolkit/source/awt/asynccallback.cxx|4 ++--
 toolkit/source/awt/stylesettings.hxx|4 ++--
 toolkit/source/awt/vclxtoolkit.cxx  |6 +++---
 toolkit/source/controls/animatedimages.cxx  |1 -
 toolkit/source/controls/dialogcontrol.cxx   |4 ++--
 toolkit/source/controls/grid/defaultgridcolumnmodel.cxx |4 ++--
 toolkit/source/controls/grid/defaultgriddatamodel.cxx   |4 ++--
 toolkit/source/controls/grid/gridcolumn.hxx |4 ++--
 toolkit/source/controls/grid/gridcontrol.hxx|4 ++--
 toolkit/source/controls/grid/sortablegriddatamodel.cxx  |4 ++--
 toolkit/source/controls/tabpagemodel.cxx|1 -
 toolkit/source/controls/tree/treecontrol.cxx|3 ++-
 toolkit/source/controls/tree/treecontrol.hxx|2 --
 toolkit/source/controls/unocontrolcontainer.cxx |4 ++--
 14 files changed, 23 insertions(+), 26 deletions(-)

New commits:
commit bfa5b13b42770fb709dc2af7cab7aff1942eaa50
Author: Takeshi Abe 
Date:   Tue Sep 8 10:41:27 2015 +0900

toolkit: tdf#88206 replace cppu::WeakImplHelper* etc.

with the variadic variants.

Change-Id: If62a0c3da7f9732a60316dfd49323f6ab838fb6d
Reviewed-on: https://gerrit.libreoffice.org/18396
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/toolkit/source/awt/asynccallback.cxx 
b/toolkit/source/awt/asynccallback.cxx
index cc988b2..f344eb8 100644
--- a/toolkit/source/awt/asynccallback.cxx
+++ b/toolkit/source/awt/asynccallback.cxx
@@ -24,7 +24,7 @@
 #include "osl/mutex.hxx"
 #include "cppuhelper/factory.hxx"
 #include "cppuhelper/implementationentry.hxx"
-#include "cppuhelper/implbase2.hxx"
+#include 
 #include 
 #include "com/sun/star/lang/XServiceInfo.hpp"
 #include 
@@ -34,7 +34,7 @@
 namespace {
 
 class AsyncCallback:
-public ::cppu::WeakImplHelper2<
+public ::cppu::WeakImplHelper<
 css::lang::XServiceInfo,
 css::awt::XRequestCallback>,
 private boost::noncopyable
diff --git a/toolkit/source/awt/stylesettings.hxx 
b/toolkit/source/awt/stylesettings.hxx
index c49f1b7..1274b59 100644
--- a/toolkit/source/awt/stylesettings.hxx
+++ b/toolkit/source/awt/stylesettings.hxx
@@ -22,7 +22,7 @@
 
 #include 
 
-#include 
+#include 
 
 #include 
 
@@ -42,7 +42,7 @@ namespace toolkit
 //= WindowStyleSettings
 
 struct WindowStyleSettings_Data;
-typedef ::cppu::WeakImplHelper1 <   ::com::sun::star::awt::XStyleSettings
+typedef ::cppu::WeakImplHelper <   ::com::sun::star::awt::XStyleSettings
 >   WindowStyleSettings_Base;
 class WindowStyleSettings : public WindowStyleSettings_Base
 {
diff --git a/toolkit/source/awt/vclxtoolkit.cxx 
b/toolkit/source/awt/vclxtoolkit.cxx
index 9d5ff01..43174f5 100644
--- a/toolkit/source/awt/vclxtoolkit.cxx
+++ b/toolkit/source/awt/vclxtoolkit.cxx
@@ -45,7 +45,7 @@
 #include 
 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -147,7 +147,7 @@ protected:
 };
 
 class VCLXToolkit : public VCLXToolkit_Impl,
-public cppu::WeakComponentImplHelper2<
+public cppu::WeakComponentImplHelper<
 css::awt::XToolkitExperimental,
 css::lang::XServiceInfo >
 {
@@ -648,7 +648,7 @@ static void SAL_CALL ToolkitWorkerFunction( void* pArgs )
 
 // constructor, which might initialize VCL
 VCLXToolkit::VCLXToolkit():
-cppu::WeakComponentImplHelper2<
+cppu::WeakComponentImplHelper<
 ::com::sun::star::awt::XToolkitExperimental,
 ::com::sun::star::lang::XServiceInfo>( GetMutex() ),
 m_aTopWindowListeners(rBHelper.rMutex),
diff --git a/toolkit/source/controls/animatedimages.cxx 
b/toolkit/source/controls/animatedimages.cxx
index a434239b9..b12e37c 100644
--- a/toolkit/source/controls/animatedimages.cxx
+++ b/toolkit/source/controls/animatedimages.cxx
@@ -34,7 +34,6 @@
 #include 
 #include 
 
-#include 
 #include 
 
 #include "helper/unopropertyarrayhelper.hxx"
diff --git a/toolkit/source/controls/dialogcontrol.cxx 
b/toolkit/source/controls/dialogcontrol.cxx
index 018b239..5481a78 100644
--- a/toolkit/source/controls/dialogcontrol.cxx
+++ b/toolkit/source/controls/dialogcontrol.cxx
@@ -43,7 +43,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -74,7 +74,7 @@ using namespace ::com::sun::star::util;
 // => use some template magic
 
 template< typename T >
-class SimpleNamedThingContainer : public ::cppu::WeakImplHelper1< 
container::XNameContainer >
+class SimpleNamedThingContainer : public ::cppu::WeakImplHelper< 
container::XNameContainer >
 {
 typedef std::unordered_map< OUString, Reference< T >, OUStringHash,
std::equal_to< OUString > > NamedThingsHash;
diff --git a/toolkit/source/controls/grid/defaultgridcolumnmodel.cxx 

[Libreoffice-bugs] [Bug 94013] New: selection of vertical text in Frame leads to crash when using GTK3

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94013

Bug ID: 94013
   Summary: selection of vertical text in Frame leads to crash
when using GTK3
   Product: LibreOffice
   Version: 5.0.1.2 release
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sleep_wal...@suse.com

Created attachment 118513
  --> https://bugs.documentfoundation.org/attachment.cgi?id=118513=edit
bug reproducer document

I found reproducible problem with GTK3 (gtk and gen works correctly). I
attached document I used to reproduce. Contains just empty document with frame
containing caption with vertical orientation. I didn't verified whether the
orientation is relevant but you should have all the required information
available.

Feel free to ask for more, I have stored the dump.

How to reproduce:
1] open attached document
2] hover your mouse cursor above the text (without selecting the frame)
3] select the text
4] click outside of frame (so the selected text is unselected again)
5] BOOM!

backtrace:
(gdb) bt
#0  0x7f09e58a0dce in VclGtkClipboard::ClipboardGet(_GtkClipboard*,
_GtkSelectionData*, unsigned int) () from
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so
#1  0x7f09e43e2d65 in g_closure_invoke (closure=0x61f5700,
return_value=0x0, n_param_values=4, param_values=0x7ffc6441b710,
invocation_hint=0x7ffc6441b6b0) at gclosure.c:768
#2  0x7f09e43f3e81 in signal_emit_unlocked_R (node=node@entry=0x2f84240,
detail=detail@entry=0, instance=instance@entry=0x3392570,
emission_return=emission_return@entry=0x0, 
instance_and_params=instance_and_params@entry=0x7ffc6441b710) at
gsignal.c:3549
#3  0x7f09e43fc77e in g_signal_emit_valist
(instance=instance@entry=0x3392570, signal_id=signal_id@entry=50,
detail=detail@entry=0, var_args=var_args@entry=0x7ffc6441b910) at
gsignal.c:3305
#4  0x7f09e43fcf95 in g_signal_emit_by_name
(instance=instance@entry=0x3392570,
detailed_signal=detailed_signal@entry=0x7f09e5357762 "selection-get") at
gsignal.c:3401
#5  0x7f09e520b5fb in gtk_selection_invoke_handler (widget=0x3392570,
data=0x7ffc6441bab0, time=0) at gtkselection.c:3059
#6  0x7f09e520cfc6 in _gtk_selection_request (widget=0x3392570,
event=0x43970f0) at gtkselection.c:2456
#7  0x7f09e518add7 in _gtk_marshal_BOOLEAN__BOXEDv (closure=0x2f840f0,
return_value=0x7ffc6441bc80, instance=, args=,
marshal_data=, n_params=, param_types=0x2f84120)
at gtkmarshalers.c:130
#8  0x7f09e43e2f94 in _g_closure_invoke_va (closure=0x2f840f0,
return_value=0x7ffc6441bc80, instance=0x3392570, args=0x7ffc6441bd88,
n_params=, param_types=0x2f84120) at gclosure.c:831
#9  0x7f09e43fbfbc in g_signal_emit_valist (instance=0x3392570,
signal_id=, detail=0, var_args=var_args@entry=0x7ffc6441bd88) at
gsignal.c:3214
#10 0x7f09e43fcae2 in g_signal_emit (instance=instance@entry=0x3392570,
signal_id=, detail=detail@entry=0) at gsignal.c:3361
#11 0x7f09e52baeac in gtk_widget_event_internal (widget=0x3392570,
event=0x43970f0) at gtkwidget.c:7787
#12 0x7f09e5189e0a in gtk_main_do_event (event=0x43970f0) at gtkmain.c:1698
#13 0x7f09e4d10672 in gdk_event_source_dispatch (source=,
callback=, user_data=) at gdkeventsource.c:364
#14 0x7f09eb899cc7 in g_main_dispatch (context=0x2f9d5f0) at gmain.c:3122
#15 g_main_context_dispatch (context=context@entry=0x2f9d5f0) at gmain.c:3737
#16 0x7f09eb899ef8 in g_main_context_iterate
(context=context@entry=0x2f9d5f0, block=block@entry=1,
dispatch=dispatch@entry=1, self=) at gmain.c:3808
#17 0x7f09eb899f9c in g_main_context_iteration (context=0x2f9d5f0,
may_block=1) at gmain.c:3869
#18 0x7f09e589e897 in GtkData::Yield(bool, bool) () from
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so
#19 0x7f09f8539443 in ImplYield (i_bAllEvents=false, i_bWait=true) at
/usr/src/debug/libreoffice-5.0.1.2/vcl/source/app/svapp.cxx:353
#20 Application::Yield () at
/usr/src/debug/libreoffice-5.0.1.2/vcl/source/app/svapp.cxx:382
#21 0x7f09f85394c5 in Application::Execute () at
/usr/src/debug/libreoffice-5.0.1.2/vcl/source/app/svapp.cxx:336
#22 0x7f09f76d5f5b in desktop::Desktop::Main (this=0x7ffc6441c3e0) at
/usr/src/debug/libreoffice-5.0.1.2/desktop/source/app/app.cxx:1605
#23 0x7f09f853e4d1 in ImplSVMain () at
/usr/src/debug/libreoffice-5.0.1.2/vcl/source/app/svmain.cxx:162
#24 0x7f09f853e512 in SVMain () at
/usr/src/debug/libreoffice-5.0.1.2/vcl/source/app/svmain.cxx:196
#25 0x7f09f76f314f in soffice_main () at
/usr/src/debug/libreoffice-5.0.1.2/desktop/source/app/sofficemain.cxx:96
#26 0x0040071b in sal_main () at
/usr/src/debug/libreoffice-5.0.1.2/desktop/source/app/main.c:48
#27 main (argc=, argv=) at
/usr/src/debug/libreoffice-5.0.1.2/desktop/source/app/main.c:47



full backtrace:
#0  

[Libreoffice-bugs] [Bug 93492] Problems using labelprinter

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93492

--- Comment #3 from Winfried Donkers  ---
(In reply to tommy27 from comment #2)
> @Winfried
> is there anything you can do for this user?

Sorry for the delay, I was on vacation.
AFAICS this problem is with the draw module and a specific (type of) printer.
Unfortunately, my relevant 'expertise' is limited to the labelwizard, which has
nothing to do with printing and labelprinters.
Consequently I will not be able to fix this myself.

It would be interesting to know if the problems also occurs with writer and/or
calc on this printer. Knowing that will make it easier to fix (although one
would need access to such a printer to properly test).

Klaus, would you be willing to test with daily builds if a developer has an
opportunity to come up with a probable fix?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - include/svx svx/source

2015-09-08 Thread Michael Stahl
 include/svx/CommonStylePreviewRenderer.hxx   |2 
 svx/source/styles/CommonStylePreviewRenderer.cxx |   51 +--
 2 files changed, 31 insertions(+), 22 deletions(-)

New commits:
commit 3a0d2c51021022233015c3318cfcf26aceb3b650
Author: Michael Stahl 
Date:   Mon Sep 7 16:40:20 2015 +0200

svx: fix font rendering in the style preview

If the style does not actually have any font items, as is the case for
frame, page and number styles in Writer, the maFont will be
default-initialized and the maPixelSize incorrect.
Avoid using these variables.

(cherry picked from commit 07df816d73884d094f0f56be022aa0b4eff00b2d)

Change-Id: I084cd8faa90a3d53310ceec55e8dae3af3dd586c
Reviewed-on: https://gerrit.libreoffice.org/18383
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/include/svx/CommonStylePreviewRenderer.hxx 
b/include/svx/CommonStylePreviewRenderer.hxx
index 1e7d54e..0a7dd89 100644
--- a/include/svx/CommonStylePreviewRenderer.hxx
+++ b/include/svx/CommonStylePreviewRenderer.hxx
@@ -22,7 +22,7 @@ namespace svx
 
 class SVX_DLLPUBLIC CommonStylePreviewRenderer : public 
sfx2::StylePreviewRenderer
 {
-SvxFont maFont;
+std::unique_ptr m_pFont;
 Color maFontColor;
 Color maBackgroundColor;
 Size maPixelSize;
diff --git a/svx/source/styles/CommonStylePreviewRenderer.cxx 
b/svx/source/styles/CommonStylePreviewRenderer.cxx
index 67f9b89..fefd43b 100644
--- a/svx/source/styles/CommonStylePreviewRenderer.cxx
+++ b/svx/source/styles/CommonStylePreviewRenderer.cxx
@@ -47,7 +47,7 @@ CommonStylePreviewRenderer::CommonStylePreviewRenderer(
 const SfxObjectShell& rShell, OutputDevice& 
rOutputDev,
 SfxStyleSheetBase* pStyle, long nMaxHeight)
 : StylePreviewRenderer(rShell, rOutputDev, pStyle, nMaxHeight)
-, maFont()
+, m_pFont()
 , maFontColor(COL_AUTO)
 , maBackgroundColor(COL_AUTO)
 , maPixelSize()
@@ -60,53 +60,55 @@ CommonStylePreviewRenderer::~CommonStylePreviewRenderer()
 
 bool CommonStylePreviewRenderer::recalculate()
 {
-maFont = SvxFont();
+m_pFont.reset();
 
 std::unique_ptr pItemSet(mpStyle->GetItemSetForPreview());
 
 if (!pItemSet) return false;
 
+std::unique_ptr pFont(new SvxFont);
+
 const SfxPoolItem* pItem;
 
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_WEIGHT)) != nullptr)
 {
-maFont.SetWeight(static_cast(pItem)->GetWeight());
+pFont->SetWeight(static_cast(pItem)->GetWeight());
 }
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_POSTURE)) != nullptr)
 {
-maFont.SetItalic(static_cast(pItem)->GetPosture());
+pFont->SetItalic(static_cast(pItem)->GetPosture());
 }
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_CONTOUR)) != nullptr)
 {
-maFont.SetOutline(static_cast< const 
SvxContourItem*>(pItem)->GetValue());
+pFont->SetOutline(static_cast< const 
SvxContourItem*>(pItem)->GetValue());
 }
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_SHADOWED)) != nullptr)
 {
-maFont.SetShadow(static_cast(pItem)->GetValue());
+pFont->SetShadow(static_cast(pItem)->GetValue());
 }
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_RELIEF)) != nullptr)
 {
-maFont.SetRelief(static_cast(static_cast(pItem)->GetValue()));
+pFont->SetRelief(static_cast(static_cast(pItem)->GetValue()));
 }
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_UNDERLINE)) != nullptr)
 {
-maFont.SetUnderline(static_cast< const 
SvxUnderlineItem*>(pItem)->GetLineStyle());
+pFont->SetUnderline(static_cast< const 
SvxUnderlineItem*>(pItem)->GetLineStyle());
 }
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_OVERLINE)) != nullptr)
 {
-maFont.SetOverline(static_cast(static_cast(pItem)->GetValue()));
+pFont->SetOverline(static_cast(static_cast(pItem)->GetValue()));
 }
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_STRIKEOUT)) != nullptr)
 {
-maFont.SetStrikeout(static_cast(pItem)->GetStrikeout());
+pFont->SetStrikeout(static_cast(pItem)->GetStrikeout());
 }
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_CASEMAP)) != nullptr)
 {
-maFont.SetCaseMap(static_cast(pItem)->GetCaseMap());
+pFont->SetCaseMap(static_cast(pItem)->GetCaseMap());
 }
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_EMPHASISMARK)) != nullptr)
 {
-maFont.SetEmphasisMark(static_cast(pItem)->GetEmphasisMark());
+pFont->SetEmphasisMark(static_cast(pItem)->GetEmphasisMark());
 }
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_COLOR)) != nullptr)
 {
@@ -131,8 +133,8 @@ bool CommonStylePreviewRenderer::recalculate()
 if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_FONT)) != nullptr)
 {
 const SvxFontItem* pFontItem = static_cast(pItem);
-  

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - avmedia/source

2015-09-08 Thread Michael Meeks
 avmedia/source/opengl/oglplayer.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit eb570808aae8080e2dbb925db6b15cc257b2b9e5
Author: Michael Meeks 
Date:   Mon Sep 7 17:31:03 2015 +0100

tdf#93996 - throttle gltf rendering to let UI re-rendering get in.

Change-Id: I4a61595294c24a609a5952ce72f9f88524969784
Reviewed-on: https://gerrit.libreoffice.org/18384
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/avmedia/source/opengl/oglplayer.cxx 
b/avmedia/source/opengl/oglplayer.cxx
index 75caec6..f1a3ada 100644
--- a/avmedia/source/opengl/oglplayer.cxx
+++ b/avmedia/source/opengl/oglplayer.cxx
@@ -121,8 +121,10 @@ bool OGLPlayer::create( const OUString& rURL )
 }
 
 // Set timer
-m_aTimer.SetTimeout(1);
+m_aTimer.SetTimeout(8); // is 125fps enough for anyone ?
+m_aTimer.SetPriority(SchedulerPriority::LOW);
 m_aTimer.SetTimeoutHdl(LINK(this,OGLPlayer,TimerHandler));
+
 return true;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 93996] gltf rendering timer is far too fast ...

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93996

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:5.1.0   | target:5.1.0 target:5.0.3

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93996] gltf rendering timer is far too fast ...

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93996

--- Comment #2 from Commit Notification 
 ---
Michael Meeks committed a patch related to this issue.
It has been pushed to "libreoffice-5-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=eb570808aae8080e2dbb925db6b15cc257b2b9e5=libreoffice-5-0

tdf#93996 - throttle gltf rendering to let UI re-rendering get in.

It will be available in 5.0.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94011] TABLE: Table border (dashed) is not saved

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94011

Cor Nouws  changed:

   What|Removed |Added

   Keywords||regression
 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl
 Ever confirmed|0   |1
 Whiteboard||bibisectrequest

--- Comment #1 from Cor Nouws  ---
Thanks for filing, Pellesimon. I confirm the problem in 4.4.5.2 and 5.0.1.2 and
in 4.3.7.2 and in 4.2.6.2 ... anyway, OK in 4.0.6.2

on 32 Bits Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94015] New: Footnote separator line shows wrong on screen

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94015

Bug ID: 94015
   Summary: Footnote separator line shows wrong on screen
   Product: LibreOffice
   Version: 4.4.4.3 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 28hen...@gmail.com

In a longer (80 page) document I use footnotes with a separator line above
them. I have sent the file back and forth to a collaborator who have edited the
document also using Libreoffice.

At some point the separator line have started to show as both thick and thin on
different pages. It is not every other page, and I can't seem to find a system
in it.

I have tried changing the separator line and removing it all together, but
nothing have helped. In both these cases the actual lines shown on screen does
not change. This is true, whether I use page styles or go through the Format -
Page menu.

I have been able to change the lines to  [dotted lines], but as soon as
I set them back to solid lines, the varied thickness reappear.

A search on the Internet have revealed a few others with the same problem. The
most informative link was this:

https://ask.libreoffice.org/en/question/28985/cant-apply-page-style-for-footnotes/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93443] copy and paste ubuntu 15.04

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93443

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Beluga  ---
>From which page do you paste when it crashes?
Please also try with LibO 5.0.x. If Ubuntu doesn't offer it by default, you can
use this ppa https://launchpad.net/~libreoffice/+archive/ubuntu/ppa

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93525] Writer EDITING: Crash on deleting text (Unknown event notification 36)

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93525

--- Comment #6 from hkaus...@luukku.com ---
I'm experiencing same problem. Also if I select text and make any editing like
for example change text style or font to something else and click somewhere on
LibreOffice window, it will crash with same terminal message.

I deleted ~/.config/libreoffice folder before testing, so it uses default
settings. Using openSUSE Tumbleweed x64. Series 4.x didn't have this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: 2 commits - loleaflet/spec loolwsd/LOOLWSD.cpp

2015-09-08 Thread Mihai Varga
 loleaflet/spec/data/lorem.odt |binary
 loleaflet/spec/loleaflet/loleafletSpec.js |5 -
 loleaflet/spec/tilebench/TileBenchSpec.js |5 -
 loolwsd/LOOLWSD.cpp   |   15 +++
 4 files changed, 15 insertions(+), 10 deletions(-)

New commits:
commit d57100db3b6a82b3fcb5af622c63f9ba1bb05735
Author: Mihai Varga 
Date:   Tue Sep 8 12:01:59 2015 +0300

loleaflet: test document

diff --git a/loleaflet/spec/data/lorem.odt b/loleaflet/spec/data/lorem.odt
new file mode 100644
index 000..1b26ee1
Binary files /dev/null and b/loleaflet/spec/data/lorem.odt differ
diff --git a/loleaflet/spec/loleaflet/loleafletSpec.js 
b/loleaflet/spec/loleaflet/loleafletSpec.js
index fd16985..dd8fe14 100644
--- a/loleaflet/spec/loleaflet/loleafletSpec.js
+++ b/loleaflet/spec/loleaflet/loleafletSpec.js
@@ -13,10 +13,13 @@ describe('TileBench', function () {
}
 
before(function () {
+   var htmlPath = window.location.pathname;
+   var dir = htmlPath.substring(0, htmlPath.lastIndexOf('/'));
+   var fileURL = 'file://' + dir + '/data/lorem.odt';
// initialize the map and load the document
map = L.map('map', {
server: 'ws://localhost:9980',
-   doc: 'file:///home/mihai/Desktop/test_docs/eval.odt',
+   doc: fileURL,
edit: false,
readOnly: false
});
diff --git a/loleaflet/spec/tilebench/TileBenchSpec.js 
b/loleaflet/spec/tilebench/TileBenchSpec.js
index 25882a7..b266848 100644
--- a/loleaflet/spec/tilebench/TileBenchSpec.js
+++ b/loleaflet/spec/tilebench/TileBenchSpec.js
@@ -14,10 +14,13 @@ describe('TileBench', function () {
}
 
before(function () {
+   var htmlPath = window.location.pathname;
+   var dir = htmlPath.substring(0, htmlPath.lastIndexOf('/'));
+   var fileURL = 'file://' + dir + '/data/lorem.odt';
// initialize the map and load the document
map = L.map('map', {
server: 'ws://localhost:9980',
-   doc: 'file:///home/mihai/Desktop/test_docs/eval.odt',
+   doc: fileURL,
edit: false,
readOnly: false
});
commit e17598e866830390673c89062bb34844f23e10df
Author: Mihai Varga 
Date:   Tue Sep 8 11:31:49 2015 +0300

loolwsd: also copy /etc/nsswitch.conf

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index b1154b0..8fc7262 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -895,15 +895,14 @@ void LOOLWSD::desktopMain()
 linkOrCopy(LOOLWSD::loTemplate, jailLOInstallation);
 
 // We need this because sometimes the hostname is not resolved
-File resolv("/etc/resolv.conf");
-if (resolv.exists())
+std::vector networkFiles = {"/etc/hosts", 
"/etc/nsswitch.conf", "/etc/resolv.conf"};
+for (std::vector::iterator it = networkFiles.begin(); it != 
networkFiles.end(); ++it)
 {
-resolv.copyTo(Path(jail, "/etc").toString());
-}
-File hosts("/etc/hosts");
-if (hosts.exists())
-{
-hosts.copyTo(Path(jail, "/etc").toString());
+File networkFile(*it);
+if (networkFile.exists())
+{
+networkFile.copyTo(Path(jail, "/etc").toString());
+}
 }
 #ifdef __linux
 // Create the urandom and random devices
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 76084] Update style from selection does not work

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76084

--- Comment #5 from Henrik <28hen...@gmail.com> ---
Confirmed in version 4.4.4.3 on Windows 10.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94011] TABLE: Table border (dashed) is not saved

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94011

Cor Nouws  changed:

   What|Removed |Added

Version|4.4.3.2 release |4.2.0.4 release

--- Comment #2 from Cor Nouws  ---
OK in 410beta 1 - wild guess: set version to 4.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94011] TABLE: Table border (dashed) is not saved

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94011

Cor Nouws  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=88
   ||208

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88208] Table borders (specific?) in Writer not correctly saved (re-loaded?)

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88208

Cor Nouws  changed:

   What|Removed |Added

   Keywords||regression
 Whiteboard||bibisectrequest

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93433] incomplete display of long autocorrect list in the replacement table

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93433

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #2 from Beluga  ---
I get to zampe just fine and even to ømassimo.
However, if I first go to Italy (Switzerland) and then to Italy (Italy), LibO
hangs.

Win 7 Pro 64-bit, Version: 5.0.1.2 (32-bit)
Build ID: 81898c9f5c0d43f3473ba111d7b351050be20261
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88208] Table borders (specific?) in Writer not correctly saved (re-loaded?)

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88208

Cor Nouws  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=94
   ||011

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93992] Typos in Calc function names and error codes

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93992

--- Comment #4 from Niklas Johansson  ---
I can confirm the Swedish part and have now made the change in Pootle.
Thanks for the report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/source

2015-09-08 Thread Michael Stahl
 sw/source/uibase/app/docstyle.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4b9c51bd265908e8bf65cb2a462dd8fd9a88904f
Author: Michael Stahl 
Date:   Mon Sep 7 16:21:53 2015 +0200

sw: fix not-quite-copypaste code in SwDocStyleSheet::FillStyleSheet()

This causes the temporary creation of frame styles to fail.

Change-Id: I5d148ae008660d9c0f457a4c0e9dc256e0dfc49a
(cherry picked from commit 110dc43d97d559b6369bca308f9dd39fd02e751e)
Reviewed-on: https://gerrit.libreoffice.org/18380
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/sw/source/uibase/app/docstyle.cxx 
b/sw/source/uibase/app/docstyle.cxx
index 016b1a1..8c0c438 100644
--- a/sw/source/uibase/app/docstyle.cxx
+++ b/sw/source/uibase/app/docstyle.cxx
@@ -1779,7 +1779,7 @@ bool SwDocStyleSheet::FillStyleSheet( FillStyleType 
eFType )
 case SFX_STYLE_FAMILY_FRAME:
 pFrameFormat = lcl_FindFrameFormat(rDoc,  aName, this, bCreate);
 bPhysical = 0 != pFrameFormat;
-if( bFillOnlyInfo && bPhysical )
+if (bFillOnlyInfo && !bPhysical)
 {
 ::sw::UndoGuard const ug(rDoc.GetIDocumentUndoRedo());
 bDeleteInfo = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 94012] Constant crash after upgrade

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94012

--- Comment #2 from Vittorio F.  ---
(also when cutting lines, eliminating lines)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94012] Constant crash after upgrade

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94012

--- Comment #1 from Vittorio F.  ---
(also when cutting lines, eliminating lines)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94014] New: Target in Document dialog has icons with transparency issues

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94014

Bug ID: 94014
   Summary: Target in Document dialog has icons with transparency
issues
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com

Created attachment 118514
  --> https://bugs.documentfoundation.org/attachment.cgi?id=118514=edit
dialog

Steps:
1) Open Writer
2) Insert Hyperlink
3) Click Document tab
4) Click Target in Document button
5) Icons appear without their transparency

Version: 5.1.0.0.alpha1+
Build ID: cf9fbdb379e2935677a73ced513d7faf855c299c
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2015-09-05_00:34:47
Locale: en-US (en_US.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [Libreoffice-commits] core.git: basic/source "Revert a fix that can never have worked in the first place?"

2015-09-08 Thread Stephan Bergmann
...in case anybody can make any sense of what the original bugfix 
 
"INTEGRATION: CWS ab12fixes: #118234# SbiExpression::Term(): Allow Input 
as symbol for action option compatible" actually wanted to achieve, or 
what "Allow Input as symbol for action option compatible" shall even mean:


On 09/08/2015 10:58 AM, Stephan Bergmann wrote:

commit 4b4a7c0d87eb580272aba0777c9021789025bdc0
Author: Stephan Bergmann 
Date:   Tue Sep 8 10:48:43 2015 +0200

 Revert a fix that can never have worked in the first place?

 clang-analyzer-deadcode.DeadStores finds that conditionally assigning

   eTok = SYMBOL

 inside the "if( SbiTokenizer::IsKws( eTok ) )" block is useless, as the 
directly
 following

   if( DoParametersFollow( pParser, eCurExpr, eTok = eNextTok ) )

 will unconditionally assign into eTok again, without intermediate use of 
the old
 eTok value.

 Now, the conditional "eTok = SYMBOL" assignment was added as
 5d98ed5c6a4afc0a7943318c510e56aef8c45193 "INTEGRATION: CWS ab12fixes: 
#118234#
 SbiExpression::Term(): Allow Input as symbol for action option compatible,"
 while the unconditional "eTok = eNextTok" assignment had followed that 
block
 ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import."

 The referenced "#118234#" was a Sun-internal bug and is no longer 
available, but
 it does very much look as if this alleged bugfix never worked in the first
 place.  So revert the code back to what it looked before
 5d98ed5c6a4afc0a7943318c510e56aef8c45193, for now.

 Change-Id: I1fe1178d2c5b0c0372da32b8dd0f2dfbdb22a1ae

diff --git a/basic/source/comp/exprtree.cxx b/basic/source/comp/exprtree.cxx
index 190822c..8b22257 100644
--- a/basic/source/comp/exprtree.cxx
+++ b/basic/source/comp/exprtree.cxx
@@ -217,15 +217,8 @@ SbiExprNode* SbiExpression::Term( const KeywordSymbolInfo* 
pKeywordSymbolInfo )
  // no keywords allowed from here on!
  if( SbiTokenizer::IsKwd( eTok ) )
  {
-if( pParser->IsCompatible() && eTok == INPUT )
-{
-eTok = SYMBOL;
-}
-else
-{
-pParser->Error( ERRCODE_BASIC_SYNTAX );
-bError = true;
-}
+pParser->Error( ERRCODE_BASIC_SYNTAX );
+bError = true;
  }

  if( DoParametersFollow( pParser, eCurExpr, eTok = eNextTok ) )

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 94010] New: UI: Horizontal srcoll Wheel backwards with RTL sheet and kde4 ui

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94010

Bug ID: 94010
   Summary: UI: Horizontal srcoll Wheel backwards with RTL sheet
and kde4 ui
   Product: LibreOffice
   Version: unspecified
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bensa...@gmail.com

I am running libreoffice 5.0 git (having fix from bug #80512) and while the
scrollbar works now, when scrolling with the Horizontal Wheel it move in the
reverse direction.

(USING kde ui in english with RTL sheet)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: basic/source mergeclasses.results rsc/inc rsc/source vcl/source

2015-09-08 Thread Noel Grandin
 basic/source/classes/sbunoobj.cxx |   16 
 mergeclasses.results  |2 --
 rsc/inc/rsctree.hxx   |   38 ++
 rsc/source/tools/rsctree.cxx  |   24 
 vcl/source/filter/sgvmain.cxx |2 --
 vcl/source/filter/sgvmain.hxx |   11 +++
 6 files changed, 33 insertions(+), 60 deletions(-)

New commits:
commit 751c771adc45cb150fa42bc70397e2571b28a60b
Author: Noel Grandin 
Date:   Thu Aug 27 13:07:42 2015 +0200

loplugin:mergeclass, merge BiNode with NameNode, Obj0Type with ObjkType

Change-Id: Icbc0dfc6096a6e2c651dad4fe9f78d176f389390

diff --git a/basic/source/classes/sbunoobj.cxx 
b/basic/source/classes/sbunoobj.cxx
index da07e3b..c7a95f1 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -4311,18 +4311,9 @@ void RTL_Impl_CreateUnoValue( StarBASIC* pBasic, 
SbxArray& rPar, bool bWrite )
 
 
 
-namespace {
-class OMutexBasis
-{
-protected:
-// this mutex is necessary for OInterfaceContainerHelper
-::osl::Mutex m_aMutex;
-};
-} // namespace
-
-class ModuleInvocationProxy : public OMutexBasis,
-  public WeakImplHelper< XInvocation, XComponent >
+class ModuleInvocationProxy : public WeakImplHelper< XInvocation, XComponent >
 {
+::osl::Mutexm_aMutex;
 OUStringm_aPrefix;
 SbxObjectRefm_xScopeObj;
 boolm_bProxyIsClassModuleObject;
@@ -4357,7 +4348,8 @@ public:
 };
 
 ModuleInvocationProxy::ModuleInvocationProxy( const OUString& aPrefix, 
SbxObjectRef xScopeObj )
-: m_aPrefix( aPrefix + "_" )
+: m_aMutex()
+, m_aPrefix( aPrefix + "_" )
 , m_xScopeObj( xScopeObj )
 , m_aListeners( m_aMutex )
 {
diff --git a/mergeclasses.results b/mergeclasses.results
index 85739e1..572d9a4 100644
--- a/mergeclasses.results
+++ b/mergeclasses.results
@@ -5,7 +5,6 @@ merge AbstractMailMergeWizard with AbstractMailMergeWizard_Impl
 merge AbstractSearchProgress with AbstractSearchProgress_Impl
 merge AbstractSwInsertDBColAutoPilot with AbstractSwInsertDBColAutoPilot_Impl
 merge AbstractTakeProgress with AbstractTakeProgress_Impl
-merge BiNode with NameNode
 merge CffGlobal with CffSubsetterContext
 merge CompareLine with SwCompareLine
 merge DdeGetPutItem with sfx2::ImplDdeItem
@@ -53,7 +52,6 @@ merge ImplGlyphFallbackFontSubstitution with 
FcGlyphFallbackSubstititution
 merge ImplPreMatchFontSubstitution with FcPreMatchSubstititution
 merge LwpDLList with LwpParaProperty
 merge LwpDLVListHead with LwpPropList
-merge Obj0Type with ObjkType
 merge OldBasicPassword with basic::SfxScriptLibraryContainer
 merge OpenGLDeviceInfo with X11OpenGLDeviceInfo
 merge OpenGLSalBitmapOp with ScaleOp
diff --git a/rsc/inc/rsctree.hxx b/rsc/inc/rsctree.hxx
index 12ee456..f2f6ac2 100644
--- a/rsc/inc/rsctree.hxx
+++ b/rsc/inc/rsctree.hxx
@@ -22,40 +22,30 @@
 #include 
 #include 
 
-class BiNode
+class NameNode
 {
+voidSubOrderTree( NameNode * pOrderNode );
+
 protected:
-BiNode* pLeft;// left subtree
-BiNode* pRight;   // right subtree
+NameNode* pLeft;// left subtree
+NameNode* pRight;   // right subtree
 
-public:
+// pCmp ist Zeiger auf Namen
+NameNode*   Search( const void * pCmp ) const;
 
  // convert a double linked list into a binary tree
-BiNode *ChangeDLListBTree( BiNode * pList );
-
-BiNode();
-virtual ~BiNode();
+NameNode*   ChangeDLListBTree( NameNode * pList );
 
+NameNode();
+virtual ~NameNode();
 
 // convert a binary tree in a double linked list
-BiNode* ChangeBTreeDLList();
-
-BiNode *Left() const { return pLeft  ; }
-BiNode *Right() const{ return pRight ; }
-voidEnumNodes( Link<> aLink ) const;
-};
-
-class NameNode : public BiNode
-{
-voidSubOrderTree( NameNode * pOrderNode );
-
-protected:
-// pCmp is a pointer to name
-NameNode*   Search( const void * pCmp ) const;
+NameNode* ChangeBTreeDLList();
 
 public:
-NameNode*   Left() const { return static_cast(pLeft); }
-NameNode*   Right() const{ return static_cast(pRight); 
}
+voidEnumNodes( Link<> aLink ) const;
+NameNode*   Left() const { return pLeft; }
+NameNode*   Right() const{ return pRight; }
 NameNode*   Search( const NameNode * pName ) const;
 // insert a new node in the b-tree
 boolInsert( NameNode * pTN, sal_uInt32 * nDepth );
diff --git a/rsc/source/tools/rsctree.cxx b/rsc/source/tools/rsctree.cxx
index eb69285..8ee5036 100644
--- 

[Libreoffice-bugs] [Bug 94011] New: TABLE: Table border (dashed) is not saved

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94011

Bug ID: 94011
   Summary: TABLE: Table border (dashed) is not saved
   Product: LibreOffice
   Version: 4.4.3.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pellesi...@gmail.com

The border disappears after reopening the file.

Steps to reproduce:

1. Open a new write document
2. Create a table
3. Select the table properties
4. Change border style to dashed
5. save and reopen file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/source

2015-09-08 Thread Michael Stahl
 sw/source/core/doc/tblrwcl.cxx |   10 --
 1 file changed, 4 insertions(+), 6 deletions(-)

New commits:
commit 969ba5fe88c2f817f2121bb26f2d472cff891399
Author: Michael Stahl 
Date:   Fri Sep 4 21:53:34 2015 +0200

sw: erroneous vector assignment in SwTable::OldMerge()

+rLineBoxes = pFndBox->GetLines()[nEnd]->GetBoxes();

This actually assigns the boxes vector of the last line to the first
line, which the previous code didn't do.

Notably after converting the types from boost::ptr_vector to
std::vector, the assignment produces a several page
error message from both GCC and clang, and infuriatingly neither
compiler was able to tell on which line in tblrwcl.cxx the template
was instantiated, so i had to bisect that.

(regression from be5e4247e2a164bd1f2eacf9a33d6d73df16d0e3)

Change-Id: I646e3ca678895480d38ec48f38d720458860a985
(cherry picked from commit 8bf0e60d1da6d1ab79455dc916fd8701122812d2)
Reviewed-on: https://gerrit.libreoffice.org/18379
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/sw/source/core/doc/tblrwcl.cxx b/sw/source/core/doc/tblrwcl.cxx
index 08db77b..12c24a5 100644
--- a/sw/source/core/doc/tblrwcl.cxx
+++ b/sw/source/core/doc/tblrwcl.cxx
@@ -1613,17 +1613,15 @@ bool SwTable::OldMerge( SwDoc* pDoc, const SwSelBoxes& 
rBoxes,
 _InsULPara aPara( pTableNd, true, true, pLeftBox, pMergeBox, pRightBox, 
pInsLine );
 
 // Move the overlapping upper/lower Lines of the selected Area
-_FndBoxes& rLineBoxes = pFndBox->GetLines().front().GetBoxes();
-for (_FndBoxes::iterator it = rLineBoxes.begin(); it != rLineBoxes.end(); 
++it)
+for (auto & it : pFndBox->GetLines().front().GetBoxes())
 {
-lcl_Merge_MoveBox(*it, );
+lcl_Merge_MoveBox(it, );
 }
 aPara.SetLower( pInsLine );
 const auto nEnd = pFndBox->GetLines().size()-1;
-rLineBoxes = pFndBox->GetLines()[nEnd].GetBoxes();
-for (_FndBoxes::iterator it = rLineBoxes.begin(); it != rLineBoxes.end(); 
++it)
+for (auto & it : pFndBox->GetLines()[nEnd].GetBoxes())
 {
-lcl_Merge_MoveBox(*it, );
+lcl_Merge_MoveBox(it, );
 }
 
 // Move the Boxes extending into the selected Area from left/right
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-ux-advise] [Bug 90855] DIALOG: Improve the 'Insert Bookmark' dialog

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90855

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #3 from Yousuf (Jay) Philips  ---
(In reply to Björn Michaelsen from comment #2)
> Hmm, wouldnt it be better to simplify the dialog to really just cover the
> "insert bookmark" usecase?

Unfortunately navigator is not a beginner friendly (aka Benjamin) interface,
secondly there are users who wont use the sidebar due to screen resolution,
thirdly we should have a regularly used feature like bookmark management in
more than just the navigator.

> We have the navigator prominently in the sidebar
> now, and it appears to me to be a much more natural way to
> manage/delete/edit existing bookmarks.

Yes it would be great to have context menu entries for bookmarks for jump and
delete. For edit and manage, did you want to create another dialog for bookmark
management or were you thinking that you wanted it in as a sidebar tab?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/source

2015-09-08 Thread Michael Stahl
 sw/source/uibase/app/docstyle.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit d83fc62ada63ea784faeee72a29b414e3efa61b3
Author: Michael Stahl 
Date:   Mon Sep 7 20:41:11 2015 +0200

tdf#91383: sw: actually reset the modified status too

... when deleting the temporarily inserted styles in
SwDocStyleSheet::FillStyleSheet().

Change-Id: Id4abc067ce10b41486f659350267c7e3933db472
(cherry picked from commit 66133fd8882a070674bbb3803634c5e75e8ae772)
Reviewed-on: https://gerrit.libreoffice.org/18387
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/sw/source/uibase/app/docstyle.cxx 
b/sw/source/uibase/app/docstyle.cxx
index 6727cb8..08da17c 100644
--- a/sw/source/uibase/app/docstyle.cxx
+++ b/sw/source/uibase/app/docstyle.cxx
@@ -1779,6 +1779,7 @@ bool SwDocStyleSheet::FillStyleSheet(
 bool bDeleteInfo = false;
 bool bFillOnlyInfo = FillAllInfo == eFType || FillPreview == eFType;
 std::vector aDelArr;
+bool const isModified(rDoc.getIDocumentState().IsModified());
 
 switch(nFamily)
 {
@@ -1966,6 +1967,10 @@ bool SwDocStyleSheet::FillStyleSheet(
 {
 ::sw::UndoGuard const ug(rDoc.GetIDocumentUndoRedo());
 ::lcl_DeleteInfoStyles( static_cast< sal_uInt16 >(nFamily), aDelArr, 
rDoc );
+if (!isModified)
+{
+rDoc.getIDocumentState().ResetModified();
+}
 }
 return bRet;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 90855] DIALOG: Improve the 'Insert Bookmark' dialog

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90855

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #3 from Yousuf (Jay) Philips  ---
(In reply to Björn Michaelsen from comment #2)
> Hmm, wouldnt it be better to simplify the dialog to really just cover the
> "insert bookmark" usecase?

Unfortunately navigator is not a beginner friendly (aka Benjamin) interface,
secondly there are users who wont use the sidebar due to screen resolution,
thirdly we should have a regularly used feature like bookmark management in
more than just the navigator.

> We have the navigator prominently in the sidebar
> now, and it appears to me to be a much more natural way to
> manage/delete/edit existing bookmarks.

Yes it would be great to have context menu entries for bookmarks for jump and
delete. For edit and manage, did you want to create another dialog for bookmark
management or were you thinking that you wanted it in as a sidebar tab?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94009] FILESAVE: DOCX - Margins not preserve

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94009

steve -_-  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from steve -_-  ---
Resaved as new docx file. Problem confirmed on

OSX 10.10.5
LO Version: 5.1.0.0.alpha1+
Build ID: 50f2c712c46c66264279ab3b61888e491a4d8dca
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2015-09-04_04:59:19
Locale: de-DE (de.UTF-8)

Attaching screenshot.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94009] FILESAVE: DOCX - Margins not preserve

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94009

--- Comment #2 from steve -_-  ---
Created attachment 118515
  --> https://bugs.documentfoundation.org/attachment.cgi?id=118515=edit
bug confirmed, screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94012] Constant crash after upgrade

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94012

--- Comment #6 from Vittorio F.  ---
I had same result afterrenaming profile, a crash, attaching gdbtrace.log

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/inc sw/source

2015-09-08 Thread Michael Stahl
 sw/inc/IDocumentStatistics.hxx   |2 +-
 sw/source/core/doc/DocumentStatisticsManager.cxx |7 +--
 sw/source/core/inc/DocumentStatisticsManager.hxx |2 +-
 sw/source/uibase/app/docsh2.cxx  |5 +++--
 4 files changed, 10 insertions(+), 6 deletions(-)

New commits:
commit da094918215757fa61e969f819576f49b91701ba
Author: Michael Stahl 
Date:   Mon Sep 7 21:52:49 2015 +0200

sw: fix newly created document being modified

After the document is created, an event is dispatched on the main loop
that calls SfxPickList::Notify(), which modifies document properties.

It tries to prevent setting the document to modified by calling
SfxObjectShell::EnableSetModified(false), but Writer cunningly outwits
it by simply having its own independent(?) modified flag that is set
unconditionally in DocumentStatisticsManager::DocInfoChgd().

Let's assume that if the modified flag shouldn't be modified in
SfxObjectShell, it shouldn't be modified in DocumentStatisticsManager.

Somehow in 4.4 and 4.3 the same thing was going on, but it didn't result
in a visibly enabled Save icon in the UI, but with 5.0 it does - cannot
easily bisect why that changed due to tdf#91383.

Change-Id: Id30fd831eb29910c9fb44ed3031bf8da23586bea
(cherry picked from commit 5adc8ee343e5c32d30095bc4005b7b022016b745)
Reviewed-on: https://gerrit.libreoffice.org/18388
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/sw/inc/IDocumentStatistics.hxx b/sw/inc/IDocumentStatistics.hxx
index 7cb50ae..9f953d4 100644
--- a/sw/inc/IDocumentStatistics.hxx
+++ b/sw/inc/IDocumentStatistics.hxx
@@ -31,7 +31,7 @@ public:
 /** DocInfo has changed (notify via DocShell):
 make required fields update.
 */
-virtual void DocInfoChgd() = 0;
+virtual void DocInfoChgd(bool isEnableSetModified) = 0;
 
 /** Document - Statistics
 */
diff --git a/sw/source/core/doc/DocumentStatisticsManager.cxx 
b/sw/source/core/doc/DocumentStatisticsManager.cxx
index 4fed190..8525ab1 100644
--- a/sw/source/core/doc/DocumentStatisticsManager.cxx
+++ b/sw/source/core/doc/DocumentStatisticsManager.cxx
@@ -77,11 +77,14 @@ DocumentStatisticsManager::DocumentStatisticsManager( 
SwDoc& i_rSwdoc ) : m_rDoc
 maStatsUpdateTimer.SetTimeoutHdl( LINK( this, DocumentStatisticsManager, 
DoIdleStatsUpdate ) );
 }
 
-void DocumentStatisticsManager::DocInfoChgd( )
+void DocumentStatisticsManager::DocInfoChgd(bool const isEnableSetModified)
 {
 m_rDoc.getIDocumentFieldsAccess().GetSysFieldType( RES_DOCINFOFLD 
)->UpdateFields();
 m_rDoc.getIDocumentFieldsAccess().GetSysFieldType( RES_TEMPLNAMEFLD 
)->UpdateFields();
-m_rDoc.getIDocumentState().SetModified();
+if (isEnableSetModified)
+{
+m_rDoc.getIDocumentState().SetModified();
+}
 }
 
 const SwDocStat& DocumentStatisticsManager::GetDocStat() const
diff --git a/sw/source/core/inc/DocumentStatisticsManager.hxx 
b/sw/source/core/inc/DocumentStatisticsManager.hxx
index be1e78a..2ad06cc 100644
--- a/sw/source/core/inc/DocumentStatisticsManager.hxx
+++ b/sw/source/core/inc/DocumentStatisticsManager.hxx
@@ -37,7 +37,7 @@ public:
 
 DocumentStatisticsManager( SwDoc& i_rSwdoc );
 
-void DocInfoChgd() SAL_OVERRIDE;
+void DocInfoChgd(bool isEnableSetModified) SAL_OVERRIDE;
 const SwDocStat () const SAL_OVERRIDE;
 SwDocStat & GetDocStat(); //Non const version of the above, not part of 
the interface.
 const SwDocStat (bool bCompleteAsync = false, bool 
bFields = true) SAL_OVERRIDE;
diff --git a/sw/source/uibase/app/docsh2.cxx b/sw/source/uibase/app/docsh2.cxx
index d75d160..166cbeb 100644
--- a/sw/source/uibase/app/docsh2.cxx
+++ b/sw/source/uibase/app/docsh2.cxx
@@ -207,7 +207,7 @@ void SwDocShell::DoFlushDocInfo()
 m_pWrtShell->StartAllAction();
 }
 
-m_pDoc->getIDocumentStatistics().DocInfoChgd();
+m_pDoc->getIDocumentStatistics().DocInfoChgd(IsEnableSetModified());
 
 if (m_pWrtShell)
 {
@@ -296,8 +296,9 @@ void SwDocShell::Notify( SfxBroadcaster&, const SfxHint& 
rHint )
 EnableSetModified( false );
 // #i41679#
 const bool bIsDocModified = 
m_pDoc->getIDocumentState().IsModified();
+// TODO: is the ResetModified() below because of only the 
direct call from DocInfoChgd, or does UpdateFields() set it too?
 
-m_pDoc->getIDocumentStatistics().DocInfoChgd( );
+m_pDoc->getIDocumentStatistics().DocInfoChgd(false);
 
 // #i41679#
 if ( !bIsDocModified )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 45589] Show bookmarks: make them visible in a document

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45589

--- Comment #7 from Cor Nouws  ---
Hi Jay,

(In reply to Yousuf (Jay) Philips from comment #6)
> Dont think that it would be good to tie it in with non-printable characters,
> as we would want this feature on by default and not all users toggle the
> "pi" button.

Users are pretty keen on being able to handle settings for e.g. showing page
margins apart from non printable characters. I could imagine the same with
bookmarks? 

Say  Options > Writer > Formatting Aids ... Display of: [ ] Bookmarks

(For me, it's no problem to have it combined with no printable characters.)

> Google Docs is the only word processor that shows bookmarks and

>From what I remember Word had a setting to to show bookmarks.

> it does so in the margins, similar to how we show line numbers (attachment
> 113660 [details]).

In the text is the only thing that makes sense, IMO. Bookmarks can be single
points and selections. Bookmarks are (also) used to mark pieces in the text for
referencing, filling, ... So only an indicator in the margin, would not help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93421] EDITING, FORMATTING: template changes do not propagate to existing documents

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93421

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #5 from Beluga  ---
(In reply to Jan Bart from comment #4)
> Created attachment 118496 [details]
> document created and updated styles in LO4.0.5
> 
> If I change the (previously attached) template in LO5, to which this
> document was linked when created in LO4.0.5, and when this document is
> opened in LO5, I do not get the "updated styles" dialog.

Yes, it's true that it didn't ask to update, even though I have a modified
TempressManuals template in my templates folder.

Win 7 Pro 64-bit, Version: 5.0.1.2 (32-bit)
Build ID: 81898c9f5c0d43f3473ba111d7b351050be20261
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 3 commits - idl/inc idl/source mergeclasses.results sw/inc sw/source

2015-09-08 Thread Noel Grandin
 idl/inc/basobj.hxx  |   78 +++-
 idl/inc/bastype.hxx |   37 +---
 idl/inc/database.hxx|6 
 idl/inc/types.hxx   |8 
 idl/source/objects/basobj.cxx   |   30 +--
 idl/source/objects/bastype.cxx  |4 
 idl/source/objects/module.cxx   |2 
 idl/source/objects/object.cxx   |4 
 idl/source/objects/slot.cxx |4 
 idl/source/objects/types.cxx|8 
 idl/source/prj/database.cxx |2 
 mergeclasses.results|2 
 sw/inc/ndhints.hxx  |  142 +---
 sw/source/core/access/acchyperlink.cxx  |2 
 sw/source/core/access/accpara.cxx   |4 
 sw/source/core/crsr/callnk.cxx  |2 
 sw/source/core/crsr/crstrvl.cxx |2 
 sw/source/core/crsr/findattr.cxx|   16 -
 sw/source/core/crsr/findtxt.cxx |   22 +-
 sw/source/core/doc/DocumentContentOperationsManager.cxx |4 
 sw/source/core/doc/DocumentFieldsManager.cxx|2 
 sw/source/core/doc/dbgoutsw.cxx |2 
 sw/source/core/doc/docruby.cxx  |2 
 sw/source/core/doc/doctxm.cxx   |6 
 sw/source/core/docnode/nodes.cxx|4 
 sw/source/core/edit/acorrect.cxx|2 
 sw/source/core/edit/edattr.cxx  |2 
 sw/source/core/frmedt/fefly1.cxx|2 
 sw/source/core/table/swtable.cxx|2 
 sw/source/core/text/frmform.cxx |4 
 sw/source/core/text/itratr.cxx  |   24 +-
 sw/source/core/text/itrpaint.cxx|4 
 sw/source/core/text/itrtxt.cxx  |2 
 sw/source/core/text/porfly.cxx  |2 
 sw/source/core/text/porlay.cxx  |4 
 sw/source/core/text/pormulti.cxx|   12 -
 sw/source/core/text/txtfld.cxx  |6 
 sw/source/core/text/txtfrm.cxx  |4 
 sw/source/core/text/txtftn.cxx  |4 
 sw/source/core/tox/ToxTextGenerator.cxx |2 
 sw/source/core/txtnode/modeltoviewhelper.cxx|2 
 sw/source/core/txtnode/ndhints.cxx  |   67 +++
 sw/source/core/txtnode/ndtxt.cxx|   44 ++--
 sw/source/core/txtnode/thints.cxx   |   69 ---
 sw/source/core/txtnode/txatritr.cxx |2 
 sw/source/core/txtnode/txtedt.cxx   |6 
 sw/source/core/undo/rolbck.cxx  |2 
 sw/source/core/unocore/unocrsrhelper.cxx|4 
 sw/source/core/unocore/unoportenum.cxx  |   26 +-
 sw/source/filter/ascii/ascatr.cxx   |4 
 sw/source/filter/html/htmlatr.cxx   |6 
 sw/source/filter/html/swhtml.cxx|4 
 sw/source/filter/html/wrthtml.cxx   |2 
 sw/source/filter/ww8/wrtw8nds.cxx   |   16 -
 sw/source/filter/ww8/ww8par.cxx |2 
 55 files changed, 321 insertions(+), 406 deletions(-)

New commits:
commit d4c6a3883a38187effdd7414a0a07a9a2d3d026d
Author: Noel Grandin 
Date:   Fri Aug 28 11:53:11 2015 +0200

loplugin:mergeclasses merge SvMetaObject with SvMetaName

Change-Id: I8c65ad9a5e2141b6fdf578e1361f8685d2f8517e

diff --git a/idl/inc/basobj.hxx b/idl/inc/basobj.hxx
index 89ca0a6..71dc136 100644
--- a/idl/inc/basobj.hxx
+++ b/idl/inc/basobj.hxx
@@ -32,8 +32,23 @@ typedef SvMetaObject * (*CreateMetaObjectType)();
 
 #define C_PREF  "C_"
 
+class SvMetaObjectMemberList : public SvRefMemberList {};
+
 class SvMetaObject : public SvRttiBase
 {
+protected:
+SvString  aName;
+SvHelpContext aHelpContext;
+SvHelpTextaHelpText;
+SvString  aConfigName;
+SvString  aDescription;
+
+bool ReadNameSvIdl( SvIdlDataBase &, SvTokenStream & rInStm );
+void DoReadContextSvIdl( SvIdlDataBase &, SvTokenStream & rInStm,
+ char c = '\0' );
+virtual void ReadContextSvIdl( SvIdlDataBase &, SvTokenStream & rInStm );
+virtual void ReadAttributesSvIdl( SvIdlDataBase & rBase,
+  SvTokenStream & rInStm );
 public:
 TYPEINFO_OVERRIDE();
 SvMetaObject();
@@ -42,14 +57,17 @@ public:
 static void 

[Libreoffice-bugs] [Bug 94008] FILEOPEN: Crash opening password protected xlsx file

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94008

Kevin Suo  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from Kevin Suo  ---
(In reply to raal from comment #4)
Hi raal, I reported this bug regarding the 5.0.2.1 test build. If you are not
able to reproduce with 5.0.1.2, then it's a possible regression.

Changing back to UNCONFIRMED.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93953] Crash when accessing Tools > Macros > Organize Macros > Javascript

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93953

--- Comment #11 from Julien Nabet  ---
Yousuf: perhaps I'm wrong but the bt still shows "???".
It might be useful to use the other way to retrieve a bt, ie attach soffice
process to gdb
https://wiki.documentfoundation.org/Development/How_to_debug#Attaching_to_the_soffice.bin_process
then when it segfaults with "???", type "c" (for "continue") until you have
something else than "???". At this moment, just type "bt".
Hope it helps.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94009] FILESAVE: DOCX - Margins not preserve

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94009

Yousuf (Jay) Philips  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=83
   ||227

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94012] Constant crash after upgrade

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94012

--- Comment #5 from Vittorio F.  ---
Created attachment 118516
  --> https://bugs.documentfoundation.org/attachment.cgi?id=118516=edit
gdbtrace.log

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93396] LibreOffice 5.0 Crashes on Windows 8 64-bit when making JDBC connection (Windows 64bit)

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93396

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #6 from Beluga  ---
Any luck with bt?
https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg

Or any difference with LibO 5.0.1?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94007] Calc fails to paste long row of numbers from Excel

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94007

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #1 from raal  ---
Hello,

Thank you for filing the bug. Please send us a sample document, as this makes
it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO', so please do change it back to
'UNCONFIRMED' once you have attached a document.
(Please note that the attachment will be public, remove any sensitive
information before attaching it.)
How can I eliminate confidential data from a sample document?
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


a deadlock question

2015-09-08 Thread meilin
Hi,I had send a same mail a few days ago. But I didn't receive some helpful
mails, So I use another mail address to send you a mail for help.

I have a deadlock question to ask you.  I hope you can help me, thank you!
I am trying to program a ContextMenuInterceptor by C++ in Secondary
development. but when I program in notifyContextMenuExecute method like :

class ContextMenuInterceptor : public
WeakImplHelper1
{
virtual ContextMenuInterceptorAction SAL_CALL notifyContextMenuExecute(
const ContextMenuExecuteEvent& aEvent )
   throw (::css::uno::RuntimeException, ::std::exception);
}

ContextMenuInterceptorAction
ContextMenuInterceptor::notifyContextMenuExecute( const
ContextMenuExecuteEvent& aEvent )
{
 Reference xSupplier = aEvent.Selection;
 Any any = xSupplier->getSelection();
}

It leads to deadlock.

///mutli-threaded backtrace
main thread:
0  Id: 5418.4e60 Suspend: 1 Teb: 7efdd000 Unfrozen
ChildEBP RetAddr  Args to Child
00edd608 74dd15f7 0002 00edd658 0001
ntdll!ZwWaitForMultipleObjects+0x15 (FPO: [5,0,0])
00edd6a4 764b19f8 00edd658 00edd6cc 
KERNELBASE!WaitForMultipleObjectsEx+0x100 (FPO: [Non-Fpo])
00edd6ec 76f1086a 0002 7efde000 
kernel32!WaitForMultipleObjectsExImplementation+0xe0 (FPO: [Non-Fpo])
00edd740 76f10b69 005c 00edd7a8 
USER32!RealMsgWaitForMultipleObjectsEx+0x14d (FPO: [Non-Fpo])
00edd75c 0fcbca13 0001 00edd7a8 
USER32!MsgWaitForMultipleObjects+0x1f (FPO: [Non-Fpo])
00edd7a0 0fe359db 02e4  51ddb8ac sal3!osl_waitCondition+0x83
(FPO: [Non-Fpo]) (CONV: cdecl)
[d:\libreofficecomplie\4.3.3.2_pure_src\sal\osl\w32\conditn.c @ 99]
00edd7f8 0fe3ea74 0abb5a08  
cppu3!cppu_threadpool::JobQueue::enter+0x10b (FPO: [Non-Fpo]) (CONV:
thiscall)
[d:\libreofficecomplie\4.3.3.2_pure_src\cppu\source\threadpool\jobqueue.cxx
@ 81]
00edd840 0fe40c2d 00edd864 0abb5a08 
cppu3!cppu_threadpool::ThreadPool::enter+0x104 (FPO: [Non-Fpo]) (CONV:
thiscall)
[d:\libreofficecomplie\4.3.3.2_pure_src\cppu\source\threadpool\threadpool.cxx
@ 349]
00edd878 0b6c37e8 0abb5a08 00edd8b4 53ebaa3a
cppu3!uno_threadpool_enter+0x8d (FPO: [Non-Fpo]) (CONV: cdecl)
[d:\libreofficecomplie\4.3.3.2_pure_src\cppu\source\threadpool\threadpool.cxx
@ 454]
00edd908 0b6e6614 0b082100 00edd980 
binaryurplo!binaryurp::Bridge::makeCall+0x148 (FPO: [Non-Fpo]) (CONV:
thiscall)
[d:\libreofficecomplie\4.3.3.2_pure_src\binaryurp\source\bridge.cxx @ 626]
00edda14 0b6e61d2 0b095768 00eddc48 00eddb00
binaryurplo!binaryurp::Proxy::do_dispatch_throw+0x294 (FPO: [Non-Fpo])
(CONV: thiscall)
[d:\libreofficecomplie\4.3.3.2_pure_src\binaryurp\source\proxy.cxx @ 184]
00eddaac 0b6e6c86 0b095768 00eddc48 00eddb00
binaryurplo!binaryurp::Proxy::do_dispatch+0x52 (FPO: [Non-Fpo]) (CONV:
thiscall)
[d:\libreofficecomplie\4.3.3.2_pure_src\binaryurp\source\proxy.cxx @ 107]
00eddac4 085629cb 0b0820f0 0b095768 00eddc48
binaryurplo!proxy_dispatchInterface+0x36 (FPO: [Non-Fpo]) (CONV: cdecl)
[d:\libreofficecomplie\4.3.3.2_pure_src\binaryurp\source\proxy.cxx @ 61]
00eddb8c 08562fc0 0b0f9a88 0b095768 0b09e430 msci_uno!`anonymous
namespace'::cpp2uno_call+0x2eb (FPO: [Non-Fpo]) (CONV: cdecl)
[d:\libreofficecomplie\4.3.3.2_pure_src\bridges\source\cpp_uno\msvc_win32_intel\cpp2uno.cxx
@ 155]
00eddc30 08563091 00eddc50 0003  msci_uno!`anonymous
namespace'::cpp_mediate+0x3e0 (FPO: [Non-Fpo]) (CONV: cdecl)
[d:\libreofficecomplie\4.3.3.2_pure_src\bridges\source\cpp_uno\msvc_win32_intel\cpp2uno.cxx
@ 334]
00eddc4c 055a0d6c 0b0f9a9c 00eddd00 51ddb52f msci_uno!`anonymous
namespace'::cpp_vtable_call+0x11 (FPO: [Non-Fpo]) (CONV: cdecl)
[d:\libreofficecomplie\4.3.3.2_pure_src\bridges\source\cpp_uno\msvc_win32_intel\cpp2uno.cxx
@ 366]
00eddcec 054e288d 0b045970 00edde28 00edde30
sfxlo!SfxViewShell::TryContextMenuInterception+0x1bc (FPO: [Non-Fpo])
(CONV: thiscall)
[d:\libreofficecomplie\4.3.3.2_pure_src\sfx2\source\view\viewsh.cxx @ 1976]
00edde6c 055aa313 0adcb3b8 0adda8f0 00edde90
sfxlo!SfxPopupMenuManager::ExecutePopup+0x37d (FPO: [Non-Fpo]) (CONV:
cdecl) [d:\libreofficecomplie\4.3.3.2_pure_src\sfx2\source\menu\mnumgr.cxx
@ 423]
00eddeb8 1929c64d 00eddf2c  0add4ae0
sfxlo!SfxDispatcher::ExecutePopup+0x153 (FPO: [Non-Fpo]) (CONV: cdecl)
[d:\libreofficecomplie\4.3.3.2_pure_src\sfx2\source\control\dispatch.cxx @
2181]
00ede17c 04a514d5 00ede1a0 51dd8810 0add4ae0 swlo!SwEditWin::Command+0x5ed
(FPO: [Non-Fpo]) (CONV: thiscall)
[d:\libreofficecomplie\4.3.3.2_pure_src\sw\source\core\uibase\docvw\edtwin.cxx
@ 5349]


child thread:
19  Id: 5418.55f4 Suspend: 1 Teb: 7ef84000 Unfrozen
ChildEBP RetAddr  Args to Child
1ffdf178 7742d993 0144  
ntdll!NtWaitForSingleObject+0x15 (FPO: [3,0,0])
1ffdf1dc 7742d877   0ad7ba60
ntdll!RtlpWaitOnCriticalSection+0x13e (FPO: [Non-Fpo])
1ffdf204 0fcbcf85 002a0958 002a0958 1ffdf228
ntdll!RtlEnterCriticalSection+0x150 (FPO: [Non-Fpo])
1ffdf214 04918bc5 002a0958 002a092c 002a1820 sal3!osl_acquireMutex+0x45
(FPO: 

[Libreoffice-bugs] [Bug 94009] New: FILESAVE: DOCX - Margins not preserve

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94009

Bug ID: 94009
   Summary: FILESAVE: DOCX - Margins not preserve
   Product: LibreOffice
   Version: 4.2.8.2 release
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Keywords: regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com

Steps:
1) Open GB_2013.docx in attachment 105410
2) Notice that the page margins are 0.00 on all sides
3) Save As a new file
4) Open up the new file
5) Notice the page top and bottom margins are 1.00

Regression as this worked correctly in 4.1.6. The saved document also doesnt
open in Word 2010 and gives the error 'Invalid parameter. Location: Part:
/word/document.xml, Line: 2, Column: 0'.

Version: 5.1.0.0.alpha1+
Build ID: cf9fbdb379e2935677a73ced513d7faf855c299c
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2015-09-05_00:34:47
Locale: en-US (en_US.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88206

--- Comment #49 from Commit Notification 
 ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bfa5b13b42770fb709dc2af7cab7aff1942eaa50

toolkit: tdf#88206 replace cppu::WeakImplHelper* etc.

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94012] Constant crash after upgrade

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94012

--- Comment #3 from Vittorio F.  ---
Also when scrolling mouse

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 58118] installation stops with error message 1303

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=58118

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||todven...@suomi24.fi
 Resolution|--- |NOTOURBUG

--- Comment #10 from Beluga  ---
Closing as NOTOURBUG per comment 8.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 39468] translate German comments, removing redundant ones

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39468

--- Comment #208 from Commit Notification 
 ---
Albert Thuswaldner committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=607197f6ce494ed8672b0e5c44d975ad942f00fa

tdf#39468 translated german comments in tabvwshc.cxx and tabvwshd.cxx

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2015-09-08 Thread Albert Thuswaldner
 sc/source/ui/view/tabvwshc.cxx |   24 
 sc/source/ui/view/tabvwshd.cxx |2 +-
 2 files changed, 13 insertions(+), 13 deletions(-)

New commits:
commit 607197f6ce494ed8672b0e5c44d975ad942f00fa
Author: Albert Thuswaldner 
Date:   Fri Sep 4 21:00:11 2015 +0200

tdf#39468 translated german comments in tabvwshc.cxx and tabvwshd.cxx

Change-Id: I1dd4c8a27bb63a91bead11d386748cd9cf2fe31c
Reviewed-on: https://gerrit.libreoffice.org/18349
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/view/tabvwshc.cxx b/sc/source/ui/view/tabvwshc.cxx
index 38502d2..6b8118e 100644
--- a/sc/source/ui/view/tabvwshc.cxx
+++ b/sc/source/ui/view/tabvwshc.cxx
@@ -118,8 +118,8 @@ VclPtr ScTabViewShell::CreateRefDialog(
 SfxChildWinInfo* pInfo,
 vcl::Window* pParent, sal_uInt16 nSlotId )
 {
-//  Dialog nur aufmachen, wenn ueber ScModule::SetRefDialog gerufen, damit
-//  z.B. nach einem Absturz offene Ref-Dialoge nicht wiederkommen 
(#42341#).
+// only open dialog when called through ScModule::SetRefDialog,
+// so that it does not re appear for instance after a crash (#42341#).
 
 if ( SC_MOD()->GetCurRefDlgId() != nSlotId )
 return NULL;
@@ -236,7 +236,7 @@ VclPtr ScTabViewShell::CreateRefDialog(
 
 case SID_DEFINE_DBNAME:
 {
-//  wenn auf einem bestehenden Bereich aufgerufen, den markieren
+// when called for an existing range, then mark
 GetDBData( true, SC_DB_OLD );
 const ScMarkData& rMark = GetViewData().GetMarkData();
 if ( !rMark.IsMarked() && !rMark.IsMultiMarked() )
@@ -268,7 +268,7 @@ VclPtr ScTabViewShell::CreateRefDialog(
 
 aArgSet.Put( aItem );
 
-// aktuelle Tabelle merken (wg. RefInput im Dialog)
+// mark current sheet (due to RefInput in dialog)
 GetViewData().SetRefTabNo( GetViewData().GetTabNo() );
 
 pResult = VclPtr::Create( pB, pCW, pParent, 
aArgSet );
@@ -295,7 +295,7 @@ VclPtr ScTabViewShell::CreateRefDialog(
   (),
) );
 
-// aktuelle Tabelle merken (wg. RefInput im Dialog)
+// mark current sheet (due to RefInput in dialog)
 GetViewData().SetRefTabNo( GetViewData().GetTabNo() );
 
 pResult = VclPtr::Create( pB, pCW, pParent, aArgSet );
@@ -406,7 +406,7 @@ VclPtr ScTabViewShell::CreateRefDialog(
 
 case SID_OPENDLG_PIVOTTABLE:
 {
-//  all settings must be in pDialogDPObject
+// all settings must be in pDialogDPObject
 
 if( pDialogDPObject )
 {
@@ -427,7 +427,7 @@ VclPtr ScTabViewShell::CreateRefDialog(
 
 case SID_OPENDLG_FUNCTION:
 {
-//  Dialog schaut selber, was in der Zelle steht
+// dialog checks, what is in the cell
 
 pResult = VclPtr::Create( pB, pCW, pParent, 
(),ScGlobal::GetStarCalcFunctionMgr() );
 }
@@ -443,7 +443,7 @@ VclPtr ScTabViewShell::CreateRefDialog(
 
 case FID_CHG_SHOW:
 {
-//  Dialog schaut selber, was in der Zelle steht
+// dialog checks, what is in the cell
 
 pResult = VclPtr::Create( pB, pCW, pParent, 
() );
 }
@@ -451,7 +451,7 @@ VclPtr ScTabViewShell::CreateRefDialog(
 
 case WID_SIMPLE_REF:
 {
-//  Dialog schaut selber, was in der Zelle steht
+// dialog checks, what is in the cell
 
 ScViewData& rViewData = GetViewData();
 rViewData.SetRefTabNo( rViewData.GetTabNo() );
@@ -518,9 +518,9 @@ VclPtr ScTabViewShell::CreateRefDialog(
 
 if (pResult)
 {
-//  Die Dialoge gehen immer mit eingeklapptem Zusaetze-Button auf,
-//  darum muss die Groesse ueber das Initialize gerettet werden
-//  (oder den Zusaetze-Status mit speichern !!!)
+// the dialogs are always displayed with the option button collapsed,
+// the size has to be carried over initialize
+// (or store the option status !!!)
 
 Size aSize = pResult->GetSizePixel();
 pResult->Initialize( pInfo );
diff --git a/sc/source/ui/view/tabvwshd.cxx b/sc/source/ui/view/tabvwshd.cxx
index de13fc6..1602ef5 100644
--- a/sc/source/ui/view/tabvwshd.cxx
+++ b/sc/source/ui/view/tabvwshd.cxx
@@ -32,7 +32,7 @@
 
 // STATIC DATA ---
 
-//! Parent-Window fuer Dialoge
+//! parent window for dialogs
 //! Problem: OLE Server!
 
 vcl::Window* ScTabViewShell::GetDialogParent()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Bug 39468] translate German comments, removing redundant ones

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39468

--- Comment #208 from Commit Notification 
 ---
Albert Thuswaldner committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=607197f6ce494ed8672b0e5c44d975ad942f00fa

tdf#39468 translated german comments in tabvwshc.cxx and tabvwshd.cxx

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: basic/source

2015-09-08 Thread Stephan Bergmann
 basic/source/comp/exprtree.cxx |   11 ++-
 1 file changed, 2 insertions(+), 9 deletions(-)

New commits:
commit 4b4a7c0d87eb580272aba0777c9021789025bdc0
Author: Stephan Bergmann 
Date:   Tue Sep 8 10:48:43 2015 +0200

Revert a fix that can never have worked in the first place?

clang-analyzer-deadcode.DeadStores finds that conditionally assigning

  eTok = SYMBOL

inside the "if( SbiTokenizer::IsKws( eTok ) )" block is useless, as the 
directly
following

  if( DoParametersFollow( pParser, eCurExpr, eTok = eNextTok ) )

will unconditionally assign into eTok again, without intermediate use of 
the old
eTok value.

Now, the conditional "eTok = SYMBOL" assignment was added as
5d98ed5c6a4afc0a7943318c510e56aef8c45193 "INTEGRATION: CWS ab12fixes: 
#118234#
SbiExpression::Term(): Allow Input as symbol for action option compatible,"
while the unconditional "eTok = eNextTok" assignment had followed that block
ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import."

The referenced "#118234#" was a Sun-internal bug and is no longer 
available, but
it does very much look as if this alleged bugfix never worked in the first
place.  So revert the code back to what it looked before
5d98ed5c6a4afc0a7943318c510e56aef8c45193, for now.

Change-Id: I1fe1178d2c5b0c0372da32b8dd0f2dfbdb22a1ae

diff --git a/basic/source/comp/exprtree.cxx b/basic/source/comp/exprtree.cxx
index 190822c..8b22257 100644
--- a/basic/source/comp/exprtree.cxx
+++ b/basic/source/comp/exprtree.cxx
@@ -217,15 +217,8 @@ SbiExprNode* SbiExpression::Term( const KeywordSymbolInfo* 
pKeywordSymbolInfo )
 // no keywords allowed from here on!
 if( SbiTokenizer::IsKwd( eTok ) )
 {
-if( pParser->IsCompatible() && eTok == INPUT )
-{
-eTok = SYMBOL;
-}
-else
-{
-pParser->Error( ERRCODE_BASIC_SYNTAX );
-bError = true;
-}
+pParser->Error( ERRCODE_BASIC_SYNTAX );
+bError = true;
 }
 
 if( DoParametersFollow( pParser, eCurExpr, eTok = eNextTok ) )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - include/svl svl/source svx/source sw/inc sw/source

2015-09-08 Thread Michael Stahl
 include/svl/style.hxx|5 +
 svl/source/items/style.cxx   |5 +
 svx/source/styles/CommonStylePreviewRenderer.cxx |   36 ++-
 svx/source/tbxctrls/tbcontrl.cxx |   35 ++-
 sw/inc/docstyle.hxx  |7 +-
 sw/source/uibase/app/docstyle.cxx|   70 ++-
 6 files changed, 121 insertions(+), 37 deletions(-)

New commits:
commit 19347304b2594f28fadf7cefe6aab4fdb5c9047f
Author: Michael Stahl 
Date:   Mon Sep 7 16:36:24 2015 +0200

tdf#91383: sw: prevent style preview from actually creating styles

The dialog/sidebar should not actually create styles that don't exist yet,
because it messes up Undo and the (unused) styles are then unnecessarily
exported to documents.

Due to Writer's ... unusual SwDocStyleSheet class this is a bit tricky.

Add a new function GetItemSetForPreview() and use it from the style preview
code.

The implementation does not use FillPhysical so will temporarily create and
then delete any non-existing styles.

Skip page and numbering styles for now since they don't have a useful 
preview.

(regression from ca95307638207db5d662059aa61594151a13e927)

(cherry picked from commit 93067f37cf22aa119db5878c4345fea500cbbb42)

-Werror,-Wreturn-type
(cherry picked from commit 0ed64030f17849ea943800343003c5ec3f4f1388)

Change-Id: Id6ee30ea467fc24c991547a4c23a9ce14fdd86c7
Reviewed-on: https://gerrit.libreoffice.org/18381
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/include/svl/style.hxx b/include/svl/style.hxx
index 5798b49..79eadf6 100644
--- a/include/svl/style.hxx
+++ b/include/svl/style.hxx
@@ -143,6 +143,11 @@ public:
 virtual void   SetHelpId( const OUString& r, sal_uLong nId );
 
 virtual SfxItemSet& GetItemSet();
+/// Due to writer's usual lack of sanity this is a separate function for
+/// preview only; it shall not create the style in case it does not exist.
+/// If the style has parents, it is _not_ required that the returned item
+/// set has parents (i.e. use it for display purposes only).
+virtual std::unique_ptr GetItemSetForPreview();
 };
 
 /* Class to iterate and search on a SfxStyleSheetBasePool */
diff --git a/svl/source/items/style.cxx b/svl/source/items/style.cxx
index bbbd45e..01da088 100644
--- a/svl/source/items/style.cxx
+++ b/svl/source/items/style.cxx
@@ -284,6 +284,11 @@ SfxItemSet& SfxStyleSheetBase::GetItemSet()
 return *pSet;
 }
 
+std::unique_ptr SfxStyleSheetBase::GetItemSetForPreview()
+{
+return std::unique_ptr(new SfxItemSet(GetItemSet()));
+}
+
 /**
  * Set help file and ID and return it
  */
diff --git a/svx/source/styles/CommonStylePreviewRenderer.cxx 
b/svx/source/styles/CommonStylePreviewRenderer.cxx
index ab1271a..67f9b89 100644
--- a/svx/source/styles/CommonStylePreviewRenderer.cxx
+++ b/svx/source/styles/CommonStylePreviewRenderer.cxx
@@ -60,65 +60,67 @@ CommonStylePreviewRenderer::~CommonStylePreviewRenderer()
 
 bool CommonStylePreviewRenderer::recalculate()
 {
-const SfxItemSet& aItemSet = mpStyle->GetItemSet();
-
 maFont = SvxFont();
 
+std::unique_ptr pItemSet(mpStyle->GetItemSetForPreview());
+
+if (!pItemSet) return false;
+
 const SfxPoolItem* pItem;
 
-if ((pItem = aItemSet.GetItem(SID_ATTR_CHAR_WEIGHT)) != nullptr)
+if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_WEIGHT)) != nullptr)
 {
 maFont.SetWeight(static_cast(pItem)->GetWeight());
 }
-if ((pItem = aItemSet.GetItem(SID_ATTR_CHAR_POSTURE)) != nullptr)
+if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_POSTURE)) != nullptr)
 {
 maFont.SetItalic(static_cast(pItem)->GetPosture());
 }
-if ((pItem = aItemSet.GetItem(SID_ATTR_CHAR_CONTOUR)) != nullptr)
+if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_CONTOUR)) != nullptr)
 {
 maFont.SetOutline(static_cast< const 
SvxContourItem*>(pItem)->GetValue());
 }
-if ((pItem = aItemSet.GetItem(SID_ATTR_CHAR_SHADOWED)) != nullptr)
+if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_SHADOWED)) != nullptr)
 {
 maFont.SetShadow(static_cast(pItem)->GetValue());
 }
-if ((pItem = aItemSet.GetItem(SID_ATTR_CHAR_RELIEF)) != nullptr)
+if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_RELIEF)) != nullptr)
 {
 maFont.SetRelief(static_cast(static_cast(pItem)->GetValue()));
 }
-if ((pItem = aItemSet.GetItem(SID_ATTR_CHAR_UNDERLINE)) != nullptr)
+if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_UNDERLINE)) != nullptr)
 {
 maFont.SetUnderline(static_cast< const 
SvxUnderlineItem*>(pItem)->GetLineStyle());
 }
-if ((pItem = aItemSet.GetItem(SID_ATTR_CHAR_OVERLINE)) != nullptr)
+if ((pItem = pItemSet->GetItem(SID_ATTR_CHAR_OVERLINE)) != nullptr)
 {
 

[Libreoffice-bugs] [Bug 93494] "Replace image" duplicates AutoCaption

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93494

Christian Pietzsch  changed:

   What|Removed |Added

Version|4.4.5.2 release |4.4.0.0.beta1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93494] "Replace image" duplicates AutoCaption

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93494

--- Comment #4 from Christian Pietzsch  ---
Did another test with LibreOffice 4.4.0.0 beta 1 (first release with change
image feature)
The bug is present in this version so it has been their since the introduction
of the feature.
Tried to see how it is handled in the code but I wasn't able to understand how
work with gerrit. Going to try it later.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


RE: df#50950 sort out Calc (ISO)WEEKNUM functions

2015-09-08 Thread Winfried Donkers
Hi Eike,

> > I'm a bit lost here. Maybe we need to sort that out from scratch again.
> > This appears to be the most complicated change in function names we're
> > tackling because of the different functions AND having an Add-In
> > function involved AND different names for similar but not quite
> > identical functions in UI and file formats.
> As you know, the problem is that the ODFF function name ISOWEEKNUM is
> currently used for a function with WEEKNUM functionality.

This keep nagging me and I have a suggestion which will make that we lose less 
time once I start implementing the ODFF1.2 ISOWEEKNUM function:

1.
I propose to change the saved function name for the current WEEKNUM function 
and to add backward compatibility to read saved ISOWEEKNUM and automatically 
redirect to WEEKNUM.

2.
This way ISOWEEKNUM will get 'obsolete' in saved documents, making it possible 
to add the ODFF1.2 IDSOWEEKNUM function to Calc one or more versions after step 
1.

I hope I didn't write in riddles ;)

Winfried
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 42451] .wpd doc opens without links

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=42451

David Tardon  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |dtar...@redhat.com
   |desktop.org |

--- Comment #8 from David Tardon  ---
All hyperlinks in the samples are on images. Do you have any sample with a
hyperlink in text? These might be represented differently.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94016] META: Bugs and enhancements for Wikihelp

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94016

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Depends on||94018

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94018] New: WIKIHELP: Switch application tag not rendered correctly

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94018

Bug ID: 94018
   Summary: WIKIHELP: Switch application tag not rendered
correctly
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 94016

When  is encountered in a help file, the wiki converter doesnt output
anything when its an appl switch.

Example File - /text/shared/01/0102.xhp
Wikihelp URL - https://help.libreoffice.org/Common/Open_1#Read-only


 
  
  Play
  Plays the selected sound file. ...
 


Wikihelp page outputs "When in Impress: {{{1}}}"

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94020] New: LOCALHELP/WIKIHELP: Large icons should be used

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94020

Bug ID: 94020
   Summary: LOCALHELP/WIKIHELP: Large icons should be used
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com

The default icons shown in LibreOffice are large (24x24) rather than small
(16x16) on all platforms since 4.4, so the help and wikihelp should show it as
well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93525] Writer EDITING: Crash on deleting text (Unknown event notification 36)

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93525

--- Comment #8 from Andrew Ridgway  ---
Created attachment 118517
  --> https://bugs.documentfoundation.org/attachment.cgi?id=118517=edit
bug 93525 backtrace

backtrace as requested Maxim Monastirsky 

exporting SAL_USE_VCLPLUGIN=gtk did not help

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93525] Writer EDITING: Crash on deleting text (Unknown event notification 36)

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93525

--- Comment #10 from Maxim Monastirsky  ---
(In reply to Tristan Miller from comment #9)
> Created attachment 118518 [details]
> Backtrace following crash
@Tristan: Your backtrace is very different from Andrew's one, so I'm afraid
it's a different problem.

> SAL_USE_VCLPLUGIN=gtk doesn't help for me either.
That's strange, because your backtrace clearly indicates it's GTK3 related.
Make sure you're exporting it in the same terminal where you're starting LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93776] Import of Word Doc formatting errors with text box locations

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93776

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #2 from Cor Nouws  ---
One report, one single problem ? :)

Would be great if that could be done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93784] FORMATTING: text jumps to the next page 'without reason?' or because frame is anchored in it

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93784

--- Comment #2 from Milan Bouchet-Valat  ---
Yeah, maybe that's reasonable, I don't know. What would be great is a way to
have a "loose anchoring" à la LaTex, where the anchor would merely represent
the ideal position to put the frame/image. It would move to the next page if
needed. That would really be helpful for long documents (like theses). But
that's beyond the scope of a bug report... :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93901] "Edit Paragraph Style" dialog does not save changes anymore after using "apply" button

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93901

Oliver Specht  changed:

   What|Removed |Added

 CC||oliver.spe...@cib.de

--- Comment #7 from Oliver Specht  ---
Happens with most (if not all) attributes. The controls on the tabpages
remember their initial values to prevent sending unchanged items. Those initial
values are not updated on 'Apply'. As a result it is not possible to go back to
the initial value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93640] Footer from DOCX Is Missing When Odd/Even Footers Are Different in MS Office

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93640

Cor Nouws  changed:

   What|Removed |Added

   Keywords||regression
 CC||c...@nouenoff.nl
 Whiteboard|filter:docx |filter:docx bibisectrequest

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94024] New: ZOrder of Shapes stops increment after 65535 Shapes

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94024

Bug ID: 94024
   Summary: ZOrder of Shapes stops increment after 65535 Shapes
   Product: LibreOffice
   Version: 4.0.3.3 release
  Hardware: Other
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: muriel.mau...@vector.com

We have integrated LibreOffice in out Tool, and we are creating some Shapes
programmatically in sdraw.
After a few Shapes (more than 65535) the Shapes are not shown as expected (some
are in Back or other, while they should be in Front). 
This is because the ZOrder of the Shapes are not incremented after 65535.

I have wrote a Macro to reproduce it (see end of the Description)

In LibreOffice 4.0.3.3 it is reproducible.
I have tried to reproduce it in LibreOffice 5.0.0.5, but the program crashed
after a couple of time and the macro will not finish.

Macro:
Dim shapeSize As new com.sun.star.awt.Size
   Dim shapePos As new com.sun.star.awt.Point
   Dim I 
   Dim shape

shapeSize.width = 2000
  shapeSize.height = 3000

  document = ThisComponent
drawPage = document.DrawPages(0)

For I = 1 To 65540 Step 1

shape = document.createInstance("com.sun.star.drawing.RectangleShape")
drawPage.add(shape)

'shape.ZOrder = i

  shapePos.X = i
  shapePos.Y = i
shape.setPosition(shapePos)
shape.setSize(shapeSize)

 If shape.ZOrder > 65534 Then
 MsgBox shape.ZOrder
 End If

Next I

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 76644] extended tips missing for menu items

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76644

Jan Holesovsky  changed:

   What|Removed |Added

 Whiteboard||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94017] New: WIKIHELP: Imported heading 1 entries should be embedded as heading 2

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94017

Bug ID: 94017
   Summary: WIKIHELP: Imported heading 1 entries should be
embedded as heading 2
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 94016

When  entries are used to bring in a section, the heading in that
section has to be turned from level 1 to level 2, as level 1 is for page
titles.

Example File - /text/swriter/main0101.xhp
Syntax - 
Wikihelp URL - https://help.libreoffice.org/Writer/File

Notice that New comes in as "= [[Common/New|New]] =" while the non embedded
Open comes is "== [[Common/Open_1|Open]] ==".

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94016] META: Bugs and enhancements for Wikihelp

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94016

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Depends on||94017

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 54882] Calc will not open a file containing a colon from command line

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=54882

--- Comment #5 from Stephan Bergmann  ---
(What /is/ a bug, though, is that LO silently fails for command line URLs that
it doesn't know how to handle, like , without giving any error
message to the user.  But I'm almost certain there is already a bug report for
that.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94019] New: Inconsistent behaviour when drag-moving a chart, chart doesn't always move with mouse.

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94019

Bug ID: 94019
   Summary: Inconsistent behaviour when drag-moving a chart, chart
doesn't always move with mouse.
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kie...@gmail.com

What happens:
Click and hold left mouse button on chart to drag it, start dragging but chart
is not shown being dragged so it is difficult to see where you are dragging the
chart to.

When this happens, the mouse pointer has a small rectangle with it indicating
dragging is in effect - this only appears when the chart itself is not being
(displayed as being) dragged. 

Expected:
Chart is always shown when being dragged so that it can easily be placed where
desired.

Reproducible: Yes, sometimes, I can't work out how to reproduce it other than
keep trying. Clicking on different cells and dragging different charts causes
this to happen sometimes with no apparent cause. Also one time the chart
momentarily started dragging and then switched to not displaying dragging,
another time the chart failed to drag at all. The code which decides whether or
not something is being dragged seems to be a bit buggy.

Why does the rectangle appear with the mouse pointer instead of dragging the
actual chart? Does this appear when some part of the programs or perhaps
hardware acceleration fails? It seems like a kludge to get around a bug.

Windows 7, Nvidia video card, Calc 5.0.0.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93887] Crash when pasting with the middle mouse button (GTK3)

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93887

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||momonas...@gmail.com
Summary|Writer: Crash when clicking |Crash when pasting with the
   |the middle mouse button |middle mouse button (GTK3)
   |click paste |

--- Comment #11 from Maxim Monastirsky  ---
This one is hard to reproduce, but I finally reproduced it with master under
Fedora 22 (64-bit). There is an infinite recursion of this stuff:

#21813 0x7fffe9c03c2f in g_closure_invoke () at /lib64/libgobject-2.0.so.0
#21814 0x7fffe9c15539 in signal_emit_unlocked_R () at
/lib64/libgobject-2.0.so.0
#21815 0x7fffe9c1def0 in g_signal_emit_valist () at
/lib64/libgobject-2.0.so.0
#21816 0x7fffe9c1e765 in g_signal_emit_by_name () at
/lib64/libgobject-2.0.so.0
#21817 0x7fffd8d119fb in gtk_selection_invoke_handler () at
/lib64/libgtk-3.so.0
#21818 0x7fffd8d11ccf in gtk_selection_convert () at /lib64/libgtk-3.so.0
#21819 0x7fffd8decbec in gtk_clipboard_wait_for_contents () at
/lib64/libgtk-3.so.0
#21820 0x7fffd93cd40e in
GtkTransferable::getTransferData(com::sun::star::datatransfer::DataFlavor
const&) (this=0x5678640, rFlavor=...) at
/run/media/maxim/SAMSUNG/libreoffice/master/vcl/unx/gtk3/app/gtk3gtkinst.cxx:138
#21821 0x7fffd93c94b2 in VclGtkClipboard::ClipboardGet(_GtkClipboard*,
_GtkSelectionData*, unsigned int) (this=0x50c37c0,
selection_data=0x7fc86aa0, info=0) at
/run/media/maxim/SAMSUNG/libreoffice/master/vcl/unx/gtk3/app/gtk3gtkinst.cxx:401
#21822 0x7fffd93c9d54 in (anonymous
namespace)::ClipboardGetFunc(GtkClipboard*, GtkSelectionData*, guint, gpointer)
(clipboard=0x14de800, selection_data=0x7fc86aa0, info=0,
user_data_or_owner=0x50c4360) at
/run/media/maxim/SAMSUNG/libreoffice/master/vcl/unx/gtk3/app/gtk3gtkinst.cxx:486


Had to kill gdb manually after it wrote a stack of ~22000 items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93525] Writer EDITING: Crash on deleting text (Unknown event notification 36)

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93525

--- Comment #9 from Tristan Miller  ---
Created attachment 118518
  --> https://bugs.documentfoundation.org/attachment.cgi?id=118518=edit
Backtrace following crash

SAL_USE_VCLPLUGIN=gtk doesn't help for me either.  See attached backtrace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90773] FILEOPEN: Long delay while opening impress presentations

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90773

--- Comment #14 from Thorsten Wagner  ---
Significant Impress performance issues still exist in LO 5.0.1, 5.0.2, and
master. Typing of characters as well as inserting objects and many other
operations become very slow after a while. Creating a presentation with Impress
from LO 5 is very annoying. I'm able to use LO 5 with Writer and Calc, for
Impress I have to use LO 4.5.

@ QA: It seems this regression is getting less attention. As the original
FILEOPEN issue seems to be resolved, is it reasonable to file a dedicated new
issue to raise attention?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] dev-tools.git: helpauthoring/filter

2015-09-08 Thread Yousuf Philips
 helpauthoring/filter/soffice2xmlhelp.xsl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bd9ddd7bdb8420b58b42e32136c83f2f589907f2
Author: Yousuf Philips 
Date:   Tue Sep 8 15:14:48 2015 +0400

Have title tag id attribute before xml-lang

Most .xhp files have it in this format, so no need to change this line
unnecessarily everytime a file is saved using the tool.

diff --git a/helpauthoring/filter/soffice2xmlhelp.xsl 
b/helpauthoring/filter/soffice2xmlhelp.xsl
index 4d4e557..56f47d1 100644
--- a/helpauthoring/filter/soffice2xmlhelp.xsl
+++ b/helpauthoring/filter/soffice2xmlhelp.xsl
@@ -106,7 +106,7 @@ DOCUMENT SKELETON
 
 
 
-
+
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 93525] Writer EDITING: Crash on deleting text (Unknown event notification 36)

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93525

--- Comment #12 from Tristan Miller  ---
See Bug 94021 for the GTK3 issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93953] Crash when accessing Tools > Macros > Organize Macros > Javascript

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93953

--- Comment #13 from Yousuf (Jay) Philips  ---
(In reply to Julien Nabet from comment #11)
> Yousuf: perhaps I'm wrong but the bt still shows "???".
> It might be useful to use the other way to retrieve a bt, ie attach soffice
> process to gdb
> https://wiki.documentfoundation.org/Development/
> How_to_debug#Attaching_to_the_soffice.bin_process

I tried that method and not sure what to do next as LO has halted and at the
(gdb) commandline. The wiki says "After attaching to the soffice.bin process
gdb stops the program." and i have no idea what that is supposed to mean.

Well it seems the crash should be reproducible by all when libreoffice is run
in backtrace mode (./soffice --backtrace).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 2 commits - avmedia/source canvas/source include/vcl slideshow/source vcl/inc vcl/opengl vcl/source vcl/unx vcl/workben

2015-09-08 Thread Michael Meeks
 avmedia/source/opengl/oglplayer.cxx|   15 
+-
 avmedia/source/opengl/oglplayer.hxx|2 
 avmedia/source/opengl/oglwindow.cxx|   10 -
 avmedia/source/opengl/oglwindow.hxx|4 
 canvas/source/opengl/ogl_spritedevicehelper.cxx|   33 
++---
 canvas/source/opengl/ogl_spritedevicehelper.hxx|2 
 include/vcl/opengl/OpenGLContext.hxx   |   19 
+--
 slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx |8 -
 vcl/inc/opengl/salbmp.hxx  |4 
 vcl/inc/opengl/win/gdiimpl.hxx |7 -
 vcl/inc/opengl/x11/gdiimpl.hxx |4 
 vcl/inc/openglgdiimpl.hxx  |   10 -
 vcl/inc/salgdi.hxx |2 
 vcl/opengl/gdiimpl.cxx |   47 
++-
 vcl/opengl/salbmp.cxx  |   16 
+-
 vcl/opengl/texture.cxx |6 -
 vcl/opengl/win/gdiimpl.cxx |   10 -
 vcl/opengl/x11/gdiimpl.cxx |   10 -
 vcl/source/app/svdata.cxx  |   12 
--
 vcl/source/gdi/salgdilayout.cxx|2 
 vcl/source/opengl/OpenGLContext.cxx|   59 
+++---
 vcl/source/window/openglwin.cxx|7 -
 vcl/unx/generic/window/salframe.cxx|4 
 vcl/workben/vcldemo.cxx|   10 -
 24 files changed, 129 insertions(+), 174 deletions(-)

New commits:
commit 56900a441de1d4cc896ad1e36a44622ed1598fad
Author: Michael Meeks 
Date:   Tue Sep 8 11:46:13 2015 +0100

tdf#94006 - fix OpenGLContext mis-use in several places.

gltf rendering, OpenGL canvas, GL transitions & GL capable (charts)
Avoid GLX operations on un-initialized contexts.

Change-Id: I7f523640f66ab656896181e5c865879234f6640e

diff --git a/avmedia/source/opengl/oglplayer.cxx 
b/avmedia/source/opengl/oglplayer.cxx
index a8a9f7d..c7bb7fb 100644
--- a/avmedia/source/opengl/oglplayer.cxx
+++ b/avmedia/source/opengl/oglplayer.cxx
@@ -28,6 +28,7 @@ namespace avmedia { namespace ogl {
 OGLPlayer::OGLPlayer()
 : Player_BASE(m_aMutex)
 , m_pHandle(NULL)
+, m_xContext(OpenGLContext::Create())
 , m_pOGLWindow(NULL)
 , m_bIsRendering(false)
 {
@@ -38,7 +39,7 @@ OGLPlayer::~OGLPlayer()
 osl::MutexGuard aGuard(m_aMutex);
 if( m_pHandle )
 {
-m_aContext.makeCurrent();
+m_xContext->makeCurrent();
 gltf_renderer_release(m_pHandle);
 }
 releaseInputFiles();
@@ -258,13 +259,13 @@ uno::Reference< media::XPlayerWindow > SAL_CALL 
OGLPlayer::createPlayerWindow( c
 }
 assert(pChildWindow->GetParent());
 
-if( !m_aContext.init(pChildWindow) )
+if( !m_xContext->init(pChildWindow) )
 {
 SAL_WARN("avmedia.opengl", "Context initialization failed");
 return uno::Reference< media::XPlayerWindow >();
 }
 
-if( !m_aContext.supportMultiSampling() )
+if( !m_xContext->supportMultiSampling() )
 {
 SAL_WARN("avmedia.opengl", "Context does not support multisampling!");
 return uno::Reference< media::XPlayerWindow >();
@@ -277,7 +278,7 @@ uno::Reference< media::XPlayerWindow > SAL_CALL 
OGLPlayer::createPlayerWindow( c
 }
 
 Size aSize = pChildWindow->GetSizePixel();
-m_aContext.setWinSize(aSize);
+m_xContext->setWinSize(aSize);
 m_pHandle->viewport.x = 0;
 m_pHandle->viewport.y = 0;
 m_pHandle->viewport.width = aSize.Width();
@@ -294,7 +295,7 @@ uno::Reference< media::XPlayerWindow > SAL_CALL 
OGLPlayer::createPlayerWindow( c
 // The background color is white by default, but we need to separate the
 // OpenGL window from the main window so set background color to grey
 glClearColor(0.5f, 0.5f, 0.5f, 0.5f);
-m_pOGLWindow = new OGLWindow(*m_pHandle, m_aContext, 
*pChildWindow->GetParent());
+m_pOGLWindow = new OGLWindow(*m_pHandle, m_xContext, 
*pChildWindow->GetParent());
 return uno::Reference< media::XPlayerWindow >( m_pOGLWindow );
 }
 
@@ -304,13 +305,13 @@ uno::Reference< media::XFrameGrabber > SAL_CALL 
OGLPlayer::createFrameGrabber()
 osl::MutexGuard aGuard(m_aMutex);
 assert(m_pHandle);
 
-if( !m_aContext.init() )
+if( !m_xContext->init() )
 {
 SAL_WARN("avmedia.opengl", "Offscreen context initialization failed");
 return uno::Reference< media::XFrameGrabber 

[Libreoffice-bugs] [Bug 93707] When I create a form in Writer and export to pdf, Adobe readers type and only password characters appear

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93707

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #1 from Cor Nouws  ---
Hi Warren,

Thanks for filing the issue.
I have no mean to test it. But could it be related to the font (Libreration) ?

Cheers - Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94022] Hide "Installable Options" in Linux print dialog

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94022

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de
 OS|All |Linux (All)
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 76964] Automatic capitalization of "i" in a non-english language

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76964

--- Comment #52 from Jack  ---
This bug (=that the English autocorrect table is always applied for certain
non-English spellchecker languages, even though the entry does not appear in
the [all] table or the table for the language in question) still persists as of
5.0.12, under windows, with English interface language.

My tests show that as of 5.0.12 the issue exists and can be fully reproduced,
but only for some spellchecking languages.
* The issue does NOT occur when the language pack is set to "none"
* The issue occurs for some languages, including Danish and French (with the
language packs installed) have the issue
* The issue does NOT occur for all languages, including German (with language
pack.)
* The issue occurs for some languages, including Haitian and Frisian WITHOUT
the language packs installed.

When making my tests, i made sure to test multiple different words, and i
checked that the words did not exist in the "all" autocorrect table or the
autocorrect table for the tested language.

SUMMARY
The issue persists as of 5.0.12, but only for some language settings.
The issue seems to be that the English autocorrect table is sometimes applied
to non-english languages.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91515] Inserting comments the text background will be white regardless of comment box background (black background after copy)

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91515

Ulrich Windl  changed:

   What|Removed |Added

 CC||ulrich.wi...@rz.uni-regensb
   ||urg.de

--- Comment #13 from Ulrich Windl  ---
I can confirm this bug (maybe new in 4.4.5.2 (Windows 7)): If you add a
comment, and then insert text from the clipboard (even for "unformatted text"),
then the text is "black on white", even if the rest of the background is yellow
as usual.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94023] New: FILESAVE: If the chart is selected, only save the cart and not the Sheet

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94023

Bug ID: 94023
   Summary: FILESAVE: If the chart is selected, only save the cart
and not the Sheet
   Product: LibreOffice
   Version: 4.4.5.2 release
  Hardware: Other
OS: Windows (All)
Status: UNCONFIRMED
  Severity: critical
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: edison...@gmail.com

I have created few sheets and more chart's from them and on save I have
forgotten one chart selected and I have saved only the chart. When I close the
File, the LibreOffice does not remember me to save it and I have lost all my
sheets!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94025] New: Libreoffice build : Impress crashes on fullscreen F5 option

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94025

Bug ID: 94025
   Summary: Libreoffice build : Impress crashes on fullscreen F5
option
   Product: LibreOffice
   Version: unspecified
  Hardware: Other
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: madhu...@cdac.in

Build is crashing on f5 fullscreen operation on Win 7 and win 10 but same build
working fine on win 8.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94016] New: META: Bugs and enhancements for Wikihelp

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94016

Bug ID: 94016
   Summary: META: Bugs and enhancements for Wikihelp
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
CC: olivier.hal...@documentfoundation.org,
rb.hensc...@t-online.de

Would be good to gather all the bugs and enhancements related to the conversion
of the help into wiki form.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93525] Writer EDITING: Crash on deleting text (Unknown event notification 36)

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93525

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #7 from Maxim Monastirsky  ---
Does it crash if you export SAL_USE_VCLPLUGIN=gtk before running LO?

Also would be useful to get a backtrace of the crash:
https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#GNU.2FLinux:_How_to_get_a_backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45589] Show bookmarks: make them visible in a document

2015-09-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45589

--- Comment #8 from Yousuf (Jay) Philips  ---
Created attachment 118519
  --> https://bugs.documentfoundation.org/attachment.cgi?id=118519=edit
bookmarks in ms word

(In reply to Cor Nouws from comment #7)
> Hi Jay,

Hi Cor,

> Users are pretty keen on being able to handle settings for e.g. showing page
> margins apart from non printable characters. I could imagine the same with
> bookmarks? 

Yes it should be a setting configurable by itself.

> Say  Options > Writer > Formatting Aids ... Display of: [ ] Bookmarks

Yes that would be a good place for it in the Options dialog, but it should also
be in the View menu.

> From what I remember Word had a setting to to show bookmarks.

Yes you are correct that Word has it, but it isnt on by default and you have to
go into its options dialog to turn it on. I've attached a screenshot of how it
looks when its bookmarked at the beginning and end of a line as well as on a
selection.

> In the text is the only thing that makes sense, IMO. Bookmarks can be single
> points and selections. Bookmarks are (also) used to mark pieces in the text
> for referencing, filling, ... So only an indicator in the margin, would not
> help.

Placing it in the text would cause it to mix with other stuff, e.g. comments,
and would result in it not looking good, i assume thats why its turned off by
default in ms word. Also bookmarks in html documents can only be positioned at
the beginning of a line. The main point of the marker in the margin would be to
let you know that there is a bookmark on that line. Never used bookmarks before
trying them out in google docs and presentation of it was very user friendly
and quite easy to understand.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >