[Libreoffice-bugs] [Bug 94873] Insert comment will not accept cursor placement

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94873

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||c...@nouenoff.nl
 Resolution|--- |WORKSFORME

--- Comment #1 from Cor Nouws  ---
Hi there,

What version do you use?

In 5.0.2.2 I cannot insert a Comment in a cell where there already is one.
But there is the command Edit Comment (in the context menu).

Can you look at that or be more specific in the problem pls?
There is also user support, can be of great help:
 http://www.libreoffice.org/get-help/community-support/

Set as WorksForMe now. PLease do reopen if there is a different clear problem.
And give a better description then and a test file maybe too.

Thanks,
Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87285] print a large page on multi page A4 doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87285

--- Comment #7 from Beluga  ---
Yep it works now.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92702] Unable to select menu items that were initially off-screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92702

--- Comment #13 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-5-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=48a7d0492dbae60d644dd7be9b1b0826fdf36f63=libreoffice-5-0

tdf#92702 Unable to select menu items that were initially off-screen

It will be available in 5.0.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/source

[László Németh]

 vcl/source/window/menufloatingwindow.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 48a7d0492dbae60d644dd7be9b1b0826fdf36f63
Author: László Németh 
Date:   Wed Sep 30 22:29:46 2015 +0200

tdf#92702 Unable to select menu items that were initially off-screen

Revert "Last item of menu with title cannot be hilighted"

This reverts commit 8ced97caa409d6dc8f69230145e9c9f281fb84fe.

(Cherry-picked from the commit 4f1dca5083c5a301181786b563b165f19a9dec7f)

Change-Id: Ic8c2195d4791900ada0296215c335b9dc39db220
Reviewed-on: https://gerrit.libreoffice.org/19048
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/vcl/source/window/menufloatingwindow.cxx 
b/vcl/source/window/menufloatingwindow.cxx
index 972ec16..5ff6cc2 100644
--- a/vcl/source/window/menufloatingwindow.cxx
+++ b/vcl/source/window/menufloatingwindow.cxx
@@ -190,7 +190,7 @@ void MenuFloatingWindow::ImplHighlightItem( const 
MouseEvent& rMEvt, bool bMBDow
 long nY = GetInitialItemY();
 long nMouseY = rMEvt.GetPosPixel().Y();
 Size aOutSz = GetOutputSizePixel();
-if ( ( nMouseY >= nY ) && ( nMouseY < ( aOutSz.Height() + nY ) ) )
+if ( ( nMouseY >= nY ) && ( nMouseY < ( aOutSz.Height() - nY ) ) )
 {
 bool bHighlighted = false;
 size_t nCount = pMenu->pItemList->size();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94745] Some of arrow character (==>) in Impress will turn into other character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94745

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #6 from Beluga  ---
(In reply to Adolfo Jayme from comment #5)
> I suspect this is caused because that arrow is from some non-standardly
> encoded font (not following Unicode) such as Wingdings, which will be
> obviously replaced when not available.

Yep, it is Wingdings. Should this be closed as notourbug, or was there some bug
report / enhancement for better automatic font replacement?

Works ok here.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92702] Unable to select menu items that were initially off-screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92702

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|bibisected target:5.1.0 |bibisected target:5.1.0
   ||target:5.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94771] FORMATTING: time is impossible to figure out

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94771

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #6 from Beluga  ---
NEEDINFO while waiting for response to comment 5.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94806] Cannot activate Impress remote

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94806

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi
  Component|Impress |Android app
Version|5.0.2.2 release |unspecified
Product|LibreOffice |Impress Remote

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - svx/source

[Jan Holesovsky]

 svx/source/tbxctrls/tbcontrl.cxx |   21 +++--
 1 file changed, 15 insertions(+), 6 deletions(-)

New commits:
commit 5ade4867da653f75efd3a1742281fc27692753b4
Author: Jan Holesovsky 
Date:   Wed Oct 7 17:37:22 2015 +0200

SvxStyleBox_Impl::CalcOptimalExtraUserWidth() is a (very) expensive 
operation.

Don't call it ~20 times on startup, instead call it once when the user
actually opens the styles dropdown.

Change-Id: I7bb28d0739bf917d23041f384f60a39a7ed5cbea

diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 5e15ccd6..3dcc35f 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -136,9 +136,10 @@ public:
 
 voidSetDefaultStyle( const OUString& rDefault ) { 
sDefaultStyle = rDefault; }
 
-voidCalcOptimalExtraUserWidth();
-
 protected:
+/// Calculate the optimal width of the dropdown.  Very expensive 
operation, triggers lots of font measurement.
+DECL_DLLPRIVATE_LINK(CalcOptimalExtraUserWidth, VclWindowEvent*);
+
 virtual voidSelect() SAL_OVERRIDE;
 
 private:
@@ -338,6 +339,7 @@ SvxStyleBox_Impl::SvxStyleBox_Impl(vcl::Window* pParent,
 SetOptimalSize();
 EnableAutocomplete( true );
 EnableUserDraw( true );
+AddEventListener(LINK(this, SvxStyleBox_Impl, CalcOptimalExtraUserWidth));
 SetUserItemSize( Size( 0, ITEM_HEIGHT ) );
 }
 
@@ -348,10 +350,13 @@ SvxStyleBox_Impl::~SvxStyleBox_Impl()
 
 void SvxStyleBox_Impl::dispose()
 {
-for(int i = 0; i < MAX_STYLES_ENTRIES; i++)
+RemoveEventListener(LINK(this, SvxStyleBox_Impl, 
CalcOptimalExtraUserWidth));
+
+for (int i = 0; i < MAX_STYLES_ENTRIES; i++)
 {
 m_pButtons[i].disposeAndClear();
 }
+
 ComboBox::dispose();
 }
 
@@ -792,8 +797,12 @@ void SvxStyleBox_Impl::UserDraw( const UserDrawEvent& 
rUDEvt )
 DrawEntry( rUDEvt, false, false );
 }
 
-void SvxStyleBox_Impl::CalcOptimalExtraUserWidth()
+IMPL_LINK(SvxStyleBox_Impl, CalcOptimalExtraUserWidth, VclWindowEvent*, event)
 {
+// perform the calculation only when we are opening the dropdown
+if (event->GetId() != VCLEVENT_DROPDOWN_PRE_OPEN)
+return 0;
+
 long nMaxNormalFontWidth = 0;
 sal_Int32 nEntryCount = GetEntryCount();
 for (sal_Int32 i = 0; i < nEntryCount; ++i)
@@ -829,6 +838,8 @@ void SvxStyleBox_Impl::CalcOptimalExtraUserWidth()
 }
 
 SetUserItemSize(Size(nMaxUserDrawFontWidth - nMaxNormalFontWidth, 
ITEM_HEIGHT));
+
+return 0;
 }
 
 // test is the color between Font- and background-color to be identify
@@ -2308,8 +2319,6 @@ void SvxStyleToolBoxControl::FillStyleBox()
 sal_uInt16 nLines = static_cast(
 std::min( pBox->GetEntryCount(), 
static_cast(MAX_STYLES_ENTRIES)));
 pBox->SetDropDownLineCount( nLines );
-
-pBox->CalcOptimalExtraUserWidth();
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 71251] EDITING - Embedded Firebird - Creating table from default choices via wizard fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71251

--- Comment #17 from ribotb  ---
Hi,

(In reply to Robinson Tryon (qubit) from comment #16)
> 
> (In reply to Lionel Elie Mamane from comment #6)
> > 
> > (note: firebird 3 has/will have BOOLEAN datatype)
> 
Read in Firebird 3 Release Notes :

New Data Type Support :
A true BOOLEAN type (True/False/Unknown), complete with support for logical
predicates

Bernard

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94764] Modified bitmap shouldnt listed with the same name

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94764

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #1 from Beluga  ---
Confirmed.

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+
Build ID: f830600ece806ec365a4839e79afabe183c5e36d
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-10-06_22:49:09
Locale: en-US (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94739] PDF Exporting Diagonal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94739

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #4 from Beluga  ---
(In reply to spartanhooah from comment #2)
> Steps:
> 1) Take a screenshot from Firefox.
> 2) Paste into paint.net 4.0.6.
> 3) Select just the part I want.
> 4) Paste into new Writer document.
> 5) Export as PDF.
> 6) Open with SumatraPDF.
> 
> Interestingly, Sumatra is the only program that actually displayed anything.
> The Windows 10 Reader app, Edge, and Firefox 41 all displayed a blank page.

I don't have paint.net, but I have SumatraPDF.
I simply right-clicked - copied image from http://imgur.com/izBTWSb.jpg, pasted
it to Writer and exported to PDF.
SumatraPDF displayed it just fine.

Does it display messed up for you, if you do as I did?

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)
SumatraPDF 3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94766] Program Will Not Allow More Than Two Spaces Between Words In and Between Sentences (Portable Apps Writer)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94766

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|major   |normal

--- Comment #1 from Beluga  ---
Could not reproduce.
Maybe a problem with the portable version, which is provided by a third party?
Please try with the regular full install.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

Set to NEEDINFO.
Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED
WORKSFORME, if the problem went away.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94876] New: loading from WKS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94876

Bug ID: 94876
   Summary: loading from WKS format
   Product: LibreOffice
   Version: 5.0.2.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: k...@tut.by

Created attachment 119408
  --> https://bugs.documentfoundation.org/attachment.cgi?id=119408=edit
screenshot and example of *.wks to load

Hello.
Libre Office Calc incorrectly loads data from WKS-file (in attachment). 
See screenshot in attachment - all data in the column "barcode" are wrong.
MS Office Excel 2003 loads this file correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Calc function to check for text that could be number in order to place UI indicators

[Caolán McNamara]

On Wed, 2015-10-07 at 14:10 +0200, Eike Rathke wrote:
> Hi Łukasz,
> 
> On the LibreOffice Conference Hackfest at Aarhus we talked about 
> placing UI indicators in the current view to hint cells that contain 
> text that could be numbers instead.

That would be v. neat. If we had a UI indicator for errors/warnings
detected in the idle loop I imagine we could extend it with all sorts
of checks, like Andrzej's unit detection stuff and things like
"formulas inconsistent with neighbouring formulas" ?

C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 94850] FILESAVE: Icon set Stars not saved as XLSX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94850

Luke  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Luke  ---
Verified Fixed in Version: 5.1.0.0.alpha1+
Build ID: 2e6feddc53830406fa04b4a0aea49bb8438dc702

Thanks moggi!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94752] Curved lines have white stripes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94752

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #3 from Beluga  ---
No repro on Win.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: config listener API ...

[Stephan Bergmann]

On 10/07/2015 07:22 PM, Michael Meeks wrote:

Just pushed:

https://gerrit.libreoffice.org/19234

Which I want to use in Calc to hide the hideous costs there. Input
appreciated.


What are those "hideous costs" exactly?  Do you have a pointer to a 
patch that makes use of the above commit to improve things?  That would 
probably explain things better.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-ux-advise] [Bug 94846] UI: Search bar should provide consistent feedback when search keys are not found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94846

--- Comment #9 from las...@csecsy.hu ---
(In reply to Alex Thurgood from comment #8)
> @laszio : which version of OSX are you using ?
I'm using OSX Yosemite 10.10.5.

Oh, and I haven't tried it before, so I just did it: this problem appears in
Writer, too. Reproduction steps are described in comment #7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 94846] UI: Search bar should provide consistent feedback when search keys are not found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94846

--- Comment #9 from las...@csecsy.hu ---
(In reply to Alex Thurgood from comment #8)
> @laszio : which version of OSX are you using ?
I'm using OSX Yosemite 10.10.5.

Oh, and I haven't tried it before, so I just did it: this problem appears in
Writer, too. Reproduction steps are described in comment #7.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94762] "Design" button is gone after viewing "Print Preview"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94762

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #1 from Beluga  ---
(In reply to Vitaliy Lotorev from comment #0)
> * Open sidebar, make sure there is a "Design" button at sidebar.

How can I do this? Where should the Design button be?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92807] Runtime error! R6025 - pure virtual function call after exiting Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92807

--- Comment #15 from gmarco  ---
(In reply to tommy27 from comment #13)
> are you still using 4.4.5.2 or 5.0.2.2?

Hello Tommy, that is an old question.
I too am still using 4452 and checking for updates I get I am up to date, but
looking at the official infos we see that the release 5 is ready since the end
of july.
Then, have we to wait the official ask for updating (I think end-of-life
november 18,2015)or it is better to update now?
Tanks, regards

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94767] EDITING: No "Delete Page / Add Page" Button or Option in Writer (Portable Apps)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94767

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||todven...@suomi24.fi
 Resolution|--- |NOTABUG

--- Comment #1 from Beluga  ---
There were 3 empty paragraphs after the table.
You can view them by enabling the display of non-printing chars, from the View
menu or with the shortcut Ctrl-F10.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94785] Installation fails with error message 1602

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94785

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #1 from Beluga  ---
https://msdn.microsoft.com/en-us/library/aa376931%28v=vs.85%29.aspx
ERROR_INSTALL_USEREXIT1602The user cancels installation.

Can't think of any solution..

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94656] Inserted images do not load in saved .ods file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94656

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #8 from Beluga  ---
I tried inserting two of the images to a new spreadsheet. The images did not
disappear after save & reload.

attachment 119152 can be unzipped and the files seen in Pictures folder.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/source

[Daniel Robertson]

 chart2/source/controller/dialogs/DataBrowser.cxx|  
 14 +--
 chart2/source/controller/inc/ItemPropertyMap.hxx|  
 35 -
 chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx   |  
 10 +-
 chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx  |  
 12 +--
 chart2/source/controller/itemsetwrapper/LegendItemConverter.cxx |  
 13 +--
 chart2/source/controller/itemsetwrapper/MultipleItemConverter.cxx   |  
  8 +-
 chart2/source/controller/itemsetwrapper/RegressionEquationItemConverter.cxx |  
 13 +--
 chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx  |  
 12 +--
 chart2/source/controller/itemsetwrapper/TitleItemConverter.cxx  |  
 13 +--
 chart2/source/controller/main/ChartController_Insert.cxx|  
 38 --
 chart2/source/controller/main/ChartController_Tools.cxx |  
  6 +
 chart2/source/controller/main/CommandDispatch.cxx   |  
 29 ++-
 chart2/source/inc/DisposeHelper.hxx |  
 34 
 chart2/source/tools/InternalDataProvider.cxx|  
  4 -
 14 files changed, 77 insertions(+), 164 deletions(-)

New commits:
commit 391f181c9f82fec1988ce2c364c7afd1b0f49719
Author: Daniel Robertson 
Date:   Sun Sep 27 19:21:35 2015 -0400

chart2: replace for_each with range-based for

Replace complex uses of ::std::for_each with a range-based for-loop.

Change-Id: I6f3d8488a63a5bed271ab70ad6f024e9869906cc
Reviewed-on: https://gerrit.libreoffice.org/19143
Tested-by: Jenkins 
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/chart2/source/controller/dialogs/DataBrowser.cxx 
b/chart2/source/controller/dialogs/DataBrowser.cxx
index d318371..d62e13d 100644
--- a/chart2/source/controller/dialogs/DataBrowser.cxx
+++ b/chart2/source/controller/dialogs/DataBrowser.cxx
@@ -401,14 +401,6 @@ Image SeriesHeader::GetChartTypeImage(
 return aResult;
 }
 
-struct applyChangesFunctor : public ::std::unary_function< std::shared_ptr< 
SeriesHeader >, void >
-{
-void operator() ( std::shared_ptr< SeriesHeader > spHeader )
-{
-spHeader->applyChanges();
-}
-};
-
 } // namespace impl
 
 namespace
@@ -541,7 +533,8 @@ bool DataBrowser::MaySwapColumns() const
 
 void DataBrowser::clearHeaders()
 {
-::std::for_each( m_aSeriesHeaders.begin(), m_aSeriesHeaders.end(), 
impl::applyChangesFunctor());
+for( const auto& spHeader : m_aSeriesHeaders )
+spHeader->applyChanges();
 m_aSeriesHeaders.clear();
 }
 
@@ -1183,7 +1176,8 @@ bool DataBrowser::EndEditing()
 SaveModified();
 
 // apply changes made to series headers
-::std::for_each( m_aSeriesHeaders.begin(), m_aSeriesHeaders.end(), 
impl::applyChangesFunctor());
+for( const auto& spHeader : m_aSeriesHeaders )
+spHeader->applyChanges();
 
 if( m_bDataValid )
 return true;
diff --git a/chart2/source/controller/inc/ItemPropertyMap.hxx 
b/chart2/source/controller/inc/ItemPropertyMap.hxx
index d62aa0e..f2fa063 100644
--- a/chart2/source/controller/inc/ItemPropertyMap.hxx
+++ b/chart2/source/controller/inc/ItemPropertyMap.hxx
@@ -32,41 +32,6 @@ typedef ::std::map< ItemConverter::tWhichIdType, 
::std::pair< ItemConverter::tPr
 typedef ::comphelper::MakeMap< ItemConverter::tWhichIdType, ::std::pair< 
ItemConverter::tPropertyNameType, ItemConverter::tMemberIdType > >
 MakeItemPropertyMap;
 
-class FillItemSetFunc : public ::std::unary_function< ItemConverter *, void >
-{
-public:
-explicit FillItemSetFunc( SfxItemSet & rOutItemSet ) :
-m_rOutItemSet( rOutItemSet )
-{}
-
-void operator() ( ItemConverter * pConv )
-{
-pConv->FillItemSet( m_rOutItemSet );
-}
-
-private:
-SfxItemSet & m_rOutItemSet;
-};
-
-class ApplyItemSetFunc : public ::std::unary_function< ItemConverter *, void >
-{
-public:
-explicit ApplyItemSetFunc( const SfxItemSet & rItemSet,
-   bool & rOutResult ) :
-m_rItemSet( rItemSet ),
-m_rOutResult( rOutResult )
-{}
-
-void operator() ( ItemConverter * pConv )
-{
-m_rOutResult = pConv->ApplyItemSet( m_rItemSet ) || m_rOutResult;
-}
-
-private:
-const SfxItemSet & m_rItemSet;
-bool & m_rOutResult;
-};
-
 }}
 
 #endif
diff --git a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx 
b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
index b155a46..59f0b79 100644
--- a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
@@ -30,6 +30,7 @@
 #include "CommonConverters.hxx"
 #include "ChartTypeHelper.hxx"
 #include 
+#include 
 
 #include 
 #include 

[Libreoffice-bugs] [Bug 94793] Setting of "Same content on first page" on Template->Footer is overwritten by equivalent setting on Template->Header

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94793

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Version|4.4.5.2 release |4.3.0.1 rc
 Ever confirmed|0   |1

--- Comment #2 from Beluga  ---
Note: this is about the default page style.

Reproduced.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

Version: 5.1.0.0.alpha1+
Build ID: f830600ece806ec365a4839e79afabe183c5e36d
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-10-06_22:49:09
Locale: en-US (fi_FI)

4.3.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94758] LibreOffice does not render Urdu font (Nafees Nastaleeq) properly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94758

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #3 from Beluga  ---
You can also use this method to test right away:
https://wiki.documentfoundation.org/Installing_in_parallel/Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94799] EDITING - Writer Spell Checker Stopped Working After Version Upgrade and Fatal Error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94799

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #1 from Beluga  ---
(In reply to junk_2010 from comment #0)
> I noticed that this message was referring to "LibreOffice/4/" and I am using
> LibreOffice 5.

The folder name wasn't renamed to 5 so the user profile would not reset. This
was a decision by the engineering steering committee.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Compiling Tiled LibreOffice Xcode Project

[Tor Lillqvist]

On 8 October 2015 at 05:51, Arjun kochhar  wrote:

> I updated configure.ac to consider 9.0 as a possible SDK too, since the
> highest value mentioned there was 8.3
>

Then you must be using some other branch than master, because that was
changed on June 16 in master. Please use the master branch for any iOS
build attempts, as the (very few) iOS-specific fixes I do (I try it maybe
once a month) go into master, not any "stable" branch.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: config listener API ...

[Tor Lillqvist]

Crazy idea time.

I wonder, as the set of configuration parameters from the source tree in a
specific build is fixed, would it be possible to simply generate a large
(C++) struct containing all of them, populate one global such struct
variable on startup (or even at build time with the default values, then
just replacing ones that are modified by user at startup time), and have
those officecfg::* calls simply refer to fields in that struct? Would be
vastly faster than current code, and simpler (at run-time) than Michael's
idea.

Sure, would have the non-ideal effect that any modification to the
officecfg module would require recompilation of any code that calls
officecfg::

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 94744] Different alphabetical index for the same Greek letter depending on accentuation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94744

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
 OS|Linux (All) |All
   Severity|normal  |enhancement

--- Comment #6 from Beluga  ---
So this is basically an enhancement. With the confidence of my complete
ignorance, I'll set to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94768] LO creates invalid ODF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94768

Beluga  changed:

   What|Removed |Added

   Priority|medium  |high
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|critical|normal

--- Comment #1 from Beluga  ---
Reproduced.

Re-prioritized as the result is not a document that can't be opened. Still,
quite embarrassing so setting priority to high.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: config listener API ...

[Michael Meeks]

On Thu, 2015-10-08 at 09:12 +0200, Stephan Bergmann wrote:
> On 10/07/2015 07:22 PM, Michael Meeks wrote:
> > https://gerrit.libreoffice.org/19234
> >
> > Which I want to use in Calc to hide the hideous costs there. Input
> > appreciated.
> 
> What are those "hideous costs" exactly ?

Oh =) good question. We have a configmgr setting that is changed
externally using the UNO API - enabling OpenCL (or not). We need to
check that inside our calculation loop to branch on it. We do an
innocuous:

if (officecfg::Office::Common::Misc::UseOpenCL::get())

Which reads beautifully =) in fact I love this type safe wrapper stuff
in the abstract (if not 100% of the implementation choices).

Of the 15bn pcycles in the profile for re-calculating this sheet we
spend ~4bn pcycles essentially in this one method call (called 225k
times) =)

That breaks down:

3.3bn pcycles in Access::getByHierarchicalName
0.5bn pcycles in 'comphelper::getComponentContext()'
+ the default parameter for 'get' ;-)
0.2bn pcycles is allocating an OUString literal
+ (I assume for the 'path' that is made there)

Which - I guess is fair enough; ~18k pcycles to get a config key seems
high but not totally excessive. The basic punch-line is that calling the
above is not a good idea to do 225k times in a row =)

But then - the way that calc re-calculates is neither trivial, nor
extremely susceptible to - "split the loop invariant out" - there is
some deeply nested recursive goodness called from several places going
on =) So - hopefully this listener provides a better solution.

>   Do you have a pointer to a patch that makes use of the above commit
> to improve things?  That would probably explain things better.

Sure - fair ask; so here - I'd just want a static global
ConfigurationListenerProperty which we can check with an in-lined
boolean comparison that goes no-where near configmgr on the hot path.

I guess across much of the rest of the code we're used to coping with
the idea that its only the user that changes config keys so we have full
control over that in the dialog and/or putting up with out-of-date
cached config state =)

Tor's idea of a shared global struct with state is interesting; but is
quite a big chunk of work I think. It could be split up by path (as now)
with a struct at the end of each node - but (I imagine) would involve a
lot of type introspection / wrangling as it's walked; and may make
startup rather slower too. I'm not sure that configmgr maintains a
flattened set of its layered data anyway (does it ?).

Also - the "atomic change set" writing for configmgr settings (although
cumbersome at first glance) -should- map rather well to the way settings
dialogs work etc. so - in a global variable / structure world we'd want
to have that readonly I guess.

Anyhow - I'm reasonably happy with the patch - unless there are better
ideas to improve it and/or integrate it with the existing wrappers -
I'll push it in a bit; and then add the calc hooks to make it useful.

ATB,

Michael.

-- 
 michael.me...@collabora.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Can't track flow of characters in from Input Method Editor

[Caolán McNamara]

On Thu, 2015-10-08 at 08:52 +0100, Richard Wordingham wrote:
> The intent of the call is to delete one Unicode character;

I imagine you need to change signalIMDeleteSurrounding where we have
nDeletePos = nPosition + offset and
nDeleteEnd = nDeletePos + nchars
and instead of adding "offset" and adding "nchars" you need to call
getText on xText to get the string, then use
OUString::iterateCodePoints to count forward from nPosition by "offset"
IM codepoints to get the utf-16 offset for LibreOffice, and similarly
iterateCodePoints by IM nchars to get the LibreOffice utf-16 nchars to
delete.

might suck rocks for performance.

C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 94837] Can't edit title box in Master Slide

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94837

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||c...@nouenoff.nl
 Resolution|--- |WORKSFORME

--- Comment #1 from Cor Nouws  ---
Hi Alex,

Sorry to read of your trouble here.. But you need to edit the style - styles
are often the "way to go" in LibreOffice :)
Use the context menu...
Also, there is great community support. Try that first if you have questions
please. See
  http://www.libreoffice.org/get-help/community-support/

Set as WorksForMe.
Best - Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94692] FORMATTING: picture with captions is not respecting the page borders

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94692

Beluga  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #3 from Beluga  ---
Ok, let's set to NEW then and let devs decide.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/source

[Caolán McNamara]

 vcl/source/gdi/sallayout.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 92eed31707e655e484e263fee2b0c0ae93d73748
Author: Caolán McNamara 
Date:   Fri Oct 2 11:25:29 2015 +0100

Resolves: tdf#92993 access violation on particular .docx on glyph layout

Change-Id: I69dfd6747e37ddb1727dd41b99d1b70eaed83425
(cherry picked from commit ae850353151cd6a79f7b4a012d0a411013c841a4)
Reviewed-on: https://gerrit.libreoffice.org/19095
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index 69d162f..4bd388d 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -1720,8 +1720,9 @@ void MultiSalLayout::AdjustLayout( ImplLayoutArgs& rArgs )
 maFallbackRuns[n].ResetPos();
 // get the next codepoint index that needs fallback
 int nActiveCharPos = nCharPos[0];
+int nActiveCharIndex = nActiveCharPos - mnMinCharPos;
 // get the end index of the active run
-int nLastRunEndChar = (vRtl[nActiveCharPos - mnMinCharPos])?
+int nLastRunEndChar = (nActiveCharIndex >= 0 && vRtl[nActiveCharIndex]) ?
 rArgs.mnEndCharPos : rArgs.mnMinCharPos - 1;
 int nRunVisibleEndChar = nCharPos[0];
 // merge the fallback levels
@@ -1870,7 +1871,8 @@ void MultiSalLayout::AdjustLayout( ImplLayoutArgs& rArgs )
 if( !bLTR )
 nOldRunAdv = -nOldRunAdv;
 #endif
-if (vRtl[nActiveCharPos - mnMinCharPos])
+nActiveCharIndex = nActiveCharPos - mnMinCharPos;
+if (nActiveCharIndex >= 0 && vRtl[nActiveCharIndex])
 {
   if (nRunVisibleEndChar > mnMinCharPos && nRunVisibleEndChar <= 
mnEndCharPos)
   nRunAdvance -= aMultiArgs.mpDXArray[nRunVisibleEndChar - 1 - 
mnMinCharPos];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Can't track flow of characters in from Input Method Editor

[Richard Wordingham]

On Thu, 8 Oct 2015 01:17:14 +0100
Richard Wordingham  wrote:

> Thank you all for your inputs.

I've finally found where the problem materialises.  There is a callback
of GtkSalFrame::IMHandler::signalIMDeleteSurrounding() to delete one
'character'.  I now need to work out where the interfacing is in
error.  The intent of the call is to delete one Unicode character; it
is now a question of where the conversion from Unicode characters to
code units should be made.  It might be anywhere from KMfL to
signalIMDeleteSurrounding().  For hacking, there is the good news that
when KMfL decides to delete two Unicode characters, there are two calls
of the function, so I could fix *my* problem straightforwardly.

Does this appear to relate to any other known problems in interfacing
with ibus?

Richard.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 94788] incorrect export footnotes to docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94788

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #1 from Beluga  ---
I assume you are speaking about inserting an endnote.
I did not see any problem.

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+
Build ID: f830600ece806ec365a4839e79afabe183c5e36d
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-10-06_22:49:09
Locale: en-US (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88377] Chart button in Calc crashes LibO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88377

--- Comment #14 from dgmg...@googlemail.com ---
Not really sure, but probably yes it worked initially. It was a surprise when
it happened but until 3 years ago I would have been using Excel. Since retiring
charts have become less appealing!! 

For the specific application I have moved to Google Sheets since that offers
any user a complete package that works without reference to their desktop
software.

Now that I know the crash will restore with the chart intact it isn't so
annoying - I either live with that on the laptop or work on the PC, which is
OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #60 from Commit Notification 
 ---
Aybuke Ozdemir committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbfc031333aa74fbd4c6362c33405c49c22283f3

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/inc starmath/source

[Takeshi Abe]

 starmath/inc/cursor.hxx|6 ++
 starmath/source/cursor.cxx |4 ++--
 2 files changed, 4 insertions(+), 6 deletions(-)

New commits:
commit ce924d97aaea265b8f58265bedb49dbcd71fbc31
Author: Takeshi Abe 
Date:   Wed Oct 7 23:21:00 2015 +0900

starmath: Represent ownership by std::unique_ptr

Change-Id: I7ce39cbdc0199d3508e7d16d1ce0b78f8d8ca620
Reviewed-on: https://gerrit.libreoffice.org/19230
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/starmath/inc/cursor.hxx b/starmath/inc/cursor.hxx
index 964c65c..2988828 100644
--- a/starmath/inc/cursor.hxx
+++ b/starmath/inc/cursor.hxx
@@ -13,6 +13,7 @@
 #include "caret.hxx"
 
 #include 
+#include 
 
 /** Factor to multiple the squared horizontal distance with
  * Used for Up and Down movement.
@@ -82,7 +83,6 @@ public:
 , mpPosition(nullptr)
 , mpTree(tree)
 , mpDocShell(pShell)
-, mpGraph(nullptr)
 , mpClipboard(nullptr)
 , mnEditSections(0)
 , mbIsEnabledSetModifiedSmDocShell(false)
@@ -94,8 +94,6 @@ public:
 ~SmCursor()
 {
 SetClipboard();
-delete mpGraph;
-mpGraph = nullptr;
 }
 
 /** Get position */
@@ -230,7 +228,7 @@ private:
 /** Owner of the formula tree */
 SmDocShell* mpDocShell;
 /** Graph over caret position in the current tree */
-SmCaretPosGraph* mpGraph;
+std::unique_ptr mpGraph;
 /** Clipboard holder */
 SmNodeList* mpClipboard;
 
diff --git a/starmath/source/cursor.cxx b/starmath/source/cursor.cxx
index 01c4b37..954563e 100644
--- a/starmath/source/cursor.cxx
+++ b/starmath/source/cursor.cxx
@@ -114,14 +114,14 @@ void SmCursor::BuildGraph(){
 _anchor = mpAnchor->CaretPos;
 if(mpPosition)
 _position = mpPosition->CaretPos;
-delete mpGraph;
+mpGraph.reset();
 //Reset anchor and position as they point into an old graph
 mpAnchor = nullptr;
 mpPosition = nullptr;
 }
 
 //Build the new graph
-mpGraph = SmCaretPosGraphBuildingVisitor(mpTree).takeGraph();
+mpGraph.reset(SmCaretPosGraphBuildingVisitor(mpTree).takeGraph());
 
 //Restore anchor and position pointers
 if(_anchor.IsValid() || _position.IsValid()){
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: tools/source

[Aybuke Ozdemir]

 tools/source/generic/config.cxx |7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit bbfc031333aa74fbd4c6362c33405c49c22283f3
Author: Aybuke Ozdemir 
Date:   Wed Oct 7 14:48:57 2015 +0300

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

Change-Id: Id9bc24079d3840277d6fc10197a4f27373f4bd25
Reviewed-on: https://gerrit.libreoffice.org/19225
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/tools/source/generic/config.cxx b/tools/source/generic/config.cxx
index 257721e..f1a638e 100644
--- a/tools/source/generic/config.cxx
+++ b/tools/source/generic/config.cxx
@@ -815,12 +815,7 @@ OString Config::ReadKey(const OString& rKey) const
 OString Config::ReadKey(const OString& rKey, const OString& rDefault) const
 {
 #ifdef DBG_UTIL
-OStringBuffer aTraceStr("Config::ReadKey( ");
-aTraceStr.append(rKey);
-aTraceStr.append(" ) from ");
-aTraceStr.append(GetGroup());
-aTraceStr.append(" in ");
-aTraceStr.append(OUStringToOString(maFileName, RTL_TEXTENCODING_UTF8));
+OString aTraceStr("Config::ReadKey( " + rKey + " ) from " + GetGroup() + " 
in " + OUStringToOString(maFileName, RTL_TEXTENCODING_UTF8));
 OSL_TRACE("%s", aTraceStr.getStr());
 #endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|EasyHack SkillCpp   |EasyHack SkillCpp
   |TopicCleanup|TopicCleanup
   |DifficultyBeginner  |DifficultyBeginner
   |target:4.1.0 target:4.2.0   |target:4.1.0 target:4.2.0
   |target:4.3.0 target:4.5.0   |target:4.3.0 target:4.5.0
   ||target:5.1.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #60 from Commit Notification 
 ---
Aybuke Ozdemir committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbfc031333aa74fbd4c6362c33405c49c22283f3

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|EasyHack SkillCpp   |EasyHack SkillCpp
   |TopicCleanup|TopicCleanup
   |DifficultyBeginner  |DifficultyBeginner
   |target:4.1.0 target:4.2.0   |target:4.1.0 target:4.2.0
   |target:4.3.0 target:4.5.0   |target:4.3.0 target:4.5.0
   ||target:5.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - comphelper/source editeng/source include/comphelper sc/source sw/source

[Miklos Vajna]

 comphelper/source/misc/string.cxx|   11 +++
 editeng/source/editeng/impedit.cxx   |9 -
 include/comphelper/string.hxx|4 
 sc/source/ui/view/gridwin.cxx|   13 -
 sw/source/core/crsr/crsrsh.cxx   |   16 +++-
 sw/source/core/crsr/viscrs.cxx   |   20 +++-
 sw/source/uibase/uiview/viewsrch.cxx |   12 
 7 files changed, 45 insertions(+), 40 deletions(-)

New commits:
commit 1cb13d87b5d887718f6d81a842444b7251dc64cf
Author: Miklos Vajna 
Date:   Thu Oct 8 08:37:12 2015 +0200

editeng, sw, sc: use comphelper::string::join()

Change-Id: I9b0a32271a965bc4089720ccb61b26b67ceab7b2

diff --git a/editeng/source/editeng/impedit.cxx 
b/editeng/source/editeng/impedit.cxx
index ea488b9..83e30ff 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -46,6 +46,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
@@ -350,17 +351,15 @@ void ImpEditView::DrawSelection( EditSelection aTmpSel, 
vcl::Region* pRegion, Ou
 libreOfficeKitCallback(LOK_CALLBACK_TEXT_SELECTION_END, 
aEnd.toString().getStr());
 }
 
-std::stringstream ss;
+std::vector v;
 for (size_t i = 0; i < aRectangles.size(); ++i)
 {
 Rectangle& rRectangle = aRectangles[i];
-if (i)
-ss << "; ";
 if (bMm100ToTwip)
 rRectangle = OutputDevice::LogicToLogic(rRectangle, 
MAP_100TH_MM, MAP_TWIP);
-ss << rRectangle.toString().getStr();
+v.push_back(rRectangle.toString().getStr());
 }
-sRectangle = ss.str().c_str();
+sRectangle = comphelper::string::join("; ", v);
 }
 libreOfficeKitCallback(LOK_CALLBACK_TEXT_SELECTION, 
sRectangle.getStr());
 }
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index aba40ff..395c4b5 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -134,6 +134,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #define LOK_USE_UNSTABLE_API
 #include 
@@ -5895,9 +5896,8 @@ static void updateLibreOfficeKitSelection(ScViewData* 
pViewData, ScDrawLayer* pD
 double nPPTY = pViewData->GetPPTY();
 
 Rectangle aBoundingBox;
-std::stringstream ss;
+std::vector aRectangles;
 
-bool bIsFirst = true;
 for (auto aRectangle : rRectangles)
 {
 aRectangle.Right() += 1;
@@ -5905,14 +5905,9 @@ static void updateLibreOfficeKitSelection(ScViewData* 
pViewData, ScDrawLayer* pD
 
 aBoundingBox.Union(aRectangle);
 
-if (bIsFirst)
-bIsFirst = false;
-else
-ss << "; ";
-
 Rectangle aRect(aRectangle.Left() / nPPTX, aRectangle.Top() / nPPTY,
 aRectangle.Right() / nPPTX, aRectangle.Bottom() / nPPTY);
-ss << aRect.toString().getStr();
+aRectangles.push_back(aRect.toString());
 }
 
 // selection start handle
@@ -5926,7 +5921,7 @@ static void updateLibreOfficeKitSelection(ScViewData* 
pViewData, ScDrawLayer* pD
 pDrawLayer->libreOfficeKitCallback(LOK_CALLBACK_TEXT_SELECTION_END, 
aEnd.toString().getStr());
 
 // the selection itself
-pDrawLayer->libreOfficeKitCallback(LOK_CALLBACK_TEXT_SELECTION, 
ss.str().c_str());
+pDrawLayer->libreOfficeKitCallback(LOK_CALLBACK_TEXT_SELECTION, 
comphelper::string::join("; ", aRectangles).getStr());
 }
 
 void ScGridWindow::UpdateCursorOverlay()
diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index ffd4a82..4ddf5eb 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -64,6 +64,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace com::sun::star;
 using namespace util;
@@ -1204,14 +1205,19 @@ OUString SwCrsrShell::getPageRectangles()
 {
 CurrShell aCurr(this);
 SwRootFrm* pLayout = GetLayout();
-std::stringstream ss;
+std::vector v;
 for (const SwFrm* pFrm = pLayout->GetLower(); pFrm; pFrm = pFrm->GetNext())
 {
-if (pFrm != pLayout->GetLower())
-ss << "; ";
-ss << pFrm->Frm().Left() << ", " << pFrm->Frm().Top() << ", " << 
pFrm->Frm().Width() << ", " << pFrm->Frm().Height();
+std::vector aRectangle
+{
+OString::number(pFrm->Frm().Left()),
+OString::number(pFrm->Frm().Top()),
+OString::number(pFrm->Frm().Width()),
+OString::number(pFrm->Frm().Height())
+};
+v.push_back(comphelper::string::join(", ", aRectangle));
 }
-return OUString::fromUtf8(ss.str().c_str());
+return OUString::fromUtf8(comphelper::string::join("; ", v).getStr());
 }
 
 /// go to the next SSelection

[Libreoffice-bugs] [Bug 94104] Editing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94104

--- Comment #3 from Beluga  ---
Why didn't you do it with Format cells - Numbers - Number - change Language
from English to Danish?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 94846] UI: Search bar should provide consistent feedback when search keys are not found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94846

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 94761] Bitmap patterns are blurry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94761

Beluga  changed:

   What|Removed |Added

   Keywords||regression
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
 Whiteboard||bibisectRequest
   Severity|normal  |minor

--- Comment #2 from Beluga  ---
Confirmed.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94763] Changing theme in Design isn't undoable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94763

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Beluga  ---
By Design window, do you mean Styles?
Undoing a style applying works for me.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94773] FILEOPEN: OOXML - Object fill patterns incorrectly imported as hatching

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94773

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Beluga  ---
Confirmed.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94875] New: animation custom motion path is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94875

Bug ID: 94875
   Summary: animation custom motion path is broken
   Product: LibreOffice
   Version: 5.1.0.0.alpha0+ Master
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Keywords: regression
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 119407
  --> https://bugs.documentfoundation.org/attachment.cgi?id=119407=edit
Click on yellow shape to start animation

Open the attached document. It has a yellow shape with a motion path.
Run the presentation and click on the yellow smiley.
Errors:
The start position gets a black rectangle in size of the bounding box. It
should become the presentation without the shape.
The end position gets a black rectangle in size of the bounding box. It should
show the shape.
The shape is gone.

I use Version: 5.1.0.0.alpha1+
Build ID: 8a334eb222906909bf77006687411ff9e03d9da3
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-10-05_12:35:55
Locale: de-DE (de_DE)

It was OK at least in
Version: 4.2.5.2
Build ID: 6ff819b65674ae6c83f3cbab9e4a4c2b292a7a94

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94850] FILESAVE: Icon set Stars not saved as XLSX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94850

steve -_-  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/fixes11' - svx/source

[Jan Holesovsky]

 svx/source/tbxctrls/tbcontrl.cxx |   10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

New commits:
commit 1596ee98e8c0f59373a0ed908e8573e97dc0b630
Author: Jan Holesovsky 
Date:   Thu Oct 8 11:28:59 2015 +0200

Fix build.

Change-Id: Ie96ae2a5f37a817eea899e32adf8e68737c4253f

diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 0c756d6..3dcc35f 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -138,7 +138,7 @@ public:
 
 protected:
 /// Calculate the optimal width of the dropdown.  Very expensive 
operation, triggers lots of font measurement.
-DECL_DLLPRIVATE_LINK_TYPED(CalcOptimalExtraUserWidth, VclWindowEvent&, 
void);
+DECL_DLLPRIVATE_LINK(CalcOptimalExtraUserWidth, VclWindowEvent*);
 
 virtual voidSelect() SAL_OVERRIDE;
 
@@ -797,11 +797,11 @@ void SvxStyleBox_Impl::UserDraw( const UserDrawEvent& 
rUDEvt )
 DrawEntry( rUDEvt, false, false );
 }
 
-IMPL_LINK_TYPED(SvxStyleBox_Impl, CalcOptimalExtraUserWidth, VclWindowEvent&, 
event, void)
+IMPL_LINK(SvxStyleBox_Impl, CalcOptimalExtraUserWidth, VclWindowEvent*, event)
 {
 // perform the calculation only when we are opening the dropdown
-if (event.GetId() != VCLEVENT_DROPDOWN_PRE_OPEN)
-return;
+if (event->GetId() != VCLEVENT_DROPDOWN_PRE_OPEN)
+return 0;
 
 long nMaxNormalFontWidth = 0;
 sal_Int32 nEntryCount = GetEntryCount();
@@ -838,6 +838,8 @@ IMPL_LINK_TYPED(SvxStyleBox_Impl, 
CalcOptimalExtraUserWidth, VclWindowEvent&, ev
 }
 
 SetUserItemSize(Size(nMaxUserDrawFontWidth - nMaxNormalFontWidth, 
ITEM_HEIGHT));
+
+return 0;
 }
 
 // test is the color between Font- and background-color to be identify
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Crash test update

[Crashtest VM]

New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/b72e63fd5a7caf373eb42bedb2f7db49cef04e91/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Compiling Tiled LibreOffice Xcode Project

[Arjun kochhar]

Also, I seem to get the following warnings in config.log, not sure if this
something I should be worried about, and if I require some specific version
of gcc to get the build going for iOS:

checking for arm-apple-darwin10-gcc... no

checking for gcc... gcc

*configure: WARNING: using cross tools not prefixed with host triplet*

checking whether the C compiler works... yes


On Thu, Oct 8, 2015 at 8:21 AM, Arjun kochhar  wrote:

> Thanks a lot tor, I seem to get couple of compilation errors while trying
> to build using the following commands : "--build=x86_64-apple-darwin14.5.0
>  --host=arm-apple-darwin14 --enable-dbgutil --enable-debug --enable-werror".
> I am currently running OS X Yosemite 10.10.5 on my Mac and have iOS 9.0 SDK
> installed. I updated configure.ac to consider 9.0 as a possible SDK too,
> since the highest value mentioned there was 8.3( I hope that is not an
> issue). But I will try using the additional options you specified to see if
> I can get the build going.
>
> Thanks.
>
> *Thanks,*
> *Arjun Kochhar,*
> *Software Engineer,*
> *Airwatch by VMWare,*
> *Bangalore,India *
>
> On Thu, Oct 8, 2015 at 12:18 AM, Tor Lillqvist  wrote:
>
>> > So possibly a build for iOS will succeed,
>>
>> I had to fix up some bit-rot, but it did build, and the TiledLibreOffice
>> app displayed the simple test1.odt as it should. (But not a more complex
>> document; It crashed, and I have no inspiration now to dig into the exact
>> reasons.)
>>
>> --tml
>>
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Compiling Tiled LibreOffice Xcode Project

[Tor Lillqvist]

>
>
> *configure: WARNING: using cross tools not prefixed with host triplet*
>

This can be ignored.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 94581] Insertion of image from wifi scanner

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94581

--- Comment #2 from Beluga  ---
Translation: Writer crashes when trying to scan an image to the document.

>From a private email: previous versions do not crash. These non-crashing
versions include 5.0.1.1 and 5.0.2.1 32-bits.

It might be that this is a problem with the 64-bit version specifically.

Jean: please reply to this bug report using the comment box and "Save changes"
button from now on.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: two unexpected bugs in LO 4.4.5.2 (and 5.0.2 as well)

[Miklos Vajna]

Hi,

The DOC import filter is under sw/source/filter/ww8/, entry point is
WW8Reader::Read().

Or if your mail was meant to be a bugreport -- this is the wrong list,
please use
https://bugs.documentfoundation.org/enter_bug.cgi?product=LibreOffice
for that purpose, since this list is for discussing code and patches.

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 94846] UI: Search bar should provide consistent feedback when search keys are not found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94846

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94846] UI: Search bar should provide consistent feedback when search keys are not found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94846

--- Comment #8 from Alex Thurgood  ---
@laszio : which version of OSX are you using ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 94846] UI: Search bar should provide consistent feedback when search keys are not found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94846

--- Comment #8 from Alex Thurgood  ---
@laszio : which version of OSX are you using ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 94874] New: 2nd Editing of Footer or Header causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94874

Bug ID: 94874
   Summary: 2nd Editing of Footer or Header causes crash
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mutlubat...@gmail.com

User-Agent:   Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML,
like Gecko) Ubuntu Chromium/45.0.2454.101 Chrome/45.0.2454.101 Safari/537.36
Build Identifier: LibreOffice 4.4.3.2

In Print Preview or Format>Page menu, Consecutive editing of Header or Footer
(i.e. putting a borderline from More... option) causes crash. Beside this, I
have tried to put a top borderline on the footer of the two sheets in the same
spreadsheet, it does not let me have borderline on both of the sheets
simultaneously. 


Reproducible: Always

Steps to Reproduce:
1.print preview (or Format>Page)
2. Footer (or Header)
3. More...
4. put a borderline on the top
Say OK. and then change to the other Sheet. 
Repeat the same. When you click on More... , 
Actual Results:  
Calc crashes.

Expected Results:  
it should let me continue editing. 

[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes


Reset User Profile?No

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94806] Cannot activate Impress remote

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94806

Beluga  changed:

   What|Removed |Added

 CC|todven...@suomi24.fi|

--- Comment #1 from Beluga  ---
Please mark the version to the version field.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92158] Input fields in editable protected section only partially editable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92158

--- Comment #2 from Kulo  ---
Also reproducible with Windows 7 Pro x64
Version: 5.0.2.2 (x64)
Build-ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Gebietsschema: de-AT (de_AT)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Compiling Tiled LibreOffice Xcode Project

[Arjun kochhar]

Thanks. In the morning today, I shifted to git://gerrit.libreoffice.org/core
master branch and along with the regular iOS build options in README.cross,
I added the options that you had provided but I seem to be getting this
error now somewhere down the line : "~/lo/core/solenv/gbuild/LinkTarget.mk:518:
*** used LinkTarget StaticLibrary/libregistry_helper.a not defined.
Stop.", somewhere here:

"[build ECH] CustomTarget/postprocess/registry/writer.list

[build ECH] CustomTarget/postprocess/registry/xsltfilter.list

[build ECH] CustomTarget/postprocess/registry/Langpack-en-US.list

[build CUS] readlicense_oo/readme

/Users/akochhar/lo/core/solenv/gbuild/LinkTarget.mk:518: *** used
LinkTarget StaticLibrary/libregistry_helper.a not defined.  Stop.

make[1]: *** Waiting for unfinished jobs

make: *** [build] Error 2"


Not sure how close to the build completion I am right now and currently
trying to figure out what might be going wrong here.


On Thu, Oct 8, 2015 at 11:55 AM, Tor Lillqvist  wrote:

>
>
> On 8 October 2015 at 05:51, Arjun kochhar  wrote:
>
>> I updated configure.ac to consider 9.0 as a possible SDK too, since the
>> highest value mentioned there was 8.3
>>
>
> Then you must be using some other branch than master, because that was
> changed on June 16 in master. Please use the master branch for any iOS
> build attempts, as the (very few) iOS-specific fixes I do (I try it maybe
> once a month) go into master, not any "stable" branch.
>
> --tml
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 94846] UI: Search bar should provide consistent feedback when search keys are not found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94846

--- Comment #7 from Alex Thurgood  ---
No repro 

Version: 5.0.2.2
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale : fr-FR (fr.UTF-8)

OSX 10.11

when I type in any string and press enter in the search dialog in an empty
Writer document, I get a "Expression not found" message immediately.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 94846] UI: Search bar should provide consistent feedback when search keys are not found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94846

--- Comment #7 from Alex Thurgood  ---
No repro 

Version: 5.0.2.2
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale : fr-FR (fr.UTF-8)

OSX 10.11

when I type in any string and press enter in the search dialog in an empty
Writer document, I get a "Expression not found" message immediately.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/qa sw/source

[Michael Stahl]

 sw/qa/extras/uiwriter/uiwriter.cxx  |   57 
 sw/source/core/doc/DocumentContentOperationsManager.cxx |   43 ++--
 sw/source/core/inc/DocumentContentOperationsManager.hxx |2 
 3 files changed, 94 insertions(+), 8 deletions(-)

New commits:
commit 06a66af0b754b62f18783c77410c7929f8134941
Author: Michael Stahl 
Date:   Fri Oct 2 15:13:18 2015 +0200

sw: fix copying of bookmarks in CopyRange

If the copied range starts with a not fully selected paragraph, the
bookmarks that are copied will be created on the wrong paragraphs,
on the node after the correct one.

This also happens when hinding the redlines, and causes asserts from
attempting to create CrossRefBookmarks on table nodes on WW8 export of
fdo66302-1.odt and fdo66312-1.odt.

Change-Id: Id576be3e38a89527d967f02b39d9aabbf6368354
(cherry picked from commit c95ba3ef2613e9d5abd2f19ab2432c7bc1a40fe7)
Reviewed-on: https://gerrit.libreoffice.org/19104
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 006cb46..364439b 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -67,6 +67,7 @@ public:
 //EDITING: undo search corrupt text when searching backward
 void testReplaceBackward();
 void testRedlineFrame();
+void testBookmarkCopy();
 void testFdo69893();
 void testFdo70807();
 void testImportRTF();
@@ -108,6 +109,7 @@ public:
 CPPUNIT_TEST(testReplaceForward);
 CPPUNIT_TEST(testReplaceBackward);
 CPPUNIT_TEST(testRedlineFrame);
+CPPUNIT_TEST(testBookmarkCopy);
 CPPUNIT_TEST(testFdo69893);
 CPPUNIT_TEST(testFdo70807);
 CPPUNIT_TEST(testImportRTF);
@@ -221,6 +223,61 @@ void SwUiWriterTest::testRedlineFrame()
 CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xDrawPage->getCount());
 }
 
+void SwUiWriterTest::testBookmarkCopy()
+{
+SwDoc * pDoc(createDoc());
+
+// add text and bookmark
+IDocumentMarkAccess & rIDMA(*pDoc->getIDocumentMarkAccess());
+IDocumentContentOperations & rIDCO(pDoc->getIDocumentContentOperations());
+SwNodeIndex aIdx(pDoc->GetNodes().GetEndOfContent(), -1);
+SwCursor aPaM(SwPosition(aIdx), nullptr, false);
+rIDCO.InsertString(aPaM, OUString("foo"));
+rIDCO.SplitNode(*aPaM.GetPoint(), false);
+rIDCO.InsertString(aPaM, OUString("bar"));
+aPaM.SetMark();
+aPaM.MovePara(GetfnParaCurr(), GetfnParaStart());
+rIDMA.makeMark(aPaM, OUString("Mark"), 
IDocumentMarkAccess::MarkType::BOOKMARK);
+aPaM.Exchange();
+aPaM.DeleteMark();
+rIDCO.SplitNode(*aPaM.GetPoint(), false);
+rIDCO.InsertString(aPaM, OUString("baz"));
+
+// copy range
+rIDCO.SplitNode(*aPaM.GetPoint(), false);
+SwPosition target(*aPaM.GetPoint());
+aPaM.Move(fnMoveBackward, fnGoContent);
+aPaM.SetMark();
+aPaM.SttEndDoc(true/*start*/);
+aPaM.Move(fnMoveForward, fnGoContent); // partially select 1st para
+
+rIDCO.CopyRange(aPaM, target, /*bCopyAll=*/false, /*bCheckPos=*/true);
+
+// check bookmark was copied to correct position
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), rIDMA.getBookmarksCount());
+for (auto it(rIDMA.getBookmarksBegin()); it != rIDMA.getBookmarksEnd(); 
++it)
+{
+OUString markText(SwPaM((*it)->GetMarkPos(), 
(*it)->GetOtherMarkPos()).GetText());
+CPPUNIT_ASSERT_EQUAL(OUString("bar"), markText);
+}
+
+// copy 2nd time, such that bCanMoveBack is false in CopyImpl
+SwPaM aCopyPaM(*aPaM.GetMark(), *aPaM.GetPoint());
+aPaM.SttEndDoc(true/*start*/);
+rIDCO.SplitNode(*aPaM.GetPoint(), false);
+aPaM.SttEndDoc(true/*start*/);
+
+rIDCO.CopyRange(aCopyPaM, *aPaM.GetPoint(), /*bCopyAll=*/false, 
/*bCheckPos=*/true);
+
+// check bookmark was copied to correct position
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), rIDMA.getBookmarksCount());
+for (auto it(rIDMA.getBookmarksBegin()); it != rIDMA.getBookmarksEnd(); 
++it)
+{
+OUString markText(SwPaM((*it)->GetMarkPos(), 
(*it)->GetOtherMarkPos()).GetText());
+CPPUNIT_ASSERT_EQUAL(OUString("bar"), markText);
+}
+}
+
 void SwUiWriterTest::testFdo75110()
 {
 SwDoc* pDoc = createDoc("fdo75110.odt");
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx 
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 1f387f4..77228f0 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -3129,11 +3129,14 @@ void DocumentContentOperationsManager::CopyWithFlyInFly(
 const SwNodeRange& rRg,
 const sal_Int32 nEndContentIndex,
 const SwNodeIndex& rInsPos,
-const SwPaM* pCopiedPaM,
+const std::pair* pCopiedPaM /*and real 
insert pos*/,
 const bool bMakeNewFrms,
 const bool bDelRedlines,
 const bool 

[Libreoffice-bugs] [Bug 84726] LibreOffice for Android most annoying bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84726
Bug 84726 depends on bug 89168, which changed state.

Bug 89168 Summary: android: React on page size changes
https://bugs.documentfoundation.org/show_bug.cgi?id=89168

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93999] LibreOffice Draw 5.0.1 crashes all the time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93999

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||momonas...@gmail.com
 Ever confirmed|0   |1

--- Comment #2 from Maxim Monastirsky  ---
Hi Giovanni,

Does it still crash for you in 5.0.2? If yes - please open a terminal and do
"export SAL_USE_VCLPLUGIN=gtk", and then start LO from the same terminal. Does
it help?

Also would be great to get a backtrace of the crash:

https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#GNU.2FLinux:_How_to_get_a_backtrace

Setting to NEEDINFO until the requested information is provided. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89168] android: React on page size changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89168

Jan Holesovsky  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---
Summary|android: Additional page|android: React on page size
   |that should not be present  |changes

--- Comment #2 from Jan Holesovsky  ---
I'm afraid there are still other documents that do not work correctly, as there
is no implementation of the LOK_CALLBACK_DOCUMENT_SIZE_CHANGED handling; so
let's keep it open please, just with a changed summary...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94765] Simple Gradients in SVG files are Blacked out

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94765

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #3 from Beluga  ---
Confirmed on insert to Writer.
Could not find a duplicate either.

Another recent report: bug 94588

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+
Build ID: f830600ece806ec365a4839e79afabe183c5e36d
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-10-06_22:49:09
Locale: en-US (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - desktop/CppunitTest_desktop_lib.mk desktop/qa desktop/source sc/source

[Miklos Vajna]

 desktop/CppunitTest_desktop_lib.mk  |3 +
 desktop/qa/data/search.ods  |binary
 desktop/qa/desktop_lib/test_desktop_lib.cxx |   76 ++--
 desktop/source/lib/init.cxx |8 ++
 sc/source/ui/view/viewfun2.cxx  |3 -
 5 files changed, 86 insertions(+), 4 deletions(-)

New commits:
commit 97c414758d3d8aa3cc2233d52612cf0a33c24c34
Author: Miklos Vajna 
Date:   Thu Oct 8 10:56:49 2015 +0200

CppunitTest_desktop_lib: add Calc find-all testcase

Fails without commit a31f95b180728c1c671930913b4b4ad96ebcda5f (sc tiled
rendering: fix showing all search results, 2015-10-07).

Change-Id: Ibc01d468168367f789b3f5046808104fa3f5ef18

diff --git a/desktop/CppunitTest_desktop_lib.mk 
b/desktop/CppunitTest_desktop_lib.mk
index be39460..0c963f9 100644
--- a/desktop/CppunitTest_desktop_lib.mk
+++ b/desktop/CppunitTest_desktop_lib.mk
@@ -56,11 +56,14 @@ $(eval $(call gb_CppunitTest_use_components,desktop_lib,\
 svtools/util/svt \
 sw/util/sw \
 sw/util/swd \
+sc/util/sc \
+sc/util/scd \
 toolkit/util/tk \
 ucb/source/core/ucb1 \
 ucb/source/ucp/file/ucpfile1 \
 unoxml/source/service/unoxml \
 xmloff/util/xo \
+i18npool/source/search/i18nsearch \
 ))
 
 $(eval $(call gb_CppunitTest_use_configuration,desktop_lib))
diff --git a/desktop/qa/data/search.ods b/desktop/qa/data/search.ods
new file mode 100644
index 000..ea1d731
Binary files /dev/null and b/desktop/qa/data/search.ods differ
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index a7696d8..3e00e59 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -16,6 +16,11 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
 
 #include "../../inc/lib/init.hxx"
 
@@ -45,14 +50,17 @@ public:
 UnoApiTest::tearDown();
 };
 
-LibLODocument_Impl* loadDoc(const char* pName);
+LibLODocument_Impl* loadDoc(const char* pName, LibreOfficeKitDocumentType 
eType = LOK_DOCTYPE_TEXT);
 void closeDoc();
+static void callback(int nType, const char* pPayload, void* pData);
+void callbackImpl(int nType, const char* pPayload);
 
 void testGetStyles();
 void testGetFonts();
 void testCreateView();
 void testGetFilterTypes();
 void testGetPartPageRectangles();
+void testSearchCalc();
 
 CPPUNIT_TEST_SUITE(DesktopLOKTest);
 CPPUNIT_TEST(testGetStyles);
@@ -60,16 +68,31 @@ public:
 CPPUNIT_TEST(testCreateView);
 CPPUNIT_TEST(testGetFilterTypes);
 CPPUNIT_TEST(testGetPartPageRectangles);
+CPPUNIT_TEST(testSearchCalc);
 CPPUNIT_TEST_SUITE_END();
 
 uno::Reference mxComponent;
+OString m_aTextSelection;
 };
 
-LibLODocument_Impl* DesktopLOKTest::loadDoc(const char* pName)
+LibLODocument_Impl* DesktopLOKTest::loadDoc(const char* pName, 
LibreOfficeKitDocumentType eType)
 {
 OUString aFileURL;
 createFileURL(OUString::createFromAscii(pName), aFileURL);
-mxComponent = loadFromDesktop(aFileURL, "com.sun.star.text.TextDocument");
+OUString aService;
+switch (eType)
+{
+case LOK_DOCTYPE_TEXT:
+aService = "com.sun.star.text.TextDocument";
+break;
+case LOK_DOCTYPE_SPREADSHEET:
+aService = "com.sun.star.sheet.SpreadsheetDocument";
+break;
+default:
+CPPUNIT_ASSERT(false);
+break;
+}
+mxComponent = loadFromDesktop(aFileURL, aService);
 if (!mxComponent.is())
 {
 CPPUNIT_ASSERT(false);
@@ -86,6 +109,23 @@ void DesktopLOKTest::closeDoc()
 }
 }
 
+void DesktopLOKTest::callback(int nType, const char* pPayload, void* pData)
+{
+static_cast(pData)->callbackImpl(nType, pPayload);
+}
+
+void DesktopLOKTest::callbackImpl(int nType, const char* pPayload)
+{
+switch (nType)
+{
+case LOK_CALLBACK_TEXT_SELECTION:
+{
+m_aTextSelection = pPayload;
+}
+break;
+}
+}
+
 void DesktopLOKTest::testGetStyles()
 {
 LibLODocument_Impl* pDocument = loadDoc("blank_text.odt");
@@ -191,6 +231,36 @@ void DesktopLOKTest::testGetFilterTypes()
 free(pJSON);
 }
 
+void DesktopLOKTest::testSearchCalc()
+{
+LibLibreOffice_Impl aOffice;
+comphelper::LibreOfficeKit::setActive();
+LibLODocument_Impl* pDocument = loadDoc("search.ods");
+pDocument->pClass->initializeForRendering(pDocument);
+pDocument->pClass->registerCallback(pDocument, ::callback, 
this);
+
+uno::Sequence 
aPropertyValues(comphelper::InitPropertySequence(
+{
+{"SearchItem.SearchString", uno::makeAny(OUString("foo"))},
+{"SearchItem.Backward", uno::makeAny(false)},
+{"SearchItem.Command", 
uno::makeAny(static_cast(SvxSearchCmd::FIND_ALL))},
+}));
+comphelper::dispatchCommand(".uno:ExecuteSearch", aPropertyValues);
+
+std::vector aSelections;

[Libreoffice-bugs] [Bug 94871] [HELP] note and warning paragraphs are aligned incorrectly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94871

--- Comment #2 from Lera  ---
Created attachment 119406
  --> https://bugs.documentfoundation.org/attachment.cgi?id=119406=edit
.xhp file

I attach .xhp file.

Also, you can download the latest version
https://gerrit.libreoffice.org/#/c/19236/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Noel Grandin]

 vcl/source/window/event.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 1d0839fb98b8ec672e22b21867297317c8a961ee
Author: Noel Grandin 
Date:   Thu Oct 8 10:51:19 2015 +0200

fix for tdf#94827 - ToolBox events aren't delivered

regression from 1e67e94f1a308ca60d4934e9fe9d5c048225ebe8
"convert Link<> to typed"

Change-Id: Ibb20366f0edcb9425d61ce5e9d5fb1a34533785b

diff --git a/vcl/source/window/event.cxx b/vcl/source/window/event.cxx
index ac950d6..548e870 100644
--- a/vcl/source/window/event.cxx
+++ b/vcl/source/window/event.cxx
@@ -238,16 +238,17 @@ void Window::CallEventListeners( sal_uLong nEvent, void* 
pData )
 if ( aDelData.IsDead() )
 return;
 
-if (!mpWindowImpl->maEventListeners.empty())
+auto& rChildListeners = pWindow->mpWindowImpl->maChildEventListeners;
+if (!rChildListeners.empty())
 {
 // Copy the list, because this can be destroyed when calling a 
Link...
-std::vector> aCopy( 
mpWindowImpl->maChildEventListeners );
+std::vector> aCopy( rChildListeners );
 for ( Link& rLink : aCopy )
 {
 if (aDelData.IsDead())
 return;
 // check this hasn't been removed in some re-enterancy 
scenario fdo#47368
-if( std::find(mpWindowImpl->maChildEventListeners.begin(), 
mpWindowImpl->maChildEventListeners.end(), rLink) != 
mpWindowImpl->maChildEventListeners.end() )
+if( std::find(rChildListeners.begin(), rChildListeners.end(), 
rLink) != rChildListeners.end() )
 rLink.Call( aEvent );
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94875] animation custom motion path is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94875

--- Comment #1 from Regina Henschel  ---
It was OK in Version: 5.1.0.0.alpha1+
Build ID: 8cd2a372e3867f99b397b9ec089d6e1f7efd1088
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-06-21_10:44:17
Locale: de-DE (de_DE)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Calc function to check for text that could be number in order to place UI indicators

[Markus Mohrhard]

Hey,

On Thu, Oct 8, 2015 at 11:31 AM, Caolán McNamara  wrote:

> On Wed, 2015-10-07 at 14:10 +0200, Eike Rathke wrote:
> > Hi Łukasz,
> >
> > On the LibreOffice Conference Hackfest at Aarhus we talked about
> > placing UI indicators in the current view to hint cells that contain
> > text that could be numbers instead.
>
> That would be v. neat. If we had a UI indicator for errors/warnings
> detected in the idle loop I imagine we could extend it with all sorts
> of checks, like Andrzej's unit detection stuff and things like
> "formulas inconsistent with neighbouring formulas" ?
>


Some such checks have been implemented this summer as part of GSoC. I still
need to integrate it outside of the unit tests into calc but would have
chosen a dialog for now.

Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 92478] CRASH when open "scan > scanner source" on windows 10 x64.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92478

raal  changed:

   What|Removed |Added

 CC||astrob...@free.fr

--- Comment #10 from raal  ---
*** Bug 94581 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94762] "Design" button is gone after viewing "Print Preview" (sidebar)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94762

--- Comment #5 from Maxim Monastirsky  ---
(In reply to Beluga from comment #4)
> I have no such thing in any version.
You should turn on experimental features.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92045] Unchecking blinking font effect does not work with DOCX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92045

Beluga  changed:

   What|Removed |Added

 CC||i...@pedrazzi.eu

--- Comment #13 from Beluga  ---
*** Bug 94805 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94805] Always blinking text on .docx files received via email.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94805

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||todven...@suomi24.fi
 Resolution|--- |DUPLICATE

--- Comment #2 from Beluga  ---
(In reply to MM from comment #1)
> Looks like a dup, bug 92045

I think so, too. Closing.

*** This bug has been marked as a duplicate of bug 92045 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa writerfilter/source

[Miklos Vajna]

 sw/qa/core/data/rtf/pass/tdf94049.rtf  |   12 
 writerfilter/source/rtftok/rtfdocumentimpl.cxx |9 ++---
 2 files changed, 18 insertions(+), 3 deletions(-)

New commits:
commit 0d79e4c07a7a7328cc0bed1d7998317b634543d8
Author: Miklos Vajna 
Date:   Thu Oct 8 14:30:13 2015 +0200

tdf#94049 RTF import: add missing check for empty shape when popping state

Change-Id: I3c9a5f89df721618bb60b8932b69a371bb6f3ff1

diff --git a/sw/qa/core/data/rtf/pass/tdf94049.rtf 
b/sw/qa/core/data/rtf/pass/tdf94049.rtf
new file mode 100644
index 000..52e25eb
--- /dev/null
+++ b/sw/qa/core/data/rtf/pass/tdf94049.rtf
@@ -0,0 +1,12 @@
+{\rtf1
+\pard\plain\par 
+{\object\objemb\objw608\objh774\objscalex100\objscaley100
+{\*\objdata
+0105020008005061636b616765006250726f674d616e2e4558450014000100633a5c646f735c61747472696220002f00101c010505000d004d45544146494c4550494354002204a0fa48040800220460058e1f0100090309020200410105000b0205000c02330027001000fb02f5ff90010422417269616c00575404002d010500090205000102ff006500410bc6008800200020002000240028002000210001008000ff00fc7ffe3ffbdff73ffceffefc1f700fc0030001fffefffe7ffe7ffc7ff00fe003c001803ff83ff87ff8fff80101fffc0101fffc0183fffe0383fffe038707c707cf8fcf9f0500090201000500010201000500090
 
205000102ff004101410b4600660020002000200024002800200021000402808000808000800080008000808080808000c0c0c000ffff0000ff00ff00ff00ff777007770007707000777700070007708f07708f08f08f08f080887700ff08f08f08f00ff08f008fff8877f0080088000fff80008f80008808fff87000608f0ff8008f870700066088f0fff088070e66088f0f0bb07770060e6660880007f0bb0787776660e666000bb07878770e6660bb0887878760ee0700f8887878667f8f888780
 
6608f8f88870660f8f8f88800000f8f8f80000008f8f8f00066608f8f0660f8f806000f8006000800500090201000500010201000d00fb020001004404002d01010003802f00101c}
+}
+\pard\plain\par 
+{\object\objemb\objw608\objh774\objscalex100\objscaley100
+{\*\objdata
+0105020008005061636b616765006250726f674d616e2e4558450014000100633a5c646f735c61747472696220002f00101c010505000d004d45544146494c4550494354002204a0fa48040800220460058e1f0100090309020200410105000b0205000c02330027001000fb02f5ff90010422417269616c00575404002d010500090205000102ff006500410bc6008800200020002000240028002000210001008000ff00fc7ffe3ffbdff73ffceffefc1f700fc0030001fffefffe7ffe7ffc7ff00fe003c001803ff83ff87ff8fff80101fffc0101fffc0183fffe0383fffe038707c707cf8fcf9f0500090201000500010201000500090
 

[Libreoffice-bugs] [Bug 94809] SEH Exception: Access Violation when opening .docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94809

--- Comment #2 from Beluga  ---
Created attachment 119409
  --> https://bugs.documentfoundation.org/attachment.cgi?id=119409=edit
Backtrace of crash on Windows 5.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94762] "Design" button is gone after viewing "Print Preview"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94762

--- Comment #3 from raal  ---
Created attachment 119410
  --> https://bugs.documentfoundation.org/attachment.cgi?id=119410=edit
design button in the sidebar

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: writerperfect/source

[Caolán McNamara]

 writerperfect/source/writer/WordPerfectImportFilter.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 64a252ffa9d0c30bec195a68c6837a0acdeca29a
Author: Caolán McNamara 
Date:   Thu Oct 8 11:18:33 2015 +0100

don't crash on loading abi13730-1.wpd

Change-Id: I3796f16c4df8cc055fb1a75b1583c5b959f02799

diff --git a/writerperfect/source/writer/WordPerfectImportFilter.cxx 
b/writerperfect/source/writer/WordPerfectImportFilter.cxx
index cc38317..7bbb36f 100644
--- a/writerperfect/source/writer/WordPerfectImportFilter.cxx
+++ b/writerperfect/source/writer/WordPerfectImportFilter.cxx
@@ -84,6 +84,9 @@ static bool handleEmbeddedWPGImage(const 
librevenge::RVNGBinaryData , libr
 if (!libwpg::WPGraphics::parse(input.getDataStream(), , 
fileFormat))
 return false;
 
+if (svgOutput.empty())
+return false;
+
 assert(1 == svgOutput.size());
 
 output.clear();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94762] "Design" button is gone after viewing "Print Preview" (sidebar)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94762

raal  changed:

   What|Removed |Added

Summary|"Design" button is gone |"Design" button is gone
   |after viewing "Print|after viewing "Print
   |Preview"|Preview"  (sidebar)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94871] [HELP] note and warning paragraphs are aligned incorrectly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94871

--- Comment #4 from Regina Henschel  ---


is needless.
The section, which will be embed with the next element, has got the attribute
'role="note"' itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94762] "Design" button is gone after viewing "Print Preview" (sidebar)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94762

--- Comment #6 from Beluga  ---
(In reply to Maxim Monastirsky from comment #5)
> (In reply to Beluga from comment #4)
> > I have no such thing in any version.
> You should turn on experimental features.

Thanks, I could repro.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93860] crash after marking a table and moving the mouse wheel

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93860

Jaime T  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Jaime T  ---
I am not able ro reproduce the crash with the daily builds and several tests
documents.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/bubli/lhm-4-1-6-backports' - sc/source

[Katarina Behrens]

 sc/source/core/tool/formulaopt.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 0d8b54e38fc4aeb12624ef457de26e5646c79a6a
Author: Katarina Behrens 
Date:   Thu Oct 8 12:55:21 2015 +0200

Related tdf#93688: save CalcA1|ExcelA1 also as a global option

without this patch, it's only possible to save it on per-document
basis

Change-Id: I13359b751ef766c7de53e9e21c299aadbbc0fbf4

diff --git a/sc/source/core/tool/formulaopt.cxx 
b/sc/source/core/tool/formulaopt.cxx
index 8e5caea..244f667 100644
--- a/sc/source/core/tool/formulaopt.cxx
+++ b/sc/source/core/tool/formulaopt.cxx
@@ -327,6 +327,9 @@ ScFormulaCfg::ScFormulaCfg() :
 case 2: // Excel R1C1
 eConv = formula::FormulaGrammar::CONV_XL_R1C1;
 break;
+case 3: // Calc A1 | Excel A1
+eConv = formula::FormulaGrammar::CONV_A1_XL_A1;
+break;
 default:
 ;
 }
@@ -443,6 +446,7 @@ void ScFormulaCfg::Commit()
 case ::formula::FormulaGrammar::CONV_OOO: nVal = 0; 
break;
 case ::formula::FormulaGrammar::CONV_XL_A1:   nVal = 1; 
break;
 case ::formula::FormulaGrammar::CONV_XL_R1C1: nVal = 2; 
break;
+case ::formula::FormulaGrammar::CONV_A1_XL_A1: nVal = 3; 
break;
 default: break;
 }
 pValues[nProp] <<= nVal;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94878] New: Elementary icon theme cleanup

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94878

Bug ID: 94878
   Summary: Elementary icon theme cleanup
   Product: LibreOffice
   Version: 5.1.0.0.alpha0+ Master
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com

In bug 92458, the elementary icon theme was integrated in with all the icons
from its package, which includes icons from human, industrial and galaxy. So
these duplicate icons should be removed and the elementary icon package should
be set to correctly inherit icons from its parent icon themes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94776] AutoCorrect doesn't work in Mac OS X 10.11 El Capitan

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94776

--- Comment #7 from tommy27  ---
is the autocorrect malfunction just limited to arrows or other symbols are
affected?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94879] New: add 'm' suffixes to member variables ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94879

Bug ID: 94879
   Summary: add 'm' suffixes to member variables ...
   Product: LibreOffice
   Version: 5.0.2.1 rc
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: michael.me...@collabora.com

The Storage code is currently really hard to read - since its missing 'm'
suffixes on its variables:

sot/source/sdstor.cxx:

bool StgStrm::Pos2Page( sal_Int32 nBytePos )

if ( !pFat )
return false;

// Values < 0 seek to the end
if( nBytePos < 0 || nBytePos >= nSize )
nBytePos = nSize;
// Adjust the position back to offset 0
nPos -= nOffset;
sal_Int32 nMask = ~( nPageSize - 1 );
sal_Int32 nOld = nPos & nMask;
sal_Int32 nNew = nBytePos & nMask;
nOffset = (short) ( nBytePos & ~nMask );
...

Pretty quickly the 'nPos' (a member) gets mixed with the 'nNew' (a local) etc.

The usual convention is to use an 'm' prefix; so: 'mpFat' 'mnPos' 'mnOffset'
here to make this much more readable.

It'd be great to have a patch that adds that for members in this module;
perhaps separate patches for similar problems in other sot/ modules would be
good too.

Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94880] percent values are not well imported from csv file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94880

--- Comment #1 from remyD  ---
Created attachment 119415
  --> https://bugs.documentfoundation.org/attachment.cgi?id=119415=edit
imported csv values

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/qa sc/source

[Miklos Vajna]

 desktop/qa/desktop_lib/test_desktop_lib.cxx |   13 
 sc/source/ui/inc/gridwin.hxx|2 +
 sc/source/ui/view/gridwin.cxx   |   23 ++---
 sc/source/ui/view/viewfun2.cxx  |   30 +---
 4 files changed, 62 insertions(+), 6 deletions(-)

New commits:
commit a42f582e0e8ee4118415632795184620c6b8058c
Author: Miklos Vajna 
Date:   Thu Oct 8 11:49:13 2015 +0200

sc tiled rendering: implement LOK_CALLBACK_SEARCH_RESULT_SELECTION

Change-Id: Iaca2c1807a6e92cf7a87b0843000d65aea45fe7b

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 3e00e59..e77bc89 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -73,6 +73,7 @@ public:
 
 uno::Reference mxComponent;
 OString m_aTextSelection;
+std::vector m_aSearchResultSelection;
 };
 
 LibLODocument_Impl* DesktopLOKTest::loadDoc(const char* pName, 
LibreOfficeKitDocumentType eType)
@@ -123,6 +124,16 @@ void DesktopLOKTest::callbackImpl(int nType, const char* 
pPayload)
 m_aTextSelection = pPayload;
 }
 break;
+case LOK_CALLBACK_SEARCH_RESULT_SELECTION:
+{
+m_aSearchResultSelection.clear();
+boost::property_tree::ptree aTree;
+std::stringstream aStream(pPayload);
+boost::property_tree::read_json(aStream, aTree);
+for (boost::property_tree::ptree::value_type& rValue : 
aTree.get_child("searchResultSelection"))
+m_aSearchResultSelection.push_back(rValue.second.data().c_str());
+}
+break;
 }
 }
 
@@ -256,6 +267,8 @@ void DesktopLOKTest::testSearchCalc()
 } while (nIndex >= 0);
 // This was 1, find-all only found one match.
 CPPUNIT_ASSERT_EQUAL(static_cast(2), aSelections.size());
+// Make sure that we get exactly as many rectangle lists as matches.
+CPPUNIT_ASSERT_EQUAL(static_cast(2), 
m_aSearchResultSelection.size());
 
 closeDoc();
 comphelper::LibreOfficeKit::setActive(false);
diff --git a/sc/source/ui/inc/gridwin.hxx b/sc/source/ui/inc/gridwin.hxx
index ae2bc5d..689b8d5 100644
--- a/sc/source/ui/inc/gridwin.hxx
+++ b/sc/source/ui/inc/gridwin.hxx
@@ -336,6 +336,8 @@ public:
 /// @see vcl::ITiledRenderable::setTextSelection() for the values of nType.
 /// Coordinates are in pixels.
 void SetCellSelectionPixel(int nType, int nPixelX, int nPixelY);
+/// Get the cell selection, coordinates are in logic units.
+void GetCellSelection(std::vector& rLogicRects);
 
 virtual ::com::sun::star::uno::Reference< 
::com::sun::star::accessibility::XAccessible > CreateAccessible() SAL_OVERRIDE;
 
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 395c4b5..5c6cb5e 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -5886,8 +5886,12 @@ void ScGridWindow::UpdateCopySourceOverlay()
 SetMapMode( aOldMode );
 }
 
-/// Turn the selection ranges rRectangles into the LibreOfficeKit selection, 
and call the callback.
-static void updateLibreOfficeKitSelection(ScViewData* pViewData, ScDrawLayer* 
pDrawLayer, const std::vector& rRectangles)
+/**
+ * Turn the selection ranges rRectangles into the LibreOfficeKit selection, 
and call the callback.
+ *
+ * @param pLogicRects - if not 0, then don't invoke the callback, just collect 
the rectangles in the pointed vector.
+ */
+static void updateLibreOfficeKitSelection(ScViewData* pViewData, ScDrawLayer* 
pDrawLayer, const std::vector& rRectangles, std::vector* 
pLogicRects = 0)
 {
 if (!pDrawLayer->isTiledRendering())
 return;
@@ -5907,9 +5911,15 @@ static void updateLibreOfficeKitSelection(ScViewData* 
pViewData, ScDrawLayer* pD
 
 Rectangle aRect(aRectangle.Left() / nPPTX, aRectangle.Top() / nPPTY,
 aRectangle.Right() / nPPTX, aRectangle.Bottom() / nPPTY);
-aRectangles.push_back(aRect.toString());
+if (pLogicRects)
+pLogicRects->push_back(aRect);
+else
+aRectangles.push_back(aRect.toString());
 }
 
+if (pLogicRects)
+return;
+
 // selection start handle
 Rectangle aStart(aBoundingBox.Left() / nPPTX, aBoundingBox.Top() / nPPTY,
 aBoundingBox.Left() / nPPTX, (aBoundingBox.Top() / nPPTY) + 256);
@@ -6093,6 +6103,13 @@ void ScGridWindow::UpdateCursorOverlay()
 SetMapMode( aOldMode );
 }
 
+void ScGridWindow::GetCellSelection(std::vector& rLogicRects)
+{
+std::vector aPixelRects;
+GetSelectionRects(aPixelRects);
+updateLibreOfficeKitSelection(pViewData, 
pViewData->GetDocument()->GetDrawLayer(), aPixelRects, );
+}
+
 void ScGridWindow::DeleteSelectionOverlay()
 {
 mpOOSelection.reset();
diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx
index dc0ef09..36b2311 100644
--- a/sc/source/ui/view/viewfun2.cxx
+++ b/sc/source/ui/view/viewfun2.cxx

[Libreoffice-commits] core.git: lotuswordpro/source

[Caolán McNamara]

 lotuswordpro/source/filter/lwpfrib.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit cc1273543f4084a779a2b0400c22466672557a95
Author: Caolán McNamara 
Date:   Thu Oct 8 10:50:23 2015 +0100

Resolves: tdf#93818 crash on loading certain lwp

Change-Id: I11f523a0936b843155f3b47139d0fc58d4d0342b

diff --git a/lotuswordpro/source/filter/lwpfrib.cxx 
b/lotuswordpro/source/filter/lwpfrib.cxx
index 7d5bbb5..c6c3160 100644
--- a/lotuswordpro/source/filter/lwpfrib.cxx
+++ b/lotuswordpro/source/filter/lwpfrib.cxx
@@ -245,10 +245,14 @@ void LwpFrib::RegisterStyle(LwpFoundry* pFoundry)
 XFTextStyle* pStyle = NULL;
 m_StyleName.clear();
 XFStyleManager* pXFStyleManager = 
LwpGlobalMgr::GetInstance()->GetXFStyleManager();
+XFTextStyle* pNamedStyle = nullptr;
 if (m_pModifiers->HasCharStyle)
 {
-XFTextStyle* pNamedStyle = static_cast
+pNamedStyle = static_cast
 
(pFoundry->GetStyleManager()->GetStyle(m_pModifiers->CharStyleID));
+}
+if (pNamedStyle)
+{
 if (m_pModifiers->FontID)
 {
 pStyle = new XFTextStyle();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Tor Lillqvist]

 vcl/source/opengl/OpenGLHelper.cxx |   24 
 1 file changed, 20 insertions(+), 4 deletions(-)

New commits:
commit b69e55bdb2544f3fcc492d535a77ff17022ed6d5
Author: Tor Lillqvist 
Date:   Thu Oct 8 13:24:12 2015 +0300

Don't re-read the same glsl files over and over again

Change-Id: I10b4badaba01630e1a054b3d4d9cc4720822511a

diff --git a/vcl/source/opengl/OpenGLHelper.cxx 
b/vcl/source/opengl/OpenGLHelper.cxx
index 92bfe7d..5290f8c2 100644
--- a/vcl/source/opengl/OpenGLHelper.cxx
+++ b/vcl/source/opengl/OpenGLHelper.cxx
@@ -11,6 +11,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -66,6 +67,7 @@ OString loadShader(const OUString& rFilename)
 {
 OUString aFileURL = getShaderFolder() + rFilename +".glsl";
 osl::File aFile(aFileURL);
+SAL_INFO("vcl.opengl", "Reading " << aFileURL);
 if(aFile.open(osl_File_OpenFlag_Read) == osl::FileBase::E_None)
 {
 sal_uInt64 nSize = 0;
@@ -85,6 +87,20 @@ OString loadShader(const OUString& rFilename)
 return OString();
 }
 
+OString& getShaderSource(const OUString& rFilename)
+{
+static std::unordered_map aMap;
+static osl::Mutex aMutex;
+osl::MutexGuard aGuard(aMutex);
+
+if (aMap.find(rFilename) == aMap.end())
+{
+aMap[rFilename] = loadShader(rFilename);
+}
+
+return aMap[rFilename];
+}
+
 }
 
 namespace {
@@ -189,8 +205,8 @@ namespace
  const OString& rPreamble )
 {
 // read shaders source
-OString aVertexShaderSource = loadShader( rVertexShaderName );
-OString aFragmentShaderSource = loadShader( rFragmentShaderName );
+OString aVertexShaderSource = getShaderSource( rVertexShaderName );
+OString aFragmentShaderSource = getShaderSource( rFragmentShaderName );
 
 // get info about the graphic device
 #if defined( SAL_UNX ) && !defined( MACOSX ) && !defined( IOS )&& !defined( 
ANDROID )
@@ -374,8 +390,8 @@ GLint OpenGLHelper::LoadShaders(const OUString& 
rVertexShaderName,
 GLint ProgramID = glCreateProgram();
 
 // read shaders from file
-OString aVertexShaderSource = loadShader(rVertexShaderName);
-OString aFragmentShaderSource = loadShader(rFragmentShaderName);
+OString aVertexShaderSource = getShaderSource(rVertexShaderName);
+OString aFragmentShaderSource = getShaderSource(rFragmentShaderName);
 
 GLint bBinaryResult = GL_FALSE;
 if( GLEW_ARB_get_program_binary && !rDigest.isEmpty() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits