[Libreoffice-commits] core.git: cui/source cui/uiconfig dbaccess/source framework/source icon-themes/tango include/svtools officecfg/registry reportdesign/source sc/source sc/uiconfig sd/source sd/uic

[Maxim Monastirsky]

 cui/source/options/optgdlg.cxx |   11 
 cui/source/options/optgdlg.hxx |1 
 cui/uiconfig/ui/optgeneralpage.ui  |   70 -
 dbaccess/source/core/dataaccess/intercept.cxx  |   54 
 dbaccess/source/core/dataaccess/intercept.hxx  |8 
 dbaccess/source/ui/app/AppController.cxx   |3 
 dbaccess/source/ui/app/AppController.hxx   |2 
 dbaccess/source/ui/querydesign/querycontroller.cxx |2 
 dbaccess/source/ui/tabledesign/TableController.cxx |   10 
 framework/source/uielement/popuptoolbarcontroller.cxx  |  159 -
 icon-themes/tango/links.txt|4 
 include/svtools/miscopt.hxx|3 
 officecfg/registry/data/org/openoffice/Setup.xcu   |1 
 officecfg/registry/schema/org/openoffice/Office/Common.xcs |7 
 reportdesign/source/ui/report/ReportController.cxx |8 
 sc/source/ui/unoobj/docuno.cxx |4 
 sc/uiconfig/scalc/toolbar/standardbar.xml  |2 
 sd/source/ui/unoidl/unomodel.cxx   |4 
 sd/uiconfig/sdraw/toolbar/standardbar.xml  |2 
 sd/uiconfig/simpress/toolbar/standardbar.xml   |2 
 sfx2/sdi/sfx.sdi   |2 
 sfx2/source/doc/guisaveas.cxx  |   17 -
 sfx2/source/doc/objserv.cxx|7 
 sfx2/source/view/viewfrm.cxx   |1 
 svtools/source/config/miscopt.cxx  |   42 ---
 sw/source/uibase/uno/unotxdoc.cxx  |4 
 sw/uiconfig/sglobal/toolbar/standardbar.xml|2 
 sw/uiconfig/sweb/toolbar/standardbar.xml   |2 
 sw/uiconfig/swform/toolbar/standardbar.xml |2 
 sw/uiconfig/swreport/toolbar/standardbar.xml   |2 
 sw/uiconfig/swriter/toolbar/standardbar.xml|2 
 sw/uiconfig/swxform/toolbar/standardbar.xml|2 
 32 files changed, 188 insertions(+), 254 deletions(-)

New commits:
commit 22328a224df4619218b88205838307f70612207e
Author: Maxim Monastirsky 
Date:   Tue Dec 22 13:12:23 2015 +0200

New saving behavior

Changes in this commit:

- AlwaysAllowSave config is gone. Saving is always permitted, unless in
  a read only document. Also changed the behavior in dbaccess to match
  sfx2.

- The toolbar save button is always enabled, to always give access to
  the dropdown. That's the case even in a read only document, except
  that it changes to DROPDOWNONLY, and the save as command icon+tooltip.
  In table/query designers we still disable the button in read only state.

- When the document is modified, the toolbar button gets a special icon
  to indicate that.

TODO:

- Icons for the document modified state are still missing. I added some
  fake links to Tango's links.txt in order to test the new behavior.
  These links shouldn't stay as-is in a production version!

Change-Id: I56c169bf48b78faaf53c2989ce8624f8297ffb6e
Reviewed-on: https://gerrit.libreoffice.org/20839
Reviewed-by: Maxim Monastirsky 
Tested-by: Maxim Monastirsky 

diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx
index dfb517f..52fc00c 100644
--- a/cui/source/options/optgdlg.cxx
+++ b/cui/source/options/optgdlg.cxx
@@ -273,7 +273,6 @@ OfaMiscTabPage::OfaMiscTabPage(vcl::Window* pParent, const 
SfxItemSet& rSet)
 get(m_pFileDlgROImage, "lockimage");
 get(m_pPrintDlgCB, "printdlg");
 get(m_pDocStatusCB, "docstatus");
-get(m_pSaveAlwaysCB, "savealways");
 get(m_pYearFrame, "yearframe");
 get(m_pYearValueField, "year");
 get(m_pToYearFT, "toyear");
@@ -309,7 +308,6 @@ void OfaMiscTabPage::dispose()
 m_pFileDlgCB.clear();
 m_pPrintDlgCB.clear();
 m_pDocStatusCB.clear();
-m_pSaveAlwaysCB.clear();
 m_pYearFrame.clear();
 m_pYearValueField.clear();
 m_pToYearFT.clear();
@@ -352,13 +350,6 @@ bool OfaMiscTabPage::FillItemSet( SfxItemSet* rSet )
 bModified = true;
 }
 
-if ( m_pSaveAlwaysCB->IsValueChangedFromSaved() )
-{
-SvtMiscOptions aMiscOpt;
-aMiscOpt.SetSaveAlwaysAllowed( m_pSaveAlwaysCB->IsChecked() );
-bModified = true;
-}
-
 const SfxUInt16Item* pUInt16Item = dynamic_cast< const SfxUInt16Item* >( 
GetOldItem( *rSet, SID_ATTR_YEAR2000 ) );
 sal_uInt16 nNum = (sal_uInt16)m_pYearValueField->GetText().toInt32();
 if ( pUInt16Item && pUInt16Item->GetValue() != nNum )
@@ -389,8 +380,6 @@ void OfaMiscTabPage::Reset( const SfxItemSet* rSet )
 m_pFileDlgCB->SaveValue();
 

[Libreoffice-commits] core.git: tubes/source

[David Tardon]

 tubes/source/contacts.cxx |   23 +--
 1 file changed, 17 insertions(+), 6 deletions(-)

New commits:
commit 18565a34d6e2768d70462f124c6d6972448efe22
Author: David Tardon 
Date:   Wed Dec 23 10:35:00 2015 +0100

convert tubes to VclPtr

Change-Id: I54fb058ad1ad89183acfd4d2661c10ccffc408d6

diff --git a/tubes/source/contacts.cxx b/tubes/source/contacts.cxx
index 6f8ae2c..d7ec246 100644
--- a/tubes/source/contacts.cxx
+++ b/tubes/source/contacts.cxx
@@ -23,12 +23,12 @@ namespace {
 
 class TubeContacts : public ModelessDialog
 {
-PushButton* mpBtnDemo;
-PushButton* mpBtnBuddy;
-PushButton* mpBtnGroup;
-PushButton* mpBtnInvite;
-PushButton* mpBtnListen;
-ListBox*mpList;
+VclPtr mpBtnDemo;
+VclPtr mpBtnBuddy;
+VclPtr mpBtnGroup;
+VclPtr mpBtnInvite;
+VclPtr mpBtnListen;
+VclPtrmpList;
 Collaboration*  mpCollaboration;
 
 DECL_LINK_TYPED( BtnDemoHdl, Button*, void );
@@ -124,6 +124,17 @@ public:
 }
 virtual ~TubeContacts()
 {
+dispose();
+}
+
+virtual void dispose() override
+{
+mpBtnListen.clear();
+mpBtnGroup.clear();
+mpBtnDemo.clear();
+mpBtnBuddy.clear();
+mpBtnGroup.clear();
+mpList.clear();
 }
 
 static OUString fromUTF8( const char *pStr )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/mailmerge-toolbar' - 241 commits - accessibility/inc accessibility/Library_acc.mk accessibility/source avmedia/source basic/source bin/distro-install-fi

[Jan Holesovsky]

Rebased ref, commits from common ancestor:
commit bb6cde1a70efaa595fec383e0c26def663736ff4
Author: Jan Holesovsky 
Date:   Wed Dec 23 10:43:39 2015 +0100

mailmerge: Icon for the Mail Merge Wizard too.

Change-Id: Iae5f6d12a2593249a693ceae894fc864887d0ae9

diff --git a/icon-themes/breeze/links.txt b/icon-themes/breeze/links.txt
index 05d232d..9fcfbf3 100644
--- a/icon-themes/breeze/links.txt
+++ b/icon-themes/breeze/links.txt
@@ -463,6 +463,8 @@ cmd/sc_xlinestyle.png cmd/sc_linestyle.png
 cmd/sc_hfixedline.png cmd/sc_line.png
 
 # Mail merge
+cmd/lc_mailmergewizard.png cmd/lc_dsbformletter.png
+cmd/sc_mailmergewizard.png cmd/sc_dsbformletter.png
 cmd/lc_mailmergefirstentry.png cmd/lc_firstrecord.png
 cmd/sc_mailmergefirstentry.png cmd/sc_firstrecord.png
 cmd/lc_mailmergelastentry.png cmd/lc_lastrecord.png
diff --git a/icon-themes/crystal/links.txt b/icon-themes/crystal/links.txt
index 4bce143..6642c92 100644
--- a/icon-themes/crystal/links.txt
+++ b/icon-themes/crystal/links.txt
@@ -10,6 +10,8 @@ cmd/sc_charbackcolor.png cmd/sc_backcolor.png
 cmd/lc_charbackcolor.png cmd/lc_backcolor.png
 
 # Mail merge
+cmd/lc_mailmergewizard.png cmd/lc_dsbformletter.png
+cmd/sc_mailmergewizard.png cmd/sc_dsbformletter.png
 cmd/lc_mailmergefirstentry.png cmd/lc_firstrecord.png
 cmd/sc_mailmergefirstentry.png cmd/sc_firstrecord.png
 cmd/lc_mailmergelastentry.png cmd/lc_lastrecord.png
diff --git a/icon-themes/elementary/links.txt b/icon-themes/elementary/links.txt
index 0db296f..c337c31 100644
--- a/icon-themes/elementary/links.txt
+++ b/icon-themes/elementary/links.txt
@@ -624,6 +624,8 @@ vcl/source/src/msgbox.png vcl/res/msgbox.png
 xmlsecurity/res/signet_11x16.png svx/res/signet_11x16.png
 
 # Mail merge
+cmd/lc_mailmergewizard.png cmd/lc_dsbformletter.png
+cmd/sc_mailmergewizard.png cmd/sc_dsbformletter.png
 cmd/lc_mailmergefirstentry.png cmd/lc_firstrecord.png
 cmd/sc_mailmergefirstentry.png cmd/sc_firstrecord.png
 cmd/lc_mailmergelastentry.png cmd/lc_lastrecord.png
diff --git a/icon-themes/galaxy/links.txt b/icon-themes/galaxy/links.txt
index 687dac5..d068ec2 100644
--- a/icon-themes/galaxy/links.txt
+++ b/icon-themes/galaxy/links.txt
@@ -88,6 +88,8 @@ cmd/sc_showgraphics.png cmd/sc_graphic.png
 svtools/res/folderop.png formula/res/fapopen.png
 
 # Mail merge
+cmd/lc_mailmergewizard.png cmd/lc_dsbformletter.png
+cmd/sc_mailmergewizard.png cmd/sc_dsbformletter.png
 cmd/lc_mailmergefirstentry.png cmd/lc_firstrecord.png
 cmd/sc_mailmergefirstentry.png cmd/sc_firstrecord.png
 cmd/lc_mailmergelastentry.png cmd/lc_lastrecord.png
diff --git a/icon-themes/hicontrast/links.txt b/icon-themes/hicontrast/links.txt
index 3ed8eb0..8147de1 100644
--- a/icon-themes/hicontrast/links.txt
+++ b/icon-themes/hicontrast/links.txt
@@ -11,6 +11,8 @@ svtools/res/folder.png formula/res/fapclose.png
 svtools/res/folderop.png formula/res/fapopen.png
 
 # Mail merge
+cmd/lc_mailmergewizard.png cmd/lc_dsbformletter.png
+cmd/sc_mailmergewizard.png cmd/sc_dsbformletter.png
 cmd/lc_mailmergefirstentry.png cmd/lc_firstrecord.png
 cmd/sc_mailmergefirstentry.png cmd/sc_firstrecord.png
 cmd/lc_mailmergelastentry.png cmd/lc_lastrecord.png
diff --git a/icon-themes/human/links.txt b/icon-themes/human/links.txt
index d3155a6..4f782ab 100644
--- a/icon-themes/human/links.txt
+++ b/icon-themes/human/links.txt
@@ -13,6 +13,8 @@ cmd/lc_charbackcolor.png cmd/lc_backcolor.png
 svtools/res/folderop.png formula/res/fapopen.png
 
 # Mail merge
+cmd/lc_mailmergewizard.png cmd/lc_dsbformletter.png
+cmd/sc_mailmergewizard.png cmd/sc_dsbformletter.png
 cmd/lc_mailmergefirstentry.png cmd/lc_firstrecord.png
 cmd/sc_mailmergefirstentry.png cmd/sc_firstrecord.png
 cmd/lc_mailmergelastentry.png cmd/lc_lastrecord.png
diff --git a/icon-themes/oxygen/links.txt b/icon-themes/oxygen/links.txt
index 4bce143..6642c92 100644
--- a/icon-themes/oxygen/links.txt
+++ b/icon-themes/oxygen/links.txt
@@ -10,6 +10,8 @@ cmd/sc_charbackcolor.png cmd/sc_backcolor.png
 cmd/lc_charbackcolor.png cmd/lc_backcolor.png
 
 # Mail merge
+cmd/lc_mailmergewizard.png cmd/lc_dsbformletter.png
+cmd/sc_mailmergewizard.png cmd/sc_dsbformletter.png
 cmd/lc_mailmergefirstentry.png cmd/lc_firstrecord.png
 cmd/sc_mailmergefirstentry.png cmd/sc_firstrecord.png
 cmd/lc_mailmergelastentry.png cmd/lc_lastrecord.png
diff --git a/icon-themes/sifr/links.txt b/icon-themes/sifr/links.txt
index 61a545a..55d5d7c 100644
--- a/icon-themes/sifr/links.txt
+++ b/icon-themes/sifr/links.txt
@@ -155,6 +155,8 @@ cmd/lc_insertcolumnsafter.png cmd/lc_insertcolumns.png
 cmd/sc_insertcolumnsafter.png cmd/sc_insertcolumns.png
 
 # Mail merge
+cmd/lc_mailmergewizard.png cmd/lc_dsbformletter.png
+cmd/sc_mailmergewizard.png cmd/sc_dsbformletter.png
 cmd/lc_mailmergefirstentry.png cmd/lc_firstrecord.png
 cmd/sc_mailmergefirstentry.png cmd/sc_firstrecord.png
 cmd/lc_mailmergelastentry.png cmd/lc_lastrecord.png
diff --git a/icon-themes/tango/links.txt b/icon-themes/tango/links.txt
index afb2f94..abf6d53 100644

[Libreoffice-bugs] [Bug 96683] New: Move tabs in Basic Editor to an own row

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96683

Bug ID: 96683
   Summary: Move tabs in Basic Editor to an own row
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: samuel.mehrbr...@cib.de

Currently the tabs in the Basic Macro Editor shared a row with the Scrollbar.
This leads to small tabs when the theme defines a small scrollbar.

Each should have an own row (as done in Calc and Draw before)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96683] Move tabs in Basic Editor to an own row

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96683

Samuel Mehrbrodt  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||samuel.mehrbr...@cib.de
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Formatting _Numbering/ordered list_[Bug 42788]

[noseeba Al kindi]

I am solving this bug:

https://bugs.documentfoundation.org/show_bug.cgi?id=42788

I checked the MS office and it have the same problem appear there just
that they have a longer indentation which let the issue start at
number 18. Moreover, they make the numbering alignment to the right by
default.

so I think the best behavior is to change the default setting to be:
numbering alignment to the right and increase the indentation.

On Tue, Dec 22, 2015 at 12:03 PM, noseeba Al kindi  wrote:
> Dear,
>
> I am new on solving bugs and this is the first bug I choose. I go
> through the documentation of this issue and I found that it could be
> solved by changing numbering alignment to the right. Another solution
> is that when the length of the Roman number is longer than the
> indentation, the whole list should be shift to right which give enough
> space to contains the longest Roman number appear in the list.
>
> I am not sure what is the right behavior here.
> I am waiting for your reply.
> Thank you
>
> Nusaiba Al-kindi
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 50550] malfunction of Impress using "drag and drop" between two presentations

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=50550

Rafael  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #9 from Rafael  ---
I tested the Bug with Impress Version 5.0.4.2 on W7-64 and it didn't crushed,
even with bigger files with a lot of images.
Thank you very much!!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: wizards/source

[Jean-Pierre Ledure]

 wizards/source/access2base/Field.xba |   14 --
 1 file changed, 8 insertions(+), 6 deletions(-)

New commits:
commit e030f2a3133777df1cdc589f8533f7a52d63d345
Author: Jean-Pierre Ledure 
Date:   Wed Dec 23 12:28:48 2015 +0100

Access2Base - Support of Hsqldb 2.3

Addition of CLOB and BLOB datatypes

Change-Id: If42c0dbb1862f525d2a0a1abf98bd053543a3d3c

diff --git a/wizards/source/access2base/Field.xba 
b/wizards/source/access2base/Field.xba
index 7daa9a9..791e3ca 100644
--- a/wizards/source/access2base/Field.xba
+++ b/wizards/source/access2base/Field.xba
@@ -305,12 +305,14 @@ Const cstMaxTextLength = 65535
Case .CHAR  
:   _PropertyGet = dbText
Case .VARCHAR   :   
_PropertyGet = dbChar
Case .LONGVARCHAR   :   
_PropertyGet = dbMemo
+   Case .CLOB  
:   _PropertyGet = dbMemo
Case .DATE  
:   _PropertyGet = dbDate
Case .TIME  
:   _PropertyGet = dbTime
Case .TIMESTAMP :   
_PropertyGet = dbTimeStamp
Case .BINARY:   
_PropertyGet = dbBinary
Case .VARBINARY :   
_PropertyGet = dbVarBinary
Case .LONGVARBINARY :   
_PropertyGet = dbLongBinary
+   Case .BLOB  
:   _PropertyGet = dbLongBinary
Case .BOOLEAN   :   
_PropertyGet = dbBoolean
Case Else   
:   _PropertyGet = dbUndefined
End Select
@@ -352,9 +354,9 @@ Const cstMaxTextLength = 65535
Case UCase(FieldSize)   
  Probably physical size = 2 * unicode string length
With com.sun.star.sdbc.DataType
Select Case Column.Type
-   Case .LONGVARCHAR
+   Case .VARCHAR, .LONGVARCHAR, .CLOB
Set oSize = 
Column.getCharacterStream
-   Case .LONGVARBINARY, .VARBINARY, .BINARY
+   Case .LONGVARBINARY, .VARBINARY, 
.BINARY, .BLOB
Set oSize = 
Column.getBinaryStream
Case Else
Set oSize = Nothing
@@ -660,14 +662,14 @@ Const cstMaxLength = 64000
 
With com.sun.star.sdbc.DataType
Select Case Column.Type
-   Case .BINARY, .VARBINARY, .LONGVARBINARY
+   Case .BINARY, .VARBINARY, .LONGVARBINARY, .BLOB
If psMethod  ReadAllBytes 
Then Goto Trace_Error
Set oStream = 
oSimpleFileAccess.openFileRead(sFile)
lFileLength = oStream.getLength()
If lFileLength = 0 Then Goto Trace_File
Column.updateBinaryStream(oStream, lFileLength)
oStream.closeInput()
-   Case .LONGVARCHAR
+   Case .VARCHAR, .LONGVARCHAR, .CLOB
If psMethod  ReadAllText 
Then Goto Trace_Error
sMemo = 
lFileLength = 0
@@ -728,10 +730,10 @@ Dim sFile As String, oSimpleFileAccess As Object, sMethod 
As String, oStream As
oSimpleFileAccess = 
CreateUnoService(com.sun.star.ucb.SimpleFileAccess)
With com.sun.star.sdbc.DataType
Select Case Column.Type
-   Case .BINARY, .VARBINARY, .LONGVARBINARY
+   Case .BINARY, .VARBINARY, .LONGVARBINARY, .BLOB
If psMethod  WriteAllBytes 
Then Goto Trace_Error
Set oStream = Column.getBinaryStream()
-   Case .LONGVARCHAR
+   Case .VARCHAR, .LONGVARCHAR, .CLOB
If psMethod  WriteAllText 
Then Goto Trace_Error
Set oStream = Column.getCharacterStream()
Case Else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] core.git: vcl/inc

[Chris Sherlock]

 vcl/inc/PhysicalFontCollection.hxx |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit d169bd53d46de8a21e40468b60d3868452baf7c6
Author: Chris Sherlock 
Date:   Wed Dec 23 11:02:31 2015 +1100

vcl: make PhysicalFontFamily::FindDefaultFont() private

Change-Id: I603a1556051ea15b45e80ed7d6fcf9dbb7b13998
Reviewed-on: https://gerrit.libreoffice.org/20866
Reviewed-by: Chris Sherlock 
Tested-by: Chris Sherlock 

diff --git a/vcl/inc/PhysicalFontCollection.hxx 
b/vcl/inc/PhysicalFontCollection.hxx
index 2e4825f..57a3e21 100644
--- a/vcl/inc/PhysicalFontCollection.hxx
+++ b/vcl/inc/PhysicalFontCollection.hxx
@@ -65,9 +65,6 @@ public:
 PhysicalFontFamily* FindByTokenNames(const OUString& rTokenStr) const;
 PhysicalFontFamily* FindByAttributes(ImplFontAttrs nSearchType, 
FontWeight, FontWidth,
  FontItalic, const OUString& 
rSearchFamily) const;
-protected:
-PhysicalFontFamily* FindDefaultFont() const;
-
 private:
 friend class WinGlyphFallbackSubstititution;
 mutable boolmbMatchData;// true if matching attributes are 
initialized
@@ -88,6 +85,8 @@ private:
 const OUString& rShortName) 
const;
 PhysicalFontFamily* ImplFindBySubstFontAttr( const utl::FontNameAttr& 
) const;
 
+PhysicalFontFamily* FindDefaultFont() const;
+
 voidInitMatchData() const;
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96580] "Edit with External Tool" damages svg image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96580

raal  changed:

   What|Removed |Added

   Keywords||bibisected, bisected
 CC||caol...@redhat.com,
   ||r...@post.cz

--- Comment #2 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Caolán McNamara; Could you possibly take a look at this one?
Thanks

76d78065370b5f15be8653a6fa83ee2527858196 is the first bad commit
commit 76d78065370b5f15be8653a6fa83ee2527858196
Author: Norbert Thiebaud 
Date:   Thu Oct 1 20:08:22 2015 -0700

source sha:78c83032b266fbb6fc20ddca86df80affaff7c24

source sha:78c83032b266fbb6fc20ddca86df80affaff7c24

:04 04 a4354ac95f7e0519963c64377589fe80c5374280
d171ce3da84dfd1c4fcc53b824eeb0a69009f627 M  instdir

authorCaolán McNamara 2015-09-30 08:40:16 (GMT)
committerCaolán McNamara 2015-09-30 12:35:43 (GMT)
commit78c83032b266fbb6fc20ddca86df80affaff7c24 (patch)
maSvgDataArray only populates a uno::Sequence, so use that instead

/bibisect-win32-5.1
$ git bisect log
# bad: [a2ca6bb70db1ba8f306a617d92070351d9a3a624] source
sha:8b5182155b6d35a1be64d37136584e30ea6a6ef8
# good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source
sha:ab465b90f6c6da5595393a0ba73f33a1e71a2b65
git bisect start 'a2ca6bb70db1ba8f306a617d92070351d9a3a624'
'c1efd324c6ad448ac9edb030dc9738b9e6899e4d'
# good: [1e602523875e23a7969d8c28276c82311eb2fa74] source
sha:5b8e4f3d676eb0a026ce1eb4c1df2ec6e0736cb1
git bisect good 1e602523875e23a7969d8c28276c82311eb2fa74
# good: [1e602523875e23a7969d8c28276c82311eb2fa74] source
sha:5b8e4f3d676eb0a026ce1eb4c1df2ec6e0736cb1
git bisect good 1e602523875e23a7969d8c28276c82311eb2fa74
# bad: [e488633c49c1a6da848fc37cdc85da06b487baf6] source
sha:d30f5bc3e65463f28c3087acad6f88e12d60e53b
git bisect bad e488633c49c1a6da848fc37cdc85da06b487baf6
# good: [4f8d5011e8ea2fa616c2dc85957769bc79e437d9] source
sha:00a6992b97a806b183e368d412508801dc632f8b
git bisect good 4f8d5011e8ea2fa616c2dc85957769bc79e437d9
# bad: [43c3f17d3bc1a6202342b46ce46a388f38bd368b] source
sha:b94eccd1d1bb7e1a849e6a024acf84b7a7c12ed3
git bisect bad 43c3f17d3bc1a6202342b46ce46a388f38bd368b
# bad: [22cae5c14840b0c8428de2cb0a4cd6c52be1726a] source
sha:85f93697defd9a812a0cda0bc4e9364e28c0339e
git bisect bad 22cae5c14840b0c8428de2cb0a4cd6c52be1726a
# good: [2589978ff6a620a7c1c0a6e6b25ee2e82f9839bf] source
sha:36739d33d3dfee4bc95b546bc297015f7cb6ca00
git bisect good 2589978ff6a620a7c1c0a6e6b25ee2e82f9839bf
# good: [9a33df39bcb8988b505374b59d3645c05c46672a] source
sha:d6e82846ce8bdd21db4a4aa783555950f0a8e442
git bisect good 9a33df39bcb8988b505374b59d3645c05c46672a
# good: [18eef8001eab24435be5380d98beb69a961d6f96] source
sha:652158c3f2c9cd0d6f71ecd14bf5d5cc02a71b50
git bisect good 18eef8001eab24435be5380d98beb69a961d6f96
# bad: [2b0ffb113b17fdfe966ce726d58a8593d1466785] source
sha:8217c99f6ef29207965ffd43aff64b24b399934d
git bisect bad 2b0ffb113b17fdfe966ce726d58a8593d1466785
# bad: [2b34baf12b92a1a3f4d00e360883c72ad0ad8dfd] source
sha:ae13a6819e1dea6646aa0eba435ca9c81101f52c
git bisect bad 2b34baf12b92a1a3f4d00e360883c72ad0ad8dfd
# bad: [d60dd88b6a861f7a9cc7f0e69df21261ed915854] source
sha:66343a8aeb4328a61766e4df41515130290e8a93
git bisect bad d60dd88b6a861f7a9cc7f0e69df21261ed915854
# good: [9e1e78fdc2c9402a77aacecc98693e7bc78d2013] source
sha:00d2eeebc8b1842c4ab7a544552f259208ee0e25
git bisect good 9e1e78fdc2c9402a77aacecc98693e7bc78d2013
# bad: [76d78065370b5f15be8653a6fa83ee2527858196] source
sha:78c83032b266fbb6fc20ddca86df80affaff7c24
git bisect bad 76d78065370b5f15be8653a6fa83ee2527858196
# first bad commit: [76d78065370b5f15be8653a6fa83ee2527858196] source
sha:78c83032b266fbb6fc20ddca86df80affaff7c24

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc

[Chris Sherlock]

 vcl/inc/PhysicalFontCollection.hxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 5bf9b846ab74f3b84f8737dce7f2f47ec2b54c1a
Author: Chris Sherlock 
Date:   Wed Dec 23 11:02:40 2015 +1100

vcl: rearrange PhysicalFontCollection function listing order

Change-Id: If9492493f0fcbe8a282820d37bccf54af7cc60ec
Reviewed-on: https://gerrit.libreoffice.org/20879
Reviewed-by: Chris Sherlock 
Tested-by: Chris Sherlock 

diff --git a/vcl/inc/PhysicalFontCollection.hxx 
b/vcl/inc/PhysicalFontCollection.hxx
index 57a3e21..0d26a09 100644
--- a/vcl/inc/PhysicalFontCollection.hxx
+++ b/vcl/inc/PhysicalFontCollection.hxx
@@ -76,10 +76,11 @@ private:
 ImplPreMatchFontSubstitution* mpPreMatchHook;   // device specific 
prematch substitution
 ImplGlyphFallbackFontSubstitution* mpFallbackHook;  // device specific 
glyph fallback substitution
 
-voidInitGenericGlyphFallback() const;
 mutable PhysicalFontFamily**  mpFallbackList;
 mutable int mnFallbackCount;
 
+voidInitGenericGlyphFallback() const;
+
 PhysicalFontFamily* ImplFindBySearchName( const OUString& ) const;
 PhysicalFontFamily* ImplFindByAliasName(const OUString& rSearchName,
 const OUString& rShortName) 
const;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc

[Chris Sherlock]

 vcl/inc/PhysicalFontCollection.hxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 566652d975c67e7c4122ecdd902f6f6d59b1
Author: Chris Sherlock 
Date:   Wed Dec 23 10:40:00 2015 +1100

vcl: No need for WinGlyphFallbackSubstititution to be friend class

Change-Id: Ibe742afdbdf2601e33621d81ad2759aa483d368e
Reviewed-on: https://gerrit.libreoffice.org/20880
Reviewed-by: Chris Sherlock 
Tested-by: Chris Sherlock 

diff --git a/vcl/inc/PhysicalFontCollection.hxx 
b/vcl/inc/PhysicalFontCollection.hxx
index 0d26a09..b78c1ab 100644
--- a/vcl/inc/PhysicalFontCollection.hxx
+++ b/vcl/inc/PhysicalFontCollection.hxx
@@ -66,7 +66,6 @@ public:
 PhysicalFontFamily* FindByAttributes(ImplFontAttrs nSearchType, 
FontWeight, FontWidth,
  FontItalic, const OUString& 
rSearchFamily) const;
 private:
-friend class WinGlyphFallbackSubstititution;
 mutable boolmbMatchData;// true if matching attributes are 
initialized
 boolmbMapNames; // true if MapNames are available
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96666] EDITING: Address Function incorrectly resolves when Sheet names is given to #REF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=9

--- Comment #3 from Trick Hartman  ---
It is not the space that is the issue, nor INDIRECT. 

I see the error with the Sheet Name. When I use any sheet name, I get a #REF.
Without it it works. 

Also, you used Excel R1C1 format, I was saying that when I use Calc A1 format.
Please try to recreate again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78558] FILEOPEN: Excel chart with transparent background imported over blue frame

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78558

Luke  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
Version|Inherited From OOo  |4.1.6.2 release
   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=121334

--- Comment #16 from Luke  ---
This bug is a regression that was never bibisected. 
Version 3.6.7.2 (Build ID: e183d5b) correctly opens attachment 118447

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96688] New: Won't load document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96688

Bug ID: 96688
   Summary: Won't load document
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bridesmu...@yahoo.co.uk

Since inserting an external picture from my charity my document will no longer
load and returns the following error message.

File format error found at 
SAXParseException: "No namespace defined for pic"
SAXParseException: '[word/document.xml line 2]: Namespace prefix pic on bodyPr
is not defined
', Stream 'word/document.xml', Line 2, Column 382856(row,col).

I have just updated to the latest version of LibreOffice available to me but
this has not fixed the error and my document will not load and I cannot access
it at all which is very frustrating as many hours work has gone in it!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78558] FILEOPEN: Excel chart with transparent background imported over blue frame

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78558

--- Comment #17 from Luke  ---
Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89)
correctly imports the test case  attachment 121514. 

The chart is render correctly and the OLE container's Area:Fill setting is
None.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96638] Paragraph remains indent after turning off auto numeration

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96638

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
 Resolution|FIXED   |WORKSFORME

--- Comment #6 from Cor Nouws  ---
thanks for testing and confirming, Reiner.
We set to WorksForMe if there is no commit /code change involved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96690] New: copying non-rendered-to vdev's

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96690

Bug ID: 96690
   Summary: copying non-rendered-to vdev's
   Product: LibreOffice
   Version: 5.0.2.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: michael.me...@collabora.com

It seems that the appended trace:

Spends its time copying un-initialized vdev state - from A to B; which yields:

VCL_GL_INFO( "OpenGLTexture::Binding invalid texture" );

We should avoid that =) fix in progress.

(gdb) bt 20
#0  0x7fffef1f4612 in OpenGLTexture::Bind() (this=0x2979240) at
/data/opt/libreoffice/master/vcl/opengl/texture.cxx:386
#1  0x7fffef1ed0e2 in OpenGLProgram::SetTexture(rtl::OString const&,
OpenGLTexture&) (this=0x1ac9498, rName="sampler", rTexture=...) at
/data/opt/libreoffice/master/vcl/opengl/program.cxx:251
#2  0x7fffef1d51a1 in OpenGLSalGraphicsImpl::DrawTexture(OpenGLTexture&,
SalTwoRect const&, bool) (this=0x29797d0, rTexture=..., pPosAry=...,
bInverted=false) at /data/opt/libreoffice/master/vcl/opengl/gdiimpl.cxx:1042

DrawTexture( rImpl.maOffscreenTex, rPosAry );

#3  0x7fffef1d9856 in OpenGLSalGraphicsImpl::DoCopyBits(SalTwoRect const&,
OpenGLSalGraphicsImpl&) (this=0x29797d0, rPosAry=..., rImpl=...) at
/data/opt/libreoffice/master/vcl/opengl/gdiimpl.cxx:1649
#4  0x7fffdcf3394e in X11OpenGLSalGraphicsImpl::copyBits(SalTwoRect const&,
SalGraphics*) (this=0x29797d0, rPosAry=..., pSrcGraphics=0x2972880) at
/data/opt/libreoffice/master/vcl/opengl/x11/gdiimpl.cxx:65
#5  0x7fffdcf16d0a in X11SalGraphics::copyBits(SalTwoRect const&,
SalGraphics*) (this=0x29796f0, rPosAry=..., pSSrcGraphics=0x2972880) at
/data/opt/libreoffice/master/vcl/unx/generic/gdi/salgdi2.cxx:167
#6  0x7fffdebf7282 in GtkSalGraphics::copyBits(SalTwoRect const&,
SalGraphics*) (this=0x29796f0, rPosAry=..., pSrcGraphics=0x2972880) at
/data/opt/libreoffice/master/vcl/unx/gtk/salnativewidgets-gtk.cxx:642
#7  0x7fffef76274b in SalGraphics::CopyBits(SalTwoRect const&,
SalGraphics*, OutputDevice const*, OutputDevice const*) (this=0x29796f0,
rPosAry=..., pSrcGraphics=0x2972880, pOutDev=0x2978290, pSrcOutDev=0x2978290)
at /data/opt/libreoffice/master/vcl/source/gdi/salgdilayout.cxx:589
#8  0x7fffef7838c3 in VirtualDevice::InnerImplSetOutputSizePixel(Size
const&, bool, boost::shared_array const&) (this=0x2978290,
rNewSize=Size = {...}, bErase=false, pBuffer=...) at
/data/opt/libreoffice/master/vcl/source/gdi/virdev.cxx:360
#9  0x7fffef783ae3 in VirtualDevice::ImplSetOutputSizePixel(Size const&,
bool, boost::shared_array const&) (this=0x2978290, rNewSize=Size
= {...}, bErase=false, pBuffer=...) at
/data/opt/libreoffice/master/vcl/source/gdi/virdev.cxx:399
#10 0x7fffef783e36 in VirtualDevice::SetOutputSizePixel(Size const&, bool)
(this=0x2978290, rNewSize=Size = {...}, bErase=false) at
/data/opt/libreoffice/master/vcl/source/gdi/virdev.cxx:446

** This looks like an abomination:
+ saving and restoring crazy stuff [!?] ... why ? ... +

#11 0x721a85f7 in
sdr::overlay::OverlayManagerBuffered::ImpPrepareBufferDevice() (this=0x2943ee0)
at
/data/opt/libreoffice/master/svx/source/sdr/overlay/overlaymanagerbuffered.cxx:46
#12 0x721a9062 in
sdr::overlay::OverlayManagerBuffered::ImpSaveBackground(vcl::Region const&,
OutputDevice*) (this=0x2943ee0, rRegion=..., pPreRenderDevice=0x295ff30) at
/data/opt/libreoffice/master/svx/source/sdr/overlay/overlaymanagerbuffered.cxx:160
#13 0x721aa0b8 in
sdr::overlay::OverlayManagerBuffered::completeRedraw(vcl::Region const&,
OutputDevice*) const (this=0x2943ee0, rRegion=..., pPreRenderDevice=0x295ff30)
at
/data/opt/libreoffice/master/svx/source/sdr/overlay/overlaymanagerbuffered.cxx:418
#14 0x721ef8f8 in SdrPaintWindow::DrawOverlay(vcl::Region const&)
(this=0x23b4000, rRegion=...) at
/data/opt/libreoffice/master/svx/source/svdraw/sdrpaintwindow.cxx:335
#15 0x72391a9c in SdrPaintView::EndCompleteRedraw(SdrPaintWindow&,
bool) (this=0x23b2700, rPaintWindow=..., bPaintFormLayer=true) at
/data/opt/libreoffice/master/svx/source/svdraw/svdpntv.cxx:763
#16 0x7268e26a in FmFormView::EndCompleteRedraw(SdrPaintWindow&, bool)
(this=0x23b2700, rPaintWindow=..., bPaintFormLayer=true) at
/data/opt/libreoffice/master/svx/source/form/fmview.cxx:477
#17 0x72391c34 in SdrPaintView::EndDrawLayers(SdrPaintWindow&, bool)
(this=0x23b2700, rPaintWindow=..., bPaintFormLayer=true) at
/data/opt/libreoffice/master/svx/source/svdraw/svdpntv.cxx:800
#18 0x7fffa6f14ee8 in SwViewShell::DLPostPaint2(bool) (this=0x22ac790,
bPaintFormLayer=true) at
/data/opt/libreoffice/master/sw/source/core/view/viewsh.cxx:245
#19 0x7fffa6f1be34 in SwViewShell::Paint(OutputDevice&, Rectangle const&)
(this=0x22ac790, rRenderContext=..., rRect=Rectangle = 

[Libreoffice-bugs] [Bug 96689] New: copying non-rendered-to vdev's

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96689

Bug ID: 96689
   Summary: copying non-rendered-to vdev's
   Product: LibreOffice
   Version: 5.0.2.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: michael.me...@collabora.com

It seems that the appended trace:

Spends its time copying un-initialized vdev state - from A to B; which yields:

VCL_GL_INFO( "OpenGLTexture::Binding invalid texture" );

We should avoid that =) fix in progress.

(gdb) bt 20
#0  0x7fffef1f4612 in OpenGLTexture::Bind() (this=0x2979240) at
/data/opt/libreoffice/master/vcl/opengl/texture.cxx:386
#1  0x7fffef1ed0e2 in OpenGLProgram::SetTexture(rtl::OString const&,
OpenGLTexture&) (this=0x1ac9498, rName="sampler", rTexture=...) at
/data/opt/libreoffice/master/vcl/opengl/program.cxx:251
#2  0x7fffef1d51a1 in OpenGLSalGraphicsImpl::DrawTexture(OpenGLTexture&,
SalTwoRect const&, bool) (this=0x29797d0, rTexture=..., pPosAry=...,
bInverted=false) at /data/opt/libreoffice/master/vcl/opengl/gdiimpl.cxx:1042

DrawTexture( rImpl.maOffscreenTex, rPosAry );

#3  0x7fffef1d9856 in OpenGLSalGraphicsImpl::DoCopyBits(SalTwoRect const&,
OpenGLSalGraphicsImpl&) (this=0x29797d0, rPosAry=..., rImpl=...) at
/data/opt/libreoffice/master/vcl/opengl/gdiimpl.cxx:1649
#4  0x7fffdcf3394e in X11OpenGLSalGraphicsImpl::copyBits(SalTwoRect const&,
SalGraphics*) (this=0x29797d0, rPosAry=..., pSrcGraphics=0x2972880) at
/data/opt/libreoffice/master/vcl/opengl/x11/gdiimpl.cxx:65
#5  0x7fffdcf16d0a in X11SalGraphics::copyBits(SalTwoRect const&,
SalGraphics*) (this=0x29796f0, rPosAry=..., pSSrcGraphics=0x2972880) at
/data/opt/libreoffice/master/vcl/unx/generic/gdi/salgdi2.cxx:167
#6  0x7fffdebf7282 in GtkSalGraphics::copyBits(SalTwoRect const&,
SalGraphics*) (this=0x29796f0, rPosAry=..., pSrcGraphics=0x2972880) at
/data/opt/libreoffice/master/vcl/unx/gtk/salnativewidgets-gtk.cxx:642
#7  0x7fffef76274b in SalGraphics::CopyBits(SalTwoRect const&,
SalGraphics*, OutputDevice const*, OutputDevice const*) (this=0x29796f0,
rPosAry=..., pSrcGraphics=0x2972880, pOutDev=0x2978290, pSrcOutDev=0x2978290)
at /data/opt/libreoffice/master/vcl/source/gdi/salgdilayout.cxx:589
#8  0x7fffef7838c3 in VirtualDevice::InnerImplSetOutputSizePixel(Size
const&, bool, boost::shared_array const&) (this=0x2978290,
rNewSize=Size = {...}, bErase=false, pBuffer=...) at
/data/opt/libreoffice/master/vcl/source/gdi/virdev.cxx:360
#9  0x7fffef783ae3 in VirtualDevice::ImplSetOutputSizePixel(Size const&,
bool, boost::shared_array const&) (this=0x2978290, rNewSize=Size
= {...}, bErase=false, pBuffer=...) at
/data/opt/libreoffice/master/vcl/source/gdi/virdev.cxx:399
#10 0x7fffef783e36 in VirtualDevice::SetOutputSizePixel(Size const&, bool)
(this=0x2978290, rNewSize=Size = {...}, bErase=false) at
/data/opt/libreoffice/master/vcl/source/gdi/virdev.cxx:446

** This looks like an abomination:
+ saving and restoring crazy stuff [!?] ... why ? ... +

#11 0x721a85f7 in
sdr::overlay::OverlayManagerBuffered::ImpPrepareBufferDevice() (this=0x2943ee0)
at
/data/opt/libreoffice/master/svx/source/sdr/overlay/overlaymanagerbuffered.cxx:46
#12 0x721a9062 in
sdr::overlay::OverlayManagerBuffered::ImpSaveBackground(vcl::Region const&,
OutputDevice*) (this=0x2943ee0, rRegion=..., pPreRenderDevice=0x295ff30) at
/data/opt/libreoffice/master/svx/source/sdr/overlay/overlaymanagerbuffered.cxx:160
#13 0x721aa0b8 in
sdr::overlay::OverlayManagerBuffered::completeRedraw(vcl::Region const&,
OutputDevice*) const (this=0x2943ee0, rRegion=..., pPreRenderDevice=0x295ff30)
at
/data/opt/libreoffice/master/svx/source/sdr/overlay/overlaymanagerbuffered.cxx:418
#14 0x721ef8f8 in SdrPaintWindow::DrawOverlay(vcl::Region const&)
(this=0x23b4000, rRegion=...) at
/data/opt/libreoffice/master/svx/source/svdraw/sdrpaintwindow.cxx:335
#15 0x72391a9c in SdrPaintView::EndCompleteRedraw(SdrPaintWindow&,
bool) (this=0x23b2700, rPaintWindow=..., bPaintFormLayer=true) at
/data/opt/libreoffice/master/svx/source/svdraw/svdpntv.cxx:763
#16 0x7268e26a in FmFormView::EndCompleteRedraw(SdrPaintWindow&, bool)
(this=0x23b2700, rPaintWindow=..., bPaintFormLayer=true) at
/data/opt/libreoffice/master/svx/source/form/fmview.cxx:477
#17 0x72391c34 in SdrPaintView::EndDrawLayers(SdrPaintWindow&, bool)
(this=0x23b2700, rPaintWindow=..., bPaintFormLayer=true) at
/data/opt/libreoffice/master/svx/source/svdraw/svdpntv.cxx:800
#18 0x7fffa6f14ee8 in SwViewShell::DLPostPaint2(bool) (this=0x22ac790,
bPaintFormLayer=true) at
/data/opt/libreoffice/master/sw/source/core/view/viewsh.cxx:245
#19 0x7fffa6f1be34 in SwViewShell::Paint(OutputDevice&, Rectangle const&)
(this=0x22ac790, rRenderContext=..., rRect=Rectangle = 

[Libreoffice-bugs] [Bug 96691] New: copying non-rendered-to vdev's

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96691

Bug ID: 96691
   Summary: copying non-rendered-to vdev's
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: michael.me...@collabora.com

It seems that the appended trace:

Spends its time copying un-initialized vdev state - from A to B; which yields:

VCL_GL_INFO( "OpenGLTexture::Binding invalid texture" );

We should avoid that =) fix in progress.

(gdb) bt 20
#0  0x7fffef1f4612 in OpenGLTexture::Bind() (this=0x2979240) at
/data/opt/libreoffice/master/vcl/opengl/texture.cxx:386
#1  0x7fffef1ed0e2 in OpenGLProgram::SetTexture(rtl::OString const&,
OpenGLTexture&) (this=0x1ac9498, rName="sampler", rTexture=...) at
/data/opt/libreoffice/master/vcl/opengl/program.cxx:251
#2  0x7fffef1d51a1 in OpenGLSalGraphicsImpl::DrawTexture(OpenGLTexture&,
SalTwoRect const&, bool) (this=0x29797d0, rTexture=..., pPosAry=...,
bInverted=false) at /data/opt/libreoffice/master/vcl/opengl/gdiimpl.cxx:1042

DrawTexture( rImpl.maOffscreenTex, rPosAry );

#3  0x7fffef1d9856 in OpenGLSalGraphicsImpl::DoCopyBits(SalTwoRect const&,
OpenGLSalGraphicsImpl&) (this=0x29797d0, rPosAry=..., rImpl=...) at
/data/opt/libreoffice/master/vcl/opengl/gdiimpl.cxx:1649
#4  0x7fffdcf3394e in X11OpenGLSalGraphicsImpl::copyBits(SalTwoRect const&,
SalGraphics*) (this=0x29797d0, rPosAry=..., pSrcGraphics=0x2972880) at
/data/opt/libreoffice/master/vcl/opengl/x11/gdiimpl.cxx:65
#5  0x7fffdcf16d0a in X11SalGraphics::copyBits(SalTwoRect const&,
SalGraphics*) (this=0x29796f0, rPosAry=..., pSSrcGraphics=0x2972880) at
/data/opt/libreoffice/master/vcl/unx/generic/gdi/salgdi2.cxx:167
#6  0x7fffdebf7282 in GtkSalGraphics::copyBits(SalTwoRect const&,
SalGraphics*) (this=0x29796f0, rPosAry=..., pSrcGraphics=0x2972880) at
/data/opt/libreoffice/master/vcl/unx/gtk/salnativewidgets-gtk.cxx:642
#7  0x7fffef76274b in SalGraphics::CopyBits(SalTwoRect const&,
SalGraphics*, OutputDevice const*, OutputDevice const*) (this=0x29796f0,
rPosAry=..., pSrcGraphics=0x2972880, pOutDev=0x2978290, pSrcOutDev=0x2978290)
at /data/opt/libreoffice/master/vcl/source/gdi/salgdilayout.cxx:589
#8  0x7fffef7838c3 in VirtualDevice::InnerImplSetOutputSizePixel(Size
const&, bool, boost::shared_array const&) (this=0x2978290,
rNewSize=Size = {...}, bErase=false, pBuffer=...) at
/data/opt/libreoffice/master/vcl/source/gdi/virdev.cxx:360
#9  0x7fffef783ae3 in VirtualDevice::ImplSetOutputSizePixel(Size const&,
bool, boost::shared_array const&) (this=0x2978290, rNewSize=Size
= {...}, bErase=false, pBuffer=...) at
/data/opt/libreoffice/master/vcl/source/gdi/virdev.cxx:399
#10 0x7fffef783e36 in VirtualDevice::SetOutputSizePixel(Size const&, bool)
(this=0x2978290, rNewSize=Size = {...}, bErase=false) at
/data/opt/libreoffice/master/vcl/source/gdi/virdev.cxx:446

** This looks like an abomination:
+ saving and restoring crazy stuff [!?] ... why ? ... +

#11 0x721a85f7 in
sdr::overlay::OverlayManagerBuffered::ImpPrepareBufferDevice() (this=0x2943ee0)
at
/data/opt/libreoffice/master/svx/source/sdr/overlay/overlaymanagerbuffered.cxx:46
#12 0x721a9062 in
sdr::overlay::OverlayManagerBuffered::ImpSaveBackground(vcl::Region const&,
OutputDevice*) (this=0x2943ee0, rRegion=..., pPreRenderDevice=0x295ff30) at
/data/opt/libreoffice/master/svx/source/sdr/overlay/overlaymanagerbuffered.cxx:160
#13 0x721aa0b8 in
sdr::overlay::OverlayManagerBuffered::completeRedraw(vcl::Region const&,
OutputDevice*) const (this=0x2943ee0, rRegion=..., pPreRenderDevice=0x295ff30)
at
/data/opt/libreoffice/master/svx/source/sdr/overlay/overlaymanagerbuffered.cxx:418
#14 0x721ef8f8 in SdrPaintWindow::DrawOverlay(vcl::Region const&)
(this=0x23b4000, rRegion=...) at
/data/opt/libreoffice/master/svx/source/svdraw/sdrpaintwindow.cxx:335
#15 0x72391a9c in SdrPaintView::EndCompleteRedraw(SdrPaintWindow&,
bool) (this=0x23b2700, rPaintWindow=..., bPaintFormLayer=true) at
/data/opt/libreoffice/master/svx/source/svdraw/svdpntv.cxx:763
#16 0x7268e26a in FmFormView::EndCompleteRedraw(SdrPaintWindow&, bool)
(this=0x23b2700, rPaintWindow=..., bPaintFormLayer=true) at
/data/opt/libreoffice/master/svx/source/form/fmview.cxx:477
#17 0x72391c34 in SdrPaintView::EndDrawLayers(SdrPaintWindow&, bool)
(this=0x23b2700, rPaintWindow=..., bPaintFormLayer=true) at
/data/opt/libreoffice/master/svx/source/svdraw/svdpntv.cxx:800
#18 0x7fffa6f14ee8 in SwViewShell::DLPostPaint2(bool) (this=0x22ac790,
bPaintFormLayer=true) at
/data/opt/libreoffice/master/sw/source/core/view/viewsh.cxx:245
#19 0x7fffa6f1be34 in SwViewShell::Paint(OutputDevice&, Rectangle const&)
(this=0x22ac790, rRenderContext=..., rRect=Rectangle = 

[Libreoffice-bugs] [Bug 82214] SVG image causes UI freeze when scrolling and slow export of PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82214

--- Comment #20 from Armin Le Grand  ---
Checked the SVG deeper - it contains polygons filled with patterns. These
patterns are huge. There are five of these, each containing 440 polygons. When
these are used as fill style, they get repeated like a texture, so multiplying
this immensely. What looks like gray is the result of a pattern with 440 small
circles (each defined by a one-point polygon with set stroke-width:7.5). No
wonder that also Inkscape and the browsers get slow, but not as slow as the
office. This shows the potential for better renderers, but also the possibility
to buffer resolution-dependent a single tile of this fill pattern. Checking...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

Terrence Enger  changed:

   What|Removed |Added

 CC||gaurangar...@gmail.com

--- Comment #3 from Terrence Enger  ---
*** Bug 96680 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96680] Inserting a column or row in a table and then undo'ing it crashes LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96680

Terrence Enger  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Terrence Enger  ---
I am marking this as a duplicate of tdf#96067, based on similar
descriptions.

*** This bug has been marked as a duplicate of bug 96067 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96694] New: Cannot scroll back to rows 1-4 in Calc speadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96694

Bug ID: 96694
   Summary: Cannot scroll back to rows 1-4 in Calc speadsheet
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: f.leer...@xs4all.nl

Hello,

I was creating a spreadsheet and at a certain moment I noticed that I could not
scroll back to rows 1-4. Rows 1-5 and column A are frozen in this spreadsheet,
sheet 5 of 5.
I have saved the document, logout as user, shutdown the Calc application and
shutdown my system with a short and also along time(night before logging in
again. No correction of bug after these actions

I have searched google with the summary keywords, without any helpfull result

Regards, Frans

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - svtools/source

[Miklos Vajna]

 svtools/source/contnr/svimpbox.cxx |   14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

New commits:
commit ad70b07e728c726e50a909d06b057072e7a0f1f3
Author: Miklos Vajna 
Date:   Mon Dec 21 14:41:26 2015 +0100

tdf#96637 svtools: fix missing highlight of selected entry in list box

Regression from 87199d3829257420429057336283c55be6ae7481 (vcl:
re-introduce idle handling., 2015-11-24), this probably worked
previously as the idle repaint triggered SvImpLBox::Paint() multiple (at
least two) times, so in the first run it could mark the first entry in
the list box as selected/highlighted, and then the second run it could
paint accordingly.

Now it's called only once, so it's required that selecting the first
entry happens before the actual painting.

With this, the certificate selection dialog has the default signing
certificate pre-selected again.

(cherry picked from commit 171ca32e02976022858b9f0affb532a35c495833)

Change-Id: I0546bf673f44f4270e36b9bbf02bb723f23d6160
Reviewed-on: https://gerrit.libreoffice.org/20850
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/svtools/source/contnr/svimpbox.cxx 
b/svtools/source/contnr/svimpbox.cxx
index 17b8c76..fbe6a32 100644
--- a/svtools/source/contnr/svimpbox.cxx
+++ b/svtools/source/contnr/svimpbox.cxx
@@ -937,6 +937,13 @@ void SvImpLBox::Paint(vcl::RenderContext& rRenderContext, 
const Rectangle& rRect
 
 rRenderContext.SetClipRegion(aClipRegion);
 
+if (!pCursor && ((nExtendedWinBits & EWB_NO_AUTO_CURENTRY) == 0))
+{
+// do not select if multiselection or explicit set
+bool bNotSelect = (aSelEng.GetSelectionMode() == MULTIPLE_SELECTION ) 
|| ((m_nStyle & WB_NOINITIALSELECTION) == WB_NOINITIALSELECTION);
+SetCursor(pStartEntry, bNotSelect);
+}
+
 for(sal_uInt16 n=0; n< nCount && pEntry; n++)
 {
 /*long nMaxRight=*/
@@ -945,13 +952,6 @@ void SvImpLBox::Paint(vcl::RenderContext& rRenderContext, 
const Rectangle& rRect
 pEntry = pView->NextVisible(pEntry);
 }
 
-if (!pCursor && ((nExtendedWinBits & EWB_NO_AUTO_CURENTRY) == 0))
-{
-// do not select if multiselection or explicit set
-bool bNotSelect = (aSelEng.GetSelectionMode() == MULTIPLE_SELECTION ) 
|| ((m_nStyle & WB_NOINITIALSELECTION) == WB_NOINITIALSELECTION);
-SetCursor(pStartEntry, bNotSelect);
-}
-
 nFlags &= (~F_DESEL_ALL);
 rRenderContext.SetClipRegion();
 if (!(nFlags & F_PAINTED))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] libcdr.git: src/lib

[David Tardon]

 src/lib/CDRParser.cpp |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 2c9213f3747093f0f6d91541c17a24269f5f46e9
Author: David Tardon 
Date:   Wed Dec 23 14:10:37 2015 +0100

coverity#1219662 untrusted loop bound

Change-Id: Iff5a8739581c3a996a910e642a5db6eab0976bb6

diff --git a/src/lib/CDRParser.cpp b/src/lib/CDRParser.cpp
index 36fbe01..d90a7c5 100644
--- a/src/lib/CDRParser.cpp
+++ b/src/lib/CDRParser.cpp
@@ -2187,6 +2187,9 @@ void 
libcdr::CDRParser::readPolygonCoords(librevenge::RVNGInputStream *input)
   CDR_DEBUG_MSG(("CDRParser::readPolygonCoords\n"));
 
   unsigned short pointNum = readU16(input);
+  const unsigned short pointSize = 2 * (m_precision == PRECISION_16BIT ? 2 : 
4) + 1;
+  if (pointNum > getRemainingLength(input) / pointSize)
+pointNum = getRemainingLength(input) / pointSize;
   input->seek(2, librevenge::RVNG_SEEK_CUR);
   std::vector > points;
   std::vector pointTypes;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 37678] Export to raster formats (BMP, GIF, JPG, PBM, PNG, and PPM) links Resolution field with dimension fields (Width/Height)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=37678

--- Comment #22 from Gary  ---
LibreOffice v5.0.4.2
OS: Win7sp1

The bug is still present in 5.0.4.2

It is necessary to examine the image attributes in the exported image file to
observe the problem.

In the export image dialog the user can set the image size (width and height)
and the resolution (pixels/inch or cm or meters). (The default resolution is 96
pixels/inch in my installation.)

In the above dialog if I set the resolution to something other than the default
of 96 pix/in, such as 300 pix/in, this new value is not applied to the exported
file. The exported file image resolution remains at 96 pix/in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94066] Doesn't display the right font for Noto Sans/ Source Han Sans Fonts.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94066

--- Comment #5 from laichiah...@outlook.com ---
Created attachment 121519
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121519=edit
But it looks like this, it is the wrong fonts

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sw/qa sw/source

[Miklos Vajna]

 sw/qa/extras/uiwriter/uiwriter.cxx |   21 +
 sw/source/core/layout/calcmove.cxx |   29 -
 2 files changed, 49 insertions(+), 1 deletion(-)

New commits:
commit d4c6c90c3491cf37181b13c1b867ac67bb098f80
Author: Miklos Vajna 
Date:   Wed Dec 16 09:49:18 2015 +0100

tdf#96515 sw Hide Whitespace: avoid creating unneeded page frames

(cherry picked from commit 2c23d4ee1e1370b20560e47db7efaeaac1d94b26)

Change-Id: I9b273543ccf2eaa87116c6e1475860e9e872c445
Reviewed-on: https://gerrit.libreoffice.org/20740
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index c69f330..097b295 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -172,6 +172,7 @@ public:
 void testTdf87922();
 void testTdf77014();
 void testTdf92648();
+void testTdf96515();
 
 CPPUNIT_TEST_SUITE(SwUiWriterTest);
 CPPUNIT_TEST(testReplaceForward);
@@ -252,6 +253,7 @@ public:
 CPPUNIT_TEST(testTdf87922);
 CPPUNIT_TEST(testTdf77014);
 CPPUNIT_TEST(testTdf92648);
+CPPUNIT_TEST(testTdf96515);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -2883,6 +2885,25 @@ void SwUiWriterTest::testTdf92648()
 }
 }
 
+void SwUiWriterTest::testTdf96515()
+{
+// Enable hide whitespace mode.
+SwDoc* pDoc = createDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+SwViewOption aViewOptions(*pWrtShell->GetViewOptions());
+aViewOptions.SetHideWhitespaceMode(true);
+pWrtShell->ApplyViewOptions(aViewOptions);
+
+// Insert a new paragraph at the end of the document.
+uno::Reference xTextDocument(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xParagraphAppend(xTextDocument->getText(), uno::UNO_QUERY);
+xParagraphAppend->finishParagraph(uno::Sequence());
+calcLayout();
+
+// This was 2, a new page was created for the new paragraph.
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest);
 CPPUNIT_PLUGIN_IMPLEMENT();
 
diff --git a/sw/source/core/layout/calcmove.cxx 
b/sw/source/core/layout/calcmove.cxx
index cac6574..9220417 100644
--- a/sw/source/core/layout/calcmove.cxx
+++ b/sw/source/core/layout/calcmove.cxx
@@ -1520,7 +1520,34 @@ void SwContentFrame::MakeAll(vcl::RenderContext* 
/*pRenderContext*/)
 // Bottom(). This might happen with undersized TextFrames on the lower 
edge of a
 // multi-column section
 const long nPrtBottom = (GetUpper()->*fnRect->fnGetPrtBottom)();
-const long nBottomDist =  (Frame().*fnRect->fnBottomDist)( nPrtBottom 
);
+long nBottomDist = (Frame().*fnRect->fnBottomDist)(nPrtBottom);
+
+if 
(getRootFrame()->GetCurrShell()->GetViewOptions()->IsWhitespaceHidden())
+{
+// When whitespace is hidden, the page frame has two heights: the
+// nominal (defined by the frame format), and the actual (which is
+// at most the nominal height, but can be smaller in case there is
+// no content for the whole page).
+// The layout size is the actual one, but we want to move the
+// content frame to a new page only in case it doesn't fit the
+// nominal size.
+if (nBottomDist < 0)
+{
+// Content frame doesn't fit the actual size, check if it fits 
the nominal one.
+SwPageFrame* pPageFrame = FindPageFrame();
+const SwFrameFormat* pPageFormat = static_cast(pPageFrame->GetRegisteredIn());
+const Size& rPageSize = pPageFormat->GetFrameSize().GetSize();
+long nWhitespace = rPageSize.getHeight() - 
pPageFrame->Frame().Height();
+if (nWhitespace > -nBottomDist)
+{
+// It does: don't move it and invalidate our page frame so
+// that it gets a larger height.
+nBottomDist = 0;
+pPageFrame->InvalidateSize();
+}
+}
+}
+
 if( nBottomDist >= 0 )
 {
 if ( bKeep && bMoveable )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96672] Outgoing mail server password in clear text inside the registrymodifications.xcu file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96672

Marina Latini  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Marina Latini  ---
ClearTextPassword

confirmed on:

* Version: 4.4.7.2
* Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
* Locale: it_IT.UTF-8
* OS: openSUSE Tumbleweed (20151124) (x86_64)

and 

* Version: 5.2.0.0.alpha0+
* Build ID: 0b1da98da44bc9acb9e42a5cd1842adf9d82a415
* CPU Threads: 4; OS Version: Linux 4.3; UI Render: default; 
* TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2015-12-22_05:54:37
* Locale: it-IT (it_IT.UTF-8)
* OS: openSUSE Tumbleweed (20151124) (x86_64)

The password is stored in cleartext and the help page:
https://help.libreoffice.org/Common/Server_Authentication 
omits this information.

Suggestions:
a) Add the information to the help page
b) Disallow the password saving
c) implement a master password manager (like kwalletmanager, GNOME Keyring
Manager/Seahorse for GNU/Linux or Keychain Access for OSX or Credential Manager
for Windows).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96593] Duplex printing OK but not for multiple copies!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96593

--- Comment #2 from Timur  ---
Also, is this the same as Bug 96180? Simple search for: Brother duplex.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - extensions/source

[Julien Nabet]

 extensions/source/abpilot/typeselectionpage.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dc66e55c53d55a91fffa7591fec96cb9578e71e3
Author: Julien Nabet 
Date:   Wed Dec 9 22:14:21 2015 +0100

tdf#96368: Address book wizard with no selection returns Evolution

Don't select an option which is not even visible

Change-Id: I003c835d7d623e559d67098de48efdf057a64422
Reviewed-on: https://gerrit.libreoffice.org/20552
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 
(cherry picked from commit 7b69dd64be71d1420158a553fb5ec861039cb017)
Reviewed-on: https://gerrit.libreoffice.org/20558
Tested-by: Julien Nabet 
(cherry picked from commit 6158def661f8281c4fc3493c7e2a1753d3891437)
Reviewed-on: https://gerrit.libreoffice.org/20559
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/extensions/source/abpilot/typeselectionpage.cxx 
b/extensions/source/abpilot/typeselectionpage.cxx
index 90bdf31..cfc9464 100644
--- a/extensions/source/abpilot/typeselectionpage.cxx
+++ b/extensions/source/abpilot/typeselectionpage.cxx
@@ -219,7 +219,7 @@ namespace abp
   loop != m_aAllTypes.end(); ++loop )
 {
 ButtonItem aItem = (*loop);
-if ( aItem.m_pItem->IsChecked() )
+if ( aItem.m_pItem->IsChecked() && aItem.m_bVisible )
 return aItem.m_eType;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96691] copying non-rendered-to vdev's

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96691

Michael Meeks  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Michael Meeks  ---


*** This bug has been marked as a duplicate of bug 96690 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96690] copying non-rendered-to vdev's

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96690

--- Comment #1 from Michael Meeks  ---
*** Bug 96691 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96690] copying non-rendered-to vdev's

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96690

Michael Meeks  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94066] Doesn't display the right font for Noto Sans/ Source Han Sans Fonts.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94066

--- Comment #4 from laichiah...@outlook.com ---
Created attachment 121518
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121518=edit
The way it should look like.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #4 from Gaurang  ---
also, undo insert columns are affected too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92840] RT DOC needs repair in MS Office

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92840

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||688

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96688] Won't load document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96688

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=92
   ||840

--- Comment #1 from Timur  ---
Please attach file, write LO versions you tested. Possible duplicate of Bug
92840.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - lotuswordpro/source

[Caolán McNamara]

 lotuswordpro/source/filter/lwpfribptr.cxx |9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit e616ff7e29ee10d0c3ea2dc6a8fc135b87b572b7
Author: Caolán McNamara 
Date:   Wed Dec 23 15:33:36 2015 +

guard against missing DropcapMgr and Foundry

Change-Id: I1007d4fac2514bc165941c70109cd8e3d57153cd
(cherry picked from commit 330127baf96c417e0eeaef9808d124788b547cf3)

diff --git a/lotuswordpro/source/filter/lwpfribptr.cxx 
b/lotuswordpro/source/filter/lwpfribptr.cxx
index 2d62f23..af7b520 100644
--- a/lotuswordpro/source/filter/lwpfribptr.cxx
+++ b/lotuswordpro/source/filter/lwpfribptr.cxx
@@ -282,10 +282,15 @@ void LwpFribPtr::XFConvert()
 LwpFribFrame* frameFrib= static_cast(pFrib);
 rtl::Reference pLayout = frameFrib->GetLayout();
 if (pLayout.is() && pLayout->GetTag() == VO_DROPCAPLAYOUT)
-m_pPara->GetFoundry()->GetDropcapMgr()->SetXFPara(m_pXFPara);
+{
+LwpFoundry* pFoundry = m_pPara->GetFoundry();
+LwpDropcapMgr* pMgr = pFoundry ? pFoundry->GetDropcapMgr() : 
nullptr;
+if (pMgr)
+pMgr->SetXFPara(m_pXFPara);
+}
 frameFrib->XFConvert(m_pXFPara);
-}
 break;
+}
 case FRIB_TAG_CHBLOCK:
 {
 LwpFribCHBlock* chbFrib = static_cast(pFrib);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - vcl/inc vcl/opengl vcl/source

[Michael Meeks]

 vcl/inc/openglgdiimpl.hxx |2 +-
 vcl/inc/svdata.hxx|1 +
 vcl/opengl/gdiimpl.cxx|   44 +++-
 vcl/source/app/svdata.cxx |   19 ++-
 4 files changed, 39 insertions(+), 27 deletions(-)

New commits:
commit 2a27d83ad8b2cab3af86624f58c183f78c2a67b8
Author: Michael Meeks 
Date:   Thu Dec 10 18:31:04 2015 +

vcl: opengl - lean on the default window's context much more.

Avoid creating our own OpenGLContext to render until we need to
refresh the screen. Also always re-use context from default window.
This simplifies our OpenGL Context use significantly, and avoids
problems with the initial default context getting destroyed in
some cases.

Change-Id: Ic2239236d3e1f14fd27979c9aab85efd84e6b760
Reviewed-on: https://gerrit.libreoffice.org/20853
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/inc/openglgdiimpl.hxx b/vcl/inc/openglgdiimpl.hxx
index 3e5ec94..c4fa5c2 100644
--- a/vcl/inc/openglgdiimpl.hxx
+++ b/vcl/inc/openglgdiimpl.hxx
@@ -158,7 +158,7 @@ public:
 void PostDraw();
 
 protected:
-bool AcquireContext();
+bool AcquireContext(bool bForceCreate = false);
 bool ReleaseContext();
 
 /// retrieve the default context for offscreen rendering
diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index 46527f0..b559cf3 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -357,6 +357,7 @@ struct ImplSVData
 
 voidImplDeInitSVData();
 VCL_PLUGIN_PUBLIC vcl::Window* ImplGetDefaultWindow();
+VCL_PLUGIN_PUBLIC vcl::Window* ImplGetDefaultContextWindow();
 VCL_PLUGIN_PUBLIC ResMgr* ImplGetResMgr();
 VCL_PLUGIN_PUBLIC ResId VclResId( sal_Int32 nId ); // throws std::bad_alloc if 
no res mgr
 DockingManager* ImplGetDockingManager();
diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx
index ba480f2..a5cec8a 100644
--- a/vcl/opengl/gdiimpl.cxx
+++ b/vcl/opengl/gdiimpl.cxx
@@ -92,7 +92,7 @@ OpenGLSalGraphicsImpl::~OpenGLSalGraphicsImpl()
 
 rtl::Reference OpenGLSalGraphicsImpl::GetOpenGLContext()
 {
-if( !AcquireContext() )
+if( !AcquireContext(true) )
 return nullptr;
 return mpContext;
 }
@@ -102,7 +102,7 @@ rtl::Reference 
OpenGLSalGraphicsImpl::GetDefaultContext()
 return ImplGetDefaultWindow()->GetGraphics()->GetOpenGLContext();
 }
 
-bool OpenGLSalGraphicsImpl::AcquireContext( )
+bool OpenGLSalGraphicsImpl::AcquireContext( bool bForceCreate )
 {
 ImplSVData* pSVData = ImplGetSVData();
 
@@ -121,6 +121,8 @@ bool OpenGLSalGraphicsImpl::AcquireContext( )
 mpContext.clear();
 }
 
+// We don't care what context we have - but not switching context
+// is rather useful from a performance perspective.
 OpenGLContext *pContext = pSVData->maGDIData.mpLastContext;
 while( pContext )
 {
@@ -134,7 +136,12 @@ bool OpenGLSalGraphicsImpl::AcquireContext( )
 mpContext = pContext;
 else if( mpWindowContext.is() )
 mpContext = mpWindowContext;
-else
+else if( bForceCreate && !IsOffscreen() )
+{
+mpWindowContext = CreateWinContext();
+mpContext = mpWindowContext;
+}
+if( !mpContext.is() )
 mpContext = GetDefaultContext();
 
 return mpContext.is();
@@ -175,11 +182,10 @@ void OpenGLSalGraphicsImpl::Init()
 VCL_GL_INFO("::Init - re-size offscreen texture");
 }
 
-if( !IsOffscreen() )
+if( mpWindowContext.is() )
 {
-if( mpWindowContext.is() )
-mpWindowContext->reset();
-mpWindowContext = CreateWinContext();
+mpWindowContext->reset();
+mpWindowContext.clear();
 }
 }
 
@@ -192,8 +198,11 @@ void OpenGLSalGraphicsImpl::DeInit()
 // let it know. Other eg. VirtualDevice contexts which have
 // references on and rely on this context continuing to work will
 // get a shiny new context in AcquireContext:: next PreDraw.
-if( mpContext.is() && !IsOffscreen() )
-mpContext->reset();
+if( mpWindowContext.is() )
+{
+mpWindowContext->reset();
+mpWindowContext.clear();
+}
 mpContext.clear();
 }
 
@@ -245,11 +254,6 @@ void OpenGLSalGraphicsImpl::PostDraw()
 
 assert (maOffscreenTex);
 
-if( IsOffscreen() )
-assert( !mpWindowContext.is() );
-else
-assert( mpWindowContext.is() );
-
 // Always queue the flush.
 if( !IsOffscreen() )
 flush();
@@ -2005,15 +2009,13 @@ void OpenGLSalGraphicsImpl::doFlush()
 if( IsOffscreen() )
 return;
 
-assert( mpWindowContext.is() );
-
 if( !maOffscreenTex )
 {
 VCL_GL_INFO( "flushAndSwap - odd no texture !" );
 return;
 }
 
-if (mnDrawCountAtFlush == mnDrawCount)
+if( mnDrawCountAtFlush == mnDrawCount )
 {
 VCL_GL_INFO( "eliding redundant flushAndSwap, no 

[Libreoffice-bugs] [Bug 96692] New: spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96692

Bug ID: 96692
   Summary: spreadsheet
   Product: LibreOffice
   Version: 4.4.7.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jbleak...@cfl.rr.com

Version: 4.4.7.2
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: en_US

uable to change font or font size
unable to format cell, rows and columns

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96636] Text "Removing files" during installation is confusing and sometimes frightening users

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96636

Cor Nouws  changed:

   What|Removed |Added

   Keywords||needsDevEval
 Status|UNCONFIRMED |NEW
  Component|Installation|UI
Version|5.0.3.2 release |unspecified
Summary|Change in Dutch message |Text "Removing files"
   |during installation |during installation is
   ||confusing and sometimes
   ||frightening users
 Ever confirmed|0   |1

--- Comment #1 from Cor Nouws  ---
Thanks JP for filing the issue and the suggestion!

When I look at Pootle, the source for translation, I see this

https://translations.documentfoundation.org/nl/translate/#search=Bestanden%20worden%20verwijderd=source,target,notes=exact
ActionTe.ulf OOO_ACTIONTEXT_73 LngText.text 
Source text "Removing files"

I think your suggestion to change the source to
 -  "Files previous installation are deleted" is OK.
Alternatively
 -  "Removing old/unused files"
or
 -  "Removing files from previous installation"

vr. groeten,
Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76736] ODF import: default-cell-style-name attribute is ignored everywhere when last of table row has no such attribute.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=76736

--- Comment #3 from Dorian  ---
Bug is still present in LibreOffice 5.0.4.2 under MacOS X 10.10.5.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94726] Sluggish performance on high-end computer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94726

--- Comment #19 from Michael Meeks  ---
5.0.4 disables GL by default ;-) so - glad that fixes things for you - but
we'll leave this bug open in order to track the underlying problem.

Then again 5.1 is significantly improved performance-wise too =) thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94631] Chinese font name does not display well in font lists when the Language of UI is not Chinese

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94631

--- Comment #9 from Jerry Shi  ---
Any updates on the bug?

I have the same problem. On two computers with Windows 10 (1511), one can show
Chinese font names and the other does not. The one that can show has Microsoft
office 2013 installed.

The configuration of the computer that has problems are:

OS: Windows 10 Pro (with 1511 udpates)
Libreoffice version: 5.0.3 (updated to the latest)
The system locale is English, 
The encoding for non-unicode program is Chinese simplified.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96693] New: No history information stored

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96693

Bug ID: 96693
   Summary: No history information stored
   Product: LibreOffice
   Version: 4.4.7.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dim_de...@arcor.de

No file history ("zuletzt verewendete Dokumente" - recently used documents(?))
is made available, neither for LibreOffice Launcher nor for Writer, Calc etc.

The button "zuletzt verwendete Dokumente" is available, but pressing it the
message "keine Dokumente" is issued.


Used OS: Windows 10

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94726] Sluggish performance on high-end computer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94726

--- Comment #18 from Kim  ---
Today I installed LibreOffice_5.0.4_Win_x86 and all of the performance issues
seems to be history.

OpenCL is enabled with default settings.

System:
OS: Windows 8.1 Pro (64bit)
GPU: Nvidia GTX 770 (driver: NVIDIA 358.50)
CPU: i7-4770K
RAM: 16GB

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 40534] slide tearing or not shown in LARGE screens (high resolution) with hardware acceleration enabled and dual screen (presenting)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=40534

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
Summary|slide tearing in LARGE  |slide tearing or not shown
   |screens with hardware   |in LARGE screens (high
   |acceleration enabled|resolution) with hardware
   ||acceleration enabled and
   ||dual screen (presenting)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92840] RT DOC needs repair in MS Office

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92840

Timur  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 CC||gti...@gmail.com
Summary|Corrupted file  |RT DOC needs repair in MS
   ||Office

--- Comment #3 from Timur  ---
Since the original reported didn't respond, and in this way it can only be
closed, I'll precise the bug:
1. download
https://europass.cedefop.europa.eu/en/documents/curriculum-vitae/templates-instructions/templates/doc.doc,
 
2. add some text in a few fields
3. save also as DOC

Result: DOC opened in MS Office reports an error.
Tested with LO 4.4.7 and master 5.2+

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: lotuswordpro/source

[Caolán McNamara]

 lotuswordpro/source/filter/lwpfribptr.cxx |9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 330127baf96c417e0eeaef9808d124788b547cf3
Author: Caolán McNamara 
Date:   Wed Dec 23 15:33:36 2015 +

guard against missing DropcapMgr and Foundry

Change-Id: I1007d4fac2514bc165941c70109cd8e3d57153cd

diff --git a/lotuswordpro/source/filter/lwpfribptr.cxx 
b/lotuswordpro/source/filter/lwpfribptr.cxx
index 2d62f23..af7b520 100644
--- a/lotuswordpro/source/filter/lwpfribptr.cxx
+++ b/lotuswordpro/source/filter/lwpfribptr.cxx
@@ -282,10 +282,15 @@ void LwpFribPtr::XFConvert()
 LwpFribFrame* frameFrib= static_cast(pFrib);
 rtl::Reference pLayout = frameFrib->GetLayout();
 if (pLayout.is() && pLayout->GetTag() == VO_DROPCAPLAYOUT)
-m_pPara->GetFoundry()->GetDropcapMgr()->SetXFPara(m_pXFPara);
+{
+LwpFoundry* pFoundry = m_pPara->GetFoundry();
+LwpDropcapMgr* pMgr = pFoundry ? pFoundry->GetDropcapMgr() : 
nullptr;
+if (pMgr)
+pMgr->SetXFPara(m_pXFPara);
+}
 frameFrib->XFConvert(m_pXFPara);
-}
 break;
+}
 case FRIB_TAG_CHBLOCK:
 {
 LwpFribCHBlock* chbFrib = static_cast(pFrib);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96678] Add Hotkeys to Each Font Effect Option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96678

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #1 from Cor Nouws  ---
Sure this is an easy hack.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96679] Add Ability to Assign Keyboard Shortcuts for All Font Effects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96679

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #2 from Cor Nouws  ---
Hi Joel,

I'm a bit biased on this idea.
- People can already use character styles and assign short cuts to those.
- Short cuts for font effect via direct formatting, is ... eh direct
formatting.
But I won't object of course if a nice solution with available short cuts is
found.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 96679] Add Ability to Assign Keyboard Shortcuts for All Font Effects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96679

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #2 from Cor Nouws  ---
Hi Joel,

I'm a bit biased on this idea.
- People can already use character styles and assign short cuts to those.
- Short cuts for font effect via direct formatting, is ... eh direct
formatting.
But I won't object of course if a nice solution with available short cuts is
found.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 82214] SVG image causes UI freeze when scrolling and slow export of PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82214

--- Comment #21 from Armin Le Grand  ---
Checked for the 1st polygon filled with that pattern - 571 tiles get created
(or better: their transformations). This leads to 251240 polygons to be drawn
for one to-be-filled polygon...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96649] LibreOffice crashes on start on Mac OS X 10.11.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96649

--- Comment #7 from rogelio  ---
Created attachment 121517
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121517=edit
crash report

I installed Java 8 from Oracle and I installed Java for OS X 2015-001 from
Apple. LibreOffice still crashes on open and does not create the user profile. 
There is no space in my name so the only space in the path is
/Users/myname/Library/Application Support/ which is built-in.
Thank you for your help.
I also run Fedora and I am enjoying/using LibreOffice on Fedora. I want to use
this on my Mac to transfer some docs to my iPad.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38274] Next/Previous element still find text after it's deleted from Find Text box on Find Bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38274

Timur  changed:

   What|Removed |Added

   Priority|medium  |low
Summary|Find & Next Page/ Next Find |Next/Previous element still
   |problem |find text after it's
   ||deleted from Find Text box
   ||on Find Bar
   Severity|minor   |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/.gitignore

[Ashod Nakashian]

 loolwsd/.gitignore |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit e6c916fe6d7ad6f65d13065323a375ecb1e36446
Author: Ashod Nakashian 
Date:   Sat Dec 12 13:51:57 2015 -0500

.gitignore: ignore dot files, /systemplate, and cscope

Change-Id: Ibdecd9e58160829208a0ba51f050b6010ad9b3f9
Reviewed-on: https://gerrit.libreoffice.org/20894
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/loolwsd/.gitignore b/loolwsd/.gitignore
index fd499f2..0f52b76 100644
--- a/loolwsd/.gitignore
+++ b/loolwsd/.gitignore
@@ -17,10 +17,13 @@
 /install-sh
 /missing
 /stamp-h1
+/systemplate
 /test-driver
 
 *.o
 *.exe
+cscope*
+.*
 connect
 lokitclient
 loadtest
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - vcl/source

[pasqualm]

 vcl/source/outdev/bitmap.cxx |   47 ---
 1 file changed, 40 insertions(+), 7 deletions(-)

New commits:
commit c9c979a5adc137df89e50809e0f810464f60894c
Author: pasqualm 
Date:   Fri Dec 18 01:03:05 2015 +0100

tdf#90319: make image flipping work in writer for png

Flipping of images was not working if it was only horizontal or vertical,
if both options were selected flipping was treated as a 180º rotation
and that make it work. Problem only affected png files because this
kind of files are treated different from jpg's.

Change-Id: Ia0e4a2b16a714cce0b7fb00d6f0a25fb3552d3b8
Reviewed-on: https://gerrit.libreoffice.org/20782
Reviewed-by: Jacobo Aragunde Pérez 
Tested-by: Jacobo Aragunde Pérez 
(cherry picked from commit 3119440a80282692640378fde5e37974ab63f096)
Reviewed-on: https://gerrit.libreoffice.org/20805
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/outdev/bitmap.cxx b/vcl/source/outdev/bitmap.cxx
index 6225e79..4c125c3 100644
--- a/vcl/source/outdev/bitmap.cxx
+++ b/vcl/source/outdev/bitmap.cxx
@@ -693,7 +693,10 @@ void OutputDevice::DrawDeviceAlphaBitmap( const Bitmap& 
rBmp, const AlphaMask& r
 Rectangle aBmpRect(Point(), rBmp.GetSizePixel());
 if (!aBmpRect.Intersection(Rectangle(rSrcPtPixel, 
rSrcSizePixel)).IsEmpty())
 {
-DrawDeviceAlphaBitmapSlowPath(rBmp, rAlpha, aDstRect, aBmpRect, 
aOutSz, aOutPt);
+Point auxOutPt(LogicToPixel(rDestPt));
+Size  auxOutSz(LogicToPixel(rDestSize));
+
+DrawDeviceAlphaBitmapSlowPath(rBmp, rAlpha, aDstRect, aBmpRect, 
auxOutSz, auxOutPt);
 }
 }
 }
@@ -993,6 +996,7 @@ void OutputDevice::DrawDeviceAlphaBitmapSlowPath(const 
Bitmap& rBitmap, const Al
 else
 {
 LinearScaleContext aLinearContext(aDstRect, aBmpRect, aOutSize, 
nOffX, nOffY);
+
 if (aLinearContext.blendBitmap( 
Bitmap::ScopedWriteAccess(aBmp).get(), pBitmapReadAccess.get(), 
pAlphaReadAccess.get(),
 nDstWidth, nDstHeight))
 {
@@ -1175,6 +1179,7 @@ void OutputDevice::DrawTransformedBitmapEx(
 if ( mnDrawMode & DrawModeFlags::NoBitmap )
 return;
 
+
 // decompose matrix to check rotation and shear
 basegfx::B2DVector aScale, aTranslate;
 double fRotate, fShearX;
@@ -1501,13 +1506,21 @@ Bitmap OutputDevice::BlendBitmap(
 
 for( nY = 0, nOutY = nOffY; nY < nDstHeight; nY++, nOutY++ )
 {
-const long nMapY = pMapY[ nY ];
+long nMapY = pMapY[ nY ];
+if (bVMirr)
+{
+nMapY = aBmpRect.Bottom() - nMapY;
+}
 const long nModY = ( nOutY & 0x0FL ) << 4L;
 int nOutX;
 
 for( nX = 0, nOutX = nOffX; nX < nDstWidth; nX++, nOutX++ )
 {
-const long  nMapX = pMapX[ nX ];
+long  nMapX = pMapX[ nX ];
+if (bHMirr)
+{
+nMapX = aBmpRect.Right() - nMapX;
+}
 const sal_uLong nD = nVCLDitherLut[ nModY | ( nOutX & 
0x0FL ) ];
 
 aDstCol = pB->GetColor( nY, nX );
@@ -1548,13 +1561,22 @@ Bitmap OutputDevice::BlendBitmap(
 {
 for( nY = 0; nY < nDstHeight; nY++ )
 {
-const long  nMapY = pMapY[ nY ];
+long  nMapY = pMapY[ nY ];
+if ( bVMirr )
+{
+nMapY = aBmpRect.Bottom() - nMapY;
+}
 ScanlinepPScan = pP->GetScanline( nMapY );
 ScanlinepAScan = pA->GetScanline( nMapY );
 
 for( nX = 0; nX < nDstWidth; nX++ )
 {
-const long nMapX = pMapX[ nX ];
+long nMapX = pMapX[ nX ];
+
+if ( bHMirr )
+{
+nMapX = aBmpRect.Right() - nMapX;
+}
 aDstCol = pB->GetPixel( nY, nX );
 pB->SetPixel( nY, nX, aDstCol.Merge( 
pP->GetPaletteColor( pPScan[ nMapX ] ),
  pAScan[ 
nMapX ] ) );
@@ -1565,14 +1587,25 @@ Bitmap OutputDevice::BlendBitmap(
 
 default:
 {
+
 for( nY = 0; nY < nDstHeight; nY++ )
  

[Libreoffice-commits] core.git: download.lst external/libvisio

[Fridrich Štrba]

 download.lst  |4 ++--
 external/libvisio/UnpackedTarball_libvisio.mk |4 
 external/libvisio/ubsan.patch |   15 ---
 3 files changed, 2 insertions(+), 21 deletions(-)

New commits:
commit ce014ac76678f186da27faadc973af3eb253c817
Author: Fridrich Å trba 
Date:   Wed Dec 23 15:31:14 2015 +0100

Upload libvisio 0.1.4

Change-Id: Ia4cb506a95a150b8106187719e9104760409dea6

diff --git a/download.lst b/download.lst
index 0b22720..b79837f 100644
--- a/download.lst
+++ b/download.lst
@@ -148,8 +148,8 @@ export SERF_TARBALL := serf-1.2.1.tar.bz2
 export SWING_TARBALL := 35c94d2df8893241173de1d16b6034c0-swingExSrc.zip
 export UCPP_TARBALL := 0168229624cfac409e766913506961a8-ucpp-1.3.2.tar.gz
 export VIGRA_TARBALL := d62650a6f908e85643e557a236ea989c-vigra1.6.0.tar.gz
-export VISIO_MD5SUM := 617f800ab7639fd76c062ab74896318e
-export VISIO_TARBALL := libvisio-0.1.3.tar.bz2
+export VISIO_MD5SUM := 3f829e7e5f7304da37446938bb0df1f5
+export VISIO_TARBALL := libvisio-0.1.4.tar.bz2
 export WPD_MD5SUM := 0773d79a1f240ef9f4f20242b13c5bb7
 export WPD_TARBALL := libwpd-0.10.0.tar.bz2
 export WPG_MD5SUM := 17da9770cb8b317b7633f9807b32b71a
diff --git a/external/libvisio/UnpackedTarball_libvisio.mk 
b/external/libvisio/UnpackedTarball_libvisio.mk
index 027c38e..f9467c5 100644
--- a/external/libvisio/UnpackedTarball_libvisio.mk
+++ b/external/libvisio/UnpackedTarball_libvisio.mk
@@ -13,10 +13,6 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,libvisio,$(VISIO_TARBALL)))
 
 $(eval $(call gb_UnpackedTarball_set_patchlevel,libvisio,0))
 
-$(eval $(call gb_UnpackedTarball_add_patches,libvisio,\
-   external/libvisio/ubsan.patch \
-))
-
 ifeq ($(COM_IS_CLANG),TRUE)
 ifneq ($(filter -fsanitize=%,$(CC)),)
 $(eval $(call gb_UnpackedTarball_add_patches,libvisio, \
diff --git a/external/libvisio/ubsan.patch b/external/libvisio/ubsan.patch
deleted file mode 100644
index 16b0ec4..000
--- a/external/libvisio/ubsan.patch
+++ /dev/null
@@ -1,15 +0,0 @@
 src/lib/VSDParser.cpp
-+++ src/lib/VSDParser.cpp
-@@ -1104,7 +1104,11 @@
-   input->seek(1, librevenge::RVNG_SEEK_CUR);
-   double scale = readDouble(input);
-   input->seek(1, librevenge::RVNG_SEEK_CUR);
--  scale /= readDouble(input);
-+  double scaleDenom = readDouble(input);
-+  if (scaleDenom != 0)
-+  {
-+scale /= scaleDenom;
-+  }
- 
-   if (m_isStencilStarted && m_currentStencil)
-   {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94066] Doesn't display the right font for Noto Sans/ Source Han Sans Fonts.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94066

laichiah...@outlook.com changed:

   What|Removed |Added

Version|5.0.1.2 release |5.0.3.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94066] Doesn't display the right font for Noto Sans/ Source Han Sans Fonts on elementary OS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94066

laichiah...@outlook.com changed:

   What|Removed |Added

Summary|Doesn't display the right   |Doesn't display the right
   |font for Noto Sans/ Source  |font for Noto Sans/ Source
   |Han Sans Fonts. |Han Sans Fonts on
   ||elementary OS

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/source

[Chris Sherlock]

 vcl/inc/PhysicalFontCollection.hxx |   13 ++---
 vcl/source/font/PhysicalFontCollection.cxx |   14 +++---
 2 files changed, 13 insertions(+), 14 deletions(-)

New commits:
commit c694c1812280e03fc04c77fb6483a2410097eb37
Author: Chris Sherlock 
Date:   Wed Dec 23 11:03:02 2015 +1100

vcl: private functions in PhysicalFontCollection start with Impl

Not a fan, but I'll stick with convention and prefix private functions
with Impl in PhysicalFontCollection.

Change-Id: Ided081a19ec071ecd5c6a5a4929584ae0f3b0f05
Reviewed-on: https://gerrit.libreoffice.org/20881
Reviewed-by: Chris Sherlock 
Tested-by: Chris Sherlock 

diff --git a/vcl/inc/PhysicalFontCollection.hxx 
b/vcl/inc/PhysicalFontCollection.hxx
index b78c1ab..66a96c87 100644
--- a/vcl/inc/PhysicalFontCollection.hxx
+++ b/vcl/inc/PhysicalFontCollection.hxx
@@ -50,8 +50,8 @@ public:
 PhysicalFontFamily* FindByFont( FontSelectPattern& ) const;
 
 // suggest fonts for glyph fallback
-PhysicalFontFamily*GetGlyphFallbackFont( FontSelectPattern&,
- OUString& rMissingCodes, int 
nFallbackLevel ) const;
+PhysicalFontFamily* GetGlyphFallbackFont( FontSelectPattern&,
+  OUString& rMissingCodes, int 
nFallbackLevel ) const;
 
 // prepare platform specific font substitutions
 voidSetPreMatchHook( ImplPreMatchFontSubstitution* );
@@ -78,16 +78,15 @@ private:
 mutable PhysicalFontFamily**  mpFallbackList;
 mutable int mnFallbackCount;
 
-voidInitGenericGlyphFallback() const;
+voidImplInitMatchData() const;
+voidImplInitGenericGlyphFallback() const;
 
 PhysicalFontFamily* ImplFindBySearchName( const OUString& ) const;
-PhysicalFontFamily* ImplFindByAliasName(const OUString& rSearchName,
-const OUString& rShortName) 
const;
+PhysicalFontFamily* ImplFindByAliasName ( const OUString& rSearchName, 
const OUString& rShortName) const;
 PhysicalFontFamily* ImplFindBySubstFontAttr( const utl::FontNameAttr& 
) const;
 
-PhysicalFontFamily* FindDefaultFont() const;
+PhysicalFontFamily* ImplFindDefaultFont() const;
 
-voidInitMatchData() const;
 };
 
 #endif // INCLUDED_VCL_INC_PHYSICALFONTCOLLECTION_HXX
diff --git a/vcl/source/font/PhysicalFontCollection.cxx 
b/vcl/source/font/PhysicalFontCollection.cxx
index 39bcb26..13f0e81 100644
--- a/vcl/source/font/PhysicalFontCollection.cxx
+++ b/vcl/source/font/PhysicalFontCollection.cxx
@@ -115,7 +115,7 @@ void PhysicalFontCollection::Clear()
 mbMatchData = false;
 }
 
-void PhysicalFontCollection::InitGenericGlyphFallback() const
+void PhysicalFontCollection::ImplInitGenericGlyphFallback() const
 {
 // normalized family names of fonts suited for glyph fallback
 // if a font is available related fonts can be ignored
@@ -284,7 +284,7 @@ PhysicalFontFamily* 
PhysicalFontCollection::GetGlyphFallbackFont( FontSelectPatt
 {
 // initialize font candidates for generic glyph fallback if needed
 if( mnFallbackCount < 0 )
-InitGenericGlyphFallback();
+ImplInitGenericGlyphFallback();
 
 // TODO: adjust nFallbackLevel by number of levels resolved by the 
fallback hook
 if( nFallbackLevel < mnFallbackCount )
@@ -431,7 +431,7 @@ PhysicalFontFamily* 
PhysicalFontCollection::ImplFindBySubstFontAttr( const utl::
 return nullptr;
 }
 
-void PhysicalFontCollection::InitMatchData() const
+void PhysicalFontCollection::ImplInitMatchData() const
 {
 // short circuit if already done
 if( mbMatchData )
@@ -469,7 +469,7 @@ PhysicalFontFamily* 
PhysicalFontCollection::FindByAttributes( ImplFontAttrs nSea
 && ((eSearchWidth == WIDTH_DONTKNOW) || (eSearchWidth == WIDTH_NORMAL)) )
 return nullptr;
 
-InitMatchData();
+ImplInitMatchData();
 PhysicalFontFamily* pFoundData = nullptr;
 
 longnBestMatch = 4;
@@ -876,7 +876,7 @@ PhysicalFontFamily* 
PhysicalFontCollection::FindByAttributes( ImplFontAttrs nSea
 return pFoundData;
 }
 
-PhysicalFontFamily* PhysicalFontCollection::FindDefaultFont() const
+PhysicalFontFamily* PhysicalFontCollection::ImplFindDefaultFont() const
 {
 // try to find one of the default fonts of the
 // UNICODE, SANSSERIF, SERIF or FIXED default font lists
@@ -909,7 +909,7 @@ PhysicalFontFamily* 
PhysicalFontCollection::FindDefaultFont() const
 
 // now try to find a reasonable non-symbol font
 
-InitMatchData();
+ImplInitMatchData();
 
 PhysicalFontFamilies::const_iterator it = maPhysicalFontFamilies.begin();
 for(; it !=  maPhysicalFontFamilies.end(); ++it )
@@ -1302,7 +1302,7 @@ PhysicalFontFamily* 

[Libreoffice-bugs] [Bug 96681] Lack of UI to change the text background color of a style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96681

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl
   Hardware|x86 (IA32)  |All
Version|5.0.3.2 release |4.4.0.1 rc
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=88
   ||276
 Ever confirmed|0   |1
 OS|Linux (All) |All

--- Comment #1 from Cor Nouws  ---
Hi Vdragon,

Thanks for filing the issue. I can confirm it.

The origin lies in the situation that not too long ago background color was
added as attribute for text-parts in a text box / shape.
Only later (issue 88276) the UI was added for that.

Regards - Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sw/source

[Miklos Vajna]

 sw/source/core/view/viewsh.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 2b8d5a2d5182ee90568173e702f531a2b9279ef9
Author: Miklos Vajna 
Date:   Tue Dec 22 09:08:18 2015 +0100

tdf#93009 SwViewShell: fix printing of comments on the margin

Clipping was set not only in case of VCL-level double buffering, but
also during printing, which means comments were excluded from the
output.

(cherry picked from commit d6913850585eae90ea9179129fe7b60a2a4305ad)

Change-Id: Iffb7d91ca78c09e2b43133f5049d52bd7dc4e730
Reviewed-on: https://gerrit.libreoffice.org/20870
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index 1b01d6e..28ece34 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -208,8 +208,8 @@ void SwViewShell::DLPrePaint2(const vcl::Region& rRegion)
 mpBufferedOut = mpOut;
 mpOut = &(mpTargetPaintWindow->GetTargetOutputDevice());
 }
-else
-// In case mpOut is used without buffering, need to set clipping.
+else if (isOutputToWindow())
+// In case mpOut is used without buffering and we're not printing, 
need to set clipping.
 mpOut->SetClipRegion(rRegion);
 
 // remember original paint MapMode for wrapped FlyFrame paints
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/source

[Miklos Vajna]

 sw/source/core/view/viewsh.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit be005a7a4ec5934372d4b13b96b22d2c8659ed95
Author: Miklos Vajna 
Date:   Tue Dec 22 09:08:18 2015 +0100

tdf#93009 SwViewShell: fix printing of comments on the margin

Clipping was set not only in case of VCL-level double buffering, but
also during printing, which means comments were excluded from the
output.

(cherry picked from commit d6913850585eae90ea9179129fe7b60a2a4305ad)

Change-Id: Iffb7d91ca78c09e2b43133f5049d52bd7dc4e730
Reviewed-on: https://gerrit.libreoffice.org/20872
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index d79458f..3d565ae 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -203,8 +203,8 @@ void SwViewShell::DLPrePaint2(const vcl::Region& rRegion)
 mpBufferedOut = mpOut;
 mpOut = &(mpTargetPaintWindow->GetTargetOutputDevice());
 }
-else
-// In case mpOut is used without buffering, need to set clipping.
+else if (isOutputToWindow())
+// In case mpOut is used without buffering and we're not printing, 
need to set clipping.
 mpOut->SetClipRegion(rRegion);
 
 // remember original paint MapMode for wrapped FlyFrame paints
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96067] Crash on undo row inserts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96067

--- Comment #5 from Terrence Enger  ---
Created attachment 121520
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121520=edit
`make debugrun` with backtrace

LibreOffice in the attached `make debugrun` is commit 30b8dbc, fetched
2015-12-22 00:55 UTC, configured ...

CC=ccache /usr/bin/gcc
CXX=ccache /usr/bin/g++
--enable-option-checking=fatal
--enable-dbgutil
--enable-debug
--enable-crashdump
--without-system-postgresql
--without-myspell-dicts
--with-extra-buildid
--without-doxygen
--with-external-tar=/home/terry/lo_hacking/git/src
# --disable-remote

..., build and running on debian-stretch.


My STR are ...

(1) Run Writer from the command line.  Program presents Writer window
"Untitled 1".

(2) Take menu option Table > "Insert Table...".  Program presents
dialog "Insert Table".

(3) In dialog "Insert Table" type "">.  Program closes the
dialog and returns focus to "Untitled 1", which now shows a table,
2-by-2; the caret is in the upper left cell.

(4) Move mouse cursor into the left margin beside the second row of
the table.  The mouse cursor changes to a bold righ-pointing
arrow.

(5) Right-click and from the popup menu select Insert > "Rows Above".
The table is now three rows by two columns, and the caret is in
the first cell of row three.

(5) Type "+Z".  SIGSEGV.

..., but note that in the same test on daily dbgutil bibisect repo
version 2015-12-23, running chroot-sid, the program failed with
SIGABRT ...

/usr/include/c++/4.8/debug/vector:353:error: attempt to subscript container 
with out-of-bounds index 2, but container only holds 2 elements.

Objects involved in the operation:
sequence "this" @ 0x0x2644820 {
  type = NSt7__debug6vectorIP11SwTableLineSaIS2_EEE;
}
Application Error

Fatal exception: Signal 6

( I am going off now to see what I have to do to get the STL debug
classes in my local build. )

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96695] filesave

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96695

--- Comment #2 from Philip Earwicker  ---
Am using Win 10 loaded on X86 macine

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96616] FILESAVE: Generating a report as "Microsoft Word 2007-2013 XML" creates .odt with .docx extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96616

--- Comment #4 from Lionel Elie Mamane  ---
Just to be clear, if one does "file / save as" from the generated report, and
saves *there* as "Microsoft Word 2007-2013 XML", then it is correctly saved as
.docx, right?

I don't understand this "Tools/Options: Load/Save -> General / Always save
as"... "Clearly" only Writer obeys that... I can't imagine Calc or Impress
following that setting. But nothing in the setting says it is for Writer only.
IMHO, that's a UI problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96609] FORMATTING: Picture disappears between page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96609

--- Comment #3 from Beluga  ---
Are you using Linux? What distro and what desktop environment?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/MasterProcessSession.cpp loolwsd/Util.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp  |6 --
 loolwsd/ChildProcessSession.hpp  |   14 ++
 loolwsd/MasterProcessSession.cpp |   17 +
 loolwsd/Util.cpp |6 +++---
 4 files changed, 26 insertions(+), 17 deletions(-)

New commits:
commit 30e1bbba1477260a66124d8350e7c1a8ee3e8f0e
Author: Ashod Nakashian 
Date:   Sun Dec 13 12:47:14 2015 -0500

loolwsd: const and cleanups

Change-Id: I2fff14407c35a3c6119f44fbee1b4c458b7eac16
Reviewed-on: https://gerrit.libreoffice.org/20897
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index ab92478..5d73230 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -40,7 +40,9 @@ using Poco::StringTokenizer;
 using Poco::URI;
 using Poco::Util::Application;
 
-ChildProcessSession::ChildProcessSession(std::shared_ptr ws, 
LibreOfficeKit *loKit, std::string childId) :
+ChildProcessSession::ChildProcessSession(std::shared_ptr ws,
+ LibreOfficeKit *loKit,
+ const std::string& childId) :
 LOOLSession(ws, Kind::ToMaster),
 _loKitDocument(NULL),
 _loKit(loKit),
@@ -817,4 +819,4 @@ bool ChildProcessSession::setPage(const char* /*buffer*/, 
int /*length*/, String
 return true;
 }
 
-
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index d2665d0..24bebc5 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -7,15 +7,20 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_CHILDPROCESSSESSION_HPP
-#define INCLUDED_CHILDPROCESSSESSION_HPP
+#ifndef INCLUDED_LOOLCHILDPROCESSSESSION_HPP
+#define INCLUDED_LOOLCHILDPROCESSSESSION_HPP
+
+#define LOK_USE_UNSTABLE_API
+#include 
 
 #include "LOOLSession.hpp"
 
 class ChildProcessSession final : public LOOLSession
 {
 public:
-ChildProcessSession(std::shared_ptr ws, 
LibreOfficeKit *loKit, std::string _childId);
+ChildProcessSession(std::shared_ptr ws,
+LibreOfficeKit *loKit,
+const std::string& _childId);
 virtual ~ChildProcessSession();
 
 virtual bool handleInput(const char *buffer, int length) override;
@@ -54,7 +59,7 @@ public:
 
 std::string _loSubPath;
 LibreOfficeKit *_loKit;
-std::string _childId;
+const std::string _childId;
 
  private:
 int _clientPart;
@@ -62,3 +67,4 @@ public:
 
 #endif
 
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/loolwsd/MasterProcessSession.cpp b/loolwsd/MasterProcessSession.cpp
index 21f8caf..b931f41 100644
--- a/loolwsd/MasterProcessSession.cpp
+++ b/loolwsd/MasterProcessSession.cpp
@@ -9,27 +9,30 @@
 
 #include 
 
+#include 
 #include 
 #include 
 #include 
 #include 
-#include 
-#include 
 #include 
 #include 
+#include 
 
-#include "MasterProcessSession.hpp"
-#include "LOOLSession.hpp"
-#include "Util.hpp"
 #include "LOOLProtocol.hpp"
+#include "LOOLSession.hpp"
 #include "LOOLWSD.hpp"
+#include "MasterProcessSession.hpp"
+#include "Util.hpp"
 
 using namespace LOOLProtocol;
+
 using Poco::Dynamic::Var;
+using Poco::Exception;
 using Poco::File;
 using Poco::IOException;
 using Poco::JSON::Object;
 using Poco::JSON::Parser;
+using Poco::Net::SocketAddress;
 using Poco::Net::WebSocket;
 using Poco::Path;
 using Poco::Process;
@@ -40,8 +43,6 @@ using Poco::Thread;
 using Poco::UInt64;
 using Poco::URI;
 using Poco::Util::Application;
-using Poco::Exception;
-using Poco::Net::SocketAddress;
 
 std::map MasterProcessSession::_childProcesses;
 
@@ -51,7 +52,7 @@ std::condition_variable 
MasterProcessSession::_availableChildSessionCV;
 Random MasterProcessSession::_rng;
 std::mutex MasterProcessSession::_rngMutex;
 
-MasterProcessSession::MasterProcessSession(std::shared_ptr ws, Kind 
kind) :
+MasterProcessSession::MasterProcessSession(std::shared_ptr ws, 
const Kind kind) :
 LOOLSession(ws, kind),
 _childId(0),
 _pidChild(0),
diff --git a/loolwsd/Util.cpp b/loolwsd/Util.cpp
index 232e425..02a2c2f 100644
--- a/loolwsd/Util.cpp
+++ b/loolwsd/Util.cpp
@@ -59,11 +59,11 @@ namespace Util
 Poco::Int64 usec = Poco::Timestamp().epochMicroseconds() - epochStart;
 
 const Poco::Int64 one_s = 100;
-Poco::Int64 hours = usec / (one_s*60*60);
+const Poco::Int64 hours = usec / (one_s*60*60);
 usec %= (one_s*60*60);
-Poco::Int64 minutes = usec / (one_s*60);
+const Poco::Int64 minutes = usec / (one_s*60);
 usec %= (one_s*60);
-Poco::Int64 seconds = usec / (one_s);
+const Poco::Int64 seconds = usec / (one_s);
 usec %= (one_s);
 
 std::ostringstream stream;

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/LOOLBroker.cpp loolwsd/LOOLWSD.cpp loolwsd/LOOLWSD.hpp loolwsd/MasterProcessSession.cpp loolwsd/MasterProcessSession.hpp

[Henry Castro]

 loolwsd/ChildProcessSession.cpp  |   10 -
 loolwsd/LOOLBroker.cpp   |   39 ++--
 loolwsd/LOOLWSD.cpp  |  375 +--
 loolwsd/LOOLWSD.hpp  |3 
 loolwsd/MasterProcessSession.cpp |   52 +++--
 loolwsd/MasterProcessSession.hpp |7 
 6 files changed, 280 insertions(+), 206 deletions(-)

New commits:
commit ef9313e3a9bfc727c44c83d09653dda4bc525c5e
Author: Henry Castro 
Date:   Sat Dec 19 20:09:48 2015 -0500

loolwsd: deligating to loolbroker and loolkit

Change-Id: I8499540630373a1bee12a5f58fca3ed701ff6404
Reviewed-on: https://gerrit.libreoffice.org/20904
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 95909af..b74138b 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -139,10 +139,16 @@ bool ChildProcessSession::handleInput(const char *buffer, 
int length)
tokens[0] == "resetselection" ||
tokens[0] == "saveas");
 
-if (_docType != "text" && 
_loKitDocument->pClass->getPart(_loKitDocument) != _clientPart)
 {
-_loKitDocument->pClass->setPart(_loKitDocument, _clientPart);
+Poco::Mutex::ScopedLock lock(_mutex);
+
+_loKitDocument->pClass->setView(_loKitDocument, _viewId);
+if (_docType != "text" && 
_loKitDocument->pClass->getPart(_loKitDocument) != _clientPart)
+{
+_loKitDocument->pClass->setPart(_loKitDocument, _clientPart);
+}
 }
+
 if (tokens[0] == "clientzoom")
 {
 return clientZoom(buffer, length, tokens);
diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index df77fa8..5a64598 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -701,16 +701,16 @@ int main(int argc, char** argv)
 
 const Poco::UInt64 _childId = Util::rng::getNext();
 
-Path jail = Path::forDirectory(childRoot + Path::separator() + 
std::to_string(_childId));
-File(jail).createDirectories();
+Path jailPath = Path::forDirectory(childRoot + Path::separator() + 
std::to_string(_childId));
+File(jailPath).createDirectories();
 
-Path jailLOInstallation(jail, loSubPath);
+Path jailLOInstallation(jailPath, loSubPath);
 jailLOInstallation.makeDirectory();
 File(jailLOInstallation).createDirectory();
 
 // Copy (link) LO installation and other necessary files into it from the 
template
 
-linkOrCopy(sysTemplate, jail);
+linkOrCopy(sysTemplate, jailPath);
 linkOrCopy(loTemplate, jailLOInstallation);
 
 // It is necessary to deploy loolkit process to chroot jail.
@@ -719,34 +719,45 @@ int main(int argc, char** argv)
 std::cout << Util::logPrefix() << "loolkit does not exists" << 
std::endl;
 exit(-1);
 }
-File("loolkit").copyTo(Path(jail, "/usr/bin").toString());
+File("loolkit").copyTo(Path(jailPath, "/usr/bin").toString());
+
+// We need this because sometimes the hostname is not resolved
+std::vector networkFiles = {"/etc/host.conf", "/etc/hosts", 
"/etc/nsswitch.conf", "/etc/resolv.conf"};
+for (std::vector::iterator it = networkFiles.begin(); it != 
networkFiles.end(); ++it)
+{
+   File networkFile(*it);
+   if (networkFile.exists())
+   {
+   networkFile.copyTo(Path(jailPath, "/etc").toString());
+   }
+}
 
 #ifdef __linux
 // Create the urandom and random devices
-File(Path(jail, "/dev")).createDirectory();
-if (mknod((jail.toString() + "/dev/random").c_str(),
+File(Path(jailPath, "/dev")).createDirectory();
+if (mknod((jailPath.toString() + "/dev/random").c_str(),
   S_IFCHR | S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | 
S_IWOTH,
   makedev(1, 8)) != 0)
 {
 std::cout << Util::logPrefix() +
-"mknod(" + jail.toString() + "/dev/random) failed: " +
+"mknod(" + jailPath.toString() + "/dev/random) failed: " +
 strerror(errno) << std::endl;
 
 }
-if (mknod((jail.toString() + "/dev/urandom").c_str(),
+if (mknod((jailPath.toString() + "/dev/urandom").c_str(),
   S_IFCHR | S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | 
S_IWOTH,
   makedev(1, 9)) != 0)
 {
 std::cout << Util::logPrefix() +
-"mknod(" + jail.toString() + "/dev/urandom) failed: " +
+"mknod(" + jailPath.toString() + "/dev/urandom) failed: " +
 strerror(errno) << std::endl;
 }
 #endif
 
-std::cout << Util::logPrefix() << "loolbroker -> chroot(\"" + 
jail.toString() + "\")" << std::endl;
-if (chroot(jail.toString().c_str()) == -1)
+std::cout << Util::logPrefix() << "loolbroker -> chroot(\"" + 
jailPath.toString() + "\")" << std::endl;
+if (chroot(jailPath.toString().c_str()) == -1)
 

[Libreoffice-bugs] [Bug 96627] Calc Access violation or crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96627

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||r...@post.cz
 Ever confirmed|0   |1
   Severity|normal  |major

--- Comment #1 from raal  ---
crash with 5.0.4.2 (x64)
ID sestavení: 2b9802c1994aa0b7dc6079e128979269cf95bc78 and Version:
5.2.0.0.alpha0+ (x64)
Build ID: cfe08df695c046371c4361a434176e6381e3e064
CPU Threads: 1; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-12-15_13:10:55

error message appears:
com.sun.star.uno.Exceptioncom.sun.star.configuration.ConfigurationProvider
expects a single, non-empty, string nodepath argument

BASIC runtime error.
Object variable not set.

after few hits of button in testing document file crashes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96627] Calc Access violation or crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96627

--- Comment #2 from raal  ---
If possible, please follow the instructions provided at this link <
https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg > and
submit a backtrace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96530] Close on draggin outside the sheet when finish create table of contents entries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96530

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #5 from Beluga  ---
I understood it this far:
1) Create table of contents, leave it empty.
2) Write a word into the document and select it.
3) Insert - Table of contents and index (menu in 5.1/5.2) - Index entry.
4) Change from Alphabetical index to Table of contents in the dropdown, hit
Insert and close.
5) Do the same index entry process for another word.
6) Right click ToC and update.

But then I fail to understand the part about "moving with arrows". Where do we
move??

In any case, we can see that the instructions are not clear. Please give
extremely detailed instructions or screenshots of this "moving with arrows".

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45681] [Calc] [AutoFilter] Inconsistent meaning of Check Box "All"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45681

--- Comment #7 from Michel Rudelle  ---

Hi,
This bug is fixed by adding the box "empty", thank you.
Tested with LibO  5.0.3.2
Best regards

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96616] FILESAVE: Generatin a report as "Microsoft Word 2007-2013 XML" creates .odt with .docx extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96616

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Alex Thurgood  ---
This would be an error - LibreOffice doesn't currently support creation of
reports as Microsoft XML, so the switch to default to such formats should
perhaps include a warning that it will not be applicable to database reports.

That said, I'm not best placed to decide whether we should offer that
possibility anyway. Personally, I don't see as a particular advantage, the
whole point of the report writer is to produce ODF compliant documents from a
linked database, but I can see the argument of wanting to be able to produce
docx reports if the UI appears, via an application default setting, to offer
that possibility. I also don't know how well our reports with various
components (e.g. charts) currently export to docx (via the Save as menu), I
would assume not very well, so this would open up a whole can of worms on that
side. 

Confirming with regard to the application switch that doesn't offer what is
written on the box, but opening up for debate as to whether it should.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOKitHelper.hpp loolwsd/LOOLSession.cpp loolwsd/LOOLSession.hpp loolwsd/LOOLWSD.cpp loolwsd/Ma

[Henry Castro]

 loolwsd/ChildProcessSession.cpp |  820 
 loolwsd/ChildProcessSession.hpp |   64 +++
 loolwsd/LOKitHelper.hpp |2 
 loolwsd/LOOLSession.cpp |  778 -
 loolwsd/LOOLSession.hpp |   48 --
 loolwsd/LOOLWSD.cpp |1 
 loolwsd/Makefile.am |4 
 7 files changed, 889 insertions(+), 828 deletions(-)

New commits:
commit 1f43e99ac7465342d2e0fbff7a313844d45a4807
Author: Henry Castro 
Date:   Sat Dec 12 14:23:44 2015 -0500

loolwsd: Refactored ChildProcessSession

ChildProcessSession class now moved to own files.

Change-Id: Ic67c8563ada51f23c83e06631ad913af610d395c
Reviewed-on: https://gerrit.libreoffice.org/20895
Reviewed-by: Ashod Nakashian 
Tested-by: Henry Castro 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
new file mode 100644
index 000..ab92478
--- /dev/null
+++ b/loolwsd/ChildProcessSession.cpp
@@ -0,0 +1,820 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "ChildProcessSession.hpp"
+#include "LOKitHelper.hpp"
+#include "LOOLProtocol.hpp"
+#include "LOOLWSD.hpp"
+#include "Util.hpp"
+
+using namespace LOOLProtocol;
+
+using Poco::File;
+using Poco::IOException;
+using Poco::JSON::Object;
+using Poco::JSON::Parser;
+using Poco::Net::WebSocket;
+using Poco::Path;
+using Poco::Process;
+using Poco::ProcessHandle;
+using Poco::StringTokenizer;
+using Poco::URI;
+using Poco::Util::Application;
+
+ChildProcessSession::ChildProcessSession(std::shared_ptr ws, 
LibreOfficeKit *loKit, std::string childId) :
+LOOLSession(ws, Kind::ToMaster),
+_loKitDocument(NULL),
+_loKit(loKit),
+_childId(childId),
+_clientPart(0)
+{
+std::cout << Util::logPrefix() << "ChildProcessSession ctor this=" << this 
<< " ws=" << _ws.get() << std::endl;
+}
+
+ChildProcessSession::~ChildProcessSession()
+{
+std::cout << Util::logPrefix() << "ChildProcessSession dtor this=" << this 
<< std::endl;
+if (LIBREOFFICEKIT_HAS(_loKit, registerCallback))
+_loKit->pClass->registerCallback(_loKit, 0, 0);
+}
+
+bool ChildProcessSession::handleInput(const char *buffer, int length)
+{
+std::string firstLine = getFirstLine(buffer, length);
+StringTokenizer tokens(firstLine, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
+
+Application::instance().logger().information(Util::logPrefix() + 
_kindString + ",Input," + getAbbreviatedMessage(buffer, length));
+
+if (tokens[0] == "canceltiles")
+{
+// this command makes sense only on the command queue level, nothing
+// to do here
+return true;
+}
+else if (tokens[0] == "commandvalues")
+{
+return getCommandValues(buffer, length, tokens);
+}
+else if (tokens[0] == "partpagerectangles")
+{
+return getPartPageRectangles(buffer, length);
+}
+else if (tokens[0] == "load")
+{
+if (_docURL != "")
+{
+sendTextFrame("error: cmd=load kind=docalreadyloaded");
+return false;
+}
+return loadDocument(buffer, length, tokens);
+}
+else if (_docURL == "")
+{
+sendTextFrame("error: cmd=" + tokens[0] + " kind=nodocloaded");
+return false;
+}
+else if (tokens[0] == "renderfont")
+{
+sendFontRendering(buffer, length, tokens);
+}
+else if (tokens[0] == "setclientpart")
+{
+return setClientPart(buffer, length, tokens);
+}
+else if (tokens[0] == "setpage")
+{
+return setPage(buffer, length, tokens);
+}
+else if (tokens[0] == "status")
+{
+return getStatus(buffer, length);
+}
+else if (tokens[0] == "tile")
+{
+sendTile(buffer, length, tokens);
+}
+else
+{
+// All other commands are such that they always require a 
LibreOfficeKitDocument session,
+// i.e. need to be handled in a child process.
+
+assert(tokens[0] == "clientzoom" ||
+   tokens[0] == "downloadas" ||
+   tokens[0] == "getchildid" ||
+   tokens[0] == "gettextselection" ||
+   tokens[0] == "paste" ||
+   tokens[0] == "insertfile" ||
+   tokens[0] == "key" ||
+   tokens[0] == "mouse" ||
+   tokens[0] == "uno" ||
+   tokens[0] == "selecttext" ||
+   tokens[0] == "selectgraphic" 

[Libreoffice-bugs] [Bug 96695] filesave

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96695

Maxim Monastirsky  changed:

   What|Removed |Added

Version|5.2.0.0.alpha0+ Master  |5.0.4.2 rc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96607] Auto-save functionality stops working after a 'Save as' operation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96607

Beluga  changed:

   What|Removed |Added

   Priority|medium  |high
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|normal  |major

--- Comment #1 from Beluga  ---
(In reply to anwilli5 from comment #0)
> a: the previous backup file gets deleted and a new one is never created

Reproduced.

Win 7 Pro 64-bit Version: 5.2.0.0.alpha0+
Build ID: 18565a34d6e2768d70462f124c6d6972448efe22
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-12-23_11:31:57
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96676] EMF+ not displaying correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96676

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #5 from Alex Thurgood  ---
Confirming :

On LO 5032, the star is nowhere to be seen if the EMF file is opened directly
with LibreOffice (it opens by default in Draw), only a pale red triangle as
Chris has described appears.

On Word for Mac 15.17.1 (latest official release), I see a deep red triangle
with thick black borders and a green star side by side in the docx file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96686] Insert data in temporary MySQL/MariaDB-Table through GUI impossible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96686

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Alex Thurgood  ---
At present temporary tables, such as those available through MySQL, can only be
created via the SQL command entry, so they are not directly creatable via the
GUI anyway.

However, they are also supposed to be updateable, and I guess the only way that
that is currently possible is also via the SQL command.

Useful enhancement request, but if we are going to make them updateable via the
UI, wouldn't it be better, for the sake of completeness, to also allow for
their creation via the UI (e.g. corresponding entry in the uppermost window
pane of the Tables UI ?

I imagine that this would involve a fair amount of work. Still, for me at
least, a valid request for enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/LOOLSession.cpp loolwsd/LOOLSession.hpp loolwsd/LOOLWSD.cpp loolwsd/Makefile.am loolwsd/MasterProcessSession.cpp loolwsd/MasterProcessSession.hpp

[Henry Castro]

 loolwsd/LOOLSession.cpp  |  595 
 loolwsd/LOOLSession.hpp  |   69 
 loolwsd/LOOLWSD.cpp  |1 
 loolwsd/Makefile.am  |4 
 loolwsd/MasterProcessSession.cpp |  640 +++
 loolwsd/MasterProcessSession.hpp |   89 +
 6 files changed, 732 insertions(+), 666 deletions(-)

New commits:
commit 894ab66d8cf00d05f0e2b122b32e7b5a72734cdb
Author: Henry Castro 
Date:   Sat Dec 12 13:50:12 2015 -0500

loolwsd: Refactored MasterProcessSession

MasterProcessSession class now moved to own files.

Change-Id: Ic1a980295b9bb4b28ec9e205de1544fb98ad98f8
Reviewed-on: https://gerrit.libreoffice.org/20893
Reviewed-by: Ashod Nakashian 
Tested-by: Henry Castro 

diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp
index f5299aa..7c208bb 100644
--- a/loolwsd/LOOLSession.cpp
+++ b/loolwsd/LOOLSession.cpp
@@ -169,601 +169,6 @@ void LOOLSession::parseDocOptions(const StringTokenizer& 
tokens, int& part, std:
 }
 }
 
-std::map MasterProcessSession::_childProcesses;
-
-std::set 
MasterProcessSession::_availableChildSessions;
-std::mutex MasterProcessSession::_availableChildSessionMutex;
-std::condition_variable MasterProcessSession::_availableChildSessionCV;
-Random MasterProcessSession::_rng;
-std::mutex MasterProcessSession::_rngMutex;
-
-MasterProcessSession::MasterProcessSession(std::shared_ptr ws, Kind 
kind) :
-LOOLSession(ws, kind),
-_childId(0),
-_pidChild(0),
-_curPart(0),
-_loadPart(-1)
-{
-std::cout << Util::logPrefix() << "MasterProcessSession ctor this=" << 
this << " ws=" << _ws.get() << std::endl;
-}
-
-MasterProcessSession::~MasterProcessSession()
-{
-std::cout << Util::logPrefix() << "MasterProcessSession dtor this=" << 
this << " _peer=" << _peer.lock().get() << std::endl;
-
-auto peer = _peer.lock();
-if (_kind == Kind::ToClient && peer)
-{
-Util::shutdownWebSocket(*(peer->_ws));
-}
-}
-
-bool MasterProcessSession::handleInput(const char *buffer, int length)
-{
-Application::instance().logger().information(Util::logPrefix() + 
_kindString + ",Input," + getAbbreviatedMessage(buffer, length));
-
-std::string firstLine = getFirstLine(buffer, length);
-StringTokenizer tokens(firstLine, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
-
-if (haveSeparateProcess())
-{
-// Note that this handles both forwarding requests from the client to 
the child process, and
-// forwarding replies from the child process to the client. Or does it?
-
-// Snoop at some  messages and manipulate tile cache information as 
needed
-auto peer = _peer.lock();
-
-if (_kind == Kind::ToPrisoner)
-{
-if (tokens[0] == "curpart:" &&
-tokens.count() == 2 &&
-getTokenInteger(tokens[1], "part", _curPart))
-{
-return true;
-}
-
-if (tokens.count() == 2 && tokens[0] == "saveas:")
-{
-std::string url;
-if (!getTokenString(tokens[1], "url", url))
-return true;
-
-if (peer)
-{
-// Save as completed, inform the other (Kind::ToClient)
-// MasterProcessSession about it.
-
-const std::string filePrefix("file:///");
-if (url.find(filePrefix) == 0)
-{
-// Rewrite file:// URLs, as they are visible to the 
outside world.
-Path path(MasterProcessSession::getJailPath(_childId), 
url.substr(filePrefix.length()));
-url = filePrefix + path.toString().substr(1);
-}
-peer->_saveAsQueue.put(url);
-}
-
-return true;
-}
-}
-
-if (_kind == Kind::ToPrisoner && peer && peer->_tileCache)
-{
-if (tokens[0] == "tile:")
-{
-int part, width, height, tilePosX, tilePosY, tileWidth, 
tileHeight;
-if (tokens.count() < 8 ||
-!getTokenInteger(tokens[1], "part", part) ||
-!getTokenInteger(tokens[2], "width", width) ||
-!getTokenInteger(tokens[3], "height", height) ||
-!getTokenInteger(tokens[4], "tileposx", tilePosX) ||
-!getTokenInteger(tokens[5], "tileposy", tilePosY) ||
-!getTokenInteger(tokens[6], "tilewidth", tileWidth) ||
-!getTokenInteger(tokens[7], "tileheight", tileHeight))
-assert(false);
-
-assert(firstLine.size() < 
static_cast(length));
-

[Libreoffice-bugs] [Bug 96686] Insert data in temporary MySQL/MariaDB-Table through GUI impossible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96686

Alex Thurgood  changed:

   What|Removed |Added

 OS|Linux (All) |All

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96679] Add Ability to Assign Keyboard Shortcuts for All Font Effects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96679

--- Comment #3 from Joel Madero  ---
> I'm a bit biased on this idea.
> - People can already use character styles and assign short cuts to those.
> - Short cuts for font effect via direct formatting, is ... eh direct
> formatting.

Of course I feel generally the same :) But if we allow shortcuts for
bold/italics/superscript/subscript/etc..seems strange to have an arbitrary
barrier just to try to force styles.

Anyways - wasn't actually my idea. It came from another bug report and I think
generally I've given up hope that the average day to day user is ever going to
get comfortable with using styles consistently (at least how they are now).

But yeah, I agree that in an ideal world styles would be the go to. Thanks for
the feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 96679] Add Ability to Assign Keyboard Shortcuts for All Font Effects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96679

--- Comment #3 from Joel Madero  ---
> I'm a bit biased on this idea.
> - People can already use character styles and assign short cuts to those.
> - Short cuts for font effect via direct formatting, is ... eh direct
> formatting.

Of course I feel generally the same :) But if we allow shortcuts for
bold/italics/superscript/subscript/etc..seems strange to have an arbitrary
barrier just to try to force styles.

Anyways - wasn't actually my idea. It came from another bug report and I think
generally I've given up hope that the average day to day user is ever going to
get comfortable with using styles consistently (at least how they are now).

But yeah, I agree that in an ideal world styles would be the go to. Thanks for
the feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 96697] UI - Sheet selection on sheet-list pop-up via right-click on sheet navigation cannot select all sheets if scrolling is needed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96697

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||r...@post.cz
 Resolution|--- |DUPLICATE

--- Comment #3 from raal  ---
Hello,

Thank you for submitting the bug. The bug has previously been reported, so this
bug will be added as a duplicate of it. You will automatically be CCed to
updates made to the other bug.

*** This bug has been marked as a duplicate of bug 93191 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93191] Sheet Tab Controls Right Click Not Working Correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93191

raal  changed:

   What|Removed |Added

 CC||mattlop...@yahoo.com.ar

--- Comment #6 from raal  ---
*** Bug 96697 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94726] Sluggish performance on high-end computer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94726

--- Comment #22 from Kim  ---
(In reply to Beluga from comment #21)
> (In reply to Kim from comment #20)
> > (In reply to Michael Meeks from comment #19)
> > > 5.0.4 disables GL by default ;-) so - glad that fixes things for you - but
> > > we'll leave this bug open in order to track the underlying problem.
> > > 
> > > Then again 5.1 is significantly improved performance-wise too =) thanks !
> > 
> > I am not sure what you mean by "5.0.4 disables GL by default". If I go to
> > Options -> LibreOffice -> OpenCL the "Allow use of OpenCL" is checked. Is
> > this setting ignored in 5.0.4?
> 
> Tools - Options - LibO - View - Use OpenGL for all rendering

Enabling OpenGL does lower the smoothness when scrolling and everything seems a
bit more sluggish (in 5.0.4).

I seem to have mixed the terms OpenCL and OpenGL, my apologies.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: oox/source

[Caolán McNamara]

 oox/source/export/shapes.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 0b901a9760a22bdc6f83829b077c30ec08613e17
Author: Caolán McNamara 
Date:   Wed Dec 23 19:10:34 2015 +

crashtesting: export of ooo40765-1.sxw to docx fails

Change-Id: I57d5e085e612908e7a22f444c771ec9fa45485ce

diff --git a/oox/source/export/shapes.cxx b/oox/source/export/shapes.cxx
index 364822f..9fcff75 100644
--- a/oox/source/export/shapes.cxx
+++ b/oox/source/export/shapes.cxx
@@ -306,11 +306,11 @@ uno::Reference GetOLEObjectStream(
 try
 {
 uno::Reference const xParent(
-uno::Reference(xObj, 
uno::UNO_QUERY)->getParent(),
-uno::UNO_QUERY);
+uno::Reference(xObj, 
uno::UNO_QUERY_THROW)->getParent(),
+uno::UNO_QUERY_THROW);
 uno::Reference const 
xParentStorage(xParent->getDocumentStorage());
 OUString const entryName(
-uno::Reference(xObj, 
uno::UNO_QUERY)->getEntryName());
+uno::Reference(xObj, 
uno::UNO_QUERY_THROW)->getEntryName());
 
 if (xParentStorage->isStreamElement(entryName))
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96310] LO will hang for 30 plus seconds after opening EMR software alongside the LO suite (1 processor fully consumed)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96310

--- Comment #9 from mwallin...@nrh-ok.com ---
Any update on this issue? 

I haven't seen any updates here recently, and want to confirm there is nothing
I need to be doing to allow this issue to be resolved in a timely manner.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96610] FORMATTING: Custom caption categories don't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96610

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||todven...@suomi24.fi
Version|5.0.4.2 rc  |3.5.0 release
 Resolution|--- |DUPLICATE
   Severity|normal  |minor

--- Comment #1 from Beluga  ---
Reproduced ("illustration").

The problem is already in 3.5.

I guess we can close as dupe of bug 61493, though.

Win 7 Pro 64-bit Version: 5.2.0.0.alpha0+
Build ID: 18565a34d6e2768d70462f124c6d6972448efe22
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-12-23_11:31:57
Locale: fi-FI (fi_FI)

LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735

*** This bug has been marked as a duplicate of bug 61493 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61493] FORMATTING: Custom Categories for Captions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=61493

Beluga  changed:

   What|Removed |Added

 CC||szots...@gmail.com

--- Comment #7 from Beluga  ---
*** Bug 96610 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96616] FILESAVE: Generatin a report as "Microsoft Word 2007-2013 XML" creates .odt with .docx extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96616

Alex Thurgood  changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/Util.cpp loolwsd/Util.hpp

[Henry Castro]

 loolwsd/Util.cpp |   67 +++
 loolwsd/Util.hpp |6 
 2 files changed, 73 insertions(+)

New commits:
commit 961f853d6d19021075c5afdd5289e2e50def9f79
Author: Henry Castro 
Date:   Sun Dec 13 12:04:45 2015 -0500

loolwsd: Added FIFO utils.

Change-Id: Ifc4e3dafce669c615d5f0d156227f31fcf959936
Reviewed-on: https://gerrit.libreoffice.org/20896
Reviewed-by: Ashod Nakashian 
Tested-by: Henry Castro 

diff --git a/loolwsd/Util.cpp b/loolwsd/Util.cpp
index 02a2c2f..9d74278 100644
--- a/loolwsd/Util.cpp
+++ b/loolwsd/Util.cpp
@@ -7,6 +7,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include 
+
 #include 
 #include 
 #include 
@@ -193,6 +195,71 @@ namespace Util
 return std::to_string(signo);
 }
 }
+
+ssize_t writeFIFO(int nPipe, const char* pBuffer, ssize_t nSize)
+{
+ssize_t nBytes = -1;
+ssize_t nCount = 0;
+
+while(true)
+{
+nBytes = write(nPipe, pBuffer + nCount, nSize - nCount);
+if (nBytes < 0)
+{
+if (errno == EINTR || errno == EAGAIN)
+continue;
+
+nCount = -1;
+break;
+}
+else if ( nCount + nBytes < nSize )
+{
+nCount += nBytes;
+}
+else
+{
+nCount = nBytes;
+break;
+}
+}
+
+return nCount;
+}
+
+ssize_t readFIFO(int nPipe, char* pBuffer, ssize_t nSize)
+{
+ssize_t nBytes;
+do
+{
+nBytes = read(nPipe, pBuffer, nSize);
+}
+while ( nBytes < 0 && errno == EINTR );
+
+return nBytes;
+}
+
+ssize_t readMessage(int nPipe, char* pBuffer, ssize_t nSize)
+{
+ssize_t nBytes = -1;
+struct pollfd aPoll;
+
+aPoll.fd = nPipe;
+aPoll.events = POLLIN;
+aPoll.revents = 0;
+
+int nPoll = poll(, 1, 3000);
+if ( nPoll < 0 )
+goto ErrorPoll;
+
+if ( nPoll == 0 )
+errno = ETIME;
+
+if( (aPoll.revents & POLLIN) != 0 )
+nBytes = readFIFO(nPipe, pBuffer, nSize);
+
+ErrorPoll:
+return nBytes;
+}
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/loolwsd/Util.hpp b/loolwsd/Util.hpp
index 02a21d6..7a82fa4 100644
--- a/loolwsd/Util.hpp
+++ b/loolwsd/Util.hpp
@@ -31,6 +31,12 @@ namespace Util
 void shutdownWebSocket(Poco::Net::WebSocket& ws);
 
 std::string signalName(int signo);
+
+ssize_t writeFIFO(int nPipe, const char* pBuffer, ssize_t nSize);
+
+ssize_t readFIFO(int nPipe, char* pBuffer, ssize_t nSize);
+
+ssize_t readMessage(int nPipe, char* pBuffer, ssize_t nSize);
 };
 
 #endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLWSD.cpp

[Henry Castro]

 loolwsd/ChildProcessSession.cpp |5 -
 loolwsd/ChildProcessSession.hpp |   11 ++-
 loolwsd/LOOLWSD.cpp |2 +-
 3 files changed, 15 insertions(+), 3 deletions(-)

New commits:
commit 03f33c71d9c5cde5e56e8d49a2f6fa84912b17f5
Author: Henry Castro 
Date:   Sun Dec 13 14:25:57 2015 -0500

loolwsd: Multiple views in ChildProcessSession

Change-Id: I07359c97acc1e5e48dbbd35dc21ed08471c0697e
Reviewed-on: https://gerrit.libreoffice.org/20899
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 5d73230..dfa179f 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -42,9 +42,11 @@ using Poco::Util::Application;
 
 ChildProcessSession::ChildProcessSession(std::shared_ptr ws,
  LibreOfficeKit *loKit,
+ LibreOfficeKitDocument * 
loKitDocument,
  const std::string& childId) :
 LOOLSession(ws, Kind::ToMaster),
-_loKitDocument(NULL),
+_loKitDocument(loKitDocument),
+_viewId(0),
 _loKit(loKit),
 _childId(childId),
 _clientPart(0)
@@ -57,6 +59,7 @@ ChildProcessSession::~ChildProcessSession()
 std::cout << Util::logPrefix() << "ChildProcessSession dtor this=" << this 
<< std::endl;
 if (LIBREOFFICEKIT_HAS(_loKit, registerCallback))
 _loKit->pClass->registerCallback(_loKit, 0, 0);
+Util::shutdownWebSocket(*_ws);
 }
 
 bool ChildProcessSession::handleInput(const char *buffer, int length)
diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index 24bebc5..5b7baef 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -18,9 +18,16 @@
 class ChildProcessSession final : public LOOLSession
 {
 public:
+/// Create a new ChildProcessSession
+/// ws The socket to our counterparty (Child or Master).
+/// loKit The LOKit instance.
+/// loKitDocument The instance to an existing document (when opening
+/// a new view) or nullptr (when first view).
+/// childId The id of the child, used by downloadas to construct jailed 
path.
 ChildProcessSession(std::shared_ptr ws,
 LibreOfficeKit *loKit,
-const std::string& _childId);
+LibreOfficeKitDocument * loKitDocument,
+const std::string& childId);
 virtual ~ChildProcessSession();
 
 virtual bool handleInput(const char *buffer, int length) override;
@@ -33,6 +40,8 @@ public:
 
 LibreOfficeKitDocument *_loKitDocument;
 std::string _docType;
+/// View ID, returned by createView() or 0 by default.
+int _viewId;
 
  protected:
 virtual bool loadDocument(const char *buffer, int length, 
Poco::StringTokenizer& tokens) override;
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 8bdc377..f02d7e5 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -1026,7 +1026,7 @@ void LOOLWSD::componentMain()
 HTTPResponse response;
 std::shared_ptr ws(new WebSocket(cs, request, response));
 
-std::shared_ptr session(new 
ChildProcessSession(ws, loKit, std::to_string(_childId)));
+std::shared_ptr session(new 
ChildProcessSession(ws, loKit, nullptr, std::to_string(_childId)));
 
 ws->setReceiveTimeout(0);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96695] New: filesave

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96695

Bug ID: 96695
   Summary: filesave
   Product: LibreOffice
   Version: 5.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philipearwicke...@gmail.com

Version: 5.0.4.2
Build ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78
Locale: en-GB (en_US)

have recently downloaded the above version and find that

File/save button is greyed out - can use Save as but not save

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96696] New: System with OSX 10.11, LO 5.1.0.1, JRE 1.8.0_60 freezes on FILEOPEN of a split database

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96696

Bug ID: 96696
   Summary: System with OSX 10.11, LO 5.1.0.1, JRE 1.8.0_60
freezes on FILEOPEN of a split database
   Product: LibreOffice
   Version: 5.1.0.1 rc
  Hardware: x86-64 (AMD64)
OS: other
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jwrichard...@btinternet.com

To replicate the problem:

Ensure you are using and Apple Mac system with  OSX 10.11.* (El Capitan)
Have LO 5.1.0.1 and JRE 1.8.0_60 installed 

Go to this URL https://forum.openoffice.org/en/forum/viewtopic.php?t=61183
which specifies how to create a split database

download the split database wizard file:
Split_HSQLDB_2.3.2_Wizard_v3d.odb

Attempt to open this odb and see that you system has frozen and locked up.

The only way to recover you system other than a reboot (you are unable to Force
Quit)
is to have the Activity monitor running and abort the LO process.

FYI the activity monitor reports >100% CPU for the LO process.

NB I have tried to make this problem as simple as possible to reproduce if
necessary I can make available my split database application which successfully
runs unchanged on
all OSXs except 10.11, windows 7 & 10, ubuntu 14.10 with various versions of LO
(both Fress & Still) and several recent version of the JRE.  

When attempting to open this application in the bug-report-environment it
exhibits the same lock system freeze. 

My conclusion is that there is a serious initiation problem with OSX 10.11 &
LO/Java when attempting to open a split database.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96697] New: UI - Sheet selection on sheet-list pop-up via right-click on sheet navigation cannot select all sheets if scrolling is needed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96697

Bug ID: 96697
   Summary: UI - Sheet selection on sheet-list pop-up via
right-click on sheet navigation cannot select all
sheets if scrolling is needed.
   Product: LibreOffice
   Version: 5.0.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mattlop...@yahoo.com.ar

Sheet selection on sheet-list pop-up via right-click on sheet navigation cannot
select all sheets if scrolling is needed.

How to reproduce:
1- Open a new spreadsheet.
2- Create many sheets (like 45).
3- Do right-click on sheet navigation buttons to get the sheet-list pop-up. You
should notice that last sheets are not visible in the pop-up and you need
scroll down to find them (maybe on high resolution screens more sheets should
be created in step 2 to reproduce the error).
4- All visible sheets are click-able correctly, however when you scroll down to
see the remaining sheets, those are not click-able.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96697] UI - Sheet selection on sheet-list pop-up via right-click on sheet navigation cannot select all sheets if scrolling is needed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96697

--- Comment #1 from Matias Lopez  ---
Created attachment 121521
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121521=edit
click-able sheet (no scroll performed)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs