[Libreoffice-commits] core.git: vcl/workben

[Stephan Bergmann]

 vcl/workben/vcldemo.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 88c7221926934694635838a269ef3e1659ba03bd
Author: Stephan Bergmann 
Date:   Mon Jan 11 08:45:57 2016 +0100

loplugin:staticmethods

Change-Id: I15d48d69dd05de34f1b85896c2b143d6f17eeecb

diff --git a/vcl/workben/vcldemo.cxx b/vcl/workben/vcldemo.cxx
index e293cc5..3b3ddeb 100644
--- a/vcl/workben/vcldemo.cxx
+++ b/vcl/workben/vcldemo.cxx
@@ -570,7 +570,7 @@ public:
 struct DrawEllipse : public RegionRenderer
 {
 RENDER_DETAILS(ellipse,KEY_E,500)
-void doInvert(OutputDevice , const Rectangle ,
+static void doInvert(OutputDevice , const Rectangle ,
   InvertFlags nFlags)
 {
 rDev.Invert(r, nFlags);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96954] format cell number settings does not work with selected cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96954

--- Comment #4 from futureproj...@gmail.com ---
Can confirm described behaviour in the provided example file when using
AOO412m3(Build:9782) Rev 1709696. Changing formatting of single cells works,
formatting the range does nothing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/Library_vcl.mk vcl/unx

[Chris Sherlock]

 vcl/Library_vcl.mk|2 
 vcl/unx/generic/gdi/gcach_ftyp.cxx| 1547 --
 vcl/unx/generic/glyphs/gcach_ftyp.cxx | 1547 ++
 3 files changed, 1548 insertions(+), 1548 deletions(-)

New commits:
commit 12490c5a7fc681bcc689e659581a8471e7a8bb54
Author: Chris Sherlock 
Date:   Mon Jan 11 12:58:30 2016 +1100

vcl: move gcach_ftyp.cxx to vcl/unx/generic/glyphs

Change-Id: Id12edc0660a2c22c6d04b820ad052bde4fa75143
Reviewed-on: https://gerrit.libreoffice.org/21310
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 393d00a..cfa9a98 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -578,7 +578,7 @@ vcl_headless_freetype_code=\
 vcl/headless/svptext \
 vcl/headless/svpglyphcache \
 vcl/unx/generic/gdi/cairotextrender \
-vcl/unx/generic/gdi/gcach_ftyp \
+vcl/unx/generic/glyphs/gcach_ftyp \
 vcl/headless/svpcairotextrender \
 
 ifeq ($(USING_X11),TRUE)
diff --git a/vcl/unx/generic/gdi/gcach_ftyp.cxx 
b/vcl/unx/generic/glyphs/gcach_ftyp.cxx
similarity index 100%
rename from vcl/unx/generic/gdi/gcach_ftyp.cxx
rename to vcl/unx/generic/glyphs/gcach_ftyp.cxx
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/generic vcl/headless vcl/inc vcl/Library_vcl.mk vcl/unx

[Chris Sherlock]

 vcl/Library_vcl.mk |8 
 vcl/generic/fontmanager/fontsubst.cxx  |2 
 vcl/generic/glyphs/gcach_layout.cxx|  621 -
 vcl/generic/glyphs/glyphcache.cxx  |  379 ---
 vcl/generic/glyphs/graphite_serverfont.cxx |  135 -
 vcl/generic/glyphs/scrptrun.cxx|  234 -
 vcl/generic/glyphs/scrptrun.h  |  173 --
 vcl/generic/print/genpspgraphics.cxx   |2 
 vcl/headless/svpglyphcache.cxx |2 
 vcl/inc/generic/glyphcache.hxx |  300 
 vcl/inc/graphite_serverfont.hxx|2 
 vcl/inc/unx/freetype_glyphcache.hxx|2 
 vcl/inc/unx/glyphcache.hxx |  300 
 vcl/unx/generic/gdi/cairotextrender.cxx|2 
 vcl/unx/generic/gdi/gcach_xpeer.hxx|2 
 vcl/unx/generic/glyphs/gcach_layout.cxx|  621 +
 vcl/unx/generic/glyphs/glyphcache.cxx  |  379 +++
 vcl/unx/generic/glyphs/graphite_serverfont.cxx |  135 +
 vcl/unx/generic/glyphs/scrptrun.cxx|  234 +
 vcl/unx/generic/glyphs/scrptrun.h  |  173 ++
 20 files changed, 1853 insertions(+), 1853 deletions(-)

New commits:
commit 09a1566bf18cdf98b111d4979e4f4ad52ce65b07
Author: Chris Sherlock 
Date:   Mon Jan 11 13:41:05 2016 +1100

vcl: move all glyph files from generic to unx

All the files in glyph are only used by Unix based systems, with the
exception of OS X. Therefore, it's not really "generic" as in "used
across all platforms" but is generic as in "used in all Unix-based
systems".

Change-Id: Id89c09df74f0ddafee5c88c55bac4c35f9b23ef8
Reviewed-on: https://gerrit.libreoffice.org/21312
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index b3dfd09..94ee4c3 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -423,7 +423,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 # handle X11 platforms, which have additional files and possibly system 
graphite
 ifneq (,$(or $(USING_X11),$(ENABLE_HEADLESS)))
 $(eval $(call gb_Library_add_exception_objects,vcl,\
-vcl/generic/glyphs/graphite_serverfont \
+vcl/unx/generic/glyphs/graphite_serverfont \
 ))
 endif
 
@@ -555,9 +555,6 @@ vcl_generic_code= \
 vcl/generic/print/prtsetup \
 vcl/generic/print/text_gfx \
 vcl/generic/fontmanager/fontsubst \
-vcl/generic/glyphs/gcach_layout \
-vcl/generic/glyphs/glyphcache \
-vcl/generic/glyphs/scrptrun \
 vcl/generic/fontmanager/fontcache \
 vcl/generic/fontmanager/fontconfig \
 vcl/generic/fontmanager/fontmanager \
@@ -579,6 +576,9 @@ vcl_headless_freetype_code=\
 vcl/headless/svpglyphcache \
 vcl/unx/generic/gdi/cairotextrender \
 vcl/unx/generic/glyphs/freetype_glyphcache \
+vcl/unx/generic/glyphs/gcach_layout \
+vcl/unx/generic/glyphs/glyphcache \
+vcl/unx/generic/glyphs/scrptrun \
 vcl/headless/svpcairotextrender \
 
 ifeq ($(USING_X11),TRUE)
diff --git a/vcl/generic/fontmanager/fontsubst.cxx 
b/vcl/generic/fontmanager/fontsubst.cxx
index 5f7bfb3..f8894450 100644
--- a/vcl/generic/fontmanager/fontsubst.cxx
+++ b/vcl/generic/fontmanager/fontsubst.cxx
@@ -19,7 +19,7 @@
 
 #include "generic/geninst.h"
 #include "generic/genpspgraphics.h"
-#include "generic/glyphcache.hxx"
+#include "unx/glyphcache.hxx"
 
 #include "vcl/sysdata.hxx"
 #include "fontinstance.hxx"
diff --git a/vcl/generic/print/genpspgraphics.cxx 
b/vcl/generic/print/genpspgraphics.cxx
index 145bf7d..d3cc75c 100644
--- a/vcl/generic/print/genpspgraphics.cxx
+++ b/vcl/generic/print/genpspgraphics.cxx
@@ -46,7 +46,7 @@
 #include "fontsubset.hxx"
 #include "generic/geninst.h"
 #include "generic/genpspgraphics.h"
-#include "generic/glyphcache.hxx"
+#include "unx/glyphcache.hxx"
 #include "generic/printergfx.hxx"
 #include "impfont.hxx"
 #include "langboost.hxx"
diff --git a/vcl/headless/svpglyphcache.cxx b/vcl/headless/svpglyphcache.cxx
index a94ea85..e5c5675 100644
--- a/vcl/headless/svpglyphcache.cxx
+++ b/vcl/headless/svpglyphcache.cxx
@@ -25,7 +25,7 @@
 #include 
 
 #include "generic/geninst.h"
-#include "generic/glyphcache.hxx"
+#include "unx/glyphcache.hxx"
 #include "headless/svpgdi.hxx"
 
 namespace
diff --git a/vcl/inc/graphite_serverfont.hxx b/vcl/inc/graphite_serverfont.hxx
index 0a5b913..137cb14 100644
--- a/vcl/inc/graphite_serverfont.hxx
+++ b/vcl/inc/graphite_serverfont.hxx
@@ -26,7 +26,7 @@
 #ifndef _MSC_VER
 #include 
 
-#include "generic/glyphcache.hxx"
+#include "unx/glyphcache.hxx"
 
 class PhysicalFontFace;
 
diff --git a/vcl/inc/unx/freetype_glyphcache.hxx 
b/vcl/inc/unx/freetype_glyphcache.hxx
index cf3c66b..3b8d315 100644
--- a/vcl/inc/unx/freetype_glyphcache.hxx
+++ 

[Libreoffice-commits] core.git: vcl/generic vcl/inc vcl/Library_vcl.mk vcl/unx

[Chris Sherlock]

 vcl/Library_vcl.mk |2 
 vcl/generic/glyphs/gcach_layout.cxx|2 
 vcl/generic/glyphs/glyphcache.cxx  |2 
 vcl/generic/glyphs/graphite_serverfont.cxx |2 
 vcl/inc/unx/freetype_glyphcache.hxx|  164 ++
 vcl/inc/unx/gcach_ftyp.hxx |  164 --
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx | 1547 +
 vcl/unx/generic/glyphs/gcach_ftyp.cxx  | 1547 -
 8 files changed, 1715 insertions(+), 1715 deletions(-)

New commits:
commit 557a6d20080e6f4d95db9e5b4dff87f3e51ac054
Author: Chris Sherlock 
Date:   Mon Jan 11 13:20:38 2016 +1100

vcl: rename gcach_ftyp.{cxx|hxx} to freetype_glyphcache.{cxx|hxx}

Change-Id: If17c0c36108c2437accba105e11a93a009d2c91f
Reviewed-on: https://gerrit.libreoffice.org/21311
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index cfa9a98..b3dfd09 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -578,7 +578,7 @@ vcl_headless_freetype_code=\
 vcl/headless/svptext \
 vcl/headless/svpglyphcache \
 vcl/unx/generic/gdi/cairotextrender \
-vcl/unx/generic/glyphs/gcach_ftyp \
+vcl/unx/generic/glyphs/freetype_glyphcache \
 vcl/headless/svpcairotextrender \
 
 ifeq ($(USING_X11),TRUE)
diff --git a/vcl/generic/glyphs/gcach_layout.cxx 
b/vcl/generic/glyphs/gcach_layout.cxx
index 9aa21bf..70ac190 100644
--- a/vcl/generic/glyphs/gcach_layout.cxx
+++ b/vcl/generic/glyphs/gcach_layout.cxx
@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "unx/gcach_ftyp.hxx"
+#include "unx/freetype_glyphcache.hxx"
 #include 
 #include 
 #include 
diff --git a/vcl/generic/glyphs/glyphcache.cxx 
b/vcl/generic/glyphs/glyphcache.cxx
index 4d13c52..33f06df 100644
--- a/vcl/generic/glyphs/glyphcache.cxx
+++ b/vcl/generic/glyphs/glyphcache.cxx
@@ -19,7 +19,7 @@
 
 #include 
 #include 
-#include "unx/gcach_ftyp.hxx"
+#include "unx/freetype_glyphcache.hxx"
 
 #include 
 #include 
diff --git a/vcl/generic/glyphs/graphite_serverfont.cxx 
b/vcl/generic/glyphs/graphite_serverfont.cxx
index 63b0fa7..623df7b 100644
--- a/vcl/generic/glyphs/graphite_serverfont.cxx
+++ b/vcl/generic/glyphs/graphite_serverfont.cxx
@@ -23,7 +23,7 @@
 #include 
 #include 
 // Module
-#include "unx/gcach_ftyp.hxx"
+#include "unx/freetype_glyphcache.hxx"
 #include "generic/glyphcache.hxx"
 #include 
 #include 
diff --git a/vcl/inc/unx/gcach_ftyp.hxx b/vcl/inc/unx/freetype_glyphcache.hxx
similarity index 100%
rename from vcl/inc/unx/gcach_ftyp.hxx
rename to vcl/inc/unx/freetype_glyphcache.hxx
diff --git a/vcl/unx/generic/glyphs/gcach_ftyp.cxx 
b/vcl/unx/generic/glyphs/freetype_glyphcache.cxx
similarity index 99%
rename from vcl/unx/generic/glyphs/gcach_ftyp.cxx
rename to vcl/unx/generic/glyphs/freetype_glyphcache.cxx
index 7e49c0b..5417590 100644
--- a/vcl/unx/generic/glyphs/gcach_ftyp.cxx
+++ b/vcl/unx/generic/glyphs/freetype_glyphcache.cxx
@@ -20,7 +20,7 @@
 
 #include 
 
-#include "unx/gcach_ftyp.hxx"
+#include "unx/freetype_glyphcache.hxx"
 
 #include "vcl/svapp.hxx"
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/LOOLKit.cpp loolwsd/Util.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |   91 ++--
 loolwsd/LOOLKit.cpp |3 -
 loolwsd/Util.cpp|2 
 3 files changed, 44 insertions(+), 52 deletions(-)

New commits:
commit 4b028e15062c40164b2231741a3811a743d5112e
Author: Ashod Nakashian 
Date:   Thu Jan 7 09:40:41 2016 -0500

loolwsd: localized lokit lock and other cleanups

Change-Id: I16453924d90ab22e57f8b6a3bbb937fef853ea2c
Reviewed-on: https://gerrit.libreoffice.org/21315
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index a24bb96..8aaf30d 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -343,6 +343,7 @@ bool ChildProcessSession::getStatus(const char* /*buffer*/, 
int /*length*/)
 {
 Poco::Mutex::ScopedLock lock(_mutex);
 
+_loKitDocument->pClass->setView(_loKitDocument, _viewId);
 std::string status = "status: " + 
LOKitHelper::documentStatus(_loKitDocument);
 StringTokenizer tokens(status, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
 if (!getTokenString(tokens[1], "type", _docType))
@@ -356,14 +357,16 @@ bool ChildProcessSession::getStatus(const char* 
/*buffer*/, int /*length*/)
 
 bool ChildProcessSession::getCommandValues(const char* /*buffer*/, int 
/*length*/, StringTokenizer& tokens)
 {
-Poco::Mutex::ScopedLock lock(_mutex);
-
 std::string command;
 if (tokens.count() != 2 || !getTokenString(tokens[1], "command", command))
 {
 sendTextFrame("error: cmd=commandvalues kind=syntax");
 return false;
 }
+
+Poco::Mutex::ScopedLock lock(_mutex);
+
+_loKitDocument->pClass->setView(_loKitDocument, _viewId);
 sendTextFrame("commandvalues: " + 
std::string(_loKitDocument->pClass->getCommandValues(_loKitDocument, 
command.c_str(;
 return true;
 }
@@ -372,15 +375,13 @@ bool ChildProcessSession::getPartPageRectangles(const 
char* /*buffer*/, int /*le
 {
 Poco::Mutex::ScopedLock lock(_mutex);
 
-   _loKitDocument->pClass->setView(_loKitDocument, _viewId);
-   sendTextFrame("partpagerectangles: " + 
std::string(_loKitDocument->pClass->getPartPageRectangles(_loKitDocument)));
+_loKitDocument->pClass->setView(_loKitDocument, _viewId);
+sendTextFrame("partpagerectangles: " + 
std::string(_loKitDocument->pClass->getPartPageRectangles(_loKitDocument)));
 return true;
 }
 
 void ChildProcessSession::sendTile(const char* /*buffer*/, int /*length*/, 
StringTokenizer& tokens)
 {
-Poco::Mutex::ScopedLock lock(_mutex);
-
 int part, width, height, tilePosX, tilePosY, tileWidth, tileHeight;
 
 if (tokens.count() < 8 ||
@@ -408,17 +409,19 @@ void ChildProcessSession::sendTile(const char* 
/*buffer*/, int /*length*/, Strin
 return;
 }
 
+Poco::Mutex::ScopedLock lock(_mutex);
+
 _loKitDocument->pClass->setView(_loKitDocument, _viewId);
 
-std::string response = "tile: " + Poco::cat(std::string(" "), 
tokens.begin() + 1, tokens.end()) + "\n";
+const std::string response = "tile: " + Poco::cat(std::string(" "), 
tokens.begin() + 1, tokens.end()) + "\n";
 
 std::vector output;
-output.reserve(4 * width * height);
+output.reserve(response.size() + (4 * width * height));
 output.resize(response.size());
 std::memcpy(output.data(), response.data(), response.size());
 
-unsigned char *pixmap = new unsigned char[4 * width * height];
-memset(pixmap, 0, 4 * width * height);
+std::vector pixmap;
+pixmap.resize(4 * width * height);
 
 if (_docType != "text" && part != 
_loKitDocument->pClass->getPart(_loKitDocument))
 {
@@ -426,26 +429,22 @@ void ChildProcessSession::sendTile(const char* 
/*buffer*/, int /*length*/, Strin
 }
 
 Poco::Timestamp timestamp;
-_loKitDocument->pClass->paintTile(_loKitDocument, pixmap, width, height, 
tilePosX, tilePosY, tileWidth, tileHeight);
+_loKitDocument->pClass->paintTile(_loKitDocument, pixmap.data(), width, 
height, tilePosX, tilePosY, tileWidth, tileHeight);
 Log::trace() << "paintTile at [" << tilePosX << ", " << tilePosY
  << "] rendered in " << (timestamp.elapsed()/1000.) << " ms" 
<< Log::end;
 
 LibreOfficeKitTileMode mode = 
static_cast(_loKitDocument->pClass->getTileMode(_loKitDocument));
-if (!Util::encodePNGAndAppendToBuffer(pixmap, width, height, output, mode))
+if (!Util::encodePNGAndAppendToBuffer(pixmap.data(), width, height, 
output, mode))
 {
 sendTextFrame("error: cmd=tile kind=failure");
 return;
 }
 
-delete[] pixmap;
-
 sendBinaryFrame(output.data(), output.size());
 }
 
 bool ChildProcessSession::clientZoom(const char* /*buffer*/, int /*length*/, 
StringTokenizer& tokens)
 {
-Poco::Mutex::ScopedLock lock(_mutex);
-
int tilePixelWidth, tilePixelHeight, 

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |   20 --
 loolwsd/LOOLKit.cpp |  118 +---
 2 files changed, 75 insertions(+), 63 deletions(-)

New commits:
commit a66a12004dde70bb3159c7c20db10b93bc48b016
Author: Ashod Nakashian 
Date:   Fri Jan 8 12:59:57 2016 -0500

loolwsd: better handling of multiple connections

Change-Id: I3acd9810b63426ea4b811bf2f4f4341ba70e4ba0
Reviewed-on: https://gerrit.libreoffice.org/21316
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 8aaf30d..7248470 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -64,16 +64,20 @@ ChildProcessSession::~ChildProcessSession()
 {
 Log::info("~ChildProcessSession dtor [" + getName() + "].");
 
+Poco::Mutex::ScopedLock lock(_mutex);
+
 if (_loKitDocument != nullptr)
 {
-_loKitDocument->pClass->registerCallback(_loKitDocument, nullptr, 
this);
+_loKitDocument->pClass->setView(_loKitDocument, _viewId);
+
+_loKitDocument->pClass->registerCallback(_loKitDocument, nullptr, 
nullptr);
 
 _loKitDocument->pClass->destroyView(_loKitDocument, _viewId);
 Log::debug("Destroy view [" + getName() + "]-> [" + 
std::to_string(_viewId) + "]");
 }
 
 if (LIBREOFFICEKIT_HAS(_loKit, registerCallback))
-_loKit->pClass->registerCallback(_loKit, nullptr, this);
+_loKit->pClass->registerCallback(_loKit, nullptr, nullptr);
 
 _onUnload(_viewId);
 }
@@ -104,6 +108,7 @@ bool ChildProcessSession::_handleInput(const char *buffer, 
int length)
 sendTextFrame("error: cmd=load kind=docalreadyloaded");
 return false;
 }
+
 return loadDocument(buffer, length, tokens);
 }
 else if (_docURL == "")
@@ -231,8 +236,6 @@ extern "C"
 
 bool ChildProcessSession::loadDocument(const char *buffer, int length, 
StringTokenizer& tokens)
 {
-Poco::Mutex::ScopedLock lock(_mutex);
-
 int part = -1;
 if (tokens.count() < 2)
 {
@@ -246,17 +249,18 @@ bool ChildProcessSession::loadDocument(const char 
*buffer, int length, StringTok
 assert(!_docURL.empty());
 assert(!_jailedFilePath.empty());
 
-if (_loKitDocument == nullptr)
-Log::info("Loading new document from URI: [" + _jailedFilePath + "].");
-else
-Log::info("Loading view to document from URI: [" + _jailedFilePath + 
"].");
+Poco::Mutex::ScopedLock lock(_mutex);
 
 if (_loKitDocument != nullptr)
 {
+Log::info("Loading view to document from URI: [" + _jailedFilePath + 
"].");
+
 _viewId = _loKitDocument->pClass->createView(_loKitDocument);
 }
 else
 {
+Log::info("Loading new document from URI: [" + _jailedFilePath + "].");
+
 if ( LIBREOFFICEKIT_HAS(_loKit, registerCallback))
 _loKit->pClass->registerCallback(_loKit, myCallback, this);
 
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 6fc03af..c565ec6 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -16,6 +16,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 
@@ -333,7 +334,7 @@ public:
 _onLoad(onLoad),
 _onUnload(onUnload)
 {
-Log::info("Connection ctor in child: " + jailId + ", thread: " + 
_sessionId);
+Log::info("Connection ctor in child: " + _jailId + ", thread: " + 
_sessionId);
 }
 
 ~Connection()
@@ -480,13 +481,18 @@ public:
   : _loKit(loKit),
 _jailId(jailId),
 _url(url),
-_loKitDocument(nullptr)
+_loKitDocument(nullptr),
+_clientViews(0),
+_mainViewId(-1)
 {
-Log::info("Document ctor for url [" + url + "] on child [" + jailId + 
"].");
+Log::info("Document ctor for url [" + _url + "] on child [" + _jailId 
+ "].");
 }
 
 ~Document()
 {
+Log::info("~Document dtor for url [" + _url + "] on child [" + _jailId 
+
+  "]. There are " + std::to_string(_mainViewId) + " views.");
+
 // Destroy all connections and views.
 for (auto aIterator : _connections)
 {
@@ -505,75 +511,53 @@ public:
 }
 }
 
-// Get the document to destroy later.
-auto loKitDocument = _connections.size() > 0
-? _connections.begin()->second->getLOKitDocument()
-: nullptr;
-
 // Destroy all connections and views.
 _connections.clear();
 
 // TODO. check what is happening when destroying lokit document
 // Destroy the document.
-if (loKitDocument != nullptr)
+if (_loKitDocument != nullptr)
 {
-loKitDocument->pClass->destroy(loKitDocument);
+_loKitDocument->pClass->destroyView(_loKitDocument, _mainViewId);
+

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |7 +--
 loolwsd/LOOLKit.cpp |1 +
 2 files changed, 2 insertions(+), 6 deletions(-)

New commits:
commit 910b34de58acf28eaf043a7647d84750a08fad0c
Author: Ashod Nakashian 
Date:   Sat Jan 9 12:02:52 2016 -0500

loolwsd: destroy ChildProcessSessions

Change-Id: I58e9f58047162e842e155b70284fe55a45af35c9
Reviewed-on: https://gerrit.libreoffice.org/21324
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 0940509..b2cc4c3 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -66,12 +66,7 @@ ChildProcessSession::~ChildProcessSession()
 
 Poco::Mutex::ScopedLock lock(_mutex);
 
-if (_loKitDocument != nullptr)
-{
-_onUnload(_viewId);
-Log::debug("Destroy view [" + getName() + "]-> [" + 
std::to_string(_viewId) + "]");
-}
-
+_onUnload(_viewId);
 }
 
 bool ChildProcessSession::_handleInput(const char *buffer, int length)
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 1564616..7c9f86e 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -438,6 +438,7 @@ public:
 
 // We should probably send the Client some sensible message and 
reason.
 _session->sendTextFrame("eof");
+_session.reset();
 }
 catch (const Exception& exc)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLWSD.hpp

[Ashod Nakashian]

 loolwsd/LOOLWSD.hpp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit cb772746d8b4a14115ef172970dcb5dba36936b4
Author: Ashod Nakashian 
Date:   Sat Jan 9 12:02:11 2016 -0500

loolwsd: multiple documents load correctly now

Change-Id: I86adda24d5ea576aa17829f27b78cb02d0350a4b
Reviewed-on: https://gerrit.libreoffice.org/21323
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLWSD.hpp b/loolwsd/LOOLWSD.hpp
index 3e990eb..4108775 100644
--- a/loolwsd/LOOLWSD.hpp
+++ b/loolwsd/LOOLWSD.hpp
@@ -51,8 +51,8 @@ public:
 std::unique_lock lock(DocumentsMutex);
 
 // Find the document if already open.
-auto it = UriToDocumentMap.find(publicFilePath);
-if (it != UriToDocumentMap.end())
+auto it = UriToDocumentMap.lower_bound(publicFilePath);
+if (it != UriToDocumentMap.end() && it->first == publicFilePath)
 {
 Log::info("Document [" + it->first + "] found.");
 return it->second;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |2 +-
 loolwsd/LOOLKit.cpp |   20 ++--
 2 files changed, 15 insertions(+), 7 deletions(-)

New commits:
commit 5130aa214d63831d08f8ae9c746f82fdb1f72e3c
Author: Ashod Nakashian 
Date:   Sun Jan 10 21:55:12 2016 -0500

loolwsd: better locking in Document

Change-Id: Ia6cef55201f5505e703026a8461282b5fb79fd85
Reviewed-on: https://gerrit.libreoffice.org/21330
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 9424769..883c648 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -256,11 +256,11 @@ bool ChildProcessSession::loadDocument(const char * 
/*buffer*/, int /*length*/,
 _loKitDocument->pClass->setPart(_loKitDocument, part);
 }
 
-
 // Respond by the document status, which has no arguments.
 if (!getStatus(nullptr, 0))
 return false;
 
+Log::info("Loaded session " + getId());
 return true;
 }
 
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 4750d08..f6fa52f 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -568,6 +568,8 @@ public:
 
 void purgeSessions()
 {
+std::unique_lock lock(_mutex);
+
 for (auto it =_connections.cbegin(); it != _connections.cend(); )
 {
 if (!it->second->isRunning())
@@ -581,7 +583,9 @@ public:
 
 bool hasConnections()
 {
-return _connections.size() > 0;
+std::unique_lock lock(_mutex);
+
+return !_connections.empty();
 }
 
 private:
@@ -619,11 +623,11 @@ private:
 /// Load a document (or view) and register callbacks.
 LibreOfficeKitDocument* onLoad(const std::string& sessionId, const 
std::string& uri)
 {
-std::unique_lock lock(_mutex);
-
-Log::info("Session " + sessionId + " is unloading. " + 
std::to_string(_clientViews) + " views loaded.");
+Log::info("Session " + sessionId + " is loading. " + 
std::to_string(_clientViews) + " views loaded.");
 
 const unsigned intSessionId = Util::decodeId(sessionId);
+
+std::unique_lock lock(_mutex);
 const auto it = _connections.find(intSessionId);
 if (it == _connections.end() || !it->second)
 {
@@ -631,6 +635,8 @@ private:
 return nullptr;
 }
 
+lock.unlock();
+
 if (_loKitDocument == nullptr)
 {
 Log::info("Loading new document from URI: [" + uri + "] for 
session [" + sessionId + "].");
@@ -667,11 +673,11 @@ private:
 
 void onUnload(const std::string& sessionId)
 {
-std::unique_lock lock(_mutex);
-
 Log::info("Session " + sessionId + " is unloading. " + 
std::to_string(_clientViews - 1) + " views left.");
 
 const unsigned intSessionId = Util::decodeId(sessionId);
+
+std::unique_lock lock(_mutex);
 const auto it = _connections.find(intSessionId);
 if (it == _connections.end() || !it->second)
 {
@@ -679,6 +685,8 @@ private:
 return;
 }
 
+lock.unlock();
+
 --_clientViews;
 
 if (_multiView && _loKitDocument)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 7e023160342c41425ebedb80ef984b45c386c3d3
Author: Ashod Nakashian 
Date:   Sun Jan 10 22:04:55 2016 -0500

loolwsd: prevent the user from killing our window with ctrl+w

Change-Id: I77f004bc131ce5b469e76089efddd9e2e99ea526
Reviewed-on: https://gerrit.libreoffice.org/21331
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 883c648..1fb17ca 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -576,6 +576,12 @@ bool ChildProcessSession::keyEvent(const char* /*buffer*/, 
int /*length*/, Strin
 return false;
 }
 
+// Don't close LO window!
+constexpr auto KEY_CTRL = 0x2000;
+constexpr auto KEY_W= 0x0216;
+if (keycode == (KEY_CTRL | KEY_W))
+return true;
+
 Poco::Mutex::ScopedLock lock(_mutex);
 
 if (_multiView)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/LOOLKit.cpp |   15 +++
 1 file changed, 11 insertions(+), 4 deletions(-)

New commits:
commit c83f3937d4faeac4eda2a03a9eac3244429ef46b
Author: Ashod Nakashian 
Date:   Sun Jan 10 10:34:47 2016 -0500

loolwsd: Document locks and view counters

Change-Id: I2bae3fd7136e5bb85276f5cad246497e51fbfdd0
Reviewed-on: https://gerrit.libreoffice.org/21328
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 35fc483..7e2f8ad 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -485,6 +485,8 @@ public:
 
 ~Document()
 {
+std::unique_lock lock(_mutex);
+
 Log::info("~Document dtor for url [" + _url + "] on child [" + _jailId 
+
   "]. There are " + std::to_string(_clientViews) + " views.");
 
@@ -597,6 +599,8 @@ private:
 Document* self = reinterpret_cast(pData);
 if (self)
 {
+std::unique_lock lock(self->_mutex);
+
 for (auto& it: self->_connections)
 {
 if (it.second->isRunning())
@@ -615,6 +619,10 @@ private:
 /// Load a document (or view) and register callbacks.
 LibreOfficeKitDocument* onLoad(const std::string& sessionId, const 
std::string& uri)
 {
+std::unique_lock lock(_mutex);
+
+Log::info("Session " + sessionId + " is unloading. " + 
std::to_string(_clientViews) + " views loaded.");
+
 const unsigned intSessionId = Util::decodeId(sessionId);
 const auto it = _connections.find(intSessionId);
 if (it == _connections.end() || !it->second)
@@ -644,16 +652,16 @@ private:
 
 _loKitDocument->pClass->registerCallback(_loKitDocument, 
ViewCallback, reinterpret_cast(intSessionId));
 
-++_clientViews;
 Log::info() << "Document [" << _url << "] view ["
 << viewId << "] loaded, leaving "
-<< _clientViews << " views." << Log::end;
+<< (_clientViews + 1) << " views." << Log::end;
 }
 else
 {
 _loKitDocument->pClass->registerCallback(_loKitDocument, 
DocumentCallback, this);
 }
 
+++_clientViews;
 return _loKitDocument;
 }
 
@@ -675,8 +683,7 @@ private:
 
 if (_multiView && _loKitDocument)
 {
---_clientViews;
-Log::info() << "Document [" << _url << "] view ["
+Log::info() << "Document [" << _url << "] session ["
 << sessionId << "] unloaded, leaving "
 << _clientViews << " views." << Log::end;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp loolwsd/LOOLWSD.cpp

[Ashod Nakashian]

 loolwsd/LOOLKit.cpp |4 ++--
 loolwsd/LOOLWSD.cpp |   26 +-
 2 files changed, 15 insertions(+), 15 deletions(-)

New commits:
commit f577e48f18c01616269159c839b25beda9a4355f
Author: Ashod Nakashian 
Date:   Sun Jan 10 10:35:28 2016 -0500

loolwsd: child Session ID in URI

Change-Id: Ide04425fe29d17dd2db1aea532de421b8f0e3669
Reviewed-on: https://gerrit.libreoffice.org/21329
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 7e2f8ad..4750d08 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -362,7 +362,7 @@ public:
 
 void run() override
 {
-static const std::string thread_name = "kit_socket_" + _sessionId;
+static const std::string thread_name = "kit_ws_" + _sessionId;
 #ifdef __linux
 if (prctl(PR_SET_NAME, reinterpret_cast(thread_name.c_str()), 0, 0, 0) != 0)
 Log::error("Cannot set thread name to " + thread_name + ".");
@@ -376,7 +376,7 @@ public:
 
 HTTPClientSession cs("127.0.0.1", MASTER_PORT_NUMBER);
 cs.setTimeout(0);
-HTTPRequest request(HTTPRequest::HTTP_GET, CHILD_URI);
+HTTPRequest request(HTTPRequest::HTTP_GET, CHILD_URI + _sessionId);
 HTTPResponse response;
 _ws = std::make_shared(cs, request, response);
 
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 71e9915..51bd75c 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -308,7 +308,8 @@ public:
 
 void handleRequest(HTTPServerRequest& request, HTTPServerResponse& 
response) override
 {
-const std::string thread_name = "client_socket";
+const auto id = LOOLWSD::GenSessionId();
+const std::string thread_name = "client_ws_" + id;
 
 #ifdef __linux
 if (prctl(PR_SET_NAME, reinterpret_cast(thread_name.c_str()), 0, 0, 0) != 0)
@@ -333,7 +334,6 @@ public:
 // Load the document.
 std::shared_ptr ws;
 const LOOLSession::Kind kind = LOOLSession::Kind::ToClient;
-const auto id = LOOLWSD::GenSessionId();
 auto session = std::make_shared(id, 
kind, ws);
 const std::string filePrefix("file://");
 const std::string load = "load url=" + filePrefix + 
fromPath;
@@ -430,8 +430,6 @@ public:
 try
 {
 auto ws = std::make_shared(request, response);
-
-const std::string id = LOOLWSD::GenSessionId();
 auto session = std::make_shared(id, 
LOOLSession::Kind::ToClient, ws);
 
 // For ToClient sessions, we store incoming messages in a queue 
and have a separate
@@ -493,21 +491,23 @@ public:
 void handleRequest(HTTPServerRequest& request, HTTPServerResponse& 
response) override
 {
 assert(request.serverAddress().port() == MASTER_PORT_NUMBER);
-assert(request.getURI() == LOOLWSD::CHILD_URI);
+assert(request.getURI().find(LOOLWSD::CHILD_URI) == 0);
 
-const std::string thread_name = "prison_socket";
+std::string thread_name = "prison_ws_";
+try
+{
+const auto index = request.getURI().find_last_of('/');
+const auto id = request.getURI().substr(index + 1);
+
+thread_name += id;
 
 #ifdef __linux
-if (prctl(PR_SET_NAME, reinterpret_cast(thread_name.c_str()), 0, 0, 0) != 0)
-Log::error("Cannot set thread name to " + thread_name + ".");
+if (prctl(PR_SET_NAME, reinterpret_cast(thread_name.c_str()), 0, 0, 0) != 0)
+Log::error("Cannot set thread name to " + thread_name + ".");
 #endif
-Log::debug("Thread [" + thread_name + "] started.");
+Log::debug("Thread [" + thread_name + "] started.");
 
-try
-{
 auto ws = std::make_shared(request, response);
-
-const std::string id;
 auto session = std::make_shared(id, 
LOOLSession::Kind::ToPrisoner, ws);
 
 SocketProcessor(ws, response, [](const char* data, const 
int size, bool)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/README loolwsd/Util.cpp

[Ashod Nakashian]

 loolwsd/README   |2 ++
 loolwsd/Util.cpp |8 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

New commits:
commit 6f4336a1fc024c040cabd988479a21620ca8d41f
Author: Ashod Nakashian 
Date:   Sun Jan 10 22:13:32 2016 -0500

loolwsd: trap segv and bus when LOOL_DEBUG env is defined

Change-Id: I56b2c70cd910ff2628e020e494143b8f38c0bd36
Reviewed-on: https://gerrit.libreoffice.org/21332
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/README b/loolwsd/README
index cd6e8d8..c441356 100644
--- a/loolwsd/README
+++ b/loolwsd/README
@@ -141,6 +141,8 @@ sudo ln -s 
~/libreoffice/master/lool-child-roots/1046829984599121011/lo /lo
 
 Use the ps command to find out exactly the path to use.
 
+Set LOOL_DEBUG=1 to trap SIGSEGV and SEGBUS and prompt for debugger.
+
 Protocol description
 
 
diff --git a/loolwsd/Util.cpp b/loolwsd/Util.cpp
index ee13030..addef5b 100644
--- a/loolwsd/Util.cpp
+++ b/loolwsd/Util.cpp
@@ -433,8 +433,12 @@ namespace Util
 sigaction(SIGINT, , nullptr);
 sigaction(SIGQUIT, , nullptr);
 sigaction(SIGHUP, , nullptr);
-sigaction(SIGBUS, , nullptr);
-sigaction(SIGSEGV, , nullptr);
+
+if (getenv("LOOL_DEBUG"))
+{
+sigaction(SIGBUS, , nullptr);
+sigaction(SIGSEGV, , nullptr);
+}
 #endif
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97008] "Select all (ctrl+a)" does not work with a header and first paragraph of body text is hidden

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97008

Luke Picciau  changed:

   What|Removed |Added

 CC||luke.b.picc...@gmail.com

--- Comment #1 from Luke Picciau  ---
Appears to be working on libreoffice 5.0.3.2 on ubuntu 15.10.

What version of libreoffice and OS are you using?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96954] format cell number settings does not work with selected cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96954

futureproj...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95441] Crash when openning Multiple Sheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95441

futureproj...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from futureproj...@gmail.com ---
Can not confirm on Win10, LibreOffice Version: 5.0.4.2
Build ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78.

1. Opened a new spreadsheet.
2. Entered "abcd" into Sheet1.A1
3. Added Sheet2 and Sheet3
4. Ctrl+C on Sheet1.A1
5. Ctrl+LeftClick on Sheet2 and Sheet3
6. Ctrl+V on Sheet1.A1
7. Sheet1.A1 Sheet2.A1 and Sheet3.A1 are all filled with "abcd". Nothing seems
misplaced. Ctrl+X works the same way.

Is there anything we miss?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bin/update_pch bin/update_pch_autotune.sh bin/update_pch_bisect reportdesign/inc sal/inc sfx2/inc vcl/inc xmlsecurity/inc

[Ashod Nakashian]

 bin/update_pch  |   12 ++---
 bin/update_pch_autotune.sh  |   31 ++-
 bin/update_pch_bisect   |3 +-
 reportdesign/inc/RptDef.hxx |   14 --
 reportdesign/inc/pch/precompiled_rpt.hxx|4 ---
 reportdesign/inc/pch/precompiled_rptui.hxx  |7 +++--
 sal/inc/pch/precompiled_sal.hxx |   32 +---
 sfx2/inc/pch/precompiled_sfx.hxx|   16 +---
 vcl/inc/pch/precompiled_vcl.hxx |   16 ++--
 xmlsecurity/inc/pch/precompiled_xmlsecurity.hxx |3 --
 xmlsecurity/inc/pch/precompiled_xsec_fw.hxx |2 -
 xmlsecurity/inc/pch/precompiled_xsec_xmlsec.hxx |   17 +---
 12 files changed, 96 insertions(+), 61 deletions(-)

New commits:
commit 24ef3924d885a37fb15442208c027c77781175b8
Author: Ashod Nakashian 
Date:   Sun Jan 10 11:09:42 2016 -0500

PCH support on Linux

Fixes and improvements to support Precompiled Headers
on Linux.

Change-Id: I8145c146b0dba56c7a4d0fdf9c330164b67ada53
Reviewed-on: https://gerrit.libreoffice.org/21307
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 

diff --git a/bin/update_pch b/bin/update_pch
index a21b069..18eba85 100755
--- a/bin/update_pch
+++ b/bin/update_pch
@@ -88,7 +88,7 @@ DEFAULTS = \
 'reportdesign.rpt'  : ( 9, EXCLUDE, INCLUDE, INCLUDE), #   
9.4
 'reportdesign.rptui': ( 4, EXCLUDE, INCLUDE, INCLUDE), #  
13.1
 'reportdesign.rptxml'   : ( 2, EXCLUDE, EXCLUDE, INCLUDE), #   
7.6
-'sal.sal'   : ( 5, EXCLUDE, INCLUDE, INCLUDE), #   
4.2
+'sal.sal'   : ( 2, EXCLUDE, EXCLUDE, INCLUDE), #   
4.2
 'sc.sc' : (12, EXCLUDE, INCLUDE, INCLUDE), #  
92.6
 'sc.scfilt' : ( 4, EXCLUDE, EXCLUDE, INCLUDE), #  
39.9
 'sc.scui'   : ( 1, EXCLUDE, EXCLUDE, INCLUDE), #  
15.0
@@ -407,6 +407,7 @@ def filter_ignore(line, module):
 'vcl/jobset.hxx',
 'vcl/oldprintadaptor.hxx',
 'vcl/opengl/OpenGLContext.hxx',
+'vcl/opengl/OpenGLHelper.hxx',  # Conflicts with X header on *ix
 'vcl/print.hxx',
 'vcl/prntypes.hxx', # redefines Orientation from 
filter/jpeg/Exif.hxx
 'vcl/sysdata.hxx',
@@ -418,6 +419,11 @@ def filter_ignore(line, module):
 'XMLEventImportHelper.hxx', # NameMap redefined in 
XMLEventExport.hxx
 'xmloff/XMLEventExport.hxx', # enums redefined
 ]
+if module == 'xmlsecurity':
+ignore_list += [
+'xmlsec/crypto.h',
+'xmlsecurity/xmlsec-wrapper.h',
+]
 
 for i in ignore_list:
 if line.startswith(i):
@@ -737,7 +743,7 @@ def generate(includes, libname, filename, module):
 f.write('\n Generated on {} using:\n {}\n'.format(
 datetime.datetime.now().strftime("%Y-%m-%d %H:%M:%S"),
 make_command_line()))
-f.write('\n If after updating build fails, use the following command 
to locate conflicting headers:\n ./bin/update_pch_bisect {} "/opt/lo/bin/make 
{}.build" --find-conflicts\n*/\n'.format(
+f.write('\n If after updating build fails, use the following command 
to locate conflicting headers:\n ./bin/update_pch_bisect {} "make {}.build" 
--find-conflicts\n*/\n'.format(
 filename, module))
 
 # svx needs this (sendreportw32.cxx)
@@ -760,7 +766,7 @@ def generate(includes, libname, filename, module):
(module == 'xmlsecurity' and libname == 'xsec_xmlsec'):
 ado_define = """
 // Cleanup windows header macro pollution.
-#ifdef WNT
+#if defined(WNT) && defined(WINAPI)
 #   include 
 #   undef RGB
 #endif
diff --git a/bin/update_pch_autotune.sh b/bin/update_pch_autotune.sh
index 5513a69..b3a7378 100755
--- a/bin/update_pch_autotune.sh
+++ b/bin/update_pch_autotune.sh
@@ -28,16 +28,22 @@ else
 modules="$@"
 fi
 
+if [[ "$OSTYPE" == "cygwin" ]]; then
+MAKE=/opt/lo/bin/make
+else
+MAKE=make
+fi
+
 function build()
 {
 local START=$(date +%s.%N)
 
-/opt/lo/bin/make "$module.build" > /dev/null
+$MAKE -sr "$module" > /dev/null
 status=$?
 if [ $status -ne 0 ];
 then
 # Spurious failures happen.
-/opt/lo/bin/make "$module.build" > /dev/null
+$MAKE "$module.build" > /dev/null
 status=$?
 fi
 
@@ -48,7 +54,20 @@ function build()
 score="FAILED"
 if [ $status -eq 0 ];
 then
+# The total size of the object files.
 size="$(du -s workdir/CxxObject/$module/ | awk '{print $1}')"
+# Add the pch file size.
+filename_rel="workdir/PrecompiledHeader/nodebug/$(basename $header)*"
+

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |   13 --
 loolwsd/ChildProcessSession.hpp |2 -
 loolwsd/LOOLKit.cpp |   78 ++--
 3 files changed, 52 insertions(+), 41 deletions(-)

New commits:
commit 9523769e94de520da1c528fd7e56baef44ff519f
Author: Ashod Nakashian 
Date:   Fri Jan 8 22:31:34 2016 -0500

loolwsd: better callback handling and shutdown

Change-Id: Id9cc9f748d2dac3afb7d7d002062f8c423bce775
Reviewed-on: https://gerrit.libreoffice.org/21321
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index f3ef86d..0940509 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -38,7 +38,6 @@ using Poco::ProcessHandle;
 using Poco::StringTokenizer;
 using Poco::URI;
 
-Poco::NotificationQueue ChildProcessSession::_callbackQueue;
 Poco::Mutex ChildProcessSession::_mutex;
 
 ChildProcessSession::ChildProcessSession(const std::string& id,
@@ -69,20 +68,10 @@ ChildProcessSession::~ChildProcessSession()
 
 if (_loKitDocument != nullptr)
 {
-if (_multiView)
-   _loKitDocument->pClass->setView(_loKitDocument, _viewId);
-
-_loKitDocument->pClass->registerCallback(_loKitDocument, nullptr, 
nullptr);
-
-if (_multiView)
-_loKitDocument->pClass->destroyView(_loKitDocument, _viewId);
+_onUnload(_viewId);
 Log::debug("Destroy view [" + getName() + "]-> [" + 
std::to_string(_viewId) + "]");
 }
 
-if (LIBREOFFICEKIT_HAS(_loKit, registerCallback))
-_loKit->pClass->registerCallback(_loKit, nullptr, nullptr);
-
-_onUnload(_viewId);
 }
 
 bool ChildProcessSession::_handleInput(const char *buffer, int length)
diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index de3bc84..646e29c 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -50,8 +50,6 @@ public:
 
 LibreOfficeKitDocument *getLoKitDocument() const { return _loKitDocument; }
 
-static Poco::NotificationQueue _callbackQueue;
-
  protected:
 virtual bool loadDocument(const char *buffer, int length, 
Poco::StringTokenizer& tokens) override;
 
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index dfef497..1564616 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -94,7 +94,8 @@ class CallBackWorker: public Runnable
 {
 public:
 CallBackWorker(NotificationQueue& queue):
-_queue(queue)
+_queue(queue),
+_stop(false)
 {
 }
 
@@ -117,7 +118,7 @@ public:
 case LOK_CALLBACK_GRAPHIC_SELECTION:
 return std::string("LOK_CALLBACK_GRAPHIC_SELECTION");
 case LOK_CALLBACK_CELL_CURSOR:
-return std::string("LLOK_CALLBACK_CELL_CURSOR");
+return std::string("LOK_CALLBACK_CELL_CURSOR");
 case LOK_CALLBACK_CELL_FORMULA:
 return std::string("LOK_CALLBACK_CELL_FORMULA");
 case LOK_CALLBACK_MOUSE_POINTER:
@@ -269,7 +270,7 @@ public:
 #endif
 Log::debug("Thread [" + thread_name + "] started.");
 
-while (!TerminationFlag)
+while (!_stop && !TerminationFlag)
 {
 Notification::Ptr aNotification(_queue.waitDequeueNotification());
 if (!TerminationFlag && aNotification)
@@ -312,8 +313,14 @@ public:
 _queue.wakeUpAll();
 }
 
+void stop()
+{
+_stop = true;
+}
+
 private:
 NotificationQueue& _queue;
+bool _stop;
 static FastMutex   _mutex;
 };
 
@@ -429,6 +436,7 @@ public:
 queue.put("eof");
 queueHandlerThread.join();
 
+// We should probably send the Client some sensible message and 
reason.
 _session->sendTextFrame("eof");
 }
 catch (const Exception& exc)
@@ -481,16 +489,29 @@ public:
 _url(url),
 _loKitDocument(nullptr),
 _clientViews(0),
-_mainViewId(-1)
+_callbackWorker(_callbackQueue)
 {
 Log::info("Document ctor for url [" + _url + "] on child [" + _jailId +
   "] LOK_VIEW_CALLBACK=" + std::to_string(_multiView) + ".");
+
+_callbackThread.start(_callbackWorker);
 }
 
 ~Document()
 {
 Log::info("~Document dtor for url [" + _url + "] on child [" + _jailId 
+
-  "]. There are " + std::to_string(_mainViewId) + " views.");
+  "]. There are " + std::to_string(_clientViews) + " views.");
+
+// Wait for the callback worker to finish.
+_callbackWorker.stop();
+_callbackWorker.wakeUpAll();
+_callbackThread.join();
+
+// Flag all connections to stop.
+for (auto aIterator : _connections)
+{
+aIterator.second->stop();
+}
 
 // Destroy all connections and views.
 for (auto aIterator : 

[Libreoffice-commits] online.git: loolwsd/MasterProcessSession.cpp

[Ashod Nakashian]

 loolwsd/MasterProcessSession.cpp |   39 +++
 1 file changed, 15 insertions(+), 24 deletions(-)

New commits:
commit f613a5181e30c12505f8884d8055e6836aca2ef0
Author: Ashod Nakashian 
Date:   Sat Jan 9 12:00:59 2016 -0500

loolwsd: better handling of commandvalues

Change-Id: Ida459b42d9398baac85d1ecc19c19fb7f7ca90f0
Reviewed-on: https://gerrit.libreoffice.org/21322
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/MasterProcessSession.cpp b/loolwsd/MasterProcessSession.cpp
index 7b7dac2..abe0809 100644
--- a/loolwsd/MasterProcessSession.cpp
+++ b/loolwsd/MasterProcessSession.cpp
@@ -7,13 +7,10 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#include 
-
 #include 
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 
@@ -26,22 +23,12 @@
 
 using namespace LOOLProtocol;
 
-using Poco::Dynamic::Var;
-using Poco::Exception;
-using Poco::File;
-using Poco::IOException;
-using Poco::JSON::Object;
-using Poco::JSON::Parser;
 using Poco::Net::SocketAddress;
 using Poco::Net::WebSocket;
 using Poco::Path;
 using Poco::Process;
-using Poco::ProcessHandle;
-using Poco::Random;
 using Poco::StringTokenizer;
-using Poco::Thread;
 using Poco::UInt64;
-using Poco::URI;
 
 std::map MasterProcessSession::_childProcesses;
 
@@ -162,17 +149,21 @@ bool MasterProcessSession::_handleInput(const char 
*buffer, int length)
 }
 else if (tokens[0] == "commandvalues:")
 {
-std::string stringMsg(buffer, length);
-std::string stringJSON = 
stringMsg.substr(stringMsg.find_first_of("{"));
-Parser parser;
-Var result = parser.parse(stringJSON);
-Object::Ptr object = result.extract();
-std::string commandName = 
object->get("commandName").toString();
-if (commandName.find(".uno:CharFontName") != std::string::npos 
||
-commandName.find(".uno:StyleApply") != std::string::npos)
+const std::string stringMsg(buffer, length);
+const auto index = stringMsg.find_first_of("{");
+if (index != std::string::npos)
 {
-// other commands should not be cached
-peer->_tileCache->saveTextFile(std::string(buffer, 
length), "cmdValues" + commandName + ".txt");
+const std::string stringJSON = stringMsg.substr(index);
+Poco::JSON::Parser parser;
+const auto result = parser.parse(stringJSON);
+const auto object = 
result.extract();
+const std::string commandName = 
object->get("commandName").toString();
+if (commandName.find(".uno:CharFontName") != 
std::string::npos ||
+commandName.find(".uno:StyleApply") != 
std::string::npos)
+{
+// other commands should not be cached
+peer->_tileCache->saveTextFile(stringMsg, "cmdValues" 
+ commandName + ".txt");
+}
 }
 }
 else if (tokens[0] == "partpagerectangles:")
@@ -394,7 +385,7 @@ bool MasterProcessSession::loadDocument(const char* 
/*buffer*/, int /*length*/,
 
 try
 {
-URI aUri(_docURL);
+Poco::URI aUri(_docURL);
 
 // request new URL session
 const std::string aMessage = "request " + getId() + " " + _docURL + 
"\r\n";
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |   39 ++---
 loolwsd/ChildProcessSession.hpp |4 +-
 loolwsd/LOOLKit.cpp |   74 
 3 files changed, 59 insertions(+), 58 deletions(-)

New commits:
commit b3d06869f59d9a2ac4a5aae65e414c7ac7287cd8
Author: Ashod Nakashian 
Date:   Fri Jan 8 21:53:28 2016 -0500

loolwsd: centralized document loading in Document

Change-Id: I1ff7e0a53cc415958e46aea74c775d7f265b8b8e
Reviewed-on: https://gerrit.libreoffice.org/21319
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 66e6587..f3ef86d 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -46,7 +46,7 @@ ChildProcessSession::ChildProcessSession(const std::string& 
id,
  LibreOfficeKit *loKit,
  LibreOfficeKitDocument * 
loKitDocument,
  const std::string& jailId,
- 
std::function onLoad,
+ 
std::function onLoad,
  std::function onUnload) :
 LOOLSession(id, Kind::ToMaster, ws),
 _loKitDocument(loKitDocument),
@@ -230,15 +230,6 @@ bool ChildProcessSession::_handleInput(const char *buffer, 
int length)
 return true;
 }
 
-extern "C"
-{
-static void myCallback(int nType, const char* pPayload, void* pData)
-{
-auto pNotif = new CallBackNotification(nType, pPayload ? pPayload : 
"(nil)", pData);
-ChildProcessSession::_callbackQueue.enqueueNotification(pNotif);
-}
-}
-
 bool ChildProcessSession::loadDocument(const char * /*buffer*/, int 
/*length*/, StringTokenizer& tokens)
 {
 int part = -1;
@@ -256,29 +247,10 @@ bool ChildProcessSession::loadDocument(const char * 
/*buffer*/, int /*length*/,
 
 Poco::Mutex::ScopedLock lock(_mutex);
 
-if (_loKitDocument != nullptr)
-{
-Log::info("Loading view to document from URI: [" + _jailedFilePath + 
"].");
-
-_viewId = _loKitDocument->pClass->createView(_loKitDocument);
-}
-else
-{
-Log::info("Loading new document from URI: [" + _jailedFilePath + "].");
-
-if ( LIBREOFFICEKIT_HAS(_loKit, registerCallback))
-_loKit->pClass->registerCallback(_loKit, myCallback, this);
-
-if ((_loKitDocument = _loKit->pClass->documentLoad(_loKit, 
_jailedFilePath.c_str())) == nullptr)
-{
-Log::error("Failed to load: " + _jailedFilePath + ", error: " + 
_loKit->pClass->getError(_loKit));
-sendTextFrame("error: cmd=load kind=failed");
-return false;
-}
-}
+_loKitDocument = _onLoad(this, _jailedFilePath);
 
 if (_multiView)
-_loKitDocument->pClass->setView(_loKitDocument, _viewId);
+_viewId = _loKitDocument->pClass->getView(_loKitDocument);
 
 std::string renderingOptions;
 if (!_docOptions.empty())
@@ -297,14 +269,11 @@ bool ChildProcessSession::loadDocument(const char * 
/*buffer*/, int /*length*/,
 _loKitDocument->pClass->setPart(_loKitDocument, part);
 }
 
-_loKitDocument->pClass->registerCallback(_loKitDocument, myCallback, this);
 
-// Respond by the document status, whih has no arguments.
+// Respond by the document status, which has no arguments.
 if (!getStatus(nullptr, 0))
 return false;
 
-_onLoad(_loKitDocument, _viewId);
-
 return true;
 }
 
diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index e6b6600..de3bc84 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -34,7 +34,7 @@ public:
 LibreOfficeKit *loKit,
 LibreOfficeKitDocument * loKitDocument,
 const std::string& jailId,
-std::function 
onLoad,
+
std::function onLoad,
 std::function onUnload);
 virtual ~ChildProcessSession();
 
@@ -89,7 +89,7 @@ private:
 /// View ID, returned by createView() or 0 by default.
 int _viewId;
 int _clientPart;
-std::function _onLoad;
+std::function _onLoad;
 std::function _onUnload;
 };
 
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 990ed74..06a52d4 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -324,7 +324,7 @@ class Connection: public Runnable
 

[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp loolwsd/LOOLKit.cpp loolwsd/LOOLWSD.cpp

[Ashod Nakashian]

 loolwsd/LOOLBroker.cpp |7 ---
 loolwsd/LOOLKit.cpp|4 ++--
 loolwsd/LOOLWSD.cpp|2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)

New commits:
commit b2b983476c63ca5e77e45bae27ca544a0a29cf4f
Author: Ashod Nakashian 
Date:   Fri Jan 8 21:53:57 2016 -0500

loolwsd: more informative warnings

Change-Id: I8dba6d003bd5c0b3c16b3cd57c3737638ce56bd1
Reviewed-on: https://gerrit.libreoffice.org/21320
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index 96d2ea1..a63899b 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -486,7 +486,8 @@ static bool globalPreinit(const std::string )
 preInit = (LokHookPreInit *)dlsym(handle, "lok_preinit");
 if (!preInit)
 {
-Log::warn("Failed to find lok_preinit hook in " + 
std::string(LIB_SOFFICEAPP) + " library.");
+Log::warn("Note: No lok_preinit hook in " + 
std::string(LIB_SOFFICEAPP) +
+  " library. Cannot fork, will execv instead.");
 return false;
 }
 
@@ -711,7 +712,7 @@ int main(int argc, char** argv)
 }
 catch (const Poco::NotFoundException& exc)
 {
-Log::error(std::string("Exception: ") + exc.what());
+Log::warn("Note: LD_BIND_NOW is not set.");
 }
 
 try
@@ -720,7 +721,7 @@ int main(int argc, char** argv)
 }
 catch (const Poco::NotFoundException& exc)
 {
-Log::error(std::string("Exception: ") + exc.what());
+Log::warn("Note: LOK_VIEW_CALLBACK is not set.");
 }
 
 // The loolkit binary must be in our directory.
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 06a52d4..dfef497 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -915,7 +915,7 @@ int main(int argc, char** argv)
 }
 catch (const Poco::NotFoundException& exc)
 {
-Log::error(std::string("Exception: ") + exc.what());
+Log::warn("Note: LD_BIND_NOW is not set.");
 }
 
 try
@@ -924,7 +924,7 @@ int main(int argc, char** argv)
 }
 catch (const Poco::NotFoundException& exc)
 {
-Log::error(std::string("Exception: ") + exc.what());
+Log::warn("Note: LOK_VIEW_CALLBACK is not set.");
 }
 
 lokit_main(loSubPath, jailId, pipe);
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index dbc4184..1d1a17b 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -823,7 +823,7 @@ int LOOLWSD::main(const std::vector& /*args*/)
 Log::initialize("wsd");
 
 Poco::Environment::set("LD_BIND_NOW", "1");
-Poco::Environment::set("LOK_VIEW_CALLBACK", "1");
+//Poco::Environment::set("LOK_VIEW_CALLBACK", "1");
 
 #ifdef __linux
 char *locale = setlocale(LC_ALL, nullptr);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |   56 ++--
 loolwsd/ChildProcessSession.hpp |8 +
 loolwsd/LOOLKit.cpp |   19 +++--
 3 files changed, 49 insertions(+), 34 deletions(-)

New commits:
commit 55f857e17cf8a7989a5b36d874d3c8cb43d6ebfd
Author: Ashod Nakashian 
Date:   Sun Jan 10 22:52:00 2016 -0500

loolwsd: Poco::Mutex -> std::mutex and callback locks on session

Change-Id: I9c7d16352110566e5fc31c280784ded30cd3a9be
Reviewed-on: https://gerrit.libreoffice.org/21333
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 1fb17ca..7db9964 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -38,7 +38,7 @@ using Poco::ProcessHandle;
 using Poco::StringTokenizer;
 using Poco::URI;
 
-Poco::Mutex ChildProcessSession::_mutex;
+std::mutex ChildProcessSession::_mutex;
 
 ChildProcessSession::ChildProcessSession(const std::string& id,
  std::shared_ptr 
ws,
@@ -64,7 +64,7 @@ ChildProcessSession::~ChildProcessSession()
 {
 Log::info("~ChildProcessSession dtor [" + getName() + "].");
 
-Poco::Mutex::ScopedLock lock(_mutex);
+std::unique_lock lock(_mutex);
 
 if (_multiView)
 _loKitDocument->pClass->setView(_loKitDocument, _viewId);
@@ -146,7 +146,7 @@ bool ChildProcessSession::_handleInput(const char *buffer, 
int length)
tokens[0] == "saveas");
 
 {
-Poco::Mutex::ScopedLock lock(_mutex);
+std::unique_lock lock(_mutex);
 
 if (_multiView)
 _loKitDocument->pClass->setView(_loKitDocument, _viewId);
@@ -232,10 +232,10 @@ bool ChildProcessSession::loadDocument(const char * 
/*buffer*/, int /*length*/,
 assert(!_docURL.empty());
 assert(!_jailedFilePath.empty());
 
-Poco::Mutex::ScopedLock lock(_mutex);
-
 _loKitDocument = _onLoad(getId(), _jailedFilePath);
 
+std::unique_lock lock(_mutex);
+
 if (_multiView)
 _viewId = _loKitDocument->pClass->getView(_loKitDocument);
 
@@ -257,7 +257,7 @@ bool ChildProcessSession::loadDocument(const char * 
/*buffer*/, int /*length*/,
 }
 
 // Respond by the document status, which has no arguments.
-if (!getStatus(nullptr, 0))
+if (!getStatus_Impl(nullptr, 0))
 return false;
 
 Log::info("Loaded session " + getId());
@@ -275,7 +275,7 @@ void ChildProcessSession::sendFontRendering(const char* 
/*buffer*/, int /*length
 return;
 }
 
-Poco::Mutex::ScopedLock lock(_mutex);
+std::unique_lock lock(_mutex);
 
 if (_multiView)
_loKitDocument->pClass->setView(_loKitDocument, _viewId);
@@ -306,18 +306,24 @@ void ChildProcessSession::sendFontRendering(const char* 
/*buffer*/, int /*length
 sendBinaryFrame(output.data(), output.size());
 }
 
-bool ChildProcessSession::getStatus(const char* /*buffer*/, int /*length*/)
+bool ChildProcessSession::getStatus(const char* buffer, int length)
 {
-Poco::Mutex::ScopedLock lock(_mutex);
+std::unique_lock lock(_mutex);
 
 if (_multiView)
 _loKitDocument->pClass->setView(_loKitDocument, _viewId);
 
+return getStatus_Impl(buffer, length);
+}
+
+bool ChildProcessSession::getStatus_Impl(const char* /*buffer*/, int 
/*length*/)
+{
 std::string status = "status: " + 
LOKitHelper::documentStatus(_loKitDocument);
 StringTokenizer tokens(status, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
 if (!getTokenString(tokens[1], "type", _docType))
 {
 Log::error("failed to get document type from status [" + status + 
"].");
+return false;
 }
 
 sendTextFrame(status);
@@ -334,7 +340,7 @@ bool ChildProcessSession::getCommandValues(const char* 
/*buffer*/, int /*length*
 return false;
 }
 
-Poco::Mutex::ScopedLock lock(_mutex);
+std::unique_lock lock(_mutex);
 
 if (_multiView)
 _loKitDocument->pClass->setView(_loKitDocument, _viewId);
@@ -345,7 +351,7 @@ bool ChildProcessSession::getCommandValues(const char* 
/*buffer*/, int /*length*
 
 bool ChildProcessSession::getPartPageRectangles(const char* /*buffer*/, int 
/*length*/)
 {
-Poco::Mutex::ScopedLock lock(_mutex);
+std::unique_lock lock(_mutex);
 
 if (_multiView)
 _loKitDocument->pClass->setView(_loKitDocument, _viewId);
@@ -383,7 +389,7 @@ void ChildProcessSession::sendTile(const char* /*buffer*/, 
int /*length*/, Strin
 return;
 }
 
-Poco::Mutex::ScopedLock lock(_mutex);
+std::unique_lock lock(_mutex);
 
 if (_multiView)
 _loKitDocument->pClass->setView(_loKitDocument, _viewId);
@@ -432,7 +438,7 @@ bool ChildProcessSession::clientZoom(const char* 
/*buffer*/, int /*length*/, Str
 return false;
 }
 
-Poco::Mutex::ScopedLock 

[Libreoffice-commits] core.git: vcl/generic

[Chris Sherlock]

 vcl/generic/fontmanager/adobe_encoding_table.hxx | 1078 +++
 vcl/generic/fontmanager/adobeenc.tab | 1078 ---
 vcl/generic/fontmanager/fontmanager.cxx  |2 
 3 files changed, 1079 insertions(+), 1079 deletions(-)

New commits:
commit 6c1a17934791b1ca07f932ad3c83465fa2b39a5a
Author: Chris Sherlock 
Date:   Mon Jan 11 13:47:33 2016 +1100

vcl: rename adobeenc.tab to adobe_encoding_table.hxx

Change-Id: Id7dbcd97acaf6a7deb13de2582c7a3515cedfac1
Reviewed-on: https://gerrit.libreoffice.org/21313
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/vcl/generic/fontmanager/adobeenc.tab 
b/vcl/generic/fontmanager/adobe_encoding_table.hxx
similarity index 100%
rename from vcl/generic/fontmanager/adobeenc.tab
rename to vcl/generic/fontmanager/adobe_encoding_table.hxx
diff --git a/vcl/generic/fontmanager/fontmanager.cxx 
b/vcl/generic/fontmanager/fontmanager.cxx
index 4fe08f1..6145f54 100644
--- a/vcl/generic/fontmanager/fontmanager.cxx
+++ b/vcl/generic/fontmanager/fontmanager.cxx
@@ -64,7 +64,7 @@
 #include 
 #include 
 
-#include "adobeenc.tab"
+#include "adobe_encoding_table.hxx"
 
 #ifdef CALLGRIND_COMPILE
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.hpp loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.hpp |   10 +++---
 loolwsd/LOOLKit.cpp |9 ++---
 2 files changed, 9 insertions(+), 10 deletions(-)

New commits:
commit 2e34e2c8cf3f72fba530718c3f9e02c0e4941f63
Author: Ashod Nakashian 
Date:   Fri Jan 8 20:45:51 2016 -0500

loolwsd: public -> private

Change-Id: Ibd662a17389d4a77bc31b84a50bc7a2e3b48bde0
Reviewed-on: https://gerrit.libreoffice.org/21318
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index b895296..e6b6600 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -46,10 +46,11 @@ public:
 
 int getViewId() const  { return _viewId; }
 
-LibreOfficeKitDocument *_loKitDocument;
-std::string _docType;
+const std::string& getDocType() const { return _docType; }
+
+LibreOfficeKitDocument *getLoKitDocument() const { return _loKitDocument; }
+
 static Poco::NotificationQueue _callbackQueue;
-static Poco::Mutex _mutex;
 
  protected:
 virtual bool loadDocument(const char *buffer, int length, 
Poco::StringTokenizer& tokens) override;
@@ -79,6 +80,9 @@ private:
 virtual bool _handleInput(const char *buffer, int length) override;
 
 private:
+LibreOfficeKitDocument *_loKitDocument;
+std::string _docType;
+static Poco::Mutex _mutex;
 const bool _multiView;
 LibreOfficeKit *_loKit;
 const std::string _jailId;
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index d2f2141..990ed74 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -157,9 +157,9 @@ public:
 {
 case LOK_CALLBACK_INVALIDATE_TILES:
 {
-int curPart = 
srv->_loKitDocument->pClass->getPart(srv->_loKitDocument);
+int curPart = 
srv->getLoKitDocument()->pClass->getPart(srv->getLoKitDocument());
 srv->sendTextFrame("curpart: part=" + std::to_string(curPart));
-if (srv->_docType == "text")
+if (srv->getDocType() == "text")
 {
 curPart = 0;
 }
@@ -346,11 +346,6 @@ public:
 const std::string& getSessionId() const { return _sessionId; }
 std::shared_ptr getWebSocket() const { return _ws; }
 
-LibreOfficeKitDocument * getLOKitDocument()
-{
-return (_session ? _session->_loKitDocument : nullptr);
-}
-
 void start()
 {
 _thread.start(*this);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |   91 
 loolwsd/ChildProcessSession.hpp |7 +--
 loolwsd/LOOLKit.cpp |   21 ++---
 3 files changed, 81 insertions(+), 38 deletions(-)

New commits:
commit efb1fecbf14559a60fe0d4d8c9eac2fca9637699
Author: Ashod Nakashian 
Date:   Fri Jan 8 19:58:50 2016 -0500

loolwsd: control multiview api via env

Change-Id: Ic385188a4d57e10a260827709d4666857fd8aae5
Reviewed-on: https://gerrit.libreoffice.org/21317
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 7248470..66e6587 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -50,6 +50,7 @@ ChildProcessSession::ChildProcessSession(const std::string& 
id,
  std::function onUnload) :
 LOOLSession(id, Kind::ToMaster, ws),
 _loKitDocument(loKitDocument),
+_multiView(getenv("LOK_VIEW_CALLBACK")),
 _loKit(loKit),
 _jailId(jailId),
 _viewId(0),
@@ -68,11 +69,13 @@ ChildProcessSession::~ChildProcessSession()
 
 if (_loKitDocument != nullptr)
 {
-_loKitDocument->pClass->setView(_loKitDocument, _viewId);
+if (_multiView)
+   _loKitDocument->pClass->setView(_loKitDocument, _viewId);
 
 _loKitDocument->pClass->registerCallback(_loKitDocument, nullptr, 
nullptr);
 
-_loKitDocument->pClass->destroyView(_loKitDocument, _viewId);
+if (_multiView)
+_loKitDocument->pClass->destroyView(_loKitDocument, _viewId);
 Log::debug("Destroy view [" + getName() + "]-> [" + 
std::to_string(_viewId) + "]");
 }
 
@@ -158,7 +161,9 @@ bool ChildProcessSession::_handleInput(const char *buffer, 
int length)
 {
 Poco::Mutex::ScopedLock lock(_mutex);
 
-_loKitDocument->pClass->setView(_loKitDocument, _viewId);
+if (_multiView)
+_loKitDocument->pClass->setView(_loKitDocument, _viewId);
+
 if (_docType != "text" && 
_loKitDocument->pClass->getPart(_loKitDocument) != _clientPart)
 {
 _loKitDocument->pClass->setPart(_loKitDocument, _clientPart);
@@ -234,7 +239,7 @@ extern "C"
 }
 }
 
-bool ChildProcessSession::loadDocument(const char *buffer, int length, 
StringTokenizer& tokens)
+bool ChildProcessSession::loadDocument(const char * /*buffer*/, int 
/*length*/, StringTokenizer& tokens)
 {
 int part = -1;
 if (tokens.count() < 2)
@@ -272,7 +277,8 @@ bool ChildProcessSession::loadDocument(const char *buffer, 
int length, StringTok
 }
 }
 
-_loKitDocument->pClass->setView(_loKitDocument, _viewId);
+if (_multiView)
+_loKitDocument->pClass->setView(_loKitDocument, _viewId);
 
 std::string renderingOptions;
 if (!_docOptions.empty())
@@ -293,7 +299,8 @@ bool ChildProcessSession::loadDocument(const char *buffer, 
int length, StringTok
 
 _loKitDocument->pClass->registerCallback(_loKitDocument, myCallback, this);
 
-if (!getStatus(buffer, length))
+// Respond by the document status, whih has no arguments.
+if (!getStatus(nullptr, 0))
 return false;
 
 _onLoad(_loKitDocument, _viewId);
@@ -304,8 +311,6 @@ bool ChildProcessSession::loadDocument(const char *buffer, 
int length, StringTok
 void ChildProcessSession::sendFontRendering(const char* /*buffer*/, int 
/*length*/, StringTokenizer& tokens)
 {
 std::string font, decodedFont;
-int width, height;
-unsigned char *pixmap;
 
 if (tokens.count() < 2 ||
 !getTokenString(tokens[1], "font", font))
@@ -316,7 +321,8 @@ void ChildProcessSession::sendFontRendering(const char* 
/*buffer*/, int /*length
 
 Poco::Mutex::ScopedLock lock(_mutex);
 
-   _loKitDocument->pClass->setView(_loKitDocument, _viewId);
+if (_multiView)
+   _loKitDocument->pClass->setView(_loKitDocument, _viewId);
 
 URI::decode(font, decodedFont);
 std::string response = "renderfont: " + Poco::cat(std::string(" "), 
tokens.begin() + 1, tokens.end()) + "\n";
@@ -326,7 +332,8 @@ void ChildProcessSession::sendFontRendering(const char* 
/*buffer*/, int /*length
 std::memcpy(output.data(), response.data(), response.size());
 
 Poco::Timestamp timestamp;
-pixmap = _loKitDocument->pClass->renderFont(_loKitDocument, 
decodedFont.c_str(), , );
+int width, height;
+unsigned char *pixmap = _loKitDocument->pClass->renderFont(_loKitDocument, 
decodedFont.c_str(), , );
 Log::trace("renderFont [" + font + "] rendered in " + 
std::to_string(timestamp.elapsed()/1000.) + "ms");
 
 if (pixmap != nullptr)
@@ -347,13 +354,16 @@ bool ChildProcessSession::getStatus(const char* 
/*buffer*/, int /*length*/)
 {
 Poco::Mutex::ScopedLock lock(_mutex);
 
-_loKitDocument->pClass->setView(_loKitDocument, _viewId);
+

[Libreoffice-commits] online.git: loolwsd/Common.hpp loolwsd/LOOLBroker.cpp loolwsd/LOOLKit.cpp loolwsd/LOOLWSD.cpp loolwsd/LOOLWSD.hpp loolwsd/Util.cpp loolwsd/Util.hpp

[Ashod Nakashian]

 loolwsd/Common.hpp |4 
 loolwsd/LOOLBroker.cpp |4 +---
 loolwsd/LOOLKit.cpp|   29 +
 loolwsd/LOOLWSD.cpp|   26 ++
 loolwsd/LOOLWSD.hpp|3 ---
 loolwsd/Util.cpp   |   39 +++
 loolwsd/Util.hpp   |   10 ++
 7 files changed, 53 insertions(+), 62 deletions(-)

New commits:
commit 5bf75f56ca88f96d9d8a47c788207cb2a742a556
Author: Ashod Nakashian 
Date:   Sat Jan 9 13:51:55 2016 -0500

loolwsd: centralized signal handling and eased debugging

Change-Id: Ifdb3e2bca540bec3c6dea1ab24173c8ea0267706
Reviewed-on: https://gerrit.libreoffice.org/21325
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/Common.hpp b/loolwsd/Common.hpp
index 1be1a89..10c3d7e 100644
--- a/loolwsd/Common.hpp
+++ b/loolwsd/Common.hpp
@@ -13,7 +13,6 @@
 
 #include 
 
-enum class LOOLState { LOOL_STARTING, LOOL_STOPPING, LOOL_ABNORMAL };
 constexpr int DEFAULT_CLIENT_PORT_NUMBER = 9980;
 constexpr int MASTER_PORT_NUMBER = 9981;
 constexpr int INTERVAL_PROBES = 10;
@@ -25,8 +24,5 @@ constexpr int PIPE_BUFFER = 1024;
 
 static const std::string JailedDocumentRoot = "/user/docs/";
 
-// Flag to stop pump loops.
-static volatile bool TerminationFlag = false;
-
 #endif
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index a63899b..515aa90 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -612,9 +612,7 @@ int main(int argc, char** argv)
 // Initialization
 Log::initialize("brk");
 
-#ifdef __linux
-setSignals(false);
-#endif
+Util::setSignals(false);
 
 std::string childRoot;
 std::string jailId;
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 7c9f86e..0d806eb 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -60,33 +60,6 @@ using Poco::FastMutex;
 
 const std::string CHILD_URI = "/loolws/child/";
 const std::string LOKIT_BROKER = "/tmp/loolbroker.fifo";
-static LOOLState TerminationState;
-
-namespace
-{
-void handleSignal(int aSignal)
-{
-Log::info() << "Signal received: " << strsignal(aSignal) << Log::end;
-TerminationState = ( aSignal == SIGTERM ? LOOLState::LOOL_ABNORMAL : 
LOOLState::LOOL_STOPPING );
-TerminationFlag = true;
-}
-
-void setSignals(bool isIgnored)
-{
-#ifdef __linux
-struct sigaction aSigAction;
-
-sigemptyset(_mask);
-aSigAction.sa_flags = 0;
-aSigAction.sa_handler = (isIgnored ? SIG_IGN : handleSignal);
-
-sigaction(SIGTERM, , nullptr);
-sigaction(SIGINT, , nullptr);
-sigaction(SIGQUIT, , nullptr);
-sigaction(SIGHUP, , nullptr);
-#endif
-}
-}
 
 // This thread handles callbacks from the
 // lokit instance.
@@ -714,7 +687,7 @@ void lokit_main(const std::string , const 
std::string& jailId, const s
 #ifdef __linux
 if (prctl(PR_SET_NAME, reinterpret_cast(process_name.c_str()), 0, 0, 0) != 0)
 Log::error("Cannot set process name to " + process_name + ".");
-setSignals(false);
+Util::setSignals(false);
 #endif
 Log::debug("Process [" + process_name + "] started.");
 
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 1d1a17b..71e9915 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -663,28 +663,6 @@ LOOLWSD::~LOOLWSD()
 {
 }
 
-void LOOLWSD::handleSignal(int aSignal)
-{
-Log::info() << "Signal received: " << strsignal(aSignal) << Log::end;
-TerminationFlag = true;
-}
-
-void LOOLWSD::setSignals(bool isIgnored)
-{
-#ifdef __linux
-struct sigaction aSigAction;
-
-sigemptyset(_mask);
-aSigAction.sa_flags = 0;
-aSigAction.sa_handler = (isIgnored ? SIG_IGN : handleSignal);
-
-sigaction(SIGTERM, , nullptr);
-sigaction(SIGINT, , nullptr);
-sigaction(SIGQUIT, , nullptr);
-sigaction(SIGHUP, , nullptr);
-#endif
-}
-
 void LOOLWSD::initialize(Application& self)
 {
 ServerApplication::initialize(self);
@@ -829,10 +807,10 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 char *locale = setlocale(LC_ALL, nullptr);
 if (locale == nullptr || std::strcmp(locale, "C") == 0)
 setlocale(LC_ALL, "en_US.utf8");
-
-setSignals(false);
 #endif
 
+Util::setSignals(false);
+
 if (access(cache.c_str(), R_OK | W_OK | X_OK) != 0)
 {
 Log::error("Unable to access cache [" + cache +
diff --git a/loolwsd/LOOLWSD.hpp b/loolwsd/LOOLWSD.hpp
index 4108775..50bde75 100644
--- a/loolwsd/LOOLWSD.hpp
+++ b/loolwsd/LOOLWSD.hpp
@@ -176,9 +176,6 @@ public:
 }
 
 protected:
-static void setSignals(bool bIgnore);
-static void handleSignal(int nSignal);
-
 void initialize(Poco::Util::Application& self) override;
 void uninitialize() override;
 void defineOptions(Poco::Util::OptionSet& options) override;
diff --git 

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLKit.cpp loolwsd/Util.cpp loolwsd/Util.hpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |4 -
 loolwsd/ChildProcessSession.hpp |   21 --
 loolwsd/LOOLKit.cpp |  136 
 loolwsd/Util.cpp|9 ++
 loolwsd/Util.hpp|2 
 5 files changed, 97 insertions(+), 75 deletions(-)

New commits:
commit 9b5a94b018ffef83bc064b1c0722c5366478a49f
Author: Ashod Nakashian 
Date:   Sat Jan 9 15:46:08 2016 -0500

loolwsd: callbacks use shared_ptr to avoid race with destructors

Change-Id: I19e06850764c6dbd1cfcc15dcd9a64029ab4fc0c
Reviewed-on: https://gerrit.libreoffice.org/21326
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index b2cc4c3..4fa08a9 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -45,7 +45,7 @@ ChildProcessSession::ChildProcessSession(const std::string& 
id,
  LibreOfficeKit *loKit,
  LibreOfficeKitDocument * 
loKitDocument,
  const std::string& jailId,
- 
std::function onLoad,
+ 
std::function 
onLoad,
  std::function onUnload) :
 LOOLSession(id, Kind::ToMaster, ws),
 _loKitDocument(loKitDocument),
@@ -231,7 +231,7 @@ bool ChildProcessSession::loadDocument(const char * 
/*buffer*/, int /*length*/,
 
 Poco::Mutex::ScopedLock lock(_mutex);
 
-_loKitDocument = _onLoad(this, _jailedFilePath);
+_loKitDocument = _onLoad(getId(), _jailedFilePath);
 
 if (_multiView)
 _viewId = _loKitDocument->pClass->getView(_loKitDocument);
diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index 646e29c..9b5dcfa 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -34,7 +34,7 @@ public:
 LibreOfficeKit *loKit,
 LibreOfficeKitDocument * loKitDocument,
 const std::string& jailId,
-
std::function onLoad,
+std::function onLoad,
 std::function onUnload);
 virtual ~ChildProcessSession();
 
@@ -87,27 +87,10 @@ private:
 /// View ID, returned by createView() or 0 by default.
 int _viewId;
 int _clientPart;
-std::function _onLoad;
+std::function _onLoad;
 std::function _onUnload;
 };
 
-class CallBackNotification: public Poco::Notification
-{
-public:
-   typedef Poco::AutoPtr Ptr;
-
-CallBackNotification(const int nType, const std::string& rPayload, void* 
pSession)
-  : m_nType(nType),
-m_aPayload(rPayload),
-m_pSession(pSession)
-{
-}
-
-const int m_nType;
-const std::string m_aPayload;
-void* m_pSession;
-};
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 0d806eb..0dc3fd6 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -61,6 +61,23 @@ using Poco::FastMutex;
 const std::string CHILD_URI = "/loolws/child/";
 const std::string LOKIT_BROKER = "/tmp/loolbroker.fifo";
 
+class CallBackNotification: public Poco::Notification
+{
+public:
+typedef Poco::AutoPtr Ptr;
+
+CallBackNotification(const int nType, const std::string& rPayload, 
std::shared_ptr& pSession)
+  : m_nType(nType),
+m_aPayload(rPayload),
+m_pSession(pSession)
+{
+}
+
+const int m_nType;
+const std::string m_aPayload;
+const std::shared_ptr m_pSession;
+};
+
 // This thread handles callbacks from the
 // lokit instance.
 class CallBackWorker: public Runnable
@@ -117,23 +134,22 @@ public:
 case LOK_CALLBACK_SET_PART:
 return std::string("LOK_CALLBACK_SET_PART");
 }
-return std::string("");
+return std::to_string(nType);
 }
 
-void callback(const int nType, const std::string& rPayload, void* pData)
+void callback(const int nType, const std::string& rPayload, 
std::shared_ptr pSession)
 {
-ChildProcessSession *srv = reinterpret_cast(pData);
-Log::trace() << "Callback [" << srv->getViewId() << "] "
+Log::trace() << "Callback [" << pSession->getViewId() << "] "
  << callbackTypeToString(nType)
  << 

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |7 +--
 loolwsd/ChildProcessSession.hpp |4 ++--
 loolwsd/LOOLKit.cpp |   26 --
 3 files changed, 27 insertions(+), 10 deletions(-)

New commits:
commit 96c7fdd0f8427f70d9ab04128a5c667868bd0bdb
Author: Ashod Nakashian 
Date:   Sun Jan 10 10:33:58 2016 -0500

loolwsd: onUnload takes Session ID

Change-Id: I63dd21441a11981f09f6b4c2d36560094fc81f1f
Reviewed-on: https://gerrit.libreoffice.org/21327
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 4fa08a9..9424769 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -46,7 +46,7 @@ ChildProcessSession::ChildProcessSession(const std::string& 
id,
  LibreOfficeKitDocument * 
loKitDocument,
  const std::string& jailId,
  
std::function 
onLoad,
- std::function onUnload) :
+ std::function onUnload) :
 LOOLSession(id, Kind::ToMaster, ws),
 _loKitDocument(loKitDocument),
 _multiView(getenv("LOK_VIEW_CALLBACK")),
@@ -66,7 +66,10 @@ ChildProcessSession::~ChildProcessSession()
 
 Poco::Mutex::ScopedLock lock(_mutex);
 
-_onUnload(_viewId);
+if (_multiView)
+_loKitDocument->pClass->setView(_loKitDocument, _viewId);
+
+_onUnload(getId());
 }
 
 bool ChildProcessSession::_handleInput(const char *buffer, int length)
diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index 9b5dcfa..4313d81 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -35,7 +35,7 @@ public:
 LibreOfficeKitDocument * loKitDocument,
 const std::string& jailId,
 std::function onLoad,
-std::function onUnload);
+std::function onUnload);
 virtual ~ChildProcessSession();
 
 virtual bool getStatus(const char *buffer, int length) override;
@@ -88,7 +88,7 @@ private:
 int _viewId;
 int _clientPart;
 std::function _onLoad;
-std::function _onUnload;
+std::function _onUnload;
 };
 
 #endif
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 0dc3fd6..35fc483 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -317,7 +317,7 @@ public:
 Connection(LibreOfficeKit *loKit, LibreOfficeKitDocument *loKitDocument,
const std::string& jailId, const std::string& sessionId,
std::function onLoad,
-   std::function onUnload) :
+   std::function onUnload) :
 _loKit(loKit),
 _loKitDocument(loKitDocument),
 _jailId(jailId),
@@ -452,7 +452,7 @@ private:
 std::shared_ptr _session;
 volatile bool _stop;
 std::function _onLoad;
-std::function _onUnload;
+std::function _onUnload;
 std::shared_ptr _ws;
 };
 
@@ -552,7 +552,7 @@ public:
 
 auto thread = std::make_shared(_loKit, _loKitDocument, 
_jailId, sessionId,
[this](const std::string& 
id, const std::string& uri) { return onLoad(id, uri); },
-   [this](const int viewId) { 
onUnload(viewId); });
+   [this](const std::string& 
id) { onUnload(id); });
 
 const auto aInserted = _connections.emplace(intSessionId, thread);
 
@@ -657,16 +657,30 @@ private:
 return _loKitDocument;
 }
 
-void onUnload(const int viewId)
+void onUnload(const std::string& sessionId)
 {
+std::unique_lock lock(_mutex);
+
+Log::info("Session " + sessionId + " is unloading. " + 
std::to_string(_clientViews - 1) + " views left.");
+
+const unsigned intSessionId = Util::decodeId(sessionId);
+const auto it = _connections.find(intSessionId);
+if (it == _connections.end() || !it->second)
+{
+Log::error("Cannot find session [" + sessionId + "] which decoded 
to " + std::to_string(intSessionId));
+return;
+}
+
+--_clientViews;
+
 if (_multiView && _loKitDocument)
 {

Re: Remove ActiveX from LibreOffice

[Chris Sherlock]

> On 11 Jan 2016, at 10:41 AM, Bryan Quigley  wrote:
> 
> To look at this issue from another POV.. If someone showed up today
> with an issue with a LO ActiveX control embedded in their application
> that didn't work - what would our response be?  It's an outdated
> technology that we're not investing in.
> 

It probably shows a lack of adoption, but it doesn’t look like anyone actually 
has reported issues with it...

>> My position on ActiveX is to leave it (lest we break applications in the
>> wild,) and to *announce its deprecation* with two goals: first, solicit the
>> feedback of LO ActiveX consumers and, if so inclined to continue using it,
>> help in its support. And second, to flag a date in the future when ActiveX
>> will be completely removed from LO codebase, pending sufficient reason and
>> support by its consumers.
> 
> I'm happy with this.  I'd say a quicker timeframe is fine though.
> From the announce, if no one has found an application that uses
> LO-embedded ActiveX remove it in a month or something.  I expect that
> if there are some users they might not hear until the install the
> version without it regardless of what we do.

Perhaps it should be announced in the release notes, with an actual version 
where it will be removed. 

Chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/generic vcl/headless vcl/inc vcl/Library_vcl.mk vcl/unx

[Chris Sherlock]

 vcl/Library_vcl.mk|   18 
 vcl/generic/print/bitmap_gfx.cxx  |  690 --
 vcl/generic/print/common_gfx.cxx  | 1235 --
 vcl/generic/print/genprnpsp.cxx   | 1367 -
 vcl/generic/print/genpspgraphics.cxx  | 1382 --
 vcl/generic/print/glyphset.cxx|  847 --
 vcl/generic/print/glyphset.hxx|  125 --
 vcl/generic/print/printerjob.cxx  | 1016 --
 vcl/generic/print/prtsetup.cxx|  530 ---
 vcl/generic/print/prtsetup.hxx|  135 --
 vcl/generic/print/psheader.ps |  363 ---
 vcl/generic/print/psputil.cxx |  249 -
 vcl/generic/print/psputil.hxx |   70 -
 vcl/generic/print/text_gfx.cxx|  728 ---
 vcl/headless/svpprn.cxx   |2 
 vcl/inc/generic/geninst.h |2 
 vcl/inc/generic/genprn.h  |   96 --
 vcl/inc/generic/genpspgraphics.h  |  221 
 vcl/inc/generic/printergfx.hxx|  399 
 vcl/inc/generic/printerjob.hxx|  130 --
 vcl/inc/headless/svpinst.hxx  |2 
 vcl/inc/headless/svpprn.hxx   |6 
 vcl/inc/unx/genprn.h  |   96 ++
 vcl/inc/unx/genpspgraphics.h  |  221 
 vcl/inc/unx/gtk/gtkprn.hxx|2 
 vcl/inc/unx/printergfx.hxx|  399 
 vcl/inc/unx/printerjob.hxx|  130 ++
 vcl/unx/generic/app/salinst.cxx   |4 
 vcl/unx/generic/fontmanager/fontsubst.cxx |4 
 vcl/unx/generic/gdi/cairotextrender.cxx   |4 
 vcl/unx/generic/gdi/salgdi.cxx|2 
 vcl/unx/generic/gdi/salgdi2.cxx   |2 
 vcl/unx/generic/gdi/salgdi3.cxx   |4 
 vcl/unx/generic/print/bitmap_gfx.cxx  |  690 ++
 vcl/unx/generic/print/common_gfx.cxx  | 1235 ++
 vcl/unx/generic/print/genprnpsp.cxx   | 1367 +
 vcl/unx/generic/print/genpspgraphics.cxx  | 1382 ++
 vcl/unx/generic/print/glyphset.cxx|  847 ++
 vcl/unx/generic/print/glyphset.hxx|  125 ++
 vcl/unx/generic/print/printerjob.cxx  | 1016 ++
 vcl/unx/generic/print/prtsetup.cxx|  530 +++
 vcl/unx/generic/print/prtsetup.hxx|  135 ++
 vcl/unx/generic/print/psheader.ps |  363 +++
 vcl/unx/generic/print/psputil.cxx |  249 +
 vcl/unx/generic/print/psputil.hxx |   70 +
 vcl/unx/generic/print/text_gfx.cxx|  728 +++
 vcl/unx/generic/window/salframe.cxx   |2 
 vcl/unx/gtk/gtkinst.cxx   |2 
 vcl/unx/gtk/gtksalframe.cxx   |2 
 vcl/unx/gtk3/gtk3gtkframe.cxx |2 
 50 files changed, 9613 insertions(+), 9613 deletions(-)

New commits:
commit 22d5d2ca7dde6164bd1e0fa9b3493870995375c5
Author: Chris Sherlock 
Date:   Mon Jan 11 15:03:01 2016 +1100

vcl: move vcl/generic/print files to vcl/unx/generic/print

These source files as all specific to Unix environments (not, however,
OS X) and are not "generic" (i.e. used across all platforms).

Change-Id: I6008a272c4b961a12702e2ef8727c56df9e80164
Reviewed-on: https://gerrit.libreoffice.org/21334
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 65ad25d..5556cf9 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -545,15 +545,6 @@ vcl_really_generic_code= \
 vcl_generic_code= \
$(vcl_really_generic_code) \
 vcl/generic/app/gendisp \
-vcl/generic/print/bitmap_gfx \
-vcl/generic/print/common_gfx \
-vcl/generic/print/glyphset \
-vcl/generic/print/printerjob \
-vcl/generic/print/psputil \
-vcl/generic/print/genpspgraphics \
-vcl/generic/print/genprnpsp \
-vcl/generic/print/prtsetup \
-vcl/generic/print/text_gfx \
 
 vcl_headless_code= \
 vcl/headless/svpbmp \
@@ -580,6 +571,15 @@ vcl_headless_freetype_code=\
 vcl/unx/generic/fontmanager/helper \
 vcl/unx/generic/fontmanager/parseAFM \
 vcl/headless/svpcairotextrender \
+vcl/unx/generic/print/bitmap_gfx \
+vcl/unx/generic/print/common_gfx \
+vcl/unx/generic/print/glyphset \
+vcl/unx/generic/print/printerjob \
+vcl/unx/generic/print/psputil \
+vcl/unx/generic/print/genpspgraphics \
+vcl/unx/generic/print/genprnpsp \
+vcl/unx/generic/print/prtsetup \
+vcl/unx/generic/print/text_gfx \
 
 ifeq ($(USING_X11),TRUE)
 $(eval $(call gb_Library_add_exception_objects,vcl,\
diff --git a/vcl/headless/svpprn.cxx b/vcl/headless/svpprn.cxx
index 8941303..422da1c 100644
--- a/vcl/headless/svpprn.cxx
+++ b/vcl/headless/svpprn.cxx
@@ 

[Libreoffice-commits] core.git: vcl/CustomTarget_afm_hash.mk vcl/generic vcl/Library_vcl.mk vcl/unx

[Chris Sherlock]

 vcl/CustomTarget_afm_hash.mk |   12 
 vcl/Library_vcl.mk   |   14 
 vcl/generic/fontmanager/adobe_encoding_table.hxx | 1078 -
 vcl/generic/fontmanager/afm_keyword_list |   62 
 vcl/generic/fontmanager/fontcache.cxx|  740 --
 vcl/generic/fontmanager/fontconfig.cxx   | 1293 ---
 vcl/generic/fontmanager/fontmanager.cxx  |  ---
 vcl/generic/fontmanager/fontsubst.cxx|  252 --
 vcl/generic/fontmanager/helper.cxx   |  390 ---
 vcl/generic/fontmanager/parseAFM.cxx | 1466 
 vcl/generic/fontmanager/parseAFM.hxx |  323 --
 vcl/unx/generic/fontmanager/adobe_encoding_table.hxx | 1078 +
 vcl/unx/generic/fontmanager/afm_keyword_list |   62 
 vcl/unx/generic/fontmanager/fontcache.cxx|  740 ++
 vcl/unx/generic/fontmanager/fontconfig.cxx   | 1293 +++
 vcl/unx/generic/fontmanager/fontmanager.cxx  |  +++
 vcl/unx/generic/fontmanager/fontsubst.cxx|  252 ++
 vcl/unx/generic/fontmanager/helper.cxx   |  390 +++
 vcl/unx/generic/fontmanager/parseAFM.cxx | 1466 
 vcl/unx/generic/fontmanager/parseAFM.hxx |  323 ++
 20 files changed, 7839 insertions(+), 7839 deletions(-)

New commits:
commit cd4c21dea96e98639cc0488526dac142d9fed583
Author: Chris Sherlock 
Date:   Mon Jan 11 14:32:04 2016 +1100

vcl: move vcl/generic/fontmanager files to vcl/unx/generic/fontmanager

These source files as all specific to Unix environments (not, however,
OS X) and are not "generic" (i.e. used across all platforms).

Change-Id: I23650c86a7b74c2ac150b981e4be88eaea07e936
Reviewed-on: https://gerrit.libreoffice.org/21314
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/vcl/CustomTarget_afm_hash.mk b/vcl/CustomTarget_afm_hash.mk
index 44b2073..bf88fb9 100644
--- a/vcl/CustomTarget_afm_hash.mk
+++ b/vcl/CustomTarget_afm_hash.mk
@@ -6,14 +6,14 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_CustomTarget_CustomTarget,vcl/generic/fontmanager))
+$(eval $(call gb_CustomTarget_CustomTarget,vcl/unx/generic/fontmanager))
 
-$(call gb_CustomTarget_get_target,vcl/generic/fontmanager) : \
-   $(call gb_CustomTarget_get_workdir,vcl/generic/fontmanager)/afm_hash.hpp
+$(call gb_CustomTarget_get_target,vcl/unx/generic/fontmanager) : \
+   $(call 
gb_CustomTarget_get_workdir,vcl/unx/generic/fontmanager)/afm_hash.hpp
 
-$(call gb_CustomTarget_get_workdir,vcl/generic/fontmanager)/afm_hash.hpp : \
-   $(SRCDIR)/vcl/generic/fontmanager/afm_keyword_list \
-   | $(call 
gb_CustomTarget_get_workdir,vcl/generic/fontmanager)/.dir
+$(call gb_CustomTarget_get_workdir,vcl/unx/generic/fontmanager)/afm_hash.hpp : 
\
+   $(SRCDIR)/vcl/unx/generic/fontmanager/afm_keyword_list \
+   | $(call 
gb_CustomTarget_get_workdir,vcl/unx/generic/fontmanager)/.dir
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),GPF,1)
$(GPERF) -C -t -l -L C++ -m 20 -Z AfmKeywordHash -k '1,4,6,$$' $< | sed 
-e 's/(char\*)0/(char\*)0, NOPE/g' | grep -v '^#line' > $@
 
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 94ee4c3..65ad25d 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -35,7 +35,7 @@ endif
 
 $(eval $(call 
gb_Library_set_precompiled_header,vcl,$(SRCDIR)/vcl/inc/pch/precompiled_vcl))
 
-$(eval $(call gb_Library_use_custom_headers,vcl,officecfg/registry 
vcl/generic/fontmanager))
+$(eval $(call gb_Library_use_custom_headers,vcl,officecfg/registry 
vcl/unx/generic/fontmanager))
 
 $(eval $(call gb_Library_set_include,vcl,\
 $$(INCLUDE) \
@@ -554,12 +554,6 @@ vcl_generic_code= \
 vcl/generic/print/genprnpsp \
 vcl/generic/print/prtsetup \
 vcl/generic/print/text_gfx \
-vcl/generic/fontmanager/fontsubst \
-vcl/generic/fontmanager/fontcache \
-vcl/generic/fontmanager/fontconfig \
-vcl/generic/fontmanager/fontmanager \
-vcl/generic/fontmanager/helper \
-vcl/generic/fontmanager/parseAFM \
 
 vcl_headless_code= \
 vcl/headless/svpbmp \
@@ -579,6 +573,12 @@ vcl_headless_freetype_code=\
 vcl/unx/generic/glyphs/gcach_layout \
 vcl/unx/generic/glyphs/glyphcache \
 vcl/unx/generic/glyphs/scrptrun \
+vcl/unx/generic/fontmanager/fontsubst \
+vcl/unx/generic/fontmanager/fontcache \
+vcl/unx/generic/fontmanager/fontconfig \
+vcl/unx/generic/fontmanager/fontmanager \
+vcl/unx/generic/fontmanager/helper \
+vcl/unx/generic/fontmanager/parseAFM \
 vcl/headless/svpcairotextrender \
 
 ifeq ($(USING_X11),TRUE)
diff --git a/vcl/generic/fontmanager/adobe_encoding_table.hxx 
b/vcl/unx/generic/fontmanager/adobe_encoding_table.hxx

[Libreoffice-bugs] [Bug 96954] format cell number settings does not work with selected cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96954

raal  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from raal  ---
(In reply to futureproject from comment #4)
> Can confirm described behaviour in the provided example file when using
> AOO412m3(Build:9782) Rev 1709696. Changing formatting of single cells works,
> formatting the range does nothing.

Hello,
this is LibreOffice bugtracker, not AOO. Can you test it in LibreOffice?
https://www.libreoffice.org/download/libreoffice-fresh/
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97032] UI: Combobox / Drop Down Menu Not Working with Mouse under Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97032

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||momonas...@gmail.com
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=96 |
   |119 |

--- Comment #3 from Maxim Monastirsky  ---
It has nothing to do with Bug 96119 or with Juergen's commit.

*** This bug has been marked as a duplicate of bug 96604 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96604] gtk3: Impossible to select an entry with mouse in some lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96604

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||lukebe...@hotmail.com

--- Comment #4 from Maxim Monastirsky  ---
*** Bug 97032 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - framework/inc framework/source

[Maxim Monastirsky]

 framework/inc/uielement/toolbarmerger.hxx   |6 -
 framework/source/uielement/addonstoolbarmanager.cxx |6 +++--
 framework/source/uielement/toolbarmanager.cxx   |2 +
 framework/source/uielement/toolbarmerger.cxx|   23 ++--
 4 files changed, 28 insertions(+), 9 deletions(-)

New commits:
commit f18fac7e726fca5379ec03588938748815292e39
Author: Maxim Monastirsky 
Date:   Sat Jan 9 22:46:16 2016 +0200

Fix Addons.xcu toolbar items width handling

This is useful for some complex controls (e.g. Combobox).
Regression of cb4177b5f6d2c63548fa544a19b36001c57193e4

Change-Id: I683cc20e9db72a4dd58d89063ec6bfcd05a1068e
(cherry picked from commit ee3cd777e187669f2d9dec156854c00cab948a50)
Reviewed-on: https://gerrit.libreoffice.org/21296
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/framework/inc/uielement/toolbarmerger.hxx 
b/framework/inc/uielement/toolbarmerger.hxx
index ea1ab34..4ad1467 100644
--- a/framework/inc/uielement/toolbarmerger.hxx
+++ b/framework/inc/uielement/toolbarmerger.hxx
@@ -44,6 +44,7 @@ struct AddonsParams
 OUString aImageId;
 OUString aTarget;
 OUString aControlType;
+sal_uInt16 nWidth;
 };
 
 struct AddonToolbarItem
@@ -54,6 +55,7 @@ struct AddonToolbarItem
 OUString aTarget;
 OUString aContext;
 OUString aControlType;
+sal_uInt16 nWidth;
 };
 
 typedef ::std::vector< AddonToolbarItem > AddonToolbarItemContainer;
@@ -79,7 +81,8 @@ class ToolBarMerger
OUString& rImageIdentifier,
OUString& rTarget,
OUString& rContext,
-   OUString& rControlType );
+   OUString& rControlType,
+   sal_uInt16& rWidth );
 
 static ReferenceToolbarPathInfo FindReferencePoint( ToolBox* pToolbar,
 const OUString& 
rReferencePoint );
@@ -131,6 +134,7 @@ class ToolBarMerger
 ToolBox*pToolbar,
 const OUString& rCommandURL,
 sal_uInt16  nId,
+sal_uInt16  nWidth,
 const OUString& rControlType );
 
 static void CreateToolbarItem( ToolBox* pToolbox,
diff --git a/framework/source/uielement/addonstoolbarmanager.cxx 
b/framework/source/uielement/addonstoolbarmanager.cxx
index 8ca598a..7804108 100644
--- a/framework/source/uielement/addonstoolbarmanager.cxx
+++ b/framework/source/uielement/addonstoolbarmanager.cxx
@@ -228,10 +228,11 @@ void AddonsToolBarManager::FillToolbar( const Sequence< 
Sequence< PropertyValue
 OUString   aContext;
 OUString   aTarget;
 OUString   aControlType;
+sal_uInt16 nWidth( 0 );
 
 const Sequence< PropertyValue >& rSeq = rAddonToolbar[n];
 
-ToolBarMerger::ConvertSequenceToValues( rSeq, aURL, aTitle, aImageId, 
aTarget, aContext, aControlType );
+ToolBarMerger::ConvertSequenceToValues( rSeq, aURL, aTitle, aImageId, 
aTarget, aContext, aControlType, nWidth );
 
 if ( IsCorrectContext( aModuleIdentifier, aContext ))
 {
@@ -262,6 +263,7 @@ void AddonsToolBarManager::FillToolbar( const Sequence< 
Sequence< PropertyValue
 AddonsParams* pRuntimeItemData = new AddonsParams;
 pRuntimeItemData->aImageId  = aImageId;
 pRuntimeItemData->aTarget   = aTarget;
+pRuntimeItemData->nWidth= nWidth;
 m_pToolBar->SetItemData( nId, pRuntimeItemData );
 m_pToolBar->SetItemCommand( nId, aURL );
 
@@ -307,7 +309,7 @@ void AddonsToolBarManager::FillToolbar( const Sequence< 
Sequence< PropertyValue
 {
 ::cppu::OWeakObject* pController = nullptr;
 
-pController = ToolBarMerger::CreateController( m_xContext, 
m_xFrame, m_pToolBar, aURL, nId, aControlType );
+pController = ToolBarMerger::CreateController( m_xContext, 
m_xFrame, m_pToolBar, aURL, nId, nWidth, aControlType );
 xController.set( pController, UNO_QUERY );
 }
 
diff --git a/framework/source/uielement/toolbarmanager.cxx 
b/framework/source/uielement/toolbarmanager.cxx
index bb80b25..f10e042 100644
--- a/framework/source/uielement/toolbarmanager.cxx
+++ b/framework/source/uielement/toolbarmanager.cxx
@@ -718,6 +718,7 @@ void ToolBarManager::CreateControllers()
 {
 // retrieve additional parameters
 OUString aControlType = static_cast< AddonsParams* >( 
m_pToolBar->GetItemData( nId ))->aControlType;
+sal_uInt16 nWidth = static_cast< AddonsParams* >( 

[Libreoffice-commits] core.git: sfx2/source

[Chris Sherlock]

 sfx2/source/control/unoctitm.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 07bb3d99e7ea969f3543f2209d721c8c18fd33fe
Author: Chris Sherlock 
Date:   Mon Jan 11 16:02:35 2016 +1100

sfx2: change variable jan to aUsageInfoMessage for clarity

Change-Id: Icc9d9b277ce2dca5ee13c381a105c387a42525c7
Reviewed-on: https://gerrit.libreoffice.org/21337
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx
index 1a82906..5b4b8af 100644
--- a/sfx2/source/control/unoctitm.cxx
+++ b/sfx2/source/control/unoctitm.cxx
@@ -650,14 +650,14 @@ void UsageInfo::save()
 
 if( file.open(osl_File_OpenFlag_Read | osl_File_OpenFlag_Write | 
osl_File_OpenFlag_Create) == osl::File::E_None )
 {
-OString jan = "Usage information:\n";
+OString aUsageInfoMsg = "Usage information:\n";
 
 for (UsageMap::const_iterator it = maUsage.begin(); it != 
maUsage.end(); ++it)
-jan += "\n" + it->first.toUtf8() + ";" + 
OString::number(it->second);
+aUsageInfoMsg += "\n" + it->first.toUtf8() + ";" + 
OString::number(it->second);
 
-jan += "\nUsage information end\n";
+aUsageInfoMsg += "\nUsage information end\n";
 sal_uInt64 written = 0;
-file.write(jan.pData->buffer, jan.getLength(), written);
+file.write(aUsageInfoMsg.pData->buffer, aUsageInfoMsg.getLength(), 
written);
 file.close();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/generic vcl/headless vcl/inc vcl/Library_vcl.mk vcl/unx

[Chris Sherlock]

 vcl/Library_vcl.mk  |   14 -
 vcl/generic/app/gendisp.cxx |  152 -
 vcl/generic/app/geninst.cxx |  164 --
 vcl/generic/app/gensys.cxx  |  213 
 vcl/headless/svpdata.cxx|2 
 vcl/headless/svpglyphcache.cxx  |2 
 vcl/headless/svpinst.cxx|2 
 vcl/inc/generic/gendata.hxx |   69 ---
 vcl/inc/generic/gendisp.hxx |   79 
 vcl/inc/generic/geninst.h   |  127 --
 vcl/inc/generic/gensys.h|   55 --
 vcl/inc/headless/svpdummies.hxx |2 
 vcl/inc/headless/svpinst.hxx|2 
 vcl/inc/unx/gendata.hxx |   69 +++
 vcl/inc/unx/gendisp.hxx |   79 
 vcl/inc/unx/geninst.h   |  127 ++
 vcl/inc/unx/gensys.h|   55 ++
 vcl/inc/unx/gtk/gtkdata.hxx |2 
 vcl/inc/unx/gtk/gtkinst.hxx |2 
 vcl/inc/unx/gtk/gtksys.hxx  |2 
 vcl/inc/unx/saldata.hxx |2 
 vcl/inc/unx/saldisp.hxx |4 
 vcl/inc/unx/salinst.h   |2 
 vcl/inc/unx/x11/x11sys.hxx  |2 
 vcl/unx/generic/app/gendisp.cxx |  152 +
 vcl/unx/generic/app/geninst.cxx |  164 ++
 vcl/unx/generic/app/gensys.cxx  |  213 
 vcl/unx/generic/app/salinst.cxx |2 
 vcl/unx/generic/fontmanager/fontmanager.cxx |2 
 vcl/unx/generic/fontmanager/fontsubst.cxx   |2 
 vcl/unx/generic/gdi/cairotextrender.cxx |2 
 vcl/unx/generic/plugadapt/salplug.cxx   |4 
 vcl/unx/generic/print/genprnpsp.cxx |2 
 vcl/unx/generic/print/genpspgraphics.cxx|2 
 vcl/unx/generic/window/salframe.cxx |2 
 vcl/unx/generic/window/screensaverinhibitor.cxx |2 
 vcl/unx/gtk/gtkdata.cxx |2 
 vcl/unx/gtk/gtksalframe.cxx |2 
 vcl/unx/gtk/gtksalmenu.cxx  |2 
 vcl/unx/gtk3/gtk3gtkframe.cxx   |2 
 vcl/unx/kde4/KDE4FilePicker.cxx |2 
 41 files changed, 890 insertions(+), 898 deletions(-)

New commits:
commit 7546390fb8d4a0f6184302061985e68b0dbceb1d
Author: Chris Sherlock 
Date:   Mon Jan 11 15:44:23 2016 +1100

vcl: move vcl/generic/app/ files to vcl/unx/generic/app

These source files as all specific to Unix environments (not, however,
OS X) and are not "generic" (i.e. used across all platforms).

Change-Id: Idba1e9bbe14d8a4bb8e5dd2c2ad1dc75458da53c
Reviewed-on: https://gerrit.libreoffice.org/21335
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 5556cf9..f757232 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -538,14 +538,6 @@ endif
 
 endif
 
-vcl_really_generic_code= \
-vcl/generic/app/gensys \
-vcl/generic/app/geninst \
-
-vcl_generic_code= \
-   $(vcl_really_generic_code) \
-vcl/generic/app/gendisp \
-
 vcl_headless_code= \
 vcl/headless/svpbmp \
 vcl/headless/svpdummies \
@@ -554,6 +546,7 @@ vcl_headless_code= \
 vcl/headless/svpinst \
 vcl/headless/svpdata \
 vcl/headless/svpvd \
+vcl/unx/generic/app/gendisp \
 
 vcl_headless_freetype_code=\
 vcl/headless/svpprn \
@@ -580,10 +573,11 @@ vcl_headless_freetype_code=\
 vcl/unx/generic/print/genprnpsp \
 vcl/unx/generic/print/prtsetup \
 vcl/unx/generic/print/text_gfx \
+vcl/unx/generic/app/gensys \
+vcl/unx/generic/app/geninst \
 
 ifeq ($(USING_X11),TRUE)
 $(eval $(call gb_Library_add_exception_objects,vcl,\
-   $(vcl_generic_code) \
 vcl/unx/generic/plugadapt/salplug \
 vcl/unx/generic/printer/jobdata \
 vcl/unx/generic/printer/ppdparser \
@@ -615,7 +609,6 @@ endif
 
 ifeq ($(ENABLE_HEADLESS),TRUE)
 $(eval $(call gb_Library_add_exception_objects,vcl,\
-   $(vcl_generic_code) \
 vcl/unx/generic/printer/jobdata \
 vcl/unx/generic/printer/ppdparser \
 vcl/null/printerinfomanager \
@@ -646,7 +639,6 @@ $(eval $(call gb_Library_add_libs,vcl,\
-llo-bootstrap \
 ))
 $(eval $(call gb_Library_add_exception_objects,vcl,\
-   $(vcl_generic_code) \
 vcl/unx/generic/printer/jobdata \
 vcl/unx/generic/printer/ppdparser \
 vcl/null/printerinfomanager \
diff --git a/vcl/headless/svpdata.cxx b/vcl/headless/svpdata.cxx
index d4fbdae..f1f9851 100644
--- a/vcl/headless/svpdata.cxx
+++ b/vcl/headless/svpdata.cxx
@@ -7,7 

[Libreoffice-bugs] [Bug 96089] Autosave run on unmodified file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96089

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=65
   ||509

--- Comment #2 from Jean-Baptiste Faure  ---
Autosave option has been made hidden since LO 5.0. Search autosave in expert
configuration to change its value.
See bug 65509

Please, could you test with a clean new user profile?

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65509] FILESAVE "Automatically save" is not running

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65509

Jean-Baptiste Faure  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||089

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96486] LOKView Add method to launch print dialogue

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96486

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||jbfa...@libreoffice.org
 Ever confirmed|0   |1
   Severity|normal  |enhancement

--- Comment #1 from Jean-Baptiste Faure  ---
Valid request. Changed Importance to enhancement.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96193] Highlight and dividers on toolbar rendering offset when window maximized.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96193

--- Comment #6 from Beluga  ---
(In reply to Jean-Baptiste Faure from comment #5)
> (In reply to Beluga from comment #3)
> > And I guess the problem goes away, if you launch from terminal with:
> > SAL_USE_VCLPLUGIN=gtk soffice
> 
> Are you sure for the syntax? For me the correct syntax is:
> export SAL_USE_VCLPLUGIN="gtk"
> with the gtk or gtk3 between double quotes.

Interesting.. The way I said it is the way developers always say it. It is also
like that in here for example:
https://wiki.archlinux.org/index.php/LibreOffice#Theme

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97004] New: E-mail

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97004

Bug ID: 97004
   Summary: E-mail
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: brcnaka...@gmail.com

Saved writer files send with e-mail.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82790] FORMATTING: Date formating does not work for newly entered dates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82790

raal  changed:

   What|Removed |Added

   Keywords|possibleRegression  |regression
 CC||r...@post.cz
 OS|Windows (All)   |All

--- Comment #6 from raal  ---
Still reproducible in Version: 5.2.0.0.alpha0+
Build ID: c1258abe50f1508ea0f628ff963bc1914ab86b67
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-01-02_01:43:32

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94841] Libre office calc crashes when full blocks are filled and sorted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94841

raal  changed:

   What|Removed |Added

   Keywords||bibisected, bisected
 CC||libreoff...@kohei.us

--- Comment #10 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Kohei Yoshida ; Could you possibly take a look at this one?
Thanks

cbd3a1049b8e33bc5a862189b30518ece7f1307e is the first bad commit
commit cbd3a1049b8e33bc5a862189b30518ece7f1307e
Author: Matthew Francis 
Date:   Sat Mar 14 23:56:31 2015 +0800

source-hash-a3fc7f20089062afa4f778e70ba8be84032a30a7

(Bibisect: Skipped preceding irrelevant commit(s)
97f700721e942912101d5acd73433448e57e39e5)

commit a3fc7f20089062afa4f778e70ba8be84032a30a7
Author: Kohei Yoshida 
AuthorDate: Sun Jul 27 14:35:37 2014 -0400
Commit: Kohei Yoshida 
CommitDate: Sun Jul 27 14:41:21 2014 -0400

fdo#81617: Split formula groups at sort range boundaries.

Otherwise, partially sorting a range may crash, or at best incorrectly
update formula references.

Change-Id: Iefcb86d205d83ccc5b684048bfd9aadabf6e13eb

:04 04 21f062a0f14872375b5a0c6004dede2964d5e158
b19810b51622977125d344ca7763b81becd3c09a Mopt

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96064] inserting video fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96064

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org

--- Comment #13 from Jean-Baptiste Faure  ---
No problem for me to insert your two video sample file in LO 5.0 and next LO
5.1. (both build at home under Ubuntu 15.10 x86-64).
Additionally both videos play without problem in edit mode and in slideshow
mode.

I think that the problem is not on the LO side; you should ask for help on a
Debian forum.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96970] Load url bar document window name

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96970

--- Comment #2 from inp...@gmail.com ---
(In reply to Jean-Baptiste Faure from comment #1)
> What is your LibreOffice version and the operating system of your computer?
>

$ cat > document1.txt
text 1

cat > document2.txt
text 2

Use writer to open document1.txt

In the 'load url bar' activate cursor after 'document' and delete '1.txt'

type '2' and the file name should auto-complete to /path/to/document2.txt',
enter return

Use menu option 'window' to select 'document1.txt'

The document viewed changes to document1, but the 'load url bar' shows
'document2.txt'. If you use the menu bar option 'window' to change repeatedly
the view of these two documents, the file name in the 'load url bar' stays
fixed, showing only 'document2.txt'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 1f/39c0bdcd0dd917e91bd8133010749543910337

[Caolán McNamara]

 1f/39c0bdcd0dd917e91bd8133010749543910337 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 753fa077337bac54ff68b5411eb6797386d609bc
Author: Caolán McNamara 
Date:   Sun Jan 10 12:00:02 2016 +

Notes added by 'git notes add'

diff --git a/1f/39c0bdcd0dd917e91bd8133010749543910337 
b/1f/39c0bdcd0dd917e91bd8133010749543910337
new file mode 100644
index 000..8ebbe55
--- /dev/null
+++ b/1f/39c0bdcd0dd917e91bd8133010749543910337
@@ -0,0 +1 @@
+ignore: obsolete
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 43/fb38f6c55b9c2b30d938cb5a30e7d875ba2bfc

[Caolán McNamara]

 43/fb38f6c55b9c2b30d938cb5a30e7d875ba2bfc |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 5325c065b10f0a6004826f7c9e7ba4728dbafc0b
Author: Caolán McNamara 
Date:   Sun Jan 10 12:00:25 2016 +

Notes added by 'git notes add'

diff --git a/43/fb38f6c55b9c2b30d938cb5a30e7d875ba2bfc 
b/43/fb38f6c55b9c2b30d938cb5a30e7d875ba2bfc
new file mode 100644
index 000..8ebbe55
--- /dev/null
+++ b/43/fb38f6c55b9c2b30d938cb5a30e7d875ba2bfc
@@ -0,0 +1 @@
+ignore: obsolete
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

[Aybuke Ozdemir]

 sfx2/source/control/unoctitm.cxx |   30 +-
 1 file changed, 25 insertions(+), 5 deletions(-)

New commits:
commit d61c16966b017abdbebf5ec0c2131de5a91c67f8
Author: Aybuke Ozdemir 
Date:   Sat Dec 5 16:19:56 2015 +0200

tdf#95505 Dump usage stats to text file

1de031c94b2ef9c4ae45a8906b250a95d3c47c47

Change-Id: I1de031c94b2ef9c4ae45a8906b250a95d3c47c47
Reviewed-on: https://gerrit.libreoffice.org/20413
Reviewed-by: jan iversen 
Tested-by: jan iversen 
Tested-by: Jenkins 

diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx
index 8645826..1a82906 100644
--- a/sfx2/source/control/unoctitm.cxx
+++ b/sfx2/source/control/unoctitm.cxx
@@ -65,6 +65,9 @@
 #include "statcach.hxx"
 #include 
 #include 
+#include 
+#include 
+#include 
 
 #include 
 #include 
@@ -74,6 +77,8 @@
 #include 
 #include 
 
+#define USAGE "file:///~/.config/libreofficedev/4/user/usage.txt"
+
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::util;
@@ -640,13 +645,28 @@ void UsageInfo::save()
 if (!mbIsCollecting)
 return;
 
-// TODO - do a real saving here, not only dump to the screen
-std::cerr << "Usage information:" << std::endl;
-for (UsageMap::const_iterator it = maUsage.begin(); it != maUsage.end(); 
++it)
+const OUString path(USAGE);
+osl::File file(path);
+
+if( file.open(osl_File_OpenFlag_Read | osl_File_OpenFlag_Write | 
osl_File_OpenFlag_Create) == osl::File::E_None )
 {
-std::cerr << it->first << ';' << it->second << std::endl;
+OString jan = "Usage information:\n";
+
+for (UsageMap::const_iterator it = maUsage.begin(); it != 
maUsage.end(); ++it)
+jan += "\n" + it->first.toUtf8() + ";" + 
OString::number(it->second);
+
+jan += "\nUsage information end\n";
+sal_uInt64 written = 0;
+file.write(jan.pData->buffer, jan.getLength(), written);
+file.close();
+}
+
+else{
+std::cerr << "Usage information:" << std::endl;
+for (UsageMap::const_iterator it = maUsage.begin(); it != 
maUsage.end(); ++it)
+std::cerr << it->first << ';' << it->second << std::endl;
+std::cerr << "Usage information end" << std::endl;
 }
-std::cerr << "Usage information end" << std::endl;
 }
 
 class theUsageInfo : public rtl::Static {};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 95505] Dump usage stats to text file in user profile rather than std error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95505

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95505] Dump usage stats to text file in user profile rather than std error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95505

--- Comment #14 from Commit Notification 
 ---
Aybuke Ozdemir committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d61c16966b017abdbebf5ec0c2131de5a91c67f8

tdf#95505 Dump usage stats to text file

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97000] New: LibreOffice Online - The Add Link property isn't in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97000

Bug ID: 97000
   Summary: LibreOffice Online - The Add Link property isn't in
Writer
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hallacke...@gmail.com

When I was working on Writer, i want to "Add Link" to some words or some
sentences. Sometimes this is very useful. LibreOffice Online can make this
property. I think this possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97005] New: LOOL UX: Strike-through together with numbering/bullets does not work correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97005

Bug ID: 97005
   Summary: LOOL UX: Strike-through together with
numbering/bullets does not work correctly
   Product: LibreOffice Online
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sedat.ak...@gmail.com

Steps to reproduce:
1. open a new document
2. write something
2. select text
3. click Strike-through button
4. apply numbering or bullets - this will Strike-through everything

Expected behavior: Should be Strike-through just text, not number or bullet.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95616] autocorrect replacement table has transient black background when resized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95616

--- Comment #3 from tommy27  ---
still present in LibO 5.2.0.0.alpha0+
Build ID: 22e5170af74c635cf55d089f97946b6dc86f82ad
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-01-05_23:41:26
Locale: it-IT (it_IT)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93648] flipped .JPEG not shown in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93648

tommy27  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #9 from tommy27  ---
I installed ImageMagick and now works fine with LibO 5.2.0.0.alpha0+
Build ID: 22e5170af74c635cf55d089f97946b6dc86f82ad
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-01-05_23:41:26
Locale: it-IT (it_IT)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80412] FILESAVE: DOC save brakes correct Normal style font and font size in Word for Mac 2011

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80412

mitja  changed:

   What|Removed |Added

   Keywords||filter:doc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96064] inserting video fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96064

--- Comment #14 from lazev  ---
Thanks JBF

I'll do it. 

Happy 2016.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80412] FILESAVE: DOC save brakes correct Normal style font and font size in Word for Mac 2011

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80412

mitja  changed:

   What|Removed |Added

 OS|Mac OS X (All)  |All

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96114] Data Validity dialog does not accept a choice other than 'All values'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96114

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org
   Hardware|All |x86-64 (AMD64)
 OS|All |Windows (All)

--- Comment #10 from Jean-Baptiste Faure  ---
(In reply to Wolfgang Jäger from comment #4)
> Add info:
> I first found the vlidity dialog simply not working.
> Now I see that the behaviour is more complicated.
> 
> Steps to reproduce:
> 1. With V5.1.0.0beta1 Calc create a new spreadsheet document (1 sheet).
> 2. enter som numeric values in A1:A3
> 3. Go to B1.
> 4. > 'Data' > 'Validity' > 'Allow:' > (choose) 'Cell range' 
> Expected: "Cell range" shows up behind "Allow:", Entering the range is
> offered.
> Actual behavieour: "All values" still shown, 'Source' not enabled 

Not reproducible for me with Version: 5.1.0.1.0+
Build ID: 9be39a75053be54214efd1fc4c2811913659c30e
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
built at home under Ubuntu_15.10_x86-64

Cell range is available in the dropdown list under "Allow:" and choosing Cell
range enable the Source text field and its associated button "Reduce"

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

license statement

[Mert Tümer]

   All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.   
  ___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Remove ActiveX from LibreOffice

[Chris Sherlock]

So I believe that we haven’t come to any firm conclusion on this issue. 

There is a patch in gerrit currently, I’m a bit concerned it might be pushed 
before this is concretely decided. 

What is our position on ActiveX? 

Michael raises a pretty good point, and there are others who have said they 
don’t want this removed. I had thought that this wasn’t going to happen now… 

Chris

> On 5 Jan 2016, at 7:00 AM, Michael Stahl  wrote:
> 
> On 30.12.2015 21:02, Bryan Quigley wrote:
>> Hi there,
>> 
>> Recently it was decided to remove the rest of NPAPI support [1] which
>> got me thinking about the other Windows specific plugin tech -
>> ActiveX.
>> 
>> It seems ActiveX is very much no longer recommended by Microsoft and
>> it seems to not work by default for IE10/11 on Windows 7 and up.  Any
>> objections to removing?
> 
> i don't think that a LO browser plugin is a terribly good idea, so no
> objection to removing that.
> 
>> AFAICT this would just be removing embedding LO into IE.
> 
> however, isn't it the case that ActiveX components may not be used just
> from IE, but from any Win32 application?
> 
> that sounds like a potentially more useful embedding use-case, similar
> to "officebean" and "LibreOfficeKit", but for developers that are
> familiar with Win32 APIs.
> 
> (or would that be something else that also happens to be called
> "ActiveX" but is not actually implemented by LO's so_activex library?)
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97006] New: Libreoffice Online- can not open .odf files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97006

Bug ID: 97006
   Summary: Libreoffice Online- can not open .odf files
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: aysemelikeyurto...@gmail.com

Math file could not open on Libreoffice Online. I think this is a problem.
Libreoffice Online can open Math documents ıt is possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl vcl/generic vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

[Chris Sherlock]

 include/vcl/font.hxx|4 ++--
 vcl/generic/glyphs/glyphcache.cxx   |2 +-
 vcl/generic/print/genpspgraphics.cxx|   10 +-
 vcl/headless/svptext.cxx|2 +-
 vcl/inc/PhysicalFontFace.hxx|4 ++--
 vcl/inc/cairotextrender.hxx |2 +-
 vcl/inc/fontattributes.hxx  |8 
 vcl/inc/fontinstance.hxx|2 +-
 vcl/inc/fontselect.hxx  |2 +-
 vcl/inc/generic/genpspgraphics.h|6 +++---
 vcl/inc/generic/glyphcache.hxx  |4 ++--
 vcl/inc/headless/svpgdi.hxx |2 +-
 vcl/inc/quartz/salgdi.h |8 
 vcl/inc/salgdi.hxx  |4 ++--
 vcl/inc/textrender.hxx  |2 +-
 vcl/inc/unx/gcach_ftyp.hxx  |   10 +-
 vcl/inc/unx/salgdi.h|4 ++--
 vcl/inc/win/salgdi.h|4 ++--
 vcl/quartz/ctfonts.cxx  |   10 +-
 vcl/quartz/ctfonts.hxx  |2 +-
 vcl/quartz/ctlayout.cxx |2 +-
 vcl/quartz/salgdi.cxx   |4 ++--
 vcl/source/font/PhysicalFontFace.cxx|4 ++--
 vcl/source/font/fontattributes.cxx  |   10 +-
 vcl/source/font/fontselect.cxx  |2 +-
 vcl/source/gdi/font.cxx |2 +-
 vcl/source/gdi/pdfwriter_impl.cxx   |4 ++--
 vcl/source/gdi/pdfwriter_impl.hxx   |2 +-
 vcl/source/gdi/virdev.cxx   |2 +-
 vcl/source/outdev/font.cxx  |6 +++---
 vcl/unx/generic/gdi/cairotextrender.cxx |8 
 vcl/unx/generic/gdi/gcach_ftyp.cxx  |   10 +-
 vcl/unx/generic/gdi/salgdi3.cxx |2 +-
 vcl/win/gdi/salfont.cxx |   30 +++---
 34 files changed, 90 insertions(+), 90 deletions(-)

New commits:
commit 36ccb37eee589c45ab2d05a5c0dff6585a2f
Author: Chris Sherlock 
Date:   Sun Jan 10 14:01:22 2016 +1100

vcl: promote ImplFontAttributes to FontAttributes

ImplFontAttributes is no longer merely a pImpl (or "compilation
firewall", take your pick) but is a fully fledged class in its
own right that is used by a number of classes, including
FontSelectPattern, LogicalFontInstance and PhysicalFontFace. Thus
I'm "promoting" the use of this class in the codebase.

Change-Id: I26866080a64796978d1c25efbcd16e3e6f94aaa5
Reviewed-on: https://gerrit.libreoffice.org/21305
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/include/vcl/font.hxx b/include/vcl/font.hxx
index 9c91995..3b58b67 100644
--- a/include/vcl/font.hxx
+++ b/include/vcl/font.hxx
@@ -33,7 +33,7 @@ class SvStream;
 #define FontAlign TextAlign
 
 class Impl_Font;
-class ImplFontAttributes;
+class FontAttributes;
 namespace vcl { class Font; }
 // need to first declare these outside the vcl namespace, or the friend 
declarations won't work right
 VCL_DLLPUBLIC SvStream&  ReadFont( SvStream& rIStm, vcl::Font& );
@@ -125,7 +125,7 @@ public:
 boolIsWordLineMode() const;
 
 voidMerge( const Font& rFont );
-voidGetFontAttributes( ImplFontAttributes& rAttrs ) const;
+voidGetFontAttributes( FontAttributes& rAttrs ) const;
 
 Font&   operator=( const Font& );
 booloperator==( const Font& ) const;
diff --git a/vcl/generic/glyphs/glyphcache.cxx 
b/vcl/generic/glyphs/glyphcache.cxx
index 12788c0..4d13c52 100644
--- a/vcl/generic/glyphs/glyphcache.cxx
+++ b/vcl/generic/glyphs/glyphcache.cxx
@@ -147,7 +147,7 @@ GlyphCache& GlyphCache::GetInstance()
 }
 
 void GlyphCache::AddFontFile( const OString& rNormalizedName, int nFaceNum,
-sal_IntPtr nFontId, const ImplFontAttributes& rDFA)
+sal_IntPtr nFontId, const FontAttributes& rDFA)
 {
 if( mpFtManager )
 mpFtManager->AddFontFile( rNormalizedName, nFaceNum, nFontId, rDFA);
diff --git a/vcl/generic/print/genpspgraphics.cxx 
b/vcl/generic/print/genpspgraphics.cxx
index 420437e..6ce0811 100644
--- a/vcl/generic/print/genpspgraphics.cxx
+++ b/vcl/generic/print/genpspgraphics.cxx
@@ -878,7 +878,7 @@ bool GenPspGraphics::AddTempDevFontHelper( 
PhysicalFontCollection* pFontCollecti
 aInfo.m_aFamilyName = rFontName;
 
 // inform glyph cache of new font
-ImplFontAttributes aDFA = GenPspGraphics::Info2FontAttributes( aInfo );
+FontAttributes aDFA = GenPspGraphics::Info2FontAttributes( aInfo );
 aDFA.IncreaseQualityBy( 5800 );
 
 int nFaceNum = rMgr.getFontFaceNumber( aInfo.m_nID );
@@ -913,14 +913,14 @@ void GenPspGraphics::ClearDevFontCache()
 GlyphCache::GetInstance().ClearFontCache();
 }
 
-void GenPspGraphics::GetFontAttributes( ImplFontAttributes *pFontAttributes, 
int )
+void GenPspGraphics::GetFontAttributes( 

[Libreoffice-bugs] [Bug 80412] FILESAVE: DOC save brakes correct Normal style font and font size in Word for Mac 2011

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80412

--- Comment #6 from mitja  ---
The problem regarding DOC documents and Default Paragraph Style (Normal Style
in Word), saved in OOo or LO, still persists when saving DOC files in Libre
Office 5.
Even more, when opening such file does not affect only Word for Mac 2011
version 14.3.6+, but even newer Word for Mac 2016.

Can anyone please take a look at this issue when saving DOC files with OO/LO?

Apparently there is something going on with Word for Mac DOC "importer" from
version 14.3.6 and on. But that affects only DOC files created with OO/LO and
Microsoft is probably not interested to solve this issue as I reported this
problem to them also.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97001] New: Libreoffice Online - Don't insert footnote in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97001

Bug ID: 97001
   Summary: Libreoffice Online - Don't insert footnote in Writer
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hallacke...@gmail.com

For example, i prepare document in Writer. In addition to i want to add
footnote to my document. This is new property for LibreOffice Online. This
property seem as button. I think this very importent for some Writer documents.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96185] Can't delete hidden image or table in Document / draft keeps prompting for non-existing field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96185

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |NOTOURBUG

--- Comment #2 from Jean-Baptiste Faure  ---
Your document is a template and the image and table are in the header of the
default page style.
To remove the image or the table you need to create a second page first,
ctrl+Enter does the job. Then you can see the table and the image.
To remove the "non existent field", you need to edit the template (import it in
your templates and use Edition button in the Template management dialog) and
uncheck the conception mode in the Edition menu. I did that in the next version
5.1.

I think that the designer of this template should have explained in the body of
the template how it is intended to work and how it can be modified. Creating a
template by doing a document, removing all its content and saving the result as
a template, is not a good method.

Closing as NotOurBug.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96193] Highlight and dividers on toolbar rendering offset when window maximized.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96193

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org

--- Comment #5 from Jean-Baptiste Faure  ---
(In reply to Beluga from comment #3)
> And I guess the problem goes away, if you launch from terminal with:
> SAL_USE_VCLPLUGIN=gtk soffice

Are you sure for the syntax? For me the correct syntax is:
export SAL_USE_VCLPLUGIN="gtk"
with the gtk or gtk3 between double quotes.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 55066] FILEOPEN: flaws in importing 123 files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=55066

--- Comment #17 from osnola  ---
Hello,

(In reply to Shubham Tibra from comment #15)
> I'd like to work on this bug, is it still open to work on.
> 
> But I'll need some help. I am new here.
> 
> I didn't understand how the import code works and how it uses the file
> format?
> 
> Can someone help me?

the source of the LibreOffice's filter(*) are in sc/source/filter/lotus.
For instance, the version number of universal-content.123 (0x1005) is read in
https://docs.libreoffice.org/sc/html/filter_8cxx_source.html#l00109, so this
function will return eWK123...

(*) concerning older Lotus's files, there are read via the libwps's filter :
the entry point on the source is
http://sourceforge.net/p/libwps/code/ci/master/tree/src/lib/Lotus.cpp#l310 ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 95899] Display problem with Writer: images disappearing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95899

Jean-Baptiste Faure  changed:

   What|Removed |Added

Summary|Display problem with Writer |Display problem with
   ||Writer: images disappearing

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 55066] FILEOPEN: flaws in importing 123 files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=55066

--- Comment #17 from osnola  ---
Hello,

(In reply to Shubham Tibra from comment #15)
> I'd like to work on this bug, is it still open to work on.
> 
> But I'll need some help. I am new here.
> 
> I didn't understand how the import code works and how it uses the file
> format?
> 
> Can someone help me?

the source of the LibreOffice's filter(*) are in sc/source/filter/lotus.
For instance, the version number of universal-content.123 (0x1005) is read in
https://docs.libreoffice.org/sc/html/filter_8cxx_source.html#l00109, so this
function will return eWK123...

(*) concerning older Lotus's files, there are read via the libwps's filter :
the entry point on the source is
http://sourceforge.net/p/libwps/code/ci/master/tree/src/lib/Lotus.cpp#l310 ...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96999] "Tools/Customize" panel should be resizable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96999

tommy27  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96999] New: "Tools/Customize" panel should be resizable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96999

Bug ID: 96999
   Summary: "Tools/Customize" panel should be resizable
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@quipo.it

Created attachment 121828
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121828=edit
screenshot

this is an UI enhancement about the "Tools/Customize" panel

as you may see from the attached screenshot sometimes the text can be long
enough to go beyond field bounds

you can use horizontal scrollbars but I think that it would be easier for the
user to manually resize the whole panel like other UI panels already do (i.e.
Tools/Autocorrect/Autocorrect Options)

I put Caolan to CC list since I know he worked on this topic in the past.

this issue is inherited from OOo and still reproducible in current 5.2.x master
builds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

--- Comment #4 from Heiko Tietze  ---
Created attachment 121830
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121830=edit
Language menu at Impress

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

--- Comment #4 from Heiko Tietze  ---
Created attachment 121830
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121830=edit
Language menu at Impress

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

--- Comment #5 from Heiko Tietze  ---
Created attachment 121831
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121831=edit
No language menu at Calc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

--- Comment #3 from Heiko Tietze  ---
Created attachment 121829
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121829=edit
Language menu at Writer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

--- Comment #5 from Heiko Tietze  ---
Created attachment 121831
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121831=edit
No language menu at Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94603] uno:Paste Not Working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94603

David Watford  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from David Watford  ---
Working on Windows Version 5.0.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source include/svx include/vcl sc/source starmath/source svtools/source svx/source vcl/generic vcl/inc vcl/qa vcl/quartz vcl/source vcl/unx vcl/win

[Chris Sherlock]

 cui/source/dialogs/cuicharmap.cxx   |   12 +++---
 include/svx/charmap.hxx |2 -
 include/vcl/outdev.hxx  |2 -
 sc/source/filter/excel/xistyle.cxx  |   50 ++--
 starmath/source/dialog.cxx  |8 ++--
 svtools/source/misc/sampletext.cxx  |   10 ++---
 svx/source/dialog/charmap.cxx   |   48 +--
 vcl/generic/fontmanager/fontmanager.cxx |8 ++--
 vcl/generic/print/genpspgraphics.cxx|4 +-
 vcl/inc/quartz/salgdi.h |2 -
 vcl/inc/unx/gcach_ftyp.hxx  |4 +-
 vcl/inc/win/salgdi.h|6 +--
 vcl/qa/cppunit/fontcharmap.cxx  |   12 +++---
 vcl/quartz/salgdi.cxx   |   42 
 vcl/source/filter/wmf/wmfwr.cxx |8 ++--
 vcl/source/outdev/font.cxx  |   22 ++--
 vcl/unx/generic/gdi/cairotextrender.cxx |4 +-
 vcl/unx/generic/gdi/gcach_ftyp.cxx  |   26 +++---
 vcl/win/gdi/salfont.cxx |   56 
 19 files changed, 163 insertions(+), 163 deletions(-)

New commits:
commit 536d0e27f05d9db7469bd8a3571c87b2ea885367
Author: Chris Sherlock 
Date:   Sun Jan 10 21:37:22 2016 +1100

Cleanup FontCharMapPtr variable prefixes

Change-Id: Ib106b91ab71ee45d5ad469d0beaf4ebaef8b57e1
Reviewed-on: https://gerrit.libreoffice.org/21306
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/cui/source/dialogs/cuicharmap.cxx 
b/cui/source/dialogs/cuicharmap.cxx
index ee26bca..b17931c 100644
--- a/cui/source/dialogs/cuicharmap.cxx
+++ b/cui/source/dialogs/cuicharmap.cxx
@@ -455,9 +455,9 @@ IMPL_LINK_NOARG_TYPED(SvxCharacterMap, FontSelectHdl, 
ListBox&, void)
 bool bNeedSubset = (aFont.GetCharSet() != RTL_TEXTENCODING_SYMBOL);
 if( bNeedSubset )
 {
-FontCharMapPtr pFontCharMap( new FontCharMap() );
-m_pShowSet->GetFontCharMap( pFontCharMap );
-pSubsetMap = new SubsetMap( pFontCharMap );
+FontCharMapPtr xFontCharMap( new FontCharMap() );
+m_pShowSet->GetFontCharMap( xFontCharMap );
+pSubsetMap = new SubsetMap( xFontCharMap );
 
 // update subset listbox for new font's unicode subsets
 // TODO: is it worth to improve the stupid linear search?
@@ -600,9 +600,9 @@ void SvxCharacterMap::selectCharByCode(Radix radix)
 // Convert the code back to a character using the appropriate radix
 sal_UCS4 cChar = aCodeString.toUInt32(static_cast (radix));
 // Use FontCharMap::HasChar(sal_UCS4 cChar) to see if the desired 
character is in the font
-FontCharMapPtr pFontCharMap(new FontCharMap());
-m_pShowSet->GetFontCharMap(pFontCharMap);
-if (pFontCharMap->HasChar(cChar))
+FontCharMapPtr xFontCharMap(new FontCharMap());
+m_pShowSet->GetFontCharMap(xFontCharMap);
+if (xFontCharMap->HasChar(cChar))
 // Select the corresponding character
 SetChar(cChar);
 }
diff --git a/include/svx/charmap.hxx b/include/svx/charmap.hxx
index 963e962..1574d18 100644
--- a/include/svx/charmap.hxx
+++ b/include/svx/charmap.hxx
@@ -105,7 +105,7 @@ private:
 
 sal_Int32   nSelectedIndex;
 
-FontCharMapPtr  mpFontCharMap;
+FontCharMapPtr  mxFontCharMap;
 SizemaFontSize;
 VclPtr  aVscrollSB;
 
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index c8e397b..ea706eb 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1260,7 +1260,7 @@ public:
 FontMetric  GetFontMetric() const;
 FontMetric  GetFontMetric( const vcl::Font& rFont ) const;
 
-boolGetFontCharMap( FontCharMapPtr& rFontCharMap ) 
const;
+boolGetFontCharMap( FontCharMapPtr& rxFontCharMap 
) const;
 boolGetFontCapabilities( vcl::FontCapabilities& 
rFontCapabilities ) const;
 
 /** Retrieve detailed font information in platform independent structure
diff --git a/sc/source/filter/excel/xistyle.cxx 
b/sc/source/filter/excel/xistyle.cxx
index 05c1516..b663c78 100644
--- a/sc/source/filter/excel/xistyle.cxx
+++ b/sc/source/filter/excel/xistyle.cxx
@@ -462,41 +462,41 @@ void XclImpFont::GuessScriptType()
 if( OutputDevice* pPrinter = GetPrinter() )
 {
 vcl::Font aFont( maData.maName, Size( 0, 10 ) );
-FontCharMapPtr pCharMap;
+FontCharMapPtr xFontCharMap;
 
 pPrinter->SetFont( aFont );
-if( pPrinter->GetFontCharMap( pCharMap ) )
+if( pPrinter->GetFontCharMap( xFontCharMap ) )
 {
 // CJK fonts
 mbHasAsian =
-pCharMap->HasChar( 0x3041 ) ||   // 3040-309F: Hiragana
-pCharMap->HasChar( 0x30A1 ) ||   // 30A0-30FF: Katakana
-pCharMap->HasChar( 0x3111 ) ||   // 3100-312F: 

[Libreoffice-ux-advise] [Bug 94042] Improving autorecovery/autosave

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94042

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org

--- Comment #14 from Jean-Baptiste Faure  ---
(In reply to Commit Notification from comment #9)
> Yousuf Philips committed a patch related to this issue.
> It has been pushed to "master":
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=2e0b9891764bb4cae6ed9a1b111d9b6dafeee92d
> 
> tdf#94042 Change autorecovery & autosave to 10 minutes
> 

Did you really change the default value for _autosave_, that is an option which
is disabled by default and hidden (available only from expert configuration)?

Best regards. JBF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 96126] Viewing graphics in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96126

Jean-Baptiste Faure  changed:

   What|Removed |Added

Summary|VIEWING  GRAPHICS IN CALC   |Viewing graphics in Calc

--- Comment #7 from Jean-Baptiste Faure  ---
No need to scream. Set summary in lowercase.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

New to Libreoffice

[Prasad Ghangal]

Hello everyone,
I am Prasad Ghangal, a BTech student. I really want to contribute in
libreoffice but I have never worked on any open source project before.
I am good at C, C++ and little python.

So can some please help me getting started?

-- 
Thanks and Regards,
Prasad Ghangal
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97002] New: LOOL UX: Colouring

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97002

Bug ID: 97002
   Summary: LOOL UX: Colouring
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: merttu...@outlook.com

There is no property for colouring texts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96200] Resizing non-empty window on multihead/nvidia crashes X server

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96200

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jbfa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #8 from Jean-Baptiste Faure  ---
(In reply to kylmonh from comment #7)
> I did a few research on my free time...
> 
> Downgrading the nvidia-driver to 352.55 does not change the problem.

And if you use the Nouveau driver (free driver) instead of the proprietary one
?

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97003] New: LOOL UX: Numbering Pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97003

Bug ID: 97003
   Summary: LOOL UX: Numbering Pages
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: merttu...@outlook.com

We can add property to display page numbers as it is in the desktop version. It
can be helpful when there are a lot of pages.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||easyHack

--- Comment #2 from Heiko Tietze  ---
In Writer there is: Tools > Language > For Selection | For Paragraph | For All
Text >  | None | Default
In Presentation we have: Tools > Language > For All Text >  | None | Default
In Calc: Nothing

It makes sense to harmonize the functionality (easyhack I guess).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||easyHack

--- Comment #2 from Heiko Tietze  ---
In Writer there is: Tools > Language > For Selection | For Paragraph | For All
Text >  | None | Default
In Presentation we have: Tools > Language > For All Text >  | None | Default
In Calc: Nothing

It makes sense to harmonize the functionality (easyhack I guess).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

--- Comment #3 from Heiko Tietze  ---
Created attachment 121829
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121829=edit
Language menu at Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 95926] Window "Edit Paragraph Style" (or any style) should have an option to switch to a different style quickly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95926

--- Comment #8 from Heiko Tietze  ---
Switching the style per dropdown would make it necessary to adopt all setting
in this dialog regardless what was changed before. Of course a confirmation
might help but that's very unusual. We had a similar discussion for the new
area fill style dialog where Jay convinced me to have a clear distinction
between the selection of a style and setting its properties.

So I agree with Jean-Baptiste.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 95926] Window "Edit Paragraph Style" (or any style) should have an option to switch to a different style quickly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95926

--- Comment #8 from Heiko Tietze  ---
Switching the style per dropdown would make it necessary to adopt all setting
in this dialog regardless what was changed before. Of course a confirmation
might help but that's very unusual. We had a similar discussion for the new
area fill style dialog where Jay convinced me to have a clear distinction
between the selection of a style and setting its properties.

So I agree with Jean-Baptiste.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96126] Viewing graphics in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96126

--- Comment #8 from Roque  ---
(In reply to Jean-Baptiste Faure from comment #7)
> No need to scream. Set summary in lowercase.
> 
> Best regards. JBF

Bonjour,
C'est quoi ce commentaire ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #6 from V Stuart Foote  ---
Created attachment 121832
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121832=edit
clip of changing language for selection of cells in calc

Changing language in calc has rather more impact -- not only spell check, but
also the data formatting defaults for that language.

However, if necessary, language can be trivially applied to selected cells. If
the whole sheet must be changed--select all.

As it is an attribute assigned to each cell -- done simply with selection and
context menu Format Cells.  Or if preferred from main menu Format -> Cells

Tools -> Options -> Language Settings -> Language: "Default Languages for
Documents" panel check box "for the current document only" can be used to force
all new sheets to use a different language. But believe selection and format
cells will have to be applied to all existing sheets to complete the change.

Don't know that it really needs adjustment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #6 from V Stuart Foote  ---
Created attachment 121832
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121832=edit
clip of changing language for selection of cells in calc

Changing language in calc has rather more impact -- not only spell check, but
also the data formatting defaults for that language.

However, if necessary, language can be trivially applied to selected cells. If
the whole sheet must be changed--select all.

As it is an attribute assigned to each cell -- done simply with selection and
context menu Format Cells.  Or if preferred from main menu Format -> Cells

Tools -> Options -> Language Settings -> Language: "Default Languages for
Documents" panel check box "for the current document only" can be used to force
all new sheets to use a different language. But believe selection and format
cells will have to be applied to all existing sheets to complete the change.

Don't know that it really needs adjustment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 97002] LOOL UX: Font color property does not exist.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97002

Mert Tumer  changed:

   What|Removed |Added

Summary|LOOL UX: Colouring  |LOOL UX: Font color
   ||property does not exist.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65138
Bug 65138 depends on bug 96997, which changed state.

Bug 96997 Summary: Sidebar usability and screen space
https://bugs.documentfoundation.org/show_bug.cgi?id=96997

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65138

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||96997

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97009] New: There is an area that should be hided while editing an odt file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97009

Bug ID: 97009
   Summary: There is an area that should be hided while editing an
odt file
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gulsah.1...@gmail.com

Created attachment 121835
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121835=edit
unneeded area

The area mentioned at the attachement is unusable option while editing an odf
file. It would be better Hiding that area would be better.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97010] New: LOOL UX: Cannot change page orientation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97010

Bug ID: 97010
   Summary: LOOL UX: Cannot change page orientation
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: berkgure...@gmail.com

Created attachment 121836
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121836=edit
page orientation button

There is no page orientation option to change page orientation to portrait or
to landscape.
It can be added as a button next to formatting buttons and change orientation
from one to other one. 
Button may looks like the button in the attachment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97012] New: There is no option for adding new spreadsheet.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97012

Bug ID: 97012
   Summary: There is no option for adding new spreadsheet.
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gulsah.1...@gmail.com

Should be added an option for adding a new speadsheet.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs