[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - icon-themes/breeze

[andreas kainz]

 icon-themes/breeze/res/savemodified_large.png |binary
 icon-themes/breeze/res/savemodified_small.png |binary
 2 files changed

New commits:
commit 9771363e9e91393ca3bf02265bb93ce8537f
Author: andreas kainz 
Date:   Mon Jan 11 22:06:18 2016 +0100

Breeze icons: add savemodified icon

Change-Id: I5f9c64f8c4b0868d2cbf4c53007076450ed7fc86
Reviewed-on: https://gerrit.libreoffice.org/21372
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 
(cherry picked from commit 8d8ddea6934f6ee0f23109fc574c02a0c8a247fd)
Signed-off-by: Adolfo Jayme Barrientos 

diff --git a/icon-themes/breeze/res/savemodified_large.png 
b/icon-themes/breeze/res/savemodified_large.png
new file mode 100644
index 000..9b49921
Binary files /dev/null and b/icon-themes/breeze/res/savemodified_large.png 
differ
diff --git a/icon-themes/breeze/res/savemodified_small.png 
b/icon-themes/breeze/res/savemodified_small.png
new file mode 100644
index 000..29fb2e7
Binary files /dev/null and b/icon-themes/breeze/res/savemodified_small.png 
differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96540] Calc crashes with this file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96540

--- Comment #3 from raal  ---
No crash, Version: 5.2.0.0.alpha0+
Build ID: 86338fbb94324ede329e1d232eeaf70f2fde696e
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-01-08_00:45:19

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97050] Setting a combobox to read-only disables the control

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97050

Usama Akkad  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Usama Akkad  ---
Hello,

Thank you for filing the bug. Please send us a sample document, as this makes
it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO', so please do change it back to
'UNCONFIRMED' once you have attached a document.
(Please note that the attachment will be public, remove any sensitive
information before attaching it.)
How can I eliminate confidential data from a sample document?
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97050] Setting a combobox to read-only disables the control

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97050

futureproj...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #2 from futureproj...@gmail.com ---
Windows 10 Pro, Version 1511 (OS Build 10586.36)
LibreOffice 5.0.4.2, Build ID 2b9802c1994aa0b7dc6079e128979269cf95bc78
Locale en_US

Can confirm bug. Setting a ComboBox's Read Only property to Yes disables the
drop-down functionality altogether.

Setting it to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

--- Comment #10 from teo8...@gmail.com ---
> an approach of setting the language of the entirety document in one 
> place wouldn't allow one to have paragraphs or words with different 
> languages

For god's sake did you even read what I wrote??

I'm not talking about disallowing ANYTHING that is currently allowed. I'm only
talking about setting DEFAULTS for a new document, for future documents, or for
the parts of the current document that haven't yet been touched (e.g. cells
that haven't been applied a format or even entered a content).

That is: you start creating a new document and you want all the defaults to be,
let's say, in Italian. You should be able to set that in one place, not a
dozen. You shouldn't go like "Ok, so now let's select a cell and format it as a
number... wait a moment, why do all the options have a comma instead of a dot?
Oh f**k, this is still in English, I have to set the locale too" and so on.

Then you still have all the options to change each thing individually for each
cell, sheet, paragraph, or whatever.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: connectivity/source

[Stephan Bergmann]

 connectivity/source/drivers/odbc/OResultSet.cxx |6 +++---
 connectivity/source/drivers/odbc/OStatement.cxx |6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 0b8b372c7fe829f9457efd8f945b8b50007f1ea6
Author: Stephan Bergmann 
Date:   Mon Jan 11 23:30:39 2016 +0100

loplugin:defaultparams

Change-Id: I60c66ae8944cb4cfe82bfb762d9739446362b61b

diff --git a/connectivity/source/drivers/odbc/OResultSet.cxx 
b/connectivity/source/drivers/odbc/OResultSet.cxx
index 1993c73..962d6bb 100644
--- a/connectivity/source/drivers/odbc/OResultSet.cxx
+++ b/connectivity/source/drivers/odbc/OResultSet.cxx
@@ -1170,7 +1170,7 @@ Sequence OResultSet::impl_getBookmark(  ) 
throw( SQLException,  Runtim
 {
 if ( m_nUseBookmarks == ODBC_SQL_NOT_DEFINED )
 {
-m_nUseBookmarks = getStmtOption(SQL_ATTR_USE_BOOKMARKS, SQL_UB_OFF);
+m_nUseBookmarks = getStmtOption(SQL_ATTR_USE_BOOKMARKS);
 }
 if(m_nUseBookmarks == SQL_UB_OFF)
 throw SQLException();
@@ -1368,7 +1368,7 @@ bool  OResultSet::isBookmarkable() const
 
 if ( m_nUseBookmarks == ODBC_SQL_NOT_DEFINED )
 {
-m_nUseBookmarks = getStmtOption(SQL_ATTR_USE_BOOKMARKS, SQL_UB_OFF);
+m_nUseBookmarks = getStmtOption(SQL_ATTR_USE_BOOKMARKS);
 }
 
 return (m_nUseBookmarks != SQL_UB_OFF) && (nAttr & SQL_CA1_BOOKMARK) == 
SQL_CA1_BOOKMARK;
@@ -1724,7 +1724,7 @@ bool OResultSet::move(IResultSetHelper::Movement 
_eCursorPosition, sal_Int32 _nO
 } // switch(_eCursorPosition)
 if ( m_nUseBookmarks == ODBC_SQL_NOT_DEFINED )
 {
-m_nUseBookmarks = getStmtOption(SQL_ATTR_USE_BOOKMARKS, SQL_UB_OFF);
+m_nUseBookmarks = getStmtOption(SQL_ATTR_USE_BOOKMARKS);
 }
 if ( m_nUseBookmarks == SQL_UB_OFF )
 {
diff --git a/connectivity/source/drivers/odbc/OStatement.cxx 
b/connectivity/source/drivers/odbc/OStatement.cxx
index 58a7a1df..df39e29 100644
--- a/connectivity/source/drivers/odbc/OStatement.cxx
+++ b/connectivity/source/drivers/odbc/OStatement.cxx
@@ -674,7 +674,7 @@ sal_Int32 OStatement_Base::getResultSetConcurrency() const
 sal_Int32 OStatement_Base::getResultSetType() const
 {
 OSL_ENSURE(m_aStatementHandle,"StatementHandle is null!");
-SQLULEN nValue (getStmtOption(SQL_ATTR_CURSOR_TYPE, SQL_CURSOR_FORWARD_ONLY));
+SQLULEN nValue (getStmtOption(SQL_ATTR_CURSOR_TYPE));
 switch(nValue)
 {
 case SQL_CURSOR_FORWARD_ONLY:
@@ -863,13 +863,13 @@ void OStatement_Base::setCursorName(const OUString &_par0)
 bool OStatement_Base::isUsingBookmarks() const
 {
 OSL_ENSURE(m_aStatementHandle,"StatementHandle is null!");
-return SQL_UB_OFF != getStmtOption(SQL_ATTR_USE_BOOKMARKS, SQL_UB_OFF);
+return SQL_UB_OFF != getStmtOption(SQL_ATTR_USE_BOOKMARKS);
 }
 
 bool OStatement_Base::getEscapeProcessing() const
 {
 OSL_ENSURE( m_aStatementHandle, "StatementHandle is null!" );
-return SQL_NOSCAN_OFF == getStmtOption(SQL_ATTR_USE_BOOKMARKS, SQL_NOSCAN_OFF);
+return SQL_NOSCAN_OFF == getStmtOption(SQL_ATTR_USE_BOOKMARKS);
 }
 
 void OStatement_Base::setUsingBookmarks(bool _bUseBookmark)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97050] Setting a combobox to read-only disables the control

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97050

--- Comment #5 from libreoff...@voicetechnology.co.uk ---
Created attachment 121865
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121865=edit
Includes listbox control

added listbox to dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97050] Setting a combobox to read-only disables the control

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97050

--- Comment #6 from libreoff...@voicetechnology.co.uk ---
Adding a read only combobox or listbox directly to a worksheet exhibits the
same problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/Library_vcl.mk vcl/source

[Chris Sherlock]

 vcl/Library_vcl.mk |2 
 vcl/source/gdi/fontcharmap.cxx |  599 +
 vcl/source/gdi/impfont.cxx |  599 -
 3 files changed, 600 insertions(+), 600 deletions(-)

New commits:
commit 49f39e0de1a4fb4360198087bf1b2d1fc61742c6
Author: Chris Sherlock 
Date:   Mon Jan 11 18:36:36 2016 +1100

vcl: tidyup file name impfont.cxx -> fontcharmap.cxx

Change-Id: Ib2acc963704c7613e1d3bd1761b619ece1aef79f
Reviewed-on: https://gerrit.libreoffice.org/21339
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 961bb05..578786f 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -281,7 +281,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/gdi/hatch \
 vcl/source/gdi/impanmvw \
 vcl/source/gdi/impbmp \
-vcl/source/gdi/impfont \
+vcl/source/gdi/fontcharmap \
 vcl/source/gdi/impgraph \
 vcl/source/gdi/impvect \
 vcl/source/gdi/jobset \
diff --git a/vcl/source/gdi/impfont.cxx b/vcl/source/gdi/fontcharmap.cxx
similarity index 100%
rename from vcl/source/gdi/impfont.cxx
rename to vcl/source/gdi/fontcharmap.cxx
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

[Chris Sherlock]

 include/vcl/fontcharmap.hxx|   23 ++-
 vcl/inc/impfont.hxx|   57 -
 vcl/inc/impfontcharmap.hxx |   82 +
 vcl/quartz/salgdi.cxx  |1 
 vcl/source/gdi/impfont.cxx |2 
 vcl/unx/generic/fontmanager/fontmanager.cxx|2 
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx |1 
 vcl/win/gdi/salfont.cxx|1 
 8 files changed, 107 insertions(+), 62 deletions(-)

New commits:
commit 27154c4bb5ed80d699d706ebd1a84e807c3f1625
Author: Chris Sherlock 
Date:   Mon Jan 11 18:31:28 2016 +1100

vcl: split off ImplFontCharMap into it's own header file

Change-Id: I6173cd191cd771b1f030fa737617b1067278ee10
Reviewed-on: https://gerrit.libreoffice.org/21338
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/include/vcl/fontcharmap.hxx b/include/vcl/fontcharmap.hxx
index c4d495c..b0dca54 100644
--- a/include/vcl/fontcharmap.hxx
+++ b/include/vcl/fontcharmap.hxx
@@ -17,8 +17,8 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_FONTCHARMAP_METRIC_HXX
-#define INCLUDED_FONTCHARMAP_METRIC_HXX
+#ifndef INCLUDED_FONTCHARMAP_HXX
+#define INCLUDED_FONTCHARMAP_HXX
 
 #include 
 #include 
@@ -164,6 +164,23 @@ inline void intrusive_ptr_release(FontCharMap* 
pFontCharMap)
 delete pFontCharMap;
 }
 
-#endif // INCLUDED_FONTCHARMAP_METRIC_HXX
+
+// CmapResult is a normalized version of the many CMAP formats
+class VCL_PLUGIN_PUBLIC CmapResult
+{
+public:
+explicitCmapResult( bool bSymbolic = false,
+const sal_uInt32* pRangeCodes = nullptr, int 
nRangeCount = 0,
+const int* pStartGlyphs = nullptr, const 
sal_uInt16* pGlyphIds = nullptr );
+
+const sal_uInt32*   mpRangeCodes;
+const int*  mpStartGlyphs;
+const sal_uInt16*   mpGlyphIds;
+int mnRangeCount;
+boolmbSymbolic;
+boolmbRecoded;
+};
+
+#endif // INCLUDED_FONTCHARMAP_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/impfont.hxx b/vcl/inc/impfont.hxx
index 904c9eb..77b90a4 100644
--- a/vcl/inc/impfont.hxx
+++ b/vcl/inc/impfont.hxx
@@ -161,64 +161,7 @@ private:
 FcPattern* mpPattern;
 };
 
-// - ImplFontCharMap -
 
-class CmapResult;
-
-class VCL_PLUGIN_PUBLIC ImplFontCharMap
-{
-public:
-explicitImplFontCharMap( const CmapResult& );
-virtual ~ImplFontCharMap();
-
-private:
-friend class FontCharMap;
-friend void intrusive_ptr_add_ref(ImplFontCharMap* pImplFontCharMap);
-friend void intrusive_ptr_release(ImplFontCharMap* pImplFontCharMap);
-
-ImplFontCharMap( const ImplFontCharMap& ) = delete;
-voidoperator=( const ImplFontCharMap& ) = delete;
-
-static ImplFontCharMapPtr getDefaultMap( bool bSymbols=false);
-boolisDefaultMap() const;
-
-private:
-const sal_uInt32*   mpRangeCodes; // pairs of StartCode/(EndCode+1)
-const int*  mpStartGlyphs;// range-specific mapper to glyphs
-const sal_uInt16*   mpGlyphIds;   // individual glyphid mappings
-int mnRangeCount;
-int mnCharCount;  // covered codepoints
-mutable sal_uInt32  mnRefCount;
-};
-
-inline void intrusive_ptr_add_ref(ImplFontCharMap* pImplFontCharMap)
-{
-++pImplFontCharMap->mnRefCount;
-}
-
-inline void intrusive_ptr_release(ImplFontCharMap* pImplFontCharMap)
-{
-if (--pImplFontCharMap->mnRefCount == 0)
-delete pImplFontCharMap;
-}
-
-// CmapResult is a normalized version of the many CMAP formats
-class VCL_PLUGIN_PUBLIC CmapResult
-{
-public:
-explicitCmapResult( bool bSymbolic = false,
-const sal_uInt32* pRangeCodes = nullptr, int 
nRangeCount = 0,
-const int* pStartGlyphs = nullptr, const 
sal_uInt16* pGlyphIds = nullptr );
-
-const sal_uInt32*   mpRangeCodes;
-const int*  mpStartGlyphs;
-const sal_uInt16*   mpGlyphIds;
-int mnRangeCount;
-boolmbSymbolic;
-boolmbRecoded;
-};
-
-bool ParseCMAP( const unsigned char* pRawData, int nRawLength, CmapResult& );
 
 #endif // INCLUDED_VCL_INC_IMPFONT_HXX
 
diff --git a/vcl/inc/impfontcharmap.hxx b/vcl/inc/impfontcharmap.hxx
new file mode 100644
index 000..ef5c961
--- /dev/null
+++ b/vcl/inc/impfontcharmap.hxx
@@ -0,0 +1,82 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with 

Re: Remove ActiveX from LibreOffice

[Ashod Nakashian]

On Mon, Jan 11, 2016 at 2:32 PM, Bryan Quigley  wrote:
>
>
> Anywhere else we should post this?
>
>
Ideally the note would show up unintrusively upon loading/using the ActiveX
itself. Unfortunately we can't show a message box or some such UI, in case
the ActiveX is used non-interactively (in which case it'd block forever,
becoming unusable).

So the next best thing to do is *include the note in the installation*,
which should be hard to miss if made prominent (unless automated in silent
mode).

This would get the attention of possibly the users, if not the developers
(who might not even test out new versions as they come out, and expect
things to work as before). Users can contact developers, I expect, or at
least plan accordingly. Regardless, all we want is to give advance warning
before the day someone installs a newer version and be met with the
surprise of missing ActiveX altogether.

The installation and release notes seem to be the most reasonable places,
if not upon using the ActiveX itself. Unless others have better ideas.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sfx2/source

[Stephan Bergmann]

 sfx2/source/bastyp/fltfnc.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d1a6c708968327be134cbfd422a3467752546f64
Author: Stephan Bergmann 
Date:   Mon Jan 11 23:38:38 2016 +0100

loplugin:defaultparams

Change-Id: I919f9f5f9ccb1429624f9c8e75574fec71a2b370

diff --git a/sfx2/source/bastyp/fltfnc.cxx b/sfx2/source/bastyp/fltfnc.cxx
index 6edc51d..863b736 100644
--- a/sfx2/source/bastyp/fltfnc.cxx
+++ b/sfx2/source/bastyp/fltfnc.cxx
@@ -1069,7 +1069,7 @@ void SfxFilterContainer::ReadSingleFilter_Impl(
 // register SfxFilter
 // first erase module name from old filter names!
 // e.g: "scalc: DIF" => "DIF"
-sal_Int32 nStartRealName = sFilterName.indexOf( ": ", 0 );
+sal_Int32 nStartRealName = sFilterName.indexOf( ": " );
 if( nStartRealName != -1 )
 {
 SAL_WARN( "sfx.bastyp", "Old format, not supported!");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/osx

[Maxim Monastirsky]

 vcl/inc/osx/salnsmenu.h |8 
 vcl/osx/salmenu.cxx |   42 +-
 vcl/osx/salnsmenu.mm|   15 +++
 3 files changed, 16 insertions(+), 49 deletions(-)

New commits:
commit cbd483211e1ac9d9e724b5ba3e3e38a0c5abe55c
Author: Maxim Monastirsky 
Date:   Mon Jan 11 18:17:49 2016 +0200

tdf#96875 Make OS X native context menus compatible

... with how framework::MenuBarManager works, following my
work of converting context menus to use it instead of
SfxPopupMenuManager (see tdf#93837).

MenuBarManager sets menu item properties/select handler
when the menu activates - in MenuBarManager::Activate, but
it was never called for submenus. The solution is to adapt
the menuNeedsUpdate delegate to call Menu::Activate.

This makes submenu items work, but doesn't update their
visual state (e.g. title). The reason is that
AquaSalMenu::ShowNativePopupMenu is creating a copy of the
NSMenu, so AquaSalMenu::SetItemText is modifying the wrong
NSMenu instance.

Another problem is that AquaSalMenu::ShowNativePopupMenu
tries to removes (via removeUnusedItemsRunner function)
all disabled items, but the correct state is set by
MenuBarManager only when the menu activates. So we must
handle disabled items only after MenuBarManager::Activate
did its job.

Turns out that we can just hide items in NSMenu instead
of removing them, so no need to clone the NSMenu anymore.

Change-Id: If0785b7f9d5f0ad98ced23585379039a51dc13bf
Reviewed-on: https://gerrit.libreoffice.org/21374
Reviewed-by: Maxim Monastirsky 
Tested-by: Maxim Monastirsky 

diff --git a/vcl/inc/osx/salnsmenu.h b/vcl/inc/osx/salnsmenu.h
index 47c410b..f815c14 100644
--- a/vcl/inc/osx/salnsmenu.h
+++ b/vcl/inc/osx/salnsmenu.h
@@ -33,10 +33,6 @@ class AquaSalMenuItem;
 
 @interface SalNSMenu : NSMenu
 {
-/* Caution: SalNSMenu instances occasionally are binary copied
-   in AquaSalMenu::ShowNativePopupMenu. If any members are added,
-   please take this into account !
-*/
 AquaSalMenu*mpMenu;
 }
 -(id)initWithMenu: (AquaSalMenu*)pMenu;
@@ -46,10 +42,6 @@ class AquaSalMenuItem;
 
 @interface SalNSMenuItem : NSMenuItem
 {
-/* Caution: SalNSMenuItem instances occasionally are binary copied
-   in AquaSalMenu::ShowNativePopupMenu. If any members are added,
-   please take this into account !
-*/
 AquaSalMenuItem*mpMenuItem;
 }
 -(id)initWithMenuItem: (AquaSalMenuItem*)pMenuItem;
diff --git a/vcl/osx/salmenu.cxx b/vcl/osx/salmenu.cxx
index 5119d6c..91a5c2e 100644
--- a/vcl/osx/salmenu.cxx
+++ b/vcl/osx/salmenu.cxx
@@ -317,37 +317,6 @@ AquaSalMenu::~AquaSalMenu()
 }
 }
 
-sal_Int32 removeUnusedItemsRunner(NSMenu * pMenu)
-{
-NSArray * elements = [pMenu itemArray];
-NSEnumerator * it = [elements objectEnumerator];
-id elem;
-NSMenuItem * lastDisplayedMenuItem = nil;
-sal_Int32 drawnItems = 0;
-bool firstEnabledItemIsNoSeparator = false;
-while((elem=[it nextObject]) != nil) {
-NSMenuItem * item = static_cast(elem);
-if( (![item isEnabled] && ![item isSeparatorItem]) || ([item 
isSeparatorItem] && (lastDisplayedMenuItem != nil && [lastDisplayedMenuItem 
isSeparatorItem])) ) {
-[[item menu]removeItem:item];
-} else {
-if( ! firstEnabledItemIsNoSeparator && [item isSeparatorItem] ) {
-[[item menu]removeItem:item];
-} else {
-firstEnabledItemIsNoSeparator = true;
-lastDisplayedMenuItem = item;
-drawnItems++;
-if( [item hasSubmenu] ) {
-removeUnusedItemsRunner( [item submenu] );
-}
-}
-}
-}
-if( lastDisplayedMenuItem != nil && [lastDisplayedMenuItem 
isSeparatorItem]) {
-[[lastDisplayedMenuItem menu]removeItem:lastDisplayedMenuItem];
-}
-return drawnItems;
-}
-
 bool AquaSalMenu::ShowNativePopupMenu(FloatingWindow * pWin, const Rectangle& 
rRect, FloatWinPopupFlags nFlags)
 {
 // do not use native popup menu when AQUA_NATIVE_MENUS is set to false
@@ -365,13 +334,6 @@ bool AquaSalMenu::ShowNativePopupMenu(FloatingWindow * 
pWin, const Rectangle& rR
 NSView* pPopupNSView = static_cast(pWin->ImplGetWindow()->ImplGetFrame())->mpNSView;
 NSRect popupFrame = [pPopupNSView frame];
 
-// since we manipulate the menu below (removing entries)
-// let's rather make a copy here and work with that
-NSMenu* pCopyMenu = [mpMenu copy];
-
-// filter disabled elements
-removeUnusedItemsRunner( pCopyMenu );
-
 // create frame rect
 NSRect displayPopupFrame = NSMakeRect( rRect.Left()+(offset-1), 
rRect.Top()+(offset+1), popupFrame.size.width, 0 );
 pParentAquaSalFrame->VCLToCocoa(displayPopupFrame, false);
@@ -390,15 +352,13 

[Libreoffice-bugs] [Bug 97035] FILEOPEN: RTF wrong cell width

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97035

m.a.riosv  changed:

   What|Removed |Added

   Keywords||regression
 Status|UNCONFIRMED |NEW
 CC||miguelangelrv@libreoffice.o
   ||rg
Version|5.2.0.0.alpha0+ Master  |4.0.6.2 release
 Ever confirmed|0   |1

--- Comment #3 from m.a.riosv  ---
Last version working for me:
Version 3.6.7.2 (Build ID: e183d5b)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93054] EDITING: dragging and dropping selected cells doesn't work (GTK3 only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93054

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||nekoh...@gmail.com

--- Comment #14 from Maxim Monastirsky  ---
*** Bug 97053 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97053] Dragging and dropping fields to create pivot tables will not work with libreoffice-gtk3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97053

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||momonas...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Maxim Monastirsky  ---
Drag & drop isn't implemented at all in gtk3.

*** This bug has been marked as a duplicate of bug 93054 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97051] Writer crashes when document has header or footer and you open page style dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97051

--- Comment #2 from Usama Akkad  ---
(In reply to Usama Akkad from comment #1)
> Confirmed on Libreoffice 15.1.0.1 Ubuntu Gnome 15.04. Report seems very
> accurate.
> In Linux I did not get the "Unknown SEH Exception" when I close the window.

Sorry, just small correction Libreoffice 5.1.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - sd/source

[Marco Cecchetti]

 sd/source/ui/view/Outliner.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 714bfcebd471b2dd67bca76fccbeddec762af0ec
Author: Marco Cecchetti 
Date:   Mon Jan 11 16:43:02 2016 +0100

lool - search all - unit test failure - solved

Change-Id: I5a74dd60f61fc0fdb88f08383d579b14222aa55d
Reviewed-on: https://gerrit.libreoffice.org/21366
Reviewed-by: Marco Cecchetti 
Tested-by: Marco Cecchetti 

diff --git a/sd/source/ui/view/Outliner.cxx b/sd/source/ui/view/Outliner.cxx
index f32c8ed..c16ba31 100644
--- a/sd/source/ui/view/Outliner.cxx
+++ b/sd/source/ui/view/Outliner.cxx
@@ -606,6 +606,8 @@ void Outliner::Initialize (bool bDirectionIsForward)
 
 bool Outliner::SearchAndReplaceAll()
 {
+DetectChange();
+
 bool bRet = true;
 // Save the current position to be restored after having replaced all
 // matches.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97050] Setting a combobox to read-only disables the control

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97050

libreoff...@voicetechnology.co.uk changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97050] Setting a combobox to read-only disables the control

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97050

libreoff...@voicetechnology.co.uk changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97050] Setting a combobox to read-only disables the control

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97050

--- Comment #4 from libreoff...@voicetechnology.co.uk ---
Ok, just added a listbox as read-only and that control is also disabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/galaxy

[andreas kainz]

 icon-themes/breeze/chart2/res/gl3dbar_roundrect.png |binary
 icon-themes/galaxy/sd/cmd/transition-comb.png   |binary
 icon-themes/galaxy/sd/cmd/transition-cut.png|binary
 icon-themes/galaxy/sd/cmd/transition-fall.png   |binary
 icon-themes/galaxy/sd/cmd/transition-icons.svg  |  934 +---
 icon-themes/galaxy/sd/cmd/transition-newsflash.png  |binary
 icon-themes/galaxy/sd/cmd/transition-push.png   |binary
 icon-themes/galaxy/sd/cmd/transition-random.png |binary
 icon-themes/galaxy/sd/cmd/transition-tile-flip.png  |binary
 icon-themes/galaxy/sd/cmd/transition-turning-helix.png  |binary
 icon-themes/galaxy/sd/cmd/transition-venetian-blinds-3d.png |binary
 11 files changed, 440 insertions(+), 494 deletions(-)

New commits:
commit 2244b1e3863a6837dbc867c51940e52b6525de43
Author: andreas kainz 
Date:   Mon Jan 11 23:58:56 2016 +0100

Breeze and galaxy transition icons update according to jays recs

Change-Id: I96b0a80962e1dc6925a57e5fe07041f2dccdacc6
Reviewed-on: https://gerrit.libreoffice.org/21375
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/icon-themes/breeze/chart2/res/gl3dbar_roundrect.png 
b/icon-themes/breeze/chart2/res/gl3dbar_roundrect.png
new file mode 100644
index 000..1b7c410
Binary files /dev/null and 
b/icon-themes/breeze/chart2/res/gl3dbar_roundrect.png differ
diff --git a/icon-themes/galaxy/sd/cmd/transition-comb.png 
b/icon-themes/galaxy/sd/cmd/transition-comb.png
index 737e6d6..f8cf344 100644
Binary files a/icon-themes/galaxy/sd/cmd/transition-comb.png and 
b/icon-themes/galaxy/sd/cmd/transition-comb.png differ
diff --git a/icon-themes/galaxy/sd/cmd/transition-cut.png 
b/icon-themes/galaxy/sd/cmd/transition-cut.png
index 3a1d0b1..ef1f565 100644
Binary files a/icon-themes/galaxy/sd/cmd/transition-cut.png and 
b/icon-themes/galaxy/sd/cmd/transition-cut.png differ
diff --git a/icon-themes/galaxy/sd/cmd/transition-fall.png 
b/icon-themes/galaxy/sd/cmd/transition-fall.png
index 910efb3..81bce28 100644
Binary files a/icon-themes/galaxy/sd/cmd/transition-fall.png and 
b/icon-themes/galaxy/sd/cmd/transition-fall.png differ
diff --git a/icon-themes/galaxy/sd/cmd/transition-icons.svg 
b/icon-themes/galaxy/sd/cmd/transition-icons.svg
index d412d54..b66c4d1 100644
--- a/icon-themes/galaxy/sd/cmd/transition-icons.svg
+++ b/icon-themes/galaxy/sd/cmd/transition-icons.svg
@@ -21,19 +21,6 @@
 
-  
-
-
 
-
-
+   height="2.323"
+   x="506.57141"
+   y="640.79797" />
 
-
-
-
-
-
-
-
-
-
+   height="1.524"
+   x="506.57141"
+   y="645.79797" />
 
-
-
-
-
-
-
-
-
-
-
-
-
-
 
-
-
-
-
-
-
 
 
-
+   sodipodi:nodetypes="cc"
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   sodipodi:nodetypes=""
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   transform="matrix(0.70710678,-0.70710678,-0.70710678,-0.70710678,0,0)"
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   sodipodi:nodetypes=""
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   transform="matrix(-0.70710678,-0.70710678,0.70710678,-0.70710678,0,0)"
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   sodipodi:nodetypes=""
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   transform="matrix(-0.70710678,0.70710678,0.70710678,0.70710678,0,0)"
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   sodipodi:nodetypes=""
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
-
+
-
+   r="8"
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
 
-
-
-
 
 
-
-
-
 
-
-
-
-
-
-
-
-
 
 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+   d="m 385.57143,479.798 0,24 30,0 0,-24 z m 1,1 28,0 0,22 -28,0 z"
+   id="rect4160-50-6"
+   inkscape:connector-curvature="0"
+   sodipodi:nodetypes="cc" />
 
+   x="427.65833"
+   y="409.32773"
+   transform="matrix(0.99745857,0.07124892,0,1,0,0)" />
 
+   x="430.05707"
+   y="408.08264"
+   transform="matrix(0.99654557,0.08304779,0,1,0,0)" />
 
+   x="432.71906"
+   y="404.73965"
+   transform="matrix(0.99503693,0.09950632,0,1,0,0)" />
 
+   x="435.93796"
+   y="397.7251"
+   transform="matrix(0.99227747,0.12403798,0,1,0,0)" />
 
+   

[Libreoffice-bugs] [Bug 96875] Submenus of MenuBarManager based context menus don't work (OS X native menus only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96875

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96875] Submenus of MenuBarManager based context menus don't work (OS X native menus only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96875

--- Comment #9 from Commit Notification 
 ---
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cbd483211e1ac9d9e724b5ba3e3e38a0c5abe55c

tdf#96875 Make OS X native context menus compatible

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96896] Writer crashes when frame title is changed via API and user closes print preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96896

--- Comment #3 from castanhe...@uol.com.br ---
Thanks, workaround works at least in 5.0.4.2.
However, when in read-only mode, the expression "(read-only)" is automatically
appended to the title only until you select print preview. After the first
preview, the expression "(read-only)" is replaced by a " : 3" (as is also the
case with edit mode).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96994] Alt shortcuts no longer work in any LO components after updating to 5.0.4.2 from 5.0.3.2.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96994

m.a.riosv  changed:

   What|Removed |Added

 Resolution|FIXED   |NOTABUG

--- Comment #9 from m.a.riosv  ---
David nothing was done to fix a bug.

Right and Left Alt are not the same key like happens with control key, so seems
there was not a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - icon-themes/breeze icon-themes/galaxy

[andreas kainz]

 icon-themes/breeze/chart2/res/gl3dbar_roundrect.png |binary
 icon-themes/galaxy/sd/cmd/transition-comb.png   |binary
 icon-themes/galaxy/sd/cmd/transition-cut.png|binary
 icon-themes/galaxy/sd/cmd/transition-fall.png   |binary
 icon-themes/galaxy/sd/cmd/transition-icons.svg  |  934 +---
 icon-themes/galaxy/sd/cmd/transition-newsflash.png  |binary
 icon-themes/galaxy/sd/cmd/transition-push.png   |binary
 icon-themes/galaxy/sd/cmd/transition-random.png |binary
 icon-themes/galaxy/sd/cmd/transition-tile-flip.png  |binary
 icon-themes/galaxy/sd/cmd/transition-turning-helix.png  |binary
 icon-themes/galaxy/sd/cmd/transition-venetian-blinds-3d.png |binary
 11 files changed, 440 insertions(+), 494 deletions(-)

New commits:
commit 8c65cd00fee2554d6fe40e4da691b04ef79116fc
Author: andreas kainz 
Date:   Mon Jan 11 23:58:56 2016 +0100

Breeze and galaxy transition icons update according to jays recs

Change-Id: I96b0a80962e1dc6925a57e5fe07041f2dccdacc6
Reviewed-on: https://gerrit.libreoffice.org/21375
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 
(cherry picked from commit 2244b1e3863a6837dbc867c51940e52b6525de43)
Signed-off-by: Adolfo Jayme Barrientos 

diff --git a/icon-themes/breeze/chart2/res/gl3dbar_roundrect.png 
b/icon-themes/breeze/chart2/res/gl3dbar_roundrect.png
new file mode 100644
index 000..1b7c410
Binary files /dev/null and 
b/icon-themes/breeze/chart2/res/gl3dbar_roundrect.png differ
diff --git a/icon-themes/galaxy/sd/cmd/transition-comb.png 
b/icon-themes/galaxy/sd/cmd/transition-comb.png
index 6679607..f8cf344 100644
Binary files a/icon-themes/galaxy/sd/cmd/transition-comb.png and 
b/icon-themes/galaxy/sd/cmd/transition-comb.png differ
diff --git a/icon-themes/galaxy/sd/cmd/transition-cut.png 
b/icon-themes/galaxy/sd/cmd/transition-cut.png
index 17f616c..ef1f565 100644
Binary files a/icon-themes/galaxy/sd/cmd/transition-cut.png and 
b/icon-themes/galaxy/sd/cmd/transition-cut.png differ
diff --git a/icon-themes/galaxy/sd/cmd/transition-fall.png 
b/icon-themes/galaxy/sd/cmd/transition-fall.png
index 2744cb4..81bce28 100644
Binary files a/icon-themes/galaxy/sd/cmd/transition-fall.png and 
b/icon-themes/galaxy/sd/cmd/transition-fall.png differ
diff --git a/icon-themes/galaxy/sd/cmd/transition-icons.svg 
b/icon-themes/galaxy/sd/cmd/transition-icons.svg
index d412d54..b66c4d1 100644
--- a/icon-themes/galaxy/sd/cmd/transition-icons.svg
+++ b/icon-themes/galaxy/sd/cmd/transition-icons.svg
@@ -21,19 +21,6 @@
 
-  
-
-
 
-
-
+   height="2.323"
+   x="506.57141"
+   y="640.79797" />
 
-
-
-
-
-
-
-
-
-
+   height="1.524"
+   x="506.57141"
+   y="645.79797" />
 
-
-
-
-
-
-
-
-
-
-
-
-
-
 
-
-
-
-
-
-
 
 
-
+   sodipodi:nodetypes="cc"
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   sodipodi:nodetypes=""
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   transform="matrix(0.70710678,-0.70710678,-0.70710678,-0.70710678,0,0)"
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   sodipodi:nodetypes=""
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   transform="matrix(-0.70710678,-0.70710678,0.70710678,-0.70710678,0,0)"
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   sodipodi:nodetypes=""
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   transform="matrix(-0.70710678,0.70710678,0.70710678,0.70710678,0,0)"
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
+   sodipodi:nodetypes=""
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
-
+
-
+   r="8"
+   inkscape:export-xdpi="90"
+   inkscape:export-ydpi="90" />
 
 
-
-
-
 
 
-
-
-
 
-
-
-
-
-
-
-
-
 
 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+   d="m 385.57143,479.798 0,24 30,0 0,-24 z m 1,1 28,0 0,22 -28,0 z"
+   id="rect4160-50-6"
+   inkscape:connector-curvature="0"
+   sodipodi:nodetypes="cc" />
 
+   x="427.65833"
+   y="409.32773"
+   transform="matrix(0.99745857,0.07124892,0,1,0,0)" />
 
+   x="430.05707"
+   y="408.08264"
+   transform="matrix(0.99654557,0.08304779,0,1,0,0)" />
 
+   x="432.71906"
+   y="404.73965"
+   transform="matrix(0.99503693,0.09950632,0,1,0,0)" />

[Libreoffice-bugs] [Bug 97051] Writer crashes when document has header or footer and you open page style dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97051

futureproj...@gmail.com changed:

   What|Removed |Added

   Severity|normal  |critical

--- Comment #3 from futureproj...@gmail.com ---
Windows 10 Pro, Version 1511 (OS Build 10586.36)
LibreOffice 5.0.4.2, Build ID 2b9802c1994aa0b7dc6079e128979269cf95bc78
Locale en_US

Can confirm bug, crash is reliably reproduceable although I did not get an
"Unknown SEH Exception."

Setting status to NEW and elevating to MEDIUM/CRITICAL since it's a crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97044] Copying sheet inside the same document causes #REF! error if cells have reference to other sheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97044

m.a.riosv  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |DUPLICATE

--- Comment #3 from m.a.riosv  ---


*** This bug has been marked as a duplicate of bug 86652 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86652] links to cells in different sheet of the same calc file break when copying the sheet with links inside the same calc file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86652

m.a.riosv  changed:

   What|Removed |Added

 CC||rjbgas...@gmail.com

--- Comment #10 from m.a.riosv  ---
*** Bug 97044 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96875] Submenus of MenuBarManager based context menus don't work (OS X native menus only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96875

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Maxim Monastirsky  ---
Hope that's fine now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97050] Setting a combobox to read-only disables the control

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97050

--- Comment #3 from libreoff...@voicetechnology.co.uk ---
Created attachment 121864
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121864=edit
Dialog box with one combobox control

I've attached a file with a dialog box triggered from a button on the main
sheet.  The dialog box has one combobox control which has a few entries and
read-only selected.  To me it shows as disabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96994] Alt shortcuts no longer work in any LO components after updating to 5.0.4.2 from 5.0.3.2.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96994

David Brian Minter  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED

--- Comment #8 from David Brian Minter  ---
(In reply to futureproject from comment #7)
> Windows 10 Pro, Version 1511 (OS Build 10586.36)
> LibreOffice 5.0.4.2, Build ID 2b9802c1994aa0b7dc6079e128979269cf95bc78
> Locale en_US
> 
> Can not reproduce.
> 
> I tried reproducing on a freshly installed 5.0.4.2, a freshly installed
> 5.0.3.2, and 5.0.4.2 updated from 5.0.3.2. Neither shows any problems with
> alt-shortcuts.
> 
> Since m.a.riosv is unable to reproduce it too I'm setting this one to
> RESOLVED WORKSFORME.


It's something weird.  Because I tried something new.  I was trying the Alt key
to the right of the space bar when I found the problem before.  The problem is
only on the right Alt key.  If I use the Alt key to the left of the space bar,
Alt+F works.


Please test with both Alt keys and see if you can reproduce it with one Alt key
but not the other.  If you can't, then it's something with my keyboard.  I have
a wireless USB Logitech keyboard.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/qa sd/source

[Marco Cecchetti]

 sd/qa/unit/tiledrendering/tiledrendering.cxx |2 --
 sd/source/ui/view/Outliner.cxx   |2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d6f1ca24932ba85607ba3e526c5721132cd39252
Author: Marco Cecchetti 
Date:   Mon Jan 11 16:43:02 2016 +0100

lool - search all - unit test failure - solved

Change-Id: I5a74dd60f61fc0fdb88f08383d579b14222aa55d
Reviewed-on: https://gerrit.libreoffice.org/21365
Tested-by: Jenkins 
Reviewed-by: Marco Cecchetti 

diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx 
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index b3ac27e..7c14fa9 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -442,7 +442,6 @@ void SdTiledRenderingTest::testSearchAll()
 
 void SdTiledRenderingTest::testSearchAllSelections()
 {
-#if 0
 SdXImpressDocument* pXImpressDocument = createDoc("search-all.odp");
 pXImpressDocument->registerCallback(::callback, this);
 
@@ -451,7 +450,6 @@ void SdTiledRenderingTest::testSearchAllSelections()
 CPPUNIT_ASSERT_EQUAL(static_cast(2), m_nPart);
 // This was 1: only the first match was highlighted.
 CPPUNIT_ASSERT_EQUAL(static_cast(2), m_aSelection.size());
-#endif
 }
 
 #endif
diff --git a/sd/source/ui/view/Outliner.cxx b/sd/source/ui/view/Outliner.cxx
index 69ec222..caf2da7 100644
--- a/sd/source/ui/view/Outliner.cxx
+++ b/sd/source/ui/view/Outliner.cxx
@@ -591,6 +591,8 @@ void Outliner::Initialize (bool bDirectionIsForward)
 
 bool Outliner::SearchAndReplaceAll()
 {
+DetectChange();
+
 bool bRet = true;
 // Save the current position to be restored after having replaced all
 // matches.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 96988] The place to set the language for the document is ridiculously undiscoverable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96988

--- Comment #10 from teo8...@gmail.com ---
> an approach of setting the language of the entirety document in one 
> place wouldn't allow one to have paragraphs or words with different 
> languages

For god's sake did you even read what I wrote??

I'm not talking about disallowing ANYTHING that is currently allowed. I'm only
talking about setting DEFAULTS for a new document, for future documents, or for
the parts of the current document that haven't yet been touched (e.g. cells
that haven't been applied a format or even entered a content).

That is: you start creating a new document and you want all the defaults to be,
let's say, in Italian. You should be able to set that in one place, not a
dozen. You shouldn't go like "Ok, so now let's select a cell and format it as a
number... wait a moment, why do all the options have a comma instead of a dot?
Oh f**k, this is still in English, I have to set the locale too" and so on.

Then you still have all the options to change each thing individually for each
cell, sheet, paragraph, or whatever.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 96337] FORMATTING: When numbering paragraphs, the numbers occasionnally forget their style (bold)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96337

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #4 from Beluga  ---
(In reply to f5d505f9 from comment #2)
> Correction: I was a little bit too quick. The bug is still present, but
> somewhat less severe.

What do you mean? I tried 30 times, but the number was always bold.

Win 7 Pro 64-bit Version: 5.2.0.0.alpha0+
Build ID: 22e5170af74c635cf55d089f97946b6dc86f82ad
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-01-05_23:41:26
Locale: fi-FI (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Gerrit patch set for a regression of Lo 5.1 wrt Lo 5.0

[Giuseppe Castagno]

Hi all,

it seems that LO 5.1 can no longer save to Google Drive.

See:

the Windows test only.

Linux test is not possible due to:


Gerrit patch for master branch at:


Thanks,

--
Kind Regards,
Giuseppe Castagno aka beppec56
Acca Esse http://www.acca-esse.eu
giuseppe.castagno at acca-esse.eu
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - 2 commits - libreofficekit/source

[Caolán McNamara]

 libreofficekit/source/gtk/lokdocview.cxx |   14 ++
 libreofficekit/source/gtk/tilebuffer.hxx |4 
 2 files changed, 10 insertions(+), 8 deletions(-)

New commits:
commit d753e9e41283ca1e0d77001ec1174426451dd7fe
Author: Caolán McNamara 
Date:   Mon Dec 21 09:11:16 2015 +

coverity#1315075 Uninitialized scalar field

Change-Id: I003839589354f02f8064b6a6af6174d2793b9b3a
(cherry picked from commit 92305c3c41d120b868e0821221a583697868ad6d)
Reviewed-on: https://gerrit.libreoffice.org/21271
Reviewed-by: David Tardon 
Tested-by: Jenkins 

diff --git a/libreofficekit/source/gtk/tilebuffer.hxx 
b/libreofficekit/source/gtk/tilebuffer.hxx
index 96100d7..cdd3e70 100644
--- a/libreofficekit/source/gtk/tilebuffer.hxx
+++ b/libreofficekit/source/gtk/tilebuffer.hxx
@@ -267,6 +267,10 @@ struct LOEvent
 , m_nSetGraphicSelectionType(0)
 , m_nSetGraphicSelectionX(0)
 , m_nSetGraphicSelectionY(0)
+, m_nTilePixelWidth(0)
+, m_nTilePixelHeight(0)
+, m_nTileTwipWidth(0)
+, m_nTileTwipHeight(0)
 {
 }
 
commit af32996eb55008b9787516a280a237b61a05ca05
Author: Caolán McNamara 
Date:   Sat Dec 19 15:11:03 2015 +

coverity#1343633 Resource leak

Change-Id: I2384091557c2a3b061e2c60118309f35b65b45d6
(cherry picked from commit 746da6b7fb3829e1ca23a4b8dfec6c502bac681c)
Reviewed-on: https://gerrit.libreoffice.org/21270
Reviewed-by: David Tardon 
Tested-by: Jenkins 

diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 918f292..426773c 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -335,6 +335,9 @@ static void
 doSearch(LOKDocView* pDocView, const char* pText, bool bBackwards, bool 
highlightAll)
 {
 LOKDocViewPrivate& priv = getPrivate(pDocView);
+if (!priv->m_pDocument)
+return;
+
 boost::property_tree::ptree aTree;
 GtkWidget* drawingWidget = GTK_WIDGET(pDocView);
 GdkWindow* drawingWindow = gtk_widget_get_window(drawingWidget);
@@ -342,9 +345,6 @@ doSearch(LOKDocView* pDocView, const char* pText, bool 
bBackwards, bool highligh
 cairo_rectangle_int_t cairoVisRect;
 int x, y;
 
-if (!priv->m_pDocument)
-return;
-
 cairo_region_get_rectangle(cairoVisRegion, 0, );
 x = pixelToTwip (cairoVisRect.x, priv->m_fZoom);
 y = pixelToTwip (cairoVisRect.y, priv->m_fZoom);
@@ -2543,13 +2543,13 @@ SAL_DLLPUBLIC_EXPORT void
 lok_doc_view_set_part (LOKDocView* pDocView, int nPart)
 {
 LOKDocViewPrivate& priv = getPrivate(pDocView);
+if (!priv->m_pDocument)
+return;
+
 GTask* task = g_task_new(pDocView, nullptr, nullptr, nullptr);
 LOEvent* pLOEvent = new LOEvent(LOK_SET_PART);
 GError* error = nullptr;
 
-if (!priv->m_pDocument)
-return;
-
 pLOEvent->m_nPart = nPart;
 g_task_set_task_data(task, pLOEvent, LOEvent::destroy);
 
@@ -2566,7 +2566,6 @@ SAL_DLLPUBLIC_EXPORT gchar*
 lok_doc_view_get_part_name (LOKDocView* pDocView, int nPart)
 {
 LOKDocViewPrivate& priv = getPrivate(pDocView);
-
 if (!priv->m_pDocument)
 return nullptr;
 
@@ -2682,7 +2681,6 @@ lok_doc_view_post_command (LOKDocView* pDocView,
gboolean bNotifyWhenFinished)
 {
 LOKDocViewPrivate& priv = getPrivate(pDocView);
-
 if (!priv->m_pDocument)
 return;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 75972] FILEOPEN: SAXParseException on one .DOCX (summary in comment 7)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75972

--- Comment #8 from Mike Kaganski  ---
Created attachment 121849
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121849=edit
compressed DOCX and PDF

The file opens with Word. It contains 5013 pages. Word works with document very
slowly; repagination takes ~5 min. The archive also contains PDF generated with
Word.

On my system, it opens with Version: 5.0.4.2 (x64)
Build ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78
Locale: ru-RU (ru_RU)
(opening takes ~12 mins; after that it shows first pages), and immidiately
crashes with SEH Exception: ACCESS VIOLATION.
Screenshot is also in attachment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx svx/source

[Miklos Vajna]

 include/svx/svddrag.hxx |   10 +-
 svx/source/engine3d/scene3d.cxx |2 +-
 svx/source/svdraw/svdcrtv.cxx   |6 +++---
 svx/source/svdraw/svddrag.cxx   |2 +-
 svx/source/svdraw/svdoashp.cxx  |2 +-
 svx/source/svdraw/svdobj.cxx|2 +-
 svx/source/svdraw/svdocapt.cxx  |2 +-
 svx/source/svdraw/svdocirc.cxx  |   26 +-
 svx/source/svdraw/svdoedge.cxx  |2 +-
 svx/source/svdraw/svdomeas.cxx  |2 +-
 svx/source/svdraw/svdopath.cxx  |4 ++--
 svx/source/svdraw/svdotxdr.cxx  |2 +-
 svx/source/table/svdotable.cxx  |2 +-
 13 files changed, 32 insertions(+), 32 deletions(-)

New commits:
commit 8fd9020b2b5ae1024dbf866cd84cf28258aba232
Author: Miklos Vajna 
Date:   Mon Jan 11 09:09:14 2016 +0100

svx: SdrDragStat::GetPointAnz() -> GetPointCount()

Change-Id: Ib8728408a81c655c36b46a8483970c38e9a40bc4

diff --git a/include/svx/svddrag.hxx b/include/svx/svddrag.hxx
index ac2a978..ab285bd 100644
--- a/include/svx/svddrag.hxx
+++ b/include/svx/svddrag.hxx
@@ -84,14 +84,14 @@ public:
 SdrPageView* GetPageView() const { return pPageView; }
 void SetPageView(SdrPageView* pPV)   { pPageView=pPV; }
 const Point& GetPoint(sal_uIntPtr nNum) const{ return *aPnts[nNum]; }
-sal_uIntPtrGetPointAnz() const   { return aPnts.size(); }
+sal_uIntPtrGetPointCount() const   { return aPnts.size(); }
 const Point& GetStart() const{ return GetPoint(0); }
 Point&   Start() { return Pnt(0); }
-const Point& GetPrev() const { return 
GetPoint(GetPointAnz()-(GetPointAnz()>=2 ? 2:1)); }
-Point& Prev(){ return 
Pnt(GetPointAnz()-(GetPointAnz()>=2 ? 2:1)); }
+const Point& GetPrev() const { return 
GetPoint(GetPointCount()-(GetPointCount()>=2 ? 2:1)); }
+Point& Prev(){ return 
Pnt(GetPointCount()-(GetPointCount()>=2 ? 2:1)); }
 const Point& GetPos0() const { return aPos0;  }
-const Point& GetNow() const  { return 
GetPoint(GetPointAnz()-1); }
-Point&   Now()   { return 
Pnt(GetPointAnz()-1); }
+const Point& GetNow() const  { return 
GetPoint(GetPointCount()-1); }
+Point&   Now()   { return 
Pnt(GetPointCount()-1); }
 const Point& GetRealNow() const  { return aRealNow; }
 Point&   RealNow()   { return aRealNow; }
 const Point& GetRef1() const { return aRef1;  }
diff --git a/svx/source/engine3d/scene3d.cxx b/svx/source/engine3d/scene3d.cxx
index 2d07749..53d35ac 100644
--- a/svx/source/engine3d/scene3d.cxx
+++ b/svx/source/engine3d/scene3d.cxx
@@ -702,7 +702,7 @@ bool E3dScene::EndCreate(SdrDragStat& rStat, SdrCreateCmd 
eCmd)
 aRect1.Justify();
 NbcSetSnapRect(aRect1);
 SetRectsDirty();
-return (eCmd==SDRCREATE_FORCEEND || rStat.GetPointAnz()>=2);
+return (eCmd==SDRCREATE_FORCEEND || rStat.GetPointCount()>=2);
 }
 
 bool E3dScene::BckCreate(SdrDragStat& /*rStat*/)
diff --git a/svx/source/svdraw/svdcrtv.cxx b/svx/source/svdraw/svdcrtv.cxx
index d9140bf..0e4719f 100644
--- a/svx/source/svdraw/svdcrtv.cxx
+++ b/svx/source/svdraw/svdcrtv.cxx
@@ -601,7 +601,7 @@ bool SdrCreateView::EndCreateObj(SdrCreateCmd eCmd)
 
 if (pAktCreate!=nullptr)
 {
-sal_uIntPtr nCount=maDragStat.GetPointAnz();
+sal_uIntPtr nCount=maDragStat.GetPointCount();
 
 if (nCount<=1 && eCmd==SDRCREATE_FORCEEND)
 {
@@ -710,7 +710,7 @@ void SdrCreateView::BckCreateObj()
 {
 if (pAktCreate!=nullptr)
 {
-if (maDragStat.GetPointAnz()<=2 )
+if (maDragStat.GetPointCount()<=2 )
 {
 BrkCreateObj();
 }
@@ -791,7 +791,7 @@ void SdrCreateView::ShowCreateObj(/*OutputDevice* pOut, 
sal_Bool bFull*/)
 if(pCircObj && OBJ_CIRC != pCircObj->GetObjIdentifier())
 {
 // #i103058# Allow SolidDragging with four points
-if(maDragStat.GetPointAnz() < 4)
+if(maDragStat.GetPointCount() < 4)
 {
 bUseSolidDragging = false;
 }
diff --git a/svx/source/svdraw/svddrag.cxx b/svx/source/svdraw/svddrag.cxx
index 91cd2d1..411cc91 100644
--- a/svx/source/svdraw/svddrag.cxx
+++ b/svx/source/svdraw/svddrag.cxx
@@ -127,7 +127,7 @@ Fraction SdrDragStat::GetYFact() const
 void SdrDragStat::TakeCreateRect(Rectangle& rRect) const
 {
 rRect=Rectangle(GetStart(),GetNow());
-if (GetPointAnz()>=2) {
+if (GetPointCount()>=2) {
 Point aBtmRgt(GetPoint(1));
 rRect.Right()=aBtmRgt.X();
 rRect.Bottom()=aBtmRgt.Y();
diff --git 

[Libreoffice-bugs] [Bug 97033] EDITING - ODB file crashes when editing tables, queries, forms....

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97033

Alex Thurgood  changed:

   What|Removed |Added

   Priority|medium  |highest

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97033] EDITING - ODB file crashes when editing tables, queries, forms....

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97033

Alex Thurgood  changed:

   What|Removed |Added

 CC||lio...@mamane.lu,
   ||rob...@familiegrosskopf.de,
   ||serval2...@yahoo.fr

--- Comment #2 from Alex Thurgood  ---
Confirmed by Julien in comment 14 of bug 96938

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97033] EDITING - ODB file crashes when editing tables, queries, forms....

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97033

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96929] Cannot started Libreoffice when install addition language KeyID

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96929

kompilainenn <79045_79...@mail.ru> changed:

   What|Removed |Added

Summary|Cannot started Libreoffice  |Cannot started Libreoffice
   |when install addition   |when install addition
   |language Identifier |language KeyID

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96929] Cannot started Libreoffice when install addition language Identifier

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96929

--- Comment #4 from kompilainenn <79045_79...@mail.ru> ---
Created attachment 121845
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121845=edit
KeyID

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96929] Cannot started Libreoffice when install addition language Identifier

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96929

--- Comment #3 from kompilainenn <79045_79...@mail.ru> ---
(In reply to Beluga from comment #2)
> Where can we get this language identifier?

oh...in locale EN this is KeyID

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97034] Find & replace results in crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97034

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Please try resetting the user profile, sometimes solves strange issues.
https://wiki.documentfoundation.org/UserProfile
Usually it's enough renaming/deleting the file
"user/registrymodifications.xcu",  it affect all the options in
Menu/Tools/Options, and the files "user/basic/dialog.xlc" and "scrip.xlc" are
overwritten, additionally custom colors in "user/config/standard.soc" are lost.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92623] mail merge crashes between step 6 and 7

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92623

--- Comment #10 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-5-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cce1320efa93cc42300e457b898d892ca580ddca=libreoffice-5-0

tdf#92623 Handle StartOfContent node for copying bookmarks

It will be available in 5.0.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/android vcl/null

[Miklos Vajna]

 vcl/android/androidinst.cxx |2 +-
 vcl/null/printerinfomanager.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 9b948d7a9690e8b418f25a1036b22ea53e23c36a
Author: Miklos Vajna 
Date:   Mon Jan 11 10:11:38 2016 +0100

vcl: fix Android build

Change-Id: I05ce4ddb4c933eb1100e3a3410cea27520072933

diff --git a/vcl/android/androidinst.cxx b/vcl/android/androidinst.cxx
index 1b46fe2..1353c44 100644
--- a/vcl/android/androidinst.cxx
+++ b/vcl/android/androidinst.cxx
@@ -15,7 +15,7 @@
 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/vcl/null/printerinfomanager.cxx b/vcl/null/printerinfomanager.cxx
index 497d370..04539b3 100644
--- a/vcl/null/printerinfomanager.cxx
+++ b/vcl/null/printerinfomanager.cxx
@@ -19,7 +19,7 @@
 
 #include "vcl/printerinfomanager.hxx"
 
-#include "generic/gendata.hxx"
+#include "unx/gendata.hxx"
 
 using namespace psp;
 using namespace osl;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 92623] mail merge crashes between step 6 and 7

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92623

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0 target:5.1.0.2 |target:5.2.0 target:5.1.0.2
   ||target:5.0.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96929] Cannot started Libreoffice when install addition language Identifier

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96929

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #2 from Beluga  ---
Where can we get this language identifier?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96941] FORMATTING: Possible regression - Connector Line paths messed up after saving and reopening

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96941

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Beluga  ---
Please attach an example file that messes up.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the document.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97034] New: Find & replace results in crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97034

Bug ID: 97034
   Summary: Find & replace results in crash
   Product: LibreOffice
   Version: 5.0.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: louisewhi...@bigpond.com

I have recently migrated from Open Office.  I write lengthy reports and always
use a past document as the base for the new document.  Since moving to
LibreOffice, I am experiencing a crash almost every time I attempt to use 'find
and replace'.  Sometimes it works for the first one, but on subsequent ones it 
crashes after I have pressed "Replace All'.  Have tried with a completely new
document as a test and the same thing happens. Happens whether I use the icon
on the toolbar or go through EDIT.  Also, I save the document before I go to
'find and replace', however if it crashes the last save is not always
acknowledged. Frustrating, but otherwise a fabulous program guys.  Thanks to
all involved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:5.2.0   | target:5.2.0
   |target:5.1.0.2  |target:5.1.0.2 target:5.0.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96479] Bookmark end node is destroyed by inserting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96479

--- Comment #14 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-5-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=107664a977c4893a0bc02f10cd20411c330b6d94=libreoffice-5-0

tdf#96479 workaround bookmark end pos handling...

It will be available in 5.0.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Ras-al-Ghul]

 vcl/source/window/dialog.cxx |   12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

New commits:
commit 9a562c6f8075d55b92150ae70a595da69ab9fac8
Author: Ras-al-Ghul 
Date:   Sun Jan 10 03:59:15 2016 +0530

tdf#96888 Kill internal vcl dog-tags ..

Added an assert statement and corrected a glaring error regarding clear() 
usage

Change-Id: Icc8ce940a6f97570d37389530f9fd90890ae8055
Reviewed-on: https://gerrit.libreoffice.org/21280
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index 066ac97..e8d8d47 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -865,10 +865,6 @@ short Dialog::Execute()
 
 VclPtr xWindow = this;
 
-#ifdef DBG_UTIL
-VclPtr xDialogParent = mpDialogParent;
-#endif
-
 // Yield util EndDialog is called or dialog gets destroyed
 // (the latter should not happen, but better safe than sorry
 while ( !xWindow->IsDisposed() && mbInExecute )
@@ -877,13 +873,7 @@ short Dialog::Execute()
 ImplEndExecuteModal();
 
 #ifdef DBG_UTIL
-if( xDialogParent  )
-{
-if( ! xDialogParent->IsDisposed() )
-xDialogParent.clear();
-else
-OSL_FAIL( "Dialog::Execute() - Parent of dialog destroyed in 
Execute()" );
-}
+assert (!mpDialogParent || !mpDialogParent->IsDisposed());
 #endif
 if ( !xWindow->IsDisposed() )
 xWindow.clear();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - include/oox oox/source sd/CppunitTest_sd_export_tests.mk sd/qa

[Michael Stahl]

 include/oox/export/shapes.hxx |2 
 oox/source/export/shapes.cxx  |6 --
 sd/CppunitTest_sd_export_tests.mk |5 +
 sd/qa/unit/export-tests.cxx   |  107 ++
 sd/qa/unit/sdmodeltestbase.hxx|   20 ---
 5 files changed, 116 insertions(+), 24 deletions(-)

New commits:
commit 92266dd8267481b654efd0dd76f1d145f9dc9e18
Author: Michael Stahl 
Date:   Mon Jan 11 11:03:18 2016 +0100

sd: with any luck the OLE test should run on WNT now too

... with the new implementation in oox.

Change-Id: I65aca6e4151ad7383d45c60430132a45ae3a001e

diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx
index 5b1daf5..102a3f4 100644
--- a/sd/qa/unit/export-tests.cxx
+++ b/sd/qa/unit/export-tests.cxx
@@ -140,9 +140,7 @@ public:
 
 void testFdo90607();
 void testTdf91378();
-#if !defined WNT
 void testBnc822341();
-#endif
 void testTdf80224();
 void testTdf92527();
 
@@ -181,9 +179,7 @@ public:
 CPPUNIT_TEST(testTransparentBackground);
 CPPUNIT_TEST(testTdf91378);
 
-#if !defined WNT
 CPPUNIT_TEST(testBnc822341);
-#endif
 CPPUNIT_TEST(testTdf80224);
 
 CPPUNIT_TEST(testExportTransitionsPPTX);
@@ -1085,8 +1081,6 @@ void SdExportTest::testTdf91378()
 xDocShRef->DoClose();
 }
 
-#if !defined WNT
-
 void SdExportTest::testBnc822341()
 {
 // Check import / export of embedded text document
@@ -1157,8 +1151,6 @@ void SdExportTest::testBnc822341()
 xDocShRef->DoClose();
 }
 
-#endif
-
 void SdExportTest::testBulletMarginAndIndentation()
 {
 ::sd::DrawDocShellRef xDocShRef = loadURL( 
getURLFromSrc("/sd/qa/unit/data/pptx/bulletMarginAndIndent.pptx"), PPTX );
commit 7dbdd410daeb6f51127da511990e98e77c62cd83
Author: Michael Stahl 
Date:   Mon Jan 11 11:02:01 2016 +0100

sd: enhance the OLE object test to also test the exported XML

Needs adding various helpers to be able to use XPath.

Change-Id: Ifa7b1e5434fb253430da2bfcc5d38ea347d437af

diff --git a/sd/CppunitTest_sd_export_tests.mk 
b/sd/CppunitTest_sd_export_tests.mk
index 3384377..5e5bafd 100644
--- a/sd/CppunitTest_sd_export_tests.mk
+++ b/sd/CppunitTest_sd_export_tests.mk
@@ -11,7 +11,10 @@
 
 $(eval $(call gb_CppunitTest_CppunitTest,sd_export_tests))
 
-$(eval $(call gb_CppunitTest_use_external,sd_export_tests,boost_headers))
+$(eval $(call gb_CppunitTest_use_externals,sd_export_tests,\
+   boost_headers \
+   libxml2 \
+))
 
 $(eval $(call gb_CppunitTest_add_exception_objects,sd_export_tests, \
 sd/qa/unit/export-tests \
diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx
index 3ddde53..5b1daf5 100644
--- a/sd/qa/unit/export-tests.cxx
+++ b/sd/qa/unit/export-tests.cxx
@@ -9,6 +9,7 @@
 #include 
 #include "sdmodeltestbase.hxx"
 #include "Outliner.hxx"
+#include 
 #include 
 #include 
 #include 
@@ -40,6 +41,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -64,6 +66,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -99,7 +102,7 @@ CPPUNIT_NS_END
 using namespace css;
 using namespace css::animations;
 
-class SdExportTest : public SdModelTestBase
+class SdExportTest : public SdModelTestBase, public XmlTestTools
 {
 public:
 void testN821567();
@@ -187,6 +190,58 @@ public:
 CPPUNIT_TEST(testTdf92527);
 
 CPPUNIT_TEST_SUITE_END();
+
+virtual void registerNamespaces(xmlXPathContextPtr& pXmlXPathCtx) override
+{
+struct { char const * pPrefix; char const * pURI; } namespaces[] =
+{
+// ODF
+{ "draw", "urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" },
+{ "fo", 
"urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" },
+{ "number", "urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
},
+{ "office", "urn:oasis:names:tc:opendocument:xmlns:office:1.0" },
+{ "style", "urn:oasis:names:tc:opendocument:xmlns:style:1.0" },
+{ "svg", 
"urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" },
+{ "table", "urn:oasis:names:tc:opendocument:xmlns:table:1.0" },
+{ "text", "urn:oasis:names:tc:opendocument:xmlns:text:1.0" },
+{ "xlink", "http://www.w3c.org/1999/xlink; },
+// OOXML
+{ "ContentType", 
"http://schemas.openxmlformats.org/package/2006/content-types; },
+{ "rels", 
"http://schemas.openxmlformats.org/package/2006/relationships; },
+{ "mc", 
"http://schemas.openxmlformats.org/markup-compatibility/2006; },
+{ "v", "urn:schemas-microsoft-com:vml" },
+{ "a", "http://schemas.openxmlformats.org/drawingml/2006/main; },
+{ "c", "http://schemas.openxmlformats.org/drawingml/2006/chart; },
+{ "pic", 
"http://schemas.openxmlformats.org/drawingml/2006/picture; },
+{ "wp", 

[Libreoffice-bugs] [Bug 96991] EDITING Issues when creating tables and editing fields 5.x

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96991

Alex Thurgood  changed:

   What|Removed |Added

Version|unspecified |5.0.3.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: minutes of ESC call ...

[Jan Holesovsky]

Hi all,

Michael Meeks píše v Čt 07. 01. 2016 v 16:11 +:

> + 5.1.0 RC2
> + deadline early next week for 5.1.0 RC2 & branch & hard-code-freeze.

There is one late feature we (the Design team) would like to ask for
late inclusion; sorry for not discussing it in the ESC on Thursday:

https://gerrit.libreoffice.org/#/c/21260/

The background:

To avoid too many 'Save' buttons in the toolbar ('normal' save, Save As,
Save Remote File, etc.), the solution taken was to introduce a dropdown
for the Save button where the less used functionality would be present
and accessible to the user.

Unfortunately that introduced a problem when the 'Save' button is
disabled: What to do with the dropdown when the Save itself is disabled?
How to behave the most logical way?

The solution (in the above gerrit request):

After some discussion & competitive analysis, we decided to kill the
possibility to disable Save, ie. now Save is always enabled.

We had an option for 'never disabling Save' already before, but we did
not make it the default yet, as too many people were using that as an
indicator of the changes in the document.

To provide the indicator functionality, now the 'Save' icon changes when
there are unsaved changes, and we'll have an alternative design (save
icon with an added asterisk) for the "unsaved changes present" state.
The updated icon is still to be provided, but should be in time for the
RC2 tagging.

Hope there are no concerns; the only alternative would be to revert the
Save-related changes.

+1's in gerrit appreciated, big thanks to Maxim for implementing the
feature & Samuel for backporting to libreoffice-5-1 gerrit.

Thank you,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97008] "Select all (ctrl+a)" does not work with a header and first paragraph of body text is hidden

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97008

Luke Picciau  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82214] SVG image causes UI freeze when scrolling and slow export of PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82214

Armin Le Grand  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 QA Contact||armin.le.gr...@me.com

--- Comment #22 from Armin Le Grand  ---
Looking deeper. Despite much data being processed, it is not (only) the
renderer. I will check what can be done with the processing what means without
touching the renderer for now...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: dbaccess/source

[Stephan Bergmann]

 dbaccess/source/core/api/RowSetCache.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit cd9a016116e07e6ac08dcdd3b08b3d070469cedc
Author: Stephan Bergmann 
Date:   Mon Jan 11 10:15:07 2016 +0100

-Werror=unused-but-set-variable

Change-Id: I8d2870dc003185598977876e4ff54af74645bc90

diff --git a/dbaccess/source/core/api/RowSetCache.cxx 
b/dbaccess/source/core/api/RowSetCache.cxx
index f1b81a1..ca288c4 100644
--- a/dbaccess/source/core/api/RowSetCache.cxx
+++ b/dbaccess/source/core/api/RowSetCache.cxx
@@ -873,8 +873,6 @@ void ORowSetCache::moveWindow()
 return;
 }
 
-bool bRet = true;
-
 sal_Int32 nDiff = (m_nFetchSize - 1) / 2;
 sal_Int32 nNewStartPos  = (m_nPosition - nDiff) - 1; //m_nPosition is 
1-based, but m_nStartPos is 0-based
 sal_Int32 nNewEndPos= nNewStartPos + m_nFetchSize;
@@ -963,7 +961,7 @@ void ORowSetCache::moveWindow()
 }
 else
 {// no rows can be reused so fill again
-bRet = reFillMatrix(nNewStartPos,nNewEndPos);
+reFillMatrix(nNewStartPos,nNewEndPos);
 }
 }
 
@@ -1076,7 +1074,7 @@ void ORowSetCache::moveWindow()
 }
 }
 else // no rows can be reused so fill again
-bRet = reFillMatrix(nNewStartPos,nNewEndPos);
+reFillMatrix(nNewStartPos,nNewEndPos);
 }
 
 if(!m_bRowCountFinal)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97035] FILEOPEN: RTF wrong cell width

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97035

--- Comment #2 from Guillaume Smaha  ---
Created attachment 121848
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121848=edit
RTF file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - basic/source compilerplugins/clang desktop/source editeng/source extensions/source

[Noel Grandin]

 basic/source/sbx/sbxdec.cxx   |1 
 compilerplugins/clang/unusedmethods.py|2 -
 desktop/source/deployment/dp_persmap.cxx  |6 
+--
 desktop/source/deployment/gui/dp_gui_dialog2.cxx  |   18 
+++---
 desktop/source/deployment/gui/dp_gui_dialog2.hxx  |8 
++--
 desktop/source/deployment/gui/dp_gui_theextmgr.cxx|9 
++---
 desktop/source/deployment/gui/dp_gui_theextmgr.hxx|2 -
 desktop/source/deployment/inc/dp_persmap.h|2 -
 desktop/source/deployment/registry/component/dp_component.cxx |   12 
++
 desktop/source/deployment/registry/configuration/dp_configuration.cxx |7 
+--
 desktop/source/migration/services/basicmigration.cxx  |8 
+---
 desktop/source/migration/services/basicmigration.hxx  |2 -
 desktop/source/migration/services/oo3extensionmigration.cxx   |8 
+---
 desktop/source/migration/services/oo3extensionmigration.hxx   |2 -
 desktop/source/migration/services/wordbookmigration.cxx   |8 
+---
 desktop/source/migration/services/wordbookmigration.hxx   |2 -
 editeng/source/editeng/editdoc.cxx|   13 
---
 editeng/source/editeng/editdoc.hxx|2 -
 editeng/source/editeng/impedit.hxx|2 -
 editeng/source/editeng/impedit2.cxx   |4 --
 editeng/source/editeng/textconv.cxx   |3 -
 editeng/source/editeng/textconv.hxx   |2 -
 extensions/source/abpilot/datasourcehandling.cxx  |3 -
 extensions/source/abpilot/datasourcehandling.hxx  |2 -
 extensions/source/propctrlr/pcrcommon.hxx |3 -
 extensions/source/propctrlr/propertyeditor.cxx|8 
+---
 extensions/source/propctrlr/propertyeditor.hxx|2 -
 extensions/source/propctrlr/standardcontrol.cxx   |4 --
 extensions/source/propctrlr/standardcontrol.hxx   |2 -
 extensions/source/propctrlr/unourl.hxx|3 -
 extensions/source/propctrlr/xsdvalidationpropertyhandler.cxx  |7 
+--
 extensions/source/propctrlr/xsdvalidationpropertyhandler.hxx  |2 -
 32 files changed, 53 insertions(+), 106 deletions(-)

New commits:
commit 9a64d7f8ddbd27020c1e9eb3866efbfaa62c8be5
Author: Noel Grandin 
Date:   Mon Jan 11 11:54:23 2016 +0200

fix windows build

Change-Id: Ie00d2dd3fbf6ff498c652249797f8d01acef8a97

diff --git a/basic/source/sbx/sbxdec.cxx b/basic/source/sbx/sbxdec.cxx
index 8938e2f..8a956c8 100644
--- a/basic/source/sbx/sbxdec.cxx
+++ b/basic/source/sbx/sbxdec.cxx
@@ -387,7 +387,6 @@ void SbxDecimal::getString( OUString& rString )
 
 SysFreeString( aBStr );
 }
-return bRet;
 #else
 (void)rString;
 #endif
commit 1ea49b5baeb415038129b4f1e0b5a331b32365d5
Author: Noel Grandin 
Date:   Mon Jan 11 11:54:13 2016 +0200

loplugin:unusedmethods unused return value in extensions

Change-Id: I449ecdb734e796813384a5d015e9ecabe28079eb

diff --git a/editeng/source/editeng/editdoc.cxx 
b/editeng/source/editeng/editdoc.cxx
index baf72de..fddb247 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -2940,19 +2940,6 @@ bool CharAttribList::HasBoundingAttrib( sal_Int32 nBound 
) const
 return false;
 }
 
-const EditCharAttrib* CharAttribList::FindEmptyAttrib( sal_uInt16 nWhich, 
sal_Int32 nPos ) const
-{
-if ( !bHasEmptyAttribs )
-return nullptr;
-
-for (const std::unique_ptr& rAttr : aAttribs)
-{
-if (rAttr->GetStart() == nPos && rAttr->GetEnd() == nPos && 
rAttr->Which() == nWhich)
-return rAttr.get();
-}
-return nullptr;
-}
-
 EditCharAttrib* CharAttribList::FindEmptyAttrib( sal_uInt16 nWhich, sal_Int32 
nPos )
 {
 if ( !bHasEmptyAttribs )
diff --git a/editeng/source/editeng/editdoc.hxx 
b/editeng/source/editeng/editdoc.hxx
index ebdfb09..9fca927 100644
--- a/editeng/source/editeng/editdoc.hxx
+++ b/editeng/source/editeng/editdoc.hxx
@@ -201,7 +201,6 @@ public:
 const EditCharAttrib* FindAttrib( sal_uInt16 nWhich, sal_Int32 nPos ) 
const;
 EditCharAttrib* FindAttrib( sal_uInt16 nWhich, sal_Int32 nPos );
 const EditCharAttrib* FindNextAttrib( sal_uInt16 nWhich, sal_Int32 
nFromPos ) const;
-const EditCharAttrib* FindEmptyAttrib( sal_uInt16 nWhich, sal_Int32 nPos ) 
const;
 EditCharAttrib* FindEmptyAttrib( sal_uInt16 nWhich, sal_Int32 nPos );
 const EditCharAttrib* FindFeature( sal_Int32 nPos ) const;
 
@@ 

[Libreoffice-commits] core.git: vcl/source

[Michael Meeks]

 vcl/source/window/status.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 3f5a9ca46efc801f79cdc00a3583646936bec689
Author: Michael Meeks 
Date:   Sat Jan 9 23:32:00 2016 +

tdf#96655 - clear non-offscreen status bar controls before render.

Change-Id: I02a85ae4572dc23df2157af1cf164a0f82701613
Reviewed-on: https://gerrit.libreoffice.org/21300
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 

diff --git a/vcl/source/window/status.cxx b/vcl/source/window/status.cxx
index ffd3541..9a45ee6 100644
--- a/vcl/source/window/status.cxx
+++ b/vcl/source/window/status.cxx
@@ -698,7 +698,7 @@ void StatusBar::MouseButtonDown( const MouseEvent& rMEvt )
 }
 }
 
-void StatusBar::Paint(vcl::RenderContext& rRenderContext, const Rectangle&)
+void StatusBar::Paint(vcl::RenderContext& rRenderContext, const Rectangle& 
rRect)
 {
 if (mbFormat)
 ImplFormat();
@@ -737,10 +737,11 @@ void StatusBar::Paint(vcl::RenderContext& rRenderContext, 
const Rectangle&)
 if( OpenGLWrapper::isVCLOpenGLEnabled() )
 bOffscreen = false;
 
+if (!bOffscreen)
+rRenderContext.Erase(rRect);
+
 for (sal_uInt16 i = 0; i < nItemCount; i++)
-{
 ImplDrawItem(rRenderContext, bOffscreen, i, true, true);
-}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96942] Some dialogs show multiple and wrong languages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96942

erik  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from erik  ---
Hello,

Installed the version 5 over version 4.4 (without uninstalling 4.4 - why would
that be necessary?).
Downloaded the v.5 (english version) and started the update.
The whole installation procedure was still in finnish for some peculiar reason
(I downloaded the english version), but once v.5 was installed I didn't get
mixed-language dialogs any longer.

The annoying ongoing feature with mixed-language dialogs is fixed in v. 5 -
Thank You.

However, the language in the installation procedure is still dictated by
localisation rather than the language of the downloaded update.
That final fix of the installation script would be greatly appreciated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - vcl/opengl

[Michael Meeks]

 vcl/opengl/salbmp.cxx |   24 ++--
 1 file changed, 18 insertions(+), 6 deletions(-)

New commits:
commit c332ed4794dc0ae818416b36aa5295a9dd34c9c6
Author: Michael Meeks 
Date:   Sat Jan 9 21:25:12 2016 +

tdf#96550 - vcl opengl - fix BGR/RGB swap for some 8-bit icons.

Change-Id: Ic71b8a94cabc392e7b83df70c1691de8f4c12b43
Reviewed-on: https://gerrit.libreoffice.org/21295
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/vcl/opengl/salbmp.cxx b/vcl/opengl/salbmp.cxx
index 9e59e23..03497dc 100644
--- a/vcl/opengl/salbmp.cxx
+++ b/vcl/opengl/salbmp.cxx
@@ -472,13 +472,25 @@ GLuint OpenGLSalBitmap::CreateTexture()
 pSrcFormat->StartLine( pSrcData );
 
 sal_uInt32 nX = mnBufWidth;
-while( nX-- )
+if (nFormat == GL_BGR)
 {
-const BitmapColor& c = pSrcFormat->ReadPixel();
-
-*pDstData++ = c.GetRed();
-*pDstData++ = c.GetGreen();
-*pDstData++ = c.GetBlue();
+while( nX-- )
+{
+const BitmapColor& c = pSrcFormat->ReadPixel();
+*pDstData++ = c.GetBlue();
+*pDstData++ = c.GetGreen();
+*pDstData++ = c.GetRed();
+}
+}
+else // RGB
+{
+while( nX-- )
+{
+const BitmapColor& c = pSrcFormat->ReadPixel();
+*pDstData++ = c.GetRed();
+*pDstData++ = c.GetGreen();
+*pDstData++ = c.GetBlue();
+}
 }
 
 pSrcData += mnBytesPerRow;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - 2 commits - libreofficekit/source

[Caolán McNamara]

 libreofficekit/source/gtk/lokdocview.cxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 699b5e361d1f75b1414a351dfe4d05d88e2b49e2
Author: Caolán McNamara 
Date:   Sat Dec 19 15:09:10 2015 +

coverity#1343632 Resource leak

Change-Id: I79bf35a4c1a2f0463abc202f6c2b104ffdd5139c
(cherry picked from commit 5b05a3fa2d6873c1046a959c545db133b1974e2c)
Reviewed-on: https://gerrit.libreoffice.org/21269
Reviewed-by: David Tardon 
Tested-by: Jenkins 

diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 6ce7344..918f292 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -2579,13 +2579,13 @@ lok_doc_view_set_partmode(LOKDocView* pDocView,
   int nPartMode)
 {
 LOKDocViewPrivate& priv = getPrivate(pDocView);
+if (!priv->m_pDocument)
+return;
+
 GTask* task = g_task_new(pDocView, nullptr, nullptr, nullptr);
 LOEvent* pLOEvent = new LOEvent(LOK_SET_PARTMODE);
 GError* error = nullptr;
 
-if (!priv->m_pDocument)
-return;
-
 pLOEvent->m_nPartMode = nPartMode;
 g_task_set_task_data(task, pLOEvent, LOEvent::destroy);
 
commit 195866b16f044bc792526145b739602166ca7276
Author: Caolán McNamara 
Date:   Sat Dec 19 15:08:01 2015 +

coverity#1343631 Resource leak

Change-Id: Ic5d7c88ae4080c2e103fb691c2e326a9e239aa12
(cherry picked from commit 169298fa73d2c5429d1960db6049a4ed15653b4f)
Reviewed-on: https://gerrit.libreoffice.org/21268
Reviewed-by: David Tardon 
Tested-by: Jenkins 

diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index ae8e52a..6ce7344 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -2649,13 +2649,13 @@ lok_doc_view_set_edit(LOKDocView* pDocView,
   gboolean bEdit)
 {
 LOKDocViewPrivate& priv = getPrivate(pDocView);
+if (!priv->m_pDocument)
+return;
+
 GTask* task = g_task_new(pDocView, nullptr, nullptr, nullptr);
 LOEvent* pLOEvent = new LOEvent(LOK_SET_EDIT);
 GError* error = nullptr;
 
-if (!priv->m_pDocument)
-return;
-
 pLOEvent->m_bEdit = bEdit;
 g_task_set_task_data(task, pLOEvent, LOEvent::destroy);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 93529] Meta: VCL/OpenGL tracker bug for 5.0+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93529
Bug 93529 depends on bug 95053, which changed state.

Bug 95053 Summary: Chart Y Axis Vertical Title invisible, if OpenGL enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=95053

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95053] Chart Y Axis Vertical Title invisible, if OpenGL enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95053

Michael Meeks  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #18 from Michael Meeks  ---
Working nicely for me on both windows and Linux. Please can you test again with
5.1.0 RC2 (due out this week) and re-open if it persists ? so much has been
fixed in the GL / VCL impl. since 5.0.0.

Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97033] New: EDITING - ODB file crashes when editing tables, queries, forms....

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97033

Bug ID: 97033
   Summary: EDITING - ODB file crashes when editing tables,
queries, forms
   Product: LibreOffice
   Version: 5.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: critical
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ipla...@yahoo.co.uk

Created attachment 121843
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121843=edit
test odb file

This is a clone of bug 96938 which affects current master builds

LibreOffice crashes when editing the attached .odb file.  Base will open the
file but as soon as I try do anything (access a table, query, form...), all
LibreOffice windows will close without any error message, and a restart
ofLibreOffice opens in recovery mode.

If I open this ODB file in my master build with lldb running, I see this :

warn:unoxml:45295:13:unoxml/source/dom/documentbuilder.cxx:296: libxml2 error:
Extra content at the end of the document
Line: 544
Column: 1

Note that I see this after having attempted to change the first record in the
very first table and seein LOdev bomb out on me when I tried to save the change
or close the table window (I ignored the auto-recovery).

This is the output when attempting to save a change to the first record of the
first table :
warn:vcl:45295:1:vcl/source/window/mouse.cxx:472: Window::ReleaseMouse():
window doesn't have the mouse capture
warn:legacy.osl:45295:1:include/cppuhelper/interfacecontainer.h:479: object is
disposed
warn:legacy.osl:45295:1:include/cppuhelper/interfacecontainer.h:479: object is
disposed
warn:legacy.osl:45295:9:connectivity/source/drivers/hsqldb/HStorageAccess.cxx:369:
No Seekable stream!
warn:legacy.osl:45295:9:connectivity/source/drivers/hsqldb/HStorageAccess.cxx:221:
Input stream is NULL!
2016-01-07T15:41:48.504+0100  SEVERE  DataFileCache.setFileModified
java.io.IOException: Stream is not valid
at com.sun.star.sdbcx.comp.hsqldb.NativeStorageAccess.read(Native Method)
at
com.sun.star.sdbcx.comp.hsqldb.StorageAccess.readInt(StorageAccess.java:66)
at org.hsqldb.persist.RAStorageWrapper.readInt(Unknown Source)
at org.hsqldb.persist.DataFileCache.setFileModified(Unknown Source)
at org.hsqldb.persist.DataFileCache.saveRows(Unknown Source)
at org.hsqldb.persist.Cache.saveRows(Unknown Source)
at org.hsqldb.persist.Cache.saveAll(Unknown Source)
at org.hsqldb.persist.DataFileCache.defrag(Unknown Source)
at org.hsqldb.persist.Log.defrag(Unknown Source)
at org.hsqldb.persist.Log.checkpoint(Unknown Source)
at org.hsqldb.persist.Logger.checkpointInternal(Unknown Source)
at org.hsqldb.persist.Logger.checkpoint(Unknown Source)
at org.hsqldb.StatementCommand.getResult(Unknown Source)
at org.hsqldb.StatementCommand.execute(Unknown Source)
at org.hsqldb.Session.executeCompiledStatement(Unknown Source)
at org.hsqldb.Session.executeDirectStatement(Unknown Source)
at org.hsqldb.Session.execute(Unknown Source)
at org.hsqldb.jdbc.JDBCStatement.fetchResult(Unknown Source)
at org.hsqldb.jdbc.JDBCStatement.execute(Unknown Source)


Process 45295 stopped
* thread #1: tid = 0x61b20a, 0x0001067c717e
libtllo.dylib`DbgUnhandledException(com::sun::star::uno::Any const&, char
const*, char const*) + 926, queue = 'com.apple.main-thread', stop reason =
signal SIGSEGV
frame #0: 0x0001067c717e
libtllo.dylib`DbgUnhandledException(com::sun::star::uno::Any const&, char
const*, char const*) + 926
libtllo.dylib`DbgUnhandledException(com::sun::star::uno::Any const&, char
const*, char const*):
->  0x1067c717e <+926>: movq   0x8(%rcx), %rcx
0x1067c7182 <+930>: movq   %rcx, -0x80(%rbp)
0x1067c7186 <+934>: leaq   0xb5935(%rip), %rsi   ; "\ncontext: "
0x1067c718d <+941>: leaq   -0x88(%rbp), %rdi

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Libreoffice-qa] minutes of ESC call ...

[Jan Holesovsky]

Hi all,

Michael Meeks píše v Čt 07. 01. 2016 v 16:11 +:

> + 5.1.0 RC2
> + deadline early next week for 5.1.0 RC2 & branch & hard-code-freeze.

There is one late feature we (the Design team) would like to ask for
late inclusion; sorry for not discussing it in the ESC on Thursday:

https://gerrit.libreoffice.org/#/c/21260/

The background:

To avoid too many 'Save' buttons in the toolbar ('normal' save, Save As,
Save Remote File, etc.), the solution taken was to introduce a dropdown
for the Save button where the less used functionality would be present
and accessible to the user.

Unfortunately that introduced a problem when the 'Save' button is
disabled: What to do with the dropdown when the Save itself is disabled?
How to behave the most logical way?

The solution (in the above gerrit request):

After some discussion & competitive analysis, we decided to kill the
possibility to disable Save, ie. now Save is always enabled.

We had an option for 'never disabling Save' already before, but we did
not make it the default yet, as too many people were using that as an
indicator of the changes in the document.

To provide the indicator functionality, now the 'Save' icon changes when
there are unsaved changes, and we'll have an alternative design (save
icon with an added asterisk) for the "unsaved changes present" state.
The updated icon is still to be provided, but should be in time for the
RC2 tagging.

Hope there are no concerns; the only alternative would be to revert the
Save-related changes.

+1's in gerrit appreciated, big thanks to Maxim for implementing the
feature & Samuel for backporting to libreoffice-5-1 gerrit.

Thank you,
Kendy

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 97033] EDITING - ODB file crashes when editing tables, queries, forms....

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97033

--- Comment #1 from Alex Thurgood  ---
Created attachment 121844
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121844=edit
backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97033] EDITING - ODB file crashes when editing tables, queries, forms....

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97033

Alex Thurgood  changed:

   What|Removed |Added

   Keywords||haveBacktrace, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96445] AutoCorrect Word Completion: drop-down "Accept with" cannot be localized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96445

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org

--- Comment #5 from Jean-Baptiste Faure  ---
(In reply to tommy27 from comment #2)
[...]
> what about the french locale?

No problem in French localization for 5.0 and 5.1. In 4.4 there is only one
item of the dropdown list which is not localized (Space).

In Pootle, for the master, the string is "Acc_ept with:", it is there:
Comment: W8dF5
libo_ui/cui/uiconfig/ui.po Unit #79289479
wordcompletionpage.ui label3 label string.text 
wordcompletionpage.ui

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97033] EDITING - ODB file crashes when editing tables, queries, forms....

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97033

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m.a.riosv  ---
Created attachment 121846
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121846=edit
Screenshot with a table open

Hi @Alex,
I can't reproduce, with or without OpenGL enable.
Win10x64
Version: 5.2.0.0.alpha0+
Build ID: 22e5170af74c635cf55d089f97946b6dc86f82ad
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-01-05_23:41:26

Java 1.8.0_66 x86.

Attached screenshot with a table open. No issue open queries or forms, but
first report give 'General error' and others seems a bit slow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/milestone-7' - loleaflet/debug

[Jan Holesovsky]

 loleaflet/debug/document/document_simple_example.html |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1f3f22cdc2b793dcef5b7d70c1b582cb916bc53b
Author: Jan Holesovsky 
Date:   Mon Jan 11 09:59:02 2016 +0100

Actually let's default to 'HideWhitespace' in this branch (not in master).

diff --git a/loleaflet/debug/document/document_simple_example.html 
b/loleaflet/debug/document/document_simple_example.html
index 3042922..1fe911e 100644
--- a/loleaflet/debug/document/document_simple_example.html
+++ b/loleaflet/debug/document/document_simple_example.html
@@ -67,7 +67,7 @@
 var renderingOptions = {
 ".uno:HideWhitespace": {
 "type": "boolean",
-"value": "false"
+"value": "true"
 },
 ".uno:ShowBorderShadow": {
 "type": "boolean",
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/qa sw/source

[Jan-Marek Glogowski]

 sw/qa/extras/mailmerge/data/tdf92623.odt|binary
 sw/qa/extras/mailmerge/mailmerge.cxx|   51 
 sw/source/core/doc/DocumentContentOperationsManager.cxx |   10 ++-
 3 files changed, 60 insertions(+), 1 deletion(-)

New commits:
commit cce1320efa93cc42300e457b898d892ca580ddca
Author: Jan-Marek Glogowski 
Date:   Thu Dec 3 23:18:16 2015 +0100

tdf#92623 Handle StartOfContent node for copying bookmarks

For SwDoc::AppendDoc we use the StartOfContent node as the
starting copy node to prevent merging of the first node in
CopyRange and to get a 2nd node needed for CopyRange in case
of single content node documents.

This correctly counts StartOfContent as a non-copy node when
adapting the bookmark ranges for copying.

Change-Id: Ia3ee0328a1be5548f8751aa2240812c4662fb73f
Reviewed-on: https://gerrit.libreoffice.org/20383
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 
(cherry picked from commit 689962feae2054f965a7378c3408b0ccfad2bbd5)

tdf#92623 MM: add unit test

Adds the missing unit test to the bugfix.

Actually the original bug was a crash, so this just
does some test on the resulting MM document.

Change-Id: I4c9f031e57157fe5744aa8290b7503b7e1990fc7
(cherry picked from commit 480e943f0100154fa82942db092ed1f66b76ef66)
Reviewed-on: https://gerrit.libreoffice.org/21076
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 
(cherry picked from commit bdcafdff89836518cb94f362ca7ea4c09a82fa03)
Reviewed-on: https://gerrit.libreoffice.org/21138
Tested-by: Jenkins 

diff --git a/sw/qa/extras/mailmerge/data/tdf92623.odt 
b/sw/qa/extras/mailmerge/data/tdf92623.odt
new file mode 100644
index 000..3dea831
Binary files /dev/null and b/sw/qa/extras/mailmerge/data/tdf92623.odt differ
diff --git a/sw/qa/extras/mailmerge/mailmerge.cxx 
b/sw/qa/extras/mailmerge/mailmerge.cxx
index 42d2385..92fc7c3 100644
--- a/sw/qa/extras/mailmerge/mailmerge.cxx
+++ b/sw/qa/extras/mailmerge/mailmerge.cxx
@@ -412,5 +412,56 @@ DECLARE_SHELL_MAILMERGE_TEST(testTdf90230, "empty.odt", 
"10-testing-addresses.od
 executeMailMerge();
 }
 
+DECLARE_SHELL_MAILMERGE_TEST(testTdf92623, "tdf92623.odt", 
"10-testing-addresses.ods", "testing-addresses")
+{
+// Copying bookmarks for MM was broken because of the StartOfContent node 
copy
+// copyied marks were off by one
+executeMailMerge();
+
+SwXTextDocument* pTextDoc = dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+IDocumentMarkAccess const *pIDMA = 
pTextDoc->GetDocShell()->GetDoc()->getIDocumentMarkAccess();
+// There is just one mark...
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), pIDMA->getAllMarksCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), pIDMA->getBookmarksCount());
+IDocumentMarkAccess::const_iterator_t mark = pIDMA->getAllMarksBegin();
+// and it's a TEXT_FIELDMARK
+CPPUNIT_ASSERT_EQUAL( sal_Int32(IDocumentMarkAccess::GetType( **mark )),
+  
sal_Int32(IDocumentMarkAccess::MarkType::TEXT_FIELDMARK ) );
+sal_uLong src_pos = (*mark)->GetMarkPos().nNode.GetIndex();
+
+// Get the size of the document in nodes
+SwDoc *doc = pTextDoc->GetDocShell()->GetDoc();
+sal_uLong size = doc->GetNodes().GetEndOfContent().GetIndex() - 
doc->GetNodes().GetEndOfExtras().GetIndex();
+CPPUNIT_ASSERT_EQUAL( sal_uLong(13), size );
+size -= 2; // For common start and end nodes
+
+// Iterate over all field marks in the target document and check that they
+// are positioned at a multitude of the document size
+SwXTextDocument* pMMTextDoc = dynamic_cast(mxMMComponent.get());
+CPPUNIT_ASSERT(pMMTextDoc);
+pIDMA = pMMTextDoc->GetDocShell()->GetDoc()->getIDocumentMarkAccess();
+// The target document has the duplicated amount of bookmarks
+// as the helping uno bookmark from the mail merge is left in the doc
+// TODO should be fixed!
+CPPUNIT_ASSERT_EQUAL(sal_Int32(20), pIDMA->getAllMarksCount());
+std::set pages;
+sal_Int32 countFieldMarks = 0;
+for( mark = pIDMA->getAllMarksBegin(); mark != pIDMA->getAllMarksEnd(); 
++mark )
+{
+IDocumentMarkAccess::MarkType markType = IDocumentMarkAccess::GetType( 
**mark );
+if( markType == IDocumentMarkAccess::MarkType::TEXT_FIELDMARK )
+{
+sal_uLong pos = (*mark)->GetMarkPos().nNode.GetIndex() - src_pos;
+CPPUNIT_ASSERT_EQUAL(sal_uLong(0), pos % size);
+CPPUNIT_ASSERT(pages.insert(pos).second);
+countFieldMarks++;
+}
+else // see previous TODO
+CPPUNIT_ASSERT_EQUAL( sal_Int32(markType), 
sal_Int32(IDocumentMarkAccess::MarkType::UNO_BOOKMARK) );
+}
+CPPUNIT_ASSERT_EQUAL(sal_Int32(10), countFieldMarks);
+}
+
 

[Libreoffice-bugs] [Bug 96655] OPENGL: Zoom slider visualization is corrupted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96655

--- Comment #6 from Commit Notification 
 ---
Michael Meeks committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3f5a9ca46efc801f79cdc00a3583646936bec689

tdf#96655 - clear non-offscreen status bar controls before render.

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96655] OPENGL: Zoom slider visualization is corrupted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96655

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - libreofficekit/source

[Pranav Kant]

 libreofficekit/source/gtk/lokdocview.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0478825ba51d390486bfbecb410bf9aaa3a3ff59
Author: Pranav Kant 
Date:   Tue Dec 15 00:23:46 2015 +0530

lokdocview: Superfluous *_set_zoom() call on widget initialization

G_PARAM_CONSTRUCT implies that parameter will be set upon widget
initialization which means calling lok_doc_view_set_zoom() while
document still points to null.

Change-Id: Ib576ac3b32c2349be2b2df6067ae79a056a03028
Reviewed-on: https://gerrit.libreoffice.org/20775
Reviewed-by: David Tardon 
Tested-by: David Tardon 
(cherry picked from commit a2682e4b081a9a8c6814db768e4ee9e5390907ae)
Reviewed-on: https://gerrit.libreoffice.org/21264
Tested-by: Jenkins 
Reviewed-by: Pranav Kant 

diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index e6356d8..16e13e1 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -760,6 +760,7 @@ static gboolean postDocumentLoad(gpointer pData)
 nDocumentHeightPixels);
 gtk_widget_set_can_focus(GTK_WIDGET(pLOKDocView), TRUE);
 gtk_widget_grab_focus(GTK_WIDGET(pLOKDocView));
+lok_doc_view_set_zoom(pLOKDocView, 1.0);
 
 return G_SOURCE_REMOVE;
 }
@@ -2143,7 +2144,6 @@ static void lok_doc_view_class_init (LOKDocViewClass* 
pClass)
  "The current zoom level of the content",
  0, 5.0, 1.0,
  static_cast(G_PARAM_READWRITE |
-  G_PARAM_CONSTRUCT |
   
G_PARAM_STATIC_STRINGS)));
 
 /**
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - include/LibreOfficeKit libreofficekit/qa libreofficekit/source

[Pranav Kant]

 include/LibreOfficeKit/LibreOfficeKitGtk.h  |   10 +++--
 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |3 +
 libreofficekit/source/gtk/lokdocview.cxx|   35 ++--
 3 files changed, 42 insertions(+), 6 deletions(-)

New commits:
commit dd6006be974ce808f276c550d32f1bc01582aaf3
Author: Pranav Kant 
Date:   Thu Dec 17 21:03:47 2015 +0530

lokdocview: Return if no document is set

For example, when document has been destroyed using
lok_doc_view_destroy_document()

Change-Id: I531b85018ffa25bcf88fb101c912b9f11b489a97
Reviewed-on: https://gerrit.libreoffice.org/20779
Reviewed-by: David Tardon 
Tested-by: David Tardon 
(cherry picked from commit df4a196b8f1e97d8a45d1d517942e01bd13182e7)
Reviewed-on: https://gerrit.libreoffice.org/21267
Tested-by: Jenkins 
Reviewed-by: Pranav Kant 

diff --git a/include/LibreOfficeKit/LibreOfficeKitGtk.h 
b/include/LibreOfficeKit/LibreOfficeKitGtk.h
index 62d2e7f..911bbdf 100644
--- a/include/LibreOfficeKit/LibreOfficeKitGtk.h
+++ b/include/LibreOfficeKit/LibreOfficeKitGtk.h
@@ -125,7 +125,7 @@ gfloat lok_doc_view_get_zoom
   (LOKDocView*
  * @pDocView: The #LOKDocView instance
  *
  * Returns: Part refers to either individual sheets in a Calc, or slides in 
Impress,
- * and has no relevance for Writer.
+ * and has no relevance for Writer. Returns -1 if no document is set currently.
  */
 gint   lok_doc_view_get_parts  
(LOKDocView* pDocView);
 
@@ -133,7 +133,7 @@ gint   lok_doc_view_get_parts   
   (LOKDocView*
  * lok_doc_view_get_part:
  * @pDocView: The #LOKDocView instance
  *
- * Returns: Current part number of the document
+ * Returns: Current part number of the document. Returns -1 if no document is 
set currently.
  */
 gint   lok_doc_view_get_part   
(LOKDocView* pDocView);
 
@@ -150,7 +150,8 @@ void   lok_doc_view_set_part
   (LOKDocView*
  * @pDocView: The #LOKDocView instance
  * @nPart:
  *
- * Returns: Get current part name of loaded document
+ * Returns: Get current part name of loaded document. Returns null if no
+ * document is set, or document has been destroyed using 
lok_doc_view_destroy_document.
  */
 gchar* lok_doc_view_get_part_name  
(LOKDocView* pDocView,
 int nPart);
@@ -248,7 +249,8 @@ void   lok_doc_view_highlight_all   
   (LOKDocView*
  * @pUsedMimeType: (out): output parameter to inform about the determined 
format
  * (suggested or plain text).
  *
- * Returns: Selected text. The caller must free the returned buffer after use.
+ * Returns: Selected text. The caller must free the returned buffer after
+ * use. Returns null if no document is set.
  */
 gchar*  lok_doc_view_copy_selection
(LOKDocView* pDocView,
 const 
gchar* pMimeType,
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx 
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index b4dbe16..fb886ef 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -549,7 +549,10 @@ static void doCopy(GtkWidget* pButton, gpointer /*pItem*/)
 TiledWindow& rWindow = lcl_getTiledWindow(pButton);
 LOKDocView* pLOKDocView = LOK_DOC_VIEW(rWindow.m_pDocView);
 char* pUsedFormat = nullptr;
+// TODO: Should check `text-selection` signal before trying to copy
 char* pSelection = lok_doc_view_copy_selection(pLOKDocView, "text/html", 
);
+if (!pSelection)
+return;
 
 GtkClipboard* pClipboard = 
gtk_clipboard_get_for_display(gtk_widget_get_display(rWindow.m_pDocView), 
GDK_SELECTION_CLIPBOARD);
 std::string aUsedFormat(pUsedFormat);
diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index eb20aab..ae8e52a 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -342,6 +342,9 @@ doSearch(LOKDocView* pDocView, const char* pText, bool 
bBackwards, bool highligh
 cairo_rectangle_int_t cairoVisRect;
 int x, y;
 
+if (!priv->m_pDocument)
+return;
+
 cairo_region_get_rectangle(cairoVisRegion, 0, );
 x = pixelToTwip (cairoVisRect.x, priv->m_fZoom);
 y = pixelToTwip (cairoVisRect.y, priv->m_fZoom);
@@ -1630,8 +1633,6 @@ setClientZoomInThread(gpointer data)
 LOKDocViewPrivate& priv = getPrivate(pDocView);
 LOEvent* pLOEvent = static_cast(g_task_get_task_data(task));
 
-if (!priv->m_pDocument)
-return;
 

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - include/LibreOfficeKit

[Pranav Kant]

 include/LibreOfficeKit/LibreOfficeKitGtk.h |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit 2f5643d7fa1009155e900a89918d5cee3265c137
Author: Pranav Kant 
Date:   Thu Dec 17 20:33:06 2015 +0530

lokdocview: Added some missing comments/annotations

Change-Id: I2f62bae37719ce96677a5ca6ffd93c8edb325a6a
Reviewed-on: https://gerrit.libreoffice.org/20777
Reviewed-by: David Tardon 
Tested-by: David Tardon 
(cherry picked from commit 9c8c3acffa304e2d85dcbbdb5bf9decc9b255b13)
Reviewed-on: https://gerrit.libreoffice.org/21266
Tested-by: Jenkins 
Reviewed-by: Pranav Kant 

diff --git a/include/LibreOfficeKit/LibreOfficeKitGtk.h 
b/include/LibreOfficeKit/LibreOfficeKitGtk.h
index c3cba8f..62d2e7f 100644
--- a/include/LibreOfficeKit/LibreOfficeKitGtk.h
+++ b/include/LibreOfficeKit/LibreOfficeKitGtk.h
@@ -123,12 +123,17 @@ gfloat lok_doc_view_get_zoom  
 (LOKDocView*
 /**
  * lok_doc_view_get_parts:
  * @pDocView: The #LOKDocView instance
+ *
+ * Returns: Part refers to either individual sheets in a Calc, or slides in 
Impress,
+ * and has no relevance for Writer.
  */
 gint   lok_doc_view_get_parts  
(LOKDocView* pDocView);
 
 /**
  * lok_doc_view_get_part:
  * @pDocView: The #LOKDocView instance
+ *
+ * Returns: Current part number of the document
  */
 gint   lok_doc_view_get_part   
(LOKDocView* pDocView);
 
@@ -144,6 +149,8 @@ void   lok_doc_view_set_part
   (LOKDocView*
  * lok_doc_view_get_part_name:
  * @pDocView: The #LOKDocView instance
  * @nPart:
+ *
+ * Returns: Get current part name of loaded document
  */
 gchar* lok_doc_view_get_part_name  
(LOKDocView* pDocView,
 int nPart);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96657] The drag and zoom tool does not show the selection area rectangle anymore (with openGL activated)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96657

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:5.2.0   | target:5.2.0
   ||target:5.1.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96657] The drag and zoom tool does not show the selection area rectangle anymore (with openGL activated)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96657

--- Comment #22 from Commit Notification 
 ---
Michael Meeks committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=dd70c25bda8f7ad8da6e68b6e88fd222cab1a10f=libreoffice-5-1

tdf#96657 - vcl opengl: implement invert: Track Frame.

It will be available in 5.1.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - include/LibreOfficeKit libreofficekit/source

[Pranav Kant]

 include/LibreOfficeKit/LibreOfficeKitGtk.h |   12 ++--
 libreofficekit/source/gtk/lokdocview.cxx   |   12 ++--
 2 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 0886f49224064a259ed6615961f420ab7b6fc3ef
Author: Pranav Kant 
Date:   Thu Dec 17 20:35:23 2015 +0530

lokdocview: Use GLib basic types

Change-Id: I07add7b9dcb1dc53d7ed61ff71545489de3be155
Reviewed-on: https://gerrit.libreoffice.org/20778
Reviewed-by: David Tardon 
Tested-by: David Tardon 
(cherry picked from commit b902432b431d01634c1f56e4758ec236a999650d)
Reviewed-on: https://gerrit.libreoffice.org/21265
Tested-by: Jenkins 
Reviewed-by: Pranav Kant 

diff --git a/include/LibreOfficeKit/LibreOfficeKitGtk.h 
b/include/LibreOfficeKit/LibreOfficeKitGtk.h
index 903a742..c3cba8f 100644
--- a/include/LibreOfficeKit/LibreOfficeKitGtk.h
+++ b/include/LibreOfficeKit/LibreOfficeKitGtk.h
@@ -118,19 +118,19 @@ void   lok_doc_view_set_zoom  
 (LOKDocView*
  *
  * Returns: The current zoom factor value in float for pDocView
  */
-float  lok_doc_view_get_zoom   
(LOKDocView* pDocView);
+gfloat lok_doc_view_get_zoom   
(LOKDocView* pDocView);
 
 /**
  * lok_doc_view_get_parts:
  * @pDocView: The #LOKDocView instance
  */
-intlok_doc_view_get_parts  
(LOKDocView* pDocView);
+gint   lok_doc_view_get_parts  
(LOKDocView* pDocView);
 
 /**
  * lok_doc_view_get_part:
  * @pDocView: The #LOKDocView instance
  */
-intlok_doc_view_get_part   
(LOKDocView* pDocView);
+gint   lok_doc_view_get_part   
(LOKDocView* pDocView);
 
 /**
  * lok_doc_view_set_part:
@@ -145,7 +145,7 @@ void   lok_doc_view_set_part
   (LOKDocView*
  * @pDocView: The #LOKDocView instance
  * @nPart:
  */
-char*  lok_doc_view_get_part_name  
(LOKDocView* pDocView,
+gchar* lok_doc_view_get_part_name  
(LOKDocView* pDocView,
 int nPart);
 
 /**
@@ -272,7 +272,7 @@ gbooleanlok_doc_view_paste  
   (LOKDocView*
  *
  * Returns: The corresponding value in twips
  */
-float  lok_doc_view_pixel_to_twip  
(LOKDocView* pDocView,
+gfloat lok_doc_view_pixel_to_twip  
(LOKDocView* pDocView,
 float 
fInput);
 
 /**
@@ -284,7 +284,7 @@ float  lok_doc_view_pixel_to_twip   
   (LOKDocView*
  *
  * Returns: The corresponding value in pixels
  */
-float  lok_doc_view_twip_to_pixel  
(LOKDocView* pDocView,
+gfloat lok_doc_view_twip_to_pixel  
(LOKDocView* pDocView,
 float 
fInput);
 
 G_END_DECLS
diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 16e13e1..eb20aab 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -2509,14 +2509,14 @@ lok_doc_view_set_zoom (LOKDocView* pDocView, float 
fZoom)
 g_object_unref(task);
 }
 
-SAL_DLLPUBLIC_EXPORT float
+SAL_DLLPUBLIC_EXPORT gfloat
 lok_doc_view_get_zoom (LOKDocView* pDocView)
 {
 LOKDocViewPrivate& priv = getPrivate(pDocView);
 return priv->m_fZoom;
 }
 
-SAL_DLLPUBLIC_EXPORT int
+SAL_DLLPUBLIC_EXPORT gint
 lok_doc_view_get_parts (LOKDocView* pDocView)
 {
 LOKDocViewPrivate& priv = getPrivate(pDocView);
@@ -2524,7 +2524,7 @@ lok_doc_view_get_parts (LOKDocView* pDocView)
 return priv->m_pDocument->pClass->getParts( priv->m_pDocument );
 }
 
-SAL_DLLPUBLIC_EXPORT int
+SAL_DLLPUBLIC_EXPORT gint
 lok_doc_view_get_part (LOKDocView* pDocView)
 {
 LOKDocViewPrivate& priv = getPrivate(pDocView);
@@ -2552,7 +2552,7 @@ lok_doc_view_set_part (LOKDocView* pDocView, int nPart)
 g_object_unref(task);
 }
 
-SAL_DLLPUBLIC_EXPORT char*
+SAL_DLLPUBLIC_EXPORT gchar*
 lok_doc_view_get_part_name (LOKDocView* pDocView, int nPart)
 {
 LOKDocViewPrivate& priv = getPrivate(pDocView);
@@ -2720,14 +2720,14 @@ lok_doc_view_paste (LOKDocView* pDocView,
 return ret;
 }
 
-SAL_DLLPUBLIC_EXPORT float
+SAL_DLLPUBLIC_EXPORT gfloat
 lok_doc_view_pixel_to_twip (LOKDocView* pDocView, float fInput)
 {
 LOKDocViewPrivate& priv = getPrivate(pDocView);
 return pixelToTwip(fInput, priv->m_fZoom);
 }
 
-SAL_DLLPUBLIC_EXPORT float
+SAL_DLLPUBLIC_EXPORT gfloat
 lok_doc_view_twip_to_pixel (LOKDocView* pDocView, float fInput)
 {
 

[Libreoffice-commits] core.git: Branch 'feature/fixes14' - vcl/inc vcl/win

[Tor Lillqvist]

 vcl/inc/win/salgdi.h |   11 
 vcl/win/source/gdi/salgdi.cxx|5 
 vcl/win/source/gdi/salgdi3.cxx   |   40 -
 vcl/win/source/gdi/winlayout.cxx |  828 ---
 vcl/win/source/gdi/winlayout.hxx |   45 --
 5 files changed, 10 insertions(+), 919 deletions(-)

New commits:
commit b8e719b73ce6c27c5cf5376c2669bfe530b36014
Author: Tor Lillqvist 
Date:   Mon Jan 11 13:11:25 2016 +0200

Revert "tdf#96420: Re-introduce SimpleWinLayout"

This reverts commit 9123edb25359e5e1c781139ac8b02bd361f7a60f.

diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index dd2452f..4ff01fa 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -214,9 +214,6 @@ private:
 RGNDATA*mpClipRgnData;  // ClipRegion-Data
 RGNDATA*mpStdClipRgnData;   // Cache 
Standard-ClipRegion-Data
 ImplFontAttrCache*  mpFontAttrCache;// Cache font attributes from 
files in so/share/fonts
-boolmbFontKernInit; // FALSE: FontKerns must be 
queried
-KERNINGPAIR*mpFontKernPairs;// Kerning Pairs of the 
current Font
-sal_uIntPtr mnFontKernPairCount;// Number of Kerning Pairs of 
the current Font
 int mnPenWidth; // Linienbreite
 
 public:
@@ -333,12 +330,6 @@ protected:
const SalBitmap* pAlphaBitmap) override;
 virtual bool   drawAlphaRect( long nX, long nY, long nWidth, long 
nHeight, sal_uInt8 nTransparency ) override;
 
-private:
-// local helpers
-
-// get kernign pairs of the current font
-sal_uLong   GetKernPairs();
-
 public:
 // public SalGraphics methods, the interface to the independent vcl part
 
@@ -460,7 +451,7 @@ voidImplGetLogFontFromFontSelect( HDC, const 
FontSelectPattern*,
 #define MAX_64KSALPOINTSsal_uInt16)0x)-8)/sizeof(POINTS))
 
 // #102411# Win's GCP mishandles kerning => we need to do it ourselves
-// SalGraphicsData::mpFontKernPairs is sorted by
+// kerning pairs is sorted by
 inline bool ImplCmpKernData( const KERNINGPAIR& a, const KERNINGPAIR& b )
 {
 if( a.wFirst < b.wFirst )
diff --git a/vcl/win/source/gdi/salgdi.cxx b/vcl/win/source/gdi/salgdi.cxx
index 42ab90e..5f29820 100644
--- a/vcl/win/source/gdi/salgdi.cxx
+++ b/vcl/win/source/gdi/salgdi.cxx
@@ -631,9 +631,6 @@ WinSalGraphics::WinSalGraphics(WinSalGraphics::Type eType, 
bool bScreen, HWND hW
 mhDefPal(0),
 mpStdClipRgnData(NULL),
 mpFontAttrCache(NULL),
-mpFontKernPairs(NULL),
-mnFontKernPairCount(0),
-mbFontKernInit(false),
 mnPenWidth(GSL_PEN_WIDTH)
 {
 if (OpenGLHelper::isVCLOpenGLEnabled() && !mbPrinter)
@@ -663,8 +660,6 @@ WinSalGraphics::~WinSalGraphics()
 
 // delete cache data
 delete [] (BYTE*)mpStdClipRgnData;
-
-delete [] mpFontKernPairs;
 }
 
 SalGraphicsImpl* WinSalGraphics::GetImpl() const
diff --git a/vcl/win/source/gdi/salgdi3.cxx b/vcl/win/source/gdi/salgdi3.cxx
index 4de6530..9412799 100644
--- a/vcl/win/source/gdi/salgdi3.cxx
+++ b/vcl/win/source/gdi/salgdi3.cxx
@@ -1559,17 +1559,6 @@ sal_uInt16 WinSalGraphics::SetFont( FontSelectPattern* 
pFont, int nFallbackLevel
 if( mpWinFontData[ nFallbackLevel ] )
 mpWinFontData[ nFallbackLevel ]->UpdateFromHDC( getHDC() );
 
-if( !nFallbackLevel )
-{
-mbFontKernInit = TRUE;
-if ( mpFontKernPairs )
-{
-delete[] mpFontKernPairs;
-mpFontKernPairs = NULL;
-}
-mnFontKernPairCount = 0;
-}
-
 // some printers have higher internal resolution, so their
 // text output would be different from what we calculated
 // => suggest DrawTextArray to workaround this problem
@@ -1656,35 +1645,6 @@ void WinSalGraphics::GetFontMetric( ImplFontMetricData* 
pMetric, int nFallbackLe
 pMetric->mnMinKashida = GetMinKashidaWidth();
 }
 
-sal_uLong WinSalGraphics::GetKernPairs()
-{
-if ( mbFontKernInit )
-{
-if( mpFontKernPairs )
-{
-delete[] mpFontKernPairs;
-mpFontKernPairs = NULL;
-}
-mnFontKernPairCount = 0;
-
-KERNINGPAIR* pPairs = NULL;
-int nCount = ::GetKerningPairsW( getHDC(), 0, NULL );
-if( nCount )
-{
-pPairs = new KERNINGPAIR[ nCount+1 ];
-mpFontKernPairs = pPairs;
-mnFontKernPairCount = nCount;
-::GetKerningPairsW( getHDC(), nCount, pPairs );
-}
-
-mbFontKernInit = FALSE;
-
-std::sort( mpFontKernPairs, mpFontKernPairs + mnFontKernPairCount, 
ImplCmpKernData );
-}
-
-return mnFontKernPairCount;
-}
-
 const FontCharMapPtr WinSalGraphics::GetFontCharMap() const
 {
 if( !mpWinFontData[0] )
diff --git a/vcl/win/source/gdi/winlayout.cxx b/vcl/win/source/gdi/winlayout.cxx
index f334fda..cef4f8a 100644
--- a/vcl/win/source/gdi/winlayout.cxx
+++ b/vcl/win/source/gdi/winlayout.cxx
@@ -47,8 

[Libreoffice-commits] core.git: filter/source

[Xisco Fauli]

 filter/source/svg/svgreader.cxx |  148 +++-
 1 file changed, 87 insertions(+), 61 deletions(-)

New commits:
commit e6e8a8650d4729965cb694d37592fd418c949a79
Author: Xisco Fauli 
Date:   Sat Dec 19 22:48:04 2015 +0100

tdf#47262 SVG: Parse gradient styles twice if the referred...

 gradient can't be found the first time

Conflicts:
filter/source/svg/svgreader.cxx

Change-Id: Iaadaac13738dd0d45832a8f38787b22b1d15de29
Reviewed-on: https://gerrit.libreoffice.org/20833
Tested-by: Jenkins 
Reviewed-by: Armin Le Grand 

diff --git a/filter/source/svg/svgreader.cxx b/filter/source/svg/svgreader.cxx
index b7a20ba..16c9cf8 100644
--- a/filter/source/svg/svgreader.cxx
+++ b/filter/source/svg/svgreader.cxx
@@ -160,7 +160,8 @@ struct AnnotatingVisitor
   StateMap& 
rStateMap,
   const State&   
rInitialState,
   const uno::Reference& 
xDocumentHandler,
-  std::vector< uno::Reference >& 
rUseElementVector) :
+  std::vector< uno::Reference >& 
rUseElementVector,
+  bool& rGradientNotFound) :
 mnCurrStateId(0),
 maCurrState(),
 maParentStates(),
@@ -170,7 +171,8 @@ struct AnnotatingVisitor
 maGradientVector(),
 maGradientStopVector(),
 maElementVector(),
-mrUseElementVector(rUseElementVector)
+mrUseElementVector(rUseElementVector),
+mrGradientNotFound(rGradientNotFound)
 {
 maParentStates.push_back(rInitialState);
 }
@@ -215,6 +217,12 @@ struct AnnotatingVisitor
 
 if( aFound != maGradientIdMap.end() )
 maGradientVector.back() = 
maGradientVector[aFound->second];
+else
+{
+mrGradientNotFound = true;
+maGradientVector.pop_back();
+return;
+}
 }
 
 // do that after dereferencing, to prevent hyperlinked
@@ -252,6 +260,12 @@ struct AnnotatingVisitor
 
 if( aFound != maGradientIdMap.end() )
 maGradientVector.back() = 
maGradientVector[aFound->second];
+else
+{
+mrGradientNotFound = true;
+maGradientVector.pop_back();
+return;
+}
 }
 
 // do that after dereferencing, to prevent hyperlinked
@@ -362,70 +376,73 @@ struct AnnotatingVisitor
 }
 default:
 {
-// init state. inherit defaults from parent.
-maCurrState = maParentStates.back();
-maCurrState.maTransform.identity();
-maCurrState.maViewBox.reset();
-
-// first parse 'color' and 'style' as 'fill' and 'stroke' 
might depend on them
-// if their values are "currentColor" and parsed previously
-uno::Reference 
xNodeColor(xAttributes->getNamedItem("color"));
-if(xNodeColor.is())
-parseAttribute(XML_COLOR, xNodeColor->getNodeValue());
-
-uno::Reference 
xNodeStyle(xAttributes->getNamedItem("style"));
-if(xNodeStyle.is())
-parseStyle(xNodeStyle->getNodeValue());
-
-const sal_Int32 nNumAttrs( xAttributes->getLength() );
-OUString sAttributeValue;
-
-//now, parse the rest of attributes
-for( sal_Int32 i=0; iitem(i)->getNodeValue();
-const sal_Int32 nTokenId(
-getTokenId(xAttributes->item(i)->getNodeName()));
-if( XML_ID == nTokenId )
+// init state. inherit defaults from parent.
+maCurrState = maParentStates.back();
+maCurrState.maTransform.identity();
+maCurrState.maViewBox.reset();
+
+// first parse 'color' and 'style' as 'fill' and 'stroke' 
might depend on them
+// if their values are "currentColor" and parsed previously
+uno::Reference 
xNodeColor(xAttributes->getNamedItem("color"));
+if(xNodeColor.is())
+parseAttribute(XML_COLOR, xNodeColor->getNodeValue());
+
+uno::Reference 
xNodeStyle(xAttributes->getNamedItem("style"));
+if(xNodeStyle.is())
+parseStyle(xNodeStyle->getNodeValue());
+
+

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - bean/pom.officebean.xml javaunohelper/pom.juh.xml jurt/pom.jurt.xml ridljar/pom.ridl.xml ridljar/pom.unoloader.xml unoil/pom.unoil.xml

[David Ostrovsky]

 bean/pom.officebean.xml   |   44 
 javaunohelper/pom.juh.xml |   44 
 jurt/pom.jurt.xml |   44 
 ridljar/pom.ridl.xml  |   44 
 ridljar/pom.unoloader.xml |   44 
 unoil/pom.unoil.xml   |   44 
 6 files changed, 264 insertions(+)

New commits:
commit 708eab71f4d099a3887d32e59ef817db50324698
Author: David Ostrovsky 
Date:   Tue Dec 1 00:20:09 2015 +0100

Expose metadata to deploy LibreOffice artifacts on Maven Central

As outlined in the requirements to deploy the artifacts on Maven
Central, the metdata must be provided:

* Project Name, Description and URL
* License Information
* Developer Information
* SCM Information

[1] http://central.sonatype.org/pages/requirements.html

Change-Id: I0bcd19a22d0e1a48f0faec0b414f816f7da5b318
Reviewed-on: https://gerrit.libreoffice.org/20315
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 9ca2de8c5995657973665189903aa2eebe0ef69a)
Reviewed-on: https://gerrit.libreoffice.org/20813
Reviewed-by: David Ostrovsky 
Reviewed-by: Miklos Vajna 

diff --git a/bean/pom.officebean.xml b/bean/pom.officebean.xml
new file mode 100644
index 000..8d366d2
--- /dev/null
+++ b/bean/pom.officebean.xml
@@ -0,0 +1,44 @@
+
+  4.0.0
+  org.libreoffice
+  officebean
+  @version@
+  jar
+  LibreOffice - LOKit4Java
+  LOKit4Java
+  https://www.libreoffice.org
+
+  
+
+  Mozilla Public License, Version 2.0
+  https://www.mozilla.org/en-US/MPL/2.0
+  repo
+
+  
+
+  
+http://cgit.freedesktop.org/libreoffice/core
+
https://gerrit.libreoffice.org/#/admin/projects/core
+  
+
+  
+
+  The Document Foundation
+
+  
+
+  
+
+  LibreOffice Development Mailing List
+  libreoffice@lists.freedesktop.org
+  
http://lists.freedesktop.org/mailman/listinfo/libreoffice
+  
http://lists.freedesktop.org/mailman/listinfo/libreoffice
+  http://lists.freedesktop.org/archives/libreoffice
+
+  
+
+  
+https://bugs.documentfoundation.org
+LibreOffice Issue Tracker
+  
+
diff --git a/javaunohelper/pom.juh.xml b/javaunohelper/pom.juh.xml
new file mode 100644
index 000..f132ead
--- /dev/null
+++ b/javaunohelper/pom.juh.xml
@@ -0,0 +1,44 @@
+
+  4.0.0
+  org.libreoffice
+  juh
+  @version@
+  jar
+  LibreOffice - Java UNO helper
+  Java UNO helper
+  https://www.libreoffice.org
+
+  
+
+  Mozilla Public License, Version 2.0
+  https://www.mozilla.org/en-US/MPL/2.0
+  repo
+
+  
+
+  
+http://cgit.freedesktop.org/libreoffice/core
+
https://gerrit.libreoffice.org/#/admin/projects/core
+  
+
+  
+
+  The Document Foundation
+
+  
+
+  
+
+  LibreOffice Development Mailing List
+  libreoffice@lists.freedesktop.org
+  
http://lists.freedesktop.org/mailman/listinfo/libreoffice
+  
http://lists.freedesktop.org/mailman/listinfo/libreoffice
+  http://lists.freedesktop.org/archives/libreoffice
+
+  
+
+  
+https://bugs.documentfoundation.org
+LibreOffice Issue Tracker
+  
+
diff --git a/jurt/pom.jurt.xml b/jurt/pom.jurt.xml
new file mode 100644
index 000..25e3403
--- /dev/null
+++ b/jurt/pom.jurt.xml
@@ -0,0 +1,44 @@
+
+  4.0.0
+  org.libreoffice
+  jurt
+  @version@
+  jar
+  LibreOffice - Java Uno Runtime
+  Java Uno Runtime
+  https://www.libreoffice.org
+
+  
+
+  Mozilla Public License, Version 2.0
+  https://www.mozilla.org/en-US/MPL/2.0
+  repo
+
+  
+
+  
+http://cgit.freedesktop.org/libreoffice/core
+
https://gerrit.libreoffice.org/#/admin/projects/core
+  
+
+  
+
+  The Document Foundation
+
+  
+
+  
+
+  LibreOffice Development Mailing List
+  libreoffice@lists.freedesktop.org
+  
http://lists.freedesktop.org/mailman/listinfo/libreoffice
+  
http://lists.freedesktop.org/mailman/listinfo/libreoffice
+  http://lists.freedesktop.org/archives/libreoffice
+
+  
+
+  
+https://bugs.documentfoundation.org
+LibreOffice Issue Tracker
+  
+
diff --git a/ridljar/pom.ridl.xml b/ridljar/pom.ridl.xml
new file mode 100644
index 000..96b862a0
--- /dev/null
+++ b/ridljar/pom.ridl.xml
@@ -0,0 +1,44 @@
+
+  4.0.0
+  org.libreoffice
+  ridl
+  @version@
+  jar
+  LibreOffice - Types for the Java Uno typesystem
+  Types for the Java Uno typesystem
+  https://www.libreoffice.org
+
+  
+
+  Mozilla Public License, Version 2.0
+  https://www.mozilla.org/en-US/MPL/2.0
+  repo
+
+  
+
+  
+http://cgit.freedesktop.org/libreoffice/core
+
https://gerrit.libreoffice.org/#/admin/projects/core

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/qa sw/source

[Jan-Marek Glogowski]

 sw/qa/extras/uiwriter/uiwriter.cxx |   97 +
 sw/source/core/txtnode/thints.cxx  |7 +-
 2 files changed, 100 insertions(+), 4 deletions(-)

New commits:
commit 107664a977c4893a0bc02f10cd20411c330b6d94
Author: Jan-Marek Glogowski 
Date:   Wed Dec 30 01:20:23 2015 +0100

tdf#96479 workaround bookmark end pos handling...

... when inserting text into a text node.

Seems SwTextNode::InsertText doesn't handle bookmark end
positions correctly. This is just handled correctly, if it
also contains the bookmark start.

This workaround simply concats the three strings to be
inserted in advance, so we just have to call
SwTextNode::InsertText once for the whole string.

(cherry picked from commit c91024891ff10c2ae01e11a28a9aecca2f36b6c3)

Conflicts:
sw/qa/extras/uiwriter/uiwriter.cxx

loplugin:stringconstant

(cherry picked from commit 67d440e6bd2c895833fa22d0f9bf5dc6901723e8)

loplugin:stringconstant

(cherry picked from commit 6aa4496c789fec271dcdc7995cf62ef2dabf1f96)
Reviewed-on: https://gerrit.libreoffice.org/21077
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 
(cherry picked from commit e781a8273eb2938f905485c00fbaf432e517d1dc)

Conflicts:
sw/qa/extras/uiwriter/uiwriter.cxx

Change-Id: Iab7708b4cc4df406bdbc3a685c7410e0e797fdc4
588a9c0205e03f701b617fd1775e7f9b9b88c6b0
60ee2ccc6090c305ade4ba16d3d298866cf89c4e
Reviewed-on: https://gerrit.libreoffice.org/21137
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 9d0d1b1..e835ee2 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -104,6 +104,7 @@ public:
 void testDde();
 void testTdf89954();
 void testTdf89720();
+void testTdf96479();
 
 CPPUNIT_TEST_SUITE(SwUiWriterTest);
 CPPUNIT_TEST(testReplaceForward);
@@ -146,6 +147,7 @@ public:
 CPPUNIT_TEST(testDde);
 CPPUNIT_TEST(testTdf89954);
 CPPUNIT_TEST(testTdf89720);
+CPPUNIT_TEST(testTdf96479);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -1150,6 +1152,101 @@ void SwUiWriterTest::testTdf89720()
 #endif
 }
 
+void SwUiWriterTest::testTdf96479()
+{
+// We want to verify the empty input text field in the bookmark
+static const OUString emptyInputTextField =
+OUStringLiteral1() + 
OUStringLiteral1();
+
+SwDoc* pDoc = createDoc();
+SwXTextDocument *xTextDoc = dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(xTextDoc);
+
+// So we can clean up all references for reload
+{
+// Append bookmark
+SwNodeIndex aIdx(pDoc->GetNodes().GetEndOfContent(), -1);
+SwPaM aPaM(aIdx);
+IDocumentMarkAccess  = *pDoc->getIDocumentMarkAccess();
+sw::mark::IMark *pMark =
+rIDMA.makeMark(aPaM, "original", 
IDocumentMarkAccess::MarkType::BOOKMARK);
+CPPUNIT_ASSERT(!pMark->IsExpanded());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), rIDMA.getBookmarksCount());
+
+// Get helper objects
+uno::Reference 
xBookmarksSupplier(mxComponent, uno::UNO_QUERY);
+uno::Reference xFactory(mxComponent, 
uno::UNO_QUERY);
+
+// Create cursor from bookmark
+uno::Reference 
xTextContent(xBookmarksSupplier->getBookmarks()->getByName("original"), 
uno::UNO_QUERY);
+uno::Reference xRange(xTextContent->getAnchor(), 
uno::UNO_QUERY);
+uno::Reference 
xCursor(xRange->getText()->createTextCursorByRange(xRange), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xCursor->isCollapsed());
+
+// Remove bookmark
+xRange->getText()->removeTextContent(xTextContent);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), rIDMA.getBookmarksCount());
+
+// Insert replacement bookmark
+uno::Reference 
xBookmarkNew(xFactory->createInstance("com.sun.star.text.Bookmark"), 
uno::UNO_QUERY);
+uno::Reference xBookmarkName(xBookmarkNew, 
uno::UNO_QUERY);
+xBookmarkName->setName("replacement");
+CPPUNIT_ASSERT(xCursor->isCollapsed());
+// Force bookmark expansion
+xCursor->getText()->insertString(xCursor, ".", true);
+xCursor->getText()->insertTextContent(xCursor, xBookmarkNew, true);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), rIDMA.getBookmarksCount());
+auto mark = *(rIDMA.getBookmarksBegin());
+CPPUNIT_ASSERT(mark->IsExpanded());
+
+// Create and insert input textfield with some content
+uno::Reference 
xTextField(xFactory->createInstance("com.sun.star.text.TextField.Input"), 
uno::UNO_QUERY);
+uno::Reference 
xCursorNew(xBookmarkNew->getAnchor()->getText()->createTextCursorByRange(xBookmarkNew->getAnchor()));
+CPPUNIT_ASSERT(!xCursorNew->isCollapsed());
+

[Libreoffice-commits] core.git: include/vcl vcl/CppunitTest_vcl_bitmap_test.mk vcl/Library_vcl.mk vcl/qa vcl/source

[Stephan Bergmann]

 include/vcl/BitmapFilterStackBlur.hxx   |   32 -
 vcl/CppunitTest_vcl_bitmap_test.mk  |1 
 vcl/Library_vcl.mk  |1 
 vcl/qa/cppunit/BitmapFilterTest.cxx |  175 
 vcl/source/bitmap/BitmapFilterStackBlur.cxx |  581 
 5 files changed, 790 deletions(-)

New commits:
commit da40d2558e3de30914f4c181cceb66937c6f1124
Author: Stephan Bergmann 
Date:   Mon Jan 11 10:42:23 2016 +0100

Remove BitmapFilterStackBlur, which is unused...

...ever since it got introduced with 
28c61871e876e6a2cac47439f768504b1a4c94a0
"vcl: stack blur implementation + basic test & performance test"

Change-Id: I78672cf74c24930df92121baecb9886df4382036

diff --git a/include/vcl/BitmapFilterStackBlur.hxx 
b/include/vcl/BitmapFilterStackBlur.hxx
deleted file mode 100644
index 5b2b002..000
--- a/include/vcl/BitmapFilterStackBlur.hxx
+++ /dev/null
@@ -1,32 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- */
-
-#ifndef INCLUDED_VCL_BITMAPFILTERSTACKBLUR_HXX
-#define INCLUDED_VCL_BITMAPFILTERSTACKBLUR_HXX
-
-#include 
-#include 
-#include 
-
-class VCL_DLLPUBLIC BitmapFilterStackBlur : BitmapFilter
-{
-sal_Int32 mnRadius;
-bool mbExtend;
-
-public:
-BitmapFilterStackBlur(sal_Int32 nRadius, bool bExtend = true);
-virtual ~BitmapFilterStackBlur();
-
-bool filter(Bitmap& rBitmap) override;
-};
-
-#endif // INCLUDED_VCL_BITMAPFILTERSTACKBLUR_HXX
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/CppunitTest_vcl_bitmap_test.mk 
b/vcl/CppunitTest_vcl_bitmap_test.mk
index 290d167..a65ddb3 100644
--- a/vcl/CppunitTest_vcl_bitmap_test.mk
+++ b/vcl/CppunitTest_vcl_bitmap_test.mk
@@ -11,7 +11,6 @@ $(eval $(call gb_CppunitTest_CppunitTest,vcl_bitmap_test))
 
 $(eval $(call gb_CppunitTest_add_exception_objects,vcl_bitmap_test, \
 vcl/qa/cppunit/BitmapTest \
-vcl/qa/cppunit/BitmapFilterTest \
 ))
 
 $(eval $(call gb_CppunitTest_use_externals,vcl_bitmap_test,\
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index f757232..961bb05 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -317,7 +317,6 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/bitmap/bitmapscalesuper \
 vcl/source/bitmap/BitmapScaleConvolution \
 vcl/source/bitmap/BitmapSymmetryCheck \
-vcl/source/bitmap/BitmapFilterStackBlur \
 vcl/source/bitmap/BitmapProcessor \
 vcl/source/bitmap/BitmapTools \
 vcl/source/bitmap/checksum \
diff --git a/vcl/qa/cppunit/BitmapFilterTest.cxx 
b/vcl/qa/cppunit/BitmapFilterTest.cxx
deleted file mode 100644
index ade5acb..000
--- a/vcl/qa/cppunit/BitmapFilterTest.cxx
+++ /dev/null
@@ -1,175 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#include 
-#include 
-#include 
-#include 
-
-#include 
-#include 
-
-#include 
-#include 
-
-#include 
-#include "BitmapSymmetryCheck.hxx"
-
-#include 
-
-namespace
-{
-
-const bool constWriteResultBitmap(false);
-const bool constEnablePerformanceTest(false);
-
-class BitmapFilterTest : public CppUnit::TestFixture
-{
-
-void testBlurCorrectness();
-void testPerformance();
-
-CPPUNIT_TEST_SUITE(BitmapFilterTest);
-CPPUNIT_TEST(testBlurCorrectness);
-CPPUNIT_TEST(testPerformance);
-CPPUNIT_TEST_SUITE_END();
-};
-
-void BitmapFilterTest::testBlurCorrectness()
-{
-// Setup test bitmap
-Size aSize(41, 31);
-Bitmap aBitmap24Bit(aSize, 24);
-
-sal_uLong nScanlineFormat = 0;
-sal_uInt16 nBPP = aBitmap24Bit.GetBitCount();
-
-{
-long aMargin1 = 1;
-long aMargin2 = 3;
-Bitmap::ScopedWriteAccess aWriteAccess(aBitmap24Bit);
-nScanlineFormat = aWriteAccess->GetScanlineFormat();
-aWriteAccess->Erase(COL_WHITE);
-aWriteAccess->SetLineColor(COL_BLACK);
-
-Rectangle aRectangle1(
-aMargin1,
-aMargin1,
-aSize.Width() - 1 - aMargin1,
-aSize.Height() - 1 - aMargin1);
-
-Rectangle aRectangle2(
-aMargin2,
-aMargin2,
-aSize.Width() - 1 - aMargin2,
-aSize.Height() - 1 - aMargin2);
-
-Rectangle aRectangle3(
-aSize.Width()  / 2,
-aSize.Height() / 2,
-aSize.Width()  / 2,
- 

[Libreoffice-bugs] [Bug 96975] Opening Hyperlinks to other .odp in presentation mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96975

Luke Picciau  changed:

   What|Removed |Added

 CC||luke.b.picc...@gmail.com
   Severity|normal  |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - libreofficekit/source

[Pranav Kant]

 libreofficekit/source/gtk/lokdocview.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 2bb2c450a741a539be69494b5308428d07c56adf
Author: Pranav Kant 
Date:   Sun Dec 13 10:48:45 2015 +0530

lokdocview: Remove an easy FIXME

Change-Id: I8305f3eb45330f457089ca0524a0df004410f59c
Reviewed-on: https://gerrit.libreoffice.org/20774
Reviewed-by: David Tardon 
Tested-by: David Tardon 
(cherry picked from commit 244aad533b0fd714136f4f62b5a07fc136c740f0)
Reviewed-on: https://gerrit.libreoffice.org/21263
Tested-by: Jenkins 
Reviewed-by: Pranav Kant 

diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 3d01a62..e6356d8 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -2430,8 +2430,7 @@ lok_doc_view_open_document_finish (LOKDocView* pDocView, 
GAsyncResult* res, GErr
 GTask* task = G_TASK(res);
 
 g_return_val_if_fail(g_task_is_valid(res, pDocView), false);
-//FIXME: make source_tag work
-//g_return_val_if_fail(g_task_get_source_tag(task) == 
lok_doc_view_open_document, NULL);
+g_return_val_if_fail(g_task_get_source_tag(task) == 
lok_doc_view_open_document, false);
 g_return_val_if_fail(error == nullptr || *error == nullptr, false);
 
 return g_task_propagate_boolean(task, error);
@@ -2456,6 +2455,7 @@ lok_doc_view_open_document (LOKDocView* pDocView,
 if (pRenderingArguments)
 priv->m_aRenderingArguments = pRenderingArguments;
 g_task_set_task_data(task, pLOEvent, LOEvent::destroy);
+g_task_set_source_tag(task, 
reinterpret_cast(lok_doc_view_open_document));
 
 g_thread_pool_push(priv->lokThreadPool, g_object_ref(task), );
 if (error != nullptr)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96385] Tracker: GL black / flickering issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96385

Michael Meeks  changed:

   What|Removed |Added

 Depends on||94462

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94691] [META] OpenGL bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94691

Michael Meeks  changed:

   What|Removed |Added

 Depends on|94462   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94462] Dropdown menus flicker when OpenGL is enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94462

Michael Meeks  changed:

   What|Removed |Added

 Blocks|94691   |96385

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97036] New: fileopen unnecessarily in new window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97036

Bug ID: 97036
   Summary: fileopen unnecessarily in new window
   Product: LibreOffice
   Version: 5.0.4.2 rc
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jasch...@wiseware.com

Load Writer.  Open a "recently used" file. Instead of replacing the default
"untitled document", a new instance of writer will created and the file will be
opened there.  Close that new window.  Now try to load the same recently used
file and it will open (as it should) by replacing the "untitled document".

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93529] Meta: VCL/OpenGL tracker bug for 5.0+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93529
Bug 93529 depends on bug 94917, which changed state.

Bug 94917 Summary: Rotated / vertical text does not render - with openGL 
activated
https://bugs.documentfoundation.org/show_bug.cgi?id=94917

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94917] Rotated / vertical text does not render - with openGL activated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94917

Michael Meeks  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #34 from Michael Meeks  ---
Just ran a test on this here, and it works on both Linux and Windows for me -
please can you re-open if you can reproduce this problem in LibreOffice 5.1.0
RC2 - due this week.

Thanks ! =)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96688] Won't load document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96688

Alexander Werner  changed:

   What|Removed |Added

  Component|LibreOffice |deletionrequest

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs