[Libreoffice-bugs] [Bug 100169] DirectWrite OpenGL having trouble composing height of text, is clipping glyphs
https://bugs.documentfoundation.org/show_bug.cgi?id=100169 --- Comment #2 from V Stuart Foote--- Created attachment 125433 --> https://bugs.documentfoundation.org/attachment.cgi?id=125433=edit clip of sample document without OpenGL rendering -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100169] DirectWrite OpenGL having trouble composing height of text, is clipping glyphs
https://bugs.documentfoundation.org/show_bug.cgi?id=100169 --- Comment #3 from V Stuart Foote--- Created attachment 125434 --> https://bugs.documentfoundation.org/attachment.cgi?id=125434=edit clip of sample document using OpenGL rendering -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 V Stuart Footechanged: What|Removed |Added Depends on||100169 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100169 [Bug 100169] DirectWrite OpenGL having trouble composing height of text, is clipping glyphs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92529] config written during startup ...
https://bugs.documentfoundation.org/show_bug.cgi?id=92529 V Stuart Footechanged: What|Removed |Added Depends on||100169 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100169 [Bug 100169] DirectWrite OpenGL having trouble composing height of text, is clipping glyphs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100169] DirectWrite OpenGL having trouble composing height of text, is clipping glyphs
https://bugs.documentfoundation.org/show_bug.cgi?id=100169 V Stuart Footechanged: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Created attachment 125432 --> https://bugs.documentfoundation.org/attachment.cgi?id=125432=edit Writer document with a mix of BMP and SMP glyphs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92529] config written during startup ...
https://bugs.documentfoundation.org/show_bug.cgi?id=92529 V Stuart Footechanged: What|Removed |Added Depends on|100169 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100169 [Bug 100169] DirectWrite OpenGL having trouble composing height of text, is clipping glyphs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100169] DirectWrite OpenGL having trouble composing height of text, is clipping glyphs
https://bugs.documentfoundation.org/show_bug.cgi?id=100169 V Stuart Footechanged: What|Removed |Added Blocks||92529 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=92529 [Bug 92529] config written during startup ... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100169] DirectWrite OpenGL having trouble composing height of text, is clipping glyphs
https://bugs.documentfoundation.org/show_bug.cgi?id=100169 V Stuart Footechanged: What|Removed |Added Blocks|92529 |93529 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=92529 [Bug 92529] config written during startup ... https://bugs.documentfoundation.org/show_bug.cgi?id=93529 [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100169] New: DirectWrite OpenGL having trouble composing height of text, is clipping glyphs
https://bugs.documentfoundation.org/show_bug.cgi?id=100169 Bug ID: 100169 Summary: DirectWrite OpenGL having trouble composing height of text, is clipping glyphs Product: LibreOffice Version: 5.2.0.0.alpha1 Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vstuart.fo...@utsa.edu On Windows 10 Pro 64-bit en-US with Version: 5.3.0.0.alpha0+ Build ID: cbf36dd473fdc9e8d8b78c9e9317836a7cbbc6c7 CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2016-06-01_00:32:07 Locale: en-US (en_US) Seem to be doing better with DirectWrite font composition on Windows when OpenGL rendering is enabled. However, the calculated height of glyphs seems erratic and glyphs for whole lines of text are framed wrong. See attached example document and clips with and without OpenGL rendering enabled. With OpenGL rendering enabled and DirectWrite composition glyphs are not positioned centered and are being clipped as compared to default rendering. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100093] Calc appends path for data linked cells automatically and incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=100093 --- Comment #10 from Jim@HiTek--- I failed at proof reading...sorry. The FIX was to open the main SS with it's XLS extension using Libre, then save it with a Libre ODS extension. Then when I opened that SS, and it asked me if I'd like to import the data from the other SS's (all with XLS extensions), it works fine. It fails when I use Libre to open the main SS with the XLS extension. Asks me if I'd like to import, when I try that, it's giving me that error and repeatedly appends the path. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/fixes22' - 4 commits - vcl/opengl
vcl/opengl/combinedTextureFragmentShader.glsl |7 +++ vcl/opengl/combinedTextureVertexShader.glsl |9 + 2 files changed, 16 insertions(+) New commits: commit df6b2fdc1587f4529290978f3b5ffba547de2b27 Author: Tomaž VajngerlDate: Tue May 31 16:15:21 2016 +0900 opengl: improve overlap tracking Instead of tracking the overlap with only one rectangle use more rectangles and add elements to the rectangle that increases the combined area the least. If a new entry overlaps with at least on rectangle then create a new list. Current limit the number of rectangles to 30. Change-Id: I3db619afc1fdd98fe7314c930e909bf2c93d7b2c diff --git a/vcl/inc/opengl/RenderList.hxx b/vcl/inc/opengl/RenderList.hxx index 32ece73..e63f5dc 100644 --- a/vcl/inc/opengl/RenderList.hxx +++ b/vcl/inc/opengl/RenderList.hxx @@ -38,6 +38,8 @@ struct RenderTextureParameters struct RenderEntry { +basegfx::B2DRange maOverlapTrackingRectangle; + RenderParameters maTriangleParameters; RenderParameters maLineParameters; RenderParameters maLineAAParameters; @@ -68,19 +70,59 @@ struct RenderEntry class RenderList { private: -basegfx::B2DRange maOverlapTrackingRectangle; std::vector maRenderEntries; +std::vector maRectangles; + +bool doesOverlap(const basegfx::B2DRange& rDrawRectangle) +{ +if (!maRenderEntries.back().maOverlapTrackingRectangle.overlaps(rDrawRectangle)) +return false; + +for (const basegfx::B2DRange& rRectangle : maRectangles) +{ +if (rRectangle.overlaps(rDrawRectangle)) +return true; +} +return false; +} void checkOverlapping(const basegfx::B2DRange& rDrawRectangle) { -if (maRenderEntries.empty() || maOverlapTrackingRectangle.overlaps(rDrawRectangle)) +if (maRenderEntries.empty() || doesOverlap(rDrawRectangle)) { maRenderEntries.resize(maRenderEntries.size() + 1); -maOverlapTrackingRectangle = rDrawRectangle; +maRenderEntries.back().maOverlapTrackingRectangle = rDrawRectangle; + +maRectangles.clear(); +maRectangles.reserve(30); +maRectangles.push_back(rDrawRectangle); } else { -maOverlapTrackingRectangle.expand(rDrawRectangle); + maRenderEntries.back().maOverlapTrackingRectangle.expand(rDrawRectangle); + +if (maRectangles.size() < 30) +{ +maRectangles.push_back(rDrawRectangle); +} +else +{ +basegfx::B2DRange aTempRectangle(maRectangles[0]); +aTempRectangle.expand(rDrawRectangle); +double minArea = aTempRectangle.getWidth() * aTempRectangle.getHeight(); +size_t index = 0; + +double area; +for (size_t i = 1; i < maRectangles.size(); ++i) +{ +aTempRectangle = basegfx::B2DRange(maRectangles[i]); +aTempRectangle.expand(rDrawRectangle); +area = aTempRectangle.getWidth() * aTempRectangle.getHeight(); +if (area < minArea) +index = i; +} +maRectangles[index].expand(rDrawRectangle); +} } } @@ -96,7 +138,6 @@ public: void clear() { maRenderEntries.clear(); -maOverlapTrackingRectangle.reset(); } std::vector& getEntries() commit a5814ee7bb01e39ab6554ee3c844489b34fc2ace Author: Tomaž Vajngerl Date: Tue May 31 12:26:04 2016 +0900 opengl: deferred texture drawing in RenderList, add drawAlphaRect Drawing accumulated textures (in Accumulatedtextures) is independent of drawing with render list which causes problems with rendering order when render list and accumulated textures are flushed. To solve this we need to combine both so we can check for overlapped drawing. Previously drawRect was using RenderList batch drawing but not drawAlphaRect which is essentially the same as drawRect but additionally supports alpha value. This adds support to draw alpha rectangles to RenderList and converts drawAlphaRect. + update combined texture shaders Change-Id: I82bf0b410e5ebabb13bab7b29a2e53a6fdaa404f diff --git a/vcl/inc/opengl/AccumulatedTextures.hxx b/vcl/inc/opengl/AccumulatedTextures.hxx deleted file mode 100644 index 504cf6a..000 --- a/vcl/inc/opengl/AccumulatedTextures.hxx +++ /dev/null @@ -1,99 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with
[Libreoffice-bugs] [Bug 100168] Writer and Math sidebars overlap
https://bugs.documentfoundation.org/show_bug.cgi?id=100168 V Stuart Footechanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu Resolution|--- |DUPLICATE --- Comment #1 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 96451 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96451] UI isn't properly refreshed when inserting formula
https://bugs.documentfoundation.org/show_bug.cgi?id=96451 V Stuart Footechanged: What|Removed |Added CC||franciscoadriansanchez@gmai ||l.com --- Comment #15 from V Stuart Foote --- *** Bug 100168 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100019] Upstreaming to English Dictionaries extension
https://bugs.documentfoundation.org/show_bug.cgi?id=100019 --- Comment #6 from Aron Budea--- Created attachment 125431 --> https://bugs.documentfoundation.org/attachment.cgi?id=125431=edit Hyphenation patterns for US+GB, v2011.10.07 Thank you for the update, Marco. Here's the zip with the current hyphenation patterns, FYI file endings are in unix format. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99235] Cannot set view scale
https://bugs.documentfoundation.org/show_bug.cgi?id=99235 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ba...@caesar.elte.hu Ever confirmed|0 |1 --- Comment #7 from Aron Budea --- I tested with 1024x600 resolution, but with English UI (the parallel installation only has English UI), and while it appeared fine for me, comparing to the screenshot my guess is that the scaling there was set to ~125% maybe, and due to Polish translation being very long, the window could only fit like shown in the image. Options: -Comment 3, -delete user profile (to reset changed scaling), -pull dialog to left, enlargen by grabbing right edge, pull dialog to right. If the scaling was not changed from default originally, then maybe there's also a system setting for scaling? Robert, were you able to adjust the scaling in the end? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100149] LibreOffice crashes when spreadsheet or document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=100149 --- Comment #3 from Dan Loomis--- Created attachment 125430 --> https://bugs.documentfoundation.org/attachment.cgi?id=125430=edit strace of problem -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98496] Formatted text in cells is not correctly saved in XLSX format
https://bugs.documentfoundation.org/show_bug.cgi?id=98496 Franciscochanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Francisco --- Bug isn't reproducible anymore under LibO 5.0.6 Closing as worksform -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100168] New: Writer and Math sidebars overlap
https://bugs.documentfoundation.org/show_bug.cgi?id=100168 Bug ID: 100168 Summary: Writer and Math sidebars overlap Product: LibreOffice Version: 5.1.2.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Formula Editor Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: franciscoadriansanc...@gmail.com Created attachment 125429 --> https://bugs.documentfoundation.org/attachment.cgi?id=125429=edit screenshot Placing both sidebars at right (Math sidebar is at left by default), when one enters into the "edit equation mode" and put the mouse over the Math sidebar, Writer sidebar elements appear. Steps to reproduce 1) Open Writer 2) Insert an equation and enter into edit mode 3) Move the mouse over the region where Writer sidebar buttons are. Expected Nothing is shown except for Math objects Actual result Writer's sidebar elements (buttons) appears over Math's sidebar. Screenshot attached. Versions in which the bug is reproducible Versión: 5.1.2.2 Id. de compilación: 1:5.1.2-0ubuntu1 Hilos de CPU: 3; Versión de SO: Linux 4.4; Renderizado de IU: predeterminado; Configuración regional: en-US (es_AR.UTF-8) Version: 5.3.0.0.alpha0+ Build ID: 86d84ae4bba0d4c45bc13232645318291a8aed75 CPU Threads: 3; OS Version: Linux 4.4; UI Render: default; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-05-26_14:33:24 Locale: es-AR (es_AR.UTF-8) Version in which I can't reproduce the bug: Versión: 5.0.6.3 Id. de compilación: 490fc03b25318460cfc54456516ea2519c11d1aa Configuración regional: en-US (es_AR.UTF-8) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100149] LibreOffice crashes when spreadsheet or document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=100149 --- Comment #2 from Dan Loomis--- Created attachment 125428 --> https://bugs.documentfoundation.org/attachment.cgi?id=125428=edit Backtrace of problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100109] Memory leak and high CPU use when scrolling a file in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=100109 --- Comment #6 from Francisco--- Hi Raal, (In reply to raal from comment #5) > Please could you test with dev version? > http://dev-builds.libreoffice.org/daily/master/ > Thank you It seems to be that this is the same version you have Version: 5.3.0.0.alpha0+ Build ID: 86d84ae4bba0d4c45bc13232645318291a8aed75 CPU Threads: 3; OS Version: Linux 4.4; UI Render: default; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-05-26_14:33:24 Locale: es-AR (es_AR.UTF-8) I couldn't reproduce the bug with this version. Also, equations are correctly shown. Scrolling is laggish, indeed. But no memory eating. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56363] Using Graphite features prevents Special Character dialog from preselecting the Graphite font
https://bugs.documentfoundation.org/show_bug.cgi?id=56363 --- Comment #11 from Linus Drumbler--- This bug is still present on 5.1.3.2, Ubuntu 14.04. I'm too lazy to take a screenshot this time. Just please take a look at it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #19 from Aron Budea--- I thought about what should happen with this report after the fix is in, and suggest to keep it open with the specific guide for the developer to temporarily undo the fix in their system, take care of the underlying issue until the crash is gone, and publish their fix (while keeping Sam's fix as well). It's a bit inconvenient, but the steps are straightforward, and it won't get forgotten. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - basic/source
basic/source/basmgr/basicmanagerrepository.cxx | 54 + 1 file changed, 38 insertions(+), 16 deletions(-) New commits: commit 4c6f0378a4512c16e43161436b9fe97d802f4516 Author: Caolán McNamaraDate: Tue May 31 17:05:59 2016 +0100 Resolves: tdf#93386 crash when closing a Database with macro editor open (cherry picked from commit 9a0fd9c7f424fb787e1fae2113f0a42f0895a1e9) (cherry picked from commit 9f21b660fe2ed3805614be5d782137554e32e7d2) Change-Id: Id3ecee744cb10f539f2b57e83a4b6e4c7744d3d5 Reviewed-on: https://gerrit.libreoffice.org/25737 Reviewed-by: Michael Meeks Tested-by: Jenkins diff --git a/basic/source/basmgr/basicmanagerrepository.cxx b/basic/source/basmgr/basicmanagerrepository.cxx index 1b3ca26..0cd2941 100644 --- a/basic/source/basmgr/basicmanagerrepository.cxx +++ b/basic/source/basmgr/basicmanagerrepository.cxx @@ -108,6 +108,17 @@ namespace basic BasicManager*& impl_getLocationForModel( const Reference< XModel >& _rxDocumentModel ); +/** tests if there is a location set at which the BasicManager for the given model +is stored. + +@param _rxDocumentModel +the model whose BasicManager's location is to be retrieved. Must not be . + +@precond +our mutex is locked +*/ +bool impl_hasLocationForModel( const Reference< XModel >& _rxDocumentModel ); + /** creates a new BasicManager instance for the given model @param _out_rpBasicManager @@ -117,7 +128,7 @@ namespace basic @param _rxDocumentModel the model whose BasicManager will be created. Must not be . */ -void impl_createManagerForModel( +bool impl_createManagerForModel( BasicManager*& _out_rpBasicManager, const Reference< XModel >& _rxDocumentModel ); @@ -211,7 +222,6 @@ namespace basic create( CreateImplRepository(), ::osl::GetGlobalMutex() ); } - BasicManager* ImplRepository::getDocumentBasicManager( const Reference< XModel >& _rxDocumentModel ) { SolarMutexGuard g; @@ -225,13 +235,13 @@ namespace basic without creating another instance. */ BasicManager*& pBasicManager = impl_getLocationForModel( _rxDocumentModel ); -if ( pBasicManager == nullptr ) -impl_createManagerForModel( pBasicManager, _rxDocumentModel ); - -return pBasicManager; +if (pBasicManager != nullptr) +return pBasicManager; +if (impl_createManagerForModel(pBasicManager, _rxDocumentModel)) +return pBasicManager; +return nullptr; } - BasicManager* ImplRepository::getApplicationBasicManager( bool _bCreate ) { SolarMutexGuard g; @@ -357,7 +367,6 @@ namespace basic return pAppBasic; } - BasicManager*& ImplRepository::impl_getLocationForModel( const Reference< XModel >& _rxDocumentModel ) { Reference< XInterface > xNormalized( _rxDocumentModel, UNO_QUERY ); @@ -367,6 +376,13 @@ namespace basic return location; } +bool ImplRepository::impl_hasLocationForModel( const Reference< XModel >& _rxDocumentModel ) +{ +Reference< XInterface > xNormalized( _rxDocumentModel, UNO_QUERY ); +DBG_ASSERT( _rxDocumentModel.is(), "ImplRepository::impl_getLocationForModel: invalid model!" ); + +return m_aStore.find(xNormalized) != m_aStore.end(); +} void ImplRepository::impl_initDocLibraryContainers_nothrow( const Reference< XPersistentLibraryContainer >& _rxBasicLibraries, const Reference< XPersistentLibraryContainer >& _rxDialogLibraries ) { @@ -393,8 +409,7 @@ namespace basic } } - -void ImplRepository::impl_createManagerForModel( BasicManager*& _out_rpBasicManager, const Reference< XModel >& _rxDocumentModel ) +bool ImplRepository::impl_createManagerForModel( BasicManager*& _out_rpBasicManager, const Reference< XModel >& _rxDocumentModel ) { StarBASIC* pAppBasic = impl_getDefaultAppBasicLibrary(); @@ -403,13 +418,13 @@ namespace basic if ( !impl_getDocumentStorage_nothrow( _rxDocumentModel, xStorage ) ) { // the document is not able to provide the storage it is based on. -return; +return false; } Reference< XPersistentLibraryContainer > xBasicLibs; Reference< XPersistentLibraryContainer > xDialogLibs; if ( !impl_getDocumentLibraryContainers_nothrow( _rxDocumentModel, xBasicLibs, xDialogLibs ) ) // the document does not have BasicLibraries and DialogLibraries -return; +return false; if ( xStorage.is() ) { @@ -470,20 +485,27 @@ namespace basic //
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - readlicense_oo/license
readlicense_oo/license/CREDITS.fodt | 2916 ++-- 1 file changed, 1472 insertions(+), 1444 deletions(-) New commits: commit 6cb7c8994b6204f71b1aa51196ce26fe10550ff9 Author: Christian LohmaierDate: Wed Jun 1 02:31:23 2016 +0200 update credits Change-Id: I0932fb77c37c9e48eb5ecb4b26ee44553b8368a5 (cherry picked from commit cbf36dd473fdc9e8d8b78c9e9317836a7cbbc6c7) diff --git a/readlicense_oo/license/CREDITS.fodt b/readlicense_oo/license/CREDITS.fodt index 89fa8ef..560e63d 100644 --- a/readlicense_oo/license/CREDITS.fodt +++ b/readlicense_oo/license/CREDITS.fodt @@ -1,10 +1,10 @@ http://www.w3.org/1999/xlink; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:config="urn:oas is:names:tc:opendocument:xmlns:config:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:ooow="http://openoffice.org/2004/writer; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:rpt="http://openoffice.org/2005/report; xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:officeooo="http://openoffice.org/2009/office; xmlns:tableooo="http://openoffice.org/2009/table; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:formx="urn:openoffice:names: experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" office:mimetype="application/vnd.oasis.opendocument.text"> - Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/5.1.3.2$Linux_X86_64 LibreOffice_project/644e4637d1d8544fd9f56425bd6cec110e49301b2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA + Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/5.1.3.2$Linux_X86_64 LibreOffice_project/644e4637d1d8544fd9f56425bd6cec110e49301b2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA - 501 + 686 501 41197 21327 @@ -16,9 +16,9 @@ 3676 3471 501 - 501 + 686 41697 - 21826 + 22012 0 0 false @@ -68,7 +68,7 @@ false false true - 5217702 + 5262926 false false false @@ -312,21 +312,24 @@ - + - + - + - + + + + - + @@ -390,26 +393,23 @@ - + - + - + - + - + - - - @@ -1030,14 +1030,14 @@ Credits -1164 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2016-05-26 00:00:36. +1166 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2016-06-01 00:10:46. * marks developers whose first contributions happened after 2010-09-28. Developers committing code since 2010-09-28 - + Ruediger TimmCommits: 82464Joined: 2000-10-10 @@ -1057,10 +1057,10 @@ Vladimir GlazunovCommits: 25434Joined: 2000-12-04 - Caolán McNamaraCommits: 19443Joined: 2000-10-10 + Caolán McNamaraCommits: 19471Joined: 2000-10-10 - Stephan BergmannCommits: 12124Joined: 2000-10-04 + Stephan BergmannCommits: 12143Joined: 2000-10-04 Ivo HinkelmannCommits: 9480Joined: 2002-09-09 @@ -1068,16 +1068,16 @@ - Tor LillqvistCommits: 7398Joined: 2010-03-23 + Tor LillqvistCommits: 7408Joined: 2010-03-23 - *Noel GrandinCommits: 5920Joined: 2011-12-12 + *Noel GrandinCommits: 5959Joined: 2011-12-12 - Miklos VajnaCommits:
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - readlicense_oo/license
readlicense_oo/license/CREDITS.fodt | 2916 ++-- 1 file changed, 1472 insertions(+), 1444 deletions(-) New commits: commit ed043775b0789942c58baa2ba6c53959dcfb1807 Author: Christian LohmaierDate: Wed Jun 1 02:31:23 2016 +0200 update credits Change-Id: I0932fb77c37c9e48eb5ecb4b26ee44553b8368a5 (cherry picked from commit cbf36dd473fdc9e8d8b78c9e9317836a7cbbc6c7) diff --git a/readlicense_oo/license/CREDITS.fodt b/readlicense_oo/license/CREDITS.fodt index 89fa8ef..560e63d 100644 --- a/readlicense_oo/license/CREDITS.fodt +++ b/readlicense_oo/license/CREDITS.fodt @@ -1,10 +1,10 @@ http://www.w3.org/1999/xlink; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:config="urn:oas is:names:tc:opendocument:xmlns:config:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:ooow="http://openoffice.org/2004/writer; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:rpt="http://openoffice.org/2005/report; xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:officeooo="http://openoffice.org/2009/office; xmlns:tableooo="http://openoffice.org/2009/table; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:formx="urn:openoffice:names: experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" office:mimetype="application/vnd.oasis.opendocument.text"> - Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/5.1.3.2$Linux_X86_64 LibreOffice_project/644e4637d1d8544fd9f56425bd6cec110e49301b2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA + Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/5.1.3.2$Linux_X86_64 LibreOffice_project/644e4637d1d8544fd9f56425bd6cec110e49301b2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA - 501 + 686 501 41197 21327 @@ -16,9 +16,9 @@ 3676 3471 501 - 501 + 686 41697 - 21826 + 22012 0 0 false @@ -68,7 +68,7 @@ false false true - 5217702 + 5262926 false false false @@ -312,21 +312,24 @@ - + - + - + - + + + + - + @@ -390,26 +393,23 @@ - + - + - + - + - + - - - @@ -1030,14 +1030,14 @@ Credits -1164 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2016-05-26 00:00:36. +1166 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2016-06-01 00:10:46. * marks developers whose first contributions happened after 2010-09-28. Developers committing code since 2010-09-28 - + Ruediger TimmCommits: 82464Joined: 2000-10-10 @@ -1057,10 +1057,10 @@ Vladimir GlazunovCommits: 25434Joined: 2000-12-04 - Caolán McNamaraCommits: 19443Joined: 2000-10-10 + Caolán McNamaraCommits: 19471Joined: 2000-10-10 - Stephan BergmannCommits: 12124Joined: 2000-10-04 + Stephan BergmannCommits: 12143Joined: 2000-10-04 Ivo HinkelmannCommits: 9480Joined: 2002-09-09 @@ -1068,16 +1068,16 @@ - Tor LillqvistCommits: 7398Joined: 2010-03-23 + Tor LillqvistCommits: 7408Joined: 2010-03-23 - *Noel GrandinCommits: 5920Joined: 2011-12-12 + *Noel GrandinCommits: 5959Joined: 2011-12-12 - Miklos VajnaCommits:
[Libreoffice-commits] core.git: readlicense_oo/license
readlicense_oo/license/CREDITS.fodt | 2916 ++-- 1 file changed, 1472 insertions(+), 1444 deletions(-) New commits: commit cbf36dd473fdc9e8d8b78c9e9317836a7cbbc6c7 Author: Christian LohmaierDate: Wed Jun 1 02:31:23 2016 +0200 update credits Change-Id: I0932fb77c37c9e48eb5ecb4b26ee44553b8368a5 diff --git a/readlicense_oo/license/CREDITS.fodt b/readlicense_oo/license/CREDITS.fodt index 89fa8ef..560e63d 100644 --- a/readlicense_oo/license/CREDITS.fodt +++ b/readlicense_oo/license/CREDITS.fodt @@ -1,10 +1,10 @@ http://www.w3.org/1999/xlink; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:config="urn:oas is:names:tc:opendocument:xmlns:config:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:ooow="http://openoffice.org/2004/writer; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:rpt="http://openoffice.org/2005/report; xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:officeooo="http://openoffice.org/2009/office; xmlns:tableooo="http://openoffice.org/2009/table; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:formx="urn:openoffice:names: experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" office:mimetype="application/vnd.oasis.opendocument.text"> - Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/5.1.3.2$Linux_X86_64 LibreOffice_project/644e4637d1d8544fd9f56425bd6cec110e49301b2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA + Credits » LibreOfficeCreditscontributorscodersdevelopersCredits for the LibreOffice development/coding.LibreOffice/5.1.3.2$Linux_X86_64 LibreOffice_project/644e4637d1d8544fd9f56425bd6cec110e49301b2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA - 501 + 686 501 41197 21327 @@ -16,9 +16,9 @@ 3676 3471 501 - 501 + 686 41697 - 21826 + 22012 0 0 false @@ -68,7 +68,7 @@ false false true - 5217702 + 5262926 false false false @@ -312,21 +312,24 @@ - + - + - + - + + + + - + @@ -390,26 +393,23 @@ - + - + - + - + - + - - - @@ -1030,14 +1030,14 @@ Credits -1164 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2016-05-26 00:00:36. +1166 individuals contributed to OpenOffice.org (and whose contributions were imported into LibreOffice) or LibreOffice until 2016-06-01 00:10:46. * marks developers whose first contributions happened after 2010-09-28. Developers committing code since 2010-09-28 - + Ruediger TimmCommits: 82464Joined: 2000-10-10 @@ -1057,10 +1057,10 @@ Vladimir GlazunovCommits: 25434Joined: 2000-12-04 - Caolán McNamaraCommits: 19443Joined: 2000-10-10 + Caolán McNamaraCommits: 19471Joined: 2000-10-10 - Stephan BergmannCommits: 12124Joined: 2000-10-04 + Stephan BergmannCommits: 12143Joined: 2000-10-04 Ivo HinkelmannCommits: 9480Joined: 2002-09-09 @@ -1068,16 +1068,16 @@ - Tor LillqvistCommits: 7398Joined: 2010-03-23 + Tor LillqvistCommits: 7408Joined: 2010-03-23 - *Noel GrandinCommits: 5920Joined: 2011-12-12 + *Noel GrandinCommits: 5959Joined: 2011-12-12 - Miklos VajnaCommits: 5613Joined: 2010-07-29 + Miklos VajnaCommits: 5619Joined: 2010-07-29
[Libreoffice-bugs] [Bug 99753] Text referenced from cells in different sheet is capitalised in some cases
https://bugs.documentfoundation.org/show_bug.cgi?id=99753 Aron Budeachanged: What|Removed |Added Summary|text content from other |Text referenced from cells |cells is capitalised|in different sheet is ||capitalised in some cases -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99753] text content from other cells is capitalised
https://bugs.documentfoundation.org/show_bug.cgi?id=99753 Aron Budeachanged: What|Removed |Added Keywords||bibisectRequest Version|5.1.3.1 rc |5.1.2.2 release --- Comment #18 from Aron Budea --- Thanks for the simplified reproduction steps. Apart from the versions mentioned before I also reproduced the bug in: -5.2 beta1, -5.1.2.2 (didn't test with earlier 5.1 versions). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98521] Font in tablecontrol isn't shown in right format
https://bugs.documentfoundation.org/show_bug.cgi?id=98521 --- Comment #4 from frofa--- Please, would someone look at this RECENTLY INTRODUCED bug and try and fix it. For me (as a Mac user), it is a fairly MAJOR interface bug because the FONTS on all my Base form TABLE LISTINGS (carefully set-up under previous versions of LO) now default to some very small and hard-to-read size making if VERY difficult for me to actually see the content. For this reason, I believe this bug should be 'escalated' to a higher priority. All the forms I use have been affected by the complete inability to set the font and font-size in the TABLE CONTROL grid. In other words, whatever value I set in the Table Control properties is SAVED by does not affect the display font and font-size of the TABLE GRID! Is anyone else so affected? And could anyone suggest a 'work-around' to use in the meantime? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - sc/source
sc/source/core/tool/interpr1.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit af2fd81efa1b1ad6dbd0449dcfd0bd57ec0116a9 Author: Pedro GiffuniDate: Tue May 31 23:25:11 2016 + RAND(): Destroy the random pool after seeding. We are using rtl_random() only for seeding, we can save some memory here. diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index 4cfb963..a2fb2ee 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -1679,15 +1679,16 @@ void ScInterpreter::ScRandom() { RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, "sc", "pfg", "ScInterpreter::ScRandom" ); -static rtlRandomPool aPool = rtl_random_createPool(); static sal_Bool SqSeeded = sal_False; static sal_uInt32 ScCNG, ScXS = 362436069; // Seeding for the PRNG if (SqSeeded == sal_False) { +rtlRandomPool aPool = rtl_random_createPool(); rtl_random_getBytes(aPool, , sizeof(ScCNG)); rtl_random_getBytes(aPool, , sizeof(nScRandomQ[0]) * SCRANDOMQ_SIZE); +rtl_random_destroyPool(aPool); SqSeeded = sal_True; } PushDouble(static_cast(KISS) / SAL_MAX_UINT32); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 100038] special at sign(@) treatment is frustrating for new users and impossible to google
https://bugs.documentfoundation.org/show_bug.cgi?id=100038 --- Comment #6 from Frederick Eaton--- > *** This bug has been marked as a duplicate of bug 98154 *** Just wanted to understand what's happening - can someone explain the connection between this bug, and bug 98154? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100076] Computer Crash after selected marking part of document with right mouse click
https://bugs.documentfoundation.org/show_bug.cgi?id=100076 Aron Budeachanged: What|Removed |Added Version|5.2.0.0.alpha1 |5.0.3.2 release Severity|normal |major --- Comment #4 from Aron Budea --- Thanks for the details. Is this option checked? Tools -> Options -> LibreOffice -> View -> Use OpenGL for all rendering If so, try if the crash happens when it's unchecked. If that doesn't help, uncheck Use hardware acceleration. It might also be worth giving the current, 5.1.3.2 version a try. Here are the steps to install it separately from your existing version: https://wiki.documentfoundation.org/Installing_in_parallel/Linux Basically both of these suggestions are to check whether OpenGL acceleration has anything to do with the crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100167] New: Cannot add subform in design view
https://bugs.documentfoundation.org/show_bug.cgi?id=100167 Bug ID: 100167 Summary: Cannot add subform in design view Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: donots...@fastmail.fm User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/50.0.2661.102 Chrome/50.0.2661.102 Safari/537.36 Build Identifier: 1:5.1.3~rc2-0ubuntu1~trusty1 It seems to be possible to create a form with a subform using the Form wizard, but not "manually" in the design view. You can create a subform object via Navigator but there doesn't seem to be a way to attach it to/embed it in an existing form - no toolbox button for "subform". Also, multi-column listboxes would be good :) Reproducible: Always Steps to Reproduce: 1. Design a form in design view 2. Attempt to add a subform Actual Results: Not possible. Expected Results: Possible. Works. Reset User Profile?No -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96097] FILESAVE: Autosave or Save a copy on calc with signed macro breaks the next save
https://bugs.documentfoundation.org/show_bug.cgi?id=96097 Commit Notificationchanged: What|Removed |Added Whiteboard|target:5.2.0|target:5.2.0 target:5.1.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99643] class EOleSysError on com.sun.star.ServiceManager
https://bugs.documentfoundation.org/show_bug.cgi?id=99643 Michael Stahlchanged: What|Removed |Added Status|NEW |RESOLVED CC||d.ostrov...@gmx.de Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |mst...@redhat.com |desktop.org | Whiteboard|target:5.3.0| --- Comment #15 from Michael Stahl --- it breaks when retrieving the UNO service manager via OneInstanceOleWrapper_Impl::CreateInstance() okay so technically this commit "broke" it commit 120586bb305f7bd763753a3f5a8d60e25ad3db8f Author: David Ostrovsky AuthorDate: Sat Feb 20 16:47:26 2016 +0100 Commit: Michael Stahl CommitDate: Mon Feb 29 13:05:33 2016 +0100 Ole: Fix WaE specifically this change: @@ -488,7 +488,7 @@ Any SAL_CALL InterfaceOleWrapper_Impl::createBridge(const Any& modelDepObject, pVar->pdispVal= static_cast ( this); AddRef(); -retAny<<= reinterpret_cast< sal_uInt32 >( pVar); +retAny<<= reinterpret_cast< sal_uIntPtr >( pVar); } } } because the caller of that function stupidly hard-codes an expected return type of TypeClass_UNSIGNED_LONG, which is sal_uInt32, but on a 64-bit platform sal_uIntPtr of course corresponds to TypeClass_UNSIGNED_HYPER. of course the pVar is not at all guaranteed to have its thrown-away upper bits all 0 in a 64-bit build, so if this worked in 5.0 it is purely by luck. fixed on master, by adapting the caller to expect hyper instead, plus fixing up several other callers and implementations of createBridge(). actually i checked again and *both* of the 64-bit pointer fixes mentioned in comment #12 are already in 5.1, so nothing more to backport. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96097] FILESAVE: Autosave or Save a copy on calc with signed macro breaks the next save
https://bugs.documentfoundation.org/show_bug.cgi?id=96097 --- Comment #6 from Commit Notification--- Guillaume Smaha committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=127c56b0501b90283c0bb2f0a06ba242186bc1ca=libreoffice-5-1 tdf#96097: Can't save a doc with signed macro after autosave/save a copy It will be available in 5.1.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99643] class EOleSysError on com.sun.star.ServiceManager
https://bugs.documentfoundation.org/show_bug.cgi?id=99643 --- Comment #14 from Commit Notification--- Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c11e60f11f34b12bf73a08a96634202a8d3aef0c tdf#99643 OLE automation bridge: fix 64-bit pointer conversions It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sfx2/source
sfx2/source/doc/objstor.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 127c56b0501b90283c0bb2f0a06ba242186bc1ca Author: Guillaume SmahaDate: Thu Apr 14 12:36:52 2016 +0200 tdf#96097: Can't save a doc with signed macro after autosave/save a copy Change-Id: Icc886a8d228cb786c6f318cfa2556ef113c553eb Reviewed-on: https://gerrit.libreoffice.org/24081 Tested-by: Jenkins Reviewed-by: jan iversen Tested-by: jan iversen (cherry picked from commit d7ef7e3e4bc9c6277e5b2d08c2657fea8cf0e639) Reviewed-on: https://gerrit.libreoffice.org/24461 Reviewed-by: Christian Lohmaier diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx index cbb3c8c..f8116d7 100644 --- a/sfx2/source/doc/objstor.cxx +++ b/sfx2/source/doc/objstor.cxx @@ -1594,8 +1594,6 @@ bool SfxObjectShell::SaveTo_Impl if ( !aScriptSignName.isEmpty() ) { -pMedium->Close(); - // target medium is still not committed, it should not be closed // commit the package storage and close it, but leave the streams open rMedium.StorageCommit_Impl(); @@ -1653,7 +1651,6 @@ bool SfxObjectShell::SaveTo_Impl { } -pMedium->Close(); rMedium.CloseZipStorage_Impl(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99643] class EOleSysError on com.sun.star.ServiceManager
https://bugs.documentfoundation.org/show_bug.cgi?id=99643 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - embedserv/source extensions/README extensions/source extensions/test
embedserv/source/embed/docholder.cxx |2 - extensions/README | 33 +- extensions/source/ole/oleobjw.cxx |2 - extensions/source/ole/servprov.cxx| 10 +++--- extensions/source/ole/unoconversionutilities.hxx |6 ++-- extensions/test/ole/OleClient/funcs.cxx |2 - extensions/test/ole/OleConverterVar1/convTest.cxx |2 - 7 files changed, 45 insertions(+), 12 deletions(-) New commits: commit 1aff9299ab2e308674af51a138294017d2cc3b8d Author: Michael StahlDate: Wed Jun 1 00:10:46 2016 +0200 extensions: more README Change-Id: I9cd902ce606c800e67cc142daf698962544b26bc diff --git a/extensions/README b/extensions/README index aefd5b88..eeff42a 100644 --- a/extensions/README +++ b/extensions/README @@ -1,4 +1,4 @@ -Browser plugin, activex control, scanner bits. Online update. +This module contains a grab-bag of unrelated misc. libraries, *none* of which is an extension. == Application online update checking == @@ -12,3 +12,34 @@ This creates one more thread, UpdateCheckThread, that regularly checks whether we have reached the time when we should ask for the update. If yes, asks for that, and shows the download button in the menu (if the new update is available). + +== OLE automation bridge == + +A bridge between "OLE automation" and UNO, so you can use UNO services +from JScript, VBScript, etc. + +https://www.openoffice.org/udk/common/man/spec/ole_bridge.html + +See udkapi/com/sun/star/bridge/oleautomation/ApplicationRegistration.idl + +This is initialized in Desktop::Main() in Desktop::OpenClients_Impl() +by creating the service "com.sun.star.bridge.OleApplicationRegistration", +which is implemented by ole_adapter::OleServer_Impl. + +See extensions/source/ole/ + +== ActiveX control == + +This allows embedding LO into a Win32 application as an ActiveX control. +See extensions/source/activex/ + +== Spotlight provider == + +On Mac OS X, this allows indexing ODF documents with Spotlight. +See extensions/source/macosx/spotlight/ + +== Scanner support == + +You can scan from LibreOffice, using platform specific backends like TWAIN/SANE. +See extensions/source/scanner/ + commit c11e60f11f34b12bf73a08a96634202a8d3aef0c Author: Michael Stahl Date: Tue May 31 23:45:53 2016 +0200 tdf#99643 OLE automation bridge: fix 64-bit pointer conversions XBridgeSupplier2::createBridge() is always called in-process and should therefore expect and create Anys with native-sized encoded pointers, so use sal_uIntPtr. Change-Id: Ia757ff38568b07de8085a1a9d323d806bcca0f63 Note: Currently all calls in LO code are with source=UNO, target=OLE. diff --git a/embedserv/source/embed/docholder.cxx b/embedserv/source/embed/docholder.cxx index 5568535..7708e1e 100644 --- a/embedserv/source/embed/docholder.cxx +++ b/embedserv/source/embed/docholder.cxx @@ -1035,7 +1035,7 @@ IDispatch* DocumentHolder::GetIDispatch() bridge::ModelDependent::OLE ); if ( anyResult.getValueTypeClass() == - cppu::UnoType::get().getTypeClass() ) + cppu::UnoType::get().getTypeClass() ) { VARIANT* pVariant = *(VARIANT**)anyResult.getValue(); if ( pVariant->vt == VT_DISPATCH ) diff --git a/extensions/source/ole/oleobjw.cxx b/extensions/source/ole/oleobjw.cxx index b2fde4a..2a2b7eb 100644 --- a/extensions/source/ole/oleobjw.cxx +++ b/extensions/source/ole/oleobjw.cxx @@ -725,7 +725,7 @@ Any SAL_CALL IUnknownWrapper_Impl::createBridge( const Any& modelDepObject, pVariant->punkVal->AddRef(); } -ret.setValue((void*), cppu::UnoType::get()); +ret.setValue(static_cast (), cppu::UnoType::get()); } } diff --git a/extensions/source/ole/servprov.cxx b/extensions/source/ole/servprov.cxx index 6d3d5fa..95b3bad 100644 --- a/extensions/source/ole/servprov.cxx +++ b/extensions/source/ole/servprov.cxx @@ -160,7 +160,7 @@ STDMETHODIMP ProviderOleWrapper_Impl::CreateInstance(IUnknown FAR* punkOuter, OLE); -if (oleAny.getValueTypeClass() == cppu::UnoType::get().getTypeClass()) +if (oleAny.getValueTypeClass() == cppu::UnoType::get().getTypeClass()) { VARIANT* pVariant = *(VARIANT**)oleAny.getValue(); @@ -291,7 +291,7 @@ STDMETHODIMP OneInstanceOleWrapper_Impl::CreateInstance(IUnknown FAR* punkOuter, OLE); -if (oleAny.getValueTypeClass() == TypeClass_UNSIGNED_LONG) +if (oleAny.getValueTypeClass() == cppu::UnoType::get().getTypeClass()) { VARIANT* pVariant = *(VARIANT**)oleAny.getValue(); @@ -374,14 +374,14 @@ Any SAL_CALL OleConverter_Impl2::createBridge(const Any&
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2f6059b8713bb5da943bb7a70a742bfbab0e4566 Author: Christian LohmaierDate: Tue May 31 23:40:28 2016 +0200 Updated core Project: translations 0e263bb2844639929901eec6d9643ba036a08a87 update translations for 5.1.4 rc1 and force-fix errors using pocheck Change-Id: Ie5bedb80db908a0279c44ed20b83dc93c4f63136 diff --git a/translations b/translations index e2faec4..0e263bb 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit e2faec46ab3cada7198c6d912287d75742e5d27f +Subproject commit 0e263bb2844639929901eec6d9643ba036a08a87 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 100166] New: Last entry of toolbar menu (close toolbar) cannot be selected with the mouse
https://bugs.documentfoundation.org/show_bug.cgi?id=100166 Bug ID: 100166 Summary: Last entry of toolbar menu (close toolbar) cannot be selected with the mouse Product: LibreOffice Version: 5.1.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sergio.calleg...@gmail.com Last entry of toolbar menu (close toolbar) cannot be selected with the mouse but it can be selected with the arrow keys... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100093] Calc appends path for data linked cells automatically and incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=100093 --- Comment #9 from Jim@HiTek--- Created attachment 125427 --> https://bugs.documentfoundation.org/attachment.cgi?id=125427=edit Test link with the XLS extension. 4th of 4 attachments. This Test link carries the XLS extension. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100093] Calc appends path for data linked cells automatically and incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=100093 --- Comment #8 from Jim@HiTek--- Created attachment 125426 --> https://bugs.documentfoundation.org/attachment.cgi?id=125426=edit Test link with the ODS extension. 3rd of 4 attachments. This is the file linked to by the MainTest.XXX files. It carries the ODS extension. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100093] Calc appends path for data linked cells automatically and incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=100093 --- Comment #7 from Jim@HiTek--- Created attachment 125425 --> https://bugs.documentfoundation.org/attachment.cgi?id=125425=edit ODS Libre SS SS #2 attachment with the ODS extension. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100093] Calc appends path for data linked cells automatically and incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=100093 --- Comment #6 from Jim@HiTek--- Created attachment 125424 --> https://bugs.documentfoundation.org/attachment.cgi?id=125424=edit Spreadsheet in the ODS format that does have the problem. In order to recreate the problem, there are 4 spreadsheets. Two of them will call (link to) data. The 3rd and 4th will just store that data. Two are saved as ODS documents, and two are saved as XLS documents. I imported them all of my original SS's from a Win10 machine and they are all XLS extensions. I'll try to send the four SS's I created for the test but right this bug report form seems to only allow one attachment at a time. You'll have to edit the two files MainTest files to put in the appropriate path on your computer. I'm new to Ubuntu and I'm still learning the path structure. I created the files and put them in a directory as close to root as I could in their own folder called TestSSFolder directly under 'Home' but the links added 'Jim' as part of the directory path. So you'll have to set up yours on your own. I have found from testing that the XLS sheets are the ones that keep appending to the paths in the links. The ODS sheets don't do that. I do want to keep my SS's as XLS in order to be able to easily go back and forth between my computer and my clients computers. Most of which still use the old XLS formatting. Three more files to follow... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/build loleaflet/dist loleaflet/Makefile loleaflet/src
loleaflet/Makefile |7 loleaflet/build/adminDeps.js |5 +++ loleaflet/dist/admin/admin.html| 42 - loleaflet/dist/admin/adminAnalytics.html | 21 -- loleaflet/dist/admin/adminSettings.html| 32 -- loleaflet/src/admin/AdminSocketBase.js |2 - loleaflet/src/admin/AdminSocketOverview.js |2 - loleaflet/src/admin/AdminStrings.js| 24 loleaflet/src/admin/Util.js|8 ++--- 9 files changed, 96 insertions(+), 47 deletions(-) New commits: commit 4b7261344759e5227dcc23eed166c352810c2d18 Author: Andras TimarDate: Tue May 31 23:26:02 2016 +0200 loleaflet: bccu#1649 l10n of Admin Console diff --git a/loleaflet/Makefile b/loleaflet/Makefile index ab851c1..1fb1998 100644 --- a/loleaflet/Makefile +++ b/loleaflet/Makefile @@ -33,10 +33,15 @@ pot: unocommands.js \ dist/errormessages.js \ dist/toolbar/toolbar.js \ - src/control/Control.Tabs.js \ + src/admin/AdminSocketBase.js \ + src/admin/AdminSocketOverview.js \ + src/admin/AdminStrings.js \ + src/admin/Util.js \ src/control/Control.Menubar.js \ + src/control/Control.Tabs.js \ src/core/Socket.js \ src/map/Map.js + html2po --pot --input=dist/loleaflet-help.html --output=po/loleaflet-help.pot l10n: pot diff --git a/loleaflet/build/adminDeps.js b/loleaflet/build/adminDeps.js index 25757c4..730296f 100644 --- a/loleaflet/build/adminDeps.js +++ b/loleaflet/build/adminDeps.js @@ -32,6 +32,11 @@ var adminDeps = { src: ['admin/AdminSocketSettings.js'], desc: 'Socket to handle settings from server', deps: ['AdminSocketBase'] + }, + + AdminStrings: { + src: ['admin/AdminStrings.js'], + desc: 'String table for user interface' } }; diff --git a/loleaflet/dist/admin/admin.html b/loleaflet/dist/admin/admin.html index d03a6ef..ef4a209 100644 --- a/loleaflet/dist/admin/admin.html +++ b/loleaflet/dist/admin/admin.html @@ -27,14 +27,20 @@ https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"> https://oss.maxcdn.com/respond/1.4.2/respond.min.js">
[Libreoffice-bugs] [Bug 56363] Using Graphite features prevents Special Character dialog from preselecting the Graphite font
https://bugs.documentfoundation.org/show_bug.cgi?id=56363 Adolfo Jaymechanged: What|Removed |Added Summary|Graphite turns Special |Using Graphite features |Character font to UI Font |prevents Special Character ||dialog from preselecting ||the Graphite font -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-1-0' - loleaflet/build loleaflet/dist loleaflet/Makefile loleaflet/src
loleaflet/Makefile |7 loleaflet/build/adminDeps.js |5 +++ loleaflet/dist/admin/admin.html| 42 - loleaflet/dist/admin/adminAnalytics.html | 21 -- loleaflet/dist/admin/adminSettings.html| 32 -- loleaflet/src/admin/AdminSocketBase.js |2 - loleaflet/src/admin/AdminSocketOverview.js |2 - loleaflet/src/admin/AdminStrings.js| 24 loleaflet/src/admin/Util.js|8 ++--- 9 files changed, 96 insertions(+), 47 deletions(-) New commits: commit f6c541a0ef8ce722d616903f1d0ea624f22b5615 Author: Andras TimarDate: Tue May 31 23:26:02 2016 +0200 loleaflet: bccu#1649 l10n of Admin Console (cherry picked from commit 4b7261344759e5227dcc23eed166c352810c2d18) diff --git a/loleaflet/Makefile b/loleaflet/Makefile index e11b8a4..7f7b36b 100644 --- a/loleaflet/Makefile +++ b/loleaflet/Makefile @@ -33,10 +33,15 @@ pot: unocommands.js \ dist/errormessages.js \ dist/toolbar/toolbar.js \ - src/control/Control.Tabs.js \ + src/admin/AdminSocketBase.js \ + src/admin/AdminSocketOverview.js \ + src/admin/AdminStrings.js \ + src/admin/Util.js \ src/control/Control.Menubar.js \ + src/control/Control.Tabs.js \ src/core/Socket.js \ src/map/Map.js + html2po --pot --input=dist/loleaflet-help.html --output=po/loleaflet-help.pot l10n: pot diff --git a/loleaflet/build/adminDeps.js b/loleaflet/build/adminDeps.js index 25757c4..730296f 100644 --- a/loleaflet/build/adminDeps.js +++ b/loleaflet/build/adminDeps.js @@ -32,6 +32,11 @@ var adminDeps = { src: ['admin/AdminSocketSettings.js'], desc: 'Socket to handle settings from server', deps: ['AdminSocketBase'] + }, + + AdminStrings: { + src: ['admin/AdminStrings.js'], + desc: 'String table for user interface' } }; diff --git a/loleaflet/dist/admin/admin.html b/loleaflet/dist/admin/admin.html index d03a6ef..ef4a209 100644 --- a/loleaflet/dist/admin/admin.html +++ b/loleaflet/dist/admin/admin.html @@ -27,14 +27,20 @@ https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"> https://oss.maxcdn.com/respond/1.4.2/respond.min.js">
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sc/inc sc/source
sc/inc/column.hxx|1 + sc/inc/document.hxx |1 + sc/inc/table.hxx |1 + sc/inc/tokenarray.hxx|1 + sc/source/core/data/column.cxx | 29 + sc/source/core/data/document.cxx | 13 + sc/source/core/data/table2.cxx |8 sc/source/ui/unoobj/docuno.cxx |9 + 8 files changed, 63 insertions(+) New commits: commit 2534e5f046654c69173b84d040013b7e1c6c3f1e Author: Marco CecchettiDate: Thu May 26 21:28:35 2016 +0200 tdf#100160 - Changing OpenCL state doesn't update sheet now we re-check for vectorization state of formula token each time OpenCL is enabled or disabled Change-Id: I652397dd154f5fbf788cb511c70e53a47cc94293 Reviewed-on: https://gerrit.libreoffice.org/25727 Reviewed-by: Jan Holesovsky Tested-by: Michael Meeks Reviewed-by: Michael Meeks diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx index 69cb036..5b319d5 100644 --- a/sc/inc/column.hxx +++ b/sc/inc/column.hxx @@ -375,6 +375,7 @@ public: bool IsFormulaDirty( SCROW nRow ) const; +void CheckVectorizationState(); void SetAllFormulasDirty( const sc::SetFormulaDirtyContext& rCxt ); void SetDirtyFromClip( SCROW nRow1, SCROW nRow2, sc::ColumnSpanSet& rBroadcastSpans ); void SetDirty( SCROW nRow1, SCROW nRow2, BroadcastMode ); diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index 4cb2de4..194fc7d 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -1036,6 +1036,7 @@ public: voidResetChanged( const ScRange& rRange ); +void CheckVectorizationState(); void SetAllFormulasDirty( const sc::SetFormulaDirtyContext& rCxt ); voidSetDirty( const ScRange&, bool bIncludeEmptyCells ); voidSetTableOpDirty( const ScRange& ); // for Interpreter TableOp diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx index da2876f..9efd590 100644 --- a/sc/inc/table.hxx +++ b/sc/inc/table.hxx @@ -526,6 +526,7 @@ public: voidResetChanged( const ScRange& rRange ); +void CheckVectorizationState(); void SetAllFormulasDirty( const sc::SetFormulaDirtyContext& rCxt ); voidSetDirty( const ScRange&, ScColumn::BroadcastMode ); voidSetDirtyAfterLoad(); diff --git a/sc/inc/tokenarray.hxx b/sc/inc/tokenarray.hxx index 1644264..9808b8b 100644 --- a/sc/inc/tokenarray.hxx +++ b/sc/inc/tokenarray.hxx @@ -65,6 +65,7 @@ public: size_t GetHash() const { return mnHashValue;} ScFormulaVectorState GetVectorState() const { return meVectorState;} +void ResetVectorState() { meVectorState = FormulaVectorEnabled; } /** * If the array contains at least one relative row reference or named diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx index 5f562ca..d4b5a2e 100644 --- a/sc/source/core/data/column.cxx +++ b/sc/source/core/data/column.cxx @@ -2646,6 +2646,28 @@ public: } }; +class CheckVectorizationHandler +{ +public: +CheckVectorizationHandler() +{} + +void operator() (size_t /*nRow*/, ScFormulaCell* p) +{ +ScTokenArray* pCode = p->GetCode(); +if (pCode != nullptr && pCode->GetVectorState() == FormulaVectorDisabled) +{ +pCode->ResetVectorState(); +FormulaToken* pFT = pCode->First(); +while (pFT != nullptr) +{ +pCode->CheckToken(*pFT); +pFT = pCode->Next(); +} +} +} +}; + struct SetDirtyVarHandler { void operator() (size_t /*nRow*/, ScFormulaCell* p) @@ -3089,6 +3111,13 @@ bool ScColumn::IsFormulaDirty( SCROW nRow ) const return p->GetDirty(); } +void ScColumn::CheckVectorizationState() +{ +sc::AutoCalcSwitch aSwitch(*pDocument, false); +CheckVectorizationHandler aFunc; +sc::ProcessFormula(maCells, aFunc); +} + void ScColumn::SetAllFormulasDirty( const sc::SetFormulaDirtyContext& rCxt ) { // is only done documentwide, no FormulaTracking diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx index ca63d82..c0f4fa3 100644 --- a/sc/source/core/data/document.cxx +++ b/sc/source/core/data/document.cxx @@ -3716,6 +3716,19 @@ bool ScDocument::HasSelectionData( SCCOL nCol, SCROW nRow, SCTAB nTab ) const return HasStringCells( ScRange( nCol, 0, nTab, nCol, MAXROW, nTab ) ); } +void ScDocument::CheckVectorizationState() +{ +bool bOldAutoCalc = GetAutoCalc(); +bAutoCalc = false; // no mulitple calculations + +TableContainer::iterator it = maTabs.begin(); +for (; it != maTabs.end(); ++it) +if (*it) +(*it)->CheckVectorizationState(); + +SetAutoCalc(bOldAutoCalc); +} + void ScDocument::SetAllFormulasDirty( const sc::SetFormulaDirtyContext& rCxt ) {
[Libreoffice-bugs] [Bug 100159] If OpenGL is used, but a shader fails to compile or link, nothing will show up
https://bugs.documentfoundation.org/show_bug.cgi?id=100159 Commit Notificationchanged: What|Removed |Added Whiteboard|target:5.3.0 target:5.2.0.1 |target:5.3.0 target:5.2.0.1 ||target:5.1.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100159] If OpenGL is used, but a shader fails to compile or link, nothing will show up
https://bugs.documentfoundation.org/show_bug.cgi?id=100159 --- Comment #4 from Commit Notification--- Tor Lillqvist committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0f2d826394fcbb3f9cfbcc818d46dc15f32b5028=libreoffice-5-1 tdf#100159: On Windows, compile GL shaders in advance, disable GL on failure It will be available in 5.1.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - desktop/source desktop/unx desktop/win32 include/desktop vcl/source
desktop/source/app/app.cxx |2 desktop/source/app/sofficemain.cxx |2 desktop/source/inc/exithelper.h| 38 --- desktop/unx/source/start.c |2 desktop/win32/source/officeloader/officeloader.cxx |2 include/desktop/exithelper.h | 38 +++ vcl/source/opengl/OpenGLContext.cxx| 109 + vcl/source/opengl/OpenGLHelper.cxx |9 - 8 files changed, 155 insertions(+), 47 deletions(-) New commits: commit 0f2d826394fcbb3f9cfbcc818d46dc15f32b5028 Author: Tor LillqvistDate: Wed May 25 15:23:22 2016 +0300 tdf#100159: On Windows, compile GL shaders in advance, disable GL on failure This is a combination of multiple commits in master, adapted for this branch as necessary: Don't claim to be reading a file before trying to open it Avoid redundancy: The same information was logged in readProgramBinary() Use VCL_GL_INFO here Failing to open a cached shader binary is a no reason for a SAL_WARN. It is normal that they don't exist when first trying, that is the very nature of a 'cache'. Move exithelper.h to include. We will want to use EXITHELPER_NORMAL_RESTART in vcl, too. If the shader compilation or loading of an already compiled shader fails, disable OpenGL in the registry and exit with the EXITHELPER_NORMAL_RESTART status. The wrapper process will thus run soffice.bin once more, and this time OpenGL will not be used. Change-Id: I54d92f150975d3fa72d93f3f679b16c90ee38f02 Reviewed-on: https://gerrit.libreoffice.org/25708 Reviewed-by: Jan Holesovsky Tested-by: Michael Meeks diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx index 3927840..958ca8a 100644 --- a/desktop/source/app/app.cxx +++ b/desktop/source/app/app.cxx @@ -35,7 +35,6 @@ #include "lockfile.hxx" #include "userinstall.hxx" #include "desktopcontext.hxx" -#include "exithelper.h" #include "migration.hxx" #include @@ -78,6 +77,7 @@ #include #include +#include #include #include #include diff --git a/desktop/source/app/sofficemain.cxx b/desktop/source/app/sofficemain.cxx index c94d5f14..28296ee 100644 --- a/desktop/source/app/sofficemain.cxx +++ b/desktop/source/app/sofficemain.cxx @@ -22,10 +22,10 @@ #include "desktopdllapi.h" #include "app.hxx" -#include "exithelper.h" #include "cmdlineargs.hxx" #include "cmdlinehelp.hxx" +#include #include #include #include diff --git a/desktop/unx/source/start.c b/desktop/unx/source/start.c index b072f0f..8583f5b 100644 --- a/desktop/unx/source/start.c +++ b/desktop/unx/source/start.c @@ -25,6 +25,7 @@ #include #include +#include #include #include #include @@ -34,7 +35,6 @@ #include #include "args.h" -#include "../../source/inc/exithelper.h" #include "pagein.h" #include "splashx.h" diff --git a/desktop/win32/source/officeloader/officeloader.cxx b/desktop/win32/source/officeloader/officeloader.cxx index e782c90..81be532 100644 --- a/desktop/win32/source/officeloader/officeloader.cxx +++ b/desktop/win32/source/officeloader/officeloader.cxx @@ -40,10 +40,10 @@ #include #include +#include #include #include -#include "../../../source/inc/exithelper.h" #include "../loader.hxx" #include diff --git a/desktop/source/inc/exithelper.h b/include/desktop/exithelper.h similarity index 90% rename from desktop/source/inc/exithelper.h rename to include/desktop/exithelper.h index f92f1a8..51175fa 100644 --- a/desktop/source/inc/exithelper.h +++ b/include/desktop/exithelper.h @@ -17,8 +17,8 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_DESKTOP_SOURCE_INC_EXITHELPER_H -#define INCLUDED_DESKTOP_SOURCE_INC_EXITHELPER_H +#ifndef INCLUDED_DESKTOP_EXITHELPER_H +#define INCLUDED_DESKTOP_EXITHELPER_H enum EExitCodes { /* e.g. used to force showing of the command line help */ @@ -33,6 +33,6 @@ enum EExitCodes { EXITHELPER_NORMAL_RESTART = 81 }; -#endif // INCLUDED_DESKTOP_SOURCE_INC_EXITHELPER_H +#endif // INCLUDED_DESKTOP_EXITHELPER_H /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index 03d0a5d..1ce8ce8 100644 --- a/vcl/source/opengl/OpenGLContext.cxx +++ b/vcl/source/opengl/OpenGLContext.cxx @@ -9,6 +9,7 @@ #include +#include #include #include #include @@ -839,6 +840,107 @@ bool OpenGLContext::ImplInit() #elif defined( _WIN32 ) +namespace +{ + +bool tryShaders(const OUString& rVertexShader, const OUString& rFragmentShader, const OUString& rGeometryShader = "", const OString& rPreamble = "") +{ +GLint nId; + +// Somewhat mysteriously, the OpenGLHelper::LoadShaders() API saves a compiled binary of the
[Libreoffice-bugs] [Bug 95292] Mail merge does not print the last record when having odd records
https://bugs.documentfoundation.org/show_bug.cgi?id=95292 --- Comment #23 from p_kongs...@op.pl --- Bug is still present in Version: 5.1.3.2 Build ID: 644e4637d1d8544fd9f56425bd6cec110e49301b CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; Locale: en-US (en_US.UTF-8) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100093] Calc appends path for data linked cells automatically and incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=100093 --- Comment #5 from Buovjaga--- (In reply to Jim@HiTek from comment #4) > Not sure what you need an example document of? I've attached the error > message though. In every case that there is a problematic document, we need it to examine the problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 V Stuart Footechanged: What|Removed |Added Depends on||100164 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100164 [Bug 100164] HiDPI shouldn't be thresholded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100164] HiDPI shouldn't be thresholded
https://bugs.documentfoundation.org/show_bug.cgi?id=100164 V Stuart Footechanged: What|Removed |Added CC||vstuart.fo...@utsa.edu Blocks||90796 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90796 [Bug 90796] [META] HiDPI / Retina bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100151] crash pptx file at the end of the presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=100151 Julien Nabetchanged: What|Removed |Added Keywords||wantBacktrace CC||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I don't reproduce this. I tested with rendering=gtk3/gtk/kde4/gen -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92609] EDITING: Crash when pressing enter after form control anchored as character
https://bugs.documentfoundation.org/show_bug.cgi?id=92609 Caolán McNamarachanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Caolán McNamara --- indeed, 5.1 works for me, and that now the oldest supported release, so lets claim this as fixed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100113] Add "Remote file" option are locked
https://bugs.documentfoundation.org/show_bug.cgi?id=100113 Leandro Martín Drudichanged: What|Removed |Added Version|5.1.3.2 release |5.1.1.3 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: /usr/lib/libnss3.so: version `NSS_3.19.1' not found
On 30/05/16 10:17, YuGiOhJCJ Mailing-List wrote: > It seems that my machine does not crash whereas currently: > * I got this line in my /etc/fstab file: > tmpfs/dev/shm tmpfs defaults 0 0 > * My RAM is 4GB > * My swap is 1 GB > * RAM + swap = 5GB > * Calling '$ du -h /tmp' gives me a /tmp disk usage of 15GB (which is bigger > than my RAM + swap) > > Why my machine does not crash in these conditions? Lionel picked me up on this, that line does not declare /tmp. So /tmp is on your local hard disk. Assuming Slack does clear out /tmp on a reboot, that gives us a baseline of you need at least 15GB for /tmp if you're going to do your build there. Adjust my figures accordingly ... But you're probably better off with an overlay, if you can work out how to use it. (Incidentally, do a "man df", that's a useful command here too - your /tmp is currently almost certainly on the / drive, and that'll tell you how much space you've got free...) Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 84411] OpenCL: S/W interpreter throws std::out_of_range error
https://bugs.documentfoundation.org/show_bug.cgi?id=84411 Commit Notificationchanged: What|Removed |Added Whiteboard|target:5.3.0|target:5.3.0 target:5.1.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84411] OpenCL: S/W interpreter throws std::out_of_range error
https://bugs.documentfoundation.org/show_bug.cgi?id=84411 --- Comment #10 from Commit Notification--- Marco Cecchetti committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a97f9c5790b4751098b0c3f78a387fbff36582a6=libreoffice-5-1 tdf#84411 - OpenCL: S/W interpreter throws std::out_of_range error It will be available in 5.1.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93779] Crash (SEH exception) when using WordWeb dictionary
https://bugs.documentfoundation.org/show_bug.cgi?id=93779 --- Comment #16 from V Stuart Foote--- (In reply to luxian from comment #14) > I joint the "fichier.odt" file. > Normaly, it's minimalistic, there is no more personal information in. > > I hope that can be usefull to correct this anoying (but not terrible) bug. > > Thank in advance for your help. > > Luxian. This issue has nothing to do with the issue here with WordWeb. The SEH Exception there was while handling non-scalable Courier font with replacement Courier New font--that issue has been corrected for the 5.0.6, and 5.2.0 releases, supposedly for 5.1.3 branch: see bug 98989 and commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=2f89245fb7e1c94bed49dde10b08ab1cf41b597b -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sc/source
sc/source/core/tool/scmatrix.cxx |4 1 file changed, 4 insertions(+) New commits: commit a97f9c5790b4751098b0c3f78a387fbff36582a6 Author: Marco CecchettiDate: Tue May 31 10:42:06 2016 +0200 tdf#84411 - OpenCL: S/W interpreter throws std::out_of_range error The problem is that in a array fragment, row start can be beyond data row end. Change-Id: I33658c87c21d1be237f4675241e3eabdd4ec7058 Reviewed-on: https://gerrit.libreoffice.org/25728 Reviewed-by: Jan Holesovsky Reviewed-by: Michael Meeks Tested-by: Michael Meeks diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx index 47652d2..c70bf71 100644 --- a/sc/source/core/tool/scmatrix.cxx +++ b/sc/source/core/tool/scmatrix.cxx @@ -3065,6 +3065,10 @@ void ScVectorRefMatrix::ensureFullMatrix() size_t nRowSize = mnRowSize; size_t nRowEnd = mnRowStart + mnRowSize; size_t nDataRowEnd = mpToken->GetArrayLength(); + +if (mnRowStart >= nDataRowEnd) +return; + if (nRowEnd > nDataRowEnd) { // Data array is shorter than the row size of the reference. Truncate ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 65152] FORMATTING: Superscript and Spacing character formats not copied by paintbrush
https://bugs.documentfoundation.org/show_bug.cgi?id=65152 --- Comment #6 from Jim Avera--- Bug is still there in 5.2.0.0.alpha0 (build from 2016-04-11). I changed the bug title to specifically mention that Superscript and Spacing character format options are not copied by the paintbrush. Here are simplified STEPS TO REPRODUCE: 1. Open the attached bugdemo.ods 2. Click in A1 (selects the cell) 3. Click the Clone Formatting Paintbrush 4. Click in A4 RESULTS: Font side and outline change in A4, but the result does not have the Superscript or modified character Spacing of the text in A1 EXPECTED RESULTS: All character attributes would be cloned -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - i18npool/source
i18npool/source/localedata/data/fi_FI.xml |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 2518935003b879fdfe30cf278b46f4e3a00f3576 Author: Eike RathkeDate: Tue May 31 16:30:45 2016 +0200 Resolves: tdf#63272 [fi-FI] percentage format with no-break space Caveat, the space needs to be quoted, otherwise it is taken as the group separator that when trailing a number divides the number by 1000. Change-Id: Ic24b90d500a6c9351ef7463b2b1adf9d066442df (cherry picked from commit 5868d927bccfc9594c4f791d0800337a0ce60c18) Reviewed-on: https://gerrit.libreoffice.org/25738 Reviewed-by: Christian Lohmaier Tested-by: Christian Lohmaier diff --git a/i18npool/source/localedata/data/fi_FI.xml b/i18npool/source/localedata/data/fi_FI.xml index 0492d88..080a967 100644 --- a/i18npool/source/localedata/data/fi_FI.xml +++ b/i18npool/source/localedata/data/fi_FI.xml @@ -81,10 +81,10 @@ ##0,00E+00 - 0% + 0"Â "% - 0,00% + 0,00"Â "% #Â ##0 [$mk-40B];-#Â ##0 [$mk-40B] ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 65152] FORMATTING: Superscript and Spacing character formats not copied by paintbrush
https://bugs.documentfoundation.org/show_bug.cgi?id=65152 Jim Averachanged: What|Removed |Added Summary|FORMATTING: Certain |FORMATTING: Superscript and |character format options|Spacing character formats |not copied by format|not copied by paintbrush |paintbrush | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65152] FORMATTING: Certain character format options not copied by format paintbrush
https://bugs.documentfoundation.org/show_bug.cgi?id=65152 Jim Averachanged: What|Removed |Added Summary|FORMATTING: Certain |FORMATTING: Certain |character format options|character format options |not copied by format|not copied by format |painbrush |paintbrush -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86988] RSIDs should not be created unless enabled in Options
https://bugs.documentfoundation.org/show_bug.cgi?id=86988 --- Comment #5 from Jim Avera--- Created attachment 125423 --> https://bugs.documentfoundation.org/attachment.cgi?id=125423=edit Instructions in comment #4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94189] Connection (conversion) .mdb --> .odb
https://bugs.documentfoundation.org/show_bug.cgi?id=94189 V Stuart Footechanged: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=93 | |779 | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93779] Crash (SEH exception) when using WordWeb dictionary
https://bugs.documentfoundation.org/show_bug.cgi?id=93779 V Stuart Footechanged: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=94 | |189 | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86988] RSIDs should not be created unless enabled in Options
https://bugs.documentfoundation.org/show_bug.cgi?id=86988 --- Comment #4 from Jim Avera--- Problem is still there in 5.2.0.0.alpha0+ Now, however, Tools->Options-Writer->Comparison no longer even has an option to enable RSIDs, and they seem to be permanently enabled. This problem really striked at the heart of the philosophy of why ODF was created -- to make a format which was simple and to facilitate different tools interoperating. As it is, the pervasive injection of RSID-related styles make interoperation with other software very difficult (e.g. the ODF::lpOD library is almost useless because of this). To make things more clear, here is an example of STEPS TO REPRODUCE: 1. Open the attached "rsidtest.odt" 2. Replace the capitalized word "THIS" in the first sentence with a lower-cased version (or may any other "spelling corrections" you like). 3. Save and exit LO 4. mkdir tempdir cd tempdir unzip -q ../rsidtest.odt xml_pp -i -s nsgmls *.xml # makes them easier to read 5. Examine "content.xml" with vim or similar Search for "Replace this word" (the corrected sentence in the document) RESULTS: The search will not succeed because of the injection of RSID-related styles for each of the fragments around the edit. EXPECTED RESULTS: Unless RSIDs are enabled, the "Replace this word ..." sentence should be in a single ODF object. In general, ODF objects should not be fragmented unless there is a visible or functional reason to do so. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93779] Crash (SEH exception) when using WordWeb dictionary
https://bugs.documentfoundation.org/show_bug.cgi?id=93779 V Stuart Footechanged: What|Removed |Added CC||vstuart.fo...@utsa.edu Summary|SEH Exception: ACCESS |Crash (SEH exception) when |VIOLATION |using WordWeb dictionary --- Comment #15 from V Stuart Foote --- Helper utility use with LibreOffice Writer having issues is WordWeb Software's WordWeb Dictionary. http://wordweb.info/ If you are not using this commercial product (its free or paid "Pro" version) the "SEH Exception: ACCESS VIOLATION" is a generic error message and is not related to this issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64445] EDITING: Very hard to edit text with "Wrap Through" image underneath
https://bugs.documentfoundation.org/show_bug.cgi?id=64445 --- Comment #5 from Jim Avera--- Bug is still there in 5.1.3.2 Also, I was never able to find any way to edit the text (besides removing the image or moving it somehwere else in the document temporarily). I'm curious how Joel did it. => Again Arrange->Send to Back has no apparent effect with respect to text. In other words, the image can't be put "behind" the text so you can select the text. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100151] crash pptx file at the end of the presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=100151 --- Comment #1 from MM--- Unconfirmed with v4.4.7.2 under windows 7 x64. Unconfirmed with v5.1.3.2 under windows 10 x64. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93779] SEH Exception: ACCESS VIOLATION
https://bugs.documentfoundation.org/show_bug.cgi?id=93779 luxianchanged: What|Removed |Added Version|5.0.1.2 release |5.1.3.2 release --- Comment #14 from luxian --- Hello, It's my first connection here and by research I fall on this thread. I hope I do well by posting here, if not just guide me plz. I've got a specific file, when I open it on Windows 10 / LibreOffice 5.1.3.2 locale fr_FR : - it open - a message box appear : LibreOffice 5.1 Fatal Error - SEH Exception: ACCESS VIOLATION - then I click on OK button - then LibreOffice just all close not really crash - I say no crash, because reopen the file give same behavior without repair of file. No problem with other odt files on this machine. I did a research inside the file ... with a VirtualBox Ubuntu Mate 16.04 "by default" but in french (I'm a French). - I open this file "fichier.odt" ... suppress a bit. - Let synchronize via dropbox with Windows 10 host machine - Open under LibreOffice Windows - see the crash - etc etc etc near 20 times :) ... Until there is only 1 letter inside the file ! I've seen that at this state, if I change the font who is "Courier" to another font, the file stop to crash the Windows LibreOffice. More information : the word Courier, in the toolbar, is in italic (I imagined the courier font is like I write now). So, it's like a bit if the file ask a not existant font in the OS ? I don't know, here is my limit of analysis (or I must unzip and become a odt expert that I'm not). On google, it seems that the bug was is knew and was resolved in OpenOffice 4.1.2, see this : http : / / 140.211.11.67 /fr / forum /viewtopic.php ? t= 44479 & p = 242474 And here too ... but no direction of solution : https : / / forum.openoffice.org / fr /forum / viewtopic.php ? f = 5 & t = 44462 I solved the problem on the original file by just change the font. There is probabely a problem between "courier" and "courrier new" when only "courrier new" is installed on Windows and the file was written first under Ubuntu Mate I joint the "fichier.odt" file. Normaly, it's minimalistic, there is no more personal information in. I hope that can be usefull to correct this anoying (but not terrible) bug. Thank in advance for your help. Luxian. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93779] SEH Exception: ACCESS VIOLATION
https://bugs.documentfoundation.org/show_bug.cgi?id=93779 --- Comment #13 from luxian--- Created attachment 125422 --> https://bugs.documentfoundation.org/attachment.cgi?id=125422=edit file who give the problem Watch near "courier" definition font when no courier font is available on Windows. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93386] Crashes when closing a Database with macro editor open
https://bugs.documentfoundation.org/show_bug.cgi?id=93386 Caolán McNamarachanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93386] Crashes when closing a Database with macro editor open
https://bugs.documentfoundation.org/show_bug.cgi?id=93386 --- Comment #22 from Commit Notification--- Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9f21b660fe2ed3805614be5d782137554e32e7d2=libreoffice-5-2 Resolves: tdf#93386 crash when closing a Database with macro editor open It will be available in 5.2.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93386] Crashes when closing a Database with macro editor open
https://bugs.documentfoundation.org/show_bug.cgi?id=93386 Commit Notificationchanged: What|Removed |Added Whiteboard|target:5.3.0|target:5.3.0 target:5.2.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/unoobj/docuno.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 299946676fdced263305db35164950ada1caba0b Author: Caolán McNamaraDate: Tue May 31 18:54:35 2016 +0100 try to fix arm build failure Change-Id: Ib0ab738f09d7112d455743a58529463aa6a73941 diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx index 56d5a61..e35e2c30 100644 --- a/sc/source/ui/unoobj/docuno.cxx +++ b/sc/source/ui/unoobj/docuno.cxx @@ -2833,7 +2833,9 @@ void ScModelObj::enableOpenCL(sal_Bool bEnable) aConfig.setOpenCLConfigToDefault(); ScInterpreter::SetGlobalConfig(aConfig); +#if HAVE_FEATURE_OPENCL sc::FormulaGroupInterpreter::switchOpenCLDevice(OUString(), true, false); +#endif ScDocument* pDoc = GetDocument(); pDoc->CheckVectorizationState(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - basic/source
basic/source/basmgr/basicmanagerrepository.cxx | 54 + 1 file changed, 38 insertions(+), 16 deletions(-) New commits: commit 9f21b660fe2ed3805614be5d782137554e32e7d2 Author: Caolán McNamaraDate: Tue May 31 17:05:59 2016 +0100 Resolves: tdf#93386 crash when closing a Database with macro editor open Change-Id: Id3ecee744cb10f539f2b57e83a4b6e4c7744d3d5 (cherry picked from commit 9a0fd9c7f424fb787e1fae2113f0a42f0895a1e9) diff --git a/basic/source/basmgr/basicmanagerrepository.cxx b/basic/source/basmgr/basicmanagerrepository.cxx index 35c965b..02a4555 100644 --- a/basic/source/basmgr/basicmanagerrepository.cxx +++ b/basic/source/basmgr/basicmanagerrepository.cxx @@ -104,6 +104,17 @@ namespace basic BasicManager*& impl_getLocationForModel( const Reference< XModel >& _rxDocumentModel ); +/** tests if there is a location set at which the BasicManager for the given model +is stored. + +@param _rxDocumentModel +the model whose BasicManager's location is to be retrieved. Must not be . + +@precond +our mutex is locked +*/ +bool impl_hasLocationForModel( const Reference< XModel >& _rxDocumentModel ); + /** creates a new BasicManager instance for the given model @param _out_rpBasicManager @@ -113,7 +124,7 @@ namespace basic @param _rxDocumentModel the model whose BasicManager will be created. Must not be . */ -void impl_createManagerForModel( +bool impl_createManagerForModel( BasicManager*& _out_rpBasicManager, const Reference< XModel >& _rxDocumentModel ); @@ -207,7 +218,6 @@ namespace basic create( CreateImplRepository(), ::osl::GetGlobalMutex() ); } - BasicManager* ImplRepository::getDocumentBasicManager( const Reference< XModel >& _rxDocumentModel ) { SolarMutexGuard g; @@ -221,13 +231,13 @@ namespace basic without creating another instance. */ BasicManager*& pBasicManager = impl_getLocationForModel( _rxDocumentModel ); -if ( pBasicManager == nullptr ) -impl_createManagerForModel( pBasicManager, _rxDocumentModel ); - -return pBasicManager; +if (pBasicManager != nullptr) +return pBasicManager; +if (impl_createManagerForModel(pBasicManager, _rxDocumentModel)) +return pBasicManager; +return nullptr; } - BasicManager* ImplRepository::getApplicationBasicManager( bool _bCreate ) { SolarMutexGuard g; @@ -353,7 +363,6 @@ namespace basic return pAppBasic; } - BasicManager*& ImplRepository::impl_getLocationForModel( const Reference< XModel >& _rxDocumentModel ) { Reference< XInterface > xNormalized( _rxDocumentModel, UNO_QUERY ); @@ -363,6 +372,13 @@ namespace basic return location; } +bool ImplRepository::impl_hasLocationForModel( const Reference< XModel >& _rxDocumentModel ) +{ +Reference< XInterface > xNormalized( _rxDocumentModel, UNO_QUERY ); +DBG_ASSERT( _rxDocumentModel.is(), "ImplRepository::impl_getLocationForModel: invalid model!" ); + +return m_aStore.find(xNormalized) != m_aStore.end(); +} void ImplRepository::impl_initDocLibraryContainers_nothrow( const Reference< XPersistentLibraryContainer >& _rxBasicLibraries, const Reference< XPersistentLibraryContainer >& _rxDialogLibraries ) { @@ -389,8 +405,7 @@ namespace basic } } - -void ImplRepository::impl_createManagerForModel( BasicManager*& _out_rpBasicManager, const Reference< XModel >& _rxDocumentModel ) +bool ImplRepository::impl_createManagerForModel( BasicManager*& _out_rpBasicManager, const Reference< XModel >& _rxDocumentModel ) { StarBASIC* pAppBasic = impl_getDefaultAppBasicLibrary(); @@ -399,13 +414,13 @@ namespace basic if ( !impl_getDocumentStorage_nothrow( _rxDocumentModel, xStorage ) ) { // the document is not able to provide the storage it is based on. -return; +return false; } Reference< XPersistentLibraryContainer > xBasicLibs; Reference< XPersistentLibraryContainer > xDialogLibs; if ( !impl_getDocumentLibraryContainers_nothrow( _rxDocumentModel, xBasicLibs, xDialogLibs ) ) // the document does not have BasicLibraries and DialogLibraries -return; +return false; if ( xStorage.is() ) { @@ -466,20 +481,27 @@ namespace basic // register as listener for this model being disposed/closed OSL_ENSURE( _rxDocumentModel.is(), "ImplRepository::impl_createManagerForModel: the document must be an XComponent!" ); +
[Libreoffice-bugs] [Bug 100146] Embedded images export / convert with degraded resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=100146 --- Comment #7 from ske...@gmail.com --- On Ubuntu 16.04 the conversion fails as follows: # convert image4.wmf image4.svg ERROR: player/record.h (28): Bad record - unexpectedly short! ERROR: player/record.h (28): Bad record - unexpectedly short! ERROR: player/record.h (28): Bad record - unexpectedly short! ERROR: player/record.h (28): Bad record - unexpectedly short! ERROR: player/record.h (101): Bad record - unexpectedly short! convert: failed to scan file `image4.wmf' @ error/wmf.c/ReadWMFImage/2706. convert: no images defined `image4.svg' @ error/convert.c/ConvertImageCommand/3210. # convert --version Version: ImageMagick 6.8.9-9 Q16 x86_64 2016-04-18 http://www.imagemagick.org Copyright: Copyright (C) 1999-2014 ImageMagick Studio LLC Features: DPC Modules OpenMP Delegates: bzlib djvu fftw fontconfig freetype jbig jng jpeg lcms lqr ltdl lzma openexr pangocairo png tiff wmf x xml zlib -=note=- The convert package isn't at version 7 as it was in your testing. The work around is as mentioned in Comment 5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80149] FILESAVE: Control characters in imported CSV files cause problems once saved as xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=80149 Eike Rathkechanged: What|Removed |Added CC||er...@redhat.com --- Comment #5 from Eike Rathke --- Characters below 0x20, except tab, carriage return and linefeed, are illegal characters in XML, see https://www.w3.org/TR/xml/#charsets EVEN the
[Libreoffice-bugs] [Bug 99753] text content from other cells is capitalised
https://bugs.documentfoundation.org/show_bug.cgi?id=99753 --- Comment #17 from Thomas Boehm--- I can reproduce the bug as following: - create new calc document - fill one or more cells in column A with text - add a new sheet - put "=Sheet1.A1" into cell A1 of Sheet2 - copy down A1 until A100 or more All text is converted to UPPERCASE in Sheet2. The bug does not appear if I copy down only to A99 or less. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 98290] Better shortcuts for the Mac OS X platform
https://bugs.documentfoundation.org/show_bug.cgi?id=98290 Commit Notificationchanged: What|Removed |Added Whiteboard|target:5.2.0|target:5.2.0 target:5.3.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/data/org/openoffice/Office/Accelerators.xcu | 64 -- 1 file changed, 56 insertions(+), 8 deletions(-) New commits: commit 3e14a07a909439fa012e2831c1a163c527b07d50 Author: Yousuf PhilipsDate: Fri May 20 22:24:31 2016 +0400 tdf#98290 New Mac shortcut for fullscreen for all apps Change-Id: Iacb8cd21e2323dff575da130ea9ec4fd98096a88 Reviewed-on: https://gerrit.libreoffice.org/25221 Tested-by: Jenkins Reviewed-by: Yousuf Philips diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu index 4112084..ec657ce 100644 --- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu @@ -1322,7 +1322,13 @@ I10N SHORTCUTS - NO TRANSLATE -.uno:FullScreen +.uno:FullScreen + + + + +I10N SHORTCUTS - NO TRANSLATE +.uno:FullScreen @@ -2314,7 +2320,13 @@ I10N SHORTCUTS - NO TRANSLATE -.uno:FullScreen +.uno:FullScreen + + + + +I10N SHORTCUTS - NO TRANSLATE +.uno:FullScreen @@ -3201,7 +3213,13 @@ I10N SHORTCUTS - NO TRANSLATE -.uno:FullScreen +.uno:FullScreen + + + + +I10N SHORTCUTS - NO TRANSLATE +.uno:FullScreen @@ -3695,7 +3713,13 @@ I10N SHORTCUTS - NO TRANSLATE -.uno:FullScreen +.uno:FullScreen + + + + +I10N SHORTCUTS - NO TRANSLATE +.uno:FullScreen @@ -4468,7 +4492,13 @@ I10N SHORTCUTS - NO TRANSLATE -.uno:FullScreen +.uno:FullScreen + + + + +I10N SHORTCUTS - NO TRANSLATE +.uno:FullScreen @@ -5229,7 +5259,13 @@ I10N SHORTCUTS - NO TRANSLATE -.uno:FullScreen +.uno:FullScreen + + + + +I10N SHORTCUTS - NO TRANSLATE +.uno:FullScreen @@ -6008,7 +6044,13 @@ I10N SHORTCUTS - NO TRANSLATE -.uno:FullScreen +.uno:FullScreen + + + + +I10N SHORTCUTS - NO TRANSLATE +.uno:FullScreen @@ -6793,7 +6835,13 @@ I10N SHORTCUTS - NO TRANSLATE -.uno:FullScreen +.uno:FullScreen + + + + +I10N SHORTCUTS - NO TRANSLATE +.uno:FullScreen ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 100093] Calc appends path for data linked cells automatically and incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=100093 Jim@HiTekchanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from Jim@HiTek --- Not sure what you need an example document of? I've attached the error message though. As shown in the attachment, the error is the number of times the path is appended to with additional "/home/jim/Documents/My Spreadsheets/Spreadsheets 16/". When I xferred the spreadsheets from my Win10 HDD, those links were working fine. I have found a work around. Turns out that Calc does not like the Directory structure. The dir tree was a copy of the old dir tree on my Win10 HDD as I copied and pasted onto the Ubuntu HDD. In order to solve the problem, I created a new directory: "Home/jim/Documents/Spreadsheets/" and placed copies of all my SS's there. Then I changed the pointers in the cells and it worked. Changing 'Path' in 'Tools' 'Options' never seemed to make any different with the error. In other words, Libre Calc does not like the path(s) I was using. This works: 'file:///home/jim/Documents/Spreadsheets/' Doesn't work: 'file:///home/jim/Documents/My Spreadsheets/Spreadsheets 16/' Now that I know what the problem is, I'll mess with paths until I find something that works for me. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100159] If OpenGL is used, but a shader fails to compile or link, nothing will show up
https://bugs.documentfoundation.org/show_bug.cgi?id=100159 --- Comment #3 from Commit Notification--- Tor Lillqvist committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=776c124e8797431c8c4eaf6d0550959b05ce69ee=libreoffice-5-2 tdf#100159: On Windows, compile GL shaders in advance, disable GL on failure It will be available in 5.2.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100159] If OpenGL is used, but a shader fails to compile or link, nothing will show up
https://bugs.documentfoundation.org/show_bug.cgi?id=100159 Commit Notificationchanged: What|Removed |Added Whiteboard|target:5.3.0|target:5.3.0 target:5.2.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - vcl/opengl
vcl/opengl/win/gdiimpl.cxx | 109 + 1 file changed, 109 insertions(+) New commits: commit 776c124e8797431c8c4eaf6d0550959b05ce69ee Author: Tor LillqvistDate: Mon May 30 14:20:11 2016 +0300 tdf#100159: On Windows, compile GL shaders in advance, disable GL on failure If the shader compilation or loading of an already compiled shader fails, disable OpenGL in the registry and exit with the EXITHELPER_NORMAL_RESTART status. The wrapper process will thus run soffice.bin once more, and this time OpenGL will not be used. Change-Id: I3cc4a615f00a8a1adb584493861e4956c83cec32 Reviewed-on: https://gerrit.libreoffice.org/25675 Reviewed-by: Tor Lillqvist Tested-by: Tor Lillqvist diff --git a/vcl/opengl/win/gdiimpl.cxx b/vcl/opengl/win/gdiimpl.cxx index cf45a46..8bc7943 100644 --- a/vcl/opengl/win/gdiimpl.cxx +++ b/vcl/opengl/win/gdiimpl.cxx @@ -8,6 +8,7 @@ */ #include "opengl/win/gdiimpl.hxx" +#include #include #include #include @@ -349,6 +350,107 @@ bool InitMultisample(const PIXELFORMATDESCRIPTOR& pfd, int& rPixelFormat, return bArbMultisampleSupported; } +namespace +{ + +bool tryShaders(const OUString& rVertexShader, const OUString& rFragmentShader, const OUString& rGeometryShader = "", const OString& rPreamble = "") +{ +GLint nId; + +// Somewhat mysteriously, the OpenGLHelper::LoadShaders() API saves a compiled binary of the +// shader only if you give it the digest of the shaders. We have API to calculate the digest +// only of the combination of vertex and fragment (but not geometry) shader. So if we have a +// geometry shader, we should not save the binary. +if (rGeometryShader.isEmpty()) +{ +nId = OpenGLHelper::LoadShaders(rVertexShader, rFragmentShader, rPreamble, OpenGLHelper::GetDigest( rVertexShader, rFragmentShader, rPreamble)); +} +else +{ +assert(rPreamble.isEmpty()); +nId = OpenGLHelper::LoadShaders(rVertexShader, rFragmentShader, rGeometryShader); +} +if (!nId) +return false; +glDeleteProgram(nId); +return glGetError() == GL_NO_ERROR; +} + +bool compiledShaderBinariesWork() +{ +static bool bBeenHere = false; +static bool bResult; + +if (bBeenHere) +return bResult; + +bBeenHere = true; + +bResult = +( +#if 0 // Only look at shaders used by vcl for now + // canvas + tryShaders("dummyVertexShader", "linearMultiColorGradientFragmentShader") && + tryShaders("dummyVertexShader", "linearTwoColorGradientFragmentShader") && + tryShaders("dummyVertexShader", "radialMultiColorGradientFragmentShader") && + tryShaders("dummyVertexShader", "radialTwoColorGradientFragmentShader") && + tryShaders("dummyVertexShader", "rectangularMultiColorGradientFragmentShader") && + tryShaders("dummyVertexShader", "rectangularTwoColorGradientFragmentShader") && + // chart2 + (GLEW_VERSION_3_3 ? + (tryShaders("shape3DVertexShader", "shape3DFragmentShader") && + tryShaders("shape3DVertexShaderBatchScroll", "shape3DFragmentShaderBatchScroll") && + tryShaders("shape3DVertexShaderBatch", "shape3DFragmentShaderBatch") && + tryShaders("textVertexShaderBatch", "textFragmentShaderBatch")) : + (tryShaders("shape3DVertexShaderV300", "shape3DFragmentShaderV300"))) && + tryShaders("textVertexShader", "textFragmentShader") && + tryShaders("screenTextVertexShader", "screenTextFragmentShader") && + tryShaders("commonVertexShader", "commonFragmentShader") && + tryShaders("pickingVertexShader", "pickingFragmentShader") && + tryShaders("backgroundVertexShader", "backgroundFragmentShader") && + tryShaders("symbolVertexShader", "symbolFragmentShader") && + tryShaders("symbolVertexShader", "symbolFragmentShader") && + // slideshow + tryShaders("reflectionVertexShader", "reflectionFragmentShader") && + tryShaders("basicVertexShader", "basicFragmentShader") && + tryShaders("vortexVertexShader", "vortexFragmentShader", "vortexGeometryShader") && + tryShaders("basicVertexShader", "rippleFragmentShader") && + tryShaders("glitterVertexShader", "glitterFragmentShader") && + tryShaders("honeycombVertexShader", "honeycombFragmentShader", "honeycombGeometryShader") && +#endif + // vcl + tryShaders("combinedVertexShader", "combinedFragmentShader") && + tryShaders("dumbVertexShader", "invert50FragmentShader") && + tryShaders("combinedTextureVertexShader", "combinedTextureFragmentShader") && + tryShaders("textureVertexShader", "areaScaleFragmentShader") && + tryShaders("transformedTextureVertexShader", "maskedTextureFragmentShader") && +
[Libreoffice-bugs] [Bug 93386] Crashes when closing a Database with macro editor open
https://bugs.documentfoundation.org/show_bug.cgi?id=93386 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93386] Crashes when closing a Database with macro editor open
https://bugs.documentfoundation.org/show_bug.cgi?id=93386 --- Comment #21 from Commit Notification--- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9a0fd9c7f424fb787e1fae2113f0a42f0895a1e9 Resolves: tdf#93386 crash when closing a Database with macro editor open It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basic/source
basic/source/basmgr/basicmanagerrepository.cxx | 54 + 1 file changed, 38 insertions(+), 16 deletions(-) New commits: commit 9a0fd9c7f424fb787e1fae2113f0a42f0895a1e9 Author: Caolán McNamaraDate: Tue May 31 17:05:59 2016 +0100 Resolves: tdf#93386 crash when closing a Database with macro editor open Change-Id: Id3ecee744cb10f539f2b57e83a4b6e4c7744d3d5 diff --git a/basic/source/basmgr/basicmanagerrepository.cxx b/basic/source/basmgr/basicmanagerrepository.cxx index 35c965b..02a4555 100644 --- a/basic/source/basmgr/basicmanagerrepository.cxx +++ b/basic/source/basmgr/basicmanagerrepository.cxx @@ -104,6 +104,17 @@ namespace basic BasicManager*& impl_getLocationForModel( const Reference< XModel >& _rxDocumentModel ); +/** tests if there is a location set at which the BasicManager for the given model +is stored. + +@param _rxDocumentModel +the model whose BasicManager's location is to be retrieved. Must not be . + +@precond +our mutex is locked +*/ +bool impl_hasLocationForModel( const Reference< XModel >& _rxDocumentModel ); + /** creates a new BasicManager instance for the given model @param _out_rpBasicManager @@ -113,7 +124,7 @@ namespace basic @param _rxDocumentModel the model whose BasicManager will be created. Must not be . */ -void impl_createManagerForModel( +bool impl_createManagerForModel( BasicManager*& _out_rpBasicManager, const Reference< XModel >& _rxDocumentModel ); @@ -207,7 +218,6 @@ namespace basic create( CreateImplRepository(), ::osl::GetGlobalMutex() ); } - BasicManager* ImplRepository::getDocumentBasicManager( const Reference< XModel >& _rxDocumentModel ) { SolarMutexGuard g; @@ -221,13 +231,13 @@ namespace basic without creating another instance. */ BasicManager*& pBasicManager = impl_getLocationForModel( _rxDocumentModel ); -if ( pBasicManager == nullptr ) -impl_createManagerForModel( pBasicManager, _rxDocumentModel ); - -return pBasicManager; +if (pBasicManager != nullptr) +return pBasicManager; +if (impl_createManagerForModel(pBasicManager, _rxDocumentModel)) +return pBasicManager; +return nullptr; } - BasicManager* ImplRepository::getApplicationBasicManager( bool _bCreate ) { SolarMutexGuard g; @@ -353,7 +363,6 @@ namespace basic return pAppBasic; } - BasicManager*& ImplRepository::impl_getLocationForModel( const Reference< XModel >& _rxDocumentModel ) { Reference< XInterface > xNormalized( _rxDocumentModel, UNO_QUERY ); @@ -363,6 +372,13 @@ namespace basic return location; } +bool ImplRepository::impl_hasLocationForModel( const Reference< XModel >& _rxDocumentModel ) +{ +Reference< XInterface > xNormalized( _rxDocumentModel, UNO_QUERY ); +DBG_ASSERT( _rxDocumentModel.is(), "ImplRepository::impl_getLocationForModel: invalid model!" ); + +return m_aStore.find(xNormalized) != m_aStore.end(); +} void ImplRepository::impl_initDocLibraryContainers_nothrow( const Reference< XPersistentLibraryContainer >& _rxBasicLibraries, const Reference< XPersistentLibraryContainer >& _rxDialogLibraries ) { @@ -389,8 +405,7 @@ namespace basic } } - -void ImplRepository::impl_createManagerForModel( BasicManager*& _out_rpBasicManager, const Reference< XModel >& _rxDocumentModel ) +bool ImplRepository::impl_createManagerForModel( BasicManager*& _out_rpBasicManager, const Reference< XModel >& _rxDocumentModel ) { StarBASIC* pAppBasic = impl_getDefaultAppBasicLibrary(); @@ -399,13 +414,13 @@ namespace basic if ( !impl_getDocumentStorage_nothrow( _rxDocumentModel, xStorage ) ) { // the document is not able to provide the storage it is based on. -return; +return false; } Reference< XPersistentLibraryContainer > xBasicLibs; Reference< XPersistentLibraryContainer > xDialogLibs; if ( !impl_getDocumentLibraryContainers_nothrow( _rxDocumentModel, xBasicLibs, xDialogLibs ) ) // the document does not have BasicLibraries and DialogLibraries -return; +return false; if ( xStorage.is() ) { @@ -466,20 +481,27 @@ namespace basic // register as listener for this model being disposed/closed OSL_ENSURE( _rxDocumentModel.is(), "ImplRepository::impl_createManagerForModel: the document must be an XComponent!" ); +assert(impl_hasLocationForModel(_rxDocumentModel)); startComponentListening( _rxDocumentModel ); -
[Libreoffice-bugs] [Bug 93883] FILESAVE: Bullet is added to empty line when saved as .PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=93883 --- Comment #10 from Commit Notification--- Mark Hung committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=005ae2fa195bddd1073f3d883cf041d9ac80fad1 tdf#93883 don't add space to empty paragraph when bullet is turned off. It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93883] FILESAVE: Bullet is added to empty line when saved as .PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=93883 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/source sd/qa
oox/source/export/drawingml.cxx |5 - sd/qa/unit/data/odp/tdf93883.odp |binary sd/qa/unit/export-tests.cxx | 12 3 files changed, 16 insertions(+), 1 deletion(-) New commits: commit 005ae2fa195bddd1073f3d883cf041d9ac80fad1 Author: Mark HungDate: Tue May 31 01:22:11 2016 +0800 tdf#93883 don't add space to empty paragraph when bullet is turned off. Change-Id: Ia1bad61cb5585dae0501e8cd657fc84bfea60ab2 Reviewed-on: https://gerrit.libreoffice.org/25679 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx index a3c40fb..c9566bf 100644 --- a/oox/source/export/drawingml.cxx +++ b/oox/source/export/drawingml.cxx @@ -1583,6 +1583,9 @@ void DrawingML::WriteRun( const Reference< XTextRange >& rRun ) sal_Int16 nLevel = -1; GET( nLevel, NumberingLevel ); +bool bNumberingIsNumber = true; +GET( bNumberingIsNumber, NumberingIsNumber ); + bool bIsURLField = false; OUString sFieldValue = GetFieldValue( rRun, bIsURLField ); bool bWriteField = !( sFieldValue.isEmpty() || bIsURLField ); @@ -1590,7 +1593,7 @@ void DrawingML::WriteRun( const Reference< XTextRange >& rRun ) OUString sText = rRun->getString(); //if there is no text following the bullet, add a space after the bullet -if (nLevel !=-1 && sText.isEmpty() ) +if (nLevel !=-1 && bNumberingIsNumber && sText.isEmpty() ) sText=" "; if ( bIsURLField ) diff --git a/sd/qa/unit/data/odp/tdf93883.odp b/sd/qa/unit/data/odp/tdf93883.odp new file mode 100755 index 000..54d589c Binary files /dev/null and b/sd/qa/unit/data/odp/tdf93883.odp differ diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx index bdaefa8..a80617c 100644 --- a/sd/qa/unit/export-tests.cxx +++ b/sd/qa/unit/export-tests.cxx @@ -130,6 +130,7 @@ public: void testTableCellBorder(); void testBulletColor(); void testTdf62176(); +void testTdf93883(); void testBulletCharAndFont(); void testBulletMarginAndIndentation(); void testParaMarginAndindentation(); @@ -185,6 +186,7 @@ public: CPPUNIT_TEST(testTableCellBorder); CPPUNIT_TEST(testBulletColor); CPPUNIT_TEST(testTdf62176); +CPPUNIT_TEST(testTdf93883); CPPUNIT_TEST(testBulletCharAndFont); CPPUNIT_TEST(testBulletMarginAndIndentation); CPPUNIT_TEST(testParaMarginAndindentation); @@ -1070,6 +1072,16 @@ void SdExportTest::testTdf62176() xDocShRef->DoClose(); } +void SdExportTest::testTdf93883() +{ +::sd::DrawDocShellRef xDocShRef = loadURL( m_directories.getURLFromSrc("/sd/qa/unit/data/odp/tdf93883.odp"), ODP); +xDocShRef = saveAndReload( xDocShRef, PPTX ); +uno::Reference< beans::XPropertySet > xShape( getShapeFromPage( 0, 0, xDocShRef ) ); +uno::Reference const xParagraph( getParagraphFromShape( 0, xShape ) ); +uno::Reference< beans::XPropertySet > xPropSet( xParagraph, uno::UNO_QUERY_THROW ); +CPPUNIT_ASSERT(!xPropSet->getPropertyValue("NumberingLevel").hasValue()); +} + void SdExportTest::testBulletCharAndFont() { ::sd::DrawDocShellRef xDocShRef = loadURL( m_directories.getURLFromSrc("/sd/qa/unit/data/odp/bulletCharAndFont.odp"), ODP); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 100093] Calc appends path for data linked cells automatically and incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=100093 --- Comment #3 from Buovjaga--- I mean the document, not a screenshot. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99643] class EOleSysError on com.sun.star.ServiceManager
https://bugs.documentfoundation.org/show_bug.cgi?id=99643 --- Comment #13 from Dorange-Pattoret Didier--- Hello, The following code : Sub TestServiceManager Set objServiceManager = CreateObject("com.sun.star.ServiceManager") Set objCoreReflection= objServiceManager.createInstance("com.sun.star.reflection.CoreReflection") Set objDesktop= objServiceManager.createInstance("com.sun.star.frame.Desktop") Dim args() Set objDocument= objDesktop.loadComponentFromURL("private:factory/swriter", "_blank", 0, args) End Sub runs with LO Win 5.1.1.3 64 bits but not with LO Win 5.1.3.2 64 bits. It seems the bug comes between this versions. All is ok with LO Win 32 bits. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs