[Libreoffice-bugs] [Bug 100598] New: FILEOPEN FILESAVE csv

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100598

Bug ID: 100598
   Summary: FILEOPEN FILESAVE csv
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: aa169d62...@gmail.com

Abstract:
LibreOffice saved a spreadsheet as a csv file without warning.  Only one sheet
(the least important) was saved.  All formulae were, as expected with csv
format, converted to textual representations of the (calculated) result.

This behavor semms different from what I remember.  I would have expected
warning messages (pop-ups).

Synopsis:
1) I typed (at the BASH command prompt) 
   soffice surv-table.csv
2) I made numerous style changes and formulae on multiple sheets over several
hours.
3) I tried to close the file (X in the right side of the title bar), Calc asked
me if I wanted to save my changes, etc.
4) OF COURSE, I said I wanted to save my changes.
5) When I tried to open surv-table.ods, I found it did not exist.
6) Further investigation found that the first sheet (the one with the fewest
formulae) had been saved in surv-table.csv

Details:
OS: Linux Mint 17 Qiana
LO Version:  4.2.8.2
Did not try with any other operating system or version.

1) I found some data on the web.  I copied and pasted it to an editor, modified
it, and save it with a csv extension.  Note: Normally I would not save it with
that extension, but LibreOffice will otherwise try to use Writer. An annoyance
that I can live with.  (Normally I would use no extension.)
2) I opened the file with ``soffice surv-table.csv''.  (I usually use the
command line as it is more efficient. If I open calc and then use insert, LO
will use some bizarre directory and not the current directory.)
3) I made many edits, using styles, but more importantly complicated formulae.
   Multiple sheets were used.  Other programs were used to make sure the
formulae were correct.
4) I actually thought I had saved my work, but when I clicked X in the title
bar, I was asked if I wanted to save my changes, ...
5) OF COURSE, I wanted to save my work!
6) I said YES, but LO Calc saved only the first sheet.  

I am sure that at some point in the past I tried to save a Calc file that I
thought was a spreadsheet and I was warned with something to the effect that
``Some features of LO Calc will be lost if saved in this format.'' Further, I
am pretty sure that whenever trying to save a spreadsheet with multiple sheets
in csv format, there is a warning pop-up to the effect that only the current
sheet will be saved.  What is going on?

Please do not save spreadsheets as csv files without warning.  (A spreadsheet
has styles, formatting, and/or formulae.)

Suggestion: If one types ``soffice foo.csv'', IMMEDIATELY change the internal,
not the file system name, to ``foo.ods''.  After all, it appears as if one is
modifying an ods file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99759] Viewing : LibreOffice crashes on attempt to view the second page of a document containing maths formulas.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99759

Aron Budea  changed:

   What|Removed |Added

 Whiteboard|backportRequest:5.1 |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99773] EDITING: calc freezes if sorting in natural mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99773

Aron Budea  changed:

   What|Removed |Added

 Whiteboard|backportRequest:5.1 |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96912] Newline in Cell (ctrl+enter) ignored by Excel if formatted content of the next line pasted in Libre Office

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96912

Aron Budea  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0|target:5.2.0 target:5.1.4
   |backportRequest:5.1 |
   |target:5.1.4|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100597] LanguageTool: Could not create Java implementation loader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100597

--- Comment #1 from Leandro Martín Drudi  ---
Created attachment 125892
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125892=edit
It can't be activated and don't work

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100597] New: LanguageTool: Could not create Java implementation loader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100597

Bug ID: 100597
   Summary: LanguageTool: Could not create Java implementation
loader
   Product: LibreOffice
   Version: 5.1.4.1 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Extensions
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sanipache...@outlook.com.ar

Created attachment 125891
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125891=edit
Ins installed, inactive and with error.

>From LanguageTool 3.0 in instalation show "Could not create Java implementation
loader". In LO 4.x install 2.9 and update into 3.0 without problems. But in new
versions of LO don't work.
I installed in Windows 10 x64, with the latest JAVA x32 and x64, LO x64 and
don't work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100596] New: Would like to be able to create and edit block arcs numerically.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100596

Bug ID: 100596
   Summary: Would like to be able to create and edit block arcs
numerically.
   Product: LibreOffice
   Version: 5.0.6.2 rc
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mattison.compu...@yahoo.com

I find that creating and modifying a block arc is quite difficult.  I actually
could not with reasonable effort get what I wanted.  I had to settle for small
triangles over big triangles, and I had to make circles and diameters, and work
off intersections to get something close to what I really wanted.  Even for
that, I had to review geometry and trigonometry lessons and use a hand
calculator.  The results has overlaps, gaps, and other imperfect matches.

My request is to provide GUIs for creating and editing block arcs.  User inputs
would be:
* the coordinates of the center of the block arc;
* the inner radius of the block arc;
* the outer radius of the block arc;
* the orientation (an angle) of one edge of the block arc; and
* the angle through which the block arc extends.
A resolution of 600 dots per inch is common in today's printers; the best have
even finer resolution.  So the GUI inputs should retain at least 4 decimal
places.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bin/upload_symbols.py

[Markus Mohrhard]

 bin/upload_symbols.py |1 +
 1 file changed, 1 insertion(+)

New commits:
commit c4f3c63931721d6b8a6994e4d71e88a6c9fe57c5
Author: Markus Mohrhard 
Date:   Sat Jun 25 02:10:51 2016 +0200

add some info how to use the symbol upload script

Change-Id: Ic1d1b5791b6012efcda0b007b9e75b6be0ef
Reviewed-on: https://gerrit.libreoffice.org/26650
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 
Tested-by: Jenkins 

diff --git a/bin/upload_symbols.py b/bin/upload_symbols.py
index d382f70..f708797 100755
--- a/bin/upload_symbols.py
+++ b/bin/upload_symbols.py
@@ -16,6 +16,7 @@ def main():
 if len(sys.argv) != 4:
 print(sys.argv)
 print("Invalid number of parameters")
+print("Usage: upload-symbols.py symbols.zip config.ini \"long 
explanation\"")
 sys.exit(1)
 
 upload_url = "http://crashreport.libreoffice.org/upload/;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/breakpad

[Markus Mohrhard]

 external/breakpad/UnpackedTarball_breakpad.mk |1 +
 external/breakpad/breakpad-stackwalk.patch.1  |   16 
 2 files changed, 17 insertions(+)

New commits:
commit c717158a82bed756c4d20f6304a29600affa0f66
Author: Markus Mohrhard 
Date:   Sat Jun 25 02:03:47 2016 +0200

add code_id to the minidump_stackwalk

Change-Id: Ibcc32344780b7ad5814678cf7dd9a2167ede1661
Reviewed-on: https://gerrit.libreoffice.org/26649
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/external/breakpad/UnpackedTarball_breakpad.mk 
b/external/breakpad/UnpackedTarball_breakpad.mk
index 59073eb..445047b 100644
--- a/external/breakpad/UnpackedTarball_breakpad.mk
+++ b/external/breakpad/UnpackedTarball_breakpad.mk
@@ -15,6 +15,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,breakpad,\
external/breakpad/breakpad-use-correct-http-header.patch.1 \
external/breakpad/breakpad-wshadow.patch.1 \
external/breakpad/breakpad-wshadow2.patch.1 \
+   external/breakpad/breakpad-stackwalk.patch.1 \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/breakpad/breakpad-stackwalk.patch.1 
b/external/breakpad/breakpad-stackwalk.patch.1
new file mode 100644
index 000..26803f1
--- /dev/null
+++ b/external/breakpad/breakpad-stackwalk.patch.1
@@ -0,0 +1,16 @@
+diff -ur breakpad.org/src/processor/stackwalk_common.cc 
breakpad/src/processor/stackwalk_common.cc
+--- breakpad.org/src/processor/stackwalk_common.cc 2016-06-25 
01:38:53.282302964 +0200
 breakpad/src/processor/stackwalk_common.cc 2016-06-25 01:42:58.463821357 
+0200
+@@ -767,9 +767,11 @@
+++module_sequence) {
+ const CodeModule *module = modules->GetModuleAtSequence(module_sequence);
+ uint64_t base_address = module->base_address();
+-printf("Module%c%s%c%s%c%s%c%s%c0x%08" PRIx64 "%c0x%08" PRIx64 "%c%d\n",
++printf("Module%c%s%c%s%c%s%c%s%c%s%c0x%08" PRIx64 "%c0x%08" PRIx64 
"%c%d\n",
+kOutputSeparator,
+
StripSeparator(PathnameStripper::File(module->code_file())).c_str(),
++   kOutputSeparator,
++   
StripSeparator(PathnameStripper::File(module->code_identifier())).c_str(),
+kOutputSeparator, StripSeparator(module->version()).c_str(),
+kOutputSeparator,
+
StripSeparator(PathnameStripper::File(module->debug_file())).c_str(),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 32581] [EDITING] Add the possibility to retrieve the filename of a movie or sound inserted in a document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32581

--- Comment #21 from kush singh  ---
@jan hi , i have build libreoffice and created a new branch as directed in the
tutorial , but i am having trouble understanding the code even after two three
days . any suggestions how i should tinker with the code to understand it
better as documentation(readme) is not enough for a beginner like me . pls help

-thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100538] Find & Replace makes replacement when it shouldn't, and Close button stops working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100538

JoNi  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #7 from JoNi  ---
I can confirm the described behaviour on recent linux master
(d56dc64795dcd913d5fa663275bf34b75a0c82e6)

close button not working until you click inside the document and try to close
again.
But it's not a real freeze as in busy and unresponsive, it just won't close the
dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100318] Different FreeType antialiasing style in LO 5.2 Beta, on Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100318

--- Comment #14 from Aron Budea  ---
Thank you for the update. Knowing that it was introduced in the 5.1 branch
between 5.1.3 and 5.1.4 could be valuable information.
The issue is still very mysterious, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93045] FILESAVE: custom styles lost on saving to XLSX ( Summary in Comment 6)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93045

--- Comment #19 from Bartosz Kosiorek  ---
I would like to fix that issue.
Could you please create .xlsx file with custom formatting via MS Excel and then
open it with LibreOffice?
After that save it into .xlsx format again, reopen and check if this issue is
still there.


I would like to compare two .xlsx files (correct one and incorrect). 
It will dramatically help in resolving that issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93045] FILESAVE: custom styles lost on saving to XLSX ( Summary in Comment 6)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93045

--- Comment #17 from Bartosz Kosiorek  ---
I would like to fix that issue.
Could you please create .xlsx file with custom formatting via MS Excel and then
open it with LibreOffice?
After that save it into .xlsx format again, reopen and check if this issue is
still there.


I would like to compare two .xlsx files (correct one and incorrect). 
It will dramatically help in resolving that issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93045] FILESAVE: custom styles lost on saving to XLSX ( Summary in Comment 6)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93045

--- Comment #17 from Bartosz Kosiorek  ---
I would like to fix that issue.
Could you please create .xlsx file with custom formatting via MS Excel and then
open it with LibreOffice?
After that save it into .xlsx format again, reopen and check if this issue is
still there.


I would like to compare two .xlsx files (correct one and incorrect). 
It will dramatically help in resolving that issue.

--- Comment #18 from Bartosz Kosiorek  ---
I would like to fix that issue.
Could you please create .xlsx file with custom formatting via MS Excel and then
open it with LibreOffice?
After that save it into .xlsx format again, reopen and check if this issue is
still there.


I would like to compare two .xlsx files (correct one and incorrect). 
It will dramatically help in resolving that issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 71176] Key combinations to easily insert accented Latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71176

Óvári  changed:

   What|Removed |Added

 CC||axel.gr...@gmail.com

--- Comment #18 from Óvári  ---
(In reply to V Stuart Foote from comment #17)
> Thank you for the kind offer! Could you adjust the license to MPLv2/LGPLv3+,
> or better complete a contributor statement as at
> https://wiki.documentfoundation.org/Development/Developers
Added Axel Grude to CC as comment #17 from V Stuart Foote asked Axel Grude for
a license adjustment or a contributor statement.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 71176] Key combinations to easily insert accented Latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71176

Óvári  changed:

   What|Removed |Added

 CC||axel.gr...@gmail.com

--- Comment #18 from Óvári  ---
(In reply to V Stuart Foote from comment #17)
> Thank you for the kind offer! Could you adjust the license to MPLv2/LGPLv3+,
> or better complete a contributor statement as at
> https://wiki.documentfoundation.org/Development/Developers
Added Axel Grude to CC as comment #17 from V Stuart Foote asked Axel Grude for
a license adjustment or a contributor statement.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl vcl/headless vcl/inc vcl/osx vcl/source vcl/unx vcl/win

[Xisco Fauli]

 include/vcl/jobdata.hxx |2 
 include/vcl/jobset.hxx  |   31 +--
 vcl/headless/svpprn.cxx |   68 
 vcl/inc/jobset.h|   55 ++
 vcl/inc/salinst.hxx |2 
 vcl/inc/salprn.hxx  |2 
 vcl/inc/unx/geninst.h   |4 
 vcl/osx/salinst.cxx |2 
 vcl/osx/salprn.cxx  |   38 ++--
 vcl/source/gdi/jobset.cxx   |  293 ++--
 vcl/source/gdi/print.cxx|  189 ---
 vcl/source/gdi/print3.cxx   |4 
 vcl/source/window/printdlg.cxx  |2 
 vcl/unx/generic/print/genprnpsp.cxx |  150 +-
 vcl/unx/generic/printer/jobdata.cxx |4 
 vcl/win/gdi/salprn.cxx  |  194 +++
 16 files changed, 552 insertions(+), 488 deletions(-)

New commits:
commit 0325b22a2a2b537a71f53b7c5d3e6c13fef68911
Author: Xisco Fauli 
Date:   Mon May 2 19:07:23 2016 +0200

tdf#62525 vcl: use cow_wrapper for jobset

Besides:
* Convert ImplJobSetup to be a class.
* Use ImplJobSetup's setters and getters everywhere
* add some const-correctness at places

Change-Id: I32101048e9be4f3950a4540b0666ed548bbcb211
Reviewed-on: https://gerrit.libreoffice.org/24594
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/include/vcl/jobdata.hxx b/include/vcl/jobdata.hxx
index 00a743f..3113518 100644
--- a/include/vcl/jobdata.hxx
+++ b/include/vcl/jobdata.hxx
@@ -74,7 +74,7 @@ struct VCL_DLLPUBLIC JobData
 // creates a new buffer using new
 // it is up to the user to delete it again
 bool getStreamBuffer( void*& pData, sal_uInt32& bytes );
-static bool constructFromStreamBuffer( void* pData, sal_uInt32 bytes, 
JobData& rJobData );
+static bool constructFromStreamBuffer( const void* pData, sal_uInt32 
bytes, JobData& rJobData );
 };
 
 } // namespace
diff --git a/include/vcl/jobset.hxx b/include/vcl/jobset.hxx
index 3c2c837..7cc7a3d 100644
--- a/include/vcl/jobset.hxx
+++ b/include/vcl/jobset.hxx
@@ -22,29 +22,19 @@
 
 #include 
 #include 
+#include 
 
 class SvStream;
-struct ImplJobSetup;
+class ImplJobSetup;
 
 class VCL_DLLPUBLIC JobSetup
 {
 friend class Printer;
 
-private:
-ImplJobSetup*   mpData;
-
-public:
-SAL_DLLPRIVATE ImplJobSetup*ImplGetData();
-SAL_DLLPRIVATE ImplJobSetup*ImplGetConstData();
-SAL_DLLPRIVATE const ImplJobSetup*  ImplGetConstData() const;
-
 public:
-JobSetup();
-JobSetup( const JobSetup& rJob );
-~JobSetup();
-
-OUString  GetPrinterName() const;
-OUString  GetDriverName() const;
+JobSetup();
+JobSetup( const JobSetup& rJob );
+~JobSetup();
 
 JobSetup&   operator=( const JobSetup& rJob );
 
@@ -52,8 +42,19 @@ public:
 booloperator!=( const JobSetup& rJobSetup ) const
 { return !(JobSetup::operator==( rJobSetup )); }
 
+SAL_DLLPRIVATE ImplJobSetup&ImplGetData();
+SAL_DLLPRIVATE const ImplJobSetup&  ImplGetConstData() const;
+
+OUString  GetPrinterName() const;
+bool  IsDefault() const;
+
 friend VCL_DLLPUBLIC SvStream&  ReadJobSetup( SvStream& rIStream, 
JobSetup& rJobSetup );
 friend VCL_DLLPUBLIC SvStream&  WriteJobSetup( SvStream& rOStream, const 
JobSetup& rJobSetup );
+
+typedef o3tl::cow_wrapper< ImplJobSetup > ImplType;
+
+private:
+ImplTypempData;
 };
 
 #endif // INCLUDED_VCL_JOBSET_HXX
diff --git a/vcl/headless/svpprn.cxx b/vcl/headless/svpprn.cxx
index a966452..c5c8ea5 100644
--- a/vcl/headless/svpprn.cxx
+++ b/vcl/headless/svpprn.cxx
@@ -60,17 +60,17 @@ inline int PtTo10Mu( int nPoints ) { return 
(int)double)nPoints)*35.2778
 
 static void copyJobDataToJobSetup( ImplJobSetup* pJobSetup, JobData& rData )
 {
-pJobSetup->meOrientation= (Orientation)(rData.m_eOrientation == 
orientation::Landscape ? ORIENTATION_LANDSCAPE : ORIENTATION_PORTRAIT);
+pJobSetup->SetOrientation( (Orientation)(rData.m_eOrientation == 
orientation::Landscape ? ORIENTATION_LANDSCAPE : ORIENTATION_PORTRAIT) );
 
 // copy page size
 OUString aPaper;
 int width, height;
 
 rData.m_aContext.getPageSize( aPaper, width, height );
-pJobSetup->mePaperFormat= PaperInfo::fromPSName(OUStringToOString( 
aPaper, RTL_TEXTENCODING_ISO_8859_1 ));
-pJobSetup->mnPaperWidth = 0;
-pJobSetup->mnPaperHeight= 0;
-if( pJobSetup->mePaperFormat == PAPER_USER )
+pJobSetup->SetPaperFormat( PaperInfo::fromPSName(OUStringToOString( 
aPaper, RTL_TEXTENCODING_ISO_8859_1 )) );
+pJobSetup->SetPaperWidth( 0 );
+pJobSetup->SetPaperHeight( 0 );
+if( pJobSetup->GetPaperFormat() == PAPER_USER )
 {
 

[Libreoffice-bugs] [Bug 100572] Formula editor (Math) crash when I export from odf to PDF or directly to pdf from interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100572

MM  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #6 from MM  ---
Unconfirmed with v5.1.4.2 (64bit) under windows 10 x64.
Confirmed with v5.1.4.2 (32 bit) under windows 7 x64.

GL is off, crashes even with new profile.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100476] Tooltips too small tou house captions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100476

Gert Van Waelvelde  changed:

   What|Removed |Added

  Component|Writer  |UI

--- Comment #13 from Gert Van Waelvelde  ---
I have changed the component to UI, because this bug appears in other
LibreOffice programs as well, so it a general UI issue, not an application
specific one.

Also, this might be a duplicate of bug 91533.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - include/svx svx/inc svx/Library_svx.mk svx/source uitest/test_main.py

[Markus Mohrhard]

 include/svx/charmap.hxx|2 +
 svx/Library_svx.mk |1 
 svx/inc/uiobject.hxx   |   34 
 svx/source/dialog/charmap.cxx  |7 
 svx/source/uitest/uiobject.cxx |   68 +
 uitest/test_main.py|   34 
 6 files changed, 132 insertions(+), 14 deletions(-)

New commits:
commit 46773b0b59bb9061c5f5660e65e4ebc0d455fe02
Author: Markus Mohrhard 
Date:   Sat Jun 25 00:17:33 2016 +0200

uitest: add a mode to just run one file

Change-Id: I99906dfc34ebcb7ab0ce76ca446435ae0902443f

diff --git a/uitest/test_main.py b/uitest/test_main.py
index 41a1b16..4939d05 100644
--- a/uitest/test_main.py
+++ b/uitest/test_main.py
@@ -19,7 +19,7 @@ from connection import PersistentConnection, OfficeConnection
 
 def parseArgs(argv):
 (optlist,args) = getopt.getopt(argv[1:], "hr",
-["help", "soffice=", "userdir=", "dir="])
+["help", "soffice=", "userdir=", "dir=", "file="])
 return (dict(optlist), args)
 
 def usage():
@@ -63,22 +63,24 @@ def get_test_case_classes_of_module(module):
 classes = get_classes_of_module(module)
 return [ c for c in classes if issubclass(c, UITestCase) ]
 
-def get_test_suite(opts):
+def add_tests_for_file(test_file, test_suite):
 test_loader = unittest.TestLoader()
+module_name = os.path.splitext(os.path.split(test_file)[1])[0]
+loader = importlib.machinery.SourceFileLoader(module_name, test_file)
+mod = loader.load_module()
+classes = get_test_case_classes_of_module(mod)
+for c in classes:
+test_names = test_loader.getTestCaseNames(c)
+for test_name in test_names:
+obj = c(test_name, opts)
+test_suite.addTest(obj)
+
+def get_test_suite_for_dir(opts):
 test_suite = unittest.TestSuite()
 
 valid_test_files = find_test_files(opts['--dir'])
 for test_file in valid_test_files:
-module_name = os.path.splitext(os.path.split(test_file)[1])[0]
-loader = importlib.machinery.SourceFileLoader(module_name, test_file)
-mod = loader.load_module()
-classes = get_test_case_classes_of_module(mod)
-for c in classes:
-test_names = test_loader.getTestCaseNames(c)
-for test_name in test_names:
-obj = c(test_name, opts)
-test_suite.addTest(obj)
-
+add_tests_for_file(test_file, test_suite)
 return test_suite
 
 
@@ -90,10 +92,14 @@ if __name__ == '__main__':
 elif not "--soffice" in opts:
 usage()
 sys.exit(1)
-elif not "--dir" in opts:
+elif "--dir" in opts:
+test_suite = get_test_suite_for_dir(opts)
+elif "--file" in opts:
+test_suite = unittest.TestSuite()
+add_tests_for_file(opts['--file'], test_suite)
+else:
 usage()
 sys.exit()
-test_suite = get_test_suite(opts)
 
 result = unittest.TextTestRunner(verbosity=2).run(test_suite)
 print("Tests run: %d" % result.testsRun)
commit 6db92434c664116eb1ec6cb127f2cd957a03bb65
Author: Markus Mohrhard 
Date:   Sat Jun 25 00:16:45 2016 +0200

uitest: add wrapper for special character window

Change-Id: I22acd9da3570e967f427207e242638f2bfd6ffb7

diff --git a/include/svx/charmap.hxx b/include/svx/charmap.hxx
index 5de50c7..fbdf77c 100644
--- a/include/svx/charmap.hxx
+++ b/include/svx/charmap.hxx
@@ -74,6 +74,8 @@ public:
 
 virtual voidResize() override;
 
+virtual FactoryFunction GetUITestFactory() const override;
+
 protected:
 virtual voidPaint( vcl::RenderContext& rRenderContext, const 
Rectangle& ) override;
 virtual voidMouseButtonDown( const MouseEvent& rMEvt ) override;
diff --git a/svx/Library_svx.mk b/svx/Library_svx.mk
index c026002..047eb9d 100644
--- a/svx/Library_svx.mk
+++ b/svx/Library_svx.mk
@@ -241,6 +241,7 @@ $(eval $(call gb_Library_add_exception_objects,svx,\
 svx/source/tbxctrls/tbxcolor \
 svx/source/tbxctrls/tbxdrctl \
 svx/source/tbxctrls/verttexttbxctrl \
+svx/source/uitest/uiobject \
 svx/source/unodraw/recoveryui \
 svx/source/unodraw/unoctabl \
 svx/source/unodraw/UnoNamespaceMap \
diff --git a/svx/inc/uiobject.hxx b/svx/inc/uiobject.hxx
new file mode 100644
index 000..2e90385
--- /dev/null
+++ b/svx/inc/uiobject.hxx
@@ -0,0 +1,34 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+
+class SvxShowCharSet;
+
+class SvxShowCharSetUIObject : WindowUIObject
+{
+VclPtr mxCharSet;
+
+public:
+
+SvxShowCharSetUIObject(VclPtr xCharSet);
+
+virtual StringMap get_state() 

[Libreoffice-bugs] [Bug 100592] Add fraction number formats for forced denominator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100592

Laurent BP  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |jumbo4...@yahoo.fr
   |desktop.org |
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

About the Progress Bar on the Document Recovery Dialog

[Muhammet Kara]

Hello Devs,

I am simplifying the Document Recovery Dialog.[0][1]

I made LO crash with many documents, and observed its behavior during 
recovery. And there was nothing in the blank space where the progress 
bar should appear. Thus, as the "Recovery document:" label along with 
the 'progress bar' under that seems broken/useless, I would like to kill 
them too. (Besides, the recovery progress is already being indicated in 
the list box below.)


What do you think? Any objections?

Thanks,
Muhammet

[0] https://bugs.documentfoundation.org/show_bug.cgi?id=99341
[1] https://gerrit.libreoffice.org/#/c/26607/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Collabora Online 1.0 Roadmap and Questions

[MENGUAL Jean-Philippe]

Hi,



Le 22/06/2016 à 17:38, Adam Saunders a écrit :
> Hi all,
> 
> I'm in the midst of writing a news article about the Collabora Online
> 1.0 release. I had a couple questions for you:
> 
> 1. (a) It appears that the 1.0 release is missing a number of features
> that could be found in vanilla LibreOffice binaries (e.g. a number of
> functions for spreadsheets, "track changes" style editing in the
> document editor, spellchecking, etc.). How come?

I think it's useful to say, also, that this product is not accessible.
It means that in an organization which chooses it, any disable worker
won't be able to use it. See bug reports about it:
https://bugs.documentfoundation.org/show_bug.cgi?id=100530
https://bugs.documentfoundation.org/show_bug.cgi?id=99785

It makes me worry for future. While LO would be used instead of Office
365, it would be a big problem. As well as today LibreOffice instead of
Office, now we reach to get something, it's broken again with online
release.

> (b) Is the only spreadsheet function available in 1.0 SUM? I wasn't able
> to find any other shortcuts for functions in the spreadsheet editor.
> 
> (c) Is the real-time editing preview in CODE available in the 1.0 demo?
> I wasn't able to find it...
> 
> 2. Are there plans to reintroduce these features in future releases?
> 
> 3. What distinguishes Collabora Online from competitors such as Open365
> (https://open365.io/) or OnlyOffice (http://onlyoffice.org/)?
> 
> 4. What is the target "market" for Collabora Online? Primarily business
> enterprises/non-profits/government agencies?
> 
> 5. What "value-added" services could I get as, say, a corporation
> contracting with Collabora to get enhancements and/or support for
> Collabora Online?
> 
> Thanks very much for any answers you can provide. It's an interesting
> project!
> 
> Thanks,
> Adam Saunders
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
> 

-- 

Jean-Philippe MENGUAL

HYPRA, progressons ensemble

Tél.: 01 84 73 06 61
Mail: cont...@hypra.fr

Site Web: http://hypra.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: external/libzmf

[Michael Stahl]

 external/libzmf/0001-add-missing-include.patch.1 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c931f3a5184928bc333796362a5616a93c6ed6d7
Author: Michael Stahl 
Date:   Fri Jun 24 22:33:28 2016 +0200

libzmf: __ANDROID__, not ANDROID

The former is defined by GCC, the latter by gbuild -D$(OS)

Change-Id: I5960f8f74defcab964729c4deca5b1a988125d24

diff --git a/external/libzmf/0001-add-missing-include.patch.1 
b/external/libzmf/0001-add-missing-include.patch.1
index c5ddfe9..ff1dc2a 100644
--- a/external/libzmf/0001-add-missing-include.patch.1
+++ b/external/libzmf/0001-add-missing-include.patch.1
@@ -18,7 +18,7 @@ index ded93c7..7e024b3 100644
  
 +#include 
 +
-+#if defined(ANDROID)
++#if defined(__ANDROID__)
 +namespace std
 +{
 +template
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 64333] [Template Manager] [UI]: Overwriting an existing template with a new one, demands that the name is typed; should be picked up by selecting the existing template

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=64333

bejectannt  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #13 from bejectannt  ---
(In reply to Samuel Mehrbrodt (CIB) from comment #12)
> The changes are in 5.2 and 5.3. The release notes section is still missing.
> Can you please test with these versions?

Thanks for the version info! It is good to know in which version one can expect
to see the "fixed" behaviour.

No, sorry, I cannot test that easily with those versions (not available in
official repos of archlinux and .deb or .rpm is of no help and building self is
much effort).

Thank you for your work!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/unx

[Caolán McNamara]

 vcl/inc/unx/gtk/gtkframe.hxx  |1 -
 vcl/unx/gtk3/gtk3gtkframe.cxx |   12 +---
 2 files changed, 1 insertion(+), 12 deletions(-)

New commits:
commit 053a843bccaef2d2323be3ddff6217c592a4c5db
Author: Caolán McNamara 
Date:   Fri Jun 24 20:59:08 2016 +0100

Resolves: rhbz#1349501 gtk3: smooth scrolling events can be disabled...

better fix, if we listen to the eventbox we get either SMOOTH scrolling
or not smooth events, not both. We get SMOOTH when supported, and not
if not supported so no need to reintroduce the miserable hack, which
doesn't work under wayland anyway

Change-Id: I993e71d3553322425a506cd93d812efe081bf3c9

diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index e455f9e..ff5c454 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -213,7 +213,6 @@ class GtkSalFrame : public SalFrame
 #if GTK_CHECK_VERSION(3,0,0)
 OUStringm_aTooltip;
 Rectangle   m_aHelpArea;
-guint32 m_nLastScrollEventTime;
 longm_nWidthRequest;
 longm_nHeightRequest;
 cairo_region_t* m_pRegion;
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index aef66c0..7e3600b 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -1013,6 +1013,7 @@ void GtkSalFrame::InitCommon()
 m_aMouseSignalIds.push_back(g_signal_connect( G_OBJECT(pEventWidget), 
"drag-failed", G_CALLBACK(signalDragFailed), this ));
 m_aMouseSignalIds.push_back(g_signal_connect( G_OBJECT(pEventWidget), 
"drag-data-delete", G_CALLBACK(signalDragDelete), this ));
 m_aMouseSignalIds.push_back(g_signal_connect( G_OBJECT(pEventWidget), 
"drag-data-get", G_CALLBACK(signalDragDataGet), this ));
+m_aMouseSignalIds.push_back(g_signal_connect( G_OBJECT(pEventWidget), 
"scroll-event", G_CALLBACK(signalScroll), this ));
 
 g_signal_connect( G_OBJECT(m_pFixedContainer), "draw", 
G_CALLBACK(signalDraw), this );
 g_signal_connect( G_OBJECT(m_pFixedContainer), "size-allocate", 
G_CALLBACK(sizeAllocated), this );
@@ -1038,7 +1039,6 @@ void GtkSalFrame::InitCommon()
 g_signal_connect( G_OBJECT(m_pWindow), "key-release-event", 
G_CALLBACK(signalKey), this );
 g_signal_connect( G_OBJECT(m_pWindow), "delete-event", 
G_CALLBACK(signalDelete), this );
 g_signal_connect( G_OBJECT(m_pWindow), "window-state-event", 
G_CALLBACK(signalWindowState), this );
-g_signal_connect( G_OBJECT(m_pWindow), "scroll-event", 
G_CALLBACK(signalScroll), this );
 g_signal_connect( G_OBJECT(m_pWindow), "leave-notify-event", 
G_CALLBACK(signalCrossing), this );
 g_signal_connect( G_OBJECT(m_pWindow), "enter-notify-event", 
G_CALLBACK(signalCrossing), this );
 g_signal_connect( G_OBJECT(m_pWindow), "visibility-notify-event", 
G_CALLBACK(signalVisibility), this );
@@ -1051,7 +1051,6 @@ void GtkSalFrame::InitCommon()
 m_bSpanMonitorsWhenFullscreen = false;
 m_nState= GDK_WINDOW_STATE_WITHDRAWN;
 m_nVisibility   = GDK_VISIBILITY_FULLY_OBSCURED;
-m_nLastScrollEventTime = GDK_CURRENT_TIME;
 m_bSendModChangeOnRelease = false;
 m_pIMHandler= nullptr;
 m_hBackgroundPixmap = None;
@@ -2658,13 +2657,6 @@ gboolean GtkSalFrame::signalScroll( GtkWidget*, 
GdkEventScroll* pEvent, gpointer
 
 GtkSalFrame* pThis = static_cast(frame);
 
-// gnome#726878 check for duplicate legacy scroll event
-if (pEvent->direction != GDK_SCROLL_SMOOTH &&
-pThis->m_nLastScrollEventTime == pEvent->time)
-{
-return false;
-}
-
 SalWheelMouseEvent aEvent;
 
 aEvent.mnTime = pEvent->time;
@@ -2678,8 +2670,6 @@ gboolean GtkSalFrame::signalScroll( GtkWidget*, 
GdkEventScroll* pEvent, gpointer
 switch (pEvent->direction)
 {
 case GDK_SCROLL_SMOOTH:
-pThis->m_nLastScrollEventTime = pEvent->time;
-
 // rhbz#1344042 "Traditionally" in gtk3 we tool a single up/down 
event as
 // equating to 3 scroll lines and a delta of 120. So scale the 
delta here
 // by 120 where a single mouse wheel click is an incoming delta_x 
of 1
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100019] Upstreaming to English Dictionaries extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100019

--- Comment #7 from Marco A.G.Pinto  ---
Hello!

I have just uploaded/updated the OXT to V2016-07-01:
http://extensions.libreoffice.org/extension-center/english-dictionaries/

Please noticed that I will go to the North of Portugal on Tuesday on vacation
and will have limited Internet access during one week.


Here are the changes in the OXT:
MAGP 2016-07-01

Updated the hyphenation patterns to 2011-10-07 (from LibreOffice):
- US + GB

Updated the Dictionaries:
- British (Marco A.G.Pinto)*
  * British has 1107 new words (2016-06-01) + 738 new words (2016-07-01).
It now uses NOSUGGEST keyword for offensive words.
It now uses COMPOUNDING (Áron Budea)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100458] Data loss on loading Calc document with hidden 0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100458

Jan-Marek Glogowski  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: external/libzmf

[Michael Stahl]

 external/libzmf/0001-add-missing-include.patch.1 |   13 -
 1 file changed, 12 insertions(+), 1 deletion(-)

New commits:
commit b72c14f68b317b27be12a2432cdeae351537d57a
Author: Michael Stahl 
Date:   Fri Jun 24 21:07:33 2016 +0200

libzmf: blind fix hack attempt to work around buggy android headers

Change-Id: Ie7b265e909389ae80d8ced3d803d7e355cda2211

diff --git a/external/libzmf/0001-add-missing-include.patch.1 
b/external/libzmf/0001-add-missing-include.patch.1
index db2a5c3..c5ddfe9 100644
--- a/external/libzmf/0001-add-missing-include.patch.1
+++ b/external/libzmf/0001-add-missing-include.patch.1
@@ -12,12 +12,23 @@ diff --git a/src/lib/ZMFCollector.cpp 
b/src/lib/ZMFCollector.cpp
 index ded93c7..7e024b3 100644
 --- a/src/lib/ZMFCollector.cpp
 +++ b/src/lib/ZMFCollector.cpp
-@@ -9,6 +9,8 @@
+@@ -9,6 +9,19 @@
  
  #include "ZMFCollector.h"
  
 +#include 
 +
++#if defined(ANDROID)
++namespace std
++{
++template
++T hypot(T x, T y)
++{
++return ::hypot(x, y);
++}
++}
++#endif
++
  #include 
  #include 
  
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 7 commits - configure.ac vcl/headless vcl/inc vcl/Library_vcl.mk vcl/quartz vcl/README.vars vcl/source vcl/unx vcl/win

[Akash Jain]

Rebased ref, commits from common ancestor:
commit 5dad86cf8b7cc925a00ab0dd778541b97110ea7e
Author: Akash Jain 
Date:   Mon Jun 20 23:49:53 2016 +0530

GSoC: Integrate CommonSalLayout in unx/ code path

Change-Id: I7591d4b159d2d92027dba162b5752468cb69e7a7

diff --git a/vcl/README.vars b/vcl/README.vars
index bf85485..b72d499 100644
--- a/vcl/README.vars
+++ b/vcl/README.vars
@@ -6,6 +6,7 @@ SAL_USE_VCLPLUGIN - use a VCL plugin
 SAL_NO_NWF - disable native widgets
 SAL_FORCEDPI - force a specific DPI (gtk & gtk3 plugins only)
 SAL_FORCE_HC - force high-contrast mode
+SAL_USE_COMMON_LAYOUT - use CommonSalLayout layout engine for text layout
 
 VCL_DOUBLEBUFFERING_AVOID_PAINT - don't paint the buffer, useful to see where 
we do direct painting
 VCL_DOUBLEBUFFERING_FORCE_ENABLE - enable double buffered painting
diff --git a/vcl/headless/svptext.cxx b/vcl/headless/svptext.cxx
index e8fd525..1a523bb 100644
--- a/vcl/headless/svptext.cxx
+++ b/vcl/headless/svptext.cxx
@@ -116,9 +116,14 @@ SalLayout* SvpSalGraphics::GetTextLayout( ImplLayoutArgs& 
rArgs, int nFallbackLe
 return m_aTextRenderImpl.GetTextLayout(rArgs, nFallbackLevel);
 }
 
-void SvpSalGraphics::DrawServerFontLayout( const ServerFontLayout& rSalLayout )
+void SvpSalGraphics::DrawServerFontLayout( const GenericSalLayout& rSalLayout, 
const ServerFont& rServerFont )
 {
-m_aTextRenderImpl.DrawServerFontLayout(rSalLayout );
+m_aTextRenderImpl.DrawServerFontLayout( rSalLayout, rServerFont );
+}
+
+void SvpSalGraphics::DrawCommonSalLayout( const CommonSalLayout& rSalLayout )
+{
+m_aTextRenderImpl.DrawCommonSalLayout( rSalLayout );
 }
 
 void SvpSalGraphics::SetTextColor( SalColor nSalColor )
diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 0d941f9..6d6d19e 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -36,6 +36,9 @@ class CommonSalLayout : public GenericSalLayout
 css::uno::Reference mxBreak;
 #ifdef _WIN32
 HDC mhDC;
+#elif defined(MACOSX) || defined(IOS)
+#else
+ServerFont& mrServerFont;
 #endif
 
 public:
@@ -45,7 +48,9 @@ public:
 explicitCommonSalLayout(const CoreTextStyle*);
 #else
 explicitCommonSalLayout(ServerFont&);
+ServerFont& GetServerFont() const {return mrServerFont;}
 #endif
+
 virtual ~CommonSalLayout();
 voidSetNeedFallback(ImplLayoutArgs&, sal_Int32, bool);
 voidAdjustLayout(ImplLayoutArgs&) override;
diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx
index dc88a60..40bc0b207 100644
--- a/vcl/inc/headless/svpgdi.hxx
+++ b/vcl/inc/headless/svpgdi.hxx
@@ -46,6 +46,7 @@
 struct BitmapBuffer;
 class GlyphCache;
 class ServerFont;
+class CommonSalLayout;
 typedef struct _cairo cairo_t;
 typedef struct _cairo_surface cairo_surface_t;
 typedef struct _cairo_user_data_key cairo_user_data_key_t;
@@ -152,7 +153,8 @@ public:
 virtual boolGetGlyphBoundRect( sal_GlyphId nIndex, Rectangle& 
) override;
 virtual boolGetGlyphOutline( sal_GlyphId nIndex, 
basegfx::B2DPolyPolygon& ) override;
 virtual SalLayout*  GetTextLayout( ImplLayoutArgs&, int nFallbackLevel 
) override;
-virtual voidDrawServerFontLayout( const ServerFontLayout& ) 
override;
+virtual voidDrawServerFontLayout( const GenericSalLayout&, 
const ServerFont& ) override;
+virtual voidDrawCommonSalLayout( const CommonSalLayout& ) 
override;
 virtual boolsupportsOperation( OutDevSupportType ) const 
override;
 virtual voiddrawPixel( long nX, long nY ) override;
 virtual voiddrawPixel( long nX, long nY, SalColor nSalColor ) 
override;
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 09dc619..0e55a89 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -402,7 +402,7 @@ public:
 virtual boolGetGlyphOutline( sal_GlyphId, 
basegfx::B2DPolyPolygon& ) override;
 
 virtual SalLayout*  GetTextLayout( ImplLayoutArgs&, int nFallbackLevel 
) override;
-virtual voidDrawServerFontLayout( const ServerFontLayout& ) 
override;
+virtual voidDrawServerFontLayout( const GenericSalLayout&, 
const ServerFont& ) override;
 virtual boolsupportsOperation( OutDevSupportType ) const 
override;
 
 #ifdef MACOSX
diff --git a/vcl/inc/salgdi.hxx b/vcl/inc/salgdi.hxx
index 56fe42d..4701cf2 100644
--- a/vcl/inc/salgdi.hxx
+++ b/vcl/inc/salgdi.hxx
@@ -44,6 +44,8 @@ class FontSubsetInfo;
 class OpenGLContext;
 class OutputDevice;
 class ServerFontLayout;
+class ServerFont;
+class CommonSalLayout;
 struct SystemGraphicsData;
 
 #if ENABLE_CAIRO_CANVAS
@@ -217,7 +219,8 @@ public:
 virtual boolGetGlyphOutline( sal_GlyphId, 
basegfx::B2DPolyPolygon& ) = 0;
 
 virtual SalLayout*  GetTextLayout( 

[Libreoffice-bugs] [Bug 57337] FORMATTING: Configurable Default Bullet Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57337

Matias  changed:

   What|Removed |Added

Version|3.6.3.2 release |5.1.4.1 rc

--- Comment #3 from Matias  ---
I think that this is a big issue considering than many other programs have
already given a solution. We need an easy way and more configurable and I have
to say a nicer window or tool to change the colour, font, character, size and
anything that you can actually do with any paragraph but with bullets and
numbering lists. 
Regardless, I can't stop saying thanks for LibreOffice, your work is excellent.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'private/pranavk/sidebar' - 3 commits - loleaflet/dist loleaflet/src

[Pranav Kant]

 loleaflet/dist/toolbar/toolbar.js|4 
 loleaflet/src/control/Control.Menubar.js |   24 +---
 2 files changed, 17 insertions(+), 11 deletions(-)

New commits:
commit d0fb736a5b11998ddca902ee11c5914dd6ace293
Author: Pranav Kant 
Date:   Fri Jun 24 23:47:05 2016 +0530

loleaflet: Ask my host to show revision-history

Change-Id: If1ed5fc03c6504e22c565b0278983bb168bb6fc8

diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index 9fda481..6b4fec6 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -8,8 +8,9 @@ L.Control.Menubar = L.Control.extend({
options: {
text:  [
{name: _('File'), type: 'menu', menu: [{name: 
_('Save'), type: 'unocommand', uno: '.uno:Save'},
-   
{name: _('Print'), id: 'print', type: 'action'},
-   
{name: _('Download as'), type: 'menu', menu: [{name: _('PDF 
Document (.pdf)'), id: 'downloadas-pdf', type: 'action'},
+   
   {name: _('Print'), id: 'print', type: 'action'},
+   
   {name: _('See revision history'), id: 'rev-history', type: 
'action'},
+   
   {name: _('Download as'), type: 'menu', menu: [{name: _('PDF 
Document (.pdf)'), id: 'downloadas-pdf', type: 'action'},


   {name: _('ODF text document (.odt)'), id: 'downloadas-odt', 
type: 'action'},


   {name: _('Microsoft Word 2003 (.doc)'), id: 
'downloadas-doc', type: 'action'},


   {name: _('Microsoft Word (.docx)'), id: 'downloadas-docx', 
type: 'action'}]}]
@@ -53,8 +54,9 @@ L.Control.Menubar = L.Control.extend({
 
presentation: [
{name: _('File'), type: 'menu', menu: [{name: 
_('Save'), type: 'unocommand', uno: '.uno:Save'},
-   
{name: _('Print'), id: 'print', type: 'action'},
-   
{name: _('Download as'), type: 'menu', menu:  [{name: _('PDF 
Document (.pdf)'), id: 'downloadas-pdf', type: 'action'},
+   
   {name: _('Print'), id: 'print', type: 'action'},
+   
   {name: _('See revision history'), id: 'rev-history', type: 
'action'},
+   
   {name: _('Download as'), type: 'menu', menu:  [{name: _('PDF 
Document (.pdf)'), id: 'downloadas-pdf', type: 'action'},


{name: _('ODF presentation (.odp)'), id: 
'downloadas-odp', type: 'action'},


{name: _('Microsoft Powerpoint 2003 (.ppt)'), id: 
'downloadas-ppt', type: 'action'},


{name: _('Microsoft Powerpoint (.pptx)'), id: 
'downloadas-pptx', type: 'action'}]}]
@@ -98,8 +100,9 @@ L.Control.Menubar = L.Control.extend({
 
spreadsheet: [
{name: _('File'), type: 'menu', menu: [{name: 
_('Save'), type: 'unocommand', uno: '.uno:Save'},
-   
{name: _('Print'), id: 'print', type: 'action'},
-   
{name: _('Download as'), type: 'menu', menu: [{name: 

[Libreoffice-commits] online.git: loleaflet/src

[Pranav Kant]

 loleaflet/src/control/Control.Menubar.js |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit ce6866b0e5e494e81887704a5d1b13f59aa6f1b9
Author: Pranav Kant 
Date:   Fri Jun 24 23:32:46 2016 +0530

loleaflet: Allow 'about', 'keyboard-shortcuts' in non-edit modes

Change-Id: I2def7a17d05ec7834290b94a51edfd589f6187ed

diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index b62a1a2..1ad0558 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -140,7 +140,8 @@ L.Control.Menubar = L.Control.extend({
allowedViewModeActions: ['downloadas-pdf', 'downloadas-odt', 
'downloadas-doc', 'downloadas-docx',
 
'downloadas-odp', 'downloadas-ppt', 'downloadas-pptx',
 
'downloadas-ods', 'downloadas-xls', 'downloadas-xlsx',
-'fullscreen', 
'zoomin', 'zoomout', 'zoomreset']
+'fullscreen', 
'zoomin', 'zoomout', 'zoomreset',
+'about', 
'keyboard-shortcuts']
},
 
onAdd: function (map) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Changes to 'private/pranavk/sidebar'

[Pranav Kant]

New branch 'private/pranavk/sidebar' available with the following commits:
commit 964abf4a5f73ea0a20ad19f9802181a9b88e1383
Author: Pranav Kant 
Date:   Fri Jun 24 22:03:47 2016 +0530

loleaflet: Ressurect loleaflet permission model for readonly mode

Change-Id: Iaceb95ad85721ddcd675c75cfeb1504ab2759ad4

commit f2c2864ff6732b6c028372e8f6f3df0c12b6f9c6
Author: Pranav Kant 
Date:   Fri Jun 24 22:05:17 2016 +0530

loleaflet: Lint before building

Change-Id: I5e38373959574b3a72fbfe0715a8758de9765438

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100595] New: MacOs strange logs on startup with brand new profile

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100595

Bug ID: 100595
   Summary: MacOs strange logs on startup with brand new profile
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: serval2...@yahoo.fr

On MacOS 10.11.5 with master sources updated some days ago, I got this on
console when launching LO Writer or Calc for example with brand new LO profile:
warn:sal.osl.pipe:5855:1:sal/osl/unx/pipe.cxx:395: shutdown() failed: Socket is
not connected
warn:sal.osl.pipe:5855:3:sal/osl/unx/pipe.cxx:436: accept() failed: Software
caused connection abort
warn:sal.osl:5855:8:sal/osl/unx/socket.cxx:932: undefined address

Steps to reproduce (with brand new profile)
Just launch Writer from console

These don't appear on console when profile directory exists
Perhaps it's nothing but perhaps it hides something more serious.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100572] Formula editor (Math) crash when I export from odf to PDF or directly to pdf from interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100572

V Stuart Foote  changed:

   What|Removed |Added

   Hardware|PA-RISC (HP)|All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100572] Formula editor (Math) crash when I export from odf to PDF or directly to pdf from interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100572

--- Comment #5 from V Stuart Foote  ---
Created attachment 125890
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125890=edit
sample Math formula document exported to PDF

On Windows 10 Pro 64-bit en-US with
Version: 5.2.0.1 (x64)
Build ID: fcbcb4963bda8633ba72bd2108ca1e802aad557d
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
Locale: en-US (en_US)

Can not reproduce. Get clean export to PDF, as well as print to PDF with
ghostscript filtering.

Attached the sample document recreated from the linked screenclips.

Please clear user profile and retest.

Also, any change if you disable OpenGL rendering?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100572] Formula editor (Math) crash when I export from odf to PDF or directly to pdf from interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100572

--- Comment #3 from V Stuart Foote  ---
Created attachment 125888
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125888=edit
sample Math formula document recreated

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100572] Formula editor (Math) crash when I export from odf to PDF or directly to pdf from interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100572

--- Comment #4 from V Stuart Foote  ---
Created attachment 125889
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125889=edit
sample Math formula document printed (ghostscrip) to PDF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100572] Formula editor (Math) crash when I export from odf to PDF or directly to pdf from interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100572

--- Comment #2 from sunu...@opmbx.org ---
Please, watch this pics.

This is the odf file
https://sunuosh.files.wordpress.com/2016/06/1-math1.jpg

Iopen the file. Write and do something
https://sunuosh.files.wordpress.com/2016/06/2-math1.jpg

Click on "File"
https://sunuosh.files.wordpress.com/2016/06/3-math1.jpg

Click on "Export..."
https://sunuosh.files.wordpress.com/2016/06/4-math1.jpg

The window to save and click "Save"
https://sunuosh.files.wordpress.com/2016/06/5-math1.jpg

PDF options, and later click on "Export" but...
https://sunuosh.files.wordpress.com/2016/06/6-math1.jpg

... happen this:
https://sunuosh.files.wordpress.com/2016/06/7-math1.jpg

Nornal Recovery
https://sunuosh.files.wordpress.com/2016/06/8-math1.jpg
https://sunuosh.files.wordpress.com/2016/06/9-math1.jpg

Now use the icon:
https://sunuosh.files.wordpress.com/2016/06/10-math.jpg

Click on "Save" and...
https://sunuosh.files.wordpress.com/2016/06/11-math.jpg

... this happen again:
https://sunuosh.files.wordpress.com/2016/06/12-math.jpg

That's happen each time since my first time with LibreOffice (Windows 8). With
Fedora 20 I never try it. Later, with windows 8.1 happen again, but I return to
Windows 8 and happens yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99559] If table has bad header (made in MS Word) LO Writer doesn' t show the first row of data.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99559

--- Comment #6 from inforb...@gmail.com ---
The bug persists in Writer 5.1.4.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94354] Freeze when trying to apply formatting to paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94354

Buovjaga  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99265] If done after cropping, compress displays image stretched

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99265

--- Comment #14 from Buovjaga  ---
(In reply to Gérald Maruccia from comment #13)
> ( no critic intended - just curious )
> 
> Why a thing that worked for so long gets suddenly broken ?

Such a break is called a regression. We don't know the reason yet, because no
one has bibisected it: https://wiki.documentfoundation.org/QA/Bibisect

If you want to get involved in quality assurance and bug triaging, please join
the #libreoffice-qa channel, say hello and stick around:
https://wiki.documentfoundation.org/Website/IRC

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svtools/source

[Stephan Bergmann]

 svtools/source/control/tabbar.cxx |   11 +++
 1 file changed, 3 insertions(+), 8 deletions(-)

New commits:
commit d56dc64795dcd913d5fa663275bf34b75a0c82e6
Author: Stephan Bergmann 
Date:   Fri Jun 24 18:57:11 2016 +0200

clang-analyzer-deadcode.DeadStores

Change-Id: I1660e3ed5eb5fac276f3715fe1ffa2308408f1b5

diff --git a/svtools/source/control/tabbar.cxx 
b/svtools/source/control/tabbar.cxx
index 9d36f56..64abad5 100644
--- a/svtools/source/control/tabbar.cxx
+++ b/svtools/source/control/tabbar.cxx
@@ -976,7 +976,6 @@ void TabBar::MouseButtonDown(const MouseEvent& rMEvt)
 return;
 }
 
-ImplTabBarItem* pItem;
 sal_uInt16 nSelId = GetPageId(rMEvt.GetPosPixel());
 
 if (!rMEvt.IsLeft())
@@ -984,9 +983,6 @@ void TabBar::MouseButtonDown(const MouseEvent& rMEvt)
 Window::MouseButtonDown(rMEvt);
 if (nSelId > 0 && nSelId != mnCurPageId)
 {
-sal_uInt16 nPos = GetPagePos( nSelId );
-pItem = mpImpl->mpItemList[nPos];
-
 if (ImplDeactivatePage())
 {
 SetCurPageId(nSelId);
@@ -1010,7 +1006,6 @@ void TabBar::MouseButtonDown(const MouseEvent& rMEvt)
 if (nSelId)
 {
 sal_uInt16  nPos = GetPagePos(nSelId);
-pItem = mpImpl->mpItemList[nPos];
 
 bool bSelectTab = false;
 
@@ -1036,7 +1031,7 @@ void TabBar::MouseButtonDown(const MouseEvent& rMEvt)
 n = 0;
 while (n < nCurPos)
 {
-pItem = mpImpl->mpItemList[n];
+auto pItem = mpImpl->mpItemList[n];
 if (n < nPos)
 bSelect = false;
 else
@@ -1062,7 +1057,7 @@ void TabBar::MouseButtonDown(const MouseEvent& rMEvt)
 n = nCurPos;
 while (n < nCount)
 {
-pItem = mpImpl->mpItemList[n];
+auto pItem = mpImpl->mpItemList[n];
 
 if (n <= nPos)
 bSelect = true;
@@ -1118,7 +1113,7 @@ void TabBar::MouseButtonDown(const MouseEvent& rMEvt)
 if (nSelId != mnCurPageId)
 {
 sal_uInt16 nPos = GetPagePos(nSelId);
-pItem = mpImpl->mpItemList[nPos];
+auto pItem = mpImpl->mpItemList[nPos];
 
 if (!pItem->mbSelect)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100544] No displays the list of user-programmed functions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100544

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Please give an explanation in English.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information in English.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Michael Stahl]

 sc/source/ui/unoobj/scdetect.cxx |   23 +++
 1 file changed, 23 insertions(+)

New commits:
commit 4e3ff19b33c84557fd20e68960499933b4e52638
Author: Michael Stahl 
Date:   Fri Jun 24 18:24:24 2016 +0200

tdf#84834 sc: stricter type detection for dBASE files

The detection is rather sloppy, the bugdoc gets erroneously detected as
dBASE because it starts with '0', has a not-too-large header size at offset 
4,
and a '\r' at a 32-byte alignment towards the start of the the not-too-large
header.

Add a plausibility check for the number of records in the file, which
helps for this bugdoc.

Change-Id: I466dfae18aa32fd62b79b9f524f22bea719721be

diff --git a/sc/source/ui/unoobj/scdetect.cxx b/sc/source/ui/unoobj/scdetect.cxx
index 3bd8ffc..bb2c407 100644
--- a/sc/source/ui/unoobj/scdetect.cxx
+++ b/sc/source/ui/unoobj/scdetect.cxx
@@ -219,14 +219,37 @@ static bool lcl_MayBeDBase( SvStream& rStream )
 if ( nSize < nEmptyDbf )
 return false;
 
+// count of records at 4
+rStream.Seek(4);
+sal_uInt32 nRecords(0);
+rStream.ReadUInt32(nRecords);
+
 // length of header starts at 8
 rStream.Seek(8);
 sal_uInt16 nHeaderLen;
 rStream.ReadUInt16( nHeaderLen );
 
+// size of record at 10
+sal_uInt16 nRecordSize(0);
+rStream.ReadUInt16(nRecordSize);
+
 if ( nHeaderLen < nEmptyDbf || nSize < nHeaderLen )
 return false;
 
+// see DTable.cxx ODbaseTable::readHeader()
+if (0 == nRecordSize)
+return false;
+
+// see DTable.cxx ODbaseTable::construct() line 546
+if (0 == nRecords)
+{
+nRecords = (nSize - nHeaderLen) / nRecordSize;
+}
+
+// tdf#84834 sanity check of size
+if (0 == nRecords || nSize < nHeaderLen + nRecords * 
sal_uInt64(nRecordSize))
+return false;
+
 // Last byte of header must be 0x0d, this is how it's specified.
 // #i9581#,#i26407# but some applications don't follow the specification
 // and pad the header with one byte 0x00 to reach an
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 84834] .log files with certain size are causing writer to stop responding (std:: bad_alloc)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84834

Michael Stahl  changed:

   What|Removed |Added

   Keywords||bibisected
 Status|NEW |RESOLVED
 CC||mst...@redhat.com
  Component|Writer  |Calc
Version|4.2.0.4 release |4.1.0.4 release
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |mst...@redhat.com
   |desktop.org |

--- Comment #4 from Michael Stahl  ---
there's a single memory allocation of > 3gb in FResultSet.cxx:1289, that will
never succeed on 32-bit.

but the real problem is that the type detection thinks that this is a DBase
file, when it's clearly not.

can repro that in 4.1.0.4 already

bibisect range:
ee53857e984fea54b7dc08b99079b38766f0b796
153621f98ee98e4eacaebcf7d62f74d54755cab6

well that contains a lot of typedetection refactoring...

fixed on master

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 60251] ACCESSIBILITY: Tracking Metabug for Windows OS accessibility and AT issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=60251

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||100530


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100530
[Bug 100530] Unable to access LibreOffice Online menu or toolbar
(CollaboraCloudSuite) via keyboard when using a screen reader
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100530] Unable to access LibreOffice Online menu or toolbar ( CollaboraCloudSuite) via keyboard when using a screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100530

V Stuart Foote  changed:

   What|Removed |Added

  Component|Writer  |LibreOffice
 Blocks||60251
Summary|Unable to access the menu   |Unable to access
   |with a screen reader|LibreOffice Online menu or
   ||toolbar
   ||(CollaboraCloudSuite) via
   ||keyboard when using a
   ||screen reader


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=60251
[Bug 60251] ACCESSIBILITY: Tracking Metabug for Windows OS accessibility and AT
issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98666] Green "progress bar" widget not correct with OpenGL rendering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98666

--- Comment #15 from V Stuart Foote  ---
(In reply to Jan Holesovsky from comment #14)
> ...
> Stuart: Can you please create a separate bug for that (if that indeed does
> not work), and make it block the bug 93529?  Thank you!

@Kendy, on 5.2.0.1 and current 5.3.0alpha0+ the Splash screen loading bar does
appear, it is Black over a Green background, but it advances smoothly.

Don't believe there is an issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100594] New: Number format fraction: forced denominator gives wrong result

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100594

Bug ID: 100594
   Summary: Number format fraction: forced denominator gives wrong
result
   Product: LibreOffice
   Version: 4.3.7.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jumbo4...@yahoo.fr

Description: Forced denominator higher than 14 and one '?' for numerator gives
wrong fraction

Steps to reproduce:
1. Format > Cells > Numbers, User format # ?/100
2. Enter values such from 0.01 to 0.2 each 1%

Actual behavior:
Values between 1% and 5% are displayed: 0
Values between 6% and 11% are displayed: 11/100
Values between 12% and 13% are displayed: 12/100
and so on

Expected behavior:
Values should be displayed 1/100 to 20/100

The problem is due to the fact that Forced Denominator fraction is calculated
not from the value, but from nFrac/nDiv which is a rounded value
http://opengrok.libreoffice.org/xref/core/svl/source/numbers/zformat.cxx#lcl_ForcedDenominator

nFrac and nDiv are calculated just before in
http://opengrok.libreoffice.org/xref/core/svl/source/numbers/zformat.cxx#ImpGetFractionOutput
with ?/? as format

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100530] Unable to access the menu with a screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100530

V Stuart Foote  changed:

   What|Removed |Added

 OS|Linux (All) |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100530] Unable to access the menu with a screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100530

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://github.com/nvaccess
   ||/nvda/issues/6111

--- Comment #8 from V Stuart Foote  ---
Opened a ticket with NVDA project

https://github.com/nvaccess/nvda/issues/6111

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100483] Cell corruption on Thinkpad 450S

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100483

maki...@gmail.com changed:

   What|Removed |Added

 CC||maki...@gmail.com

--- Comment #2 from maki...@gmail.com ---
Created attachment 125887
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125887=edit
cell corruption

See attached

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94354] Freeze when trying to apply formatting to paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94354

--- Comment #10 from cathy gilland  ---
(In reply to cathy gilland from comment #9)
> issue is fixed now (at least I can't reproduce it) libre office 5.1.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/unx

[Stephan Bergmann]

 vcl/unx/gtk3/gtk3gtkinst.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit eedc5b15fb5c9a352657edec841b6a30c408e5c8
Author: Stephan Bergmann 
Date:   Fri Jun 24 18:21:35 2016 +0200

loplugin:redundantcast

Change-Id: I1ca323870cfbfae05768489ebd8d0fc59191de06

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 262478f..6be4438 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -429,13 +429,13 @@ namespace
   guint info,
   gpointer user_data_or_owner)
 {
-VclGtkClipboard* pThis = 
reinterpret_cast(user_data_or_owner);
+VclGtkClipboard* pThis = 
static_cast(user_data_or_owner);
 pThis->ClipboardGet(clipboard, selection_data, info);
 }
 
 void ClipboardClearFunc(GtkClipboard *clipboard, gpointer 
user_data_or_owner)
 {
-VclGtkClipboard* pThis = 
reinterpret_cast(user_data_or_owner);
+VclGtkClipboard* pThis = 
static_cast(user_data_or_owner);
 pThis->ClipboardClear(clipboard);
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94354] Freeze when trying to apply formatting to paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94354

cathy gilland  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from cathy gilland  ---
issue is fixed now (at least I can't reproduce it) libre office 5.2.1.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100530] Unable to access the menu with a screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100530

V Stuart Foote  changed:

   What|Removed |Added

 CC||ja...@nvaccess.org,
   ||michael.me...@collabora.com

--- Comment #7 from V Stuart Foote  ---
@Michael, seem to have some significant accessibility issues with the
LibreOffice Online CollaboraCloudSute.  No discoverable navigation to the menu,
and toolbar and document canvas, the F6, F10 used by LO Desktop apps are held
by Browser.

Also, the multiline editable content of the document canvas is not being
resolved--at least by NVDA.

@Jamie, just checked using NVDA 2016.2.1 and no improvement. Is the LibreOffice
Online going to need its own module--I know it is not
Symphony/IAccessible2/MSAA based like the Desktop.  Has anyone from Collabora
touched base with you and Mic?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100483] Cell corruption on Thinkpad 450S

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100483

--- Comment #1 from maki...@gmail.com ---
Problem still exists with 5.1.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100530] Unable to access the menu with a screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100530

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #6 from V Stuart Foote  ---
Confirming - on Windows 10 Pro 64-bit en-US with FireFox 47.0 and NVDA 2016.1

Took a moment and figured out Collabora's LibreOffice Online offer and
registered for a Collabora CloudSuite demo.

The GUI is OK, and mouse based navigation moves one to the menus, but during
editing found the edit cursor gets detached from its position on the canvas.

The listing of keyboard shorts does not provide any navigation between GUI
control elements, and I was unable to identify any.

Unfortunately, most of the GUI for the document canvas is not exposed as NVDA
accessible events with default modules--the content is uninteligible "blank".
NV Access may need to work with Collabora on a module.

If things are similar with Orca reader (expect that they are) at this point the
Collabora CloudSuite should be considered completely not accessible with
limited AT support--they have work to do.


Here are the currently listed Collabora CloudSuite keyboard shortcuts for
anyone interested.

Keyboard Shortcuts
General Keyboard Shortcuts
UndoCtrl + Z
RedoCtrl + Y
Cut Ctrl + X
Paste as unformatted text   Ctrl + Alt + Shift + V
Print (Download as PDF) Ctrl + P
Text formatting
BoldCtrl + B
Italic  Ctrl + I
Underline   Ctrl + U
Double UnderlineCtrl + D
Strikethrough   Ctrl + Alt + 5
Superscript Ctrl + Shift + P
Subscript   Ctrl + Shift + B
Remove direct formattingCtrl + M
Paragraph formatting
Align CenterCtrl + E
Align Left  Ctrl + L
Align Right Ctrl + R
Justify Ctrl + J
Apply Default paragraph style   Ctrl + 0
Apply Heading 1 paragraph style Ctrl + 1
Apply Heading 2 paragraph style Ctrl + 2
Apply Heading 3 paragraph style Ctrl + 3
Apply Heading 4 paragraph style Ctrl + 4
Apply Heading 5 paragraph style Ctrl + 5
Text selection and navigation in document
Select All  Ctrl + A
Move cursor to the left Arrow Left
Move cursor with selection to the left  Shift + Arrow Left
Go to beginning of a word   Ctrl + Arrow Left
Select to the left word by word Ctrl + Shift + Arrow Left
Move cursor to the rightArrow Right
Move cursor with selection to the right Shift + Arrow Right
Go to start of the next wordCtrl + Arrow Right
Select to the right word by wordCtrl + Shift + Arrow Right
Move cursor up one line Arrow Up
Select lines in upwards direction   Shift + Arrow Up
Move cursor to beginning of the previous paragraph  Ctrl + Arrow Up
Select to beginning of paragraphCtrl + Shift + Arrow Up
Move cursor down one line   Arrow Down
Select lines in downwards direction Shift + Arrow Down
Move cursor to beginning of the next paragraph  Ctrl + Arrow Down
Select to end of paragraph  Ctrl + Shift + Arrow Down
Go to beginning of line Home
Go and select to the beginning of a lineShift + Home
Go to start of document Ctrl + Home
Go and select text to start of document Ctrl + Shift + Home
Go to end of line   End
Go and select to the end of a line  Shift + End
Go to end of document   Ctrl + End
Go and select text to end of document   Ctrl + Shift + End
Move the view up one page   PageUp
Switch cursor between text and header   Ctrl + PageUp
Extend the selection up one pageShift + PageUp
Move the view down one page PageDown
Switch cursor between text and footer   Ctrl + PageDown
Extend the selection down one page  Shift + PageDown
Delete to beginning of word Ctrl + Backspace
Delete to end of word   Ctrl + Del
Delete to beginning of sentence Ctrl + Shift + Backspace
Delete to end of sentence   Ctrl + Shift + Del
Shortcut Keys for Tables
Ctrl + AIf the active cell is empty: selects the whole table.
Otherwise: selects the contents of the active cell. Pressing again selects the
entire table.
Ctrl + Home If the active cell is empty: goes to the beginning of the
table. Otherwise: first press goes to beginning of the active cell, second
press goes to beginning of the current table, third press goes to beginning of
document.
Ctrl + End  If the active cell is empty: goes to the end of the table.
Otherwise: first press goes to the end of the active cell, second press goes to
the end of the current table, third press goes to the end of the document.
Ctrl + Tab  Inserts a tab stop (only in tables). Depending on the Window
Manager in use, Alt + Tab may be used instead.
Alt + Arrow KeysIncreases/decreases the size of the column/row on the
right/bottom cell edge
Alt + Shift + 

[Libreoffice-commits] core.git: Branch 'feature/dialog-screenshots' - include/vcl sd/qa sd/source

[Katarina Behrens]

 include/vcl/abstdlg.hxx|1 +
 sd/qa/unit/dialogs-test.cxx|   30 ++
 sd/source/ui/dlg/sddlgfact.hxx |2 ++
 3 files changed, 29 insertions(+), 4 deletions(-)

New commits:
commit ab2fc97c3cf6a7dc5798d0e67830bf081492d4ff
Author: Katarina Behrens 
Date:   Fri Jun 24 17:54:18 2016 +0200

Screenshot names to copy screenshot IDs

for simple (!tab) dialogs. Some more tweaking needed for tab ones
still

Change-Id: Ic7e0bf09e41e1d2e15a80beae9e5fbf94c443e0c

diff --git a/include/vcl/abstdlg.hxx b/include/vcl/abstdlg.hxx
index 676154e..9a6842b 100644
--- a/include/vcl/abstdlg.hxx
+++ b/include/vcl/abstdlg.hxx
@@ -39,6 +39,7 @@ public:
 virtual std::vector getAllPageUIXMLDescriptions() const;
 virtual bool selectPageByUIXMLDescription(const OString& 
rUIXMLDescription);
 virtual Bitmap createScreenshot() const;
+virtual OString GetScreenshotId() const { return OString(); };
 };
 
 class VCL_DLLPUBLIC VclAbstractDialog2
diff --git a/sd/qa/unit/dialogs-test.cxx b/sd/qa/unit/dialogs-test.cxx
index 59f1cc4..2295be4 100644
--- a/sd/qa/unit/dialogs-test.cxx
+++ b/sd/qa/unit/dialogs-test.cxx
@@ -60,7 +60,20 @@
 
 using namespace ::com::sun::star;
 
-static const char* SCREENSHOT_DIRECTORY = "/workdir/screenshots";
+static const char* SCREENSHOT_DIRECTORY = "/workdir/screenshots/";
+
+namespace {
+void splitHelpId( OString& rHelpId, OUString& rDirname, OUString 
 )
+{
+   sal_Int32 nIndex = rHelpId.lastIndexOf( '/' );
+
+   if( nIndex > 0 )
+rDirname = OStringToOUString( rHelpId.copy( 0, nIndex ), 
RTL_TEXTENCODING_UTF8 );
+
+   if( rHelpId.getLength() > nIndex+1 )
+rBasename= OStringToOUString( rHelpId.copy( nIndex+1 ), 
RTL_TEXTENCODING_UTF8 );
+}
+}
 
 /// Test opening a dialog in sd
 class SdDialogsTest : public test::BootstrapFixture, public unotest::MacrosTest
@@ -641,9 +654,18 @@ void SdDialogsTest::dumpDialogToPath(VclAbstractDialog& 
rDlg, const OUString& rP
 
 if (!aScreenshot.IsEmpty())
 {
-const OUString aPath = rPath + ".png";
-SvFileStream aNew(aPath, StreamMode::WRITE | StreamMode::TRUNC);
-CPPUNIT_ASSERT_MESSAGE( OUStringToOString( "Failed to create " + 
aPath, RTL_TEXTENCODING_UTF8).getStr(), aNew.IsOpen() );
+OString aScreenshotId = rDlg.GetScreenshotId();
+OUString aDirname, aBasename;
+splitHelpId( aScreenshotId, aDirname, aBasename );
+aDirname = OUString::createFromAscii( SCREENSHOT_DIRECTORY ) + 
aDirname;
+
+osl::FileBase::RC err = osl::Directory::createPath( 
m_directories.getURLFromSrc( aDirname ));
+CPPUNIT_ASSERT_MESSAGE( OUStringToOString( "Failed to create " + 
aDirname, RTL_TEXTENCODING_UTF8).getStr(),
+(err == osl::FileBase::E_None || err == 
osl::FileBase::E_EXIST) );
+
+OUString aFullPath = m_directories.getSrcRootPath() + aDirname + 
"/" + aBasename + ".png";
+SvFileStream aNew(aFullPath, StreamMode::WRITE | 
StreamMode::TRUNC);
+CPPUNIT_ASSERT_MESSAGE( OUStringToOString( "Failed to open " + 
OUString::number(aNew.GetErrorCode()), RTL_TEXTENCODING_UTF8).getStr(), 
aNew.IsOpen() );
 
 vcl::PNGWriter aPNGWriter(aScreenshot);
 aPNGWriter.Write(aNew);
diff --git a/sd/source/ui/dlg/sddlgfact.hxx b/sd/source/ui/dlg/sddlgfact.hxx
index 86bc1f7..9bb135c 100644
--- a/sd/source/ui/dlg/sddlgfact.hxx
+++ b/sd/source/ui/dlg/sddlgfact.hxx
@@ -32,6 +32,7 @@ public: \
 virtual std::vector getAllPageUIXMLDescriptions() const override; 
\
 virtual bool selectPageByUIXMLDescription(const OString& 
rUIXMLDescription) override; \
 virtual Bitmap createScreenshot() const override;   \
+virtual OString GetScreenshotId() const;   \
 virtual ~Class();   \
 virtual short   Execute() override ;
 
@@ -39,6 +40,7 @@ public: \
 std::vector Class::getAllPageUIXMLDescriptions() const { return 
pDlg->getAllPageUIXMLDescriptions(); } \
 bool Class::selectPageByUIXMLDescription(const OString& rUIXMLDescription) { 
return pDlg->selectPageByUIXMLDescription(rUIXMLDescription); } \
 Bitmap Class::createScreenshot() const { return pDlg->createScreenshot();} \
+OString Class::GetScreenshotId() const { return pDlg->GetScreenshotId();} \
 Class::~Class() \
 {   \
 }   \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100593] New: Add fraction number format option to reduce forced denominator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100593

Bug ID: 100593
   Summary: Add fraction number format option to reduce forced
denominator
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jumbo4...@yahoo.fr

Description: Fraction number format enables forced denominator, such as ?/4.
But in some cases, user would prefer reduced fraction than exact forced
denominator.

Steps to reproduce:
1. Change number format: Format > Cells > Numbers, Category: Fraction
2. Enter format such as # ?/4
3. Enter values 0.25, 0.50, 0.75, 1.00, 1.25, 1.50, 1.75, 2.00

Actual behavior:
Display
1/4, 2/4 (!), 3/4, 1, 1 1/4, 1 2/4 (!), 1 3/4, 2

Expected behavior:
Previous display is correct, but user may expect
1/2 instead of 2/4 and 1 1/2 instead of 1 2/4

May be a number format such as # ?/(4) could be ok to have reduced fraction
even with forced denominator?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100558] Spin button for changing day/month/ year in date form control doesn't set right hand digits

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100558

--- Comment #19 from Alex Thurgood  ---
And LO 4.1.0.0 alpha bombs out for me on launch, just after the old startup
dialog gets displayed, so no joy there either.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100558] Spin button for changing day/month/ year in date form control doesn't set right hand digits

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100558

--- Comment #18 from Alex Thurgood  ---
I can't test any of the 4.0.x or 3.7 releases that I have because Java (JDK or
JRE) fails to get detected on OSX 10.11 with these releases, even if I specify
a system path.

LO 3.6.7 doesn't show the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71176] Key combinations to easily insert accented Latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71176

V Stuart Foote  changed:

   What|Removed |Added

 CC||j...@documentfoundation.org

--- Comment #17 from V Stuart Foote  ---
Hi Axel,

(In reply to Axel Grude from comment #16)

> Hello, I am the current developer of Zombie Keys and just wanted to say feel
> free to use my code for any LibreOffice extension. As a (Mozilla) XUL based
> addon I cannot say how universally applicable my code would be, but the
> heart of it is a key listener which is stored by a big JSON structure
> containing keyboard layouts and possible shortcuts. It may be a bit of work
> adding support for more (non-eastern European) languages, but it doesn't
> require development or rewrite of the actual algorithms. 
> 
> If there is somebody on the LibreOffice Addons team who would like to take
> on the task they can contact me for support. I won't have time to write (or
> even test) it myself though, as unfortunately I am still using MS Office
> myself. If you like I can attach the most relevant JS module. 
> 
> the code repository is at:
> 
> https://github.com/RealRaven2000/ZombieKeys

Thank you for the kind offer! Could you adjust the license to MPLv2/LGPLv3+, or
better complete a contributor statement as at
https://wiki.documentfoundation.org/Development/Developers

Are you sure we can't entice you to play :-)

@Michael M., Jan I. -- no doubt the need for better IME support such as this
for "deadkeys" is real, but if we move forward with Heiko's assertion that
enhancements such as this belong as bundled extensions to core--how best would
we proceed?  A working .oxt demonstration first--or an ESC sponsored EasyHack
with mentorship?

@UX-advise -- so where would a cross platform control for "deadkey" management
best be inserted into the UI?  Somewhere to provide GUI assignments, and
character mouse pick from a dialog, with option to enable "deadkey" keyboard
accelerator mappings?  And potentially also provide a consistent GUI to hook
other IME configuration(s) into? 

Seems like the framework to extend is already there with the Special Characters
dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 71176] Key combinations to easily insert accented Latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71176

V Stuart Foote  changed:

   What|Removed |Added

 CC||j...@documentfoundation.org

--- Comment #17 from V Stuart Foote  ---
Hi Axel,

(In reply to Axel Grude from comment #16)

> Hello, I am the current developer of Zombie Keys and just wanted to say feel
> free to use my code for any LibreOffice extension. As a (Mozilla) XUL based
> addon I cannot say how universally applicable my code would be, but the
> heart of it is a key listener which is stored by a big JSON structure
> containing keyboard layouts and possible shortcuts. It may be a bit of work
> adding support for more (non-eastern European) languages, but it doesn't
> require development or rewrite of the actual algorithms. 
> 
> If there is somebody on the LibreOffice Addons team who would like to take
> on the task they can contact me for support. I won't have time to write (or
> even test) it myself though, as unfortunately I am still using MS Office
> myself. If you like I can attach the most relevant JS module. 
> 
> the code repository is at:
> 
> https://github.com/RealRaven2000/ZombieKeys

Thank you for the kind offer! Could you adjust the license to MPLv2/LGPLv3+, or
better complete a contributor statement as at
https://wiki.documentfoundation.org/Development/Developers

Are you sure we can't entice you to play :-)

@Michael M., Jan I. -- no doubt the need for better IME support such as this
for "deadkeys" is real, but if we move forward with Heiko's assertion that
enhancements such as this belong as bundled extensions to core--how best would
we proceed?  A working .oxt demonstration first--or an ESC sponsored EasyHack
with mentorship?

@UX-advise -- so where would a cross platform control for "deadkey" management
best be inserted into the UI?  Somewhere to provide GUI assignments, and
character mouse pick from a dialog, with option to enable "deadkey" keyboard
accelerator mappings?  And potentially also provide a consistent GUI to hook
other IME configuration(s) into? 

Seems like the framework to extend is already there with the Special Characters
dialog.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann]

 compilerplugins/clang/weakobject.cxx |   23 +++
 1 file changed, 15 insertions(+), 8 deletions(-)

New commits:
commit e6daf6bfb0c3c3e3ba03c825d778436c369f19a3
Author: Stephan Bergmann 
Date:   Fri Jun 24 17:27:18 2016 +0200

Fix check for calls to OWeakObject::release

Change-Id: I90030dee12676eb356ebe2244358052cfcd725de

diff --git a/compilerplugins/clang/weakobject.cxx 
b/compilerplugins/clang/weakobject.cxx
index 42bdf6e..cac13cd 100644
--- a/compilerplugins/clang/weakobject.cxx
+++ b/compilerplugins/clang/weakobject.cxx
@@ -106,16 +106,23 @@ public:
 {
 // note: this is only sometimes a CXXMethodDecl
 FunctionDecl const*const pCalled(pCallExpr->getDirectCallee());
-if (pCalled->getName() == "release"
-//this never works  && pCalled == pOverridden
-&& (pCalled->getParent() == pOverridden->getParent()
-// allow this convenient shortcut
-|| 
loplugin::TypeCheck(QualType(pMethodDecl->getParent()->getTypeForDecl(), 
0)).Class("OWeakObject").Namespace("cppu")
-|| 
loplugin::TypeCheck(QualType(pMethodDecl->getParent()->getTypeForDecl(), 
0)).Class("OWeakAggObject").Namespace("cppu")))
+if (pCalled->getName() == "release")
 {
-return true;
+//this never works  && pCalled == pOverridden
+if (pCalled->getParent() == pOverridden->getParent())
+{
+return true;
+}
+// Allow this convenient shortcut:
+auto td = dyn_cast(pCalled->getParent());
+if (td != nullptr
+&& (loplugin::TypeCheck(QualType(td->getTypeForDecl(), 
0)).Class("OWeakObject").Namespace("cppu")
+|| 
loplugin::TypeCheck(QualType(td->getTypeForDecl(), 
0)).Class("OWeakAggObject").Namespace("cppu")))
+{
+return true;
+}
 }
-if (pCalled->getName() == "relase_ChildImpl") // FIXME remove 
this lunacy
+else if (pCalled->getName() == "relase_ChildImpl") // FIXME 
remove this lunacy
 {
 return true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100558] Spin button for changing day/month/ year in date form control doesn't set right hand digits

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100558

--- Comment #17 from Lionel Elie Mamane  ---
Hmm.. Might be linked to the UNO date struct changes in 4.1... In this case,
the bug will have been first introduced in 4.1.0.alpha by
https://cgit.freedesktop.org/libreoffice/core/commit/?id=dd780228cca25dc818ca7fdb628ff607c109618e
or thereabouts.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91807] Writer crashes when saving (OS X) or gives "write error" then saves corrupt file (Win 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91807

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #19 from Caolán McNamara  ---
Now it doesn't crash or write an utterly corrupted document. Granted it won't
*let* you write the document now cause it contains busted sub objects, but at
least it doesn't destroy what you already have. Fixed, for limited amounts of
fixed I guess.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100592] New: Add fraction number formats for forced denominator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100592

Bug ID: 100592
   Summary: Add fraction number formats for forced denominator
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jumbo4...@yahoo.fr

Description: In UI dialog for Number format, category Fraction, only 2 models
were available. In LibO 5.2, two new formats were added, but some more should
be added.

Steps to reproduce:
1. Format > Cells > Numbers, Category: Fraction

Actual behavior:
Two models were available:
# ?/?
# ??/??
In LibO 5.2, two new formats were added
# ?/4
# ?/100
See
https://cgit.freedesktop.org/libreoffice/core/commit?id=5c24711c6517943d22a978112dc74fa4184dc5f7
Formats list is not explicit about these format, but this is for bug 100413
comment 1.

Expected behavior:
In other spreadsheet software, there are many other formats. This may let the
user think that LibO cannot manage these formats
Proposed list:
# ?/?
# ?/??
# ?/???
# ?/2
# ?/4
# ?/8
# ?/16
# ?/10
# ?/100

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100591] New: Kerning problem on LO Calc with Arial and Liberation Sans

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100591

Bug ID: 100591
   Summary: Kerning problem on LO Calc with Arial and Liberation
Sans
   Product: LibreOffice
   Version: 5.1.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kjor...@lkjcpa.com

OS: Windows 7
LO version: 5.1.x

Downloaded and installed LO Version 5.1.3.2 on Win 7 on 2016.0623. Found that
the LO Calc spreadsheet cells contained a kerning error between the letters "w"
and the "r" in the word "rewritten."

Tried several fonts. The error appears specific to Arial and Liberation Sans
fonts.

Because of another bug just reported, uninstalled LO Version 5.1.3.2 and
reinstalled LO Version 5.1.2. Problem still present.

Tested LO Writer Version 5.1.2 for the same problem. Problem did not appear.

Downloaded and installed LO Version 5.1.4.2 on Linux Mint 17.3 on 2016.0624.
Tested LO Calc for this problem. Problem did not appear.

Problem appears specific to Windows LO Calc Version 5.1.x.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100590] Input line shows unprintable character for the number 1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100590

LKeithJordan  changed:

   What|Removed |Added

 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91807] Writer crashes when saving (OS X) or gives "write error" then saves corrupt file (Win 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91807

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|odf target:5.3.0|odf target:5.3.0
   |target:5.1.5|target:5.1.5 target:5.2.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91807] Writer crashes when saving (OS X) or gives "write error" then saves corrupt file (Win 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91807

--- Comment #18 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f8a132e58e2fa4328e47b19bd49386641d115221=libreoffice-5-2

package: fix exception handling in DeflateThread (related tdf#91807)

It will be available in 5.2.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99265] If done after cropping, compress displays image stretched

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99265

--- Comment #13 from Gérald Maruccia  ---
( no critic intended - just curious )

Why a thing that worked for so long gets suddenly broken ?

( and does not get fixed with new version yet being reported )

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Libreoffice-qa] [Writer] Inserting dummy text, changing font to a non-existing one leads to grey menues in 5.2.0.0RC1

[Thomas Hackert]

Hello V Stuart, *,
V Stuart Foote wrote:
> Tested your exact STR on Windows 10 Pro 64-bit en-US with
> Version: 5.2.0.1 (x64)
> Build ID: fcbcb4963bda8633ba72bd2108ca1e802aad557d
> CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL;
> Locale: en-US (en_US)
> 
> Can not reproduce on Windows.  So, for others can you identify
> your Debian Desktop Environment and theme.

Sure. XFCE 4.12-3 but do not ask me, what theme (xfce-kde2? 
microdeck?). Maybe I will have the time to find this out later ... 
;)
Thanks for testing and have a nice evening
Thomas.

-- 
Ocean:  A body of water occupying about two-thirds of a world made 
for man --who has no gills.
-- Ambrose Bierce

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 100558] Spin button for changing day/month/ year in date form control doesn't set right hand digits

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100558

--- Comment #16 from Alex Thurgood  ---
Bug not present in 

Version 3.6.3.2 (Build ID: 58f22d5)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: download.lst external/mdds

[Kohei Yoshida]

 download.lst  |4 ++--
 external/mdds/UnpackedTarball_mdds.mk |1 -
 external/mdds/tdf90579.patch.0|   23 ---
 3 files changed, 2 insertions(+), 26 deletions(-)

New commits:
commit 81db0773fe499fd4b326925dad42a7099f19fcb3
Author: Kohei Yoshida 
Date:   Thu Jun 23 22:42:48 2016 -0400

Upgrade mdds to 1.2.1.

Change-Id: Ifc5b9d94bad191c0e19d5e6dada492caeb9cba76
Reviewed-on: https://gerrit.libreoffice.org/26638
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/download.lst b/download.lst
index b2d72fb..ef5712b 100644
--- a/download.lst
+++ b/download.lst
@@ -97,8 +97,8 @@ export LIBXML_TARBALL := 
ae249165c173b1ff386ee8ad676815f5-libxml2-2.9.4.tar.gz
 export LIBXSLT_TARBALL := 
a129d3c44c022de3b9dcf6d6f288d72e-libxslt-1.1.29.tar.gz
 export LPSOLVE_TARBALL := 26b3e95ddf3d9c077c480ea45874b3b8-lp_solve_5.5.tar.gz
 export MARIADB_TARBALL := 
a233181e03d3c307668b4c722d881661-mariadb_client-2.0.0-src.tar.gz
-export MDDS_MD5SUM := 9f3383fb7bae825eab69f3a6ec1d74b2
-export MDDS_TARBALL := mdds-1.2.0.tar.bz2
+export MDDS_MD5SUM := 4cf64cd1f6543501b10054a0801a03dd
+export MDDS_TARBALL := mdds-1.2.1.tar.bz2
 export MDNSRESPONDER_MD5SUM := 940057ac8b513b00e8e9ca12ef796762
 export MDNSRESPONDER_TARBALL := mDNSResponder-576.30.4.tar.gz
 export MSPUB_MD5SUM := ff9d0f9dd8fbc523408ea1953d5bde41
diff --git a/external/mdds/UnpackedTarball_mdds.mk 
b/external/mdds/UnpackedTarball_mdds.mk
index bd57593..c015f4c 100644
--- a/external/mdds/UnpackedTarball_mdds.mk
+++ b/external/mdds/UnpackedTarball_mdds.mk
@@ -14,7 +14,6 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,mdds,$(MDDS_TARBALL)))
 $(eval $(call gb_UnpackedTarball_set_patchlevel,mdds,0))
 
 $(eval $(call gb_UnpackedTarball_add_patches,mdds,\
-external/mdds/tdf90579.patch.0 \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/mdds/tdf90579.patch.0 b/external/mdds/tdf90579.patch.0
deleted file mode 100644
index 5ef1bc7..000
--- a/external/mdds/tdf90579.patch.0
+++ /dev/null
@@ -1,23 +0,0 @@
-diff --git a/include/mdds/multi_type_vector_def.inl 
b/include/mdds/multi_type_vector_def.inl
-index 0e2a15a..fe9c767 100644
 include/mdds/multi_type_vector_def.inl
-+++ include/mdds/multi_type_vector_def.inl
-@@ -2306,6 +2306,9 @@ void multi_type_vector<_CellBlockFunc, 
_EventFunc>::swap_single_to_multi_blocks(
- {
- // Source range is at the top of a block.
- 
-+// Shrink the current block by erasing the top part.
-+element_block_func::erase(*blk_src->mp_data, 0, len);
-+
- if (src_tail_len == 0)
- {
- // the whole block needs to be replaced.
-@@ -2314,8 +2317,6 @@ void multi_type_vector<_CellBlockFunc, 
_EventFunc>::swap_single_to_multi_blocks(
- }
- else
- {
--// Shrink the current block by erasing the top part.
--element_block_func::erase(*blk_src->mp_data, 0, len);
- blk_src->m_size -= len;
- }
- 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - package/inc package/source sfx2/source

[Michael Stahl]

 package/inc/ZipOutputStream.hxx|1 +
 package/source/zipapi/ZipOutputStream.cxx  |   12 +++-
 package/source/zippackage/ZipPackageStream.cxx |   11 +++
 sfx2/source/doc/docfile.cxx|6 +++---
 4 files changed, 26 insertions(+), 4 deletions(-)

New commits:
commit f8a132e58e2fa4328e47b19bd49386641d115221
Author: Michael Stahl 
Date:   Thu Jun 23 11:24:55 2016 +0200

package: fix exception handling in DeflateThread (related tdf#91807)

In the bugdoc of tdf#91807 there are at least 49 corrupt zip streams
that raise exceptions in the DeflateThreads.  Because the maximum
allowed number of threads happens to be 48, this results in an infinite
loop in ZipOutputStream::reduceScheduledThreadsToGivenNumberOrLess().

(regression from 7e2ea27e5d56f5cf767a6718a0f5edc28e24af14)

In case an exception is thrown, don't re-throw it immediately, which
might cause trouble such as leaking all of the ZipOutputEntry instances
in m_aEntries.

(cherry picked from commit 8d8b9b80b114b94b20b0bf1438d80e925b49e3bf)

sfx2: exception on storage commit is an error (related: tdf#91807)

For no good or obvious reason, SfxMedium::StorageCommit_Impl() swallows
embed::UseBackupException if there is a pTempFile, which (as the comment
claims) is "always now".  This results in the temp file actually being
copied to the user-visible file and the SaveAs "succeeding", when it
clearly did not.

Also move the exception throwing to the end of ZipOutputStream::finish()
to avoid more memory leaks.

(cherry picked from commit 9084c11fb472f2024e609770ce922c911227e7a8)

Change-Id: I448cc43291754ef20adfa6b65916282fcc365a11
Reviewed-on: https://gerrit.libreoffice.org/26619
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/package/inc/ZipOutputStream.hxx b/package/inc/ZipOutputStream.hxx
index 26d7715..136bc72 100644
--- a/package/inc/ZipOutputStream.hxx
+++ b/package/inc/ZipOutputStream.hxx
@@ -40,6 +40,7 @@ class ZipOutputStream
 ZipEntry*m_pCurrentEntry;
 comphelper::ThreadPool _rSharedThreadPool;
 std::vector< ZipOutputEntry* > m_aEntries;
+::css::uno::Any m_aDeflateException;
 
 public:
 ZipOutputStream(
diff --git a/package/source/zipapi/ZipOutputStream.cxx 
b/package/source/zipapi/ZipOutputStream.cxx
index 9213ed7..41f78b4 100644
--- a/package/source/zipapi/ZipOutputStream.cxx
+++ b/package/source/zipapi/ZipOutputStream.cxx
@@ -98,7 +98,12 @@ void 
ZipOutputStream::consumeScheduledThreadEntry(ZipOutputEntry* pCandidate)
 //Any exceptions thrown in the threads were caught and stored for now
 ::css::uno::Any 
aCaughtException(pCandidate->getParallelDeflateException());
 if (aCaughtException.hasValue())
-::cppu::throwException(aCaughtException);
+{
+m_aDeflateException = aCaughtException; // store it for later throwing
+// the exception handler in DeflateThread should have cleaned temp file
+delete pCandidate;
+return;
+}
 
 writeLOC(pCandidate->getZipEntry(), pCandidate->isEncrypt());
 
@@ -187,6 +192,11 @@ void ZipOutputStream::finish()
 writeEND( nOffset, static_cast < sal_Int32 > (m_aChucker.GetPosition()) - 
nOffset);
 m_xStream->flush();
 m_aZipList.clear();
+
+if (m_aDeflateException.hasValue())
+{   // throw once all threads are finished and m_aEntries can be released
+::cppu::throwException(m_aDeflateException);
+}
 }
 
 const css::uno::Reference< css::io::XOutputStream >& 
ZipOutputStream::getStream()
diff --git a/package/source/zippackage/ZipPackageStream.cxx 
b/package/source/zippackage/ZipPackageStream.cxx
index 43a9b85..5efb145 100644
--- a/package/source/zippackage/ZipPackageStream.cxx
+++ b/package/source/zippackage/ZipPackageStream.cxx
@@ -486,6 +486,17 @@ private:
 catch (const uno::Exception&)
 {
 mpEntry->setParallelDeflateException(::cppu::getCaughtException());
+try
+{
+if (mpEntry->m_xOutStream.is())
+mpEntry->closeBufferFile();
+if (!mpEntry->m_aTempURL.isEmpty())
+mpEntry->deleteBufferFile();
+}
+catch (uno::Exception const&)
+{
+}
+mpEntry->setFinished();
 }
 }
 };
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 184a307..6a0c4c9 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -1625,10 +1625,10 @@ bool SfxMedium::StorageCommit_Impl()
 OSL_ENSURE( !pImpl->m_aName.isEmpty(), "The 
exception _must_ contain the temporary URL!\n" );
 }
 }
-
-   

[Libreoffice-bugs] [Bug 91807] Writer crashes when saving (OS X) or gives "write error" then saves corrupt file (Win 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91807

--- Comment #17 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=60f668ba594c08aa935887ecd0e76d6ba016f166=libreoffice-5-1

package: fix exception handling in DeflateThread (related tdf#91807)

It will be available in 5.1.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sw/source

[Michael Stahl]

 sw/source/core/layout/pagechg.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit c5320ed05f51482a37993420068e754223f08d5c
Author: Michael Stahl 
Date:   Thu Jun 23 22:17:49 2016 +0200

sw: fix STL asserts in lcl_MoveAllLowerObjs *again*

Comment added in cf91483690291272f48ff95c1aebd165da8ae4f0 evidently
insufficient.

(regression from b415494bf0468b74318b61f114e2ff4ae68c00ee)

Change-Id: I9a017aefc3a77b0760fcdc3b8e43ff7c6ac516ac
(cherry picked from commit e7d8cb3ec22906d5d45ba65e0a0cfccd68d202e8)
Reviewed-on: https://gerrit.libreoffice.org/26620
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/core/layout/pagechg.cxx 
b/sw/source/core/layout/pagechg.cxx
index c722da9..7ea39752 100644
--- a/sw/source/core/layout/pagechg.cxx
+++ b/sw/source/core/layout/pagechg.cxx
@@ -1763,8 +1763,10 @@ static void lcl_MoveAllLowerObjs( SwFrame* pFrame, const 
Point& rOffset )
 
 // note: pSortedObj elements may be removed and inserted from
 // MoveObjectIfActive(), invalidating iterators
-for (SwAnchoredObject* pAnchoredObj : *pSortedObj)
+// DO NOT CONVERT THIS TO A C++11 FOR LOOP, IT DID NOT WORK THE LAST 2 
TIMES
+for (size_t i = 0; i < pSortedObj->size(); ++i)
 {
+SwAnchoredObject *const pAnchoredObj = (*pSortedObj)[i];
 const SwFrameFormat& rObjFormat = pAnchoredObj->GetFrameFormat();
 const SwFormatAnchor& rAnchor = rObjFormat.GetAnchor();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 91807] Writer crashes when saving (OS X) or gives "write error" then saves corrupt file (Win 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91807

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|odf target:5.3.0|odf target:5.3.0
   ||target:5.1.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - package/inc package/source sfx2/source

[Michael Stahl]

 package/inc/ZipOutputStream.hxx|1 +
 package/source/zipapi/ZipOutputStream.cxx  |   12 +++-
 package/source/zippackage/ZipPackageStream.cxx |   11 +++
 sfx2/source/doc/docfile.cxx|6 +++---
 4 files changed, 26 insertions(+), 4 deletions(-)

New commits:
commit 60f668ba594c08aa935887ecd0e76d6ba016f166
Author: Michael Stahl 
Date:   Thu Jun 23 11:24:55 2016 +0200

package: fix exception handling in DeflateThread (related tdf#91807)

In the bugdoc of tdf#91807 there are at least 49 corrupt zip streams
that raise exceptions in the DeflateThreads.  Because the maximum
allowed number of threads happens to be 48, this results in an infinite
loop in ZipOutputStream::reduceScheduledThreadsToGivenNumberOrLess().

(regression from 7e2ea27e5d56f5cf767a6718a0f5edc28e24af14)

In case an exception is thrown, don't re-throw it immediately, which
might cause trouble such as leaking all of the ZipOutputEntry instances
in m_aEntries.

(cherry picked from commit 8d8b9b80b114b94b20b0bf1438d80e925b49e3bf)

sfx2: exception on storage commit is an error (related: tdf#91807)

For no good or obvious reason, SfxMedium::StorageCommit_Impl() swallows
embed::UseBackupException if there is a pTempFile, which (as the comment
claims) is "always now".  This results in the temp file actually being
copied to the user-visible file and the SaveAs "succeeding", when it
clearly did not.

Also move the exception throwing to the end of ZipOutputStream::finish()
to avoid more memory leaks.

(cherry picked from commit 9084c11fb472f2024e609770ce922c911227e7a8)

Change-Id: I448cc43291754ef20adfa6b65916282fcc365a11
Reviewed-on: https://gerrit.libreoffice.org/26618
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/package/inc/ZipOutputStream.hxx b/package/inc/ZipOutputStream.hxx
index f995469..0f30618 100644
--- a/package/inc/ZipOutputStream.hxx
+++ b/package/inc/ZipOutputStream.hxx
@@ -40,6 +40,7 @@ class ZipOutputStream
 ZipEntry*m_pCurrentEntry;
 comphelper::ThreadPool _rSharedThreadPool;
 std::vector< ZipOutputEntry* > m_aEntries;
+::css::uno::Any m_aDeflateException;
 
 public:
 ZipOutputStream(
diff --git a/package/source/zipapi/ZipOutputStream.cxx 
b/package/source/zipapi/ZipOutputStream.cxx
index 8cd8b90..94413e2 100644
--- a/package/source/zipapi/ZipOutputStream.cxx
+++ b/package/source/zipapi/ZipOutputStream.cxx
@@ -98,7 +98,12 @@ void 
ZipOutputStream::consumeScheduledThreadEntry(ZipOutputEntry* pCandidate)
 //Any exceptions thrown in the threads were caught and stored for now
 ::css::uno::Any 
aCaughtException(pCandidate->getParallelDeflateException());
 if (aCaughtException.hasValue())
-::cppu::throwException(aCaughtException);
+{
+m_aDeflateException = aCaughtException; // store it for later throwing
+// the exception handler in DeflateThread should have cleaned temp file
+delete pCandidate;
+return;
+}
 
 writeLOC(pCandidate->getZipEntry(), pCandidate->isEncrypt());
 
@@ -187,6 +192,11 @@ void ZipOutputStream::finish()
 writeEND( nOffset, static_cast < sal_Int32 > (m_aChucker.GetPosition()) - 
nOffset);
 m_xStream->flush();
 m_aZipList.clear();
+
+if (m_aDeflateException.hasValue())
+{   // throw once all threads are finished and m_aEntries can be released
+::cppu::throwException(m_aDeflateException);
+}
 }
 
 css::uno::Reference< css::io::XOutputStream > ZipOutputStream::getStream()
diff --git a/package/source/zippackage/ZipPackageStream.cxx 
b/package/source/zippackage/ZipPackageStream.cxx
index 0ff190a..3e84d1e 100644
--- a/package/source/zippackage/ZipPackageStream.cxx
+++ b/package/source/zippackage/ZipPackageStream.cxx
@@ -486,6 +486,17 @@ private:
 catch (const uno::Exception&)
 {
 mpEntry->setParallelDeflateException(::cppu::getCaughtException());
+try
+{
+if (mpEntry->m_xOutStream.is())
+mpEntry->closeBufferFile();
+if (!mpEntry->m_aTempURL.isEmpty())
+mpEntry->deleteBufferFile();
+}
+catch (uno::Exception const&)
+{
+}
+mpEntry->setFinished();
 }
 }
 };
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index e30deb7..fe2078f 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -1620,10 +1620,10 @@ bool SfxMedium::StorageCommit_Impl()
 OSL_ENSURE( !pImp->m_aName.isEmpty(), "The 
exception _must_ contain the temporary URL!\n" );
 }
 }
-
-if ( 

[Libreoffice-commits] core.git: sc/qa

[Zdeněk Crhonek]

 sc/qa/unit/data/functions/fods/disc.fods | 1872 +++
 sc/qa/unit/data/functions/fods/dollarde.fods | 1749 +
 sc/qa/unit/data/functions/fods/dollarfr.fods | 1717 
 3 files changed, 5338 insertions(+)

New commits:
commit 58362bfda5e3eda4e91f0ad5a565670882bb18bb
Author: Zdeněk Crhonek 
Date:   Fri Jun 24 15:38:42 2016 +0200

add DISC, DOLLARDE, DOLARFR test case

Change-Id: I3048f265a5f435d686964a7853ff3a4d90911837
Reviewed-on: https://gerrit.libreoffice.org/26641
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/functions/fods/disc.fods 
b/sc/qa/unit/data/functions/fods/disc.fods
new file mode 100644
index 000..8853f55
--- /dev/null
+++ b/sc/qa/unit/data/functions/fods/disc.fods
@@ -0,0 +1,1872 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-06-24T15:37:03.112370087P0D1LibreOfficeDev/5.2.0.0.alpha1$Linux_X86_64
 
LibreOffice_project/fa9416906e615f5f19ad8524176d2ed693662769
+ 
+  
+   0
+   0
+   34873
+   20623
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   90
+   60
+   true
+  
+  
+   2
+   18
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   90
+   60
+   true
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 90
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ false
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   jQH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAswAEAAhSAAAEdAAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkE0AAASAENPTVBBVF9EVVBMRVhfTU9ERQoARFVQTEVYX09GRg==
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+
+   
+
+  
+  
+
+
+   (
+   
+   )
+  
+  
+
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   £
+   
+  
+  
+   -
+   £
+   
+   
+  
+  
+   £
+ 

[Libreoffice-bugs] [Bug 100558] Spin button for changing day/month/ year in date form control doesn't set right hand digits

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100558

--- Comment #15 from Alex Thurgood  ---
Bug not present in

LibreOffice 3.5.2.2 
Build ID: 281b639-6baa1d3-ef66a77-d866f25-f36d45f

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100590] New: Input line shows unprintable character for the number 1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100590

Bug ID: 100590
   Summary: Input line shows unprintable character for the number
1
   Product: LibreOffice
   Version: 5.1.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kjor...@lkjcpa.com

OS: Windows 7
LO version: 5.1.3.2

Downloaded and installed LO Version 5.1.3.2 on Win 7 on 2016.0623. Found that
the LO Calc input line reflected an unprintable character (black rectangle) in
place of the number 1 wherever it occurred in the spreadsheet cell.

Rebooted and tried again. Same result.

Uninstalled LO Version 5.1.3.2 and reinstalled LO Version 5.1.2. Problem did
not appear.

Downloaded and installed LO Version 5.1.4.2 on Linux Mint 17.3 on 2016.0624.
Tested LO Calc for this problem. Problem did not appear.

Problem appear specific to Windows LO Version 5.1.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100558] Spin button for changing day/month/ year in date form control doesn't set right hand digits

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100558

--- Comment #14 from Alex Thurgood  ---
Bug not present in

LibreOffice 3.4.2 
OOO340m1 (Build:203)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100558] Spin button for changing day/month/ year in date form control doesn't set right hand digits

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100558

Alex Thurgood  changed:

   What|Removed |Added

   Keywords||regression

--- Comment #13 from Alex Thurgood  ---
Bug not present in 

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

in this version, I can set the year digits by setting the cursor on the right
hand side of the date separator and clicking on the spin button.

==> regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100558] Spin button for changing day/month/ year in date form control doesn't set right hand digits

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100558

Alex Thurgood  changed:

   What|Removed |Added

Version|5.1.2.2 release |4.1.4.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100558] Spin button for changing day/month/ year in date form control doesn't set right hand digits

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100558

--- Comment #12 from Alex Thurgood  ---
Bug already present in 

Version: 4.1.4.2
Build ID: 0a0440ccc0227ad9829de5f46be37cfb6edcf72

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann]

 compilerplugins/clang/compat.hxx  |   14 ++
 compilerplugins/clang/constantparam.cxx   |2 +-
 compilerplugins/clang/unuseddefaultparams.cxx |2 +-
 compilerplugins/clang/unusedfields.cxx|2 +-
 compilerplugins/clang/unusedmethods.cxx   |4 ++--
 compilerplugins/clang/unusedmethodsremove.cxx |2 +-
 6 files changed, 20 insertions(+), 6 deletions(-)

New commits:
commit f8a18a464eb2cd8ee7a07b8ddef0fa5d79d638ef
Author: Stephan Bergmann 
Date:   Fri Jun 24 16:46:55 2016 +0200

Adpat to 

"Use more ArrayRefs"

Change-Id: Ied0ab11dd9366b3f499100b2627f4919cca52c9c

diff --git a/compilerplugins/clang/compat.hxx b/compilerplugins/clang/compat.hxx
index db573f5..7a87944 100644
--- a/compilerplugins/clang/compat.hxx
+++ b/compilerplugins/clang/compat.hxx
@@ -128,6 +128,20 @@ inline clang::QualType getReturnType(clang::FunctionDecl 
const & decl) {
 #endif
 }
 
+#if CLANG_VERSION >= 30900
+inline clang::ArrayRef parameters(
+clang::FunctionDecl const & decl)
+{
+return decl.parameters();
+}
+#else
+inline clang::FunctionDecl::param_const_range parameters(
+clang::FunctionDecl const & decl)
+{
+return decl.params();
+}
+#endif
+
 inline clang::QualType getReturnType(clang::FunctionProtoType const & type) {
 #if CLANG_VERSION >= 30500
 return type.getReturnType();
diff --git a/compilerplugins/clang/constantparam.cxx 
b/compilerplugins/clang/constantparam.cxx
index 54fe00c..88d0ec0 100644
--- a/compilerplugins/clang/constantparam.cxx
+++ b/compilerplugins/clang/constantparam.cxx
@@ -122,7 +122,7 @@ MyCallSiteInfo ConstantParam::niceName(const FunctionDecl* 
functionDecl, int par
 }
 aInfo.nameAndParams += functionDecl->getNameAsString() + "(";
 bool bFirst = true;
-for (const ParmVarDecl *pParmVarDecl : functionDecl->params()) {
+for (const ParmVarDecl *pParmVarDecl : compat::parameters(*functionDecl)) {
 if (bFirst)
 bFirst = false;
 else
diff --git a/compilerplugins/clang/unuseddefaultparams.cxx 
b/compilerplugins/clang/unuseddefaultparams.cxx
index 0a3ce28..6d2094e 100644
--- a/compilerplugins/clang/unuseddefaultparams.cxx
+++ b/compilerplugins/clang/unuseddefaultparams.cxx
@@ -107,7 +107,7 @@ MyFuncInfo UnusedDefaultParams::niceName(const 
FunctionDecl* functionDecl)
 }
 aInfo.nameAndParams += functionDecl->getNameAsString() + "(";
 bool bFirst = true;
-for (const ParmVarDecl *pParmVarDecl : functionDecl->params()) {
+for (const ParmVarDecl *pParmVarDecl : compat::parameters(*functionDecl)) {
 if (bFirst)
 bFirst = false;
 else
diff --git a/compilerplugins/clang/unusedfields.cxx 
b/compilerplugins/clang/unusedfields.cxx
index a370cb3..8174511 100644
--- a/compilerplugins/clang/unusedfields.cxx
+++ b/compilerplugins/clang/unusedfields.cxx
@@ -124,7 +124,7 @@ std::string UnusedFields::fullyQualifiedName(const 
FunctionDecl* functionDecl)
 }
 ret += functionDecl->getNameAsString() + "(";
 bool bFirst = true;
-for (const ParmVarDecl *pParmVarDecl : functionDecl->params()) {
+for (const ParmVarDecl *pParmVarDecl : compat::parameters(*functionDecl)) {
 if (bFirst)
 bFirst = false;
 else
diff --git a/compilerplugins/clang/unusedmethods.cxx 
b/compilerplugins/clang/unusedmethods.cxx
index aa645fb..d84449f 100644
--- a/compilerplugins/clang/unusedmethods.cxx
+++ b/compilerplugins/clang/unusedmethods.cxx
@@ -148,7 +148,7 @@ MyFuncInfo UnusedMethods::niceName(const FunctionDecl* 
functionDecl)
 }
 aInfo.nameAndParams += functionDecl->getNameAsString() + "(";
 bool bFirst = true;
-for (const ParmVarDecl *pParmVarDecl : functionDecl->params()) {
+for (const ParmVarDecl *pParmVarDecl : compat::parameters(*functionDecl)) {
 if (bFirst)
 bFirst = false;
 else
@@ -178,7 +178,7 @@ std::string UnusedMethods::fullyQualifiedName(const 
FunctionDecl* functionDecl)
 }
 ret += functionDecl->getNameAsString() + "(";
 bool bFirst = true;
-for (const ParmVarDecl *pParmVarDecl : functionDecl->params()) {
+for (const ParmVarDecl *pParmVarDecl : compat::parameters(*functionDecl)) {
 if (bFirst)
 bFirst = false;
 else
diff --git a/compilerplugins/clang/unusedmethodsremove.cxx 
b/compilerplugins/clang/unusedmethodsremove.cxx
index 74c310d..273b415 100644
--- a/compilerplugins/clang/unusedmethodsremove.cxx
+++ b/compilerplugins/clang/unusedmethodsremove.cxx
@@ -79,7 +79,7 @@ std::string niceName(const CXXMethodDecl* functionDecl)
 + "::" + functionDecl->getNameAsString()
 + "(";
 bool bFirst = true;
-for (const ParmVarDecl *pParmVarDecl : functionDecl->params()) {
+for (const ParmVarDecl *pParmVarDecl : compat::parameters(*functionDecl)) {
 if (bFirst)
 bFirst = false;
 else

[Libreoffice-bugs] [Bug 100558] Spin button for changing day/month/ year in date form control doesn't set right hand digits

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100558

Alex Thurgood  changed:

   What|Removed |Added

Version|unspecified |5.1.2.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99265] If done after cropping, compress displays image stretched

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99265

--- Comment #12 from Gérald Maruccia  ---
Created attachment 125886
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125886=edit
compress after cropping → stretch image in 5.1.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99265] If done after cropping, compress displays image stretched

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99265

--- Comment #11 from Gérald Maruccia  ---
Still not fixed in version: 5.1.4.2
Build ID: 1:5.1.4-0ubuntu1~trusty1
Threads CPU : 4; Version de l'OS :Linux 3.16; UI Render : par défaut; 
Locale : fr-FR (fr_FR.UTF-8)

If done AFTER cropping, « compress » stretches image…

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89870] Unify text layout to use HarfBuzz on all platforms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89870

akash...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |akash...@gmail.com
   |desktop.org |

--- Comment #5 from akash...@gmail.com ---
I am working on this on a feature branch.

https://cgit.freedesktop.org/libreoffice/core/log/?h=feature/commonsallayout

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Libreoffice-qa] [Writer] Inserting dummy text, changing font to a non-existing one leads to grey menues in 5.2.0.0RC1

[V Stuart Foote]

Hello Thomas,

Tested your exact STR on Windows 10 Pro 64-bit en-US with
Version: 5.2.0.1 (x64)
Build ID: fcbcb4963bda8633ba72bd2108ca1e802aad557d
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
Locale: en-US (en_US)

Can not reproduce on Windows.  So, for others can you identify your Debian
Desktop Environment and theme.

Stuart





--
View this message in context: 
http://nabble.documentfoundation.org/Libreoffice-qa-Writer-Inserting-dummy-text-changing-font-to-a-non-existing-one-leads-to-grey-menues-1-tp4187055p4187066.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 82069] FILEOPEN: RTF rectangle positioning/arrangement incorrect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82069

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

--- Comment #6 from Miklos Vajna  ---
This looks sane on master, bisecting points out that my commit
37ecf082378a94d28d90b6f7639b0815484d9e3e (RTF import: fix handling of
RTF_SHPFBLWTXT, 2014-08-13) fixed the appearing strange red rectangle.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81234
Bug 81234 depends on bug 82069, which changed state.

Bug 82069 Summary: FILEOPEN: RTF rectangle positioning/arrangement incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=82069

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac download.lst external/libmwaw writerperfect/qa

[David Tardon]

 configure.ac   
|2 
 download.lst   
|4 
 external/libmwaw/0001-fix-build-with-msvc.patch.1  
|   54 
 
external/libmwaw/0001-if-ptr-to-member-var.-is-defined-ensure-the-class-is.patch.1
 |   56 
 external/libmwaw/Library_mwaw.mk   
|9 
 external/libmwaw/UnpackedTarball_libmwaw.mk
|4 
 writerperfect/qa/unit/WpftDrawFilterTest.cxx   
|4 
 writerperfect/qa/unit/WpftWriterFilterTest.cxx 
|2 
 writerperfect/qa/unit/data/draw/libmwaw/pass/CricketDraw_1.0.hqx   
|  133 ++
 writerperfect/qa/unit/data/draw/libmwaw/pass/CricketDraw_1.1.hqx   
|   72 +
 writerperfect/qa/unit/data/draw/libmwaw/pass/FreeHand_1.0.hqx  
|   75 +
 writerperfect/qa/unit/data/draw/libmwaw/pass/FreeHand_2.0.hqx  
|   49 +++
 writerperfect/qa/unit/data/writer/libmwaw/pass/MaxWrite_1.hqx  
|   12 
 writerperfect/qa/unit/data/writer/libmwaw/pass/MouseWrite_1.hqx
|   58 
 14 files changed, 473 insertions(+), 61 deletions(-)

New commits:
commit 2ff98b560cfaa747b19e013857d89d16fe99fd76
Author: David Tardon 
Date:   Thu Jun 23 14:51:30 2016 +0200

upload libmwaw 0.3.8

Change-Id: I4779d538199ecccb8997e3bfdbf97d7b0ea9679b

diff --git a/configure.ac b/configure.ac
index c5e484b..d99b4b4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7865,7 +7865,7 @@ dnl 
===
 dnl Check for system libmwaw
 dnl ===
 libo_CHECK_SYSTEM_MODULE([libmwaw],[MWAW],[libmwaw-0.3 >= 0.3.1])
-libo_PKG_VERSION([MWAW], [libmwaw-0.3], [0.3.7])
+libo_PKG_VERSION([MWAW], [libmwaw-0.3], [0.3.8])
 
 dnl ===
 dnl Check for system libpagemaker
diff --git a/download.lst b/download.lst
index 7741265..b2d72fb 100644
--- a/download.lst
+++ b/download.lst
@@ -103,8 +103,8 @@ export MDNSRESPONDER_MD5SUM := 
940057ac8b513b00e8e9ca12ef796762
 export MDNSRESPONDER_TARBALL := mDNSResponder-576.30.4.tar.gz
 export MSPUB_MD5SUM := ff9d0f9dd8fbc523408ea1953d5bde41
 export MSPUB_TARBALL := libmspub-0.1.2.tar.bz2
-export MWAW_MD5SUM := 4a8a53a9d997cf0e2bd208178797dbfb
-export MWAW_VERSION_MICRO := 7
+export MWAW_MD5SUM := 72ad446d76b157e30c1baf39bb288b99
+export MWAW_VERSION_MICRO := 8
 export MWAW_TARBALL := libmwaw-0.3.$(MWAW_VERSION_MICRO).tar.bz2
 export MYSQLCPPCONN_TARBALL := 
7239a4430efd4d0189c4f24df67f08e5-mysql-connector-c++-1.1.4.tar.gz
 export MYTHES_TARBALL := a8c2c5b8f09e7ede322d5c602ff6a4b6-mythes-1.2.4.tar.gz
diff --git a/external/libmwaw/0001-fix-build-with-msvc.patch.1 
b/external/libmwaw/0001-fix-build-with-msvc.patch.1
new file mode 100644
index 000..95b5e0c
--- /dev/null
+++ b/external/libmwaw/0001-fix-build-with-msvc.patch.1
@@ -0,0 +1,54 @@
+From 01495bf788fe32723f222599e34ba1779ca3d594 Mon Sep 17 00:00:00 2001
+From: David Tardon 
+Date: Fri, 24 Jun 2016 14:01:14 +0200
+Subject: [PATCH] fix build with msvc
+
+---
+ src/lib/CricketDrawParser.cxx | 4 ++--
+ src/lib/FreeHandParser.cxx| 4 ++--
+ 2 files changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/src/lib/CricketDrawParser.cxx b/src/lib/CricketDrawParser.cxx
+index f04be91..9fe5a32 100644
+--- a/src/lib/CricketDrawParser.cxx
 b/src/lib/CricketDrawParser.cxx
+@@ -930,12 +930,12 @@ bool CricketDrawParser::readShape()
+ MWAWBox2f box(shape.m_vertices[0], shape.m_vertices[2]);
+ int angle[2] = { shape.m_angles[0], shape.m_angles[1] };
+ if (box.min()[1]>box.max()[1]) {
+-  std::swap(box.min()[1],box.max()[1]);
++  std::swap(box.min()[1],box.max()[1]);
+   angle[0]=180-shape.m_angles[1];
+   angle[1]=180-shape.m_angles[0];
+ }
+ if (angle[1]<=angle[0])
+-  std::swap(angle[0],angle[1]);
++  std::swap(angle[0],angle[1]);
+ if (angle[1]>360) {
+   int numLoop=int(angle[1]/360)-1;
+   angle[0]-=numLoop*360;
+diff --git a/src/lib/FreeHandParser.cxx b/src/lib/FreeHandParser.cxx
+index 78d8b08..e97e6e3 100644
+--- a/src/lib/FreeHandParser.cxx
 b/src/lib/FreeHandParser.cxx
+@@ -999,7 +999,7 @@ bool FreeHandParser::checkHeader(MWAWHeader *header, bool 
strict)
+ getPageSpan().setFormOrientation(MWAWPageSpan::LANDSCAPE);
+ for (int j=0; j<4; ++j) {
+   if (j==1) continue;
+-  std::swap(dim[2*j],dim[2*j+1]);
++  std::swap(dim[2*j],dim[2*j+1]);
+ }
+ val &= 0xFFDF;
+   }
+@@ -1016,7 +1016,7 @@ bool