[Libreoffice-bugs] [Bug 107024] Moving between elements on main menu flickers ( with CPU or default hardware acceleration, but is OK with OpenGL rendering )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107024

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||khaledho...@eglug.org,
   ||michael.me...@collabora.com
   ||, t...@iki.fi,
   ||vstuart.fo...@utsa.edu
  Component|UI  |graphics stack
 Blocks||103729
Summary|options flicker |Moving between elements on
   ||main menu flickers (with
   ||CPU or default hardware
   ||acceleration, but is OK
   ||with OpenGL rendering)
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Confirmed.

On Windows 10 Pro 64-bit en-US with nVidia GPU (driver 21.21.13.7653) with
Version: 5.3.2.1 (x64)
Build ID: 7f6693c08cc110b9721245fc4bd4f1712e0c086c
CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; Layout Engine:
new; 
Locale: en-US (en_US); Calc: CL

Flicker is not present with OpenGL rendering, but quite noticeable with
hardware acceleration, or with CPU only rendering.

This was OK with 5.3.0.3 and 5.3.1.2 but goes bad for 5.3.2.1

Needs Windows bibisect

@Michael, Khaled, * -- for 5.3.2.0+ we've moved font layout more completely to
DirectWrite but is that now causing a buffering issue that shows up as flicker
in the menus?

=-ref-=
https://bugs.documentfoundation.org/show_bug.cgi?id=104242#c12 and resulting
shift to DirectWrite from GDI.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103729
[Bug 103729] [META] Tracking HarfBuzz based common text layout regressions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106982] Can't select single column in writer table anymore.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106982

--- Comment #10 from Bob English  ---
Thanks for your efforts, but I have absolutely no Idea what you are trying to
tell me :(

I am just a user.  I made the files, formatted them and started using them, all
was well and good.  After an update from Ubuntu 16.04 to 16.10 which included
an update to LO 3.2.2 I opened the files (OTT) and  did a save as (ODT), and
decided to change the font of one column (Bahamas Light) to (Bahamas), I tried
to select the desired column, and that's when I ran into the odd behavior.  I
made no changes to anything else, besides changing the text by highlighting the
text only and then changing it.

Sorry for my not understanding, but you just made it sound like I did something
to cause this; If I did I would love to know how (in GUI user terms, like by
setting this...)

You marked the bug as invalid, now I feel invalid ;)

I am sure I did not cause this by any direct action, so it must have been the
update or a dependency... don't ask me how, but to me it is therefore still a
bug.

Can you tell me what I have to do to fix this?  I have loads of documents I am
trying to make, look and work consistently, most of which I have not checked
yet for the same behavior, and would like things to work as they should.

I use LO from the GUI only and don't have any understanding nor mess with the
inner workings of any of it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106205] Extra spacing in menu bar's list display

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106205

Fakabbir amin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTOURBUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103427] [META] Styles and Formatting sidebar deck and floating window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103427

Aron Budea  changed:

   What|Removed |Added

 Depends on||106961


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106961
[Bug 106961] UI: Esc key does not quit Fill Format mode
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106961] UI: Esc key does not quit Fill Format mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106961

Aron Budea  changed:

   What|Removed |Added

   Keywords||implementationError
 CC||ba...@caesar.elte.hu
Version|5.3.1.2 release |4.2.0.4 release
 Blocks||103427
   Severity|normal  |minor

--- Comment #1 from Aron Budea  ---
Confirmed with as early as v4.2.0.4 / Windows 7. Seems like the bug arrived
with the Sidebar.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103427
[Bug 103427] [META] Styles and Formatting sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92237] Mixed-Up Keyboard Shortcuts in spanish

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92237

--- Comment #8 from Sebastian Silva  ---
Just to add that this issue is present in Debian Stretch (LibreOffice 5.2.6.2).

It is small, but annoying and I haven't found a workaround.

It also happens with Ctrl-N which is both mapped for "New Document" and "Bold"
(but only does the latter).

I think it's fine to have localized shortcuts but they should be
(automatically?) double-checked to not conflict with each other. Perhaps a user
might want to toggle this under Options > Accessibility or Language? I went
looking for an option.

I'm using Spanish from Spain for UI.
Thanks in advance.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106982] Can't select single column in writer table anymore.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106982

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #9 from V Stuart Foote  ---
Sorry, only just looked at the sample files provided and you have table cells
with "number-columns-spanned=#" attribute assigned to a cell holding the
Totals.

With the spanned column present selection of the single columns can not be done
with the mouse over selection. 

Selection of the full column simply includes the span. The cell could be split
to remove the span matching the rest of the table and would restore the mouse
over selection--not really what folks would want, but consistent. 

With focus into the cell and +Cursor-Down the column can be selected one
cell at a time to apply style to the cells. Note that as selected range passes
into the "spanned" cell, the selection will expand to hold the span--as with
the mouse over column select.

On the Windows builds the "spanned" selection is not any recent change as it
has the same behavior with earlier releases I checked [refs].

Resolved -> INVALID

=-refs-=

Version: 5.3.2.2 (x64)
Build ID: 6cd4f1ef626f15116896b1d8e1398b56da0d0ee1
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; Layout Engine: new; 
Locale: en-US (en_US); Calc: group

Version: 5.2.2.2 (x64)
Build ID: 8f96e87c890bf8fa77463cd4b640a2312823f3ad
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
Locale: en-US (en_US); Calc: CL

Version: 5.1.5.2 (x64)
Build ID: 7a864d8825610a8c07cfc3bc01dd4fce6a9447e5
CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; 
Locale: en-US (en_US); Calc: CL

Version: 4.4.6.3
Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d
Locale: en_US

LibreOffice 3.4.6 
OOO340m1 (Build:602)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: -Og in dbgutil builds

[Norbert Thiebaud]

On Thu, Apr 6, 2017 at 10:39 AM, Michael Stahl  wrote:

>
> but i'm mostly interested in Norbert's opinion, since the biggest
> benefit of -Og is faster tinderbox/jenkins builds.

I am neutral. Considering that we are doing a clang-plugin build in
the mix, I doubt -Og on the gcc build is going to impact that much
either way the overall bottom line.
If that happen to be a real impact, I can always tweak the jenkins
build using the dedicated distro-config / lode mechanisms.

iow: make the default what make sens for dev. if that has a negative
impact on jenkins, we will sort it out there.

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106982] Can't select single column in writer table anymore.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106982

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107026] New: Adding page resulting from inserting text doesn' t update document view.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107026

Bug ID: 107026
   Summary: Adding page resulting from inserting text doesn't
update document view.
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: ARM
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: uzno...@yahoo.com

How to reproduce:
1. open a .odt file in editing mode.
2. insert some text until you fill the current page and a new page is supposed
to be created to accommodate new text.
3. However we don't see new page showing up.
4. close the document and save.
5. reopen it and you will see the new page you created.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105769] Crash when saving a pasted HTML table as DOCX or HTML, repro in comment 14 (Win, 64-bit build only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105769

--- Comment #18 from Aron Budea  ---
Created attachment 132404
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132404=edit
Sample HTML: copy table from browser to Writer, save as DOCX

Caolán, you're tight, I'm attaching a sample HTML file.
I have tested with Firefox and IE 11, and could reproduce the crash with both.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106527] Completely support BASE table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106527

--- Comment #3 from Volga  ---
(In reply to Elie Roux from comment #1)
Anyways, to fully support the different baselines, users
> should be able to manually set the different baselines at character, line or
> paragraph level (although a reasonable automatic guess could be implemented
> first). Having these baseline options not only means UI but also
> modifications in the file format, providing extensions to ODF, etc. that's
> quite a big job...
We can submitting a proposal to OASIS Technical Committees, then focus on their
Issue Tracker if they are decided to do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107025] FORMATTING: Characters are too close when snap to char is turn off

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107025

Mark Hung  changed:

   What|Removed |Added

 Blocks||106568


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106568
[Bug 106568] [META]Text Grid Issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106568] [META]Text Grid Issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106568

Mark Hung  changed:

   What|Removed |Added

 Depends on||107025


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107025
[Bug 107025] FORMATTING: Characters are too close when snap to char is turn off
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107025] New: FORMATTING: Characters are too close when snap to char is turn off

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107025

Bug ID: 107025
   Summary: FORMATTING: Characters are too close when snap to char
is turn off
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mark...@gmail.com

Created attachment 132403
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132403=edit
Sample File

1. Tools / Options / LibreOffice Writer / General / Use, uncheck "square page
mode"
2. Select "Lines and Chars" in Text Grid tab in Page Style dialog.
3. Set Lines per page to 60, Max base text size to 12pt
4. Set Characters per line to 60, Characters width to 8pt
5. Enter some Chinese with text less than 10 pt. It even overlap when text size
is 6pt.


According to ODF1.2, 20.301 style:layout-grid-mode Within a layout cell, no
more than one Asian [UNICODE] character is displayed. An Asian character that
does not fit into a single layout cell is displayed centered into as many
layout cells as required. Non Asian text is centered within as many cells as
required.

According to ODF1.2, 20.305 style:layout-grid-snap-to
The style:layout-grid-snap-to attribute specifies whether the text is snapped
to the grid or not. It is evaluated only if the style:layout-grid-mode
attribute has the value both and the style:layout-grid-standard-mode attribute
has the value true.

Microsoft Word has similar feature, that it can select "Lines and Chars",
except it specifies character distance and line distance instead of Max base
text size and Character width. So characters are always layout in fix distance.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107024] options flicker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107024

thunderball...@safe-mail.net changed:

   What|Removed |Added

Summary|row flickers|options flicker

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc sc/source

[Markus Mohrhard]

 sc/inc/attarray.hxx  |1 
 sc/source/core/data/attarray.cxx |  269 ---
 2 files changed, 140 insertions(+), 130 deletions(-)

New commits:
commit 7e03a22b690ff2fa9e2a1cf3a7b0f86ab48b10a4
Author: Markus Mohrhard 
Date:   Fri Apr 7 15:05:06 2017 +0200

ScAttrArray::HasAttrib needs to process the default pattern if none set

Change-Id: I00f82387ce67ce7d6e8708c7def994767cd79b6f
Reviewed-on: https://gerrit.libreoffice.org/36269
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/inc/attarray.hxx b/sc/inc/attarray.hxx
index a78d77497541..e43ff9268866 100644
--- a/sc/inc/attarray.hxx
+++ b/sc/inc/attarray.hxx
@@ -101,6 +101,7 @@ friend class ScHorizontalAttrIterator;
 void RemoveCellCharAttribs( SCROW nStartRow, SCROW nEndRow,
   const ScPatternAttr* pPattern, ScEditDataArray* 
pDataArray );
 void SetDefaultIfNotInit( SCSIZE nNeeded = 1 );
+bool HasAttrib_Impl(const ScPatternAttr* pPattern, HasAttrFlags nMask, 
SCROW nRow1, SCROW nRow2, SCSIZE i) const;
 
 ScAttrArray(const ScAttrArray&) = delete;
 ScAttrArray& operator=(const ScAttrArray&) = delete;
diff --git a/sc/source/core/data/attarray.cxx b/sc/source/core/data/attarray.cxx
index a55f8dcfd260..bb81939ad342 100644
--- a/sc/source/core/data/attarray.cxx
+++ b/sc/source/core/data/attarray.cxx
@@ -1286,12 +1286,147 @@ void ScAttrArray::ApplyBlockFrame( const SvxBoxItem* 
pLineOuter, const SvxBoxInf
 }
 }
 
-// Test if field contains specific attribute
+bool ScAttrArray::HasAttrib_Impl(const ScPatternAttr* pPattern, HasAttrFlags 
nMask, SCROW nRow1, SCROW nRow2, SCSIZE i) const
+{
+bool bFound = false;
+if ( nMask & HasAttrFlags::Merged )
+{
+const ScMergeAttr* pMerge =
+static_cast( >GetItem( ATTR_MERGE ) 
);
+if ( pMerge->GetColMerge() > 1 || pMerge->GetRowMerge() > 1 )
+bFound = true;
+}
+if ( nMask & ( HasAttrFlags::Overlapped | HasAttrFlags::NotOverlapped | 
HasAttrFlags::AutoFilter ) )
+{
+const ScMergeFlagAttr* pMergeFlag =
+static_cast( >GetItem( 
ATTR_MERGE_FLAG ) );
+if ( (nMask & HasAttrFlags::Overlapped) && pMergeFlag->IsOverlapped() )
+bFound = true;
+if ( (nMask & HasAttrFlags::NotOverlapped) && 
!pMergeFlag->IsOverlapped() )
+bFound = true;
+if ( (nMask & HasAttrFlags::AutoFilter) && pMergeFlag->HasAutoFilter() 
)
+bFound = true;
+}
+if ( nMask & HasAttrFlags::Lines )
+{
+const SvxBoxItem* pBox =
+static_cast( >GetItem( ATTR_BORDER ) 
);
+if ( pBox->GetLeft() || pBox->GetRight() || pBox->GetTop() || 
pBox->GetBottom() )
+bFound = true;
+}
+if ( nMask & HasAttrFlags::Shadow )
+{
+const SvxShadowItem* pShadow =
+static_cast( >GetItem( ATTR_SHADOW 
) );
+if ( pShadow->GetLocation() != SvxShadowLocation::NONE )
+bFound = true;
+}
+if ( nMask & HasAttrFlags::Conditional )
+{
+bool bContainsCondFormat =
+!static_cast(pPattern->GetItem( 
ATTR_CONDITIONAL )).GetCondFormatData().empty();
+if ( bContainsCondFormat )
+bFound = true;
+}
+if ( nMask & HasAttrFlags::Protected )
+{
+const ScProtectionAttr* pProtect =
+static_cast( >GetItem( 
ATTR_PROTECTION ) );
+bool bFoundTemp = false;
+if ( pProtect->GetProtection() || pProtect->GetHideCell() )
+bFoundTemp = true;
+
+bool bContainsCondFormat = pData &&
+!static_cast(pPattern->GetItem( 
ATTR_CONDITIONAL )).GetCondFormatData().empty();
+if ( bContainsCondFormat && nCol != -1 ) // pDocument->GetCondResult() 
is valid only for real columns.
+{
+SCROW nRowStartCond = std::max( nRow1, i ? pData[i-1].nRow 
+ 1: 0 );
+SCROW nRowEndCond = std::min( nRow2, pData[i].nRow );
+bool bFoundCond = false;
+for(SCROW nRowCond = nRowStartCond; nRowCond <= nRowEndCond && 
!bFoundCond; ++nRowCond)
+{
+const SfxItemSet* pSet = pDocument->GetCondResult( nCol, 
nRowCond, nTab );
+
+const SfxPoolItem* pItem;
+if( pSet && pSet->GetItemState( ATTR_PROTECTION, true,  
) == SfxItemState::SET )
+{
+const ScProtectionAttr* pCondProtect = static_cast(pItem);
+if( pCondProtect->GetProtection() || 
pCondProtect->GetHideCell() )
+bFoundCond = true;
+else
+break;
+}
+else
+{
+// well it is not true that we found one
+// but existing one + cell where conditional
+// formatting does not remove it
+  

[Libreoffice-bugs] [Bug 107024] New: row flickers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107024

Bug ID: 107024
   Summary: row flickers
   Product: LibreOffice
   Version: 5.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: thunderball...@safe-mail.net

When selecting File/Edit/Insert/etc from top row the line flickers momentarily.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107023] New: Crash in: SalFrame::SetCallback(vcl::Window *, bool (*)( vcl::Window *, SalEvent, void const *))

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107023

Bug ID: 107023
   Summary: Crash in: SalFrame::SetCallback(vcl::Window *,bool
(*)(vcl::Window *,SalEvent,void const *))
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: peter.beu...@bigpond.com.au

This bug was filed from the crash reporting server and is
br-236f2a8b-8303-4876-9aac-d06932dcd3e7.
=
Moving an image around on a slide

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106982] Can't select single column in writer table anymore.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106982

Bob English  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #8 from Bob English  ---
Now I just upgraded:

Version: 5.3.2.2
Build ID: 1:5.3.2~rc2-0ubuntu1~yakkety0
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: en-US (en_US.UTF-8); Calc: group

Problem still exists.

I have tried everything in my limited power and understanding.

Can anyone tell me if there is somehow a problem with the files and not the
program?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_svg

[andreas kainz]

 icon-themes/breeze/cmd/lc_mailmergewizard.png  |binary
 icon-themes/breeze/cmd/sc_mailmergewizard.png  |binary
 icon-themes/breeze/links.txt   |2 --
 icon-themes/breeze_dark/cmd/lc_mailmergewizard.png |binary
 icon-themes/breeze_dark/cmd/sc_mailmergewizard.png |binary
 icon-themes/breeze_dark/links.txt  |2 --
 icon-themes/breeze_svg/cmd/lc_mailmergewizard.svg  |   13 +
 icon-themes/breeze_svg/cmd/sc_mailmergewizard.svg  |   13 +
 icon-themes/breeze_svg/links.txt   |2 --
 9 files changed, 26 insertions(+), 6 deletions(-)

New commits:
commit 2f7b05988e6853ddac68b614e9d83e05af08bc0f
Author: andreas kainz 
Date:   Sat Apr 8 00:29:39 2017 +0200

add mailmergewizard icon to breeze

Change-Id: Ic9848b6834f5d1cde5177084d796322280d270e9
Reviewed-on: https://gerrit.libreoffice.org/36285
Tested-by: Jenkins 
Reviewed-by: Heiko Tietze 

diff --git a/icon-themes/breeze/cmd/lc_mailmergewizard.png 
b/icon-themes/breeze/cmd/lc_mailmergewizard.png
new file mode 100644
index ..571031d63414
Binary files /dev/null and b/icon-themes/breeze/cmd/lc_mailmergewizard.png 
differ
diff --git a/icon-themes/breeze/cmd/sc_mailmergewizard.png 
b/icon-themes/breeze/cmd/sc_mailmergewizard.png
new file mode 100644
index ..30fc253b4aa5
Binary files /dev/null and b/icon-themes/breeze/cmd/sc_mailmergewizard.png 
differ
diff --git a/icon-themes/breeze/links.txt b/icon-themes/breeze/links.txt
index 141563c27cc1..4ed3f1e5de1a 100644
--- a/icon-themes/breeze/links.txt
+++ b/icon-themes/breeze/links.txt
@@ -470,8 +470,6 @@ cmd/sc_xlinestyle.png cmd/sc_linestyle.png
 cmd/sc_hfixedline.png cmd/sc_line.png
 
 # Mail merge
-cmd/lc_mailmergewizard.png cmd/lc_dsbformletter.png
-cmd/sc_mailmergewizard.png cmd/sc_dsbformletter.png
 cmd/lc_mailmergefirstentry.png cmd/lc_firstrecord.png
 cmd/sc_mailmergefirstentry.png cmd/sc_firstrecord.png
 cmd/lc_mailmergelastentry.png cmd/lc_lastrecord.png
diff --git a/icon-themes/breeze_dark/cmd/lc_mailmergewizard.png 
b/icon-themes/breeze_dark/cmd/lc_mailmergewizard.png
new file mode 100644
index ..b6a66b47d778
Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_mailmergewizard.png 
differ
diff --git a/icon-themes/breeze_dark/cmd/sc_mailmergewizard.png 
b/icon-themes/breeze_dark/cmd/sc_mailmergewizard.png
new file mode 100644
index ..7b2b587b178e
Binary files /dev/null and b/icon-themes/breeze_dark/cmd/sc_mailmergewizard.png 
differ
diff --git a/icon-themes/breeze_dark/links.txt 
b/icon-themes/breeze_dark/links.txt
index 141563c27cc1..4ed3f1e5de1a 100644
--- a/icon-themes/breeze_dark/links.txt
+++ b/icon-themes/breeze_dark/links.txt
@@ -470,8 +470,6 @@ cmd/sc_xlinestyle.png cmd/sc_linestyle.png
 cmd/sc_hfixedline.png cmd/sc_line.png
 
 # Mail merge
-cmd/lc_mailmergewizard.png cmd/lc_dsbformletter.png
-cmd/sc_mailmergewizard.png cmd/sc_dsbformletter.png
 cmd/lc_mailmergefirstentry.png cmd/lc_firstrecord.png
 cmd/sc_mailmergefirstentry.png cmd/sc_firstrecord.png
 cmd/lc_mailmergelastentry.png cmd/lc_lastrecord.png
diff --git a/icon-themes/breeze_svg/cmd/lc_mailmergewizard.svg 
b/icon-themes/breeze_svg/cmd/lc_mailmergewizard.svg
new file mode 100644
index ..f27c324df78c
--- /dev/null
+++ b/icon-themes/breeze_svg/cmd/lc_mailmergewizard.svg
@@ -0,0 +1,13 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+  
+
+  .ColorScheme-Text {
+color:#4d4d4d;
+  }
+  
+  
+ 
+
diff --git a/icon-themes/breeze_svg/cmd/sc_mailmergewizard.svg 
b/icon-themes/breeze_svg/cmd/sc_mailmergewizard.svg
new file mode 100644
index ..3e515f9a3680
--- /dev/null
+++ b/icon-themes/breeze_svg/cmd/sc_mailmergewizard.svg
@@ -0,0 +1,13 @@
+http://www.w3.org/2000/svg; viewBox="0 0 16 16">
+  
+
+  .ColorScheme-Text {
+color:#4d4d4d;
+  }
+  
+  
+ 
+
diff --git a/icon-themes/breeze_svg/links.txt b/icon-themes/breeze_svg/links.txt
index 141563c27cc1..4ed3f1e5de1a 100644
--- a/icon-themes/breeze_svg/links.txt
+++ b/icon-themes/breeze_svg/links.txt
@@ -470,8 +470,6 @@ cmd/sc_xlinestyle.png cmd/sc_linestyle.png
 cmd/sc_hfixedline.png cmd/sc_line.png
 
 # Mail merge
-cmd/lc_mailmergewizard.png cmd/lc_dsbformletter.png
-cmd/sc_mailmergewizard.png cmd/sc_dsbformletter.png
 cmd/lc_mailmergefirstentry.png cmd/lc_firstrecord.png
 cmd/sc_mailmergefirstentry.png cmd/sc_firstrecord.png
 cmd/lc_mailmergelastentry.png cmd/lc_lastrecord.png
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107022] LO Non-Standard Font File Names Cause Problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107022

LibreTraining  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #5 from LibreTraining  ---
The font names registered are not the problem.
The fact that 2 different font files register the same font name is the
problem.

BUT, I think I have determined the problem (my problem).

I just deleted all the relevant font files and then did a Repair install.
The re-installed font files have the correct file names.
So I guess LO is renaming the font files during the installation.

What happened ...
I had extracted the LO 5.3.0.3 font files when I started working on 
my LibreOffice Fonts Guide.
So then when I had the previous font issues and deleted everything, 
I simply copied those distribution files into my font directory.
Everything worked again.
But then when LO was updated I ended-up with two files for each font.
One with underline, and one with hyphen.

Now I do not know why the font files are named differently in the distribution,
but that is where the confusion arose. Why not use the real names?

So I am closing this as resolved/notabug (because "brainfart" is not an
option).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cppcanvas/source

[Bartosz Kosiorek]

 cppcanvas/source/mtfrenderer/emfplus.cxx |   88 +++
 1 file changed, 55 insertions(+), 33 deletions(-)

New commits:
commit 723ee43cf65f85d7b586ae8c98529a22621054a3
Author: Bartosz Kosiorek 
Date:   Fri Apr 7 13:24:41 2017 +0200

Replace EmfPlusRecordType decimal valuse with hex

Change-Id: Ia5f248282e663e86b76a8c90fb5dd55d112f6912
Reviewed-on: https://gerrit.libreoffice.org/36260
Tested-by: Jenkins 
Reviewed-by: Bartosz Kosiorek 

diff --git a/cppcanvas/source/mtfrenderer/emfplus.cxx 
b/cppcanvas/source/mtfrenderer/emfplus.cxx
index 20142396e4e9..f242e31eed62 100644
--- a/cppcanvas/source/mtfrenderer/emfplus.cxx
+++ b/cppcanvas/source/mtfrenderer/emfplus.cxx
@@ -58,39 +58,61 @@
 namespace
 {
 
-#define EmfPlusRecordTypeHeader 16385
-#define EmfPlusRecordTypeEndOfFile 16386
-#define EmfPlusRecordTypeGetDC 16388
-#define EmfPlusRecordTypeObject 16392
-#define EmfPlusRecordTypeFillRects 16394
-#define EmfPlusRecordTypeFillPolygon 16396
-#define EmfPlusRecordTypeDrawLines 16397
-#define EmfPlusRecordTypeFillEllipse 16398
-#define EmfPlusRecordTypeDrawEllipse 16399
-#define EmfPlusRecordTypeFillPie 16400
-#define EmfPlusRecordTypeFillPath 16404
-#define EmfPlusRecordTypeDrawPath 16405
-#define EmfPlusRecordTypeDrawImage 16410
-#define EmfPlusRecordTypeDrawImagePoints 16411
-#define EmfPlusRecordTypeDrawString 16412
-#define EmfPlusRecordTypeSetRenderingOrigin 16413
-#define EmfPlusRecordTypeSetAntiAliasMode 16414
-#define EmfPlusRecordTypeSetTextRenderingHint 16415
-#define EmfPlusRecordTypeSetInterpolationMode 16417
-#define EmfPlusRecordTypeSetPixelOffsetMode 16418
-#define EmfPlusRecordTypeSetCompositingQuality 16420
-#define EmfPlusRecordTypeSave 16421
-#define EmfPlusRecordTypeRestore 16422
-#define EmfPlusRecordTypeBeginContainerNoParams 16424
-#define EmfPlusRecordTypeEndContainer 16425
-#define EmfPlusRecordTypeSetWorldTransform 16426
-#define EmfPlusRecordTypeResetWorldTransform 16427
-#define EmfPlusRecordTypeMultiplyWorldTransform 16428
-#define EmfPlusRecordTypeSetPageTransform 16432
-#define EmfPlusRecordTypeSetClipRect 16434
-#define EmfPlusRecordTypeSetClipPath 16435
-#define EmfPlusRecordTypeSetClipRegion 16436
-#define EmfPlusRecordTypeDrawDriverString 16438
+#define EmfPlusRecordTypeHeader 0x4001
+#define EmfPlusRecordTypeEndOfFile 0x4002
+//TODO EmfPlusRecordTypeComment 0x4003
+#define EmfPlusRecordTypeGetDC 0x4004
+//TODO EmfPlusRecordTypeMultiFormatStart 0x4005
+//TODO EmfPlusRecordTypeMultiFormatSection 0x4006
+//TODO EmfPlusRecordTypeMultiFormatEnd 0x4007
+#define EmfPlusRecordTypeObject 0x4008
+//TODO EmfPlusRecordTypeClear 0x4009
+#define EmfPlusRecordTypeFillRects 0x400A
+#define EmfPlusRecordTypeFillPolygon 0x400C
+#define EmfPlusRecordTypeDrawLines 0x400D
+#define EmfPlusRecordTypeFillEllipse 0x400E
+#define EmfPlusRecordTypeDrawEllipse 0x400F
+#define EmfPlusRecordTypeFillPie 0x4010
+//TODO EmfPlusRecordTypeDrawPie 0x4011
+//TODO EmfPlusRecordTypeDrawArc 0x4012
+//TODO EmfPlusRecordTypeFillRegion 0x4013
+#define EmfPlusRecordTypeFillPath 0x4014
+#define EmfPlusRecordTypeDrawPath 0x4015
+//TODO EmfPlusRecordTypeFillClosedCurve 0x4016
+//TODO EmfPlusRecordTypeDrawClosedCurve 0x4017
+//TODO EmfPlusRecordTypeDrawCurve 0x4018
+//TODO EmfPlusRecordTypeDrawBeziers 0x4019
+#define EmfPlusRecordTypeDrawImage 0x401A
+#define EmfPlusRecordTypeDrawImagePoints 0x401B
+#define EmfPlusRecordTypeDrawString 0x401C
+#define EmfPlusRecordTypeSetRenderingOrigin 0x401D
+#define EmfPlusRecordTypeSetAntiAliasMode 0x401E
+#define EmfPlusRecordTypeSetTextRenderingHint 0x401F
+#define EmfPlusRecordTypeSetInterpolationMode 0x4021
+#define EmfPlusRecordTypeSetPixelOffsetMode 0x4022
+//TODO EmfPlusRecordTypeSetCompositingMode 0x4023
+#define EmfPlusRecordTypeSetCompositingQuality 0x4024
+#define EmfPlusRecordTypeSave 0x4025
+#define EmfPlusRecordTypeRestore 0x4026
+//TODO EmfPlusRecordTypeBeginContainer 0x4027
+#define EmfPlusRecordTypeBeginContainerNoParams 0x4028
+#define EmfPlusRecordTypeEndContainer 0x4027
+#define EmfPlusRecordTypeSetWorldTransform 0x402A
+#define EmfPlusRecordTypeResetWorldTransform 0x402B
+#define EmfPlusRecordTypeMultiplyWorldTransform 0x402C
+//TODO EmfPlusRecordTypeScaleWorldTransform 0x402E
+//TODO EmfPlusRecordTypeRotateWorldTransform 0x402F
+#define EmfPlusRecordTypeSetPageTransform 0x4030
+//TODO EmfPlusRecordTypeResetClip 0x4031
+#define EmfPlusRecordTypeSetClipRect 0x4032
+#define EmfPlusRecordTypeSetClipPath 0x4033
+#define EmfPlusRecordTypeSetClipRegion 0x4034
+//TODO EmfPlusRecordTypeOffsetClip 0x4035
+#define EmfPlusRecordTypeDrawDriverString 0x4036
+//TODO EmfPlusRecordTypeStrokeFillPath 0x4037
+//TODO EmfPlusRecordTypeSerializableObject 0x4038
+//TODO EmfPlusRecordTypeSetTSGraphics 0x4039
+//TODO EmfPlusRecordTypeSetTSClip 0x403A
 
 #define EmfPlusObjectTypeBrush 0x100
 #define EmfPlusObjectTypePen 0x200
___

[Libreoffice-bugs] [Bug 97731] Record summary footer is not visible when table listing is first opened

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97731

--- Comment #40 from jodo  ---
Fixed in 5.3.2.2 (x64)
thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98660] UI: select in table data view scroll bar scrolls multiple pages (Windows)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98660

--- Comment #14 from jodo  ---
Alex,
The problem is still in 5.3.2.2 (x64).
Both with and without 
  Use OpenGL for all rendering.
In both cases, it said 
  GL is currently disabled 
at the bottom of the Graphics Output section of LO View Options.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107022] LO Non-Standard Font File Names Cause Problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107022

--- Comment #4 from V Stuart Foote  ---
(In reply to LibreTraining from comment #3)
> That is the 5.3.2 distribution file which I have renamed to show the the
> full version number.

Yes correct, those are the data files--but not the font name they are
registered into the OS with when actually installed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106986] Graph corrupt when saving to DOCX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106986

tommy27  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106986] Graph corrupt when saving to DOCX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106986

tommy27  changed:

   What|Removed |Added

 CC||ba...@quipo.it

--- Comment #3 from tommy27  ---
Created attachment 132402
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132402=edit
screenshot .ODT vs .DOCX

I confirm bug under Win8.1 x64 using LibO 5.2.5.2
see screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107022] LO Non-Standard Font File Names Cause Problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107022

--- Comment #3 from LibreTraining  ---
That is the 5.3.2 distribution file which I have renamed to show the the full
version number.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107022] LO Non-Standard Font File Names Cause Problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107022

--- Comment #2 from LibreTraining  ---

I just extracted: LibreOffice_5.3.2.2_Win_x64.msi

Font file names ... 

Caladea_Bold.ttf
Caladea_BoldItalic.ttf
Caladea_Italic.ttf
Caladea_Regular.ttf
Carlito_Bold.ttf
Carlito_BoldItalic.ttf
Carlito_Italic.ttf
Carlito_Regular.ttf
DejaVuMathTeXGyre.ttf
DejaVuSans.ttf
DejaVuSansCondensed.ttf
DejaVuSansCondensed_Bold.ttf
DejaVuSansCondensed_BoldOblique.ttf
DejaVuSansCondensed_Oblique.ttf
DejaVuSansMono.ttf
DejaVuSansMono_Bold.ttf
DejaVuSansMono_BoldOblique.ttf
DejaVuSansMono_Oblique.ttf
DejaVuSans_Bold.ttf
DejaVuSans_BoldOblique.ttf
DejaVuSans_ExtraLight.ttf
DejaVuSans_Oblique.ttf
DejaVuSerif.ttf
DejaVuSerifCondensed.ttf
DejaVuSerifCondensed_Bold.ttf
DejaVuSerifCondensed_BoldItalic.ttf
DejaVuSerifCondensed_Italic.ttf
DejaVuSerif_Bold.ttf
DejaVuSerif_BoldItalic.ttf
DejaVuSerif_Italic.ttf
EmojiOneColor_SVGinOT.ttf
GenBasB.ttf
GenBasBI.ttf
GenBasI.ttf
GenBasR.ttf
GenBkBasB.ttf
GenBkBasBI.ttf
GenBkBasI.ttf
GenBkBasR.ttf
LiberationMono_Bold.ttf
LiberationMono_BoldItalic.ttf
LiberationMono_Italic.ttf
LiberationMono_Regular.ttf
LiberationSansNarrow_Bold.ttf
LiberationSansNarrow_BoldItalic.ttf
LiberationSansNarrow_Italic.ttf
LiberationSansNarrow_Regular.ttf
LiberationSans_Bold.ttf
LiberationSans_BoldItalic.ttf
LiberationSans_Italic.ttf
LiberationSans_Regular.ttf
LiberationSerif_Bold.ttf
LiberationSerif_BoldItalic.ttf
LiberationSerif_Italic.ttf
LiberationSerif_Regular.ttf
LinBiolinum_RB_G.ttf
LinBiolinum_RI_G.ttf
LinBiolinum_R_G.ttf
LinLibertine_DR_G.ttf
LinLibertine_RBI_G.ttf
LinLibertine_RB_G.ttf
LinLibertine_RI_G.ttf
LinLibertine_RZI_G.ttf
LinLibertine_RZ_G.ttf
LinLibertine_R_G.ttf
OpenSans_Bold.ttf
OpenSans_BoldItalic.ttf
OpenSans_Italic.ttf
OpenSans_Regular.ttf
opens___.ttf
PT_Serif_Web_Bold.ttf
PT_Serif_Web_BoldItalic.ttf
PT_Serif_Web_Italic.ttf
PT_Serif_Web_Regular.ttf
SourceCodePro_Black.ttf
SourceCodePro_BlackIt.ttf
SourceCodePro_Bold.ttf
SourceCodePro_BoldIt.ttf
SourceCodePro_ExtraLight.ttf
SourceCodePro_ExtraLightIt.ttf
SourceCodePro_It.ttf
SourceCodePro_Light.ttf
SourceCodePro_LightIt.ttf
SourceCodePro_Medium.ttf
SourceCodePro_MediumIt.ttf
SourceCodePro_Regular.ttf
SourceCodePro_Semibold.ttf
SourceCodePro_SemiboldIt.ttf
SourceSansPro_Black.ttf
SourceSansPro_BlackIt.ttf
SourceSansPro_Bold.ttf
SourceSansPro_BoldIt.ttf
SourceSansPro_ExtraLight.ttf
SourceSansPro_ExtraLightIt.ttf
SourceSansPro_It.ttf
SourceSansPro_Light.ttf
SourceSansPro_LightIt.ttf
SourceSansPro_Regular.ttf
SourceSansPro_Semibold.ttf
SourceSansPro_SemiboldIt.ttf


Same as what I found in v5.3.0.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106934] Image Control property style:repeat="scale" is not valid

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106934

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com

--- Comment #1 from Thomas Lendo  ---
I can confirm that style:repeat="scale" in content.xml exists after following
steps:

- Open new Writer document.
- Insert an Image Control (View > Toolbars > Form Controls > Open more controls
toolbar > Image Control).
- Right-click on it and open "Position and Size...".
- Activate "Keep ratio".
- Click OK and save the document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: kit/Kit.cpp

[Michael Meeks]

 kit/Kit.cpp |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 9ea75f974c1ae1ee70e51ba87443e475f7fbd319
Author: Michael Meeks 
Date:   Fri Apr 7 22:33:01 2017 +0100

Re-allocate vector storage to compressed size.

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 6717c677..121f20e8 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -373,6 +373,7 @@ class PngCache
 {
 if (hash)
 {
+newEntry._data->shrink_to_fit();
 _cache.emplace(hash, newEntry);
 _cacheSize += newEntry._data->size();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107022] LO Non-Standard Font File Names Cause Problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107022

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
  Component|LibreOffice |Installation

--- Comment #1 from V Stuart Foote  ---
Sorry, can not reproduce.

On Windows 8.1 Ent 64-bit en-US with
Version: 5.3.2.2 (x64)
Build ID: 6cd4f1ef626f15116896b1d8e1398b56da0d0ee1
CPU Threads: 8; OS Version: Windows 6.29; UI Render: GL; Layout Engine: new; 
Locale: en-US (en_US); Calc: group

The fonts are all named with the 'hyphen', and are listed as noted in the make
files for source [1]

=-ref-=
[1] http://opengrok.libreoffice.org/xref/core/external/more_fonts/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl vcl/qa vcl/source

[Miklos Vajna]

 include/vcl/filter/pdfdocument.hxx  |7 ++-
 vcl/qa/cppunit/pdfexport/data/tdf107018.odt |binary
 vcl/qa/cppunit/pdfexport/pdfexport.cxx  |   50 
 vcl/source/filter/ipdf/pdfdocument.cxx  |   27 ++-
 vcl/source/gdi/pdfwriter_impl.cxx   |   10 ++---
 5 files changed, 70 insertions(+), 24 deletions(-)

New commits:
commit ee73747ab58fbbd5039823767693431223c347d3
Author: Miklos Vajna 
Date:   Fri Apr 7 18:19:41 2017 +0200

tdf#107018 PDF export of PDF images: handle references in nested 
dictionaries

Also get rid of the GetKeyOffset() and GetKeyValueLength() calls when
copying dictionaries: the reference already knows its offset and length,
so no need to call them. This makes the dictionary and the array
handling more similar.

Change-Id: I65936acfaf857636a8d83da3a4cec69289eb89d8
Reviewed-on: https://gerrit.libreoffice.org/36282
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/include/vcl/filter/pdfdocument.hxx 
b/include/vcl/filter/pdfdocument.hxx
index 595b4f0fdfd3..d83cb8308f11 100644
--- a/include/vcl/filter/pdfdocument.hxx
+++ b/include/vcl/filter/pdfdocument.hxx
@@ -71,6 +71,9 @@ class VCL_DLLPUBLIC PDFObjectElement : public PDFElement
 std::vector< std::unique_ptr > m_aElements;
 /// Uncompressed buffer of an object in an object stream.
 std::unique_ptr m_pStreamBuffer;
+/// List of all reference elements inside this object's dictionary and
+/// nested dictionaries.
+std::vector m_aDictionaryReferences;
 
 public:
 PDFObjectElement(PDFDocument& rDoc, double fObjectValue, double 
fGenerationValue);
@@ -88,8 +91,8 @@ public:
 PDFNumberElement* GetNumberElement() const;
 /// Get access to the parsed key-value items from the object dictionary.
 const std::map& GetDictionaryItems();
-/// Same as GetDictionaryItems(), but entries are sorted by file offset.
-std::vector< std::pair > 
GetDictionaryItemsByOffset();
+const std::vector& GetDictionaryReferences() const;
+void AddDictionaryReference(PDFReferenceElement* pReference);
 void SetArray(PDFArrayElement* pArrayElement);
 void SetStream(PDFStreamElement* pStreamElement);
 /// Access to the stream of the object, if it has any.
diff --git a/vcl/qa/cppunit/pdfexport/data/tdf107018.odt 
b/vcl/qa/cppunit/pdfexport/data/tdf107018.odt
new file mode 100644
index ..3bfc7b2d73cb
Binary files /dev/null and b/vcl/qa/cppunit/pdfexport/data/tdf107018.odt differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx 
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 31d0dfb384f2..aacf36b2796b 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -53,6 +53,7 @@ public:
 void testTdf106972();
 void testTdf106972Pdf17();
 void testTdf107013();
+void testTdf107018();
 #endif
 
 CPPUNIT_TEST_SUITE(PdfExportTest);
@@ -65,6 +66,7 @@ public:
 CPPUNIT_TEST(testTdf106972);
 CPPUNIT_TEST(testTdf106972Pdf17);
 CPPUNIT_TEST(testTdf107013);
+CPPUNIT_TEST(testTdf107018);
 #endif
 CPPUNIT_TEST_SUITE_END();
 };
@@ -402,6 +404,54 @@ void PdfExportTest::testTdf107013()
 // This failed, the reference to the image was created, but not the image.
 CPPUNIT_ASSERT(pXObject);
 }
+
+void PdfExportTest::testTdf107018()
+{
+vcl::filter::PDFDocument aDocument;
+load("tdf107018.odt", aDocument);
+
+// Get access to the only image on the only page.
+std::vector aPages = aDocument.GetPages();
+CPPUNIT_ASSERT_EQUAL(static_cast(1), aPages.size());
+vcl::filter::PDFObjectElement* pResources = 
aPages[0]->LookupObject("Resources");
+CPPUNIT_ASSERT(pResources);
+auto pXObjects = 
dynamic_cast(pResources->Lookup("XObject"));
+CPPUNIT_ASSERT(pXObjects);
+CPPUNIT_ASSERT_EQUAL(static_cast(1), pXObjects->GetItems().size());
+vcl::filter::PDFObjectElement* pXObject = 
pXObjects->LookupObject(pXObjects->GetItems().begin()->first);
+CPPUNIT_ASSERT(pXObject);
+
+// Get access to the form object inside the image.
+auto pXObjectResources = 
dynamic_cast(pXObject->Lookup("Resources"));
+CPPUNIT_ASSERT(pXObjectResources);
+auto pXObjectForms = 
dynamic_cast(pXObjectResources->LookupElement("XObject"));
+CPPUNIT_ASSERT(pXObjectForms);
+vcl::filter::PDFObjectElement* pForm = 
pXObjectForms->LookupObject(pXObjectForms->GetItems().begin()->first);
+CPPUNIT_ASSERT(pForm);
+
+// Get access to Resources -> Font -> F1 of the form.
+auto pFormResources = 
dynamic_cast(pForm->Lookup("Resources"));
+

[Libreoffice-bugs] [Bug 106970] FILEOPEN: DOCX: Spacing between bullets is incorrect ( follow-up bug 106690 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106970

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106692] FILEOPEN: RTF: Incorrect paragraph break at the beginning of the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106692

Michael Stahl  changed:

   What|Removed |Added

   Keywords||filter:rtf
 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |mst...@redhat.com
   |desktop.org |

--- Comment #3 from Michael Stahl  ---
fixed on master

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106692] FILEOPEN: RTF: Incorrect paragraph break at the beginning of the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106692

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106692] FILEOPEN: RTF: Incorrect paragraph break at the beginning of the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106692

--- Comment #2 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=69b7204164945cfed385d58e64592ce1b17937d7

tdf#106692 writerfilter: RTF import: fix \'0d in \leveltext

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa writerfilter/source

[Michael Stahl]

 sw/qa/extras/rtfimport/data/hexcrlf.rtf|6 ++
 writerfilter/source/rtftok/rtfdocumentimpl.cxx |6 --
 2 files changed, 10 insertions(+), 2 deletions(-)

New commits:
commit 69b7204164945cfed385d58e64592ce1b17937d7
Author: Michael Stahl 
Date:   Fri Apr 7 22:29:15 2017 +0200

tdf#106692 writerfilter: RTF import: fix \'0d in \leveltext

It's not a newline but yet another one of those bizarre RTF-encodings.

(regression from 10e733908038407791f9c14af2a86417cc4a653c)

Change-Id: I568050b031b95ac0b6ebfa1a0c39107e62f68bed

diff --git a/sw/qa/extras/rtfimport/data/hexcrlf.rtf 
b/sw/qa/extras/rtfimport/data/hexcrlf.rtf
index 7c7ed1a9b5f8..1aaa0839c7eb 100644
--- a/sw/qa/extras/rtfimport/data/hexcrlf.rtf
+++ b/sw/qa/extras/rtfimport/data/hexcrlf.rtf
@@ -1,4 +1,10 @@
 {\rtf1
+{\*\listtable
+{\list\listtemplateid1
+{\listlevel{\leveltext \'0d\'00.\'01.\'02.\'03.\'04.\'05.\'06}{\levelnumbers 
\'01\'03\'05\'07\'09\'0b\'0d}}
+{\listname Heading;}\listid1199164
+}}
+
 foo\'0dba
 r\'0abaz\'0d\'0aquux
 \par }
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index fe35afe1d372..adf0a80c6956 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -1123,8 +1123,10 @@ RTFError RTFDocumentImpl::resolveChars(char ch)
 if (!bSkipped)
 {
 // note: apparently \'0d\'0a is interpreted as 2 breaks, not 1
-if (m_aStates.top().eDestination != Destination::DOCCOMM
-&& (ch == '\r' || ch == '\n'))
+if ((ch == '\r' || ch == '\n')
+&& m_aStates.top().eDestination != Destination::DOCCOMM
+&& m_aStates.top().eDestination != 
Destination::LEVELNUMBERS
+&& m_aStates.top().eDestination != Destination::LEVELTEXT)
 {
 checkUnicode(/*bUnicode =*/ false, /*bHex =*/ true);
 dispatchSymbol(RTF_PAR);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105871] Save and Quit crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105871

mk...@dorkypantsr.us changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #14 from mk...@dorkypantsr.us ---
Opens and quits successfully in Safe Mode.

In Safe Mode, I Reset to Factory Settings, checking both boxes: (a) Reset
settings and user interface modifications, and (b) Reset entire user profile;
then clicked Apply Changes and Restart.

I opened the 2 Calc documents, made a change in one and Quit, and got the same
crash again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source

[Caolán McNamara]

 filter/source/msfilter/msdffimp.cxx |   18 +++---
 1 file changed, 11 insertions(+), 7 deletions(-)

New commits:
commit a1147a34d85742fd5d9410efac6fc59ac2fd1574
Author: Caolán McNamara 
Date:   Fri Apr 7 20:49:52 2017 +0100

check escher seeks

Change-Id: I4cb523e8654defa25e75ebd54f1e125ea02e1cf9
Reviewed-on: https://gerrit.libreoffice.org/36281
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index e8bc66a8372d..c3b428655b37 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -222,13 +222,20 @@ DffPropertyReader::DffPropertyReader( const 
SvxMSDffManager& rMan )
 InitializePropSet( DFF_msofbtOPT );
 }
 
+bool checkSeek(SvStream , sal_uInt32 nOffset)
+{
+const sal_uInt64 nMaxSeek(rSt.Tell() + rSt.remainingSize());
+return (nOffset <= nMaxSeek && rSt.Seek(nOffset) == nOffset);
+}
+
 void DffPropertyReader::SetDefaultPropSet( SvStream& rStCtrl, sal_uInt32 
nOffsDgg ) const
 {
 const_cast(this)->pDefaultPropSet.reset();
 sal_uInt32 nMerk = rStCtrl.Tell();
-rStCtrl.Seek( nOffsDgg );
+bool bOk = checkSeek(rStCtrl, nOffsDgg);
 DffRecordHeader aRecHd;
-bool bOk = ReadDffRecordHeader( rStCtrl, aRecHd );
+if (bOk)
+bOk = ReadDffRecordHeader( rStCtrl, aRecHd );
 if (bOk && aRecHd.nRecType == DFF_msofbtDggContainer)
 {
 if ( SvxMSDffManager::SeekToRec( rStCtrl, DFF_msofbtOPT, 
aRecHd.GetRecEndFilePos() ) )
@@ -5799,13 +5806,10 @@ void SvxMSDffManager::CheckTxBxStoryChain()
 and remembering the File-Offsets for each Blip

 **/
-void SvxMSDffManager::GetCtrlData( sal_uInt32 nOffsDgg_ )
+void SvxMSDffManager::GetCtrlData(sal_uInt32 nOffsDggL)
 {
-// absolutely remember Start Offset, in case we have to position again
-sal_uInt32 nOffsDggL = nOffsDgg_;
-
 // position control stream
-if (nOffsDggL != rStCtrl.Seek(nOffsDggL))
+if (!checkSeek(rStCtrl, nOffsDggL))
 return;
 
 sal_uInt8   nVer;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107022] New: LO Non-Standard Font File Names Cause Problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107022

Bug ID: 107022
   Summary: LO Non-Standard Font File Names Cause Problems
   Product: LibreOffice
   Version: 5.3.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libretraining.tutori...@gmail.com

Description:

LibreOffice font file names are not the same as the original source.
Underlines replace the original hyphen in the original file names.
This causes duplicate fonts to be installed if the user or any other
application has installed these very commonly used fonts.

On Windows this has the effect of disabling those fonts.
I would expect this would also cause issues on Linux and Mac. 

I just installed the LO 5.3.2.2 update – and my fonts are messed-up again.
Caladea, DejaVu, Liberation Sans, etc., etc., - all disabled.
They are listed, but appear as what looks like Courier.

So I went looking to see why the fonts are broken, again.
I found in the Fonts folder there were multiple duplicates.

For example:
Caladea_Bold.ttf
Caladea_BoldItalic.ttf
Caladea_Italic.ttf
Caladea_Regular.ttf
Caladea-Bold.ttf
Caladea-BoldItalic.ttf
Caladea-Italic.ttf
Caladea-Regular.ttf

Caladea from Font Library – uses hyphen
Caladea from RPM Source - uses hyphen
Caladea from Debian website - uses hyphen

Same problem with: 
- Caladea
- Carlito
- DejaVu
- EmojiOne Color
- Liberation Mono
- Liberation Sans
- Liberation Serif
- Open Sans
- PT Serif
- Source Code Pro

The originals all use hyphens in the file name.
LibreOffice for some reason changes these to underlines.

So if a user has installed these fonts and then installs LibreOffice, 
they are going to have duplicate font name problems.

Or if a user has unexplained font issues after previously installing
LibreOffice, and they clean-out the font files, and they clean-out all the
registry errors, and then they reinstall all the fonts from the original
sources to get rid of some unexplained font issues, get it working properly
again, AND THEN install a LibreOffice update – and then it is all screwed-up
again (me).

This could also explain some of the unexplained font bugs.
I updated LO to test the DejaVu fonts with the latest version.
To see if Bug 87288 was still an issue, or had been fixed.
Instead the update completely disabled all the DejaVu fonts.
So I have to fix it again.

Many other applications install these fonts.
I am sure I am not the only one with these issues.

LibreOffice should use the original font file names.


Steps to Reproduce:
1. Install these common open source fonts
2. Or install an application which installs these common open source fonts
3. Update LibreOffice
4. Try to figure-out why your fonts are disabled again

Actual Results:  
LibreOffice installs the same fonts with different file names which completely
confuses the operating system which then simply disables the fonts.

Expected Results:
Use the same file names as the rest of the planet so installing LibreOffice
does not mess-up the fonts.



Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101
Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 36574] [FORMATTING] Can' t make default Writer bullet types locale dependent (french bullets / dash bullets)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=36574

--- Comment #27 from Cor Nouws  ---
(In reply to peterpan from comment #26)
> (In reply to Mikhail Krasilnikov from comment #25)
> > I run into this issue when trying to create template with company style for
> > our employees. Most of them don't now (and don't want to know) how to set
> > hot keys. When they need list, they just click icon on toolbar. So I need a
> > way to change style for lists, created by pressing these icons.
> 
> And that is exactly also my point. Thank you for formulating it.

Mind that for setting the default, bug 57337 is the one to follow.
Apart from that I understand you, I think the renewed split buttons make it
much easier for users to make at least some choice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106994] Text next to enlarged bullet point gets cropped

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106994

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||khaledho...@eglug.org

--- Comment #4 from Xisco Faulí  ---
Regression introduced by:

author  Khaled Hosny 2016-11-09 13:22:43 (GMT)
committer   Khaled Hosny 2016-11-22 15:32:11
(GMT)
commit  34d7602954d4483b3bc9db700e7df2c15348947a (patch)
tree8dcfb93fc29815fd89481a7840d64d6c187534db
parent  c855aec445628f96d3d32cfde6efd4e51e4489c9 (diff)
tdf#55469 Consistent line spacing across platforms

Bisected with bibisect-linux-64-5.3

Adding Cc: to Khaled Hosny

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - include/svtools

[Caolán McNamara]

 include/svtools/insdlg.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1946bdabb8132a1989024f1bcd1d24806e1fae9e
Author: Caolán McNamara 
Date:   Fri Apr 7 16:18:22 2017 +0100

Resolves: tdf#106732 the intent was surely to return a const ref

Change-Id: Iaaa1f76a689645adaebf4fe5b87003ad238f71f2
(cherry picked from commit a7d008a8dfdc0a8b42061329b5e756b1b034abaf)
Reviewed-on: https://gerrit.libreoffice.org/36278
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/include/svtools/insdlg.hxx b/include/svtools/insdlg.hxx
index 5e18693663b3..58bada8fadd2 100644
--- a/include/svtools/insdlg.hxx
+++ b/include/svtools/insdlg.hxx
@@ -60,7 +60,7 @@ public:
 return aObjectServerList.size();
 }
 
-const SvObjectServeroperator[]( size_t n ) const
+const SvObjectServer&   operator[]( size_t n ) const
 {
 return aObjectServerList[ n ];
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - include/svtools

[Caolán McNamara]

 include/svtools/insdlg.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d9736ca79ed3205bb091787e09ebb736ffd808a3
Author: Caolán McNamara 
Date:   Fri Apr 7 16:18:22 2017 +0100

Resolves: tdf#106732 the intent was surely to return a const ref

Change-Id: Iaaa1f76a689645adaebf4fe5b87003ad238f71f2
(cherry picked from commit a7d008a8dfdc0a8b42061329b5e756b1b034abaf)
Reviewed-on: https://gerrit.libreoffice.org/36276
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/include/svtools/insdlg.hxx b/include/svtools/insdlg.hxx
index 5e18693663b3..58bada8fadd2 100644
--- a/include/svtools/insdlg.hxx
+++ b/include/svtools/insdlg.hxx
@@ -60,7 +60,7 @@ public:
 return aObjectServerList.size();
 }
 
-const SvObjectServeroperator[]( size_t n ) const
+const SvObjectServer&   operator[]( size_t n ) const
 {
 return aObjectServerList[ n ];
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

[Markus Mohrhard]

 sc/qa/uitest/conditional_format/tdf105466.py |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit e9af903505a730320268081e43658c30c289b91f
Author: Markus Mohrhard 
Date:   Fri Apr 7 22:12:08 2017 +0200

uitest: temporarily disable failing test

Change-Id: If65fb4906e69030d0716998619bc6a1acd6730aa

diff --git a/sc/qa/uitest/conditional_format/tdf105466.py 
b/sc/qa/uitest/conditional_format/tdf105466.py
index fb0a872702b9..fa7db7e49698 100644
--- a/sc/qa/uitest/conditional_format/tdf105466.py
+++ b/sc/qa/uitest/conditional_format/tdf105466.py
@@ -8,8 +8,11 @@
 from uitest.framework import UITestCase
 from libreoffice.uno.propertyvalue import mkPropertyValues
 
+import unittest
+
 class tdf105466(UITestCase):
 
+@unittest.skip("issue with floating windows")
 def test_changing_conditional_format(self):
 
 self.ui_test.create_doc_in_start_center("calc")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: configmgr/source include/o3tl o3tl/CppunitTest_o3tl_tests.mk o3tl/qa

[Stephan Bergmann]

 configmgr/source/winreg.cxx   |   42 -
 configmgr/source/writemodfile.cxx |  235 --
 configmgr/source/writemodfile.hxx |9 
 include/o3tl/string_view.hxx  |  867 ++
 o3tl/CppunitTest_o3tl_tests.mk|1 
 o3tl/qa/test-string_view.cxx  |  212 +
 6 files changed, 1212 insertions(+), 154 deletions(-)

New commits:
commit 50057a37a877213d935958d5c643fde1434d680c
Author: Stephan Bergmann 
Date:   Fri Apr 7 15:59:12 2017 +0200

Introduce o3tl::string_view.hxx approximation of C++17 

...and use it in configmgr/source/writemodfile.hxx

Change-Id: Ie683dc21010ed45cc454ff89bea0376994b351f2
Reviewed-on: https://gerrit.libreoffice.org/36270
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/configmgr/source/winreg.cxx b/configmgr/source/winreg.cxx
index c48a85e70e26..76d7abe15462 100644
--- a/configmgr/source/winreg.cxx
+++ b/configmgr/source/winreg.cxx
@@ -149,7 +149,7 @@ void dumpWindowsRegistryKey(HKEY hKey, OUString const & 
aKeyName, TempFile 
 bool bHasNode = false;
 sal_Int32 nCloseNode = 0;
 
-writeData(aFileHandle, "");
+aFileHandle.writeString("\">");
 break;
 }
 }
 
-writeData(aFileHandle, "");
+aFileHandle.writeString(" oor:finalized=\"true\"");
+aFileHandle.writeString(">");
 writeValueContent(aFileHandle, aValue);
-writeData(aFileHandle, "");
+aFileHandle.writeString("");
 for(; nCloseNode > 0; nCloseNode--)
-writeData(aFileHandle, "");
-writeData(aFileHandle, "\n");
+aFileHandle.writeString("");
+aFileHandle.writeString("\n");
 }
 RegCloseKey(hCurKey);
 }
@@ -235,14 +236,13 @@ bool dumpWindowsRegistry(OUString* pFileURL, WinRegType 
eType)
 "cannot create temporary file");
 }
 aFileHandle.url = *pFileURL;
-writeData(
-aFileHandle,
-"\n\n");
+aFileHandle.writeString(
+"\n\n");
 dumpWindowsRegistryKey(hKey, "", aFileHandle);
-writeData(aFileHandle, "");
+aFileHandle.writeString("");
 oslFileError e = aFileHandle.closeWithoutUnlink();
 if (e != osl_File_E_None)
 SAL_WARN("configmgr", "osl_closeFile failed with " << +e);
diff --git a/configmgr/source/writemodfile.cxx 
b/configmgr/source/writemodfile.cxx
index a1e545e5b5a3..e34b604dafd5 100644
--- a/configmgr/source/writemodfile.cxx
+++ b/configmgr/source/writemodfile.cxx
@@ -20,12 +20,15 @@
 #include 
 
 #include 
+#include 
+#include 
 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -57,13 +60,11 @@ class Components;
 
 namespace {
 
-OString convertToUtf8(
-OUString const & text, sal_Int32 offset, sal_Int32 length)
-{
-assert(offset <= text.getLength() && text.getLength() - offset >= length);
+OString convertToUtf8(o3tl::u16string_view text) {
 OString s;
+assert(text.size() <= sal_uInt32(std::numeric_limits::max()));
 if (!rtl_convertUStringToString(
-, text.pData->buffer + offset, length,
+, text.data(), text.size(),
 RTL_TEXTENCODING_UTF8,
 (RTL_UNICODETOTEXT_FLAGS_UNDEFINED_ERROR |
  RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR)))
@@ -139,43 +140,38 @@ oslFileError TempFile::flush() {
 return e;
 }
 
-void TempFile::writeString(char const *begin, sal_Int32 length) {
-buffer.append(begin, length);
+void TempFile::writeString(o3tl::string_view text) {
+buffer.append(text.data(), text.size());
 if (buffer.getLength() > 0x1)
 flush();
 }
 
 namespace {
 
-void writeData_(TempFile , char const * begin, sal_Int32 length) {
-assert(length >= 0);
-handle.writeString(begin, length);
-}
-
 void writeValueContent_(TempFile &, bool) = delete;
 // silence loplugin:salbool
 void writeValueContent_(TempFile , sal_Bool value) {
 if (value) {
-writeData_(handle, RTL_CONSTASCII_STRINGPARAM("true"));
+handle.writeString("true");
 } else {
-writeData_(handle, RTL_CONSTASCII_STRINGPARAM("false"));
+handle.writeString("false");
 }
 }
 
 void writeValueContent_(TempFile , sal_Int16 value) {
-writeData(handle, OString::number(value));
+handle.writeString(OString::number(value));
 }
 
 void writeValueContent_(TempFile , sal_Int32 

[Libreoffice-commits] core.git: vcl/source

[Miklos Vajna]

 vcl/source/gdi/pdfwriter_impl.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 39038a3544d1b42388a15e6098ccad8398e8ef36
Author: Miklos Vajna 
Date:   Fri Apr 7 16:25:49 2017 +0200

PDF export of PDF images: avoid invalid offset for not used jpeg bitmaps

I missed the JPEG case in commit
30102ded91b9ecfea172ffc6443154230ee37cbd (vcl PDF export, norefxobj:
avoid replacement bitmap, 2017-03-29).

Change-Id: If1f74c7873d05d5d7da5eb881626d4e5e535a0a1
Reviewed-on: https://gerrit.libreoffice.org/36272
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 65c62166aca4..8445377a1a5a 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -11696,7 +11696,8 @@ void PDFWriterImpl::drawJPGBitmap( SvStream& rDCTData, 
bool bIsTrueColor, const
 {
 m_aJPGs.emplace( m_aJPGs.begin() );
 JPGEmit& rEmit = m_aJPGs.front();
-rEmit.m_nObject = createObject();
+if (!hasPdfData(rGraphic, m_aContext.UseReferenceXObject) || 
m_aContext.UseReferenceXObject)
+rEmit.m_nObject = createObject();
 rEmit.m_aID = aID;
 rEmit.m_pStream.reset( pStream );
 rEmit.m_bTrueColor  = bIsTrueColor;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: net/Socket.hpp wsd/LOOLWSD.cpp

[Michael Meeks]

 net/Socket.hpp  |2 ++
 wsd/LOOLWSD.cpp |7 ---
 2 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 254de88a586d3599df16201ff2713ad6f086c200
Author: Michael Meeks 
Date:   Fri Apr 7 20:47:10 2017 +0100

Clear ownership of socket while it is being transferred.

This addresses a gap between ServerSocket accepting new sockets,
and their being added to their new polls.

diff --git a/net/Socket.hpp b/net/Socket.hpp
index 3b44e803..33dbbe5e 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -453,6 +453,8 @@ public:
 {
 std::lock_guard lock(_mutex);
 LOG_DBG("Inserting socket #" << newSocket->getFD() << " into " << 
_name);
+// sockets in transit are un-owned.
+newSocket->setThreadOwner(std::thread::id(0));
 _newSockets.emplace_back(newSocket);
 wakeup();
 }
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 0fe28328..1fca253b 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1445,12 +1445,13 @@ private:
 UnitWSD::get().newChild(*this);
 
 auto child = std::make_shared(pid, socket, request);
-_childProcess = child; // weak
-addNewChild(child);
 
-// We no longer own this socket.
+// Drop pretentions of ownership before adding to the list.
 socket->setThreadOwner(std::thread::id(0));
 
+_childProcess = child; // weak
+addNewChild(child);
+
 // Remove from prisoner poll since there is no activity
 // until we attach the childProcess (with this socket)
 // to a docBroker, which will do the polling.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Bartosz Kosiorek]

 vcl/source/filter/wmf/enhwmf.cxx |   24 
 1 file changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 92a5c6d2c0d0ec4ec4df689f96065574b83a3657
Author: Bartosz Kosiorek 
Date:   Mon Apr 3 01:09:10 2017 +0200

Read number of polylines as UInt32 according to documentation

Change-Id: I7ef8c66485044e2543dc8d9a9e589537eb36f70f
Reviewed-on: https://gerrit.libreoffice.org/36025
Tested-by: Jenkins 
Reviewed-by: Bartosz Kosiorek 

diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index 0d8a9b0d1cd1..75089260335d 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -541,27 +541,27 @@ template 
 void EnhWMFReader::ReadAndDrawPolyLine()
 {
 sal_uInt32  nPoints;
-sal_Int32   i, nPoly(0), nGesPoints(0);
-pWMF->SeekRel( 0x10 );
-// Number of Polygons:
-pWMF->ReadInt32( nPoly ).ReadInt32( nGesPoints );
+sal_uInt32  i, nNumberOfPolylines( 0 ), nCount( 0 );
+pWMF->SeekRel( 0x10 ); // TODO Skipping Bounds. A 128-bit WMF RectL object 
(specifies the bounding rectangle in device units.)
+pWMF->ReadUInt32( nNumberOfPolylines );
+pWMF->ReadUInt32( nCount ); // total number of points in all polylines
 
 // taking the amount of points of each polygon, retrieving the total 
number of points
 if ( pWMF->good() &&
- ( static_cast< sal_uInt32 >(nPoly) < SAL_MAX_UINT32 / 
sizeof(sal_uInt16) ) &&
- ( static_cast< sal_uInt32 >( nPoly ) * sizeof(sal_uInt16) ) <= ( 
nEndPos - pWMF->Tell() )
+ ( nNumberOfPolylines < SAL_MAX_UINT32 / sizeof( sal_uInt16 ) ) &&
+ ( nNumberOfPolylines * sizeof( sal_uInt16 ) ) <= ( nEndPos - 
pWMF->Tell() )
)
 {
-std::unique_ptr pnPoints(new sal_uInt16[ nPoly ]);
-for ( i = 0; i < nPoly && pWMF->good(); i++ )
+std::unique_ptr< sal_uInt32[] > pnPolylinePointCount( new sal_uInt32[ 
nNumberOfPolylines ] );
+for ( i = 0; i < nNumberOfPolylines && pWMF->good(); i++ )
 {
 pWMF->ReadUInt32( nPoints );
-pnPoints[ i ] = (sal_uInt16)nPoints;
+pnPolylinePointCount[ i ] = nPoints;
 }
-// Get polygon points:
-for ( i = 0; ( i < nPoly ) && pWMF->good(); i++ )
+// Get polyline points:
+for ( i = 0; ( i < nNumberOfPolylines ) && pWMF->good(); i++ )
 {
-tools::Polygon aPolygon = ReadPolygon(0, pnPoints[i]);
+tools::Polygon aPolygon = ReadPolygon< T >( 0, 
pnPolylinePointCount[ i ] );
 pOut->DrawPolyLine( aPolygon, false, bRecordPath );
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107021] New: WindowServer memory leak when performing mail merge in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107021

Bug ID: 107021
   Summary: WindowServer memory leak when performing mail merge in
Writer
   Product: LibreOffice
   Version: 5.3.1.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: allencb...@gmail.com

Description:
When using the mail merge wizard in the tools menu to create a mail merge with
a large amount of entries (approximately 2000), and selecting to save the
results as individual documents WindowServer uses an increasing amount of
memory (as much as 70 gigabytes) until it crashes.

Steps to Reproduce:
1. From form letter, goto "Tools" > "Mail Merge Wizard..."
2. Hit "Next>>" twice to get to data selection 
3. "Select Address List..." and select ODS spreadsheet containing 2000 row
recipient list
4. Uncheck address block option
5. Hit "Next>>"
6. Uncheck salutation option
7. Hit "Finish"
8. In the tool bar that appears under the formatting tool bar, select "Save
Merged Documents"
9. Select "Save As Individual Documents"
10. Click "Save Documents"
11. Once document creation is complete specify save location

Actual Results:  
LibreOffice begins saving the documents, while doing so WindowServer memory
usage increases, and part way through computer exits to operating system login
screen.

Expected Results:
Saved the 2000 merged documents to individual files in the specified location.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
Gecko/20100101 Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63570] FILESAVE Writer does not evaluate formulas when converting to pdf or printing by command line

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63570

--- Comment #10 from to...@pis.to ---
I can confirm this bug using also .fods format and converting to pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #6 from DeepFlight5  ---
Sorry, my commentary from February had an error. It should read:

"I assume the "float" problem lies in the LibreOffice code and not in HarfBuzz,
since HarfBuzz is used in Firefox and Chrome also, which have no problems with
accurate glyph display. Will this "float" bug of LibreOffice be fixed anywhere
soon?"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107020] MS Word cannot open round-tripped docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107020

Justin L  changed:

   What|Removed |Added

   Keywords||bibisected, filter:docx,
   ||regression
 CC||jl...@mail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107020] New: MS Word cannot open round-tripped docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107020

Bug ID: 107020
   Summary: MS Word cannot open round-tripped docx
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jl...@mail.com

attachment 132354 from bug 106974 cannot be opened in MS Word after
round-tripping through LO5.4alpha.

Couldn't guess the regression commit somewhere between linux-daily-dbgutil
BAD commit 5fd912cb5ba30cf35881008e752e10a350b13009
2017-03-27: source-hash-23282b476f094c735ecfae4f82798e36ac9cbbc9
and GOOD commit ea808858bbabb761135da08e6c07d7dd99d6322f
2017-03-25: source-hash-193f8966135064a32164c9da08d01dab9c1fc15d

Tested using Ubuntu 16.04, and MSWord 2007.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107003] EDITING: Gallery image will increase in size when rotation it after adding a note caption

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107003

--- Comment #4 from Regina Henschel  ---
I had not closed this report, because it has indeed to be discussed, how the
current behavior can be improved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106700] nested docx documents take long time to open or do not open at all

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106700

Miklos Vajna  changed:

   What|Removed |Added

   Keywords|bibisected, bisected,   |
   |regression  |

--- Comment #14 from Miklos Vajna  ---
If you want faster import, just go to Tools -> Options -> Load/Save ->
Microsoft Office and untick the Load column at the "WinWord to LibreOffice"
row. I don't think this is a regression; the binary DOC import always did this
"embedded DOC" -> "embedded Writer document" conversion, and it's consistent
that with the above commit the DOCX import does the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107003] EDITING: Gallery image will increase in size when rotation it after adding a note caption

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107003

--- Comment #3 from Telesto  ---
@Regina:
I agree it's caused by "relative width" setting (I didn't notice). But I'm
still seeing a bug or inconsistency.

The image switches from absolute to relative width when adding a Note caption.
Its introduced somewhere after LibO5.0.6.3. But I'm not sure if it's on purpose 
The advance is that makes it possible to resize frame and image at once.
However if its intended, why not change the image height also to relative
(inconsistent)

I also notice at least two disadvantages:
1. When replacing the image from the note caption frame by deleting the
existing image add adding a new one (image size will be absolute)
2. The image size will increase when
a) rotating the image
b) copying the image from the caption frame to a new frame. 

Yes, there is a easy workaround: uncheck 'relative width'. But why should I
think of disabling relative width, if I didn't enable it in the first place?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105102] Pasting multiple images to Writer document: doing that at once, causes them to be placed on top of each other

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105102

Buovjaga  changed:

   What|Removed |Added

 CC||tangogolfsie...@gmail.com
Version|5.3.0.3 release |Inherited From OOo

--- Comment #3 from Buovjaga  ---
gentisle: you are describing some other issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105102] Pasting multiple images to Writer document: doing that at once, causes them to be placed on top of each other

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105102

gentisle  changed:

   What|Removed |Added

Version|unspecified |5.3.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105102] Pasting multiple images to Writer document: doing that at once, causes them to be placed on top of each other

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105102

--- Comment #2 from gentisle  ---
Description:
A little more clarity on this one.

Steps to reproduce:
1a. Either copy and paste an image with mouse or keyboard
   or
1b. Scan via the Insert/Media/Scan/Request menu
   Then
2. click to the right of image to deselect it.
3. Press 'enter' key.

If user adds empty lines after the point where he/she WILL paste an image, then
moves the cursor back up and pastes the image, Writer adds header/footer.

Actual Results:
Cursor instead moves to precede image that was just pasted/scanned.
Subsequent use of 'enter' key moves the cursor down the side of the image until
it is below the image.

Expected Results:
That it will work like OpenOffice 3.2.1 and paste images in subsequent
pasting/scanning order.

Reproducible:
Always in 5.3.03, 5.3.2, 4.4.3 versions in Win 7/64 WinXP/32, 5.0.3.2 Linux
amd64/Linuxmint 17.3KDE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105811] Enhancement to CELL() function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105811

Carlos  changed:

   What|Removed |Added

Summary|Enhancement to Cell()   |Enhancement to CELL()
   |function|function

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106999] Add feedback behaviour to style applying UNO commands, so that style is marked in menu and toolbar, when in use in text with focus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106999

Thomas Lendo  changed:

   What|Removed |Added

Summary|Add feedback behaviour to   |Add feedback behaviour to
   |style applying UNO  |style applying UNO
   |commands, so that style is  |commands, so that style is
   |marked in menu, when in use |marked in menu and toolbar,
   |in text with focus  |when in use in text with
   ||focus

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90433] HYPERLINK() function, if present but not evaluated, wrongly forces cell to pretend being linked.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90433

Carlos  changed:

   What|Removed |Added

Summary|HYPERLINK function, if  |HYPERLINK() function, if
   |present but not evaluated,  |present but not evaluated,
   |wrongly forces cell to  |wrongly forces cell to
   |pretend being linked.   |pretend being linked.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 73078] Function TYPE() returns error, when parameter is a reference to an empty cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=73078

Carlos  changed:

   What|Removed |Added

Summary|Function TYPE returns   |Function TYPE() returns
   |error, when parameter is a  |error, when parameter is a
   |reference to an empty cell  |reference to an empty cell

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102939] freeze cells not operating properly with multiple sheets selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102939

Carlos  changed:

   What|Removed |Added

Summary|freeze cells function not   |freeze cells not operating
   |operating properly with |properly with multiple
   |multiple sheets selected|sheets selected

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102939] freeze cells not operating properly with multiple sheets selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102939

Carlos  changed:

   What|Removed |Added

Summary|freeze cells function not   |freeze cells not operating
   |operating properly with |properly with multiple
   |multiple sheets selected|sheets selected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107019] EMF+ EmfPlusRecordTypeDrawBeziers is not implemented

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107019

Bartosz  changed:

   What|Removed |Added

 CC||gan...@poczta.onet.pl
   Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107019] EMF+ EmfPlusRecordTypeDrawBeziers is not implemented

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107019

Bartosz  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107019] EMF+ EmfPlusRecordTypeDrawBeziers is not implemented

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107019

--- Comment #1 from Bartosz  ---
Created attachment 132401
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132401=edit
File on which curve is not displayed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107019] New: EMF+ EmfPlusRecordTypeDrawBeziers is not implemented

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107019

Bug ID: 107019
   Summary: EMF+ EmfPlusRecordTypeDrawBeziers is not implemented
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gan...@poczta.onet.pl

Description:
The EmfPlusRecordTypeDrawBeziers record for EMF+ is not implemented.

Steps to Reproduce:
1. Drag and drop attached EMF file in Writer

Actual Results:  
Curve is not appearing in chart

Expected Results:
Curve is appearing in chart


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Ubuntu Chromium/56.0.2924.76 Chrome/56.0.2924.76 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97101] Add a SPLIT() function for separating string cells based on a delimiter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97101

Carlos  changed:

   What|Removed |Added

Summary|Add a split function for|Add a SPLIT() function for
   |separating sting cells  |separating string cells
   |based on a delimiter|based on a delimiter

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 36574] [FORMATTING] Can' t make default Writer bullet types locale dependent (french bullets / dash bullets)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=36574

--- Comment #26 from peterpan  ---
(In reply to Mikhail Krasilnikov from comment #25)
> I run into this issue when trying to create template with company style for
> our employees. Most of them don't now (and don't want to know) how to set
> hot keys. When they need list, they just click icon on toolbar. So I need a
> way to change style for lists, created by pressing these icons.

And that is exactly also my point. Thank you for formulating it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88490] function CELL() errors - date, currency, coord InfoType

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88490

Carlos  changed:

   What|Removed |Added

Summary|function CELL errors -  |function CELL() errors -
   |date, currency,coord|date, currency,coord
   |InfoType|InfoType

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85986] CELL() Function does not re-evaluate a change in sheet name.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85986

Carlos  changed:

   What|Removed |Added

Summary|CELL Function does not  |CELL() Function does not
   |re-evaluate a change in |re-evaluate a change in
   |sheet name. |sheet name.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106151] Add a new CELL() function for Excel compatibility

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106151

Carlos  changed:

   What|Removed |Added

Summary|Add a new CELL function for |Add a new CELL() function
   |Excel compatibility |for Excel compatibility

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Crash test update

[Crashtest VM]

New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/d3099d03d5302303b9b7a3c29093455ff58be1ae/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'feature/table_rotated_text' - 2 commits - oox/source sd/qa svx/source

[Tamás Zolnai]

 oox/source/drawingml/table/tablecell.cxx |7 
 sd/qa/unit/data/pptx/tdf100926.pptx  |binary
 sd/qa/unit/import-tests.cxx  |   28 +++
 svx/source/table/cell.cxx|   44 +++
 4 files changed, 79 insertions(+)

New commits:
commit 15e1a8c5caa2da21e820fc3c1f20dc5490e1986f
Author: Tamás Zolnai 
Date:   Fri Apr 7 14:17:57 2017 +0200

tdf#100926: PPTX import of table with rotated text

Change-Id: I05a8e979ac11b179e15784023032a56edc5b569b

diff --git a/oox/source/drawingml/table/tablecell.cxx 
b/oox/source/drawingml/table/tablecell.cxx
index 1c0d08616599..2501a6cd2d45 100644
--- a/oox/source/drawingml/table/tablecell.cxx
+++ b/oox/source/drawingml/table/tablecell.cxx
@@ -467,6 +467,13 @@ void TableCell::pushToXCell( const 
::oox::core::XmlFilterBase& rFilterBase, cons
 }
 
 getTextBody()->insertAt( rFilterBase, xText, xAt, aTextStyleProps, 
pMasterTextListStyle );
+
+if (getVertToken() == XML_vert)
+xPropSet->setPropertyValue("RotateAngle", Any(short(27000)));
+else if (getVertToken() == XML_vert270)
+xPropSet->setPropertyValue("RotateAngle", Any(short(9000)));
+else
+xPropSet->setPropertyValue("RotateAngle", Any(short(0)));
 }
 
 } } }
diff --git a/sd/qa/unit/data/pptx/tdf100926.pptx 
b/sd/qa/unit/data/pptx/tdf100926.pptx
new file mode 100755
index ..71627394ec84
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf100926.pptx differ
diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index f45ae187d0db..881a43de6928 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -145,6 +145,7 @@ public:
 void testTdf104445();
 void testTdf105150();
 void testTdf105150PPT();
+void testTdf100926();
 
 bool checkPattern(sd::DrawDocShellRef& rDocRef, int nShapeNumber, 
std::vector& rExpected);
 void testPatternImport();
@@ -210,6 +211,7 @@ public:
 CPPUNIT_TEST(testTdf104445);
 CPPUNIT_TEST(testTdf105150);
 CPPUNIT_TEST(testTdf105150PPT);
+CPPUNIT_TEST(testTdf100926);
 CPPUNIT_TEST(testPatternImport);
 
 CPPUNIT_TEST_SUITE_END();
@@ -2189,6 +2191,32 @@ void SdImportTest::testPatternImport()
 xDocRef->DoClose();
 }
 
+void SdImportTest::testTdf100926()
+{
+sd::DrawDocShellRef xDocShRef = 
loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/pptx/tdf100926.pptx"), 
PPTX);
+const SdrPage* pPage = GetPage(1, xDocShRef);
+CPPUNIT_ASSERT(pPage != nullptr);
+
+sdr::table::SdrTableObj *pTableObj = 
dynamic_cast(pPage->GetObj(0));
+CPPUNIT_ASSERT(pTableObj != nullptr);
+uno::Reference< table::XCellRange > xTable(pTableObj->getTable(), 
uno::UNO_QUERY_THROW);
+
+sal_Int32 nRotation = 0;
+uno::Reference< beans::XPropertySet > xCell(xTable->getCellByPosition(0, 
0), uno::UNO_QUERY_THROW);
+xCell->getPropertyValue("RotateAngle") >>= nRotation;
+CPPUNIT_ASSERT_EQUAL(sal_Int32(27000), nRotation);
+
+xCell.set(xTable->getCellByPosition(1, 0), uno::UNO_QUERY_THROW);
+xCell->getPropertyValue("RotateAngle") >>= nRotation;
+CPPUNIT_ASSERT_EQUAL(sal_Int32(9000), nRotation);
+
+xCell.set(xTable->getCellByPosition(2, 0), uno::UNO_QUERY_THROW);
+xCell->getPropertyValue("RotateAngle") >>= nRotation;
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), nRotation);
+
+xDocShRef->DoClose();
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SdImportTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx
index ae4daa76affa..3096ee6948aa 100644
--- a/svx/source/table/cell.cxx
+++ b/svx/source/table/cell.cxx
@@ -334,6 +334,22 @@ namespace sdr
 const SvxTextRotateItem* pRotateItem = static_cast(pNewItem);
 SdrTextObj& rObj = static_cast(GetSdrObject());
 rObj.SetVerticalWriting(pRotateItem->IsVertical(), true, 
pRotateItem->IsTopToBottom());
+
+// Set a cell vertical property
+OutlinerParaObject* pParaObj = 
mxCell->GetEditOutlinerParaObject();
+
+const bool bOwnParaObj = pParaObj != nullptr;
+
+if (pParaObj == nullptr)
+pParaObj = mxCell->GetOutlinerParaObject();
+
+if (pParaObj)
+{
+pParaObj->SetVertical(pRotateItem->IsVertical(), 
pRotateItem->IsTopToBottom());
+
+if (bOwnParaObj)
+delete pParaObj;
+}
 }
 
 // call parent
commit 76651ebf109d6841240a1d90f708893106d148d9
Author: Tamás Zolnai 
Date:   Thu Apr 6 22:22:53 2017 +0200

Implement RotateAngle API property for Impress table cells

Change-Id: I01379c0fc21e8fe294bc882bf824f64502863ff4

diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx
index ead3e2ab3d78..ae4daa76affa 100644
--- 

[Libreoffice-bugs] [Bug 102286] Crash in: SwWrtShell:: CalcAndSetScal - in Writer paste table from Calc multiple times using autocaption (steps in comment 6)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102286

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106732] Autocaption shows Other OLE Objects instead of Spreadsheet, Draw, etc.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106732

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #7 from Caolán McNamara  ---
I think this will work now

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102286] Crash in: SwWrtShell:: CalcAndSetScal - in Writer paste table from Calc multiple times using autocaption (steps in comment 6)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102286

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106732] Autocaption shows Other OLE Objects instead of Spreadsheet, Draw, etc.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106732

--- Comment #6 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a7d008a8dfdc0a8b42061329b5e756b1b034abaf

Resolves: tdf#106732 the intent was surely to return a const ref

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102286] Crash in: SwWrtShell:: CalcAndSetScal - in Writer paste table from Calc multiple times using autocaption (steps in comment 6)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102286

--- Comment #12 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5ce387c4812466e6752b434cf0f5a54f98c6a147

Resolves: tdf#102286 lets not crash on null pFrame

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106732] Autocaption shows Other OLE Objects instead of Spreadsheet, Draw, etc.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106732

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 7 commits - dbaccess/source dbaccess/uiconfig dbaccess/UIConfig_dbaccess.mk include/svtools sw/source vcl/source

[Caolán McNamara]

 dbaccess/UIConfig_dbaccess.mk |1 
 dbaccess/source/ui/browser/sbagrid.cxx|   23 ++
 dbaccess/source/ui/browser/sbagrid.src|   64 +-
 dbaccess/source/ui/inc/dbu_resource.hrc   |   12 +--
 dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx |   18 +
 dbaccess/source/ui/querydesign/query.src  |   23 --
 dbaccess/source/ui/tabledesign/TEditControl.cxx   |   13 +--
 dbaccess/uiconfig/ui/querycolmenu.ui  |   31 
 include/svtools/insdlg.hxx|2 
 sw/source/core/frmedt/fews.cxx|   13 ++-
 vcl/source/gdi/svgdata.cxx|8 +-
 11 files changed, 95 insertions(+), 113 deletions(-)

New commits:
commit 5ce387c4812466e6752b434cf0f5a54f98c6a147
Author: Caolán McNamara 
Date:   Fri Apr 7 16:55:37 2017 +0100

Resolves: tdf#102286 lets not crash on null pFrame

this is the FlyEmbeddedPrt case

ensure we don't end up with a null pFrame at return time

Change-Id: I68ff6f0a36462cffc47d774865e69041c4dd15a8

diff --git a/sw/source/core/frmedt/fews.cxx b/sw/source/core/frmedt/fews.cxx
index 473c324b0b39..44384a5a9ec2 100644
--- a/sw/source/core/frmedt/fews.cxx
+++ b/sw/source/core/frmedt/fews.cxx
@@ -125,12 +125,14 @@ const SwRect& SwFEShell::GetAnyCurRect( CurRectType 
eType, const Point* pPt,
 bFrame = false;
 SAL_FALLTHROUGH;
 case CurRectType::FlyEmbedded:
-pFrame = xObj.is() ? FindFlyFrame( xObj )
+{
+const SwFrame *pFlyFrame = xObj.is() ? 
FindFlyFrame(xObj) : nullptr;
+pFrame = pFlyFrame ? pFlyFrame
 : pFrame->IsFlyFrame()
 ? pFrame
 : pFrame->FindFlyFrame();
 break;
-
+}
 case CurRectType::SectionOutsideTable :
 if( pFrame->IsInTab() )
 pFrame = pFrame->FindTabFrame();
commit a7d008a8dfdc0a8b42061329b5e756b1b034abaf
Author: Caolán McNamara 
Date:   Fri Apr 7 16:18:22 2017 +0100

Resolves: tdf#106732 the intent was surely to return a const ref

Change-Id: Iaaa1f76a689645adaebf4fe5b87003ad238f71f2

diff --git a/include/svtools/insdlg.hxx b/include/svtools/insdlg.hxx
index 5e18693663b3..58bada8fadd2 100644
--- a/include/svtools/insdlg.hxx
+++ b/include/svtools/insdlg.hxx
@@ -60,7 +60,7 @@ public:
 return aObjectServerList.size();
 }
 
-const SvObjectServeroperator[]( size_t n ) const
+const SvObjectServer&   operator[]( size_t n ) const
 {
 return aObjectServerList[ n ];
 }
commit ebd43aee5b9cf98ed96ce28985267ad0bc980b7a
Author: Caolán McNamara 
Date:   Fri Apr 7 13:41:38 2017 +0100

rework setting hidden property on line break

to avoid the assert in InsertItem, I guess that was the wrong way
to do it then.

Change-Id: Icd30ced1d2598ec42d3e5f555360f5d2377515c1

diff --git a/sw/source/core/frmedt/fews.cxx b/sw/source/core/frmedt/fews.cxx
index 6cd9d88a398a..473c324b0b39 100644
--- a/sw/source/core/frmedt/fews.cxx
+++ b/sw/source/core/frmedt/fews.cxx
@@ -494,12 +494,11 @@ void SwFEShell::InsertLabel( const SwLabelType eType, 
const OUString , con
 
 aAnc.SetAnchor();
 
-SfxItemSet 
aSet(makeItemSetFromFormatAnchor(GetDoc()->GetAttrPool(), aAnc));
-
 SwFlyFrame *pFly = GetSelectedOrCurrFlyFrame();
 OSL_ENSURE(pFly, "SetFlyFrameAttr, no Fly selected.");
 if (pFly)
 {
+SfxItemSet 
aSet(makeItemSetFromFormatAnchor(GetDoc()->GetAttrPool(), aAnc));
 SwFlyFrameFormat* pInnerFlyFormat = pFly->GetFormat();
 GetDoc()->SetFlyFrameAttr(*pInnerFlyFormat, aSet);
 }
@@ -513,7 +512,9 @@ void SwFEShell::InsertLabel( const SwLabelType eType, const 
OUString , con
 //the next line, pushing the caption text out of
 //the frame making the caption apparently disappear
 SvxCharHiddenItem aHidden(true, RES_CHRATR_HIDDEN);
-pTextNode->InsertItem(aHidden, nIndex, nIndex + 1);
+SfxItemSet aSet(GetDoc()->GetAttrPool(), aHidden.Which(), 
aHidden.Which());
+aSet.Put(aHidden);
+pTextNode->SetAttr(aSet, nIndex, nIndex + 1);
 }
 }
 
commit 3e1977abc648a0b30be7af3c10060938de1b143f
Author: 

[Libreoffice-bugs] [Bug 36574] [FORMATTING] Can' t make default Writer bullet types locale dependent (french bullets / dash bullets)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=36574

--- Comment #25 from Mikhail Krasilnikov  ---
I run into this issue when trying to create template with company style for our
employees. Most of them don't now (and don't want to know) how to set hot keys.
When they need list, they just click icon on toolbar. So I need a way to change
style for lists, created by pressing these icons.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - svx/inc svx/source

[Marco Cecchetti]

 svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx|2 ++
 svx/source/sdr/contact/viewcontactofsdrole2obj.cxx |7 ++-
 2 files changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 695d36f31cf3d56f97ef04e8503854ebb9e57846
Author: Marco Cecchetti 
Date:   Fri Apr 7 11:58:52 2017 +0200

LOK - Calc: charts are misplaced

We need to update the transformation primitive wrapping the chart when
the grid offset is changed.

Change-Id: I42179fdc7cc806c5757a125881f08279767ccbcc
Reviewed-on: https://gerrit.libreoffice.org/36257
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx 
b/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx
index 8d94c6115aa6..a00b95b1661d 100644
--- a/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx
+++ b/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx
@@ -33,6 +33,8 @@ class ViewContactOfSdrOle2Obj : public ViewContactOfSdrRectObj
 private:
 // #i123539# allow local buffering of chart data (if chart)
 drawinglayer::primitive2d::Primitive2DReference mxChartContent;
+// used to check if we need to re-calc the transformation
+Point maGridOffset;
 
 protected:
 // Create a Object-Specific ViewObjectContact, set ViewContact and
diff --git a/svx/source/sdr/contact/viewcontactofsdrole2obj.cxx 
b/svx/source/sdr/contact/viewcontactofsdrole2obj.cxx
index 630c869a43c8..6c05ce59ef9b 100644
--- a/svx/source/sdr/contact/viewcontactofsdrole2obj.cxx
+++ b/svx/source/sdr/contact/viewcontactofsdrole2obj.cxx
@@ -100,12 +100,17 @@ drawinglayer::primitive2d::Primitive2DContainer 
ViewContactOfSdrOle2Obj::createP
 // #i123539# allow buffering and reuse of local chart data to not need 
to rebuild it
 // on every ViewObjectContact::getPrimitive2DSequence call. : Not 
needed for
 // aw080, there this mechanism alraedy works differently
-if(mxChartContent.is())
+if(mxChartContent.is()
+// check if we need to update the transformation primitive 
wrapping the chart
+&& maGridOffset == GetOle2Obj().GetGridOffset())
 {
 xContent = mxChartContent;
 }
 else
 {
+// update grid offset
+const_cast< ViewContactOfSdrOle2Obj* >(this)->maGridOffset = 
GetOle2Obj().GetGridOffset();
+
 // try to get chart primitives and chart range directly from 
xChartModel
 basegfx::B2DRange aChartContentRange;
 const drawinglayer::primitive2d::Primitive2DContainer 
aChartSequence(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/inc svx/source

[Marco Cecchetti]

 svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx|2 ++
 svx/source/sdr/contact/viewcontactofsdrole2obj.cxx |7 ++-
 2 files changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 5991304ede33b112b7700b2b9f0e18f6c523a0e8
Author: Marco Cecchetti 
Date:   Fri Apr 7 11:58:52 2017 +0200

LOK - Calc: charts are misplaced

We need to update the transformation primitive wrapping the chart when
the grid offset is changed.

Change-Id: I42179fdc7cc806c5757a125881f08279767ccbcc
Reviewed-on: https://gerrit.libreoffice.org/36255
Tested-by: Jenkins 
Reviewed-by: Jan Holesovsky 

diff --git a/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx 
b/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx
index 8d94c6115aa6..a00b95b1661d 100644
--- a/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx
+++ b/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx
@@ -33,6 +33,8 @@ class ViewContactOfSdrOle2Obj : public ViewContactOfSdrRectObj
 private:
 // #i123539# allow local buffering of chart data (if chart)
 drawinglayer::primitive2d::Primitive2DReference mxChartContent;
+// used to check if we need to re-calc the transformation
+Point maGridOffset;
 
 protected:
 // Create a Object-Specific ViewObjectContact, set ViewContact and
diff --git a/svx/source/sdr/contact/viewcontactofsdrole2obj.cxx 
b/svx/source/sdr/contact/viewcontactofsdrole2obj.cxx
index 874b982c1dbf..d70b9b48761a 100644
--- a/svx/source/sdr/contact/viewcontactofsdrole2obj.cxx
+++ b/svx/source/sdr/contact/viewcontactofsdrole2obj.cxx
@@ -100,12 +100,17 @@ drawinglayer::primitive2d::Primitive2DContainer 
ViewContactOfSdrOle2Obj::createP
 // #i123539# allow buffering and reuse of local chart data to not need 
to rebuild it
 // on every ViewObjectContact::getPrimitive2DSequence call. : Not 
needed for
 // aw080, there this mechanism alraedy works differently
-if(mxChartContent.is())
+if(mxChartContent.is()
+// check if we need to update the transformation primitive 
wrapping the chart
+&& maGridOffset == GetOle2Obj().GetGridOffset())
 {
 xContent = mxChartContent;
 }
 else
 {
+// update grid offset
+const_cast< ViewContactOfSdrOle2Obj* >(this)->maGridOffset = 
GetOle2Obj().GetGridOffset();
+
 // try to get chart primitives and chart range directly from 
xChartModel
 basegfx::B2DRange aChartContentRange;
 const drawinglayer::primitive2d::Primitive2DContainer 
aChartSequence(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 83071] UI: User interface for outline numbering is confusing with possibilities offered both at Format >Paragraph ... Outline numbering and at Tools>Outline numbering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83071

Cor Nouws  changed:

   What|Removed |Added

Summary|UI: User interface for  |UI: User interface for
   |outline numbering is|outline numbering is
   |confusing   |confusing with
   ||possibilities offered both
   ||at Format>Paragraph ...
   ||Outline numbering and at
   ||Tools>Outline numbering

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 83071] UI: User interface for outline numbering is confusing with possibilities offered both at Format >Paragraph ... Outline numbering and at Tools>Outline numbering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83071

Cor Nouws  changed:

   What|Removed |Added

Summary|UI: User interface for  |UI: User interface for
   |outline numbering is|outline numbering is
   |confusing   |confusing with
   ||possibilities offered both
   ||at Format>Paragraph ...
   ||Outline numbering and at
   ||Tools>Outline numbering

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106111] Display, PDF, print and print preview broken for all spreadsheets with line breaks ( 5.3 regression) (steps in comment 40)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106111

--- Comment #41 from Volga  ---
What happened if you print with PDFCreator?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107003] EDITING: Gallery image will increase in size when rotation it after adding a note caption

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107003

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
Same as in other bug report. First disable relative width before doing any
changes to the image itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47849] EDITING: Spell & grammar check "seems" it isn't working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47849

agenceli...@gmail.com changed:

   What|Removed |Added

Version|5.1.4.2 release |5.2.6.2 release

--- Comment #18 from agenceli...@gmail.com ---
Spellcheck does not work. It is sluggish - taking more than 1.5 minutes when
commanded to ignore. After a couple of episodes of this behaviour I thought it
was working but it is not. It only goes through the motions. Does not ignore or
add to dictionary; when "correcting" it goes through the motions but makes no
correction. I am uncertain as to whether the program is actually saving any
changes because spellcheck made LO crash & the reopened version had no
corrections/changes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sfx2/source

[Caolán McNamara]

 sfx2/source/control/unoctitm.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 66f8067f8e7b159a293c2d9320291251167d59e7
Author: Caolán McNamara 
Date:   Fri Dec 16 15:24:22 2016 +

-Werror=maybe-unintialized

Change-Id: I73eb58e44c00d5e1cfcabe71f2ba946a81a62fa7

diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx
index 10df8e1f08dd..43bc6aa47882 100644
--- a/sfx2/source/control/unoctitm.cxx
+++ b/sfx2/source/control/unoctitm.cxx
@@ -1113,10 +1113,10 @@ static void InterceptLOKStateChangeEvent(const 
SfxViewFrame* pViewFrame, const c
 }
 else if (aEvent.FeatureURL.Path == "ToggleMergeCells")
 {
-if (aEvent.IsEnabled)
+sal_Bool aBool;
+
+if (aEvent.IsEnabled && (aEvent.State >>= aBool))
 {
-sal_Bool aBool;
-aEvent.State >>= aBool;
 aBuffer.append(OUString::boolean(aBool));
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 57337] FORMATTING: Impossible to configure the default bullet styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57337

Cor Nouws  changed:

   What|Removed |Added

   Priority|high|medium
Summary|FORMATTING: Configurable|FORMATTING: Impossible to
   |Default Bullet Styles   |configure the default
   ||bullet styles

--- Comment #7 from Cor Nouws  ---
work around, not chique of course, is to add one paragraph in the file with the
changed default bullet/number. That makes that it is saved in the file too ..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 36574] [FORMATTING] Can' t make default Writer bullet types locale dependent (french bullets / dash bullets)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=36574

Cor Nouws  changed:

   What|Removed |Added

   Priority|high|medium
Summary|[FORMATTING] Can't set  |[FORMATTING] Can't make
   |default Writer bullet type  |default Writer bullet types
   |/ french bullets / dash |locale dependent (french
   |bullets |bullets / dash bullets)

--- Comment #24 from Cor Nouws  ---
work around, not chique of course, is to add one paragraph in the file with the
changed default bullet/number. That makes that it is saved in the file too ..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84467] Searching for font size does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84467

--- Comment #8 from Axel Niedenhoff  ---
Yes, this is still the same for LO 5.3.2. (Tested with Linux 64 bit.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106990] font rendering got worse looking in 5.3.2.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106990

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0
 Whiteboard||needsWin7

--- Comment #25 from V Stuart Foote  ---
(In reply to Andy from comment #24)
> Are you sure you have checked impress FULL SCREEN rendering?? tha one you're
> showing seems to be a windowed display. I do not remember perfectly, but I
> did not notice the thing immediately while editing the slides, but only when
> starting the full screen presentation... Thus the non-full screen display
> was probably not so different for me too. Please check that the good results
> you're getting are the same when going full screen too..

On this Windows 7 sp1 32-bit VM, in Presentation mode there no difference
between font rendering of the 5.3.1 and 5.3.2 builds with OpenGL rendering, GPU
Hardware acceleration, or CPU only rendering.

Continue to be unable to confirm, the Harfbuzz based font rendering works for
me.

You could try driver update for your Intel HD GPU, beyond that -> UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - 7 commits - filter/source

[Rohan Kumar]

 filter/source/svg/presentation_engine.js |  722 +++
 1 file changed, 641 insertions(+), 81 deletions(-)

New commits:
commit d000db0eb4e1c6c769b8d383cf0e570ce248c682
Author: Rohan Kumar 
Date:   Sun Mar 12 23:16:30 2017 +0530

tdf#51358 Add Support for more slide transitions to Impress SVG Export

Ported the class WaterfallWipe.

Change-Id: I4856243c4b29e45f16ee780db42c2f742a6b1dc1
Reviewed-on: https://gerrit.libreoffice.org/35107
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/filter/source/svg/presentation_engine.js 
b/filter/source/svg/presentation_engine.js
index 90e3af16263a..48cad273080f 100644
--- a/filter/source/svg/presentation_engine.js
+++ b/filter/source/svg/presentation_engine.js
@@ -5170,6 +5170,7 @@ ZIGZAGWIPE_TRANSITION   = 17; // 10
 BARNZIGZAGWIPE_TRANSITION   = 18; // 11
 FANWIPE_TRANSITION  = 19; // 25
 SINGLESWEEPWIPE_TRANSITION  = 20; // 24
+WATERFALLWIPE_TRANSITION= 21; // 34
 
 aTransitionTypeInMap = {
 'barWipe'   : BARWIPE_TRANSITION,
@@ -5191,7 +5192,8 @@ aTransitionTypeInMap = {
 'irisWipe'  : IRISWIPE_TRANSITION,
 'veeWipe'   : VEEWIPE_TRANSITION,
 'zigZagWipe': ZIGZAGWIPE_TRANSITION,
-'barnZigZagWipe': BARNZIGZAGWIPE_TRANSITION
+'barnZigZagWipe': BARNZIGZAGWIPE_TRANSITION,
+'waterfallWipe' : WATERFALLWIPE_TRANSITION
 };
 
 aTransitionTypeOutMap = [ '', 'barWipe', 'boxWipe', 'fourBoxWipe', 
'ellipseWipe',
@@ -5268,6 +5270,10 @@ CLOCKWISETOPLEFT_TRANS_SUBTYPE  = 59; // 44
 COUNTERCLOCKWISEBOTTOMLEFT_TRANS_SUBTYPE= 60; // 45
 CLOCKWISEBOTTOMRIGHT_TRANS_SUBTYPE  = 61; // 46
 COUNTERCLOCKWISETOPRIGHT_TRANS_SUBTYPE  = 62; // 47
+VERTICALLEFT_TRANS_SUBTYPE  = 63; // 93
+VERTICALRIGHT_TRANS_SUBTYPE = 64; // 94
+HORIZONTALLEFT_TRANS_SUBTYPE= 65; // 95
+HORIZONTALRIGHT_TRANS_SUBTYPE   = 66; // 96
 
 aTransitionSubtypeInMap = {
 'default'   : DEFAULT_TRANS_SUBTYPE,
@@ -5332,7 +5338,11 @@ aTransitionSubtypeInMap = {
 'up': UP_TRANS_SUBTYPE,
 'right' : RIGHT_TRANS_SUBTYPE,
 'diagonalBottomLeft': DIAGONALBOTTOMLEFT_TRANS_SUBTYPE,
-'diagonalTopLeft'   : DIAGONALTOPLEFT_TRANS_SUBTYPE
+'diagonalTopLeft'   : DIAGONALTOPLEFT_TRANS_SUBTYPE,
+'verticalLeft'  : VERTICALLEFT_TRANS_SUBTYPE,
+'verticalRight' : VERTICALRIGHT_TRANS_SUBTYPE,
+'horizontalLeft': HORIZONTALLEFT_TRANS_SUBTYPE,
+'horizontalRight'   : HORIZONTALRIGHT_TRANS_SUBTYPE
 };
 
 aTransitionSubtypeOutMap = [ 'default', 'leftToRight', 'topToBottom', 
'cornersIn',
@@ -5587,6 +5597,48 @@ 
aTransitionInfoTable[BARWIPE_TRANSITION][TOPTOBOTTOM_TRANS_SUBTYPE] =
 'scaleIsotropically' : false
 };
 
+aTransitionInfoTable[WATERFALLWIPE_TRANSITION] = {};
+aTransitionInfoTable[WATERFALLWIPE_TRANSITION][VERTICALLEFT_TRANS_SUBTYPE] =
+{
+'class' : TRANSITION_CLIP_POLYPOLYGON,
+'rotationAngle' : 0.0,
+'scaleX' : 1.0,
+'scaleY' : 1.0,
+'reverseMethod' : REVERSEMETHOD_ROTATE_180,
+'outInvertsSweep' : true,
+'scaleIsotropically' : false
+};
+aTransitionInfoTable[WATERFALLWIPE_TRANSITION][VERTICALRIGHT_TRANS_SUBTYPE] =
+{
+'class' : TRANSITION_CLIP_POLYPOLYGON,
+'rotationAngle' : 0.0,
+'scaleX' : 1.0,
+'scaleY' : 1.0,
+'reverseMethod' : REVERSEMETHOD_ROTATE_180,
+'outInvertsSweep' : true,
+'scaleIsotropically' : false
+};
+aTransitionInfoTable[WATERFALLWIPE_TRANSITION][HORIZONTALLEFT_TRANS_SUBTYPE] =
+{
+'class' : TRANSITION_CLIP_POLYPOLYGON,
+'rotationAngle' : -90.0,
+'scaleX' : 1.0,
+'scaleY' : 1.0,
+'reverseMethod' : REVERSEMETHOD_ROTATE_180,
+'outInvertsSweep' : true,
+'scaleIsotropically' : false
+};
+aTransitionInfoTable[WATERFALLWIPE_TRANSITION][HORIZONTALRIGHT_TRANS_SUBTYPE] =
+{
+'class' : TRANSITION_CLIP_POLYPOLYGON,
+'rotationAngle' : 90.0,
+'scaleX' : 1.0,
+'scaleY' : 1.0,
+'reverseMethod' : REVERSEMETHOD_ROTATE_180,
+'outInvertsSweep' : true,
+'scaleIsotropically' : false
+};
+
 aTransitionInfoTable[BOXWIPE_TRANSITION] = {};
 aTransitionInfoTable[BOXWIPE_TRANSITION][TOPLEFT_TRANS_SUBTYPE] =
 {
@@ -9701,6 +9753,10 @@ function createClipPolyPolygon( nType, nSubtype )
 // flipOnYAxis
 nSubtype == COUNTERCLOCKWISEBOTTOMLEFT_TRANS_SUBTYPE ||
 nSubtype == COUNTERCLOCKWISETOPRIGHT_TRANS_SUBTYPE );
+case WATERFALLWIPE_TRANSITION:
+return new WaterfallWipePath(128, // flipOnYAxis
+  nSubtype == 
VERTICALRIGHT_TRANS_SUBTYPE ||
+  nSubtype == 
HORIZONTALLEFT_TRANS_SUBTYPE);
 case DISSOLVE_TRANSITION:
 return new RandomWipePath( 16 * 16, false /* dissolve */