[Libreoffice-bugs] [Bug 94591] FILEOPEN: ODT - Custom shapes and ellipses not rendered correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=94591 --- Comment #7 from krishna [:kr1shna]--- attachment 119111 blank document lo viewer v1 lo viewer v4 lo viewer v6 lo viewer v8 lo viewer v10 attachment 119109 repro lo viewer v1 lo viewer v4 lo viewer v6 lo viewer v8 lo viewer v10 os: android 5.1 device: lyf flame 3 [ ls-4001 ] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112201] FILEOPEN: DOCX thesis template with missing name and logo of university on 2nd page
https://bugs.documentfoundation.org/show_bug.cgi?id=112201 bugzilla@mkr.email changed: What|Removed |Added Summary|FILEOPEN: DOCX thesis |FILEOPEN: DOCX thesis |template with missing name |template with missing name |and logo of university on |and logo of university on |2nd and 3rd page|2nd page -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112039] Writer stops responding with high CPU load on opening or editing .DOC with tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=112039 --- Comment #7 from andis.lazd...@gmail.com --- (In reply to Timur from comment #6) > This project is in need of volunteers to bibisect so you may consider to > start with that. Sorry to say, but now it's very problematic due to shortage of time. This test requires at least 15 minutes for a version. I'll try to do it in October. 5.4.1 has other issues so the problems with track changes are rather painful. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78510] FILEOPEN: ODT 1.2 bullet points (in file from Word) in wrong location
https://bugs.documentfoundation.org/show_bug.cgi?id=78510 --- Comment #8 from krishna [:kr1shna]--- repro lo viewer v1 lo viewer v4 lo viewer v6 lo viewer v8 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112144] Help page in mixed language
https://bugs.documentfoundation.org/show_bug.cgi?id=112144 Jean-Baptiste Faurechanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||jbfa...@libreoffice.org Ever confirmed|0 |1 --- Comment #2 from Jean-Baptiste Faure --- Confirmed from comment #2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui | 419 -- 1 file changed, 106 insertions(+), 313 deletions(-) New commits: commit 89c25a02ccf9bd5b4392ffd2d469dbcb4ae94bcb Author: andreas kainzDate: Tue Aug 29 23:49:39 2017 +0200 update notebookbar_groupedbar_full view group sync appearance between writer and calc Change-Id: I7a91e12c0632be4a1dfbc488bcf6397b5219c43f Reviewed-on: https://gerrit.libreoffice.org/41714 Reviewed-by: Yousuf Philips Tested-by: Yousuf Philips diff --git a/sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui b/sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui index 0fec03e9dde2..16b7a6df4513 100644 --- a/sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui +++ b/sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui @@ -2,6 +2,7 @@ + True @@ -5568,57 +5569,20 @@ True vertical - + True False +both-horiz +False - -True -False -both-horiz -False - - -True -False -.uno:Zoom - - -False -True - - - - -False -True -0 - - - - + True False -end -True -icons -False - - -True -False -.uno:ZoomPage - - -False -True - - +.uno:Zoom False -True -1 +True @@ -5629,57 +5593,42 @@ - + True False +icons +False - + True False -icons -False - - -True -False -.uno:ControlCodes - - -False -True - - +
[Libreoffice-ux-advise] [Bug 107158] Groupedbar variant of the Notebookbar for Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=107158 --- Comment #16 from Commit Notification--- andreas kainz committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=342622d51f457c5a7d5026814a323d1deece4681 tdf#107158 Groupedbar variant of the Notebookbar for Calc It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 107158] Groupedbar variant of the Notebookbar for Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=107158 Commit Notificationchanged: What|Removed |Added Whiteboard|target:5.4.0|target:5.4.0 target:6.0.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: officecfg/registry sc/uiconfig sc/UIConfig_scalc.mk
officecfg/registry/data/org/openoffice/Office/UI/Notebookbar.xcu | 22 sc/UIConfig_scalc.mk |2 sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui | 9879 +++ sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui |12664 ++ 4 files changed, 22567 insertions(+) New commits: commit 342622d51f457c5a7d5026814a323d1deece4681 Author: andreas kainzDate: Thu Aug 31 00:19:40 2017 +0200 tdf#107158 Groupedbar variant of the Notebookbar for Calc Change-Id: I8f6a086a0895d54cce6243f65c3f47f7cc4cf50e Reviewed-on: https://gerrit.libreoffice.org/41742 Tested-by: Jenkins Reviewed-by: Yousuf Philips diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Notebookbar.xcu b/officecfg/registry/data/org/openoffice/Office/UI/Notebookbar.xcu index ee8aff0b52a5..f10de902dc00 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/Notebookbar.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/Notebookbar.xcu @@ -83,6 +83,28 @@ false + + +Groupedbar Compact + + +notebookbar_groupedbar_compact.ui + + +false + + + + +Groupedbar Full + + +notebookbar_groupedbar_full.ui + + +false + + Contextual groups diff --git a/sc/UIConfig_scalc.mk b/sc/UIConfig_scalc.mk index bd926ac93dd6..4e03e316669c 100644 --- a/sc/UIConfig_scalc.mk +++ b/sc/UIConfig_scalc.mk @@ -146,6 +146,8 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/scalc,\ sc/uiconfig/scalc/ui/namerangesdialog \ sc/uiconfig/scalc/ui/notebookbar \ sc/uiconfig/scalc/ui/notebookbar_groups \ + sc/uiconfig/scalc/ui/notebookbar_groupedbar_full \ + sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact \ sc/uiconfig/scalc/ui/managenamesdialog \ sc/uiconfig/scalc/ui/mergecellsdialog \ sc/uiconfig/scalc/ui/movecopysheet \ diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui new file mode 100644 index ..f4933e3a4e6a --- /dev/null +++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui @@ -0,0 +1,9879 @@ + + + + + + +True +False + + +True +False +.uno:LeftPara + + + + +True +False +.uno:CenterPara + + + + +True +False +.uno:RightPara + + + + +True +False +.uno:JustifyPara + + + + +True +False + + +True +False +.uno:ExtrusionToggle + + + + +True +False + + + + +True +False +.uno:ExtrusionTiltDown + + + + +True +False +.uno:ExtrusionTiltUp + + + + +True +False +.uno:ExtrusionTiltLeft + + + + +True +False +.uno:ExtrusionTiltRight + + + + +True +False + + +True +False +.uno:ObjectAlignLeft + + + + +True +False +.uno:AlignCenter + + + + +True +False +.uno:ObjectAlignRight + + + + +True +False + + + + +True +False +.uno:AlignUp + + + + +True +False +.uno:AlignMiddle + + + + +True +False +.uno:AlignDown + + + + +True +False + + +True +False +.uno:ToggleAnchorType + + + + +True +False + + + + +True +False +.uno:WrapOff + + + + +True +False +.uno:WrapOn + + + + +True +False +.uno:WrapIdeal + + + + +True +False +.uno:WrapLeft + + + + +True +False +.uno:WrapRight + + + + +True +False +.uno:WrapThrough + + + + +True +False +.uno:WrapThroughTransparent + + + + +True +False +.uno:WrapContour + + + + +True +False +.uno:WrapAnchorOnly + + + + +True +False +.uno:TextWrap + + + + +
[Libreoffice-bugs] [Bug 72608] VIEWING: ODT file open from external storage opens in double-page display by default
https://bugs.documentfoundation.org/show_bug.cgi?id=72608 --- Comment #12 from haim kilov--- Created attachment 136021 --> https://bugs.documentfoundation.org/attachment.cgi?id=136021=edit a one-page file opens on a two-page display on an iMac 27" Mac OS 10.9.5, LO 5.4.0.3 A one-page file still opens in double-page display, although correctly, but with humongous margins on the left and right sides. Please see the attachment (a screenshot of a small one-page file). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61377] Lost characters in PDF rendering of Russian and Latvian with Times font
https://bugs.documentfoundation.org/show_bug.cgi?id=61377 haim kilovchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from haim kilov --- Everything appears to be fine for me. Mac OS 10.9.5. LO 5.4.0.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83513] EDITING: Spellchecker does not underline cyrillic words in English texts
https://bugs.documentfoundation.org/show_bug.cgi?id=83513 --- Comment #14 from haim kilov--- The bug is still there! LO 5.4.0.3, mac OS 10.9.5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75748] FILEOPEN: incorrect display of some numbering styles in .DOC and .DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=75748 Justin Lchanged: What|Removed |Added CC||jl...@mail.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||6541 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106541] FILEOPEN: Top level numbering is not considered in this DOC/ DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=106541 Justin Lchanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=75 ||748 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112220] FILESAVE XLSX: Cell Indent Increases on Each Save
https://bugs.documentfoundation.org/show_bug.cgi?id=112220 Kevin Suochanged: What|Removed |Added Severity|normal |major --- Comment #1 from Kevin Suo --- Increase the importance a little bit as it causes format loss. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112220] New: FILESAVE XLSX: Cell Indent Increases on Each Save
https://bugs.documentfoundation.org/show_bug.cgi?id=112220 Bug ID: 112220 Summary: FILESAVE XLSX: Cell Indent Increases on Each Save Product: LibreOffice Version: 5.3.5.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: suokunl...@126.com Created attachment 136020 --> https://bugs.documentfoundation.org/attachment.cgi?id=136020=edit Test xlsx file The attached xlsx file contains cells with indent text. On each edit and save, the indent value increases. Steps to Reproduce: 1. Open the Attached XLSX. Notice the indent width of the cell values. 2. Do any editing in some blank cells, then save and reopen. 3. Repeat several times. Bug Behaviour: The indent value increases on each save. Expected: The indent value remains the same. Version: 5.3.5.2 Build ID:5.3.5.2-3.fc26 CPU 线程:4; 操作系统:Linux 4.12; UI 渲染:默认; VCL: gtk3; Layout Engine: new; Locale: zh-CN (zh_CN.UTF-8); Calc: group Fedora 26 x64 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75539] DOC import filter mismatch of shape size
https://bugs.documentfoundation.org/show_bug.cgi?id=75539 --- Comment #7 from Justin L--- Other clues pointed to this as the very likely commit for LO 3.6 https://cgit.freedesktop.org/libreoffice/core/commit/?id=5845298e615a599d5edc7c42275b52ae954250e8 author Luboš Luňák 2012-05-28 15:21:10 (GMT) commit 5845298e615a599d5edc7c42275b52ae954250e8 fix horizontal rule width in .doc documents (bnc#757118) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.ColumnHeader.js |8 loleaflet/src/control/Control.RowHeader.js|8 2 files changed, 8 insertions(+), 8 deletions(-) New commits: commit 3b6af443bda99dd8f10b668bbafa5efdceb3d6be Author: Henry CastroDate: Mon Sep 4 20:40:53 2017 -0400 loleaflet: related to tdf#107806 Change-Id: Ifd6bd15538007416747accf7b0ad602292b1195a diff --git a/loleaflet/src/control/Control.ColumnHeader.js b/loleaflet/src/control/Control.ColumnHeader.js index c63a0c83..a9571d25 100644 --- a/loleaflet/src/control/Control.ColumnHeader.js +++ b/loleaflet/src/control/Control.ColumnHeader.js @@ -297,14 +297,14 @@ L.Control.ColumnHeader = L.Control.Header.extend({ if (item.width != distance.x) { var command = { + ColumnWidth: { + type: 'unsigned short', + value: this._map._docLayer.twipsToHMM(Math.max(distance.x, 0)) + }, Column: { type: 'unsigned short', value: item.parentNode && item.parentNode.nextSibling && L.DomUtil.getStyle(item.parentNode.nextSibling, 'display') === 'none' ? item.column + 1 : item.column - }, - Width: { - type: 'unsigned short', - value: Math.max(distance.x, 0) } }; diff --git a/loleaflet/src/control/Control.RowHeader.js b/loleaflet/src/control/Control.RowHeader.js index c582117e..744a99a6 100644 --- a/loleaflet/src/control/Control.RowHeader.js +++ b/loleaflet/src/control/Control.RowHeader.js @@ -271,14 +271,14 @@ L.Control.RowHeader = L.Control.Header.extend({ if (item.height != distance.y) { var command = { + RowHeight: { + type: 'unsigned short', + value: this._map._docLayer.twipsToHMM(Math.max(distance.y, 0)) + }, Row: { type: 'long', value: item.parentNode && item.parentNode.nextSibling && L.DomUtil.getStyle(item.parentNode.nextSibling, 'display') === 'none' ? item.row + 1 : item.row - }, - Height: { - type: 'unsigned short', - value: Math.max(distance.y, 0) } }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112219] FILESAVE: ODT: Chart misplaced after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=112219 Xisco Faulíchanged: What|Removed |Added Keywords||bibisectRequest, regression CC||xiscofa...@libreoffice.org Version|6.0.0.0.alpha0+ Master |5.0 all versions --- Comment #1 from Xisco Faulí --- Reproduced in Version: 4.5.0.0.alpha0+ Build ID: 2851ce5afd0f37764cbbc2c2a9a63c7adc844311 Locale: ca_ES but not in Version: 4.3.0.0.alpha1+ Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112219] New: FILESAVE: ODT: Chart misplaced after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=112219 Bug ID: 112219 Summary: FILESAVE: ODT: Chart misplaced after RT Product: LibreOffice Version: 6.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Steps to reproduce: 1. Open attachment 93604 from bug 74430 2. Save it as .ODT 3. Open the new file Observed behaviour: Chart is shifted down. Reproduced in Version: 6.0.0.0.alpha0+ Build ID: 04d70c0999c716f5465631eca50945915ec607c4 CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group [Bug found by office-interoperability-tools] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/dist
loleaflet/dist/toolbar/toolbar.js |3 +++ 1 file changed, 3 insertions(+) New commits: commit 01dd761750b0fe0ab5a1c0949fc9dd7b67db195f Author: Henry CastroDate: Mon Sep 4 19:16:07 2017 -0400 loleaflet: log when w2ui toolbar is not created Change-Id: I9f8f50b628028f9f5541aa97f8c2f0ff2e72924d diff --git a/loleaflet/dist/toolbar/toolbar.js b/loleaflet/dist/toolbar/toolbar.js index ef30c422..d69fe1b3 100644 --- a/loleaflet/dist/toolbar/toolbar.js +++ b/loleaflet/dist/toolbar/toolbar.js @@ -722,6 +722,9 @@ $(function () { $('#search-input').off('keypress', onSearchKeyPress).on('keypress', onSearchKeyPress); } }); + if ($('#toolbar-up').children().length === 0) { + console.log('w2ui toolbar is not created'); + } }); var userJoinedPopupMessage = '' + _('%user has joined') + ''; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 4 commits - sc/inc sc/source
sc/inc/document.hxx| 11 ++--- sc/source/core/data/documen2.cxx | 78 ++--- sc/source/core/data/documen3.cxx | 12 ++--- sc/source/core/data/documen4.cxx |4 - sc/source/core/data/documen5.cxx |8 +-- sc/source/core/data/documen6.cxx |4 - sc/source/core/data/documen8.cxx | 28 ++--- sc/source/core/data/documen9.cxx | 28 ++--- sc/source/core/data/document.cxx | 56 +- sc/source/core/data/document10.cxx |2 sc/source/core/data/fillinfo.cxx |4 - 11 files changed, 117 insertions(+), 118 deletions(-) New commits: commit fc61be93c60967bf1d6bcffcada8189016d4530e Author: Tor LillqvistDate: Tue Sep 5 01:12:40 2017 +0300 Prefix one more member of ScDocument: pShell Change-Id: I72f2556f54e1ea4b397f9b21b1d767ae597e6e43 diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index 498ea76b119f..e08378e2242c 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -319,7 +319,7 @@ private: SfxUndoManager* mpUndoManager; ScFieldEditEngine* mpEditEngine; // uses pEditPool from xPoolHelper ScNoteEditEngine* mpNoteEngine; // uses pEditPool from xPoolHelper -SfxObjectShell* pShell; +SfxObjectShell* mpShell; VclPtrpPrinter; VclPtr pVirtualDevice_100th_mm; ScDrawLayer*pDrawLayer; // SdrModel @@ -931,7 +931,7 @@ public: boolSetDdeLinkResultMatrix( size_t nDdePos, const ScMatrixRef& pResults ); SfxBindings*GetViewBindings(); -SfxObjectShell* GetDocumentShell() const{ return pShell; } +SfxObjectShell* GetDocumentShell() const{ return mpShell; } SC_DLLPUBLIC ScDrawLayer* GetDrawLayer() { return pDrawLayer; } SC_DLLPUBLIC const ScDrawLayer* GetDrawLayer() const { return pDrawLayer; } SfxBroadcaster* GetDrawBroadcaster(); // to avoid header diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx index 78cc2a103d05..c54564ddd918 100644 --- a/sc/source/core/data/documen2.cxx +++ b/sc/source/core/data/documen2.cxx @@ -138,7 +138,7 @@ ScDocument::ScDocument( ScDocumentMode eMode, SfxObjectShell* pDocShell ) : mpUndoManager( nullptr ), mpEditEngine( nullptr ), mpNoteEngine( nullptr ), -pShell( pDocShell ), +mpShell( pDocShell ), pPrinter( nullptr ), pVirtualDevice_100th_mm( nullptr ), pDrawLayer( nullptr ), @@ -266,7 +266,7 @@ const sfx2::LinkManager* ScDocument::GetLinkManager() const sc::DocumentLinkManager& ScDocument::GetDocLinkManager() { if (!mpDocLinkMgr) -mpDocLinkMgr.reset(new sc::DocumentLinkManager(pShell)); +mpDocLinkMgr.reset(new sc::DocumentLinkManager(mpShell)); return *mpDocLinkMgr; } @@ -297,7 +297,7 @@ sal_uInt32 ScDocument::GetDocumentID() const const ScDocument* pThis = this; sal_uInt32 nCrc = rtl_crc32( 0, , sizeof(ScDocument*) ); // the this pointer only might not be sufficient -nCrc = rtl_crc32( nCrc, , sizeof(SfxObjectShell*) ); +nCrc = rtl_crc32( nCrc, , sizeof(SfxObjectShell*) ); return nCrc; } @@ -328,16 +328,16 @@ IMPL_LINK_NOARG(ScDocument, TrackTimeHdl, Timer *, void) { aTrackIdle.Start();// try again later } -else if (pShell)// execute +else if (mpShell)// execute { TrackFormulas(); -pShell->Broadcast( SfxHint( SfxHintId::ScDataChanged ) ); +mpShell->Broadcast( SfxHint( SfxHintId::ScDataChanged ) ); // modified... -if (!pShell->IsModified()) +if (!mpShell->IsModified()) { -pShell->SetModified(); +mpShell->SetModified(); SfxBindings* pBindings = GetViewBindings(); if (pBindings) { @@ -977,16 +977,16 @@ sal_uLong ScDocument::TransferTab( ScDocument* pSrcDoc, SCTAB nSrcPos, // 3 => NameBox // 4 => both -if (pSrcDoc->pShell->GetMedium()) +if (pSrcDoc->mpShell->GetMedium()) { -pSrcDoc->maFileURL = pSrcDoc->pShell->GetMedium()->GetURLObject().GetMainURL(INetURLObject::DecodeMechanism::ToIUri); +pSrcDoc->maFileURL = pSrcDoc->mpShell->GetMedium()->GetURLObject().GetMainURL(INetURLObject::DecodeMechanism::ToIUri); // for unsaved files use the title name and adjust during save of file if (pSrcDoc->maFileURL.isEmpty()) -pSrcDoc->maFileURL = pSrcDoc->pShell->GetName(); +pSrcDoc->maFileURL = pSrcDoc->mpShell->GetName(); } else { -pSrcDoc->maFileURL = pSrcDoc->pShell->GetName(); +pSrcDoc->maFileURL =
[Libreoffice-bugs] [Bug 111853] A highlighting change within the textbox is applied but doesn 't show up on screen
https://bugs.documentfoundation.org/show_bug.cgi?id=111853 Terrence Engerchanged: What|Removed |Added Keywords|bibisectRequest |bibisected --- Comment #5 from Terrence Enger --- Working on debian-stretch with xfce desktop in the daily Linux dbgutil bibisect repository, I see that the bug entered LibreOffice somewhere in the 39 commits: commitdates-h -- good 1ab3f526 2017-08-10 368b583b bad 2b43da38 2017-08-11 4e2b4486 Several commits mention editviewoverlay, including 71a8c7a5: editviewoverlay: correct reaction on property change I am removing keyword bibisectRequest and adding keyword bibisected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111853] A highlighting change within the textbox is applied but doesn 't show up on screen
https://bugs.documentfoundation.org/show_bug.cgi?id=111853 Terrence Engerchanged: What|Removed |Added CC||lo_b...@iseries-guru.com --- Comment #4 from Terrence Enger --- Created attachment 136019 --> https://bugs.documentfoundation.org/attachment.cgi?id=136019=edit output from bibisect in daily Linux dbgutil repository -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39560] UI: Columns in Format-Page-Columns-dialog are equalized in some situations
https://bugs.documentfoundation.org/show_bug.cgi?id=39560 --- Comment #12 from Leandro Martín Drudi--- Still reproducible in 5.4.1. 1) Edit page property or create a new page style. 2) Set margin to 0 3) Set Border Spacing to Contents to any value. 4) Set columns to different width. 5) Apply. 6) Edit style or page property and the columns with retorn to the same value. It is a shame that this mistake is still taken as something unimportant. Editing a document becomes very annoying in LibO. Maybe that's why many users have gone to other suites or continue with MS Office. I am sorry but I am very annoyed by this problem that makes me lose a lot of time in editing a file when it should be something simple. I upload a video in Bug 112217. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109253] FONT NAME list: Scrolling through the list causes a crash. " Bad allocation" error message
https://bugs.documentfoundation.org/show_bug.cgi?id=109253 --- Comment #28 from Robert McClure--- This is clearly NOT a font issue, but a memory allocation and de-allocation issue. No font file, however badly put together, should cause a crash. No software should rely on foreign files to be perfect and should always protect itself from bad input. Of course, a lot of software does not do this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112162] Password set disappears after restoring file
https://bugs.documentfoundation.org/show_bug.cgi?id=112162 Aron Budeachanged: What|Removed |Added Keywords||security CC||ba...@caesar.elte.hu --- Comment #3 from Aron Budea --- Does it also happen after killing LibreOffice in task manager, or only after an unexpected shutdown? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra beta - all buttons are blue ("default ")
https://bugs.documentfoundation.org/show_bug.cgi?id=112153 Aron Budeachanged: What|Removed |Added Version|5.4.0.3 release |5.4.1.2 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Aron Budeachanged: What|Removed |Added Depends on||112212 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112212 [Bug 112212] assertion, lstner.cxx:101, "duplicate listener ..." -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39560] UI: Columns in Format-Page-Columns-dialog are equalized in some situations
https://bugs.documentfoundation.org/show_bug.cgi?id=39560 m.a.riosvchanged: What|Removed |Added CC||sanipache...@outlook.com.ar --- Comment #11 from m.a.riosv --- *** Bug 112217 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112217] Page Style: Custom Column Width Is Lost When You Edit
https://bugs.documentfoundation.org/show_bug.cgi?id=112217 m.a.riosvchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |DUPLICATE --- Comment #1 from m.a.riosv --- Looks like a dup of https://bugs.documentfoundation.org/show_bug.cgi?id=39560 If you are not agree please reopen it. *** This bug has been marked as a duplicate of bug 39560 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112212] assertion, lstner.cxx:101, "duplicate listener ..."
https://bugs.documentfoundation.org/show_bug.cgi?id=112212 Aron Budeachanged: What|Removed |Added Blocks||105537 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105537 [Bug 105537] [META] Assertion failed crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112218] Crash in: `anonymous namespace'::ContentIdxStoreImpl:: RestoreBkmks(SwDoc *, std::function &)
https://bugs.documentfoundation.org/show_bug.cgi?id=112218 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- I see you're using LibreOffice 5.3.4.2 Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104742] [META] Network-involved bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=104742 Bug 104742 depends on bug 111876, which changed state. Bug 111876 Summary: Links to Windows shares become corrupted in XLSX after save https://bugs.documentfoundation.org/show_bug.cgi?id=111876 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112218] New: Crash in: `anonymous namespace'::ContentIdxStoreImpl:: RestoreBkmks(SwDoc *, std::function &)
https://bugs.documentfoundation.org/show_bug.cgi?id=112218 Bug ID: 112218 Summary: Crash in: `anonymous namespace'::ContentIdxStoreImpl::RestoreBkmks(SwDoc *,std::function &) Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: a...@holistx.co.uk This bug was filed from the crash reporting server and is br-4484a653-3dd1-4974-8116-8ad16dec19aa. = Problem may be related to the Mendeley Desktop plugin - performance drops as number of citations in document increases and eventually LibreOffice crashes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108496] FILEOPEN: DOCX file numbered list restarted from 1 following section break assumes previous numbered list sequence after 1
https://bugs.documentfoundation.org/show_bug.cgi?id=108496 Bartoszchanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75539] DOC import filter mismatch of shape size
https://bugs.documentfoundation.org/show_bug.cgi?id=75539 Justin Lchanged: What|Removed |Added CC||jl...@mail.com --- Comment #6 from Justin L --- confirmed a still very long looking line shape in LO 6.0dev. Looking at the positioning and size properties it reports being 16cm long, and hitting OK makes it properly sized. Shows up in bibisect-43max as long in 3.6, but as a tiny dot before that. Unfortunately I could not identify the commit that affected the length, since it covers about 1.5 months of commits. # bad: [a71a4447320f177181c9cff9f7c6fd93802cbd8e] source-hash-9afb6e1e38c362a768e8e981f7b03cf8bcaf22cf # good: [894d6fd8932770422f37b8f562717c846fef6a1b] source-hash-61d78aca81f08ac3a0f9eb65799d04d56fbad312 # possible first bad commit: [a71a4447320f177181c9cff9f7c6fd93802cbd8e] source-hash-9afb6e1e38c362a768e8e981f7b03cf8bcaf22cf # possible first bad commit: [c6a69c23e32b372e1f279f1a5ea6aa0a6cf52968] source-hash-cac1f33e839469d884730350e46a21d92fb442f2 # possible first bad commit: [1273b9e25faacf414c611503c2a11283af274044] source-hash-cf04745f7a027594fd64a493c276a8280dbccfe1 # possible first bad commit: [0a0d80b18dc905ee56faaad81c2d6839f8e0172d] source-hash-4ba8147f61fadb4e8ae7abc0ad5c9e928edf4baa # possible first bad commit: [2cb4591ac9908e86e6e0844714ce74f2c5f0d813] source-hash-8201c8a5f680947c2e855504be321afb1e5bc06a # possible first bad commit: [ef67f79d5c082070b3185286da0bacd714bb61b4] source-hash-099198a4224778fe6e43f5dc13b5b9b1b4dc828c # possible first bad commit: [e4c742a9e244bd7ebeabc50c90182df28ac3daaf] source-hash-c52ba433491afbca70aa1977a624c795bdd5b9ef # possible first bad commit: [aed6d9e275e4560aa251d23dd7ba6a0a725afab7] source-hash-c77918bb03974ff9be90c889f77e62ea0755052f # possible first bad commit: [638cb54cb50a2b1269009db83f70792cf5076abc] source-hash-877c96a601e6e50d0c7a8f704d57baec22f089c5 # possible first bad commit: [e87a0055deae2c9e25ae1d1a365cec8418b785ce] source-hash-67ff63988f3b8eef2cc2b5bdf917918b93c3f070 # possible first bad commit: [5b4693bb72eca5e38e3f56d036bca425c9a21b37] source-hash-e3633f60b349022994e291aa3d1a0c90c3403b2e # possible first bad commit: [d101b9946a6a04e65e3923038503436c790b7e12] source-hash-18e6e7d929c2be209407ed2e56b8ec4d5e6c4900 # possible first bad commit: [96a055e15ee7171a2973a3c3a7307dd9867f] source-hash-9ca02a663c3eee2698eb360dd5dc7afb1951e743 # possible first bad commit: [113bce8fc413d543d6e00747ebe924e83788f810] source-hash-24c125f4de208e4093198d32e2e3b7faae4470fa # possible first bad commit: [8b099bdbf262cdc405279bb8058b1beb14e3e8f3] source-hash-ef7a460fa51140782b7ad4d87aa782ca007c56ca # possible first bad commit: [74328ea761f699662228f05e71c6214af2abf719] source-hash-35be7d7574cd0f45a18ee5838dd14cb1040890d4 # possible first bad commit: [3e74c2f3e7426e024d76ddb46945fdda53eb695e] source-hash-3a35fd8f1c6b176e675b998a82526636aad5a00b # possible first bad commit: [b2c3b987024faeeabd2e45187cb08b5eee4c4629] source-hash-a90d7788a4b9aca4378cd1660293403db3d399ac # possible first bad commit: [8a39227e344637eb7154a10ac825d211e64d584c] source-hash-f5080ebb7022c9f5d7d7fdca4fe9d19f9bb8cabf # possible first bad commit: [7cbcdae3f616c42e345dc92dfd17c957eecdccb9] source-hash-bb36072c92687a954a38aeca7fb9945f8e7cca13 # possible first bad commit: [b119645386363b75d60215f91775cba82c1c6126] source-hash-3b328186706e6819acfea7b3a6dc8c9d3b6f9693 # possible first bad commit: [09b0c68ed3c0cb7a96ac98146a67e9540df994c8] source-hash-d50f02bec4a70bd26a518e4e76f4a876454ab937 # possible first bad commit: [a0225eee14bbecc662d5e82894b0f7738c75ff23] source-hash-1aa91a2d8e7db5cebff5b47f3005f1acff64d25e # possible first bad commit: [13312242b4c33dfbbf82238d6e47bbefdaf22f32] source-hash-33f5acad371bcf838011b3629450e6dcd405a4e9 # possible first bad commit: [e1ec404400a4c6531a5d49d89631d1acc599071d] source-hash-5708f2bfa70db0479ddbf9b454329cd81e0f509d # possible first bad commit: [54177448b4716be474746c4a676f39d8038caf03] source-hash-fd58025dc7379126738cf73908ec10e809348e6a # possible first bad commit: [d3f11a2232b85bc3ab3e69000f571c0eba1930fd] source-hash-0bbf79005a697c6781047c01f05eb660836a18e1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/dist
loleaflet/dist/toolbar/toolbar.js | 52 +++--- 1 file changed, 26 insertions(+), 26 deletions(-) New commits: commit b53bcf23ae601687fd8996d66e5a2a56d8c21d8e Author: Henry CastroDate: Mon Sep 4 16:52:30 2017 -0400 loleaflet: disable toolbar buttons before the document is loaded Change-Id: Ia6679414f8eab54366a48b1c431ce9384d2dc8ca diff --git a/loleaflet/dist/toolbar/toolbar.js b/loleaflet/dist/toolbar/toolbar.js index e33ad8f7..ef30c422 100644 --- a/loleaflet/dist/toolbar/toolbar.js +++ b/loleaflet/dist/toolbar/toolbar.js @@ -469,18 +469,18 @@ $(function () { ]}, {type: 'button', id: 'save', img: 'save', hint: _('Save')}, {type: 'break', id: 'savebreak'}, - {type: 'button', id: 'undo', img: 'undo', hint: _('Undo'), uno: 'Undo'}, - {type: 'button', id: 'redo', img: 'redo', hint: _('Redo'), uno: 'Redo'}, - {type: 'button', id: 'repair', img: 'repair', hint: _('Document repair')}, + {type: 'button', id: 'undo', img: 'undo', hint: _('Undo'), uno: 'Undo', disabled: true}, + {type: 'button', id: 'redo', img: 'redo', hint: _('Redo'), uno: 'Redo', disabled: true}, + {type: 'button', id: 'repair', img: 'repair', hint: _('Document repair'), disabled: true}, {type: 'break'}, {type: 'html', id: 'styles', html: ''}, {type: 'html', id: 'fonts', html: ''}, {type: 'html', id: 'fontsizes', html: ''}, {type: 'break'}, - {type: 'button', id: 'bold', img: 'bold', hint: _('Bold'), uno: 'Bold'}, - {type: 'button', id: 'italic', img: 'italic', hint: _('Italic'), uno: 'Italic'}, - {type: 'button', id: 'underline', img: 'underline', hint: _('Underline'), uno: 'Underline'}, - {type: 'button', id: 'strikeout', img: 'strikeout', hint: _('Strikeout'), uno: 'Strikeout'}, + {type: 'button', id: 'bold', img: 'bold', hint: _('Bold'), uno: 'Bold', disabled: true}, + {type: 'button', id: 'italic', img: 'italic', hint: _('Italic'), uno: 'Italic', disabled: true}, + {type: 'button', id: 'underline', img: 'underline', hint: _('Underline'), uno: 'Underline', disabled: true}, + {type: 'button', id: 'strikeout', img: 'strikeout', hint: _('Strikeout'), uno: 'Strikeout', disabled: true}, {type: 'break', id: 'formatbreak'}, {type: 'button', id: 'insertfootnote', img: 'insertfootnote', hint: _('Insert Footnote'), uno: 'InsertFootnote' }, {type: 'break' }, @@ -489,29 +489,29 @@ $(function () { {type: 'html', id: 'backcolor-html', html: ''}, {type: 'button', id: 'backcolor', img: 'backcolor', hint: _('Highlighting')}, {type: 'break'}, - {type: 'button', id: 'leftpara', img: 'alignleft', hint: _('Align left'), uno: 'LeftPara', unosheet: 'AlignLeft'}, - {type: 'button', id: 'centerpara', img: 'alignhorizontal', hint: _('Center horizontally'), uno: 'CenterPara', unosheet: 'AlignHorizontalCenter'}, - {type: 'button', id: 'rightpara', img: 'alignright', hint: _('Align right'), uno: 'RightPara', unosheet: 'AlignRight'}, - {type: 'button', id: 'justifypara', img: 'alignblock', hint: _('Justified'), uno: 'JustifyPara', unosheet: ''}, + {type: 'button', id: 'leftpara', img: 'alignleft', hint: _('Align left'), uno: 'LeftPara', unosheet: 'AlignLeft', disabled: true}, + {type: 'button', id: 'centerpara', img: 'alignhorizontal', hint: _('Center horizontally'), uno: 'CenterPara', unosheet: 'AlignHorizontalCenter', disabled: true}, + {type: 'button', id: 'rightpara', img: 'alignright', hint: _('Align right'), uno: 'RightPara', unosheet: 'AlignRight', disabled: true}, + {type: 'button', id: 'justifypara', img: 'alignblock', hint: _('Justified'), uno: 'JustifyPara', unosheet: '', disabled: true}, {type: 'break', id: 'wraptextseparator'}, - {type: 'button', id: 'wraptext', img: 'wraptext', hint: _('Wrap Text'), uno: 'WrapText'}, - {type: 'button', id: 'togglemergecells', img: 'togglemergecells', hint: _('Merge and Center Cells'), uno: 'ToggleMergeCells'}, + {type: 'button', id: 'wraptext', img: 'wraptext', hint: _('Wrap Text'), uno: 'WrapText', disabled: true}, + {type: 'button', id:
[Libreoffice-commits] core.git: 12 commits - cui/inc cui/Library_cui.mk cui/source cui/uiconfig extras/source
cui/Library_cui.mk |1 cui/inc/strings.hrc |3 cui/source/customize/CommandCategoryListBox.cxx | 268 cui/source/customize/SvxMenuConfigPage.cxx | 329 -- cui/source/customize/SvxToolbarConfigPage.cxx | 747 -- cui/source/customize/cfg.cxx| 168 +++-- cui/source/inc/CommandCategoryListBox.hxx | 66 ++ cui/source/inc/SvxConfigPageHelper.hxx |5 cui/source/inc/SvxMenuConfigPage.hxx| 20 cui/source/inc/SvxToolbarConfigPage.hxx | 24 cui/source/inc/cfg.hxx | 55 - cui/uiconfig/ui/customizedialog.ui | 14 cui/uiconfig/ui/menuassignpage.ui | 789 ++-- extras/source/glade/libreoffice-catalog.xml.in |3 14 files changed, 1287 insertions(+), 1205 deletions(-) New commits: commit 6c68f38bc28bb55a4f0d53b8f38957516d3935d1 Author: Muhammet KaraDate: Mon Aug 28 15:19:57 2017 +0300 Make the Modify button functional in the Customize dialog By adding "rename", "change icon", "reset icon", and "restore default command" options to the Modify button at the bottom of the right (toolbar/menu entries) list. Change icon / Reset icon / Restore default command options are not supported in the menu/context menu tabs yet. Change-Id: Iade3d1aca722c7f8eddcadf251b9562c5366d8ad Reviewed-on: https://gerrit.libreoffice.org/41620 Reviewed-by: Katarina Behrens Tested-by: Katarina Behrens diff --git a/cui/source/customize/SvxMenuConfigPage.cxx b/cui/source/customize/SvxMenuConfigPage.cxx index 336e6bbe4ed9..016141184758 100644 --- a/cui/source/customize/SvxMenuConfigPage.cxx +++ b/cui/source/customize/SvxMenuConfigPage.cxx @@ -135,9 +135,18 @@ SvxMenuConfigPage::SvxMenuConfigPage(vcl::Window *pParent, const SfxItemSet& rSe m_pInsertBtn->SetSelectHdl( LINK( this, SvxMenuConfigPage, InsertHdl ) ); +m_pModifyBtn->SetSelectHdl( +LINK( this, SvxMenuConfigPage, ModifyItemHdl ) ); m_pResetBtn->SetClickHdl( LINK( this, SvxMenuConfigPage, ResetMenuHdl ) ); +PopupMenu* pPopup = m_pModifyBtn->GetPopupMenu(); +// These operations are not possible on menus/context menus yet +pPopup->EnableItem( pPopup->GetItemId("changeIcon"), false ); +pPopup->EnableItem( pPopup->GetItemId("resetIcon"), false ); +pPopup->EnableItem( pPopup->GetItemId("restoreItem"), false ); +pPopup->RemoveDisabledEntries(); + if ( !bIsMenuBar ) { // Context menus cannot be added/removed @@ -149,7 +158,6 @@ SvxMenuConfigPage::SvxMenuConfigPage(vcl::Window *pParent, const SfxItemSet& rSe // TODO: Remove this when it is possible to reset menubar menus individually m_pResetBtn->Disable(); } - } SvxMenuConfigPage::~SvxMenuConfigPage() @@ -197,19 +205,19 @@ void SvxMenuConfigPage::UpdateButtonStates() // Disable Up and Down buttons depending on current selection SvTreeListEntry* selection = m_pContentsListBox->GetCurEntry(); -if ( m_pContentsListBox->GetEntryCount() == 0 || selection == nullptr ) -{ -m_pMoveUpButton->Enable( false ); -m_pMoveDownButton->Enable( false ); +bool bIsSeparator = +selection && (static_cast (selection->GetUserData()))->IsSeparator(); +bool bIsValidSelection = +!(m_pContentsListBox->GetEntryCount() == 0 || selection == nullptr); -return; -} +m_pMoveUpButton->Enable( +bIsValidSelection && selection != m_pContentsListBox->First() ); +m_pMoveDownButton->Enable( +bIsValidSelection && selection != m_pContentsListBox->Last() ); -SvTreeListEntry* first = m_pContentsListBox->First(); -SvTreeListEntry* last = m_pContentsListBox->Last(); +m_pRemoveCommandButton->Enable( bIsValidSelection ); -m_pMoveUpButton->Enable( selection != first ); -m_pMoveDownButton->Enable( selection != last ); +m_pModifyBtn->Enable( bIsValidSelection && !bIsSeparator); } void SvxMenuConfigPage::DeleteSelectedTopLevel() @@ -386,6 +394,49 @@ IMPL_LINK( SvxMenuConfigPage, InsertHdl, MenuButton *, pButton, void ) } } +IMPL_LINK( SvxMenuConfigPage, ModifyItemHdl, MenuButton *, pButton, void ) +{ +OString sIdent = pButton->GetCurItemIdent(); + +SAL_WARN("cui.customize", "sIdent: " << sIdent); + +if (sIdent == "renameItem") +{ +SvTreeListEntry* pActEntry = m_pContentsListBox->GetCurEntry(); +SvxConfigEntry* pEntry = +static_cast (pActEntry->GetUserData()); + +OUString aNewName( SvxConfigPageHelper::stripHotKey( pEntry->GetName() ) ); +OUString aDesc = CuiResId( RID_SVXSTR_LABEL_NEW_NAME ); + +VclPtrInstance< SvxNameDialog > pNameDialog( this,
[Libreoffice-bugs] [Bug 76147] Formatting: video in presentation slide is always in front of (on top of) text during slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=76147 --- Comment #7 from Gene Kohlenberg--- I just tested this bug using Version: 5.3.4.2 (x64). The text that is supposed to be in front of the video is still behind the video so that the text does not show. My current computer is running Windows 10 Home. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112217] New: Page Style: Custom Column Width Is Lost When You Edit
https://bugs.documentfoundation.org/show_bug.cgi?id=112217 Bug ID: 112217 Summary: Page Style: Custom Column Width Is Lost When You Edit Product: LibreOffice Version: 5.4.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sanipache...@outlook.com.ar Created attachment 136018 --> https://bugs.documentfoundation.org/attachment.cgi?id=136018=edit Step by step Ste by step: 1) New Style. 2) Margin 0 cm. 3) Borders: 2 cm for margin space. 4) Apply columns of different width. 5) Close Style editor. 5) Edit the style. COLUMNS WIDTH ARE LOST! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: distro-configs/LibreOfficeAndroidX86.conf
distro-configs/LibreOfficeAndroidX86.conf |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 690d7bd3174fb5ccb4c6c2467626ee119eea0453 Author: Christian LohmaierDate: Mon Sep 4 22:31:08 2017 +0200 android: should be i686-linux-android, not i686-linux-androideabi Change-Id: I8042fd656892a627c52d1b02c161594d97976726 diff --git a/distro-configs/LibreOfficeAndroidX86.conf b/distro-configs/LibreOfficeAndroidX86.conf index 62cf17d6adcd..cacd45941ecb 100644 --- a/distro-configs/LibreOfficeAndroidX86.conf +++ b/distro-configs/LibreOfficeAndroidX86.conf @@ -1,4 +1,4 @@ ---host=i686-linux-androideabi +--host=i686-linux-android --disable-cairo-canvas --disable-cups --disable-gstreamer-0-10 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 75458] FILEOPEN DOC: carriage-return-positioned tables not exactly spaced on page same as Word
https://bugs.documentfoundation.org/show_bug.cgi?id=75458 Justin Lchanged: What|Removed |Added Version|4.1.0.4 release |Inherited From OOo Summary|writer 4.2.1.1 changes |FILEOPEN DOC: |formatting of imported Word |carriage-return-positioned |doc |tables not exactly spaced ||on page same as Word --- Comment #6 from Justin L --- The document didn't open properly until 4.1, but it has never opened well. Marking as inherited from OOo. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.Menubar.js | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) New commits: commit a29fa8756dbc9b0686300a0854994bf18b3ea4b6 Author: Henry CastroDate: Mon Sep 4 16:32:24 2017 -0400 loleaflet: add initial menu bar before the document is loaded Change-Id: I9ab7f87e0ad3f4c9ff11670b8a2675d895a9c812 diff --git a/loleaflet/src/control/Control.Menubar.js b/loleaflet/src/control/Control.Menubar.js index 031bbb52..17bc8a64 100644 --- a/loleaflet/src/control/Control.Menubar.js +++ b/loleaflet/src/control/Control.Menubar.js @@ -6,6 +6,12 @@ L.Control.Menubar = L.Control.extend({ // TODO: Some mechanism to stop the need to copy duplicate menus (eg. Help) options: { + initial: [ + {name: _('File'), disabled: true}, + {name: _('Edit'), disabled: true}, + {name: _('View'), disabled: true}, + {name: _('Insert'), disabled: true} + ], text: [ {name: _('File'), id: 'file', type: 'menu', menu: [ {name: _('Save'), id: 'save', type: 'action'}, @@ -298,6 +304,7 @@ L.Control.Menubar = L.Control.extend({ onAdd: function (map) { this._initialized = false; this._menubarCont = L.DomUtil.get('main-menu'); + this._initializeMenu(this.options.initial); map.on('doclayerinit', this._onDocLayerInit, this); map.on('addmenu', this._addMenu, this); @@ -322,6 +329,11 @@ L.Control.Menubar = L.Control.extend({ }, _onDocLayerInit: function() { + // clear initial menu + while (this._menubarCont.hasChildNodes()) { + this._menubarCont.removeChild(this._menubarCont.firstChild); + } + // Add document specific menu var docType = this._map.getDocType(); if (docType === 'text') { @@ -746,7 +758,7 @@ L.Control.Menubar = L.Control.extend({ L.DomUtil.addClass(liItem, 'readonly'); } } - var aItem = L.DomUtil.create('a', '', liItem); + var aItem = L.DomUtil.create('a', menu[i].disabled ? 'disabled' : '', liItem); aItem.innerHTML = menu[i].name; if (menu[i].type === 'menu') { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: comphelper/source
comphelper/source/misc/threadpool.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 662c17fbd2ea72247d6ab94583f505dc242e1e8f Author: Tor LillqvistDate: Mon Sep 4 20:32:38 2017 +0300 We can use thread_local on Windows, too (In some DBG_UTIL code.) Change-Id: I2f09c46186154551bfed5f711bd3b03efbf81053 Reviewed-on: https://gerrit.libreoffice.org/41909 Tested-by: Jenkins Reviewed-by: Tor Lillqvist diff --git a/comphelper/source/misc/threadpool.cxx b/comphelper/source/misc/threadpool.cxx index e67bacb8bd6b..7368544a14b1 100644 --- a/comphelper/source/misc/threadpool.cxx +++ b/comphelper/source/misc/threadpool.cxx @@ -22,7 +22,7 @@ namespace comphelper { /** prevent waiting for a task from inside a task */ -#if defined DBG_UTIL && defined LINUX +#if defined DBG_UTIL && (defined LINUX || defined _WIN32) static thread_local bool gbIsWorkerThread; #endif @@ -55,7 +55,7 @@ public: virtual void execute() override { -#if defined DBG_UTIL && defined LINUX +#if defined DBG_UTIL && (defined LINUX || defined _WIN32) gbIsWorkerThread = true; #endif std::unique_lock< std::mutex > aGuard( mpPool->maMutex ); @@ -215,7 +215,7 @@ ThreadTask *ThreadPool::popWorkLocked( std::unique_lock< std::mutex > & rGuard, void ThreadPool::waitUntilDone(const std::shared_ptr& rTag) { -#if defined DBG_UTIL && defined LINUX +#if defined DBG_UTIL && (defined LINUX || defined _WIN32) assert(!gbIsWorkerThread && "cannot wait for tasks from inside a task"); #endif { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 85740] Some letters missing from table of contents .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=85740 Xisco Faulíchanged: What|Removed |Added Status|NEW |RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |WORKSFORME --- Comment #4 from Xisco Faulí --- I can no longer reproduce it in Version: 6.0.0.0.alpha0+ Build ID: 04d70c0999c716f5465631eca50945915ec607c4 CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group nor in Version: 6.0.0.0.alpha0+ Build ID: 78960ad06faca055a6d97afbc764c902d5d07f6f CPU threads: 1; OS: Windows 6.1; UI render: default; TinderBox: Win-x86@39, Branch:master, Time: 2017-08-30_06:31:19 Locale: es-ES (es_ES); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104524] [META] DOCX Table of Contents (ToC) and Index related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104524 Bug 104524 depends on bug 85740, which changed state. Bug 85740 Summary: Some letters missing from table of contents .docx https://bugs.documentfoundation.org/show_bug.cgi?id=85740 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57589] FILEOPEN - A particular docx has a black background where text should be
https://bugs.documentfoundation.org/show_bug.cgi?id=57589 --- Comment #10 from Xisco Faulí--- Still reproducible in Version: 6.0.0.0.alpha0+ Build ID: 04d70c0999c716f5465631eca50945915ec607c4 CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111850] UI breaks after scrolling somewhere while playing video
https://bugs.documentfoundation.org/show_bug.cgi?id=111850 --- Comment #3 from Caolán McNamara--- I guess X (vs wayland) Looking at playback with the preferred /usr/lib*/gstreamer-1.0/libgstgtksink.so from gstreamer-plugins-bad-free-gtk under GDK_BACKEND=x11 what I see matches that. So seems reproducible anyway which is a good start -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109253] FONT NAME list: Scrolling through the list causes a crash. " Bad allocation" error message
https://bugs.documentfoundation.org/show_bug.cgi?id=109253 --- Comment #27 from Bryan Leech--- Back again. I was confused by this term "commit" - but have used Telesto's link (thank you Telesto) to install the version 6.0.0. . It almost solves the problem. I can scoll through my fonts and not crash - unless I scroll VERY rapidly. This is just an initial response, so yet to be tested by time, but I can live with this if it proves to be consistent with what I have seen just now. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112162] Password set disappears after restoring file
https://bugs.documentfoundation.org/show_bug.cgi?id=112162 Jean-Baptiste Faurechanged: What|Removed |Added CC||jbfa...@libreoffice.org --- Comment #2 from Jean-Baptiste Faure --- The main bug is shutting down the computer without saving. What file format are you using for your documents ? Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104527] [META] DOC bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104527 Bug 104527 depends on bug 73629, which changed state. Bug 73629 Summary: FILEOPEN: paragraph contextual spacing issue (with numbered list..) in .doc and docx https://bugs.documentfoundation.org/show_bug.cgi?id=73629 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Bug 103182 depends on bug 111483, which changed state. Bug 111483 Summary: FILEOPEN: Ole object not displayed (gtk3) https://bugs.documentfoundation.org/show_bug.cgi?id=111483 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107810] [META] OLE/Embedded object bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107810 Bug 107810 depends on bug 111483, which changed state. Bug 111483 Summary: FILEOPEN: Ole object not displayed (gtk3) https://bugs.documentfoundation.org/show_bug.cgi?id=111483 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73629] FILEOPEN: paragraph contextual spacing issue ( with numbered list..) in .doc and docx
https://bugs.documentfoundation.org/show_bug.cgi?id=73629 Justin Lchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE Whiteboard|NoRepro:4.2.0.2:OSX | --- Comment #17 from Justin L --- fixed in LO 5.3 for bug 75221 by author Mike Kaganski in commit ba18832ceeda21f047a664b71a4333a54737e6c8 tdf#75221: make margin collapsing implementation conform OASIS proposal *** This bug has been marked as a duplicate of bug 75221 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Bug 103182 depends on bug 111073, which changed state. Bug 111073 Summary: Fullscreen: incorrect gif's background (gtk3) https://bugs.documentfoundation.org/show_bug.cgi?id=111073 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: slideshow/source vcl/headless
slideshow/source/engine/shapes/gdimtftools.cxx |2 +- vcl/headless/svpgdi.cxx|9 - 2 files changed, 9 insertions(+), 2 deletions(-) New commits: commit 67951d08ddd20ac87fc7eb54a90cb81901a89f8c Author: Caolán McNamaraDate: Mon Sep 4 17:12:02 2017 +0100 Resolves: tdf#111073 incorrect gif background color a) set correct palette entries for the 1bit bitmap returned b) only use a BITMASK for the mask (like its AnimatedGraphicPrimitive2D brother in drawinglayer does) Change-Id: I704997de554dc4d0e523458d45ab329815b5046a Reviewed-on: https://gerrit.libreoffice.org/41905 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/slideshow/source/engine/shapes/gdimtftools.cxx b/slideshow/source/engine/shapes/gdimtftools.cxx index 3d7e643dfb7b..fb12c9853392 100644 --- a/slideshow/source/engine/shapes/gdimtftools.cxx +++ b/slideshow/source/engine/shapes/gdimtftools.cxx @@ -285,7 +285,7 @@ bool getAnimationFromGraphic( VectorOfMtfAnimationFrames& o_rFrames, pVDev->EnableMapMode( false ); // setup mask VDev (alpha VDev is currently rather slow) -ScopedVclPtrInstance< VirtualDevice > pVDevMask; +ScopedVclPtrInstance pVDevMask(DeviceFormat::BITMASK); pVDevMask->SetOutputSizePixel( aAnimSize ); pVDevMask->EnableMapMode( false ); diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx index 170d6c6087e6..5b8c0a8a66e0 100644 --- a/vcl/headless/svpgdi.cxx +++ b/vcl/headless/svpgdi.cxx @@ -1145,7 +1145,14 @@ void SvpSalGraphics::drawMask( const SalTwoRect& rTR, SalBitmap* SvpSalGraphics::getBitmap( long nX, long nY, long nWidth, long nHeight ) { SvpSalBitmap* pBitmap = new SvpSalBitmap(); -pBitmap->Create(Size(nWidth, nHeight), GetBitCount(), BitmapPalette()); +BitmapPalette aPal; +if (GetBitCount() == 1) +{ +aPal.SetEntryCount(2); +aPal[0] = Color(COL_BLACK); +aPal[1] = Color(COL_WHITE); +} +pBitmap->Create(Size(nWidth, nHeight), GetBitCount(), aPal); cairo_surface_t* target = SvpSalGraphics::createCairoSurface(pBitmap->GetBuffer()); cairo_t* cr = cairo_create(target); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112202] FILEOPEN: DOCX thesis template with emtpy header
https://bugs.documentfoundation.org/show_bug.cgi?id=112202 Jean-Baptiste Faurechanged: What|Removed |Added Version|unspecified |6.0.0.0.alpha0+ Master -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109253] FONT NAME list: Scrolling through the list causes a crash. " Bad allocation" error message
https://bugs.documentfoundation.org/show_bug.cgi?id=109253 --- Comment #26 from Bryan Leech--- (In reply to Bryan Leech from comment #25) > (In reply to JohnHardy from comment #21) > > Bryan: It may not be the specific Helvetica font that causes the crash, but > > rather a fault that could occur in any font, in my case it happened to be > > with a Helvetica font. I'm just speculating. The fonts may be OK and it is a > > LO problem. > > > > If you haven't tried yet, you could remove all but a few fonts and test LO. > > Add a few fonts at a time and test again. See when the problem resurfaces. > > That assumes that there is a font problem. But it could be a LO problem. > > > > I will try Telesto's link on my other computer where I have not yet found > > the cause of the crash. John - and others: Thank you. Starting with few fonts and increasing is an idea, but I just don't have the time, unfortunately - and that may not be the issue. I have neglected to mention that my other computer (desktop also running Win 7 Home Premium 64-bit), has no problems. Unfortunately, it's convenient for me to use this laptop much of the time. The suggestions of the daily commit releases take me out of my depth - or appear to. I'm reasonably computer literate so could probaly sort out that approach, but exploring needs time Ilack. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109253] FONT NAME list: Scrolling through the list causes a crash. " Bad allocation" error message
https://bugs.documentfoundation.org/show_bug.cgi?id=109253 --- Comment #25 from Bryan Leech--- (In reply to JohnHardy from comment #21) > Bryan: It may not be the specific Helvetica font that causes the crash, but > rather a fault that could occur in any font, in my case it happened to be > with a Helvetica font. I'm just speculating. The fonts may be OK and it is a > LO problem. > > If you haven't tried yet, you could remove all but a few fonts and test LO. > Add a few fonts at a time and test again. See when the problem resurfaces. > That assumes that there is a font problem. But it could be a LO problem. > > I will try Telesto's link on my other computer where I have not yet found > the cause of the crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104527] [META] DOC bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104527 Bug 104527 depends on bug 73416, which changed state. Bug 73416 Summary: FILESAVE: Dots are added before section titles https://bugs.documentfoundation.org/show_bug.cgi?id=73416 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73416] FILESAVE: Dots are added before section titles
https://bugs.documentfoundation.org/show_bug.cgi?id=73416 Justin Lchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Justin L --- fixed in LO 5.3 for bug 104805 by Miklos Vajna in commit 19d08bbf704332d727cfbe8e101e7d14c62326a0 tdf#104805 DOC import: fix non-0-starting LVL.xst with none-type prev level *** This bug has been marked as a duplicate of bug 104805 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39468] translate German comments, removing redundant ones
https://bugs.documentfoundation.org/show_bug.cgi?id=39468 --- Comment #352 from Commit Notification--- Andreas Brandner committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a89c3dc4b0a2ec846af387833474b543b3f149ad tdf#39468 Translate German comments/terms It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/menufloatingwindow.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit a89c3dc4b0a2ec846af387833474b543b3f149ad Author: Andreas BrandnerDate: Mon Sep 4 18:41:27 2017 +0200 tdf#39468 Translate German comments/terms Change-Id: I528e7e4b4d365ff512cd03ea22f7517319541e05 Reviewed-on: https://gerrit.libreoffice.org/41907 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/vcl/source/window/menufloatingwindow.cxx b/vcl/source/window/menufloatingwindow.cxx index 0204828574e5..d6dd08d4e17e 100644 --- a/vcl/source/window/menufloatingwindow.cxx +++ b/vcl/source/window/menufloatingwindow.cxx @@ -280,7 +280,6 @@ IMPL_LINK_NOARG(MenuFloatingWindow, PopupEnd, FloatingWindow*, void) End(); if ( pActivePopup ) { -//SAL_WARN_IF( pActivePopup->ImplGetWindow(), "vcl", "PopupEnd, obwohl pActivePopup MIT Window!" ); KillActivePopup(); // should be ok to just remove it //pActivePopup->bCanceled = true; } @@ -357,7 +356,7 @@ IMPL_LINK( MenuFloatingWindow, HighlightChanged, Timer*, pTimer, void ) sal_uInt16 nRet = pActivePopup->ImplExecute( this, tools::Rectangle( aItemTopLeft, aItemBottomRight ), FloatWinPopupFlags::Right, pMenu, pTimer == nullptr ); SetPopupModeFlags( nOldFlags ); -// nRet != 0, wenn es waerend Activate() abgeschossen wurde... +// nRet != 0, if it was stopped during Activate()... if ( !nRet && ( pActivePopup == pTest ) && pActivePopup->ImplGetWindow() ) pActivePopup->ImplGetFloatingWindow()->AddPopupModeWindow( this ); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configure.ac
configure.ac | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) New commits: commit f7bc186bdabd420f5cfb0de62108413160b1e1de Author: jan IversenDate: Sat Sep 2 17:40:45 2017 +0200 iOS, update configure.ac to handle ios Added enable-ios-simulator, and updated to do cross compile Change-Id: Id9031aa2ad1e271f843cf1cba6e3b67d907b6df0 diff --git a/configure.ac b/configure.ac index 81a3ac0877ef..39f42eb6d0ed 100644 --- a/configure.ac +++ b/configure.ac @@ -716,7 +716,7 @@ darwin*) # Mac OS X or iOS test_freetype=no test_fontconfig=no test_dbus=no -if test "$host_cpu" = "armv7" -o "$host_cpu" = "arm64"; then +if test "$enable_ios_simulator" = "yes" -o "$host_cpu" = "armv7" -o "$host_cpu" = "arm64"; then _os=iOS test_gtk=no test_cups=no @@ -991,6 +991,11 @@ AC_SUBST(DLOPEN_LIBS) # if you use --disable-extension-integration. Is that really the # case? +AC_ARG_ENABLE(ios-simulator, +AS_HELP_STRING([--enable-ios-simulator], +[build i386 or x86_64 for ios simulator]) +) + libo_FUZZ_ARG_ENABLE(extension-integration, AS_HELP_STRING([--disable-extension-integration], [Disable integration of the built extensions in the installer of the @@ -2709,7 +2714,7 @@ dnl === dnl Check OS X SDK and compiler dnl === -if test $_os = Darwin; then +if test $_os = Darwin -o $_os = iOS; then # If no --with-macosx-sdk option is given, look for one @@ -2946,6 +2951,7 @@ if test $_os = iOS; then elif test "$build_cpu" = "x86_64"; then platform=iPhoneSimulator XCODE_ARCHS=x86_64 +BITNESS_OVERRIDE=64 versionmin=-mios-simulator-version-min=9.3 else platform=iPhoneOS @@ -3153,6 +3159,9 @@ if test "$_os" = "WINNT"; then BITNESS_OVERRIDE=64 fi fi +if test "$_os" = "iOS"; then +cross_compiling="yes" +fi if test "$cross_compiling" = "yes"; then export CROSS_COMPILING=TRUE @@ -4015,9 +4024,19 @@ darwin*) OS=IOS ;; i*86) -AC_MSG_ERROR([Can't build 64-bit code in 32-bit OS]) +if test "$enable_ios_simulator" = "yes"; then +OS=IOS +CPUNAME=i386 +RTL_ARCH=i386 +PLATFORMID=macosx_i38 +else +AC_MSG_ERROR([Can't build 64-bit code in 32-bit OS]) +fi ;; x86_64) +if test "$enable_ios_simulator" = "yes"; then +OS=IOS +fi CPUNAME=X86_64 RTL_ARCH=X86_64 PLATFORMID=macosx_x86_64 @@ -6343,7 +6362,7 @@ _ACEOF fi fi -AC_MSG_CHECKING([if gcc has a visibility bug with class-level attributes (GCC bug 26905)]) + AC_MSG_CHECKING([if gcc has a visibility bug with class-level attributes (GCC bug 26905)]) cat >visibility.cxx <<_ACEOF #pragma GCC visibility push(hidden) struct __attribute__ ((visibility ("default"))) TestStruct { @@ -6358,7 +6377,7 @@ _ACEOF else case "$host_cpu" in i?86|x86_64) -if test "$_os" = "Darwin"; then +if test "$_os" = "Darwin" -o "$_os" = "iOS"; then gccvisbroken=no else if $EGREP -q '@PLT|@GOT' visibility.s || test "$ENABLE_LTO" = "TRUE"; then ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: external/libepubgen writerperfect/qa writerperfect/source
external/libepubgen/libepubgen-epub3.patch.1 | 44 + writerperfect/qa/unit/EPUBExportTest.cxx | 13 + writerperfect/qa/unit/data/writer/epubexport/meta.fodt | 12 writerperfect/source/writer/exp/xmlmetai.cxx | 24 + 4 files changed, 93 insertions(+) New commits: commit 41092fe0bb0d2f49948bf2a1f27acb53f21a84aa Author: Miklos VajnaDate: Mon Sep 4 17:27:39 2017 +0200 EPUB export: write author metadata is the author and is the "last modified by" in ODF (it seems), so map the first to EPUB's . Change-Id: Id701c8c38b0901ae14fbbc7b32d01b43d6d03f68 Reviewed-on: https://gerrit.libreoffice.org/41903 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/external/libepubgen/libepubgen-epub3.patch.1 b/external/libepubgen/libepubgen-epub3.patch.1 index d1d35c102022..0415bf340e78 100644 --- a/external/libepubgen/libepubgen-epub3.patch.1 +++ b/external/libepubgen/libepubgen-epub3.patch.1 @@ -1862,3 +1862,47 @@ index 4ce2964..1661064 100644 -- 2.12.3 +From 7e3b5186616326534b1ae95c6d2d188c5e522c7f Mon Sep 17 00:00:00 2001 +From: Miklos Vajna +Date: Mon, 4 Sep 2017 17:18:49 +0200 +Subject: [PATCH] EPUBGenerator: always write author and title + +Some EPUB3 readers categorize books by author and then title, so if +these are empty, then it's next to impossible to reach the export result +there. +--- + src/lib/EPUBGenerator.cpp | 11 --- + src/test/EPUBTextGeneratorTest.cpp | 11 +++ + 2 files changed, 19 insertions(+), 3 deletions(-) + +diff --git a/src/lib/EPUBGenerator.cpp b/src/lib/EPUBGenerator.cpp +index 1661064..3340643 100644 +--- a/src/lib/EPUBGenerator.cpp b/src/lib/EPUBGenerator.cpp +@@ -260,15 +260,20 @@ void EPUBGenerator::writeRoot() + sink.insertCharacters(identifierCharactrs.c_str()); + sink.closeElement("dc:identifier"); + +- // Zero-width space as it must be at least one character in length after +- // white space has been trimmed. +- RVNGString title("\u200b"); ++ RVNGString title("Unknown Title"); + if (m_metadata["dc:title"] && !m_metadata["dc:title"]->getStr().empty()) + title = m_metadata["dc:title"]->getStr(); + sink.openElement("dc:title"); + sink.insertCharacters(title); + sink.closeElement("dc:title"); + ++ RVNGString creator("Unknown Author"); ++ if (m_metadata["meta:initial-creator"] && !m_metadata["meta:initial-creator"]->getStr().empty()) ++creator = m_metadata["meta:initial-creator"]->getStr(); ++ sink.openElement("dc:creator"); ++ sink.insertCharacters(creator); ++ sink.closeElement("dc:creator"); ++ + RVNGString language("en"); + if (m_metadata["dc:language"] && !m_metadata["dc:language"]->getStr().empty()) + language = m_metadata["dc:language"]->getStr(); +-- +2.12.3 + diff --git a/writerperfect/qa/unit/EPUBExportTest.cxx b/writerperfect/qa/unit/EPUBExportTest.cxx index fef1cf19770c..61a6da2941f0 100644 --- a/writerperfect/qa/unit/EPUBExportTest.cxx +++ b/writerperfect/qa/unit/EPUBExportTest.cxx @@ -53,6 +53,7 @@ public: void testPageBreakSplit(); void testSpanAutostyle(); void testParaAutostyleCharProps(); +void testMeta(); CPPUNIT_TEST_SUITE(EPUBExportTest); CPPUNIT_TEST(testOutlineLevel); @@ -61,6 +62,7 @@ public: CPPUNIT_TEST(testPageBreakSplit); CPPUNIT_TEST(testSpanAutostyle); CPPUNIT_TEST(testParaAutostyleCharProps); +CPPUNIT_TEST(testMeta); CPPUNIT_TEST_SUITE_END(); }; @@ -88,6 +90,7 @@ void EPUBExportTest::tearDown() void EPUBExportTest::registerNamespaces(xmlXPathContextPtr ) { +xmlXPathRegisterNs(pXmlXpathCtx, BAD_CAST("dc"), BAD_CAST("http://purl.org/dc/elements/1.1/;)); xmlXPathRegisterNs(pXmlXpathCtx, BAD_CAST("opf"), BAD_CAST("http://www.idpf.org/2007/opf;)); xmlXPathRegisterNs(pXmlXpathCtx, BAD_CAST("xhtml"), BAD_CAST("http://www.w3.org/1999/xhtml;)); } @@ -202,6 +205,16 @@ void EPUBExportTest::testParaAutostyleCharProps() assertXPath(mpXmlDoc, "//xhtml:p[2]/xhtml:span", "class", "span1"); } +void EPUBExportTest::testMeta() +{ +createDoc("meta.fodt", {}); + +mpXmlDoc = parseExport("OEBPS/content.opf"); +// This was "Unknown Author", was not handled. +assertXPathContent(mpXmlDoc, "/opf:package/opf:metadata/dc:creator", "A U Thor"); +assertXPathContent(mpXmlDoc, "/opf:package/opf:metadata/dc:title", "Title"); +} + CPPUNIT_TEST_SUITE_REGISTRATION(EPUBExportTest); } diff --git a/writerperfect/qa/unit/data/writer/epubexport/meta.fodt b/writerperfect/qa/unit/data/writer/epubexport/meta.fodt new file mode 100644 index ..4e46fe79fcda --- /dev/null +++ b/writerperfect/qa/unit/data/writer/epubexport/meta.fodt @@ -0,0 +1,12 @@ + +http://purl.org/dc/elements/1.1/;> + +A U Thor +Title + + + + Hello world! + + + diff --git
[Libreoffice-bugs] [Bug 104602] FILEOPEN DOCX: File appears to be empty
https://bugs.documentfoundation.org/show_bug.cgi?id=104602 Justin Lchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #9 from Justin L --- requested backport to 5.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109195] [META] DOCX Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109195 Bug 109195 depends on bug 108765, which changed state. Bug 108765 Summary: FILEOPEN: DOCX - Footnote paragraph and character styles opens incorrectly when styles not defined https://bugs.documentfoundation.org/show_bug.cgi?id=108765 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108761] [META] DOCX documents loading with incorrect style defaults when not defined
https://bugs.documentfoundation.org/show_bug.cgi?id=108761 Bug 108761 depends on bug 108765, which changed state. Bug 108765 Summary: FILEOPEN: DOCX - Footnote paragraph and character styles opens incorrectly when styles not defined https://bugs.documentfoundation.org/show_bug.cgi?id=108765 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93992] Typos in Calc function names and error codes
https://bugs.documentfoundation.org/show_bug.cgi?id=93992 Eike Rathkechanged: What|Removed |Added Attachment #136016|0 |1 is obsolete|| --- Comment #21 from Eike Rathke --- Created attachment 136017 --> https://bugs.documentfoundation.org/attachment.cgi?id=136017=edit Test document for function name translations in 5.4 Erroneously in the previous attachment included the *_ADD and *_EXCEL2003 names of duplicated functions that lead to duplicate names when reloaded. Removed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/rtfexport/data/tdf112208_hangingIndent.rtf | 89 sw/qa/extras/rtfexport/rtfexport2.cxx |6 + writerfilter/source/rtftok/rtfsprm.cxx |2 3 files changed, 97 insertions(+) New commits: commit 72b19aa29f9adcab6dd20d1517208f3b999d055e Author: Justin LuthDate: Mon Sep 4 11:43:09 2017 -0400 tdf#112208 rtfimport: fix missing paragraph first line indent This is a followup to commit f528f9499bd91b700c549575e88fa102cfffede9 adding ParaFirstLineIndent to that commit's Para(Left|Right)Margin. I also added code for hanging indents, but it doesn't look like that case will ever hit. Just added for completeness. My test unit was created in Word as a hanging indent, but it invokes the firstLine case... Change-Id: I2b04866b9eb4b085503f3b7d3b6e97d4f9e3d19c Reviewed-on: https://gerrit.libreoffice.org/41901 Reviewed-by: Justin Luth Tested-by: Justin Luth diff --git a/sw/qa/extras/rtfexport/data/tdf112208_hangingIndent.rtf b/sw/qa/extras/rtfexport/data/tdf112208_hangingIndent.rtf new file mode 100644 index ..8f3be9e4cbbe --- /dev/null +++ b/sw/qa/extras/rtfexport/data/tdf112208_hangingIndent.rtf @@ -0,0 +1,89 @@ +{\rtf1\adeflang1025\ansi\ansicpg1252\uc1\adeff0\deff0\stshfdbch0\stshfloch0\stshfhich0\stshfbi0\deflang2057\deflangfe2057{\fonttbl{\f0\froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;}{\f1\fswiss\fcharset0\fprq2{\*\panose 020b0604020202020204}Arial;}{\f95\froman\fcharset238\fprq2 Times New Roman CE;} +{\f96\froman\fcharset204\fprq2 Times New Roman Cyr;}{\f98\froman\fcharset161\fprq2 Times New Roman Greek;}{\f99\froman\fcharset162\fprq2 Times New Roman Tur;}{\f100\fbidi \froman\fcharset177\fprq2 Times New Roman (Hebrew);} +{\f101\fbidi \froman\fcharset178\fprq2 Times New Roman (Arabic);}{\f102\froman\fcharset186\fprq2 Times New Roman Baltic;}{\f103\froman\fcharset163\fprq2 Times New Roman (Vietnamese);}{\f105\fswiss\fcharset238\fprq2 Arial CE;} +{\f106\fswiss\fcharset204\fprq2 Arial Cyr;}{\f108\fswiss\fcharset161\fprq2 Arial Greek;}{\f109\fswiss\fcharset162\fprq2 Arial Tur;}{\f110\fbidi \fswiss\fcharset177\fprq2 Arial (Hebrew);}{\f111\fbidi \fswiss\fcharset178\fprq2 Arial (Arabic);} +{\f112\fswiss\fcharset186\fprq2 Arial Baltic;}{\f113\fswiss\fcharset163\fprq2 Arial (Vietnamese);}}{\colortbl;\red0\green0\blue0;\red0\green0\blue255;\red0\green255\blue255;\red0\green255\blue0;\red255\green0\blue255;\red255\green0\blue0; +\red255\green255\blue0;\red255\green255\blue255;\red0\green0\blue128;\red0\green128\blue128;\red0\green128\blue0;\red128\green0\blue128;\red128\green0\blue0;\red128\green128\blue0;\red128\green128\blue128;\red192\green192\blue192;\red0\green0\blue1;} +{\stylesheet{\ql \li0\ri0\widctlpar\wrapdefault\aspalpha\aspnum\faauto\adjustright\rin0\lin0\itap0 \rtlch\fcs1 \af0\afs24\alang1025 \ltrch\fcs0 \fs24\lang2057\langfe2057\cgrid\langnp2057\langfenp2057 \snext0 Normal;}{ +\s1\ql \li0\ri0\sb240\sa120\keepn\nowidctlpar\wrapdefault\faauto\outlinelevel0\rin0\lin0\itap0 \rtlch\fcs1 \ab\af1\afs32\alang1025 \ltrch\fcs0 \b\f1\fs32\lang2057\langfe2057\cgrid\langnp2057\langfenp2057 \sbasedon28 \snext29 heading 1;}{ +\s2\ql \li0\ri0\sb240\sa120\keepn\nowidctlpar\wrapdefault\faauto\ilvl1\outlinelevel1\rin0\lin0\itap0 \rtlch\fcs1 \ab\ai\af1\afs28\alang1025 \ltrch\fcs0 \b\i\f1\fs28\lang2057\langfe2057\cgrid\langnp2057\langfenp2057 \sbasedon28 \snext29 heading 2;}{ +\s3\ql \li0\ri0\sb240\sa120\keepn\nowidctlpar\wrapdefault\faauto\ilvl2\outlinelevel2\rin0\lin0\itap0 \rtlch\fcs1 \ab\af1\afs28\alang1025 \ltrch\fcs0 \b\f1\fs28\lang2057\langfe2057\cgrid\langnp2057\langfenp2057 \sbasedon28 \snext29 heading 3;}{\*\cs10 +\additive \ssemihidden Default Paragraph Font;}{\* +\ts11\tsrowd\trftsWidthB3\trpaddl108\trpaddr108\trpaddfl3\trpaddft3\trpaddfb3\trpaddfr3\trcbpat1\trcfpat1\tblind0\tblindtype3\tscellwidthfts0\tsvertalt\tsbrdrt\tsbrdrl\tsbrdrb\tsbrdrr\tsbrdrdgl\tsbrdrdgr\tsbrdrh\tsbrdrv +\ql \li0\ri0\widctlpar\wrapdefault\aspalpha\aspnum\faauto\adjustright\rin0\lin0\itap0 \rtlch\fcs1 \af0\afs20 \ltrch\fcs0 \fs20\lang1024\langfe1024\cgrid\langnp1024\langfenp1024 \snext11 \ssemihidden Normal Table;}{ +\s15\ql \li0\ri0\nowidctlpar\wrapdefault\faauto\rin0\lin0\itap0 \rtlch\fcs1 \af1\afs24\alang1081 \ltrch\fcs0 \f1\fs24\lang1043\langfe2052\kerning1\cgrid\langnp1043\langfenp2052 \snext15 Default Style;}{\*\cs16 \additive +\ul\lang255\langfe255\langnp255\langfenp255\ulc1 Internetkoppeling;}{\*\cs17 \additive \ul\lang255\langfe255\langnp255\langfenp255\ulc1 Bezochte internetkoppeling;}{\*\cs18 \additive \super Eindnootanker;}{\*\cs19 \additive \super Voetnootanker;}{\*\cs20 +\additive Voetnoottekens;}{\*\cs21 \additive Eindnoottekens;}{\*\cs22 \additive Endnote Characters;}{\*\cs23 \additive \ul\cf9\lang255\langfe255\langnp255\langfenp255 Internet
[Libreoffice-bugs] [Bug 93992] Typos in Calc function names and error codes
https://bugs.documentfoundation.org/show_bug.cgi?id=93992 --- Comment #20 from Eike Rathke--- Created attachment 136016 --> https://bugs.documentfoundation.org/attachment.cgi?id=136016=edit Test document for function name translations in 5.4 Updated with function names as of LibreOffice 5.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112200] Vertical page prints with text horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=112200 rairose.corn...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #7 from rairose.corn...@gmail.com --- I deleted the old version of LibreOffice Vanilla from my computer. Then I downloaded the correct version (see first attachment). However, when I try to print a document, the same problem is still occurring. I tried it with several different documents, and it happens every time. I've looked through the forum, but I can't find another thread that gives instructions on how to fix this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112200] Vertical page prints with text horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=112200 --- Comment #6 from rairose.corn...@gmail.com --- Created attachment 136015 --> https://bugs.documentfoundation.org/attachment.cgi?id=136015=edit But it's still printing improperly. But it's still printing improperly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112200] Vertical page prints with text horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=112200 --- Comment #5 from rairose.corn...@gmail.com --- Created attachment 136014 --> https://bugs.documentfoundation.org/attachment.cgi?id=136014=edit I downloaded the correct version. I deleted the old version of LibreOffice Vanilla from my computer. Then I downloaded the new version from the proper source. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: git-hook: Catch tab indentation also for makefiles
2017-09-04 17:13 GMT+02:00 jani libreoffice: > > I think temporary GNU make still needs recipe lines to start with tab >> characters? And in any case, our makefiles are apparently written with >> lots of tab characters all over the place. I'd suggest to revert (at least >> for now). > > > Yeah, I see that tabs and spaces are mixed in makefiles. That's why I > thought it would be good to make it consistent similar to other source > files. > I did not push it yet. It's on gerrit. So I can abandon it. > > > build breaks on my mac when I replace tab with spaces, so please do not > make this a demand. > OK, I abandoned the patch. Thanks! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 69343] FILESAVE: saving odt as doc doesn' t show last line if opened in Word 2013
https://bugs.documentfoundation.org/show_bug.cgi?id=69343 --- Comment #14 from itjoker@gmail.com --- Problem still not solved completely for LibreOffice Version 5.4.1.2 Build-ID: ea7cb86e6eeb2bf3a5af73a8fac570321527 / MSOffice 2016 Version 16.0.4266.1003 Testing environment on Windows 10 Pro Version 1703 The following test is working fine: 1. open new file 2. enter three lines of text. 3. save as file test1.odt 4. save as file test1.doc 5. close LO Writer 6. open file test1.doc with MS Word 7. MS Word shows the text entered with LO Writer (OK) Next test is not working correctly: 1. open template "Modern business letter sans-serif" in LO Writer 2. just save as test2.doc 3. close LO Writer 4. open file test2.doc with MS Word 5. last line doesn't show up!!! 6. save as test2-2.doc 7. close MS Word 8. open test2-2.doc with MS Word 9. last line is displayed correctly! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/odfexport/data/tdf111891_frameVertStyle.odt |binary sw/qa/extras/odfexport/odfexport.cxx |6 ++ sw/source/core/unocore/unostyle.cxx |7 ++- 3 files changed, 12 insertions(+), 1 deletion(-) New commits: commit 10dc371d31f003ac3ed9b89ca1db95d36603603f Author: Justin LuthDate: Thu Aug 24 15:48:29 2017 -0400 tdf#111891 unostyle: use default handler for non-page style LO 5.1 commit 664197d95becd516c3dac25a50439078ba61e051 introduced a handler for RES_TEXT_VERT_ADJUST to handle page styles, but that meant that the default handler was no longer called for frames (the only other item currently using RES_TEXT_VERT_ADJUST). Change-Id: I33827160fe64dc4cc2107afc26f7ac2e698007e1 Reviewed-on: https://gerrit.libreoffice.org/41538 Tested-by: Justin Luth Reviewed-by: Justin Luth diff --git a/sw/qa/extras/odfexport/data/tdf111891_frameVertStyle.odt b/sw/qa/extras/odfexport/data/tdf111891_frameVertStyle.odt new file mode 100644 index ..8fcf98a6272b Binary files /dev/null and b/sw/qa/extras/odfexport/data/tdf111891_frameVertStyle.odt differ diff --git a/sw/qa/extras/odfexport/odfexport.cxx b/sw/qa/extras/odfexport/odfexport.cxx index cc096f406733..a2f9923b57d7 100644 --- a/sw/qa/extras/odfexport/odfexport.cxx +++ b/sw/qa/extras/odfexport/odfexport.cxx @@ -860,6 +860,12 @@ DECLARE_ODFEXPORT_TEST(testTextFrameVertAdjust, "textframe-vertadjust.odt") CPPUNIT_ASSERT_EQUAL(drawing::TextVerticalAdjust_BOTTOM, getProperty(xFrame, "TextVerticalAdjust")); } +DECLARE_ODFEXPORT_TEST(testTdf111891_frameVertStyle, "tdf111891_frameVertStyle.odt") +{ +uno::Reference xFrame(getShape(1), uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(drawing::TextVerticalAdjust_BOTTOM, getProperty(xFrame, "TextVerticalAdjust")); +} + DECLARE_ODFEXPORT_TEST(testShapeRelsize, "shape-relsize.odt") { uno::Reference xShape = getShape(1); diff --git a/sw/source/core/unocore/unostyle.cxx b/sw/source/core/unocore/unostyle.cxx index d3764741486a..62b9821791a0 100644 --- a/sw/source/core/unocore/unostyle.cxx +++ b/sw/source/core/unocore/unostyle.cxx @@ -1804,8 +1804,13 @@ void SwXStyle::SetPropertyValue(const SfxItemPropertySimpleEntry& } } template<> -void SwXStyle::SetPropertyValue(const SfxItemPropertySimpleEntry&, const SfxItemPropertySet&, const uno::Any& rValue, SwStyleBase_Impl& o_rStyleBase) +void SwXStyle::SetPropertyValue(const SfxItemPropertySimpleEntry& rEntry, const SfxItemPropertySet& rPropSet, const uno::Any& rValue, SwStyleBase_Impl& o_rStyleBase) { +if(m_rEntry.m_eFamily != SfxStyleFamily::Page) +{ +SetPropertyValue(rEntry, rPropSet, rValue, o_rStyleBase); +return; +} if(!m_pDoc || !rValue.has() || !o_rStyleBase.GetOldPageDesc()) return; SwPageDesc* pPageDesc = m_pDoc->FindPageDesc(o_rStyleBase.GetOldPageDesc()->GetName()); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 111895] FILEOPEN: DOCX: Images and other components hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=111895 --- Comment #9 from Commit Notification--- Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=24e453e6018af2e71af784dc9364b5ea70112f29 Revert "tdf#111895 writerfilter: avoid hiding shapes behind background" It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa writerfilter/source
dev/null |binary sw/qa/extras/ooxmlexport/ooxmlexport9.cxx | 16 writerfilter/source/dmapper/DomainMapper.cxx |5 - writerfilter/source/dmapper/DomainMapper.hxx |1 - writerfilter/source/dmapper/GraphicImport.cxx | 16 +--- 5 files changed, 1 insertion(+), 37 deletions(-) New commits: commit 24e453e6018af2e71af784dc9364b5ea70112f29 Author: Justin LuthDate: Mon Sep 4 18:04:29 2017 +0200 Revert "tdf#111895 writerfilter: avoid hiding shapes behind background" This reverts commit d21f67fa7fd0360688e083eeb2bbcd57f5414d71. A better fix is commit de0993097cad2fd5819f8bea5ff53cddce7cde41. This patch didn't properly describe the zOrder stuff anyway. The problem technically wasn't with the zOrder - the painting method only made it seem to be so. Thanks to the reviewers for their helpful comments that spurred further areas of research. Change-Id: I586edd189e5b0a25b6e1e64ca42fdf43305997da Reviewed-on: https://gerrit.libreoffice.org/41904 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/qa/extras/ooxmlexport/data/tdf111895_foregroundShape.docx b/sw/qa/extras/ooxmlexport/data/tdf111895_foregroundShape.docx deleted file mode 100644 index b282059b1097.. Binary files a/sw/qa/extras/ooxmlexport/data/tdf111895_foregroundShape.docx and /dev/null differ diff --git a/sw/qa/extras/ooxmlexport/data/tdf111895_foregroundShape2.docx b/sw/qa/extras/ooxmlexport/data/tdf111895_foregroundShape2.docx deleted file mode 100644 index ae2e3c7573db.. Binary files a/sw/qa/extras/ooxmlexport/data/tdf111895_foregroundShape2.docx and /dev/null differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx index 43639f622cac..930cbdc41b4f 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx @@ -230,22 +230,6 @@ DECLARE_OOXMLEXPORT_TEST(testTdf98700_keepWithNext, "tdf98700_keepWithNext.odt") CPPUNIT_ASSERT_EQUAL_MESSAGE("Text Body style toggled off keep with next", false, getProperty(getParagraph(5), "ParaKeepTogether")); } -DECLARE_OOXMLEXPORT_TEST(testTdf111895_foregroundShape, "tdf111895_foregroundShape.docx") -{ -uno::Reference xPageStyle(getStyles("PageStyles")->getByName("Standard"), uno::UNO_QUERY); -CPPUNIT_ASSERT_EQUAL_MESSAGE("Light yellow background", sal_Int32(0x66), getProperty(xPageStyle, "BackColor")); -// despite a behindDoc==1, put shape in foreground since the page background would have hidden it otherwise. -CPPUNIT_ASSERT_EQUAL_MESSAGE("Shape is in front of page background", true, getProperty(getShape(1), "Opaque")); -} - -DECLARE_OOXMLEXPORT_TEST(testTdf111895_foregroundShape2, "tdf111895_foregroundShape2.docx") -{ -uno::Reference xPageStyle(getStyles("PageStyles")->getByName("Standard"), uno::UNO_QUERY); -CPPUNIT_ASSERT_EQUAL_MESSAGE("Light yellow background", sal_Int32(0x66), getProperty(xPageStyle, "BackColor")); -// despite a page background, don't show behindDoc==1 shape in front since it would have hidden wrap_THROUGH text. -CPPUNIT_ASSERT_EQUAL_MESSAGE("Shape is in front of page background", false, getProperty(getShape(1), "Opaque")); -} - // base class to supply a helper method for testHFLinkToPrev class testHFBase : public Test { diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index 41decae20717..fc83d8d31af8 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -3778,11 +3778,6 @@ bool DomainMapper::IsStyleSheetImport() const return m_pImpl->IsStyleSheetImport(); } -bool DomainMapper::HasPageBackground() const -{ -return (bool)m_pImpl->m_oBackgroundColor; -} - void DomainMapper::enableInteropGrabBag(const OUString& aName) { m_pImpl->m_aInteropGrabBagName = aName; diff --git a/writerfilter/source/dmapper/DomainMapper.hxx b/writerfilter/source/dmapper/DomainMapper.hxx index 35a18b445c13..b2b89f1776c1 100644 --- a/writerfilter/source/dmapper/DomainMapper.hxx +++ b/writerfilter/source/dmapper/DomainMapper.hxx @@ -110,7 +110,6 @@ public: bool IsInHeaderFooter() const; bool IsInTable() const; bool IsStyleSheetImport() const; -bool HasPageBackground() const; /** @see DomainMapper_Impl::processDeferredCharacterProperties() */ diff --git a/writerfilter/source/dmapper/GraphicImport.cxx b/writerfilter/source/dmapper/GraphicImport.cxx index 68d7ac4a1738..65a20747c38f 100644 --- a/writerfilter/source/dmapper/GraphicImport.cxx +++ b/writerfilter/source/dmapper/GraphicImport.cxx @@ -197,7 +197,6 @@ public: text::WrapTextMode nWrap; bool bLayoutInCell; bool bOpaque; -bool bBehindDoc; bool bContour; bool
[Libreoffice-bugs] [Bug 99477] EDITING: "View> Freeze Cells> Freeze First..." does not work if the sheet is already frozen
https://bugs.documentfoundation.org/show_bug.cgi?id=99477 Eike Rathkechanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | --- Comment #9 from Eike Rathke --- This is my stab at it: https://gerrit.libreoffice.org/41908 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99953] Misaligned cell background color when inserting Calc table in Writer document , depending on zoom level
https://bugs.documentfoundation.org/show_bug.cgi?id=99953 Xisco Faulíchanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||1938 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111938] Blurry borders and colors bleeding in calc8 object
https://bugs.documentfoundation.org/show_bug.cgi?id=111938 Xisco Faulíchanged: What|Removed |Added CC||xiscofa...@libreoffice.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=99 ||953 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78463] FILEOPEN: Formulas are imported incorrectly from Excel 2003 XML
https://bugs.documentfoundation.org/show_bug.cgi?id=78463 David Berkychanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from David Berky --- I downloaded the attached XML file, opened it in Version: 5.4.1.2 (x64) in Windows 10 (version 1703 - OS Build 15063.540). I copied the list of codes from column A rows 2-27 from sheet "Codes" into column D (rows 3-28) of sheet "Patient Charges" and the formulas are correct and pull in the correct data. This one "WORKSFORME". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112210] LibreOffice does not work in headless mode under Windows Server Core 2016 (Docker)
https://bugs.documentfoundation.org/show_bug.cgi?id=112210 Gabriel Muñozchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112216] New: UI: First press of Backspace or Delete cannot delete characters in distance of shadow for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=112216 Bug ID: 112216 Summary: UI: First press of Backspace or Delete cannot delete characters in distance of shadow for shapes Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikenyannyan...@gmail.com Description: When I try to edit distance of shadow of newly created shape, first press of Backspace or Delete cannot delete characters in the editbox. When I use arrow keys to move the caret left or right before trying to delete charaacters, characters aren't deleted by the first press of Backspace or Delete after using arrow keys. After typing some characters (numbers) in the shadow distance field, first press of Backspace or Delete after that can delete characters as expected. In the shadow angle field, without typing numbers or other characters, first press of Backspace or Delete can delete characters as expected. After editing angle, first Backspace or Delete in the shadow distance field can delete characters as expected, but just focusing to angle field before focusing to distance field couldn't make the first press work. I also tried selecting multiple characters in the distance field and pressing Backspace key. The result is similar: the characters aren't deleted in the first attempt, but are deleted in the second attempt. Steps to Reproduce: 1. Open LibreOffice Impress from the Start menu. 2. Click "Rectangle" button in the tool bar and put a rectangle. (arbitrary size and position is OK) 3. In the property of the rectangle, turn on check for "enable" in "shadow" 4. Click just right of "6" (before "pt") in the "distance" field and put a caret there. 5. Press Backspace key. Actual Results: The caret moves left without deleting the character "6". Expected Results: The character "6" is deleted. Reproducible: Always User Profile Reset: No Additional Info: Tested with LibreOffice 5.4.1.2 (x64) on Windows 7 x64. According to my memory, this bug should be reproduced with LibreOffice 5.3, Windows and Mac OS X version. User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'private/jmux/scheduler-fixes' - 248 commits - android/Bootstrap android/source avmedia/source basctl/source basic/source canvas/Library_canvastools.mk canvas/so
Rebased ref, commits from common ancestor: commit 969e9337f010ac567ec50d138990e7644fdbf4cd Author: Jan-Marek GlogowskiDate: Mon Sep 4 17:40:13 2017 +0200 fixup Change-Id: I67957742ab7795856e2b028ee214febe965a5ed2 diff --git a/vcl/headless/svpinst.cxx b/vcl/headless/svpinst.cxx index 8a805ea345b1..5fcb7c57d602 100644 --- a/vcl/headless/svpinst.cxx +++ b/vcl/headless/svpinst.cxx @@ -306,29 +306,27 @@ SalBitmap* SvpSalInstance::CreateSalBitmap() bool SvpSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) { -// first, check for already queued events. -std::list< SalUserEvent > aEvents; +bool bEvent = false; + +// first, process current user events +std::list< SalUserEvent > aCurrentEvents; { osl::MutexGuard g(m_aEventGuard); if( ! m_aUserEvents.empty() ) { if( bHandleAllCurrentEvents ) -{ -aEvents = m_aUserEvents; -m_aUserEvents.clear(); -} +aCurrentEvents.swap( m_aUserEvents ); else { -aEvents.push_back( m_aUserEvents.front() ); +aCurrentEvents.push_back( m_aUserEvents.front() ); m_aUserEvents.pop_front(); } +bEvent = true; } } - -bool bEvent = !aEvents.empty(); if( bEvent ) { -for( std::list::const_iterator it = aEvents.begin(); it != aEvents.end(); ++it ) +for( auto it = aCurrentEvents.begin(); it != aCurrentEvents.end(); ++it ) { if ( isFrameAlive( it->m_pFrame ) ) { @@ -340,6 +338,9 @@ bool SvpSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) pSvpFrame->PostPaint(); } } + +if ( !bHandleAllCurrentEvents ) +return true; } } diff --git a/vcl/inc/osx/salinst.h b/vcl/inc/osx/salinst.h index 207f6cce7b3c..028b02afe630 100644 --- a/vcl/inc/osx/salinst.h +++ b/vcl/inc/osx/salinst.h @@ -143,9 +143,7 @@ public: // this is needed to avoid duplicate open events through a) command line and b) NSApp's openFile static bool isOnCommandLine( const OUString& ); -void wakeupYield(); - - public: +public: friend class AquaSalFrame; void PostUserEvent( AquaSalFrame* pFrame, SalEvent nType, void* pData ); @@ -163,7 +161,6 @@ public: static const short AppStartTimerEvent = 10; static const short YieldWakeupEvent = 20; static const short DispatchTimerEvent = 30; -static const short PostedUserEvent= 40; static NSMenu* GetDynamicDockMenu(); }; diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx index b663227cf244..c037c9cf5ddf 100644 --- a/vcl/osx/salinst.cxx +++ b/vcl/osx/salinst.cxx @@ -392,21 +392,16 @@ AquaSalInstance::~AquaSalInstance() delete mpSalYieldMutex; } -void AquaSalInstance::wakeupYield() -{ -// wakeup :Yield -if( mbWaitingYield ) -ImplNSAppPostEvent( AquaSalInstance::YieldWakeupEvent, YES ); -} - void AquaSalInstance::PostUserEvent( AquaSalFrame* pFrame, SalEvent nType, void* pData ) { { osl::MutexGuard g( maUserEventListMutex ); maUserEvents.push_back( SalUserEvent( pFrame, pData, nType ) ); } -// notify main loop that an event has arrived -wakeupYield(); +if( mbWaitingYield ) +dispatch_async(dispatch_get_main_queue(),^{ +ImplNSAppPostEvent( AquaSalInstance::YieldWakeupEvent, NO ); +}); } comphelper::SolarMutex* AquaSalInstance::GetYieldMutex() @@ -457,9 +452,6 @@ void AquaSalInstance::handleAppDefinedEvent( NSEvent* pEvent ) case DispatchTimerEvent: AquaSalTimer::handleDispatchTimerEvent(); break; -case YieldWakeupEvent: -// do nothing -break; #if !HAVE_FEATURE_MACOSX_SANDBOX case AppleRemoteControlEvent: // Defined in { @@ -545,8 +537,6 @@ bool AquaSalInstance::RunInMainYield( bool bHandleAllCurrentEvents ) bool AquaSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) { -bool bHadEvent = false; - // ensure that the per thread autorelease pool is top level and // will therefore not be destroyed by cocoa implicitly SalData::ensureThreadAutoreleasePool(); @@ -555,35 +545,39 @@ bool AquaSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) // an own pool for each yield level ReleasePoolHolder aReleasePool; -// Release all locks so that we don't deadlock when we pull pending -// events from the event queue -bool bDispatchUser = true; -while( bDispatchUser ) +bool bHadEvent = false; + +// first, process current user events +std::list< SalUserEvent > aCurrentEvents; { -// get one user event -SalUserEvent aEvent( nullptr, nullptr, SalEvent::NONE ); +osl::MutexGuard g(m_aEventGuard); +if( ! m_aUserEvents.empty() )
[Libreoffice-bugs] [Bug 111073] Fullscreen: incorrect gif's background (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=111073 Caolán McNamarachanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #4 from Caolán McNamara --- mostly missing the palette entries to state what is black and what is white in the 1 bit depth bitmaps in svp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37153] FILEOPEN FORMATTING Writer Text frame moved position after import of Word .doc
https://bugs.documentfoundation.org/show_bug.cgi?id=37153 Justin Lchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104527] [META] DOC bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104527 Bug 104527 depends on bug 37153, which changed state. Bug 37153 Summary: FILEOPEN FORMATTING Writer Text frame moved position after import of Word .doc https://bugs.documentfoundation.org/show_bug.cgi?id=37153 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37153] FILEOPEN FORMATTING Writer Text frame moved position after import of Word .doc
https://bugs.documentfoundation.org/show_bug.cgi?id=37153 --- Comment #15 from Commit Notification--- Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e56f61c4637c09afbf125fa02f131b0c49e36351 tdf#37153 ConsiderWrapOnObjPos: always affect anchoring cell It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111921] Textbox: User defined character style not "saved" properly when applied to text in text box ( an automatic-style is created instead)
https://bugs.documentfoundation.org/show_bug.cgi?id=111921 Alexandre Leclercchanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from Alexandre Leclerc --- Hi, I used the “T” symbol, indeed. And I just remarked that indeed it is impossible to apply a style. But when I made my first experiments, I did not apply the style. In fact I copied and pasted already styled characters into the textbox. The formatting was kept, etc. So to reproduce the behaviour: 1. Type “ABC” in the main editor. 2. Apply character formatting to it. 3. Create the textbox (T icon in the insert menu) 4. Copy the ABC in the main text and paste it into the textbox. The same character formatting is kept, but there is now a disconnection between the character and the style. Now I understand this it is probably not meant to behave like that, but I would certainly have appreciated it. Thank you and best regards! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/data/tdf37153_considerWrapOnObjPos.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport9.cxx| 18 ++ sw/source/core/layout/tabfrm.cxx |4 +- 3 files changed, 20 insertions(+), 2 deletions(-) New commits: commit e56f61c4637c09afbf125fa02f131b0c49e36351 Author: Justin LuthDate: Fri Sep 1 22:37:13 2017 -0400 tdf#37153 ConsiderWrapOnObjPos: always affect anchoring cell MSO doesn't make a distinction where the object is located - whether it is contained within the boundaries of the anchoring cell or not. It always affects the anchoring cell's vertical orientation. Both DOC and DOCX enable this compatibility setting. Change-Id: Ifa066d3549b1a6183360b5b01c659e41c681d492 Reviewed-on: https://gerrit.libreoffice.org/41821 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/qa/extras/ooxmlexport/data/tdf37153_considerWrapOnObjPos.docx b/sw/qa/extras/ooxmlexport/data/tdf37153_considerWrapOnObjPos.docx new file mode 100644 index ..d89baaf084a2 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf37153_considerWrapOnObjPos.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx index 7dbd94bb910f..43639f622cac 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include @@ -568,6 +569,23 @@ DECLARE_OOXMLEXPORT_TEST(testTdf99227, "tdf99227.docx") assertXPath(pXmlDoc, "//w:footnote/w:p/w:r/w:drawing", 1); } +DECLARE_OOXMLEXPORT_TEST(testTdf37153, "tdf37153_considerWrapOnObjPos.docx") +{ +CPPUNIT_ASSERT_EQUAL(text::WrapTextMode_THROUGH, getProperty(getShape(1), "Surround")); + +uno::Reference xTablesSupplier(mxComponent, uno::UNO_QUERY); +uno::Reference xTables(xTablesSupplier->getTextTables(), uno::UNO_QUERY); +uno::Reference xTable(xTables->getByIndex(0), uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(text::VertOrientation::BOTTOM, getProperty(xTable->getCellByName("A1"), "VertOrient")); + +//For MSO compatibility, the textbox should be at the top of the cell, not at the bottom - despite VertOrientation::BOTTOM +xmlDocPtr pXmlDoc = parseLayoutDump(); +sal_Int32 nFlyTop = getXPath(pXmlDoc, "/root/page/body/tab/row/cell[1]/txt/anchored/fly/infos/bounds", "top").toInt32(); +CPPUNIT_ASSERT_MESSAGE("FlyTop should be 2865, not 5649", nFlyTop < sal_Int32(3000)); +sal_Int32 nTextTop = getXPath(pXmlDoc, "/root/page/body/tab/row/cell[2]/txt[1]/infos/bounds", "top").toInt32(); +CPPUNIT_ASSERT_MESSAGE("TextTop should be 3856", nTextTop > 3000); +} + DECLARE_OOXMLEXPORT_TEST(testTdf82173_footnoteStyle, "tdf82173_footnoteStyle.docx") { uno::Reference xFootnotesSupplier(mxComponent, uno::UNO_QUERY); diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx index 34420867ca42..efcc0df63223 100644 --- a/sw/source/core/layout/tabfrm.cxx +++ b/sw/source/core/layout/tabfrm.cxx @@ -4974,7 +4974,8 @@ void SwCellFrame::Format( vcl::RenderContext* /*pRenderContext*/, const SwBorder for (SwAnchoredObject* pAnchoredObj : *pPg->GetSortedObjs()) { SwRect aTmp( pAnchoredObj->GetObjRect() ); -if ( aTmp.IsOver( aRect ) ) +const SwFrame* pAnch = pAnchoredObj->GetAnchorFrame(); +if ( (bConsiderWrapOnObjPos && IsAnLower( pAnch )) || (!bConsiderWrapOnObjPos && aTmp.IsOver( aRect )) ) { const SwFrameFormat& rAnchoredObjFrameFormat = pAnchoredObj->GetFrameFormat(); const SwFormatSurround = rAnchoredObjFrameFormat.GetSurround(); @@ -4990,7 +4991,6 @@ void SwCellFrame::Format( vcl::RenderContext* /*pRenderContext*/, const SwBorder continue; } -const SwFrame* pAnch = pAnchoredObj->GetAnchorFrame(); // #i43913# // #i52904# - no vertical alignment, // if object, anchored inside cell, has temporarily ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112215] New: LibreOffice crashes due to PPD file using CUPS
https://bugs.documentfoundation.org/show_bug.cgi?id=112215 Bug ID: 112215 Summary: LibreOffice crashes due to PPD file using CUPS Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jeti2...@hotmail.com Created attachment 136013 --> https://bugs.documentfoundation.org/attachment.cgi?id=136013=edit Lexmark printer PPD file that makes LibreOffice crash whenever it is parsed. I have a printer that uses a PPD file for the 'Lexmark MS310 Series'. In the PPD file (see attachment) you can find the following two relevant lines: *?FileSystem: "" *?TTRasterizer: "" Even though this is no syntax error according to 'cupstestppd' utility, it is these two lines that make LibreOffice crash (upon opening any Print dialog, and sometimes even when opening an existing file rendering LibreOffice unusable). Removing these lines from the PPD file, and modifying the printer in the CUPS webinterface with these changes, solves the problem. This only occurs when the PPD file is added to a printer, and the CUPS service is running. I have reproduced this issue on two different computers consistently. And using the backtrace parameter, I found that the exception occurs somewhere in a PPDParser related code. This behavior is bad since a PPD file should never be able to crash LibreOffice without any errors/warnings. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112208] FILEOPEN: RTF: Incorrect indent
https://bugs.documentfoundation.org/show_bug.cgi?id=112208 Justin Lchanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | --- Comment #4 from Justin L --- proposed fix: https://gerrit.libreoffice.org/41901 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106757] LO Crashes with fatal error if try to edit master page in sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=106757 --- Comment #12 from mikenyannyan...@gmail.com --- I'm the reporter of the bug marked as duplicate. This bug is reproduced in: Version: 5.4.1.2 (x64) Build ID: ea7cb86e6eeb2bf3a5af73a8fac570321527 CPU threads: 8; OS: Windows 6.1; UI render: default; Locale: ja-JP (ja_JP); Calc: group Windows 7 Home Premium Service Pack 1 x64 Previously I was using LibreOffice 5.2.7 (x86), then updated to 5.3.4 (x64). 5.4.1 (x64) is installed after that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112193] "Fatal Error" dialog appears and crash when I try to edit the master slide (page)
https://bugs.documentfoundation.org/show_bug.cgi?id=112193 --- Comment #3 from mikenyannyan...@gmail.com --- Thank you for advice. This bug is reproduced in version 5.4.1.2 (x64). My 5.3.4 (x64) had been installed after installing 5.2.7 (x86). This might be related? And sorry for creating duplicate. I searched for "fatal error master slide", but it was actually called "master page"... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/headless
vcl/headless/svpgdi.cxx | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) New commits: commit 3cb59bff332b02f607d15b5ed41b4438e8102980 Author: Caolán McNamaraDate: Mon Sep 4 13:34:09 2017 +0100 Resolves: tdf#111483 1 bit bitmaps with non-standard black/white indexes can be left "untoggled" when converted to cairo A1 Change-Id: I18f3e2109cd4b57bce584545090e26c931de1200 Reviewed-on: https://gerrit.libreoffice.org/41895 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx index ce01c4e89230..170d6c6087e6 100644 --- a/vcl/headless/svpgdi.cxx +++ b/vcl/headless/svpgdi.cxx @@ -113,6 +113,7 @@ namespace void Toggle1BitTransparency(const BitmapBuffer& rBuf) { +assert(rBuf.maPalette.GetBestIndex(BitmapColor(Color(COL_BLACK))) == 0); // TODO: make upper layers use standard alpha if (getCairoFormat(rBuf) == CAIRO_FORMAT_A1) { @@ -216,10 +217,14 @@ namespace pAlphaBits.reset( new unsigned char[nImageSize] ); memcpy(pAlphaBits.get(), pMaskBuf->mpBits, nImageSize); -// TODO: make upper layers use standard alpha -unsigned char* pDst = pAlphaBits.get(); -for (int i = nImageSize; --i >= 0; ++pDst) -*pDst = ~*pDst; +const sal_Int32 nBlackIndex = pMaskBuf->maPalette.GetBestIndex(BitmapColor(Color(COL_BLACK))); +if (nBlackIndex == 0) +{ +// TODO: make upper layers use standard alpha +unsigned char* pDst = pAlphaBits.get(); +for (int i = nImageSize; --i >= 0; ++pDst) +*pDst = ~*pDst; +} mask = cairo_image_surface_create_for_data(pAlphaBits.get(), CAIRO_FORMAT_A1, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: git-hook: Catch tab indentation also for makefiles
>> I think temporary GNU make still needs recipe lines to start with tab >> characters? And in any case, our makefiles are apparently written with lots >> of tab characters all over the place. I'd suggest to revert (at least for >> now). > > Yeah, I see that tabs and spaces are mixed in makefiles. That's why I thought > it would be good to make it consistent similar to other source files. > I did not push it yet. It's on gerrit. So I can abandon it. build breaks on my mac when I replace tab with spaces, so please do not make this a demand. rgds jan o ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 105844] FILESAVE: Very slow saving compared to 5.2.5
https://bugs.documentfoundation.org/show_bug.cgi?id=105844 Telestochanged: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs