[Libreoffice-bugs] [Bug 112964] New: Copying Hyperlink between Writer and Textbox in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112964

Bug ID: 112964
   Summary: Copying Hyperlink between Writer and Textbox in
Impress
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Keywords: regression
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: berndbrin...@gmx.de

Hello,   

  If you copy an Hyperlink "( https://de.wikipedia.org/wiki/LibreOffice  )"
with Attribute 
'_top' or '_parent' or '_blank' or '_self' from Writer into a
Textbox in Impress, the URL-String would be modified to the following Form:

"(   https://de.wikipedia.org/wiki/LibreOffice; \t "_top  )"

   The Attribute Name is added at the End of the URL-String
and the Hyperlink does not work. 

This bug comes also by copying the Hyperlink into a Textbox 
in Writer, Impress and Draw. 
  I reported this Bug in earlier Versions (BugNr.108318) and now it is 
back from Hell. 
  I hope you can solve the Problem.

Thanks and Greetings

Bernd Brinker 
Berlin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112963] New: Copying Hyperlink between Applications / Textbox

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112963

Bug ID: 112963
   Summary: Copying Hyperlink between Applications / Textbox
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Keywords: possibleRegression
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: berndbrin...@gmx.de

Hello,   

  If you copy an Hyperlink "( https://de.wikipedia.org/wiki/LibreOffice  )"
with Attribute 
'_top' or '_parent' or '_blank' or '_self' from writer 
into calc, the URL-String would be modified to the following Form:
"(   https://de.wikipedia.org/wiki/LibreOffice; \t "_top  )"
   The Attribute Name is added at the End of the URL-String. 

This bug comes also by copying the Hyperlink into a Textbox 
in writer, impress and draw. 
  I reported this Bug in earlier Versions (BugNr.108318) and now it is 
back from Hell. 
  I hope you can solve the Problem.

Thanks and Greetings

Bernd Brinker 
Berlin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112962] New: Copying Hyperlink between Applications / Textbox

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112962

Bug ID: 112962
   Summary: Copying Hyperlink between Applications / Textbox
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Keywords: possibleRegression
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: berndbrin...@gmx.de

Hello,   

  If you copy an Hyperlink "( https://de.wikipedia.org/wiki/LibreOffice  )"
with Attribute 
'_top' or '_parent' or '_blank' or '_self' from writer 
into calc, the URL-String would be modified to the following Form:
"(   https://de.wikipedia.org/wiki/LibreOffice; \t "_top  )"
   The Attribute Name is added at the End of the URL-String. 

This bug comes also by copying the Hyperlink into a Textbox 
in writer, impress and draw. 
  I reported this Bug in earlier Versions (BugNr.108318) and now it is 
back from Hell. 
  I hope you can solve the Problem.

Thanks and Greetings

Bernd Brinker 
Berlin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112405] Cannot save text document error message as follows. Write Error. Error in writing sub-document styles.xml.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112405

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #3 from Aron Budea  ---
Paul, thanks for the sample. I couldn't reproduce the bug with LO 5.4.1.2 or
5.4.2.2 / Linux. (might be Mac specific)

However, LO 5.4.2.2 was release yesterday, and it resolved someone else's
similar error reported in bug 60769 comment 29, could you please give it a try
with the latest version? (though it's a very generic error message, so it might
be unrelated)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 54157] LibreOffice 4.0 most annoying bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=54157
Bug 54157 depends on bug 60769, which changed state.

Bug 60769 Summary: FILEOPEN, FILESAVE, "Could not save document, error in 
writing sub document context.xml" then corrupt file.
https://bugs.documentfoundation.org/show_bug.cgi?id=60769

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 54157] LibreOffice 4.0 most annoying bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=54157
Bug 54157 depends on bug 60769, which changed state.

Bug 60769 Summary: FILEOPEN, FILESAVE, "Could not save document, error in 
writing sub document context.xml" then corrupt file.
https://bugs.documentfoundation.org/show_bug.cgi?id=60769

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109246] opendocument load indefinitely

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109246

--- Comment #2 from krishna [:kr1shna]  ---
waiting for issue [ 1 ] to resolve. no news since [ 2 ]

[ 1 ] https://bugs.documentfoundation.org/show_bug.cgi?id=111871
[ 2 ]
https://lists.freedesktop.org/archives/libreoffice-qa/2017-September/010267.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62603] Find/Replace affects formatting in undesired ways

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62603

--- Comment #19 from Luke Kendall  ---
Created attachment 136821
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136821=edit
Example file to reproduce the bug

I am just reporting that this bug is still present in 5.4.1.2.

Attached is a very short file with a simple example of the broken behaviour.  I
hope this helps.

Here are the reproduction steps:

1. Open the provided file (RegExp-format-ruin.odt)
2. Open Find and Replace.
3. Copy and paste the Find string provided in the doc into the Find field
4. Copy and paste the Replace string provided in the doc into the Replace field
5. Click Find.
6. Click Replace

Result: note that the Italic style capital "O" changes to Regular.

>From the user perspective, only the space was changed (of course, the whole
matched text was replaced).

All the same, the format or attributes of matched sub-patterns ($1, $2 etc.)
should be preserved when they are replaced.

PS:
===

I feel this is related to similar problems when manually replacing selected
text: the new text typed in is given the format (italic/regular/bold) of the
text immediately to its left, instead of the format of the text that is being
replaced.

Maybe you would prefer a second bug report for that.  I have done so as Bug
112961.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112961] New: EDITING: Editing selected text copies the format of the text to its left

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112961

Bug ID: 112961
   Summary: EDITING: Editing selected text copies the format of
the text to its left
   Product: LibreOffice
   Version: 5.4.1.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: l...@zeta.org.au

Created attachment 136820
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136820=edit
Short example .odt document

When editing text adjacent to text with a different format, the format of the
edited text changes from what it was, to the format to its left.  This has been
true for LibreOffice for many, many years, and it is as annoying or even as
infuriating now as it was then.

Steps to reproduce (See attached document):

1. Prepare some text with different formats.
2. Select the first word (or character) of the text at the start of a new
format.
3. Type some new text in.
4. Instead of keeping its format, the format is copied from the text to its
left.

Expected result: the format of the selected text is unchanged.

I note that this behaviour also seems to be in Calc:
https://bugs.documentfoundation.org/show_bug.cgi?id=107857

I wonder whether it is also the cause of the bug reported here:
62603

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112601] Build issue on Windows when linking mergedlo.dll

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112601

--- Comment #4 from Tomofumi Yagi  ---
(In reply to Xisco Faulí from comment #3)

Hi Xisco Faulí,
Christian Lohmaier committed a patch related to this issue.

https://github.com/LibreOffice/core/commit/499194508c8cf91fbbc21f882bcf4ace77e19eaa#diff-fadefc091c75e3bcea28c2fc8a883b6d

I confirmed that this commit resolved build breakage.
Thanks for fixing!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 54157] LibreOffice 4.0 most annoying bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=54157
Bug 54157 depends on bug 60769, which changed state.

Bug 60769 Summary: FILEOPEN, FILESAVE, "Could not save document, error in 
writing sub document context.xml" then corrupt file.
https://bugs.documentfoundation.org/show_bug.cgi?id=60769

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 54157] LibreOffice 4.0 most annoying bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=54157
Bug 54157 depends on bug 60769, which changed state.

Bug 60769 Summary: FILEOPEN, FILESAVE, "Could not save document, error in 
writing sub document context.xml" then corrupt file.
https://bugs.documentfoundation.org/show_bug.cgi?id=60769

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66058] FILEOPEN: .docx elbow connector routing in diagrams import bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66058

Luke  changed:

   What|Removed |Added

 CC||g.araminow...@gmail.com
 Resolution|WORKSFORME  |FIXED

--- Comment #14 from Luke  ---
This bug was fixed by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c8e3fea4996436d1fd608cf5ef0fdc18f5a8fd7f

GSoC: import VML shape adjustments

Thanks Grzegorz!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112166] Crash on previewing slide fade transition with Intel graphics card in a VM

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112166

--- Comment #10 from jebsoluti...@gmail.com ---
Tested on Windows 10 Professional.  Libreoffice 5.4.2 doesn't crash with Intel
integrated video (i7-2620m).  But the single-frame flicker of showing the
previous slide for a split second is still there.

Also, on Windows 10 the top menu (File, Edit, View, insert, Format, Slide...)
seems to sometimes flicker or become invisible when I move the mouse over it. 
It's like it's being redrawn unnecessarily.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112960] Transitions that do not work in impress on windows 10

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112960

--- Comment #2 from Joimer Reyes  ---
I'm sorry for sending the previous image

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112960] Transitions that do not work in impress on windows 10

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112960

--- Comment #1 from Joimer Reyes  ---
Created attachment 136818
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136818=edit
In this image, I am indicating the transitions effects that don't work in my
operating system

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112960] Transitions that do not work in impress on windows 10

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112960

Joimer Reyes  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112960] New: Transitions that do not work in impress on windows 10

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112960

Bug ID: 112960
   Summary: Transitions that do not work in impress on windows 10
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: joimer_reyes2...@hotmail.com

Created attachment 136817
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136817=edit
In this image, I am indicating the transitions effects that don't work in my
operating system

In impress, installed in windows 10 some transition effects of slides like
vortex, honeycomb and castling do not work. When you apply them, there is no
visual effect on the slide, instead, the monitor screen turns dark.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109062] Two-finger scroll with touchpad is not working on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109062

--- Comment #10 from rwh...@crashwhite.com ---
Confirming this behavior for LibreOffice 5.3.6.1 running on a MacBookAir6,2
with i7 processor running macOS 10.12.6. I have a 139 Kb document with 50 or so
rows of multi-line cells, and scrolling down or across--using either two-finger
gesture on touchpad or Logitech mouse--is halting, laggy, and inconsistent.

As noted previously, scrolling up or to the left works fine.

On the MacBookAir6,2 I downloaded an old copy of LibreOffice 5.2.7002, and the
same 139 Kb document scrolls without issue in any direction, suggesting this is
an issue related to LibreOffice versions after 5.2.7 for macOS.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112166] Crash on previewing slide fade transition with Intel graphics card in a VM

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112166

--- Comment #9 from jebsoluti...@gmail.com ---
I updated to 5.4.2 and the crash still exists:

crashreport.libreoffice.org/stats/crash_details/f5b5ff86-62b6-449b-b8cb-9d862920f90f

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97629] [META] Help Content Modernization

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97629
Bug 97629 depends on bug 112754, which changed state.

Bug 112754 Summary: [NEWHELP] Improve Heading 1 style in help pages displayed 
in browser
https://bugs.documentfoundation.org/show_bug.cgi?id=112754

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112754] [NEWHELP] Improve Heading 1 style in help pages displayed in browser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112754

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |f...@libreoffice.org
   |desktop.org |

--- Comment #2 from Adolfo Jayme  ---
I complied, but with a couple of tweaks:

• 22-px bold looked too large to me, so I’ve added “font-weight: 300”
• I noticed the margin-bottom rule was duplicated unnecessarily, so I’ve
settled
  on 8 px for its global value.

We should consider making this change to the offline help CSS files as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112754] [NEWHELP] Improve Heading 1 style in help pages displayed in browser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112754

--- Comment #1 from Commit Notification 
 ---
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/help/commit/?id=208b4ffb21e49ad906280ce3663852d5a1b83994

tdf#112754 Enlarge H1, make its fonts thinner & increase margin-bottom

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112754] [NEWHELP] Improve Heading 1 style in help pages displayed in browser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112754

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: help3xsl/default.css

[Adolfo Jayme Barrientos]

 help3xsl/default.css |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 208b4ffb21e49ad906280ce3663852d5a1b83994
Author: Adolfo Jayme Barrientos 
Date:   Fri Oct 6 20:09:34 2017 -0500

tdf#112754 Enlarge H1, make its fonts thinner & increase margin-bottom

Change-Id: Ie683cdd429626bfcb1e2ebc0ad8ae88ec1fe50be

diff --git a/help3xsl/default.css b/help3xsl/default.css
index cc8fafb27..d686169b1 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -87,7 +87,7 @@ h3,
 h4,
 h5,
 h6 {
-margin-bottom: 5pt;
+margin-bottom: 8pt;
 color: #18A303;
 }
 p,
@@ -96,10 +96,10 @@ td {
 margin: 2px 2px 2px 2px;
 }
 h1 {
-font-size: 18pt;
-border-bottom: 5px solid #18A303;
+font-size: 22pt;
+font-weight: 300;
+border-bottom: 3px solid #18A303;
 padding-bottom: 6px;
-margin-bottom: 6px;
 }
 h2 {
 font-size: 14pt;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Adolfo Jayme Barrientos]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c5a93cad149618bbd43632f1660a558c34bdbf7e
Author: Adolfo Jayme Barrientos 
Date:   Fri Oct 6 20:09:34 2017 -0500

Updated core
Project: help  208b4ffb21e49ad906280ce3663852d5a1b83994

tdf#112754 Enlarge H1, make its fonts thinner & increase margin-bottom

Change-Id: Ie683cdd429626bfcb1e2ebc0ad8ae88ec1fe50be

diff --git a/helpcontent2 b/helpcontent2
index 0f0c9fd543e5..208b4ffb21e4 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 0f0c9fd543e5ceb5ae6d0a823997bd009b549753
+Subproject commit 208b4ffb21e49ad906280ce3663852d5a1b83994
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - sw/source

[Michael Stahl]

 sw/source/core/doc/docnew.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit b853c74fe6fc661dd0a7594dc877ae5c21dd7a86
Author: Michael Stahl 
Date:   Fri Oct 6 21:39:24 2017 +0200

sw: fix infinite grammar checking idle loop

The grammar checker always wants to be started in DoIdleJobs(),
even if all paragraphs are already marked as checked.

This is because there is currently no call anywhere of
SwRootFrame::SetNeedGrammarCheck(false) to reset the flag
and prevent DoIdleJobs from trying to start the grammar checker.

This call was already there before but was removed without
any justification in commit 9160fe814a46e93da6907e169ce9d58e46fa37f2.

This has become an infinite loop in several Junit tests with commit
53da556c600fa82ba84bc7fdce6a594b43f2b097.

Change-Id: Ibe7ad93442070aac0577725d044281912307d9e8
(cherry picked from commit 05c704d3bea7f9a7ec51ac28d4d55ba8068f2da5)

diff --git a/sw/source/core/doc/docnew.cxx b/sw/source/core/doc/docnew.cxx
index 53b173b7ba28..4c90a33b628e 100644
--- a/sw/source/core/doc/docnew.cxx
+++ b/sw/source/core/doc/docnew.cxx
@@ -185,7 +185,14 @@ bool SwDoc::StartGrammarChecking( bool bSkipStart )
 {
 bStarted = true;
 if ( !bSkipStart )
+{
+for (auto pLayout : GetAllLayouts())
+{   // we're starting it now, don't start grammar checker
+// again until the user modifies the document
+pLayout->SetNeedGrammarCheck(false);
+}
 xGCIterator->startProofreading( xDoc, xFPIP );
+}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108598] FORMATTING Row height is changed or not changed wrongly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108598

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||khaledho...@eglug.org,
   ||r...@post.cz

--- Comment #2 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Khaled Hosny; Could you possibly take a look at this one? Thanks

5e01bd2a91a717cdaccff18de7c44de37b270914 is the first bad commit
commit 5e01bd2a91a717cdaccff18de7c44de37b270914
Author: Norbert Thiebaud 
Date:   Wed Nov 2 17:34:31 2016 -0700

source sha:8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533
author  Khaled Hosny 2016-11-02 21:52:06 (GMT)
committer   Khaled Hosny 2016-11-03 00:17:06
(GMT)
commit  8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533 (patch)
treedb496889434c484a87b13ffcc4650d65e6672129
parent  c8be45889217c555e4bec92af838d0524ceba4e0 (diff)
Revert "Revert "Enable the new text layout engine by default""

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112957] New Mexico! vk Viagra Number +1 (888) 662 4929 Buy Online viagra+ Viagra Customer Service toll free number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112957

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|General |deletionrequest
 Resolution|--- |INVALID
Product|Document Liberation Project |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112956] New Jersey! vk Viagra Phone Number +1 (888) 662 4929 Buy Online viagra+ Viagra Customer Service toll free number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112956

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|General |deletionrequest
 Resolution|--- |INVALID
Product|Document Liberation Project |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112948] Default outline still uses StarSymbol font

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112948

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6515
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Caolán had worked on these for bug 106515 and asked for a new bug if we thought
it was an issue. Guess this is it.

=-ref-=
https://bugs.documentfoundation.org/show_bug.cgi?id=106515#c10

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66058] FILEOPEN: .docx elbow connector routing in diagrams import bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66058

--- Comment #13 from Xisco Faulí  ---
midpoint location issue fixed by 485945bb6327aa2b6ace2b0c4e98ad159067f944

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112861] FILEOPEN: connector's rotation not imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112861

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112861] FILEOPEN: connector's rotation not imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112861

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisected, bisected|

--- Comment #4 from Xisco Faulí  ---
This bug is not a regression.
c8e3fea4996436d1fd608cf5ef0fdc18f5a8fd7f fixed the missing midpoint location
described in bug 66058

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112861] FILEOPEN: connector's rotation not imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112861

raal  changed:

   What|Removed |Added

   Keywords|regression  |

--- Comment #3 from raal  ---
Not a regression, at oldest commit are rows point from up to down. This commit
made it better, only with wrong direction.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83660] VIEWING: In slide show windows taskbar doesnt disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83660

--- Comment #13 from mattreecebent...@gmail.com ---
Still present. You can fix this on a per-file basis by changing the Slide Show
settings as per  Cor Nouws's advice, but this is still the wrong behaviour for
the program when it does not occur on other OS's

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112861] FILEOPEN: connector's rotation not imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112861

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||regression
 CC||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94582] Formula editor UI flickers on mouse movement

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94582

Telesto  changed:

   What|Removed |Added

   Keywords||bibisected, bisected
 CC||glo...@fbihome.de

--- Comment #8 from Telesto  ---
@Jan Marek
You might be interested in this one. It has a timer/scheduler aspect; not sure
if it's the root cause, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112861] FILEOPEN: connector's rotation not imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112861

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||g.araminow...@gmail.com,
   ||r...@post.cz

--- Comment #2 from raal  ---
Grzegorz, please could you look at this problem ? 


485945bb6327aa2b6ace2b0c4e98ad159067f944 is the first bad commit
commit 485945bb6327aa2b6ace2b0c4e98ad159067f944
Author: Norbert Thiebaud 
Date:   Thu Jul 27 07:45:13 2017 -0700

source sha:c8e3fea4996436d1fd608cf5ef0fdc18f5a8fd7f

author  Grzegorz Araminowicz   2017-06-06
06:53:39 (GMT)
committer   Jan Holesovsky 2017-06-09 14:28:11
(GMT)
commit  c8e3fea4996436d1fd608cf5ef0fdc18f5a8fd7f (patch)
tree4a29ae2713515c47afa87a3b2b64445e6a5099f2
parent  9614f12bae668dfe848ae6cc0bac091be106fa8e (diff)
GSoC: import VML shape adjustments

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112949] Dropping file to toolbar won't open the file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112949

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Do you have Quicklaunch enabled? Also what OS? What "Toolbar"--a screen shot
perhaps?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112958] New: Embedded video clip play on NVIDIA display ( yet another OpenGL workaround)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112958

Bug ID: 112958
   Summary: Embedded video clip play on NVIDIA display (yet
another OpenGL workaround)
   Product: LibreOffice
   Version: 5.4.1.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rdbing...@verizon.net

Windows 10 Pro x64

LO Version: 5.4.2.2 (x64)
Build ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4
CPU threads: 8; OS: Windows 6.19; UI render: default; 
Locale: en-US (en_US); Calc: CL
Tools->Options->LibreOffice->View->Graphics Output->Use OpenGL CHECKED, shows
GL currently in use.

K-Lite Mega media codec pack 13.5.8 http://www.codecguide.com/download_kl.htm
HW accel enabled, full ffdshow components installed.

HW config: Laptop display driven by Intel P630 integrated graphics + 2 x
external Dell P2414H displays driven by NVIDIA M1200 GPU w/ driver v385.69
(current), DirectX runtime v12.0.  NVIDIA Control Panel settings are AUTO or
defaults.  No 3D apps in use.  No special NVIDIA settings for LO.

Application: LO Impress with MP4 video with sound embedded using LO INSERT
Audio or Video.  Impress retrieves 1st frame from clip and uses it as the UI
static placeholder at UI play position and size for the embedded media object.

Symptoms:
Impress window on NVIDIA display: Play yields sound only or sometimes at
startup a flicker of video then reversion to static placeholder video frame.
HOWEVER, if the Impress window is disturbed in any way during video play that
forces a re-draw (re-size or grab title bar and wiggle) then video shows for
some time but can revert to static placeholder video frame.  Observed slight
hint that a video play frame could be active *behind* the static frame
placeholder.

Impress window on CPU display: Expected full video play behavior.

EVEN BETTER: Drag Impress window to and fro between displays on Windows
extended desktop during video play and play behavior changes per display as
described above.

Workaround:
After much fiddling with K-Lite codec pack and NVIDIA settings to no joy
received a pointer from a K-Lite forum member to LO bug 107764. The important
dataum in bug 107764 is the state of using OpenGL. Disabled LO use of OpenGL
and now video play works as expected on all displays.  Suggests issue is OpenGL
lib compat with NVIDIA or how LO uses OpenGL in NVIDIA context vice generic PnP
display.  FYI, LO Media Playback Repeat function doesn't.

msinfo32 data cut (per bug 107764) follows.

System Information report written at: 10/06/17 16:33:19
System Name: 
[System Summary]

ItemValue   
OS Name Microsoft Windows 10 Pro
Version 10.0.15063 Build 15063  
Other OS DescriptionNot Available   
OS Manufacturer Microsoft Corporation   
System Name   
System Manufacturer HP  
System ModelHP ZBook 15 G4  
System Type x64-based PC
System SKU  Y4E80AV 
Processor   Intel(R) Xeon(R) CPU E3-1535M v6 @ 3.10GHz, 3096 Mhz, 4
Core(s), 8 Logical Processor(s) 
BIOS Version/Date   HP P70 Ver. 01.02, 6/9/2017 
SMBIOS Version  3.0 
Embedded Controller Version 70.57   
BIOS Mode   UEFI
BaseBoard Manufacturer  HP  
BaseBoard Model Not Available   
BaseBoard Name  Base Board  
Platform Role   Mobile  
Secure Boot State   On  
PCR7 Configuration  Elevation Required to View  
Windows Directory   c:\Windows  
System Directoryc:\Windows\system32 
Boot Device \Device\HarddiskVolume3 
Locale  United States   
Hardware Abstraction Layer  Version = "10.0.15063.502"  
User Name 
Time Zone   Eastern Daylight Time   
Installed Physical Memory (RAM) 16.0 GB 
Total Physical Memory   15.4 GB 
Available Physical Memory   9.29 GB 
Total Virtual Memory17.8 GB 
Available Virtual Memory10.9 GB 
Page File Space 2.38 GB 
Page File   C:\pagefile.sys 
Device Encryption Support   Elevation Required to View  
Hyper-V - VM Monitor Mode ExtensionsYes 
Hyper-V - Second Level Address Translation Extensions   Yes 
Hyper-V - Virtualization Enabled in FirmwareYes 
Hyper-V - Data Execution Protection Yes 

[Display]

ItemValue   
NameIntel(R) HD Graphics P630   
PNP Device ID   PCI\VEN_8086_591D_8275103C_04\3&11583659&2&10
Adapter TypeIntel(R) HD Graphics Family, Intel Corporation compatible   
Adapter Description Intel(R) HD Graphics P630   
Adapter RAM 1.00 GB (1,073,741,824 bytes)   
Installed Drivers  
igdumdim64,igd10iumd64,igd10iumd64,igd12umd64,igdumdim32,igd10iumd32,igd10iumd32,igd12umd32
 
Driver Version  21.20.16.4627   
INF Fileoem94.inf (iKBLD_w10_DS section)
Color PlanesNot Available   
Color Table Entries 

[Libreoffice-bugs] [Bug 111085] EDITING: Changing default master slide design slow and CPU hogging

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111085

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|regression  |
 CC||xiscofa...@libreoffice.org

--- Comment #4 from Xisco Faulí  ---
> Note: It was broken before, but in a different way. Not all the sheet where
> converted before; but it was fast. Now it's slow but working fine

I don't think it's a regression then

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94184] Automatic spell checking makes Writer unresponsive for ~2min

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94184

Xisco Faulí  changed:

   What|Removed |Added

 CC||michael.me...@collabora.com
   ||,
   ||xiscofa...@libreoffice.org

--- Comment #9 from Xisco Faulí  ---
Adding Cc: to Michael Meeks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro]

 loleaflet/src/control/Control.Menubar.js |   19 +--
 1 file changed, 13 insertions(+), 6 deletions(-)

New commits:
commit e78d9a0d915ef9a95bb87359d3f80e7b38bc5699
Author: Henry Castro 
Date:   Fri Oct 6 17:33:26 2017 -0400

loleaflet: add "None (Do not check spelling)" option

Change-Id: Iae5176cf5b6b87b5c9540e392e6e81db7193e83f

diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index 2132417e..57ec87e9 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -175,11 +175,11 @@ L.Control.Menubar = L.Control.extend({
{name: _('Tools'), id: 'tools', type: 'menu', menu: [
{name: _('Automatic spell checking'), type: 
'unocommand', uno: '.uno:SpellOnline'},
{name: _('Language for selection'), type: 
'menu', menu: [
-   {name: _('Reset to Default Language'), 
id: 'resetselection', type: 'unocommand', uno: 
'.uno:LanguageStatus?Language:string=Current_RESET_LANGUAGES'}]},
+   {name: _('None (Do not check 
spelling)'), id: 'noneselection', type: 'unocommand', uno: 
'.uno:LanguageStatus?Language:string=Current_LANGUAGE_NONE'}]},
{name: _('Language for paragraph'), type: 
'menu', menu: [
-   {name: _('Reset to Default Language'), 
id: 'resetparagraph', type: 'unocommand', uno: 
'.uno:LanguageStatus?Language:string=Paragraph_RESET_LANGUAGES'}]},
+   {name: _('None (Do not check 
spelling)'), id: 'noneparagraph', type: 'unocommand', uno: 
'.uno:LanguageStatus?Language:string=Paragraph_LANGUAGE_NONE'}]},
{name: _('Language for entire document'), type: 
'menu', menu: [
-   {name: _('Reset to Default Language'), 
id: 'resetlanguage', type: 'unocommand', 
uno:'.uno:LanguageStatus?Language:string=Default_RESET_LANGUAGES'}]}
+   {name: _('None (Do not check 
spelling)'), id: 'nonelanguage', type: 'unocommand', uno: 
'.uno:LanguageStatus?Language:string=Default_LANGUAGE_NONE'}]}
]},
{name: _('Help'), id: 'help', type: 'menu', menu: [
{name: _('Keyboard shortcuts'), id: 
'keyboard-shortcuts', type: 'action'},
@@ -359,14 +359,21 @@ L.Control.Menubar = L.Control.extend({
 
_onInitMenu: function (e) {
if (e.commandName === '.uno:LanguageStatus') {
-   $menuSelection = $('#menu-resetselection').parent();
-   $menuParagraph = $('#menu-resetparagraph').parent();
-   $menuDefault = $('#menu-resetlanguage').parent();
+   var resetLang = _('Reset to Default Language');
+   $menuSelection = $('#menu-noneselection').parent();
+   $menuParagraph = $('#menu-noneparagraph').parent();
+   $menuDefault = $('#menu-nonelanguage').parent();
for (var lang in e.commandValues) {

$menuSelection.append(this._createLangMenuItem(_(e.commandValues[lang]), 
encodeURIComponent('Current_' + e.commandValues[lang])));

$menuParagraph.append(this._createLangMenuItem(_(e.commandValues[lang]), 
encodeURIComponent('Paragraph_' + e.commandValues[lang])));

$menuDefault.append(this._createLangMenuItem(_(e.commandValues[lang]), 
encodeURIComponent('Default_' + e.commandValues[lang])));
}
+   $menuSelection.append(this._createMenu([{type: 
'separator'}]));
+   $menuParagraph.append(this._createMenu[{type: 
'separator'}]);
+   $menuDefault.append(this._createMenu([{type: 
'separator'}]));
+   
$menuSelection.append(this._createLangMenuItem(resetLang, 
'Current_RESET_LANGUAGES'));
+   
$menuParagraph.append(this._createLangMenuItem(resetLang, 
'Paragraph_RESET_LANGUAGES'));
+   $menuDefault.append(this._createLangMenuItem(resetLang, 
'Default_RESET_LANGUAGES'));
}
},
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104878] Impress works very slow with large sized GIF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104878

Xisco Faulí  changed:

   What|Removed |Added

 CC||armin.le.gr...@me.com,
   ||xiscofa...@libreoffice.org

--- Comment #12 from Xisco Faulí  ---
Adding Cc: to Armin Le Grand

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112943] Colour dropdrown lists are displayed for a fraction of second (gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112943

Xisco Faulí  changed:

   What|Removed |Added

 Whiteboard|64a708cba9b954afe3331f63c58 |
   |218eb53b3d0ce Caolán|
   |McNamara|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112956] New: New Jersey! vk Viagra Phone Number +1 (888) 662 4929 Buy Online viagra+ Viagra Customer Service toll free number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112956

Bug ID: 112956
   Summary: New Jersey! vk Viagra Phone Number +1 (888) 662 4929
Buy Online viagra+ Viagra Customer Service toll free
number
   Product: Document Liberation Project
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xo...@shalar.net

vk Viagra Phone Number +1 (888) 662 4929 Buy Online viagra+ Viagra Customer
Service toll free number

vk Viagra Phone Number +1 (888) 662 4929 Buy Online viagra+ Viagra Customer
Service toll free number

vk Viagra Phone Number +1 (888) 662 4929 Buy Online viagra+ Viagra Customer
Service toll free number

vk Viagra Phone Number +1 (888) 662 4929 Buy Online viagra+ Viagra Customer
Service toll free number

The toll free telephone number to order Viagra online is (888) 662 4929. Speak
with a sales specialist at Viagra when you contact their toll free telephone
number.
Contactviagra support viagra phone number viagra online support viagra customer
service number viagra tech support center viagra customer service viagra
customer care number usa viagra customer number viagra customer support number
viagra customer care number viagra customer care toll free number viagra tech
support viagra technical support viagra support viagra tech support viagra
support center viagra .com customer service viagra customer care number viagra
customer care viagra phone number
phone number for viagra customer service viagra phone support viagra phone
number tech support viagra support phone number
contact viagra by phone viagra contact phone number viagra helpline phone
number viagra phone viagra for phone viagra contact number viagra contact
support
contact viagra viagra contact number usa viagra toll free number
https://community.ebay.com/t5/Getting-Started/vk-Viagra-Phone-Number-1-888-662-4929-Buy-Online-viagra-Viagra/m-p/27541833

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112920] Effects that do not work in impress on windows 10

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112920

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Xisco Faulí  ---
Thanks for reporting this issue.
It has been already reported in bug 91456

*** This bug has been marked as a duplicate of bug 91456 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91456] "Fade smoothly" slide transition is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91456

Xisco Faulí  changed:

   What|Removed |Added

 CC||joimer_reyes2...@hotmail.co
   ||m

--- Comment #21 from Xisco Faulí  ---
*** Bug 112920 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99138] Honeycomb slide transition doesnt work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99138

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #10 from Xisco Faulí  ---
Hi Jay, is it the same issue as bug 91456 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112939] Color on drop-down color chooser is always black instead of chosen color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112939

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected

--- Comment #5 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Noel Grandin; Could you possibly take a look at this one? Thanks

3c0341afe087fc66e782bb87b2bf8d40d4aa39b8 is the first bad commit
commit 3c0341afe087fc66e782bb87b2bf8d40d4aa39b8
Author: Norbert Thiebaud 
Date:   Sat Sep 30 16:47:35 2017 -0700

source sha:404630c6052919c1a0b5dab405084c2a39fc2f5c

author  Noel Grandin  2017-09-27 09:36:18
(GMT)
committer   Noel Grandin  2017-09-27
10:59:25 (GMT)
commit  404630c6052919c1a0b5dab405084c2a39fc2f5c (patch)
treeb27ac3d74104ee750bb1aac45800923632a59b4e
parent  f7445e1014815a9eb02e2c22257bbce32dc43589 (diff)
simplify Bitmap operator==/IsEqual (stage1)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112926] FREEZE with some images images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112926

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
I can't reproduce it in

Version: 6.0.0.0.alpha0+
Build ID: 34f4446b0a5e04465216ff4ec2547aa82e0f06c2
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

could you please try with gtk3 launching LibreOffice with
SAL_USE_VCLPLUGIN=gtk3 instdir/program/swriter

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112927] PDF's made with CutePDF and PDF995

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112927

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Hi Mich,
if you create the document in Writer, why do you use CutePDF? You can export to
PDF using Writer as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/escriba/escriba-5.2' - 2 commits - sw/qa sw/source

[Miklos Vajna]

 sw/qa/extras/uiwriter/data/tdf112860.fodt | 1394 ++
 sw/qa/extras/uiwriter/uiwriter.cxx|   10 
 sw/source/core/layout/ftnfrm.cxx  |1 
 sw/source/core/layout/sectfrm.cxx |2 
 sw/source/core/layout/tabfrm.cxx  |   40 
 5 files changed, 1445 insertions(+), 2 deletions(-)

New commits:
commit bfdc36ede39f5bb165446a6f02b33d82589bd64c
Author: Miklos Vajna 
Date:   Fri Oct 6 22:50:03 2017 +0200

sw: work around layout loop with split sections inside nested tables

This is just a short-term workaround, the actual root cause has to be
fixed (and that fix needs a testcase).

The change just makes sure that once a page is formatted, then a follow
page's table row doesn't invalidate the previous page (when the row is
shrinking), this way avoiding the loop.

Change-Id: Ic4b9252157ed29c3b554f06caf0630e56ba2ac79

diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index 0c6db983d50d..0a336f9cbe76 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -4319,6 +4319,43 @@ SwTwips SwRowFrame::GrowFrame( SwTwips nDist, bool bTst, 
bool bInfo )
 return nReal;
 }
 
+static bool lcl_ContainsNestedTableContainingSection(SwRowFrame* pRow)
+{
+SwFrame* pLower = pRow->Lower();
+if (!pLower)
+return false;
+if (!pLower->IsCellFrame())
+return false;
+SwCellFrame* pOuterCell = static_cast(pLower);
+
+pLower = pOuterCell->Lower();
+if (!pLower)
+return false;
+if (!pLower->IsTabFrame())
+return false;
+SwTabFrame* pInnerTab = static_cast(pLower);
+
+pLower = pInnerTab->Lower();
+if (!pLower)
+return false;
+if (!pLower->IsRowFrame())
+return false;
+SwRowFrame* pInnerRow = static_cast(pLower);
+
+pLower = pInnerRow->Lower();
+if (!pLower)
+return false;
+if (!pLower->IsCellFrame())
+return false;
+SwCellFrame* pInnerCell = static_cast(pLower);
+
+pLower = pInnerCell->Lower();
+if (!pLower)
+return false;
+
+return pLower->IsSctFrame();
+}
+
 SwTwips SwRowFrame::ShrinkFrame( SwTwips nDist, bool bTst, bool bInfo )
 {
 SWRECTFN( this )
@@ -4407,7 +,8 @@ SwTwips SwRowFrame::ShrinkFrame( SwTwips nDist, bool 
bTst, bool bInfo )
  && !pTab->IsInRecalcLowerRow() )
 {
 SwTabFrame* pMasterTab = pTab->FindMaster();
-pMasterTab->InvalidatePos();
+if (!lcl_ContainsNestedTableContainingSection(this))
+pMasterTab->InvalidatePos();
 }
 }
 AdjustCells( (Prt().*fnRect->fnGetHeight)() - nReal, true );
commit f60b65a808d77f4eac813fd8dd3e4688b6372e20
Author: Miklos Vajna 
Date:   Tue Oct 3 17:44:01 2017 +0200

tdf#112860 sw: avoid shortcut for tables in SwFrame::GetNextSctLeaf()

As the comment says the shortcut only works if no columns or pages are
between the section frames, while for tables there are definitely table,
row and column frames. This resulted later in
SwFrame::IsFootnoteAllowed() a nullptr dereference, as the frame was
still marked as in-table, but wasn't in a table anymore.

Reviewed-on: https://gerrit.libreoffice.org/43091
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 
(cherry picked from commit c985ad5f7b479706935459630c5a59ccae6fa8b7)

Conflicts:
sw/qa/extras/uiwriter/uiwriter.cxx

Change-Id: I4191c77d20c6ccc096156fae15ca7c22cc5b68b6

diff --git a/sw/qa/extras/uiwriter/data/tdf112860.fodt 
b/sw/qa/extras/uiwriter/data/tdf112860.fodt
new file mode 100644
index ..845c55ae8f42
--- /dev/null
+++ b/sw/qa/extras/uiwriter/data/tdf112860.fodt
@@ -0,0 +1,1394 @@
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oas
 is:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 

[Libreoffice-bugs] [Bug 112947] Possible write to free'd memory in OResultSet.cxx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112947

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Dear Nick,
Thanks for the plausible fix.
Could you please create a patch and submit it to gerrit as described here:
https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch?
Core developers can review your patch there

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/escriba/escriba-5.2.1' - 2 commits - sw/qa sw/source

[Miklos Vajna]

 sw/qa/extras/uiwriter/data/tdf112860.fodt | 1394 ++
 sw/qa/extras/uiwriter/uiwriter.cxx|   10 
 sw/source/core/layout/ftnfrm.cxx  |1 
 sw/source/core/layout/sectfrm.cxx |2 
 sw/source/core/layout/tabfrm.cxx  |   40 
 5 files changed, 1445 insertions(+), 2 deletions(-)

New commits:
commit a3884863aba7807e7b473a0acb3f7aa4e4ae9a37
Author: Miklos Vajna 
Date:   Fri Oct 6 22:50:03 2017 +0200

sw: work around layout loop with split sections inside nested tables

This is just a short-term workaround, the actual root cause has to be
fixed (and that fix needs a testcase).

The change just makes sure that once a page is formatted, then a follow
page's table row doesn't invalidate the previous page (when the row is
shrinking), this way avoiding the loop.

Change-Id: Ic4b9252157ed29c3b554f06caf0630e56ba2ac79

diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index 0c6db983d50d..0a336f9cbe76 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -4319,6 +4319,43 @@ SwTwips SwRowFrame::GrowFrame( SwTwips nDist, bool bTst, 
bool bInfo )
 return nReal;
 }
 
+static bool lcl_ContainsNestedTableContainingSection(SwRowFrame* pRow)
+{
+SwFrame* pLower = pRow->Lower();
+if (!pLower)
+return false;
+if (!pLower->IsCellFrame())
+return false;
+SwCellFrame* pOuterCell = static_cast(pLower);
+
+pLower = pOuterCell->Lower();
+if (!pLower)
+return false;
+if (!pLower->IsTabFrame())
+return false;
+SwTabFrame* pInnerTab = static_cast(pLower);
+
+pLower = pInnerTab->Lower();
+if (!pLower)
+return false;
+if (!pLower->IsRowFrame())
+return false;
+SwRowFrame* pInnerRow = static_cast(pLower);
+
+pLower = pInnerRow->Lower();
+if (!pLower)
+return false;
+if (!pLower->IsCellFrame())
+return false;
+SwCellFrame* pInnerCell = static_cast(pLower);
+
+pLower = pInnerCell->Lower();
+if (!pLower)
+return false;
+
+return pLower->IsSctFrame();
+}
+
 SwTwips SwRowFrame::ShrinkFrame( SwTwips nDist, bool bTst, bool bInfo )
 {
 SWRECTFN( this )
@@ -4407,7 +,8 @@ SwTwips SwRowFrame::ShrinkFrame( SwTwips nDist, bool 
bTst, bool bInfo )
  && !pTab->IsInRecalcLowerRow() )
 {
 SwTabFrame* pMasterTab = pTab->FindMaster();
-pMasterTab->InvalidatePos();
+if (!lcl_ContainsNestedTableContainingSection(this))
+pMasterTab->InvalidatePos();
 }
 }
 AdjustCells( (Prt().*fnRect->fnGetHeight)() - nReal, true );
commit 84cd7643533aa5b1c4a096ec47fbd44992a03198
Author: Miklos Vajna 
Date:   Tue Oct 3 17:44:01 2017 +0200

tdf#112860 sw: avoid shortcut for tables in SwFrame::GetNextSctLeaf()

As the comment says the shortcut only works if no columns or pages are
between the section frames, while for tables there are definitely table,
row and column frames. This resulted later in
SwFrame::IsFootnoteAllowed() a nullptr dereference, as the frame was
still marked as in-table, but wasn't in a table anymore.

Reviewed-on: https://gerrit.libreoffice.org/43091
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 
(cherry picked from commit c985ad5f7b479706935459630c5a59ccae6fa8b7)

Conflicts:
sw/qa/extras/uiwriter/uiwriter.cxx

Change-Id: I4191c77d20c6ccc096156fae15ca7c22cc5b68b6

diff --git a/sw/qa/extras/uiwriter/data/tdf112860.fodt 
b/sw/qa/extras/uiwriter/data/tdf112860.fodt
new file mode 100644
index ..845c55ae8f42
--- /dev/null
+++ b/sw/qa/extras/uiwriter/data/tdf112860.fodt
@@ -0,0 +1,1394 @@
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oas
 is:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 

[Libreoffice-bugs] [Bug 112952] Calc UI: colors rectangle for color of gradient for figure in Sidebar are black

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112952

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #2 from Xisco Faulí  ---
Regina was a bit faster than you ;-)

*** This bug has been marked as a duplicate of bug 112939 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112939] Color on drop-down color chooser is always black instead of chosen color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112939

Xisco Faulí  changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #4 from Xisco Faulí  ---
*** Bug 112952 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112955] New Hampshire! vk Viagra Phone Number +1 (888) 662 4929 Buy Online viagra+ Viagra Customer Service toll free number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112955

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|General |deletionrequest
 Resolution|--- |INVALID
Product|Document Liberation Project |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112954] Nevada! vk Viagra Phone Number +1 (888) 662 4929 Buy Online viagra+ Viagra Customer Service toll free number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112954

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|General |deletionrequest
 Resolution|--- |INVALID
Product|Document Liberation Project |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81684] Strange spacing of greek letters in 'over' denominator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81684

--- Comment #8 from arrowdodger  ---
I confirm the bug is still there. LO 5.4.1.2 on Windows x64.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112952] Calc UI: colors rectangle for color of gradient for figure in Sidebar are black

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112952

--- Comment #1 from kompilainenn <79045_79...@mail.ru> ---
Created attachment 136816
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136816=edit
Screenshot with two black rectangles instead color rectangles

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112952] New: Calc UI: colors rectangle for color of gradient for figure in Sidebar are black

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112952

Bug ID: 112952
   Summary: Calc UI: colors rectangle for color of gradient for
figure in Sidebar are black
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Description:
Calc UI: colors rectangle for color of gradient for figure in Sidebar are black
(see screenshot from attach). LO with autoupdater from Markus, OpenGL - off!

Version: 6.0.0.0.alpha0+
Build ID: ca95e886b42157d1d6394ed0b4c910978f5c2fda
CPU threads: 4; OS: Windows 6.1; UI render: default; 
Locale: ru-RU (ru_RU); Calc: CL

Steps to Reproduce:
1. Open Calc
2. Draw any figure and select it
3. Open Sidebar
4. Select in Area fill -> Gradient
5. On two drop-down lists there are color rectangle. They both are black
instead color for any select color. 

Actual Results:  
both color rectangles are black instead color for any select color. 

Expected Results:
each rectangle is right color


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/jmux/scheduler-fixes' - 6 commits - connectivity/source sc/qa sc/source svx/source sw/source vcl/inc vcl/osx vcl/source vcl/win

[Jan-Marek Glogowski]

Rebased ref, commits from common ancestor:
commit de21edd69c985de4be8ee637cc61824e87e53d2a
Author: Jan-Marek Glogowski 
Date:   Fri Sep 29 22:24:15 2017 +0200

WIP Fix unprocessed shutdown events

DO NOT MERGE!

This is just a test patch, since I can't reproduce the
Jenkins failures locally. It's not "make check" tested,
just "make vcl".

This fixes multiple problems, which I missed.

We're not interested in WM_TIMER events, but in active
SAL_MSG_TIMER_CALLBACK, which is indicated by PollForMessage().

This includes a revert of "tdf#38915: don't wait on message queue
if application already has quit.", which is commited as
f054b9187155bc32b7d06808aea87127cb0a3a4f.

We can't ignore the wait flag, just because the application will
quit, as we have to deliver the expected event announced by
pTimer->PollForMessage().

And we don't try to "clean" the message queue, as invalid events
are simply identified by there version ID.

On Mac we can probably drop the workaround. We can't wait for a
timer event in a redirected dispatch_async, for whatever reason.

Change-Id: If806d41c6fcfce10b0c4c7fdcf1df5df6ac16a1d

diff --git a/vcl/inc/win/saltimer.h b/vcl/inc/win/saltimer.h
index 5ad6a1718f19..532765e050f0 100644
--- a/vcl/inc/win/saltimer.h
+++ b/vcl/inc/win/saltimer.h
@@ -34,7 +34,7 @@ class WinSalTimer final : public SalTimer, protected 
VersionedEvent
 
 void ImplStart( sal_uIntPtr nMS );
 void ImplStop();
-void ImplEmitTimerCallback();
+void ImplHandleTimerEvent( WPARAM aWPARAM );
 
 public:
 WinSalTimer();
@@ -43,16 +43,9 @@ public:
 virtual void Start(sal_uIntPtr nMS) override;
 virtual void Stop() override;
 
-inline bool IsValidWPARAM( WPARAM wParam ) const;
-
 inline bool PollForMessage() const;
 };
 
-inline bool WinSalTimer::IsValidWPARAM( WPARAM aWPARAM ) const
-{
-return IsValidEventVersion( static_cast( aWPARAM ) );
-}
-
 inline bool WinSalTimer::PollForMessage() const
 {
 return m_bPollForMessage;
diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index d475f30275b0..0334087f57cf 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -570,10 +570,10 @@ bool AquaSalInstance::DoYield(bool bWait, bool 
bHandleAllCurrentEvents)
 // handle available events
 NSEvent* pEvent = nil;
 NSTimeInterval now = [[NSProcessInfo processInfo] systemUptime];
+AquaSalInstance *pInst = GetSalData()->mpInstance;
 do
 {
 SolarMutexReleaser aReleaser;
-
 SAL_WNODEPRECATED_DECLARATIONS_PUSH
 // 'NSAnyEventMask' is deprecated: first deprecated in macOS 10.12
 pEvent = [NSApp nextEventMatchingMask: NSAnyEventMask
@@ -591,6 +591,8 @@ SAL_WNODEPRECATED_DECLARATIONS_POP
 
 [NSApp updateWindows];
 
+if ( AquaSalInstance::AnyInput( VclInputFlags::TIMER ) && 
!pInst->mbNoYieldLock && !bHadEvent )
+continue;
 if ( !bHandleAllCurrentEvents || !pEvent || now < [pEvent 
timestamp] )
 break;
 }
@@ -618,7 +620,7 @@ SAL_WNODEPRECATED_DECLARATIONS_POP
 }
 
 // collect update rectangles
-for( auto pSalFrame : GetSalData()->mpInstance->getFrames() )
+for( auto pSalFrame : pInst->getFrames() )
 {
 AquaSalFrame* pFrame = static_cast( pSalFrame );
 if( pFrame->mbShown && ! pFrame->maInvalidRect.IsEmpty() )
diff --git a/vcl/osx/saltimer.cxx b/vcl/osx/saltimer.cxx
index 877fdfae85b5..e6336fbedd6e 100644
--- a/vcl/osx/saltimer.cxx
+++ b/vcl/osx/saltimer.cxx
@@ -44,30 +44,8 @@ SAL_WNODEPRECATED_DECLARATIONS_POP
subtype: nEventId
data1: nUserData
data2: 0];
-assert( pEvent );
 if ( nil == pEvent )
-return;
-if ( NO == bAtStart )
-{
-// nextEventMatchingMask has to run in the main thread!
-assert([NSThread isMainThread]);
-
-// Posting an event to the end of an empty queue fails,
-// so we peek the queue and post to the start, if empty.
-// Some Qt bugs even indicate nextEvent without dequeue
-// sometimes blocks, so we dequeue and re-add the event.
-SAL_WNODEPRECATED_DECLARATIONS_PUSH
-// 'NSAnyEventMask' is deprecated: first deprecated in macOS 10.12
-NSEvent* pPeekEvent = [NSApp nextEventMatchingMask: NSAnyEventMask
-SAL_WNODEPRECATED_DECLARATIONS_POP
-   untilDate: nil
-   inMode: NSDefaultRunLoopMode
-   dequeue: YES];
-if ( nil == pPeekEvent )
-bAtStart = YES;
-else
-[NSApp postEvent: pPeekEvent atStart: YES];
-}
+std::abort();
 [NSApp postEvent: pEvent atStart: bAtStart];
 }
 
diff --git a/vcl/source/app/scheduler.cxx 

[Libreoffice-commits] core.git: sc/qa sc/source

[Tamás Zolnai]

 sc/qa/unit/data/xlsx/pivottable_outline_mode.xlsx |binary
 sc/qa/unit/subsequent_export-test.cxx |   19 +++
 sc/source/filter/excel/xepivotxml.cxx |6 ++
 3 files changed, 25 insertions(+)

New commits:
commit ad439ded005cffd525ffe874f535fca7a4da1f49
Author: Tamás Zolnai 
Date:   Fri Oct 6 20:35:54 2017 +0200

tdf#112946: Pivot table: Missing selector for a row field after RT in Calc

We need to explicitly set compact flags to false, since true is
the default. It seems MSO prefers compact mode, when the file
contains colliding mode flags.

Change-Id: Ib311f1cf44345be294e6c6607c227c2baa0fb693
Reviewed-on: https://gerrit.libreoffice.org/43210
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 

diff --git a/sc/qa/unit/data/xlsx/pivottable_outline_mode.xlsx 
b/sc/qa/unit/data/xlsx/pivottable_outline_mode.xlsx
new file mode 100755
index ..6b575c0af7b3
Binary files /dev/null and b/sc/qa/unit/data/xlsx/pivottable_outline_mode.xlsx 
differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index d0596bdf06ef..21837ff11152 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -226,6 +226,7 @@ public:
 void testPivotTableBoolFieldFilterXLSX();
 void testPivotTableRowColPageFieldFilterXLSX();
 void testPivotTableErrorItemFilterXLSX();
+void testPivotTableOutlineModeXLSX();
 
 CPPUNIT_TEST_SUITE(ScExportTest);
 CPPUNIT_TEST(test);
@@ -346,6 +347,7 @@ public:
 CPPUNIT_TEST(testPivotTableBoolFieldFilterXLSX);
 CPPUNIT_TEST(testPivotTableRowColPageFieldFilterXLSX);
 CPPUNIT_TEST(testPivotTableErrorItemFilterXLSX);
+CPPUNIT_TEST(testPivotTableOutlineModeXLSX);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -5251,6 +5253,23 @@ void ScExportTest::testPivotTableErrorItemFilterXLSX()
 xDocSh->DoClose();
 }
 
+void ScExportTest::testPivotTableOutlineModeXLSX()
+{
+ScDocShellRef xShell = loadDoc("pivottable_outline_mode.", FORMAT_XLSX);
+CPPUNIT_ASSERT(xShell.is());
+
+std::shared_ptr pXPathFile = 
ScBootstrapFixture::exportTo(&(*xShell), FORMAT_XLSX);
+xmlDocPtr pTable = XPathHelper::parseExport(pXPathFile, m_xSFactory, 
"xl/pivotTables/pivotTable1.xml");
+CPPUNIT_ASSERT(pTable);
+
+// Next to the outline flags, compact flags also should be set (true is 
the default)
+assertXPath(pTable, "/x:pivotTableDefinition", "outline", "1");
+assertXPath(pTable, "/x:pivotTableDefinition", "outlineData", "1");
+assertXPath(pTable, "/x:pivotTableDefinition", "compact", "0");
+assertXPath(pTable, "/x:pivotTableDefinition", "compactData", "0");
+assertXPath(pTable, 
"/x:pivotTableDefinition/x:pivotFields/x:pivotField[1]", "compact", "0");
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(ScExportTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xepivotxml.cxx 
b/sc/source/filter/excel/xepivotxml.cxx
index 9bc8836a57f4..6f9f7106f997 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -674,6 +674,8 @@ void XclExpXmlPivotTables::SavePivotTableXml( 
XclExpXmlStream& rStrm, const ScDP
 XML_indent, ToPsz10(false),
 XML_outline, ToPsz10(true),
 XML_outlineData, ToPsz10(true),
+XML_compact, ToPsz10(false),
+XML_compactData, ToPsz10(false),
 FSEND);
 
 // NB: Excel's range does not include page field area (if any).
@@ -723,6 +725,7 @@ void XclExpXmlPivotTables::SavePivotTableXml( 
XclExpXmlStream& rStrm, const ScDP
 {
 pPivotStrm->singleElement(XML_pivotField,
 XML_showAll, ToPsz10(false),
+XML_compact, ToPsz10(false),
 FSEND);
 continue;
 }
@@ -733,6 +736,7 @@ void XclExpXmlPivotTables::SavePivotTableXml( 
XclExpXmlStream& rStrm, const ScDP
 {
 pPivotStrm->singleElement(XML_pivotField,
 XML_showAll, ToPsz10(false),
+XML_compact, ToPsz10(false),
 FSEND);
 continue;
 }
@@ -742,6 +746,7 @@ void XclExpXmlPivotTables::SavePivotTableXml( 
XclExpXmlStream& rStrm, const ScDP
 pPivotStrm->singleElement(XML_pivotField,
 XML_dataField, ToPsz10(true),
 XML_showAll, ToPsz10(false),
+XML_compact, ToPsz10(false),
 FSEND);
 
 continue;
@@ -810,6 +815,7 @@ void XclExpXmlPivotTables::SavePivotTableXml( 
XclExpXmlStream& rStrm, const ScDP
 if (!bHasDefaultSubtotal)
 pAttList->add(XML_defaultSubtotal, ToPsz10(false));
 
+pAttList->add( XML_compact, ToPsz10(false));
 sax_fastparser::XFastAttributeListRef xAttributeList(pAttList);
 pPivotStrm->startElement(XML_pivotField, xAttributeList);
 

[Libreoffice-bugs] [Bug 112745] FILEOPEN: DOCX - Unknown area at the top of document between margin and first line

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112745

--- Comment #3 from Yousuf Philips (jay)  ---
I assume this is text grid related, as modifying the settings in text grid tab
of page style does decrease the height of the space. Below is an example of how
i was able to slightly decrease the size of the space.

steps:
1. Format > Page > Text Grid (you need to have asian support enabled)
2. set to 'Grid (lines and characters)'
3. uncheck 'snap to characters'
4. set to 'No Grid'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Michael Stahl]

 sw/source/core/doc/docnew.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit 05c704d3bea7f9a7ec51ac28d4d55ba8068f2da5
Author: Michael Stahl 
Date:   Fri Oct 6 21:39:24 2017 +0200

sw: fix infinite grammar checking idle loop

The grammar checker always wants to be started in DoIdleJobs(),
even if all paragraphs are already marked as checked.

This is because there is currently no call anywhere of
SwRootFrame::SetNeedGrammarCheck(false) to reset the flag
and prevent DoIdleJobs from trying to start the grammar checker.

This call was already there before but was removed without
any justification in commit 9160fe814a46e93da6907e169ce9d58e46fa37f2.

This has become an infinite loop in several Junit tests with commit
53da556c600fa82ba84bc7fdce6a594b43f2b097.

Change-Id: Ibe7ad93442070aac0577725d044281912307d9e8

diff --git a/sw/source/core/doc/docnew.cxx b/sw/source/core/doc/docnew.cxx
index 9e2a82d3083c..d414b920aef0 100644
--- a/sw/source/core/doc/docnew.cxx
+++ b/sw/source/core/doc/docnew.cxx
@@ -172,7 +172,14 @@ bool SwDoc::StartGrammarChecking( bool bSkipStart )
 {
 bStarted = true;
 if ( !bSkipStart )
+{
+for (auto pLayout : GetAllLayouts())
+{   // we're starting it now, don't start grammar checker
+// again until the user modifies the document
+pLayout->SetNeedGrammarCheck(false);
+}
 xGCIterator->startProofreading( xDoc, xFPIP );
+}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 112950] PDF export of RTL text messed up in some cases

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112950

Eyal Rozenberg  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Eyal Rozenberg  ---
Note you'll need the David CLM font. You can get it here:

https://sourceforge.net/projects/culmus/files/culmus/0.131/culmus-0.131.tar.gz/download

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112950] PDF export of RTL text messed up in some cases

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112950

--- Comment #1 from Eyal Rozenberg  ---
Created attachment 136815
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136815=edit
PDF export result

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112950] New: PDF export of RTL text messed up in some cases

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112950

Bug ID: 112950
   Summary: PDF export of RTL text messed up in some cases
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyal...@technion.ac.il

Created attachment 136814
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136814=edit
ODT document whose PDF export gets messed up

I'm using LO writer 5.4.2.2 release on Linux Mint 18.2.

I have an ODT document which has (probably) been edited by MS Word at some
point. When I export it to PDF, some of the Hebrew letters overlap each other,
some don't. On the second page, after having pressed the numbered list toolbar
button, the PDF export renders the text almost properly, but not quite -
sapcing is off. Specifically, notice the lack of distance between the rightmost
Heh (ה) and Ain (ע) on the top line on page 2.

Finally, when I remove the end of the paragraph and keep most of the first line
- on page 3 - the rendering looks just fine.

I suspect this is not a recent regression, since I recall having experienced
this with previous versions - but now I got annoyed enough to spend the time
creating a small manifesting example and reporting it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: connectivity/source

[Noel Grandin]

 connectivity/source/drivers/evoab2/NStatement.cxx |   32 +-
 connectivity/source/drivers/evoab2/NStatement.hxx |6 ++--
 connectivity/source/drivers/odbc/OConnection.cxx  |   29 ---
 connectivity/source/inc/odbc/OConnection.hxx  |7 ++--
 4 files changed, 33 insertions(+), 41 deletions(-)

New commits:
commit c8cbcd77484d8172d76d0758f16f9b340277fa52
Author: Noel Grandin 
Date:   Fri Oct 6 15:57:05 2017 +0200

use more rtl::Reference in connectivity

instead of manual ref counting

Change-Id: I210d4a2cd6487bd2d7d81a53106b484fe411ca9b
Reviewed-on: https://gerrit.libreoffice.org/43203
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/connectivity/source/drivers/evoab2/NStatement.cxx 
b/connectivity/source/drivers/evoab2/NStatement.cxx
index 58225437ace1..095d2abf7038 100644
--- a/connectivity/source/drivers/evoab2/NStatement.cxx
+++ b/connectivity/source/drivers/evoab2/NStatement.cxx
@@ -72,7 +72,7 @@ OCommonStatement::OCommonStatement(OEvoabConnection* 
_pConnection)
 , ::comphelper::OPropertyContainer(OCommonStatement_IBase::rBHelper)
 , OStatement_CBase( static_cast(_pConnection), this )
 , m_xResultSet(nullptr)
-, m_pConnection(_pConnection)
+, m_xConnection(_pConnection)
 , m_aParser(_pConnection->getDriver().getComponentContext())
 , m_aSQLIterator( _pConnection, 
_pConnection->createCatalog()->getTables(), m_aParser )
 , m_pParseTree(nullptr)
@@ -85,8 +85,6 @@ OCommonStatement::OCommonStatement(OEvoabConnection* 
_pConnection)
 , m_nResultSetConcurrency(ResultSetConcurrency::UPDATABLE)
 , m_bEscapeProcessing(true)
 {
-m_pConnection->acquire();
-
 #define REGISTER_PROP( id, member ) \
 registerProperty( \
 OMetaConnection::getPropMap().getNameByIndex( id ), \
@@ -126,9 +124,7 @@ void OCommonStatement::disposing()
 
 disposeResultSet();
 
-if (m_pConnection)
-m_pConnection->release();
-m_pConnection = nullptr;
+m_xConnection.clear();
 
 dispose_ChildImpl();
 OCommonStatement_IBase::disposing();
@@ -198,7 +194,7 @@ OUString 
OCommonStatement::impl_getColumnRefColumnName_throw( const OSQLParseNod
 }
 
 if ( !sColumnName.getLength() )
-m_pConnection->throwGenericSQLException( STR_QUERY_TOO_COMPLEX, *this 
);
+m_xConnection->throwGenericSQLException( STR_QUERY_TOO_COMPLEX, *this 
);
 
 return sColumnName;
 }
@@ -230,7 +226,7 @@ void OCommonStatement::orderByAnalysis( const 
OSQLParseNode* _pOrderByClause, So
 
 // column name -> column field
 if ( !SQL_ISRULE( pColumnRef, column_ref ) )
-m_pConnection->throwGenericSQLException( STR_SORT_BY_COL_ONLY, 
*this );
+m_xConnection->throwGenericSQLException( STR_SORT_BY_COL_ONLY, 
*this );
 const OUString sColumnName( impl_getColumnRefColumnName_throw( 
*pColumnRef ) );
 guint nField = evoab::findEvoabField( sColumnName );
 // ascending/descending?
@@ -301,14 +297,14 @@ EBookQuery *OCommonStatement::whereAnalysis( const 
OSQLParseNode* parseTree )
 )
 )
 {
-m_pConnection->throwGenericSQLException( STR_QUERY_TOO_COMPLEX, 
*this );
+m_xConnection->throwGenericSQLException( STR_QUERY_TOO_COMPLEX, 
*this );
 }
 
 if  (   ( pPrec->getNodeType() != SQLNodeType::Equal )
 &&  ( pPrec->getNodeType() != SQLNodeType::NotEqual )
 )
 {
-m_pConnection->throwGenericSQLException( STR_OPERATOR_TOO_COMPLEX, 
*this );
+m_xConnection->throwGenericSQLException( STR_OPERATOR_TOO_COMPLEX, 
*this );
 }
 
 // recognize the special "0 = 1" condition
@@ -342,7 +338,7 @@ EBookQuery *OCommonStatement::whereAnalysis( const 
OSQLParseNode* parseTree )
 const OSQLParseNode* pPart2 = parseTree->getChild(1);
 
 if( ! SQL_ISRULE( parseTree->getChild( 0 ), column_ref) )
-
m_pConnection->throwGenericSQLException(STR_QUERY_INVALID_LIKE_COLUMN,*this);
+
m_xConnection->throwGenericSQLException(STR_QUERY_INVALID_LIKE_COLUMN,*this);
 
 OUString aColumnName( impl_getColumnRefColumnName_throw( 
*parseTree->getChild( 0 ) ) );
 
@@ -358,7 +354,7 @@ EBookQuery *OCommonStatement::whereAnalysis( const 
OSQLParseNode* parseTree )
 SAL_INFO(
 "connectivity.evoab2",
 "analyseSQL : pAtom->count() = " << pAtom->count());
-
m_pConnection->throwGenericSQLException(STR_QUERY_INVALID_LIKE_STRING,*this);
+
m_xConnection->throwGenericSQLException(STR_QUERY_INVALID_LIKE_STRING,*this);
 }
 
 const sal_Unicode WILDCARD = '%';
@@ -383,7 +379,7 @@ EBookQuery *OCommonStatement::whereAnalysis( const 
OSQLParseNode* parseTree )
 else if( bNotLike )
 {
 // We 

[Libreoffice-commits] core.git: svx/source

[Noel Grandin]

 svx/source/svdraw/svdoole2.cxx |   62 +
 1 file changed, 21 insertions(+), 41 deletions(-)

New commits:
commit 3ee1c87e6cf3fac38e1c7666c4c7ea357f26bec8
Author: Noel Grandin 
Date:   Fri Oct 6 15:57:25 2017 +0200

use more rtl::Reference in SdrLightEmbeddedClient_Impl

instead of manual ref counting

Change-Id: Ia07d5411c45d24934a619016cd8dbfb1fac6cc4b
Reviewed-on: https://gerrit.libreoffice.org/43204
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/svx/source/svdraw/svdoole2.cxx b/svx/source/svdraw/svdoole2.cxx
index 02a41ca31e0a..d2b0470196b7 100644
--- a/svx/source/svdraw/svdoole2.cxx
+++ b/svx/source/svdraw/svdoole2.cxx
@@ -120,7 +120,6 @@ class SdrLightEmbeddedClient_Impl : public 
::cppu::WeakImplHelper
 
 public:
 explicit SdrLightEmbeddedClient_Impl( SdrOle2Obj* pObj );
-void Release();
 
 void SetSizeScale( const Fraction& aScaleWidth, const Fraction& 
aScaleHeight )
 {
@@ -185,16 +184,6 @@ void SAL_CALL SdrLightEmbeddedClient_Impl::changingState( 
const css::lang::Event
 {
 }
 
-void SdrLightEmbeddedClient_Impl::Release()
-{
-{
-SolarMutexGuard aGuard;
-mpObj = nullptr;
-}
-
-release();
-}
-
 void SAL_CALL SdrLightEmbeddedClient_Impl::stateChanged( const 
css::lang::EventObject& /*aEvent*/, ::sal_Int32 nOldState, ::sal_Int32 
nNewState )
 {
 SolarMutexGuard aGuard;
@@ -595,9 +584,9 @@ public:
 svt::EmbeddedObjectRef mxObjRef;
 
 std::unique_ptr mxGraphic;
-OUString maProgName;
+OUStringmaProgName;
 OUStringaPersistName;   // name of object in persist
-SdrLightEmbeddedClient_Impl* pLightClient; // must be registered as client 
only using AddOwnLightClient() call
+rtl::Reference mxLightClient; // must be 
registered as client only using AddOwnLightClient() call
 
 bool mbFrame:1; // Due to compatibility at SdrTextObj for now
 bool mbSuppressSetVisAreaSize:1; // #i118524#
@@ -612,7 +601,6 @@ public:
 rtl::Reference mxModifyListener;
 
 explicit SdrOle2ObjImpl( bool bFrame ) :
-pLightClient (nullptr),
 mbFrame(bFrame),
 mbSuppressSetVisAreaSize(false),
 mbTypeAsked(false),
@@ -626,7 +614,6 @@ public:
 
 SdrOle2ObjImpl( bool bFrame, const svt::EmbeddedObjectRef& rObjRef ) :
 mxObjRef(rObjRef),
-pLightClient (nullptr),
 mbFrame(bFrame),
 mbSuppressSetVisAreaSize(false),
 mbTypeAsked(false),
@@ -713,11 +700,7 @@ SdrOle2Obj::~SdrOle2Obj()
 
 DisconnectFileLink_Impl();
 
-if ( mpImpl->pLightClient )
-{
-mpImpl->pLightClient->Release();
-mpImpl->pLightClient = nullptr;
-}
+mpImpl->mxLightClient.clear();
 }
 
 void SdrOle2Obj::SetAspect( sal_Int64 nAspect )
@@ -962,14 +945,11 @@ void SdrOle2Obj::Connect_Impl()
 
 if ( mpImpl->mxObjRef.is() )
 {
-if ( !mpImpl->pLightClient )
-{
-mpImpl->pLightClient = new SdrLightEmbeddedClient_Impl( 
this );
-mpImpl->pLightClient->acquire();
-}
+if ( !mpImpl->mxLightClient.is() )
+mpImpl->mxLightClient = new SdrLightEmbeddedClient_Impl( 
this );
 
-mpImpl->mxObjRef->addStateChangeListener( mpImpl->pLightClient 
);
-mpImpl->mxObjRef->addEventListener( uno::Reference< 
document::XEventListener >( mpImpl->pLightClient ) );
+mpImpl->mxObjRef->addStateChangeListener( 
mpImpl->mxLightClient.get() );
+mpImpl->mxObjRef->addEventListener( uno::Reference< 
document::XEventListener >( mpImpl->mxLightClient.get() ) );
 
 if ( mpImpl->mxObjRef->getCurrentState() != 
embed::EmbedStates::LOADED )
 GetSdrGlobalData().GetOLEObjCache().InsertObj(this);
@@ -1119,10 +1099,10 @@ void SdrOle2Obj::Disconnect_Impl()
 }
 }
 
-if ( mpImpl->mxObjRef.is() && mpImpl->pLightClient )
+if ( mpImpl->mxObjRef.is() && mpImpl->mxLightClient.is() )
 {
-mpImpl->mxObjRef->removeStateChangeListener ( mpImpl->pLightClient 
);
-mpImpl->mxObjRef->removeEventListener( uno::Reference< 
document::XEventListener >( mpImpl->pLightClient ) );
+mpImpl->mxObjRef->removeStateChangeListener ( 
mpImpl->mxLightClient.get() );
+mpImpl->mxObjRef->removeEventListener( uno::Reference< 
document::XEventListener >( mpImpl->mxLightClient.get() ) );
 mpImpl->mxObjRef->setClientSite( nullptr );
 
 GetSdrGlobalData().GetOLEObjCache().RemoveObj(this);
@@ -1518,8 +1498,8 @@ void SdrOle2Obj::ImpSetVisAreaSize()
 // the client is required to get access to scaling
 SfxInPlaceClient* pClient = SfxInPlaceClient::GetClient( 
dynamic_cast(pModel->GetPersist()), 

[Libreoffice-bugs] [Bug 112528] Can't make chart with specific information in a dynamic table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112528

Julian  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
Version|5.4.1.1 rc  |5.4.1.2 release
 Ever confirmed|1   |0

--- Comment #4 from Julian  ---
Hello Jacques, thanks for your answer.

Apparently, what you did is another solution: take the needed information of
the dynamic table, copy and paste it in another page and make the charts with
the copy-pasted information, but that means (in my oppinion) more steps to
follow. The matter is when you want to make the same thing but selecting
directly the information from the dynamic table, not taking the info apart.
With LibreOffice 5.3.6 it works, without separate the data from the dynamic
table.

Thank you for the attention.



LibreOffice 5.4.1.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Tamás Zolnai]

 sc/source/filter/excel/xepivotxml.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit bab595df78bd05a45f92aa15dca058f27b86d5be
Author: Tamás Zolnai 
Date:   Fri Oct 6 18:55:27 2017 +0200

tdf#112936: Pivot table: LO created XLSX file makes Excel to crash

It's not actually clear, why Excel crashes, but setting the version
makes it working. I expect that this version number (which specifies MSO
Excel versions) makes MSO to handle the pivot table differently. As the
internal implementation of the pivot table was changed in different
versions. The name "DATA" might had a special meaning in the earlier
versions (e.g. XP, MSO 2000) which leads this crash.
So setting the version to MSO 2007 seems a good solution for this.
Older versions not seems a target of LO exported XLSX files in these days.
Also smaller values leads to the crash described in the bug report.

Change-Id: I6e9edc949d1670d657e9277cfd86ff163458
Reviewed-on: https://gerrit.libreoffice.org/43208
Reviewed-by: Tamás Zolnai 
Tested-by: Tamás Zolnai 

diff --git a/sc/source/filter/excel/xepivotxml.cxx 
b/sc/source/filter/excel/xepivotxml.cxx
index 270066f76126..9bc8836a57f4 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -221,6 +221,7 @@ void XclExpXmlPivotCaches::SavePivotCacheXml( 
XclExpXmlStream& rStrm, const Entr
 FSNS(XML_xmlns, XML_r), 
XclXmlUtils::ToOString(rStrm.getNamespaceURL(OOX_NS(officeRel))).getStr(),
 FSNS(XML_r, XML_id), XclXmlUtils::ToOString(aRelId).getStr(),
 XML_recordCount, 
OString::number(rEntry.mpCache->GetDataSize()).getStr(),
+XML_createdVersion, "3", // MS Excel 2007, tdf#112936: setting version 
number makes MSO to handle the pivot table differently
 FSEND);
 
 if (rEntry.meType == Worksheet)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 112949] New: Dropping file to toolbar won't open the file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112949

Bug ID: 112949
   Summary: Dropping file to toolbar won't open the file.
   Product: LibreOffice
   Version: 4.2.8.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: t0...@seznam.cz

Description:
Dropping a file to a toolbar area doesn't open it as if it was opened using the
open dialog. 

Steps to Reproduce:
1. Drag & Drop a file to the toolbar area. 

Actual Results:  
Nothing happens, dropping to a toolbar area is not allowed. 

Expected Results:
Opening the file as if it was opened using the "Open" dialog. 


Reproducible: Always

User Profile Reset: Yes

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/59.0.3071.115 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111627] Cursor keys scroll document in Calc instead of moving

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111627

--- Comment #6 from Aron Budea  ---
There is a bug report to make this setting configurable, bug 112876.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112937] Line break doesn' t work if there is a non-standard space before the closing bracket and and between the closing bracket and slash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112937

t0...@seznam.cz changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111627] Cursor keys scroll document in Calc instead of moving

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111627

--- Comment #5 from Hamid  ---
Found the caveat: changing keyboard layout (which is pressing both shifts)
triggers scroll lock on my keyboard. Of course the keyboard is just reporting
key presses but KDE or X is interpreting it such way. I'll look more into it
and if relevant will notify.

To check for yourself (the options line in the output):

$ setxkbmap -print -verbose 10
Setting verbose level to 10
locale is C
Trying to load rules file ./rules/evdev...
Trying to load rules file /usr/share/X11/xkb/rules/evdev...
Success.
Applied rules from evdev:
rules:  evdev
model:  pc101
layout: us,ir
options:grp_led:scroll,grp:shifts_toggle
Trying to build keymap using the following components:
keycodes:   evdev+aliases(qwerty)
types:  complete
compat: complete+ledscroll(group_lock)
symbols:pc+us+ir:2+inet(evdev)+group(shifts_toggle)
geometry:   pc(pc101)
xkb_keymap {
xkb_keycodes  { include "evdev+aliases(qwerty)" };
xkb_types { include "complete"  };
xkb_compat{ include "complete+ledscroll(group_lock)"};
xkb_symbols   { include "pc+us+ir:2+inet(evdev)+group(shifts_toggle)"  
};
xkb_geometry  { include "pc(pc101)" };
};

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/jmux/scheduler-fixes' - 17 commits - configure.ac filter/source include/svx reportdesign/source sc/CppunitTest_sc_databaserangeobj.mk sc/CppunitTest_sc_

[Jan-Marek Glogowski]

Rebased ref, commits from common ancestor:
commit eff62066d4dc945053e3c003e0aa8adf198d942c
Author: Jan-Marek Glogowski 
Date:   Fri Sep 29 22:24:15 2017 +0200

WIP Fix unprocessed shutdown events

DO NOT MERGE!

This is just a test patch, since I can't reproduce the
Jenkins failures locally. It's not "make check" tested,
just "make vcl".

This fixes multiple problems, which I missed.

We're not interested in WM_TIMER events, but in active
SAL_MSG_TIMER_CALLBACK, which is indicated by PollForMessage().

This includes a revert of "tdf#38915: don't wait on message queue
if application already has quit.", which is commited as
f054b9187155bc32b7d06808aea87127cb0a3a4f.

We can't ignore the wait flag, just because the application will
quit, as we have to deliver the expected event announced by
pTimer->PollForMessage().

And we don't try to "clean" the message queue, as invalid events
are simply identified by there version ID.

On Mac we can probably drop the workaround. We can't wait for a
timer event in a redirected dispatch_async, for whatever reason.

Change-Id: If806d41c6fcfce10b0c4c7fdcf1df5df6ac16a1d

diff --git a/vcl/inc/win/saltimer.h b/vcl/inc/win/saltimer.h
index 5ad6a1718f19..532765e050f0 100644
--- a/vcl/inc/win/saltimer.h
+++ b/vcl/inc/win/saltimer.h
@@ -34,7 +34,7 @@ class WinSalTimer final : public SalTimer, protected 
VersionedEvent
 
 void ImplStart( sal_uIntPtr nMS );
 void ImplStop();
-void ImplEmitTimerCallback();
+void ImplHandleTimerEvent( WPARAM aWPARAM );
 
 public:
 WinSalTimer();
@@ -43,16 +43,9 @@ public:
 virtual void Start(sal_uIntPtr nMS) override;
 virtual void Stop() override;
 
-inline bool IsValidWPARAM( WPARAM wParam ) const;
-
 inline bool PollForMessage() const;
 };
 
-inline bool WinSalTimer::IsValidWPARAM( WPARAM aWPARAM ) const
-{
-return IsValidEventVersion( static_cast( aWPARAM ) );
-}
-
 inline bool WinSalTimer::PollForMessage() const
 {
 return m_bPollForMessage;
diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index d475f30275b0..0334087f57cf 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -570,10 +570,10 @@ bool AquaSalInstance::DoYield(bool bWait, bool 
bHandleAllCurrentEvents)
 // handle available events
 NSEvent* pEvent = nil;
 NSTimeInterval now = [[NSProcessInfo processInfo] systemUptime];
+AquaSalInstance *pInst = GetSalData()->mpInstance;
 do
 {
 SolarMutexReleaser aReleaser;
-
 SAL_WNODEPRECATED_DECLARATIONS_PUSH
 // 'NSAnyEventMask' is deprecated: first deprecated in macOS 10.12
 pEvent = [NSApp nextEventMatchingMask: NSAnyEventMask
@@ -591,6 +591,8 @@ SAL_WNODEPRECATED_DECLARATIONS_POP
 
 [NSApp updateWindows];
 
+if ( AquaSalInstance::AnyInput( VclInputFlags::TIMER ) && 
!pInst->mbNoYieldLock && !bHadEvent )
+continue;
 if ( !bHandleAllCurrentEvents || !pEvent || now < [pEvent 
timestamp] )
 break;
 }
@@ -618,7 +620,7 @@ SAL_WNODEPRECATED_DECLARATIONS_POP
 }
 
 // collect update rectangles
-for( auto pSalFrame : GetSalData()->mpInstance->getFrames() )
+for( auto pSalFrame : pInst->getFrames() )
 {
 AquaSalFrame* pFrame = static_cast( pSalFrame );
 if( pFrame->mbShown && ! pFrame->maInvalidRect.IsEmpty() )
diff --git a/vcl/osx/saltimer.cxx b/vcl/osx/saltimer.cxx
index 877fdfae85b5..e6336fbedd6e 100644
--- a/vcl/osx/saltimer.cxx
+++ b/vcl/osx/saltimer.cxx
@@ -44,30 +44,8 @@ SAL_WNODEPRECATED_DECLARATIONS_POP
subtype: nEventId
data1: nUserData
data2: 0];
-assert( pEvent );
 if ( nil == pEvent )
-return;
-if ( NO == bAtStart )
-{
-// nextEventMatchingMask has to run in the main thread!
-assert([NSThread isMainThread]);
-
-// Posting an event to the end of an empty queue fails,
-// so we peek the queue and post to the start, if empty.
-// Some Qt bugs even indicate nextEvent without dequeue
-// sometimes blocks, so we dequeue and re-add the event.
-SAL_WNODEPRECATED_DECLARATIONS_PUSH
-// 'NSAnyEventMask' is deprecated: first deprecated in macOS 10.12
-NSEvent* pPeekEvent = [NSApp nextEventMatchingMask: NSAnyEventMask
-SAL_WNODEPRECATED_DECLARATIONS_POP
-   untilDate: nil
-   inMode: NSDefaultRunLoopMode
-   dequeue: YES];
-if ( nil == pPeekEvent )
-bAtStart = YES;
-else
-[NSApp postEvent: pPeekEvent atStart: YES];
-}
+std::abort();
 [NSApp postEvent: pEvent atStart: bAtStart];
 }
 
diff --git a/vcl/source/app/scheduler.cxx 

[Libreoffice-bugs] [Bug 112948] New: Default outline still uses StarSymbol font

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112948

Bug ID: 112948
   Summary: Default outline still uses StarSymbol font
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Start a presentation with "Title,Content" slide. Write some lines in the
content and shift the lines to different levels. Save the file. Open
content.xml in an editor.

The font for the list symbols is "StarSymbol", but that font is not delivered
by LibreOffice and not free available. So in most cases a font substitution
will be made.

Request: Use a font, that is delivered by LibreOffice, if a font is needed at
all.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/jmux/libreoffice-4-1+kde4+fixes' - 0 commits -

[Unknown]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/jmux/libreoffice-4-1+kde4' - 0 commits -

[Unknown]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/jmux/libreoffice-4-1-6+backports+unit' - 0 commits -

[Unknown]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/jmux/libreoffice-4-1-6+backports' - 0 commits -

[Unknown]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/jmux/libreoffice-4-1-6+all-no-merge' - 0 commits -

[Unknown]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 112947] New: Possible write to free'd memory in OResultSet.cxx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112947

Bug ID: 112947
   Summary: Possible write to free'd memory in OResultSet.cxx
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: n...@lurcher.org

I noticed while writing an ODBC driver and running with valgrind I noticed that
creating a DB query could lead to the driver writing to free'd space.

Process is in OResultSet.cxx

Row status array is allocated and set in the driver

m_pRowStatusArray = new SQLUSMALLINT[1]; // the default value
setStmtOption(SQL_ATTR_ROW_STATUS_PTR,
m_pRowStatusArray);

However in the destructor, when OResultSet is released, m_pRowStatusArray is
released, but the address is not reset in the ODBC driver, so next time that
statement is used, that address is referenced.

A simple (and seems to work) fix is to reset the value when its released.

OResultSet::~OResultSet()
{
setStmtOption(SQL_ATTR_ROW_STATUS_PTR,
NULL);
delete [] m_pRowStatusArray;
delete m_pSkipDeletedSet;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - sw/inc sw/source

[Jan-Marek Glogowski]

Rebased ref, commits from common ancestor:
commit c8377d3cada65d20786f52db0a14b7e7de6d8324
Author: Jan-Marek Glogowski 
Date:   Fri Oct 6 11:00:19 2017 +0200

Don't schedule the Idle job for busy documents

This refactors DocumentTimerManager to export the busy status
independent of the Idle function. This way it can be ignored in
the Scheduler while the document is busy,

Reviewed-on: https://gerrit.libreoffice.org/43197
Tested-by: Jenkins 
Reviewed-by: Jan-Marek Glogowski 
(cherry picked from commit 53da556c600fa82ba84bc7fdce6a594b43f2b097)

Conflicts:
sw/inc/doc.hxx
sw/source/core/doc/DocumentTimerManager.cxx
sw/source/core/inc/DocumentTimerManager.hxx

Change-Id: Icec2075d3338ad8dd4440678eb0570d7fe887778

diff --git a/sw/inc/IDocumentTimerAccess.hxx b/sw/inc/IDocumentTimerAccess.hxx
index 2cdb33e5ab7d..94947b35ac30 100644
--- a/sw/inc/IDocumentTimerAccess.hxx
+++ b/sw/inc/IDocumentTimerAccess.hxx
@@ -55,6 +55,11 @@ public:
 */
 virtual void StartBackgroundJobs() = 0;
 
+/**
+ * Is the document ready to be processed?
+ */
+virtual bool IsDocIdle() const = 0;
+
 protected:
 virtual ~IDocumentTimerAccess() {};
 };
diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index f154c4379021..9ce4526fcd80 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -238,9 +238,6 @@ typedef std::vector 
SwPageDescs;
 
 void SetAllScriptItem( SfxItemSet& rSet, const SfxPoolItem& rItem );
 
-// global function to start grammar checking in the document
-void StartGrammarChecking( SwDoc  );
-
 // Represents the model of a Writer document.
 class SW_DLLPUBLIC SwDoc :
 public IInterface
@@ -1651,6 +1648,12 @@ public:
 std::swap(mvUnoCursorTable, unoCursorTable);
 }
 
+/**
+ * @param bSkipStart don't actually start the jobs, just check
+ * @returns true if new background checking jobs were started
+ */
+bool StartGrammarChecking( bool bSkipStart = false );
+
 private:
 // Copies master header to left / first one, if necessary - used by 
ChgPageDesc().
 void CopyMasterHeader(const SwPageDesc , const SwFormatHeader 
, SwPageDesc , bool bLeft, bool bFirst);
diff --git a/sw/source/core/doc/DocumentTimerManager.cxx 
b/sw/source/core/doc/DocumentTimerManager.cxx
index f3d71cd48a47..66018bcefca1 100644
--- a/sw/source/core/doc/DocumentTimerManager.cxx
+++ b/sw/source/core/doc/DocumentTimerManager.cxx
@@ -80,27 +80,16 @@ void DocumentTimerManager::StartBackgroundJobs()
 maDocIdle.Start();
 }
 
-IMPL_LINK_TYPED( DocumentTimerManager, DoIdleJobs, Timer*, pIdle, void )
+DocumentTimerManager::IdleJob DocumentTimerManager::GetNextIdleJob() const
 {
-#ifdef TIMELOG
-static ::rtl::Logfile* pModLogFile = 0;
-if( !pModLogFile )
-pModLogFile = new ::rtl::Logfile( "First DoIdleJobs" );
-#endif
-
 SwRootFrame* pTmpRoot = 
m_rDoc.getIDocumentLayoutAccess().GetCurrentLayout();
 if( pTmpRoot &&
 !SfxProgress::GetActiveProgress( m_rDoc.GetDocShell() ) )
 {
 SwViewShell* 
pShell(m_rDoc.getIDocumentLayoutAccess().GetCurrentViewShell());
 for(SwViewShell& rSh : pShell->GetRingContainer())
-{
 if( rSh.ActionPend() )
-{
-pIdle->Start();
-return;
-}
-}
+return IdleJob::Busy;
 
 if( pTmpRoot->IsNeedGrammarCheck() )
 {
@@ -109,59 +98,93 @@ IMPL_LINK_TYPED( DocumentTimerManager, DoIdleJobs, Timer*, 
pIdle, void )
 SvtLinguConfig().GetProperty( OUString(
 UPN_IS_GRAMMAR_AUTO ) ) >>= bIsAutoGrammar;
 
-if (bIsOnlineSpell && bIsAutoGrammar)
-StartGrammarChecking( m_rDoc );
+if( bIsOnlineSpell && bIsAutoGrammar && 
m_rDoc.StartGrammarChecking( true ) )
+return IdleJob::Grammar;
 }
-std::set aAllLayouts = m_rDoc.GetAllLayouts();
-std::set::iterator pLayIter = aAllLayouts.begin();
-for ( ;pLayIter != aAllLayouts.end();++pLayIter )
+
+for ( auto pLayout : m_rDoc.GetAllLayouts() )
 {
-if ((*pLayIter)->IsIdleFormat())
-{
-(*pLayIter)->GetCurrShell()->LayoutIdle();
-// Defer the remaining work.
-pIdle->Start();
-return;
-}
+if( pLayout->IsIdleFormat() )
+return IdleJob::Layout;
 }
 
 SwFieldUpdateFlags nFieldUpdFlag = 
m_rDoc.GetDocumentSettingManager().getFieldUpdateFlags(true);
 if( ( AUTOUPD_FIELD_ONLY == nFieldUpdFlag
-|| AUTOUPD_FIELD_AND_CHARTS == nFieldUpdFlag ) &&
-
m_rDoc.getIDocumentFieldsAccess().GetUpdateFields().IsFieldsDirty()
-// If we switch the field name the Fields are not updated.
-

[Libreoffice-bugs] [Bug 98211] RTL: Paragraph dialog justified combobox doesnt list 'right'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98211

--- Comment #11 from V Stuart Foote  ---
(In reply to Yousuf Philips (jay) from comment #10)
> Yes thats my bad. It is showing up for me as i have asian language support
> enabled, but ideally we should fix those labels as well, because labels like
> 'Left/Top' arent good in my view.

True needs attention, but the Left/Top, Right/Bottom labels for Tabs are hard
coded in .ui, and not linked to CJK use.  

Also, some interesting affects in the ruler(s) not following the vertical text
direction(s) when set in the Page dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] BHS at Libo Conference's hacknight

[Xisco Fauli]

Hello all,

For those attending the LibreOffice conference, there will be a
hacknight on Thursday, October 12, from 7PM to 11PM, at Rome Scout Center.

From the QA team we would like to run a short bug hunting session during
the hacknight where we can focus on a topic or two to work on them.

For now, these are the topics mentioned during the latest QA meeting:

- Notebookbar

- Unconfirmed 'needsDevAdvice' bugs

If you have any other topic in mind, even if you're not attending the
conference, please let us know.

Regards

-- 
Xisco Faulí
Libreoffice QA Team
IRC: x1sc0


___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 112946] Pivot table: Missing selector for a row field after RT in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112946

Tamás Zolnai  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |zolnaitamas2...@gmail.com
   |desktop.org |
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112946] Pivot table: Missing selector for a row field after RT in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112946

--- Comment #1 from Tamás Zolnai  ---
Created attachment 136813
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136813=edit
Simple pivot table in outline view

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112946] New: Pivot table: Missing selector for a row field after RT in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112946

Bug ID: 112946
   Summary: Pivot table: Missing selector for a row field after RT
in Calc
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zolnaitamas2...@gmail.com

Description:
In MSO there are more view types (oultine, tabular, compact). It seems to me LO
calc only supports outline mode. In the attached test document I added a simple
pivot table in outline view in Excel. If I round trip it in Calc and reopen it
in Excel, a popup button / selector is missing in G1 cell for field2 pivot
table field. It seems the issue is that the outline mode is not correctly
exported by Calc.

Steps to Reproduce:
1. Open attached test document in Calc
2. Resave it to an XLSX file
3. Open it in Excel and refresh the table

Actual Results:  
When opening the document, the selector is missing. After an update it switches
to compact mode.

Expected Results:
Selector button should be there after importing the document. After a refresh
the same outline layout should be displayed as in Calc or in the original test
document.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/61.0.3163.100 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/CppunitTest_sc_databaserangeobj.mk sc/CppunitTest_sc_datapilottableobj.mk sc/CppunitTest_sc_namedrangeobj.mk sc/CppunitTest_sc_namedrangesobj.mk sc/CppunitTest_sc_ta

[Jan-Marek Glogowski]

 sc/CppunitTest_sc_databaserangeobj.mk  |1 +
 sc/CppunitTest_sc_datapilottableobj.mk |1 +
 sc/CppunitTest_sc_namedrangeobj.mk |1 +
 sc/CppunitTest_sc_namedrangesobj.mk|1 +
 sc/CppunitTest_sc_tablesheetobj.mk |1 +
 test/source/bootstrapfixture.cxx   |5 +
 vcl/source/app/scheduler.cxx   |3 ++-
 7 files changed, 12 insertions(+), 1 deletion(-)

New commits:
commit 141fe1c5e7fbf67a083b34e49e19b6ea78a0eb2b
Author: Jan-Marek Glogowski 
Date:   Fri Oct 6 12:53:05 2017 +0200

Process all pending events during Cppunit setUp

Larger unit tests collect a lot of events, which are just processed
on shutdown. But since the Scheduler is just an unsorted linked
list, processing these in order is O(n^2) for lookup, which really
adds up, e.g. sw_ooxmlexport8 has 35047 tasks on shutdown.

So this just processes all pending events before running each unit
test.

Also adds missing spellchecking components to some calc tests.

Change-Id: Icf12146015afc17a1f52f79c18f248b72650ad46
Reviewed-on: https://gerrit.libreoffice.org/43199
Tested-by: Jenkins 
Reviewed-by: Jan-Marek Glogowski 

diff --git a/sc/CppunitTest_sc_databaserangeobj.mk 
b/sc/CppunitTest_sc_databaserangeobj.mk
index 528829687311..ff48e3c0a1f6 100644
--- a/sc/CppunitTest_sc_databaserangeobj.mk
+++ b/sc/CppunitTest_sc_databaserangeobj.mk
@@ -73,6 +73,7 @@ $(eval $(call 
gb_CppunitTest_use_components,sc_databaserangeobj,\
 forms/util/frm \
 framework/util/fwk \
 i18npool/util/i18npool \
+linguistic/source/lng \
 oox/util/oox \
 package/source/xstor/xstor \
 package/util/package2 \
diff --git a/sc/CppunitTest_sc_datapilottableobj.mk 
b/sc/CppunitTest_sc_datapilottableobj.mk
index ea953602add4..3ba76c2c288e 100644
--- a/sc/CppunitTest_sc_datapilottableobj.mk
+++ b/sc/CppunitTest_sc_datapilottableobj.mk
@@ -73,6 +73,7 @@ $(eval $(call 
gb_CppunitTest_use_components,sc_datapilottableobj,\
 forms/util/frm \
 framework/util/fwk \
 i18npool/util/i18npool \
+linguistic/source/lng \
 oox/util/oox \
 package/source/xstor/xstor \
 package/util/package2 \
diff --git a/sc/CppunitTest_sc_namedrangeobj.mk 
b/sc/CppunitTest_sc_namedrangeobj.mk
index 3b68504ac429..b18ba6c64569 100644
--- a/sc/CppunitTest_sc_namedrangeobj.mk
+++ b/sc/CppunitTest_sc_namedrangeobj.mk
@@ -73,6 +73,7 @@ $(eval $(call gb_CppunitTest_use_components,sc_namedrangeobj,\
 forms/util/frm \
 framework/util/fwk \
 i18npool/util/i18npool \
+linguistic/source/lng \
 oox/util/oox \
 package/source/xstor/xstor \
 package/util/package2 \
diff --git a/sc/CppunitTest_sc_namedrangesobj.mk 
b/sc/CppunitTest_sc_namedrangesobj.mk
index 49d5f43f9f54..0b7c012c27ce 100644
--- a/sc/CppunitTest_sc_namedrangesobj.mk
+++ b/sc/CppunitTest_sc_namedrangesobj.mk
@@ -73,6 +73,7 @@ $(eval $(call 
gb_CppunitTest_use_components,sc_namedrangesobj,\
 forms/util/frm \
 framework/util/fwk \
 i18npool/util/i18npool \
+linguistic/source/lng \
 oox/util/oox \
 package/source/xstor/xstor \
 package/util/package2 \
diff --git a/sc/CppunitTest_sc_tablesheetobj.mk 
b/sc/CppunitTest_sc_tablesheetobj.mk
index ef212c33574f..c4347c083a9d 100644
--- a/sc/CppunitTest_sc_tablesheetobj.mk
+++ b/sc/CppunitTest_sc_tablesheetobj.mk
@@ -74,6 +74,7 @@ $(eval $(call gb_CppunitTest_use_components,sc_tablesheetobj,\
 framework/util/fwk \
 i18npool/source/search/i18nsearch \
 i18npool/util/i18npool \
+linguistic/source/lng \
 oox/util/oox \
 package/source/xstor/xstor \
 package/util/package2 \
diff --git a/test/source/bootstrapfixture.cxx b/test/source/bootstrapfixture.cxx
index 415292bd2a26..a195db529d71 100644
--- a/test/source/bootstrapfixture.cxx
+++ b/test/source/bootstrapfixture.cxx
@@ -31,6 +31,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -104,6 +105,10 @@ void test::BootstrapFixture::setUp()
 test::BootstrapFixtureBase::setUp();
 
 test_init_impl(m_bAssertOnDialog, m_bNeedUCB, m_xSFactory.get());
+
+#if OSL_DEBUG_LEVEL > 0
+Scheduler::ProcessEventsToIdle();
+#endif
 }
 
 test::BootstrapFixture::~BootstrapFixture()
diff --git a/vcl/source/app/scheduler.cxx b/vcl/source/app/scheduler.cxx
index 5c1b1bc8f5f4..8fd26ec79a55 100644
--- a/vcl/source/app/scheduler.cxx
+++ b/vcl/source/app/scheduler.cxx
@@ -105,7 +105,8 @@ void Scheduler::ImplDeInitScheduler()
 ++nTasks;
 pSchedulerData = pSchedulerData->mpNext;
 }
-SAL_INFO( "vcl.schedule.deinit", "DeInit the scheduler - tasks: " << 
nTasks );
+SAL_INFO( "vcl.schedule.deinit",
+  "DeInit the scheduler - pending tasks: " << nTasks );
 }
 
 // clean up all the sfx::SfxItemDisruptor_Impl Idles
___
Libreoffice-commits mailing list

[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91999

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2861

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112861] FILEOPEN: connector's rotation not imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112861

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=91
   ||999

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: writerfilter/source

[Serge Krot]

 writerfilter/source/ooxml/factoryimpl.py|5 ++---
 writerfilter/source/ooxml/factoryimpl_ns.py |6 --
 2 files changed, 2 insertions(+), 9 deletions(-)

New commits:
commit f4cbd31465d3737855e694b7341fb3bc063d63c4
Author: Serge Krot 
Date:   Wed Oct 4 09:45:53 2017 +0200

related tdf#66398 remove useless breaks

Change-Id: I39caad06bcd645d582c180195a839113759b57a1
Reviewed-on: https://gerrit.libreoffice.org/43159
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/writerfilter/source/ooxml/factoryimpl.py 
b/writerfilter/source/ooxml/factoryimpl.py
index 2168fff556d7..3605892fe71f 100644
--- a/writerfilter/source/ooxml/factoryimpl.py
+++ b/writerfilter/source/ooxml/factoryimpl.py
@@ -25,7 +25,7 @@ def createFastChildContextFromFactory(model):
 (OOXMLFastContextHandler* pHandler, OOXMLFactory_ns::Pointer_t pFactory, 
Token_t Element)
 {
 uno::Reference  aResult;
-Id nDefine = pHandler->getDefine();
+const Id nDefine = pHandler->getDefine();
 
 if (pFactory.get() != NULL)
 {
@@ -33,7 +33,7 @@ def createFastChildContextFromFactory(model):
 Id nElementId;
 if (pFactory->getElementId(nDefine, Element, nResource, nElementId))
 {
-Id nId = pFactory->getResourceId(nDefine, Element);
+const Id nId = pFactory->getResourceId(nDefine, Element);
 
 switch (nResource)
 {""")
@@ -108,7 +108,6 @@ def fastTokenToId(model):
 print("""
 std::string fastTokenToId(sal_uInt32 nToken)
 {
-
 std::string sResult;
 #ifdef DEBUG_WRITERFILTER
 
diff --git a/writerfilter/source/ooxml/factoryimpl_ns.py 
b/writerfilter/source/ooxml/factoryimpl_ns.py
index 1134a14cb331..54e3b8c9060a 100644
--- a/writerfilter/source/ooxml/factoryimpl_ns.py
+++ b/writerfilter/source/ooxml/factoryimpl_ns.py
@@ -235,7 +235,6 @@ def printValueData(values):
 output_else = "else "
 print("else { return false; }")
 print("return true;")
-print("break;")
 print("}")
 
 
@@ -258,7 +257,6 @@ def factoryGetListValue(nsNode):
 appendValueData(values, valueData, 
idToLabel(valueNode.getAttribute("tokenid")))
 printValueData(values)
 print("return false;")
-print("break;")
 
 print("""default:
 break;
@@ -376,7 +374,6 @@ def factoryCreateElementMap(files, nsNode):
 print("default: return false;")
 print("}")
 print("return true;")
-print("break;")
 print("default:")
 print("switch (nId)")
 print("{")
@@ -384,10 +381,7 @@ def factoryCreateElementMap(files, nsNode):
 print("""default: return false;
 }
 return true;
-break;
 }
-
-return false;
 }
 """)
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Serge Krot]

 sw/source/filter/ww8/docxexport.cxx |   22 --
 1 file changed, 16 insertions(+), 6 deletions(-)

New commits:
commit 4054051cd5aee8cbc6cd2b3384b4ab3d6b6a6ace
Author: Serge Krot 
Date:   Mon Oct 2 17:51:24 2017 +0200

tdf#66398 Do not output document protection in docx twice

Change-Id: I16a5f2d3b8ef59e6edfdecd9d2bd19a2c10c80ea
Reviewed-on: https://gerrit.libreoffice.org/43158
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/sw/source/filter/ww8/docxexport.cxx 
b/sw/source/filter/ww8/docxexport.cxx
index 8e6b8d5cce21..4ecd04f7d425 100644
--- a/sw/source/filter/ww8/docxexport.cxx
+++ b/sw/source/filter/ww8/docxexport.cxx
@@ -965,6 +965,7 @@ void DocxExport::WriteSettings()
 // Has themeFontLang information
 uno::Reference< beans::XPropertySet > xPropSet( 
m_pDoc->GetDocShell()->GetBaseModel(), uno::UNO_QUERY_THROW );
 
+bool hasProtectionProperties = false;
 uno::Reference< beans::XPropertySetInfo > xPropSetInfo = 
xPropSet->getPropertySetInfo();
 const OUString aGrabBagName = UNO_NAME_MISC_OBJ_INTEROPGRABBAG;
 if ( xPropSetInfo->hasPropertyByName( aGrabBagName ) )
@@ -1057,8 +1058,12 @@ void DocxExport::WriteSettings()
 
 if (rAttributeList.getLength())
 {
+// we have document protection from from input DOCX file
+
 sax_fastparser::XFastAttributeListRef 
xAttributeList(pAttributeList);
 pFS->singleElementNS(XML_w, XML_documentProtection, 
xAttributeList);
+
+hasProtectionProperties = true;
 }
 }
 }
@@ -1066,13 +1071,18 @@ void DocxExport::WriteSettings()
 
 // Protect form
 // Section-specific write protection
-if 
(m_pDoc->getIDocumentSettingAccess().get(DocumentSettingId::PROTECT_FORM) ||
-m_pSections->DocumentIsProtected())
+if (! hasProtectionProperties)
 {
-pFS->singleElementNS(XML_w, XML_documentProtection,
-FSNS(XML_w, XML_edit), "forms",
-FSNS(XML_w, XML_enforcement), "true",
-FSEND);
+if 
(m_pDoc->getIDocumentSettingAccess().get(DocumentSettingId::PROTECT_FORM) ||
+m_pSections->DocumentIsProtected())
+{
+// we have form protection from Writer or from input ODT file
+
+pFS->singleElementNS(XML_w, XML_documentProtection,
+FSNS(XML_w, XML_edit), "forms",
+FSNS(XML_w, XML_enforcement), "true",
+FSEND);
+}
 }
 
 // finish settings.xml
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Serge Krot]

 sw/source/filter/ww8/docxexport.cxx |   20 +---
 1 file changed, 9 insertions(+), 11 deletions(-)

New commits:
commit 40f627c28deb9c7eacd77c4a2c4e2eb919d5cf88
Author: Serge Krot 
Date:   Mon Oct 2 17:40:59 2017 +0200

tdf#66398 Remove double initialization of the form protection

Change-Id: I639523b55aef1914ddec62aaae44b0dc87346d0b
Reviewed-on: https://gerrit.libreoffice.org/43157
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/sw/source/filter/ww8/docxexport.cxx 
b/sw/source/filter/ww8/docxexport.cxx
index b76c121bb0d2..8e6b8d5cce21 100644
--- a/sw/source/filter/ww8/docxexport.cxx
+++ b/sw/source/filter/ww8/docxexport.cxx
@@ -931,12 +931,6 @@ void DocxExport::WriteSettings()
 pFS->singleElementNS( XML_w, XML_defaultTabStop, FSNS( XML_w, XML_val 
),
 OString::number( m_aSettings.defaultTabStop).getStr(), FSEND );
 
-// Protect form
-if( m_pDoc->getIDocumentSettingAccess().get( 
DocumentSettingId::PROTECT_FORM ))
-{
-pFS->singleElementNS( XML_w, XML_documentProtection, FSNS(XML_w, 
XML_edit), "forms", FSNS(XML_w, XML_enforcement), "1",  FSEND );
-}
-
 // Do not justify lines with manual break
 if( m_pDoc->getIDocumentSettingAccess().get( 
DocumentSettingId::DO_NOT_JUSTIFY_LINES_WITH_MANUAL_BREAK ))
 {
@@ -1070,14 +1064,18 @@ void DocxExport::WriteSettings()
 }
 }
 
+// Protect form
 // Section-specific write protection
-if ( m_pSections->DocumentIsProtected() )
+if 
(m_pDoc->getIDocumentSettingAccess().get(DocumentSettingId::PROTECT_FORM) ||
+m_pSections->DocumentIsProtected())
 {
-pFS->singleElementNS( XML_w, XML_documentProtection,
-  FSNS( XML_w, XML_enforcement ), "true",
-  FSNS( XML_w, XML_edit ), "forms",
-  FSEND );
+pFS->singleElementNS(XML_w, XML_documentProtection,
+FSNS(XML_w, XML_edit), "forms",
+FSNS(XML_w, XML_enforcement), "true",
+FSEND);
 }
+
+// finish settings.xml
 pFS->endElementNS( XML_w, XML_settings );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 112932] Pressing enter in read-only Table of Content doesnt jump to heading

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112932

--- Comment #2 from Alex ARNAUD  ---
(In reply to Yousuf Philips (jay) from comment #1)
> Not sure that pressing enter alone in edit mode should work like that but
> yes a combination shortcut key using enter, would be a useful thing to have.

For me it's not a problem to affect the enter key to activate an item in the
Table of Contents because for the moment enter key doesn't nothing on this
context.

Best regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112945] FORMATTING Tooltips for cell shadow swapped

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112945

--- Comment #1 from Xavier Van Wijmeersch  ---
confirm with

Version: 6.0.0.0.alpha0+
Build ID: 072a077972ada6500151623642db544ff5cb567e
CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs