[Libreoffice-commits] core.git: vcl/source

[Pranav Kant]

 vcl/source/window/window.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 05e4ce8643cc4cba6e86779af162caf79c2c7bf3
Author: Pranav Kant 
Date:   Fri Feb 16 12:25:13 2018 +0530

lok IME: underline characters which are being composed

Change-Id: Ibfc35f1668228400f37ec9b0b0350583483f484d

diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 388c793c03d7..94255057 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -2078,7 +2078,7 @@ void Window::PostExtTextInputEvent(VclEventId nType, 
const OUString& rText)
 {
 std::unique_ptr pAttr(new 
ExtTextInputAttr[rText.getLength()]);
 for (int i = 0; i < rText.getLength(); ++i) {
-pAttr[i] = ExtTextInputAttr::NONE;
+pAttr[i] = ExtTextInputAttr::Underline;
 }
 SalExtTextInputEvent aEvent { rText, pAttr.get(), rText.getLength(), 
EXTTEXTINPUT_CURSOR_OVERWRITE };
 ImplWindowFrameProc(this, SalEvent::ExtTextInput, );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115839] New: fileopen docx unable to change font size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115839

Bug ID: 115839
   Summary: fileopen docx unable to change font size
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: ARM
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kris...@grrlz.net

Created attachment 139982
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139982=edit
screenshot docx font

open attachment 91408 on Bug 73217

current behaviour:
not able to change font size

expected behaviour:
able to change font size

tinderbox: buildname: Android-ARM@24-Bytemark-Hosting
tinderbox: tree: MASTER
tinderbox: pull time 2018-02-18 23:29:44
tinderbox: git sha1s
core:68cebacac864da199ace7fe03db0e054e6b36966

lyf flame 3, android 5.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100735] Date format in the "Document in use" warning window is not localized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100735

--- Comment #3 from Mike Kaganski  ---
A clear candidate to easyhack.

What should be done:

1. Create a LockFileCommon method that would parse the time string back to
TimeValue, and then format back to string using provided locale (it should
presumably use locale's default datetime format).
2. This method should be used wherever currently the
LockFileComponent::EDITTIME string is used (i.e., only when the need to display
the string arises).

We should definitely not try to write localized string to lockfile.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115836] BUILDING: ArrayFunctionsTest:: testArrayFormulasFODS test failed during build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115836

--- Comment #1 from Ｖ字龍(Vdragon)  ---
For the `-march native` compiler flag, my processor is a Intel(R) Core(TM)
i5-4460  CPU @ 3.20GHz with the following flags:

```
fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush
dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm
constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid
aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16
xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand
lahf_lm abm cpuid_fault invpcid_single pti tpr_shadow vnmi flexpriority ept
vpid fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt dtherm ida
arat pln pts
```

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115295] Page separator line is slowing down the page scrolling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115295

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #4 from Buovjaga  ---
Dipankar: do you reproduce with a version 6 appimage?
https://www.libreoffice.org/download/appimage

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107443] FILEOPEN: "Open" in "Document in Use" dialog for non-default file format documents opens read-only

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107443

--- Comment #10 from Mike Kaganski  ---
(In reply to Mike Kaganski from comment #9)
> (the timeout prevents lags when working with files on low-latency filesystems)

Of course, high-latency was meant; sorry for the mistake.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115825] LibreOffice Writer printing bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115825

--- Comment #1 from Imai <14m4...@kobe-du.ac.jp> ---
Issue not reproduced.

OS X EL Capitan
Ver:10.11.3

version: 6.0.1.1
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
CPU threads: 4; OS:Mac OS X 10.11.3; UI render: default; 
local: ja-JP (ja.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115809] Documents dropping attached pictures

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115809

--- Comment #2 from qw...@q.com ---
Should I provide the document with the images dropped?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115600] Missing Messages at the Use of “Navigate by” Function when Document Beginning or End is Reached

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115600

--- Comment #1 from IWAMOTO <14m4...@kobe-du.jp> ---
Did not reproduce in the following environment.

Version: 6.0.1.1 (x64)
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
Locale: ja-JP (ja_JP); 
OS:Winsows7 Home Premium x64

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115838] New: Cannot undo Bold. Italic, underline when applied to more than 19 pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115838

Bug ID: 115838
   Summary: Cannot undo Bold. Italic, underline when applied to
more than 19 pages
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: loveujesus...@gmail.com

Description:
I'm using Libre Office 6.0.1 on Windows 10 version 1709. I prepared a document
in Libre office Writer which consisted of more than 40 pages. I selected all
the pages and pressed 'bold', and I found that once everything was made 'bold',
it couldn't remove (undo) that 'bold' when I pressed it ('bold') again. The
same applies for 'italic' and 'underline'. I also found out that it works
properly till 19 pages.Please help?

Thank you.

Steps to Reproduce:
1.Select more than 30 pages
2.Press "bold" (or italics or underline)
3.Now press "bold"(or italics or underline)
  again.

Actual Results:  
Once the all the 30 pages are made "bold", when you press the "bold" button
again, it won't undo that "bold" 

Expected Results:
After it makes all the 30 pages "bold", it should undo the "bold" when I press
the "bold" button again.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I am very well aware that doing Ctrl + Z will undo the effect of "bold" but
that's not what I want. I'm doing this to remove any "bold" text in between the
30 pages that might have occured accidently.


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Edge/16.16299

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115798] Writer - Table of Contents are moved when saving a .docx format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115798

--- Comment #8 from Imai <14m4...@kobe-du.ac.jp> ---
Issue not reproduced.

OS X EL Capitan
Ver:10.11.3

version: 6.0.1.1
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
CPU threads: 4; OS:Mac OS X 10.11.3; UI render: default; 
local: ja-JP (ja.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107443] FILEOPEN: "Open" in "Document in Use" dialog for non-default file format documents opens read-only

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107443

--- Comment #9 from Mike Kaganski  ---
(In reply to Thomas Lendo from comment #8)
> For me, it's still a regression as it worked well until LibO 5.1.

Unfortunately I cannot see a reliable reproducing steps to be able to test.

As Aron has already explained, two things are considered when the dialogs are
chosen: if there is a lock OO-style file present; and if the document is locked
at filesystem level (i.e., out of the scope of LibreOffice). The logic is that
if the document is not FS-locked, but the lockfile is present, then we might
suspect that the lockfile might be stale from some crash, so it had only been
left by mistake; and in this case, we can suggest to ignore the lockfile. But
if the lockfile is accompanied by FS-lock, then we see that the file is indeed
used right now by some other application, and so we don't offer an option to
override the lockfile.

But I can imagine a situation when (esp. in multiuser environment) a document
had been checked to have no FS lock; but the lockfile is already present. Then
user decides to ignore the lock, so file is tried to open in RW mode. But in
the meantime, the document had been already locked by another application, so
the attempt failed, and RO mode resulted.

I even can imagine that happening because of concurrent MSO installation -
imagine this sequence:

1. User double-clicks a DOCX document on a network share, which has a stale
lockfile from a previous LO session.
2. LO checks the document file, sees no FS lock on it, but detects the
lockfile, and offers to override the lockfile.
3. In the meantime, a timeout elapses that prevents immediate file info display
in Explorer for files on network shares (the timeout prevents lags when working
with files on low-latency filesystems); the DOCX document that had been
selected in Explorer by double-click is started to be analysed by associated
shell extension (simply put, a MSO component opens it in the background to
extract author/stats/preview); and file gets locked for the time being (the
network latency might make this a lengthy operation).
4. User clicks "Open".
5. File cannot be open for editing - RO mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115809] Documents dropping attached pictures

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115809

--- Comment #1 from IWAMOTO <14m4...@kobe-du.jp> ---
Did not reproduce in the following environment


Version: 6.0.1.1 (x64)
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
Locale: ja-JP (ja_JP); 
OS:Winsows7 Home Premium x64

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95633] Find and Replace ‘italic’ brings faulty results or hangs LO.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95633

--- Comment #9 from pieter kristensen  ---
tested on feb 19th 2018 (LO 6.0.1.0 linux). Bug is still prestent. LO hangs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115625] FILEOPEN DOCX: Text Frame Placed on Wrong Position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115625

IWAMOTO <14m4...@kobe-du.jp> changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #5 from IWAMOTO <14m4...@kobe-du.jp> ---
This was reproduced in the following environment.


Version: 6.0.1.1 (x64)
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
Locale: ja-JP (ja_JP);
OS:Winsows7 Home Premium x64

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: is it wise to comment on Bug 115625

[Muhammet Kara]

Hi krishna,

Since you have already tested for the bug on a different platform 
(Android), I don't see any harm on adding your findings to the report.


Cheers,
Muhammet

On 02/17/2018 10:06 AM, krishna wrote:

downloaded test file and screenshots on Bug 115625 using lo viewer master daily 
build

observation: the issue is repro on

tinderbox: buildname: Android-ARM@24-Bytemark-Hosting
tinderbox: tree: MASTER
tinderbox: pull time 2018-02-17 00:05:19
tinderbox: git sha1s
core:05986e7f98ea1c0bd8092500968774ef3f6bcef4

lyf flame 3, android 5.1

my dilemma:

[ 1 ] issue author has expressed concern and set earlier version to 3.6,  i 
assumed it might be inherited from openoffice.

so, dont add comment

[ 2 ] add a comment stating it is repro on lo viewer master daily build.

out of the above two, which one should i choose ?
your suggestions or advice are welcome.

regards,
krishna [ kr1shna ]
--

krishna [ never ever ask about my real name or identity ]

ji-bu-rish: https://github.com/kr1shna-opensource/


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 115835] Calc - Copying Cells in a Row with Conditional formatting - Conditional formatting not copied

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115835

--- Comment #2 from IWAMOTO <14m4...@kobe-du.jp> ---
Do not reproduce.

Version: 6.0.1.1 (x64)
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
Locale: ja-JP (ja_JP); 
OS:Winsows7 Home Premium x64

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: accessibility/source

[Arnaud Versini]

 accessibility/source/extended/accessibletablistbox.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 7d4584a18fac7f37ed0f7b3b26e6e1a9d65da26f
Author: Arnaud Versini 
Date:   Sun Feb 18 10:01:49 2018 +0100

accessibility: Small optimisation in AccessibleTabListBox

Change-Id: Idf351923a57cf608dd4945e3ce639ba8011ecdbb
Reviewed-on: https://gerrit.libreoffice.org/49922
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/accessibility/source/extended/accessibletablistbox.cxx 
b/accessibility/source/extended/accessibletablistbox.cxx
index 48d4b12ef05c..fb2116f74852 100644
--- a/accessibility/source/extended/accessibletablistbox.cxx
+++ b/accessibility/source/extended/accessibletablistbox.cxx
@@ -99,10 +99,10 @@ namespace accessibility
 if (nChildIndex == 0)
 {
 //! so far the actual implementation object only supports column 
headers
-xRet = implGetFixedChild( ::svt::BBINDEX_COLUMNHEADERBAR );
+xRet = implGetHeaderBar( ::svt::BBTYPE_COLUMNHEADERBAR );
 }
 else if (nChildIndex == 1)
-xRet = implGetFixedChild( ::svt::BBINDEX_TABLE );
+xRet = implGetTable();
 
 if ( !xRet.is() )
 throw RuntimeException();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115461] Exporting 3D scenes results in bad quality

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115461

--- Comment #1 from Imai <14m4...@kobe-du.ac.jp> ---
Issue is reproduced.

OS X EL Capitan
Ver:10.11.3

version: 6.0.1.1
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
CPU threads: 4; OS:Mac OS X 10.11.3; UI render: default; 
local: ja-JP (ja.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: regarding Gsoc 2018 project details

[Muhammet Kara]

Hi Dashan,

To get started with the development: 
https://wiki.documentfoundation.org/Development/GetInvolved


GSoC ideas for LibreOffice: 
https://wiki.documentfoundation.org/Development/GSoC/Ideas


Cheers,
Muhammet

On 02/17/2018 11:59 AM, dashan jot singh wrote:

Sir/Madam,
I'm dashan jot singh studying in 2nd year of B.tech in Information 
technology.

I'm interested to know more about your project.
I want to know more about your project, that what actually you expect 
in this project and also what specifications you want in this project

please provide details.


thank you

regards,
Dashan jot Singh
National Institute of Technology Karnataka,surathkal
Email-: 16it216.das...@nitk.edu.in 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 2 commits - extensions/source fpicker/source

[Noel Grandin]

 extensions/source/bibliography/bibconfig.cxx |   20 +---
 extensions/source/bibliography/bibconfig.hxx |2 +-
 fpicker/source/office/OfficeFilePicker.cxx   |   19 +--
 fpicker/source/office/OfficeFilePicker.hxx   |6 --
 fpicker/source/office/iodlg.cxx  |9 -
 fpicker/source/office/iodlgimp.cxx   |2 +-
 fpicker/source/office/iodlgimp.hxx   |2 +-
 7 files changed, 25 insertions(+), 35 deletions(-)

New commits:
commit 9ee96d942603ff45370558c55ff989700b64045e
Author: Noel Grandin 
Date:   Wed Feb 7 12:36:25 2018 +0200

loplugin:useuniqueptr in filepicker

Change-Id: I367bea33bdb9ea3132d3ed079a16b516498b4fcc
Reviewed-on: https://gerrit.libreoffice.org/49947
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/fpicker/source/office/OfficeFilePicker.cxx 
b/fpicker/source/office/OfficeFilePicker.cxx
index 82f9dca8bf12..23aabac5962b 100644
--- a/fpicker/source/office/OfficeFilePicker.cxx
+++ b/fpicker/source/office/OfficeFilePicker.cxx
@@ -407,7 +407,7 @@ void SvtFilePicker::ensureFilterList( const OUString& 
_rInitialCurrentFilter )
 {
 if ( !m_pFilterList )
 {
-m_pFilterList = new FilterList;
+m_pFilterList.reset( new FilterList );
 
 // set the first filter to the current filter
 if ( m_aCurrentFilter.isEmpty() )
@@ -419,22 +419,13 @@ void SvtFilePicker::ensureFilterList( const OUString& 
_rInitialCurrentFilter )
 // class SvtFilePicker
 
 SvtFilePicker::SvtFilePicker()
-:m_pFilterList  ( nullptr )
-,m_pElemList( nullptr )
-,m_bMultiSelection  ( false )
+:m_bMultiSelection  ( false )
 ,m_nServiceType ( TemplateDescription::FILEOPEN_SIMPLE )
 {
 }
 
 SvtFilePicker::~SvtFilePicker()
 {
-if ( m_pFilterList && !m_pFilterList->empty() )
-m_pFilterList->erase( m_pFilterList->begin(), m_pFilterList->end() );
-delete m_pFilterList;
-
-if ( m_pElemList && !m_pElemList->empty() )
-m_pElemList->erase( m_pElemList->begin(), m_pElemList->end() );
-delete m_pElemList;
 }
 
 
@@ -629,7 +620,7 @@ void SAL_CALL SvtFilePicker::setValue( sal_Int16 nElementID,
 else
 {
 if ( !m_pElemList )
-m_pElemList = new ElementList;
+m_pElemList.reset( new ElementList );
 
 bool bFound = false;
 ElementList::iterator aListIter;
@@ -705,7 +696,7 @@ void SAL_CALL SvtFilePicker::setLabel( sal_Int16 nLabelID, 
const OUString& rValu
 else
 {
 if ( !m_pElemList )
-m_pElemList = new ElementList;
+m_pElemList.reset( new ElementList );
 
 bool bFound = false;
 ElementList::iterator aListIter;
@@ -776,7 +767,7 @@ void SAL_CALL SvtFilePicker::enableControl( sal_Int16 
nElementID, sal_Bool bEnab
 else
 {
 if ( !m_pElemList )
-m_pElemList = new ElementList;
+m_pElemList.reset( new ElementList );
 
 bool bFound = false;
 ElementList::iterator aListIter;
diff --git a/fpicker/source/office/OfficeFilePicker.hxx 
b/fpicker/source/office/OfficeFilePicker.hxx
index 27e761f39f05..af60daa9ee0b 100644
--- a/fpicker/source/office/OfficeFilePicker.hxx
+++ b/fpicker/source/office/OfficeFilePicker.hxx
@@ -61,8 +61,10 @@ class SvtFilePicker :public SvtFilePicker_Base
 ,public ::svt::IFilePickerListener
 {
 protected:
-FilterList* m_pFilterList;
-ElementList*m_pElemList;
+std::unique_ptr
+m_pFilterList;
+std::unique_ptr
+m_pElemList;
 
 boolm_bMultiSelection;
 sal_Int16   m_nServiceType;
diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx
index f8b5e1dd5d7f..873b5ccd2f76 100644
--- a/fpicker/source/office/iodlg.cxx
+++ b/fpicker/source/office/iodlg.cxx
@@ -119,7 +119,7 @@ namespace
 OUString getMostCurrentFilter( std::unique_ptr const & 
pImpl )
 {
 assert( pImpl && "invalid impl pointer" );
-const SvtFileDialogFilter_Impl* pFilter = pImpl->_pUserFilter;
+const SvtFileDialogFilter_Impl* pFilter = pImpl->_pUserFilter.get();
 
 if ( !pFilter )
 pFilter = pImpl->GetCurFilter();
@@ -768,8 +768,7 @@ IMPL_LINK_NOARG( SvtFileDialog, NewFolderHdl_Impl, Button*, 
void)
 void SvtFileDialog::createNewUserFilter( const OUString& _rNewFilter )
 {
 // delete the old user filter and create a new one
-DELETEZ( pImpl->_pUserFilter );
-pImpl->_pUserFilter = new SvtFileDialogFilter_Impl( _rNewFilter, 
_rNewFilter );
+pImpl->_pUserFilter.reset( new SvtFileDialogFilter_Impl( _rNewFilter, 
_rNewFilter ) );
 
 // remember the extension
 bool bIsAllFiles = _rNewFilter == FILEDIALOG_FILTER_ALL;
@@ -910,7 +909,7 @@ void SvtFileDialog::OpenHdl_Impl(void const * pVoid)
 // MBA->PB: ?!
 

[Libreoffice-commits] core.git: 2 commits - cui/source filter/source include/svx svx/source

[Noel Grandin]

 cui/source/tabpages/tppattern.cxx |6 +++---
 filter/source/flash/swfwriter.cxx |   22 --
 filter/source/flash/swfwriter.hxx |4 ++--
 include/svx/xbtmpit.hxx   |2 +-
 svx/source/xoutdev/xattrbmp.cxx   |   34 --
 svx/source/xoutdev/xtabptrn.cxx   |2 +-
 6 files changed, 27 insertions(+), 43 deletions(-)

New commits:
commit ccd316d1cb310734848bd20244f509024b549b8c
Author: Noel Grandin 
Date:   Fri Feb 16 14:26:14 2018 +0200

use VirtualDevice in createHistorical8x8FromArray

part of making BitmapWriteAccess an internal detail of vcl/

Change-Id: I8b3aa2fdd3c26db0e48b228640cd31b0bd31543c
Reviewed-on: https://gerrit.libreoffice.org/49937
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/cui/source/tabpages/tppattern.cxx 
b/cui/source/tabpages/tppattern.cxx
index 141bd052cc66..443f5d95f7f0 100644
--- a/cui/source/tabpages/tppattern.cxx
+++ b/cui/source/tabpages/tppattern.cxx
@@ -72,9 +72,9 @@ public:
 // BitmapCtl: Returns the Bitmap
 BitmapEx GetBitmapEx()
 {
-const Bitmap aRetval(createHistorical8x8FromArray(pBmpArray, 
aPixelColor, aBackgroundColor));
-
-return (pBmpArray != nullptr) ? BitmapEx(aRetval) : BitmapEx();
+if (!pBmpArray)
+return BitmapEx();
+return createHistorical8x8FromArray(pBmpArray, aPixelColor, 
aBackgroundColor);
 }
 
 void SetBmpArray( const sal_uInt16* pPixel ) { pBmpArray = pPixel; }
diff --git a/include/svx/xbtmpit.hxx b/include/svx/xbtmpit.hxx
index 7f34b0c1be71..b9ced7c42fb0 100644
--- a/include/svx/xbtmpit.hxx
+++ b/include/svx/xbtmpit.hxx
@@ -30,7 +30,7 @@ class BitmapColor;
 
 // helper to construct historical 8x8 bitmaps with two colors
 
-Bitmap SVX_DLLPUBLIC createHistorical8x8FromArray(const sal_uInt16* pArray, 
Color aColorPix, Color aColorBack);
+BitmapEx SVX_DLLPUBLIC createHistorical8x8FromArray(sal_uInt16 const * pArray, 
Color aColorPix, Color aColorBack);
 bool SVX_DLLPUBLIC isHistorical8x8(const BitmapEx& rBitmapEx, BitmapColor& 
o_rBack, BitmapColor& o_rFront);
 
 
diff --git a/svx/source/xoutdev/xattrbmp.cxx b/svx/source/xoutdev/xattrbmp.cxx
index 8e6e5afb18a8..336f84d9c2a8 100644
--- a/svx/source/xoutdev/xattrbmp.cxx
+++ b/svx/source/xoutdev/xattrbmp.cxx
@@ -38,6 +38,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -143,37 +144,26 @@ XFillBitmapItem::XFillBitmapItem(const XFillBitmapItem& 
rItem)
 {
 }
 
-Bitmap createHistorical8x8FromArray(const sal_uInt16* pArray, Color aColorPix, 
Color aColorBack)
+BitmapEx createHistorical8x8FromArray(sal_uInt16 const *pArray, Color 
aColorPix, Color aColorBack)
 {
-BitmapPalette aPalette(2);
+vcl::bitmap::RawBitmap aBitmap(Size(8, 8));
 
-aPalette[0] = BitmapColor(aColorBack);
-aPalette[1] = BitmapColor(aColorPix);
-
-Bitmap aBitmap(Size(8, 8), 1, );
-Bitmap::ScopedWriteAccess pContent(aBitmap);
-
-if(pContent)
+for(sal_uInt16 a(0); a < 8; a++)
 {
-for(sal_uInt16 a(0); a < 8; a++)
+for(sal_uInt16 b(0); b < 8; b++)
 {
-for(sal_uInt16 b(0); b < 8; b++)
+if(pArray[(a * 8) + b])
 {
-if(pArray[(a * 8) + b])
-{
-pContent->SetPixelIndex(a, b, 1);
-}
-else
-{
-pContent->SetPixelIndex(a, b, 0);
-}
+aBitmap.SetPixel(a, b, aColorBack);
+}
+else
+{
+aBitmap.SetPixel(a, b, aColorPix);
 }
 }
-
-pContent.reset();
 }
 
-return aBitmap;
+return vcl::bitmap::CreateFromData(std::move(aBitmap));
 }
 
 bool isHistorical8x8(const BitmapEx& rBitmapEx, BitmapColor& o_rBack, 
BitmapColor& o_rFront)
diff --git a/svx/source/xoutdev/xtabptrn.cxx b/svx/source/xoutdev/xtabptrn.cxx
index 9dd126dd3126..40e38cb3e331 100644
--- a/svx/source/xoutdev/xtabptrn.cxx
+++ b/svx/source/xoutdev/xtabptrn.cxx
@@ -49,7 +49,7 @@ bool XPatternList::Create()
 {
 OUStringBuffer aStr(SvxResId(RID_SVXSTR_PATTERN));
 sal_uInt16 aArray[64];
-Bitmap aBitmap;
+BitmapEx aBitmap;
 const sal_Int32 nLen(aStr.getLength() - 1);
 
 memset(aArray, 0, sizeof(aArray));
commit add367bfec9d12502e64d2994f0f39e2e436442a
Author: Noel Grandin 
Date:   Tue Feb 6 15:13:35 2018 +0200

loplugin:useuniqueptr in swf::Writer

Change-Id: Ia337bffa45a1949567f70586db480d92bb55b238
Reviewed-on: https://gerrit.libreoffice.org/49936
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/filter/source/flash/swfwriter.cxx 
b/filter/source/flash/swfwriter.cxx
index d32c417d4362..071f567073e5 100644
--- a/filter/source/flash/swfwriter.cxx
+++ 

[Libreoffice-commits] core.git: 2 commits - include/svx svx/source

[Noel Grandin]

 include/svx/linectrl.hxx  |5 +++--
 svx/source/table/tablertfimporter.cxx |   26 ++
 svx/source/tbxctrls/linectrl.cxx  |8 ++--
 3 files changed, 15 insertions(+), 24 deletions(-)

New commits:
commit 55dd09e3e5867a0dbaca53b8a3425839e5210234
Author: Noel Grandin 
Date:   Tue Feb 6 15:01:33 2018 +0200

loplugin:useuniqueptr in SdrTableRTFParser

Change-Id: I3d0657bcfcb9fca0d7f8c27499c159ddc5ccf47d
Reviewed-on: https://gerrit.libreoffice.org/49935
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/svx/source/table/tablertfimporter.cxx 
b/svx/source/table/tablertfimporter.cxx
index 3860bf1759b2..46f43cd6b377 100644
--- a/svx/source/table/tablertfimporter.cxx
+++ b/svx/source/table/tablertfimporter.cxx
@@ -81,7 +81,6 @@ class SdrTableRTFParser
 {
 public:
 explicit SdrTableRTFParser( SdrTableObj& rTableObj );
-~SdrTableRTFParser();
 
 void Read( SvStream& rStream );
 
@@ -100,7 +99,7 @@ public:
 
 private:
 SdrTableObj&mrTableObj;
-SdrOutliner*mpOutliner;
+std::unique_ptr mpOutliner;
 SfxItemPool&mrItemPool;
 
 RTFCellDefaultVector maDefaultList;
@@ -119,7 +118,7 @@ private:
 std::vector< sal_Int32 >::iterator maLastEdge;
 std::vector< RTFColumnVectorPtr > maRows;
 
-RTFCellDefault* mpInsDefault;
+std::unique_ptr mpInsDefault;
 RTFCellDefault* mpActDefault;
 RTFCellDefault* mpDefMerge;
 
@@ -148,13 +147,7 @@ SdrTableRTFParser::SdrTableRTFParser( SdrTableObj& 
rTableObj )
 {
 mpOutliner->SetUpdateMode(true);
 mpOutliner->SetStyleSheet( 0, mrTableObj.GetStyleSheet() );
-mpInsDefault = new RTFCellDefault(  );
-}
-
-SdrTableRTFParser::~SdrTableRTFParser()
-{
-delete mpOutliner;
-delete mpInsDefault;
+mpInsDefault.reset( new RTFCellDefault(  ) );
 }
 
 void SdrTableRTFParser::Read( SvStream& rStream )
@@ -402,7 +395,7 @@ void SdrTableRTFParser::ProcToken( RtfImportInfo* pInfo )
 break;
 case RTF_CLMGF: // The first cell of cells to be merged
 {
-mpDefMerge = mpInsDefault;
+mpDefMerge = mpInsDefault.get();
 mnLastToken = pInfo->nToken;
 }
 break;
@@ -431,19 +424,20 @@ void SdrTableRTFParser::ProcToken( RtfImportInfo* pInfo )
 case RTF_CELLX: // closes cell default
 {
 mbNewDef = true;
-maDefaultList.push_back( std::shared_ptr< RTFCellDefault >( 
mpInsDefault ) );
+std::shared_ptr pDefault( mpInsDefault.release() );
+maDefaultList.push_back( pDefault );
 
 
 const sal_Int32 nSize = TwipsToHundMM( pInfo->nTokenValue );
 if ( nSize > mnLastEdge )
 InsertColumnEdge( nSize );
 
-mpInsDefault->mnCellX = nSize;
+pDefault->mnCellX = nSize;
 // Record cellx in the first merged cell.
-if ( mpDefMerge && mpInsDefault->mnColSpan == 0 )
+if ( mpDefMerge && pDefault->mnColSpan == 0 )
 mpDefMerge->mnCellX = nSize;
 
-mpInsDefault = new RTFCellDefault(  );
+mpInsDefault.reset( new RTFCellDefault(  ) );
 
 mnLastToken = pInfo->nToken;
 }
@@ -463,7 +457,7 @@ void SdrTableRTFParser::ProcToken( RtfImportInfo* pInfo )
 if ( mbNewDef || !mpActDefault )
 NewCellRow();
 if ( !mpActDefault )
-mpActDefault = mpInsDefault;
+mpActDefault = mpInsDefault.get();
 if ( mpActDefault->mnColSpan > 0 )
 {
 InsertCell(pInfo);
commit e7d2ebe2fdb05ccdc742cc7c3d910880ba73ceef
Author: Noel Grandin 
Date:   Tue Feb 6 14:56:30 2018 +0200

loplugin:useuniqueptr in SvxLineStyleToolBoxControl

Change-Id: I83e1536a1d45fffbf4fc5ddb611e382568ebf26c
Reviewed-on: https://gerrit.libreoffice.org/49934
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/linectrl.hxx b/include/svx/linectrl.hxx
index 2c476118d446..a2b1a484e18a 100644
--- a/include/svx/linectrl.hxx
+++ b/include/svx/linectrl.hxx
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 
 class XLineStyleItem;
 class XLineDashItem;
@@ -38,8 +39,8 @@ class SvxMetricField;
 class SVX_DLLPUBLIC SvxLineStyleToolBoxControl : public SfxToolBoxControl
 {
 private:
-XLineStyleItem* pStyleItem;
-XLineDashItem*  pDashItem;
+std::unique_ptr  pStyleItem;
+std::unique_ptr   pDashItem;
 
 boolbUpdate;
 
diff --git a/svx/source/tbxctrls/linectrl.cxx b/svx/source/tbxctrls/linectrl.cxx
index d562abf9b4ca..4360b8155156 100644
--- a/svx/source/tbxctrls/linectrl.cxx
+++ b/svx/source/tbxctrls/linectrl.cxx
@@ -69,8 +69,6 @@ SvxLineStyleToolBoxControl::SvxLineStyleToolBoxControl( 

[Libreoffice-commits] core.git: filter/source

[Noel Grandin]

 filter/source/graphicfilter/icgm/cgm.cxx|   15 ---
 filter/source/graphicfilter/icgm/cgm.hxx|   12 ++--
 filter/source/graphicfilter/icgm/class0.cxx |6 ++
 filter/source/graphicfilter/icgm/class1.cxx |6 +++---
 filter/source/graphicfilter/icgm/class4.cxx |5 ++---
 filter/source/graphicfilter/icgm/class7.cxx |2 +-
 6 files changed, 18 insertions(+), 28 deletions(-)

New commits:
commit ef8ed797598062273ecb43fac8dbae4dbe3bf3cb
Author: Noel Grandin 
Date:   Tue Feb 6 15:24:01 2018 +0200

loplugin:useuniqueptr in CGM

Change-Id: Iecd9251f68cd894a14fb6824151768d4cb663e0f
Reviewed-on: https://gerrit.libreoffice.org/49944
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/filter/source/graphicfilter/icgm/cgm.cxx 
b/filter/source/graphicfilter/icgm/cgm.cxx
index 5e066bc65127..3da966412c77 100644
--- a/filter/source/graphicfilter/icgm/cgm.cxx
+++ b/filter/source/graphicfilter/icgm/cgm.cxx
@@ -64,26 +64,19 @@ CGM::CGM(uno::Reference< frame::XModel > const & rModel)
 , mnElementID(0)
 , mnElementSize(0)
 {
-pElement = new CGMElements;
-pCopyOfE = new CGMElements;
+pElement.reset( new CGMElements );
+pCopyOfE.reset( new CGMElements );
 }
 
 CGM::~CGM()
 {
-for(sal_uInt8* i : maDefRepList)
-delete [] i;
 maDefRepList.clear();
 maDefRepSizeList.clear();
-delete mpBitmapInUse;
-delete mpChart;
-delete mpOutAct;
-delete pCopyOfE;
-delete pElement;
 };
 
 sal_uInt32 CGM::GetBackGroundColor()
 {
-return ( pElement ) ? pElement->aColorTable[ 0 ] : 0;
+return pElement ? pElement->aColorTable[ 0 ] : 0;
 }
 
 sal_uInt32 CGM::ImplGetUI16()
@@ -615,7 +608,7 @@ void CGM::ImplDefaultReplacement()
 
 for ( size_t i = 0, n = maDefRepList.size(); i < n; ++i )
 {
-sal_uInt8*  pBuf = maDefRepList[ i ];
+sal_uInt8*  pBuf = maDefRepList[ i ].get();
 sal_uInt32  nElementSize = maDefRepSizeList[ i ];
 mpEndValidSource = pBuf + nElementSize;
 sal_uInt32  nCount = 0;
diff --git a/filter/source/graphicfilter/icgm/cgm.hxx 
b/filter/source/graphicfilter/icgm/cgm.hxx
index 06ce45ed27be..8ecbec12998c 100644
--- a/filter/source/graphicfilter/icgm/cgm.hxx
+++ b/filter/source/graphicfilter/icgm/cgm.hxx
@@ -65,14 +65,14 @@ class CGM
 boolmbFirstOutPut;
 boolmbInDefaultReplacement;
 sal_uInt32  mnAct4PostReset;
-CGMBitmap*  mpBitmapInUse;
-CGMChart*   mpChart;// if 
sal_True->"SHWSLIDEREC"
+std::unique_ptr mpBitmapInUse;
+std::unique_ptr mpChart;  // if 
sal_True->"SHWSLIDEREC"
 //  otherwise "BEGINPIC" 
commands
 // controls page inserting
-CGMElements*pElement;
-CGMElements*pCopyOfE;
-CGMImpressOutAct*   mpOutAct;
-::std::vector< sal_uInt8 * > maDefRepList;
+std::unique_ptr pElement;
+std::unique_ptr pCopyOfE;
+std::unique_ptr mpOutAct;
+::std::vector< std::unique_ptr > maDefRepList;
 ::std::vector< sal_uInt32  > maDefRepSizeList;
 
 sal_uInt8*  mpSource; // start of source buffer 
that is not increased
diff --git a/filter/source/graphicfilter/icgm/class0.cxx 
b/filter/source/graphicfilter/icgm/class0.cxx
index c6f1e4d4a6b9..baeef1249dd7 100644
--- a/filter/source/graphicfilter/icgm/class0.cxx
+++ b/filter/source/graphicfilter/icgm/class0.cxx
@@ -38,8 +38,7 @@ void CGM::ImplDoClass0()
 CGMBitmapDescriptor* pBmpDesc = mpBitmapInUse->GetBitmap();
 // do anything with the bitmap
 mpOutAct->DrawBitmap( pBmpDesc );
-delete mpBitmapInUse;
-mpBitmapInUse = nullptr;
+mpBitmapInUse.reset();
 }
 mbIsFinished = true;
 mbPictureBody = false;
@@ -75,8 +74,7 @@ void CGM::ImplDoClass0()
 CGMBitmapDescriptor* pBmpDesc = mpBitmapInUse->GetBitmap();
 // do anything with the bitmap
 mpOutAct->DrawBitmap( pBmpDesc );
-delete mpBitmapInUse;
-mpBitmapInUse = nullptr;
+mpBitmapInUse.reset();
 }
 mpOutAct->EndFigure();  // close 
potential figures
 mpOutAct->EndGrouping();// finish 
potential groups
diff --git a/filter/source/graphicfilter/icgm/class1.cxx 
b/filter/source/graphicfilter/icgm/class1.cxx
index 3bd903796aab..b8eabf83f04d 100644
--- a/filter/source/graphicfilter/icgm/class1.cxx
+++ b/filter/source/graphicfilter/icgm/class1.cxx
@@ -164,9 +164,9 @@ void 

[Libreoffice-commits] core.git: 2 commits - include/svx svx/source

[Noel Grandin]

 include/svx/AccessibleShape.hxx  |5 +++--
 svx/source/accessibility/AccessibleShape.cxx |   18 --
 svx/source/form/navigatortreemodel.cxx   |4 ++--
 svx/source/inc/fmexpl.hxx|5 +++--
 4 files changed, 16 insertions(+), 16 deletions(-)

New commits:
commit d3c7a7807695deee35e40ef6d77a7428682525d3
Author: Noel Grandin 
Date:   Tue Feb 6 13:27:25 2018 +0200

loplugin:useuniqueptr in AccessibleShape

Change-Id: I4c91ce6eb47f2802313fed22357e5c960cea50b2
Reviewed-on: https://gerrit.libreoffice.org/49931
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/AccessibleShape.hxx b/include/svx/AccessibleShape.hxx
index 592a7ead9b32..71842073ffdf 100644
--- a/include/svx/AccessibleShape.hxx
+++ b/include/svx/AccessibleShape.hxx
@@ -48,6 +48,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace com { namespace sun { namespace star {
 namespace accessibility { class XAccessible; }
@@ -373,7 +374,7 @@ public:
 
 protected:
 /// Children manager. May be empty if there are no children.
-ChildrenManager* mpChildrenManager;
+std::unique_ptr mpChildrenManager;
 
 /// Reference to the actual shape.
 css::uno::Reference<
@@ -389,7 +390,7 @@ protected:
 
 /** The accessible text engine.  May be NULL if it can not be created.
 */
-AccessibleTextHelper* mpText;
+std::unique_ptr mpText;
 
 /** This object can be used to modify the child list of our parent.
 */
diff --git a/svx/source/accessibility/AccessibleShape.cxx 
b/svx/source/accessibility/AccessibleShape.cxx
index 810fa68dbc3d..cd3a84889f86 100644
--- a/svx/source/accessibility/AccessibleShape.cxx
+++ b/svx/source/accessibility/AccessibleShape.cxx
@@ -118,8 +118,8 @@ AccessibleShape::AccessibleShape (
 
 AccessibleShape::~AccessibleShape()
 {
-delete mpChildrenManager;
-delete mpText;
+mpChildrenManager.reset();
+mpText.reset();
 SAL_INFO("svx", "~AccessibleShape");
 
 // Unregistering from the various broadcasters should be unnecessary
@@ -135,8 +135,8 @@ void AccessibleShape::Init()
 // Create a children manager when this shape has children of its own.
 Reference xShapes (mxShape, uno::UNO_QUERY);
 if (xShapes.is() && xShapes->getCount() > 0)
-mpChildrenManager = new ChildrenManager (
-this, xShapes, maShapeTreeInfo, *this);
+mpChildrenManager.reset( new ChildrenManager (
+this, xShapes, maShapeTreeInfo, *this) );
 if (mpChildrenManager != nullptr)
 mpChildrenManager->Update();
 
@@ -174,12 +174,12 @@ void AccessibleShape::Init()
 if( !pOutlinerParaObject )
 {
 // empty text -> use proxy edit source to delay creation 
of EditEngine
-mpText = new AccessibleTextHelper( 
o3tl::make_unique(*pSdrObject, *pView, *pWindow) );
+mpText.reset( new AccessibleTextHelper( 
o3tl::make_unique(*pSdrObject, *pView, *pWindow) ) 
);
 }
 else
 {
 // non-empty text -> use full-fledged edit source right 
away
-mpText = new AccessibleTextHelper( 
o3tl::make_unique(*pSdrObject, nullptr, *pView, *pWindow) );
+mpText.reset( new AccessibleTextHelper( 
o3tl::make_unique(*pSdrObject, nullptr, *pView, *pWindow) ) 
);
 }
 if( pWindow->HasFocus() )
 mpText->SetFocus();
@@ -1195,14 +1195,12 @@ void AccessibleShape::disposing()
 // Release the child containers.
 if (mpChildrenManager != nullptr)
 {
-delete mpChildrenManager;
-mpChildrenManager = nullptr;
+mpChildrenManager.reset();
 }
 if (mpText != nullptr)
 {
 mpText->Dispose();
-delete mpText;
-mpText = nullptr;
+mpText.reset();
 }
 
 // Cleanup.  Remove references to objects to allow them to be
commit cc0be9f9616b732955ff21850fb69142ee46507e
Author: Noel Grandin 
Date:   Tue Feb 6 11:41:51 2018 +0200

loplugin:useuniqueptr in NavigatorTreeModel

Change-Id: I53e7e4ab0a1533266ce97d5a093a1742808b6215
Reviewed-on: https://gerrit.libreoffice.org/49930
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/svx/source/form/navigatortreemodel.cxx 
b/svx/source/form/navigatortreemodel.cxx
index 2c7c717b39de..95a38b4f75a1 100644
--- a/svx/source/form/navigatortreemodel.cxx
+++ b/svx/source/form/navigatortreemodel.cxx
@@ -191,7 +191,7 @@ namespace svxform
 ,m_pFormModel(nullptr)
 {
 m_pPropChangeList = new OFormComponentObserver(this);
-m_pRootList = new FmEntryDataList();
+m_pRootList.reset( new FmEntryDataList() );
 }
 
 

[Libreoffice-commits] core.git: 2 commits - include/svx svx/source

[Noel Grandin]

 include/svx/clipboardctl.hxx |4 +++-
 svx/source/dialog/fntctrl.cxx|   17 +
 svx/source/mnuctrls/clipboardctl.cxx |8 +++-
 3 files changed, 11 insertions(+), 18 deletions(-)

New commits:
commit 6e5d8bb2d60c2e44aa1d2bf7810bff09b9ceabb5
Author: Noel Grandin 
Date:   Tue Feb 6 14:51:39 2018 +0200

loplugin:useuniqueptr in FontPrevWin_Impl

Change-Id: I0919b8e2c58dbe26154e4a7c7c77e8e63f665842
Reviewed-on: https://gerrit.libreoffice.org/49933
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/svx/source/dialog/fntctrl.cxx b/svx/source/dialog/fntctrl.cxx
index 63b53beb64ce..df74bc29f474 100644
--- a/svx/source/dialog/fntctrl.cxx
+++ b/svx/source/dialog/fntctrl.cxx
@@ -156,8 +156,8 @@ class FontPrevWin_Impl
 SvxFont maCTLFont;
 OUString maText;
 OUString maScriptText;
-Color* mpColor;
-Color* mpBackColor;
+std::unique_ptr mpColor;
+std::unique_ptr mpBackColor;
 long mnAscent;
 sal_Unicode mcStartBracket;
 sal_Unicode mcEndBracket;
@@ -182,8 +182,6 @@ public:
 FontPrevWin_Impl() :
 mpPrinter(nullptr),
 mbDelPrinter(false),
-mpColor(nullptr),
-mpBackColor(nullptr),
 mnAscent(0),
 mcStartBracket(0),
 mcEndBracket(0),
@@ -204,8 +202,6 @@ public:
 
 ~FontPrevWin_Impl()
 {
-delete mpColor;
-delete mpBackColor;
 if (mbDelPrinter)
 mpPrinter.disposeAndClear();
 }
@@ -604,22 +600,19 @@ void SvxFontPrevWindow::SetFont( const SvxFont& 
rNormalOutFont, const SvxFont& r
 
 void SvxFontPrevWindow::SetColor(const Color )
 {
-delete pImpl->mpColor;
-pImpl->mpColor = new Color(rColor);
+pImpl->mpColor.reset(new Color(rColor));
 Invalidate();
 }
 
 void SvxFontPrevWindow::ResetColor()
 {
-delete pImpl->mpColor;
-pImpl->mpColor = nullptr;
+pImpl->mpColor.reset();
 Invalidate();
 }
 
 void SvxFontPrevWindow::SetBackColor(const Color )
 {
-delete pImpl->mpBackColor;
-pImpl->mpBackColor = new Color(rColor);
+pImpl->mpBackColor.reset(new Color(rColor));
 Invalidate();
 }
 
commit 5d9e3beb3760bcc04afb5d69b0c9ff70d522dd5e
Author: Noel Grandin 
Date:   Tue Feb 6 13:27:43 2018 +0200

loplugin:useuniqueptr in SvxClipBoardControl

Change-Id: Ib9e3d20680cba684fea8b586a5ca4c5835ca6b42
Reviewed-on: https://gerrit.libreoffice.org/49932
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/clipboardctl.hxx b/include/svx/clipboardctl.hxx
index 135498be439e..e825035cd34d 100644
--- a/include/svx/clipboardctl.hxx
+++ b/include/svx/clipboardctl.hxx
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 
 class PopupMenu;
 class SfxModule;
@@ -32,7 +33,8 @@ class ToolBox;
 
 class SAL_WARN_UNUSED SVX_DLLPUBLIC SvxClipBoardControl : public 
SfxToolBoxControl
 {
-SfxPoolItem*pClipboardFmtItem;
+std::unique_ptr
+pClipboardFmtItem;
 VclPtr   pPopup;
 boolbDisabled;
 
diff --git a/svx/source/mnuctrls/clipboardctl.cxx 
b/svx/source/mnuctrls/clipboardctl.cxx
index 22c00fe7e8fd..6d5c2e9fe25b 100644
--- a/svx/source/mnuctrls/clipboardctl.cxx
+++ b/svx/source/mnuctrls/clipboardctl.cxx
@@ -42,7 +42,6 @@ SvxClipBoardControl::SvxClipBoardControl(
 sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox& rTbx ) :
 
 SfxToolBoxControl( nSlotId, nId, rTbx ),
-pClipboardFmtItem( nullptr ),
 pPopup( nullptr ),
 bDisabled( false )
 {
@@ -56,13 +55,12 @@ SvxClipBoardControl::SvxClipBoardControl(
 SvxClipBoardControl::~SvxClipBoardControl()
 {
 DelPopup();
-delete pClipboardFmtItem;
 }
 
 
 VclPtr SvxClipBoardControl::CreatePopupWindow()
 {
-const SvxClipboardFormatItem* pFmtItem = 
dynamic_cast( pClipboardFmtItem  );
+const SvxClipboardFormatItem* pFmtItem = 
dynamic_cast( pClipboardFmtItem.get()  );
 if ( pFmtItem )
 {
 if (pPopup)
@@ -111,10 +109,10 @@ void SvxClipBoardControl::StateChanged( sal_uInt16 nSID, 
SfxItemState eState, co
 {
 if ( SID_CLIPBOARD_FORMAT_ITEMS == nSID )
 {
-DELETEZ( pClipboardFmtItem );
+pClipboardFmtItem.reset();
 if ( eState >= SfxItemState::DEFAULT )
 {
-pClipboardFmtItem = pState->Clone();
+pClipboardFmtItem.reset( pState->Clone() );
 GetToolBox().SetItemBits( GetId(), GetToolBox().GetItemBits( 
GetId() ) | ToolBoxItemBits::DROPDOWN );
 }
 else if ( !bDisabled )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115813] Position shifted while moving the handle of OOXML Callout shape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115813

--- Comment #1 from Imai <14m4...@kobe-du.ac.jp> ---
Issue is reproduced.

OS X EL Capitan
Ver:10.11.3

version: 6.0.1.1
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
CPU threads: 4; OS:Mac OS X 10.11.3; UI render: default; 
local: ja-JP (ja.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115295] Page separator line is slowing down the page scrolling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115295

--- Comment #3 from Imai <14m4...@kobe-du.ac.jp> ---
Not repreducced

OS X EL Capitan
Ver:10.11.3

version: 6.0.1.1
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
CPU threads: 4; OS:Mac OS X 10.11.3; UI render: default; 
local: ja-JP (ja.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115830] Indentation level on bullets does not stay when set via bullets and numbering dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115830

--- Comment #2 from Imai <14m4...@kobe-du.ac.jp> ---

Detailed version info: 6.0.1.1
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
CPU threads: 4; OS:Mac OS X 10.11.3; UI render: default; 
local: ja-JP (ja.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115830] Indentation level on bullets does not stay when set via bullets and numbering dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115830

Imai <14m4...@kobe-du.ac.jp> changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Imai <14m4...@kobe-du.ac.jp> ---
Issue is reproduced.

OS X EL Capitan
Ver:10.11.3

Libreoffice 6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115810] A change in font size in a large document is a CPU hog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115810

--- Comment #2 from Imai <14m4...@kobe-du.ac.jp> ---
Issue is reproduced.

OS X EL Capitan
Ver:10.11.3

Libreoffice 6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114878] Fix "CSV injection" vulnerability

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114878

--- Comment #5 from Mike Kaganski  ---
Well, I'd close it as WONTFIX (after updating our help), because the issue of
discrepancy between documentation and implementation indeed exists.

But I only expressed my personal opinion, and I suppose that erAck's opinion
here is much more relevant.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Resources on writing import/export file filters for Writer

[Jens Tröger]

Hello,

I’m looking into writing an “export filter”, i.e. exporting the currently open 
Writer document to a custom file format. Can somebody please point me at the 
appropriate documentation and perhaps code samples? At a later point I’d like 
to import a custom file format as well, and will look for that same 
documentation.

Thanks!
Jens

--
Jens Tröger
http://savage.light-speed.de/

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 115311] UI missing for nesting character styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115311

--- Comment #2 from Kenneth Hanson  ---
(In reply to Heiko Tietze from comment #1)
> The request is solely technically driven and I recommend to not do that.
> ...
> If we need to support these nested styles (my suggestion would be to remove 
> them from the file format), the easter-eggy shift+click thing is good enough.

I strongly disagree. The ability to nest character styles is extremely
important for complex documents. It's the only sane way to represent semantic
or formatting considerations that are orthogonal to each other.

Style support is a widely touted feature of LO (and rightly so), but these
kinds of limitations (can't nest character styles, can't inherit page styles,
graphic styles not available in Writer, character styles not available in
Impress...) prevents it from realizing its potential.

Undocumented features are just as bad as not having the feature at all, unless
you have unlimited time to tinker. I was extremely excited to learn that this
might already work, because if true it's one less reason that I might need to
use LaTeX. I never would have discovered it if not for Regina's exploration.

Personally, I think a second "apply" button that nests rather than replaces
existing styles would be an unobtrusive way to make nesting available. At the
very least, the double-click feature should be confirmed and added to the help
text.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 115311] UI missing for nesting character styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115311

--- Comment #2 from Kenneth Hanson  ---
(In reply to Heiko Tietze from comment #1)
> The request is solely technically driven and I recommend to not do that.
> ...
> If we need to support these nested styles (my suggestion would be to remove 
> them from the file format), the easter-eggy shift+click thing is good enough.

I strongly disagree. The ability to nest character styles is extremely
important for complex documents. It's the only sane way to represent semantic
or formatting considerations that are orthogonal to each other.

Style support is a widely touted feature of LO (and rightly so), but these
kinds of limitations (can't nest character styles, can't inherit page styles,
graphic styles not available in Writer, character styles not available in
Impress...) prevents it from realizing its potential.

Undocumented features are just as bad as not having the feature at all, unless
you have unlimited time to tinker. I was extremely excited to learn that this
might already work, because if true it's one less reason that I might need to
use LaTeX. I never would have discovered it if not for Regina's exploration.

Personally, I think a second "apply" button that nests rather than replaces
existing styles would be an unobtrusive way to make nesting available. At the
very least, the double-click feature should be confirmed and added to the help
text.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 34171] Bad user name reporting when file is locked in mixed Calc / Excel environment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34171

--- Comment #23 from Mike Kaganski  ---
Do we really need to care for foreign lock files? This might be inconvenient,
but trying to "support" alien locking schemes (that aren't standardized) could
bring more problems possibly. E.g., stale lockfiles of other programs. And why
limit with only MSO? Let's do it for all possible office suites (and not only
office - we support DXF - let's consider AutoCAD lock files, too)!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115012] Chart in XLSX has gaps instead of/around zero values

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115012

--- Comment #6 from Aron Budea  ---
Some comments from Markus on IRC:

<@moggi> the behavior, it is not the chart side but the calc side that forces
us to interpret ="" as empty
<@moggi> implemented in ScChart2DataSequence::BuildDataCache
 this will return false, right? pFCell->IsValue()
<@moggi> yes
<@moggi> well, it would require to pass the missing value treatment to the sc
chart data provider as this requires to treat cache items with Item::mbIsValue
== false and Item::maString.isEmpty() == true as 0
<@moggi> currently it is NaN
 apart from this problem, is extending the mentioned
MissingValueTreatment.idl with an "OOXML-specific" value an acceptable change?
<@moggi> I would need to ask sberg what the rules are about published constants
<@moggi> if extending them is considered API breaking this would be a much
bigger task as that would require to replace the chart1 API constants with a
new chart2 API constant group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115837] the doc with Hebrew always consists the terrible and disturbing spaces between the words in the Western font!!!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115837

--- Comment #1 from Sasha  ---
only the workaround I fond - the set for the CPECIFIC doc the WESTERN font as
the needed me Hebrew (!) font - and then, after the doc saved, the text are in
Hebrew even in the spaces between the Hebrew words.  The problem is that into
the Tables this workaround does not works.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115837] New: the doc with Hebrew always consists the terrible and disturbing spaces between the words in the Western font!!!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115837

Bug ID: 115837
   Summary: the doc with Hebrew always consists the terrible and
disturbing spaces between the words in the Western
font!!!
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sasha.razgo...@gmail.com

Description:
The spaces between the Hebrew words are in the Western font. It is very
annoying to always get the added word or char in the font that was NOT chosen
for the text of the document! 

Steps to Reproduce:
1.two words in Hebrew in font "a" (the font (the default font?) of the doc).
2.a Hebrew word (or char) are inserted between these two Hebrew word after the
space (to the left of the space)
3.

Actual Results:  
the added chars are in different font "b" - in the font that is the Western
font that "translated" to a Hebrew font (with the name that are the nearest to
the Western font's name).

Expected Results:
In case the only the specific document (that I working with it) have this
annoying feature, then tell me the workaround for the problem! Even when I copy
all the doc into the new empty one then the font changed to the default font
and the spaces between Hebrew words becomes be in this font -- BUT after the
doc saved and opened the spaces becomes be in the WESTERN font again!!! :(


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: ru
Module: StartModule
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/63.0.3239.132 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115835] Calc - Copying Cells in a Row with Conditional formatting - Conditional formatting not copied

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115835

--- Comment #1 from Ashok  ---
Tried to create a sample document with the error to attach
Found that if you save the document and then open it, all the cells have the
conditional Formatting and there is no issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106070] RTF IO open file error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106070

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105856] XAdES signature created via LibreOffice is not compliant ( SignedProperties reference is missing Type attribute).

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105856

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95633] Find and Replace ‘italic’ brings faulty results or hangs LO.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95633

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91904] Color drop down needs to be lower when expanded from toolbar on the left

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91904

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90070] Adding a border and spacing to content shrinks the size on an image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90070

--- Comment #15 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115836] New: BUILDING: ArrayFunctionsTest:: testArrayFormulasFODS test failed during build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115836

Bug ID: 115836
   Summary: BUILDING: ArrayFunctionsTest::testArrayFormulasFODS
test failed during build
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vdragon.tai...@gmail.com

Error log:

```
Testing
file:///home/builduser/libreoffice/sc/qa/unit/data/functions/array/fods/linest.fods:
/home/builduser/libreoffice/sc/qa/unit/functions_test.cxx:47:ArrayFunctionsTest::testArrayFormulasFODS
double equality assertion failed
- Expected: 1
- Actual  : 0
- Delta   : 1e-14

ArrayFunctionsTest::testArrayFormulasFODS finished in: 357ms
functions_test.cxx:47:Assertion
Test name: ArrayFunctionsTest::testArrayFormulasFODS
double equality assertion failed
- Expected: 1
- Actual  : 0
- Delta   : 1e-14

Failures !!!
Run: 1   Failure total: 1   Failures: 1   Errors: 0
```

Build flags:

```
./autogen.sh CFLAGS='-pipe -O2 -march=native' CXXFLAGS='-pipe -O2
-march=native' --without-doxygen
```

Build revision:

```
$ git describe --tags --always --long --always --dirty
0fd3e7b
```

Build system:

* Ubuntu 16.04 LXD container
* Host: Lubuntu 16.04

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115835] New: Calc - Copying Cells in a Row with Conditional formatting - Conditional formatting not copied

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115835

Bug ID: 115835
   Summary: Calc - Copying Cells in a Row with Conditional
formatting - Conditional formatting not copied
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ashokin...@gmail.com

Description:
LibreOffice Calc Ver 6.01 x64 on Windows 10 64 Bit
If you try to copy a range of cells in a row with conditional formatting only
the conditional formatting of the first cell in the range is copied.
For Example if Range A1:C1 has conditional formatting and if you select the
Range Range A1:C1 and copy to Range A2:C2 then only the cell A2 has the
conditional formatting.  The other cells (B2 and C2) does not have the
conditional formatting of B1 and C1.  The issue is there only when you copy
rows.  When you copy columns say range E1:E3 to F1:F3 conditional formatting of
all cells are copied.  The problem started, I think, from Version 5.2 or 5.3 

Steps to Reproduce:
1.  Create a Range of Cells in a Row say A1:C1 with Conditional Formatting 
2.  Select the cells in the Row (A1:C1) and Copy to another Row (Say A2:C2)
3.

Actual Results:  
Only Cell A2 had conditional Formatting

Expected Results:
The conditional Formatting of the other cells should have been copied 


Reproducible: Always


User Profile Reset: No



Additional Info:
The issue is there only when rows are copied.  Works perfectly well when
columns are copied.


User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like
Gecko

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115239] Bookmark on the first word can't be deleted.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115239

--- Comment #5 from Imai <14m4...@kobe-du.ac.jp> ---
Issue is reproduced on:

OS X EL Capitan
ver.10.11.3（15D21）

LibreOffice 6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115239] Bookmark on the first word can't be deleted.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115239

IWAMOTO <14m4...@kobe-du.jp> changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from IWAMOTO <14m4...@kobe-du.jp> ---
Issue is reproduced on.
OS:Windows 7 Home Premium x64


version: 6.0.1.1 (x64)
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
CPU threads: 2; OS:Windows 6.1; UI render: default;
Locale: ja-JP (ja_JP); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 115050, which changed state.

Bug 115050 Summary: "Zero Width Non Joiner" partly ignored if input via the 
keyboard
https://bugs.documentfoundation.org/show_bug.cgi?id=115050

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115050] "Zero Width Non Joiner" partly ignored if input via the keyboard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115050

Khaled Hosny  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #5 from Khaled Hosny  ---
The font does not have any OpenType features that interact with U+200C at all. 

What is happening here is that inserting any character via Special Character
dialog puts the character in text span of its own with different text style,
which will cause LibreOffice to break the text when shaping i.e. the text is
processed as if it were the two words “Wachs” and “tube”, see bug 113134. This
has the side effect of causing the behavior you are expecting to happen, but it
is in’t intentional, rather a bad interaction of bug 113134 and LibreOffice’s
own limitation for shaping words across inline styles separately.

As such the font is actually working as intended in the 1st line, while the
second line is a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - 3 commits - sw/qa sw/source sw/uiconfig

[Serge Krot]

 sw/qa/extras/odfexport/data/tdf101856.odt |binary
 sw/qa/extras/odfexport/odfexport.cxx  |   46 ++
 sw/source/core/text/porlay.cxx|   19 
 sw/uiconfig/swriter/ui/insertbookmark.ui  |   39 -
 4 files changed, 90 insertions(+), 14 deletions(-)

New commits:
commit 7ab4fe63f05b1f90bb0b197a039048cbd1a17b4e
Author: Serge Krot 
Date:   Mon Feb 12 10:19:10 2018 +0100

tdf#101856: Use bookmark attributes at load

Conflicts:
sw/source/core/text/porlay.cxx

Change-Id: I935c50f8b3a1d7179121b9230a7f7f25fa6aea22

diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index 0c9ebb64a103..88e0032fd218 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -2082,6 +2082,25 @@ void SwScriptInfo::selectHiddenTextProperty(const 
SwTextNode& rNode, MultiSelect
 }
 }
 }
+
+for (const SwIndex* pIndex = rNode.GetFirstIndex(); pIndex; pIndex = 
pIndex->GetNext())
+{
+const sw::mark::IMark* pMark = pIndex->GetMark();
+const sw::mark::IBookmark* pBookmark = dynamic_cast(pMark);
+if (pBookmark && pBookmark->IsHidden())
+{
+// intersect bookmark range with textnode range and add the 
intersection to rHiddenMulti
+
+const sal_Int32 nSt =  
pBookmark->GetMarkStart().nContent.GetIndex();
+const sal_Int32 nEnd = pBookmark->GetMarkEnd().nContent.GetIndex();
+
+if( nEnd > nSt )
+{
+Range aTmp( nSt, nEnd - 1 );
+rHiddenMulti.Select(aTmp, true);
+}
+}
+}
 }
 
 void SwScriptInfo::selectRedLineDeleted(const SwTextNode& rNode, 
MultiSelection , bool bSelect)
commit 61150f1c37744457e7a1a1c1e684612b6adf0298
Author: Serge Krot 
Date:   Thu Feb 8 13:19:01 2018 +0100

tdf#101856 odt: write/read new bookmark attributes: unit test

Change-Id: I094f91c2af2d171067e3c37a8d52276835d36e9c

diff --git a/sw/qa/extras/odfexport/data/tdf101856.odt 
b/sw/qa/extras/odfexport/data/tdf101856.odt
new file mode 100755
index ..bddd1502281c
Binary files /dev/null and b/sw/qa/extras/odfexport/data/tdf101856.odt differ
diff --git a/sw/qa/extras/odfexport/odfexport.cxx 
b/sw/qa/extras/odfexport/odfexport.cxx
index 4b30c57cdfd1..e49c359eeb2a 100644
--- a/sw/qa/extras/odfexport/odfexport.cxx
+++ b/sw/qa/extras/odfexport/odfexport.cxx
@@ -966,5 +966,51 @@ DECLARE_ODFEXPORT_TEST(testImageMimetype, 
"image-mimetype.odt")
 
 #endif
 
+// MAILMERGE Add conditional to expand / collapse bookmarks
+DECLARE_ODFEXPORT_TEST(tdf101856, "tdf101856.odt")
+{
+// get bookmark interface
+uno::Reference xBookmarksSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xBookmarksByIdx(xBookmarksSupplier->getBookmarks(), uno::UNO_QUERY);
+uno::Reference 
xBookmarksByName(xBookmarksSupplier->getBookmarks(), uno::UNO_QUERY);
+
+// check: we have 2 bookmarks
+CPPUNIT_ASSERT_EQUAL(static_cast(5), 
xBookmarksByIdx->getCount());
+CPPUNIT_ASSERT(xBookmarksByName->hasByName("BookmarkVisible"));
+CPPUNIT_ASSERT(xBookmarksByName->hasByName("BookmarkHidden"));
+
CPPUNIT_ASSERT(xBookmarksByName->hasByName("BookmarkVisibleWithCondition"));
+
CPPUNIT_ASSERT(xBookmarksByName->hasByName("BookmarkNotHiddenWithCondition"));
+CPPUNIT_ASSERT(xBookmarksByName->hasByName("BookmarkHiddenWithCondition"));
+
+// 
+uno::Reference 
xBookmark1(xBookmarksByName->getByName("BookmarkVisible"), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString(""), getProperty(xBookmark1, 
UNO_NAME_BOOKMARK_CONDITION));
+CPPUNIT_ASSERT_EQUAL(false, getProperty(xBookmark1, 
UNO_NAME_BOOKMARK_HIDDEN));
+
+// 
+uno::Reference 
xBookmark2(xBookmarksByName->getByName("BookmarkHidden"), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString(""), getProperty(xBookmark2, 
UNO_NAME_BOOKMARK_CONDITION));
+CPPUNIT_ASSERT_EQUAL(true, getProperty(xBookmark2, 
UNO_NAME_BOOKMARK_HIDDEN));
+
+// 
+uno::Reference 
xBookmark3(xBookmarksByName->getByName("BookmarkVisibleWithCondition"), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString("0==1"), getProperty(xBookmark3, 
UNO_NAME_BOOKMARK_CONDITION));
+CPPUNIT_ASSERT_EQUAL(true, getProperty(xBookmark3, 
UNO_NAME_BOOKMARK_HIDDEN));
+
+// 
+//
+// The following test doesn't work, while during output in the case of 
loext:hidden="false".
+// no additional parameters are written. Implementation should be reviewed.
+//
+//uno::Reference 
xBookmark4(xBookmarksByName->getByName("BookmarkNotHiddenWithCondition"), 
uno::UNO_QUERY);
+//CPPUNIT_ASSERT_EQUAL(OUString("1==1"), getProperty(xBookmark4, 
UNO_NAME_BOOKMARK_CONDITION));
+//CPPUNIT_ASSERT_EQUAL(false, getProperty(xBookmark4, 
UNO_NAME_BOOKMARK_HIDDEN));
+
+// 
+uno::Reference 

[Libreoffice-bugs] [Bug 105105] Bad allocation while removing sheets (in a 32-bit LibreOffice )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105105

--- Comment #18 from IWAMOTO <14m4...@kobe-du.jp> ---
Not reproduce 

バージョン: 6.0.1.1 (x64)
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
CPU threads: 2; OS:Windows 6.1; UI render: default; 
ロケール: ja-JP (ja_JP); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104921] Make Arabic text justification more robust

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104921

--- Comment #2 from Khaled Hosny  ---
>From bug 112849 comment 4:

> Kashida in LibreOffice is fundamentally broken:
> 
> // A note on how Kashida justification is implemented (because it took me 5
> // years to figure it out):
> // The decision to insert Kashidas, where and how much is taken by Writer.
> // This decision is communicated to us in a very indirect way; by increasing
> // the width of the character after which Kashidas should be inserted by the
> // desired amount.
> //
> // Writer eventually calls IsKashidaPosValid() to check whether it can
> insert a
> // Kashida between two characters or not.
> //
> // Here we do:
> // - In LayoutText() set KashidaJustification flag based on text script.
> // - In ApplyDXArray():
> //   * Check the above flag to decide whether to insert Kashidas or not.
> //   * For any RTL glyph that has DX adjustment, insert enough Kashidas to
> // fill in the added space.
> 
> from
> https://gerrit.libreoffice.org/gitweb?p=core.git;a=blob;f=vcl/source/gdi/
> CommonSalLayout.cxx;h=8e8565717932088558ee7a4b31fc0bfe405e98e3;hb=HEAD#l698
> 
> The insanity described above together with the the whole DX array madness
> and the use of integers to hold glyph positions, makes is so that any
> rounding errors would cause VCL to think that writer wants to insert a
> kashida in this place.
> 
> Fixing kashida once and for all requires 1) making the communication between
> Writer and VCL explicit e.g. have a separate “kashida insertion points”
> array 2) Kill DX array for good and enter the 21 century (it is an API
> “inspired” by Windows 3.1 3) Fix rounding errors by preserving fractional
> glyph positions in a way or another.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Repository.mk

[Markus Mohrhard]

 Repository.mk |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 0fd3e7beeb20b1c6406b1c3dca2aac09baba7ff2
Author: Markus Mohrhard 
Date:   Mon Feb 19 00:36:36 2018 +0100

fix windows build after 61bfc53ee710f9c79ac597888a6ee9dfee165ea4

Change-Id: I5687d54bf2566898116c697f5a760cc0989ac0f6
Reviewed-on: https://gerrit.libreoffice.org/49955
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/Repository.mk b/Repository.mk
index f7c8d7ae353e..8aeca4b18257 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -884,7 +884,6 @@ $(eval $(call gb_Helper_register_packages_for_install,ooo,\
extras_gallmytheme \
extras_gallroot \
extras_gallsystem \
-   extras_gallwwwback \
extras_gallwwwgraf \
extras_glade \
extras_labels \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108846] FILEOPEN PPTX Fuzzy images when viewed in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108846

--- Comment #14 from Kevin Evans  ---
I am a retired software developer. I certainly don't want to get into VMs or
other OS installations etc, etc.

Just needed a piece of software that worked for me.

Kevin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115834] "Capitalize first letter of every sentence" is non working properly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115834

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |NOTABUG

--- Comment #2 from V Stuart Foote  ---
No it works correctly if you disable the Tools -> AutoCorrect -> AutoCorrect
Options: Localized Options  "Single Quotes" Replace check-box.

The quotation Replace action asserts before the Capitalize actions--so the
initial position gets dropped.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115808] Impress displays images differently on different machines ( screen resolutions?)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115808

--- Comment #2 from Eric M  ---
One last comment is that if an .odp presentation with mangled *slide sorter*
images is saved in .ppt format, and opened again with LibreOffice, the slide
sorter view of the .ppt slides is fine, the thumbnails are sharp and the images
are not mangled. For this to work the slides have to be OK in the normal slide
view, fixed by the methods in my comment 1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66792] UI: Better integration of font styles into the toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66792

--- Comment #17 from Heiko Tietze  ---
The design team discussed the various options of a) access to style variations
in submenus, b) splitting into two dropdowns similar to InDesign, and c)
indentation of the variations. All solutions are not easy to handle, and most
fonts have just R/B/I/BI that are addressed by the toggle buttons bold and
italic. Plus, we have the two dropdowns solution implemented in the character
dialog. So the recommendation is to 'ignore' variants meaning to collapse all
DejaVu fonts into one (regular).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 66792] UI: Better integration of font styles into the toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66792

--- Comment #17 from Heiko Tietze  ---
The design team discussed the various options of a) access to style variations
in submenus, b) splitting into two dropdowns similar to InDesign, and c)
indentation of the variations. All solutions are not easy to handle, and most
fonts have just R/B/I/BI that are addressed by the toggle buttons bold and
italic. Plus, we have the two dropdowns solution implemented in the character
dialog. So the recommendation is to 'ignore' variants meaning to collapse all
DejaVu fonts into one (regular).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: starmath/inc

[Takeshi Abe]

 starmath/inc/node.hxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 6893d8b193fa809f7cd7cd9c44b1733b6b5607cb
Author: Takeshi Abe 
Date:   Sun Feb 18 16:00:39 2018 +0900

starmath: Spare unnecessary assignments

Change-Id: I8ddc1c04a76475d63a39dc21d36cda7a7aa26b9e
Reviewed-on: https://gerrit.libreoffice.org/49921
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/inc/node.hxx b/starmath/inc/node.hxx
index f4d90b9ada05..7479e3385503 100644
--- a/starmath/inc/node.hxx
+++ b/starmath/inc/node.hxx
@@ -266,12 +266,13 @@ public:
 {
 //Resize subnodes array
 maSubNodes.resize(nIndex + 1);
-//Set new slots to NULL
-for (size_t i = size; i < nIndex+1; i++)
+//Set new slots to NULL except at nIndex
+for (size_t i = size; i < nIndex; i++)
 maSubNodes[i] = nullptr;
 }
 maSubNodes[nIndex] = pNode;
-ClaimPaternity();
+if (pNode)
+pNode->SetParent(this);
 }
 
 private:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Crash test update

[Crashtest VM]

New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/cf9e55538375e5c5dea173151f1d0386bd29ad4e/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: desktop/source

[Markus Mohrhard]

 desktop/source/app/updater.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4f97bfb3c2f4b4bae40edbdfcdcfcdd8587c1c11
Author: Markus Mohrhard 
Date:   Mon Feb 19 00:42:36 2018 +0100

fix updater on windows

Change-Id: Ib6f2334a3f6f3f5c217a71e2967a69e354b0a473
Reviewed-on: https://gerrit.libreoffice.org/49956
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/desktop/source/app/updater.cxx b/desktop/source/app/updater.cxx
index e34cc6a7cce0..867b5f737329 100644
--- a/desktop/source/app/updater.cxx
+++ b/desktop/source/app/updater.cxx
@@ -152,7 +152,7 @@ void createStr(const OUString& rStr, CharT** pArgs, size_t 
i)
 #error "Need an implementation"
 #endif
 CharT* pStr = new CharT[aStr.getLength() + 1];
-tstrncpy(pStr, aStr.getStr(), aStr.getLength());
+tstrncpy(pStr, (CharT*)aStr.getStr(), aStr.getLength());
 pStr[aStr.getLength()] = '\0';
 pArgs[i] = pStr;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115834] "Capitalize first letter of every sentence" is non working properly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115834

--- Comment #1 from Giacomo Fina  ---
I also tried resetting user profile. Nothing changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115834] New: "Capitalize first letter of every sentence" is non working properly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115834

Bug ID: 115834
   Summary: "Capitalize first letter of every sentence" is non
working properly
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jaimemis...@gmail.com

Description:
The first letter of a sentence is not auto-capitalized when the first word is
followed by an apostrophe. I've tried both in english and in italian.
E.g.
After a full stop, the sentence "i am happy" will be auto-corrected in "I am
happy" but if you write "i'm happy", it will remain uncorrected.

Steps to Reproduce:
1.in a new document, write "i'm happy" without capitalizing the first letter
with the keyboard.

Actual Results:  
The first letter remained not capitalized

Expected Results:
it should have capitalized it


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115829] Search and replace is slow in a large document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115829

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Why do you spect 30 seconds, there are 9750 replacements, that implies preserve
their undo and redo the document at the same time. Using a word of the same
lenght seems it's bit quicker, so maybe redo such a long document for every
change it's the main issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara]

 sw/source/filter/ww8/ww8par.hxx  |2 +-
 sw/source/filter/ww8/ww8par2.cxx |9 -
 2 files changed, 5 insertions(+), 6 deletions(-)

New commits:
commit 99457255b69e67b276339d98f977ada8caa25753
Author: Caolán McNamara 
Date:   Sun Feb 18 21:16:06 2018 +

ofz#6450 use the rule name, not the rule itself

Change-Id: I62541dc48b7e9d5a906f32791437a86a8283a7bf
Reviewed-on: https://gerrit.libreoffice.org/49952
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8par.hxx b/sw/source/filter/ww8/ww8par.hxx
index 5b7b9a6f10e2..ed797637a04b 100644
--- a/sw/source/filter/ww8/ww8par.hxx
+++ b/sw/source/filter/ww8/ww8par.hxx
@@ -979,7 +979,7 @@ struct ANLDRuleMap
 OUString msOutlineNumRule;// WinWord 6 numbering, variant 1
 OUString msNumberingNumRule;  // WinWord 6 numbering, variant 2
 SwNumRule* GetNumRule(const SwDoc& rDoc, sal_uInt8 nNumType);
-void SetNumRule(const SwNumRule*, sal_uInt8 nNumType);
+void SetNumRule(const OUString& rNumRule, sal_uInt8 nNumType);
 };
 
 struct SprmReadInfo;
diff --git a/sw/source/filter/ww8/ww8par2.cxx b/sw/source/filter/ww8/ww8par2.cxx
index f284886201cd..3005b5dcc16a 100644
--- a/sw/source/filter/ww8/ww8par2.cxx
+++ b/sw/source/filter/ww8/ww8par2.cxx
@@ -874,13 +874,12 @@ SwNumRule *ANLDRuleMap::GetNumRule(const SwDoc& rDoc, 
sal_uInt8 nNumType)
 return rDoc.FindNumRulePtr(rNumRule);
 }
 
-void ANLDRuleMap::SetNumRule(const SwNumRule *pRule, sal_uInt8 nNumType)
+void ANLDRuleMap::SetNumRule(const OUString& rNumRule, sal_uInt8 nNumType)
 {
-OUString sNumRule = pRule ? pRule->GetName() : OUString();
 if (WW8_Numbering == nNumType)
-msNumberingNumRule = sNumRule;
+msNumberingNumRule = rNumRule;
 else
-msOutlineNumRule = sNumRule;
+msOutlineNumRule = rNumRule;
 }
 
 // StartAnl is called at the beginning of a row area that contains
@@ -952,7 +951,7 @@ void SwWW8ImplReader::StartAnl(const sal_uInt8* pSprm13)
 m_xCtrlStck->NewAttr(*m_pPaM->GetPoint(),
 SfxStringItem(RES_FLTR_NUMRULE, sNumRule));
 
-m_aANLDRules.SetNumRule(pNumRule, m_nWwNumType);
+m_aANLDRules.SetNumRule(sNumRule, m_nWwNumType);
 }
 
 // NextAnlLine() is called once for every row of a
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: lotuswordpro/source

[Caolán McNamara]

 lotuswordpro/source/filter/lwplayout.cxx |   29 +++--
 lotuswordpro/source/filter/lwplayout.hxx |1 +
 2 files changed, 16 insertions(+), 14 deletions(-)

New commits:
commit 68cebacac864da199ace7fe03db0e054e6b36966
Author: Caolán McNamara 
Date:   Sun Feb 18 21:06:33 2018 +

ofz#6448 infinite-regress

Change-Id: Ie0c082a4b43355e935594f2dda694edfc9cdf315
Reviewed-on: https://gerrit.libreoffice.org/49950
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/lotuswordpro/source/filter/lwplayout.cxx 
b/lotuswordpro/source/filter/lwplayout.cxx
index b18896468f22..df43d93a81e2 100644
--- a/lotuswordpro/source/filter/lwplayout.cxx
+++ b/lotuswordpro/source/filter/lwplayout.cxx
@@ -1424,6 +1424,7 @@ bool LwpMiddleLayout::HasContent()
 LwpLayout::LwpLayout(LwpObjectHeader const , LwpSvStream* pStrm)
 : LwpMiddleLayout(objHdr, pStrm)
 , m_bGettingShadow(false)
+, m_bGettingNumCols(false)
 {
 }
 
@@ -1472,24 +1473,24 @@ void LwpLayout::Read()
 */
 sal_uInt16 LwpLayout::GetNumCols()
 {
-if(m_nOverrideFlag & OVER_COLUMNS)
+if (m_bGettingNumCols)
+throw std::runtime_error("recursion in layout");
+m_bGettingNumCols = true;
+
+sal_uInt16 nRet = 0;
+LwpLayoutColumns* pLayColumns = (m_nOverrideFlag & OVER_COLUMNS) ? 
dynamic_cast(m_LayColumns.obj().get()) : nullptr;
+if (pLayColumns)
 {
-LwpLayoutColumns* pLayColumns = 
dynamic_cast(m_LayColumns.obj().get());
-if(pLayColumns)
-{
-return pLayColumns->GetNumCols();
-}
+nRet = pLayColumns->GetNumCols();
 }
-
-rtl::Reference xBase(GetBasedOnStyle());
-LwpVirtualLayout* pStyle = dynamic_cast(xBase.get());
-if (pStyle)
+else
 {
-return pStyle->GetNumCols();
+rtl::Reference xBase(GetBasedOnStyle());
+LwpVirtualLayout* pStyle = 
dynamic_cast(xBase.get());
+nRet = pStyle ? pStyle->GetNumCols() : LwpVirtualLayout::GetNumCols();
 }
-
-return LwpVirtualLayout::GetNumCols();
-
+m_bGettingNumCols = false;
+return nRet;
 }
 
 /**
diff --git a/lotuswordpro/source/filter/lwplayout.hxx 
b/lotuswordpro/source/filter/lwplayout.hxx
index a0f6ef868da3..50dbcdf57197 100644
--- a/lotuswordpro/source/filter/lwplayout.hxx
+++ b/lotuswordpro/source/filter/lwplayout.hxx
@@ -417,6 +417,7 @@ class LwpLayout : public LwpMiddleLayout
 {
 private:
 bool m_bGettingShadow;
+bool m_bGettingNumCols;
 public:
 LwpLayout( LwpObjectHeader const , LwpSvStream* pStrm );
 virtual ~LwpLayout() override;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/source

[Caolán McNamara]

 filter/source/graphicfilter/itiff/itiff.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4c15c1334406eb36e961e9fb7e782d26a830d958
Author: Caolán McNamara 
Date:   Sun Feb 18 21:09:53 2018 +

ofz#6449 Integer-overflow

Change-Id: Ia144192a1374615c50fb3574f7a229926e43d7cb
Reviewed-on: https://gerrit.libreoffice.org/49951
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index bad8ba73be43..2849fb776876 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1363,7 +1363,7 @@ bool TIFFReader::ReadTIFF(SvStream & rTIFF, Graphic & 
rGraphic )
 }
 if ( !nBitsPerSample || ( nBitsPerSample > 32 ) )
 bStatus = false;
-if (nImageWidth < 0 || nImageLength < 0)
+if (nImageWidth <= 0 || nImageLength <= 0)
 bStatus = false;
 if ( bStatus )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115824] FILEOPEN older files. Referenced Cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115824

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #4 from m.a.riosv  ---
I think it was resolved, but I'm not able to find the bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114878] Fix "CSV injection" vulnerability

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114878

--- Comment #4 from Jean-Baptiste Faure  ---
(In reply to Xisco Faulí from comment #3)
> @Mike Kaganski, should it be closed as RESOLVED WONTFIX ?

If I understand well what Mike wrote, it should be closed as RESOLVED NOTABUG.
WONTFIX agrees there is a problem in LibreOffice. It seems it is not the case.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115348] FILEOPEN: Left justified .rtf saved in LO is stuck fully justified when opened in MS Word

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115348

Jean-Baptiste Faure  changed:

   What|Removed |Added

Version|unspecified |5.1.0.3 release
 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115406] Support EPUB 3.0.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115406

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||jbfa...@libreoffice.org
Version|unspecified |6.1.0.0.alpha0+ Master
 Ever confirmed|0   |1
   Severity|normal  |enhancement

--- Comment #2 from Jean-Baptiste Faure  ---
Not a bug. Set to enhancement. From comment #1 I understand yes but later. So
set status to NEW.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115461] Exporting 3D scenes results in bad quality

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115461

Jean-Baptiste Faure  changed:

   What|Removed |Added

Version|unspecified |6.0.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115833] Specific autocorrection performed only if certain text exists in the document.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115833

--- Comment #1 from saverio.p...@gmail.com ---
System information:

- XUbuntu x86-64 16.04

Libreoffice information:

Version: 6.0.1.1
Build ID: 1:6.0.1~rc1-0ubuntu0.16.04.1~lo1
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115833] New: Specific autocorrection performed only if certain text exists in the document.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115833

Bug ID: 115833
   Summary: Specific autocorrection performed only if certain text
exists in the document.
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: saverio.p...@gmail.com

Created attachment 139981
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139981=edit
test case for replacement bug

I've removed the three dots replacement (`.*...` -> `…`) in the Write
autocorrect replacement list.

This works as expected - if I open a new document and type three dots (and
space), the three dots are not replaced.

However, there is a pecular exception; if I paste into the same document
certain text, and type three dots (and space), the three dots are now replaced.

I've attached what I believe is the minimal test case for reproducing the
problem.

In order to reproduce the error:

- remove the three dots replacement from Writer autocorrect options
- open the attached document
- type three dots (and space)

The three dots will be replaced.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38781] LOCALHELP for WRITER Navigation Toolbar ('View -> Toolbars -> Navigation') missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38781

--- Comment #14 from V Stuart Foote  ---
Aslo, if fully functional seems like this set of controls--.uno:NavigateBack &
.uno:NavigateForward would make sense to appear in the Standard toolbar, or
maybe the Navigator dialog adjacent to the PreviousPage/NextPage buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 38781] LOCALHELP for WRITER Navigation Toolbar ('View -> Toolbars -> Navigation') missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38781

--- Comment #14 from V Stuart Foote  ---
Aslo, if fully functional seems like this set of controls--.uno:NavigateBack &
.uno:NavigateForward would make sense to appear in the Standard toolbar, or
maybe the Navigator dialog adjacent to the PreviousPage/NextPage buttons.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 115798] Writer - Table of Contents are moved when saving a .docx format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115798

Jean-Baptiste Faure  changed:

   What|Removed |Added

Version|unspecified |5.3.7.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: cpp2uno throw problems.

[Stephan Bergmann]

On 18.02.2018 16:44, jan iversen wrote:
frame.cxx, 1270,  implts_sendFrameActionEvent( 
css::frame::FrameAction_FRAME_ACTIVATED );
cpp2uno.cxx, 204 (Mac version) CPPU_CURRENT_NAMESPACE::raiseException( 
, pThis->getBridge()->getUno2Cpp() ); // has to destruct the any
except.cxx, 290 (Mac version) void raiseException( uno_Any * pUnoExc, 
uno_Mapping * pUno2Cpp )


line 341 in raisException: __cxxabiv1::__cxa_throw( pCppExc, rtti, 
deleteException );


calls:

exc_thrower.cxx, 205, Any SAL_CALL getCaughtException()

and then

uno2cpp.cxx, 305, unoInterfaceProxyDispatch()
as expected.


Doing the same on the device, everything is identical until
line 341 in raisException: __cxxabiv1::__cxa_throw( pCppExc, rtti, 
deleteException );


which throws an exception that ends up in LoadEnv::~LoadEnv().


So in the first case the (synthetically) thrown exception is apparently 
caught by some exception handler for some type T, while in the second 
case that fails for whatever reason, and exception handling proceeds 
past that dismissed handler, and happens to call a LoadEnv dtor during 
stack unwinding.


The most likely reason for that handler for type T to be dismissed is 
that, while the (synthetically) thrown exception is nominally of type T 
or some type derived from it, the type info does not match.  (The 
libc++abi used on macOS and iOS uses the strict Itanium ABI rule of 
address equivalence for RTTI equivalence.)


Does the dlsym call


rtti = static_cast(dlsym( m_hApp, symName.getStr() ));


in RTTI::getRTTI in bridges/source/cpp_uno/gcc3_ios/except.cxx fail when 
it shouldn't (because the relevant RTTI is already emitted in the LO code)?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 38781] LOCALHELP for WRITER Navigation Toolbar ('View -> Toolbars -> Navigation') missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38781

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=5608

--- Comment #13 from V Stuart Foote  ---
The source [1][2] is reasonably well documented. And the Greenberg & Cockburn
[3] "recency with temporal ordering" based back and forward history navigation
remains.  But, if fully functional would expect the feature to be less about
navigating hyperlinks (internal or external) and for the control to provide
more generic Back and Forward movements within a document.

A GoToMark, GoToFLy, GotoINetAttr, GotoOutline (index), GotoOutline (string),
GotoRegion, GotoRefMark, GotoNextTOXBase, GotoTable,GotoFld, and GotoRedline
action were linked as history navigation targets. 

Unfortunately, not clear the "recency with temporal ordering" of the navigation
history is still implemented correctly. I couldn't identify where in UI a user
could "add" a mark to trigger inclusion of a SwUnoCsr position to the
m_entries[] list and _activate_ the control. And while inserting an internal
hyperlink--reference, bookmark, header, footer, etc. the Cusor is registered
into the navigation history, and activates the Navigation toolbar
controls--other actions for cursor/focus movement do not.  For example a
Go-to-End of document should provide a Navigation toolbar action to return
from.

=-ref-=
[1]
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/wrtsh/navmgr.cxx?a=true

[2] https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/navsh.hxx

[3] https://prism.ucalgary.ca/bitstream/handle/1880/45977/1999-641-04.pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 38781] LOCALHELP for WRITER Navigation Toolbar ('View -> Toolbars -> Navigation') missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38781

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=5608

--- Comment #13 from V Stuart Foote  ---
The source [1][2] is reasonably well documented. And the Greenberg & Cockburn
[3] "recency with temporal ordering" based back and forward history navigation
remains.  But, if fully functional would expect the feature to be less about
navigating hyperlinks (internal or external) and for the control to provide
more generic Back and Forward movements within a document.

A GoToMark, GoToFLy, GotoINetAttr, GotoOutline (index), GotoOutline (string),
GotoRegion, GotoRefMark, GotoNextTOXBase, GotoTable,GotoFld, and GotoRedline
action were linked as history navigation targets. 

Unfortunately, not clear the "recency with temporal ordering" of the navigation
history is still implemented correctly. I couldn't identify where in UI a user
could "add" a mark to trigger inclusion of a SwUnoCsr position to the
m_entries[] list and _activate_ the control. And while inserting an internal
hyperlink--reference, bookmark, header, footer, etc. the Cusor is registered
into the navigation history, and activates the Navigation toolbar
controls--other actions for cursor/focus movement do not.  For example a
Go-to-End of document should provide a Navigation toolbar action to return
from.

=-ref-=
[1]
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/wrtsh/navmgr.cxx?a=true

[2] https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/navsh.hxx

[3] https://prism.ucalgary.ca/bitstream/handle/1880/45977/1999-641-04.pdf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 114300] [META] Bugs and enhancements involving lock files or file locking

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114300

Aron Budea  changed:

   What|Removed |Added

 Depends on||115742


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115742
[Bug 115742] Can't save over a file if there is a lingering lock file from a
different user
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115742] Can' t save over a file if there is a lingering lock file from a different user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115742

Aron Budea  changed:

   What|Removed |Added

 Blocks||114300


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114300
[Bug 114300] [META] Bugs and enhancements involving lock files or file locking
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115818] Image disappears while editing a document or on autosave

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115818

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Telesto  ---
Repro with
Version: 6.1.0.0.alpha0+
Build ID: b87fe45e8b087a315a65b92bf9c168b1e4c5cc00
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-02-16_23:14:35
Locale: nl-NL (nl_NL); Calc: CL

No repro with
Version: 5.2.5.0.0+
Build ID: a4d4fbeb623013f6377b30711ceedb38ea4b49f8
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-2, Time:
2016-12-24_14:43:55
Locale: nl-NL (nl_NL); Calc: CL

Image isn't actually gone. It's somewhere at the bottom of the page and
transparent.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Manifest.xml for 64bit LO

[Stephan Bergmann]

On 18.02.2018 13:39, Jan Rheinländer wrote:

in my C++ extension manifest.xml I have the line:



What is the correct line to use for a 64-bit extension compiled for
64-bit LibreOffice? Can I bundle both 32bit and 64bit extension binaries
in the same .oxt?


The description at 
 
isn't too precise, but what should work is to use "Windows_x86" for 32 
bit and "Windows_x86_64" for 64 bit (and just "Windows" would mean that 
the corresponding file is suitable for both 32 and 64 bit, but which of 
course would not be the case for a DLL; see 
desktop/source/deployment/misc/dp_platform.cxx for the relevant code).

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 115565] Unable to use keyboard to move to previous or next toolbox item when Sidebar Navigator deck GotoPage control has focus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115565

Jim Raykowski  changed:

   What|Removed |Added

   Keywords||accessibility

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl vcl/source

[Markus Mohrhard]

 include/vcl/dialog.hxx   |2 ++
 vcl/source/window/dialog.cxx |   23 ---
 2 files changed, 14 insertions(+), 11 deletions(-)

New commits:
commit dc324bbffad071bc5a115b2faae1ac97ad216711
Author: Markus Mohrhard 
Date:   Sun Feb 18 19:09:07 2018 +0100

uitest: fix small race condition when launching modeless dialogs

Change-Id: I44f7af1b44badce6ed09eeca0bb19760b5f22aa9
Reviewed-on: https://gerrit.libreoffice.org/49942
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/include/vcl/dialog.hxx b/include/vcl/dialog.hxx
index 979c62c199dc..e2ad43bcbf48 100644
--- a/include/vcl/dialog.hxx
+++ b/include/vcl/dialog.hxx
@@ -176,6 +176,8 @@ class VCL_DLLPUBLIC ModelessDialog : public Dialog
 
 public:
 explicitModelessDialog( vcl::Window* pParent, const OUString& rID, 
const OUString& rUIXMLDescription, Dialog::InitFlag eFlag = 
Dialog::InitFlag::Default );
+
+voidActivate() override;
 };
 
 class VCL_DLLPUBLIC ModalDialog : public Dialog
diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index 0219f2a806d2..cdad91241c35 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -731,17 +731,6 @@ void Dialog::StateChanged( StateChangedType nType )
 ImplInitSettings();
 Invalidate();
 }
-
-if (!mbModalMode && nType == StateChangedType::Visible)
-{
-css::uno::Reference< css::uno::XComponentContext > xContext(
-comphelper::getProcessComponentContext() );
-css::uno::Reference 
xEventBroadcaster(css::frame::theGlobalEventBroadcaster::get(xContext), 
css::uno::UNO_QUERY_THROW);
-css::document::DocumentEvent aObject;
-aObject.EventName = "ModelessDialogVisible";
-xEventBroadcaster->documentEventOccured(aObject);
-UITestLogger::getInstance().log("Modeless Dialog Visible");
-}
 }
 
 void Dialog::DataChanged( const DataChangedEvent& rDCEvt )
@@ -1302,4 +1291,16 @@ ModalDialog::ModalDialog( vcl::Window* pParent, const 
OUString& rID, const OUStr
 {
 }
 
+void ModelessDialog::Activate()
+{
+css::uno::Reference< css::uno::XComponentContext > xContext(
+comphelper::getProcessComponentContext() );
+css::uno::Reference 
xEventBroadcaster(css::frame::theGlobalEventBroadcaster::get(xContext), 
css::uno::UNO_QUERY_THROW);
+css::document::DocumentEvent aObject;
+aObject.EventName = "ModelessDialogVisible";
+xEventBroadcaster->documentEventOccured(aObject);
+UITestLogger::getInstance().log("Modeless Dialog Visible");
+Dialog::Activate();
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: libreoffice-6.0.1.1 fails to compile with system gpgme-1.9.0

[Stephan Bergmann]

On 18.02.2018 21:37, Thorsten Behrens wrote:

John Frankish wrote:

The problem is with:

AC_CHECK_HEADER(gpgme++/gpgmepp_version.h, [ 
GPGMEPP_CFLAGS=-I/usr/include/gpgme++ ],


Ah right, I guess the GPGMEPP_CFLAGS=... part there is entirely
redundant. Should work fine w/o.


Note that we include gpgme++ include files without the leading 
"gpgme++/" (e.g.



#if HAVE_FEATURE_GPGME
# include 
# include 
# include 
# include 
# include 
#endif


in comphelper/source/misc/storagehelper.cxx), presumably because 
external/gpgmepp/ExternalProject_gpgmepp.mk in its current form doesn't 
provide those gpgme++ include files in a gpgme++ directory.


So setting GPGMEPP_CFLAGS for the --with-system-gpgmepp /is/ necessary 
with the current setup, it just does not work to arbitrarily guess that 
the gpgme++ directory is in /usr/include merely because the compiler is 
able to include gpgme++/gpgmepp_version.h from one of its system locations.


Probably best to make external/gpgmepp/ExternalProject_gpgmepp.mk run 
`make install` to somewhere, and use proper includes with "gpgme++/" 
prefix across our code.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 2 commits - sfx2/source svx/source sw/source

[Markus Mohrhard]

 sfx2/source/dialog/backingcomp.cxx |4 +++-
 svx/source/dialog/srchdlg.cxx  |2 ++
 sw/source/uibase/misc/redlndlg.cxx |2 ++
 3 files changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 76aea63d8055e9bb8d2edc85a739c9a48a7f8d96
Author: Markus Mohrhard 
Date:   Sun Feb 18 19:03:48 2018 +0100

uitest: call base class Activate in modeless dialogs

Change-Id: I342e925a5dbc178962f720f1efc9ee001d235718
Reviewed-on: https://gerrit.libreoffice.org/49941
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/svx/source/dialog/srchdlg.cxx b/svx/source/dialog/srchdlg.cxx
index b9075133bad0..6a0701bb1aa0 100644
--- a/svx/source/dialog/srchdlg.cxx
+++ b/svx/source/dialog/srchdlg.cxx
@@ -614,6 +614,8 @@ void SvxSearchDialog::Activate()
 m_pMatchCaseCB->Check( pSearchItem->GetExact() );
 m_pJapMatchFullHalfWidthCB->Check( 
!pSearchItem->IsMatchFullHalfWidthForms() );
 }
+
+SfxModelessDialog::Activate();
 }
 
 
diff --git a/sw/source/uibase/misc/redlndlg.cxx 
b/sw/source/uibase/misc/redlndlg.cxx
index 05a9aa77265f..3ac0dbd537aa 100644
--- a/sw/source/uibase/misc/redlndlg.cxx
+++ b/sw/source/uibase/misc/redlndlg.cxx
@@ -112,10 +112,12 @@ void SwModelessRedlineAcceptDlg::Activate()
 if (!bMod)
 pSh->ResetModified();
 pImplDlg->Init();
+SfxModelessDialog::Activate();
 
 return;
 }
 
+SfxModelessDialog::Activate();
 pImplDlg->Activate();
 }
 
commit 3ed222f6497cf6b2b54d90a4de80fe2db9130f59
Author: Markus Mohrhard 
Date:   Sun Feb 18 18:21:04 2018 +0100

don't use the global mutex for UI stuff

This leads to deadlocks if one thread is using the process factory
while holding the SolarMutex and another thread is calling the
BackingComp::getTypes method.

Change-Id: Ib4750aa1ebbfbf4f8dcd09ec2a218202450f4928
Reviewed-on: https://gerrit.libreoffice.org/49940
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sfx2/source/dialog/backingcomp.cxx 
b/sfx2/source/dialog/backingcomp.cxx
index 76086dc404c7..8d4ee36b4dd4 100644
--- a/sfx2/source/dialog/backingcomp.cxx
+++ b/sfx2/source/dialog/backingcomp.cxx
@@ -90,6 +90,8 @@ private:
 /** the owner frame of this component. */
 css::uno::Reference< css::frame::XFrame > m_xFrame;
 
+osl::Mutex m_aTypeProviderMutex;
+
 public:
 
 explicit BackingComp();
@@ -235,7 +237,7 @@ css::uno::Sequence< css::uno::Type > SAL_CALL 
BackingComp::getTypes()
 if (!pTypeCollection)
 {
 /* GLOBAL SAFE { */
-::osl::MutexGuard aGlobalLock(::osl::Mutex::getGlobalMutex());
+::osl::MutexGuard aGlobalLock(m_aTypeProviderMutex);
 // Control these pointer again ... it can be, that another instance 
will be faster then this one!
 if (!pTypeCollection)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: uitest/uitest

[Markus Mohrhard]

 uitest/uitest/test.py |8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

New commits:
commit fb4d5885f3c8d00ae528ddf57b2abaa4aabfbcf3
Author: Markus Mohrhard 
Date:   Sun Feb 18 01:06:13 2018 +0100

uitest: add timeout for blocking actions

Change-Id: I796d4ea0034ddae0427418f0d53a00c3dfa66871
Reviewed-on: https://gerrit.libreoffice.org/49939
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/uitest/uitest/test.py b/uitest/uitest/test.py
index 0318dfa64d81..f179807c5b0f 100644
--- a/uitest/uitest/test.py
+++ b/uitest/uitest/test.py
@@ -178,7 +178,7 @@ class UITest(object):
 time.sleep(DEFAULT_SLEEP)
 
 def execute_blocking_action(self, action, dialog_element=None,
-args=(), dialog_handler=None):
+args=(), dialog_handler=None, dialog_timeout=30):
 """Executes an action which blocks while a dialog is shown.
 
 Click a button or perform some other action on the dialog when it
@@ -192,6 +192,8 @@ class UITest(object):
 args(tuple, optional): The arguments to be passed to `action`
 dialog_handler(callable, optional): Will be called when the dialog
 is shown, with the dialog object passed as a parameter.
+timeout(optional): The maximum time the thread will wait for the
+dialog actions to happen. None means wait forever.
 """
 
 thread = threading.Thread(target=action, args=args)
@@ -207,7 +209,9 @@ class UITest(object):
 xUIElement.executeAction("CLICK", tuple())
 if dialog_handler:
 dialog_handler(xDlg)
-thread.join()
+thread.join(dialog_timeout)
+if thread.isAlive():
+raise DialogNotClosedException()
 return
 
 time_ += DEFAULT_SLEEP
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: libreoffice-6.0.1.1 fails to compile with system gpgme-1.9.0

[Thorsten Behrens]

John Frankish wrote:
> The problem is with:
> 
> AC_CHECK_HEADER(gpgme++/gpgmepp_version.h, [ 
> GPGMEPP_CFLAGS=-I/usr/include/gpgme++ ],
> 
Ah right, I guess the GPGMEPP_CFLAGS=... part there is entirely
redundant. Should work fine w/o.

If you have libs at non-standard places, please set CFLAGS/CPPFLAGS
accordingly.

> if test "$gccvisbroken" = "yes"; then
> as_fn_error $? "Your gcc is not -fvisibility=hidden safe. This is no 
> longer supported." "$LINENO" 5
> 
> ..to read "no", the build then succeeds.
> 
You should never need to hack configure (instead of
configure.ac). Still not sure what the fundamental problem really is
there.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 115824] FILEOPEN older files. Referenced Cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115824

--- Comment #3 from Laurent BP  ---
I see the problem. But behavior is the same whatever LibO version used: 5.3.7
or 6.0.1.
How did you build such formula?
If I manually remove extra sheet name, formula color enlightening works again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115757] A better performance of LibreOffice Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115757

J. Schulte  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #21 from J. Schulte  ---
When it shouldn´t help i will search for a better methode

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115832] LibreOffice 6.0.1.1 crash at launch, remains in recovery loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115832

--- Comment #3 from mrelw...@yahoo.com ---
Created attachment 139980
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139980=edit
System created "hang" report from yesterday, running LO 6.0.0.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115832] LibreOffice 6.0.1.1 crash at launch, remains in recovery loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115832

--- Comment #2 from mrelw...@yahoo.com ---
Created attachment 139979
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139979=edit
A system created crash report from 2 days ago that might not be related.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115832] LibreOffice 6.0.1.1 crash at launch, remains in recovery loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115832

mrelw...@yahoo.com changed:

   What|Removed |Added

Summary|LibreOffice 6 crash at  |LibreOffice 6.0.1.1 crash
   |launch, remains in recovery |at launch, remains in
   |loop|recovery loop

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115832] LibreOffice 6 crash at launch, remains in recovery loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115832

--- Comment #1 from mrelw...@yahoo.com ---
Created attachment 139978
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139978=edit
An .xls document that could be causing the issue.

Double-clicking this document in the LibreOffice welcome window recent
documents view might be causing the crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115832] New: LibreOffice 6 crash at launch, remains in recovery loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115832

Bug ID: 115832
   Summary: LibreOffice 6 crash at launch, remains in recovery
loop
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: Other
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mrelw...@yahoo.com

Description:
Since updating to LibreOffice 6.0.1.1 I haven't been able to use it for more
than a few seconds before it crashes. LibreOffice tries to relaunch, and
document recovery goes thru fine, after which it crashes immediately when I
click "OK".

LibreOffice 6.0 Document Recovery:
"Due to an unexpected error, LibreOffice Crashed. ..."

6.0.0.2 used to work, so I installed it on top of 6.0.1.1. No help, didn't get
it to launch. Installed 5.4.5 on top of that, works fine.

I renamed the user directory at
~/Application Support/LibreOffice
and reinstalled 6.0.1.1. It created a new user directory at launch, and
launched fine a few times until I clicked a recent .xls document at the
LibreOffice launch window. Crashed immediately, and fell back in the document
recovery loop. The .xls file is attached.

The latest crashes didn't create any crash reports, so I'm not sure if the
attached ones are relevant.

Steps to Reproduce:
1. Install LibreOffice 6.0.1.1 on top of previous LibreOffice install.
2. Launch LibreOffice, and open the attached .xls.
3. Quit LibreOffice.
4. Launch LibreOffice.app and select the same file from the recent files in the
welcome window.

Actual Results:  
LibreOffice crashes at launch and can not launch again without crashing and
entering document recovery loop.

Expected Results:
LibreOFfice to launch and open the document normally.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
As suggested in the links here at the bug reporting page:

"libreoffice --safe-mode" in Terminal does nothing as the command is not found.
Also navigated to the LibreOffice.app location and entered "LibreOffice.app
--safe-mode", same result, "command not found".

"registrymodifications.xcu" in ~/Library/Application Support/LibreOffice did
not have the string about "OpenGL", but putting it there as "false" didn't help
either.


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/604.5.6
(KHTML, like Gecko) Version/11.0.3 Safari/604.5.6

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115540] New formatting toolbar focused on the use of styles is not translated in french.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115540

Julien Nabet  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #5 from Julien Nabet  ---
Your new screenshot shows it's ok now.
Let's put this one to WFM then.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs