[Libreoffice-commits] online.git: loleaflet/src loleaflet/unocommands.js
loleaflet/src/control/Control.Menubar.js |5 - loleaflet/unocommands.js | 17 + 2 files changed, 13 insertions(+), 9 deletions(-) New commits: commit 209e34a1557844111727e08782024310858aa9e7 Author: Andras TimarDate: Tue Feb 20 23:31:12 2018 +0100 loleaflet: add Tools - AutoCorrect - While Typing toggle menu item to Writer Change-Id: Id5dfb0b99834beddd927d67167f3be5a417e138f Reviewed-on: https://gerrit.libreoffice.org/50069 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/loleaflet/src/control/Control.Menubar.js b/loleaflet/src/control/Control.Menubar.js index dc144648..d72e6f99 100644 --- a/loleaflet/src/control/Control.Menubar.js +++ b/loleaflet/src/control/Control.Menubar.js @@ -208,7 +208,10 @@ L.Control.Menubar = L.Control.extend({ {name: _UNO('.uno:SetLanguageAllTextMenu', 'text'), type: 'menu', menu: [ {name: _('None (Do not check spelling)'), id: 'nonelanguage', uno: '.uno:LanguageStatus?Language:string=Default_LANGUAGE_NONE'}]} ]}, - {uno: '.uno:WordCountDialog'} + {uno: '.uno:WordCountDialog'}, + {type: 'separator'}, + {name: _UNO('.uno:AutoFormatMenu', 'text'), type: 'menu', menu: [ + {uno: '.uno:OnlineAutoFormat'}]} ]}, {name: _UNO('.uno:HelpMenu', 'text'), id: 'help', type: 'menu', menu: [ {name: _('Keyboard shortcuts'), id: 'keyboard-shortcuts', type: 'action'}, diff --git a/loleaflet/unocommands.js b/loleaflet/unocommands.js index 40e8348c..2a41c046 100644 --- a/loleaflet/unocommands.js +++ b/loleaflet/unocommands.js @@ -6,6 +6,7 @@ var unoCommandsArray = { AnchorMenu:{global:{menu:_('Anc~hor'),},}, ArrangeFrameMenu:{text:{menu:_('Arrange'),},}, ArrangeMenu:{global:{menu:_('A~rrange'),},presentation:{menu:_('~Arrange'),},}, + AutoFormatMenu:{text:{menu:_('AutoCorr~ect'),},}, BackgroundColor:{global:{menu:_('Background Color'),},}, Bold:{global:{menu:_('Bold'),},}, BringToFront:{global:{menu:_('~Bring to Front'),},}, @@ -27,7 +28,7 @@ var unoCommandsArray = { CommonAlignVerticalCenter:{global:{menu:_('Center'),},}, ContinueNumbering:{text:{menu:_('Continue previous numbering'),},}, ControlCodes:{text:{menu:_('For~matting Marks'),},}, - Copy:{global:{menu:_('~Copy'),},}, + Copy:{global:{menu:_('Cop~y'),},}, CopyHyperlinkLocation:{text:{menu:_('Copy Hyperlink Location'),},}, Cut:{global:{menu:_('~Cut'),},}, DataFilterAutoFilter:{spreadsheet:{menu:_('Auto~Filter'),},}, @@ -84,7 +85,7 @@ var unoCommandsArray = { IncrementLevel:{text:{menu:_('Promote One Level'),},}, IncrementSubLevels:{text:{menu:_('Promote One Level With Subpoints'),},}, InsertAnnotation:{global:{context:_('Insert Comment'),menu:_('Comme~nt'),},presentation:{menu:_('Comme~nt'),},spreadsheet:{context:_('Insert Co~mment'),menu:_('Comm~ent'),},}, - InsertAuthorField:{presentation:{menu:_('~Author'),},text:{menu:_('~Author'),},}, + InsertAuthorField:{presentation:{menu:_('~Author'),},text:{menu:_('First ~Author'),},}, InsertBreakMenu:{spreadsheet:{menu:_('Insert Page ~Break'),},}, InsertColumnBreak:{spreadsheet:{menu:_('~Column Break'),},text:{menu:_('Insert Column Break'),},}, InsertColumnsAfter:{presentation:{menu:_('Insert Column Right'),},spreadsheet:{context:_('Insert Columns ~Right'),menu:_('Columns ~Right'),},text:{menu:_('Columns R~ight'),},}, @@ -92,7 +93,7 @@ var unoCommandsArray = { InsertColumnsMenu:{spreadsheet:{menu:_('Insert Co~lumns'),},}, InsertDateField:{text:{menu:_('~Date'),},}, InsertEndnote:{text:{menu:_('~Endnote'),},}, - InsertField:{text:{menu:_('~Fields'),},}, + InsertField:{text:{menu:_('~More Fields...'),},}, InsertFootnote:{text:{context:_('Insert Footnote'),menu:_('~Footnote'),},}, InsertGraphic:{global:{context:_('Insert Image...'),menu:_('~Image...'),},}, InsertHardHyphen:{global:{menu:_('Non-br~eaking hyphen'),},}, @@ -102,14 +103,13 @@ var unoCommandsArray = { InsertMenu:{global:{menu:_('~Insert'),},}, InsertNeutralParagraph:{text:{menu:_('Insert Unnumbered Entry'),},}, InsertNonBreakingSpace:{global:{menu:_('~Non-breaking space'),},}, + InsertPageCountField:{text:{menu:_('Page ~Count'),},}, InsertPageFooter:{text:{menu:_('Foote~r'),},}, InsertPageHeader:{text:{menu:_('He~ader'),},}, - InsertPageCountField:{text:{menu:_('Page ~Count'),},},
[Libreoffice-commits] core.git: desktop/source sfx2/source
desktop/source/lib/init.cxx |3 ++- sfx2/source/control/unoctitm.cxx |1 + 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit e73cba0cea07eedee5507535f585e89e42ea0124 Author: Andras TimarDate: Tue Feb 20 23:21:34 2018 +0100 lok: support of AutoCorrect -> While Typing menu in Writer Change-Id: I7c07f3a6269cd4b92cc50f7aaf847faf04665029 Reviewed-on: https://gerrit.libreoffice.org/50068 Tested-by: Jenkins Reviewed-by: Andras Timar diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 8d0611c21d07..1953b05daf70 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -1764,7 +1764,8 @@ static void doc_iniUnoCommands () OUString(".uno:DocumentRepair"), OUString(".uno:TransformDialog"), OUString(".uno:InsertPageHeader"), -OUString(".uno:InsertPageFooter") +OUString(".uno:InsertPageFooter"), +OUString(".uno:OnlineAutoFormat") }; util::URL aCommandURL; diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx index 31364d8f84a3..023ab89701e3 100644 --- a/sfx2/source/control/unoctitm.cxx +++ b/sfx2/source/control/unoctitm.cxx @@ -1005,6 +1005,7 @@ static void InterceptLOKStateChangeEvent(const SfxViewFrame* pViewFrame, const c aEvent.FeatureURL.Path == "RightPara" || aEvent.FeatureURL.Path == "Shadowed" || aEvent.FeatureURL.Path == "SpellOnline" || +aEvent.FeatureURL.Path == "OnlineAutoFormat" || aEvent.FeatureURL.Path == "SubScript" || aEvent.FeatureURL.Path == "SuperScript" || aEvent.FeatureURL.Path == "Strikeout" || ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115646] UI: Send E-Mail as PDF wont work
https://bugs.documentfoundation.org/show_bug.cgi?id=115646 --- Comment #2 from Terentev Maksim--- Can't send document via mail. I got: Error "Libreoffice can't find email settings" Although in Settings/Internet/Email typed "thunderbird" (and tried "/usr/bin/thunderbird") Xubuntu 16.04.3 Libreoffice from ppa 1:6.0.1~rc1-0ubuntu0.16.04.1~lo1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115897] New: LibreOffice 5.4.5 with fcitx-gtk3: open .ods or .xls password protected file, system becomes unresponsive
https://bugs.documentfoundation.org/show_bug.cgi?id=115897 Bug ID: 115897 Summary: LibreOffice 5.4.5 with fcitx-gtk3: open .ods or .xls password protected file, system becomes unresponsive Product: LibreOffice Version: 5.4.5.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kewl.bugzi...@alto.eu.org Description: Open a password protected .ods / .xlsx from Calc starting from a view with a blank spreadsheet opened. Calc uses 100% cpu and fills the memory until the system becomes unresponsive. Steps to Reproduce: 1. start from a view with blank spreadsheet and fcitx-gtk3 active 2. open password protected .ods 3. provide the correct password Actual Results: Calc uses 100% cpu and fills the memory until the system becomes unresponsive. Expected Results: Open the spreadsheet Reproducible: Always User Profile Reset: Yes Additional Info: Tested with fcitx-gtk3 4.2.9.6 and LibreOffice 5.4.5. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115896] FILEOPEN Shape in table in a DOC appears on wrong side of the page
https://bugs.documentfoundation.org/show_bug.cgi?id=115896 Dieter Praaschanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||dgp-m...@gmx.de Ever confirmed|0 |1 --- Comment #2 from Dieter Praas --- I confirm the described bahaviour in the attached document. Version: 6.1.0.0.alpha0+ (x64) Build ID: 77a535285f0fd5f2464430abdc67cf99be024868 CPU threads: 4; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-01-23_23:04:23 Locale: de-DE (de_DE); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
A bug in footer
Hi and thank you for your great job. Libreoffice is the best office suit ever! I assume I find a bug in Writer footer section. It's about writing in right-to-left languages of Arabic & Farsi(persian). When I assign a footnote and horizontal separator line appears on the left there is no way to permanently shift it to right. Every time I open the file I have to go through the footer section to change the separator line to right again. I have this problem in a number of platforms: Linux Mint 18.3 Cinnamon, Arch Linux Cinnamon, Mac Os X high sierra. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: cui/source include/svtools include/vcl svtools/source vcl/source
cui/source/tabpages/chardlg.cxx| 10 + include/svtools/ctrlbox.hxx|3 - include/vcl/field.hxx | 18 + svtools/source/control/ctrlbox.cxx | 14 ++- vcl/source/control/field.cxx | 71 +++-- 5 files changed, 47 insertions(+), 69 deletions(-) New commits: commit f00e891f3369f7b8c2532634d9ff4ab19da17c33 Author: Mike KaganskiDate: Wed Feb 21 00:30:16 2018 +0300 tdf#115892: properly get the box' saved value Previously textual value like "10,5 pt" was converted to int as simply 10 (multiplied by 10, it became 100), which compared as different from unchanged value of 105. This made the fractional values to be treated as always changed. This patch uses the same code to convert saved value as is used for current edit box value. Change-Id: I09a84a6bf33b17e0192b79b31af21ef14d7e9c63 Reviewed-on: https://gerrit.libreoffice.org/50066 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx index 1e641d05c688..cc34b315dd08 100644 --- a/cui/source/tabpages/chardlg.cxx +++ b/cui/source/tabpages/chardlg.cxx @@ -1040,14 +1040,8 @@ bool SvxCharNamePage::FillItemSet_Impl( SfxItemSet& rSet, LanguageGroup eLangGrp if ( pSizeBox->GetText().isEmpty() ) // GetValue() returns the min-value nSize = 0; -long nSavedSize = pSizeBox->GetSavedValue().toInt32(); -bool bRel = true; - -if ( !pSizeBox->IsRelative() ) -{ -nSavedSize *= 10; -bRel = false; -} +long nSavedSize = static_cast(pSizeBox->GetSavedIntValue()); +const bool bRel = pSizeBox->IsRelative(); switch ( eLangGrp ) { diff --git a/include/svtools/ctrlbox.hxx b/include/svtools/ctrlbox.hxx index b446b7a0503d..5e557e24777f 100644 --- a/include/svtools/ctrlbox.hxx +++ b/include/svtools/ctrlbox.hxx @@ -362,6 +362,7 @@ class SVT_DLLPUBLIC FontSizeBox : public MetricBox protected: virtual OUString CreateFieldText( sal_Int64 nValue ) const override; +virtual sal_Int64 GetValueFromStringUnit(const OUString& rStr, FieldUnit eOutUnit) const override; public: FontSizeBox( vcl::Window* pParent, WinBits nWinStyle ); @@ -384,8 +385,6 @@ public: virtual voidSetValue( sal_Int64 nNewValue, FieldUnit eInUnit ) override; virtual voidSetValue( sal_Int64 nNewValue ) override; -virtual sal_Int64 GetValue( FieldUnit eOutUnit ) const override; -virtual sal_Int64 GetValue() const override; private: FontSizeBox( const FontSizeBox& ) = delete; diff --git a/include/vcl/field.hxx b/include/vcl/field.hxx index 0380259acf01..615421153a0d 100644 --- a/include/vcl/field.hxx +++ b/include/vcl/field.hxx @@ -155,7 +155,8 @@ public: voidSetUserValue( sal_Int64 nNewValue ); virtual voidSetValue( sal_Int64 nNewValue ); -virtual sal_Int64 GetValue() const; +sal_Int64 GetValue() const; +sal_Int64 GetSavedIntValue() const; virtual OUStringCreateFieldText( sal_Int64 nValue ) const; boolIsValueModified() const; @@ -186,6 +187,8 @@ protected: SAL_DLLPRIVATE void ImplNewFieldValue( sal_Int64 nNewValue ); SAL_DLLPRIVATE void ImplSetUserValue( sal_Int64 nNewValue, Selection const * pNewSelection = nullptr ); +virtual sal_Int64 GetValueFromString(const OUString& rStr) const; + private: SAL_DLLPRIVATE void ImplInit(); @@ -225,8 +228,8 @@ public: virtual voidSetValue( sal_Int64 nValue ) override; using NumericFormatter::SetUserValue; voidSetUserValue( sal_Int64 nNewValue, FieldUnit eInUnit ); -virtual sal_Int64 GetValue( FieldUnit eOutUnit ) const; -virtual sal_Int64 GetValue() const override; +using NumericFormatter::GetValue; +sal_Int64 GetValue( FieldUnit eOutUnit ) const; virtual OUStringCreateFieldText( sal_Int64 nValue ) const override; sal_Int64 GetCorrectedValue( FieldUnit eOutUnit ) const; @@ -242,6 +245,9 @@ protected: SAL_DLLPRIVATE bool ImplMetricReformat( const OUString& rStr, double& rValue, OUString& rOutStr ); +virtual sal_Int64 GetValueFromString(const OUString& rStr) const override; +virtual sal_Int64 GetValueFromStringUnit(const OUString& rStr, FieldUnit eOutUnit) const; + private: SAL_DLLPRIVATE voidImplInit(); @@ -255,6 +261,7 @@ class VCL_DLLPUBLIC CurrencyFormatter : public NumericFormatter protected: CurrencyFormatter(); SAL_DLLPRIVATE bool ImplCurrencyReformat( const OUString& rStr, OUString& rOutStr ); +virtual sal_Int64 GetValueFromString(const
[Libreoffice-commits] core.git: compilerplugins/clang dbaccess/source desktop/source editeng/qa framework/source sal/cppunittester sax/source sdext/source sfx2/source shell/source slideshow/source sto
compilerplugins/clang/nestedunnamed.cxx | 75 + dbaccess/source/ui/querydesign/QueryDesignView.cxx| 15 desktop/source/deployment/registry/component/dp_component.cxx |5 editeng/qa/unit/core-test.cxx | 24 framework/source/services/autorecovery.cxx| 37 framework/source/services/urltransformer.cxx | 79 - sal/cppunittester/cppunittester.cxx |4 sax/source/expatwrap/sax_expat.cxx| 35 sdext/source/pdfimport/wrapper/wrapper.cxx| 79 - sfx2/source/view/frmload.cxx | 29 shell/source/backends/desktopbe/desktopbackend.cxx|4 slideshow/source/engine/opengl/TransitionerImpl.cxx | 591 -- slideshow/source/engine/slide/slideimpl.cxx | 45 stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTscript.cxx |4 svl/qa/unit/svl.cxx |2 svtools/source/uno/wizard/unowizard.cxx | 91 - svx/source/tbxctrls/tbunosearchcontrollers.cxx| 11 sw/source/core/unocore/unoportenum.cxx|3 toolkit/source/awt/vclxtoolkit.cxx| 62 - toolkit/source/controls/animatedimages.cxx| 17 toolkit/source/controls/grid/sortablegriddatamodel.cxx| 116 - vcl/source/gdi/dibtools.cxx | 40 22 files changed, 667 insertions(+), 701 deletions(-) New commits: commit ba8a70365ef459c967cd8a71a6d48ca53dd341bd Author: Stephan BergmannDate: Tue Feb 20 16:03:20 2018 +0100 New loplugin:nestedunnamed Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c Reviewed-on: https://gerrit.libreoffice.org/50048 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/compilerplugins/clang/nestedunnamed.cxx b/compilerplugins/clang/nestedunnamed.cxx new file mode 100644 index ..c26f5aac8efd --- /dev/null +++ b/compilerplugins/clang/nestedunnamed.cxx @@ -0,0 +1,75 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include + +#include "plugin.hxx" + +// Warn about unnamed namespaces nested (directly) within unnamed namespaces. (It can be hard to +// keep track whether a certain spot in a source file is already in an unnamed namespace, so it +// happens that additions to the source add redundant, nested unnamed namespaces.) + +namespace +{ +class NestedUnnamed : public RecursiveASTVisitor, public loplugin::Plugin +{ +public: +explicit NestedUnnamed(loplugin::InstantiationData const& data) +: Plugin(data) +{ +} + +void run() override +{ +if (compiler.getLangOpts().CPlusPlus) +{ +TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); +} +} + +bool VisitNamespaceDecl(NamespaceDecl const* decl) +{ +if (ignoreLocation(decl)) +{ +return true; +} +if (!decl->isAnonymousNamespace()) +{ +return true; +} +NamespaceDecl const* outer; +for (auto p = decl->getLexicalParent();; p = p->getLexicalParent()) +{ +outer = dyn_cast(p); +if (outer != nullptr) +{ +break; +} +if (isa(p)) +{ +return true; +} +} +if (!outer->isAnonymousNamespace()) +{ +return true; +} +report(DiagnosticsEngine::Warning, "unnamed namespace directly nested in unnamed namespace", + decl->getLocation()) +<< decl->getSourceRange(); +report(DiagnosticsEngine::Note, "outer namespace declared here", outer->getLocation()) +<< outer->getSourceRange(); +return true; +} +}; + +loplugin::Plugin::Registration X("nestedunnamed"); +} + +/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx b/dbaccess/source/ui/querydesign/QueryDesignView.cxx index 8a0f82fd05d3..ee67a9a69fe2 100644 --- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx +++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx @@ -1685,18 +1685,15 @@ namespace return eErrorCode; } -namespace +OQueryTableWindow*
[Libreoffice-bugs] [Bug 115896] FILEOPEN Shape in table in a DOC appears on wrong side of the page
https://bugs.documentfoundation.org/show_bug.cgi?id=115896 --- Comment #1 from Aron Budea--- Created attachment 140030 --> https://bugs.documentfoundation.org/attachment.cgi?id=140030=edit PDF exported from Word -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112700] [META] DOC (binary) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112700 Aron Budeachanged: What|Removed |Added Depends on||115896 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115896 [Bug 115896] FILEOPEN Shape in table in a DOC appears on wrong side of the page -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112793] [META] DOC (binary) shape-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112793 Aron Budeachanged: What|Removed |Added Depends on||115896 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115896 [Bug 115896] FILEOPEN Shape in table in a DOC appears on wrong side of the page -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115896] New: FILEOPEN Shape in table in a DOC appears on wrong side of the page
https://bugs.documentfoundation.org/show_bug.cgi?id=115896 Bug ID: 115896 Summary: FILEOPEN Shape in table in a DOC appears on wrong side of the page Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Keywords: filter:doc Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu Blocks: 112700, 112793 Created attachment 140029 --> https://bugs.documentfoundation.org/attachment.cgi?id=140029=edit Sample DOC Open the attached DOC. The yellow shape should be near the right edge of the table. => It is on the left side instead. Observed with LO 6.0.1.1 & 3.3.0 / Windows 7. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112700 [Bug 112700] [META] DOC (binary) table-related issues https://bugs.documentfoundation.org/show_bug.cgi?id=112793 [Bug 112793] [META] DOC (binary) shape-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/authratr.hxx |2 +- sw/source/core/inc/layact.hxx |2 +- sw/source/core/layout/layact.cxx|8 sw/source/core/text/txtpaint.hxx|4 ++-- sw/source/core/txtnode/fntcache.cxx |2 +- sw/source/filter/ww8/ww8graf.cxx|2 +- sw/source/filter/ww8/ww8par.hxx |6 +++--- sw/source/filter/ww8/ww8par6.cxx| 14 +++--- sw/source/filter/ww8/ww8scan.cxx|2 +- sw/source/ui/config/optpage.cxx |4 ++-- sw/source/uibase/app/swmodul1.cxx | 10 +- sw/source/uibase/docvw/srcedtw.cxx |2 +- 12 files changed, 29 insertions(+), 29 deletions(-) New commits: commit 0adb36835bcbe55bdf2717556a98e51f1873b19f Author: Noel GrandinDate: Tue Feb 20 17:05:04 2018 +0200 ColorData->Color in sw Change-Id: I6b5b6b15f86d452b73fe02df5dec5490b29daed8 Reviewed-on: https://gerrit.libreoffice.org/50050 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/inc/authratr.hxx b/sw/inc/authratr.hxx index cb932d88bddc..03f670fde347 100644 --- a/sw/inc/authratr.hxx +++ b/sw/inc/authratr.hxx @@ -28,7 +28,7 @@ class SW_DLLPUBLIC AuthorCharAttr public: sal_uInt16 m_nItemId; sal_uInt16 m_nAttr; -ColorData m_nColor; +Color m_nColor; AuthorCharAttr(); diff --git a/sw/source/core/inc/layact.hxx b/sw/source/core/inc/layact.hxx index 3912a696ea92..9240ef9d2a98 100644 --- a/sw/source/core/inc/layact.hxx +++ b/sw/source/core/inc/layact.hxx @@ -190,7 +190,7 @@ class SwLayIdle #endif #ifdef DBG_UTIL -void ShowIdle( ColorData eName ); +void ShowIdle( Color eName ); #endif enum IdleJobType{ ONLINE_SPELLING, AUTOCOMPLETE_WORDS, WORD_COUNT, SMART_TAGS }; diff --git a/sw/source/core/layout/layact.cxx b/sw/source/core/layout/layact.cxx index ca12cc96c7da..a4df2477ea01 100644 --- a/sw/source/core/layout/layact.cxx +++ b/sw/source/core/layout/layact.cxx @@ -2047,7 +2047,7 @@ bool SwLayIdle::DoIdleJob( IdleJobType eJob, bool bVisAreaOnly ) } #if HAVE_FEATURE_DESKTOP && defined DBG_UTIL -void SwLayIdle::ShowIdle( ColorData eColorData ) +void SwLayIdle::ShowIdle( Color eColor ) { if ( !m_bIndicator ) { @@ -2059,16 +2059,16 @@ void SwLayIdle::ShowIdle( ColorData eColorData ) aRect = pWin->PixelToLogic( aRect ); // Depending on if idle layout is in progress or not, draw a "red square" or a "green square". pWin->Push( PushFlags::FILLCOLOR|PushFlags::LINECOLOR ); -pWin->SetFillColor( eColorData ); +pWin->SetFillColor( eColor ); pWin->SetLineColor(); pWin->DrawRect( aRect ); pWin->Pop(); } } } -#define SHOW_IDLE( ColorData ) ShowIdle( ColorData ) +#define SHOW_IDLE( Color ) ShowIdle( Color ) #else -#define SHOW_IDLE( ColorData ) +#define SHOW_IDLE( Color ) #endif // DBG_UTIL SwLayIdle::SwLayIdle( SwRootFrame *pRt, SwViewShellImp *pI ) : diff --git a/sw/source/core/text/txtpaint.hxx b/sw/source/core/text/txtpaint.hxx index 21fbefc2822d..44ae26ff49bf 100644 --- a/sw/source/core/text/txtpaint.hxx +++ b/sw/source/core/text/txtpaint.hxx @@ -72,7 +72,7 @@ class DbgRect : public SwDbgOut public: DbgRect( OutputDevice* pOut, const tools::Rectangle , const bool bOn, - ColorData eColor ); + Color eColor ); }; inline SwDbgOut::SwDbgOut( OutputDevice* pOutDev, const bool bOn ) @@ -99,7 +99,7 @@ inline DbgBackColor::~DbgBackColor() inline DbgRect::DbgRect( OutputDevice* pOutDev, const tools::Rectangle , const bool bOn, - ColorData eColor ) + Color eColor ) : SwDbgOut( pOutDev, bOn ) { if( pOut ) diff --git a/sw/source/core/txtnode/fntcache.cxx b/sw/source/core/txtnode/fntcache.cxx index dd13467717a1..e177aa948201 100644 --- a/sw/source/core/txtnode/fntcache.cxx +++ b/sw/source/core/txtnode/fntcache.cxx @@ -2469,7 +2469,7 @@ bool SwDrawTextInfo::ApplyAutoColor( vcl::Font* pFont ) { const vcl::Font& rFnt = pFont ? *pFont : GetOut().GetFont(); bool bPrt = GetShell() && ! GetShell()->GetWin(); -ColorData nNewColor = COL_BLACK; +Color nNewColor = COL_BLACK; bool bChgFntColor = false; bool bChgLineColor = false; diff --git a/sw/source/filter/ww8/ww8graf.cxx b/sw/source/filter/ww8/ww8graf.cxx index f8258e10a001..1fa4223b7531 100644 --- a/sw/source/filter/ww8/ww8graf.cxx +++ b/sw/source/filter/ww8/ww8graf.cxx @@ -112,7 +112,7 @@ Color WW8TransCol(SVBT32 nWC) // (to make the writer UI show the right color names) // the table is split in base 3, the greys are missing as // they don't fit into that system (4 values: bw, wb, 2 * grey) -static const ColorData eColA[] = { // B G R B G R B G R +static const Color eColA[] = { // B G
[Libreoffice-commits] core.git: 2 commits - editeng/source filter/source framework/source include/filter include/svtools reportdesign/source sc/source sd/source sfx2/source starmath/source svtools/sou
editeng/source/accessibility/AccessibleEditableTextPara.cxx |2 editeng/source/accessibility/AccessibleImageBullet.cxx |2 filter/source/msfilter/msdffimp.cxx |2 filter/source/msfilter/util.cxx |2 framework/source/services/taskcreatorsrv.cxx|2 include/filter/msfilter/msdffimp.hxx|4 - include/svtools/colorcfg.hxx|2 reportdesign/source/ui/inc/ColorListener.hxx|2 sc/source/core/tool/detfunc.cxx |6 +- sc/source/ui/Accessibility/AccessibleCsvControl.cxx |4 - sc/source/ui/Accessibility/AccessibleDocument.cxx |2 sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx|2 sc/source/ui/view/output2.cxx |4 - sd/source/ui/accessibility/AccessibleDocumentViewBase.cxx |2 sd/source/ui/accessibility/AccessibleSlideSorterObject.cxx |2 sd/source/ui/accessibility/AccessibleSlideSorterView.cxx|2 sd/source/ui/slidesorter/inc/view/SlsTheme.hxx | 18 sd/source/ui/slidesorter/view/SlsTheme.cxx | 25 +--- sfx2/source/sidebar/Paint.cxx |2 starmath/source/accessibility.cxx |4 - starmath/source/tmpdevice.cxx |4 - starmath/source/view.cxx|2 svtools/source/config/colorcfg.cxx |6 +- svtools/source/edit/editsyntaxhighlighter.cxx | 14 +++--- svx/source/accessibility/GraphCtlAccessibleContext.cxx |2 svx/source/unodraw/XPropertyTable.cxx |5 -- svx/source/unodraw/unoctabl.cxx |8 +-- sw/source/core/access/accdoc.cxx|2 28 files changed, 66 insertions(+), 68 deletions(-) New commits: commit 72593849bb644684a8c00f70a3f18bcfabca737f Author: Noel GrandinDate: Tue Feb 20 15:22:05 2018 +0200 ColorData->Color in sd..svx Change-Id: I70de56b6bfb1ea4655ec03510fad92bf6645f64e Reviewed-on: https://gerrit.libreoffice.org/50046 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/editeng/source/accessibility/AccessibleEditableTextPara.cxx b/editeng/source/accessibility/AccessibleEditableTextPara.cxx index 29fa9380eaf9..ecaf8445eea0 100644 --- a/editeng/source/accessibility/AccessibleEditableTextPara.cxx +++ b/editeng/source/accessibility/AccessibleEditableTextPara.cxx @@ -1136,7 +1136,7 @@ namespace accessibility { // #10# Added to XAccessibleComponent interface svtools::ColorConfig aColorConfig; -sal_uInt32 nColor = aColorConfig.GetColorValue( svtools::FONTCOLOR ).nColor; +Color nColor = aColorConfig.GetColorValue( svtools::FONTCOLOR ).nColor; return static_cast(nColor); } diff --git a/editeng/source/accessibility/AccessibleImageBullet.cxx b/editeng/source/accessibility/AccessibleImageBullet.cxx index a475af08b09a..5ab8259f92a7 100644 --- a/editeng/source/accessibility/AccessibleImageBullet.cxx +++ b/editeng/source/accessibility/AccessibleImageBullet.cxx @@ -326,7 +326,7 @@ namespace accessibility // #10# Added to XAccessibleComponent interface svtools::ColorConfig aColorConfig; -sal_uInt32 nColor = aColorConfig.GetColorValue( svtools::FONTCOLOR ).nColor; +Color nColor = aColorConfig.GetColorValue( svtools::FONTCOLOR ).nColor; return static_cast(nColor); } diff --git a/framework/source/services/taskcreatorsrv.cxx b/framework/source/services/taskcreatorsrv.cxx index 5c60edf117fb..532c96c401f3 100644 --- a/framework/source/services/taskcreatorsrv.cxx +++ b/framework/source/services/taskcreatorsrv.cxx @@ -267,7 +267,7 @@ css::uno::Reference< css::awt::XWindow > TaskCreatorService::implts_createContai { try { -nBackground = ::svtools::ColorConfig().GetColorValue(::svtools::APPBACKGROUND).nColor; +nBackground = sal_Int32(::svtools::ColorConfig().GetColorValue(::svtools::APPBACKGROUND).nColor); } catch (const css::uno::Exception &) { diff --git a/include/svtools/colorcfg.hxx b/include/svtools/colorcfg.hxx index ad3672d7b83b..983db90311cb 100644 --- a/include/svtools/colorcfg.hxx +++ b/include/svtools/colorcfg.hxx @@ -84,7 +84,7 @@ struct ColorConfigValue { boolbIsVisible; //validity depends on the element type -sal_Int32 nColor; +::Color nColor; ColorConfigValue() : bIsVisible(false), nColor(0) {} bool operator !=(const ColorConfigValue& rCmp) const { return nColor != rCmp.nColor || bIsVisible != rCmp.bIsVisible;} diff --git
[Libreoffice-commits] core.git: compilerplugins/clang include/svx svx/source
compilerplugins/clang/changetoolsgen.cxx |4 include/svx/svdtrans.hxx |2 svx/source/accessibility/ChildrenManagerImpl.cxx |8 svx/source/accessibility/charmapacc.cxx |2 svx/source/accessibility/svxpixelctlaccessiblecontext.cxx |4 svx/source/customshapes/EnhancedCustomShape2d.cxx | 36 - svx/source/customshapes/EnhancedCustomShape3d.cxx | 16 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx | 10 svx/source/dialog/ClassificationEditView.cxx |4 svx/source/dialog/_contdlg.cxx| 14 svx/source/dialog/charmap.cxx | 34 - svx/source/dialog/connctrl.cxx| 16 svx/source/dialog/contwnd.cxx |4 svx/source/dialog/dlgctl3d.cxx| 20 - svx/source/dialog/dlgctrl.cxx | 32 - svx/source/dialog/docrecovery.cxx |4 svx/source/dialog/fntctrl.cxx |6 svx/source/dialog/framelinkarray.cxx |8 svx/source/dialog/graphctl.cxx| 12 svx/source/dialog/hdft.cxx|4 svx/source/dialog/imapwnd.cxx |4 svx/source/dialog/measctrl.cxx|4 svx/source/dialog/pagectrl.cxx| 58 +- svx/source/dialog/paraprev.cxx| 42 +- svx/source/dialog/rulritem.cxx|8 svx/source/dialog/searchcharmap.cxx | 14 svx/source/dialog/svxbmpnumvalueset.cxx | 26 - svx/source/dialog/swframeexample.cxx | 180 - svx/source/engine3d/scene3d.cxx | 24 - svx/source/engine3d/view3d.cxx|8 svx/source/fmcomp/fmgridcl.cxx|8 svx/source/fmcomp/fmgridif.cxx|4 svx/source/fmcomp/gridctrl.cxx| 26 - svx/source/form/datanavi.cxx | 16 svx/source/form/filtnav.cxx | 16 svx/source/form/fmexpl.cxx|4 svx/source/form/fmpage.cxx|8 svx/source/form/fmvwimp.cxx | 16 svx/source/form/tabwin.cxx|4 svx/source/form/tbxform.cxx |6 svx/source/gallery2/galbrws1.cxx |4 svx/source/gallery2/galbrws2.cxx |4 svx/source/gallery2/galctrl.cxx | 10 svx/source/gallery2/galobj.cxx|8 svx/source/sdr/overlay/overlaymanagerbuffered.cxx |8 svx/source/sidebar/PanelLayout.cxx|4 svx/source/sidebar/line/LineWidthValueSet.cxx | 12 svx/source/sidebar/tools/ValueSetWithTextControl.cxx | 18 svx/source/stbctrls/pszctrl.cxx | 14 svx/source/stbctrls/xmlsecctrl.cxx|6 svx/source/stbctrls/zoomsliderctrl.cxx| 20 - svx/source/styles/CommonStylePreviewRenderer.cxx |8 svx/source/svdraw/svdcrtv.cxx |8 svx/source/svdraw/svddrag.cxx |8 svx/source/svdraw/svddrgmt.cxx| 68 +-- svx/source/svdraw/svddrgv.cxx |4 svx/source/svdraw/svdedtv1.cxx| 16 svx/source/svdraw/svdedtv2.cxx|4 svx/source/svdraw/svdedxv.cxx | 80 ++-- svx/source/svdraw/svdetc.cxx | 16 svx/source/svdraw/svdfmtf.cxx | 26 - svx/source/svdraw/svdglev.cxx |4 svx/source/svdraw/svdglue.cxx | 40 +- svx/source/svdraw/svdhdl.cxx |8 svx/source/svdraw/svdhlpln.cxx| 12 svx/source/svdraw/svdibrow.cxx| 10 svx/source/svdraw/svdmrkv.cxx | 24 - svx/source/svdraw/svdmrkv1.cxx|8 svx/source/svdraw/svdoashp.cxx| 112 ++--- svx/source/svdraw/svdobj.cxx | 96 ++-- svx/source/svdraw/svdocapt.cxx| 16 svx/source/svdraw/svdocirc.cxx| 56 +- svx/source/svdraw/svdoedge.cxx| 272 +++--- svx/source/svdraw/svdograf.cxx
[Libreoffice-bugs] [Bug 115895] Color picker images missing in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=115895 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115895] New: Color picker images missing in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=115895 Bug ID: 115895 Summary: Color picker images missing in Impress Product: LibreOffice Version: 6.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: normal Priority: high Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: noelgran...@gmail.com Created attachment 140028 --> https://bugs.documentfoundation.org/attachment.cgi?id=140028=edit Screenshot Start Impress. The images for color widgets in the toolbar are missing (see screenshot). Observed using LO 6.1 daily build (a8d4d4b9edca48b8fb94dbb06d7dd1e689b07b98, 2018-02-20_23:42:48) / Windows 7. The images are there in 6.0.1.1. => regression Bibisected to the following commit using repo bibisect-win32-6.1. Adding Cc: to Noel Grandin, please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=88ca1a6f75b1e94136e04e8dc65b98955d0e8aaf author Noel Grandin2018-02-14 15:30:50 +0200 committer Noel Grandin 2018-02-15 12:52:53 +0100 move ToolboxButtonColorUpdater bitmap update to VirtualDevice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: solenv/vs
solenv/vs/LibreOffice.natvis |7 +++ 1 file changed, 7 insertions(+) New commits: commit fd20935bb819cb24e71f4f91b97149c35bc5987d Author: Mike KaganskiDate: Wed Feb 21 00:43:13 2018 +0300 Update LibreOffice.natvis Change-Id: I46a976de94508dd2b79c9dcb19d25d307f4c732c Reviewed-on: https://gerrit.libreoffice.org/50067 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/solenv/vs/LibreOffice.natvis b/solenv/vs/LibreOffice.natvis index d1b2b8938b11..ad45cbe19432 100644 --- a/solenv/vs/LibreOffice.natvis +++ b/solenv/vs/LibreOffice.natvis @@ -102,6 +102,13 @@ {m_Point}, {m_Size} + +{nRight==-32767?0:(nRight-nLeft+(nLeft>nRight?(-1):(1)))} +{nBottom==-32767?0:(nBottom-nTop+(nTop>nBottom?(-1):(1)))} +empty +{*this,view(w)nd} x {*this,view(h)nd} +{{ LT=[{nLeft} , {nTop}] RB=[{nRight} , {nBottom}] [{*this,view(sz)}] }} + _sal_Sequence (empty) _sal_Sequence of {nElements,d} elements ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115353] Status bar displays wrong characters upon load (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=115353 --- Comment #6 from Aron Budea--- Created attachment 140027 --> https://bugs.documentfoundation.org/attachment.cgi?id=140027=edit Screenshot (02.20.) I'm afraid it still isn't working correctly, the attached screenshot was taken with a fres daily build. It is sometimes showing correctly, but closing and reopening the presentation, maybe resizing the window in between brings forth the issue in a few tries. Version: 6.1.0.0.alpha0+ (x64) Build ID: a8d4d4b9edca48b8fb94dbb06d7dd1e689b07b98 CPU threads: 16; OS: Windows 6.1; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-02-20_23:42:48 Locale: hu-HU (hu_HU); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115353] Status bar displays wrong characters upon load (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=115353 Aron Budeachanged: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 Bug 83066 depends on bug 115353, which changed state. Bug 115353 Summary: Status bar displays wrong characters upon load (OpenGL) https://bugs.documentfoundation.org/show_bug.cgi?id=115353 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL rendering tracker bug for 5.0+
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 Bug 93529 depends on bug 115353, which changed state. Bug 115353 Summary: Status bar displays wrong characters upon load (OpenGL) https://bugs.documentfoundation.org/show_bug.cgi?id=115353 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106100] presentation with svgs mangled in >= 5.2
https://bugs.documentfoundation.org/show_bug.cgi?id=106100 --- Comment #6 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: editeng/qa
editeng/qa/unit/core-test.cxx | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) New commits: commit 156f5105e5c0d127d618ce8c120cfe9618a0e44a Author: Tamás ZolnaiDate: Wed Feb 21 01:03:59 2018 +0100 Increase delta value for these checks Change-Id: I14582541bf076340cfc95a17e1a9070a596c67db Reviewed-on: https://gerrit.libreoffice.org/50073 Tested-by: Jenkins Reviewed-by: Tamás Zolnai diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx index b34ad8bb18f8..e0f03a8d75d8 100644 --- a/editeng/qa/unit/core-test.cxx +++ b/editeng/qa/unit/core-test.cxx @@ -1892,12 +1892,7 @@ void Test::testHoriAlignIgnoreTrailingWhitespace() // Check horizontal position ParaPortion* pParaPortion = aEditEngine.GetParaPortions()[0]; EditLine* pLine = >GetLines()[0]; -// this keeps failing on OSX with a value of 4495 -#if !defined(MACOSX) -CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(4527), pLine->GetStartPosX(), 10); -#else -(void) pLine; // avoid -Wunused-variable -#endif +CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(4527), pLine->GetStartPosX(), 100); } // Second test case: center alignment with compatibility option disabled @@ -1918,7 +1913,7 @@ void Test::testHoriAlignIgnoreTrailingWhitespace() // Check horizontal position ParaPortion* pParaPortion = aEditEngine.GetParaPortions()[0]; EditLine* pLine = >GetLines()[0]; -CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(4407), pLine->GetStartPosX(), 10); +CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(4407), pLine->GetStartPosX(), 100); } // Third test case: right alignment with compatibility option enabled @@ -1939,7 +1934,7 @@ void Test::testHoriAlignIgnoreTrailingWhitespace() // Check horizontal position ParaPortion* pParaPortion = aEditEngine.GetParaPortions()[0]; EditLine* pLine = >GetLines()[0]; -CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(9054), pLine->GetStartPosX(), 10); +CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(9054), pLine->GetStartPosX(), 100); } // Fourth test case: right alignment with compatibility option disabled @@ -1960,7 +1955,7 @@ void Test::testHoriAlignIgnoreTrailingWhitespace() // Check horizontal position ParaPortion* pParaPortion = aEditEngine.GetParaPortions()[0]; EditLine* pLine = >GetLines()[0]; -CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(8815), pLine->GetStartPosX(), 10); +CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(8815), pLine->GetStartPosX(), 100); } // Test multiple paragraph case @@ -1991,9 +1986,9 @@ void Test::testHoriAlignIgnoreTrailingWhitespace() // Check horizontal position ParaPortion* pParaPortion = aEditEngine.GetParaPortions()[0]; -CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(4527), pParaPortion->GetLines()[0].GetStartPosX(), 50); +CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(4527), pParaPortion->GetLines()[0].GetStartPosX(), 100); pParaPortion = aEditEngine.GetParaPortions()[1]; -CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(8815), pParaPortion->GetLines()[0].GetStartPosX(), 50); +CPPUNIT_ASSERT_DOUBLES_EQUAL(static_cast(8815), pParaPortion->GetLines()[0].GetStartPosX(), 100); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115891] FORMATTING: Calc Conditional Formatting Not Functioning Properly
https://bugs.documentfoundation.org/show_bug.cgi?id=115891 --- Comment #3 from CW--- I thought that I had tried that, but I see that it does work. I agree that this shouldn't be required. I don't know if this is the right place to suggest this, but there should be either a note about this in the Help file, and/or a note in the dialog where you enter the reference cell. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115043] A superfluous separate click is needed for closing the right click menu, if the menu isn't used after all
https://bugs.documentfoundation.org/show_bug.cgi?id=115043 Aron Budeachanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Aron Budea --- (In reply to Heiko Tietze from comment #2) > Isn't it the same everywhere? Try in your browser. IMHO WF. Interestingly it's OS-dependent. In Windows 7 clicking somewhere after opening right-click menu counts as a normal click. In Ubuntu 17.10 two clicks are needed. Tested with Chrome and Firefox in both OSes. Not sure if other flavors behave differently, but it seems there's no standard for this. Let's close as WFM. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115566] Custom bullet (-) not shown during slideshow in Online
https://bugs.documentfoundation.org/show_bug.cgi?id=115566 Aron Budeachanged: What|Removed |Added Component|Impress |filters and storage Version|unspecified |6.0.1.1 release Blocks||111450 Product|LibreOffice Online |LibreOffice --- Comment #1 from Aron Budea --- Since the slideshow plays an exported SVG, the issue is with SVG export. Export the presentation to SVG, and open eg. in Inkscape (strangely Draw doesn't show any content, but Inkscape does). Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=111450 [Bug 111450] [META] SVG fileSave filter (Draw) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115566] Custom bullet (-) in presentation not exported into SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=115566 Aron Budeachanged: What|Removed |Added Summary|Custom bullet (-) not shown |Custom bullet (-) in |during slideshow in Online |presentation not exported ||into SVG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111450] [META] SVG fileSave filter (Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=111450 Aron Budeachanged: What|Removed |Added Depends on||115566 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115566 [Bug 115566] Custom bullet (-) not shown during slideshow in Online -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113740] EDITING Tablet input not recognised
https://bugs.documentfoundation.org/show_bug.cgi?id=113740 Aron Budeachanged: What|Removed |Added CC||rony.abe...@monogramm.io --- Comment #4 from Aron Budea --- *** Bug 115771 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115771] UI : mouse operations don' t work well on surface pro 4 using an external mouse, a touchpad or the touchscreen
https://bugs.documentfoundation.org/show_bug.cgi?id=115771 Aron Budeachanged: What|Removed |Added Status|NEW |RESOLVED CC||ba...@caesar.elte.hu Resolution|--- |DUPLICATE --- Comment #1 from Aron Budea --- I assume this is the same issue as bug 113740. *** This bug has been marked as a duplicate of bug 113740 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115891] FORMATTING: Calc Conditional Formatting Not Functioning Properly
https://bugs.documentfoundation.org/show_bug.cgi?id=115891 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||ba...@caesar.elte.hu Resolution|--- |NOTABUG --- Comment #2 from Aron Budea --- If you use absolute cell reference, eg. $B$5 instead of B5, then the conditional formatting will work as expected. While I have a tiny bit of doubt why it would be necessary when in this case conditional formatting references a value coming from a single source, the behavior seems to be consistent, so let's close this as NOTABUG. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115894] Default formatting on selected text reset the size of the textbox unexpectedly.
https://bugs.documentfoundation.org/show_bug.cgi?id=115894 --- Comment #1 from Mark Hung--- Additional information: Ctrl+Z can't restore the text box geometry in this case. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115894] New: Default formatting on selected text reset the size of the textbox unexpectedly.
https://bugs.documentfoundation.org/show_bug.cgi?id=115894 Bug ID: 115894 Summary: Default formatting on selected text reset the size of the textbox unexpectedly. Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mark...@gmail.com Steps to reproduce: 1. Create a new and empty presentation slide. 2. In title slide, click "Click to add Text" and enter some text. Change some text formatting as well. 3. Ctrl+a to select all text in the text box. 4. Select default formatting from the format menu. Actual result: The text format as well as text box size are reset. Expected result: The size of the text box should keep unchanged. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115893] LO Base Report Builder Does Not Import CLOB (memo field) Data
https://bugs.documentfoundation.org/show_bug.cgi?id=115893 jimj_...@yahoo.ca changed: What|Removed |Added Summary|LO Base Report Writer Does |LO Base Report Builder Does |Not Import CLOB (memo |Not Import CLOB (memo |field) Data |field) Data -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/text/XMLTextFrameContext.cxx |5 - xmloff/source/text/txtparae.cxx|4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) New commits: commit ea360461746f37be021b63da7a64a60d0f3c4af4 Author: Armin Le GrandDate: Tue Feb 20 15:55:49 2018 +0100 tdf#115782: Need to use mirrored rotation in ODF To be compatible with the orientation of rotations in ODF format in current state (which is wrong oriented) we have to do the same as in all other places (unfortunately). Change-Id: I2f02019b91a0f6020612c9c09be2d247e1b1deb1 Reviewed-on: https://gerrit.libreoffice.org/50047 Tested-by: Jenkins Reviewed-by: Armin Le Grand diff --git a/xmloff/source/text/XMLTextFrameContext.cxx b/xmloff/source/text/XMLTextFrameContext.cxx index 4f3a484b3bf6..d95aad61e78a 100644 --- a/xmloff/source/text/XMLTextFrameContext.cxx +++ b/xmloff/source/text/XMLTextFrameContext.cxx @@ -1025,7 +1025,10 @@ XMLTextFrameContext_Impl::XMLTextFrameContext_Impl( // value is already mirrored, so do not do it again here (to be in sync // with XMLTextParagraphExport::_exportTextGraphic normally it would need // to me mirrored using * -1.0, see conversion there) -const double fRotate(aDecomposedTransform.getRotate() * (1800.0/M_PI)); +// CAUTIONII: Due to tdf#115782 it is better for current ODF to indeed use it +// with the wrong orientation as in all other cases - ARGH! We will need to +// correct this in future ODF ASAP! For now, mirror the rotation here AGAIN +const double fRotate(aDecomposedTransform.getRotate() * (-1800.0/M_PI)); nRotation = static_cast< sal_Int16 >(basegfx::fround(fRotate) % 3600); // tdf#115529 may be negative, with the above modulo maximal -3599, so diff --git a/xmloff/source/text/txtparae.cxx b/xmloff/source/text/txtparae.cxx index 16a57ed09d23..2cc83399191a 100644 --- a/xmloff/source/text/txtparae.cxx +++ b/xmloff/source/text/txtparae.cxx @@ -3078,7 +3078,9 @@ void XMLTextParagraphExport::_exportTextGraphic( // we have a right-handed coordinate system, so need to correct this by mirroring // the rotation to get the correct transformation. See also case XML_TOK_TEXT_FRAME_TRANSFORM // in XMLTextFrameContext_Impl::XMLTextFrameContext_Impl and #i78696# -const double fRotate(static_cast< double >(-nRotation) * (F_PI/1800.0)); +// CAUTIONII: Due to tdf#115782 it is better for current ODF to indeed write it with the wrong +// orientation as in all other cases - ARGH! We will need to correct this in future ODF ASAP! +const double fRotate(static_cast< double >(nRotation) * (F_PI/1800.0)); // transform to rotation center which is the object's center aSdXMLImExTransform2D.AddTranslate(-aCenter); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115893] LO Base Report Writer Does Not Import CLOB (memo field) Data
https://bugs.documentfoundation.org/show_bug.cgi?id=115893 --- Comment #3 from jimj_...@yahoo.ca --- The only workaround for this problem is to use a spreadsheet and import the data there. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115893] LO Base Report Writer Does Not Import CLOB (memo field) Data
https://bugs.documentfoundation.org/show_bug.cgi?id=115893 --- Comment #2 from jimj_...@yahoo.ca --- Query looks like this: SELECT "Company", "Notes" FROM "Business Contacts" AS "Business Contacts" ORDER BY "Company" ASC -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115893] LO Base Report Writer Does Not Import CLOB (memo field) Data
https://bugs.documentfoundation.org/show_bug.cgi?id=115893 jimj_...@yahoo.ca changed: What|Removed |Added CC||jimj_...@yahoo.ca --- Comment #1 from jimj_...@yahoo.ca --- Created attachment 140026 --> https://bugs.documentfoundation.org/attachment.cgi?id=140026=edit Screenshot of LO Base Report Writer not displaying CLOB data -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115893] New: LO Base Report Writer Does Not Import CLOB (memo field) Data
https://bugs.documentfoundation.org/show_bug.cgi?id=115893 Bug ID: 115893 Summary: LO Base Report Writer Does Not Import CLOB (memo field) Data Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jimj_...@yahoo.ca Description: LibreOffice 6.0.1 and prior versions does not import data from CLOB fields, for example a "memo" or "comments" field. Instead LO Base Report Writer displays the following for each record: Any[Type[com.sun.star.sdbc.XClob], com.sun.star.bridges.jni_uno.JNI_proxy@7ee0f142 [oid=7f627403f070;gcc3:affine[0];fe0d3ee695f4212879a7aa3fb6ec575, type=com.sun.star.sdbc.XClob]] Steps to Reproduce: 1. Create a Query to list fields that you want printed. 2. Design Report as you like. Include a CLOB field. Close Report Builder. 3. 'Open' the Report you just created. Actual Results: The folowing is printed in place of the actual CLOB data in each record: Any[Type[com.sun.star.sdbc.XClob], com.sun.star.bridges.jni_uno.JNI_proxy@7ee0f142 [oid=7f627403f070;gcc3:affine[0];fe0d3ee695f4212879a7aa3fb6ec575, type=com.sun.star.sdbc.XClob]] Expected Results: LO Base Report Writer prints contents of CLOB field. Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.1.1 Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6 CPU threads: 2; OS: Linux 4.10; UI render: default; VCL: gtk2; Locale: en-CA (en_CA.UTF-8); Calc: group User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-1' - debian/changelog
debian/changelog |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit dfa952bceb2e11441fa0e53990a835ad36b00033 Author: Andras TimarDate: Wed Feb 21 01:26:59 2018 +0100 fix debian/changelog for 3.1 Change-Id: I54fbbed9dffe14af8d91e895bf0463a36a99a5af diff --git a/debian/changelog b/debian/changelog index 2fb85e5b..442d4351 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,6 +1,12 @@ loolwsd (3.1.0-2) unstable; urgency=medium - * see the git log: http://col.la/cool30 + * see the git log: http://col.la/cool31 + + -- Andras Timar Wed, 21 Feb 2018 01:26:00 +0100 + +loolwsd (3.1.0-1) unstable; urgency=medium + + * see the git log: http://col.la/cool31 -- Andras Timar Thu, 15 Feb 2018 22:00:00 +0100 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112055] No font set when pasting text into a textbox
https://bugs.documentfoundation.org/show_bug.cgi?id=112055 --- Comment #4 from Regina Henschel--- Currently the elements inside the text box are not able to use custom styles (those from styles.xml). That is a limitation of LibreOffice and not covered by file format. Currently the elements in the paragraphs inside the text box can use the same automatic styles as the elements in the original text. LibreOffice uses it already, but not in all cases. That can be improved, but the current solution is not really an error. The real problem is, that the paragraph styles are not handled correctly. The original text uses paragraph style "Standard", which is "Default style" in the UI. Because of the lacking feature of using custom styles from styles.xml, currently special automatic paragraph styles are generated in custom.xml. But that is wrongly done. It would be sufficient, if these special styles would get a style:parent-style-name="Standard" and nothing else. And in case the original text uses already an automatic paragraph style, the same automatic style can be used directly in the text-box. That is about file format. Changes in the internal model might be more difficult. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95116] LibreOffice-5 — Crashes when trying to SAVE documents in folders that contain many files
https://bugs.documentfoundation.org/show_bug.cgi?id=95116 --- Comment #25 from Roy--- Xisco, Yes, all is fine. I just don't save to folders with more than 10 files. I was simply responding to Alex Thurgood's message. Roy -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115890] Assert when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 Julien Nabetchanged: What|Removed |Added Blocks||105537 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105537 [Bug 105537] [META] Assertion failed crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Julien Nabetchanged: What|Removed |Added Depends on|115890 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115890 [Bug 115890] Assert when using tab to move between controls in the Navigator in the Sidebar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115890] Assert when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 Julien Nabetchanged: What|Removed |Added Keywords|accessibility | Blocks|105537 | --- Comment #9 from Julien Nabet --- I don't know why dynamic cast doesn't work since SwContent inherits from SwTypeNumber (see https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/swcont.hxx#70) but this works: assert(pEntry->GetUserData() == nullptr || static_cast (pEntry->GetUserData())); Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105537 [Bug 105537] [META] Assertion failed crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Julien Nabetchanged: What|Removed |Added Depends on||115890 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115890 [Bug 115890] Assert when using tab to move between controls in the Navigator in the Sidebar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115890] Assert when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 Aron Budeachanged: What|Removed |Added Keywords||accessibility Blocks||105537 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105537 [Bug 105537] [META] Assertion failed crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Aron Budeachanged: What|Removed |Added Depends on||115890 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115890 [Bug 115890] Assert when using tab to move between controls in the Navigator in the Sidebar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115890] Assert when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 Julien Nabetchanged: What|Removed |Added Keywords||haveBacktrace Status|UNCONFIRMED |NEW CC||mst...@redhat.com Ever confirmed|0 |1 --- Comment #8 from Julien Nabet --- Michael: the assert has been added with https://cgit.freedesktop.org/libreoffice/core/commit/?id=b673ddb7d7a7b09ad171af57acadb3e532030428, thought you might be interested in this one. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115890] Assert when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 Julien Nabetchanged: What|Removed |Added Summary|Crash when using tab to |Assert when using tab to |move between controls in|move between controls in |the Navigator in the|the Navigator in the |Sidebar |Sidebar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115890] Crash when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 --- Comment #7 from Julien Nabet--- Created attachment 140025 --> https://bugs.documentfoundation.org/attachment.cgi?id=140025=edit bt with debug symbols I could reproduce the assertion. It mustn't be confounded with a crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Changes to 'refs/tags/3.1-rc2'
Tag '3.1-rc2' created by Andras Timarat 2018-02-20 23:04 + 3.1-rc2 Changes since 3.1-rc1-8: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'refs/tags/3.1-rc2' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-1' - loolwsd.spec.in
loolwsd.spec.in |1 - 1 file changed, 1 deletion(-) New commits: commit c74959107aafd9de0af406028a239f4afda626de Author: Andras TimarDate: Wed Feb 21 00:01:23 2018 +0100 remove deleted robots.txt from rpm spec file Change-Id: Ic1d872f2e92dee64ef23d012b4cd50ad2931664a (cherry picked from commit 4adacbdaa63a814465bba7663f65181d8daa31ad) Signed-off-by: Andras Timar diff --git a/loolwsd.spec.in b/loolwsd.spec.in index ebc39282..a741431f 100644 --- a/loolwsd.spec.in +++ b/loolwsd.spec.in @@ -145,7 +145,6 @@ echo "accountrequired pam_unix.so" >> %{buildroot}/etc/pam.d/loolwsd /usr/bin/loolconfig /usr/share/loolwsd/discovery.xml /usr/share/loolwsd/favicon.ico -/usr/share/loolwsd/robots.txt /usr/share/loolwsd/loleaflet /usr/share/doc/loolwsd/README /usr/share/doc/loolwsd/README.vars ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115853] Custom properties deleted
https://bugs.documentfoundation.org/show_bug.cgi?id=115853 Julien Nabetchanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #2 from Julien Nabet --- I submitted for review this patch on gerrit: https://gerrit.libreoffice.org/#/c/50070/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #28 from Aron Budea--- (In reply to Julien Nabet from comment #27) > I agree with you but why you're talking about deleting an object here? > Indeed, > https://opengrok.libreoffice.org/ > search?project=core=mpProvider= shows no call > to delete on mpProvider. The deletion must've happened somewhere else, since this class is not the owner of mpProvider, the pointer is passed in via the constructor. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #27 from Julien Nabet--- (In reply to Aron Budea from comment #26) > ... > Deleting an object doesn't set its pointers scattered in the code to nullptr. I agree with you but why you're talking about deleting an object here? Indeed, https://opengrok.libreoffice.org/search?project=core=mpProvider= shows no call to delete on mpProvider. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: formula/source include/formula sc/source
formula/source/core/api/FormulaCompiler.cxx | 37 formula/source/core/api/token.cxx |1 include/formula/FormulaCompiler.hxx |1 include/formula/compiler.hxx| 10 +++ include/formula/opcode.hxx |4 +-- sc/source/core/data/funcdesc.cxx|2 - 6 files changed, 14 insertions(+), 41 deletions(-) New commits: commit a8d4d4b9edca48b8fb94dbb06d7dd1e689b07b98 Author: Eike RathkeDate: Tue Feb 20 17:42:03 2018 +0100 Resolves: tdf#115879 treat NOT as the 1-parameter function that it is ... instead of a low precedence unary operator with an odd behaviour. This wasn't documented nor specified but maybe needed for old(est) binary file format compatibility. Generate an error for anything else than a context of a function with one argument. There might be some corner cases of documents where some old usage leads to error now, of which some may have worked by accident, but some not as intended. Related, the internal not exposed (but available) NEG was classified similar as a unary operator but corectly handled as function at all places. Classified as an ordinary 1-parameter function as well. Change-Id: I3d84a6382243c8d64313e37346f81c857e71be95 Reviewed-on: https://gerrit.libreoffice.org/50055 Reviewed-by: Eike Rathke Tested-by: Eike Rathke diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx index 1866fa53201b..a83cc129a93c 100644 --- a/formula/source/core/api/FormulaCompiler.cxx +++ b/formula/source/core/api/FormulaCompiler.cxx @@ -525,16 +525,7 @@ uno::Sequence< sheet::FormulaOpCodeMapEntry > FormulaCompiler::OpCodeMap::create // regular unary operators for (sal_uInt16 nOp = SC_OPCODE_START_UN_OP; nOp < SC_OPCODE_STOP_UN_OP && nOp < mnSymbols; ++nOp) { -switch (nOp) -{ -// NOT and NEG in fact are functions but for legacy reasons -// are sorted into unary operators for compiler interna. -case SC_OPCODE_NOT : -case SC_OPCODE_NEG : -break; // nothing, -default: -lclPushOpCodeMapEntry( aVec, mpTable.get(), nOp ); -} +lclPushOpCodeMapEntry( aVec, mpTable.get(), nOp ); } } if ((nGroups & FormulaMapGroup::BINARY_OPERATORS) != 0) @@ -568,9 +559,7 @@ uno::Sequence< sheet::FormulaOpCodeMapEntry > FormulaCompiler::OpCodeMap::create SC_OPCODE_IF_NA, SC_OPCODE_CHOOSE, SC_OPCODE_AND, -SC_OPCODE_OR, -SC_OPCODE_NOT, -SC_OPCODE_NEG +SC_OPCODE_OR }; lclPushOpCodeMapEntries( aVec, mpTable.get(), aOpCodes, SAL_N_ELEMENTS(aOpCodes) ); // functions with 2 or more parameters. @@ -1473,9 +1462,7 @@ void FormulaCompiler::Factor() NextToken(); } } -// special cases NOT() and NEG() -else if( eOp == ocNot || eOp == ocNeg - || (SC_OPCODE_START_1_PAR <= eOp && eOp < SC_OPCODE_STOP_1_PAR) ) +else if (SC_OPCODE_START_1_PAR <= eOp && eOp < SC_OPCODE_STOP_1_PAR) { if (eOp == ocIsoWeeknum && FormulaGrammar::isODFF( meGrammar )) { @@ -1551,7 +1538,7 @@ void FormulaCompiler::Factor() } else { -// standard handling of ocNot, ocNeg and 1-parameter opcodes +// standard handling of 1-parameter opcodes pFacToken = mpToken; eOp = NextToken(); if( nNumFmt == SvNumFormatType::UNDEFINED && eOp == ocNot ) @@ -1918,18 +1905,6 @@ void FormulaCompiler::CompareLine() } } -void FormulaCompiler::NotLine() -{ -CompareLine(); -while (mpToken->GetOpCode() == ocNot) -{ -FormulaTokenRef p = mpToken; -NextToken(); -CompareLine(); -PutCode(p); -} -} - OpCode FormulaCompiler::Expression() { static const short nRecursionMax = 42; @@ -1939,13 +1914,13 @@ OpCode FormulaCompiler::Expression() SetError( FormulaError::StackOverflow ); return ocStop; //! generate token instead? } -NotLine(); +CompareLine(); while (mpToken->GetOpCode() == ocAnd || mpToken->GetOpCode() == ocOr) { FormulaTokenRef p = mpToken; mpToken->SetByte( 2 ); // 2 parameters! NextToken(); -NotLine(); +CompareLine(); PutCode(p); } return mpToken->GetOpCode(); diff --git a/formula/source/core/api/token.cxx b/formula/source/core/api/token.cxx index 13d6914392db..1d33b4d93571
[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #26 from Aron Budea--- (In reply to Julien Nabet from comment #24) > (In reply to Aron Budea from comment #23) > >... > > bool IsOffscreen() const { return mpProvider == nullptr || > > mpProvider->IsOffScreen(); } > > > > mpProvider is an invalid pointer, so this seems to be a use-after-free > > issue. > >... > Either mpProvider is equal to nullptr and it returns true without testing > second condition (and so without trying dereferencing nullptr) > or mpProvider != null and we enter the second condition without pb of > nullptr dereferencing. Deleting an object doesn't set its pointers scattered in the code to nullptr. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Aron Budeachanged: What|Removed |Added Crash report or|["google_breakpad::Exceptio |["google_breakpad::Exceptio crash signature|nHandler::HandlePureVirtual |nHandler::HandlePureVirtual |Call()"]|Call()","OpenGLSalGraphicsI ||mpl::doFlush()"] --- Comment #25 from Aron Budea --- My crash report signature is different from what's indicated in the crash report field: http://crashreport.libreoffice.org/stats/crash_details/a4ce0839-1ec7-4ad7-a7d4-68e9a91ef1cf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #24 from Julien Nabet--- (In reply to Aron Budea from comment #23) >... > bool IsOffscreen() const { return mpProvider == nullptr || > mpProvider->IsOffScreen(); } > > mpProvider is an invalid pointer, so this seems to be a use-after-free issue. >... Either mpProvider is equal to nullptr and it returns true without testing second condition (and so without trying dereferencing nullptr) or mpProvider != null and we enter the second condition without pb of nullptr dereferencing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92907] Exiting LibreOffice takes a long time with much spreadsheet data in the clipboard
https://bugs.documentfoundation.org/show_bug.cgi?id=92907 Heiko Tietzechanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTOURBUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108843] [META] Clipboard bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108843 Bug 108843 depends on bug 92907, which changed state. Bug 92907 Summary: Exiting LibreOffice takes a long time with much spreadsheet data in the clipboard https://bugs.documentfoundation.org/show_bug.cgi?id=92907 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTOURBUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Aron Budeachanged: What|Removed |Added Keywords||bisected CC||glo...@fbihome.de, ||michael.me...@collabora.com --- Comment #23 from Aron Budea --- Bibisected to the commit referenced below using repo bibisect-win32-6.0 (and a dictionary added to instdir/share/extensions, so Check for Updates is active in Extension Manager). For me it also only happens with OpenGL enabled. The commit seems to be earlier than some of the good ones identified by V Stuart, but I'm already getting a crash by checking out the commit corresponding to a9588baca8137f51e2ca72e40b1f448b0e1885d1's state in the bibisect repo. Adding Cc: to Jan-Marek Glogowski, please take a look. The crash itself occurs in: https://opengrok.libreoffice.org/xref/core/vcl/inc/openglgdiimpl.hxx#161 bool IsOffscreen() const { return mpProvider == nullptr || mpProvider->IsOffScreen(); } mpProvider is an invalid pointer, so this seems to be a use-after-free issue. https://cgit.freedesktop.org/libreoffice/core/commit/?id=52dfefec8da5d7f25c39218fd890cad6491728ab author Jan-Marek Glogowski 2017-01-27 23:40:11 +0100 committer Jan-Marek Glogowski 2017-07-13 12:10:27 +0200 Run LO scheduler only via system timer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49955] EDITING: Impossible to edit several Master slides at once
https://bugs.documentfoundation.org/show_bug.cgi?id=49955 Heiko Tietzechanged: What|Removed |Added Status|NEW |NEEDINFO CC||tietze.he...@gmail.com --- Comment #5 from Heiko Tietze --- Why do you expect this to work? It's the same behavior as in the normal view. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92907] Exiting LibreOffice takes a long time with much spreadsheet data in the clipboard
https://bugs.documentfoundation.org/show_bug.cgi?id=92907 --- Comment #7 from Telesto--- (In reply to Heiko Tietze from comment #6) > My take here is WF/NOB following comment 4. Or a solution as requested here: bug 112537 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71989] EDITING: CUT can't be restored with Undo in select-all text
https://bugs.documentfoundation.org/show_bug.cgi?id=71989 --- Comment #8 from Heiko Tietze--- (In reply to Heiko Tietze from comment #7) > ...NAB Ignore my comment. Undo is the question here. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71989] EDITING: CUT can't be restored with Undo in select-all text
https://bugs.documentfoundation.org/show_bug.cgi?id=71989 Heiko Tietzechanged: What|Removed |Added CC||tietze.he...@gmail.com --- Comment #7 from Heiko Tietze --- Isn't that the standard behavior of textboxes? I mean an empty textboxes is always removed, also in Writer. => NAB -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92907] Exiting LibreOffice takes a long time with much spreadsheet data in the clipboard
https://bugs.documentfoundation.org/show_bug.cgi?id=92907 Heiko Tietzechanged: What|Removed |Added CC||tietze.he...@gmail.com --- Comment #6 from Heiko Tietze --- My take here is WF/NOB following comment 4. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115892] Opening a Style dialog' s Font tab adds Asian text size to the properties set in the style
https://bugs.documentfoundation.org/show_bug.cgi?id=115892 Mike Kaganskichanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #1 from Mike Kaganski --- https://gerrit.libreoffice.org/50066 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112055] No font set when pasting text into a textbox
https://bugs.documentfoundation.org/show_bug.cgi?id=112055 Heiko Tietzechanged: What|Removed |Added CC||rb.hensc...@t-online.de, ||tietze.he...@gmail.com --- Comment #3 from Heiko Tietze --- When you copy a text with paragraph/character style it would be necessary to accept the properties at the textbox. Though, the textbox is likely not capable of styles - intentionally in my opinion. Of course, the properties could get burned in as direct formatting. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115420 V Stuart Footechanged: What|Removed |Added Keywords||bibisected -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #22 from V Stuart Foote--- (In reply to Xisco Faulí from comment #19) > @Telesto, @V Stuart, any change it can be bisected? Crash on "Close" button click with OpenGL enabled, bibisect from builds on hand: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=a9588baca8137f51e2ca72e40b1f448b0e1885d1..1e87e93132f808ab95eab932b36bfe40d3cc607a Bad 2017-11-03 8c374022790b54834fa54615e1953c8ee30641a8 2017-08-23 1ba1bb96659d0048bff2a9a15646f6e1e04bd2c4 2017-08-02 9ca7bda2cc8b67c2d10fcb81cce8bfd4d8b79b09 2017-07-25 1e87e93132f808ab95eab932b36bfe40d3cc607a Good 2017-07-21 a9588baca8137f51e2ca72e40b1f448b0e1885d1 2017-07-19 c0d7f348f20ea1ae0d4b738136be4d5cbff550ae 2017-06-16 5ac1d27d0bca285047f291e0a475f8bb99134cea -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115892] New: Opening a Style dialog' s Font tab adds Asian text size to the properties set in the style
https://bugs.documentfoundation.org/show_bug.cgi?id=115892 Bug ID: 115892 Summary: Opening a Style dialog's Font tab adds Asian text size to the properties set in the style Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com Opening a Style (Character or Paragraph) dialog's Font tab adds Asian text size (11) to the properties set in the style (visible on the Organizer tab). The Asian text font size is 10,5 pt by default. When the Fonts tab is opened, the fractional font size is wrongly detected as modified wrt initial; so the property is added to the style. It's impossible to remove this setting from the style afterwards. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115043] A superfluous separate click is needed for closing the right click menu, if the menu isn't used after all
https://bugs.documentfoundation.org/show_bug.cgi?id=115043 Heiko Tietzechanged: What|Removed |Added CC||tietze.he...@gmail.com --- Comment #2 from Heiko Tietze --- Isn't it the same everywhere? Try in your browser. IMHO WF. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/cib_contract136' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 24d5373124198a45046407738052086cb951a612 Author: Thorsten BehrensDate: Tue Feb 20 22:24:39 2018 +0100 Bump version to 5.2.7.5 Change-Id: I5e32ad3f2837dfab3455770517a2b16d12bd0cb6 diff --git a/configure.ac b/configure.ac index 90c2301cac23..95d0bd52c77f 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[5.2.7.4],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[5.2.7.5],[],[],[http://documentfoundation.org/]) AC_PREREQ([2.59]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bin/gla11y config_host.mk.in configure.ac solenv/gbuild
bin/gla11y | 216 +++ config_host.mk.in|1 configure.ac | 10 + solenv/gbuild/TargetLocations.mk |2 solenv/gbuild/UIConfig.mk| 26 5 files changed, 254 insertions(+), 1 deletion(-) New commits: commit 226697ae27ef451cad404256e83eef88262f16d1 Author: Samuel ThibaultDate: Fri Feb 16 13:22:10 2018 +0100 Integrate initial version of gla11y tool in the build system This is part of integrating an accessibility non-regression tool. This adds checks in configure.ac for the presence of python lxml which we will need, and adds support for calling the tool at build time, to check for definite UI errors. For now, that only emits errors for missing or duplicate accessibility relation targets, and senseless relations: a label being mnemonic for several widgets. Change-Id: Idda91b15b9a9e0322d16db33dfac8e03f2aa518c Reviewed-on: https://gerrit.libreoffice.org/49856 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/bin/gla11y b/bin/gla11y new file mode 100755 index ..d0619133ad0f --- /dev/null +++ b/bin/gla11y @@ -0,0 +1,216 @@ +#!/usr/bin/env python +# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +# This file incorporates work covered by the following license notice: +# +# Copyright (c) 2018 Martin Pieuchot +# Copyright (c) 2018 Samuel Thibault +# +# Permission to use, copy, modify, and distribute this software for any +# purpose with or without fee is hereby granted, provided that the above +# copyright notice and this permission notice appear in all copies. +# +# THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +# WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +# MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +# WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF +# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. +# +# vim: set shiftwidth=4 softtabstop=4 expandtab: + +# Take LibreOffice (glade) .ui files and check for non accessible widgets + +from __future__ import print_function + +import os +import sys +import getopt +import lxml.etree as ET + +progname = os.path.basename(sys.argv[0]) +Werror = False +Wnone = False +errors = 0 +warnings = 0 + + +def errstr(elm): +""" +Print the line number of the element +""" + +return str(elm.sourceline) + +def err(filename, elm, msg): +global errors + +if elm == None: +prefix = "%s:" % filename +else: +prefix = "%s:%s" % (filename, errstr(elm)) + +errors += 1 +msg = "%s ERROR: %s" % (prefix, msg) +print(msg.encode('ascii', 'ignore')) + + +def warn(filename, elm, msg): +global Werror, Wnone, errors, warnings + +if Wnone: +return + +prefix = "%s:%s" % (filename, errstr(elm)) + +if Werror: +errors += 1 +else: +warnings += 1 + +msg = "%s WARNING: %s" % (prefix, msg) +print(msg.encode('ascii', 'ignore')) + + +def check_objects(filename, elm, objects, target): +""" +Check that objects contains exactly one object +""" +length = len(list(objects)) +if length == 0: +err(filename, elm, "use of undeclared target '%s'" % target) +elif length > 1: +err(filename, elm, "sevral targets are named '%s'" % target) + +def check_props(filename, root, props): +""" +Check the given list of relation properties +""" +for prop in props: +objects = root.iterfind(".//object[@id='%s']" % prop.text) +check_objects(filename, prop, objects, prop.text) + +def check_rels(filename, root, rels): +""" +Check the given list of relations +""" +for rel in rels: +target = rel.attrib['target'] +targets = root.iterfind(".//object[@id='%s']" % target) +check_objects(filename, rel, targets, target) + +def check_a11y_relation(filename, root): +""" +Emit an error message if any of the 'object' elements of the XML +document represented by `root' doesn't comply with Accessibility +rules. +""" + +for obj in root.iter('object'): + +label_for = obj.findall("accessibility/relation[@type='label-for']") +check_rels(filename, root, label_for) + +labelled_by = obj.findall("accessibility/relation[@type='labelled-by']") +
[Libreoffice-bugs] [Bug 115883] SAXException: [word/document.xml line 2]: unknown error on opening DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=115883 --- Comment #7 from Julien Nabet--- #0 0x7fffca0fc3fb in (anonymous namespace)::Entity::saveException(com::sun::star::uno::Any const&) (this=0x57b6d180, e= uno::Any("com.sun.star.uno.RuntimeException": { = {Message = "", Context = empty uno::Reference}, })) at /home/julien/lo/libreoffice/sax/source/fastparser/fastparser.cxx:619 #1 0x7fffca0fb872 in (anonymous namespace)::Entity::endElement() (this=0x57b6d180) at /home/julien/lo/libreoffice/sax/source/fastparser/fastparser.cxx:493 #2 0x7fffca0ffe99 in sax_fastparser::FastSaxParserImpl::callbackEndElement() (this=0x57b6d030) at /home/julien/lo/libreoffice/sax/source/fastparser/fastparser.cxx:1263 #3 0x7fffca0fa608 in (anonymous namespace)::call_callbackEndElement(void*, xmlChar const*, xmlChar const*, xmlChar const*) (userData=0x57b6d030) at /home/julien/lo/libreoffice/sax/source/fastparser/fastparser.cxx:314 #4 0x7fffe6afbd05 in () at /usr/lib/x86_64-linux-gnu/libxml2.so.2 #5 0x7fffe6b048b9 in () at /usr/lib/x86_64-linux-gnu/libxml2.so.2 #6 0x7fffe6b0620e in xmlParseChunk () at /usr/lib/x86_64-linux-gnu/libxml2.so.2 #7 0x7fffca0fe2f9 in sax_fastparser::FastSaxParserImpl::parse() (this=0x57b6d030) at /home/julien/lo/libreoffice/sax/source/fastparser/fastparser.cxx:1052 (gdb) frame 7 #7 0x7fffca0fe2f9 in sax_fastparser::FastSaxParserImpl::parse (this=0x57b6d030) at /home/julien/lo/libreoffice/sax/source/fastparser/fastparser.cxx:1052 1052bContinue = xmlParseChunk( rEntity.mpParser, reinterpret_cast(seqOut.getConstArray()), nRead, 0 ) (gdb) p seqOut.getConstArray() $2 = (const signed char *) 0x57e6f078 "-RU\"/>Корпоративные лицензии___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 115291] Text highlight color changes when .odt document saved as a .doc document.
https://bugs.documentfoundation.org/show_bug.cgi?id=115291 Thomas Lendochanged: What|Removed |Added CC||thomas.le...@gmail.com --- Comment #6 from Thomas Lendo --- (In reply to Yousuf Philips (jay) (retired) from comment #5) > (In reply to Heiko Tietze from comment #4) > > Alternatively, we could ask the user when exporting a document may result in > > corrupt properties. > We already give users the 'Confirm File Format' dialog when not saving to > ODF, which does state 'This document may contain formatting or content that > cannot be saved in the currently selected file format'. We could go beyond > this, if devs are interested in implementing it, and create a dialog similar > to the MS compatibility checker. > > http://technastic.com/wp-content/uploads/2016/02/Microsoft-Word- > Compatibility-checker.jpg This would be really genius to have a list of things that change instead of a vague statement that something could happen--or not. In such a dialog also the possibilities in the options dialog can be referenced because nobody finds the option to change highlighting saving today. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 115291] Text highlight color changes when .odt document saved as a .doc document.
https://bugs.documentfoundation.org/show_bug.cgi?id=115291 Thomas Lendochanged: What|Removed |Added CC||thomas.le...@gmail.com --- Comment #6 from Thomas Lendo --- (In reply to Yousuf Philips (jay) (retired) from comment #5) > (In reply to Heiko Tietze from comment #4) > > Alternatively, we could ask the user when exporting a document may result in > > corrupt properties. > We already give users the 'Confirm File Format' dialog when not saving to > ODF, which does state 'This document may contain formatting or content that > cannot be saved in the currently selected file format'. We could go beyond > this, if devs are interested in implementing it, and create a dialog similar > to the MS compatibility checker. > > http://technastic.com/wp-content/uploads/2016/02/Microsoft-Word- > Compatibility-checker.jpg This would be really genius to have a list of things that change instead of a vague statement that something could happen--or not. In such a dialog also the possibilities in the options dialog can be referenced because nobody finds the option to change highlighting saving today. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115890] Crash when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 --- Comment #6 from Julien Nabet--- You're right, I hadn't tested it with Orca. I'll give it a try later. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115890] Crash when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 --- Comment #5 from am_dxer--- Do you have Orca enabled when testing on Debian? From looking at the trace, this looks to only occur when a11y is enabled. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115050] "Zero Width Non Joiner" does not specify a word end if input via the keyboard
https://bugs.documentfoundation.org/show_bug.cgi?id=115050 --- Comment #12 from Patrick Schönbach--- Why does it worrk in other word processors with OpenType support, then? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115891] FORMATTING: Calc Conditional Formatting Not Functioning Properly
https://bugs.documentfoundation.org/show_bug.cgi?id=115891 CWchanged: What|Removed |Added CC||wach...@gmail.com --- Comment #1 from CW --- Created attachment 140024 --> https://bugs.documentfoundation.org/attachment.cgi?id=140024=edit Calc Spreadsheet Showing Malfunctioning Conditional Formatting -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115883] SAXException: [word/document.xml line 2]: unknown error on opening DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=115883 --- Comment #6 from Julien Nabet--- For the record, I use enable-dbgutil. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115883] SAXException: [word/document.xml line 2]: unknown error on opening DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=115883 --- Comment #5 from Julien Nabet--- "SAXException: [word/document.xml line 2]: unknown error Proceeding with import may cause data loss or corruption, and application may become unstable or crash." -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115891] New: FORMATTING: Calc Conditional Formatting Not Functioning Properly
https://bugs.documentfoundation.org/show_bug.cgi?id=115891 Bug ID: 115891 Summary: FORMATTING: Calc Conditional Formatting Not Functioning Properly Product: LibreOffice Version: 6.0.1.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: wach...@gmail.com Description: Conditional formatting applied to a range of cells only works properly on a handful of those cells and misrepresents the status of others. Steps to Reproduce: 1.Create spreadsheet with an array of random values. Values should be 'Scientific' in nature. IE: 4.7e-6 2.Place a threshold value in a separate cell. IE: 3.1415e-3 3.Setup Conditional Formatting : Cell Value Is, greater than, (threshold cell location), enter some obvious style. 4.Click OK Actual Results: In the example spreadsheet: Cells B14,B15 and B16 are handled correctly. Cell B17 is incorrectly showing that the value is over the threshold. Similarly, cells C15 and C17 are incorrectly indicated, but C16 is correct. Etc. Expected Results: Expected to have values that were "greater than" cell B5 value to be highlighted, cells below or equal to the value should be displayed normally. Reproducible: Always User Profile Reset: Yes Additional Info: See Expected Results User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:58.0) Gecko/20100101 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115883] SAXException: [word/document.xml line 2]: unknown error on opening DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=115883 Julien Nabetchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115883] SAXException: [word/document.xml line 2]: unknown error on opening DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=115883 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #4 from Julien Nabet --- Created attachment 140023 --> https://bugs.documentfoundation.org/attachment.cgi?id=140023=edit console logs On pc Debian x86-64 with master sources updated today, I could reproduce this. I attached console logs. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115890] Crash when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 --- Comment #3 from am_dxer--- Introduced somewhere between 7d56128654457bfc859217c23a957d1712fd6e1c and 48cf115778b29ab916dd884d0bfc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115890] Crash when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #4 from Julien Nabet --- On pc Debian x86-64 with master sources updated today + gtk2 rendering, I don't reproduce this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115739] LibreOffice Writer crashes when trying to save an untitled document
https://bugs.documentfoundation.org/show_bug.cgi?id=115739 --- Comment #6 from am_dxer--- Please ignore comment 5. I posted it on the wrong bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #21 from Michael Meeks--- Oh - I was rather convinced by comment#18 =) Its great to see the trace there ! should make things much easier ... nice work. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115828] SQL: SHUTDOWN COMPACT fails in internal HSQLDB
https://bugs.documentfoundation.org/show_bug.cgi?id=115828 --- Comment #4 from Julien Nabet--- I reverted the patch locally and gave a new try, I could still reproduce this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115739] LibreOffice Writer crashes when trying to save an untitled document
https://bugs.documentfoundation.org/show_bug.cgi?id=115739 --- Comment #5 from am_dxer--- Introduced somewhere between 7d56128654457bfc859217c23a957d1712fd6e1c and 48cf115778b29ab916dd884d0bfcfeffd03e7603 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #20 from V Stuart Foote--- @Michael M.--See the debug trace from Comment 16, the crash here really only occurs with OpenGL rendering enabled. Why drop it from the META? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115184] Error message with the back-up option turned on
https://bugs.documentfoundation.org/show_bug.cgi?id=115184 tomraymond...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115184] Error message with the back-up option turned on
https://bugs.documentfoundation.org/show_bug.cgi?id=115184 --- Comment #2 from tomraymond...@gmail.com --- So Tools - Options - Load/Save - General: Always create a backup copy? YES Formatted DVD as Like a USB Flash Drive, Live File System -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104252] Embedded EMF/ WMF and SVM images shows text content on screen but not in print or PDF export on Windows (with HW acceleration and GDI, but not with OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=104252 --- Comment #43 from V Stuart Foote--- (In reply to Jérôme from comment #42) > Is there a way to backport the fix to the 5 version ? Realistically no, this was substantial refactoring of EMF handling. Not appropriate to attempt backport to 5.4 this late in its dev cycle. Please move to 6.0.1 if your graphics are affected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs