[Libreoffice-bugs] [Bug 101125] libreoffice writer hangs for me when i attempt to open this .docx file.
https://bugs.documentfoundation.org/show_bug.cgi?id=101125 --- Comment #17 from Khaled Hosny--- (In reply to Julien Nabet from comment #16) > (In reply to Khaled Hosny from comment #15) > > No idea, but after the document loads scrolling through it seems to be OK, > > so looks like some issue with loading the document. > Thank you for your feedback. > Just for curiosity, how much time you had to wait to open the doc? It toke about 4 minutes here (a 5 years old MackBook Pro running Linux). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115747] Can't edit file on samba shares
https://bugs.documentfoundation.org/show_bug.cgi?id=115747 --- Comment #10 from Katarina Behrens (CIB)--- A wild guess: could it be that in case when this annoying dialog appears, samba share is mounted read-only or for another reason, the user doesn't have permission to create files in the given folder (and since document lock files get dropped in the same folder as the document itself ... there we go) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116140] Writer is getting very slow if i have a document with many page filling images
https://bugs.documentfoundation.org/show_bug.cgi?id=116140 --- Comment #1 from Telesto--- It's still possible to change the memory settings. Their corresponding settings are /org.openoffice.Office.Common/Cache/GraphibManager/TotalCacheSize /org.openoffice.Office.Common/Cache/GraphibManager/ObjectCacheSize /org.openoffice.Office.Common/Cache/GraphibManager/ObjectReleaseTime /org.openoffice.Office.Common/Cache/DrawingEngine/OLE_Objects and this setting seems to depend on latter: /org.openoffice.Office.Common/Cache/Writer/OLE_Objects See bug 110448 The following project my help to (for the future): Improving the image handling in LibreOffice - Part 1 (https://tomazvajngerl.blogspot.nl) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115696] fileopen xlsx a1 cell is black on lo viewer master daily build
https://bugs.documentfoundation.org/show_bug.cgi?id=115696 raalchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115696] fileopen xlsx a1 cell is black on lo viewer master daily build
https://bugs.documentfoundation.org/show_bug.cgi?id=115696 raalchanged: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- Created attachment 140303 --> https://bugs.documentfoundation.org/attachment.cgi?id=140303=edit screenshot android 5.0.2 I can confirm with Version: 6.1.0.0.alpha0+ Build ID: dc8d8cb -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115735] unable to add slide
https://bugs.documentfoundation.org/show_bug.cgi?id=115735 --- Comment #7 from raal--- Created attachment 140302 --> https://bugs.documentfoundation.org/attachment.cgi?id=140302=edit screenshot Hi Krishna,you have to be in edit mode. See printscreen. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=105500 --- Comment #19 from Pierre-Alain Dorange--- With last 5.x revision it was even worst. Draw module was not usable, all the interface was so slow and so unresponsiness... Even with the sidebar hidden rgere was noticable lags. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116153] New: Can't launch
https://bugs.documentfoundation.org/show_bug.cgi?id=116153 Bug ID: 116153 Summary: Can't launch Product: LibreOffice Version: 6.0.2.1 release Hardware: x86 (IA32) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pdora...@mac.com With MACOS X (and its fucking protection) i cannot launch LibreOffice 6. At the first launch MacOS do it "checking" (to make sure the software was not damaged or contain a virus or something like this). This process was longer and longer. Now with LO6 it consumes 40 GB of memory (i do not have this amount of course) and slow down the computer until it freeze ! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85588] COLOR PICKER: More space between 'Custom Color' icon and label
https://bugs.documentfoundation.org/show_bug.cgi?id=85588 --- Comment #10 from tommy27--- retested in 6.1.0.0.alpha0+ Build ID: e0a94ded5d1635fa2a2d9e222bfcfa0a2289a01f CPU threads: 4; OS: Windows 6.3; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-02-08_23:36:06 Locale: it-IT (it_IT); Calc: group in my previous screenshot from 5.0 alpha there were 3 pixels between the right margin of the icon and the left margin of the "C" of "custom color" label. now I count 4 pixels. may we mark this as resolved WFM? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/tools reportdesign/source sw/source
include/tools/gen.hxx | 15 --- reportdesign/source/ui/report/ViewsWindow.cxx | 16 sw/source/ui/table/autoformatpreview.cxx |4 ++-- 3 files changed, 14 insertions(+), 21 deletions(-) New commits: commit ee69f5e0758a2a1842362bf403dc62746437f358 Author: Noel GrandinDate: Fri Mar 2 12:02:39 2018 +0200 drop old tools/gen methods Change-Id: I9b9d1503b476f84e91fa283e523875b562c6b837 Reviewed-on: https://gerrit.libreoffice.org/50166 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/include/tools/gen.hxx b/include/tools/gen.hxx index 38f80404e1f6..56ef15c2c742 100644 --- a/include/tools/gen.hxx +++ b/include/tools/gen.hxx @@ -102,8 +102,8 @@ public: longgetX() const { return X(); } longgetY() const { return Y(); } -voidsetX(long nX) { X() = nX; } -voidsetY(long nY) { Y() = nY; } +voidsetX(long nX) { nA = nX; } +voidsetY(long nY) { nB = nY; } Pair const &toPair() const { return *this; } Pair & toPair() { return *this; } @@ -193,15 +193,13 @@ public: longWidth() const { return nA; } longHeight() const { return nB; } -long& Width() { return nA; } -long& Height() { return nB; } longAdjustWidth( long n ) { nA += n; return nA; } longAdjustHeight( long n ) { nB += n; return nB; } longgetWidth() const { return Width(); } longgetHeight() const { return Height(); } -voidsetWidth(long nWidth) { Width() = nWidth; } -voidsetHeight(long nHeight) { Height() = nHeight; } +voidsetWidth(long nWidth) { nA = nWidth; } +voidsetHeight(long nHeight) { nB = nHeight; } Pair const &toPair() const { return *this; } Pair & toPair() { return *this; } @@ -390,11 +388,6 @@ public: longTop() const { return nTop;} longBottom() const { return nBottom; } -long& Left() { return nLeft; } -long& Right() { return nRight; } -long& Top() { return nTop;} -long& Bottom(){ return nBottom; } - voidSetLeft(long v){ nLeft = v; } voidSetRight(long v) { nRight = v; } voidSetTop(long v) { nTop = v;} diff --git a/reportdesign/source/ui/report/ViewsWindow.cxx b/reportdesign/source/ui/report/ViewsWindow.cxx index 5e48c8c209f3..341dc465a397 100644 --- a/reportdesign/source/ui/report/ViewsWindow.cxx +++ b/reportdesign/source/ui/report/ViewsWindow.cxx @@ -770,9 +770,9 @@ void OViewsWindow::alignMarkedObjects(ControlModification _nControlModification, bool bMove = true; -auto aGetFun = ::std::mem_fn(static_cast (::Rectangle::Bottom)); +auto aGetFun = ::std::mem_fn(::Rectangle::Bottom); auto aSetFun = ::std::mem_fn(::Rectangle::SetBottom); -auto aRefFun = ::std::mem_fn(static_cast (::Rectangle::Top)); +auto aRefFun = ::std::mem_fn(::Rectangle::Top); TRectangleMap::const_iterator aRectIter = aSortRectangles.begin(); TRectangleMap::const_iterator aRectEnd = aSortRectangles.end(); for (;aRectIter != aRectEnd ; ++aRectIter) @@ -791,9 +791,9 @@ void OViewsWindow::alignMarkedObjects(ControlModification _nControlModification, switch(_nControlModification) { case ControlModification::TOP : -aGetFun = ::std::mem_fn(static_cast (::Rectangle::Top)); +aGetFun = ::std::mem_fn(::Rectangle::Top); aSetFun = ::std::mem_fn(::Rectangle::SetTop); -aRefFun = ::std::mem_fn(static_cast (::Rectangle::Bottom)); +aRefFun = ::std::mem_fn(::Rectangle::Bottom); pValue = break; case ControlModification::BOTTOM: @@ -806,18 +806,18 @@ void OViewsWindow::alignMarkedObjects(ControlModification _nControlModification, bMove = false; break; case ControlModification::RIGHT : -aGetFun = ::std::mem_fn(static_cast (::Rectangle::Right)); +aGetFun = ::std::mem_fn(::Rectangle::Right); aSetFun = ::std::mem_fn(::Rectangle::SetRight); -aRefFun = ::std::mem_fn(static_cast
[Libreoffice-bugs] [Bug 113063] In a textbox and RTL directionality - weak characters misplaced when sentence begins with LTR text
https://bugs.documentfoundation.org/show_bug.cgi?id=113063 --- Comment #5 from Mark Hung--- Please check with latest master build. Possibly fixed with the following commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e85aa0cc8b306c2f5ca6240b99e1704f772dbebb tdf#60533 invoke ubidi_setPara with correct paraLevel parameter. It will be available in 6.1.0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96806] In RTL cells, weak characters directionality is decided by first letter, not cell directionality
https://bugs.documentfoundation.org/show_bug.cgi?id=96806 --- Comment #9 from Mark Hung--- Please check with latest master build. Possibly fixed with the following commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e85aa0cc8b306c2f5ca6240b99e1704f772dbebb tdf#60533 invoke ubidi_setPara with correct paraLevel parameter. It will be available in 6.1.0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60533] Brackets (..), {..}, [..] inverted )..(, }..{, ]..[ when switch to RTL text direction with all fonts (Affect : calc, impress, draw).
https://bugs.documentfoundation.org/show_bug.cgi?id=60533 Mark Hungchanged: What|Removed |Added CC||ofirr@gmail.com --- Comment #30 from Mark Hung --- *** Bug 92641 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103495] Space between Arabic/ Hebrew word missing in textboxes when sentence begins with English word
https://bugs.documentfoundation.org/show_bug.cgi?id=103495 --- Comment #6 from Mark Hung--- Please check with latest master build. Possibly fixed with the following commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e85aa0cc8b306c2f5ca6240b99e1704f772dbebb tdf#60533 invoke ubidi_setPara with correct paraLevel parameter. It will be available in 6.1.0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92641] Parentheses order wrong when a line with text direction Right-to-left starts with LTR characters
https://bugs.documentfoundation.org/show_bug.cgi?id=92641 Mark Hungchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #13 from Mark Hung --- *** This bug has been marked as a duplicate of bug 60533 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Bug 43808 depends on bug 92641, which changed state. Bug 92641 Summary: Parentheses order wrong when a line with text direction Right-to-left starts with LTR characters https://bugs.documentfoundation.org/show_bug.cgi?id=92641 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79585] RTL: RTL Layout Problem in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=79585 --- Comment #16 from Mark Hung--- Please check with latest master build. Possibly fixed with the following commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e85aa0cc8b306c2f5ca6240b99e1704f772dbebb tdf#60533 invoke ubidi_setPara with correct paraLevel parameter. It will be available in 6.1.0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115735] unable to add slide
https://bugs.documentfoundation.org/show_bug.cgi?id=115735 --- Comment #6 from krishna [:kr1shna]--- Created attachment 140301 --> https://bugs.documentfoundation.org/attachment.cgi?id=140301=edit printscreen -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115735] unable to add slide
https://bugs.documentfoundation.org/show_bug.cgi?id=115735 --- Comment #5 from krishna [:kr1shna]--- by acccident i have checked again on new daily build, there is no option on both experimental and non-experimental mode see attachment Version: 6.1.0.0.alpha0+ tinderbox: buildname: Android-ARM@24-Bytemark-Hosting tinderbox: tree: MASTER tinderbox: pull time 2018-03-02 18:11:47 tinderbox: git sha1s core:e802e960f8f7343eec1a14eba70b7affc6298968 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116152] fileopen pptx unsupported url type detection failed
https://bugs.documentfoundation.org/show_bug.cgi?id=116152 --- Comment #1 from krishna [:kr1shna]--- Created attachment 140300 --> https://bugs.documentfoundation.org/attachment.cgi?id=140300=edit printscreen -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116152] New: fileopen pptx unsupported url type detection failed
https://bugs.documentfoundation.org/show_bug.cgi?id=116152 Bug ID: 116152 Summary: fileopen pptx unsupported url type detection failed Product: LibreOffice Version: 6.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Android Viewer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kris...@grrlz.net open attachment 87168 from bug #67297 expected display content current errors: unsupported url, type detection failed see attachment errors on both [ 1 ] lo viewer v14 Build ID: 484d0ea842da [ 2 ] Version: 6.1.0.0.alpha0+ tinderbox: buildname: Android-ARM@24-Bytemark-Hosting tinderbox: tree: MASTER tinderbox: pull time 2018-03-02 18:11:47 tinderbox: git sha1s core:e802e960f8f7343eec1a14eba70b7affc6298968 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/xml/column-width-row-height.xml | 100 sc/qa/unit/subsequent_filters-test.cxx | 60 ++ 2 files changed, 160 insertions(+) New commits: commit 08b8b55d9d540fcd29d18dd8883d24de457e2675 Author: Kohei YoshidaDate: Fri Mar 2 22:04:51 2018 -0500 Add a new test case for Excel 2003 XML import. This one checks on importing column widths and row heights. Change-Id: I19c63230666aa949eb61805ed2bffe46199a305e Reviewed-on: https://gerrit.libreoffice.org/50653 Tested-by: Jenkins Reviewed-by: Kohei Yoshida diff --git a/sc/qa/unit/data/xml/column-width-row-height.xml b/sc/qa/unit/data/xml/column-width-row-height.xml new file mode 100644 index ..170cd28cd31f --- /dev/null +++ b/sc/qa/unit/data/xml/column-width-row-height.xml @@ -0,0 +1,100 @@ + + +http://www.w3.org/TR/REC-html40;> + + Kohei Yoshida + Kohei Yoshida + 2013-04-16T23:00:57Z + 2013-04-16T23:09:17Z + Novell, Inc. + 16.00 + + + + + + 12210 + 28800 + 0 + 0 + False + False + + + + + + + + + + + + + + + + + + + + +Column Width +10 +15 +20 +12 +12 +12 +22 +22 + + +Row Height + + +20 + + +30 + + +40 + + +50 + + +25 + + +25 + + +25 + + +35 + + +35 + + + + + + + + + + + False + False + + + diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx index 6742e12b999e..3ec2982ada04 100644 --- a/sc/qa/unit/subsequent_filters-test.cxx +++ b/sc/qa/unit/subsequent_filters-test.cxx @@ -244,6 +244,7 @@ public: void testBorderDirectionsXLSXML(); void testBorderColorsXLSXML(); void testHiddenRowsColumnsXLSXML(); +void testColumnWidthRowHeightXLSXML(); CPPUNIT_TEST_SUITE(ScFiltersTest); CPPUNIT_TEST(testBooleanFormatXLSX); @@ -373,6 +374,7 @@ public: CPPUNIT_TEST(testBorderDirectionsXLSXML); CPPUNIT_TEST(testBorderColorsXLSXML); CPPUNIT_TEST(testHiddenRowsColumnsXLSXML); +CPPUNIT_TEST(testColumnWidthRowHeightXLSXML); CPPUNIT_TEST(testCondFormatFormulaListenerXLSX); CPPUNIT_TEST_SUITE_END(); @@ -3887,6 +3889,64 @@ void ScFiltersTest::testHiddenRowsColumnsXLSXML() xDocSh->DoClose(); } +void ScFiltersTest::testColumnWidthRowHeightXLSXML() +{ +ScDocShellRef xDocSh = loadDoc("column-width-row-height.", FORMAT_XLS_XML); +CPPUNIT_ASSERT_MESSAGE("Failed to load column-width-row-height.xml", xDocSh.is()); +ScDocument& rDoc = xDocSh->GetDocument(); + +struct RowHeight +{ +SCROW nRow1; +SCROW nRow2; +sal_uInt16 nHeight; // in points (1 point == 20 twips) +}; + +std::vector aRowChecks = { +{ 2, 2, 20 }, +{ 3, 3, 30 }, +{ 4, 4, 40 }, +{ 5, 5, 50 }, +{ 7, 9, 25 }, +{ 12, 13, 35 }, +}; + +for (const RowHeight& rh : aRowChecks) +{ +for (SCROW i = rh.nRow1; i <= rh.nRow2; ++i) +{ +sal_uInt16 nHeight = rDoc.GetRowHeight(i, 0); +CPPUNIT_ASSERT_EQUAL(sal_uInt16(rh.nHeight*20), nHeight); +} +} + +struct ColWidth +{ +SCCOL nCol1; +SCCOL nCol2; +sal_uInt16 nWidth; // in points (1 point == 20 twips +}; + +std::vector aColChecks = { +{ 1, 1, 56 }, +{ 2, 2, 83 }, +{ 3, 3, 109 }, +{ 5, 7, 67 }, +{ 10, 11, 119 }, +}; + +for (const ColWidth& cw : aColChecks) +{ +for (SCCOL i = cw.nCol1; i <= cw.nCol2; ++i) +{ +sal_uInt16 nWidth = rDoc.GetColWidth(i, 0); +CPPUNIT_ASSERT_EQUAL(sal_uInt16(cw.nWidth*20), nWidth); +} +} + +xDocSh->DoClose(); +} + void ScFiltersTest::testCondFormatXLSB() { ScDocShellRef xDocSh = loadDoc("cond_format.", FORMAT_XLSB); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 116151] Cannot use the File Open or File Save Dialogs in Libreoffice with libreoffice-kde installed
https://bugs.documentfoundation.org/show_bug.cgi?id=116151 --- Comment #1 from listst...@fastmail.com.au --- Created attachment 140299 --> https://bugs.documentfoundation.org/attachment.cgi?id=140299=edit screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116151] New: Cannot use the File Open or File Save Dialogs in Libreoffice with libreoffice-kde installed
https://bugs.documentfoundation.org/show_bug.cgi?id=116151 Bug ID: 116151 Summary: Cannot use the File Open or File Save Dialogs in Libreoffice with libreoffice-kde installed Product: LibreOffice Version: 5.4.5.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: listst...@fastmail.com.au Description: Using Libreoffice 5.4.5 in KDE Plasma 5.8.8/Frameworks 5.36 the File Open/Save dialogs throw up error messages like the below, as well as failing to load properly (the dialogs don't show any file or directories). "Unable to save bookmarks in /home/tim/.local/share/user-places.xbel. Reported error was: Unable to open temporary file. Error was: 5.. This error message will only be shown once. The cause of the error needs to be fixed as quickly as possible, which is most likely a full hard drive." See screenshot for how the file dialog looks Workaround: I found this is caused by the libreoffice-kde package somehow. If I remove this package and instead install libreoffice-gtk3 then the issue is worked around. I'm on Ubuntu 16.04 Steps to Reproduce: 1.Open Libreoffice (doesn't matter whether Calc, Writer etc) on KDE with libreoffice-kde installed 2.File->Open or File->Save Actual Results: File dialog is broken, shows error messages and cannot see any files or folders Expected Results: File open/save dialog works Reproducible: Always User Profile Reset: No Additional Info: Version: 5.4.5.1 Build ID: 1:5.4.5-0ubuntu0.16.04.1~lo1 CPU threads: 4; OS: unknown; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); Calc: group User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85588] COLOR PICKER: More space between 'Custom Color' icon and label
https://bugs.documentfoundation.org/show_bug.cgi?id=85588 --- Comment #9 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106167] LOKDocView: Print option in the widget
https://bugs.documentfoundation.org/show_bug.cgi?id=106167 --- Comment #3 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91296] FILEOPEN: UI: GUI does not reflect actual Header And Footer Settings
https://bugs.documentfoundation.org/show_bug.cgi?id=91296 --- Comment #4 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105776] Writer page-down & page-up navigation in default single-page view
https://bugs.documentfoundation.org/show_bug.cgi?id=105776 Thomas Lendochanged: What|Removed |Added CC||dani3l.grigo...@gmail.com --- Comment #4 from Thomas Lendo --- *** Bug 115979 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115979] Page down issue with browsing one page at a time
https://bugs.documentfoundation.org/show_bug.cgi?id=115979 Thomas Lendochanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Thomas Lendo --- *** This bug has been marked as a duplicate of bug 105776 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115976] Font grouping via PANOSE
https://bugs.documentfoundation.org/show_bug.cgi?id=115976 Thomas Lendochanged: What|Removed |Added Blocks||113638 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113638 [Bug 113638] [META] Fonts listed in LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113638] [META] Fonts listed in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=113638 Thomas Lendochanged: What|Removed |Added Depends on||115976 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115976 [Bug 115976] Font grouping via PANOSE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108437] [META] Image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108437 Thomas Lendochanged: What|Removed |Added Depends on||114076 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114076 [Bug 114076] FILEOPEN: artifacts on Images ( white lines ) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96520] XY plot: Allow more than 2 Y axes and more than 1 X axis
https://bugs.documentfoundation.org/show_bug.cgi?id=96520 Thomas Lendochanged: What|Removed |Added Blocks||108538 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108538 [Bug 108538] [META] Chart feature enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108538] [META] Chart feature enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108538 Thomas Lendochanged: What|Removed |Added Depends on||96520 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=96520 [Bug 96520] XY plot: Allow more than 2 Y axes and more than 1 X axis -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115747] Can't edit file on samba shares
https://bugs.documentfoundation.org/show_bug.cgi?id=115747 Aron Budeachanged: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||bu...@bubli.org, ||juergen.funk...@cib.de, ||mikekagan...@hotmail.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||6942 --- Comment #9 from Aron Budea --- Hi, thanks for bibisecting the bug, that seems like a very plausible commit indeed (referencing it below). Adding Cc: to Juergen Funk (author) and Katarina Behrens (committer). It would be great to know how to reproduce the bug as well. It seems like the exception that happens when creating the lock file is handled change in this commit. Jerome, did a lock file get created in 5.4? Mike, you've been dealing with lock-file-related issues lately, do you have any thoughts on what could be the culprit in this case? https://cgit.freedesktop.org/libreoffice/core/commit/?id=6ca3b3648e25ae9d4d2d29a0df83349198ec3f5e author Juergen Funk 2017-04-12 11:26:10 +0200 committer Katarina Behrens 2017-06-06 15:58:02 +0200 tdf#106942 Wrong message when lock file is empty or corrupt -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106942] When drive is full and open a file, wrong message for lock ( no space for the lock-file)
https://bugs.documentfoundation.org/show_bug.cgi?id=106942 Aron Budeachanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||5747 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37638] Index randomly broken up with extra white space
https://bugs.documentfoundation.org/show_bug.cgi?id=37638 --- Comment #20 from eladh...@gmail.com --- The bug is still present in Libreoffice 6.0.1.1. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Administrator privilige issue
I am working on a bug 45735 that requires changing the registery keys which appears to only work in administrator mode.. Will that work in LO? All i can do without administrator permission is tell user to set default app to LO manually.. Should i do that? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 116142] Remove Quickstarter from Windows builds
https://bugs.documentfoundation.org/show_bug.cgi?id=116142 --- Comment #2 from V Stuart Foote--- And yet despite the "survey" ESC agreed tthat the Quickstarter would be deprecated at 5.4 for Linux builds [1], and was dropped at 6.0 [2] It has never existed for OSX builds, and it represents a source of continued instability on Windows builds. Following suit, and removing it now from the code base for Windows builds is appropriate as we have dropped support for Windows XP and Vista. Microsoft had dropped the OSA launcher from Office at the 2003 release, and at Windows 7 they brought in the entire Jump List infrastructure (of pinned Start menu and Task bar launchers) that LO supports reasonably well. Meaning, the residual Quickstarter on Windows is not a required GUI having already been replaced with Windows specific interface that the project already implements. The Quickstarter is a maintenance headache that just needs to go. =-ref-= [1] https://wiki.documentfoundation.org/ReleaseNotes/5.4#General_2 [2] https://wiki.documentfoundation.org/ReleaseNotes/6.0#General_3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 116142] Remove Quickstarter from Windows builds
https://bugs.documentfoundation.org/show_bug.cgi?id=116142 --- Comment #2 from V Stuart Foote--- And yet despite the "survey" ESC agreed tthat the Quickstarter would be deprecated at 5.4 for Linux builds [1], and was dropped at 6.0 [2] It has never existed for OSX builds, and it represents a source of continued instability on Windows builds. Following suit, and removing it now from the code base for Windows builds is appropriate as we have dropped support for Windows XP and Vista. Microsoft had dropped the OSA launcher from Office at the 2003 release, and at Windows 7 they brought in the entire Jump List infrastructure (of pinned Start menu and Task bar launchers) that LO supports reasonably well. Meaning, the residual Quickstarter on Windows is not a required GUI having already been replaced with Windows specific interface that the project already implements. The Quickstarter is a maintenance headache that just needs to go. =-ref-= [1] https://wiki.documentfoundation.org/ReleaseNotes/5.4#General_2 [2] https://wiki.documentfoundation.org/ReleaseNotes/6.0#General_3 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 106604] FILEOPEN VIEWING - Opened XLS-File is not displaying superscript correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=106604 nenad.ste...@gmail.com changed: What|Removed |Added Version|Inherited From OOo |unspecified --- Comment #4 from nenad.ste...@gmail.com --- can confirm this also for Version: 6.0.2.1 (x64) Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89 CPU threads: 4; OS: Windows 10.0; UI render: GL; Locale: de-AT (de_AT); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56408] Inconsistent parenthesis/ bracket inter-line flow with mixed LTR and RTL text in multi-line paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=56408 --- Comment #17 from Khaled Hosny--- This is a bug, change in direction does not create line breaking opportunity. There is even an easy way to check this with https://unicode.org/cldr/utility/breaks.jsp; copy the text there and choose Line in the drop down and it should show all possible line breaking opportunities. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116150] [NEWHELP] CASE and CASEINLINE for 'sys' logic flawed, default cannot be WIN
https://bugs.documentfoundation.org/show_bug.cgi?id=116150 Olivier Hallotchanged: What|Removed |Added Blocks||97629 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97629 [Bug 97629] [META] Help Content Modernization -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97629] [META] Help Content Modernization
https://bugs.documentfoundation.org/show_bug.cgi?id=97629 Olivier Hallotchanged: What|Removed |Added Depends on||116150 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116150 [Bug 116150] [NEWHELP] CASE and CASEINLINE for 'sys' logic flawed, default cannot be WIN -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116150] [NEWHELP] CASE and CASEINLINE for 'sys' logic flawed, default cannot be WIN
https://bugs.documentfoundation.org/show_bug.cgi?id=116150 --- Comment #1 from Olivier Hallot--- Sample case https://help.libreoffice.org/6.0/en-US/text/shared/guide/digitalsign_send.html?System=UNIX=SHARED#bm_id7430951 In this page the section "Manage your certificates" is not shown. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116150] New: [NEWHELP] CASE and CASEINLINE for 'sys' logic flawed, default cannot be WIN
https://bugs.documentfoundation.org/show_bug.cgi?id=116150 Bug ID: 116150 Summary: [NEWHELP] CASE and CASEINLINE for 'sys' logic flawed, default cannot be WIN Product: LibreOffice Version: 6.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: olivier.hal...@documentfoundation.org CC: olivier.hal...@documentfoundation.org The current implementation of the logic for CASE and CASEINLINE for 'sys' selector is wrong. Default case/caseinline cannot be WIN. It depends on the other cases of the page. E.g. If URL sends =WIN and the page has a case inline only for UNIX, then WIN must display the default. Note: only one 'sys' can be visible in the rendered page. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116147] Creating Documents with Wizard Crashes LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=116147 Julien Nabetchanged: What|Removed |Added Keywords||wantBacktrace --- Comment #3 from Julien Nabet --- Any chance for a backtrace? (see https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#Windows:_How_to_get_a_backtrace) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116147] Creating Documents with Wizard Crashes LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=116147 MMchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from MM --- Confirmed on windows 7 x64 with Version: 6.0.2.1 (x64) Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89 CPU threads: 3; OS: Windows 6.1; UI render: default Something like it supposed to be fixed (bug 114881), as file > wizard > agenda / fax also crashes. But clearly it isn't fixed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-commits] core.git: bin/gla11y
libreoffice-comm...@lists.freedesktop.org wrote: > commit 44b4ad7d210097fdaed7dd94c5746b03f43592d3 > Author: Thorsten Behrens> Date: Fri Mar 2 22:38:18 2018 +0100 > > build fix: disable gla11y for python 2.6 > Some tinderboxen failing with: Traceback (most recent call last): File "/tinderbox/buildslave/source/libo-master/bin/gla11y", line 406, in main check_a11y_relation(filename, tree) File "/tinderbox/buildslave/source/libo-master/bin/gla11y", line 255, in check_a11y_relation for obj in root.iter(´object´): AttributeError: _ElementInterface instance has no attribute ´iter´ Cheers, -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 107755] store recently opened files list only in recently-used.xbel instead of registrymodifications.xcu too
https://bugs.documentfoundation.org/show_bug.cgi?id=107755 --- Comment #7 from Hussam Al-Tayeb--- It should be part of glib2. Glib2 may be called something else on your distribution. An alternative is to run gvfs-info /path/to/file. I may have some clues as to why the modified date is incorrect on your installation. Would you mind keeping this bug open in case someone is able to spare time to take a look? At least correctly populating the Recents panel in gtk+ file dialog will be a welcome enhancement as it prunes stale entries. Thank you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115142] When an image is bigger than the slide impress shrinks it to the size of the slide
https://bugs.documentfoundation.org/show_bug.cgi?id=115142 --- Comment #9 from Ilya Zverev--- Also this affects text boxes: for example, make a text box much wider than the slide, paste some text with long lines there, and press F5. It would be shrunk to the slide width. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116147] Creating Documents with Wizard Crashes LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=116147 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Just for the record, on pc Debian x86-64 with master sources updated today or with LO Debian package 6.0.1, I don't reproduce this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 116142] Remove Quickstarter from Windows builds
https://bugs.documentfoundation.org/show_bug.cgi?id=116142 --- Comment #1 from Heiko Tietze--- Survey revealed that the quickstarter is used https://design.blog.documentfoundation.org/2017/06/28/results-survey-libreoffice-features/ Decision was made in the ESC to keep all these potentially outdated features. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 116142] Remove Quickstarter from Windows builds
https://bugs.documentfoundation.org/show_bug.cgi?id=116142 --- Comment #1 from Heiko Tietze--- Survey revealed that the quickstarter is used https://design.blog.documentfoundation.org/2017/06/28/results-survey-libreoffice-features/ Decision was made in the ESC to keep all these potentially outdated features. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115460] BurnInStyleSheetAttributes not working correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=115460 --- Comment #4 from Heiko Tietze--- (In reply to Buovjaga from comment #3) > Which .fodg file should I test with? The attached minimal example or the cubes from intro.fodg on layer "Layout". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: bin/gla11y
bin/gla11y |3 +++ 1 file changed, 3 insertions(+) New commits: commit 44b4ad7d210097fdaed7dd94c5746b03f43592d3 Author: Thorsten BehrensDate: Fri Mar 2 22:38:18 2018 +0100 build fix: disable gla11y for python 2.6 Things got massively worse with f927fc06b8160c6db134b29dab510e2cd567e3f3 so disable for the moment Change-Id: Ie8a03aa42d5c29bc6931c9c621d1b0427eeddab8 diff --git a/bin/gla11y b/bin/gla11y index 13f1c8e98b97..443e4e774760 100755 --- a/bin/gla11y +++ b/bin/gla11y @@ -38,6 +38,9 @@ except ImportError: import xml.etree.ElementTree as ET lxml = False +if sys.version_info < (2,7): +exit() + progname = os.path.basename(sys.argv[0]) suppressions = {} gen_suppr = None ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107755] store recently opened files list only in recently-used.xbel instead of registrymodifications.xcu too
https://bugs.documentfoundation.org/show_bug.cgi?id=107755 --- Comment #6 from Jean-Baptiste Faure--- (In reply to Hussam Al-Tayeb from comment #5) > what does > "gio info /path/to/your/file.odt | grep time" say? (assuming the file name > is file.odt) no gio command. Which package is missing? Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115142] When an image is bigger than the slide impress shrinks it to the size of the slide
https://bugs.documentfoundation.org/show_bug.cgi?id=115142 --- Comment #8 from Ilya Zverev--- I should add that when exporting to PDF, images are properly clipped. So while this bug makes LibreOffice unusable for presentations with large images, you can still export to a PDF and present from it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115142] When an image is bigger than the slide impress shrinks it to the size of the slide
https://bugs.documentfoundation.org/show_bug.cgi?id=115142 Ilya Zverevchanged: What|Removed |Added CC||kevin.cow...@york.ac.uk --- Comment #7 from Ilya Zverev --- *** Bug 116023 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116023] Image animation resizes large images to screen size
https://bugs.documentfoundation.org/show_bug.cgi?id=116023 Ilya Zverevchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Ilya Zverev --- *** This bug has been marked as a duplicate of bug 115142 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115667] Objects partly outside of slide get moved/ shrinked fully onto slide in presentation mode
https://bugs.documentfoundation.org/show_bug.cgi?id=115667 Ilya Zverevchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Ilya Zverev --- *** This bug has been marked as a duplicate of bug 115142 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115142] When an image is bigger than the slide impress shrinks it to the size of the slide
https://bugs.documentfoundation.org/show_bug.cgi?id=115142 Ilya Zverevchanged: What|Removed |Added CC||stefan-libreoffice@breunig. ||xyz --- Comment #6 from Ilya Zverev --- *** Bug 115667 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107755] store recently opened files list only in recently-used.xbel instead of registrymodifications.xcu too
https://bugs.documentfoundation.org/show_bug.cgi?id=107755 --- Comment #5 from Hussam Al-Tayeb--- what does "gio info /path/to/your/file.odt | grep time" say? (assuming the file name is file.odt) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115649] 64-bit Writer v.6.0.1.1 crashes every time I send a file to network printer after clicking OK to print (ucrtbase.dll)
https://bugs.documentfoundation.org/show_bug.cgi?id=115649 --- Comment #26 from t34--- I deactivate the checkbox from comment #16 (Drucker-Einstellungen mit dem Dokument laden) and my printing problems are gone. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107755] store recently opened files list only in recently-used.xbel instead of registrymodifications.xcu too
https://bugs.documentfoundation.org/show_bug.cgi?id=107755 --- Comment #4 from Jean-Baptiste Faure--- The list of recent files provided by my Nautilus (Ubuntu 16.04) is clearly wrong from a LibreOffice point of view because it shows ODF files accessed during the last hour that I did not open since several weeks. So your proposition seems not be able to provide better information than the current recently used files implementation. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115649] 64-bit Writer v.6.0.1.1 crashes every time I send a file to network printer after clicking OK to print (ucrtbase.dll)
https://bugs.documentfoundation.org/show_bug.cgi?id=115649 --- Comment #25 from t34--- Created attachment 140298 --> https://bugs.documentfoundation.org/attachment.cgi?id=140298=edit msinfo32 output als attachment I install LO 6.0.2.1 (32bit) and redistributable 2015upd3 and redistributable 2017 but the problem still exist. Problemsignatur: Problemereignisname: APPCRASH Anwendungsname: soffice.bin Anwendungsversion:6.0.2.1 Anwendungszeitstempel:5a90808c Fehlermodulname: ucrtbase.DLL Fehlermodulversion: 10.0.10586.1171 Fehlermodulzeitstempel: 59ae5046 Ausnahmecode: 4015 Ausnahmeoffset: 000846fa Betriebsystemversion: 6.1.7601.2.1.0.768.3 Gebietsschema-ID: 1031 Zusatzinformation 1: 8379 Zusatzinformation 2: 8379e785032335032d2770be032d4a42 Zusatzinformation 3: ae19 Zusatzinformation 4: ae19bb907d810a11e01b34374a8edad6 msinfo32 output als attachment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source sw/uiconfig
sw/inc/swabstdlg.hxx |2 +- sw/source/ui/dialog/swdlgfact.cxx| 11 +++ sw/source/ui/dialog/swdlgfact.hxx| 11 +-- sw/source/ui/table/splittbl.cxx | 33 ++--- sw/source/uibase/inc/splittbl.hxx| 33 - sw/source/uibase/shells/tabsh.cxx|3 ++- sw/uiconfig/swriter/ui/splittable.ui | 22 ++ 7 files changed, 59 insertions(+), 56 deletions(-) New commits: commit 6eb1affe21d98097c539619af617f0bbe5b8abd1 Author: Caolán McNamaraDate: Fri Mar 2 15:30:01 2018 + weld split table dialog Change-Id: I329a57fa09e6eb0fe75b93b0726d9b7718426693 Reviewed-on: https://gerrit.libreoffice.org/50639 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx index 89e70bc4237b..dcdc6d408c8d 100644 --- a/sw/inc/swabstdlg.hxx +++ b/sw/inc/swabstdlg.hxx @@ -430,7 +430,7 @@ public: virtual VclPtr CreateSwSortingDialog(vcl::Window * pParent, SwWrtShell ) = 0; virtual VclPtr CreateSwTableHeightDialog(vcl::Window *pParent, SwWrtShell ) = 0; virtual VclPtr CreateSwColumnDialog(vcl::Window *pParent, SwWrtShell ) = 0; -virtual VclPtr CreateSplitTableDialog ( vcl::Window * pParent, SwWrtShell ) = 0; +virtual VclPtr CreateSplitTableDialog(weld::Window* pParent, SwWrtShell ) = 0; virtual VclPtr CreateSwAutoFormatDlg(weld::Window* pParent, SwWrtShell* pShell, bool bSetAutoFormat = true, diff --git a/sw/source/ui/dialog/swdlgfact.cxx b/sw/source/ui/dialog/swdlgfact.cxx index a2999ec607dd..96a4acb469c5 100644 --- a/sw/source/ui/dialog/swdlgfact.cxx +++ b/sw/source/ui/dialog/swdlgfact.cxx @@ -92,7 +92,10 @@ IMPL_ABSTDLG_BASE(AbstractSwInsertAbstractDlg_Impl); IMPL_ABSTDLG_BASE(SwAbstractSfxDialog_Impl); IMPL_ABSTDLG_BASE(AbstractSwAsciiFilterDlg_Impl); IMPL_ABSTDLG_BASE(VclAbstractDialog_Impl); -IMPL_ABSTDLG_BASE(AbstractSplitTableDialog_Impl); +short AbstractSplitTableDialog_Impl::Execute() +{ +return m_xDlg->run(); +} short AbstractSwBreakDlg_Impl::Execute() { return m_xDlg->run(); @@ -197,7 +200,7 @@ void AbstractSwAsciiFilterDlg_Impl::FillOptions( SwAsciiOptions& rOptions ) SplitTable_HeadlineOption AbstractSplitTableDialog_Impl::GetSplitMode() { -return pDlg->GetSplitMode(); +return m_xDlg->GetSplitMode(); } OUString AbstractSwBreakDlg_Impl::GetTemplateName() @@ -795,9 +798,9 @@ VclPtr SwAbstractDialogFactory_Impl::CreateSwSortingDialog(vc return VclPtr::Create( pDlg ); } -VclPtr SwAbstractDialogFactory_Impl::CreateSplitTableDialog ( vcl::Window *pParent, SwWrtShell ) +VclPtr SwAbstractDialogFactory_Impl::CreateSplitTableDialog(weld::Window *pParent, SwWrtShell ) { -return VclPtr::Create( VclPtr::Create( pParent, rSh) ); +return VclPtr::Create(new SwSplitTableDlg(pParent, rSh)); } VclPtr SwAbstractDialogFactory_Impl::CreateSwSelGlossaryDlg(const OUString ) diff --git a/sw/source/ui/dialog/swdlgfact.hxx b/sw/source/ui/dialog/swdlgfact.hxx index 6c0418ecdf6d..13a25e8d9948 100644 --- a/sw/source/ui/dialog/swdlgfact.hxx +++ b/sw/source/ui/dialog/swdlgfact.hxx @@ -118,7 +118,14 @@ public: class AbstractSplitTableDialog_Impl : public AbstractSplitTableDialog // add for { -DECL_ABSTDLG_BASE(AbstractSplitTableDialog_Impl, SwSplitTableDlg) +protected: +std::unique_ptr m_xDlg; +public: +explicit AbstractSplitTableDialog_Impl(SwSplitTableDlg* p) +: m_xDlg(p) +{ +} +virtual short Execute() override; virtual SplitTable_HeadlineOption GetSplitMode() override; }; @@ -438,7 +445,7 @@ public: virtual VclPtr CreateSwSortingDialog(vcl::Window * pParent, SwWrtShell ) override; virtual VclPtr CreateSwTableHeightDialog(vcl::Window *pParent, SwWrtShell ) override; virtual VclPtr CreateSwColumnDialog(vcl::Window *pParent, SwWrtShell ) override; -virtual VclPtr CreateSplitTableDialog ( vcl::Window * pParent, SwWrtShell ) override; +virtual VclPtr CreateSplitTableDialog(weld::Window* pParent, SwWrtShell ) override; virtual VclPtr CreateSwAutoFormatDlg(weld::Window* pParent, SwWrtShell* pShell, bool bSetAutoFormat = true, diff --git a/sw/source/ui/table/splittbl.cxx b/sw/source/ui/table/splittbl.cxx index 63dd08223447..f78041b06cfa 100644 --- a/sw/source/ui/table/splittbl.cxx +++ b/sw/source/ui/table/splittbl.cxx @@ -21,39 +21,26 @@ #include #include -SwSplitTableDlg::SwSplitTableDlg( vcl::Window *pParent, SwWrtShell ) -: SvxStandardDialog( pParent, "SplitTableDialog", "modules/swriter/ui/splittable.ui" ) +SwSplitTableDlg::SwSplitTableDlg(weld::Window *pParent, SwWrtShell ) +: m_xBuilder(Application::CreateBuilder(pParent,
[Libreoffice-commits] core.git: sw/source sw/uiconfig vcl/source
sw/source/ui/dialog/swdlgfact.cxx | 10 - sw/source/ui/dialog/swdlgfact.hxx |9 + sw/source/ui/table/convert.cxx | 177 - sw/source/uibase/inc/convert.hxx | 53 sw/uiconfig/swriter/ui/converttexttable.ui | 86 +++--- vcl/source/window/builder.cxx |2 6 files changed, 162 insertions(+), 175 deletions(-) New commits: commit 810cfc0106ae0b1874681f7a8c79c36186aefcca Author: Caolán McNamaraDate: Fri Mar 2 16:28:51 2018 + weld convert text-to-table/table-to-text dialog Change-Id: I81137c0fe0b0e243ebc5b836ac09448d746b2214 Reviewed-on: https://gerrit.libreoffice.org/50644 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/source/ui/dialog/swdlgfact.cxx b/sw/source/ui/dialog/swdlgfact.cxx index ecb89281d7fd..a2999ec607dd 100644 --- a/sw/source/ui/dialog/swdlgfact.cxx +++ b/sw/source/ui/dialog/swdlgfact.cxx @@ -98,7 +98,10 @@ short AbstractSwBreakDlg_Impl::Execute() return m_xDlg->run(); } IMPL_ABSTDLG_BASE(AbstractTabDialog_Impl); -IMPL_ABSTDLG_BASE(AbstractSwConvertTableDlg_Impl); +short AbstractSwConvertTableDlg_Impl::Execute() +{ +return m_xDlg->run(); +} IMPL_ABSTDLG_BASE(AbstractSwInsertDBColAutoPilot_Impl); IMPL_ABSTDLG_BASE(AbstractDropDownFieldDialog_Impl); IMPL_ABSTDLG_BASE(AbstractSwLabDlg_Impl); @@ -215,7 +218,7 @@ sal_uInt16 AbstractSwBreakDlg_Impl:: GetKind() void AbstractSwConvertTableDlg_Impl::GetValues( sal_Unicode& rDelim,SwInsertTableOptions& rInsTableFlags, SwTableAutoFormat const*& prTAFormat) { -pDlg->GetValues(rDelim,rInsTableFlags, prTAFormat); +m_xDlg->GetValues(rDelim,rInsTableFlags, prTAFormat); } void AbstractSwInsertDBColAutoPilot_Impl::DataToDoc( const uno::Sequence< uno::Any >& rSelection, @@ -702,8 +705,7 @@ VclPtr SwAbstractDialogFactory_Impl::CreateSwCharDlg(vcl: VclPtr SwAbstractDialogFactory_Impl::CreateSwConvertTableDlg(SwView& rView, bool bToTable) { -VclPtr pDlg = VclPtr::Create(rView, bToTable); -return VclPtr::Create(pDlg); +return VclPtr::Create(new SwConvertTableDlg(rView, bToTable)); } VclPtr SwAbstractDialogFactory_Impl::CreateSwCaptionDialog ( vcl::Window *pParent, SwView ) diff --git a/sw/source/ui/dialog/swdlgfact.hxx b/sw/source/ui/dialog/swdlgfact.hxx index becab7e73700..6c0418ecdf6d 100644 --- a/sw/source/ui/dialog/swdlgfact.hxx +++ b/sw/source/ui/dialog/swdlgfact.hxx @@ -149,7 +149,14 @@ private: class AbstractSwConvertTableDlg_Impl : public AbstractSwConvertTableDlg { -DECL_ABSTDLG_BASE( AbstractSwConvertTableDlg_Impl,SwConvertTableDlg) +protected: +std::unique_ptr m_xDlg; +public: +explicit AbstractSwConvertTableDlg_Impl(SwConvertTableDlg* p) +: m_xDlg(p) +{ +} +virtual short Execute() override; virtual void GetValues( sal_Unicode& rDelim,SwInsertTableOptions& rInsTableFlags, SwTableAutoFormat const*& prTAFormat) override; }; diff --git a/sw/source/ui/table/convert.cxx b/sw/source/ui/table/convert.cxx index 6b918a59beae..f6df42e9c9bd 100644 --- a/sw/source/ui/table/convert.cxx +++ b/sw/source/ui/table/convert.cxx @@ -46,21 +46,21 @@ void SwConvertTableDlg::GetValues( sal_Unicode& rDelim, SwInsertTableOptions& rInsTableOpts, SwTableAutoFormat const*& prTAFormat ) { -if( mpTabBtn->IsChecked() ) +if (m_xTabBtn->get_active()) { //0x0b mustn't be set when re-converting table into text -bIsKeepColumn = !mpKeepColumn->IsVisible() || mpKeepColumn->IsChecked(); +bIsKeepColumn = !m_xKeepColumn->get_visible() || m_xKeepColumn->get_active(); rDelim = bIsKeepColumn ? 0x09 : 0x0b; nSaveButtonState = 0; } -else if( mpSemiBtn->IsChecked() ) +else if (m_xSemiBtn->get_active()) { rDelim = ';'; nSaveButtonState = 1; } -else if( mpOtherBtn->IsChecked() && !mpOtherEd->GetText().isEmpty() ) +else if (m_xOtherBtn->get_active() && !m_xOtherEd->get_text().isEmpty()) { -uOther = mpOtherEd->GetText()[0]; +uOther = m_xOtherEd->get_text()[0]; rDelim = uOther; nSaveButtonState = 3; } @@ -68,7 +68,7 @@ void SwConvertTableDlg::GetValues( sal_Unicode& rDelim, { nSaveButtonState = 2; rDelim = cParaDelim; -if(mpOtherBtn->IsChecked()) +if (m_xOtherBtn->get_active()) { nSaveButtonState = 3; uOther = 0; @@ -76,15 +76,15 @@ void SwConvertTableDlg::GetValues( sal_Unicode& rDelim, } sal_uInt16 nInsMode = 0; -if (mpBorderCB->IsChecked()) +if (m_xBorderCB->get_active()) nInsMode |= tabopts::DEFAULT_BORDER; -if
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/interpr1.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 38b87bbb24c1d1cc088d3d135e7e95b3ec75d386 Author: Eike RathkeDate: Fri Mar 2 21:38:08 2018 +0100 Resolves: tdf#116149 handle external references in VAR* and STDEV* functions Change-Id: I644a5f8f92452ca775ee3b42a73d3f0a0ac3c623 diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index 632d16c49b32..1722ececce25 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -3930,9 +3930,11 @@ void ScInterpreter::GetStVarParams( bool bTextAsZero, double(*VarResult)( double } } break; +case svExternalSingleRef : +case svExternalDoubleRef : case svMatrix : { -ScMatrixRef pMat = PopMatrix(); +ScMatrixRef pMat = GetMatrix(); if (pMat) { SCSIZE nC, nR; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 116149] VAR* and STDEV* functions don't support external references
https://bugs.documentfoundation.org/show_bug.cgi?id=116149 Eike Rathkechanged: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116149] New: VAR* and STDEV* functions don' t support external references
https://bugs.documentfoundation.org/show_bug.cgi?id=116149 Bug ID: 116149 Summary: VAR* and STDEV* functions don't support external references Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: er...@redhat.com The VAR* and STDEV* functions' families don't work with external references. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115496] Menubar entry in the hamburger menu isn' t working in with Notebookbar in Grouped full/compact mode
https://bugs.documentfoundation.org/show_bug.cgi?id=115496 --- Comment #3 from V Stuart Foote--- (In reply to V Stuart Foote from comment #2) > Is there a need for the Label [1], and does that interfere with the > .uno:MenuBar action name? The .uno command seems to work fine from the popup > menu [2]. > Or, is it just that the command is ".uno:Menubar", rather than ".uno:MenuBar"? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116148] FILESAVE PPTX hatching in chart becomes a solid bar
https://bugs.documentfoundation.org/show_bug.cgi?id=116148 --- Comment #3 from Gerald Pfeifer--- Created attachment 140297 --> https://bugs.documentfoundation.org/attachment.cgi?id=140297=edit This is how it looks like after saving as PPTX and reopening that -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116148] FILESAVE PPTX hatching in chart becomes a solid bar
https://bugs.documentfoundation.org/show_bug.cgi?id=116148 --- Comment #2 from Gerald Pfeifer--- Created attachment 140296 --> https://bugs.documentfoundation.org/attachment.cgi?id=140296=edit Screenshot before -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116148] FILESAVE PPTX hatching in chart becomes a solid bar
https://bugs.documentfoundation.org/show_bug.cgi?id=116148 --- Comment #1 from Gerald Pfeifer--- Created attachment 140295 --> https://bugs.documentfoundation.org/attachment.cgi?id=140295=edit Sample document (in ODP) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116148] FILESAVE PPTX hatching in chart becomes a solid bar
https://bugs.documentfoundation.org/show_bug.cgi?id=116148 Gerald Pfeiferchanged: What|Removed |Added Summary|FILESAVE PPTX hatching in |FILESAVE PPTX hatching in |graph becomes a solid bar |chart becomes a solid bar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116148] New: FILESAVE PPTX hatching in graph becomes a solid bar
https://bugs.documentfoundation.org/show_bug.cgi?id=116148 Bug ID: 116148 Summary: FILESAVE PPTX hatching in graph becomes a solid bar Product: LibreOffice Version: 6.0.1.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ger...@pfeifer.com Description: Saving a chart with blocks that use hatching as PPTX (regardless whether the original came as PPTX or ODP) loses the hatching and replaces it with solid color. Steps to Reproduce: 1. Open sample document (in ODP format). 2. Save as PPTX. 3. Close and reopen saved PPTX. Actual Results: Observe the difference where what used to be blocks with hatching now show in solid color. Expected Results: Document does not visually change when saving as PPTX. Reproducible: Always User Profile Reset: No Additional Info: This originally came from a PPTX document, and the import from PPTX to ODP with LibreOffice seems to have worked just fine. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Bug 102593 depends on bug 114675, which changed state. Bug 114675 Summary: EDITING: pasting text (in Calc in a cell in edit mode, in Draw in a text shape), leaves the cursor in front of the pasted text https://bugs.documentfoundation.org/show_bug.cgi?id=114675 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112128] [META] Cell edit mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112128 Bug 112128 depends on bug 114675, which changed state. Bug 114675 Summary: EDITING: pasting text (in Calc in a cell in edit mode, in Draw in a text shape), leaves the cursor in front of the pasted text https://bugs.documentfoundation.org/show_bug.cgi?id=114675 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: editeng/inc editeng/source
editeng/inc/editxml.hxx |3 ++- editeng/source/editeng/impedit4.cxx |4 +--- editeng/source/xml/xmltxtimp.cxx| 11 +-- 3 files changed, 12 insertions(+), 6 deletions(-) New commits: commit a44e62b82c7598471da9a5254953067613806337 Author: Eike RathkeDate: Fri Mar 2 20:31:48 2018 +0100 Resolves: tdf#114675 return new EditPaM of insert position from SvxReadXML() Change-Id: I77027d74a0addaafaf19e2c2a8e9759d560951eb diff --git a/editeng/inc/editxml.hxx b/editeng/inc/editxml.hxx index 6e3a3de26a47..a3918e1c5397 100644 --- a/editeng/inc/editxml.hxx +++ b/editeng/inc/editxml.hxx @@ -23,12 +23,13 @@ class EditEngine; class SvStream; struct ESelection; +class EditPaM; /** this function exports the selected content of an edit engine into a xml stream*/ extern void SvxWriteXML( EditEngine& rEditEngine, SvStream& rStream, const ESelection& rSel ); /** this function imports xml from the stream into the selected of an edit engine */ -extern void SvxReadXML( EditEngine& rEditEngine, SvStream& rStream, const ESelection& rSel ); +extern EditPaM SvxReadXML( EditEngine& rEditEngine, SvStream& rStream, const ESelection& rSel ); #endif diff --git a/editeng/source/editeng/impedit4.cxx b/editeng/source/editeng/impedit4.cxx index 81f329cf999d..38d627b2142c 100644 --- a/editeng/source/editeng/impedit4.cxx +++ b/editeng/source/editeng/impedit4.cxx @@ -135,9 +135,7 @@ EditPaM ImpEditEngine::ReadXML( SvStream& rInput, EditSelection aSel ) ESelection aESel = CreateESel( aSel ); -::SvxReadXML( *GetEditEnginePtr(), rInput, aESel ); - -return aSel.Max(); +return ::SvxReadXML( *GetEditEnginePtr(), rInput, aESel ); } EditPaM ImpEditEngine::ReadRTF( SvStream& rInput, EditSelection aSel ) diff --git a/editeng/source/xml/xmltxtimp.cxx b/editeng/source/xml/xmltxtimp.cxx index 7fad6fa1419d..fa7e84546609 100644 --- a/editeng/source/xml/xmltxtimp.cxx +++ b/editeng/source/xml/xmltxtimp.cxx @@ -138,7 +138,7 @@ SvxXMLXTextImportComponent::SvxXMLXTextImportComponent( SvXMLImport::setTargetDocument(new SvxSimpleUnoModel); } -void SvxReadXML( EditEngine& rEditEngine, SvStream& rStream, const ESelection& rSel ) +EditPaM SvxReadXML( EditEngine& rEditEngine, SvStream& rStream, const ESelection& rSel ) { SvxEditEngineSource aEditSource( ); @@ -159,6 +159,9 @@ void SvxReadXML( EditEngine& rEditEngine, SvStream& rStream, const ESelection& r rEditEngine.InsertParaBreak( rEditEngine.CreateSelection( rSel ).Max() ); rEditEngine.InsertParaBreak( rEditEngine.CreateSelection( rSel ).Max() ); +// Init return PaM. +EditPaM aPaM( rEditEngine.CreateSelection( rSel ).Max()); + ESelection aSel(rSel.nStartPara+1, 0, rSel.nEndPara+1, 0); uno::Reference xParent; SvxUnoText* pUnoText = new SvxUnoText( , , xParent ); @@ -227,12 +230,16 @@ void SvxReadXML( EditEngine& rEditEngine, SvStream& rStream, const ESelection& r rEditEngine.ParaAttribsToCharAttribs( pDoc.GetObject( pDoc.Count() - initialParaCount + aSel.nEndPara - 2 ) ); rEditEngine.ConnectParagraphs( pDoc.GetObject( pDoc.Count() - initialParaCount + aSel.nEndPara - 2 ), pDoc.GetObject( pDoc.Count() - initialParaCount + aSel.nEndPara -1 ), true ); -rEditEngine.ConnectParagraphs( pDoc.GetObject( pDoc.Count() - initialParaCount + aSel.nEndPara - 2 ), + +// The final join is to be returned. +aPaM = rEditEngine.ConnectParagraphs( pDoc.GetObject( pDoc.Count() - initialParaCount + aSel.nEndPara - 2 ), pDoc.GetObject( pDoc.Count() - initialParaCount + aSel.nEndPara -1 ), true ); } catch( const uno::Exception& ) { } + +return aPaM; } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115496] Menubar entry in the hamburger menu isn' t working in with Notebookbar in Grouped full/compact mode
https://bugs.documentfoundation.org/show_bug.cgi?id=115496 V Stuart Footechanged: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- Is there a need for the Label [1], and does that interfere with the .uno:MenuBar action name? The .uno command seems to work fine from the popup menu [2]. And what ever happend to assigning a shortcut (presumably F10) to the .uno:MenuBar command as for bug 90195 or bug 107343? =-ref-= [1] https://opengrok.libreoffice.org/search?project=core=%22menubarD%5C%22%5C%3EMenubar%22 [2] https://opengrok.libreoffice.org/search?project=core=%22id%5C%3D%5C%22%5C.uno%5C%3AMenubar%5C%22%22 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa svl/source
sc/qa/unit/subsequent_filters-test.cxx |5 +++-- svl/source/numbers/zformat.cxx |2 ++ svl/source/numbers/zforscan.cxx| 20 svl/source/numbers/zforscan.hxx|5 + 4 files changed, 30 insertions(+), 2 deletions(-) New commits: commit ce4fc2fc08be8ea2773194e303ed42d2579e93a0 Author: Eike RathkeDate: Fri Mar 2 17:15:47 2018 +0100 Resolves: tdf#115351 convert boolean equivalent format codes to proper Boolean Because Excel does not know a Boolean number format, BOOLEAN is saved to Excel as "TRUE";"TRUE";"FALSE" with implicit conditions [>0] and [<0]. This when loaded has no boolean property. Then saved to ODF it is loaded as [>0]"TRUE";[<0]"TRUE";"FALSE" with explicit conditions, which has identical meaning. Convert both equivalent format codes to proper BOOLEAN when reading. Locale dependent representations are treated the same, e.g. "WAHR";"WAHR";"FALSCH" Change-Id: I49383d71fce972fdd7ad9b19ce3bc150d02aba62 Reviewed-on: https://gerrit.libreoffice.org/50642 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx index 5332bc77722e..6742e12b999e 100644 --- a/sc/qa/unit/subsequent_filters-test.cxx +++ b/sc/qa/unit/subsequent_filters-test.cxx @@ -459,7 +459,8 @@ void ScFiltersTest::testBooleanFormatXLSX() ScDocShellRef xDocSh = loadDoc("check-boolean.", FORMAT_XLSX); ScDocument& rDoc = xDocSh->GetDocument(); SvNumberFormatter* pNumFormatter = rDoc.GetFormatTable(); -const OUString aBooleanTypeStr = "\"TRUE\";\"TRUE\";\"FALSE\""; +// Saved as >"TRUE";"TRUE";"FALSE"< but reading converted back to >BOOLEAN< +const OUString aBooleanTypeStr = "BOOLEAN"; CPPUNIT_ASSERT_MESSAGE("Failed to load check-boolean.xlsx", xDocSh.is()); sal_uInt32 nNumberFormat; @@ -469,7 +470,7 @@ void ScFiltersTest::testBooleanFormatXLSX() rDoc.GetNumberFormat(0, i, 0, nNumberFormat); const SvNumberformat* pNumberFormat = pNumFormatter->GetEntry(nNumberFormat); const OUString& rFormatStr = pNumberFormat->GetFormatstring(); -CPPUNIT_ASSERT_EQUAL_MESSAGE("Number format != boolean", rFormatStr, aBooleanTypeStr); +CPPUNIT_ASSERT_EQUAL_MESSAGE("Number format != boolean", aBooleanTypeStr, rFormatStr); } xDocSh->DoClose(); diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx index 2223e151e521..984c85f108f0 100644 --- a/svl/source/numbers/zformat.cxx +++ b/svl/source/numbers/zformat.cxx @@ -761,6 +761,8 @@ SvNumberformat::SvNumberformat(OUString& rString, , bAdditionalBuiltin( false ) , bStarFlag( false ) { +rScan.ReplaceBooleanEquivalent( rString); + OUStringBuffer sBuff(rString); // If the group (AKA thousand) separator is a No-Break Space (French) diff --git a/svl/source/numbers/zforscan.cxx b/svl/source/numbers/zforscan.cxx index 3f1cf19a0b20..d9e1fba36a8f 100644 --- a/svl/source/numbers/zforscan.cxx +++ b/svl/source/numbers/zforscan.cxx @@ -361,6 +361,16 @@ void ImpSvNumberformatScan::SetDependentKeywords() InitSpecialKeyword( NF_KEY_TRUE ); InitSpecialKeyword( NF_KEY_FALSE ); +// Boolean equivalent format codes that are written to Excel files, may +// have been written to ODF as well, specifically if such loaded Excel file +// was saved as ODF, and shall result in proper Boolean again. +// "TRUE";"TRUE";"FALSE" +sBooleanEquivalent1 = "\"" + sKeyword[NF_KEY_TRUE] + "\";\"" + +sKeyword[NF_KEY_TRUE] + "\";\"" + sKeyword[NF_KEY_FALSE] + "\""; +// [>0]"TRUE";[<0]"TRUE";"FALSE" +sBooleanEquivalent2 = "[>0]\"" + sKeyword[NF_KEY_TRUE] + "\";[<0]\"" + +sKeyword[NF_KEY_TRUE] + "\";\"" + sKeyword[NF_KEY_FALSE] + "\""; + // compatibility currency strings InitCompatCur(); @@ -3289,4 +3299,14 @@ void ImpSvNumberformatScan::CopyInfo(ImpSvNumberformatInfo* pInfo, sal_uInt16 nC pInfo->nCntExp = nCntExp; } +void ImpSvNumberformatScan::ReplaceBooleanEquivalent( OUString& rString ) +{ +InitKeywords(); +/* TODO: compare case insensitive? Or rather leave as is and case not + * matching indicates user supplied on purpose? Written to file / generated + * was always uppercase. */ +if (rString == sBooleanEquivalent1 || rString == sBooleanEquivalent2) +rString = GetKeywords()[NF_KEY_BOOLEAN]; +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/svl/source/numbers/zforscan.hxx b/svl/source/numbers/zforscan.hxx index 34e64bd25da6..e2246f574dd5 100644 --- a/svl/source/numbers/zforscan.hxx +++ b/svl/source/numbers/zforscan.hxx @@ -144,6 +144,9 @@ public: return sCurString; } +/// Replace Boolean equivalent format codes with proper Boolean format. +void
[Libreoffice-bugs] [Bug 113825] [META] Wizard bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113825 Harald Koesterchanged: What|Removed |Added Depends on||116147 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116147 [Bug 116147] Creating Documents with Wizard Crashes LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116147] New: Creating Documents with Wizard Crashes LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=116147 Bug ID: 116147 Summary: Creating Documents with Wizard Crashes LibreOffice Product: LibreOffice Version: 6.0.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: harald.koes...@mail.de Blocks: 113825 In order to reproduce: [1] Start LibreOffice and open letter wizard: File > Wizards > Letter… [2] Click several times 'Next'. You do not need to change anything. Then 'Finish'. A 'Save as' dialogue is displayed. [3] Save document as template. A message is displayed, that LibreOffice is no longer working. You can only close LibreOffice. Expected: Saving of document and no crash. [4] Close program. LibreOffice is completely closed. There is the danger of data loss if a document has been edited and has not been saved before using the wizard. OS: Win10, 64 bit. Bug exists in versions 6.0.0, 6.0.1 and 6.0.2, but not in 5.4.4 (all 64 bit). Bug 114881 describes the same problem, but according that report the bug has been fixed. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113825 [Bug 113825] [META] Wizard bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116146] New: EDITING - Index "Search term" does not accept regular expression
https://bugs.documentfoundation.org/show_bug.cgi?id=116146 Bug ID: 116146 Summary: EDITING - Index "Search term" does not accept regular expression Product: LibreOffice Version: 6.0.2.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: luci...@ulmail.net "Search term" in a concordance file, i.e. a .sdi file, does not accept regular expression and if one is put in, the whole row is ignored. Example: consciousness; metaphysics; biology;1 Dennett(?!, however);Dennett, Daniel (?___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114675] EDITING: pasting text (in Calc in a cell in edit mode, in Draw in a text shape), leaves the cursor in front of the pasted text
https://bugs.documentfoundation.org/show_bug.cgi?id=114675 Eike Rathkechanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | --- Comment #9 from Eike Rathke --- Apparently not.. taking. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source xmlsecurity/qa
vcl/source/filter/ipdf/pdfdocument.cxx |4 +++- xmlsecurity/qa/unit/pdfsigning/data/forcepoint16.pdf |binary xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx|2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) New commits: commit c8cd02629d0c17c248eae42369fff246f49ae9d7 Author: Miklos VajnaDate: Fri Mar 2 11:18:21 2018 +0100 forcepoint #16: fix heap-use-after-free PDFDocument::Tokenize() in the aKeyword == "obj" case allocates a PDFObjectElement, stores it as an owning pointer inside rElements, and also stores two non-owning references to it in m_aOffsetObjects and m_aIDObjects. So make sure those 2 other containers are also cleared then elements go away. LO_TRACE="valgrind" bin/run pdfverify doesn't report errors anymore after the fix. Change-Id: Ie103de3e24a1080257a79e53b994e8536a9597bc Reviewed-on: https://gerrit.libreoffice.org/50627 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/vcl/source/filter/ipdf/pdfdocument.cxx b/vcl/source/filter/ipdf/pdfdocument.cxx index af1eea1f57cf..98b6a2d8a596 100644 --- a/vcl/source/filter/ipdf/pdfdocument.cxx +++ b/vcl/source/filter/ipdf/pdfdocument.cxx @@ -1260,8 +1260,10 @@ bool PDFDocument::Read(SvStream& rStream) if (pPrev) nStartXRef = pPrev->GetValue(); -// Reset state, except object offsets and the edit buffer. +// Reset state, except the edit buffer. m_aElements.clear(); +m_aOffsetObjects.clear(); +m_aIDObjects.clear(); m_aStartXRefs.clear(); m_aEOFs.clear(); m_pTrailer = nullptr; diff --git a/xmlsecurity/qa/unit/pdfsigning/data/forcepoint16.pdf b/xmlsecurity/qa/unit/pdfsigning/data/forcepoint16.pdf new file mode 100644 index ..9edccb47f40c Binary files /dev/null and b/xmlsecurity/qa/unit/pdfsigning/data/forcepoint16.pdf differ diff --git a/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx b/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx index cb7fd4cfe945..8cf913279643 100644 --- a/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx +++ b/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx @@ -452,6 +452,8 @@ void PDFSigningTest::testTokenize() "tdf107149.pdf", // Nested parentheses were not handled. "tdf114460.pdf", +// Valgrind was unhappy about this. +"forcepoint16.pdf", }; for (const auto& rName : aNames) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115792] Cursor is in the wrong position after pasting text
https://bugs.documentfoundation.org/show_bug.cgi?id=115792 Eike Rathkechanged: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112128] [META] Cell edit mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112128 Bug 112128 depends on bug 115792, which changed state. Bug 115792 Summary: Cursor is in the wrong position after pasting text https://bugs.documentfoundation.org/show_bug.cgi?id=115792 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Bug 102593 depends on bug 115792, which changed state. Bug 115792 Summary: Cursor is in the wrong position after pasting text https://bugs.documentfoundation.org/show_bug.cgi?id=115792 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115792] Cursor is in the wrong position after pasting text
https://bugs.documentfoundation.org/show_bug.cgi?id=115792 Eike Rathkechanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Eike Rathke --- It is. *** This bug has been marked as a duplicate of bug 114675 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/edit/edlingu.cxx | 44 ++-- 1 file changed, 20 insertions(+), 24 deletions(-) New commits: commit f5850c7841e98c9f91076ea0e0b840374766bfca Author: Michael StahlDate: Thu Mar 1 22:23:02 2018 +0100 sw: convert DELETEZ to unique_ptr in edlingu.cxx Change-Id: I7af773aec20d23b925a90eade56452e8aed93b5b Reviewed-on: https://gerrit.libreoffice.org/50623 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/sw/source/core/edit/edlingu.cxx b/sw/source/core/edit/edlingu.cxx index 9cf389eaa3a4..9373007147db 100644 --- a/sw/source/core/edit/edlingu.cxx +++ b/sw/source/core/edit/edlingu.cxx @@ -66,27 +66,27 @@ using namespace ::com::sun::star::linguistic2; class SwLinguIter { SwEditShell *pSh; -SwPosition *pStart; -SwPosition *pEnd; -SwPosition *pCurr; -SwPosition *pCurrX; +std::unique_ptr m_pStart; +std::unique_ptr m_pEnd; +std::unique_ptr m_pCurr; +std::unique_ptr m_pCurrX; sal_uInt16 nCursorCnt; public: SwLinguIter(); SwEditShell *GetSh() { return pSh; } -const SwPosition *GetEnd() const { return pEnd; } -void SetEnd( SwPosition* pNew ){ delete pEnd; pEnd = pNew; } +const SwPosition *GetEnd() const { return m_pEnd.get(); } +void SetEnd(SwPosition* pNew) { m_pEnd.reset(pNew); } -const SwPosition *GetStart() const { return pStart; } -void SetStart( SwPosition* pNew ){ delete pStart; pStart = pNew; } +const SwPosition *GetStart() const { return m_pStart.get(); } +void SetStart(SwPosition* pNew) { m_pStart.reset(pNew); } -const SwPosition *GetCurr() const { return pCurr; } -void SetCurr( SwPosition* pNew ){ delete pCurr; pCurr = pNew; } +const SwPosition *GetCurr() const { return m_pCurr.get(); } +void SetCurr(SwPosition* pNew) { m_pCurr.reset(pNew); } -const SwPosition *GetCurrX() const { return pCurrX; } -void SetCurrX( SwPosition* pNew ){ delete pCurrX; pCurrX = pNew; } +const SwPosition *GetCurrX() const { return m_pCurrX.get(); } +void SetCurrX(SwPosition* pNew) { m_pCurrX.reset(pNew); } sal_uInt16& GetCursorCnt(){ return nCursorCnt; } @@ -181,10 +181,6 @@ static SwHyphIter* g_pHyphIter = nullptr; SwLinguIter::SwLinguIter() : pSh(nullptr) -, pStart(nullptr) -, pEnd(nullptr) -, pCurr(nullptr) -, pCurrX(nullptr) , nCursorCnt(0) { // TODO missing: ensurance of re-entrance, OSL_ENSURE( etc. @@ -203,7 +199,7 @@ void SwLinguIter::Start_( SwEditShell *pShell, SwDocPositions eStart, SET_CURR_SHELL( pSh ); -OSL_ENSURE( !pEnd, "SwLinguIter::Start_ without End?"); +OSL_ENSURE(!m_pEnd, "SwLinguIter::Start_ without End?"); SwPaM *pCursor = pSh->GetCursor(); @@ -235,8 +231,8 @@ void SwLinguIter::Start_( SwEditShell *pShell, SwDocPositions eStart, if ( *pCursor->GetPoint() > *pCursor->GetMark() ) pCursor->Exchange(); -pStart = new SwPosition( *pCursor->GetPoint() ); -pEnd = new SwPosition( *pCursor->GetMark() ); +m_pStart.reset(new SwPosition(*pCursor->GetPoint())); +m_pEnd.reset(new SwPosition(*pCursor->GetMark())); if( bSetCurr ) { SwPosition* pNew = new SwPosition( *GetStart() ); @@ -253,7 +249,7 @@ void SwLinguIter::End_(bool bRestoreSelection) if( !pSh ) return; -OSL_ENSURE( pEnd, "SwLinguIter::End_ without end?"); +OSL_ENSURE(m_pEnd, "SwLinguIter::End_ without end?"); if(bRestoreSelection) { while( nCursorCnt-- ) @@ -262,10 +258,10 @@ void SwLinguIter::End_(bool bRestoreSelection) pSh->KillPams(); pSh->ClearMark(); } -DELETEZ(pStart); -DELETEZ(pEnd); -DELETEZ(pCurr); -DELETEZ(pCurrX); +m_pStart.reset(); +m_pEnd.reset(); +m_pCurr.reset(); +m_pCurrX.reset(); pSh = nullptr; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/objserv.cxx | 49 ++-- 1 file changed, 29 insertions(+), 20 deletions(-) New commits: commit 0950917b9514069e8dbf92b9c0fbd44b492a7cd1 Author: Henry CastroDate: Thu Mar 1 16:11:44 2018 -0400 lokdialog: convert the dialog File -> Properties... to async exec Change-Id: I677760e9b154256c00ea4e99fd40204744f3cd21 Reviewed-on: https://gerrit.libreoffice.org/50600 Tested-by: Jenkins Reviewed-by: Henry Castro diff --git a/sfx2/source/doc/objserv.cxx b/sfx2/source/doc/objserv.cxx index c69cbe927643..aaf71fb25586 100644 --- a/sfx2/source/doc/objserv.cxx +++ b/sfx2/source/doc/objserv.cxx @@ -468,30 +468,39 @@ void SfxObjectShell::ExecFile_Impl(SfxRequest ) // creating dialog is done via virtual method; application will // add its own statistics page -ScopedVclPtr pDlg(CreateDocumentInfoDialog(aSet)); -if ( RET_OK == pDlg->Execute() ) +VclAbstractDialog::AsyncContext aCtx; +std::shared_ptr pReq = std::make_shared(rReq); +VclPtr pDlg(CreateDocumentInfoDialog(aSet)); + +aCtx.mxOwner = pDlg; +aCtx.maEndDialogFn = [this, pDlg, xCmisDoc, pReq](sal_Int32 nResult) { -const SfxDocumentInfoItem* pDocInfoItem = SfxItemSet::GetItem(pDlg->GetOutputItemSet(), SID_DOCINFO, false); -if ( pDocInfoItem ) +if (RET_OK == nResult) { -// user has done some changes to DocumentInfo -pDocInfoItem->UpdateDocumentInfo(getDocProperties()); -uno::Sequence< document::CmisProperty > aNewCmisProperties = -pDocInfoItem->GetCmisProperties( ); -if ( aNewCmisProperties.getLength( ) > 0 ) -xCmisDoc->updateCmisProperties( aNewCmisProperties ); -SetUseUserData( pDocInfoItem->IsUseUserData() ); -SetUseThumbnailSave( pDocInfoItem-> IsUseThumbnailSave() ); -// add data from dialog for possible recording purpose -rReq.AppendItem( SfxDocumentInfoItem( GetTitle(), -getDocProperties(), aNewCmisProperties, IsUseUserData(), IsUseThumbnailSave() ) ); +const SfxDocumentInfoItem* pDocInfoItem = SfxItemSet::GetItem(pDlg->GetOutputItemSet(), SID_DOCINFO, false); +if ( pDocInfoItem ) +{ +// user has done some changes to DocumentInfo + pDocInfoItem->UpdateDocumentInfo(getDocProperties()); +uno::Sequence< document::CmisProperty > aNewCmisProperties = +pDocInfoItem->GetCmisProperties( ); +if ( aNewCmisProperties.getLength( ) > 0 ) +xCmisDoc->updateCmisProperties( aNewCmisProperties ); +SetUseUserData( pDocInfoItem->IsUseUserData() ); +SetUseThumbnailSave( pDocInfoItem-> IsUseThumbnailSave() ); +// add data from dialog for possible recording purpose +pReq->AppendItem( SfxDocumentInfoItem( GetTitle(), +getDocProperties(), aNewCmisProperties, IsUseUserData(), IsUseThumbnailSave() ) ); +} +pReq->Done(); } +else +// nothing done; no recording +pReq->Ignore(); +}; -rReq.Done(); -} -else -// nothing done; no recording -rReq.Ignore(); +pDlg->StartExecuteAsync(aCtx); +rReq.Ignore(); } return; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 52586] Mail Merge doesn' t seem to respect a standard data sources filter - steps in Comment 4 ( workaround: use filter in address list)
https://bugs.documentfoundation.org/show_bug.cgi?id=52586 --- Comment #14 from Nicolas R--- (In reply to Timur from comment #13) > This bug is about standard data sources filter. Looks like there's a > workaround: use filter in Select address list, step 3. of Mail Merge Wizard. Yes, but it's a workaround only for filter, no workaround for sorting. It will be really fine if the buttons in the Mail Merge toolbar could use filter / sort options of DataSources toolbar ... and less unsettling -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116093] FILESAVE: Set Microsoft format as a default saving format currently work only for Writer !!
https://bugs.documentfoundation.org/show_bug.cgi?id=116093 Timurchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #2 from Timur --- Not a bug. Each program is handled differently. Please don't report a bug unless you are certain it is. If not, first use ask.libreoffice.org. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115491] Paragraph borders L and R detached with line spacing > 1
https://bugs.documentfoundation.org/show_bug.cgi?id=115491 --- Comment #3 from Buovjaga--- Repro steps with hallo world in 5.4 alpha0 do not yet show the problem. Note: the example file actually shows another, newer bug that is not yet in 6.0.1. In 6.1 you can see there is a gap in the borders of all but the first example. Let's wait for bibisecters before going into that further. Sadly my Windows VM is running out of space so I can't pull in the bibisect repo of 6.0 branch point. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111527] I can't extract Pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=111527 Timurchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INVALID --- Comment #10 from Timur --- OK. What we have here is invalid bug report that says that error happens only sometimes. Bug must be reproducible and there are no steps here. I'll close as Invalid. If you experience it again, please set back to Unconfirmed. If you get an error please write down exact error. But you need to know whether it happens with a specific file and attach at or with any file. You have to be sure it's not a local problem with a computer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116098] Shortcut for recording changes doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=116098 --- Comment #8 from Zetok--- (In reply to Alex ARNAUD from comment #5) > (In reply to Zetok from comment #3) > > After downgrading LO to 5.4.5.1 with GTK2 ctrl+shift+e works again. > > Where do you download the 5.4.5 versions? Can you check on the about dialog > if the VCL is GTK2 or GTK3. If I install the 5.4.5 version of LibreOffice > from TDF I'm with the GTK2 vcl so the issue doesn't occur. > > Best regards. I've downgraded LO from Gentoo ~testing (6.0.1.1) to stable (5.4.5.1). The about dialog in LO 5.4.5.1 does show that GTK2 is used. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111665] "Data" -> "Validity": represent boolean values with a checkbox
https://bugs.documentfoundation.org/show_bug.cgi?id=111665 c.bu...@posteo.jp changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #6 from c.bu...@posteo.jp --- Your provided workaround doesn't fit my needs. My request was for a real checkbox to represent boolean values in a cell. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66597] Problems with copying and extracting text from generated PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=66597 Timurchanged: What|Removed |Added CC||dani3l.grigo...@gmail.com --- Comment #34 from Timur --- *** Bug 116056 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs