[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - loleaflet/src

2018-12-11 Thread Libreoffice Gerrit user
 loleaflet/src/control/Signing.js |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 7eb217af7fcd0d46f92ef20645156cd18e442de1
Author: Szymon Kłos 
AuthorDate: Tue Dec 11 17:08:37 2018 +0100
Commit: Andras Timar 
CommitDate: Wed Dec 12 08:58:12 2018 +0100

Don't show '<<' button in the signing toolbar

Change-Id: Ie178add1812735ac4653b0aedab58f70a8b6f0e8
(cherry picked from commit 375a1a60789a1871b0209f4699680f48410c5a40)

diff --git a/loleaflet/src/control/Signing.js b/loleaflet/src/control/Signing.js
index d4113cc67..78066279f 100644
--- a/loleaflet/src/control/Signing.js
+++ b/loleaflet/src/control/Signing.js
@@ -272,6 +272,11 @@ L.Map.include({
oldtoolbarSize = $('#document-container').css('top');
 
$('#document-container').css('top', '110px');
+
+   // Avoid scroll button ">>"
+   var el = w2ui['document-signing-bar'];
+   if (el)
+   el.resize();
},
hideSignDocument: function() {
$('#document-signing-bar').hide();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122033] AutoCorrect

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122033

Dieter Praas  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter Praas  ---
Thank you for reporting the bug. To be certain the reported issue is not
related to corruption in the user profile, could you please reset your
Libreoffice profile (https://wiki.documentfoundation.org/UserProfile) and
re-test?

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the issue is still present

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: chart2/source

2018-12-11 Thread Libreoffice Gerrit user
 chart2/source/tools/ThreeDHelper.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 06d77084228e16a68a6da37f182be282be2fa946
Author: Andrea Gelmini 
AuthorDate: Mon Dec 10 15:37:06 2018 +0100
Commit: Julien Nabet 
CommitDate: Wed Dec 12 08:24:47 2018 +0100

Fix typo

Change-Id: I2914579b935a7e755626493d043618555b91
Reviewed-on: https://gerrit.libreoffice.org/64997
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/chart2/source/tools/ThreeDHelper.cxx 
b/chart2/source/tools/ThreeDHelper.cxx
index 067642e5a149..b6e91156fbab 100644
--- a/chart2/source/tools/ThreeDHelper.cxx
+++ b/chart2/source/tools/ThreeDHelper.cxx
@@ -976,7 +976,7 @@ void ThreeDHelper::setRotationAngleToDiagram(
 
 try
 {
-//remind old rotation for adaption of light directions
+//remind old rotation for adaptation of light directions
 ::basegfx::B3DHomMatrix aInverseOldRotation( 
lcl_getInverseRotationMatrix( xSceneProperties ) );
 
 ::basegfx::B3DHomMatrix aInverseCameraRotation;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84837

AOL Support  changed:

   What|Removed |Added

URL||https://www.800customerserv
   ||icenumber.com/aol-phone-num
   ||ber/

--- Comment #123 from AOL Support  ---
 if you can access the expert’s advice by making a single call, that is not
going to cost you anything. What else could be the best option than this? Next
time whenever you see any AOL email error, contact us via email or call at our
toll-free number 800-329-1530
https://www.800customerservicenumber.com/aol-phone-number/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 77044] FILEOPEN : Incorrect docX import (frames border)

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77044

--- Comment #15 from jmgigan...@libertysurf.fr ---
Bug still present in 6.1.3.2 (Win 7 Pro X64)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/sfx2 sc/source sfx2/source

2018-12-11 Thread Libreoffice Gerrit user
 include/sfx2/app.hxx|2 +-
 include/sfx2/childwin.hxx   |6 +++---
 include/sfx2/module.hxx |2 +-
 sc/source/ui/inc/ChildWindowWrapper.hxx |4 ++--
 sfx2/source/appl/appchild.cxx   |8 
 sfx2/source/appl/childwin.cxx   |4 ++--
 sfx2/source/appl/childwinimpl.cxx   |4 ++--
 sfx2/source/appl/module.cxx |4 ++--
 sfx2/source/dialog/dockwin.cxx  |4 ++--
 sfx2/source/inc/childwinimpl.hxx|2 +-
 10 files changed, 20 insertions(+), 20 deletions(-)

New commits:
commit 0dd025a2180e7fb1bf27a71687769a61d608abf2
Author: Noel Grandin 
AuthorDate: Tue Dec 11 12:59:35 2018 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 12 07:31:12 2018 +0100

use unique_ptr for SfxChildWinFactory

Change-Id: I4305310ea296a5326838759742b14e687158d426
Reviewed-on: https://gerrit.libreoffice.org/64954
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/sfx2/app.hxx b/include/sfx2/app.hxx
index 701fa90475b3..27653aed3e98 100644
--- a/include/sfx2/app.hxx
+++ b/include/sfx2/app.hxx
@@ -190,7 +190,7 @@ public:
 SAL_DLLPRIVATE SfxAppData_Impl* Get_Impl() const { return pImpl.get(); }
 
 // Object-Factories/global arrays
-SAL_DLLPRIVATE void RegisterChildWindow_Impl(SfxModule*, 
SfxChildWinFactory*);
+SAL_DLLPRIVATE void RegisterChildWindow_Impl(SfxModule*, 
std::unique_ptr);
 SAL_DLLPRIVATE void RegisterChildWindowContext_Impl(SfxModule*, 
sal_uInt16, std::unique_ptr);
 SAL_DLLPRIVATE void RegisterStatusBarControl_Impl(SfxModule*, 
const SfxStbCtrlFactory&);
 SAL_DLLPRIVATE void RegisterToolBoxControl_Impl( SfxModule*, const 
SfxTbxCtrlFactory&);
diff --git a/include/sfx2/childwin.hxx b/include/sfx2/childwin.hxx
index 74efab5857de..3ddc7a377dae 100644
--- a/include/sfx2/childwin.hxx
+++ b/include/sfx2/childwin.hxx
@@ -191,7 +191,7 @@ public:
 virtual SfxChildWinInfo GetInfo() const;
 voidSaveStatus(const SfxChildWinInfo& rInfo);
 
-static void RegisterChildWindow(SfxModule*, SfxChildWinFactory*);
+static void RegisterChildWindow(SfxModule*, 
std::unique_ptr);
 
 static SfxChildWindow* CreateChildWindow( sal_uInt16, vcl::Window*, 
SfxBindings*, SfxChildWinInfo const &);
 voidSetHideNotDelete( bool bOn );
@@ -266,11 +266,11 @@ public:
 } \
 voidClass::RegisterChildWindow (bool bVis, SfxModule *pMod, 
SfxChildWindowFlags nFlags)   \
 {   \
-SfxChildWinFactory *pFact = new SfxChildWinFactory( \
+auto pFact = o3tl::make_unique( \
 Class::CreateImpl, MyID, Pos );   \
 pFact->aInfo.nFlags |= nFlags;  \
 pFact->aInfo.bVisible = bVis; \
-SfxChildWindow::RegisterChildWindow(pMod, pFact); \
+SfxChildWindow::RegisterChildWindow(pMod, 
std::move(pFact)); \
 }
 
 #define SFX_IMPL_POS_CHILDWINDOW_WITHID(Class, MyID, Pos) \
diff --git a/include/sfx2/module.hxx b/include/sfx2/module.hxx
index 842cab05e4e8..5709e4a90fbb 100644
--- a/include/sfx2/module.hxx
+++ b/include/sfx2/module.hxx
@@ -75,7 +75,7 @@ public:
 SfxSlotPool*GetSlotPool() const;
 
 voidRegisterToolBoxControl(const 
SfxTbxCtrlFactory&);
-voidRegisterChildWindow(SfxChildWinFactory*);
+void
RegisterChildWindow(std::unique_ptr);
 voidRegisterStatusBarControl(const 
SfxStbCtrlFactory&);
 
 virtual VclPtr  CreateTabPage( sal_uInt16 nId,
diff --git a/sc/source/ui/inc/ChildWindowWrapper.hxx 
b/sc/source/ui/inc/ChildWindowWrapper.hxx
index 1f4920d7a566..db6d0c70f73e 100644
--- a/sc/source/ui/inc/ChildWindowWrapper.hxx
+++ b/sc/source/ui/inc/ChildWindowWrapper.hxx
@@ -53,10 +53,10 @@ public:
 SfxModule* pModule  = nullptr,
 SfxChildWindowFlags nFlags = SfxChildWindowFlags::NONE)
 {
-SfxChildWinFactory* pFactory = new 
SfxChildWinFactory(ChildWindowWrapper::CreateImpl, WindowID, CHILDWIN_NOPOS );
+auto pFactory = 
o3tl::make_unique(ChildWindowWrapper::CreateImpl, WindowID, 
CHILDWIN_NOPOS );
 pFactory->aInfo.nFlags |= nFlags;
 pFactory->aInfo.bVisible = bVisible;
-SfxChildWindow::RegisterChildWindow(pModule, pFactory);
+SfxChildWindow::RegisterChildWindow(pModule, std::move(pFactory));
 }
 
 virtual SfxChildWinInfo GetInfo() const override
diff --git a/sfx2/source/appl/appchild.cxx b/sfx2/source/appl/appchild.cxx
index 6003a8c547fb..05a0f185ab40 100644
--- a/sfx2/source/appl/appchild.cxx
+++ b/sfx2/source/appl/appchild.cxx
@@ -35,11 +35,11 @@
 #include 
 
 
-void SfxApplication::RegisterChildWindow_Impl( SfxModule *pMod, 
SfxChildWinFactory 

[Libreoffice-bugs] [Bug 122033] New: AutoCorrect

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122033

Bug ID: 122033
   Summary: AutoCorrect
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stefanschran...@yahoo.de

Description:


AutoCorrect is amazing! Makes Libre Office very attractive. 
But it does not save the auto-correct library after shut down Libre Office.
Why not?
thanks and Respect for that great work of Libre Office

kind regards
Stefan 

Actual Results:
But it does not save the auto-correct library after shut down Libre Office.


Expected Results:
to save the But it does not save the auto-correct library after shut down



Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: editeng/source include/editeng

2018-12-11 Thread Libreoffice Gerrit user
 editeng/source/editeng/editeng.cxx  |3 +--
 editeng/source/editeng/impedit.cxx  |   10 +-
 editeng/source/editeng/impedit.hxx  |2 +-
 editeng/source/editeng/impedit3.cxx |6 +++---
 editeng/source/items/numitem.cxx|   13 ++---
 editeng/source/uno/unotext.cxx  |   27 +--
 include/editeng/numitem.hxx |2 +-
 7 files changed, 30 insertions(+), 33 deletions(-)

New commits:
commit d4fac095361f9d0c08091ba19c3fb167850be6b8
Author: Noel Grandin 
AuthorDate: Tue Dec 11 12:45:04 2018 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 12 07:29:04 2018 +0100

loplugin:useuniqueptr in editeng

Change-Id: I1172359ed57e5f19e7d3d7af30e6fbf8e54d9e75
Reviewed-on: https://gerrit.libreoffice.org/64950
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/editeng/source/editeng/editeng.cxx 
b/editeng/source/editeng/editeng.cxx
index 89ee759b63f8..c67df5641d65 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -1706,14 +1706,13 @@ void EditEngine::InsertParagraph(sal_Int32 nPara, const 
OUString& rTxt)
 
 void EditEngine::SetText(sal_Int32 nPara, const OUString& rTxt)
 {
-EditSelection* pSel = pImpEditEngine->SelectParagraph( nPara );
+std::unique_ptr pSel = pImpEditEngine->SelectParagraph( 
nPara );
 if ( pSel )
 {
 pImpEditEngine->UndoActionStart( EDITUNDO_INSERT );
 pImpEditEngine->ImpInsertText( *pSel, rTxt );
 pImpEditEngine->UndoActionEnd();
 pImpEditEngine->FormatAndUpdate();
-delete pSel;
 }
 }
 
diff --git a/editeng/source/editeng/impedit.cxx 
b/editeng/source/editeng/impedit.cxx
index 390f524ddab4..66cf4b6a347f 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -236,7 +236,7 @@ void ImpEditView::DrawSelectionXOR( EditSelection aTmpSel, 
vcl::Region* pRegion,
 bool bClipRegion = pTarget->IsClipRegion();
 vcl::Region aOldRegion = pTarget->GetClipRegion();
 
-tools::PolyPolygon* pPolyPoly = nullptr;
+std::unique_ptr pPolyPoly;
 
 if ( !pRegion )
 {
@@ -260,7 +260,7 @@ void ImpEditView::DrawSelectionXOR( EditSelection aTmpSel, 
vcl::Region* pRegion,
 }
 else
 {
-pPolyPoly = new tools::PolyPolygon;
+pPolyPoly.reset(new tools::PolyPolygon);
 }
 
 DBG_ASSERT( !pEditEngine->IsIdleFormatterActive(), "DrawSelectionXOR: Not 
formatted!" );
@@ -339,7 +339,7 @@ void ImpEditView::DrawSelectionXOR( EditSelection aTmpSel, 
vcl::Region* pRegion,
 Range aLineXPosStartEnd = 
pEditEngine->GetLineXPosStartEnd(pTmpPortion, );
 aTopLeft.setX( aLineXPosStartEnd.Min() );
 aBottomRight.setX( aLineXPosStartEnd.Max() );
-ImplDrawHighlightRect( pTarget, aTopLeft, aBottomRight, 
pPolyPoly );
+ImplDrawHighlightRect( pTarget, aTopLeft, aBottomRight, 
pPolyPoly.get() );
 }
 else
 {
@@ -360,7 +360,7 @@ void ImpEditView::DrawSelectionXOR( EditSelection aTmpSel, 
vcl::Region* pRegion,
 Point aPt1( std::min( nX1, nX2 ), aTopLeft.Y() );
 Point aPt2( std::max( nX1, nX2 ), aBottomRight.Y() );
 
-ImplDrawHighlightRect( pTarget, aPt1, aPt2, pPolyPoly );
+ImplDrawHighlightRect( pTarget, aPt1, aPt2, 
pPolyPoly.get() );
 
 nTmpStartIndex = nTmpEndIndex;
 }
@@ -464,7 +464,7 @@ void ImpEditView::DrawSelectionXOR( EditSelection aTmpSel, 
vcl::Region* pRegion,
 pOutWin->Pop();
 }
 
-delete pPolyPoly;
+pPolyPoly.reset();
 }
 else
 {
diff --git a/editeng/source/editeng/impedit.hxx 
b/editeng/source/editeng/impedit.hxx
index 2ef1ea099c60..b85046088c41 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -868,7 +868,7 @@ public:
 //  OV-Special
 voidInvalidateFromParagraph( sal_Int32 nFirstInvPara );
 EditPaM InsertParagraph( sal_Int32 nPara );
-EditSelection*  SelectParagraph( sal_Int32 nPara );
+std::unique_ptr SelectParagraph( sal_Int32 nPara );
 
 voidSetStatusEventHdl( const Link& rLink ) 
{ aStatusHdlLink = rLink; }
 const Link& GetStatusEventHdl() const   { 
return aStatusHdlLink; }
diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index ee2b003fc46d..05a386dedea9 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -4174,13 +4174,13 @@ EditPaM ImpEditEngine::InsertParagraph( sal_Int32 nPara 
)
 return ImpInsertParaBreak( aPaM );
 }
 
-EditSelection* ImpEditEngine::SelectParagraph( sal_Int32 nPara )
+std::unique_ptr ImpEditEngine::SelectParagraph( sal_Int32 nPara 
)
 {
-EditSelection* pSel = nullptr;
+std::unique_ptr pSel;
 ContentNode* pNode = GetEditDoc().GetObject( nPara );
 

[Libreoffice-commits] core.git: basic/source framework/source

2018-12-11 Thread Libreoffice Gerrit user
 basic/source/classes/sbxmod.cxx|   12 ++--
 framework/source/fwe/classes/addonsoptions.cxx |   15 +++
 2 files changed, 13 insertions(+), 14 deletions(-)

New commits:
commit 30eb0839c59d8066d130ea3f25b605d9f6276eb9
Author: Noel Grandin 
AuthorDate: Tue Dec 11 09:11:14 2018 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 12 07:28:49 2018 +0100

loplugin:useuniqueptr in basic and framework

Change-Id: I409c9c572eb8f3d68c8a387844b43988b4ab5c32
Reviewed-on: https://gerrit.libreoffice.org/64949
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index db86e597b12b..69343b6d7552 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -1105,12 +1105,12 @@ void SbModule::Run( SbMethod* pMeth )
 
 SbModule* pOldMod = GetSbData()->pMod;
 GetSbData()->pMod = this;
-SbiRuntime* pRt = new SbiRuntime( this, pMeth, pMeth->nStart );
+std::unique_ptr pRt(new SbiRuntime( this, pMeth, 
pMeth->nStart ));
 
 pRt->pNext = GetSbData()->pInst->pRun;
 if( pRt->pNext )
 pRt->pNext->block();
-GetSbData()->pInst->pRun = pRt;
+GetSbData()->pInst->pRun = pRt.get();
 if ( mbVBACompat )
 {
 GetSbData()->pInst->EnableCompatibility( true );
@@ -1144,7 +1144,7 @@ void SbModule::Run( SbMethod* pMeth )
 if( pRtNext && (pRt->GetDebugFlags() & BasicDebugFlags::Break) )
 pRtNext->SetDebugFlags( BasicDebugFlags::Break );
 
-delete pRt;
+pRt.reset();
 GetSbData()->pMod = pOldMod;
 if( bDelInst )
 {
@@ -1223,14 +1223,14 @@ void SbModule::RunInit()
 SbModule* pOldMod = GetSbData()->pMod;
 GetSbData()->pMod = this;
 // The init code starts always here
-SbiRuntime* pRt = new SbiRuntime( this, nullptr, 0 );
+std::unique_ptr pRt(new SbiRuntime( this, nullptr, 0 ));
 
 pRt->pNext = GetSbData()->pInst->pRun;
-GetSbData()->pInst->pRun = pRt;
+GetSbData()->pInst->pRun = pRt.get();
 while( pRt->Step() ) {}
 
 GetSbData()->pInst->pRun = pRt->pNext;
-delete pRt;
+pRt.reset();
 GetSbData()->pMod = pOldMod;
 pImage->bInit = true;
 pImage->bFirstInit = false;
diff --git a/framework/source/fwe/classes/addonsoptions.cxx 
b/framework/source/fwe/classes/addonsoptions.cxx
index 10f0b06e67f9..2c6f33bef492 100644
--- a/framework/source/fwe/classes/addonsoptions.cxx
+++ b/framework/source/fwe/classes/addonsoptions.cxx
@@ -262,7 +262,7 @@ class AddonsOptions_Impl : public ConfigItem
 void AppendPopupMenu( Sequence< PropertyValue >& 
aTargetPopupMenu, const Sequence< PropertyValue >& rSourcePopupMenu );
 bool ReadToolBarItem( const OUString& 
aToolBarItemNodeName, Sequence< PropertyValue >& aToolBarItem );
 bool ReadStatusBarItem( const OUString& 
aStatusbarItemNodeName, Sequence< PropertyValue >& aStatusbarItem );
-ImageEntry*  ReadImageData( const OUString& aImagesNodeName );
+std::unique_ptr ReadImageData( const OUString& 
aImagesNodeName );
 void ReadAndAssociateImages( const OUString& aURL, 
const OUString& aImageId );
 ImageReadImageFromURL( const OUString& aURL );
 bool HasAssociatedImages( const OUString& aURL );
@@ -746,12 +746,11 @@ void AddonsOptions_Impl::ReadImages( ImageManager& 
aImageManager )
 OUString aImagesUserDefinedItemNode = aBuf.makeStringAndClear();
 
 // Read a user-defined images data
-ImageEntry* pImageEntry = ReadImageData( 
aImagesUserDefinedItemNode );
+std::unique_ptr pImageEntry = ReadImageData( 
aImagesUserDefinedItemNode );
 if ( pImageEntry )
 {
 // Successfully read a user-defined images item, put it into 
our image manager
-aImageManager.emplace( aURL, *pImageEntry );
-delete pImageEntry; // We have the ownership of the pointer
+aImageManager.emplace( aURL, std::move(*pImageEntry) );
 }
 }
 }
@@ -1328,14 +1327,14 @@ void AddonsOptions_Impl::ReadAndAssociateImages( const 
OUString& aURL, const OUS
 m_aImageManager.emplace( aURL, aImageEntry );
 }
 
-AddonsOptions_Impl::ImageEntry* AddonsOptions_Impl::ReadImageData( const 
OUString& aImagesNodeName )
+std::unique_ptr 
AddonsOptions_Impl::ReadImageData( const OUString& aImagesNodeName )
 {
 Sequence< OUString > aImageDataNodeNames = GetPropertyNamesImages( 
aImagesNodeName );
 Sequence< Any >  aPropertyData;
 Sequence< sal_Int8 > aImageDataSeq;
 OUString aImageURL;
 
-ImageEntry* pEntry = nullptr;
+

[Libreoffice-bugs] [Bug 112700] [META] DOC (binary) table-related issues

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112700
Bug 112700 depends on bug 121734, which changed state.

Bug 121734 Summary: Floating table from a .DOC may paste to another document 
with different frame properties
https://bugs.documentfoundation.org/show_bug.cgi?id=121734

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122032] Bold style show in auto numeric list for .docx but not must

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122032

--- Comment #2 from seven  ---
Comment on attachment 147456
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147456
Documet show bold style for all editors after save in libreoffice

Saved document s-test.docx in libreoffice and get s-test-2.docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122032] Bold style show in auto numeric list for .docx but not must

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122032

--- Comment #1 from seven  ---
Created attachment 147456
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147456=edit
Documet show bold style for all editors after save in libreoffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122032] New: Bold style show in auto numeric list for .docx but not must

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122032

Bug ID: 122032
   Summary: Bold style show in auto numeric list for .docx but not
must
   Product: LibreOffice
   Version: 6.1.4.1 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: seve...@mail.ru

Created attachment 147455
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147455=edit
Test document where bold style showed only in LibreOffice

See document s-test.docx
Item 1.2 in first column and 1.1 in second column is bold, but not must be (i
need original normal style font)

If save document in s-test-2.docx bold style will be visible for MS office and
LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/CppunitTest_sw_ww8import.mk sw/qa sw/source

2018-12-11 Thread Libreoffice Gerrit user
 sw/CppunitTest_sw_ww8import.mk|1 
 sw/qa/extras/ww8import/data/tdf121734.doc |binary
 sw/qa/extras/ww8import/ww8import.cxx  |   43 ++
 sw/source/filter/ww8/ww8par.cxx   |4 --
 sw/source/filter/ww8/ww8par4.cxx  |3 --
 sw/source/filter/ww8/ww8par6.cxx  |6 +---
 6 files changed, 47 insertions(+), 10 deletions(-)

New commits:
commit d398e9248c183cf988b6d985b342b0cbff93ea02
Author: Mike Kaganski 
AuthorDate: Wed Dec 12 00:31:13 2018 +0300
Commit: Mike Kaganski 
CommitDate: Wed Dec 12 05:51:53 2018 +0100

tdf#121734: ww8 import: use direct formatting for floating object frames

... and don't modify standard frame styles to have no borders and padding.
This makes "Frame", "OLE", and "Graphics" frame styles of imported DOC
files to have usual settings (for "Frame", it's 1.5 mm padding and all
borders set to 0.05 pt black line).

All objects that need invisible frame will have them with all necessary
settings set explicitly, which allows to copy and paste such frames to
other documents without problems.

This makes DOC import aligned with DOCX import in this regard.

Change-Id: I6f05cf71e63ceccb8e0ddebe23ec41bf69af9b52
Reviewed-on: https://gerrit.libreoffice.org/64992
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/CppunitTest_sw_ww8import.mk b/sw/CppunitTest_sw_ww8import.mk
index 1ccc1a3f20aa..bb73e4230da0 100644
--- a/sw/CppunitTest_sw_ww8import.mk
+++ b/sw/CppunitTest_sw_ww8import.mk
@@ -19,6 +19,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sw_ww8import, \
 comphelper \
 cppu \
 cppuhelper \
+editeng \
 sal \
 test \
 unotest \
diff --git a/sw/qa/extras/ww8import/data/tdf121734.doc 
b/sw/qa/extras/ww8import/data/tdf121734.doc
new file mode 100644
index ..11a9bf503ca5
Binary files /dev/null and b/sw/qa/extras/ww8import/data/tdf121734.doc differ
diff --git a/sw/qa/extras/ww8import/ww8import.cxx 
b/sw/qa/extras/ww8import/ww8import.cxx
index de16cfe253e6..cd07887669bd 100644
--- a/sw/qa/extras/ww8import/ww8import.cxx
+++ b/sw/qa/extras/ww8import/ww8import.cxx
@@ -13,6 +13,9 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 
 class Test : public SwModelTestBase
 {
@@ -147,6 +150,46 @@ DECLARE_WW8IMPORT_TEST(testTdf112346, "tdf112346.doc")
 CPPUNIT_ASSERT_EQUAL(static_cast(0), xDrawPage->getCount());
 }
 
+DECLARE_WW8IMPORT_TEST(testTdf121734, "tdf121734.doc")
+{
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+SwDoc* pDoc = pTextDoc->GetDocShell()->GetDoc();
+SwPosFlyFrames aPosFlyFrames = pDoc->GetAllFlyFormats(nullptr, false);
+// There is only one fly frame in the document: the one with the imported 
floating table
+CPPUNIT_ASSERT_EQUAL(size_t(1), aPosFlyFrames.size());
+for (const auto& rPosFlyFrame : aPosFlyFrames)
+{
+const SwFrameFormat& rFormat = rPosFlyFrame->GetFormat();
+const SfxPoolItem* pItem = nullptr;
+
+// The LR and UL spacings and borders must all be set explicitly;
+// spacings and border distances must be 0; borders must be absent.
+
+CPPUNIT_ASSERT_EQUAL(SfxItemState::SET, 
rFormat.GetItemState(RES_LR_SPACE, false, ));
+auto pLR = static_cast(pItem);
+CPPUNIT_ASSERT(pLR);
+CPPUNIT_ASSERT_EQUAL(long(0), pLR->GetLeft());
+CPPUNIT_ASSERT_EQUAL(long(0), pLR->GetRight());
+
+CPPUNIT_ASSERT_EQUAL(SfxItemState::SET, 
rFormat.GetItemState(RES_UL_SPACE, false, ));
+auto pUL = static_cast(pItem);
+CPPUNIT_ASSERT(pUL);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0), pUL->GetUpper());
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0), pUL->GetLower());
+
+CPPUNIT_ASSERT_EQUAL(SfxItemState::SET, rFormat.GetItemState(RES_BOX, 
false, ));
+auto pBox = static_cast(pItem);
+CPPUNIT_ASSERT(pBox);
+for (auto eLine : { SvxBoxItemLine::TOP, SvxBoxItemLine::BOTTOM,
+SvxBoxItemLine::LEFT, SvxBoxItemLine::RIGHT })
+{
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0), pBox->GetDistance(eLine));
+CPPUNIT_ASSERT(!pBox->GetLine(eLine));
+}
+}
+}
+
 // tests should only be added to ww8IMPORT *if* they fail round-tripping in 
ww8EXPORT
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index b1174771c554..16c7850adce7 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -6319,12 +6319,8 @@ ErrCode WW8Reader::Read(SwDoc , const OUString& 
rBaseURL, SwPaM , cons
 rBaseURL, bNew, m_bSkipImages, *rPaM.GetPoint()));
 if (bNew)
 {
-// Remove Frame and offsets from Frame Template
-Reader::ResetFrameFormats( rDoc );
-
 rPaM.GetBound().nContent.Assign(nullptr, 0);
 

[Libreoffice-bugs] [Bug 103627] Writer ignores +

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103627

--- Comment #10 from Terrence Enger  ---
I still see the bug in dailt Linux dbgutil bibisect repository version
2018-12-11.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 72606] Consistently call Unicode Win32 functions, and define UNICODE globally

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #26 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38575] Open attached document blocks LibreOffice writer

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=38575

--- Comment #13 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104338] Issue on 2 column format header inside a table under .doc format

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104338

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104167] FILEOPEN: DOCX: 3 pages are merged into 1

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104167

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103627] Writer ignores +

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103627

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 77044] FILEOPEN : Incorrect docX import (frames border)

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77044

--- Comment #14 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 36021] FILEOPEN: Endnote first number placed in wrong position

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36021

--- Comment #19 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 79737] FILESAVE: DOCX: Bibliographic fonts not exported

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=79737

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93675] docx: Diagram export working but when opened with Word displayed differently than in LO

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93675

--- Comment #18 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85237] FORMATTING: wrong color in a text (.doc file)

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=85237

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 79313] DOCX: Line breaks disappear in exported SDT block

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=79313

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 75057] [META] OOXML Chart object issues

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=75057

Aron Budea  changed:

   What|Removed |Added

 Depends on||122031


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=122031
[Bug 122031] FILESAVE Percentage format in pie chart not saved in XLSX format
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122031] New: FILESAVE Percentage format in pie chart not saved in XLSX format

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122031

Bug ID: 122031
   Summary: FILESAVE Percentage format in pie chart not saved in
XLSX format
   Product: LibreOffice
   Version: 4.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: filter:xlsx
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu
Blocks: 75057

Created attachment 147454
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147454=edit
Sample XLSX

The attached XLSX was created in Excel, and the percentage format is set to 3
decimals.
Save again in XLSX format in Calc, and reopen (or open in Excel).

=> Percentages are shown with no decimals, in particular:
14.286% -> 14%
28.571% -> 29%
57.143% -> 57%

Seems like percentage format doesn't get saved.
And indeed, opening the result with a version before bug 115182's fix (eg. with
6.1.0.3) shows two decimals, which is how default format was imported at that
point.

Observed using LO 6.3.0.0.alpha0+ (2018-12-11,
34d5e910adba4094bba1303284f9552028d0b019) & 4.4.0.3 / Windows 7.
In 4.0.0.3 even the imported format wasn't correct.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=75057
[Bug 75057] [META] OOXML Chart object issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105225] Color palette cannot be chosen in various places

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105225

--- Comment #76 from Jim Raykowski  ---
(In reply to Jim Raykowski from comment #75)

> The usefulness of these two background settings seem dubious to me.

After adding some needed things for new background use to the Writer/Web
portion of the patch only the uno background command portion is dubious of use
to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: CppUnit compiler support

2018-12-11 Thread Markus Mohrhard
Hey Spencer,

On Tue, Dec 11, 2018 at 12:31 PM FRISBY, SPENCER G CIV USAF AFMC 518
SMXS/MXDX  wrote:

> Hi,
>
> I was wondering if CppUnit 1.14 has support to be compiled by Green Hills
> MULTI 4.2.4 C++ compiler.
>
> If it does, could you provide me documentation that outlines the steps to
> take?
>
>
>
As I don't have access to this compiler I can not confirm or deny that the
compiler supports CppUnit 1.14. The build should only require a C++11
compliant compiler. If the compiler supports C++11 a normal ./configure
with CC and CXX set should be enough. If your compiler supports C++11 and
still fails please let me know with the corresponding failure message.

Kind regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Compiler baselines

2018-12-11 Thread Markus Mohrhard
Hey,

On Mon, Dec 10, 2018 at 6:14 PM Stephan Bergmann 
wrote:

> On 08/12/2018 19:35, Markus Mohrhard wrote:
> > Gandalf is not a CentOS based buildbot but the self-built gcc is now
> > available under "/opt/rh/devtoolset-7/root/usr/bin/gcc" to reduce the
> > differences between the different buildbots and make it easier to move
> > jobs between different jenkins VMs. The only difference is that the gcc
> > is version 8.2 instead of 7.3.
> >
> > Additionally, I have now also used the same CC and CXX setting for the
> > random config build bot
> > (
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=ceb32911f07b63fda074facba377eeb4d5946cdf).
>
> > Based on that I think gandalf can be used again for the tinderbox job
> > and therefore hopefully take a bit of load of the gerrit build machines.
>
> But shared libs and executables built with that CXX, when executed
> during the build, will pick up an older libstdc++.so.6 from the system
> (and thus fail when they use functionality not present in the old
> libstdc++ version), no?
>

Just to document it here. I have adapted ld.so.conf to contain references
to  /opt/rh/devtoolset-7/root/usr/lib and
/opt/rh/devtoolset-7/root/usr/lib64. That ensures that always the new
libstdc++ from the gcc8 build is picked up.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 122030] New: Writer program - Table Toolbar constant placing is now impossible

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122030

Bug ID: 122030
   Summary: Writer program - Table Toolbar constant placing is now
impossible
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jwo...@outlook.com

Description:
Manually opened Table Toolbar automatically turned off.

Steps to Reproduce:
1.Manually place Table Toolbar by selecting it from View - Toolbars - Table.
2.Place cursor inside table then move outside table.
3.Table Toolbar turned off automatically.

Actual Results:
Table Toolbar turned off automatically.

Expected Results:
Table Toolbar should kept opend if user placed it manually.


Reproducible: Always


User Profile Reset: No



Additional Info:
Many of Writer document composed of text and tables. Automatic opening and
disappearing of Table Toolbar makes me loose focus on work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116672] The problem of drawing trapezoidal graphs

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116672

--- Comment #11 from cson...@halmai.hu ---
Created attachment 147453
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147453=edit
group of two trapezoid to act like a single A-like trapezoid

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 116672] The problem of drawing trapezoidal graphs

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116672

--- Comment #11 from cson...@halmai.hu ---
Created attachment 147453
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147453=edit
group of two trapezoid to act like a single A-like trapezoid

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 116672] The problem of drawing trapezoidal graphs

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116672

--- Comment #10 from cson...@halmai.hu ---
There is a work-around, you can cretae a group of 
- an A-like trapezoid without text and with the desired line and area settings
- a V-like trapezoid in its middle, with the text and with "none" line and
"none" area.  

This is not ideal, just a work-around to get a shape that looks like we wanted. 

See the attachment antitrapezoid.odg

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 116672] The problem of drawing trapezoidal graphs

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116672

--- Comment #10 from cson...@halmai.hu ---
There is a work-around, you can cretae a group of 
- an A-like trapezoid without text and with the desired line and area settings
- a V-like trapezoid in its middle, with the text and with "none" line and
"none" area.  

This is not ideal, just a work-around to get a shape that looks like we wanted. 

See the attachment antitrapezoid.odg

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/inc sc/source

2018-12-11 Thread Libreoffice Gerrit user
 sc/inc/dptabres.hxx  |   14 --
 sc/source/core/data/dptabres.cxx |   37 ++---
 2 files changed, 30 insertions(+), 21 deletions(-)

New commits:
commit 3c964980da07892a02d5ac721d80558c459532d0
Author: Eike Rathke 
AuthorDate: Tue Dec 11 23:48:37 2018 +0100
Commit: Eike Rathke 
CommitDate: Wed Dec 12 01:26:01 2018 +0100

Use Welford one-pass variance algorithm for DataPilot / pivot table

... instead of the naïve algorithm. Short test case with 4 values:

107
111
113
117

 Naïve Var: -21845.33
   Welford Var: 17.314259847
VAR() two-pass: 17.3

Change-Id: I2f27ab91166551e96c0e467f41bd6e6d49b50295
Reviewed-on: https://gerrit.libreoffice.org/64993
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/inc/dptabres.hxx b/sc/inc/dptabres.hxx
index d28e192863c6..0a20f3cffa76 100644
--- a/sc/inc/dptabres.hxx
+++ b/sc/inc/dptabres.hxx
@@ -24,6 +24,7 @@
 #include "dpfilteredcache.hxx"
 #include "calcmacros.hxx"
 #include "dpitemdata.hxx"
+#include "subtotal.hxx"
 
 #include 
 #include 
@@ -144,18 +145,19 @@ struct ScDPRelativePos
 
 //  Possible values for the nCount member:
 //  (greater than 0 counts the collected values)
-const long SC_DPAGG_EMPTY=  0;  // empty during data collection
-const long SC_DPAGG_DATA_ERROR   = -1;  // error during data collection
-const long SC_DPAGG_RESULT_EMPTY = -2;  // empty result calculated
-const long SC_DPAGG_RESULT_VALID = -3;  // valid result calculated
-const long SC_DPAGG_RESULT_ERROR = -4;  // error in calculated result
+const sal_Int64 SC_DPAGG_EMPTY=  0;  // empty during data collection
+const sal_Int64 SC_DPAGG_DATA_ERROR   = -1;  // error during data collection
+const sal_Int64 SC_DPAGG_RESULT_EMPTY = -2;  // empty result calculated
+const sal_Int64 SC_DPAGG_RESULT_VALID = -3;  // valid result calculated
+const sal_Int64 SC_DPAGG_RESULT_ERROR = -4;  // error in calculated result
 
 class ScDPAggData
 {
 private:
+WelfordRunner   maWelford;
 double  fVal;
 double  fAux;
-longnCount;
+sal_Int64   nCount;
 std::unique_ptr pChild;
 std::vector mSortedValues;
 
diff --git a/sc/source/core/data/dptabres.cxx b/sc/source/core/data/dptabres.cxx
index 305f6d8ac711..d989875b7359 100644
--- a/sc/source/core/data/dptabres.cxx
+++ b/sc/source/core/data/dptabres.cxx
@@ -428,15 +428,7 @@ void ScDPAggData::Update( const ScDPValue& rNext, 
ScSubTotalFunc eFunc, const Sc
 case SUBTOTAL_FUNC_STDP:
 case SUBTOTAL_FUNC_VAR:
 case SUBTOTAL_FUNC_VARP:
-{
-// fAux is used to sum up squares
-if ( !SubTotal::SafePlus( fVal, rNext.mfValue ) )
-nCount = -1;// -1 for error
-double fAdd = rNext.mfValue;
-if ( !SubTotal::SafeMult( fAdd, rNext.mfValue ) ||
- !SubTotal::SafePlus( fAux, fAdd ) )
-nCount = -1;// -1 for error
-}
+maWelford.update( rNext.mfValue);
 break;
 case SUBTOTAL_FUNC_MED:
 {
@@ -486,14 +478,19 @@ void ScDPAggData::Calculate( ScSubTotalFunc eFunc, const 
ScDPSubTotalState& rSub
 case SUBTOTAL_FUNC_MED:
 case SUBTOTAL_FUNC_MAX:
 case SUBTOTAL_FUNC_MIN:
+bError = ( nCount <= 0 );   // no data is an error
+break;
+
 case SUBTOTAL_FUNC_STDP:
 case SUBTOTAL_FUNC_VARP:
 bError = ( nCount <= 0 );   // no data is an error
+assert(bError || nCount == 
static_cast(maWelford.getCount()));
 break;
 
 case SUBTOTAL_FUNC_STD:
 case SUBTOTAL_FUNC_VAR:
 bError = ( nCount < 2 );// need at least 2 values
+assert(bError || nCount == 
static_cast(maWelford.getCount()));
 break;
 
 default:
@@ -525,23 +522,33 @@ void ScDPAggData::Calculate( ScSubTotalFunc eFunc, const 
ScDPSubTotalState& rSub
 fResult = fVal / static_cast(nCount);
 break;
 
-//TODO: use safe mul for fVal * fVal
-
 case SUBTOTAL_FUNC_STD:
 if ( nCount >= 2 )
-fResult = sqrt((fAux - 
fVal*fVal/static_cast(nCount)) / static_cast(nCount-1));
+{
+fResult = maWelford.getVarianceSample();
+if (fResult < 0.0)
+bError = true;
+else
+fResult = sqrt( fResult);
+}
 break;
 case SUBTOTAL_FUNC_VAR:
 if ( nCount >= 2 )
-fResult = (fAux - fVal*fVal/static_cast(nCount)) / 
static_cast(nCount-1);
+fResult = 

[Libreoffice-ux-advise] [Bug 116672] The problem of drawing trapezoidal graphs

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116672

cson...@halmai.hu changed:

   What|Removed |Added

  Component|Impress |Draw

--- Comment #9 from cson...@halmai.hu ---
Now the prolem is clear but the description was quite confusing. 

First of all, I changed the Component from Impress to Draw because the attached
screenshot shows Draw and the problem is present in both.

The steps to reproduce it in Draw:
- Shape -> Insert -> Basic -> Trapezoid
- Draw a trapezoid (the lower edge will be always shorter than the upper, that
is, it looks like V rather than A)
- double click the middle of the shape
- Enter some text like "bbb"
- Turn the trapezoid from V-like to A-like, that is, the bottom edge is longer
than the upper one. IN order to do that, you can flip it vertically, rotate by
180 degrees, or drag one of horizontal edges to the opposite side of the other
horizontal edge.

Whichever way you do it, the label "bbb" will be flipped to "qqq". That is, you
cannot create a trapezoid which 
- has its longer edge on the bottom and
- the text is not flipped.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 116672] The problem of drawing trapezoidal graphs

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116672

cson...@halmai.hu changed:

   What|Removed |Added

  Component|Impress |Draw

--- Comment #9 from cson...@halmai.hu ---
Now the prolem is clear but the description was quite confusing. 

First of all, I changed the Component from Impress to Draw because the attached
screenshot shows Draw and the problem is present in both.

The steps to reproduce it in Draw:
- Shape -> Insert -> Basic -> Trapezoid
- Draw a trapezoid (the lower edge will be always shorter than the upper, that
is, it looks like V rather than A)
- double click the middle of the shape
- Enter some text like "bbb"
- Turn the trapezoid from V-like to A-like, that is, the bottom edge is longer
than the upper one. IN order to do that, you can flip it vertically, rotate by
180 degrees, or drag one of horizontal edges to the opposite side of the other
horizontal edge.

Whichever way you do it, the label "bbb" will be flipped to "qqq". That is, you
cannot create a trapezoid which 
- has its longer edge on the bottom and
- the text is not flipped.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sw/source

2018-12-11 Thread Libreoffice Gerrit user
 sw/source/uibase/app/apphdl.cxx |   17 -
 1 file changed, 16 insertions(+), 1 deletion(-)

New commits:
commit 1ae5f5274011e42dfa85dca5f472ff8bbeecaa4e
Author: Mike Kaganski 
AuthorDate: Thu Dec 6 23:36:04 2018 +0300
Commit: Thorsten Behrens 
CommitDate: Wed Dec 12 00:46:22 2018 +0100

tdf#121606: displaying Mail Merge toolbar shouldn't activate connection

At least I think so. Thus now the code that queries the state of the
toolbar controls only queries dataset if connection is active.

Operating the navigation buttons (next/prev) will, naturally, activate
connection if not yet active. This should also enable the other controls
that may be initially disabled: create/save/print/email documents. Thus,
the navigation controls also check if they have activated the connection,
and invalidate said document creation controls state. Possibly there's a
better place for the invalidation of the controls, but I was unable to
find one.

Regression after commit 5c2c5ff01c23e4f7a8947746afc13a46cbef5bec

Change-Id: I76f895c871718c9c761339ba03963baf6837b592
Reviewed-on: https://gerrit.libreoffice.org/64738
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
(cherry picked from commit 60714a814847f6d10f00aa6809a3896a48741e0b)
Reviewed-on: https://gerrit.libreoffice.org/64746
Reviewed-by: Katarina Behrens 
(cherry picked from commit b27a9058c706d70adddc71544b74b1f9607185bb)
Reviewed-on: https://gerrit.libreoffice.org/64959
Reviewed-by: Thorsten Behrens 

diff --git a/sw/source/uibase/app/apphdl.cxx b/sw/source/uibase/app/apphdl.cxx
index 8bd7c3b62a63..5ffb6f06c4ca 100644
--- a/sw/source/uibase/app/apphdl.cxx
+++ b/sw/source/uibase/app/apphdl.cxx
@@ -187,7 +187,8 @@ void SwModule::StateOther(SfxItemSet )
 xConfigItem = pView->GetMailMergeConfigItem();
 if (!xConfigItem)
 rSet.DisableItem(nWhich);
-else
+else if (xConfigItem->GetConnection().is()
+ && !xConfigItem->GetConnection()->isClosed())
 {
 bool bFirst, bLast;
 bool bValid = xConfigItem->IsResultSetFirstLast(bFirst, 
bLast);
@@ -240,6 +241,8 @@ void SwModule::StateOther(SfxItemSet )
 // #i51949# hide e-Mail option if e-Mail is not supported
 // #i63267# printing might be disabled
 if (!xConfigItem ||
+!xConfigItem->GetConnection().is() ||
+xConfigItem->GetConnection()->isClosed() ||
 !xConfigItem->GetResultSet().is() ||
 xConfigItem->GetCurrentDBData().sDataSource.isEmpty() ||
 xConfigItem->GetCurrentDBData().sCommand.isEmpty() ||
@@ -778,6 +781,9 @@ void SwModule::ExecOther(SfxRequest& rReq)
 if (!xConfigItem)
 return;
 
+const bool bHadConnection
+= xConfigItem->GetConnection().is() && 
!xConfigItem->GetConnection()->isClosed();
+
 sal_Int32 nPos = xConfigItem->GetResultSetPosition();
 switch (nWhich)
 {
@@ -815,6 +821,15 @@ void SwModule::ExecOther(SfxRequest& rReq)
 rBindings.Invalidate(FN_MAILMERGE_LAST_ENTRY);
 rBindings.Invalidate(FN_MAILMERGE_CURRENT_ENTRY);
 rBindings.Invalidate(FN_MAILMERGE_EXCLUDE_ENTRY);
+if (!bHadConnection && xConfigItem->GetConnection().is()
+&& !xConfigItem->GetConnection()->isClosed())
+{
+// The connection has been activated. Update controls that 
were disabled
+rBindings.Invalidate(FN_MAILMERGE_CREATE_DOCUMENTS);
+rBindings.Invalidate(FN_MAILMERGE_SAVE_DOCUMENTS);
+rBindings.Invalidate(FN_MAILMERGE_PRINT_DOCUMENTS);
+rBindings.Invalidate(FN_MAILMERGE_EMAIL_DOCUMENTS);
+}
 rBindings.Update();
 }
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 118094] Firebird: Support more XResultSet functions

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118094

--- Comment #14 from Drew Jensen  ---
Created attachment 147452
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147452=edit
added a line in macro for each xResultSet function and some properties

So, using LO 6.2Beta1 these functions and properties of XResultSet are working
with firebird:
isBeforeFirst
isAfterLast
isFirst
first
getRow
relative( long > 0 ) error with negative numbers
FetchDirection
FetchSize
ResultSetConcurrency
ResultSetType

While these are not:
CursorName 
isLast 
beforeFirst
afterLast
last
absolute( long )
previous
refreshRow
rowUpdated
rowInserted
rowDeleted

Of those refreshRow, and these three, rowUpdate, rowInserted, and rowDeleted
surprised me. 

I think, for the others, there are other open items which should get a higher
priority. For now I think it is important to clearly document, for users, what
is and isn't supported with regards to those functions not implemented because
the fb engine doesn't implement them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - external/boost

2018-12-11 Thread Libreoffice Gerrit user
Rebased ref, commits from common ancestor:
commit 27c506467976f2d494fee0d8d3bd7f044a883b36
Author: Thorsten Behrens 
AuthorDate: Tue Dec 11 15:37:28 2018 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Dec 12 00:37:34 2018 +0100

-Werror=implicit-fallthrough= (GCC 7)

Change-Id: I404cea124ee8043179ac7db58c5a0d644d188a01

diff --git a/external/boost/UnpackedTarball_boost.mk 
b/external/boost/UnpackedTarball_boost.mk
index 728b3c382713..d42782e84da5 100644
--- a/external/boost/UnpackedTarball_boost.mk
+++ b/external/boost/UnpackedTarball_boost.mk
@@ -88,6 +88,9 @@ boost_patches += boost_1_60_0.android.undef.warning.patch
 # Clang -Wimplicit-fallthrough":
 boost_patches += fallthrough.patch.0
 
+# Backport from boost 1.66 - fix gcc7 warnings
+boost_patches += boost.Wfallthrough.warnings.patch.1
+
 $(eval $(call gb_UnpackedTarball_UnpackedTarball,boost))
 
 $(eval $(call gb_UnpackedTarball_set_tarball,boost,$(BOOST_TARBALL)))
diff --git a/external/boost/boost.Wfallthrough.warnings.patch.1 
b/external/boost/boost.Wfallthrough.warnings.patch.1
new file mode 100644
index ..78ce8c7d8fad
--- /dev/null
+++ b/external/boost/boost.Wfallthrough.warnings.patch.1
@@ -0,0 +1,12 @@
+--- a/boost/config/compiler/gcc.hpp2015-12-08 19:55:19.0 +0100
 b/boost/config/compiler/gcc.hpp2018-12-11 15:31:29.015359148 +0100
+@@ -67,6 +67,9 @@
+ # define BOOST_NO_EXCEPTIONS
+ #endif
+ 
++#if __GNUC__ >= 7
++#  define BOOST_FALLTHROUGH __attribute__((fallthrough))
++#endif
+ 
+ //
+ // Threading support: Turn this on unconditionally here (except for
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 121734] Floating table from a .DOC may paste to another document with different frame properties

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121734

Mike Kaganski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #4 from Mike Kaganski  ---
https://gerrit.libreoffice.org/64992

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119027] Tabbed: Wrong spacing and indentation icon in Layout tab

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119027

--- Comment #9 from Rizal Muttaqin  ---
(In reply to andreas_k from comment #4)
> as this actions are for Paragraphs, should it be in the layout tab? or
> should I remove this items?

Just leave these actions placement as MS Word does. This bug is about similar
icons between different functions. I don't know whether this is related to
wrong Notebookbar ui file declaration or in code?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122022] PIVOTTABLE : Drill details filter whole row instead of one cell

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122022

m.a.riosv  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122022] PIVOTTABLE : Drill details filter whole row instead of one cell

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122022

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m.a.riosv  ---
Created attachment 147451
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147451=edit
File with redone pivot table

I have redo the pivot table and now works for me.
Version: 6.1.4.1 (x64)
Build ID: 25073d18caee244880112e52c4a7e71f6081b3a9
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: es-ES (es_ES); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105225] Color palette cannot be chosen in various places

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105225

--- Comment #75 from Jim Raykowski  ---
Hi All,

Here is a patch for the remaining two places, AFAIK, where color palette cannot
be chosen:

https://gerrit.libreoffice.org/#/c/64991/

The usefulness of these two background settings seem dubious to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - 2 commits - sc/inc sc/source

2018-12-11 Thread Libreoffice Gerrit user
 sc/inc/dpglobal.hxx  |2 +-
 sc/inc/subtotal.hxx  |   23 ++-
 sc/source/core/data/column2.cxx  |   14 --
 sc/source/core/data/documen4.cxx |   39 ---
 sc/source/core/tool/subtotal.cxx |8 
 5 files changed, 79 insertions(+), 7 deletions(-)

New commits:
commit 80fdc2491df857c910afbd30c025b4594cb1cf83
Author: Eike Rathke 
AuthorDate: Tue Dec 11 17:35:00 2018 +0100
Commit: Eike Rathke 
CommitDate: Tue Dec 11 22:24:16 2018 +0100

Correct typed_flags mask is 0x1fff

This was wrong since

commit 298ee50676b849020a8a5042e8612f71379ecf3b
CommitDate: Sun Nov 20 00:14:28 2016 +0100

PivotMedian: Implement median as a new pivot table function

and in fact in a debug build failed an assertion

soffice.bin: include/o3tl/typed_flags_set.hxx:85:
  constexpr o3tl::is_typed_flags::Wrap::Wrap(type name 
std::underlying_type<_Tp>::type)
  [with E = PivotFunc; typename std::underlying_type<_Tp>::type M = 4607; 
typename std::underlying_type<_Tp>::type = int]:
  Assertion `static_cast::type>(~0) == M 
|| (value & ~M) == 0' failed.

when one of the functions (e.g. StdVar) not included in the mask
was chosen as pivot table data function.

Change-Id: I5b9efc7d2cbcf6fece3ef228db8f6e0ffa17b510
Reviewed-on: https://gerrit.libreoffice.org/64974
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 639a401fbd910c1fede35f7106a5acf716ec5fea)
Reviewed-on: https://gerrit.libreoffice.org/64984

diff --git a/sc/inc/dpglobal.hxx b/sc/inc/dpglobal.hxx
index 295af86db148..0a5b6e94dc6b 100644
--- a/sc/inc/dpglobal.hxx
+++ b/sc/inc/dpglobal.hxx
@@ -39,7 +39,7 @@ enum class PivotFunc {
 Auto = 0x1000
 };
 namespace o3tl {
-template<> struct typed_flags : is_typed_flags {};
+template<> struct typed_flags : is_typed_flags {};
 }
 
 struct ScDPValue
commit 1cb79dd63e0f825cee46fa58a6a9df39e8160f60
Author: Eike Rathke 
AuthorDate: Tue Dec 11 12:43:14 2018 +0100
Commit: Eike Rathke 
CommitDate: Tue Dec 11 22:24:03 2018 +0100

Resolves: tdf#46119 implement GeneralFunction_VAR, VARP, STDEV and STDEVP

These were never implemented. Likely because they aren't used
internally by Calc, which for formula expressions in the
interpreter and for DataPilot / pivot table uses a different
approach, but they are needed for
css::sheet::XSheetOperation::computeFunction()

Change-Id: I1af038bf9db8d0c04d69598b992b827b083e2248
Reviewed-on: https://gerrit.libreoffice.org/64957
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit fc1568d570a96bfa57013ae62adf3f9606639fd3)
Reviewed-on: https://gerrit.libreoffice.org/64975

diff --git a/sc/inc/subtotal.hxx b/sc/inc/subtotal.hxx
index 7858fcae6f2b..46f6fcc7693c 100644
--- a/sc/inc/subtotal.hxx
+++ b/sc/inc/subtotal.hxx
@@ -30,11 +30,32 @@ public:
 static bool SafeDiv( double& fVal1, double fVal2);
 };
 
+/** Implements the Welford Online one-pass algorithm.
+See 
https://en.wikipedia.org/wiki/Algorithms_for_calculating_variance#Welford's_Online_algorithm
+and Donald E. Knuth, TAoCP vol.2, 3rd edn., p. 232
+ */
+class WelfordRunner
+{
+public:
+WelfordRunner() : fMean(0.0), fM2(0.0), nCount(0) {}
+voidupdate( double fVal );
+sal_uInt64  getCount() const{ return nCount; }
+double  getMean() const { return fMean; }
+double  getVarianceSample() const   { return nCount > 1 ? fM2 / 
(nCount-1) : 0.0; }
+double  getVariancePopulation() const   { return nCount > 0 ? fM2 / 
nCount : 0.0; }
+
+private:
+double  fMean;
+double  fM2;
+sal_Int64   nCount;
+};
+
 struct ScFunctionData   // to calculate single functions
 {
+WelfordRunner   maWelford;
 ScSubTotalFunc const  eFunc;
 double  nVal;
-longnCount;
+sal_uInt64  nCount;
 boolbError;
 
 ScFunctionData( ScSubTotalFunc eFn ) :
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index c46f1a70ce8b..5f77628699f6 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -3423,10 +3423,20 @@ class UpdateSubTotalHandler
 mrData.nVal = fVal;
 }
 break;
-default:
+case SUBTOTAL_FUNC_VAR:
+case SUBTOTAL_FUNC_VARP:
+case SUBTOTAL_FUNC_STD:
+case SUBTOTAL_FUNC_STDP:
 {
-// added to avoid warnings
+if (!bVal)
+return;
+
+mrData.maWelford.update( fVal);
 }
+break;
+default:
+// unhandled unknown
+mrData.bError = true;
 }
 }
 
diff --git 

[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #5 from Jan-Marek Glogowski  ---
These patches are no fixes, but will detect the failing JDK setup during
configure as an early warning! They should be reverted after a real fix is
merged.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121925

--- Comment #4 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/c9de94c65b8ab8bf6073400eda5ba848ba22af47%5E%21

tdf#121925 test for URLClassPath.ClassPathURLCheck

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121925] Fix Java Jar dependency classpath to pass the ClassPathURLCheck

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121925

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.3.0|target:6.3.0 target:6.2.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - configure.ac

2018-12-11 Thread Libreoffice Gerrit user
 configure.ac |   52 
 1 file changed, 52 insertions(+)

New commits:
commit c9de94c65b8ab8bf6073400eda5ba848ba22af47
Author: Jan-Marek Glogowski 
AuthorDate: Thu Dec 6 13:26:48 2018 +
Commit: Jan-Marek Glogowski 
CommitDate: Tue Dec 11 22:08:42 2018 +0100

tdf#121925 test for URLClassPath.ClassPathURLCheck

Adds a configure test to check for the enabled ClassPathURLCheck.
Should be reverted, if our jars pass it.

Change-Id: I040b41f329ccae21b92118fd58270682e50e95c1
Reviewed-on: https://gerrit.libreoffice.org/64709
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 905c107cde4a0a7059b1e11b5f23a0a59188cb0c)
Reviewed-on: https://gerrit.libreoffice.org/64968
Reviewed-by: Jan-Marek Glogowski 

diff --git a/configure.ac b/configure.ac
index d553580772c0..1a5323c1b10b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7304,6 +7304,58 @@ if test -n "$ENABLE_JAVA" -a -z "$JAVAINC"; then
 fi
 SOLARINC="$SOLARINC $JAVAINC"
 
+if test "$ENABLE_JAVA" != "" -a "x" != "x$JAVACOMPILER"; then
+url_check_unknown=0
+java_base="testurlcheck"
+java_src="${java_base}.java"
+java_cls="${java_base}.class"
+cat > "${java_src}" <<_ACEOF
+[import jdk.internal.loader.URLClassPath;
+import java.lang.reflect.Field;
+import java.net.URL;
+
+class ${java_base}
+{
+public static void main(String args[])
+{
+try {
+URLClassPath cp = new URLClassPath(new URL[0], null);
+Field field = 
cp.getClass().getDeclaredField("DISABLE_CP_URL_CHECK");
+field.setAccessible(true);
+System.out.println(field.get(cp).toString());
+} catch(Exception e) {
+System.out.println("unknown");
+}
+}
+}]
+_ACEOF
+AC_MSG_CHECKING([if jdk.net.URLClassPath.ClassPathURLCheck is disabled])
+java_cmd="$JAVACOMPILER --add-exports 
java.base/jdk.internal.loader=ALL-UNNAMED ${java_src} 1>&2"
+AC_TRY_EVAL(java_cmd)
+if test $? = 0 -a -f "./${java_cls}"; then
+java_res=`$JAVAINTERPRETER --add-opens 
java.base/jdk.internal.loader=ALL-UNNAMED ${java_base} 2>/dev/null`
+if test $? = 0; then
+case "${java_res}" in
+true) AC_MSG_RESULT([yes]) ;;
+false)
+rm -f "./${java_src}" "./${java_cls}"
+AC_MSG_ERROR([no - Java unit tests will break!])
+;;
+*) url_check_unknown=1 ;;
+esac
+else
+url_check_unknown=1
+fi
+else
+url_check_unknown=1
+fi
+if test $url_check_unknown -eq 1; then
+AC_MSG_RESULT([unknown - assuming yes])
+add_warning "Unable to find the default value for 
jdk.net.URLClassPath.ClassPathURLCheck - java tests might fail!"
+fi
+rm -f "./${java_src}" "./${java_cls}"
+fi
+
 AC_SUBST(JAVACOMPILER)
 AC_SUBST(JAVADOC)
 AC_SUBST(JAVAINTERPRETER)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 76334] LO4.3 writes svg:viewBox="0 0 0 0" when convert a shape in pptx to odp.

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76334

--- Comment #11 from Regina Henschel  ---
(In reply to Roman Kuznetsov from comment #10)
> Regina, how look this bug for user? What is wrong?

Apache OpenOffice will not render the shape. I have not tested Google Docs or
other applications.

SVG is very clear about value zero, "A negative value for  or 
is an error (see Error processing). A value of zero disables rendering of the
element." ["https://www.w3.org/TR/SVG11/coords.html#ViewBoxAttribute] So Apache
OpenOffice is right here.

(In reply to Roman Kuznetsov from comment #10)
> I tried to make export to SVG from ODP, just reopen ODP -> rectangle with
> orange text looks fine in both case.

svg-export does not use the svg:viewBox information.


If you remove the invalid attribute sub-view-size (bug 105603), then it is
rendered false in LibreOffice too. So LibreOffice produces documents which will
become problematic when other bugs are fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - external/boost

2018-12-11 Thread Libreoffice Gerrit user
Rebased ref, commits from common ancestor:
commit 046758120ad8feb90b6d6e19bb00336f78f50f38
Author: Thorsten Behrens 
AuthorDate: Tue Dec 11 15:37:28 2018 +0100
Commit: Thorsten Behrens 
CommitDate: Tue Dec 11 21:42:00 2018 +0100

-Werror=implicit-fallthrough= (GCC 7)

Change-Id: I404cea124ee8043179ac7db58c5a0d644d188a01

diff --git a/external/boost/UnpackedTarball_boost.mk 
b/external/boost/UnpackedTarball_boost.mk
index 728b3c382713..d42782e84da5 100644
--- a/external/boost/UnpackedTarball_boost.mk
+++ b/external/boost/UnpackedTarball_boost.mk
@@ -88,6 +88,9 @@ boost_patches += boost_1_60_0.android.undef.warning.patch
 # Clang -Wimplicit-fallthrough":
 boost_patches += fallthrough.patch.0
 
+# Backport from boost 1.66 - fix gcc7 warnings
+boost_patches += boost.Wfallthrough.warnings.patch.1
+
 $(eval $(call gb_UnpackedTarball_UnpackedTarball,boost))
 
 $(eval $(call gb_UnpackedTarball_set_tarball,boost,$(BOOST_TARBALL)))
diff --git a/external/boost/boost.Wfallthrough.warnings.patch 
b/external/boost/boost.Wfallthrough.warnings.patch
new file mode 100644
index ..78ce8c7d8fad
--- /dev/null
+++ b/external/boost/boost.Wfallthrough.warnings.patch
@@ -0,0 +1,12 @@
+--- a/boost/config/compiler/gcc.hpp2015-12-08 19:55:19.0 +0100
 b/boost/config/compiler/gcc.hpp2018-12-11 15:31:29.015359148 +0100
+@@ -67,6 +67,9 @@
+ # define BOOST_NO_EXCEPTIONS
+ #endif
+ 
++#if __GNUC__ >= 7
++#  define BOOST_FALLTHROUGH __attribute__((fallthrough))
++#endif
+ 
+ //
+ // Threading support: Turn this on unconditionally here (except for
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 92235] Font STYLES for Table Headers are not copied when defining auto table format

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92235

--- Comment #12 from eisa01  ---
This is still present.

Note: Important to check the paragraph style! The formatting (e.g., bold
header) is applied, but the paragraph style is not. As such, you lose the
format if you press ctrl+m (presumably resetting format)

Version: 6.3.0.0.alpha0+
Build ID: beae6c7a7f163daad0d4dea63a3d403af2745fd1
CPU threads: 2; OS: Mac OS X 10.13.6; UI render: default; VCL: osx; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-12-06_23:52:29
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: loleaflet/src

2018-12-11 Thread Libreoffice Gerrit user
 loleaflet/src/control/Signing.js |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 375a1a60789a1871b0209f4699680f48410c5a40
Author: Szymon Kłos 
AuthorDate: Tue Dec 11 17:08:37 2018 +0100
Commit: Szymon Kłos 
CommitDate: Tue Dec 11 21:30:18 2018 +0100

Don't show '<<' button in the signing toolbar

Change-Id: Ie178add1812735ac4653b0aedab58f70a8b6f0e8

diff --git a/loleaflet/src/control/Signing.js b/loleaflet/src/control/Signing.js
index 183d5ed88..d6bc52b2b 100644
--- a/loleaflet/src/control/Signing.js
+++ b/loleaflet/src/control/Signing.js
@@ -272,6 +272,11 @@ L.Map.include({
oldtoolbarSize = $('#document-container').css('top');
 
$('#document-container').css('top', '110px');
+
+   // Avoid scroll button ">>"
+   var el = w2ui['document-signing-bar'];
+   if (el)
+   el.resize();
},
hideSignDocument: function() {
$('#document-signing-bar').hide();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122024] merged cells become unmerged when deleting first row or column

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122024

BogdanB  changed:

   What|Removed |Added

 CC||bogdan...@gmail.com

--- Comment #4 from BogdanB  ---
I'm not an expert, nut in my opinion if I decided to merge A1:A3 and then to
delete a column with merge cells it is logic to delete everything on that
column, includind merge cell or other things. And column B to became the first
row.

So, I think this is not a bug. I don't understand Excel logic on this problem:
I have a column and I delete a column with some changes, and changes remains?
Why?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117414] CRASH - on attempting to load a writer template document (OSX)

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117414

eisa01  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #8 from eisa01  ---
This works for me, I can open the template without issues as well

Version: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU threads: 2; OS: Mac OS X 10.13.6; UI render: default; 
Locale: en-US (en_US.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103314
Bug 103314 depends on bug 117414, which changed state.

Bug 117414 Summary: CRASH - on attempting to load a writer template document 
(OSX)
https://bugs.documentfoundation.org/show_bug.cgi?id=117414

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: helpcontent2

2018-12-11 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d1363c39201e93aa83028fd837fe12f48f79f63b
Author: Sabri Unal 
AuthorDate: Tue Dec 11 22:28:55 2018 +0200
Commit: Gerrit Code Review 
CommitDate: Tue Dec 11 21:13:59 2018 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - Correct some Format - Row/Column/Cell paths

Some Format - Row/Column/Cell paths are corrected
as Format - Rows/Columns/Cells

Change-Id: If9795322ca50f3f5646b9195de69eb1e348662cf
Reviewed-on: https://gerrit.libreoffice.org/64985
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 6f928cff923f..a3ad770b3b2c 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 6f928cff923ffacc6a1e12b0ddb6b7938d7f463d
+Subproject commit a3ad770b3b2ca000646c0b3bfa0933e8486c7a22
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103378
Bug 103378 depends on bug 121966, which changed state.

Bug 121966 Summary: Character corruption when converting pptx to pdf on Ubuntu
https://bugs.documentfoundation.org/show_bug.cgi?id=121966

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121966] Character corruption when converting pptx to pdf on Ubuntu

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121966

Drew Jensen  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |NOTABUG

--- Comment #6 from Drew Jensen  ---
I take it then closing this issue as not a bug is correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] help.git: source/text

2018-12-11 Thread Libreoffice Gerrit user
 source/text/scalc/01/05030300.xhp |4 ++--
 source/text/scalc/01/05030400.xhp |4 ++--
 source/text/scalc/02/0215.xhp |2 +-
 source/text/scalc/guide/specialfilter.xhp |2 +-
 source/text/scalc/guide/text_wrap.xhp |2 +-
 source/text/shared/00/00040503.xhp|4 ++--
 source/text/shared/02/0213.xhp|2 +-
 7 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit a3ad770b3b2ca000646c0b3bfa0933e8486c7a22
Author: Sabri Unal 
AuthorDate: Tue Dec 11 22:28:55 2018 +0200
Commit: Olivier Hallot 
CommitDate: Tue Dec 11 21:13:59 2018 +0100

Correct some Format - Row/Column/Cell paths

Some Format - Row/Column/Cell paths are corrected
as Format - Rows/Columns/Cells

Change-Id: If9795322ca50f3f5646b9195de69eb1e348662cf
Reviewed-on: https://gerrit.libreoffice.org/64985
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/05030300.xhp 
b/source/text/scalc/01/05030300.xhp
index 01b1d5d68..d1fc2e7d4 100644
--- a/source/text/scalc/01/05030300.xhp
+++ b/source/text/scalc/01/05030300.xhp
@@ -48,7 +48,7 @@
 
   
 
-Select the 
rows or columns that you want to hide, and then choose Format - Row - 
Hide or Format - Column - Hide.
+Select the 
rows or columns that you want to hide, and then choose Format - Rows - 
Hide or Format - Columns - Hide.
 You can hide a 
sheet by selecting the sheet tab and then choosing Format - Sheet - 
Hide. Hidden sheets are not printed unless they occur within a print 
range.
 A break in the row 
or column header indicates whether the row or column is hidden.
 To display 
hidden rows, columns or sheets
@@ -57,7 +57,7 @@
 Select the 
range that includes the hidden objects. You can also use the box in the corner 
above row 1 and beside column A. For sheets, this step is not 
necessary.UFI: fixes #i18582#
 
 
-Choose Format - 
Row/Column - Show or Format - Sheet - Show.
+Choose Format - 
Rows/Columns - Show or Format - Sheet - Show.
 
 
 
diff --git a/source/text/scalc/01/05030400.xhp 
b/source/text/scalc/01/05030400.xhp
index b53974052..5ea172cf3 100644
--- a/source/text/scalc/01/05030400.xhp
+++ b/source/text/scalc/01/05030400.xhp
@@ -43,8 +43,8 @@
 
   
 
-To show a 
column or row, select the range of rows or columns containing the hidden 
elements, then choose Format - Row - Show or Format - Column 
- Show.
-For example, 
to show the column B, click on the header of the column A, expand the selection 
to the column C, then chose Format - Column - Show. To show the 
column A previously hidden, click on the header of the column B, keep the mouse 
button pressed and drag on the left. The selected range displayed in the name 
area changes from B1:B1048576 to A1:B1048576. Choose Format - Column - 
Show. Proceed the same way with rows.
+To show a 
column or row, select the range of rows or columns containing the hidden 
elements, then choose Format - Rows - Show or Format - 
Columns - Show.
+For example, 
to show the column B, click on the header of the column A, expand the selection 
to the column C, then chose Format - Columns - Show. To show the 
column A previously hidden, click on the header of the column B, keep the mouse 
button pressed and drag on the left. The selected range displayed in the name 
area changes from B1:B1048576 to A1:B1048576. Choose Format - Columns - 
Show. Proceed the same way with rows.
 To show all 
hidden cells, first click in the field in the upper left corner. This selects 
all cells of the table.
 
 
diff --git a/source/text/scalc/02/0215.xhp 
b/source/text/scalc/02/0215.xhp
index d5b599dfe..90398511d 100644
--- a/source/text/scalc/02/0215.xhp
+++ b/source/text/scalc/02/0215.xhp
@@ -48,6 +48,6 @@
   
   
   
-  Format - 
Cells - Numbers.
+  Format - 
Cells - Numbers.
  
 
diff --git a/source/text/scalc/guide/specialfilter.xhp 
b/source/text/scalc/guide/specialfilter.xhp
index e4ad7a9fb..4709176b5 100644
--- a/source/text/scalc/guide/specialfilter.xhp
+++ b/source/text/scalc/guide/specialfilter.xhp
@@ -48,7 +48,7 @@
 Once you 
have created a filter matrix, select the sheet ranges to be filtered. Open the 
Advanced Filter dialog by choosing Data - Filter - Advanced 
Filter, and define the filter conditions.


-Then click 
OK, and you will see that only the rows from the original sheet whose contents 
have met the search criteria are still visible. All other rows are temporarily 
hidden and can be made to reappear with the Format - Row - Show 
command.
+Then click 
OK, and you will see that only the rows from the original sheet whose contents 
have met the search criteria are still visible. All other rows are temporarily 
hidden and can be made to reappear with the Format - Rows - Show 
command.

   

Example 
diff --git a/source/text/scalc/guide/text_wrap.xhp 
b/source/text/scalc/guide/text_wrap.xhp
index 10569c4f6..3038210bf 100644
--- 

[Libreoffice-bugs] [Bug 122024] merged cells become unmerged when deleting first row or column

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122024

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #3 from raal  ---
It works in Gnumeric and Excel- deleting column A keeps the merge

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105588] SVG exported from Impress or Draw cannot be correctly inserted as an image into another document

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105588

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1916

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121916] SVG from document created with older LibreOffice builds provoke redundant paste option; transparency lost

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121916

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5588

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/qa

2018-12-11 Thread Libreoffice Gerrit user
 sc/qa/uitest/calc_tests/data/tdf31805.ods |binary
 sc/qa/uitest/calc_tests7/tdf31805.py  |   47 ++
 2 files changed, 47 insertions(+)

New commits:
commit 23b6c876180b5fc7b124f8116a350a9b9066e1f6
Author: Zdeněk Crhonek 
AuthorDate: Tue Dec 11 16:35:31 2018 +0100
Commit: Zdenek Crhonek 
CommitDate: Tue Dec 11 20:50:42 2018 +0100

uitest for bug tdf#31805

Change-Id: I21790869be9c87e923cb4d87b58b2dc4b143fb25
Reviewed-on: https://gerrit.libreoffice.org/64971
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/uitest/calc_tests/data/tdf31805.ods 
b/sc/qa/uitest/calc_tests/data/tdf31805.ods
new file mode 100644
index ..4660363efaa7
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/tdf31805.ods differ
diff --git a/sc/qa/uitest/calc_tests7/tdf31805.py 
b/sc/qa/uitest/calc_tests7/tdf31805.py
new file mode 100644
index ..bc7edd669526
--- /dev/null
+++ b/sc/qa/uitest/calc_tests7/tdf31805.py
@@ -0,0 +1,47 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.document import get_cell_by_position
+from libreoffice.uno.propertyvalue import mkPropertyValues
+import org.libreoffice.unotest
+import pathlib
+
+#Bug 31805 - Deleting a column or row from merged cells
+def get_url_for_data_file(file_name):
+return 
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+
+class tdf31805(UITestCase):
+def test_tdf31805_delete_column_merged(self):
+calc_doc = 
self.ui_test.load_file(get_url_for_data_file("tdf31805.ods"))
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+document = self.ui_test.get_component()
+#1. open "sample.ods"
+#2. click 'G1'
+#3. Menu 'edit -> Celete Cell - Delete entire Column'
+#expected: Column with cell containing "g" will be deleted,
+# a merged cell range will remainlect row 1
+
+gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "G1"}))
+self.assertEqual(get_cell_by_position(document, 0, 2, 
4).getIsMerged(), True)
+self.xUITest.executeCommand(".uno:DeleteColumns")
+#verify. C5:F11 should be merged
+#isMerged   returns true if this cell is merged with another cell.
+self.assertEqual(get_cell_by_position(document, 0, 2, 
4).getIsMerged(), True)  #C5
+self.assertEqual(get_cell_by_position(document, 0, 6, 
4).getIsMerged(), False)  #G5
+gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A11"}))
+self.xUITest.executeCommand(".uno:DeleteRows")
+self.assertEqual(get_cell_by_position(document, 0, 2, 
4).getIsMerged(), True)  #C5
+gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "D1"}))
+self.xUITest.executeCommand(".uno:DeleteColumns")
+self.assertEqual(get_cell_by_position(document, 0, 2, 
4).getIsMerged(), True)  #C5
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 103151] SVG rendered wrong in the presenter console

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103151

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=95
   ||438

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 95438] SLIDESHOW/VIEWING: Misrendered SVG in presenter console

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95438

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3151

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104238] [META] Impress image bugs and enhancements

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104238

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||91349


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91349
[Bug 91349] Animated gif converted to static gif in SVG export
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108438] [META] Animated image bugs and enhancements

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108438

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||91349


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91349
[Bug 91349] Animated gif converted to static gif in SVG export
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91349] Animated gif converted to static gif in SVG export

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91349

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||104238, 108438


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104238
[Bug 104238] [META] Impress image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108438
[Bug 108438] [META] Animated image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122026] BASE - Problems in Report design

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122026

Robert Großkopf  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Robert Großkopf  ---
This seems to be a duplicate of bug 120152. Have tested with LO 6.1.2.1 and LO
6.1.3.2 - both will fail. But with LO 6.1.4.1 you could add fields to the
report again.

I will set this as duplicate of bug 120152. Seems to be fixed for next version.

*** This bug has been marked as a duplicate of bug 120152 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91347] Placeholder is visible in SVG export

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91347

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||111450
   Keywords||filter:svg


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=111450
[Bug 111450] [META] SVG fileSave filter (Draw)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111450] [META] SVG fileSave filter (Draw)

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111450

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||91347


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91347
[Bug 91347] Placeholder is visible in SVG export
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121966] Character corruption when converting pptx to pdf on Ubuntu

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121966

--- Comment #5 from n...@enthought.com ---
It was due to missing font in Ubuntu. `apt-get install fonts-umefonts` solved
the problem. Thanks for the help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111450] [META] SVG fileSave filter (Draw)

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111450

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||91318


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91318
[Bug 91318] SVG export should use fill pattern
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91318] SVG export should use fill pattern

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91318

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:svg
 Blocks||111450


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=111450
[Bug 111450] [META] SVG fileSave filter (Draw)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/inc

2018-12-11 Thread Libreoffice Gerrit user
 sc/inc/dpglobal.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 639a401fbd910c1fede35f7106a5acf716ec5fea
Author: Eike Rathke 
AuthorDate: Tue Dec 11 17:35:00 2018 +0100
Commit: Eike Rathke 
CommitDate: Tue Dec 11 20:40:00 2018 +0100

Correct typed_flags mask is 0x1fff

This was wrong since

commit 298ee50676b849020a8a5042e8612f71379ecf3b
CommitDate: Sun Nov 20 00:14:28 2016 +0100

PivotMedian: Implement median as a new pivot table function

and in fact in a debug build failed an assertion

soffice.bin: include/o3tl/typed_flags_set.hxx:85:
  constexpr o3tl::is_typed_flags::Wrap::Wrap(type name 
std::underlying_type<_Tp>::type)
  [with E = PivotFunc; typename std::underlying_type<_Tp>::type M = 4607; 
typename std::underlying_type<_Tp>::type = int]:
  Assertion `static_cast::type>(~0) == M 
|| (value & ~M) == 0' failed.

when one of the functions (e.g. StdVar) not included in the mask
was chosen as pivot table data function.

Change-Id: I5b9efc7d2cbcf6fece3ef228db8f6e0ffa17b510
Reviewed-on: https://gerrit.libreoffice.org/64974
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/inc/dpglobal.hxx b/sc/inc/dpglobal.hxx
index 295af86db148..0a5b6e94dc6b 100644
--- a/sc/inc/dpglobal.hxx
+++ b/sc/inc/dpglobal.hxx
@@ -39,7 +39,7 @@ enum class PivotFunc {
 Auto = 0x1000
 };
 namespace o3tl {
-template<> struct typed_flags : is_typed_flags {};
+template<> struct typed_flags : is_typed_flags {};
 }
 
 struct ScDPValue
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122027] Continue Previous Numbering Does Not Find Previous Number and Starts at 1. Again

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122027

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|6.1.2.1 release |5.4.7.2 release
 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1
 Blocks||103369
 OS|Linux (All) |All
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||7233

--- Comment #1 from Dieter Praas  ---
I confirm this with

Version: 6.1.3.2 (x64)
Build-ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: group threaded

and

Version: 5.4.7.2 (x64)
Build-ID: c838ef25c16710f8838b1faec480ebba495259d0
CPU-Threads: 4; BS: Windows 6.19; UI-Render: GL; 
Gebietsschema: de-DE (de_DE); Calc: CL


Steps to reproduce
1. open a new document
2. Type two lines
3. change lines to numbered list
4. In the second line change to "Restart numbering"
5. In the second line Change to "Continue previous numbering"

Actual result
Doesn't work

Additional observation: "Restart numbering button" changes numbering between
restart and continue


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103369
[Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89985] Text of this svg image is shifted in slideshow

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89985

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:odp, filter:svg
 Blocks||88278, 103610


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=88278
[Bug 88278] [META] SVG import image filter (all modules)
https://bugs.documentfoundation.org/show_bug.cgi?id=103610
[Bug 103610] [META] Slide show (presentation mode) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88278] [META] SVG import image filter (all modules)

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88278

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||89985


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89985
[Bug 89985] Text of this svg image is shifted in slideshow
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103369

Dieter Praas  changed:

   What|Removed |Added

 Depends on||122027


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=122027
[Bug 122027] Continue Previous Numbering Does Not Find Previous Number and
Starts at 1. Again
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103610] [META] Slide show (presentation mode) bugs and enhancements

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103610

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||89985


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89985
[Bug 89985] Text of this svg image is shifted in slideshow
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117233] Improve handling of "Continue Previous Number" (see comment 12)

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117233

Dieter Praas  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2027

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88278] [META] SVG import image filter (all modules)

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88278

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||87450


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87450
[Bug 87450] SVG reduced in quality and distorted
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87450] SVG reduced in quality and distorted

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87450

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||88278
   Keywords||filter:svg


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=88278
[Bug 88278] [META] SVG import image filter (all modules)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122029] New: Crash in: s_stub_releaseInterface

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122029

Bug ID: 122029
   Summary: Crash in: s_stub_releaseInterface
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: norie...@gmail.com

This bug was filed from the crash reporting server and is
br-e96f84ea-fed2-442f-98a7-54179efe4ea4.
=

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 62133] Minor Draw UI inconsistency- background colour of area style/filling buttons slightly different

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62133

eisa01  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #14 from eisa01  ---
This is fixed for me now

Version: 6.3.0.0.alpha0+
Build ID: beae6c7a7f163daad0d4dea63a3d403af2745fd1
CPU threads: 2; OS: Mac OS X 10.13.6; UI render: default; VCL: osx; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-12-06_23:52:29
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84909] [META] Enhancing Impress/Draw toolbars and context menu

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84909
Bug 84909 depends on bug 62133, which changed state.

Bug 62133 Summary: Minor Draw UI inconsistency- background colour of area 
style/filling buttons slightly different
https://bugs.documentfoundation.org/show_bug.cgi?id=62133

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82267] Add warning that inserting an .svg file will get converted to bitmap when converting to OOXML formatted .pptx

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82267

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:pptx
 Blocks||107817


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107817
[Bug 107817] [META] Impress UI/UX bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107817] [META] Impress UI/UX bugs and enhancements

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107817

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||82267


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=82267
[Bug 82267] Add warning that inserting an .svg file will get converted to
bitmap when converting to OOXML formatted .pptx
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/qa sw/source

2018-12-11 Thread Libreoffice Gerrit user
 sw/qa/extras/unowriter/unowriter.cxx |   38 +++
 sw/source/core/unocore/unoobj2.cxx   |   30 +++
 2 files changed, 68 insertions(+)

New commits:
commit 42dffe7b135c0680a8e20e4170a5f1176afc908e
Author: Miklos Vajna 
AuthorDate: Tue Dec 11 16:42:54 2018 +0100
Commit: Miklos Vajna 
CommitDate: Tue Dec 11 20:15:30 2018 +0100

sw: fix paragraph enumeration going past a selected table

Writer has the internal invariant that if a text (non-table) selection
starts outside a table, it should end outside a table as well.  This
means if you start your selection before a table and you try to select
till the end of the table, your selection will end at the start of the
next non-table node in fact.

This is especially confusing if you turn the selection into a paragraph
enumeration, where the last paragraph's 0 -> 0 character range is
"selected" (i.e. none of the paragraph content is selected) and still
the paragraph is included in the paragraph enumeration.

Special-case the "selection ending at para start after a table"
situation when it comes to turning this selection into a paragraph
enumeration to avoid the unexpected empty paragraph at the end.

Change-Id: I51432dee9e5d76971533c8059edab1cd9683434b
Reviewed-on: https://gerrit.libreoffice.org/64972
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/qa/extras/unowriter/unowriter.cxx 
b/sw/qa/extras/unowriter/unowriter.cxx
index 4bff617f62ef..8cba987a7c63 100644
--- a/sw/qa/extras/unowriter/unowriter.cxx
+++ b/sw/qa/extras/unowriter/unowriter.cxx
@@ -380,6 +380,44 @@ DECLARE_UNOAPI_TEST_FILE(testSelectionInTableEnum, 
"selection-in-table-enum.odt"
 CPPUNIT_ASSERT(!xEnum->hasMoreElements());
 }
 
+DECLARE_UNOAPI_TEST_FILE(testSelectionInTableEnumEnd, 
"selection-in-table-enum.odt")
+{
+// Select from "Before" till the table end.
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+CPPUNIT_ASSERT(pWrtShell);
+pWrtShell->Down(/*bSelect=*/true);
+
+// Access the selection.
+uno::Reference xModel(mxComponent, uno::UNO_QUERY);
+CPPUNIT_ASSERT(xModel.is());
+uno::Reference 
xSelections(xModel->getCurrentSelection(),
+uno::UNO_QUERY);
+CPPUNIT_ASSERT(xSelections.is());
+uno::Reference xSelection(xSelections->getByIndex(0), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xSelection.is());
+OUString aExpectedSelection
+= "Before" SAL_NEWLINE_STRING "A1" SAL_NEWLINE_STRING "B1" 
SAL_NEWLINE_STRING
+  "C2" SAL_NEWLINE_STRING "A2" SAL_NEWLINE_STRING "B2" 
SAL_NEWLINE_STRING
+  "C2" SAL_NEWLINE_STRING;
+CPPUNIT_ASSERT_EQUAL(aExpectedSelection, xSelection->getString());
+
+// Enumerate paragraphs in the selection.
+uno::Reference xCursor(
+xSelection->getText()->createTextCursorByRange(xSelection), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xCursor.is());
+uno::Reference xEnum = 
xCursor->createEnumeration();
+// Before.
+xEnum->nextElement();
+// Table.
+xEnum->nextElement();
+// Without the accompanying fix in place, this test would have failed: i.e.
+// the enumeration contained the paragraph after the table, but no part of
+// that paragraph was part of the selection.
+CPPUNIT_ASSERT(!xEnum->hasMoreElements());
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/unocore/unoobj2.cxx 
b/sw/source/core/unocore/unoobj2.cxx
index 98a6b079a69c..788d4508feb0 100644
--- a/sw/source/core/unocore/unoobj2.cxx
+++ b/sw/source/core/unocore/unoobj2.cxx
@@ -513,6 +513,12 @@ struct SwXParagraphEnumerationImpl final : public 
SwXParagraphEnumeration
 /// @throws lang::WrappedTargetException
 /// @throws uno::RuntimeException
 uno::Reference< text::XTextContent > NextElement_Impl();
+
+/**
+ * Determines if the last element in the enumeration should be ignored or
+ * not.
+ */
+bool IgnoreLastElement(SwUnoCursor& rCursor, bool bMovedFromTable);
 };
 
 SwXParagraphEnumeration* SwXParagraphEnumeration::Create(
@@ -566,6 +572,23 @@ lcl_CursorIsInSection(
 return bRes;
 }
 
+bool SwXParagraphEnumerationImpl::IgnoreLastElement(SwUnoCursor& rCursor, bool 
bMovedFromTable)
+{
+// Ignore the last element of a selection enumeration if this is a stub
+// paragraph (directly after table, selection ends at paragaph start).
+
+if (rCursor.Start()->nNode.GetIndex() != m_nEndIndex)
+return false;
+
+if (m_eCursorType != CursorType::Selection)
+return false;
+
+if (!bMovedFromTable)
+return false;
+
+return m_nLastParaEnd == 0;
+}
+
 uno::Reference< text::XTextContent >
 SwXParagraphEnumerationImpl::NextElement_Impl()
 {
@@ -588,11 

[Libreoffice-bugs] [Bug 119675] Firebird: Migration: User dialog to set treatment of datetime and time values during migration

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119675

--- Comment #2 from Terrence Enger  ---
[1] says that Firebird 4.0 Beta1 will have TIME WITH TIMEZONE and
DATETIME WITH TIMEZONE.  Firebird 4.0 is still alpha, and I have not
found a schedule for its advancement from that state.  The latest
"daily" build of 4.0, [2], was on 2018-11-25, which is earlier than
the commit in question.

I wonder whether this promise from Firebird should change our plans
with respect to this bug and bug 117732?

In the long run, I expect that we can most nearly maintain the
behaviour that users are familiar with by:
(1) Our conversion from HSQLDB converts to fields with-timezone-GMT.
(2) We translate data retrieved from the database to local time and we
convert data writtem to the database to GMT.

Do we expect to do that?  Should this change our plans with respect to
always offering the conversion from embedded HSQLDB to embedded
Firebird?

Of course, after doing (2), it will be tempting to give the user
access to additional functionality by optionally--or, optionally if
the .odb was converted from embedded HSQLDB--giving the user some
explicit access to timezone data.  I do not know what this might look
like.  Do we have anything like this in our connection to a database
already offering with-timezone?

references
--
[1]

[2] 

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121173] Double Spaces in some sentences

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121173

--- Comment #7 from Commit Notification 
 ---
Sophia Schröder committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/+/6f928cff923ffacc6a1e12b0ddb6b7938d7f463d%5E%21

Related: tdf#121173 double spaces in sentences

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: helpcontent2

2018-12-11 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e4c02a7bfe6f35afd359f6540b310437fd9a1d43
Author: Sophia Schröder 
AuthorDate: Mon Dec 10 21:42:07 2018 +0100
Commit: Gerrit Code Review 
CommitDate: Tue Dec 11 20:10:04 2018 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces in sentences

Change-Id: Id9e9094b932af787ceccbe5ea867459afe6677c0
Reviewed-on: https://gerrit.libreoffice.org/64897
Tested-by: Jenkins
Reviewed-by: Sophie Gautier 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 793e75c7f7d3..6f928cff923f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 793e75c7f7d321491e2eecfb88ed05f0661ffaf9
+Subproject commit 6f928cff923ffacc6a1e12b0ddb6b7938d7f463d
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: source/text

2018-12-11 Thread Libreoffice Gerrit user
 source/text/shared/01/05290300.xhp |   12 
 1 file changed, 4 insertions(+), 8 deletions(-)

New commits:
commit 6f928cff923ffacc6a1e12b0ddb6b7938d7f463d
Author: Sophia Schröder 
AuthorDate: Mon Dec 10 21:42:07 2018 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Dec 11 20:10:04 2018 +0100

Related: tdf#121173 double spaces in sentences

Change-Id: Id9e9094b932af787ceccbe5ea867459afe6677c0
Reviewed-on: https://gerrit.libreoffice.org/64897
Tested-by: Jenkins
Reviewed-by: Sophie Gautier 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/shared/01/05290300.xhp 
b/source/text/shared/01/05290300.xhp
index 1f9290cad..fa140e890 100644
--- a/source/text/shared/01/05290300.xhp
+++ b/source/text/shared/01/05290300.xhp
@@ -1,6 +1,5 @@
 
-
-
+
 
-
+
 
 
 Enter Group
@@ -29,19 +28,16 @@
 
 
 
-  
-  
-
 
 Enter 
Group
   Opens the 
selected group, so that you can edit the individual objects. If the selected 
group contains nested group, you can repeat this command on the 
subgroups. This command does not permanently ungroup the 
objects.
   
   
 
-  To select an 
individual object in a group,  hold down  
Command 
Ctrl , and then click the 
object.
+  To select an 
individual object in a group, hold down CommandCtrl,
 and then click the object.
   
   Groups
   Exit 
Group
   
- 
+
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 76334] LO4.3 writes svg:viewBox="0 0 0 0" when convert a shape in pptx to odp.

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76334

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
   Keywords||filter:pptx, filter:svg

--- Comment #10 from Roman Kuznetsov <79045_79...@mail.ru> ---
Regina, how look this bug for user? What is wrong?
I tried to make export to SVG from ODP, just reopen ODP -> rectangle with
orange text looks fine in both case.

Version: 6.3.0.0.alpha0+
Build ID: ba17d2e3c1acd571a4faa7e31ef97a2ec71591bd
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-12-10_01:14:49
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66901] SVG images within a presentation, deform (change aspect) to be exported in vector format.

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=66901

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #14 from Roman Kuznetsov <79045_79...@mail.ru> ---
Created attachment 147450
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147450=edit
SVG from 6.3 a0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111450] [META] SVG fileSave filter (Draw)

2018-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111450
Bug 111450 depends on bug 66901, which changed state.

Bug 66901 Summary: [SVG] SVG images within a presentation, deform (change 
aspect) to be exported in vector format.
https://bugs.documentfoundation.org/show_bug.cgi?id=66901

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >