[Libreoffice-bugs] [Bug 122642] LOOL - fail adding images
https://bugs.documentfoundation.org/show_bug.cgi?id=122642 Andras Timar changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||bibisectRequest, regression CC||tima...@gmail.com --- Comment #1 from Andras Timar --- Confirmed. It's a regression. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=84837 --- Comment #162 from alex1999 --- Router Support Number for Indie Check Router Support Article and Router Support Phone Number for Independent Support. Call +18559000490 https://www.technical-help-support.com/router-support/ https://www.technical-help-support.com/router-support/cisco-support/ https://www.technical-help-support.com/router-support/linksys-support/ https://www.technical-help-support.com/router-support/netgear-support/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=84837 --- Comment #163 from alex1999 --- Contact Email Support Phone Number for Indie Email Support. Check Email Support Article and Email Support Number for Independent Support. Call +18666000870 https://www.technical-help-support.com/email-support/ https://www.technical-help-support.com/email-support/gmail-support/ https://www.technical-help-support.com/email-support/yahoo-mail-support/ https://www.technical-help-support.com/email-support/roadrunner-email-support/ https://www.technical-help-support.com/email-support/sbcglobal-email-support/ https://www.technical-help-support.com/email-support/bellsouth-email-support/ https://www.technical-help-support.com/email-support/att-email-support/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=84837 --- Comment #164 from alex1999 --- Contact for latest devices support. Call +18666000870 https://www.technical-help-support.com/device-support/ https://www.technical-help-support.com/device-support/netflix-support/ https://www.technical-help-support.com/device-support/roku-support/ https://www.technical-help-support.com/device-support/garmin-support/ https://www.technical-help-support.com/device-support/kindle-support/ https://www.technical-help-support.com/device-support/tomtom-support/ https://www.technical-help-support.com/device-support/arlo-support/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122699] Select a style and show cells formatted with that style
https://bugs.documentfoundation.org/show_bug.cgi?id=122699 --- Comment #1 from russell --- Created attachment 148300 --> https://bugs.documentfoundation.org/attachment.cgi?id=148300=edit Image of enhancement - Select style highlights cells -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=84837 --- Comment #161 from alex1999 --- Looking for Microsoft number or Microsoft customer support phone number? Contact Microsoft Support by phone and get Microsoft help from experts.Call +18333508050 & Get instant resolution Microsoft support Microsoft Support Number Call Now +18333508050 for Microsoft support and services. This is Trusted Microsoft Technical Support number provide instant support https://www.technical-help-support.com/microsoft-support/ https://www.technical-help-support.com/microsoft-support/microsoft-activation-support/ https://www.technical-help-support.com/microsoft-support/microsoft-contact/ https://www.technical-help-support.com/microsoft-support/microsoft-customer-service/ https://www.technical-help-support.com/microsoft-support/microsoft-help/ https://www.technical-help-support.com/microsoft-support/microsoft-number/ https://www.technical-help-support.com/microsoft-support/microsoft-office-support/ https://www.technical-help-support.com/microsoft-support/microsoft-outlook-support/ https://www.technical-help-support.com/microsoft-support/microsoft-phone-support/ https://www.technical-help-support.com/microsoft-support/microsoft-technical-support/ https://www.technical-help-support.com/microsoft-support/microsoft-telephone-support/ https://www.technical-help-support.com/microsoft-support/microsoft-windows-support/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=84837 --- Comment #159 from alex1999 --- https://www.google.com https://www.google.com;>ajay [url=www.google.com]kumar[/url] keyword -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=84837 --- Comment #160 from alex1999 --- Call +1-855-553-4777 iPhone, iPad, itunes, macintosh, macbook, apple id and Mac, technical help. Contact to apple customer service for any technical query related to apple if you are facing Any Apple related problems call +1-855-553-4777 for instant resolution by apple support experts https://www.technical-help-support.com/ https://www.technical-help-support.com/apple-support/ https://www.technical-help-support.com/apple-support/apple-help-number/ https://www.technical-help-support.com/apple-support/apple-id-support/ https://www.technical-help-support.com/apple-support/macintosh-support/ https://www.technical-help-support.com/apple-support/macbook-support/ https://www.technical-help-support.com/apple-support/iphone-support/ https://www.technical-help-support.com/apple-support/mac-support/ https://www.technical-help-support.com/apple-support/apple-ipad-support/ https://www.technical-help-support.com/apple-support/apple-tech-support/ https://www.technical-help-support.com/apple-support/itunes-support/ https://www.technical-help-support.com/apple-support/apple-customer-service/ https://www.technical-help-support.com/apple-support/icloud-support/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122699] New: Select a style and show cells formatted with that style
https://bugs.documentfoundation.org/show_bug.cgi?id=122699 Bug ID: 122699 Summary: Select a style and show cells formatted with that style Product: LibreOffice Version: 6.1.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: prusselltechgr...@gmail.com Description: With Cell Styles selected from Styles and Formatting (F11), select a style, and all cells on the current sheet that are formatted with that style are highlighted. The highlighting could mean an overlay, different color, dashed lines. Actual Results: Currently it works the other way around. The user clicks a cell and the style is highlighted in the Styles and Formatting panel. Expected Results: Please see attached image. It would be helpful to see, all cells using style "X", especially if converting spreadsheets from direct formatting to styles. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122488] Toolbar icons to insert row/column in table are misleading with Sifr
https://bugs.documentfoundation.org/show_bug.cgi?id=122488 --- Comment #3 from BogdanB --- Created attachment 148299 --> https://bugs.documentfoundation.org/attachment.cgi?id=148299=edit sifr icon looking good sifr icons looking good -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122488] Toolbar icons to insert row/column in table are misleading with Sifr
https://bugs.documentfoundation.org/show_bug.cgi?id=122488 BogdanB changed: What|Removed |Added CC||bogdan...@gmail.com --- Comment #2 from BogdanB --- For me on version 6.3 it's ok. Version: 6.3.0.0.alpha0+ Build ID: 6b4ea2d8ddd681fec98773d7e0bbec9657a1fc08 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: ro-RO (ro_RO); UI-Language: en-US Calc: threaded See the attachament -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: tools/map.cpp
tools/map.cpp | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
New commits:
commit 6bc1fa6215faa69b9327fcdac428f89635dd03b0
Author: Miklos Vajna
AuthorDate: Mon Jan 14 08:43:40 2019 +0100
Commit: Miklos Vajna
CommitDate: Mon Jan 14 08:44:04 2019 +0100
tools: make members private in AddrSpace
Only _addrToStr needed a getter, the rest is not used externally.
Change-Id: Ie1c0f860c6aa0acc26c8c7272298225a4804a5e5
diff --git a/tools/map.cpp b/tools/map.cpp
index 5f1df765f..845adfa07 100644
--- a/tools/map.cpp
+++ b/tools/map.cpp
@@ -141,11 +141,13 @@ public:
};
struct AddrSpace {
+private:
unsigned _proc_id;
std::vector _maps;
std::unordered_map _addrToStr;
StringData _strings[3];
+public:
AddrSpace(unsigned proc_id) :
_proc_id(proc_id)
{
@@ -263,6 +265,8 @@ struct AddrSpace {
}
close (mem_fd);
}
+
+const std::unordered_map& getAddrToStr() const {
return _addrToStr; }
};
@@ -289,8 +293,8 @@ static void dumpDiff(const AddrSpace ,
for (unsigned int j = 0; j < width/8; j++)
{
std::string str;
-auto it = space._addrToStr.find(ptrs[j]);
-if (it != space._addrToStr.end())
+auto it = space.getAddrToStr().find(ptrs[j]);
+if (it != space.getAddrToStr().end())
{
str = it->second;
haveAnnots = true;
@@ -486,7 +490,7 @@ static void dump_unshared(unsigned proc_id, unsigned
parent_id,
if (DumpStrings)
{
printf("String dump:\n");
-for (const auto& addr : space._addrToStr)
+for (const auto& addr : space.getAddrToStr())
{
if (DumpAll ||
unShared.find((addr.first & ~0x1fff)) != unShared.end())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: uitest/test_main.py
uitest/test_main.py |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit b0f22a54c4c6f45f173b91d051b34d176cbab629
Author: Miklos Vajna
AuthorDate: Fri Jan 11 14:53:15 2019 +0100
Commit: Miklos Vajna
CommitDate: Mon Jan 14 08:42:36 2019 +0100
uitest: fail early in case a test file would be ignored
So the mistake I did in commit 457acbfa304ac8bda0755c9ca8f1e1e22e490ac8
(UITest_writer_tests: split this into 4 parts, 2018-07-03) does not
happen again.
Change-Id: Ia28ed1fe9909d9c46ebe95d3a1926b0dced46140
Reviewed-on: https://gerrit.libreoffice.org/66180
Reviewed-by: Markus Mohrhard
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/uitest/test_main.py b/uitest/test_main.py
index 934b27790961..bbfb8ad57072 100644
--- a/uitest/test_main.py
+++ b/uitest/test_main.py
@@ -45,9 +45,9 @@ def find_test_files(dir_path):
if not os.path.isfile(file_path):
continue
-# ignore any non .py files
+# fail on any non .py files
if not os.path.splitext(file_path)[1] == ".py":
-continue
+raise Exception("file with an extension which is not .py: " +
file_path)
# ignore the __init__.py file
# it is obviously not a test file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122685] 『Expansion Kit』 toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=122685 和尚蟹 changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122685] 『Expansion Kit』 toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=122685 --- Comment #3 from 和尚蟹 --- (In reply to Regina Henschel from comment #2) > I do not understand you. What is the purpose of the "Expansion Kit" toolbar? Like the toolbar of the browser, Because you can use the "snap button", So it will add a lot of features, E.g, Drop down menu carried out End ...and many more Can you use the "snap button", a lot worse. Focus I think the "Expansion Kit" toolbar will definitely attract more people to write programs. Because the browser has the "Expansion Kit" toolbar, it attracts more people to write programs, and Google uses this trick to defeat Microsoft. The "Expansion Kit" toolbar is also considered a "strategy." -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122698] Problematic behavior when inputting Chinese in a text block
https://bugs.documentfoundation.org/show_bug.cgi?id=122698 --- Comment #1 from Franklin Weng --- Created attachment 148298 --> https://bugs.documentfoundation.org/attachment.cgi?id=148298=edit Screencast - strange behavior of text block input -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - 2 commits - vcl/inc vcl/qt5
vcl/inc/qt5/Qt5Menu.hxx |2 +-
vcl/qt5/Qt5Menu.cxx | 23 +--
2 files changed, 18 insertions(+), 7 deletions(-)
New commits:
commit 9ddf669ee1a4490cfbfe0d7166ce7effcc717074
Author: Aleksei Nikiforov
AuthorDate: Thu Jan 10 15:54:56 2019 +0300
Commit: Michael Weghorn
CommitDate: Mon Jan 14 07:54:52 2019 +0100
Unregister action when menu item is removed
Change-Id: I9fc5e6630560f285eeb7ef4dbc5e39ccabd5f0df
Reviewed-on: https://gerrit.libreoffice.org/66147
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 35b59e56cc01e5ecf97583ab7b7884d301457089)
Reviewed-on: https://gerrit.libreoffice.org/66172
Reviewed-by: Aleksei Nikiforov
Reviewed-by: Michael Weghorn
diff --git a/vcl/qt5/Qt5Menu.cxx b/vcl/qt5/Qt5Menu.cxx
index d92c0c0e3a8b..6aa201f7ad30 100644
--- a/vcl/qt5/Qt5Menu.cxx
+++ b/vcl/qt5/Qt5Menu.cxx
@@ -185,7 +185,15 @@ void Qt5Menu::InsertItem(SalMenuItem* pSalMenuItem,
unsigned nPos)
void Qt5Menu::RemoveItem(unsigned nPos)
{
SolarMutexGuard aGuard;
-maItems.erase(maItems.begin() + nPos);
+
+if (nPos < maItems.size())
+{
+Qt5MenuItem* pItem = maItems[nPos];
+pItem->mpAction.reset();
+pItem->mpMenu.reset();
+
+maItems.erase(maItems.begin() + nPos);
+}
}
void Qt5Menu::SetSubMenu(SalMenuItem* pSalMenuItem, SalMenu* pSubMenu,
unsigned)
commit b6704c14ce2241e76904e494125a520814ec5021
Author: Aleksei Nikiforov
AuthorDate: Thu Jan 10 15:54:56 2019 +0300
Commit: Michael Weghorn
CommitDate: Mon Jan 14 07:54:39 2019 +0100
tdf#122253 KDE5: Correct parent menu before it's used
Also correct action group of menu
Change-Id: Ie7eddd3cdc9fa1c36fdeaa1e96eb5d50d7126c09
Reviewed-on: https://gerrit.libreoffice.org/66146
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit c278857137ea0e9e25613d5f6bf8ddaf1336fbcc)
Reviewed-on: https://gerrit.libreoffice.org/66173
Reviewed-by: Aleksei Nikiforov
Reviewed-by: Michael Weghorn
diff --git a/vcl/inc/qt5/Qt5Menu.hxx b/vcl/inc/qt5/Qt5Menu.hxx
index 9f7469fa3f78..b3b06bfeabac 100644
--- a/vcl/inc/qt5/Qt5Menu.hxx
+++ b/vcl/inc/qt5/Qt5Menu.hxx
@@ -33,7 +33,7 @@ private:
QMenu* mpQMenu;
QActionGroup* mpQActionGroup;
-void DoFullMenuUpdate(Menu* pMenuBar, QMenu* pParentMenu = nullptr);
+void DoFullMenuUpdate(Menu* pMenuBar);
static void NativeItemText(OUString& rItemText);
QMenu* InsertMenuItem(Qt5MenuItem* pSalMenuItem, unsigned nPos);
diff --git a/vcl/qt5/Qt5Menu.cxx b/vcl/qt5/Qt5Menu.cxx
index 130d7c583f58..d92c0c0e3a8b 100644
--- a/vcl/qt5/Qt5Menu.cxx
+++ b/vcl/qt5/Qt5Menu.cxx
@@ -219,18 +219,17 @@ void Qt5Menu::SetFrame(const SalFrame* pFrame)
if (pMainWindow)
{
mpQMenuBar = pMainWindow->menuBar();
+mpQMenu = nullptr;
+mpQActionGroup = nullptr;
DoFullMenuUpdate(mpVCLMenu);
}
}
-void Qt5Menu::DoFullMenuUpdate(Menu* pMenuBar, QMenu* pParentMenu)
+void Qt5Menu::DoFullMenuUpdate(Menu* pMenuBar)
{
-mpQMenu = pParentMenu;
-
if (mbMenuBar && mpQMenuBar)
mpQMenuBar->clear();
-mpQActionGroup = nullptr;
for (sal_Int32 nItem = 0; nItem < static_cast(GetItemCount());
nItem++)
{
@@ -240,8 +239,12 @@ void Qt5Menu::DoFullMenuUpdate(Menu* pMenuBar, QMenu*
pParentMenu)
if (pSalMenuItem->mpSubMenu != nullptr)
{
+// correct parent menu and action group before calling
HandleMenuActivateEvent
+pSalMenuItem->mpSubMenu->mpQMenu = pQMenu;
+pSalMenuItem->mpSubMenu->mpQActionGroup = nullptr;
+
pMenuBar->HandleMenuActivateEvent(pSalMenuItem->mpSubMenu->GetMenu());
-pSalMenuItem->mpSubMenu->DoFullMenuUpdate(pMenuBar, pQMenu);
+pSalMenuItem->mpSubMenu->DoFullMenuUpdate(pMenuBar);
pMenuBar->HandleMenuDeActivateEvent(pSalMenuItem->mpSubMenu->GetMenu());
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90931] 'Apply Style' drop down doesnt show accurate style previews
https://bugs.documentfoundation.org/show_bug.cgi?id=90931 --- Comment #5 from russell --- As of 6.1.4.2, Calc Styles and Formatting (F11) does not show previews, even if Show Previews is checked. Similar to bug report: https://bugs.documentfoundation.org/show_bug.cgi?id=107540 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122698] New: Problematic behavior when inputting Chinese in a text block
https://bugs.documentfoundation.org/show_bug.cgi?id=122698 Bug ID: 122698 Summary: Problematic behavior when inputting Chinese in a text block Product: LibreOffice Version: 6.2.0.2 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: frank...@goodhorse.idv.tw Description: In Writer 6.2 rc2, it is okay to input under normal mode. However when inputting in a text block, the behavior is strange: * Inputting English was okay. * When inputting Chinese (via input method), the first Chinese character would be "eaten" and was not shown. The second Chinese character could be shown. * After pressing Enter to next (several) lines, when I input another Chinese character the cursor would jump back to the position of last Chinese character. * If I input English characters at the previous step then there was nothing weird. But when I use Ctrl-Space again to switch my input method to Chinese input mode, the cursor jumped back again. In Impress and Draw the behavior of inputting in a text block was the similar, except the first Chinese character wouldn't be eaten. Steps to Reproduce: 1. Open Writer 6.2 rc2 and insert a text block. 2. Input a Chinese character via input method (my IM engine is gcin) 3. The first Chinese character would be eaten, but the characters afterwards can be shown 4. Press Enter (one or several times) 5. Input another Chinese character again 6. The cursor would jump back to the position of last Chinese character and new character would be shown in the same line Actual Results: * In Writer the first Chinese character input in a text block would be gone, and others would be shown. * Pressing Enter to change line was useless since when inputting another Chinese character the cursor would jump back. * In Impress and Draw the first Chinese character would be shown correctly, but changing lines was still useless. Expected Results: It should act normally Reproducible: Always User Profile Reset: Yes Additional Info: Only happened in VCL kde5 backend. kde4 and gtk3 would not happen. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/sdwindow.cxx |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
New commits:
commit 61778fd20395794d2de3b52d60dcc65083aecd93
Author: Mike Kaganski
AuthorDate: Mon Jan 14 06:44:26 2019 +0100
Commit: Mike Kaganski
CommitDate: Mon Jan 14 07:41:51 2019 +0100
Simplify sd::Window::RequestHelp
Change-Id: I0d42c5a3133d97464d105a1ff29772c1b63a3a69
Reviewed-on: https://gerrit.libreoffice.org/66282
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sd/source/ui/view/sdwindow.cxx b/sd/source/ui/view/sdwindow.cxx
index f295d00cf4d1..227291d4de41 100644
--- a/sd/source/ui/view/sdwindow.cxx
+++ b/sd/source/ui/view/sdwindow.cxx
@@ -280,12 +280,7 @@ bool Window::EventNotify( NotifyEvent& rNEvt )
void Window::RequestHelp(const HelpEvent& rEvt)
{
-if ( mpViewShell )
-{
-if( !mpViewShell->RequestHelp( rEvt ) )
-vcl::Window::RequestHelp( rEvt );
-}
-else
+if (!mpViewShell || !mpViewShell->RequestHelp(rEvt))
vcl::Window::RequestHelp( rEvt );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107540] UI: Sidebar doesn't show cell styles formatted with 'Show preview' checked.
https://bugs.documentfoundation.org/show_bug.cgi?id=107540 --- Comment #5 from russell --- As of 6.1.4.2, Calc Styles and Formatting (F11) does not show previews, even if Show Previews is checked. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117147] latest update won't open the DOCX documents, crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=117147
--- Comment #20 from Roman Kuznetsov <79045_79...@mail.ru> ---
(In reply to Roman Kuznetsov from comment #19)
> fast opening and no crash in
>
> Версия: 6.1.3.1 (x64)
> ID сборки: a9670562c26181ec3afbe381c9ff499ae88c98b7
> Потоков ЦП: 4; ОС:Windows 10.0; Отрисовка ИП: GL;
> Локаль: ru-RU (ru_RU); Calc: threaded
>
> DriverVersion: 24.20.100.6286
> DriverDate: 8-15-2018
> DeviceID: PCI\VEN_8086_591B_1A101043_04
> AdapterVendorID: 0x8086
> AdapterDeviceID: 0x591b
> AdapterSubsysID: 0x1a101043
> DeviceKey:
> System\CurrentControlSet\Control\Video\{F8C86852-6691-11E8-B80B-
> E25B7CE3019B}\
> DeviceString: Intel(R) HD Graphics 630
fast opening and no crash in
Version: 6.2.0.1
Build ID: 0412ee99e862f384c1106d0841a950c4cfaa9df1
CPU threads: 4; OS: Windows 6.1; UI render: GL; VCL: win;
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded
DriverVersion: 10.18.10.4425
DriverDate: 4-4-2016
DeviceID: PCI\VEN_8086_0166_21F717AA_09
AdapterVendorID: 0x8086
AdapterDeviceID: 0x0166
AdapterSubsysID: 0x21f717aa
DeviceKey:
System\CurrentControlSet\Control\Video\{92E621FD-7AE7-489A-8F2F-47AFD10834D8}\
DeviceString: Intel(R) HD Graphics 4000
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122697] Clear Direct Formatting removes Conditional Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=122697 --- Comment #2 from russell --- Created attachment 148297 --> https://bugs.documentfoundation.org/attachment.cgi?id=148297=edit Sample spreadsheet -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122697] Clear Direct Formatting removes Conditional Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=122697 --- Comment #1 from russell --- Created attachment 148296 --> https://bugs.documentfoundation.org/attachment.cgi?id=148296=edit Image of spreadsheet -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122697] New: Clear Direct Formatting removes Conditional Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=122697 Bug ID: 122697 Summary: Clear Direct Formatting removes Conditional Formatting Product: LibreOffice Version: 6.1.4.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: prusselltechgr...@gmail.com Description: Clear Direct Formatting removes Conditional Formatting. Conditional Format itself is deleted when entire spreadsheet is selected. Steps to Reproduce: 1. Create a spreadsheet with Conditional Formatting (i.e., change background for odd rows) for the range A2:E9 2. Right-click E5 and select Clear Direct Formatting. 3. The Conditional Format will no longer appy to E5. Checking the conditional format will show the range changed from A2:E9 to A2:D9,E2:E4,E6:E9. Please see attached sample spreadsheet and image. Actual Results: Conditional Format is removed. If the entire spreadsheet is selected and Clear Direct Formatting is selected, the Conditional Format itself will be deleted. Expected Results: Conditional Format is not removed. The range stays the same. The Conditional Format itself is NOT deleted. Reproducible: Always User Profile Reset: No Additional Info: >From the Help: Clear Direct Formatting Removes direct formatting and formatting by character styles from the selection. Direct formatting is formatting that you applied without using styles, such as setting bold typeface by clicking the Bold icon. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source
chart2/source/model/template/ChartTypeTemplate.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 101c8679d29b7aadd85628083efa1b73c8b3863b Author: Andrea Gelmini AuthorDate: Wed Jan 9 07:47:28 2019 + Commit: Julien Nabet CommitDate: Mon Jan 14 07:15:14 2019 +0100 Fix typo Change-Id: Ibf7d46963bfb3cb75170c43ba8a3279f1c34 Reviewed-on: https://gerrit.libreoffice.org/66281 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/chart2/source/model/template/ChartTypeTemplate.hxx b/chart2/source/model/template/ChartTypeTemplate.hxx index fc2e33b83bc8..705bdbd6b3fe 100644 --- a/chart2/source/model/template/ChartTypeTemplate.hxx +++ b/chart2/source/model/template/ChartTypeTemplate.hxx @@ -213,7 +213,7 @@ protected: */ virtual sal_Int32 getAxisCountByDimension( sal_Int32 nDimension ); -/** adapt properties of exsisting axes and remove superfluous axes +/** adapt properties of existing axes and remove superfluous axes */ virtual void adaptAxes( const css::uno::Sequence< css::uno::Reference< css::chart2::XCoordinateSystem > > & rCoordSys ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/docshell/dbdocfun.cxx | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
New commits:
commit 4824d5ea717eedd245421272f25d99c0f72642bb
Author: Martin van Zijl
AuthorDate: Thu Nov 22 09:42:34 2018 +1300
Commit: Noel Grandin
CommitDate: Mon Jan 14 07:05:44 2019 +0100
tdf#119804 allow sort when header row protected
Change-Id: I303c11f8dbe4ccd302961b4afc0f67cd9c5d2582
Reviewed-on: https://gerrit.libreoffice.org/66133
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/source/ui/docshell/dbdocfun.cxx
b/sc/source/ui/docshell/dbdocfun.cxx
index 5060c53ff205..aec29c4434e8 100644
--- a/sc/source/ui/docshell/dbdocfun.cxx
+++ b/sc/source/ui/docshell/dbdocfun.cxx
@@ -504,7 +504,18 @@ bool ScDBDocFunc::Sort( SCTAB nTab, const ScSortParam&
rSortParam,
nTab = aLocalParam.nDestTab;
}
-ScEditableTester aTester( , nTab, aLocalParam.nCol1,aLocalParam.nRow1,
+// tdf#119804: If there is a header row/column, it won't be affected by
+// sorting; so we can exclude it from the test.
+SCROW nStartingRowToEdit = aLocalParam.nRow1;
+SCROW nStartingColToEdit = aLocalParam.nCol1;
+if ( aLocalParam.bHasHeader )
+{
+if ( aLocalParam.bByRow )
+nStartingRowToEdit++;
+else
+nStartingColToEdit++;
+}
+ScEditableTester aTester( , nTab,
nStartingColToEdit,nStartingRowToEdit,
aLocalParam.nCol2,aLocalParam.nRow2 );
if (!aTester.IsEditable())
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/filter/html/parcss1.cxx | 54 +++---
sw/source/filter/html/parcss1.hxx | 12 +++-
sw/source/filter/html/svxcss1.cxx | 25 +++--
sw/source/filter/html/svxcss1.hxx | 11 ++-
sw/source/filter/xml/xmlfmt.cxx |7 ++--
5 files changed, 38 insertions(+), 71 deletions(-)
New commits:
commit 57cf9acfde03dd4247b4a40ca10bb3fd2f8bed17
Author: Noel Grandin
AuthorDate: Fri Jan 11 15:27:27 2019 +0200
Commit: Noel Grandin
CommitDate: Mon Jan 14 07:02:26 2019 +0100
use unique_ptr in SwXMLItemSetStyleContext_Impl::ConnectPageDesc
Change-Id: Ie633140acbb3254fb90056a601d58843cf8116cf
Reviewed-on: https://gerrit.libreoffice.org/66187
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/filter/xml/xmlfmt.cxx b/sw/source/filter/xml/xmlfmt.cxx
index b9f584e5a672..35257d16dfdc 100644
--- a/sw/source/filter/xml/xmlfmt.cxx
+++ b/sw/source/filter/xml/xmlfmt.cxx
@@ -614,21 +614,20 @@ void SwXMLItemSetStyleContext_Impl::ConnectPageDesc()
}
const SfxPoolItem *pItem;
-SwFormatPageDesc *pFormatPageDesc = nullptr;
+std::unique_ptr pFormatPageDesc;
if( SfxItemState::SET == pItemSet->GetItemState( RES_PAGEDESC, false,
) )
{
if( static_cast(pItem)->GetPageDesc() !=
pPageDesc )
-pFormatPageDesc = new SwFormatPageDesc( *static_cast(pItem) );
+pFormatPageDesc.reset(new SwFormatPageDesc( *static_cast(pItem) ));
}
else
-pFormatPageDesc = new SwFormatPageDesc();
+pFormatPageDesc.reset(new SwFormatPageDesc());
if( pFormatPageDesc )
{
pFormatPageDesc->RegisterToPageDesc( *pPageDesc );
pItemSet->Put( *pFormatPageDesc );
-delete pFormatPageDesc;
}
}
commit 0f257c1dce36b69741a96ec9c10158867c48f610
Author: Noel Grandin
AuthorDate: Fri Jan 11 13:28:39 2019 +0200
Commit: Noel Grandin
CommitDate: Mon Jan 14 07:02:20 2019 +0100
use unique_ptr in CSS1Parser
Change-Id: I4553233f7cf2f54a94154f41e899183490eec3e9
Reviewed-on: https://gerrit.libreoffice.org/66184
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/filter/html/parcss1.cxx
b/sw/source/filter/html/parcss1.cxx
index ba64adad7be6..9a14ddc1be07 100644
--- a/sw/source/filter/html/parcss1.cxx
+++ b/sw/source/filter/html/parcss1.cxx
@@ -733,13 +733,12 @@ void CSS1Parser::ParseStyleSheet()
void CSS1Parser::ParseRule()
{
// selector
-CSS1Selector *pSelector = ParseSelector();
+std::unique_ptr pSelector = ParseSelector();
if( !pSelector )
return;
// process selector
-if( SelectorParsed( pSelector, true ) )
-delete pSelector;
+SelectorParsed( std::move(pSelector), true );
LOOP_CHECK_DECL
@@ -757,8 +756,7 @@ void CSS1Parser::ParseRule()
return;
// process selector
-if( SelectorParsed( pSelector, false ) )
-delete pSelector;
+SelectorParsed( std::move(pSelector), false );
}
// '{'
@@ -768,13 +766,12 @@ void CSS1Parser::ParseRule()
// declaration
OUString aProperty;
-CSS1Expression *pExpr = ParseDeclaration( aProperty );
+std::unique_ptr pExpr = ParseDeclaration( aProperty );
if( !pExpr )
return;
// process expression
-if( DeclarationParsed( aProperty, pExpr ) )
-delete pExpr;
+DeclarationParsed( aProperty, std::move(pExpr) );
LOOP_CHECK_RESTART
@@ -789,12 +786,11 @@ void CSS1Parser::ParseRule()
// declaration
if( CSS1_IDENT == nToken )
{
-CSS1Expression *pExp = ParseDeclaration( aProperty );
+std::unique_ptr pExp = ParseDeclaration( aProperty
);
if( pExp )
{
// process expression
-if( DeclarationParsed( aProperty, pExp ) )
-delete pExp;
+DeclarationParsed( aProperty, std::move(pExp));
}
}
}
@@ -824,9 +820,10 @@ void CSS1Parser::ParseRule()
// pseude_element
// : IDENT
-CSS1Selector *CSS1Parser::ParseSelector()
+std::unique_ptr CSS1Parser::ParseSelector()
{
-CSS1Selector *pRoot = nullptr, *pLast = nullptr;
+std::unique_ptr pRoot;
+CSS1Selector *pLast = nullptr;
bool bDone = false;
CSS1Selector *pNew = nullptr;
@@ -932,7 +929,7 @@ CSS1Selector *CSS1Parser::ParseSelector()
if( pLast )
pLast->SetNext( pNew );
else
-pRoot = pNew;
+pRoot.reset(pNew);
pLast = pNew;
pNew = nullptr;
@@ -991,9 +988,10 @@ CSS1Selector *CSS1Parser::ParseSelector()
// the sign is only used for numeric values (except PERCENTAGE)
// and it's applied on nValue!
-CSS1Expression *CSS1Parser::ParseDeclaration( OUString& rProperty )
+std::unique_ptr CSS1Parser::ParseDeclaration( OUString&
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/app/mainwn.cxx | 54
1 file changed, 27 insertions(+), 27 deletions(-)
New commits:
commit 101cd1b9cfb2b080a838f3253e6d7f37f483a372
Author: Noel Grandin
AuthorDate: Fri Jan 11 15:38:54 2019 +0200
Commit: Noel Grandin
CommitDate: Mon Jan 14 07:02:36 2019 +0100
use unique_ptr in SwProgress
Change-Id: I7a5d271b2da175e064d50e8b99460e4e024237fb
Reviewed-on: https://gerrit.libreoffice.org/66188
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/uibase/app/mainwn.cxx b/sw/source/uibase/app/mainwn.cxx
index 36a34038f856..8adb6212e4ad 100644
--- a/sw/source/uibase/app/mainwn.cxx
+++ b/sw/source/uibase/app/mainwn.cxx
@@ -30,17 +30,17 @@ struct SwProgress
long nStartValue,
nStartCount;
SwDocShell *pDocShell;
-SfxProgress *pProgress;
+std::unique_ptr pProgress;
};
-static std::vector *pProgressContainer = nullptr;
+static std::vector> *pProgressContainer = nullptr;
static SwProgress *lcl_SwFindProgress( SwDocShell const *pDocShell )
{
-for (SwProgress* pTmp : *pProgressContainer)
+for (auto& pTmp : *pProgressContainer)
{
if ( pTmp->pDocShell == pDocShell )
-return pTmp;
+return pTmp.get();
}
return nullptr;
}
@@ -48,29 +48,31 @@ static SwProgress *lcl_SwFindProgress( SwDocShell const
*pDocShell )
void StartProgress( const char* pMessResId, long nStartValue, long nEndValue,
SwDocShell *pDocShell )
{
-if( !SW_MOD()->IsEmbeddedLoadSave() )
+if( SW_MOD()->IsEmbeddedLoadSave() )
+return;
+
+SwProgress *pProgress = nullptr;
+
+if ( !pProgressContainer )
+pProgressContainer = new std::vector>;
+else
{
-SwProgress *pProgress = nullptr;
+pProgress = lcl_SwFindProgress( pDocShell );
+if ( pProgress )
+++pProgress->nStartCount;
+}
-if ( !pProgressContainer )
-pProgressContainer = new std::vector;
-else
-{
-if ( nullptr != (pProgress = lcl_SwFindProgress( pDocShell )) )
-++pProgress->nStartCount;
-}
-if ( !pProgress )
-{
-pProgress = new SwProgress;
-pProgress->pProgress = new SfxProgress( pDocShell,
-SwResId(pMessResId),
-nEndValue - nStartValue );
-pProgress->nStartCount = 1;
-pProgress->pDocShell = pDocShell;
-pProgressContainer->insert( pProgressContainer->begin(), pProgress
);
-}
-pProgress->nStartValue = nStartValue;
+if ( !pProgress )
+{
+pProgress = new SwProgress;
+pProgress->pProgress.reset( new SfxProgress( pDocShell,
+SwResId(pMessResId),
+nEndValue - nStartValue ) );
+pProgress->nStartCount = 1;
+pProgress->pDocShell = pDocShell;
+pProgressContainer->insert( pProgressContainer->begin(),
std::unique_ptr(pProgress) );
}
+pProgress->nStartValue = nStartValue;
}
void SetProgressState( long nPosition, SwDocShell const *pDocShell )
@@ -91,7 +93,7 @@ void EndProgress( SwDocShell const *pDocShell )
std::vector::size_type i;
for ( i = 0; i < pProgressContainer->size(); ++i )
{
-SwProgress *pTmp = (*pProgressContainer)[i];
+SwProgress *pTmp = (*pProgressContainer)[i].get();
if ( pTmp->pDocShell == pDocShell )
{
pProgress = pTmp;
@@ -103,8 +105,6 @@ void EndProgress( SwDocShell const *pDocShell )
{
pProgress->pProgress->Stop();
pProgressContainer->erase( pProgressContainer->begin() + i );
-delete pProgress->pProgress;
-delete pProgress;
//#112337# it may happen that the container has been removed
//while rescheduling
if ( pProgressContainer && pProgressContainer->empty() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #204 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/c73cc08f0a4af4578e1d061d042f2c11ce0b51ae%5E%21 tdf#45904 Move XNameAccess Java tests to C++ It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/extras/scdatapilottablesobj.cxx | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
New commits:
commit 74db00dc36cec6390329e44636deda7f43e2891a
Author: Jens Carl
AuthorDate: Sun Jan 13 20:26:44 2019 +
Commit: Jens Carl
CommitDate: Mon Jan 14 05:20:39 2019 +0100
Add XServiceInfo tests to ScDataPilotTablesObj
Change-Id: Ic7a786d63b17760c2b18fd60bb3e2e01947522ae
Reviewed-on: https://gerrit.libreoffice.org/66274
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/sc/qa/extras/scdatapilottablesobj.cxx
b/sc/qa/extras/scdatapilottablesobj.cxx
index 9713fbd3177d..3aed492b7e06 100644
--- a/sc/qa/extras/scdatapilottablesobj.cxx
+++ b/sc/qa/extras/scdatapilottablesobj.cxx
@@ -12,6 +12,7 @@
#include
#include
#include
+#include
#include
#include
@@ -42,7 +43,8 @@ class ScDataPilotTablesObj : public CalcUnoApiTest,
public apitest::XElementAccess,
public apitest::XEnumerationAccess,
public apitest::XIndexAccess,
- public apitest::XNameAccess
+ public apitest::XNameAccess,
+ public apitest::XServiceInfo
{
public:
ScDataPilotTablesObj();
@@ -73,6 +75,11 @@ public:
CPPUNIT_TEST(testGetElementNames);
CPPUNIT_TEST(testHasByName);
+// XServiceInfo
+CPPUNIT_TEST(testGetImplementationName);
+CPPUNIT_TEST(testGetSupportedServiceNames);
+CPPUNIT_TEST(testSupportsService);
+
CPPUNIT_TEST_SUITE_END();
private:
@@ -84,6 +91,7 @@ ScDataPilotTablesObj::ScDataPilotTablesObj()
, XElementAccess(cppu::UnoType::get())
, XIndexAccess(1)
, XNameAccess("DataPilotTable")
+, XServiceInfo("ScDataPilotTablesObj",
"com.sun.star.sheet.DataPilotTables")
{
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/qa qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa
framework/qa/complex/api_internal/api.lst|1 qadevOOo/Jar_OOoRunner.mk|1 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv |3 qadevOOo/tests/java/mod/_sc/ScDataPilotTablesObj.java| 157 -- sc/qa/extras/scdatapilottablesobj.cxx| 10 sc/qa/unoapi/sc_4.sce|1 6 files changed, 9 insertions(+), 164 deletions(-) New commits: commit c73cc08f0a4af4578e1d061d042f2c11ce0b51ae Author: Jens Carl AuthorDate: Sun Jan 13 19:25:12 2019 + Commit: Jens Carl CommitDate: Mon Jan 14 05:19:50 2019 +0100 tdf#45904 Move XNameAccess Java tests to C++ Move XNameAccess Java tests to C++ for ScDataPilotTablesObj. Change-Id: I43bd4ca0688e38792080710c288ca746f95460d9 Reviewed-on: https://gerrit.libreoffice.org/66273 Tested-by: Jenkins Reviewed-by: Jens Carl diff --git a/framework/qa/complex/api_internal/api.lst b/framework/qa/complex/api_internal/api.lst index 113755a44ddb..6b9a152fbeb9 100644 --- a/framework/qa/complex/api_internal/api.lst +++ b/framework/qa/complex/api_internal/api.lst @@ -80,7 +80,6 @@ job85=sc.ScCellSearchObj job88=sc.ScDatabaseRangeObj job90=sc.ScDataPilotFieldObj job91=sc.ScDataPilotFieldsObj -job92=sc.ScDataPilotTablesObj job94=sc.ScDDELinksObj job95=sc.ScDrawPagesObj job96=sc.ScFilterDescriptorBase diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk index 12bd022d00f0..a4c227a8f463 100644 --- a/qadevOOo/Jar_OOoRunner.mk +++ b/qadevOOo/Jar_OOoRunner.mk @@ -974,7 +974,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\ qadevOOo/tests/java/mod/_sc/ScDataPilotFieldsObj \ qadevOOo/tests/java/mod/_sc/ScDataPilotItemObj \ qadevOOo/tests/java/mod/_sc/ScDataPilotItemsObj \ -qadevOOo/tests/java/mod/_sc/ScDataPilotTablesObj \ qadevOOo/tests/java/mod/_sc/ScDDELinksObj \ qadevOOo/tests/java/mod/_sc/ScDocumentConfiguration \ qadevOOo/tests/java/mod/_sc/ScDrawPageObj \ diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv deleted file mode 100644 index bf88fcd3661a.. --- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv +++ /dev/null @@ -1,3 +0,0 @@ -"ScDataPilotTablesObj";"com::sun::star::container::XNameAccess";"getByName()" -"ScDataPilotTablesObj";"com::sun::star::container::XNameAccess";"getElementNames()" -"ScDataPilotTablesObj";"com::sun::star::container::XNameAccess";"hasByName()" diff --git a/qadevOOo/tests/java/mod/_sc/ScDataPilotTablesObj.java b/qadevOOo/tests/java/mod/_sc/ScDataPilotTablesObj.java deleted file mode 100644 index 7bcd96b85391.. --- a/qadevOOo/tests/java/mod/_sc/ScDataPilotTablesObj.java +++ /dev/null @@ -1,157 +0,0 @@ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -package mod._sc; - -import java.io.PrintWriter; - -import lib.TestCase; -import lib.TestEnvironment; -import lib.TestParameters; -import util.SOfficeFactory; - -import com.sun.star.container.XIndexAccess; -import com.sun.star.lang.XComponent; -import com.sun.star.sheet.XDataPilotDescriptor; -import com.sun.star.sheet.XDataPilotTables; -import com.sun.star.sheet.XDataPilotTablesSupplier; -import com.sun.star.sheet.XSpreadsheet; -import com.sun.star.sheet.XSpreadsheetDocument; -import com.sun.star.sheet.XSpreadsheets; -import com.sun.star.table.CellAddress; -import com.sun.star.table.CellRangeAddress; -import com.sun.star.uno.AnyConverter; -import com.sun.star.uno.Type; -import com.sun.star.uno.UnoRuntime; -import com.sun.star.uno.XInterface; - -/** -* Test for object which is represented by service -* com.sun.star.sheet.DataPilotTables. -* Object implements the following interfaces : -* -* com::sun::star::sheet::XDataPilotTables -* com::sun::star::container::XNameAccess -* com::sun::star::container::XElementAccess -* -* @see com.sun.star.sheet.DataPilotTables -* @see com.sun.star.sheet.XDataPilotTables -* @see com.sun.star.container.XNameAccess -* @see
[Libreoffice-bugs] [Bug 55954] EDITING: CJK text has wrong style applied when copied from Writer to Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=55954 --- Comment #11 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114975] Fileopen: Arrows with shapes from docx slightly misplaced
https://bugs.documentfoundation.org/show_bug.cgi?id=114975 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92784] Base: Truncated string in forms wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=92784 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100678] FILEOPEN Endless pagination loop until resources are depleted
https://bugs.documentfoundation.org/show_bug.cgi?id=100678 --- Comment #17 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78755] [FILEOPEN]: DOCX import filter - the 2nd table is placed on the page incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=78755 --- Comment #8 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55359] Word count gives wrong results
https://bugs.documentfoundation.org/show_bug.cgi?id=55359 --- Comment #15 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94437] Editing: entries from a deleted alphabetic index reappear when a new index is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=94437 --- Comment #17 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108533] OpenGL option won't stay active after restart
https://bugs.documentfoundation.org/show_bug.cgi?id=108533 --- Comment #13 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90262] Some animated gif files do not loop infinitely when inserted in the presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=90262 --- Comment #11 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sw/source
sw/source/uibase/docvw/PostItMgr.cxx | 34 +++---
1 file changed, 31 insertions(+), 3 deletions(-)
New commits:
commit 3ddbd377abfbf462f83e3190aa2fd31da876fd6d
Author: Michael Stahl
AuthorDate: Fri Jan 11 15:22:59 2019 +0100
Commit: Thorsten Behrens
CommitDate: Mon Jan 14 02:08:43 2019 +0100
sw_redlinehide: fix infinite loop when deleting comments
The problem is that sw::UpdateFramesForAddDeleteRedline() sends a
SwFormatFieldHintWhich::REMOVED event in order to remove any comments
that may have been deleted from the document view.
Unfortunately there's another listener in class FieldDocWatchingStack
that is used during various SwPostItMgr::Delete* functions, which will
effectively start over from scratch if it receives this event, so it
is an infinite loop.
Avoid this by simply ignoring any redline-deleted fields; deleting them
again won't provide any benefit anyway.
This can be seen with UITest
deleteAllComments.DeleteAllComments.test_comment_trackchanges.
(regression from 9b67b6a6d4b912f1e515d3884fa02c1be8aa6921)
Change-Id: Ie1d5676d1d79a51e2e4a01a3e282f8739ff08899
Reviewed-on: https://gerrit.libreoffice.org/66178
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 484fb55168b18bbd8c6160e5a3958a5188987ab5)
Reviewed-on: https://gerrit.libreoffice.org/66193
Reviewed-by: Thorsten Behrens
diff --git a/sw/source/uibase/docvw/PostItMgr.cxx
b/sw/source/uibase/docvw/PostItMgr.cxx
index 7a963e335b5c..600b4ced6b37 100644
--- a/sw/source/uibase/docvw/PostItMgr.cxx
+++ b/sw/source/uibase/docvw/PostItMgr.cxx
@@ -1384,6 +1384,28 @@ public:
}
};
+class IsFieldNotDeleted : public FilterFunctor
+{
+private:
+IDocumentRedlineAccess const& m_rIDRA;
+FilterFunctor const& m_rNext;
+
+public:
+IsFieldNotDeleted(IDocumentRedlineAccess const& rIDRA,
+FilterFunctor & rNext)
+: m_rIDRA(rIDRA)
+, m_rNext(rNext)
+{
+}
+bool operator()(const SwFormatField* pField) const override
+{
+if (!m_rNext(pField))
+return false;
+if (!pField->GetTextField())
+return false;
+return !sw::IsFieldDeletedInModel(m_rIDRA, *pField->GetTextField());
+}
+};
//Manages the passed in vector by automatically removing entries if they are
deleted
//and automatically adding entries if they appear in the document and match the
@@ -1494,7 +1516,9 @@ void SwPostItMgr::Delete(const OUString& rAuthor)
mpWrtShell->StartUndo( SwUndoId::DELETE, );
IsPostitFieldWithAuthorOf aFilter(rAuthor);
-FieldDocWatchingStack aStack(mvPostItFields, *mpView->GetDocShell(),
aFilter);
+IDocumentRedlineAccess const&
rIDRA(mpWrtShell->getIDocumentRedlineAccess());
+IsFieldNotDeleted aFilter2(rIDRA, aFilter);
+FieldDocWatchingStack aStack(mvPostItFields, *mpView->GetDocShell(),
aFilter2);
while (const SwFormatField* pField = aStack.pop())
{
if (mpWrtShell->GotoField(*pField))
@@ -1521,7 +1545,9 @@ void SwPostItMgr::Delete(sal_uInt32 nPostItId)
mpWrtShell->StartUndo( SwUndoId::DELETE, );
IsPostitFieldWithPostitId aFilter(nPostItId);
-FieldDocWatchingStack aStack(mvPostItFields, *mpView->GetDocShell(),
aFilter);
+IDocumentRedlineAccess const&
rIDRA(mpWrtShell->getIDocumentRedlineAccess());
+IsFieldNotDeleted aFilter2(rIDRA, aFilter);
+FieldDocWatchingStack aStack(mvPostItFields, *mpView->GetDocShell(),
aFilter2);
const SwFormatField* pField = aStack.pop();
if (pField && mpWrtShell->GotoField(*pField))
mpWrtShell->DelRight();
@@ -1542,8 +1568,10 @@ void SwPostItMgr::Delete()
mpWrtShell->StartUndo( SwUndoId::DELETE, );
IsPostitField aFilter;
+IDocumentRedlineAccess const&
rIDRA(mpWrtShell->getIDocumentRedlineAccess());
+IsFieldNotDeleted aFilter2(rIDRA, aFilter);
FieldDocWatchingStack aStack(mvPostItFields, *mpView->GetDocShell(),
-aFilter);
+aFilter2);
while (const SwFormatField* pField = aStack.pop())
{
if (mpWrtShell->GotoField(*pField))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override
Hello, LO 6.0.7.3 fails compiling with gcc 8.2.1 20190101 I emitting: [build SPP] scp2/source/ooo/ure [build SCP] scp2/source/writer/file_writer [build SPP] scp2/source/xsltfilter/file_xsltfilter [build SPP] scp2/source/xsltfilter/module_xsltfilter [build SPP] scp2/source/gnome/file_gnome [build SPP] scp2/source/gnome/module_gnome [build SPP] scp2/source/sdkoo/sdkoo [build SCP] scp2/source/writer/module_writer [build CXX] sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx In file included from /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx:24, from /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20: /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override virtual void drawString(GfxState *state, const GooString *s) override; ^~ /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22: warning: by ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ [-Woverloaded-virtual] make[1]: *** [/src/libreoffice-6.0.7.3/solenv/gbuild/LinkTarget.mk:293: /src/libreoffice- 6.0.7.3/workdir/CxxObject/sdext/source/pdfimport/xpdfwrapper/pnghelper.o] Error 1 make[1]: *** Waiting for unfinished jobs [build CXX] sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx In file included from /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx:20: /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override virtual void drawString(GfxState *state, const GooString *s) override; ^~ /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22: warning: by ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ [-Woverloaded-virtual] make[1]: *** [/src/libreoffice-6.0.7.3/solenv/gbuild/LinkTarget.mk:293: /src/libreoffice- 6.0.7.3/workdir/CxxObject/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.o] Error 1 [build CXX] sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx In file included from /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:20: /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override virtual void drawString(GfxState *state, const GooString *s) override; ^~ /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22: warning: by ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ [-Woverloaded-virtual] make[1]: *** [/src/libreoffice-6.0.7.3/solenv/gbuild/LinkTarget.mk:293: /src/libreoffice- 6.0.7.3/workdir/CxxObject/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.o] Error 1 [ https://bugs.documentfoundation.org/show_bug.cgi?id=122690 ] Regards Дилян ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 122692] Crash in: SvTreeList::Remove(SvTreeListEntry const *)
https://bugs.documentfoundation.org/show_bug.cgi?id=122692 --- Comment #2 from lindsaybige...@cad2data.com --- (In reply to Xisco Faulí from comment #1) > Thank you for reporting the bug. To be certain the reported issue is not > related to corruption in the user profile, could you please reset your > Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and > re-test? > > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' if the issue is still present Have restarted in Safe mode. Will come back in a few days with a report. Cheers! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120479] Crash in: libc-2.27.so
https://bugs.documentfoundation.org/show_bug.cgi?id=120479 --- Comment #20 from Franklin Weng --- (In reply to Xisco Faulí from comment #18) > Does it happen with LibreOffice 6.2.0.1 from > https://wiki.documentfoundation.org/QA/GetInvolved#Test_Pre-releases ? It crashed too often for me... crashreport.libreoffice.org/stats/crash_details/c1841129-d9d8-4d04-8dc2-46a9f4c484d6 The same version / hardware info as the last comment. Might be kde5 backend related as well? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122684] Copying range using VBA doesn't work correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=122684
--- Comment #5 from Gunnar ---
Thanks!
But the code fails to remove the contents of the copied range.
rSrc = "B2:C5"
rDst = "E2"
Worksheets("Sheet1").Range(rSrc).Copy
destination:=Worksheets("Sheet2").Range(rDSt)
Worksheets("Sheet2").Range(rDst).ClearContents
rDst points to upper left corner in the destination sheet, which is cleared.
rScr and rDst are not equal!
To make it work, you need to set rDst = "E2:F5" (same size)
But anyway, it's close to a solution.
This bug cost me a lot of trouble because what was copied was changing all the
time since the selected range was random, and I couldn't get hold of what was
going on. I was close to giving up until, by luck, the selected cell had a
different background color. Viola!
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: source/text
source/text/shared/optionen/01010200.xhp | 69 ++- 1 file changed, 33 insertions(+), 36 deletions(-) New commits: commit 01d79bef0c183c39ef56c4bd8bbdb6ae6e9ff4f8 Author: Sophia Schröder AuthorDate: Sun Jan 13 19:27:33 2019 +0100 Commit: Olivier Hallot CommitDate: Mon Jan 14 00:04:40 2019 +0100 Small changes / improvements Change-Id: I0ee2d02f72948de572a545f0af009df32296ec7d Reviewed-on: https://gerrit.libreoffice.org/66267 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/optionen/01010200.xhp b/source/text/shared/optionen/01010200.xhp index 672bb7502..8c6cb3cf3 100644 --- a/source/text/shared/optionen/01010200.xhp +++ b/source/text/shared/optionen/01010200.xhp @@ -1,6 +1,5 @@ - - - - General - /text/shared/optionen/01010200.xhp - - - - -saving; options - defaults;of saving - URL; saving absolute/relative paths - relative saving of URLs - absolute saving of URLs + +General +/text/shared/optionen/01010200.xhp + + + + + +saving; options +defaults;of saving +URL; saving absolute/relative paths +relative saving of URLs +absolute saving of URLs General - In the General section, you can select default settings for saving documents, and can select default file formats. + In the General section, you can select default settings for saving documents, and can select default file formats. @@ -47,8 +46,8 @@ Load Load user-specific settings with the document - Loads the user-specific settings saved in a document with the document. - If Load user-specific settings with the document is not selected, the following user-specific settings still apply: + Loads the user-specific settings saved in a document with the document. + If Load user-specific settings with the document is not selected, the following user-specific settings still apply: Settings available in File - Print - Options, @@ -74,29 +73,28 @@ Load printer settings with the document - If enabled, the printer settings will be loaded with the document. This can cause a document to be printed on a distant printer, if you do not change the printer manually in the Print dialog. If disabled, your standard printer will be used to print this document. The current printer settings will be stored with the document whether or not this option is checked. + If enabled, the printer settings will be loaded with the document. This can cause a document to be printed on a distant printer, if you do not change the printer manually in the Print dialog. If disabled, your standard printer will be used to print this document. The current printer settings will be stored with the document whether or not this option is checked. Save Edit document properties before saving - Specifies that the Properties dialog will appear every time you select the Save As command. + Specifies that the Properties dialog will appear every time you select the Save As command. Always create backup copy - Saves the previous version of a document as a backup copy whenever you save a document. Every time %PRODUCTNAME creates a backup copy, the previous backup copy is replaced. The backup copy gets the extension .BAK. - To change the location of the backup copy, choose %PRODUCTNAME - PreferencesTools - Options - %PRODUCTNAME - Paths, and then enter a new path for the backup file. + Saves the previous version of a document as a backup copy whenever you save a document. Every time %PRODUCTNAME creates a backup copy, the previous backup copy is replaced. The backup copy gets the extension .BAK. + To change the location of the backup copy, choose %PRODUCTNAME - PreferencesTools - Options - %PRODUCTNAME - Paths, and then enter a new path for the backup file. Save AutoRecovery information every - Specifies that %PRODUCTNAME saves the information needed to restore all open documents in case of a crash. You can specify the saving time interval. + Specifies that %PRODUCTNAME saves the information needed to restore all open documents in case of a crash. You can specify the saving time interval. Minutes - Specifies the time interval in minutes for the automatic recovery option. - + Specifies the time interval in minutes for the automatic recovery option. Automatically save the document too -Specifies that %PRODUCTNAME saves all open documents when saving auto recovery information. Uses the same time interval as AutoRecovery does. - Save URLs relative to file system - This option allows you to select the default for relative addressing of URLs in the file system and on the Internet. Relative addressing is only possible if the source document and the referenced document are both on the same drive.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 411f3a050ac2be598019d512f8ccfe041080c28f Author: Sophia Schröder AuthorDate: Sun Jan 13 19:27:33 2019 +0100 Commit: Gerrit Code Review CommitDate: Mon Jan 14 00:04:40 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Small changes / improvements Change-Id: I0ee2d02f72948de572a545f0af009df32296ec7d Reviewed-on: https://gerrit.libreoffice.org/66267 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 3ba223f9a987..01d79bef0c18 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 3ba223f9a987066c3e3efa1e614443b9fe2fcac6 +Subproject commit 01d79bef0c183c39ef56c4bd8bbdb6ae6e9ff4f8 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/01/02220100.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3ba223f9a987066c3e3efa1e614443b9fe2fcac6 Author: Sophia Schröder AuthorDate: Sun Jan 13 19:24:17 2019 +0100 Commit: Olivier Hallot CommitDate: Sun Jan 13 23:56:01 2019 +0100 Small changes / improvements Change-Id: Ia4074a79d3bf471cd23e022f6d57057fb5e07e36 Reviewed-on: https://gerrit.libreoffice.org/66266 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/02220100.xhp b/source/text/shared/01/02220100.xhp index 52e5e7842..7beb3bba9 100644 --- a/source/text/shared/01/02220100.xhp +++ b/source/text/shared/01/02220100.xhp @@ -41,7 +41,7 @@ Lists the properties of the URL that is attached to the hotspot. URL: - Enter the URL for the file that you want to open when you click the selected hotspot. If you want to jump to a named anchor within the current document, the address should be of the form "file:///C/[current_document_name]#anchor_name". + Enter the URL for the file that you want to open when you click the selected hotspot. If you want to jump to a named anchor within the current document, the address should be of the form "file:///C:/Documents/[current_document_name]#anchor_name". Alternative text: Enter the text that you want to display when the mouse rests on the hotspot in a browser. If you do not enter any text, the Address is displayed. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3d381a726a9597bfcacf40c10d55fb7ccebe0f40 Author: Sophia Schröder AuthorDate: Sun Jan 13 19:24:17 2019 +0100 Commit: Gerrit Code Review CommitDate: Sun Jan 13 23:56:01 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Small changes / improvements Change-Id: Ia4074a79d3bf471cd23e022f6d57057fb5e07e36 Reviewed-on: https://gerrit.libreoffice.org/66266 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index b01d56512f5d..3ba223f9a987 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit b01d56512f5da9ab4b62095f2c353957e0e8517c +Subproject commit 3ba223f9a987066c3e3efa1e614443b9fe2fcac6 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/01/0222.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b01d56512f5da9ab4b62095f2c353957e0e8517c Author: Sophia Schröder AuthorDate: Sun Jan 13 18:59:40 2019 +0100 Commit: Olivier Hallot CommitDate: Sun Jan 13 23:55:12 2019 +0100 Small changes / improvements Change-Id: I2a476a6c70c4bdc559a7815a1131a50f67771e18 Reviewed-on: https://gerrit.libreoffice.org/66265 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/0222.xhp b/source/text/shared/01/0222.xhp index 4888c434b..02986e2b2 100644 --- a/source/text/shared/01/0222.xhp +++ b/source/text/shared/01/0222.xhp @@ -232,7 +232,7 @@ Address: - Enter the URL for the file that you want to open when you click the selected hotspot. If you want to jump to an anchor within the document, the address should be of the form "file:///C/document_name#anchor_name"This needs a rework as the document address example seems to be windows only and uses forbidden root directory again.. + Enter the URL for the file that you want to open when you click the selected hotspot. If you want to jump to an anchor within the document, the address should be of the form "file:///C:/Documents/document_name#anchor_name"This needs a rework as the document address example seems to be windows only and uses forbidden root directory again.. Text: Enter the text that you want to display when the mouse rests on the hotspot in a browser. If you do not enter any text, the Address is displayed. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0af0f3e87bd5429de508ca1223280ef8ffe30930 Author: Sophia Schröder AuthorDate: Sun Jan 13 18:59:40 2019 +0100 Commit: Gerrit Code Review CommitDate: Sun Jan 13 23:55:12 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Small changes / improvements Change-Id: I2a476a6c70c4bdc559a7815a1131a50f67771e18 Reviewed-on: https://gerrit.libreoffice.org/66265 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 9ae286e52bcf..b01d56512f5d 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 9ae286e52bcf86723a514274c84f3c1f6645b091 +Subproject commit b01d56512f5da9ab4b62095f2c353957e0e8517c ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0c91f940124123f97c714fd2dff10c92f4708896 Author: Sophia Schröder AuthorDate: Sun Jan 13 18:50:03 2019 +0100 Commit: Gerrit Code Review CommitDate: Sun Jan 13 23:54:26 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Small changes / improvements Change-Id: I2e3660b92a0ad2083f983b6cca6103478a5ed5a7 Reviewed-on: https://gerrit.libreoffice.org/66264 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 22bb1e2aaf20..9ae286e52bcf 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 22bb1e2aaf2071f0ade0530b535b1dc1874b88f3 +Subproject commit 9ae286e52bcf86723a514274c84f3c1f6645b091 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/01/02210101.xhp |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 9ae286e52bcf86723a514274c84f3c1f6645b091 Author: Sophia Schröder AuthorDate: Sun Jan 13 18:50:03 2019 +0100 Commit: Olivier Hallot CommitDate: Sun Jan 13 23:54:26 2019 +0100 Small changes / improvements Change-Id: I2e3660b92a0ad2083f983b6cca6103478a5ed5a7 Reviewed-on: https://gerrit.libreoffice.org/66264 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/02210101.xhp b/source/text/shared/01/02210101.xhp index a1533dae8..2d10585d7 100644 --- a/source/text/shared/01/02210101.xhp +++ b/source/text/shared/01/02210101.xhp @@ -34,16 +34,16 @@ Name - Enter a name for the floating frame. The name cannot contain spaces, special characters, or begin with an underscore ( _ ). + Enter a name for the floating frame. The name cannot contain spaces, special characters, or begin with an underscore (_). Contents Enter the path and the name of the file that you want to display in the floating frame. You can also click the Browse button and locate the file that you want to display. For example, you can enter: - http://www.example.com + https://www.example.com -file:///c|/Readme.txtAdolfo: Is the "|" character after the "file:///c" correct? And a user file should *never* be in a root directory anyway. +file:///C:/Documents/Readme.txtAdolfo: Is the "|" character after the "file:///c" correct? And a user file should *never* be in a root directory anyway.SophiaS: agreed, changed ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - kit/ChildSession.cpp kit/ChildSession.hpp kit/Kit.cpp loleaflet/src test/WhiteBoxTests.cpp wsd/ClientSession.cpp
kit/ChildSession.cpp | 168 +++
kit/ChildSession.hpp |4
kit/Kit.cpp |6 +
loleaflet/src/control/Signing.js | 120 +--
test/WhiteBoxTests.cpp |5 +
wsd/ClientSession.cpp|1
6 files changed, 260 insertions(+), 44 deletions(-)
New commits:
commit 0177e41893b14670547c6c0e83350a2806523a2f
Author: Tomaž Vajngerl
AuthorDate: Sun Jan 13 23:45:44 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Sun Jan 13 23:51:01 2019 +0100
add export, sign and upload as one function for PDF signing
PDF export, signing and upload needs to be done in one operation
as PDF doesn't change the current document. The workflow is just
a bit different to the ODF / OOXML that it needs a change in
behaviour.
Change-Id: I752b293494a2d677fa7f12f2317954cfcf47859b
(cherry picked from commit 7137c953d88c14ddd6e9f6f56e338e0d54544b34)
diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 7f856b252..e4c899cca 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -274,6 +274,7 @@ bool ChildSession::_handleInput(const char *buffer, int
length)
tokens[0] == "asksignaturestatus" ||
tokens[0] == "signdocument" ||
tokens[0] == "uploadsigneddocument" ||
+ tokens[0] == "exportsignanduploaddocument" ||
tokens[0] == "rendershapeselection");
if (tokens[0] == "clientzoom")
@@ -373,6 +374,10 @@ bool ChildSession::_handleInput(const char *buffer, int
length)
{
return uploadSignedDocument(buffer, length, tokens);
}
+else if (tokens[0] == "exportsignanduploaddocument")
+{
+return exportSignAndUploadDocument(buffer, length, tokens);
+}
#endif
else if (tokens[0] == "rendershapeselection")
{
@@ -1397,6 +1402,169 @@ bool ChildSession::signDocumentContent(const char*
buffer, int length, const std
return bResult;
}
+bool ChildSession::exportSignAndUploadDocument(const char* buffer, int length,
const std::vector& /*tokens*/)
+{
+bool bResult = false;
+
+std::string filename;
+std::string wopiUrl;
+std::string token;
+std::string filetype;
+std::string x509Certificate;
+std::string privateKey;
+std::vector certificateChain;
+
+{ // parse JSON
+const std::string firstLine = getFirstLine(buffer, length);
+const char* data = buffer + firstLine.size() + 1;
+const int size = length - firstLine.size() - 1;
+std::string json(data, size);
+
+Poco::JSON::Parser parser;
+Poco::JSON::Object::Ptr root =
parser.parse(json).extract();
+
+filename = JsonUtil::getJSONValue(root, "filename");
+wopiUrl = JsonUtil::getJSONValue(root, "wopiUrl");
+token = JsonUtil::getJSONValue(root, "token");
+filetype = JsonUtil::getJSONValue(root, "type");
+x509Certificate = JsonUtil::getJSONValue(root,
"x509Certificate");
+privateKey = JsonUtil::getJSONValue(root, "privateKey");
+
+for (auto& rChainPtr : *root->getArray("chain"))
+{
+if (!rChainPtr.isString())
+{
+sendTextFrame("error: cmd=exportsignanduploaddocument
kind=syntax");
+return false;
+}
+std::string chainCertificate = rChainPtr;
+certificateChain.push_back(chainCertificate);
+}
+}
+
+if (filetype.empty() || filename.empty() || wopiUrl.empty() ||
token.empty() || x509Certificate.empty() || privateKey.empty())
+{
+sendTextFrame("error: cmd=exportsignanduploaddocument kind=syntax");
+return false;
+}
+
+std::string mimetype = getMimeFromFileType(filetype);
+if (mimetype.empty())
+{
+sendTextFrame("error: cmd=exportsignanduploaddocument kind=syntax");
+return false;
+}
+
+// add certificate chain
+for (auto const & certificate : certificateChain)
+{
+std::vector binaryChainCertificate =
decodeBase64(extractCertificate(certificate));
+
+bResult = getLOKitDocument()->addCertificate(
+binaryChainCertificate.data(),
+binaryChainCertificate.size());
+
+if (!bResult)
+{
+sendTextFrame("error: cmd=exportsignanduploaddocument
kind=syntax");
+return false;
+}
+}
+
+// export document to a temp file
+const std::string aTempDir =
FileUtil::createRandomDir(JAILED_DOCUMENT_ROOT);
+const Poco::Path filenameParam(filename);
+const std::string aTempDocumentURL = JAILED_DOCUMENT_ROOT + aTempDir + "/"
+ filenameParam.getFileName();
+
+{
+std::unique_lock lock(_docManager.getDocumentMutex());
+
+getLOKitDocument()->saveAs(aTempDocumentURL.c_str(), filetype.c_str(),
nullptr);
+}
+
+// sign document
+{
+
[Libreoffice-commits] online.git: kit/ChildSession.cpp kit/ChildSession.hpp kit/Kit.cpp loleaflet/src test/WhiteBoxTests.cpp wsd/ClientSession.cpp
kit/ChildSession.cpp | 168 +++
kit/ChildSession.hpp |4
kit/Kit.cpp |6 +
loleaflet/src/control/Signing.js | 120 +--
test/WhiteBoxTests.cpp |5 +
wsd/ClientSession.cpp|1
6 files changed, 260 insertions(+), 44 deletions(-)
New commits:
commit 7137c953d88c14ddd6e9f6f56e338e0d54544b34
Author: Tomaž Vajngerl
AuthorDate: Sun Jan 13 23:45:44 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Sun Jan 13 23:50:18 2019 +0100
add export, sign and upload as one function for PDF signing
PDF export, signing and upload needs to be done in one operation
as PDF doesn't change the current document. The workflow is just
a bit different to the ODF / OOXML that it needs a change in
behaviour.
Change-Id: I752b293494a2d677fa7f12f2317954cfcf47859b
diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 7f856b252..e4c899cca 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -274,6 +274,7 @@ bool ChildSession::_handleInput(const char *buffer, int
length)
tokens[0] == "asksignaturestatus" ||
tokens[0] == "signdocument" ||
tokens[0] == "uploadsigneddocument" ||
+ tokens[0] == "exportsignanduploaddocument" ||
tokens[0] == "rendershapeselection");
if (tokens[0] == "clientzoom")
@@ -373,6 +374,10 @@ bool ChildSession::_handleInput(const char *buffer, int
length)
{
return uploadSignedDocument(buffer, length, tokens);
}
+else if (tokens[0] == "exportsignanduploaddocument")
+{
+return exportSignAndUploadDocument(buffer, length, tokens);
+}
#endif
else if (tokens[0] == "rendershapeselection")
{
@@ -1397,6 +1402,169 @@ bool ChildSession::signDocumentContent(const char*
buffer, int length, const std
return bResult;
}
+bool ChildSession::exportSignAndUploadDocument(const char* buffer, int length,
const std::vector& /*tokens*/)
+{
+bool bResult = false;
+
+std::string filename;
+std::string wopiUrl;
+std::string token;
+std::string filetype;
+std::string x509Certificate;
+std::string privateKey;
+std::vector certificateChain;
+
+{ // parse JSON
+const std::string firstLine = getFirstLine(buffer, length);
+const char* data = buffer + firstLine.size() + 1;
+const int size = length - firstLine.size() - 1;
+std::string json(data, size);
+
+Poco::JSON::Parser parser;
+Poco::JSON::Object::Ptr root =
parser.parse(json).extract();
+
+filename = JsonUtil::getJSONValue(root, "filename");
+wopiUrl = JsonUtil::getJSONValue(root, "wopiUrl");
+token = JsonUtil::getJSONValue(root, "token");
+filetype = JsonUtil::getJSONValue(root, "type");
+x509Certificate = JsonUtil::getJSONValue(root,
"x509Certificate");
+privateKey = JsonUtil::getJSONValue(root, "privateKey");
+
+for (auto& rChainPtr : *root->getArray("chain"))
+{
+if (!rChainPtr.isString())
+{
+sendTextFrame("error: cmd=exportsignanduploaddocument
kind=syntax");
+return false;
+}
+std::string chainCertificate = rChainPtr;
+certificateChain.push_back(chainCertificate);
+}
+}
+
+if (filetype.empty() || filename.empty() || wopiUrl.empty() ||
token.empty() || x509Certificate.empty() || privateKey.empty())
+{
+sendTextFrame("error: cmd=exportsignanduploaddocument kind=syntax");
+return false;
+}
+
+std::string mimetype = getMimeFromFileType(filetype);
+if (mimetype.empty())
+{
+sendTextFrame("error: cmd=exportsignanduploaddocument kind=syntax");
+return false;
+}
+
+// add certificate chain
+for (auto const & certificate : certificateChain)
+{
+std::vector binaryChainCertificate =
decodeBase64(extractCertificate(certificate));
+
+bResult = getLOKitDocument()->addCertificate(
+binaryChainCertificate.data(),
+binaryChainCertificate.size());
+
+if (!bResult)
+{
+sendTextFrame("error: cmd=exportsignanduploaddocument
kind=syntax");
+return false;
+}
+}
+
+// export document to a temp file
+const std::string aTempDir =
FileUtil::createRandomDir(JAILED_DOCUMENT_ROOT);
+const Poco::Path filenameParam(filename);
+const std::string aTempDocumentURL = JAILED_DOCUMENT_ROOT + aTempDir + "/"
+ filenameParam.getFileName();
+
+{
+std::unique_lock lock(_docManager.getDocumentMutex());
+
+getLOKitDocument()->saveAs(aTempDocumentURL.c_str(), filetype.c_str(),
nullptr);
+}
+
+// sign document
+{
+std::vector binaryCertificate =
[Libreoffice-commits] help.git: source/text
source/text/shared/01/0102.xhp| 269 +++--- source/text/shared/guide/doc_open.xhp | 179 +- 2 files changed, 199 insertions(+), 249 deletions(-) New commits: commit 22bb1e2aaf2071f0ade0530b535b1dc1874b88f3 Author: Olivier Hallot AuthorDate: Sat Jan 12 07:58:42 2019 -0200 Commit: Olivier Hallot CommitDate: Sun Jan 13 23:49:17 2019 +0100 Remove ref of native file picker in Open pages Native filepicker is not selectable in UI so not available to user unless set in Expert config. Change-Id: I894cebfccac9337cc558f011e2be96d30f234a93 Reviewed-on: https://gerrit.libreoffice.org/66208 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/0102.xhp b/source/text/shared/01/0102.xhp index a246b99ac..cdc1888e6 100644 --- a/source/text/shared/01/0102.xhp +++ b/source/text/shared/01/0102.xhp @@ -1,152 +1,131 @@ - + + + + +Open +/text/shared/01/0102.xhp + + + + +directories; creating new +folder creation +My Documents folder; opening +multiple documents; opening +opening; several files +selecting; several files +opening; files, with placeholders +placeholders;on opening files +documents; opening with templates +templates; opening documents with +documents; styles changed +styles; changed message + +mw replaced "wildcards" by "regular expressions"mw deleted "regular expressions;" and "files;" + + + + + + +Open +Opens a local or remote file, or imports one. + + + + +%PRODUCTNAME uses the native file picker dialog of the window manager of your operating system for the Open command. + +If the file that you want to open contains styles, special rules apply. + +Display area +Displays the files and folders in the folder that you are in. To open a file, select the file, and then click Open. +To open more than one document at the same time, each in an own window, hold CommandCtrl while you click the files, and then click Open. - - -Open -/text/shared/01/0102.xhp - - - - - directories; creating new - folder creation - My Documents folder; opening - multiple documents; opening - opening; several files - selecting; several files - opening; files, with placeholders - placeholders;on opening files - documents; opening with templates - templates; opening documents with - documents; styles changed - styles; changed message - -mw replaced "wildcards" by "regular expressions"mw deleted "regular expressions;" and "files;" - - - - - - -Open - Opens a local or remote file, or imports one. - - - - -The following sections describe the %PRODUCTNAME Open dialog box. To activate the %PRODUCTNAME Open and Save dialog boxes, choose %PRODUCTNAME - PreferencesTools - Options - %PRODUCTNAME- General, and then select the Use %PRODUCTNAME dialogs in the Open/Save dialogs area. -If the file that you want to open contains styles, special rules apply. - - -Up One Level -Move up one folder in the folder hierarchy. Long-click to see the higher level folders. - - -Create New Folder - Creates a new folder. - - -Display area - Displays the files and folders in the folder that you are in. To open a file, select the file, and then click Open. - To open more than one document at the same time, each in an own window, hold CommandCtrl while you click the files, and then click Open. - - -Click a column header to sort the files. Click again to reverse the sort order. - - -To delete a file, right-click the file, and then choose Delete. - - -To rename a file, right-click the file, and then choose Rename. - - - -Click to delete the file with the name shown in this dialog. - -Click to cancel deletion of the file with the name shown in this dialog. - -Click to delete all selected files. - - -File name - Enter a file name or a path for the file. You can also enter an URL that starts with the protocol name ftp, http, or https. - If you want, you can use wildcards in the File name box to filter the list of files that is displayed. - For example, to list all of the text files in a folder, enter the asterisk wildcard with the text file extension (*.txt), and then click Open. Use the question mark (?) wildcard to represent any character, as in ??3*.txt, which only displays text files with a '3' as the third character in the file name. - - -Version - If there are multiple versions of the selected file, select the version that you want to open. You can save and organize multiple versions of a document by choosing File - Versions. The versions of a document are opened in read-only mode. - -File type - Select the file type that you
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2671be45606ef499fad52113323eb075c8ad13d4 Author: Olivier Hallot AuthorDate: Sat Jan 12 07:58:42 2019 -0200 Commit: Gerrit Code Review CommitDate: Sun Jan 13 23:49:17 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Remove ref of native file picker in Open pages Native filepicker is not selectable in UI so not available to user unless set in Expert config. Change-Id: I894cebfccac9337cc558f011e2be96d30f234a93 Reviewed-on: https://gerrit.libreoffice.org/66208 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 4c805e7b0cf8..22bb1e2aaf20 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 4c805e7b0cf85aaff832353fe5fb5efcc6d6cfe0 +Subproject commit 22bb1e2aaf2071f0ade0530b535b1dc1874b88f3 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 81375e66cd0e0ae1e805397e16d923df4a57e47c Author: Olivier Hallot AuthorDate: Sat Jan 12 17:32:40 2019 -0200 Commit: Gerrit Code Review CommitDate: Sun Jan 13 23:48:42 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Fix some mistakes in attibutes Change-Id: Ib5719ff52025c2eb558fb6e31ed69f8a6e733b40 Reviewed-on: https://gerrit.libreoffice.org/66243 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 9edd5ad5fc08..4c805e7b0cf8 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 9edd5ad5fc08b4173a08e697d1b1a2d2d64227eb +Subproject commit 4c805e7b0cf85aaff832353fe5fb5efcc6d6cfe0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 080dbea65a56a585dba3576ef9e7a1be4f88afb9 Author: Olivier Hallot AuthorDate: Sat Jan 12 17:19:02 2019 -0200 Commit: Gerrit Code Review CommitDate: Sun Jan 13 23:48:03 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Mute l10n in lines of Basic and Python code Change-Id: I8cebb9a0132d430242ae32be9b7fdac10e4e7da2 Reviewed-on: https://gerrit.libreoffice.org/66242 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 01a40cf73465..9edd5ad5fc08 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 01a40cf7346582ca284194bb9e27989a5cf4f565 +Subproject commit 9edd5ad5fc08b4173a08e697d1b1a2d2d64227eb ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/sbasic/shared/enum.xhp |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 4c805e7b0cf85aaff832353fe5fb5efcc6d6cfe0 Author: Olivier Hallot AuthorDate: Sat Jan 12 17:32:40 2019 -0200 Commit: Olivier Hallot CommitDate: Sun Jan 13 23:48:42 2019 +0100 Fix some mistakes in attibutes Change-Id: Ib5719ff52025c2eb558fb6e31ed69f8a6e733b40 Reviewed-on: https://gerrit.libreoffice.org/66243 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/sbasic/shared/enum.xhp b/source/text/sbasic/shared/enum.xhp index 2cae25156..e56b335d1 100644 --- a/source/text/sbasic/shared/enum.xhp +++ b/source/text/sbasic/shared/enum.xhp @@ -51,7 +51,7 @@ Enumerated values are rendered to Long datatype. Basic functions are public accessors to enumerations. Enumeration names and value names must be unique within a library and across modules. Usage: -Display WindowManager grouped constant values: +Display WindowManager grouped constant values: Dim winMgr As Object : winMgr = library.module.WindowManager With winMgr @@ -60,9 +60,9 @@ -Const statement, constants -Option VBASupport statement -With statement +Const statement, constants +Option VBASupport statement +With statement ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/sbasic/python/python_shell.xhp | 36 ++--- 1 file changed, 18 insertions(+), 18 deletions(-) New commits: commit 9edd5ad5fc08b4173a08e697d1b1a2d2d64227eb Author: Olivier Hallot AuthorDate: Sat Jan 12 17:19:02 2019 -0200 Commit: Olivier Hallot CommitDate: Sun Jan 13 23:48:03 2019 +0100 Mute l10n in lines of Basic and Python code Change-Id: I8cebb9a0132d430242ae32be9b7fdac10e4e7da2 Reviewed-on: https://gerrit.libreoffice.org/66242 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/sbasic/python/python_shell.xhp b/source/text/sbasic/python/python_shell.xhp index 264cd34d9..194bc2fd6 100644 --- a/source/text/sbasic/python/python_shell.xhp +++ b/source/text/sbasic/python/python_shell.xhp @@ -26,27 +26,27 @@ Using a Basic macro: -Sub interpreter_console -ps = CreateUnoService(com.sun.star.util.PathSettings) -install_path = ConvertFromURL(ps.Module) -Shell( install_path + GetPathSeparator() + python ) -End Sub +Sub interpreter_console +ps = CreateUnoService(com.sun.star.util.PathSettings) +install_path = ConvertFromURL(ps.Module) +Shell( install_path + GetPathSeparator() + python ) +End Sub Using a Python macro: -# -*- coding: utf-8 -*- -from __future__ import unicode_literals - -import uno, os, subprocess - -def interpreter_console(): -ctx = XSCRIPTCONTEXT.getComponentContext() -smgr = ctx.getServiceManager() -ps = smgr.createInstanceWithContext(com.sun.star.util.PathSettings, ctx) -install_path = uno.fileUrlToSystemPath(ps.Module) -pgm = install_path + os.sep + python # Python shell/console path -subprocess.Popen(pgm) # Start Python interactive Shell - +# -*- coding: utf-8 -*- +from __future__ import unicode_literals + +import uno, os, subprocess + +def interpreter_console(): +ctx = XSCRIPTCONTEXT.getComponentContext() +smgr = ctx.getServiceManager() +ps = smgr.createInstanceWithContext(com.sun.star.util.PathSettings, ctx) +install_path = uno.fileUrlToSystemPath(ps.Module) +pgm = install_path + os.sep + python # Python shell/console path + subprocess.Popen(pgm) # Start Python interactive Shell + Usage: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107334] [META] Chart wizard dialog issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107334 Bug 107334 depends on bug 90465, which changed state. Bug 90465 Summary: Transparency not preserved on chart type sample icons in insert chart wizard https://bugs.documentfoundation.org/show_bug.cgi?id=90465 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122247] [META] Icon requests
https://bugs.documentfoundation.org/show_bug.cgi?id=122247 Bug 122247 depends on bug 90465, which changed state. Bug 90465 Summary: Transparency not preserved on chart type sample icons in insert chart wizard https://bugs.documentfoundation.org/show_bug.cgi?id=90465 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90465] Transparency not preserved on chart type sample icons in insert chart wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=90465 andreas_k changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #15 from andreas_k --- there are no cart tango icons any more the fallback was used. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122245] [META] Icon theme issues that need coding
https://bugs.documentfoundation.org/show_bug.cgi?id=122245 andreas_k changed: What|Removed |Added Depends on||98193 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98193 [Bug 98193] Save icon breaks icon customization -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122247] [META] Icon requests
https://bugs.documentfoundation.org/show_bug.cgi?id=122247 andreas_k changed: What|Removed |Added Depends on|98193 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98193 [Bug 98193] Save icon breaks icon customization -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98193] Save icon breaks icon customization
https://bugs.documentfoundation.org/show_bug.cgi?id=98193 andreas_k changed: What|Removed |Added Blocks|122247 |122245 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122245 [Bug 122245] [META] Icon theme issues that need coding https://bugs.documentfoundation.org/show_bug.cgi?id=122247 [Bug 122247] [META] Icon requests -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89297] Header, footer and page number missing on second page when saved as docx (continuous section breaks enhancement request)
https://bugs.documentfoundation.org/show_bug.cgi?id=89297 --- Comment #15 from Aron Budea --- *** Bug 117830 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117830] Wrong header/footer shown for intermittent section in DOC(X)
https://bugs.documentfoundation.org/show_bug.cgi?id=117830 --- Comment #8 from Aron Budea --- *** This bug has been marked as a duplicate of bug 89297 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/win
vcl/win/gdi/gdiimpl.cxx | 15 +++
1 file changed, 15 insertions(+)
New commits:
commit 5af161ebbe2a0183c1302099c995548d82965fa9
Author: Armin Le Grand
AuthorDate: Fri Jan 11 17:59:59 2019 +0100
Commit: Thorsten Behrens
CommitDate: Sun Jan 13 22:45:23 2019 +0100
tdf#122384 Added isPrinter support to WinSalGraphicsImpl::drawPolyLine
As already guessed but not been sure (see 'One more hint'
in WinSalGraphicsImpl::drawPolyPolygon) the strange WinGDI
transform is also needed when printing for WinSalGraphicsImpl::
drawPolyLine.
Change-Id: I39f89eac0c17e524949221306723a355c6e94a17
Reviewed-on: https://gerrit.libreoffice.org/66190
Tested-by: Jenkins
Reviewed-by: Armin Le Grand
(cherry picked from commit 6e3c4ae8bca898700cde9caaff43c3a8a61eebc2)
Reviewed-on: https://gerrit.libreoffice.org/66270
Reviewed-by: Thorsten Behrens
diff --git a/vcl/win/gdi/gdiimpl.cxx b/vcl/win/gdi/gdiimpl.cxx
index fa6dccb48c5a..10aad77ed229 100644
--- a/vcl/win/gdi/gdiimpl.cxx
+++ b/vcl/win/gdi/gdiimpl.cxx
@@ -2310,6 +2310,21 @@ bool WinSalGraphicsImpl::drawPolyLine(
aGraphics.SetSmoothingMode(Gdiplus::SmoothingModeNone);
}
+if(mrParent.isPrinter())
+{
+// tdf#122384 As metioned above in WinSalGraphicsImpl::drawPolyPolygon
+// (look for 'One more hint: This *may* also be needed now in'...).
+// See comments in same spot above *uregntly* before doing changes
here,
+// these comments are *still fully valid* at this place (!)
+const Gdiplus::REAL aDpiX(aGraphics.GetDpiX());
+const Gdiplus::REAL aDpiY(aGraphics.GetDpiY());
+
+aGraphics.ScaleTransform(
+Gdiplus::REAL(100.0) / aDpiX,
+Gdiplus::REAL(100.0) / aDpiY,
+Gdiplus::MatrixOrderAppend);
+}
+
aGraphics.DrawPath(
,
&(*pGraphicsPath));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122659] FORMATTING: Outline numbering modification only keeps the last modified style
https://bugs.documentfoundation.org/show_bug.cgi?id=122659 --- Comment #2 from dubre...@yahoo.com --- (In reply to Oliver Brinzing from comment #1) > > 1.menu "tools" "outline numbering" > > do you mean: Tools/Chapter Numbering... ? Yes that's correct; sorry my interface was in french, I've juste modified it to English and it's "Tools/Chapter Numbering" > > 2.modify the paragraph style for level one (for example) > > do you mean (for example) changing "Heading 1" to "Caption" ? > > for me this works with lo 6.1.4.2, Level 2 still has "Heading 2" That's it. Maybe this bug was corrected in 6.1.4.2 version. I've encountered the same problem on 2 different machines with LO 6.1.3.2 (the other one is on Linux/Ubuntu too) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122685] 『Expansion Kit』 toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=122685 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Regina Henschel --- I do not understand you. What is the purpose of the "Expansion Kit" toolbar? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/uno/unomod.cxx | 61 +---
1 file changed, 27 insertions(+), 34 deletions(-)
New commits:
commit c4747e1c71fc7a25bcb6321891a719e527c3f572
Author: Caolán McNamara
AuthorDate: Sun Jan 13 20:09:21 2019 +
Commit: Caolán McNamara
CommitDate: Sun Jan 13 22:12:25 2019 +0100
ofz#12500 ubsan error
Change-Id: I2520f77116be418a2cb8bcf3731894dc3dd4fb56
Reviewed-on: https://gerrit.libreoffice.org/66272
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/source/uibase/uno/unomod.cxx b/sw/source/uibase/uno/unomod.cxx
index a7a60ad2faec..54c2c3a50940 100644
--- a/sw/source/uibase/uno/unomod.cxx
+++ b/sw/source/uibase/uno/unomod.cxx
@@ -275,82 +275,79 @@ void SwXPrintSettings::_preSetValues ()
}
}
-void SwXPrintSettings::_setSingleValue( const comphelper::PropertyInfo &
rInfo, const uno::Any )
+namespace
{
-bool bVal;
+bool tryBoolAccess(const uno::Any )
+{
+const auto xPrSet = o3tl::tryAccess(rValue);
+if (!xPrSet)
+throw lang::IllegalArgumentException();
+return *xPrSet;
+}
+}
+void SwXPrintSettings::_setSingleValue( const comphelper::PropertyInfo &
rInfo, const uno::Any )
+{
switch( rInfo.mnHandle )
{
case HANDLE_PRINTSET_LEFT_PAGES:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintLeftPage(bVal);
+mpPrtOpt->SetPrintLeftPage(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_RIGHT_PAGES:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintRightPage(bVal);
+mpPrtOpt->SetPrintRightPage(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_REVERSED:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintReverse(bVal);
+mpPrtOpt->SetPrintReverse(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_PROSPECT:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintProspect(bVal);
+mpPrtOpt->SetPrintProspect(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_GRAPHICS:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintGraphic(bVal);
+mpPrtOpt->SetPrintGraphic(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_TABLES:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintTable(bVal);
+mpPrtOpt->SetPrintTable(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_DRAWINGS:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintDraw(bVal);
+mpPrtOpt->SetPrintDraw(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_CONTROLS:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintControl(bVal);
+mpPrtOpt->SetPrintControl(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_PAGE_BACKGROUND:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintPageBackground(bVal);
+mpPrtOpt->SetPrintPageBackground(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_BLACK_FONTS:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintBlackFont(bVal);
+mpPrtOpt->SetPrintBlackFont(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_SINGLE_JOBS:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintSingleJobs(bVal);
+mpPrtOpt->SetPrintSingleJobs(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_PAPER_FROM_SETUP:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPaperFromSetup(bVal);
+mpPrtOpt->SetPaperFromSetup(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_ANNOTATION_MODE:
@@ -366,8 +363,7 @@ void SwXPrintSettings::_setSingleValue( const
comphelper::PropertyInfo & rInfo,
break;
case HANDLE_PRINTSET_EMPTY_PAGES:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintEmptyPages(bVal);
+mpPrtOpt->SetPrintEmptyPages(tryBoolAccess(rValue));
}
break;
case HANDLE_PRINTSET_FAX_NAME:
@@ -381,20 +377,17 @@ void SwXPrintSettings::_setSingleValue( const
comphelper::PropertyInfo & rInfo,
break;
case HANDLE_PRINTSET_PROSPECT_RTL:
{
-bVal = *o3tl::tryAccess(rValue);
-mpPrtOpt->SetPrintProspect_RTL(bVal);
+mpPrtOpt->SetPrintProspect_RTL(tryBoolAccess(rValue));
}
break;
case
[Libreoffice-bugs] [Bug 93085] Application window is too high, status bar is not visible (1024x600 resolution), size of module launch inherited from the StartCenter which gets a fixed minimum height (
https://bugs.documentfoundation.org/show_bug.cgi?id=93085 --- Comment #39 from Christopher --- Oh, sorry. I apologize... I should have read the thread more carefully! (This is especially embarrassing since I usually insist that *others* do as I have failed here.) I look forward to LO 6.2 then :) and in the meantime, once again, sorry for being a bit of an idiot. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61914] [META] Start Center bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=61914 Bug 61914 depends on bug 93085, which changed state. Bug 93085 Summary: Application window is too high, status bar is not visible (1024x600 resolution), size of module launch inherited from the StartCenter which gets a fixed minimum height (comment 14) https://bugs.documentfoundation.org/show_bug.cgi?id=93085 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93085] Application window is too high, status bar is not visible (1024x600 resolution), size of module launch inherited from the StartCenter which gets a fixed minimum height (
https://bugs.documentfoundation.org/show_bug.cgi?id=93085 Johnny_M changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #38 from Johnny_M --- (In reply to Christopher from comment #37) > The old behavior is once again present in LibreOffice 6.0.7 and in 6.1.4 The fix in comment 33 was applied to the (coming) version 6.2 and later. Not those. Please re-open if present in LO 6.2 - see https://qa.blog.documentfoundation.org/2019/01/11/libreoffice-6-2-rc2-is-ready-for-testing/ for release details. Closing again for now. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #203 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/8e323a3fb2d359d29fdaee61f60ef6b0488fc942%5E%21 tdf#45904 Move XElementAccess Java tests to C++ It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa
qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv |2 --
sc/qa/extras/scdatapilottablesobj.cxx| 10
++
2 files changed, 10 insertions(+), 2 deletions(-)
New commits:
commit 8e323a3fb2d359d29fdaee61f60ef6b0488fc942
Author: Jens Carl
AuthorDate: Sun Jan 13 19:15:06 2019 +
Commit: Jens Carl
CommitDate: Sun Jan 13 21:48:56 2019 +0100
tdf#45904 Move XElementAccess Java tests to C++
Move XElementAccess Java tests to C++ for ScDataPilotTablesObj.
Change-Id: I33849462bfbc5fb55f97387c8ab33a834b398c55
Reviewed-on: https://gerrit.libreoffice.org/66269
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git
a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv
index 8e400adc6c10..bf88fcd3661a 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv
@@ -1,5 +1,3 @@
"ScDataPilotTablesObj";"com::sun::star::container::XNameAccess";"getByName()"
"ScDataPilotTablesObj";"com::sun::star::container::XNameAccess";"getElementNames()"
"ScDataPilotTablesObj";"com::sun::star::container::XNameAccess";"hasByName()"
-"ScDataPilotTablesObj";"com::sun::star::container::XElementAccess";"getElementType()"
-"ScDataPilotTablesObj";"com::sun::star::container::XElementAccess";"hasElements()"
diff --git a/sc/qa/extras/scdatapilottablesobj.cxx
b/sc/qa/extras/scdatapilottablesobj.cxx
index 76dcdf9c86fa..44eef48f8d93 100644
--- a/sc/qa/extras/scdatapilottablesobj.cxx
+++ b/sc/qa/extras/scdatapilottablesobj.cxx
@@ -8,6 +8,7 @@
*/
#include
+#include
#include
#include
#include
@@ -15,6 +16,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -26,6 +28,8 @@
#include
+#include
+
using namespace css;
using namespace css::uno;
using namespace com::sun::star;
@@ -34,6 +38,7 @@ namespace sc_apitest
{
class ScDataPilotTablesObj : public CalcUnoApiTest,
public apitest::XDataPilotTables,
+ public apitest::XElementAccess,
public apitest::XEnumerationAccess,
public apitest::XIndexAccess
{
@@ -50,6 +55,10 @@ public:
// XDataPilotTables
CPPUNIT_TEST(testXDataPilotTables);
+// XElementAccess
+CPPUNIT_TEST(testGetElementType);
+CPPUNIT_TEST(testHasElements);
+
// XEnumerationAccess
CPPUNIT_TEST(testCreateEnumeration);
@@ -65,6 +74,7 @@ private:
ScDataPilotTablesObj::ScDataPilotTablesObj()
: CalcUnoApiTest("/sc/qa/extras/testdocuments")
+, XElementAccess(cppu::UnoType::get())
, XIndexAccess(1)
{
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #202 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/823ce74283d5214204abee7b2765e86f094c32eb%5E%21 tdf#45904 Move XIndexAccess Java tests to C++ It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa
qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv |2 -
sc/qa/extras/scdatapilottablesobj.cxx| 15
+++---
2 files changed, 11 insertions(+), 6 deletions(-)
New commits:
commit 823ce74283d5214204abee7b2765e86f094c32eb
Author: Jens Carl
AuthorDate: Sun Jan 13 19:08:09 2019 +
Commit: Jens Carl
CommitDate: Sun Jan 13 21:47:28 2019 +0100
tdf#45904 Move XIndexAccess Java tests to C++
Move XIndexAccess Java tests to C++ for ScDataPilotTablesObj.
Change-Id: Ic39fe92825bcb667c5d92635cafb15dbe36d7dc3
Reviewed-on: https://gerrit.libreoffice.org/66268
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git
a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv
index 4de45992a904..8e400adc6c10 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv
@@ -1,7 +1,5 @@
"ScDataPilotTablesObj";"com::sun::star::container::XNameAccess";"getByName()"
"ScDataPilotTablesObj";"com::sun::star::container::XNameAccess";"getElementNames()"
"ScDataPilotTablesObj";"com::sun::star::container::XNameAccess";"hasByName()"
-"ScDataPilotTablesObj";"com::sun::star::container::XIndexAccess";"getCount()"
-"ScDataPilotTablesObj";"com::sun::star::container::XIndexAccess";"getByIndex()"
"ScDataPilotTablesObj";"com::sun::star::container::XElementAccess";"getElementType()"
"ScDataPilotTablesObj";"com::sun::star::container::XElementAccess";"hasElements()"
diff --git a/sc/qa/extras/scdatapilottablesobj.cxx
b/sc/qa/extras/scdatapilottablesobj.cxx
index eb3eaf884563..76dcdf9c86fa 100644
--- a/sc/qa/extras/scdatapilottablesobj.cxx
+++ b/sc/qa/extras/scdatapilottablesobj.cxx
@@ -9,6 +9,7 @@
#include
#include
+#include
#include
#include
@@ -17,8 +18,8 @@
#include
#include
#include
-#include
#include
+#include
#include
#include
#include
@@ -33,7 +34,8 @@ namespace sc_apitest
{
class ScDataPilotTablesObj : public CalcUnoApiTest,
public apitest::XDataPilotTables,
- public apitest::XEnumerationAccess
+ public apitest::XEnumerationAccess,
+ public apitest::XIndexAccess
{
public:
ScDataPilotTablesObj();
@@ -51,6 +53,10 @@ public:
// XEnumerationAccess
CPPUNIT_TEST(testCreateEnumeration);
+// XIndexAccess
+CPPUNIT_TEST(testGetByIndex);
+CPPUNIT_TEST(testGetCount);
+
CPPUNIT_TEST_SUITE_END();
private:
@@ -59,6 +65,7 @@ private:
ScDataPilotTablesObj::ScDataPilotTablesObj()
: CalcUnoApiTest("/sc/qa/extras/testdocuments")
+, XIndexAccess(1)
{
}
@@ -81,7 +88,7 @@ uno::Reference ScDataPilotTablesObj::init()
uno::Reference
xDPD(xDPT->createDataPilotDescriptor(),
UNO_QUERY_THROW);
xDPD->setSourceRange(table::CellRangeAddress(0, 0, 0, 4, 4));
-//xDPT->insertNewByName("DataPilotTable", table::CellAddress(0, 5, 5),
xDPD);
+xDPT->insertNewByName("DataPilotTable", table::CellAddress(0, 5, 5), xDPD);
return xDPT;
}
@@ -112,7 +119,7 @@ void ScDataPilotTablesObj::tearDown()
CPPUNIT_TEST_SUITE_REGISTRATION(ScDataPilotTablesObj);
-} // end namespace
+} // namespace sc_apitest
CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Changes to 'refs/tags/libreoffice-6.2.0.2'
Tag 'libreoffice-6.2.0.2' created by Andras Timar at 2019-01-13 20:22 + libreoffice-6.2.0.2 Changes since libreoffice-6.2.0.1-19: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'refs/tags/libreoffice-6.2.0.2' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 61914] [META] Start Center bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=61914 Bug 61914 depends on bug 93085, which changed state. Bug 93085 Summary: Application window is too high, status bar is not visible (1024x600 resolution), size of module launch inherited from the StartCenter which gets a fixed minimum height (comment 14) https://bugs.documentfoundation.org/show_bug.cgi?id=93085 What|Removed |Added Status|VERIFIED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93085] Application window is too high, status bar is not visible (1024x600 resolution), size of module launch inherited from the StartCenter which gets a fixed minimum height (
https://bugs.documentfoundation.org/show_bug.cgi?id=93085 Christopher changed: What|Removed |Added Resolution|FIXED |--- Status|VERIFIED|REOPENED --- Comment #37 from Christopher --- The old behavior is once again present in LibreOffice 6.0.7 and in 6.1.4 both, at least on 64-bit Debian-based OSes. I manually installed 6.1.4.2 over whatever 6.0.7.x version came with Xubuntu 18.04 (my current OS) and this did not resolve the issue. If I open LibreOffice to the Start Center, it will not size to my 1024x600 screen. If I open a document from the file manager, it will. I suppose something got rolled back after a bit... unfortunately. It would be nice if this were fixed again in the next revision of LibreOffice, and considerably nicer if it actually stayed that way this time. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Changes to 'refs/tags/libreoffice-6.2.0.2'
Tag 'libreoffice-6.2.0.2' created by Andras Timar at 2019-01-13 19:53 + libreoffice-6.2.0.2 Changes since libreoffice-6.2.0.1-18: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'libreoffice-6-2' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d57f2ccb141de2bda83628b2a0f852a10d5158cd Author: Andras Timar AuthorDate: Sun Jan 13 20:53:09 2019 +0100 Commit: Andras Timar CommitDate: Sun Jan 13 20:53:09 2019 +0100 Bump version to 6.2.0.2 Change-Id: I0134af9a0b48cbceb160c8b2a1c4a959ece69bab diff --git a/configure.ac b/configure.ac index d23a5da2e..8006afa11 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ AC_PREREQ([2.63]) -AC_INIT([libreoffice-online], [6.2.0.1], [libreoffice@lists.freedesktop.org]) +AC_INIT([libreoffice-online], [6.2.0.2], [libreoffice@lists.freedesktop.org]) LT_INIT([shared, disable-static, dlopen]) AM_INIT_AUTOMAKE([1.10 subdir-objects tar-pax -Wno-portability]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: basegfx/Library_basegfx.mk basegfx/source
basegfx/Library_basegfx.mk |3 --- basegfx/source/range/b1drange.cxx | 22 -- basegfx/source/tuple/b2i64tuple.cxx | 22 -- basegfx/source/tuple/b3ituple.cxx | 22 -- 4 files changed, 69 deletions(-) New commits: commit 5669026f584d2bfc2d8aba93a4a5c24dc79be541 Author: Takeshi Abe AuthorDate: Sun Jan 13 23:55:55 2019 +0900 Commit: Noel Grandin CommitDate: Sun Jan 13 20:46:01 2019 +0100 basegfx: Kill empty .cxx Change-Id: I5bf94400d787bd57396870878d3ae7bd1e36e22d Reviewed-on: https://gerrit.libreoffice.org/66263 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/basegfx/Library_basegfx.mk b/basegfx/Library_basegfx.mk index 68a7372c1073..4a89d4995583 100644 --- a/basegfx/Library_basegfx.mk +++ b/basegfx/Library_basegfx.mk @@ -58,7 +58,6 @@ $(eval $(call gb_Library_add_exception_objects,basegfx,\ basegfx/source/polygon/b3dpolygontools \ basegfx/source/polygon/b3dpolypolygon \ basegfx/source/polygon/b3dpolypolygontools \ -basegfx/source/range/b1drange \ basegfx/source/range/b2dpolyrange \ basegfx/source/range/b2drange \ basegfx/source/range/b2drangeclipper \ @@ -76,9 +75,7 @@ $(eval $(call gb_Library_add_exception_objects,basegfx,\ basegfx/source/tools/unopolypolygon \ basegfx/source/tools/zoomtools \ basegfx/source/tuple/b2dtuple \ -basegfx/source/tuple/b2i64tuple \ basegfx/source/tuple/b3dtuple \ -basegfx/source/tuple/b3ituple \ basegfx/source/vector/b2dvector \ basegfx/source/vector/b2ivector \ basegfx/source/vector/b3dvector \ diff --git a/basegfx/source/range/b1drange.cxx b/basegfx/source/range/b1drange.cxx deleted file mode 100644 index fbe7a39d9808.. --- a/basegfx/source/range/b1drange.cxx +++ /dev/null @@ -1,22 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -#include - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/basegfx/source/tuple/b2i64tuple.cxx b/basegfx/source/tuple/b2i64tuple.cxx deleted file mode 100644 index ba316ff916f9.. --- a/basegfx/source/tuple/b2i64tuple.cxx +++ /dev/null @@ -1,22 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -#include - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/basegfx/source/tuple/b3ituple.cxx b/basegfx/source/tuple/b3ituple.cxx deleted file mode 100644 index fef2359c7c9d.. --- a/basegfx/source/tuple/b3ituple.cxx +++ /dev/null @@ -1,22 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0
[Libreoffice-bugs] [Bug 122695] Impress: tooltip doesn't stay when hovering over Content Type selector
https://bugs.documentfoundation.org/show_bug.cgi?id=122695 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Xisco Faulí --- Reproduced in Version: 6.3.0.0.alpha0+ Build ID: a5784b7fd63cee073d85b669f745f7f6271ab040 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117147] latest update won't open the DOCX documents, crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=117147
Roman Kuznetsov <79045_79...@mail.ru> changed:
What|Removed |Added
Keywords||filter:docx
Blocks||93529, 104450
--- Comment #19 from Roman Kuznetsov <79045_79...@mail.ru> ---
fast opening and no crash in
Версия: 6.1.3.1 (x64)
ID сборки: a9670562c26181ec3afbe381c9ff499ae88c98b7
Потоков ЦП: 4; ОС:Windows 10.0; Отрисовка ИП: GL;
Локаль: ru-RU (ru_RU); Calc: threaded
DriverVersion: 24.20.100.6286
DriverDate: 8-15-2018
DeviceID: PCI\VEN_8086_591B_1A101043_04
AdapterVendorID: 0x8086
AdapterDeviceID: 0x591b
AdapterSubsysID: 0x1a101043
DeviceKey:
System\CurrentControlSet\Control\Video\{F8C86852-6691-11E8-B80B-E25B7CE3019B}\
DeviceString: Intel(R) HD Graphics 630
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=93529
[Bug 93529] [META] VCL/OpenGL rendering tracker bug for 5.0+
https://bugs.documentfoundation.org/show_bug.cgi?id=104450
[Bug 104450] [META] DOCX (OOXML) file opening issues
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL rendering tracker bug for 5.0+
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||117147 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=117147 [Bug 117147] latest update won't open the DOCX documents, crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104450] [META] DOCX (OOXML) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104450 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||117147 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=117147 [Bug 117147] latest update won't open the DOCX documents, crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76324] CALC becomes very slow with 5000+ comments
https://bugs.documentfoundation.org/show_bug.cgi?id=76324 --- Comment #68 from Dan H --- Here's an interesting datum: in LibreOffice 6.1.4.2-1.fc29 under Fedora 29, the save-after-small-edit test, on one of my production spreadsheets with many thousands of comments, takes about 80 seconds if both the GTK2 and GTK3 integration packages are installed, but takes only about 25 seconds if only the GTK2 integration package is installed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115625] FILEOPEN DOCX: Text Frame Placed on Wrong Position
https://bugs.documentfoundation.org/show_bug.cgi?id=115625 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||104449 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104449 [Bug 104449] [META] DOCX (OOXML) textbox-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104449] [META] DOCX (OOXML) textbox-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104449 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||115625 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115625 [Bug 115625] FILEOPEN DOCX: Text Frame Placed on Wrong Position -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - vcl/inc vcl/os2
vcl/inc/unx/x11_cursors/assw_mask.h | 10 +-
vcl/os2/source/src/chain.ptr|binary
2 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 0906c985dbb1ab292155d1b7eb2b1908fbf6752d
Author: Matthias Seidel
AuthorDate: Sun Jan 13 18:39:03 2019 +
Commit: Matthias Seidel
CommitDate: Sun Jan 13 18:39:03 2019 +
OS/2 has black pointer
diff --git a/vcl/os2/source/src/chain.ptr b/vcl/os2/source/src/chain.ptr
index 13a0aa2440ff..8ac5f9032357 100644
Binary files a/vcl/os2/source/src/chain.ptr and b/vcl/os2/source/src/chain.ptr
differ
commit 81b26cc1eccd270591f1ad741dde24f9ec4004c6
Author: Matthias Seidel
AuthorDate: Sun Jan 13 18:02:13 2019 +
Commit: Matthias Seidel
CommitDate: Sun Jan 13 18:02:13 2019 +
Corrected mask for X11 pointer (autoscroll south west)
diff --git a/vcl/inc/unx/x11_cursors/assw_mask.h
b/vcl/inc/unx/x11_cursors/assw_mask.h
index 0c629f20cf7e..4b2780170ff7 100644
--- a/vcl/inc/unx/x11_cursors/assw_mask.h
+++ b/vcl/inc/unx/x11_cursors/assw_mask.h
@@ -29,8 +29,8 @@ static const unsigned char assw_mask_bits[] = {
0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
- 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
- 0x00,0x00,0x0e,0x00,0x00,0x00,0x1f,0x00,0x00,0x00,0x1f,0x00,0x00,0x10,0x1f,
- 0x00,0x00,0x18,0x0e,0x00,0x00,0x38,0x00,0x00,0x00,0x38,0x00,0x00,0x00,0xfc,
- 0x00,0x00,0x00,0xfc,0x03,0x00,0x00,0xfc,0x01,0x00,0x00,0x3c,0x00,0x00,0x00,
- 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00};
+ 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x0E,0x00,
+ 0x00,0x00,0x1F,0x00,0x00,0x80,0x3F,0x00,0x00,0x90,0x3F,0x00,0x00,0xB8,0x3F,
+ 0x00,0x00,0x3C,0x1F,0x00,0x00,0x7C,0x0E,0x00,0x00,0xFC,0x00,0x00,0x00,0xFE,
+ 0x03,0x00,0x00,0xFE,0x07,0x00,0x00,0xFE,0x03,0x00,0x00,0xFE,0x01,0x00,0x00,
+ 0x3E,0x00,0x00,0x00,0x00,0x00,0x00,0x00};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122696] New: Improvement for "page" configuration
https://bugs.documentfoundation.org/show_bug.cgi?id=122696 Bug ID: 122696 Summary: Improvement for "page" configuration Product: LibreOffice Version: 6.2.0.2 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cide...@gmail.com Add the paper Type list: • The paper for the press series ISO RA and SRA. • British Imperial System. • United States Customary System. Example: The RA series of ISO paper formats: RA0 1220 × 860 mm. RA1 860 × 610 mm. RA2 610 × 430 mm. RA3 430 × 305 mm. RA4 305 × 215 mm. RA5 215 × 152 mm. RA6 152 × 107 mm. The SRA series of ISO paper formats: SRA0 1280 × 900 mm. SRA1 900 × 640 mm. SRA2 640 × 450 mm. SRA3 450 × 320 mm. SRA4 320 × 225 mm. SRA5 225 × 160 mm. SRA6 160 × 112 mm. Atte. Pablo Félix Jiménez -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122695] New: Impress: tooltip doesn't stay when hovering over Content Type selector
https://bugs.documentfoundation.org/show_bug.cgi?id=122695 Bug ID: 122695 Summary: Impress: tooltip doesn't stay when hovering over Content Type selector Product: LibreOffice Version: 5.2.0.4 release Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com CC: caol...@redhat.com Created attachment 148294 --> https://bugs.documentfoundation.org/attachment.cgi?id=148294=edit Screenshot of Content Type selector with a tooltip When hovering over Content Type selector (see [1] page 15 "Selecting slide layout", and the attachment), on Windows, a tooltip is shown initially when cursor is over the button's border, but then disappears immediately as cursor moves towards the center of the button. This looks like flickering, and the tooltip is effectively absent (testing on Ubuntu, I couldn't even get the tooltip when over the button edge). To reproduce: 1. Create a new presentation, dismiss template selector 2. Right-click the first slide at the left-hand Slides pane, and select Layout->Title and 2 Content 3. Try hovering the mouse pointer over the Content Type selectors. This is a regression in 5.2, and was OK in 5.1. Bibisecting using bibisect-win32-5.2, https://git.libreoffice.org/core/+/681294d55b6b4edcdef08982596cb4bcee32e635 is identified (although it's strange that the commit mentions gtk3 but shows on both Linux and Windows, but it still looks relevant modifying e.g. sd/source/ui/slidesorter/view/SlsToolTip.cxx). Tested using Version: 6.2.0.2 (x64) Build ID: 2ce5217b30a543f7666022df50f0562f82be0cff CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: CL and with Version: 6.1.4.2 Build ID: 1:6.1.4-0ubuntu0.18.04.1~lo1 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group threaded Caolán: could you please take a look? [1] https://wiki.documentfoundation.org/images/9/90/GS6006-GettingStartedWithImpress.pdf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122627] 'URL Recognition' in Options tab of AutoCorrect Options dialog is broken (gen/gtk2)
https://bugs.documentfoundation.org/show_bug.cgi?id=122627 Xisco Faulí changed: What|Removed |Added Ever confirmed|0 |1 Keywords|bibisectRequest |bibisected, bisected CC||caol...@redhat.com Status|UNCONFIRMED |NEW --- Comment #2 from Xisco Faulí --- Regression introduced by: author Caolán McNamara 2018-12-03 15:31:02 + committer Caolán McNamara 2018-12-04 09:54:13 +0100 commit bf1932fe2133e5954441be6299e6788c17e1d1b9 (patch) tree77995bbb032b9a56b33e42ee5bdd46bafe29e681 parent a5784b7fd63cee073d85b669f745f7f6271ab040 (diff) weld OfaAutocorrOptionsPage Bisected with: bibisect-linux64-6.3 Adding Cc: to Caolán McNamara -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122627] 'URL Recognition' in Options tab of AutoCorrect Options dialog is broken (gen/gtk2)
https://bugs.documentfoundation.org/show_bug.cgi?id=122627 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Hardware|x86-64 (AMD64) |All OS|Windows (All) |All Summary|'URL Recognition' in|'URL Recognition' in |Options tab of AutoCorrect |Options tab of AutoCorrect |Options dialog is broken|Options dialog is broken ||(gen/gtk2) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
