[Libreoffice-bugs] [Bug 130662] Word changed after pressing Space
https://bugs.documentfoundation.org/show_bug.cgi?id=130662 --- Comment #3 from Timur --- When reporting a bug, we don't know if you are aware of options. Like Tools / Autocorrect / Correct Two Initial Capitals. That shouldn't depend on don't type. So far, this all looks like not a bug. If you can explain why it would be a bug, with reproducible steps, you may set Unconfirmed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130527] Calc spoils xlsx file when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=130527 --- Comment #12 from Timur --- Xusco, please see this script gone wild and neutralize it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
9 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 9 of 9 defect(s)
** CID 1458437: Incorrect expression (USELESS_CALL)
*** CID 1458437: Incorrect expression (USELESS_CALL)
/vcl/source/fontsubset/sft.cxx: 2434 in
vcl::GetTTGlobalFontInfo(vcl::TrueTypeFont *, vcl::TTGlobalFontInfo *)()
2428 if (table && table_size >= 10) {
2429 info->ascender = XUnits(UPEm, GetInt16(table,
HHEA_ascender_offset));
2430 info->descender = XUnits(UPEm, GetInt16(table,
HHEA_descender_offset));
2431 info->linegap = XUnits(UPEm, GetInt16(table,
HHEA_lineGap_offset));
2432 }
2433
>>> CID 1458437: Incorrect expression (USELESS_CALL)
>>> Calling "vcl::getTable(ttf, 8U)" is only useful for its return value,
>>> which is ignored.
2434 getTable(ttf, O_vhea);
2435 }
2436
2437 GlyphData *GetTTRawGlyphData(TrueTypeFont *ttf, sal_uInt32 glyphID)
2438 {
2439 const sal_uInt8* glyf = getTable(ttf, O_glyf);
** CID 1458436: Error handling issues (CHECKED_RETURN)
/vcl/source/window/builder.cxx: 3186 in
VclBuilder::handleRow(xmlreader::XmlReader &, const rtl::OString &)()
*** CID 1458436: Error handling issues (CHECKED_RETURN)
/vcl/source/window/builder.cxx: 3186 in
VclBuilder::handleRow(xmlreader::XmlReader &, const rtl::OString &)()
3180 {
3181 name = reader.getAttributeValue(false);
3182 sContext = OString(name.begin, name.length);
3183 }
3184 }
3185
>>> CID 1458436: Error handling issues (CHECKED_RETURN)
>>> Calling "nextItem" without checking return value (as is done elsewhere
>>> 25 out of 31 times).
3186 reader.nextItem(
3187 xmlreader::XmlReader::Text::Raw, , );
3188
3189 OString sValue(name.begin, name.length);
3190 OUString sFinalValue;
3191 if (bTranslated)
** CID 1458435: Error handling issues (CHECKED_RETURN)
/vcl/source/window/builder.cxx: 3347 in
VclBuilder::handleItems(xmlreader::XmlReader &) const()
*** CID 1458435: Error handling issues (CHECKED_RETURN)
/vcl/source/window/builder.cxx: 3347 in
VclBuilder::handleItems(xmlreader::XmlReader &) const()
3341 {
3342 name = reader.getAttributeValue(false);
3343 sId = OString(name.begin, name.length);
3344 }
3345 }
3346
>>> CID 1458435: Error handling issues (CHECKED_RETURN)
>>> Calling "nextItem" without checking return value (as is done elsewhere
>>> 25 out of 31 times).
3347 reader.nextItem(
3348 xmlreader::XmlReader::Text::Raw, , );
3349
3350 OString sValue(name.begin, name.length);
3351 OUString sFinalValue;
3352 if (bTranslated)
** CID 1458434:(TAINTED_SCALAR)
/filter/source/graphicfilter/ipict/ipict.cxx: 1129 in
::PictReader::ReadPixMapEtc(BitmapEx &, bool, bool, tools::Rectangle
*, tools::Rectangle *, bool, bool)()
/filter/source/graphicfilter/ipict/ipict.cxx: 1129 in
::PictReader::ReadPixMapEtc(BitmapEx &, bool, bool, tools::Rectangle
*, tools::Rectangle *, bool, bool)()
*** CID 1458434:(TAINTED_SCALAR)
/filter/source/graphicfilter/ipict/ipict.cxx: 1129 in
::PictReader::ReadPixMapEtc(BitmapEx &, bool, bool, tools::Rectangle
*, tools::Rectangle *, bool, bool)()
1123 aScanline[ i++ ] = nDat;
1124 }
1125 }
1126 sal_uInt8* pTmp = aScanline.data();
1127 if ( nCmpCount == 4 )
1128 pTmp += nWidth;
>>> CID 1458434:(TAINTED_SCALAR)
>>> Using tainted variable "nWidth" as a loop boundary.
1129 for (sal_uInt16 nx = 0; nx < nWidth; pTmp++)
1130 pBitmap->SetPixel(ny, nx++, Color(*pTmp, pTmp[
nWidth ], pTmp[ 2 * nWidth ]));
1131 nDataSize += nByteCount;
1132 pPict->Seek( nSrcBitsPos + nByteCount );
1133 }
1134 }
/filter/source/graphicfilter/ipict/ipict.cxx: 1129 in
[Libreoffice-bugs] [Bug 130300] compress png files
https://bugs.documentfoundation.org/show_bug.cgi?id=130300 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128286] After delete all character in input method Composition Window, input cursor jump 1 character after
https://bugs.documentfoundation.org/show_bug.cgi?id=128286 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129431] Crashes other program when I over-write pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=129431 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130378] Switch from 6.2 to 6.3, Extension Java Development, Fatal Exception: Signal 6 / Core Dumps / Unstable API ?
https://bugs.documentfoundation.org/show_bug.cgi?id=130378 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130644] Setting up Bookmarks for a TOC.
https://bugs.documentfoundation.org/show_bug.cgi?id=130644 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130605] LibreOffice Calc Opens a 37mb CSV with 15 columns and around 100 thousand rows Much Slower than Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=130605 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130300] compress png files
https://bugs.documentfoundation.org/show_bug.cgi?id=130300 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126906] Libre Writer Locks Up Itself and the Whole GNOME Desktop Upon Pasting Web Page Contents
https://bugs.documentfoundation.org/show_bug.cgi?id=126906 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127668] Main LO window closes with some LO application
https://bugs.documentfoundation.org/show_bug.cgi?id=127668 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130605] LibreOffice Calc Opens a 37mb CSV with 15 columns and around 100 thousand rows Much Slower than Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=130605 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130644] Setting up Bookmarks for a TOC.
https://bugs.documentfoundation.org/show_bug.cgi?id=130644 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130378] Switch from 6.2 to 6.3, Extension Java Development, Fatal Exception: Signal 6 / Core Dumps / Unstable API ?
https://bugs.documentfoundation.org/show_bug.cgi?id=130378 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126525] Use external color pickers as provided by os/DE, or other projects
https://bugs.documentfoundation.org/show_bug.cgi?id=126525 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126525] Use external color pickers as provided by os/DE, or other projects
https://bugs.documentfoundation.org/show_bug.cgi?id=126525 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126525] Use external color pickers as provided by os/DE, or other projects
https://bugs.documentfoundation.org/show_bug.cgi?id=126525 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126525] Use external color pickers as provided by os/DE, or other projects
https://bugs.documentfoundation.org/show_bug.cgi?id=126525 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 130676] LibO Calc: Insert Time Shortcut (Ctrl + shift + ; ) Doesn't Work Properly
https://bugs.documentfoundation.org/show_bug.cgi?id=130676 Ming Hua changed: What|Removed |Added CC||ming.v@qq.com --- Comment #1 from Ming Hua --- Hi Rania, Thanks for reporting the bug. What operating system and what keyboard layouts are you using? It is also helpful if you can paste the inforamtion about your system in the Help > About LibreOffice dialog (the text can be selected by mouse) here. This is a known problem for some keyboard layouts, see for example, the dependency list of bug 107243. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130662] Word changed after pressing Space
https://bugs.documentfoundation.org/show_bug.cgi?id=130662 --- Comment #2 from smsourov...@outlook.com --- In Bangladesh, we use a font named SutonnyMJ. It uses ANSI letters and show them as Bangla letters. It's an old method but widely used(even now while I'm typing this). You may say that why don't we use Unicode. I'll say ask that question to other people. While I was typing using SutonnyMJ font, I couldn't see that. I'm extremely sorry if I misused bugzilla. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106675] PRINTING: Add option to print without background
https://bugs.documentfoundation.org/show_bug.cgi?id=106675 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=38 ||065 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130546] Record changes and smart punctuation conversion causes pointless change and restores deleted text
https://bugs.documentfoundation.org/show_bug.cgi?id=130546 --- Comment #2 from Luke Kendall --- Created attachment 157884 --> https://bugs.documentfoundation.org/attachment.cgi?id=157884=edit Another example document, maybe related? A similar problem occurs even when Record changes are off. In the following sentence, ‘Please’ is in italics, and from the comma onwards – ‘,”’ – Regular. I was disturbed to discover that typing three periods, and then a space to get the smart punctuation to convert the periods into an ellipsis, removed the italics of the ‘Please’. Do you think this bug is related to (or the same as) the above bug? “Please,” began Anika. See the attached file, which adds to the previous version of the example document. I also wonder whether the bug is Linux only. It's odd that it couldn't be reproduced under Windows. Perhaps there's an option or customisation that causes the problem? I went looking for what I referred to as "smart punctuation" but couldn't find anything like that under the Tool->Options menus. I think it's actually set via AutoCorrect. I see I have .*... and … (ellipsis). Maybe the regexp is causing the problem? Hmm, maybe not: changing that AutoCorrect option to .*... -> … made no difference. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103683] PDF export mediabox trimbox cropbox bleedbox artbox
https://bugs.documentfoundation.org/show_bug.cgi?id=103683 --- Comment #11 from Nora --- Your report and pictures can utilize grayscale, CMYK, named spot hues, RGB, or Lab shading models. Each can be either uncalibrated or aligned by utilizing an ICC shading profile. For best outcomes, install the profile in the produced print-prepared PDF. The Dynamic Media Classic Server does this as a matter of course. Ensure that all necessary https://assignmenthelp247.com/ shading profiles have been transferred to the Dynamic Media Classic stage. Ideally, ensure that the shading the executives alternatives set in your plan application, coordinate those set in your Dynamic Media Classic Server. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71300] PDF: Impress should not export the background color into pdf file.
https://bugs.documentfoundation.org/show_bug.cgi?id=71300 V Stuart Foote changed: What|Removed |Added Resolution|--- |DUPLICATE CC||vstuart.fo...@utsa.edu Status|NEW |RESOLVED --- Comment #7 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 38065 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Bug 103378 depends on bug 71300, which changed state. Bug 71300 Summary: PDF: Impress should not export the background color into pdf file. https://bugs.documentfoundation.org/show_bug.cgi?id=71300 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source include/xmloff reportdesign/source sc/inc sc/source sw/source xmloff/inc xmloff/qa xmloff/source
dbaccess/source/filter/xml/xmlAutoStyle.cxx |4 dbaccess/source/filter/xml/xmlAutoStyle.hxx |2 dbaccess/source/filter/xml/xmlColumn.cxx|6 dbaccess/source/filter/xml/xmlExport.cxx| 30 +- dbaccess/source/filter/xml/xmlStyleImport.cxx | 42 +-- dbaccess/source/filter/xml/xmlStyleImport.hxx |8 dbaccess/source/filter/xml/xmlTable.cxx |2 include/xmloff/SchXMLImportHelper.hxx |2 include/xmloff/XMLShapeStyleContext.hxx |2 include/xmloff/XMLTextMasterStylesContext.hxx |4 include/xmloff/XMLTextShapeStyleContext.hxx |2 include/xmloff/families.hxx | 107 include/xmloff/prstylei.hxx |2 include/xmloff/shapeexport.hxx |4 include/xmloff/styleexp.hxx |5 include/xmloff/txtparae.hxx |6 include/xmloff/txtstyli.hxx |2 include/xmloff/xmlaustp.hxx | 27 +- include/xmloff/xmlimp.hxx |4 include/xmloff/xmlstyle.hxx | 29 +- reportdesign/source/filter/xml/xmlAutoStyle.cxx |4 reportdesign/source/filter/xml/xmlAutoStyle.hxx |2 reportdesign/source/filter/xml/xmlCell.cxx |2 reportdesign/source/filter/xml/xmlColumn.cxx|4 reportdesign/source/filter/xml/xmlExport.cxx| 32 +- reportdesign/source/filter/xml/xmlExport.hxx|4 reportdesign/source/filter/xml/xmlHelper.cxx|2 reportdesign/source/filter/xml/xmlRow.cxx |4 reportdesign/source/filter/xml/xmlStyleImport.cxx | 64 ++-- reportdesign/source/filter/xml/xmlStyleImport.hxx | 12 reportdesign/source/filter/xml/xmlTable.cxx |2 reportdesign/source/filter/xml/xmlfilter.cxx|2 sc/inc/sheetdata.hxx|3 sc/source/filter/xml/sheetdata.cxx |4 sc/source/filter/xml/xmlannoi.cxx |2 sc/source/filter/xml/xmlannoi.hxx | 11 sc/source/filter/xml/xmlcelli.cxx |2 sc/source/filter/xml/xmlcoli.cxx|2 sc/source/filter/xml/xmlexprt.cxx | 78 ++--- sc/source/filter/xml/xmlexternaltabi.cxx|2 sc/source/filter/xml/xmlimprt.cxx |4 sc/source/filter/xml/xmlrowi.cxx|2 sc/source/filter/xml/xmlstyle.cxx | 10 sc/source/filter/xml/xmlstyle.hxx |4 sc/source/filter/xml/xmlstyli.cxx | 96 +++ sc/source/filter/xml/xmlstyli.hxx | 18 - sc/source/filter/xml/xmlsubti.cxx |2 sw/source/filter/xml/xmlfmt.cxx | 114 sw/source/filter/xml/xmlfmte.cxx|6 sw/source/filter/xml/xmlimp.cxx |6 sw/source/filter/xml/xmlimp.hxx |4 sw/source/filter/xml/xmlitemi.cxx | 11 sw/source/filter/xml/xmltbli.cxx|8 sw/source/filter/xml/xmltexte.cxx |4 sw/source/uibase/config/StoredChapterNumbering.cxx |6 xmloff/inc/PageMasterStyleMap.hxx |2 xmloff/inc/SchXMLAutoStylePoolP.hxx |2 xmloff/inc/StyleMap.hxx | 10 xmloff/inc/XMLChartStyleContext.hxx |2 xmloff/qa/unit/uxmloff.cxx |6 xmloff/source/chart/SchXMLAutoStylePoolP.cxx|4 xmloff/source/chart/SchXMLExport.cxx| 12 xmloff/source/chart/XMLChartStyleContext.cxx|4 xmloff/source/core/xmlimp.cxx |6 xmloff/source/draw/XMLGraphicsDefaultStyle.cxx |2 xmloff/source/draw/XMLShapeStyleContext.cxx | 18 - xmloff/source/draw/sdxmlexp.cxx | 14 - xmloff/source/draw/shapeexport.cxx
Your presentation on LibreOffice code
[ Please don't drop the list from CC, you may get valuable input from others. ] I've joined the list now. > Perhaps what you want is to tweak/extend the code that maps an OUString> to a > list of glyphs, the vcl text layout. > > GenericSalLayout::LayoutText() at vcl/source/gdi/CommonSalLayout.cxx:286 > does that using harfbuzz, I believe standard gtk apps use that at the > end as well. What is OUString? Does it come from Harfbuzz which uses previously known characters? If so, it won't work. I need to map a combination of keys (two or more keys pressed simultaneously) to a glyph. As I said, the keys have non-standard keycodes. So I would still need to trap the keystrokes and save the values of the hardware_keycodes that are part of the GdkEventKey for each key that is pressed, and then create a composite value and pass that value to GenericSalLayout::LayoutText() and map it to the glyph value (again a non-standard value but which is part of a fontfile I have generated). Where would I intercept the key_press_event and key_release_event of the GtkTextView before converting it to the OUString and passing it to GenericSalLayout::LayoutText() ? -a ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 130676] New: LibO Calc: Insert Time Shortcut (Ctrl + shift + ; ) Doesn't Work Properly
https://bugs.documentfoundation.org/show_bug.cgi?id=130676 Bug ID: 130676 Summary: LibO Calc: Insert Time Shortcut (Ctrl + shift + ;) Doesn't Work Properly Product: LibreOffice Version: 6.4.0.3 release Hardware: x86-64 (AMD64) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: m...@raniaamina.id Description: To insert date and time quickly, actually we hold down ctrl + ; (for date) and ctrl + shift + ; (for time). Insert date work properly, but not for insert time shortcut. When i hold down ctrl + shift + ; appear ( : ) character instead time. I try to look for keyboard shortcut list on Tool menu -> Customize -> Keyboard. At insert functions list, there no option for Time, so i can't make custom shortcut. Steps to Reproduce: 1. Open LibreOffice Calc 2. Hold Down Ctrl + Shift + ; button Actual Results: Appear ( : ) chararter inside cell Expected Results: Appear current time inside cell Reproducible: Always User Profile Reset: No Additional Info: I tried on newest LibreOfficedev but this problem still exist. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Bug 103378 depends on bug 38065, which changed state. Bug 38065 Summary: PDF Export with OS or LibO Appearance background color https://bugs.documentfoundation.org/show_bug.cgi?id=38065 What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 João Paulo changed: What|Removed |Added Depends on||38065 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=38065 [Bug 38065] PDF Export with OS or LibO Appearance background color -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130608] LibreOffice Writer - Highlight Colors do not stay as saved
https://bugs.documentfoundation.org/show_bug.cgi?id=130608 --- Comment #7 from stefane.guevrem...@gmail.com --- No Way!!!... Thank you!!! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130651] Fedora 31 / Gnome: Crash when switching between application window (with AlternateTab Extension enabled)
https://bugs.documentfoundation.org/show_bug.cgi?id=130651 Kevin Suo changed: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130651] Fedora 31 / Gnome: Crash when switching between application window (with AlternateTab Extension enabled)
https://bugs.documentfoundation.org/show_bug.cgi?id=130651 --- Comment #1 from Kevin Suo --- Created attachment 157883 --> https://bugs.documentfoundation.org/attachment.cgi?id=157883=edit gdbtrace.log gdb backtrace with a debug-symbol-only build as of commit f0c8312bc6630ed64f174acc6f65bb5172765951 (2020-02-14 10:55:43 +0100)l -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
I Need Your Consent to Proceed
How are you doing today hope your still using this email libreoffice@lists.freedesktop.org I am Mr. Gregg William from Alert Security Firm London, I am representing an investor from chemgas.com with the mandate to help find a dependable international trustee to channel the investment fund of USD $20 million into 10 years profitable project that will target a reasonable return on investment (ROI) With a strong plan to compensate your assistance. This plan will also give you full authority to handle the investment. 10% from the total investment amount has been allocated for compensation. kindly let me know if you are interested to proceed and what area of investment you would recommend. Thank you as I await your swift action. Regards, Gregg William Alert Security Company ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 130328] AppContainer Isolation based Windows Store App
https://bugs.documentfoundation.org/show_bug.cgi?id=130328 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130327] Frame in Header problems: only shows on all pages after anchor is changed "to page" and then to any other anchor
https://bugs.documentfoundation.org/show_bug.cgi?id=130327 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130319] Zooming right in causes Freeze Cells point to be forgotten after inevitable zoom out again
https://bugs.documentfoundation.org/show_bug.cgi?id=130319 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130336] Use of custom colors is not consistent
https://bugs.documentfoundation.org/show_bug.cgi?id=130336 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130279] Missing emojis in the GB autocorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=130279 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130316] The portable version of Writer pops up a bubble saying that there is an upgrade available, which can lead to failure.
https://bugs.documentfoundation.org/show_bug.cgi?id=130316 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124259] LibreOffice 6.2 Turkish spell checking dictionary is missing in Turkish installation
https://bugs.documentfoundation.org/show_bug.cgi?id=124259 --- Comment #3 from QA Administrators --- Dear HidayetKurnaz, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126811] in 6.3, Base will not accept the ACCESS database
https://bugs.documentfoundation.org/show_bug.cgi?id=126811 --- Comment #4 from QA Administrators --- Dear Ernst Sigl, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130527] Calc spoils xlsx file when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=130527 QA Administrators changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130527] Calc spoils xlsx file when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=130527 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125431] An unwanted image is corrupting .pdf conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=125431 --- Comment #11 from QA Administrators --- Dear 510jrb2301, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105743] Textflow changes on hiding whitespace && two columns-layout
https://bugs.documentfoundation.org/show_bug.cgi?id=105743 --- Comment #7 from QA Administrators --- Dear BottleOnTheGround, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130675] Cell borders overflow in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=130675 --- Comment #2 from jun meguro --- Created attachment 157882 --> https://bugs.documentfoundation.org/attachment.cgi?id=157882=edit sample.pdf sample.pdf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130675] Cell borders overflow in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=130675 --- Comment #1 from jun meguro --- Created attachment 157881 --> https://bugs.documentfoundation.org/attachment.cgi?id=157881=edit sample.ods sample.ods -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130675] New: Cell borders overflow in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=130675 Bug ID: 130675 Summary: Cell borders overflow in Calc Product: LibreOffice Version: 6.3.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmag...@gmail.com Description: When using calc, if you set the cell border in a specific pattern, the cell line will protrude. Open attached .ods and pdf. This behavior occurs in LO6. *, But not in LO5. *. Steps to Reproduce: 1.Open new Calc heet. 2.Set border line as specific pattern.(look at attached sample) 3. Actual Results: cell line will protrude. Expected Results: Fit borders like any other pattern. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: version: 6.3.4.2 Build ID: 1:6.3.4-0ubuntu0.19.10.1 CPU threads: 8; OS:Linux 5.3; UI render: default; VCL: gtk3; Locale: ja-JP (ja_JP.UTF-8); UI-Language: ja-JP Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130605] LibreOffice Calc Opens a 37mb CSV with 15 columns and around 100 thousand rows Much Slower than Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=130605 --- Comment #2 from Ben --- (In reply to m.a.riosv from comment #1) > So please attach a csv file where to test the slowness on opening it. The site tells me the csv is too large to attach -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/uiconfig
chart2/uiconfig/ui/sidebartype.ui | 52 ++ 1 file changed, 20 insertions(+), 32 deletions(-) New commits: commit 0cb4f304abf6f8dd6b40eb800788d2fe80581813 Author: andreas kainz AuthorDate: Fri Feb 14 23:23:59 2020 +0100 Commit: andreas_kainz CommitDate: Sat Feb 15 00:25:34 2020 +0100 chart sidebar chart type alignment update Change-Id: I22a72ec8354ea3832ab27f362b1487894283305e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88749 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/chart2/uiconfig/ui/sidebartype.ui b/chart2/uiconfig/ui/sidebartype.ui index d8b82bae4fb3..d6d9dbaa0cc0 100644 --- a/chart2/uiconfig/ui/sidebartype.ui +++ b/chart2/uiconfig/ui/sidebartype.ui @@ -29,18 +29,14 @@ True False -6 -6 -6 -6 -6 -6 +6 True False True -6 +3 +6 True @@ -73,12 +69,13 @@ True False -6 +3 True False -12 +True +6 _3D Look @@ -99,6 +96,7 @@ False +True Simple Realistic @@ -180,7 +178,7 @@ True False -6 +3 _Stack series @@ -204,7 +202,7 @@ True False -6 +3 On top @@ -262,7 +260,8 @@ True False -12 +True +6 False @@ -279,6 +278,7 @@ False +True Straight Smooth @@ -326,7 +326,8 @@ True False -12 +True +6 False @@ -346,6 +347,7 @@ True True +True True adjustment1 @@ -370,25 +372,13 @@ True False -6 +3 6 - - -True -False -Chart Type: -True -cmb_chartType - - -0 -0 - - True False +center True liststore2 0 @@ -407,8 +397,9 @@ -1 +0 0 +2 @@ -420,11 +411,8 @@ 0 -1 +0 - - - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130660] Don't hardcode paper sizes into LibreOffice Source code, store them in XML and provide GUI to add own sizes.
https://bugs.documentfoundation.org/show_bug.cgi?id=130660 iantheprogrammer changed: What|Removed |Added Severity|normal |enhancement --- Comment #2 from iantheprogrammer --- Thank you for the suggestion. I have reduced the bug's severity to "enhancement." -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: common/Session.hpp kit/ChildSession.cpp kit/ChildSession.hpp
common/Session.hpp |6 --
kit/ChildSession.cpp | 14 --
kit/ChildSession.hpp |6 --
3 files changed, 26 deletions(-)
New commits:
commit 701cb6a230f3796964442560e057aa05dbe01a67
Author: Michael Meeks
AuthorDate: Fri Feb 14 18:49:56 2020 +
Commit: Michael Meeks
CommitDate: Fri Feb 14 23:33:49 2020 +0100
tdf#130673 - kill obsolete locking.
This dates back to 2016 and our pre non-blocking and pre-unipoll state.
It is no longer necessary - a single thread reads all data from the
socket and feeds events into the Kit process; much cleaner.
Change-Id: I46ad6806a1e0cdbb0e5cf4ea5d3e5e5078d3391a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88741
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
diff --git a/common/Session.hpp b/common/Session.hpp
index 6a3f7cfea..aa585a559 100644
--- a/common/Session.hpp
+++ b/common/Session.hpp
@@ -175,12 +175,6 @@ protected:
_lastActivityTime = std::chrono::steady_clock::now();
}
-/// Internal lock shared with derived classes.
-std::unique_lock getLock()
-{
-return std::unique_lock(_mutex);
-}
-
void dumpState(std::ostream& os) override;
private:
diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index d45891b58..83acd082f 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -50,8 +50,6 @@ using Poco::URI;
using namespace LOOLProtocol;
-std::recursive_mutex ChildSession::Mutex;
-
namespace {
std::vector decodeBase64(const std::string & inputBase64)
@@ -88,8 +86,6 @@ void ChildSession::disconnect()
{
if (!isDisconnected())
{
-std::unique_lock lock(Mutex);
-
if (_viewId >= 0)
{
if (_docManager)
@@ -125,8 +121,6 @@ bool ChildSession::_handleInput(const char *buffer, int
length)
// Client is getting active again.
// Send invalidation and other sync-up messages.
-std::unique_lock lock(Mutex); //TODO: Move to
top of function?
-
getLOKitDocument()->setView(_viewId);
int curPart = 0;
@@ -610,8 +604,6 @@ bool ChildSession::loadDocument(const char * /*buffer*/,
int /*length*/, const s
assert(!getDocURL().empty());
assert(!getJailedFilePath().empty());
-std::unique_lock lock(Mutex);
-
#if defined(ENABLE_DEBUG) && !MOBILEAPP
if (std::getenv("PAUSEFORDEBUGGER"))
{
@@ -2219,7 +2211,6 @@ bool ChildSession::removeTextContext(const char*
/*buffer*/, int /*length*/,
return false;
}
-std::unique_lock lock(getLock());
getLOKitDocument()->setView(_viewId);
getLOKitDocument()->removeTextContext(id, before, after);
@@ -2233,7 +2224,6 @@ void ChildSession::rememberEventsForInactiveUser(const
int type, const std::stri
{
if (type == LOK_CALLBACK_INVALIDATE_TILES)
{
-std::unique_lock lock(getLock());
_stateRecorder.recordInvalidate(); // TODO remember the area, not just
a bool ('true' invalidates everything)
}
else if (type == LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR ||
@@ -2249,7 +2239,6 @@ void ChildSession::rememberEventsForInactiveUser(const
int type, const std::stri
type == LOK_CALLBACK_CELL_ADDRESS ||
type == LOK_CALLBACK_REFERENCE_MARKS)
{
-std::unique_lock lock(getLock());
_stateRecorder.recordEvent(type, payload);
}
else if (type == LOK_CALLBACK_INVALIDATE_VIEW_CURSOR ||
@@ -2259,7 +2248,6 @@ void ChildSession::rememberEventsForInactiveUser(const
int type, const std::stri
type == LOK_CALLBACK_VIEW_CURSOR_VISIBLE ||
type == LOK_CALLBACK_VIEW_LOCK)
{
-std::unique_lock lock(getLock());
Poco::JSON::Parser parser;
Poco::JSON::Object::Ptr root =
parser.parse(payload).extract();
@@ -2272,7 +2260,6 @@ void ChildSession::rememberEventsForInactiveUser(const
int type, const std::stri
std::string value;
if (LOOLProtocol::parseNameValuePair(payload, name, value, '='))
{
-std::unique_lock lock(getLock());
_stateRecorder.recordState(name, payload);
}
}
@@ -2280,7 +2267,6 @@ void ChildSession::rememberEventsForInactiveUser(const
int type, const std::stri
type == LOK_CALLBACK_REDLINE_TABLE_ENTRY_MODIFIED ||
type == LOK_CALLBACK_COMMENT)
{
-std::unique_lock lock(getLock());
_stateRecorder.recordEventSequence(type, payload);
}
}
diff --git a/kit/ChildSession.hpp b/kit/ChildSession.hpp
index 4a64be709..8aaa46b54 100644
--- a/kit/ChildSession.hpp
+++ b/kit/ChildSession.hpp
@@ -220,14 +220,12 @@ public:
bool sendTextFrame(const char* buffer, int length) override
{
const auto msg = "client-" + getId() + ' ' + std::string(buffer,
length);
-const std::unique_lock lock = getLock();
return _docManager->sendFrame(msg.data(), msg.size(), WSOpCode::Text);
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - common/Util.cpp
common/Util.cpp |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit 7091f57b358fd06a236b96cc91990251bba8ea6e
Author: Michael Meeks
AuthorDate: Mon Jan 20 19:33:00 2020 +
Commit: Michael Meeks
CommitDate: Fri Feb 14 23:33:38 2020 +0100
util: for process thread count - ignore '.' and '..' in /proc/self/tasks
Change-Id: Ieec6eaac475b4e318578cfc0d93c36e2395e6f19
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87097
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
(cherry picked from commit 09bb16ad78f71e285b6059774ce089b9ef1d006b)
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87110
diff --git a/common/Util.cpp b/common/Util.cpp
index 2a0151615..253c4a35e 100644
--- a/common/Util.cpp
+++ b/common/Util.cpp
@@ -157,8 +157,12 @@ namespace Util
return -1;
}
int tasks = 0;
-while (readdir(fdDir))
-tasks++;
+struct dirent *i;
+while ((i = readdir(fdDir)))
+{
+if (i->d_name[0] != '.')
+tasks++;
+}
closedir(fdDir);
return tasks;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/basegfx
include/basegfx/polygon/b2dpolygontools.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f164ceaed1edc631a14afe128d3623cdac1a1197 Author: Andrea Gelmini AuthorDate: Fri Feb 14 22:34:34 2020 +0100 Commit: Julien Nabet CommitDate: Fri Feb 14 23:29:54 2020 +0100 Fix typo Change-Id: I314345471928d61b11cc88858f84146534c74d9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88746 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/include/basegfx/polygon/b2dpolygontools.hxx b/include/basegfx/polygon/b2dpolygontools.hxx index 90001bae7131..e1eb4c044dbb 100644 --- a/include/basegfx/polygon/b2dpolygontools.hxx +++ b/include/basegfx/polygon/b2dpolygontools.hxx @@ -198,7 +198,7 @@ namespace basegfx this internally to guarantee the same algorithm is used) it is not needed to accumulate a potentially huge number of polygons in the result-polyPolygons, but e.g. consume -them directly in the caller. Example is renderinmg a +them directly in the caller. Example is rendering a dashed line but without creating the potentially huge amount of polygons. The 2nd version will also merge first/last line/gap snippets ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/app/inputhdl.cxx |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
New commits:
commit 8705ca0c8a8f87fc4880922064f1f84cac1ea42c
Author: ayhanyalcinsoy
AuthorDate: Sun Jan 5 19:39:57 2020 +0300
Commit: Eike Rathke
CommitDate: Fri Feb 14 22:58:36 2020 +0100
tdf#124443: show arguments' tooltip above if in Formula Bar's Input Line
Change-Id: I33d52af9c2b1ac3f5cfe279ff17d487c70b8cf32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86226
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index acf924de9397..b0131488e148 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -1156,7 +1156,14 @@ void ScInputHandler::ShowArgumentsTip( OUString&
rSelText )
aBuf.append( " : " );
aBuf.append(
ppFDesc->getParameterDescription(nActive-1) );
aNew = aBuf.makeStringAndClear();
-ShowTipBelow( aNew );
+if (eMode != SC_INPUT_TOP)
+{
+ShowTipBelow( aNew );
+}
+else
+{
+ShowTip(aNew);
+}
bFound = true;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130608] LibreOffice Writer - Highlight Colors do not stay as saved
https://bugs.documentfoundation.org/show_bug.cgi?id=130608 Regina Henschel changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED CC||rb.hensc...@t-online.de --- Comment #6 from Regina Henschel --- The docx format has only some special colors as "highlighting" and your eca4ff does not belong to them and a nearby color is used. If you want eca4ff as color, you need to use it as ordinary background color. LibreOffice has a switch for that. Go to Tools > Options > Load/Save > Microsoft Office. Set the option 'Export as' from 'Highlighting' to 'Shading' in section 'Character Highlighting'. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130472] The xlsx files containing hatched auto-shapes cannot open
https://bugs.documentfoundation.org/show_bug.cgi?id=130472 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #4 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I noticed these kinds of logs: warn:vcl.gdi:280028:280028:vcl/source/bitmap/BitmapFastScaleFilter.cxx:112: no resize warn:vcl.gdi:280028:280028:vcl/source/bitmap/bitmapfilter.cxx:26: Bitmap filter failed warn:vcl.gdi:280028:280028:vcl/source/bitmap/bitmapfilter.cxx:26: Bitmap filter failed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130674] New: Empty window behind password dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=130674 Bug ID: 130674 Summary: Empty window behind password dialog Product: LibreOffice Version: 6.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thorsten.wagne...@gmail.com Description: When opening an encrypted document using operating systems file manager an empty window is displayed behind password dialog. Steps to Reproduce: 1. Quit LO or close Startcenter 2. Open an encrypted document using operating systems file manager Actual Results: An empty window is displayed behind password dialog. Expected Results: Password dialog is displayed without an empty window behind it. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Issue existis using LO 6.4.0 and is present with current revision of master as well. Issue is visible on macOS at least, but other operating systems may be affected too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130608] LibreOffice Writer - Highlight Colors do not stay as saved
https://bugs.documentfoundation.org/show_bug.cgi?id=130608 stefane.guevrem...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #5 from stefane.guevrem...@gmail.com --- Oh! Gotcha. I'm using 6.2.8.2 (x64) Steps to Reproduce: 1. Create new LibreOffice Writer Document 2. Write some text 3. Select characters 4. Click on "Highlight Color" Tool 5. Click on Custom Color... 6. in "Hex #:" textarea, write: eca4ff 7. Click Ok 8. Save As 9. In "Save as type:" choose "Word 2007-2019 (*.docx)" 10. Save File 11. Reopen File That's it! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svtools svtools/source
include/svtools/unitconv.hxx |5 --
svtools/source/misc/unitconv.cxx | 92 ---
2 files changed, 1 insertion(+), 96 deletions(-)
New commits:
commit e917918dfb42ef9f95768280918bc42c628de0be
Author: Caolán McNamara
AuthorDate: Fri Feb 14 15:52:14 2020 +
Commit: Caolán McNamara
CommitDate: Fri Feb 14 21:44:16 2020 +0100
remove recently unused functions
Change-Id: Ie7645d7f9b8350d3a993c40541747dc8ac817ab9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88730
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/svtools/unitconv.hxx b/include/svtools/unitconv.hxx
index f787e0cee42d..2edf1ade815b 100644
--- a/include/svtools/unitconv.hxx
+++ b/include/svtools/unitconv.hxx
@@ -25,8 +25,6 @@
namespace weld { class MetricSpinButton; }
-class MetricField;
-
// macro -
// typedef ---
@@ -36,7 +34,6 @@ typedef long (*FUNC_CONVERT)(long);
// Functions -
SVT_DLLPUBLIC void SetFieldUnit(weld::MetricSpinButton& rCtrl, FieldUnit
eUnit, bool bAll = false);
-SVT_DLLPUBLIC void SetFieldUnit( MetricField& rCtrl, FieldUnit eUnit,
bool bAll = false );
SVT_DLLPUBLIC long CalcToUnit( float nIn, MapUnit eUnit );
SVT_DLLPUBLIC long CalcToPoint( long nIn, MapUnit eUnit, sal_uInt16
nFactor );
@@ -47,9 +44,7 @@ SVT_DLLPUBLIC long ControlToItem( long nIn, FieldUnit
eCtrl, MapUnit eItem
SVT_DLLPUBLIC FieldUnit MapToFieldUnit( const MapUnit eUnit );
SVT_DLLPUBLIC void SetMetricValue(weld::MetricSpinButton& rField, int
lCoreValue, MapUnit eUnit);
-SVT_DLLPUBLIC void SetMetricValue( MetricField& rField, long lCoreValue,
MapUnit eUnit );
SVT_DLLPUBLIC int GetCoreValue(const weld::MetricSpinButton& rField,
MapUnit eUnit);
-SVT_DLLPUBLIC long GetCoreValue( const MetricField& rField, MapUnit eUnit
);
SVT_DLLPUBLIC long PointToTwips( long nIn );
diff --git a/svtools/source/misc/unitconv.cxx b/svtools/source/misc/unitconv.cxx
index ef5494a6f96e..8076b6890196 100644
--- a/svtools/source/misc/unitconv.cxx
+++ b/svtools/source/misc/unitconv.cxx
@@ -19,7 +19,7 @@
#include
#include
-#include
+#include
#include
void SetFieldUnit(weld::MetricSpinButton& rField, FieldUnit eUnit, bool bAll)
@@ -80,64 +80,6 @@ void SetFieldUnit(weld::MetricSpinButton& rField, FieldUnit
eUnit, bool bAll)
}
}
-void SetFieldUnit( MetricField& rField, FieldUnit eUnit, bool bAll )
-{
-sal_Int64 nFirst= rField.Denormalize( rField.GetFirst( FieldUnit::TWIP
) );
-sal_Int64 nLast = rField.Denormalize( rField.GetLast( FieldUnit::TWIP ) );
-sal_Int64 nMin = rField.Denormalize( rField.GetMin( FieldUnit::TWIP ) );
-sal_Int64 nMax = rField.Denormalize( rField.GetMax( FieldUnit::TWIP ) );
-
-if ( !bAll )
-{
-switch ( eUnit )
-{
-case FieldUnit::M:
-case FieldUnit::KM:
-eUnit = FieldUnit::CM;
-break;
-
-case FieldUnit::FOOT:
-case FieldUnit::MILE:
-eUnit = FieldUnit::INCH;
-break;
-default: ;//prevent warning
-}
-}
-rField.SetUnit( eUnit );
-switch( eUnit )
-{
-// _CHAR and _LINE sets the step of "char" and "line" unit, they are
same as FieldUnit::MM
-case FieldUnit::CHAR:
-case FieldUnit::LINE:
-case FieldUnit::MM:
-rField.SetSpinSize( 50 );
-break;
-
-case FieldUnit::INCH:
-rField.SetSpinSize( 2 );
-break;
-
-default:
-rField.SetSpinSize( 10 );
-}
-
-if ( FieldUnit::POINT == eUnit )
-{
-if( rField.GetDecimalDigits() > 1 )
-rField.SetDecimalDigits( 1 );
-}
-else
-rField.SetDecimalDigits( 2 );
-
-if ( !bAll )
-{
-rField.SetFirst( rField.Normalize( nFirst ), FieldUnit::TWIP );
-rField.SetLast( rField.Normalize( nLast ), FieldUnit::TWIP );
-rField.SetMin( rField.Normalize( nMin ), FieldUnit::TWIP );
-rField.SetMax( rField.Normalize( nMax ), FieldUnit::TWIP );
-}
-}
-
void SetMetricValue(weld::MetricSpinButton& rField, int nCoreValue, MapUnit
eUnit)
{
auto nVal = OutputDevice::LogicToLogic(nCoreValue, eUnit,
MapUnit::Map100thMM);
@@ -145,14 +87,6 @@ void SetMetricValue(weld::MetricSpinButton& rField, int
nCoreValue, MapUnit eUni
rField.set_value(nVal, FieldUnit::MM_100TH);
}
-void SetMetricValue( MetricField& rField, long nCoreValue, MapUnit eUnit )
-{
-sal_Int64 nVal = OutputDevice::LogicToLogic( nCoreValue, eUnit,
MapUnit::Map100thMM );
-nVal = rField.Normalize( nVal );
-rField.SetValue(nVal, FieldUnit::MM_100TH);
-
-}
-
int GetCoreValue(const weld::MetricSpinButton& rField,
[Libreoffice-bugs] [Bug 63087] Detective "Trace Precedents" or "Trace Dependents" pointing to a different tab does not provide reference cell
https://bugs.documentfoundation.org/show_bug.cgi?id=63087 gte.ejecut...@ecosa.com.co changed: What|Removed |Added CC||gte.ejecut...@ecosa.com.co --- Comment #34 from gte.ejecut...@ecosa.com.co --- This is, imho, the most important issue if LO is to be considered a replacement for Excel in business. Without it, only simple sheets can be reviewed on a timely basis. A workaround for tracing dependents in other sheets is to find/replace using regular expressions as follows: sheet\..*A.*1 where, for a given cell sheet.A1: sheet is the sheet name A is the column 1 is the row The regular expression characters used: \ to take the period as a literal .* any character any number of times (to search with/without absolute references - $) It's not perfect (it will find some references that are not the cell in question) buy won't miss any case. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/uiconfig
sc/uiconfig/scalc/ui/sidebaralignment.ui |6 ++ 1 file changed, 6 insertions(+) New commits: commit f05aa5bc92ba93cc730f7f61e21011c6f5c82088 Author: andreas kainz AuthorDate: Fri Feb 14 17:18:09 2020 +0100 Commit: andreas_kainz CommitDate: Fri Feb 14 21:32:14 2020 +0100 calc alignment sidebar sync width Change-Id: Ib15b57e03d7a9fc83639b685ee872ee54ba8bb18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88733 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/sc/uiconfig/scalc/ui/sidebaralignment.ui b/sc/uiconfig/scalc/ui/sidebaralignment.ui index 0ced578a0d95..5d5474ba6e01 100644 --- a/sc/uiconfig/scalc/ui/sidebaralignment.ui +++ b/sc/uiconfig/scalc/ui/sidebaralignment.ui @@ -459,4 +459,10 @@ + + + + + + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/uiconfig
sc/uiconfig/scalc/ui/sidebarcellappearance.ui |3 +++ 1 file changed, 3 insertions(+) New commits: commit dda88aca3151dd4916c5f7599293f8e5cd161f2e Author: andreas kainz AuthorDate: Fri Feb 14 17:27:48 2020 +0100 Commit: andreas_kainz CommitDate: Fri Feb 14 21:31:43 2020 +0100 clac cell appearance sidebar alignment update Change-Id: If9e2069ef514474fa748af9bec185c2437c33035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88734 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/sc/uiconfig/scalc/ui/sidebarcellappearance.ui b/sc/uiconfig/scalc/ui/sidebarcellappearance.ui index 0631a1d62585..eb134808a776 100644 --- a/sc/uiconfig/scalc/ui/sidebarcellappearance.ui +++ b/sc/uiconfig/scalc/ui/sidebarcellappearance.ui @@ -33,6 +33,7 @@ True True Select the background color of the selected cells. +end icons False 2 @@ -88,6 +89,7 @@ True True Select the line color of the borders. +end icons False 2 @@ -118,6 +120,7 @@ True True +end icons False 2 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129275] Typing problem with Old Hungarian text in Writer under Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=129275 Kovács Viktor changed: What|Removed |Added Assignee|kovacs.viktor@gmail.com |libreoffice-b...@lists.free ||desktop.org Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #22 from Kovács Viktor --- Good bye! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107244] [META] Ctrl+Alt (aka AltGR) keyboard shortcut issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107244 Bug 107244 depends on bug 129275, which changed state. Bug 129275 Summary: Typing problem with Old Hungarian text in Writer under Windows https://bugs.documentfoundation.org/show_bug.cgi?id=129275 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/ui/envelp/label1.cxx| 24
sw/source/uibase/inc/labimp.hxx |3 ---
sw/source/uibase/inc/uitool.hxx |5 -
sw/source/uibase/utlui/uitool.cxx | 13 -
4 files changed, 12 insertions(+), 33 deletions(-)
New commits:
commit 90fbc16b5667324ec5f4bf54b1b6fc0677958686
Author: Caolán McNamara
AuthorDate: Fri Feb 14 15:47:29 2020 +
Commit: Caolán McNamara
CommitDate: Fri Feb 14 21:25:00 2020 +0100
remove MetricField use from sw
Change-Id: Ib59efd309521db5dd568ae4f3353034839cb7e1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88729
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/ui/envelp/label1.cxx b/sw/source/ui/envelp/label1.cxx
index 38bc29df5f57..4ac097718c0e 100644
--- a/sw/source/ui/envelp/label1.cxx
+++ b/sw/source/ui/envelp/label1.cxx
@@ -21,6 +21,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -388,24 +389,23 @@ IMPL_LINK_NOARG(SwLabPage, TypeHdl, weld::ComboBox&, void)
void SwLabPage::DisplayFormat()
{
-ScopedVclPtrInstance< MetricField >
aField(Application::GetDefDialogParent(), WinBits(0));
-FieldUnit aMetric = ::GetDfltMetric(false);
-SetMetric(*aField, aMetric);
-aField->SetDecimalDigits(2);
-aField->SetMin (0);
-aField->SetMax (LONG_MAX);
+std::unique_ptr
xBuilder(Application::CreateBuilder(GetFrameWeld(), "cui/ui/spinbox.ui"));
+std::unique_ptr
xField(xBuilder->weld_metric_spin_button("spin", FieldUnit::CM));
+SetFieldUnit(*xField, ::GetDfltMetric(false));
+xField->set_digits(2);
+xField->set_range(0, INT_MAX - 1, FieldUnit::NONE);
SwLabRec* pRec = GetSelectedEntryPos();
aItem.m_aLstType = pRec->m_aType;
-SETFLDVAL(*aField, pRec->m_nWidth);
-aField->Reformat();
-const OUString aWString = aField->GetText();
+setfldval(*xField, pRec->m_nWidth);
+xField->reformat();
+const OUString aWString = xField->get_text();
-SETFLDVAL(*aField, pRec->m_nHeight);
-aField->Reformat();
+setfldval(*xField, pRec->m_nHeight);
+xField->reformat();
OUString aText = pRec->m_aType + ": " + aWString +
- " x " + aField->GetText() +
+ " x " + xField->get_text() +
" (" + OUString::number( pRec->m_nCols ) +
" x " + OUString::number( pRec->m_nRows ) + ")";
m_xFormatInfo->set_label(aText);
diff --git a/sw/source/uibase/inc/labimp.hxx b/sw/source/uibase/inc/labimp.hxx
index 928ee86ec600..e8db8aab1140 100644
--- a/sw/source/uibase/inc/labimp.hxx
+++ b/sw/source/uibase/inc/labimp.hxx
@@ -21,9 +21,6 @@
#include
-#define GETFLDVAL(rField)
(rField).Denormalize((rField).GetValue(FieldUnit::TWIP))
-#define SETFLDVAL(rField, lValue)
(rField).SetValue((rField).Normalize(lValue), FieldUnit::TWIP)
-
inline int getfldval(const weld::MetricSpinButton& rField)
{
return rField.denormalize(rField.get_value(FieldUnit::TWIP));
diff --git a/sw/source/uibase/inc/uitool.hxx b/sw/source/uibase/inc/uitool.hxx
index 867107bfffe3..0ecd18da1575 100644
--- a/sw/source/uibase/inc/uitool.hxx
+++ b/sw/source/uibase/inc/uitool.hxx
@@ -19,12 +19,10 @@
#ifndef INCLUDED_SW_SOURCE_UIBASE_INC_UITOOL_HXX
#define INCLUDED_SW_SOURCE_UIBASE_INC_UITOOL_HXX
-#include
#include
#include
#include
-class MetricFormatter;
class SfxItemSet;
class SwPageDesc;
class SvxTabStopItem;
@@ -38,9 +36,6 @@ class DateTime;
class SfxViewFrame;
class SwEditShell;
-// switch a metric
-SW_DLLPUBLIC void SetMetric(MetricFormatter& rCtrl, FieldUnit eUnit);
-
// fill BoxInfo attribute
SW_DLLPUBLIC void PrepareBoxInfo(SfxItemSet& rSet, const SwWrtShell& rSh);
diff --git a/sw/source/uibase/utlui/uitool.cxx
b/sw/source/uibase/utlui/uitool.cxx
index 1acca5313503..cf82118f8ace 100644
--- a/sw/source/uibase/utlui/uitool.cxx
+++ b/sw/source/uibase/utlui/uitool.cxx
@@ -74,19 +74,6 @@ using namespace ::com::sun::star;
// General list of string pointer
-// Switch metric
-
-void SetMetric(MetricFormatter& rCtrl, FieldUnit eUnit)
-{
-SwTwips nMin = static_cast< SwTwips >(rCtrl.GetMin(FieldUnit::TWIP));
-SwTwips nMax = static_cast< SwTwips >(rCtrl.GetMax(FieldUnit::TWIP));
-
-rCtrl.SetUnit(eUnit);
-
-rCtrl.SetMin(nMin, FieldUnit::TWIP);
-rCtrl.SetMax(nMax, FieldUnit::TWIP);
-}
-
// Set boxinfo attribute
void PrepareBoxInfo(SfxItemSet& rSet, const SwWrtShell& rSh)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source cui/uiconfig cui/UIConfig_cui.mk solenv/sanitizers
cui/UIConfig_cui.mk |1
cui/source/tabpages/grfpage.cxx | 25 ++--
cui/uiconfig/ui/spinbox.ui | 82
solenv/sanitizers/ui/cui.suppr |1
4 files changed, 98 insertions(+), 11 deletions(-)
New commits:
commit 14cb677a4325ac3e4e150f10a62f15e744093bf4
Author: Caolán McNamara
AuthorDate: Fri Feb 14 15:31:59 2020 +
Commit: Caolán McNamara
CommitDate: Fri Feb 14 21:24:14 2020 +0100
remove MetricField use from cui
Change-Id: I10729db9ae465a714657b58cbfa67bed47a6c7f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88726
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/cui/UIConfig_cui.mk b/cui/UIConfig_cui.mk
index 38e447aa4b9a..fb243e4eb3c5 100644
--- a/cui/UIConfig_cui.mk
+++ b/cui/UIConfig_cui.mk
@@ -206,6 +206,7 @@ $(eval $(call gb_UIConfig_add_uifiles,cui,\
cui/uiconfig/ui/tsaurldialog \
cui/uiconfig/ui/twolinespage \
cui/uiconfig/ui/wordcompletionpage \
+ cui/uiconfig/ui/spinbox \
cui/uiconfig/ui/zoomdialog \
))
diff --git a/cui/source/tabpages/grfpage.cxx b/cui/source/tabpages/grfpage.cxx
index d44610dd23b1..96e2fcd1b9e2 100644
--- a/cui/source/tabpages/grfpage.cxx
+++ b/cui/source/tabpages/grfpage.cxx
@@ -31,7 +31,6 @@
#include
#include
#include
-#include
#include
#include
#include
@@ -627,16 +626,20 @@ void SvxGrfCropPage::GraphicHasChanged( bool bFound )
// display original size
const FieldUnit eMetric = GetModuleFieldUnit( GetItemSet() );
-ScopedVclPtrInstance< MetricField >
aFld(Application::GetDefDialogParent(), WB_HIDE);
-SetFieldUnit( *aFld, eMetric );
-aFld->SetDecimalDigits(m_xWidthMF->get_digits());
-aFld->SetMax( LONG_MAX - 1 );
-
-aFld->SetValue( aFld->Normalize( aOrigSize.Width() ), eUnit );
-OUString sTemp = aFld->GetText();
-aFld->SetValue( aFld->Normalize( aOrigSize.Height() ), eUnit );
-// multiplication sign (U+00D7)
-sTemp += u"\u00D7" + aFld->GetText();
+OUString sTemp;
+{
+std::unique_ptr
xBuilder(Application::CreateBuilder(GetFrameWeld(), "cui/ui/spinbox.ui"));
+std::unique_ptr
xFld(xBuilder->weld_metric_spin_button("spin", FieldUnit::CM));
+SetFieldUnit( *xFld, eMetric );
+xFld->set_digits(m_xWidthMF->get_digits());
+xFld->set_max(INT_MAX - 1, FieldUnit::NONE);
+
+xFld->set_value(xFld->normalize(aOrigSize.Width()), eUnit);
+sTemp = xFld->get_text();
+xFld->set_value(xFld->normalize(aOrigSize.Height()), eUnit);
+// multiplication sign (U+00D7)
+sTemp += u"\u00D7" + xFld->get_text();
+}
if ( aOrigPixelSize.Width() && aOrigPixelSize.Height() ) {
sal_Int32 ax =
sal_Int32(floor(static_cast(aOrigPixelSize.Width()) /
diff --git a/cui/uiconfig/ui/spinbox.ui b/cui/uiconfig/ui/spinbox.ui
new file mode 100644
index ..0618f37135cd
--- /dev/null
+++ b/cui/uiconfig/ui/spinbox.ui
@@ -0,0 +1,82 @@
+
+
+
+
+
+False
+dialog
+
+
+
+
+
+False
+vertical
+2
+
+
+False
+end
+
+
+gtk-ok
+True
+True
+True
+True
+
+
+True
+True
+0
+
+
+
+
+False
+False
+0
+
+
+
+
+True
+False
+True
+6
+
+
+True
+True
+True
+True
+adjustment1
+1
+
+
+False
+True
+0
+
+
+
+
+False
+True
+1
+
+
+
+
+
+ ok
+
+
+
+1
+10
+1
+1
+10
+
+
diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr
index e58c0a692316..7d71d2e109ad 100644
--- a/solenv/sanitizers/ui/cui.suppr
+++ b/solenv/sanitizers/ui/cui.suppr
@@ -290,6 +290,7 @@ cui/uiconfig/ui/spellingdialog.ui://GtkLabel[@id='explain']
orphan-label
cui/uiconfig/ui/spellingdialog.ui://GtkLabel[@id='resumeft'] orphan-label
cui/uiconfig/ui/spellingdialog.ui://GtkLabel[@id='nosuggestionsft']
orphan-label
cui/uiconfig/ui/spellingdialog.ui://GtkLabel[@id='alttitleft'] orphan-label
+cui/uiconfig/ui/spinbox.ui://GtkSpinButton[@id='spin'] no-labelled-by
cui/uiconfig/ui/storedwebconnectiondialog.ui://GtkLabel[@id='label1']
orphan-label
cui/uiconfig/ui/textanimtabpage.ui://GtkLabel[@id='FT_COUNT'] orphan-label
[Libreoffice-bugs] [Bug 130661] MACRO setformula does not appear to work with array formula
https://bugs.documentfoundation.org/show_bug.cgi?id=130661 --- Comment #2 from christophe.alvi...@insee.fr --- Thanks a lot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/navipi.hxx | 15 -
sw/source/uibase/utlui/navipi.cxx | 43 --
2 files changed, 29 insertions(+), 29 deletions(-)
New commits:
commit 1b2fcca411d410c6cd1fd46fa8f26fa0191f4b05
Author: Caolán McNamara
AuthorDate: Fri Feb 14 12:55:54 2020 +
Commit: Caolán McNamara
CommitDate: Fri Feb 14 21:21:47 2020 +0100
rework SwNavigationPI to listen to two properties
SID_DOCFULLNAME as before, and FN_STAT_PAGE to keep track
of the current number of pages to always keep the page spinbutton
up to date instead of waiting until its focusin signal to change it.
a true gtk spinbutton will have its + disabled unless it can be increased
so it will need to have the current max uptodate before focusing in
Change-Id: I29a5d93ae38c6a3d0e74994a466102af234bfd48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88707
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/uibase/inc/navipi.hxx b/sw/source/uibase/inc/navipi.hxx
index 103dd6ac6255..2b49a0ce6c88 100644
--- a/sw/source/uibase/inc/navipi.hxx
+++ b/sw/source/uibase/inc/navipi.hxx
@@ -28,6 +28,7 @@
#include
#include
#include
+#include
#include
#include
#include "conttree.hxx"
@@ -46,14 +47,18 @@ class SfxChildWindowContext;
enum class RegionMode;
class SpinField;
-class SwNavigationPI : public PanelLayout,
- public SfxControllerItem, public SfxListener
+class SwNavigationPI : public PanelLayout
+ , public
::sfx2::sidebar::ControllerItem::ItemUpdateReceiverInterface
+ , public SfxListener
{
friend class SwNavigationChild;
friend class SwContentTree;
friend class SwGlobalTree;
friend class SwNavigationPIUIObject;
+::sfx2::sidebar::ControllerItem m_aDocFullName;
+::sfx2::sidebar::ControllerItem m_aPageStats;
+
VclPtr m_aContentToolBox;
VclPtr m_aGlobalToolBox;
VclPtr m_xEdit;
@@ -93,7 +98,6 @@ class SwNavigationPI : public PanelLayout,
DECL_LINK( ToolBoxClickHdl, ToolBox *, void );
DECL_LINK( ToolBoxDropdownClickHdl, ToolBox*, void );
DECL_LINK( EditAction, NumEditAction&, void );
-DECL_LINK( EditGetFocus, Control&, void );
DECL_LINK( DoneLink, SfxPoolItem const *, void );
DECL_LINK( MenuSelectHdl, Menu *, bool );
DECL_LINK( ChangePageHdl, Timer*, void );
@@ -123,8 +127,9 @@ public:
voidUpdateListBox();
voidMoveOutline(SwOutlineNodes::size_type nSource,
SwOutlineNodes::size_type nTarget, bool bWithCilds);
-virtual voidStateChanged( sal_uInt16 nSID, SfxItemState eState,
-const SfxPoolItem* pState )
override;
+virtual voidNotifyItemUpdate(const sal_uInt16 nSId,
+ const SfxItemState eState,
+ const SfxPoolItem* pState) override;
virtual voidStateChanged(StateChangedType nStateChange) override;
diff --git a/sw/source/uibase/utlui/navipi.cxx
b/sw/source/uibase/utlui/navipi.cxx
index cdda8dbe783b..466c65b39d9d 100644
--- a/sw/source/uibase/utlui/navipi.cxx
+++ b/sw/source/uibase/utlui/navipi.cxx
@@ -403,21 +403,6 @@ IMPL_LINK( SwNavigationPI, EditAction, NumEditAction&,
rEdit, void )
}
}
-// If the page can be set here, the maximum is set.
-
-IMPL_LINK( SwNavigationPI, EditGetFocus, Control&, rControl, void )
-{
-NumEditAction* pEdit = static_cast();
-SwView *pView = GetCreateView();
-if (!pView)
-return;
-SwWrtShell = pView->GetWrtShell();
-
-const sal_uInt16 nPageCnt = rSh.GetPageCnt();
-pEdit->SetMax(nPageCnt);
-pEdit->SetLast(nPageCnt);
-}
-
void SwNavigationPI::ZoomOut()
{
if (!IsZoomedIn())
@@ -510,7 +495,8 @@ SwNavigationPI::SwNavigationPI(vcl::Window* pParent,
const css::uno::Reference& rxFrame,
SfxBindings* _pBindings)
: PanelLayout(pParent, "NavigatorPanel",
"modules/swriter/ui/navigatorpanel.ui", rxFrame/*, true*/)
-, SfxControllerItem(SID_DOCFULLNAME, *_pBindings)
+, m_aDocFullName(SID_DOCFULLNAME, *_pBindings, *this)
+, m_aPageStats(FN_STAT_PAGE, *_pBindings, *this)
, m_pContentView(nullptr)
, m_pContentWrtShell(nullptr)
, m_pActContView(nullptr)
@@ -548,7 +534,6 @@ SwNavigationPI::SwNavigationPI(vcl::Window* pParent,
m_xEdit->SetMin(1);
m_xEdit->SetFirst(1);
m_xEdit->SetActionHdl(LINK(this, SwNavigationPI, EditAction));
-m_xEdit->SetGetFocusHdl(LINK(this, SwNavigationPI, EditGetFocus));
m_xEdit->SetAccessibleName(m_xEdit->GetQuickHelpText());
m_xEdit->SetUpHdl(LINK(this, SwNavigationPI, PageEditModifyHdl));
m_xEdit->SetDownHdl(LINK(this, SwNavigationPI, PageEditModifyHdl));
@@ -692,9 +677,6 @@ void SwNavigationPI::dispose()
m_pxObjectShell.reset();
}
-if (IsBound())
-m_rBindings.Release(*this);
-
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkframe.cxx | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
New commits:
commit e30caebf76ccd088840b870ecb8929ce132baed0
Author: Caolán McNamara
AuthorDate: Fri Feb 14 17:08:04 2020 +
Commit: Caolán McNamara
CommitDate: Fri Feb 14 20:57:46 2020 +0100
don't use gtk_window_group_remove_window if widgets are not GtkWindows
Change-Id: I80d01f29091d7cc06e82295e781ef7a53fb7776b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88739
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index 118c77f9f7b3..ee32281378be 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -2252,19 +2252,22 @@ const SystemEnvData* GtkSalFrame::GetSystemData() const
void GtkSalFrame::SetParent( SalFrame* pNewParent )
{
+GtkWindow* pWindow = GTK_IS_WINDOW(m_pWindow) ? GTK_WINDOW(m_pWindow) :
nullptr;
if (m_pParent)
{
-
gtk_window_group_remove_window(gtk_window_get_group(GTK_WINDOW(m_pParent->m_pWindow)),
GTK_WINDOW(m_pWindow));
+if (pWindow && GTK_IS_WINDOW(m_pParent->m_pWindow))
+
gtk_window_group_remove_window(gtk_window_get_group(GTK_WINDOW(m_pParent->m_pWindow)),
pWindow);
m_pParent->m_aChildren.remove(this);
}
m_pParent = static_cast(pNewParent);
if (m_pParent)
{
m_pParent->m_aChildren.push_back(this);
-
gtk_window_group_add_window(gtk_window_get_group(GTK_WINDOW(m_pParent->m_pWindow)),
GTK_WINDOW(m_pWindow));
+if (pWindow && GTK_IS_WINDOW(m_pParent->m_pWindow))
+
gtk_window_group_add_window(gtk_window_get_group(GTK_WINDOW(m_pParent->m_pWindow)),
pWindow);
}
-if( ! isChild() )
-gtk_window_set_transient_for( GTK_WINDOW(m_pWindow),
+if (!isChild() && pWindow)
+gtk_window_set_transient_for( pWindow,
(m_pParent && !
m_pParent->isChild(true,false)) ? GTK_WINDOW(m_pParent->m_pWindow) : nullptr
);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkframe.cxx | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
New commits:
commit ce16f1f32937ee881268abf91454900b0170c637
Author: Caolán McNamara
AuthorDate: Fri Feb 14 16:57:12 2020 +
Commit: Caolán McNamara
CommitDate: Fri Feb 14 20:57:06 2020 +0100
Resolves: tdf#130414 don't crash attempting gtk_fixed_move if parent changed
Change-Id: I5b51f1fb0eccbdb1b3ad14ff7b36077a0016a838
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88738
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index 62d49dd106e8..118c77f9f7b3 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -709,10 +709,15 @@ void GtkSalFrame::moveWindow( long nX, long nY )
{
if( isChild( false ) )
{
-if( m_pParent )
-gtk_fixed_move( m_pParent->getFixedContainer(),
+GtkWidget* pParent = m_pParent ? gtk_widget_get_parent(m_pWindow) :
nullptr;
+// tdf#130414 its possible that we were reparented and are no longer
inside
+// our original GtkFixed parent
+if (pParent && GTK_IS_FIXED(pParent))
+{
+gtk_fixed_move( GTK_FIXED(pParent),
m_pWindow,
nX - m_pParent->maGeometry.nX, nY -
m_pParent->maGeometry.nY );
+}
}
else
gtk_window_move( GTK_WINDOW(m_pWindow), nX, nY );
@@ -1030,7 +1035,6 @@ void GtkSalFrame::Init( SalFrame* pParent,
SalFrameStyleFlags nStyle )
// insert into container
gtk_fixed_put( m_pParent->getFixedContainer(),
m_pWindow, 0, 0 );
-
}
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126455] Ribbon menu button icons default icons NOT contrasted.. in KDE with Breeze dark theme
https://bugs.documentfoundation.org/show_bug.cgi?id=126455 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||7138 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127138] Breeze dark system theme should enable Breeze dark icons
https://bugs.documentfoundation.org/show_bug.cgi?id=127138 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6455 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/tbxctrls/grafctrl.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 85e52d79debfd496672ed16c6ee916d61bb1e754 Author: Caolán McNamara AuthorDate: Fri Feb 14 15:40:02 2020 + Commit: Caolán McNamara CommitDate: Fri Feb 14 20:55:12 2020 +0100 drop unneeded include Change-Id: Iad7851542b9bb68eb0a5672c797a5b8ffb7deea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88727 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/svx/source/tbxctrls/grafctrl.cxx b/svx/source/tbxctrls/grafctrl.cxx index fe753171034a..2013f544cd16 100644 --- a/svx/source/tbxctrls/grafctrl.cxx +++ b/svx/source/tbxctrls/grafctrl.cxx @@ -21,7 +21,6 @@ #include #include -#include #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svtools svtools/inc svtools/source svx/inc sw/inc
include/svtools/editbrowsebox.hxx |6 +++---
svtools/inc/pch/precompiled_svt.hxx |3 ++-
svtools/source/brwbox/ebbcontrols.cxx | 10 ++
svx/inc/pch/precompiled_svxcore.hxx |3 +--
sw/inc/pch/precompiled_swui.hxx |3 +--
5 files changed, 17 insertions(+), 8 deletions(-)
New commits:
commit 2936c3ce0e10a92b808be02483c6d55089cdc208
Author: Caolán McNamara
AuthorDate: Fri Feb 14 09:36:04 2020 +
Commit: Caolán McNamara
CommitDate: Fri Feb 14 20:54:50 2020 +0100
use fwd decl of SpinField
Change-Id: Ifea23e791ec53448a8591583f283b87430ef38c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88678
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/svtools/editbrowsebox.hxx
b/include/svtools/editbrowsebox.hxx
index 2ac388323e04..0be5603898e2 100644
--- a/include/svtools/editbrowsebox.hxx
+++ b/include/svtools/editbrowsebox.hxx
@@ -27,7 +27,6 @@
#include
#include
#include
-#include
#include
#include
@@ -36,6 +35,7 @@
class Button;
class CheckBox;
+class SpinField;
// EditBrowseBoxFlags (EBBF)
@@ -256,8 +256,8 @@ namespace svt
{
public:
SpinCellController(SpinField* pSpinField);
-const SpinField& GetSpinWindow() const { return static_cast(GetWindow()); }
-SpinField& GetSpinWindow() { return static_cast(GetWindow()); }
+const SpinField& GetSpinWindow() const;
+SpinField& GetSpinWindow();
virtual void SetModified() override;
virtual bool IsModified() const override;
diff --git a/svtools/inc/pch/precompiled_svt.hxx
b/svtools/inc/pch/precompiled_svt.hxx
index a26b21753606..ac1920ba1b9b 100644
--- a/svtools/inc/pch/precompiled_svt.hxx
+++ b/svtools/inc/pch/precompiled_svt.hxx
@@ -13,7 +13,7 @@
manual changes will be rewritten by the next run of update_pch.sh (which
presumably
also fixes all possible problems, so it's usually better to use it).
- Generated on 2020-02-13 16:04:02 using:
+ Generated on 2020-02-14 09:32:48 using:
./bin/update_pch svtools svt --cutoff=4 --exclude:system --include:module
--exclude:local
If after updating build fails, use the following command to locate
conflicting headers:
@@ -101,6 +101,7 @@
#include
#include
#include
+#include
#include
#include
#include
diff --git a/svtools/source/brwbox/ebbcontrols.cxx
b/svtools/source/brwbox/ebbcontrols.cxx
index 822c6413e241..e928fef8bd05 100644
--- a/svtools/source/brwbox/ebbcontrols.cxx
+++ b/svtools/source/brwbox/ebbcontrols.cxx
@@ -18,6 +18,7 @@
#include
#include
+#include
#include
#include
#include
@@ -454,6 +455,15 @@ namespace svt
GetSpinWindow().SetModifyHdl( LINK(this, SpinCellController,
ModifyHdl) );
}
+const SpinField& SpinCellController::GetSpinWindow() const
+{
+return static_cast(GetWindow());
+}
+
+SpinField& SpinCellController::GetSpinWindow()
+{
+return static_cast(GetWindow());
+}
void SpinCellController::SetModified()
{
diff --git a/svx/inc/pch/precompiled_svxcore.hxx
b/svx/inc/pch/precompiled_svxcore.hxx
index 8a4f0d60d792..ddf81c1dc526 100644
--- a/svx/inc/pch/precompiled_svxcore.hxx
+++ b/svx/inc/pch/precompiled_svxcore.hxx
@@ -13,7 +13,7 @@
manual changes will be rewritten by the next run of update_pch.sh (which
presumably
also fixes all possible problems, so it's usually better to use it).
- Generated on 2020-02-13 21:37:51 using:
+ Generated on 2020-02-14 09:32:42 using:
./bin/update_pch svx svxcore --cutoff=7 --exclude:system --include:module
--exclude:local
If after updating build fails, use the following command to locate
conflicting headers:
@@ -62,7 +62,6 @@
#include
#include
#include
-#include
#include
#include
#include
diff --git a/sw/inc/pch/precompiled_swui.hxx b/sw/inc/pch/precompiled_swui.hxx
index fd997e9135b5..806127d57a0e 100644
--- a/sw/inc/pch/precompiled_swui.hxx
+++ b/sw/inc/pch/precompiled_swui.hxx
@@ -13,7 +13,7 @@
manual changes will be rewritten by the next run of update_pch.sh (which
presumably
also fixes all possible problems, so it's usually better to use it).
- Generated on 2020-02-05 19:55:24 using:
+ Generated on 2020-02-14 09:32:42 using:
./bin/update_pch sw swui --cutoff=3 --exclude:system --include:module
--include:local
If after updating build fails, use the following command to locate
conflicting headers:
@@ -151,7 +151,6 @@
#include
#include
#include
-#include
#include
#include
#include
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 130612] Could change format style only once in certain circumstances
https://bugs.documentfoundation.org/show_bug.cgi?id=130612 Timur changed: What|Removed |Added Assignee|campo.fel...@web.de |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 130612] Could change format style only once in certain circumstances
https://bugs.documentfoundation.org/show_bug.cgi?id=130612 Timur changed: What|Removed |Added Assignee|campo.fel...@web.de |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130662] Word changed after pressing Space
https://bugs.documentfoundation.org/show_bug.cgi?id=130662 Timur changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #1 from Timur --- Looks like Correct Two Initial Capitals. If that is, reporting as a bug is s misuse of bugzilla. You need to use ask.libreoffice.org for basic issues. Anyway, you also say resolved, I'll close. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130673] LOOL: UI locks up after pressing backspace on a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=130673 Michael Meeks changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |michael.me...@collabora.com |desktop.org | --- Comment #1 from Michael Meeks --- patch in gerrit: https://gerrit.libreoffice.org/c/online/+/88741 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124443] AutoInput tooltip positioning is inconsistent when editing formula, covering different parts of UI
https://bugs.documentfoundation.org/show_bug.cgi?id=124443 Eike Rathke changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |ayhanyalcin...@pisilinux.or |desktop.org |g --- Comment #5 from Eike Rathke --- Assigning to who was actually working on this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130673] New: LOOL: UI locks up after pressing backspace on a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=130673 Bug ID: 130673 Summary: LOOL: UI locks up after pressing backspace on a cell Product: LibreOffice Online Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: michael.me...@collabora.com Backspace on a cell should open the Delete Contents dialog. - In a spreadsheet, click on a cell (make sure you're not in cell edit mode) and press backspace. => Session locks up, clicking around or trying to enter data does nothing. Exiting the editing session keeps it running in the background. This is a regression, traced back to the cp-6.2 backport of the following commit. https://cgit.freedesktop.org/libreoffice/core/commit/?id=80a1c69a30a55ed648a43976f6ab401ac2b5ceaa author Michael Meeks 2020-02-03 22:47:34 +0100 committer Michael Meeks 2020-02-04 19:59:58 +0100 tdf#130382 - process key-event handlers synchronously for unipoll. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130673] LOOL: UI locks up after pressing backspace on a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=130673 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130382] Chinese / IM text input problem ...
https://bugs.documentfoundation.org/show_bug.cgi?id=130382 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0673 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130672] New: base sql query parameter with negative value fails
https://bugs.documentfoundation.org/show_bug.cgi?id=130672 Bug ID: 130672 Summary: base sql query parameter with negative value fails Product: LibreOffice Version: 6.3.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cwayneda...@gmail.com Description: Simple example: SELECT * FROM "MediaInfo" WHERE "aid" = :P1 The "aid" column is integer and has some negative integers in it. When I run the query and enter a positive integer it works but finds no records if I enter a negative. It does work when I replace :P1 with either '-1030' or just -1030. Sliderule gave two workarounds: SELECT * FROM "MediaInfo" WHERE "aid" = :P1*1 or SELECT * FROM "MediaInfo" WHERE "aid" IN ( :P1 ) He says it's an issue with Base OpenOffice / LibreOffice database parser. Steps to Reproduce: 1. Create table1 with "ID", "AID" columns, both integer. Create data rows, with negative numbers for "aid", ex: ID AID 123 -1030 124 235 666 - 2. Create query SELECT * FROM "table1" WHERE "aid" = :P1 3. Run query, enter -1030 for prompt. Actual Results: No records found. Expected Results: 123, -1030 Reproducible: Always User Profile Reset: No Additional Info: Version: 6.3.4.2 (x64) Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130604] Unable to enable Skia/Vulkan hw rendering on Windows builds
https://bugs.documentfoundation.org/show_bug.cgi?id=130604 V Stuart Foote changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #3 from V Stuart Foote --- On Windows 10 Ent 64-bit (1903) with nVidia K2000 GPU and Version: 7.0.0.0.alpha0+ (x64) Build ID: cf96cb11e2a46c452a273ded1c66c556118983cf CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Vulkan; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: CL The 'Graphics Output' check boxes on the Tools -> Options -> View panel are doing sane things for Skia. The 'Use Skia for all rendering' is enabling Skia/Vulkan, while the 'Force Skia software rendering' is toggling to Skia/raster mode but changing the mode, or enabling/disabling Skia, needs restart of LibreOffice (same as OpenGL rendering). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/Makefile-clang.mk config_host.mk.in configure.ac
compilerplugins/Makefile-clang.mk |8 config_host.mk.in |1 + configure.ac | 14 ++ 3 files changed, 23 insertions(+) New commits: commit bce14e97a6dad7686643d094995433c77e4aee7e Author: Stephan Bergmann AuthorDate: Fri Feb 14 16:28:53 2020 +0100 Commit: Stephan Bergmann CommitDate: Fri Feb 14 19:24:32 2020 +0100 Prevent -Werror,-Wunknown-warning-option when building compilerplugins ...with --enable-werror (seen it fail with a local build against a locally built Clang 5.0.2). (bin/gen-boost-headers faces a similar dilemma with Clang needing to silence -Wunknown-warning-option and GCC failing upon the silencing incantation. There, we were able to hack around that with a preceding #pragma GCC diagnostic ignored "-Wpragmas" Here, the easiest approach appears to be a new COMPILER_PLUGINS_COM_IS_CLANG analoguous to the existing COM_IS_CLANG.) Change-Id: I9036261fdd238c8a020a1d88b4e75fd444f9e030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88725 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/compilerplugins/Makefile-clang.mk b/compilerplugins/Makefile-clang.mk index 543ec27aad44..266919cf02b8 100644 --- a/compilerplugins/Makefile-clang.mk +++ b/compilerplugins/Makefile-clang.mk @@ -101,6 +101,14 @@ CLANGWERROR := #TODO: /WX else CLANGWERROR := -Werror +# When COMPILER_PLUGINS_CXXFLAGS (obtained via `llvm-config --cxxflags`) contains options like +# -Wno-maybe-uninitialized that are targeting GCC (when LLVM was actually built with GCC), and +# COMPILER_PLUGINS_CXX (defaulting to CXX) deonotes a Clang that does not understand those options, +# it fails with -Werror,-Wunknown-warning-option, so we need -Wno-unknown-warning-option (but which +# GCC does not understand) at least with -Werror: +ifeq ($(COMPILER_PLUGINS_COM_IS_CLANG),TRUE) +CLANGWERROR += -Wno-unknown-warning-option +endif endif endif diff --git a/config_host.mk.in b/config_host.mk.in index 9dd4b72c421c..ef612734da3c 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -78,6 +78,7 @@ export COMMONS_LOGGING_JAR=@COMMONS_LOGGING_JAR@ export COMMONS_LOGGING_VERSION=@COMMONS_LOGGING_VERSION@ export COMPATH=@COMPATH@ export COMPILER_PLUGINS=@COMPILER_PLUGINS@ +export COMPILER_PLUGINS_COM_IS_CLANG=@COMPILER_PLUGINS_COM_IS_CLANG@ export COMPILER_PLUGINS_CXX=@COMPILER_PLUGINS_CXX@ export COMPILER_PLUGINS_CXXFLAGS=@COMPILER_PLUGINS_CXXFLAGS@ export COMPILER_PLUGINS_CXX_LINKFLAGS=@COMPILER_PLUGINS_CXX_LINKFLAGS@ diff --git a/configure.ac b/configure.ac index 3fa8fc760e3f..e186f6d3eb73 100644 --- a/configure.ac +++ b/configure.ac @@ -7218,6 +7218,7 @@ if test "$COM_IS_CLANG" != "TRUE"; then fi fi +COMPILER_PLUGINS_COM_IS_CLANG= if test "$COM_IS_CLANG" = "TRUE"; then if test -n "$enable_compiler_plugins"; then compiler_plugins="$enable_compiler_plugins" @@ -7336,6 +7337,18 @@ if test "$COM_IS_CLANG" = "TRUE"; then LDFLAGS=$save_LDFLAGS LIBS="$save_LIBS" AC_LANG_POP([C++]) + +AC_MSG_CHECKING([whether the compiler for building compilerplugins is actually Clang]) +AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ +#ifndef __clang__ +you lose +#endif +int foo=42; +]])], +[AC_MSG_RESULT([yes]) + COMPILER_PLUGINS_COM_IS_CLANG=TRUE], +[AC_MSG_RESULT([no])]) +AC_SUBST(COMPILER_PLUGINS_COM_IS_CLANG) fi else if test "$enable_compiler_plugins" = "yes"; then @@ -7343,6 +7356,7 @@ else fi fi AC_SUBST(COMPILER_PLUGINS) +AC_SUBST(COMPILER_PLUGINS_COM_IS_CLANG) AC_SUBST(COMPILER_PLUGINS_CXX) AC_SUBST(COMPILER_PLUGINS_CXXFLAGS) AC_SUBST(COMPILER_PLUGINS_CXX_LINKFLAGS) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: basegfx/source include/basegfx
basegfx/source/polygon/b2dpolygontools.cxx | 36 +++
basegfx/source/polygon/b3dpolygontools.cxx | 255 +++-
include/basegfx/polygon/b2dpolygontools.hxx |2
include/basegfx/polygon/b3dpolygontools.hxx | 12 +
4 files changed, 216 insertions(+), 89 deletions(-)
New commits:
commit 62ac8333999c661432adb0a18245a399daa89dcb
Author: Armin Le Grand
AuthorDate: Fri Feb 14 16:47:14 2020 +0100
Commit: Armin Le Grand
CommitDate: Fri Feb 14 19:19:49 2020 +0100
tdf#130655 callback interface for 3D and secure dash
Added same interface for 3D but just for lines, it uses no
gaps. Added the security mechanism mentioned in the task
in comment (2) to 2D and 3D
Change-Id: I5da303c01562088682d95ee4f294c99e1f17bf6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88728
Tested-by: Jenkins
Reviewed-by: Armin Le Grand
diff --git a/basegfx/source/polygon/b2dpolygontools.cxx
b/basegfx/source/polygon/b2dpolygontools.cxx
index 68d1120bc2cb..c194a38dc9d2 100644
--- a/basegfx/source/polygon/b2dpolygontools.cxx
+++ b/basegfx/source/polygon/b2dpolygontools.cxx
@@ -16,6 +16,8 @@
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include
+#include
#include
#include
@@ -32,8 +34,6 @@
#include
#include
-#include
-
// #i37443#
#define ANGLE_BOUND_START_VALUE (2.25)
#define ANGLE_BOUND_MINIMUM_VALUE (0.1)
@@ -1231,6 +1231,32 @@ namespace basegfx::utils
return;
}
+// precalculate maximal acceptable length of candidate polygon
assuming
+// we want to create a maximum of fNumberOfAllowedSnippets. For
+// fNumberOfAllowedSnippets use ca. 65536, double due to line &
gap.
+static double fNumberOfAllowedSnippets(65535.0 * 2.0);
+const double fAllowedLength((fNumberOfAllowedSnippets *
fDotDashLength) / double(rDotDashArray.size()));
+const double
fCandidateLength(basegfx::utils::getLength(rCandidate));
+std::vector aDotDashArray(rDotDashArray);
+
+if(fCandidateLength > fAllowedLength)
+{
+// we would produce more than fNumberOfAllowedSnippets, so
+// adapt aDotDashArray to exactly produce assumed number. Also
+// assert this to let the caller know about it.
+// If this asserts: Please think about checking your
DotDashArray
+// before calling this function or evtl. use the callback
version
+// to *not* produce that much of data. Even then, you may still
+// think about producing too much runtime (!)
+assert(true && "applyLineDashing: potentially too expensive to
do the requested dismantle - please consider stretched LineDash pattern (!)");
+
+// calculate correcting factor, apply to aDotDashArray and
fDotDashLength
+// to enlarge these as needed
+const double fFactor(fCandidateLength / fAllowedLength);
+std::for_each(aDotDashArray.begin(), aDotDashArray.end(),
[](double ){ f *= fFactor; });
+fDotDashLength *= fFactor;
+}
+
// prepare current edge's start
B2DCubicBezier aCurrentEdge;
const bool bIsClosed(rCandidate.isClosed());
@@ -1240,7 +1266,7 @@ namespace basegfx::utils
// prepare DotDashArray iteration and the line/gap switching bool
sal_uInt32 nDotDashIndex(0);
bool bIsLine(true);
-double fDotDashMovingLength(rDotDashArray[0]);
+double fDotDashMovingLength(aDotDashArray[0]);
B2DPolygon aSnippet;
// remember 1st and last snippets to try to merge after execution
@@ -1303,7 +1329,7 @@ namespace basegfx::utils
// prepare next DotDashArray step and flip
line/gap flag
fLastDotDashMovingLength = fDotDashMovingLength;
-fDotDashMovingLength +=
rDotDashArray[(++nDotDashIndex) % nDotDashCount];
+fDotDashMovingLength +=
aDotDashArray[(++nDotDashIndex) % nDotDashCount];
bIsLine = !bIsLine;
}
@@ -1367,7 +1393,7 @@ namespace basegfx::utils
// prepare next DotDashArray step and flip
line/gap flag
fLastDotDashMovingLength = fDotDashMovingLength;
-fDotDashMovingLength +=
rDotDashArray[(++nDotDashIndex) % nDotDashCount];
+fDotDashMovingLength +=
aDotDashArray[(++nDotDashIndex) % nDotDashCount];
bIsLine = !bIsLine;
}
diff --git a/basegfx/source/polygon/b3dpolygontools.cxx
b/basegfx/source/polygon/b3dpolygontools.cxx
index
[Libreoffice-bugs] [Bug 123839] window frame too wide - mouse doesn't touch scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=123839 Xisco Faulí changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123839] window frame too wide - mouse doesn't touch scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=123839 --- Comment #8 from JohnForster --- Always make sure the mouse is on if it does not push the restart button at the mouse's bottom to turn it on. If the problem still continues, try restarting the machine if that doesn't solve it, the scroll wheel will have to be cleaned or the scroll wheel will be destroyed. https://beststudentadvisors.com/take-my-exam-help.php -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130661] MACRO setformula does not appear to work with array formula
https://bugs.documentfoundation.org/show_bug.cgi?id=130661
Oliver Brinzing changed:
What|Removed |Added
CC||oliver.brinz...@gmx.de
Resolution|--- |WORKSFORME
Status|UNCONFIRMED |RESOLVED
--- Comment #1 from Oliver Brinzing ---
(In reply to christophe.alviset from comment #0)
> I am using array formulas. For some reason, while using macros or sorting or
> something else, the array formulas go away and I am left with simple
> formulas (ie SUM(...) instead of {SUM(...)}
>
> I want to write a macro to reset these cells to array formulas, but
> setformula does not seem to work with an array formula. It sets a string.
Please try with setArrayFormula(), e.g:
ThisComponent.getSheets().getByIndex(0).getCellByPosition(0,2).setArrayFormula("=SUM((A1:A2)*(B1:B2))")
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75748] FILEOPEN: incorrect display of some numbering styles in .DOC and .DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=75748 --- Comment #21 from Timur --- DOCX is verified fine with 7.0+ and we'll see for DOC in duplicated bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106541] FILEOPEN: Numbering from custom style based on Heading 1 is not considered in this DOC
https://bugs.documentfoundation.org/show_bug.cgi?id=106541 --- Comment #13 from Timur --- Created attachment 157880 --> https://bugs.documentfoundation.org/attachment.cgi?id=157880=edit Appendices DOC compared MSO 2013 LO 7.0+ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106541] FILEOPEN: Numbering from custom style based on Heading 1 is not considered in this DOC
https://bugs.documentfoundation.org/show_bug.cgi?id=106541 --- Comment #12 from Timur --- Created attachment 157879 --> https://bugs.documentfoundation.org/attachment.cgi?id=157879=edit Appendices DOC Since this is now DOC bug, I add DOC version of attachment 126453 DOCX from bug 95495. Saved in MSO 2013. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130345] FIREBIRD: Impossible to create an autovalue key when inserting a new table
https://bugs.documentfoundation.org/show_bug.cgi?id=130345 --- Comment #6 from Julien Nabet --- (In reply to Robert Großkopf from comment #5) > ... > We could > - change the wizard to choose the possibility to set AutoIncrement while > importing rows, which has already a value in the field. The Generator has to > be set afterwords with the max value of the field. > - change the table editor. It should be possible to read the max value of a > Integer field and set this value to the generator. Too difficult task at least for me. > > Since LO 4.2 we have an experimental Firebird database. It is 6 years ago. > Seems it is too tricky to get it working for us. I won't use this kind of > internal database. I understand you too well and already told it... There have been a lot of work to integrate Firebird but it's not the case anymore since several months (years?). I think it should be removed but it's only my personal opinion. I'm gonna send an email to Lionel and Tamas and I put you in cc Alexander Thurgood and you since you're the main (only?) QA experts about Base. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/CppunitTest_sw_core_layout.mk sw/Module_sw.mk sw/qa sw/source
sw/CppunitTest_sw_core_layout.mk | 72 ++ sw/Module_sw.mk |1 sw/qa/core/layout/data/table-fly-overlap.docx |binary sw/qa/core/layout/layout.cxx | 48 + sw/source/core/layout/tabfrm.cxx | 30 ++ 5 files changed, 149 insertions(+), 2 deletions(-) New commits: commit fd7749fddc5a767461dfced55369af48e5a6d561 Author: Miklos Vajna AuthorDate: Fri Feb 14 16:29:44 2020 +0100 Commit: Miklos Vajna CommitDate: Fri Feb 14 18:37:34 2020 +0100 sw: fix handling of table vs fly overlaps in the AddVerticalFlyOffsets case When a table overlaps with a fly frame, Writer creates a fly portion inside the relevant cell frame (increasing its height), and Word shifts the table down. Both are valid approaches, but the rendering result is different in case the table has a border. So keep the default unchanged, but in case the AddVerticalFlyOffsets compat flag (set by the Word importers) is set, avoid the overlap the Word way. Note that the table frame uses the full width (available in the body) even for e.g. 50% width tables, so check for the overlap using the print area, which does not always overlap. Finally, don't always require a valid frame area definition from the fly frame: - the mentioned i#46807 bugdoc currently doesn't need that check - the fly frame area definition becomes valid only after already positioning the table, leading to an overlap Keep that check for the non-compat case, though. Change-Id: I9202050befebf2efdbb5395ded6fcb52b378d8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88724 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/sw/CppunitTest_sw_core_layout.mk b/sw/CppunitTest_sw_core_layout.mk new file mode 100644 index ..1801e66a713d --- /dev/null +++ b/sw/CppunitTest_sw_core_layout.mk @@ -0,0 +1,72 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +#* +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +#* + +$(eval $(call gb_CppunitTest_CppunitTest,sw_core_layout)) + +$(eval $(call gb_CppunitTest_use_common_precompiled_header,sw_core_layout)) + +$(eval $(call gb_CppunitTest_add_exception_objects,sw_core_layout, \ +sw/qa/core/layout/layout \ +)) + +$(eval $(call gb_CppunitTest_use_libraries,sw_core_layout, \ +comphelper \ +cppu \ +cppuhelper \ +sal \ +sfx \ +sw \ +test \ +unotest \ +utl \ +vcl \ +svt \ +tl \ +svl \ +)) + +$(eval $(call gb_CppunitTest_use_externals,sw_core_layout,\ +boost_headers \ +libxml2 \ +)) + +$(eval $(call gb_CppunitTest_set_include,sw_core_layout,\ +-I$(SRCDIR)/sw/inc \ +-I$(SRCDIR)/sw/source/core/inc \ +-I$(SRCDIR)/sw/source/uibase/inc \ +-I$(SRCDIR)/sw/qa/inc \ +$$(INCLUDE) \ +)) + +$(eval $(call gb_CppunitTest_use_api,sw_core_layout,\ + udkapi \ + offapi \ + oovbaapi \ +)) + +$(eval $(call gb_CppunitTest_use_ure,sw_core_layout)) +$(eval $(call gb_CppunitTest_use_vcl,sw_core_layout)) + +$(eval $(call gb_CppunitTest_use_rdb,sw_core_layout,services)) + +$(eval $(call gb_CppunitTest_use_custom_headers,sw_core_layout,\ +officecfg/registry \ +)) + +$(eval $(call gb_CppunitTest_use_configuration,sw_core_layout)) + +$(eval $(call gb_CppunitTest_use_uiconfigs,sw_core_layout, \ +modules/swriter \ +)) + +$(eval $(call gb_CppunitTest_use_more_fonts,sw_core_layout)) + +# vim: set noet sw=4 ts=4: diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk index 44c33f9d9951..06611c2fc283 100644 --- a/sw/Module_sw.mk +++ b/sw/Module_sw.mk @@ -108,6 +108,7 @@ $(eval $(call gb_Module_add_slowcheck_targets,sw,\ CppunitTest_sw_core_doc \ CppunitTest_sw_uibase_shells \ CppunitTest_sw_core_accessibilitycheck \ +CppunitTest_sw_core_layout \ )) ifneq ($(DISABLE_GUI),TRUE) diff --git a/sw/qa/core/layout/data/table-fly-overlap.docx b/sw/qa/core/layout/data/table-fly-overlap.docx new file mode 100644 index ..a819e855b2eb Binary files /dev/null and b/sw/qa/core/layout/data/table-fly-overlap.docx differ diff --git a/sw/qa/core/layout/layout.cxx b/sw/qa/core/layout/layout.cxx new file mode 100644 index ..cbea578be4cc --- /dev/null +++ b/sw/qa/core/layout/layout.cxx @@ -0,0 +1,48 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License,
[Libreoffice-bugs] [Bug 130414] Crash when setting window position via API (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=130414 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/html loleaflet/src
loleaflet/html/loleaflet.html.m4 |3 +++
loleaflet/src/control/Control.AlertDialog.js |6 +-
loleaflet/src/control/Control.Infobar.js |6 +-
loleaflet/src/control/Control.Menubar.js |7 +--
4 files changed, 6 insertions(+), 16 deletions(-)
New commits:
commit ceec4f0505ee5849fe5c4480cf1d70e0aef70849
Author: Jan Holesovsky
AuthorDate: Fri Feb 14 17:08:56 2020 +0100
Commit: Michael Meeks
CommitDate: Fri Feb 14 18:27:51 2020 +0100
android: Actually override window.open to always send the HYPERLINK on
mobile.
To cover potential future developers adding window.open without knowing
it might break mobile...
Change-Id: Iadad985ac6fad9b9f068f224fd8fb21f073bead6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88732
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
diff --git a/loleaflet/html/loleaflet.html.m4 b/loleaflet/html/loleaflet.html.m4
index 4addf8955..9cba7427a 100644
--- a/loleaflet/html/loleaflet.html.m4
+++ b/loleaflet/html/loleaflet.html.m4
@@ -40,6 +40,9 @@ dnl# and window.ThisIsTheGtkApp
ifelse(MOBILEAPP,[true],
[ window.ThisIsAMobileApp = true;
+ window.open = function (url, windowName, windowFeatures) {
+ window.postMobileMessage('HYPERLINK ' + url); /* don't call the 'normal'
window.open on mobile at all */
+ }
window.MobileAppName='MOBILEAPPNAME';],
[ window.ThisIsAMobileApp = false;]
)
diff --git a/loleaflet/src/control/Control.AlertDialog.js
b/loleaflet/src/control/Control.AlertDialog.js
index 20404dcb5..c73d87d92 100644
--- a/loleaflet/src/control/Control.AlertDialog.js
+++ b/loleaflet/src/control/Control.AlertDialog.js
@@ -62,11 +62,7 @@ L.Control.AlertDialog = L.Control.extend({
type: 'button',
className: 'vex-dialog-button-primary',
click: function openClick () {
- if (window.ThisIsAMobileApp) {
-
window.postMobileMessage('HYPERLINK ' + url);
- } else {
- window.open(url,
'_blank');
- }
+ window.open(url, '_blank');
vex.closeAll();
}
});
diff --git a/loleaflet/src/control/Control.Infobar.js
b/loleaflet/src/control/Control.Infobar.js
index 48b92c8a1..b00d0cdb2 100644
--- a/loleaflet/src/control/Control.Infobar.js
+++ b/loleaflet/src/control/Control.Infobar.js
@@ -22,11 +22,7 @@ L.Control.Infobar = L.Control.extend({
return;
if (e.action.startsWith('http')) { // We have a
link
- if (window.ThisIsAMobileApp) {
-
window.postMobileMessage('HYPERLINK ' + e.action);
- } else {
- var win = window.open(e.action,
'_blank');
- }
+ var win = window.open(e.action,
'_blank');
win.focus();
}
};
diff --git a/loleaflet/src/control/Control.Menubar.js
b/loleaflet/src/control/Control.Menubar.js
index 6ea82050f..1a5cdc19d 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -1155,12 +1155,7 @@ L.Control.Menubar = L.Control.extend({
} else if (id === 'about') {
this._map.showLOAboutDialog();
} else if (id === 'report-an-issue') {
- var bugLink =
'https://bugs.documentfoundation.org/enter_bug.cgi?product=LibreOffice%20Online';
- if (window.ThisIsAMobileApp) {
- window.postMobileMessage('HYPERLINK ' +
bugLink);
- } else {
- window.open(bugLink, '_blank');
- }
+
window.open('https://bugs.documentfoundation.org/enter_bug.cgi?product=LibreOffice%20Online',
'_blank');
} else if (id === 'inserthyperlink') {
this._map.showHyperlinkDialog();
} else if (id === 'keyboard-shortcuts' || id === 'online-help')
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: android/lib
android/lib/build.gradle |2
android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java | 32
--
android/lib/src/main/res/layout/lolib_activity_main.xml | 19
+
android/lib/src/main/res/values/strings.xml |1
4 files changed, 50 insertions(+), 4 deletions(-)
New commits:
commit 1f04f155324989429eed3478825dbebd67fc3f75
Author: mert
AuthorDate: Wed Feb 12 19:39:50 2020 +0300
Commit: Jan Holesovsky
CommitDate: Fri Feb 14 18:19:14 2020 +0100
android: show progressbar at first start of the document
Copying the assets takes some time at first install
so showing progressbar is a good idea for user to wait
Edit: ConstraintLayout implementation added in build.gradle
Change-Id: Ia38259cb3ae1b25983a4067fce500f2700c2c79f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88548
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Jan Holesovsky
diff --git a/android/lib/build.gradle b/android/lib/build.gradle
index ea92be07f..480c4dcd7 100644
--- a/android/lib/build.gradle
+++ b/android/lib/build.gradle
@@ -63,6 +63,8 @@ dependencies {
implementation 'androidx.appcompat:appcompat:1.0.2'
implementation 'com.google.android.material:material:1.1.0-alpha04'
+implementation 'androidx.constraintlayout:constraintlayout:1.1.2'
+
}
task copyUnpackAssets(type: Copy) {
diff --git
a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
index 7033707e5..9af5eb267 100644
--- a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
+++ b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
@@ -22,6 +22,7 @@ import android.content.pm.PackageManager;
import android.content.res.AssetFileDescriptor;
import android.content.res.AssetManager;
import android.net.Uri;
+import android.os.AsyncTask;
import android.os.Build;
import android.os.Bundle;
import android.os.Environment;
@@ -42,6 +43,7 @@ import android.webkit.ValueCallback;
import android.webkit.WebChromeClient;
import android.webkit.WebSettings;
import android.webkit.WebView;
+import android.widget.ProgressBar;
import android.widget.TextView;
import android.widget.Toast;
@@ -110,6 +112,7 @@ public class LOActivity extends AppCompatActivity {
private Thread nativeMsgThread;
private Handler nativeHandler;
private Looper nativeLooper;
+private Bundle savedInstanceState;
/** In case the mobile-wizard is visible, we have to intercept the
Android's Back button. */
private boolean mMobileWizardVisible = false;
@@ -142,7 +145,6 @@ public class LOActivity extends AppCompatActivity {
String fromAssetPath, String
targetDir) {
try {
String[] files = assetManager.list(fromAssetPath);
-
boolean res = true;
for (String file : files) {
String[] dirOrFile = assetManager.list(fromAssetPath + "/" +
file);
@@ -255,12 +257,33 @@ public class LOActivity extends AppCompatActivity {
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
+this.savedInstanceState = savedInstanceState;
getWindow().addFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON);
sPrefs =
PreferenceManager.getDefaultSharedPreferences(getApplicationContext());
-updatePreferences();
-
setContentView(R.layout.lolib_activity_main);
+init();
+}
+
+private void init() {
+new AsyncTask() {
+@Override
+protected Void doInBackground(Void... voids) {
+updatePreferences();
+return null;
+}
+@Override
+protected void onPostExecute(Void aVoid) {
+initUI();
+}
+}.execute();
+}
+
+private void initUI() {
+TextView assetsTextView = findViewById(R.id.assetsTextView);
+ProgressBar assetsProgressbar = findViewById(R.id.assetsProgressbar);
+assetsProgressbar.setVisibility(View.GONE);
+assetsTextView.setVisibility(View.GONE);
isDocDebuggable = sPrefs.getBoolean(KEY_ENABLE_SHOW_DEBUG_INFO, false)
&& BuildConfig.DEBUG;
if (getIntent().getData() != null) {
@@ -482,7 +505,8 @@ public class LOActivity extends AppCompatActivity {
Log.i(TAG, "onResume..");
// check for config change
-updatePreferences();
+if (documentLoaded)
+updatePreferences();
}
@Override
diff --git a/android/lib/src/main/res/layout/lolib_activity_main.xml
b/android/lib/src/main/res/layout/lolib_activity_main.xml
index 2810a9af9..9d9524dc5 100644
--- a/android/lib/src/main/res/layout/lolib_activity_main.xml
+++
