[Libreoffice-bugs] [Bug 134763] Writer round behavior differs from Word in a table formula
https://bugs.documentfoundation.org/show_bug.cgi?id=134763 --- Comment #4 from himajin100...@gmail.com --- you can find "Number Format" toolbar-item, not "Number Format(Decimal), if you enable Table toolbar displayed around a status bar. Clicking this toolbar-item shows a dialog to specify Numberformat -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134763] Writer round behavior differs from Word in a table formula
https://bugs.documentfoundation.org/show_bug.cgi?id=134763 himajin100...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from himajin100...@gmail.com --- Reproduced probably the cause is not the calculation, but the format Table uses. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/init.cxx | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) New commits: commit 6f55a64f002d80a19201e2a9b0171725fb71a7fb Author: Tomaž Vajngerl AuthorDate: Sun Jul 26 21:58:33 2020 +0200 Commit: Tomaž Vajngerl CommitDate: Mon Jul 27 07:12:05 2020 +0200 allow to .uno:Save a PDF doc - divert to SaveAs to the doc. file To save PDF annotations, we need to allow a .uno:Save if the document was opened from a PDF file. When we get a .uno:Save command, we need to divert that to SaveAs into the same file as the current document was opened with. Change-Id: I0c511c4e5501de03ea8b0efb5aaf37cd09936e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99463 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index f757c825fb08..02dcab22ec7c 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -102,6 +102,8 @@ #include #endif #include +#include +#include #include #include #include @@ -715,6 +717,28 @@ std::string extractPrivateKey(const std::string & privateKey) return privateKey.substr(pos1, pos2); } +OUString lcl_getCurrentDocumentMimeType(LibLODocument_Impl* pDocument) +{ +OUString aMimeType; +SfxBaseModel* pBaseModel = dynamic_cast(pDocument->mxComponent.get()); +if (!pBaseModel) +return aMimeType; + +SfxObjectShell* pObjectShell = pBaseModel->GetObjectShell(); +if (!pObjectShell) +return aMimeType; + +SfxMedium* pMedium = pObjectShell->GetMedium(); +if (!pMedium) +return aMimeType; + +auto pFilter = pMedium->GetFilter(); +if (!pFilter) +return aMimeType; + +return pFilter->GetMimeType(); +} + // Gets an undo manager to enter and exit undo context. Needed by ToggleOrientation css::uno::Reference< css::document::XUndoManager > getUndoManager( const css::uno::Reference< css::frame::XFrame >& rxFrame ) { @@ -2430,6 +2454,9 @@ static int doc_saveAs(LibreOfficeKitDocument* pThis, const char* sUrl, const cha OUString sFormat = getUString(pFormat); OUString aURL(getAbsoluteURL(sUrl)); + +uno::Reference xStorable(pDocument->mxComponent, uno::UNO_QUERY_THROW); + if (aURL.isEmpty()) { SetLastExceptionMsg("Filename to save to was not provided."); @@ -2569,7 +2596,6 @@ static int doc_saveAs(LibreOfficeKitDocument* pThis, const char* sUrl, const cha aSaveMediaDescriptor[MediaDescriptor::PROP_INTERACTIONHANDLER()] <<= xInteraction; } -uno::Reference xStorable(pDocument->mxComponent, uno::UNO_QUERY_THROW); if (bTakeOwnership) xStorable->storeAsURL(aURL, aSaveMediaDescriptor.getAsConstPropertyValueList()); @@ -3731,6 +3757,30 @@ static void doc_postUnoCommand(LibreOfficeKitDocument* pThis, const char* pComma // handle potential interaction if (gImpl && aCommand == ".uno:Save") { +// Check if saving a PDF file +OUString aMimeType = lcl_getCurrentDocumentMimeType(pDocument); +if (aMimeType == "application/pdf") +{ +// If we have a PDF file (for saving annotations for example), we need +// to run save-as to the same file as the opened document. Plain save +// doesn't work as the PDF is not a "native" format. +uno::Reference xStorable(pDocument->mxComponent, uno::UNO_QUERY_THROW); +OUString aURL = xStorable->getLocation(); +OString aURLUtf8 = OUStringToOString(aURL, RTL_TEXTENCODING_UTF8); +bool bResult = doc_saveAs(pThis, aURLUtf8.getStr(), "pdf", nullptr); + +// Send the result of save +boost::property_tree::ptree aTree; +aTree.put("commandName", pCommand); +aTree.put("success", bResult); +std::stringstream aStream; +boost::property_tree::write_json(aStream, aTree); +OString aPayload = aStream.str().c_str(); + pDocument->mpCallbackFlushHandlers[nView]->queue(LOK_CALLBACK_UNO_COMMAND_RESULT, aPayload.getStr()); +return; +} + + rtl::Reference const pInteraction( new LOKInteractionHandler("save", gImpl, pDocument)); uno::Reference const xInteraction(pInteraction.get()); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 134763] Writer round behavior differs from Word in a table formula
https://bugs.documentfoundation.org/show_bug.cgi?id=134763 --- Comment #2 from himajin100...@gmail.com --- I haven't understood the algorithm yet(just for lazyness). https://opengrok.libreoffice.org/xref/core/sw/source/core/bastyp/calc.cxx?r=474a9171#920 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
FW: Re: I have wrote for a couple of hours something like 56 pages after that I have save it pressing the button Save many times and I the end I have discovered that my document had lost 50 + pages ,
Hi, Paul, or anybody else,I think, it would be reason, that we file a bug. Modify autosave range option setting for speed capability HDD vs SSD vs Cloud.I can't to do this, (file a bug) just check back, because I don't know, how could I put the link of these mails' archive.Thanks,Viktor PS Hi , Here I have found that other people are praising the Autosaving Option from Google Docs , The thing that I have emphasized in the previous emails as well as a priority , a must from my opinion ., IMHO . We can not compare A trillion dollar company like Google with 2 Billion users for G suite with a Team of Volunteers that are developing for free a product like Libre .But I think we should emulate the Best Features like Autosaving from Google Docs and others , from Successful and reliable software solutions like G Docs so on and Implement by Default AutoSAving features every Couple of Seconds IMHO .https://www.goskills.com/Microsoft-Office/Resources/Google-Docs-Microsoft-Word-comparison https://www.zdnet.com/article/google-g-suite-now-has-2-billion-users/#:~:text=Google's%20office%20productivity%20suite%2C%20G,the%20end%20of%20last%20year. Plus, Docs backs up your saved files to Google Drive instead of your local hard drive.So Google saves your work — and backs up your work — to give you extra protection should you spill coffee all over your laptop and wreck your hard drive.Our winner: Google is the automatic save hero you never thought your docs needed.Thanks for your work developing a good product .kind regards.adrian g On Thu, Jul 23, 2020 at 10:58 PM g adi wrote:Hi Italo , Paul , Hi guys ! I have just remember how I have said in the previous emails : Why do not made Autosaving Implicit By Default Very Frequently , By Default it is like 10 minutes , I have manual Choose 1 minute the minimum but I have Remember that Google Docs has the AutoSave like every 2 Seconds , Why you do not do the same ? Autosave every 1 -2 Seconds ? and by Default do not let new Libre Users choose them because can be too late and they will loose they words , work and the Libre File and the people will be very upset . This should be a Priority , it is a Major Issue and and Urgent One in IMHO , Google Docs is doing the same for example .Loosing your Writing is very frustrating and people could lose precious and very important documents , it was not my case , still I was upset but you got my idea . https://ask.libreoffice.org/en/question/33150/libreoffice-just-not-saving-properly-and-deleted-1000-words-of-my-dissertation/#:~:text=Check%20the%20Tools%20%7C%20Options%20%7C%20LibreOffice,document%20and%20save%20as%20docx. I don't know what the going on but I just saved my work to close it and reopen it because spellcheck wasn't working and I reopened it and it's saved 2 words? It did something similar last night but I thought I just hadn't saved it properly cos it only lost 200 words or so. 2. Same Why the Backup or Temporary File Salvation it is not working properly too ? As a second net save mechanism in the case like something Bad is Happening like in my case : saving as Docx , Black out , no more Electricity so on ?3. Microsoft Word , Google Docs they have better Recovery Systems I think , I think we can learn from them and we can implement ?4. I have give you the details requested , can you reproduce my case and my error ?Thanks .kind regards,adrian gOn Thu, Jul 23, 2020 at 4:39 PM g adi wrote:Hi !Thanks for making this software for free , for your work but yesterday I was very upset .I have open a new file save it .docx , like I have done for a file before , one more time , just so this was the second time that I have created and saved a file with Docx and not ODt because in the past couple of my friends after I have send them the Odt files they said that they could not open them on Laptop or Mobile and I need to tell them what to install so on so Yesterday I have said that Lets create a Docx File using Libre so that It will be compatible for my friends But It was a bad Idea to save it Docx instead of Odt . It cost me a couple of hours of work . I have wrote for a couple of hours something like 56 pages after that I have save it pressing the button Save many times and I the end I have discovered that my document had lost 50 + pages , they were pics for my anatomy Notes , all my pics were gone just a little Text had been save it .very frustrating to lose my work for couple of hours .I have tried the solution bellow with the Backup and Temporary files and no file I have found .I could not believe that this could happen for Libre Office a software with many years experience behind .I do not Understand why This Option It is still there Saving As Docx , Still Available if it is not Working properly ? Why not Beta ? Why not a big Sign that it is possible to loose your Work ? if It Is causing Losing Pages 98 % of my pages mayne , 50 + pages with pictures for
[Libreoffice-bugs] [Bug 134749] button background color changes to black in libreoffice calc
https://bugs.documentfoundation.org/show_bug.cgi?id=134749 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134747] sorting in calc can't be focused on letters alone
https://bugs.documentfoundation.org/show_bug.cgi?id=134747 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134763] Writer round behavior differs from Word in a table formula
https://bugs.documentfoundation.org/show_bug.cgi?id=134763 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121760] Can't delete wrong file in extensions (LO Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=121760 --- Comment #10 from QA Administrators --- Dear Rodion, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134743] Table of Contents - "Tab position relative to paragraph style format" stops working
https://bugs.documentfoundation.org/show_bug.cgi?id=134743 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130232] Crash in: mscx_uno.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=130232 --- Comment #3 from QA Administrators --- Dear John Roden, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130230] Writer create .pdf files with wrong link
https://bugs.documentfoundation.org/show_bug.cgi?id=130230 --- Comment #5 from QA Administrators --- Dear Daniel, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134633] Fails to show the preview of the shapes in browser -- Draw Drawing
https://bugs.documentfoundation.org/show_bug.cgi?id=134633 --- Comment #4 from compuclever_...@hotmail.com --- Created attachment 163587 --> https://bugs.documentfoundation.org/attachment.cgi?id=163587=edit Preview in web browser -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118148] [NEWHELP] Handle tags in the UI
https://bugs.documentfoundation.org/show_bug.cgi?id=118148 --- Comment #16 from Adolfo Jayme --- > What is left open is to find a way to add there translated strings into the > translation/weblate process. As long as this doesn’t exist, please do the migration to core slowly. It’s very painful to have a bunch of untranslated strings thrown at the translator teams at once, and it’s annoying to translate them since they are almost the same as the previous helpcontent2 ones but Weblate doesn’t prefill them. I beg you to talk to Cloph and find a solution! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125993] CHAPTER NUMBERING DIALOG: Give option to seperate different chapter levels with a dash
https://bugs.documentfoundation.org/show_bug.cgi?id=125993 --- Comment #7 from hoo...@gmail.com --- excuse me test the LibreOffice 6.3 test time 2020.07.27 Still have my problems "A.1" the "." is not i want to be "A-1" or "1-1-2" Change the "." Replace "any" with "." chinese taiwan in the APA is "1-1-2" but, writer is 1.1.2 Actual Results: i can't Change the "." Replace "any" with "." chinese taiwan in the APA is "1-1-2" but, writer is 1.1.2 It is recommended to make the writer more flexible,please -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 125993] CHAPTER NUMBERING DIALOG: Give option to seperate different chapter levels with a dash
https://bugs.documentfoundation.org/show_bug.cgi?id=125993 --- Comment #7 from hoo...@gmail.com --- excuse me test the LibreOffice 6.3 test time 2020.07.27 Still have my problems "A.1" the "." is not i want to be "A-1" or "1-1-2" Change the "." Replace "any" with "." chinese taiwan in the APA is "1-1-2" but, writer is 1.1.2 Actual Results: i can't Change the "." Replace "any" with "." chinese taiwan in the APA is "1-1-2" but, writer is 1.1.2 It is recommended to make the writer more flexible,please -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135154] FILEOPEN DOCX: Image only partly rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=135154 Aron Budea changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected Ever confirmed|0 |1 Version|7.0.0.1 rc |6.4.0.3 release CC||ba...@caesar.elte.hu, ||vmik...@collabora.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4600 Status|UNCONFIRMED |NEW --- Comment #4 from Aron Budea --- Confirmed using LO 7.1.0.0.alpha0+ (abea0d6647c7f1f7e76c73c26cb80e6a67dc5111) / Ubuntu. Bibisected to the following commit using repo bibisect-linux-64-6.4. Adding CC: to Miklos Vajna. https://cgit.freedesktop.org/libreoffice/core/commit/?id=acfb28d572201396bbe60e3824ccab28567d6a74 author Miklos Vajna 2019-09-24 10:06:49 +0200 committer Miklos Vajna 2019-09-24 10:56:28 +0200 tdf#124600 sw AddVerticalFrameOffsets: fix bad wrap of half-intersecting frame -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135144] Saving DOCX to ODT with hiding tracking changes trashes all images
https://bugs.documentfoundation.org/show_bug.cgi?id=135144 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||7776, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0707 Version|7.0.0.1 rc |6.4.0.3 release Keywords|bibisectRequest |bibisected, bisected, ||dataLoss CC||ba...@caesar.elte.hu, ||vmik...@collabora.com --- Comment #4 from Aron Budea --- Confirmed using LO 7.1.0.0.alpha0+ (abea0d6647c7f1f7e76c73c26cb80e6a67dc5111) / Ubuntu. Bibisected to the 6.3 backport of the following commit using repo bibisect-linux-64-6.3. Same commit as identified for bug 130707. Adding CC: to Miklos Vajna. https://cgit.freedesktop.org/libreoffice/core/commit/?id=28d67b792724a23015dec32fb0278b729f676736 author Miklos Vajna 2019-08-26 20:57:10 +0200 committer Miklos Vajna 2019-08-27 09:15:23 +0200 tdf#107776 sw ODF shape import: make is-textbox check more strict -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130707] FILEOPEN: Writer document "Read Error. Format error discovered in the file in sub-document content.xml at 2, 68950(row, col)."
https://bugs.documentfoundation.org/show_bug.cgi?id=130707 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5144 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130707] FILEOPEN: Writer document "Read Error. Format error discovered in the file in sub-document content.xml at 2, 68950(row, col)."
https://bugs.documentfoundation.org/show_bug.cgi?id=130707 Aron Budea changed: What|Removed |Added Hardware|Other |All CC||ba...@caesar.elte.hu OS|Windows (All) |All --- Comment #4 from Aron Budea --- Let's add the magic words. Adding CC: to Miklos Vajna. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135103] Decimal precision fail in addition
https://bugs.documentfoundation.org/show_bug.cgi?id=135103 --- Comment #7 from Javier --- (In reply to Michael Warner from comment #5) > (In reply to Javier from comment #4) > > So, a few points here. > > The first is that I would like to bring to your attention this page: > https://www.libreoffice.org/community/get-involved/ > > Which begins with this: > > Welcome! LibreOffice is developed by a friendly community, > > Statements like : > > > If your boss see this, probably he doubt about yours skills. > > Are something I might expect on twitter or youtube, but not really in line > with what I would expect from a "friendly community". > > Second is: > > > > The other problem, every conditional must be formated before each > > calculation, like > > > > =IF( ROUND( ( - ;2) = ROUND( > with -999.13>;2); "OK"; "FAIL" ) ); > > > > I was just talking about formatting for display. Proper rounding in > comparisons of floating points is a whole other topic, also worthy of > addressing, but not something I choose to argue about here. > > > That's a very heavy issue, a lot of time, memory, CPU resource, bugs, etc. > > Fair enough, and things that we as developers must worry about. But > irrelevant to users who don't know (or care) about the details of floating > point representation in computers and just want the spreadsheet to add up > numbers and show the result the way they learned it in elementary school. > > Third point is that you are the person who filed the original bug. I was > trying to help by brainstorming a possible solution to what I thought was > the problem you were reporting. But your response is confusing to me because > it seems like you are arguing against fixing the bug you filed. That doesn't > make sense, so I think there is some context or detail to this whole > situation that I am not aware of or not picking up on here. Thanks a LOT for your time. 3 simples fact about me: -English is not my language; sorry if I'm not clear. -I understand about "friendly community". I'm part of Debian community for more than 15 years (I'm a 55 old grandpa, that learned programming with cards an holes). -The complexity of actual programs are so far than my skills. I just only wanted to mark something. I understand floating point more than you believe, I came from the time that memory and CPU cycles was VERY expensive; everything were made with logarithms. I was using the spreadsheet for simple calculation, no more far than a single precision point number, only 2 decimal. For this reason, it was odd for me. For me, the bug is closed. In my country, we said "known problem, is not problem". Thanks again. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Need help for unit tests
Hi all, I need again help in unit tests. I'm working on https://gerrit.libreoffice.org/c/core/+/99464. That is continuation for https://bugs.documentfoundation.org/show_bug.cgi?id=128345 FILESAVE: PPTX: transparency gradient on solid fill is not considered in export This part is about transparency in charts. I have (until now) three files to be examined, each with one problem. I have used assertXPath on the saved pptx file. I have expected to get /ppt/charts/chart1.xml in all three cases, but I get chart1.xml for the first file, chart2.xml for the second and chart3.xml for the third file. You see it in SdOOXMLExportTest1::testTdf128345Chart_CS_TG() in sd/qa/unit/export-tests-ooxml1.cxx#1290. Why is it not chart1.xml in all cases? Do I miss something? Are these numbers stable? How can I force to get chart1.xml in the export to pptx? I have used assertXPath, because I do not know, how to access a chart and its parts from the active document in a unit test. Any hint, how to directly get the start and end color of a transparency gradient of a data point, for example? I have seen in https://opengrok.libreoffice.org/xref/core/chart2/qa/extras/chart2import.cxx 2541 Reference xDataPointLabel1(getShapeByName(xShapes, 2542 "CID/MultiClick/CID/D=0:CS=0:CT=0:Series=0:DataLabels=:DataLabel=0"), UNO_SET_THROW); How is the string build, what does it mean? And a general review of the patch would be nice too. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 88105] STATUSBAR: Disabling page number counting in web layout
https://bugs.documentfoundation.org/show_bug.cgi?id=88105 --- Comment #7 from Mike Kaganski --- Just a note. Our "Web view" has pages. So it may show you "page 1 of 2" or anything like that. Just our Web view "page" is 10 meter long - see BROWSE_HEIGHT in sw/source/core/inc/frmtool.hxx. We fake the "infinite" space with this trick - unfortunately. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130699] Assert on undo/redo table captions SwIndexReg::~SwIndexReg(
https://bugs.documentfoundation.org/show_bug.cgi?id=130699 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8073 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128073] CRASH: in SwIndex::SwIndex(SwIndexReg * const, long)
https://bugs.documentfoundation.org/show_bug.cgi?id=128073 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0699 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132810] Gallery: Crash swlo!SwFEShell::SelectObj+0x46a when inserting a new shape with cursor still in textbox SwFrame::AppendDrawObj(SwAnchoredObject &)
https://bugs.documentfoundation.org/show_bug.cgi?id=132810 Telesto changed: What|Removed |Added Summary|Gallery: Crash |Gallery: Crash |swlo!SwFEShell::SelectObj+0 |swlo!SwFEShell::SelectObj+0 |x46a when inserting a new |x46a when inserting a new |shape with cursor still in |shape with cursor still in |textbox |textbox ||SwFrame::AppendDrawObj(SwAn ||choredObject &) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38093] Add an Outline View layout and editing mode to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=38093 --- Comment #143 from Bernhard Rohrer --- (In reply to Mike Kaganski from comment #142) > I still believe that making the outline mode in normal view is a wrong thing > to do. Having things like headers/footers with possible page numbers and/or > chapter names would interfere with the mode; having the pages indicator in > to status line ... It would result in much confusion. The page numbering > problem was already raised in comment 51 and comment 52. > > E.g. Word shows its outline in something like our "web" view. I fully agree -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130699] Assert on undo/redo table captions SwIndexReg::~SwIndexReg(
https://bugs.documentfoundation.org/show_bug.cgi?id=130699 Telesto changed: What|Removed |Added Summary|Assert on undo/redo table |Assert on undo/redo table |captions|captions ||SwIndexReg::~SwIndexReg( -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-6-4' - distro-configs/NISZ_32.conf distro-configs/NISZ_64.conf
distro-configs/NISZ_32.conf |3 +-- distro-configs/NISZ_64.conf |3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) New commits: commit 0f4860e17c048f6f04e0c02b92fe817bdf817c11 Author: Gabor Kelemen AuthorDate: Sun Jul 26 21:36:06 2020 +0200 Commit: Gabor Kelemen CommitDate: Sun Jul 26 23:47:40 2020 +0200 Weekly version number bump: N3 Change-Id: I94e67cfce3c312a0bd1ab0269c8b5866876cd9a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99462 Tested-by: Gabor Kelemen Reviewed-by: Gabor Kelemen diff --git a/distro-configs/NISZ_32.conf b/distro-configs/NISZ_32.conf index 688271d1b83c..ca0add850497 100644 --- a/distro-configs/NISZ_32.conf +++ b/distro-configs/NISZ_32.conf @@ -20,7 +20,7 @@ --without-helppack-integration # NISZ build ---with-vendor=NISZ Zrt. (Kiad�s sz�ma: N2) +--with-vendor=NISZ Zrt. (Kiad�s sz�ma: N3) --with-lang=en-US hu de fr it ru hr sk pl ro --with-visual-studio=2017 @@ -30,4 +30,3 @@ #--with-parallelism=4 #--with-ucrt-dir=$core/../../packages/WindowsUCRT #--with-jdk-home=$core/../../../ojdk-32 - diff --git a/distro-configs/NISZ_64.conf b/distro-configs/NISZ_64.conf index 89806c274e1d..b833acca1146 100644 --- a/distro-configs/NISZ_64.conf +++ b/distro-configs/NISZ_64.conf @@ -21,7 +21,7 @@ --enable-64-bit # NISZ build ---with-vendor=NISZ Zrt. (Kiad�s sz�ma: N2) +--with-vendor=NISZ Zrt. (Kiad�s sz�ma: N3) --with-lang=en-US hu de fr it ru hr sk pl ro --with-visual-studio=2017 @@ -31,4 +31,3 @@ #--with-parallelism=4 #--with-ucrt-dir=$core/../../packages/WindowsUCRT #--with-jdk-home=$core/../../../ojdk-32 - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119241] Crash in: CompareSwOutlineNodes::operator()(SwNode * const &, SwNode * const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=119241 --- Comment #20 from Telesto --- *** Bug 134780 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134780] Crash in: CompareSwOutlineNodes::operator()(SwNode * const &, SwNode * const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=134780 --- Comment #7 from Telesto --- *** This bug has been marked as a duplicate of bug 119241 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134626] assertion in SwTextNode::~SwTextNode()
https://bugs.documentfoundation.org/show_bug.cgi?id=134626 Telesto changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #14 from Telesto --- *** This bug has been marked as a duplicate of bug 119241 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Bug 105537 depends on bug 134626, which changed state. Bug 134626 Summary: assertion in SwTextNode::~SwTextNode() https://bugs.documentfoundation.org/show_bug.cgi?id=134626 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119241] Crash in: CompareSwOutlineNodes::operator()(SwNode * const &, SwNode * const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=119241 --- Comment #19 from Telesto --- *** Bug 134626 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 Telesto changed: What|Removed |Added Blocks||105537 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105537 [Bug 105537] [META] Assertion failed crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Telesto changed: What|Removed |Added Depends on||135167 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135167 [Bug 135167] BigPtrArray::Index2Block undo crash -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Bug 105948 depends on bug 131676, which changed state. Bug 131676 Summary: Crash Undoing a large paste "BigPtrArray::Index2Block https://bugs.documentfoundation.org/show_bug.cgi?id=131676 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 Telesto changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132157] [META] BigPtrArray::Index2Block undo crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=132157 Bug 132157 depends on bug 131676, which changed state. Bug 131676 Summary: Crash Undoing a large paste "BigPtrArray::Index2Block https://bugs.documentfoundation.org/show_bug.cgi?id=131676 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 --- Comment #6 from Telesto --- *** Bug 131676 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131676] Crash Undoing a large paste "BigPtrArray::Index2Block
https://bugs.documentfoundation.org/show_bug.cgi?id=131676 Telesto changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Telesto --- *** This bug has been marked as a duplicate of bug 135167 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131676] Crash Undoing a large paste "BigPtrArray::Index2Block
https://bugs.documentfoundation.org/show_bug.cgi?id=131676 Telesto changed: What|Removed |Added Keywords|wantBacktrace | CC|serval2...@yahoo.fr | --- Comment #3 from Telesto --- Nevermind.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131676] Crash Undoing a large paste "BigPtrArray::Index2Block
https://bugs.documentfoundation.org/show_bug.cgi?id=131676 Telesto changed: What|Removed |Added CC||serval2...@yahoo.fr Keywords||wantBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sd/source svx/source
sd/source/ui/func/futext.cxx |3 --- svx/source/svdraw/svdedxv.cxx |7 +++ 2 files changed, 7 insertions(+), 3 deletions(-) New commits: commit d2c960e731c3689a510425a778b2e51e6180ab05 Author: Mike Kaganski AuthorDate: Fri Jul 3 16:25:03 2020 +0300 Commit: Mike Kaganski CommitDate: Sun Jul 26 23:37:20 2020 +0200 Re-implement 481e686a66e550229ec0b600a785452f0d753342 Marking documents modified simply on entry to an edit box created a problem, when using search in a read-only Online session made the document modified, and then auto-save failed, displaying a warning: Document cannot be saved. Check your permissions or contact the storage server administrator. The original problem, that 481e686a66e550229ec0b600a785452f0d753342 fixed, was that entering a box in Impress in browser, typing, then pressing Save without exiting the box did not save the edits. Yet, the same sequence works outside of Online. In that case, the doc is marked modified in SdrObjEditView::KeyInput, which obviously is not called from Online, where SdrObjEditView::Command is called instead with CommandEventId::ExtTextInput. So just make sure that we mark the document modified also in this case, making sure that only the actual edits set the "modified" flag. This reverts 481e686a66e550229ec0b600a785452f0d753342. Change-Id: Ib05bc0492616a306dd328bcb8f2e1c9d7e7aa191 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97870 Tested-by: Mike Kaganski Reviewed-by: Mike Kaganski Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98137 Tested-by: Jenkins CollaboraOffice diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx index 6fca64946b08..deb140146511 100644 --- a/sd/source/ui/func/futext.cxx +++ b/sd/source/ui/func/futext.cxx @@ -70,7 +70,6 @@ #include #include #include -#include using namespace ::com::sun::star; using namespace ::com::sun::star::uno; @@ -204,8 +203,6 @@ void FuText::DoExecute( SfxRequest& ) SdrViewEvent aVEvt; mpView->PickAnything(aMEvt, SdrMouseEventKind::BUTTONDOWN, aVEvt); mpView->MarkObj(aVEvt.pRootObj, pPV); -if (comphelper::LibreOfficeKit::isActive() && mpViewShell && mpViewShell->GetDocSh()) -mpViewShell->GetDocSh()->SetModified(); mxTextObj.reset( dynamic_cast< SdrTextObj* >( aVEvt.pObj ) ); } diff --git a/svx/source/svdraw/svdedxv.cxx b/svx/source/svdraw/svdedxv.cxx index c38ebfa75505..70eddab0210f 100644 --- a/svx/source/svdraw/svdedxv.cxx +++ b/svx/source/svdraw/svdedxv.cxx @@ -1911,6 +1911,13 @@ bool SdrObjEditView::Command(const CommandEvent& rCEvt, vcl::Window* pWin) else { pTextEditOutlinerView->Command(rCEvt); +if (mpModel && comphelper::LibreOfficeKit::isActive()) +{ +// It could execute CommandEventId::ExtTextInput, while SdrObjEditView::KeyInput +// isn't called +if (pTextEditOutliner && pTextEditOutliner->IsModified()) +mpModel->SetChanged(); +} return true; } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 --- Comment #5 from Telesto --- @Julien Could you add BT to all the see also's? So we finally know if there a dupes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 Telesto changed: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=13 |tion.org/show_bug.cgi?id=13 |4101|3914, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||3911, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||2660 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133914] Crash swlo!BigPtrArray::Index2Block
https://bugs.documentfoundation.org/show_bug.cgi?id=133914 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5167 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134101] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=134101 Telesto changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=13 | |5167| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132660] Crash in: BigPtrArray::Index2Block(unsigned __int64)
https://bugs.documentfoundation.org/show_bug.cgi?id=132660 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5167 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133911] Crash swlo!BigPtrArray::Index2Block+0xc8swlo!BigPtrArray::Index2Block+0xc8:
https://bugs.documentfoundation.org/show_bug.cgi?id=133911 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5167 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 Telesto changed: What|Removed |Added Blocks||132157 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=132157 [Bug 132157] [META] BigPtrArray::Index2Block undo crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132157] [META] BigPtrArray::Index2Block undo crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=132157 Telesto changed: What|Removed |Added Depends on||135167 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135167 [Bug 135167] BigPtrArray::Index2Block undo crash -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Changes to 'refs/tags/libreoffice-7.0.0.2'
Tag 'libreoffice-7.0.0.2' created by Andras Timar at 2020-07-26 21:19 + libreoffice-7.0.0.2 Changes since libreoffice-7.0.0.1-8: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - kit/ChildSession.cpp kit/Kit.cpp net/Socket.hpp net/WebSocketHandler.hpp
kit/ChildSession.cpp |9 + kit/Kit.cpp | 10 ++ net/Socket.hpp | 41 ++--- net/WebSocketHandler.hpp | 16 4 files changed, 73 insertions(+), 3 deletions(-) New commits: commit 39a5f4ac30268ddbf012f7f4816edda3a8ddb6b4 Author: Gabriel Masei AuthorDate: Fri Jul 10 15:22:35 2020 +0300 Commit: Andras Timar CommitDate: Sun Jul 26 23:18:24 2020 +0200 kit: disable parallel handling of messages while processing load and save The map._activate, among other actions, is sending indirectly some messages to the server like clientzoom and clientvisiblearea. If these messages are send before the document finishes processing the load message then there is a chance that a nodocloaded error will be thrown because there is a chance that the messages will be processed in parallel with load. This happens constantly for xlsx files. This is generated by the Unipoll mechanism which, in case of xlsx files, triggers a parallel processing. To avoid the above scenario a mechanism of disabling parallel processing of messages in kit was implemented and is used for load and save messages, for now. Change-Id: I4c83e72e600f92d0bb4f1f18cebe694e326256d0 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98519 Tested-by: Jenkins Tested-by: Michael Meeks Reviewed-by: Michael Meeks Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99275 Tested-by: Jenkins CollaboraOffice Reviewed-by: Andras Timar diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp index b0aa69701..71440c290 100644 --- a/kit/ChildSession.cpp +++ b/kit/ChildSession.cpp @@ -212,6 +212,8 @@ bool ChildSession::_handleInput(const char *buffer, int length) return false; } +// Disable processing of other messages while loading document +InputProcessingManager processInput(getProtocol(), false); _isDocLoaded = loadDocument(buffer, length, tokens); LOG_TRC("isDocLoaded state after loadDocument: " << _isDocLoaded << '.'); @@ -379,6 +381,13 @@ bool ChildSession::_handleInput(const char *buffer, int length) newTokens.push_back(firstLine.substr(4)); // Copy the remaining part. return unoCommand(buffer, length, newTokens); } +else if (tokens[1].find(".uno:Save") != std::string::npos) +{ +// Disable processing of other messages while saving document +InputProcessingManager processInput(getProtocol(), false); +return unoCommand(buffer, length, tokens); +} + return unoCommand(buffer, length, tokens); } else if (tokens.equals(0, "selecttext")) diff --git a/kit/Kit.cpp b/kit/Kit.cpp index 3e4944740..4d20d27b4 100644 --- a/kit/Kit.cpp +++ b/kit/Kit.cpp @@ -2356,6 +2356,16 @@ protected: } } +virtual void enableProcessInput(bool enable = true) override +{ +WebSocketHandler::enableProcessInput(enable); +// Wake up poll to process data from socket input buffer +if (enable) +{ +_ksPoll.wakeup(); +} +} + void onDisconnect() override { #if !MOBILEAPP diff --git a/net/Socket.hpp b/net/Socket.hpp index 55cfe05bb..399d6b408 100644 --- a/net/Socket.hpp +++ b/net/Socket.hpp @@ -370,6 +370,10 @@ public: /// Will be called exactly once. virtual void onConnect(const std::shared_ptr& socket) = 0; +/// Enable/disable processing of incoming data at socket level. +virtual void enableProcessInput(bool /*enable*/){}; +virtual bool processInputEnabled(){ return true; }; + /// Called after successful socket reads. virtual void handleIncomingMessage(SocketDisposition ) = 0; @@ -469,6 +473,32 @@ public: virtual void dumpState(std::ostream& os) = 0; }; +class InputProcessingManager +{ +public: +InputProcessingManager(const std::shared_ptr , bool inputProcess) +: _protocol(protocol) +{ +if (_protocol) +{ +// Save previous state to be restored in destructor +_prevInputProcess = _protocol->processInputEnabled(); +protocol->enableProcessInput(inputProcess); +} +} + +~InputProcessingManager() +{ +// Restore previous state +if (_protocol) +_protocol->enableProcessInput(_prevInputProcess); +} + +private: +std::shared_ptr _protocol; +bool _prevInputProcess; +}; + /// Handles non-blocking socket event polling. /// Only polls on N-Sockets and invokes callback and /// doesn't manage buffers or client data. @@ -782,7 +812,8 @@ public: _sentHTTPContinue(false), _shutdownSignalled(false), _incomingFD(-1), -_readType(readType) +_readType(readType), +_inputProcessingEnabled(true) {
[Libreoffice-bugs] [Bug 135172] New: condition icon set desn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=135172 Bug ID: 135172 Summary: condition icon set desn't work Product: LibreOffice Version: 6.4.5.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nedj...@gmail.com Description: condition icon set desn't work in calc 6.4.5.2 in v7 it's work Actual Results: nothing Expected Results: nothing Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135162] PDF Export - WRITER/CALC - Push Button - WEB link containing German umlaut not working
https://bugs.documentfoundation.org/show_bug.cgi?id=135162 --- Comment #6 from himajin100...@gmail.com --- >pdf 1.7 says I meant 12.6.4.7 URI Actions in PDF 1.7 specification -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135162] PDF Export - WRITER/CALC - Push Button - WEB link containing German umlaut not working
https://bugs.documentfoundation.org/show_bug.cgi?id=135162 himajin100...@gmail.com changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #5 from himajin100...@gmail.com --- confirmed https://opengrok.libreoffice.org/xref/core/vcl/source/gdi/pdfwriter_impl.cxx?r=6294ecd7#4417 pdf 1.7 says the URI has to be US-ASII https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf -- https://opengrok.libreoffice.org/xref/core/vcl/README?r=a0fdbc49#189 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38093] Add an Outline View layout and editing mode to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=38093 --- Comment #142 from Mike Kaganski --- I still believe that making the outline mode in normal view is a wrong thing to do. Having things like headers/footers with possible page numbers and/or chapter names would interfere with the mode; having the pages indicator in to status line ... It would result in much confusion. The page numbering problem was already raised in comment 51 and comment 52. E.g. Word shows its outline in something like our "web" view. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 Julien Nabet changed: What|Removed |Added Keywords|wantBacktrace |haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 --- Comment #4 from Julien Nabet --- Created attachment 163586 --> https://bugs.documentfoundation.org/attachment.cgi?id=163586=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I got an assertion. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135131] Bangalore Escorts
https://bugs.documentfoundation.org/show_bug.cgi?id=135131 Timur changed: What|Removed |Added Version|2.1.3 |unspecified Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED Component|General |deletionRequest Product|Impress Remote |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135154] FILEOPEN DOCX: Image only partly rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=135154 --- Comment #3 from Timur --- Please correct all similar bugs from critical to normal,see flowchart. I dislike that you open many similar bugs without putting to See Also. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-6-4' - sw/qa sw/source
sw/qa/extras/ooxmlexport/data/tdf133924.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport6.cxx| 12 +++- sw/source/filter/ww8/docxattributeoutput.cxx | 11 --- 3 files changed, 15 insertions(+), 8 deletions(-) New commits: commit e0b9e1bd5f96c377375f4c8bb5a35d169071db43 Author: Tibor Nagy AuthorDate: Sun Jun 14 16:23:54 2020 +0200 Commit: Gabor Kelemen CommitDate: Sun Jul 26 22:17:33 2020 +0200 tdf#133924 DOCX export: fix text wraps around frame Co-authored-by: Attila Bakos (NISZ) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96290 Tested-by: László Németh Reviewed-by: László Németh (cherry picked from commit 9bbc60c0d5e60eacecd624f343aecc94e4219c84) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96699 Tested-by: Jenkins Reviewed-by: Xisco Fauli (cherry picked from commit d4dbf1cc87ae21567acc96a409974f1d159d550f) Change-Id: I08f0c8a8f4f554178548ca5fc8d072998a379b32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99403 Tested-by: Gabor Kelemen Reviewed-by: Gabor Kelemen diff --git a/sw/qa/extras/ooxmlexport/data/tdf133924.docx b/sw/qa/extras/ooxmlexport/data/tdf133924.docx new file mode 100644 index ..3bdbe8d6f1e0 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf133924.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx index 9b96cd04893b..bcc9fed18e1c 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx @@ -1019,7 +1019,17 @@ DECLARE_OOXMLEXPORT_TEST(testTdf133457, "tdf133457.docx") if (!pXmlDocument) return; -assertXPath(pXmlDocument, "/w:document/w:body/w:p[4]/w:pPr/w:framePr","vAnchor","text"); +assertXPath(pXmlDocument, "/w:document/w:body/w:p[4]/w:pPr/w:framePr", "vAnchor", "text"); +} + +DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf133924, "tdf133924.docx") +{ +xmlDocPtr pXmlDocument = parseExport("word/document.xml"); +if (!pXmlDocument) +return; + +assertXPath(pXmlDocument, "/w:document/w:body/w:p[2]/w:pPr/w:framePr", "wrap", "around"); +assertXPath(pXmlDocument, "/w:document/w:body/w:p[3]/w:pPr/w:framePr", "wrap", "notBeside"); } CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 9b63aefddc15..0d8534386cf7 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -587,17 +587,14 @@ void DocxAttributeOutput::PopulateFrameProperties(const SwFrameFormat* pFrameFor switch (pFrameFormat->GetSurround().GetValue()) { case css::text::WrapTextMode_NONE: -attrList->add( FSNS( XML_w, XML_wrap), "none"); -break; -case css::text::WrapTextMode_THROUGH: -attrList->add( FSNS( XML_w, XML_wrap), "through"); -break; -case css::text::WrapTextMode_PARALLEL: attrList->add( FSNS( XML_w, XML_wrap), "notBeside"); break; case css::text::WrapTextMode_DYNAMIC: +attrList->add(FSNS(XML_w, XML_wrap), "auto"); +break; +case css::text::WrapTextMode_PARALLEL: default: -attrList->add( FSNS( XML_w, XML_wrap), "auto"); +attrList->add(FSNS(XML_w, XML_wrap), "around"); break; } attrList->add( FSNS( XML_w, XML_vAnchor), relativeFromV ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135154] FILEOPEN DOCX: Image only partly rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=135154 Timur changed: What|Removed |Added Severity|critical|normal -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basegfx/source
basegfx/source/color/bcolormodifier.cxx | 27 --- 1 file changed, 27 deletions(-) New commits: commit d7894ddca9d5f56e86f9b488c97e3268637b017e Author: Arnaud Versini AuthorDate: Sun Jul 26 18:10:29 2020 +0200 Commit: Noel Grandin CommitDate: Sun Jul 26 22:16:13 2020 +0200 basegfx: remove completly useless namespace opening and closing Change-Id: I6959e9eabd6623435cc534c55869a844b0f207d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99459 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/basegfx/source/color/bcolormodifier.cxx b/basegfx/source/color/bcolormodifier.cxx index e2a2567288c6..c943658f05eb 100644 --- a/basegfx/source/color/bcolormodifier.cxx +++ b/basegfx/source/color/bcolormodifier.cxx @@ -29,10 +29,7 @@ namespace basegfx BColorModifier::~BColorModifier() { } -} // end of namespace basegfx -namespace basegfx -{ BColorModifier_gray::~BColorModifier_gray() { } @@ -48,10 +45,7 @@ namespace basegfx return ::basegfx::BColor(fLuminance, fLuminance, fLuminance); } -} // end of namespace basegfx -namespace basegfx -{ BColorModifier_invert::~BColorModifier_invert() { } @@ -65,10 +59,7 @@ namespace basegfx { return ::basegfx::BColor(1.0 - aSourceColor.getRed(), 1.0 - aSourceColor.getGreen(), 1.0 - aSourceColor.getBlue()); } -} // end of namespace basegfx -namespace basegfx -{ BColorModifier_luminance_to_alpha::~BColorModifier_luminance_to_alpha() { } @@ -84,10 +75,7 @@ namespace basegfx return ::basegfx::BColor(fAlpha, fAlpha, fAlpha); } -} // end of namespace basegfx -namespace basegfx -{ BColorModifier_replace::~BColorModifier_replace() { } @@ -108,10 +96,7 @@ namespace basegfx { return maBColor; } -} // end of namespace basegfx -namespace basegfx -{ BColorModifier_interpolate::~BColorModifier_interpolate() { } @@ -132,10 +117,7 @@ namespace basegfx { return interpolate(maBColor, aSourceColor, mfValue); } -} // end of namespace basegfx -namespace basegfx -{ BColorModifier_black_and_white::~BColorModifier_black_and_white() { } @@ -165,10 +147,7 @@ namespace basegfx return ::basegfx::BColor(1.0, 1.0, 1.0); } } -} // end of namespace basegfx -namespace basegfx -{ BColorModifier_gamma::BColorModifier_gamma(double fValue) : BColorModifier(), mfValue(fValue), @@ -215,10 +194,7 @@ namespace basegfx return aSourceColor; } } -} // end of namespace basegfx -namespace basegfx -{ BColorModifier_RGBLuminanceContrast::BColorModifier_RGBLuminanceContrast(double fRed, double fGreen, double fBlue, double fLuminance, double fContrast) : BColorModifier(), mfRed(std::clamp(fRed, -1.0, 1.0)), @@ -296,10 +272,7 @@ namespace basegfx return aSourceColor; } } -} // end of namespace basegfx -namespace basegfx -{ ::basegfx::BColor BColorModifierStack::getModifiedColor(const ::basegfx::BColor& rSource) const { if(maBColorModifiers.empty()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: fpicker/Library_fps.mk fpicker/source
fpicker/Library_fps.mk |1 fpicker/source/win32/FPServiceInfo.hxx | 37 -- fpicker/source/win32/FPentry.cxx| 97 fpicker/source/win32/VistaFilePicker.cxx| 39 ++- fpicker/source/win32/VistaFilePicker.hxx|9 -- fpicker/source/win32/fps.component |8 +- fpicker/source/win32/workbench/Test_fps.cxx |2 7 files changed, 29 insertions(+), 164 deletions(-) New commits: commit 946e742aa63a2559721c761cea5c80286fbffa6b Author: Noel Grandin AuthorDate: Sun Jul 26 20:54:22 2020 +0200 Commit: Noel Grandin CommitDate: Sun Jul 26 22:15:12 2020 +0200 fpicker/win32: create instances with uno constructors See tdf#74608 for motivation. Change-Id: Ic7d6c94e8709184fc8f195bd019402e361e9b810 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99461 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/fpicker/Library_fps.mk b/fpicker/Library_fps.mk index 31dd47e88b30..e41a8a40a081 100644 --- a/fpicker/Library_fps.mk +++ b/fpicker/Library_fps.mk @@ -56,7 +56,6 @@ endif $(eval $(call gb_Library_add_exception_objects,fps,\ fpicker/source/win32/asyncrequests \ fpicker/source/win32/FilterContainer \ - fpicker/source/win32/FPentry \ fpicker/source/win32/VistaFilePicker \ fpicker/source/win32/VistaFilePickerEventHandler \ fpicker/source/win32/VistaFilePickerImpl \ diff --git a/fpicker/source/win32/FPServiceInfo.hxx b/fpicker/source/win32/FPServiceInfo.hxx deleted file mode 100644 index edc350c1a9cc.. --- a/fpicker/source/win32/FPServiceInfo.hxx +++ /dev/null @@ -1,37 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -#ifndef INCLUDED_FPICKER_SOURCE_WIN32_FILEPICKER_FPSERVICEINFO_HXX -#define INCLUDED_FPICKER_SOURCE_WIN32_FILEPICKER_FPSERVICEINFO_HXX - -// the service names -#define FILE_PICKER_SERVICE_NAME "com.sun.star.ui.dialogs.SystemFilePicker" - -// the implementation names -#define FILE_PICKER_IMPL_NAME "com.sun.star.ui.dialogs.Win32FilePicker" - -// the service names -#define FOLDER_PICKER_SERVICE_NAME "com.sun.star.ui.dialogs.SystemFolderPicker" - -// the implementation names -#define FOLDER_PICKER_IMPL_NAME "com.sun.star.ui.dialogs.Win32FolderPicker" - -#endif - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/fpicker/source/win32/FPentry.cxx b/fpicker/source/win32/FPentry.cxx deleted file mode 100644 index a4e48f8865e5.. --- a/fpicker/source/win32/FPentry.cxx +++ /dev/null @@ -1,97 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -#include -#include -#include -#include "FPServiceInfo.hxx" - -#include "VistaFilePicker.hxx" -#include "WinImplHelper.hxx" -#include - -using namespace ::com::sun::star; -using namespace ::com::sun::star::uno; -using namespace ::com::sun::star::container; -using namespace ::com::sun::star::lang; -using namespace ::com::sun::star::registry; -using namespace ::cppu; -using ::com::sun::star::ui::dialogs::XFilePicker2; -using ::com::sun::star::ui::dialogs::XFolderPicker2; - -static Reference< XInterface > createInstance( -const Reference< XMultiServiceFactory >& rServiceManager ) -{ -return Reference( -
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - 3 commits - common/Session.hpp loleaflet/Makefile.am loleaflet/po loleaflet/src wsd/ClientSession.cpp wsd/ClientSession.hpp wsd/Doc
common/Session.hpp |2 - loleaflet/Makefile.am |1 loleaflet/po/templates/loleaflet-ui.pot | 14 +++ loleaflet/src/control/Permission.js | 63 +++- loleaflet/src/core/Socket.js|4 ++ wsd/ClientSession.cpp | 39 +-- wsd/ClientSession.hpp | 10 - wsd/DocumentBroker.cpp | 15 +++ wsd/DocumentBroker.hpp |3 + wsd/Storage.cpp |4 ++ wsd/Storage.hpp |2 + wsd/TestStubs.cpp |2 - 12 files changed, 143 insertions(+), 16 deletions(-) New commits: commit 2ee2c1697529e4f3e5349ecc387ab72d271d62f7 Author: Mike Kaganski AuthorDate: Tue Jul 14 22:19:14 2020 +0300 Commit: Mike Kaganski CommitDate: Sun Jul 26 22:13:49 2020 +0200 Allow user to try to lock the document for edit Use mobile-edit-button for that is permitted. Change-Id: I4d4c3f21d574abae033bacc69def96aaf6b51567 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98786 Tested-by: Jenkins CollaboraOffice Tested-by: Jenkins Reviewed-by: Mike Kaganski Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99322 diff --git a/loleaflet/po/templates/loleaflet-ui.pot b/loleaflet/po/templates/loleaflet-ui.pot index 2b770af3a..24a8c9c37 100644 --- a/loleaflet/po/templates/loleaflet-ui.pot +++ b/loleaflet/po/templates/loleaflet-ui.pot @@ -819,16 +819,20 @@ msgstr "" msgid "Current" msgstr "" -#: src/control/Permission.js:42 +#: src/control/Permission.js:45 msgid "The document could not be locked, and is opened in read-only mode." msgstr "" -#: src/control/Permission.js:44 +#: src/control/Permission.js:47 src/control/Permission.js:65 msgid "" "\n" "Server returned this reason: \"" msgstr "" +#: src/control/Permission.js:63 +msgid "The document could not be locked." +msgstr "" + #: src/control/Ruler.js:368 msgid "Left Margin" msgstr "" diff --git a/loleaflet/src/control/Permission.js b/loleaflet/src/control/Permission.js index 68bc731ea..b5a19439c 100644 --- a/loleaflet/src/control/Permission.js +++ b/loleaflet/src/control/Permission.js @@ -13,24 +13,22 @@ L.Map.include({ var that = this; button.on('click', function () { - button.hide(); - that._enterEditMode('edit'); - that.fire('editorgotfocus'); - // In the iOS/android app, just clicking the mobile-edit-button is - // not reason enough to pop up the on-screen keyboard. - if (!(window.ThisIsTheiOSApp || window.ThisIsTheAndroidApp)) - that.focus(); + that._switchToEditMode(); }); // temporarily, before the user touches the floating action button this._enterReadOnlyMode('readonly'); } + else if (this.options.canTryLock) { + // This is a success response to an attempt to lock using mobile-edit-button + this._switchToEditMode(); + } else { this._enterEditMode(perm); } } else if (perm === 'view' || perm === 'readonly') { - if (window.mode.isMobile() || window.mode.isTablet()) { + if (!this.options.canTryLock && (window.mode.isMobile() || window.mode.isTablet())) { $('#mobile-edit-button').hide(); } @@ -39,13 +37,50 @@ L.Map.include({ }, onLockFailed: function(reason) { - var alertMsg = _('The document could not be locked, and is opened in read-only mode.'); - if (reason) { - alertMsg += _('\nServer returned this reason: "') + reason + '"'; + if (this.options.canTryLock === undefined) { + // This is the initial notification. This status is not permanent. + // Allow to try to lock the file for edit again. + this.options.canTryLock = true; + + var alertMsg = _('The document could not be locked, and is opened in read-only mode.'); + if (reason) { + alertMsg += _('\nServer returned this reason: "') + reason + '"'; + } + vex.dialog.alert({ message: alertMsg }); + + var
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/xlsx/tdf134769.xlsx |binary sc/qa/unit/subsequent_export-test.cxx | 21 + 2 files changed, 21 insertions(+) New commits: commit e59ac9bea9caf5b24258ac1fecfc886a0fc7374f Author: Xisco Fauli AuthorDate: Sat Jul 25 19:55:41 2020 +0200 Commit: Xisco Fauli CommitDate: Sun Jul 26 22:11:27 2020 +0200 tdf#134769: sc_subsequent_export_test: Add unittest Change-Id: Ief7138716bb15a1b7a87fa9baee2cfaf7bbfc9c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99447 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sc/qa/unit/data/xlsx/tdf134769.xlsx b/sc/qa/unit/data/xlsx/tdf134769.xlsx new file mode 100644 index ..2f7c74adff57 Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf134769.xlsx differ diff --git a/sc/qa/unit/subsequent_export-test.cxx b/sc/qa/unit/subsequent_export-test.cxx index ae42341df323..b645979f6b84 100644 --- a/sc/qa/unit/subsequent_export-test.cxx +++ b/sc/qa/unit/subsequent_export-test.cxx @@ -224,6 +224,7 @@ public: void testKeepSettingsOfBlankRows(); void testTdf133595(); +void testTdf134769(); void testTdf105272(); void testTdf118990(); void testTdf121612(); @@ -375,6 +376,7 @@ public: CPPUNIT_TEST(testKeepSettingsOfBlankRows); CPPUNIT_TEST(testTdf133595); +CPPUNIT_TEST(testTdf134769); CPPUNIT_TEST(testTdf105272); CPPUNIT_TEST(testTdf118990); CPPUNIT_TEST(testTdf121612); @@ -4593,6 +4595,25 @@ void ScExportTest::testTdf133595() xDocSh->DoClose(); } +void ScExportTest::testTdf134769() +{ +ScDocShellRef xDocSh = loadDoc("tdf134769.", FORMAT_XLSX); +CPPUNIT_ASSERT(xDocSh.is()); + +std::shared_ptr pXPathFile = ScBootstrapFixture::exportTo(&(*xDocSh), FORMAT_XLSX); +xmlDocUniquePtr pSheet = XPathHelper::parseExport(pXPathFile, m_xSFactory, "xl/worksheets/sheet1.xml"); +CPPUNIT_ASSERT(pSheet); + +// without the fix in place, the legacyDrawing would have been exported after the checkbox +// and Excel would have claimed the document is corrupted +// Use their ids to check the order +assertXPath(pSheet, "/x:worksheet/x:drawing", "id", "rId2"); +assertXPath(pSheet, "/x:worksheet/x:legacyDrawing", "id", "rId3"); +assertXPath(pSheet, "/x:worksheet/mc:AlternateContent/mc:Choice/x:controls/mc:AlternateContent/mc:Choice/x:control", "id", "rId4"); + +xDocSh->DoClose(); +} + void ScExportTest::testTdf105272() { ScDocShellRef xDocSh = loadDoc("tdf105272.", FORMAT_XLSX); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135171] FILESAVE DOCX: A DOCX exported from LibreOffice takes long long time to open
https://bugs.documentfoundation.org/show_bug.cgi?id=135171 Telesto changed: What|Removed |Added Summary|FILEOPEN DOCX: Takes long |FILESAVE DOCX: A DOCX |long time |exported from LibreOffice ||takes long long time to ||open --- Comment #3 from Telesto --- A file exported by 5.2.5 opens also fine in 7.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135171] FILEOPEN DOCX: Takes long long time
https://bugs.documentfoundation.org/show_bug.cgi?id=135171 Telesto changed: What|Removed |Added Version|7.1.0.0.alpha0+ Master |6.0.0.3 release Keywords||bibisectRequest, regression --- Comment #2 from Telesto --- Also found in 6.0 not in 5.2.5 (rendering surely not perfect, but does open :-) even faster in 4.4.7.2 (but probably incomplete) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-6-4' - sw/qa sw/source
sw/qa/extras/ooxmlexport/data/tdf133701.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport6.cxx| 10 ++ sw/source/filter/ww8/docxattributeoutput.cxx |9 - 3 files changed, 18 insertions(+), 1 deletion(-) New commits: commit 6de6809522804ea2f4fa3f249de726d8d7d120a6 Author: Tibor Nagy AuthorDate: Tue Jun 9 13:38:35 2020 +0200 Commit: Gabor Kelemen CommitDate: Sun Jul 26 21:57:16 2020 +0200 tdf#133701 DOXC export: fix frame distance from text Vertical and horizontal minimum distances of frame and the text wrapping around the frame were not exported. Note: different left/right, top/bottom values aren't supported by OOXML hSpace, vSpace, so calculate average values to keep the page layout. Co-authored-by: Attila Bakos (NISZ) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96110 Tested-by: László Németh Reviewed-by: László Németh (cherry picked from commit a2113f5f46921c38a0c4929bb564183009a838e9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96698 Tested-by: Jenkins Reviewed-by: Xisco Fauli (cherry picked from commit ebe228dc28773816beaa78837a8441513270cb67) Change-Id: Ieef999003bcc6b9bba0a932ee4dd2b5461380c17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99402 Tested-by: Gabor Kelemen Reviewed-by: Gabor Kelemen diff --git a/sw/qa/extras/ooxmlexport/data/tdf133701.docx b/sw/qa/extras/ooxmlexport/data/tdf133701.docx new file mode 100644 index ..dfef409c268c Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf133701.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx index 01904b93b365..9b96cd04893b 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx @@ -42,6 +42,16 @@ protected: } }; +DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf133701, "tdf133701.docx") +{ +xmlDocPtr pXmlDocument = parseExport("word/document.xml"); +if (!pXmlDocument) +return; + +assertXPath(pXmlDocument, "/w:document/w:body/w:p[2]/w:pPr/w:framePr", "hSpace", "567"); +assertXPath(pXmlDocument, "/w:document/w:body/w:p[2]/w:pPr/w:framePr", "vSpace", "284"); +} + DECLARE_OOXMLEXPORT_TEST(testDmlShapeTitle, "dml-shape-title.docx") { CPPUNIT_ASSERT_EQUAL(OUString("Title"), getProperty(getShape(1), "Title")); diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index d5ebe12bad2f..9b63aefddc15 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -563,7 +563,6 @@ static void lcl_deleteAndResetTheLists( rtl::ReferenceGetHoriOrient().GetPos(), pFrameFormat->GetVertOrient().GetPos()); @@ -574,6 +573,14 @@ void DocxAttributeOutput::PopulateFrameProperties(const SwFrameFormat* pFrameFor attrList->add( FSNS( XML_w, XML_x), OString::number(aPos.X)); attrList->add( FSNS( XML_w, XML_y), OString::number(aPos.Y)); +sal_Int16 nLeft = pFrameFormat->GetLRSpace().GetLeft(); +sal_Int16 nRight = pFrameFormat->GetLRSpace().GetRight(); +sal_Int16 nUpper = pFrameFormat->GetULSpace().GetUpper(); +sal_Int16 nLower = pFrameFormat->GetULSpace().GetLower(); + +attrList->add(FSNS(XML_w, XML_hSpace), OString::number((nLeft + nRight) / 2)); +attrList->add(FSNS(XML_w, XML_vSpace), OString::number((nUpper + nLower) / 2)); + OString relativeFromH = convertToOOXMLHoriOrientRel( pFrameFormat->GetHoriOrient().GetRelationOrient() ); OString relativeFromV = convertToOOXMLVertOrientRel( pFrameFormat->GetVertOrient().GetRelationOrient() ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135171] FILEOPEN DOCX: Takes long long time
https://bugs.documentfoundation.org/show_bug.cgi?id=135171 --- Comment #1 from Telesto --- Created attachment 163585 --> https://bugs.documentfoundation.org/attachment.cgi?id=163585=edit Example file DOCX exported with 7.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135171] New: FILEOPEN DOCX: Takes long long time
https://bugs.documentfoundation.org/show_bug.cgi?id=135171 Bug ID: 135171 Summary: FILEOPEN DOCX: Takes long long time Product: LibreOffice Version: 7.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: FILEOPEN DOCX: Takes long long time Steps to Reproduce: 1. Open attachment 163583 [details] 2. Save as DOCX 3. File reload -> Start waiting.. Actual Results: 2 minutes or more didn't wait Expected Results: 30 seconds Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37507] Vertical scrolling with mouse cursor is too fast to control
https://bugs.documentfoundation.org/show_bug.cgi?id=37507 --- Comment #8 from jfilc...@yahoo.com --- Confirmed. I've been writing books using Writer and the text selection scrolling is set so high (speed wise) as it's functionally useless for the average user. Plenty of user complaints about this bug that can be Googled, so it's a serious usability bug that is a real turn off for users. It makes Writer feel amateurish compared to Word, and should be fixed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135144] Saving DOCX to ODT with hiding tracking changes trashes all images
https://bugs.documentfoundation.org/show_bug.cgi?id=135144 Telesto changed: What|Removed |Added Version|7.1.0.0.alpha0+ Master |7.0.0.1 rc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135144] Saving DOCX to ODT with hiding tracking changes trashes all images
https://bugs.documentfoundation.org/show_bug.cgi?id=135144 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5096 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135096] Missing images after save to ODT (tracking changed hide)
https://bugs.documentfoundation.org/show_bug.cgi?id=135096 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5144 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135170] SPECIAL PASTE RTF: Only pasting a number field
https://bugs.documentfoundation.org/show_bug.cgi?id=135170 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135170] New: SPECIAL PASTE RTF: Only pasting a number field
https://bugs.documentfoundation.org/show_bug.cgi?id=135170 Bug ID: 135170 Summary: SPECIAL PASTE RTF: Only pasting a number field Product: LibreOffice Version: 7.0.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: SPECIAL PASTE RTF: Only pasting a number field Steps to Reproduce: 1. Open attachment 163583 [details] 2. CTRL+A 3. CTRL+C 4. CTRL+N 5. CTRL+SHIFT+V RTF Actual Results: Pastes only a number field Expected Results: At minimum the first 60 pages (as before); ideally everything Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL not in 6.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-6-4' - sw/qa sw/source
sw/qa/extras/uiwriter/uiwriter.cxx | 14 ++ sw/source/uibase/shells/textfld.cxx | 11 +++ 2 files changed, 25 insertions(+) New commits: commit efe25ca0706541f7d0144e5b650a19f8d2f1a1ac Author: László Németh AuthorDate: Thu Jun 11 07:37:49 2020 +0200 Commit: Gabor Kelemen CommitDate: Sun Jul 26 21:37:31 2020 +0200 tdf#134035 sw: insert long date format for Hungarian in Writer using Insert->Field->Date or the similar toolbar function. Note: the previously used short date format -MM-DD is rare in Hungarian text documents, and it is no longer mentioned in the last Hungarian orthographic standard (But it's still default in Calc, as standardized by (MSZ) ISO 8601.) Conflicts: sw/qa/extras/uiwriter/uiwriter.cxx Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96112 Tested-by: Jenkins Reviewed-by: László Németh (cherry picked from commit 64641e9aa8f5399bae7846830176bcbfaf9d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96584 Reviewed-by: Adolfo Jayme Barrientos (cherry picked from commit 86ed93261137e24c679baed137cc4559eb5376e4) Change-Id: I09f2f3314356e84c73a42be9f06ceaa6769e7338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99401 Tested-by: Gabor Kelemen Reviewed-by: Gabor Kelemen diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index 22c64cf844d6..33a5563c505e 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -368,6 +368,7 @@ public: void testTdf59666(); void testTdf133524(); void testInconsistentBookmark(); +void testInsertLongDateFormat(); CPPUNIT_TEST_SUITE(SwUiWriterTest); CPPUNIT_TEST(testReplaceForward); @@ -577,6 +578,7 @@ public: CPPUNIT_TEST(testTdf38394); CPPUNIT_TEST(testTdf59666); CPPUNIT_TEST(testTdf133524); +CPPUNIT_TEST(testInsertLongDateFormat); CPPUNIT_TEST_SUITE_END(); private: @@ -7144,6 +7146,18 @@ void SwUiWriterTest::testTdf133524() CPPUNIT_ASSERT_EQUAL(sReplaced, static_cast(pDoc->GetNodes()[nIndex])->GetText()); } +void SwUiWriterTest::testInsertLongDateFormat() +{ +// only for Hungarian, yet +createDoc("tdf133524.fodt"); +lcl_dispatchCommand(mxComponent, ".uno:InsertDateField", {}); +// Make sure that the document starts with a field now, and its expanded string value contains space +const uno::Reference< text::XTextRange > xField = getRun(getParagraph(1), 1); +CPPUNIT_ASSERT_EQUAL(OUString("TextField"), getProperty(xField, "TextPortionType")); +// the date format was "-MM-DD", but now ". MMM DD." +CPPUNIT_ASSERT(xField->getString().indexOf(" ") > -1); +} + CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest); CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/sw/source/uibase/shells/textfld.cxx b/sw/source/uibase/shells/textfld.cxx index c65d5d65da6a..b5644784f8ac 100644 --- a/sw/source/uibase/shells/textfld.cxx +++ b/sw/source/uibase/shells/textfld.cxx @@ -82,6 +82,7 @@ #include #include #include +#include using namespace nsSwDocInfoSubType; @@ -636,9 +637,19 @@ void SwTextShell::ExecField(SfxRequest ) break; case FN_INSERT_FLD_DATE: +{ nInsertType = SwFieldTypesEnum::Date; bIsText = false; +// use long date format for Hungarian +SwPaM* pCursorPos = rSh.GetCursor(); +if( pCursorPos ) +{ +LanguageType nLang = pCursorPos->GetPoint()->nNode.GetNode().GetTextNode()->GetLang(pCursorPos->GetPoint()->nContent.GetIndex()); +if (nLang == LANGUAGE_HUNGARIAN) +nInsertFormat = rSh.GetNumberFormatter()->GetFormatIndex(NF_DATE_SYSTEM_LONG, nLang); +} goto FIELD_INSERT; +} case FN_INSERT_FLD_TIME: nInsertType = SwFieldTypesEnum::Time; bIsText = false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135150] FILEOPEN ODT: Layout ODT of file written with 7.1 broken with 6.1
https://bugs.documentfoundation.org/show_bug.cgi?id=135150 --- Comment #7 from Telesto --- Created attachment 163584 --> https://bugs.documentfoundation.org/attachment.cgi?id=163584=edit PDF exported with 6.1 master -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135169] Crash on Paste Special RTF
https://bugs.documentfoundation.org/show_bug.cgi?id=135169 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx | 122 +++--- 1 file changed, 49 insertions(+), 73 deletions(-) New commits: commit a93b329b4c1757f0a585cac6348e9b152372c33f Author: Shivam Kumar Singh AuthorDate: Sat Jul 25 13:29:12 2020 +0530 Commit: Mike Kaganski CommitDate: Sun Jul 26 21:32:07 2020 +0200 tdf#135106 Direct Formatting should be empty by default Change-Id: Ic7dfb2e681c5128288b2f39054bc642ab6028fed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99420 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx b/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx index 51d052e0ed91..b2c346353e52 100644 --- a/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx +++ b/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx @@ -23,6 +23,8 @@ #include #include #include +#include +#include #include #include #include @@ -61,12 +63,49 @@ WriterInspectorTextPanel::WriterInspectorTextPanel(vcl::Window* pParent, pShell->SetChgLnk(LINK(this, WriterInspectorTextPanel, AttrChangedNotify)); } -static void UpdateTree(SwDocShell* pDocSh, std::vector& aStore) +static void InsertValues(const css::uno::Reference& rSource, + std::unordered_map& rIsDefined, + svx::sidebar::TreeNode& rNode, const bool& isRoot, + const std::vector& rHiddenProperty) { +uno::Reference xPropertiesSet(rSource, uno::UNO_QUERY_THROW); +uno::Reference xPropertiesState(rSource, uno::UNO_QUERY_THROW); +const uno::Sequence aProperties += xPropertiesSet->getPropertySetInfo()->getProperties(); + +for (const beans::Property& rProperty : aProperties) +{ +if (std::find(rHiddenProperty.begin(), rHiddenProperty.end(), rProperty.Name) +!= rHiddenProperty.end()) +continue; +if (isRoot +|| xPropertiesState->getPropertyState(rProperty.Name) + == beans::PropertyState_DIRECT_VALUE) +{ +const uno::Any aAny = xPropertiesSet->getPropertyValue(rProperty.Name); +svx::sidebar::TreeNode aTemp; +if (rIsDefined[rProperty.Name]) +aTemp.isGrey = true; +rIsDefined[rProperty.Name] = true; +aTemp.sNodeName = rProperty.Name; +aTemp.aValue = aAny; +rNode.children.push_back(aTemp); +} +} + const comphelper::string::NaturalStringSorter aSorter( comphelper::getProcessComponentContext(), Application::GetSettings().GetUILanguageTag().getLocale()); +std::sort( +rNode.children.begin(), rNode.children.end(), +[](svx::sidebar::TreeNode const& rEntry1, svx::sidebar::TreeNode const& rEntry2) { +return aSorter.compare(rEntry1.sNodeName, rEntry2.sNodeName) < 0; +}); +} + +static void UpdateTree(SwDocShell* pDocSh, std::vector& aStore) +{ SwDoc* pDoc = pDocSh->GetDoc(); SwPaM* pCursor = pDoc->GetEditShell()->GetCursor(); svx::sidebar::TreeNode aDFNode; @@ -82,31 +121,15 @@ static void UpdateTree(SwDocShell* pDocSh, std::vector& uno::Reference xRange( SwXTextRange::CreateXTextRange(*pDoc, *pCursor->GetPoint(), nullptr)); - uno::Reference xPropertiesSet(xRange, uno::UNO_QUERY_THROW); -uno::Reference xPropertiesState(xRange, uno::UNO_QUERY_THROW); - -uno::Sequence aProperties -= xPropertiesSet->getPropertySetInfo()->getProperties(); - std::unordered_map aIsDefined; -for (const beans::Property& rProperty : std::as_const(aProperties)) -{ -if (xPropertiesState->getPropertyState(rProperty.Name) == beans::PropertyState_DIRECT_VALUE) -{ -const uno::Any aAny = xPropertiesSet->getPropertyValue(rProperty.Name); -aIsDefined[rProperty.Name] = true; -svx::sidebar::TreeNode aTemp; -aTemp.sNodeName = rProperty.Name; -aTemp.aValue = aAny; -aDFNode.children.push_back(aTemp); -} -} -std::sort( -aDFNode.children.begin(), aDFNode.children.end(), -[](svx::sidebar::TreeNode const& rEntry1, svx::sidebar::TreeNode const& rEntry2) { -return aSorter.compare(rEntry1.sNodeName, rEntry2.sNodeName) < 0; -}); + +InsertValues(xRange, aIsDefined, aDFNode, false, + { UNO_NAME_RSID, UNO_NAME_PARA_IS_NUMBERING_RESTART, UNO_NAME_PARA_STYLE_NAME, + UNO_NAME_PARA_CONDITIONAL_STYLE_NAME, UNO_NAME_PAGE_STYLE_NAME, + UNO_NAME_NUMBERING_START_VALUE, UNO_NAME_NUMBERING_IS_NUMBER, + UNO_NAME_PARA_CONTINUEING_PREVIOUS_SUB_TREE, UNO_NAME_CHAR_STYLE_NAME, + UNO_NAME_NUMBERING_LEVEL }); uno::Reference xStyleFamiliesSupplier(pDocSh->GetBaseModel(),
[Libreoffice-bugs] [Bug 135169] Crash on Paste Special RTF
https://bugs.documentfoundation.org/show_bug.cgi?id=135169 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5168 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135168] Lots of empty pages added on paste since 6.5
https://bugs.documentfoundation.org/show_bug.cgi?id=135168 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5169 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135169] New: Crash on Paste Special RTF
https://bugs.documentfoundation.org/show_bug.cgi?id=135169 Bug ID: 135169 Summary: Crash on Paste Special RTF Product: LibreOffice Version: 7.0.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Crash on Paste Special RTF Steps to Reproduce: 1. Open attachment 163583 2. CTRL+A 3. CTRL+C 4. CTRL+N 5. CTRL+SHIFT+V RTF Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.1.0.0.alpha0+ (x64) Build ID: CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL not in 6.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 --- Comment #3 from Telesto --- (In reply to Julien Nabet from comment #2) > Searching in Bugzilla, we've got this > https://bugs.documentfoundation.org/buglist. > cgi?quicksearch=Index2Block_id=1175224 > and in peculiar tdf#134101 which is very resembling. > (BigPtrArray::Index2Block + undo process in both cases + odt) > > IMHO, it could be interesting to wait for this one to be fixed before > creating new similar bugtrackers. There are some fixed new introduced.. lots of stuff crashes into BigPtrArray::Index2Block.. So I'm never sure.. There are three bugs around which could be they same -> all inherited.. so maybe/ hopefully the same... a BT would tell (that's the reason for wantBackTrace :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135168] Lots of empty pages added on paste since 6.5
https://bugs.documentfoundation.org/show_bug.cgi?id=135168 --- Comment #1 from Telesto --- Created attachment 163583 --> https://bugs.documentfoundation.org/attachment.cgi?id=163583=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135168] New: Lots of empty pages added on paste since 6.5
https://bugs.documentfoundation.org/show_bug.cgi?id=135168 Bug ID: 135168 Summary: Lots of empty pages added on paste since 6.5 Product: LibreOffice Version: 7.0.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Lots of empty pages added on paste since 6.5 Steps to Reproduce: 1. Open the attached file 2. CTRL+A 3. CTRL+C 4. CTRL+N 5. CTRL+V Actual Results: 401 Expected Results: 339 shows the original.. 330 on copy/paste with different versions.. so within acceptable range Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.0.0.0.beta1+ (x64) Build ID: 2891e91a513520d68ea2b8c59c14335861a15253 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL not in 6.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135168] Lots of empty pages added on paste since 6.5
https://bugs.documentfoundation.org/show_bug.cgi?id=135168 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4101 --- Comment #2 from Julien Nabet --- Searching in Bugzilla, we've got this https://bugs.documentfoundation.org/buglist.cgi?quicksearch=Index2Block_id=1175224 and in peculiar tdf#134101 which is very resembling. (BigPtrArray::Index2Block + undo process in both cases + odt) IMHO, it could be interesting to wait for this one to be fixed before creating new similar bugtrackers. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134101] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=134101 Julien Nabet changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5167 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65725] FILE_SAVE : Master document export PDF in headless mode doesn't show sub documents page
https://bugs.documentfoundation.org/show_bug.cgi?id=65725 --- Comment #13 from Derek Cooper --- I can confirm this bug exists in version 6.4.5.2 on Windows 10. Details: Version: 6.4.5.2 (x64) Build ID: a726b36747cf2001e06b58ad5db1aa3a9a1872d6 CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133914] Crash swlo!BigPtrArray::Index2Block
https://bugs.documentfoundation.org/show_bug.cgi?id=133914 Telesto changed: What|Removed |Added Keywords||wantBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: I have wrote for a couple of hours something like 56 pages after that I have save it pressing the button Save many times and I the end I have discovered that my document had lost 50 + pages ,
PS Hi , Here I have found that other people are praising the Autosaving Option from Google Docs , The thing that I have emphasized in the previous emails as well as a priority , a must from my opinion ., IMHO . We can not compare A trillion dollar company like Google with 2 Billion users for G suite with a Team of Volunteers that are developing for free a product like Libre .But I think we should emulate the Best Features like Autosaving from Google Docs and others , from Successful and reliable software solutions like G Docs so on and Implement by Default AutoSAving features every Couple of Seconds IMHO . https://www.goskills.com/Microsoft-Office/Resources/Google-Docs-Microsoft-Word-comparison https://www.zdnet.com/article/google-g-suite-now-has-2-billion-users/#:~:text=Google's%20office%20productivity%20suite%2C%20G,the%20end%20of%20last%20year. Plus, Docs backs up your saved files to Google Drive instead of your local hard drive. So Google saves your work — *and backs up your work — *to give you extra protection should you spill coffee all over your laptop and wreck your hard drive. Our winner: Google is the automatic save hero you never thought your docs needed. Thanks for your work developing a good product . kind regards. adrian g On Thu, Jul 23, 2020 at 10:58 PM g adi wrote: > Hi Italo , Paul , Hi guys ! > > I have just remember how I have said in the previous emails : Why do not > made Autosaving Implicit By Default Very Frequently , By Default it is like > 10 minutes , I have manual Choose 1 minute the minimum but I have Remember > that Google Docs has the AutoSave like every 2 Seconds , > > Why you do not do the same ? Autosave every 1 -2 Seconds ? and by Default > do not let new Libre Users choose them because can be too late and they > will loose they words , work and the Libre File and the people will be > very upset . > > This should be a Priority , it is a Major Issue and and Urgent One in > IMHO , Google Docs is doing the same for example . > > Loosing your Writing is very frustrating and people could lose > precious and very important documents , it was not my case , still I was > upset but you got my idea . > > > > https://ask.libreoffice.org/en/question/33150/libreoffice-just-not-saving-properly-and-deleted-1000-words-of-my-dissertation/#:~:text=Check%20the%20Tools%20%7C%20Options%20%7C%20LibreOffice,document%20and%20save%20as%20docx. > > I don't know what the going on but I just saved my work to close it > and reopen it because spellcheck wasn't working and I reopened it and it's > saved 2 words? It did something similar last night but I thought I just > hadn't saved it properly cos it only lost 200 words or so. > > 2. Same Why the Backup or Temporary File Salvation it is not working > properly too ? As a second net save mechanism in the case like something > Bad is Happening like in my case : saving as Docx , Black out , no more > Electricity so on ? > > 3. Microsoft Word , Google Docs they have better Recovery Systems I think > , I think we can learn from them and we can implement ? > > 4. I have give you the details requested , can you reproduce my case and > my error ? > > Thanks . > kind regards, > adrian g > > > > > On Thu, Jul 23, 2020 at 4:39 PM g adi wrote: > >> Hi ! >> >> Thanks for making this software for free , for your work but yesterday I >> was very upset . >> >> I have open a new file save it .docx , like I have done for a file before >> , one more time , just so this was the second time that I have created and >> saved a file with Docx and not ODt because in the past couple of my friends >> after I have send them the Odt files they said that they could not open >> them on Laptop or Mobile and I need to tell them what to install so on so >> Yesterday I have said that Lets create a Docx File using Libre so that It >> will be compatible for my friends But It was a bad Idea to save it Docx >> instead of Odt . It cost me a couple of hours of work . >> >> I have wrote for a couple of hours something like 56 pages after that I >> have save it pressing the button Save many times and I the end I have >> discovered that my document had lost 50 + pages , >> they were pics for my anatomy Notes , all my pics were gone just a little >> Text had been save it . >> very frustrating to lose my work for couple of hours . >> I have tried the solution bellow with the Backup and Temporary files and >> no file I have found . >> I could not believe that this could happen for Libre Office a software >> with many years experience behind . >> I do not Understand why This Option It is still there Saving As Docx , >> Still Available if it is not Working properly ? Why not Beta ? Why not a >> big Sign that it is possible to loose your Work ? >> if It Is causing Losing Pages 98 % of my pages mayne , 50 + pages with >> pictures for Anatomy . >> The issue was reported in 2014 and still in 2020 had the same problem . >> >> >>
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 Telesto changed: What|Removed |Added Keywords||wantBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133911] Crash swlo!BigPtrArray::Index2Block+0xc8swlo!BigPtrArray::Index2Block+0xc8:
https://bugs.documentfoundation.org/show_bug.cgi?id=133911 Telesto changed: What|Removed |Added Keywords||wantBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 Telesto changed: What|Removed |Added Summary|BigPtrArray::Index2Block|BigPtrArray::Index2Block |undo crash at undo |undo crash -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] BigPtrArray::Index2Block undo crash at undo
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 --- Comment #1 from Telesto --- Created attachment 163582 --> https://bugs.documentfoundation.org/attachment.cgi?id=163582=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135167] New: BigPtrArray::Index2Block undo crash at undo
https://bugs.documentfoundation.org/show_bug.cgi?id=135167 Bug ID: 135167 Summary: BigPtrArray::Index2Block undo crash at undo Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: BigPtrArray::Index2Block undo crash at undo Steps to Reproduce: 1. Open the attached file 2. CTRL+A 3. CTRL+C 4. CTRL+N 5. CTRL+V 6. CTRL+Z Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Found in 7.1 6.0 4.4.7.2 4.2.7.2 4.0.0.3 3.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs