[Libreoffice-bugs] [Bug 120383] Template documents in online have fixed language

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120383

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Aron Budea  ---
Fixed by the following commits in NC and oC richdocuments:
https://github.com/nextcloud/richdocuments/commit/56439d25a22974d6f71993fb2b63461e20386866
https://github.com/owncloud/richdocuments/commit/27021cf1fdd5ad01a3488d85081f1c09e2bfffde

Templates are based on bug 133661's minimal templates.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137087] FILEOPEN: Calc becomes "not responding" after opening this simple file

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137087

m.a.riosv  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from m.a.riosv  ---
Confirmed with:
Version: 6.4.7.1 (x64)
Build ID: 32fe9ceb49bbaa24397ab3ebad5eb8f5287d8086
CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: GL; VCL: win; 
Locale: es-ES (es_ES); UI-Language: en-US Calc: CL

The issue is solved resetting whole rows to automatic height.

Runs smoothly with:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: dec9a123867dcd0fea4683beeb3b4b6659f926f3
CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: threaded

So maybe it has been solved at some point.

Marked as works for me, because it works on the latest version, and looks a
corner case.

Please if you are not agree reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137089] Neither /opt/collaboraoffice6.4/program/libsofficeapp.so or /opt/collaboraoffice6.4/program/libmergedlo.so exist.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137089

Aron Budea  changed:

   What|Removed |Added

 Resolution|--- |MOVED
 Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Aron Budea  ---
Simon, if you're still having this issue, please open it at the following issue
tracker: https://github.com/CollaboraOnline/online/issues

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137193] Calc gridlines disappear on formula cells

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137193

Bill  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137193] Calc gridlines disappear on formula cells

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137193

--- Comment #2 from Bill  ---
Created attachment 166043
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166043=edit
Calc worksheet

I should also have said that the lines disappear around the formula cells only,
the rest of the sheet is unaffected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133315] Calc hangs after undoing the deletion of a number of columns

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133315

m.a.riosv  changed:

   What|Removed |Added

   Severity|critical|normal
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #7 from m.a.riosv  ---
Works fine for me, a few of seconds.
Version: 7.1.0.0.alpha0+ (x64)
Build ID: dec9a123867dcd0fea4683beeb3b4b6659f926f3
CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: threaded

So please retest, in any why critical.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137113] LO Calc Data - Validity - Cell Range / LIST - Selection List - Typing Selection is NOT working

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137113

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEW

--- Comment #4 from m.a.riosv  ---
Confirmed, begin showing the last values.
Version: 7.1.0.0.alpha0+ (x64)
Build ID: dec9a123867dcd0fea4683beeb3b4b6659f926f3
CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137147] Provide a way to cancel formula calculation in Calc (e.g., by hitting ESC key)

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137147

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Meanwhile, you can disable Menu/Data/Calculate/Autocalculate.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137193] Calc gridlines disappear on formula cells

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137193

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Please attach a sample file where it happens.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137195] LibreOffice Calc locks up during opening an existing file.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137195

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from m.a.riosv  ---
Please try Menu/Help/Restart in Safe Mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61203] SQL syntax error inserting new record into empty table

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61203

Julien Nabet  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED
 CC|serval2...@yahoo.fr |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108897

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on|109061  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109061
[Bug 109061] xlsx import : large ranges in formula shows error on recalc
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133764] [META] Very large spreadsheets problem

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133764

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on||109061


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109061
[Bug 109061] xlsx import : large ranges in formula shows error on recalc
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109061] xlsx import : large ranges in formula shows error on recalc

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109061

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Blocks|108897  |133764

--- Comment #9 from NISZ LibreOffice Team  ---
Now very large sheets are somewhat supported, but enabling that and opening
this file makes Calc instantly crash in current 7.1 master.

Version: 7.1.0.0.alpha0+ (x64)
Build ID: dda71436b8594fb0669b3ac06c02a3997a0674be
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108897
[Bug 108897] [META] XLSX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=133764
[Bug 133764] [META] Very large spreadsheets problem
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104520
Bug 104520 depends on bug 106552, which changed state.

Bug 106552 Summary: Commandline convert DOCX to fodt or odt, wrong 

https://bugs.documentfoundation.org/show_bug.cgi?id=106552

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106552] Commandline convert DOCX to fodt or odt, wrong

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106552

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #7 from Buovjaga  ---
(In reply to Mike Kaganski from comment #6)
> Can't repro with Version: 7.0.2.1 (x64)
> Build ID: ede20268f3f8777cdf69e0281835d320c41213fc
> CPU threads: 12; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL:
> win
> Locale: ru-RU (ru_RU); UI: en-US
> Calc: CL
> 
> WORKSFORME? Or Linux-specific?

WORKSFORME

Arch Linux 64-bit
Version: 7.1.0.0.alpha0+
Build ID: 09c24681a3414092fde50ec0f617c9f7c79e8a61
CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 30 September 2020

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117718] [META] Flat xml/odf issues

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117718
Bug 117718 depends on bug 106552, which changed state.

Bug 106552 Summary: Commandline convert DOCX to fodt or odt, wrong 

https://bugs.documentfoundation.org/show_bug.cgi?id=106552

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106552] Commandline convert DOCX to fodt or odt, wrong

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106552

--- Comment #6 from Mike Kaganski  ---
Can't repro with Version: 7.0.2.1 (x64)
Build ID: ede20268f3f8777cdf69e0281835d320c41213fc
CPU threads: 12; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

WORKSFORME? Or Linux-specific?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: bin/lint-ui.py

2020-10-02 Thread Noel (via logerrit)
 bin/lint-ui.py |8 
 1 file changed, 8 insertions(+)

New commits:
commit 4d19361336b32585d5cd5bd5faccba4467b7d5e8
Author: Noel 
AuthorDate: Fri Oct 2 12:56:09 2020 +0200
Commit: Noel Grandin 
CommitDate: Fri Oct 2 19:02:20 2020 +0200

lint-ui: add check for upper in GtkAdjustment

Change-Id: I3a9859dbb4dbb0aeb2446176a239843a19d40e1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103833
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/bin/lint-ui.py b/bin/lint-ui.py
index 5dc33eaaec2a..26c011f2637a 100755
--- a/bin/lint-ui.py
+++ b/bin/lint-ui.py
@@ -96,6 +96,14 @@ def check_radio_buttons(root):
 if len(radio_underlines) < 1:
 lint_assert(False, "No use_underline in GtkRadioButton with id = 
'" + radio.attrib['id'] + "'", radio)
 
+def check_adjustments(root):
+adjustments = [element for element in root.findall('.//object') if 
element.attrib['class'] == 'GtkAdjustment']
+for adjusment in adjustments:
+uppers = radio.findall("./property[@name='upper']")
+assert len(uppers) <= 1
+if len(uppers) < 1:
+lint_assert(False, "No upper in GtkAdjustment with id = '" + 
radio.attrib['id'] + "'", radio)
+
 def check_menu_buttons(root):
 buttons = [element for element in root.findall('.//object') if 
element.attrib['class'] == "GtkMenuButton"]
 for button in buttons:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103378

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on|106539  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106539
[Bug 106539] Headers/footers cut off in this XLS/XLSX when exported to
PDF/printed
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109087] [META] Sheet header and footer bugs and enhancements

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109087

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on||106539


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106539
[Bug 106539] Headers/footers cut off in this XLS/XLSX when exported to
PDF/printed
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106539] Headers/footers cut off in this XLS/XLSX when exported to PDF/printed

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106539

NISZ LibreOffice Team  changed:

   What|Removed |Added

 CC||libreoff...@nisz.hu
 Blocks|103378  |109087

--- Comment #13 from NISZ LibreOffice Team  ---
Upper/lower margin is 1.5 cm while header/footer is 1.3. 
Enlarging the header/footer to 1.5 cm in Excel makes the header/footer text
completely disappear, while reducing them to 1 cm in Excel makes the text
appear whole.
Changing meta bug in any case.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
[Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109087
[Bug 109087] [META] Sheet header and footer bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137211] My "EXACT" function isn't working properly, but only with one specific spreadsheet.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137211

Mike Kaganski  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Mike Kaganski  ---
Ah, this is not a bug. Your ODS has Data->Calculate->AutoCalculate disabled. It
just does not calculate formulas, until you press F9 (for current cell) or
Ctrl+Shift+F9 (for everything).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137211] My "EXACT" function isn't working properly, but only with one specific spreadsheet.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137211

--- Comment #2 from Mike Kaganski  ---
Which cell exactly is expected to produce TRUE?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137211] My "EXACT" function isn't working properly, but only with one specific spreadsheet.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137211

--- Comment #1 from R.J. Bowman  ---
Created attachment 166042
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166042=edit
A sample file affected by the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137211] New: My "EXACT" function isn't working properly, but only with one specific spreadsheet.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137211

Bug ID: 137211
   Summary: My "EXACT" function isn't working properly, but only
with one specific spreadsheet.
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: b...@wonderworldcomics.com

Description:
This is a specific problem with a spreadsheet. I have cut the spreadsheet down
to just a portion of the entries effected and you can download it here:
http://wonderworldcomics.com/ProblemEXACTFunction.ods
The problem is that the "EXACT" function isn't working properly. It always
returns a "FALSE" result, even when comparing two cells with the exact same
contents.
I'm using LebreOffice 7.0.1.2, but it doesn't matter. The problem appeared when
I was using an earlier version. I thought that an update might fix it, but it
didn't. I checked the file on a different computer and the bug was still there.
The same file even produces the same results on OpenOffice Calc, so the problem
is likely to be present on just about any version of LibreOffice or OpenOffice.
If I save the sheet in CSV format then reload, the problem is fixed in the new
CSV file, but then if I copy the sheet from the CSV file and past it into a new
sheet in the ODS file, the problem comes back.
I think that it has something to do with the formatting of the sheet, but I've
tried everything I could think of and, no dice.
Please advise.

Steps to Reproduce:
1. Load file that I've linked to
2. Look at what the functions in column 1 are doing

Actual Results:
Always false, even when it should be true. Only with this one spreadsheet.

Expected Results:
Should have resulted in true when cells compared matched.


Reproducible: Always


User Profile Reset: No



Additional Info:
The bug seems to exist in all LibreOffice software versions, and even in
OpenOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137188] Apostrophe quirk only in Writer

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137188

Ming Hua  changed:

   What|Removed |Added

 CC||ming.v@qq.com

--- Comment #3 from Ming Hua  ---
Indeed, version 7.0 made improvement for certain locales to use more
appropriate quotation marks according to local language rules, see [1] for
details.

So your problem is likely writing English in a non-English locale, and
therefore getting non-English autocorrect rules applied.

If that's not the case, and you believe you are using the correct locale, then
in addition to changing the autocorrect rules for yourself, there may be a bug
needs fixing as well.  Please provide the version information in "About >
LibreOffice" dialog (there is a button that copies all the needed text into
clipboard).

1. https://wiki.documentfoundation.org/ReleaseNotes/7.0#AutoCorrect

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137210] New: Edit --> Fields... fails to highlight or otherwise indicate the current field while navigating forward and backward, making locating the field in question cumberso

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137210

Bug ID: 137210
   Summary: Edit --> Fields... fails to highlight or otherwise
indicate the current field while navigating forward
and backward, making locating the field in question
cumbersome and slow.
   Product: LibreOffice
   Version: 7.0.1.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: thuck...@yahoo.com

Description:
Edit --> Fields... (in Writer) fails to highlight or otherwise indicate the
current field while navigating forward and backward, making locating the field
in question cumbersome and slow.  This is particularly problematic in large,
text-heavy documents containing many fields.  Neither IBM Lotus Symphony nor
Apache OpenOffice has such an issue, but it is a result of poor programming
changes in LibreOffice's Edit Fields dialogue.  Please fix this so that
LibreOffice is more usable for fields-laden documents.

Steps to Reproduce:
1.Locate a field, and then go to Edit --> Fields...
2.Use the left and right "arrow" (triangle) buttons to move to the prior or
next field in the document.
3.Notice that the current field in the document is NOT highlighted, the cursor
is NOT blinking or visible near it, and you have to actually READ through all
the text on the page to try to locate the field in question.  That's a total
pain and a waste of time and productivity.

Actual Results:
The current field is NOT evident when moving to it.

Expected Results:
As in Apache OpenOffice 4.x and IBM Lotus Symphony 3, the current field to
which one has navigated using the Edit Fields dialogue's previous or next
button should be made obvious by being highlighted or evidently selected, but
that is NOT occurring even in the latest version of LibreOffice.  


Reproducible: Always


User Profile Reset: No



Additional Info:
OpenGL is NOT enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108253] [META] Calc cell formula bugs and enhancements

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108253
Bug 108253 depends on bug 99313, which changed state.

Bug 99313 Summary: FILEOPEN: XLSX - Validity check based on a formula produces 
faulty result
https://bugs.documentfoundation.org/show_bug.cgi?id=99313

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108897
Bug 108897 depends on bug 99313, which changed state.

Bug 99313 Summary: FILEOPEN: XLSX - Validity check based on a formula produces 
faulty result
https://bugs.documentfoundation.org/show_bug.cgi?id=99313

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99313] FILEOPEN: XLSX - Validity check based on a formula produces faulty result

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99313

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99313] FILEOPEN: XLSX - Validity check based on a formula produces faulty result

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99313

--- Comment #8 from NISZ LibreOffice Team  ---
Created attachment 166041
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166041=edit
The example file in Calc 6.1 and 6.2

This seems to work since 6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108897
Bug 108897 depends on bug 96578, which changed state.

Bug 96578 Summary: EDITING and FILESAVE xlsx file shows wrong number/format 
(with Polish locale..?)
https://bugs.documentfoundation.org/show_bug.cgi?id=96578

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107575] [META] Number format bugs and enhancements

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107575
Bug 107575 depends on bug 96578, which changed state.

Bug 96578 Summary: EDITING and FILESAVE xlsx file shows wrong number/format 
(with Polish locale..?)
https://bugs.documentfoundation.org/show_bug.cgi?id=96578

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 96578] EDITING and FILESAVE xlsx file shows wrong number/format (with Polish locale..?)

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96578

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 96578] EDITING and FILESAVE xlsx file shows wrong number/format (with Polish locale..?)

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96578

--- Comment #13 from NISZ LibreOffice Team  ---
Created attachment 166040
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166040=edit
The example file saved in 5.3 and 5.2 and reloaded

Seems to work fine since 5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137209] gtk3: "New Address List" dialog gets broken

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137209

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: chart2/qa chart2/source sw/qa

2020-10-02 Thread Tünde Tóth (via logerrit)
 chart2/qa/extras/chart2import.cxx  |4 -
 chart2/source/view/charttypes/PieChart.cxx |  115 +++--
 chart2/source/view/charttypes/PieChart.hxx |2 
 sw/qa/extras/layout/data/tdf137116.docx|binary
 sw/qa/extras/layout/layout.cxx |   20 +
 5 files changed, 66 insertions(+), 75 deletions(-)

New commits:
commit a91ac466e2a996a07248ec4a2518d5ba9bdf3d61
Author: Tünde Tóth 
AuthorDate: Tue Sep 29 13:32:40 2020 +0200
Commit: László Németh 
CommitDate: Fri Oct 2 17:01:02 2020 +0200

tdf#137116 pie chart: improve BestFit position of data labels

Regression from commit: 2e1a1054a4a98415057e72269ace9db075d3b191
(tdf#136752 pie chart: improve data label position)

Change-Id: I66943684957a220c81db7f928fbb47700b78d012
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103610
Tested-by: Jenkins
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/chart2/qa/extras/chart2import.cxx 
b/chart2/qa/extras/chart2import.cxx
index 6097a8a0388f..dadc782c0af6 100644
--- a/chart2/qa/extras/chart2import.cxx
+++ b/chart2/qa/extras/chart2import.cxx
@@ -2579,8 +2579,8 @@ void Chart2ImportTest::testTdf134225()
 awt::Point aLabelPosition2 = xDataPointLabel2->getPosition();
 
 // Check the distance between the position of the 1st data point label and 
the second one
-CPPUNIT_ASSERT_DOUBLES_EQUAL(1800, sal_Int32(aLabelPosition2.X - 
aLabelPosition1.X), 30);
-CPPUNIT_ASSERT_DOUBLES_EQUAL(2123, sal_Int32(aLabelPosition2.Y - 
aLabelPosition1.Y), 30);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(1669, sal_Int32(aLabelPosition2.X - 
aLabelPosition1.X), 30);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(2166, sal_Int32(aLabelPosition2.Y - 
aLabelPosition1.Y), 30);
 #endif
 }
 
diff --git a/chart2/source/view/charttypes/PieChart.cxx 
b/chart2/source/view/charttypes/PieChart.cxx
index e2dd04f6c645..6042b0d0dbe4 100644
--- a/chart2/source/view/charttypes/PieChart.cxx
+++ b/chart2/source/view/charttypes/PieChart.cxx
@@ -389,26 +389,51 @@ void PieChart::createTextLabelShape(
  *  First off the routine try to place the label inside the related 
pie slice,
  *  if this is not possible the label is placed outside.
  */
-if (!performLabelBestFitInnerPlacement(rParam, aPieLabelInfo)
-&& m_aAvailableOuterRect.getWidth())
+if (!performLabelBestFitInnerPlacement(rParam, aPieLabelInfo))
 {
-double fAngleDegree
-= rParam.mfUnitCircleStartAngleDegree + 
rParam.mfUnitCircleWidthAngleDegree / 2.0;
-while (fAngleDegree > 360.0)
-fAngleDegree -= 360.0;
-while (fAngleDegree < 0.0)
-fAngleDegree += 360.0;
-
-if (fAngleDegree < 67.5 || fAngleDegree >= 292.5)
-fTextMaximumFrameWidth
-= 0.8 * (m_aAvailableOuterRect.getMaxX() - 
aPieLabelInfo.aFirstPosition.getX());
-else if (fAngleDegree < 112.5 || fAngleDegree >= 247.5)
-fTextMaximumFrameWidth = 0.8 * 
m_aAvailableOuterRect.getWidth();
-else
-fTextMaximumFrameWidth
-= 0.8 * (aPieLabelInfo.aFirstPosition.getX() - 
m_aAvailableOuterRect.getMinX());
-
-nTextMaximumFrameWidth = ceil(fTextMaximumFrameWidth);
+if (m_aAvailableOuterRect.getWidth())
+{
+double fAngleDegree = rParam.mfUnitCircleStartAngleDegree
+  + rParam.mfUnitCircleWidthAngleDegree / 
2.0;
+while (fAngleDegree > 360.0)
+fAngleDegree -= 360.0;
+while (fAngleDegree < 0.0)
+fAngleDegree += 360.0;
+
+if (fAngleDegree < 67.5 || fAngleDegree >= 292.5)
+fTextMaximumFrameWidth
+= 0.8
+  * (m_aAvailableOuterRect.getMaxX() - 
aPieLabelInfo.aFirstPosition.getX());
+else if (fAngleDegree < 112.5 || fAngleDegree >= 247.5)
+fTextMaximumFrameWidth = 0.8 * 
m_aAvailableOuterRect.getWidth();
+else
+fTextMaximumFrameWidth
+= 0.8
+  * (aPieLabelInfo.aFirstPosition.getX() - 
m_aAvailableOuterRect.getMinX());
+
+nTextMaximumFrameWidth = ceil(fTextMaximumFrameWidth);
+}
+
+nScreenValueOffsetInRadiusDirection = (m_nDimension != 3) ? 150 : 
0;
+aScreenPosition2D
+= 
aPolarPosHelper.getLabelScreenPositionAndAlignmentForUnitCircleValues(
+eAlignment, css::chart::DataLabelPlacement::OUTSIDE,
+rParam.mfUnitCircleStartAngleDegree,
+rParam.mfUnitCircleWidthAngleDegree, 
rParam.mfUnitCircleInnerRadius,
+rParam.mfUnitCircleOuterRadius, rParam.mfLogicZ + 0.5, 0);
+aPieLabelInfo.aFirstPosition
+   

[Libreoffice-bugs] [Bug 137200] Changing font for whole document using styles impossible

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137200

--- Comment #7 from V Stuart Foote  ---
(In reply to Timur from comment #6)
> https://help.libreoffice.org/7.1/en-US/text/shared/optionen/01040300.html

Oh very cool, I'd never tried it that way, changing Basic fonts for an existing
& open document...

=> NAB

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137199] FILESAVE: DOCX to ODT Static text in numbered list is lost

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137199

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||0394

--- Comment #6 from Timur  ---
a. -> a 
commit 7dbcd3803dc1a2ab77f6569e291a142007ffab22
Date:   Fri Jun 5 01:23:36 2020 +0200
source sha:36c713f673796f51b9bc657492b0c16396231805
previous source sha:69eb1bb950d09c8edfc78f980c21645c88ac408e

commit  36c713f673796f51b9bc657492b0c16396231805[log]
author  Vasily Melenchuk   Sun May 17 13:35:46
2020 +0300
committer   Thorsten Behrens   Fri Jun 05
01:13:05 2020 +0200
tree5397293a7632da3f2940f61cb63689e7b104d635
parent  69eb1bb950d09c8edfc78f980c21645c88ac408e [diff]

tdf#120394: DOCX list import: simplify zero width space hack

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91286] FILESAVE xlsx Image duplicate after export

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91286

NISZ LibreOffice Team  changed:

   What|Removed |Added

 CC||libreoff...@nisz.hu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||8535

--- Comment #6 from NISZ LibreOffice Team  ---
Still happens in

Version: 7.1.0.0.alpha0+ (x64)
Build ID: dda71436b8594fb0669b3ac06c02a3997a0674be
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118535] FILESAVE DOCX Writer saves images anchored to header/footer multiple times

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118535

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=91
   ||286

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137199] FILESAVE: DOCX to ODT Static text in numbered list is lost

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137199

Timur  changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All
Version|7.0.1.2 release |7.0.0.0.beta1+
 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137199] FILESAVE: DOCX to ODT Static text in numbered list is lost

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137199

Timur  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||6883
 CC||vasily.melenc...@cib.de

--- Comment #5 from Timur  ---
Repro 7.1+
Bibisect 7.0: there were changes: a) -> a. -> a 

a) -> a.
commit 290aa630be3962fa06811ad5a4c5532122e33573
Date:   Mon Apr 27 22:42:10 2020 +0200
source sha:7459b9ecb54a298f02d19089620149718f8d8d48
previous source sha:4ba179eb9208185406207522e39626327c7d74c3

commit  7459b9ecb54a298f02d19089620149718f8d8d48[log]
author  Vasily Melenchuk   Mon Apr 13 11:06:29
2020 +0300
committer   Thorsten Behrens   Mon Apr 27
22:36:12 2020 +0200
tree8e26f751e26b4e4f7ca53d36d6c94603d096650c
parent  4ba179eb9208185406207522e39626327c7d74c3 [diff]

tdf#116883: sw: support for lists level format string

CC: Vasily, please take a look.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: chart2/source

2020-10-02 Thread Balazs Varga (via logerrit)
 chart2/source/controller/main/ChartController_Position.cxx |   16 ++---
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 17b0eb43ac23cd82a06d54432a0ec22cffa5b3c7
Author: Balazs Varga 
AuthorDate: Thu Oct 1 11:29:26 2020 +0200
Commit: László Németh 
CommitDate: Fri Oct 2 16:42:20 2020 +0200

tdf#137165 chart2: fix label position in Position and Size

dialog window.

Follow-up of commit 4223ff2be69f03e571464b0b09ad0d278918631b
(tdf#48436 Chart: add CustomLabelPosition UNO API property).

Change-Id: Ie676af7b9438b928041a404fb1efac6919b30030
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103750
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/chart2/source/controller/main/ChartController_Position.cxx 
b/chart2/source/controller/main/ChartController_Position.cxx
index 32c4bd78522e..52664c356257 100644
--- a/chart2/source/controller/main/ChartController_Position.cxx
+++ b/chart2/source/controller/main/ChartController_Position.cxx
@@ -114,11 +114,6 @@ void 
ChartController::executeDispatch_PositionAndSize(const ::css::uno::Sequence
 if( aCID.isEmpty() )
 return;
 
-awt::Size aSelectedSize;
-ExplicitValueProvider* pProvider( 
comphelper::getUnoTunnelImplementation( m_xChartView ) );
-if( pProvider )
-aSelectedSize = ToSize( pProvider->getRectangleOfObject( aCID ) );
-
 ObjectType eObjectType = ObjectIdentifier::getObjectType( aCID );
 
 UndoGuard aUndoGuard(
@@ -181,8 +176,13 @@ void 
ChartController::executeDispatch_PositionAndSize(const ::css::uno::Sequence
 
 if(pOutItemSet || pArgs)
 {
-awt::Rectangle aObjectRect;
-lcl_getPositionAndSizeFromItemSet( aItemSet, aObjectRect, 
aSelectedSize );
+awt::Rectangle aOldObjectRect;
+ExplicitValueProvider* 
pProvider(comphelper::getUnoTunnelImplementation( 
m_xChartView ));
+if( pProvider )
+aOldObjectRect = pProvider->getRectangleOfObject(aCID);
+
+awt::Rectangle aNewObjectRect;
+lcl_getPositionAndSizeFromItemSet( aItemSet, aNewObjectRect, 
ToSize(aOldObjectRect) );
 awt::Size aPageSize( ChartModelHelper::getPageSize( getModel() ) );
 awt::Rectangle aPageRect( 0,0,aPageSize.Width,aPageSize.Height );
 
@@ -194,7 +194,7 @@ void ChartController::executeDispatch_PositionAndSize(const 
::css::uno::Sequence
 }
 
 bool bMoved = PositionAndSizeHelper::moveObject( 
m_aSelection.getSelectedCID(), getModel()
-, aObjectRect, awt::Rectangle(), aPageRect );
+, aNewObjectRect, aOldObjectRect, aPageRect );
 if( bMoved || bChanged )
 aUndoGuard.commit();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137209] gtk3: "New Address List" dialog gets broken

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137209

--- Comment #1 from Stephan Bergmann  ---
(In reply to Stephan Bergmann from comment #0)
> Originally reported as
>  132#issuecomment-702745904> "LibreOffice won't customize the mail merge
> menu."  Can reproduce on Linux with SAL_USE_VCLPLUGIN=gen with all of
[...]

can reproduce with SAL_USE_VCLPLUGIN=gtk3, I mean

> Works fine at least with SAL_USE_VCLPLUGIN=gen and SAL_USE_VCLPLUGIN=qt5 in
> my local build.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/qa

2020-10-02 Thread Xisco Fauli (via logerrit)
 sc/qa/uitest/calc_tests/data/chartArea.ods |binary
 sc/qa/uitest/chart/chartTitles.py  |   42 +
 2 files changed, 42 insertions(+)

New commits:
commit ec932755543a548f6d07d2909e5f18aff1c20cfd
Author: Xisco Fauli 
AuthorDate: Fri Oct 2 12:33:34 2020 +0200
Commit: Xisco Fauli 
CommitDate: Fri Oct 2 16:41:54 2020 +0200

uitest: sc: test chart title moves with arrow keys

Reuse one file with a chart for this test.
I just added a title to the chart

Change-Id: If73394026350c375059feb1635a7c85c0ecc150d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103831
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/calc_tests/data/chartArea.ods 
b/sc/qa/uitest/calc_tests/data/chartArea.ods
index c7cead1a5917..d7f863c31ed4 100644
Binary files a/sc/qa/uitest/calc_tests/data/chartArea.ods and 
b/sc/qa/uitest/calc_tests/data/chartArea.ods differ
diff --git a/sc/qa/uitest/chart/chartTitles.py 
b/sc/qa/uitest/chart/chartTitles.py
index c6c2488bcadc..1e3ac564ffd6 100644
--- a/sc/qa/uitest/chart/chartTitles.py
+++ b/sc/qa/uitest/chart/chartTitles.py
@@ -7,6 +7,7 @@
 from uitest.framework import UITestCase
 from uitest.uihelper.common import get_state_as_dict
 from uitest.uihelper.common import select_pos
+from uitest.uihelper.common import change_measurement_unit
 from uitest.uihelper.calc import enter_text_to_cell
 from libreoffice.calc.document import get_cell_by_position
 from libreoffice.uno.propertyvalue import mkPropertyValues
@@ -94,5 +95,46 @@ class chartTitles(UITestCase):
 xOKBtn = xDialog.getChild("ok")
 self.ui_test.close_dialog_through_button(xOKBtn)
 
+self.ui_test.close_doc()
+
+   def test_title_move_with_arrows_keys(self):
+
+calc_doc = self.ui_test.load_file(get_url_for_data_file("chartArea.ods"))
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+
+change_measurement_unit(self, "Centimeter")
+
+gridwin.executeAction("SELECT", mkPropertyValues({"OBJECT": "Object 1"}))
+gridwin.executeAction("ACTIVATE", tuple())
+xChartMainTop = self.xUITest.getTopFocusWindow()
+xChartMain = xChartMainTop.getChild("chart_window")
+
+# Select the title
+xTitle = xChartMain.getChild("CID/Title=")
+xTitle.executeAction("SELECT", tuple())
+
+self.ui_test.execute_dialog_through_action(xTitle, "COMMAND", 
mkPropertyValues({"COMMAND": "TransformDialog"}))
+
+xDialog = self.xUITest.getTopFocusWindow()
+self.assertEqual("3.52", 
get_state_as_dict(xDialog.getChild("MTR_FLD_POS_X"))['Value'])
+self.assertEqual("0.3", 
get_state_as_dict(xDialog.getChild("MTR_FLD_POS_Y"))['Value'])
+
+xOkBtn = xDialog.getChild("ok")
+xOkBtn.executeAction("CLICK", tuple())
+
+xChartMain.executeAction("TYPE", mkPropertyValues({"KEYCODE": "UP"}))
+xChartMain.executeAction("TYPE", mkPropertyValues({"KEYCODE": "LEFT"}))
+
+self.ui_test.execute_dialog_through_action(xTitle, "COMMAND", 
mkPropertyValues({"COMMAND": "TransformDialog"}))
+
+# Check the position has changed after moving the title using the arrows 
keys
+xDialog = self.xUITest.getTopFocusWindow()
+self.assertEqual("3.42", 
get_state_as_dict(xDialog.getChild("MTR_FLD_POS_X"))['Value'])
+self.assertEqual("0.2", 
get_state_as_dict(xDialog.getChild("MTR_FLD_POS_Y"))['Value'])
+
+xOkBtn = xDialog.getChild("ok")
+xOkBtn.executeAction("CLICK", tuple())
+
 self.ui_test.close_doc()
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/qa

2020-10-02 Thread Xisco Fauli (via logerrit)
 sc/qa/uitest/chart/chartTitles.py |   16 
 1 file changed, 16 insertions(+)

New commits:
commit 40de76681c47fb6561a5a236a46114355a5f5072
Author: Xisco Fauli 
AuthorDate: Fri Oct 2 12:14:36 2020 +0200
Commit: Xisco Fauli 
CommitDate: Fri Oct 2 16:41:05 2020 +0200

uitest: chartTitles.py: assert changes in chart

Change-Id: If6f0fdf6b26f09f467a0226468f6f00e885c4f41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103830
Tested-by: Jenkins
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/chart/chartTitles.py 
b/sc/qa/uitest/chart/chartTitles.py
index 8b500ccba3e0..c6c2488bcadc 100644
--- a/sc/qa/uitest/chart/chartTitles.py
+++ b/sc/qa/uitest/chart/chartTitles.py
@@ -27,6 +27,13 @@ class chartTitles(UITestCase):
 gridwin = xCalcDoc.getChild("grid_window")
 document = self.ui_test.get_component()
 
+xCS = 
document.Sheets[0].Charts[0].getEmbeddedObject().FirstDiagram.CoordinateSystems[0]
+
+
self.assertFalse(document.Sheets[0].Charts[0].getEmbeddedObject().HasMainTitle)
+
self.assertFalse(document.Sheets[0].Charts[0].getEmbeddedObject().HasSubTitle)
+self.assertIsNone(xCS.getAxisByDimension(0, 0).TitleObject)
+self.assertIsNone(xCS.getAxisByDimension(1, 0).TitleObject)
+
 gridwin.executeAction("SELECT", mkPropertyValues({"OBJECT": "Object 1"}))
 gridwin.executeAction("ACTIVATE", tuple())
 xChartMainTop = self.xUITest.getTopFocusWindow()
@@ -52,6 +59,15 @@ class chartTitles(UITestCase):
 xOKBtn = xDialog.getChild("ok")
 self.ui_test.close_dialog_through_button(xOKBtn)
 
+
self.assertTrue(document.Sheets[0].Charts[0].getEmbeddedObject().HasMainTitle)
+
self.assertTrue(document.Sheets[0].Charts[0].getEmbeddedObject().HasSubTitle)
+self.assertEqual("A", 
document.Sheets[0].Charts[0].getEmbeddedObject().Title.String)
+self.assertEqual("B", 
document.Sheets[0].Charts[0].getEmbeddedObject().SubTitle.String)
+self.assertEqual("C", xCS.getAxisByDimension(0, 
0).TitleObject.Text[0].String)
+self.assertEqual("D", xCS.getAxisByDimension(1, 
0).TitleObject.Text[0].String)
+self.assertEqual("E", xCS.getAxisByDimension(0, 
1).TitleObject.Text[0].String)
+self.assertEqual("F", xCS.getAxisByDimension(1, 
1).TitleObject.Text[0].String)
+
 #reopen and verify InsertMenuTitles dialog
 gridwin.executeAction("SELECT", mkPropertyValues({"OBJECT": "Object 1"}))
 gridwin.executeAction("ACTIVATE", tuple())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: config_host/config_locales.h.in extras/CustomTarget_autocorr.mk extras/Package_autocorr.mk extras/source i18npool/CustomTarget_collator.mk i18npool/Library_localedata_e

2020-10-02 Thread Mihkel Tõnnov (via logerrit)
 config_host/config_locales.h.in   |1 
 extras/CustomTarget_autocorr.mk   |3 
 extras/Package_autocorr.mk|1 
 extras/source/autocorr/lang/vro/DocumentList.xml  |2 
 extras/source/autocorr/lang/vro/META-INF/manifest.xml |5 
 i18npool/CustomTarget_collator.mk |2 
 i18npool/Library_localedata_euro.mk   |1 
 i18npool/source/collator/collator_unicode.cxx |   10 
 i18npool/source/collator/data/vro_alphanumeric.txt|   73 ++
 i18npool/source/localedata/data/vro_EE.xml|  448 ++
 i18npool/source/localedata/localedata.cxx |1 
 11 files changed, 547 insertions(+)

New commits:
commit 568ee718bb217f4ecbebc962557ef659b9f6e624
Author: Mihkel Tõnnov 
AuthorDate: Mon Sep 21 19:56:30 2020 +0200
Commit: Eike Rathke 
CommitDate: Fri Oct 2 16:39:32 2020 +0200

tdf#136951: Add Võro (vro-EE) locale data and rudimentary autocorrect list

Change-Id: Id5a5d71b7f457d18b9d0982f9b4df95566c09be9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103122
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/config_host/config_locales.h.in b/config_host/config_locales.h.in
index a5f1e65b7dbe..b9b6988cc891 100644
--- a/config_host/config_locales.h.in
+++ b/config_host/config_locales.h.in
@@ -49,6 +49,7 @@
 #define WITH_LOCALE_th 0
 #define WITH_LOCALE_tr 0
 #define WITH_LOCALE_uk 0
+#define WITH_LOCALE_vro 0
 #define WITH_LOCALE_zh 0
 
 #define WITH_LOCALE_FOR_SCRIPT_Cyrl 0
diff --git a/extras/CustomTarget_autocorr.mk b/extras/CustomTarget_autocorr.mk
index 63165f267f52..8ac2dd86502a 100644
--- a/extras/CustomTarget_autocorr.mk
+++ b/extras/CustomTarget_autocorr.mk
@@ -55,6 +55,7 @@ extras_AUTOCORR_LANGS := \
sv:sv-SE \
tr:tr-TR \
vi:vi-VN \
+   vro:vro-EE \
zh-CN:zh-CN \
zh-TW:zh-TW \
 
@@ -224,6 +225,8 @@ extras_AUTOCORR_XMLFILES := \
vi/DocumentList.xml \
vi/META-INF/manifest.xml \
vi/WordExceptList.xml \
+   vro/DocumentList.xml \
+   vro/META-INF/manifest.xml \
zh-CN/DocumentList.xml \
zh-CN/META-INF/manifest.xml \
zh-CN/SentenceExceptList.xml \
diff --git a/extras/Package_autocorr.mk b/extras/Package_autocorr.mk
index 877b26b5a235..cc14860637ee 100644
--- a/extras/Package_autocorr.mk
+++ b/extras/Package_autocorr.mk
@@ -55,6 +55,7 @@ $(eval $(call 
gb_Package_add_files,extras_autocorr,$(LIBO_SHARE_FOLDER)/autocorr
acor_sv-SE.dat \
acor_tr-TR.dat \
acor_vi-VN.dat \
+   acor_vro-EE.dat \
acor_zh-CN.dat \
acor_zh-TW.dat \
 ))
diff --git a/extras/source/autocorr/lang/vro/DocumentList.xml 
b/extras/source/autocorr/lang/vro/DocumentList.xml
new file mode 100644
index ..81ff2ece1f55
--- /dev/null
+++ b/extras/source/autocorr/lang/vro/DocumentList.xml
@@ -0,0 +1,2 @@
+
+http://openoffice.org/2001/block-list;>
\ No newline at end of file
diff --git a/extras/source/autocorr/lang/vro/META-INF/manifest.xml 
b/extras/source/autocorr/lang/vro/META-INF/manifest.xml
new file mode 100644
index ..bd8de6e3524c
--- /dev/null
+++ b/extras/source/autocorr/lang/vro/META-INF/manifest.xml
@@ -0,0 +1,5 @@
+
+
+ 
+ 
+
\ No newline at end of file
diff --git a/extras/source/autocorr/lang/vro/mimetype 
b/extras/source/autocorr/lang/vro/mimetype
new file mode 100644
index ..e69de29bb2d1
diff --git a/i18npool/CustomTarget_collator.mk 
b/i18npool/CustomTarget_collator.mk
index 2e64e2043dce..4cf7b953573f 100644
--- a/i18npool/CustomTarget_collator.mk
+++ b/i18npool/CustomTarget_collator.mk
@@ -36,6 +36,8 @@ i18npool_COTXTS := \
 ne_charset.txt) \
 $(call gb_Helper_optional_locale,sid, \
 sid_charset.txt) \
+$(call gb_Helper_optional_locale,vro, \
+vro_alphanumeric.txt) \
 $(call gb_Helper_optional_locale,zh, \
 zh_charset.txt \
 zh_pinyin.txt \
diff --git a/i18npool/Library_localedata_euro.mk 
b/i18npool/Library_localedata_euro.mk
index 5a110bbe03fd..14909ac59539 100644
--- a/i18npool/Library_localedata_euro.mk
+++ b/i18npool/Library_localedata_euro.mk
@@ -104,6 +104,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,localedata_euro,\
CustomTarget/i18npool/localedata/localedata_tt_RU \
CustomTarget/i18npool/localedata/localedata_uk_UA \
CustomTarget/i18npool/localedata/localedata_vec_IT \
+   CustomTarget/i18npool/localedata/localedata_vro_EE \
CustomTarget/i18npool/localedata/localedata_wa_BE \
 ))
 
diff --git a/i18npool/source/collator/collator_unicode.cxx 
b/i18npool/source/collator/collator_unicode.cxx
index 39037cf2e77b..c05a9cb025c6 100644
--- a/i18npool/source/collator/collator_unicode.cxx
+++ b/i18npool/source/collator/collator_unicode.cxx
@@ -80,6 +80,7 @@ const sal_uInt8* get_collator_data_ln_charset();
 const sal_uInt8* 

[Libreoffice-bugs] [Bug 137209] New: gtk3: "New Address List" dialog gets broken

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137209

Bug ID: 137209
   Summary: gtk3: "New Address List" dialog gets broken
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sberg...@redhat.com
CC: caol...@redhat.com

Originally reported as

"LibreOffice won't customize the mail merge menu."  Can reproduce on Linux with
SAL_USE_VCLPLUGIN=gen with all of Flathub's LO 7.0.1.2 flatpak,
libreoffice-6.4.6.2-1.fc32.x86_64, and a recent local build of master towards
LO 7.1:  "File - New - Text Document", "Tools - Mail Merge Wizard... - Insert
Address Block - Select Different Address List... - Create... - Customize...",
select "Company Name" element, "Delete - OK": "New Address List" dialog starts
to extend past the bottom of the screen, labels on the left are garbled, all
edit fields but the final "Gender" refuse to take focus (also see the original
report's ).

Works fine at least with SAL_USE_VCLPLUGIN=gen and SAL_USE_VCLPLUGIN=qt5 in my
local build.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105584] [META] Calc image bugs and enhancements

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105584
Bug 105584 depends on bug 88592, which changed state.

Bug 88592 Summary: VIEWING: Green display bug;picture with zero width [xlsx]
https://bugs.documentfoundation.org/show_bug.cgi?id=88592

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88592] VIEWING: Green display bug; picture with zero width [xlsx]

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88592

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||noelgran...@gmail.com
 Status|NEW |RESOLVED

--- Comment #16 from NISZ LibreOffice Team  ---
@Noel Grandin thanks for fixing this one :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137199] FILESAVE: DOCX to ODT Static text in numbered list is lost

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137199

Timur  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Timur  ---
Nice report. A song for you: 
https://www.youtube.com/watch?v=jBH-PaDzg7U

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88592] VIEWING: Green display bug; picture with zero width [xlsx]

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88592

--- Comment #15 from NISZ LibreOffice Team  ---
Created attachment 166039
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166039=edit
The example file in Calc 6.3 and 6.2

No longer happens in 6.3.0 and newer, since:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=d0119ff7f2c68aa05286bd303128f3a69c6bbd6a

author  Noel Grandin 2019-05-06 11:33:41 +0200
committer   Thorsten Behrens   2019-05-08
12:42:53 +0200

improve tools::Rectangle->basegfx::B2?Rectangle conversion

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137208] New: osl_getModuleURLFromAddress returns false if getcwd returns an error

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137208

Bug ID: 137208
   Summary: osl_getModuleURLFromAddress returns false if getcwd
returns an error
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: sdk
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: marc-oliver.str...@advantest.com

We had a crash when bootstrapping UNO because someone removed the current
working directory.
Stacktrace:
SEGV
libuno_cppu.so.3(uno_getMapping+0x178)[0x743372c8]
libuno_cppuhelpergcc3.so.3(+0x64dea)[0x74bbadea]
libuno_cppuhelpergcc3.so.3(_ZN4cppu40defaultBootstrap_InitialComponentContextERKN3rtl8OUStringE+0x6f9)[0x74b993b9]

uno_getMapping crashed due to aFrom, aTo being nullptr, caused by
osl_getModuleURLFromAddress always returning false - so no module could be
loaded.

osl_getModuleURLFromAddress called osl_getProcessWorkingDir(workDir), which
returned a nullptr as workDir because the current working dir had been deleted.
This caused osl_getModureURLFromAddress to return false, even though the module
path (as returned by getModulePathFromAddress) was an absolute path.

To improve robustness against such (accidental) work directory removals, I
suggest osl_getModuleURLFromAddress to not check the current working directory
at all, but to delegate checking of the working dir to
osl_getAbsoluteFileURL(...), once the given path is detected to be a relative
path.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115709
Bug 115709 depends on bug 136850, which changed state.

Bug 136850 Summary: FILEOPEN DOCX Changes in floating table accepted if 
structure was changed
https://bugs.documentfoundation.org/show_bug.cgi?id=136850

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/qa writerfilter/source

2020-10-02 Thread László Németh (via logerrit)
 sw/qa/extras/ooxmlexport/data/tdf136850.docx  |binary
 sw/qa/extras/ooxmlexport/ooxmlexport11.cxx|7 +++
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   18 --
 3 files changed, 23 insertions(+), 2 deletions(-)

New commits:
commit c37f2b927715ebbeffcc1d7a1e9d646f1611c4ec
Author: László Németh 
AuthorDate: Fri Oct 2 12:55:04 2020 +0200
Commit: László Németh 
CommitDate: Fri Oct 2 16:24:32 2020 +0200

tdf#136850 DOCX: fix change tracking in floating tables

Deleted text still reappeared as normal text in floating
tables in the case of combination with tracked paragraph
property changes.

Follow-up of commit 288db6eb47fbbd2b3ca34ffea0686d8ed8ed9be9
(tdf#132271 DOCX: import change tracking in floating tables)
and commit 464a7b0631335a8f8729512b8c27f864747f56a7
(tdf#136667 DOCX import: fix crash of floating tables).

Change-Id: I2c8f63054520ce28306c063ef638756f7d8342e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103832
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf136850.docx 
b/sw/qa/extras/ooxmlexport/data/tdf136850.docx
new file mode 100644
index ..e94a66208e0d
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf136850.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
index e7b996562803..e45d99c6d2d7 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
@@ -998,6 +998,13 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf136667, 
"tdf136667.docx")
 assertXPath(pXmlDoc, "//w:ins", 4);
 }
 
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf136850, "tdf136850.docx")
+{
+xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
+// import change tracking in floating tables
+assertXPath(pXmlDoc, "//w:del");
+}
+
 DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf128156, "tdf128156.docx")
 {
 xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index cd985e4fd995..cd78ab36bd0a 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -6809,11 +6809,12 @@ void DomainMapper_Impl::ExecuteFrameConversion()
 {
 if( m_xFrameStartRange.is() && m_xFrameEndRange.is() && 
!m_bDiscardHeaderFooter )
 {
+std::vector redPos, redLen;
 try
 {
 uno::Reference< text::XTextAppendAndConvert > 
xTextAppendAndConvert( GetTopTextAppend(), uno::UNO_QUERY_THROW );
 // convert redline ranges to cursor movement and character length
-std::vector redPos, redLen;
+
 for( size_t i = 0; i < aFramedRedlines.size(); i+=3)
 {
 uno::Reference< text::XTextRange > xRange;
@@ -6863,7 +6864,20 @@ void DomainMapper_Impl::ExecuteFrameConversion()
 }
 
 m_bIsActualParagraphFramed = false;
-aFramedRedlines.clear();
+
+if (redPos.size() == aFramedRedlines.size()/3)
+{
+for( sal_Int32 i = aFramedRedlines.size() - 1; i >= 0; --i)
+{
+// keep redlines of floating tables to process them in 
CloseSectionGroup()
+if ( redPos[i/3] != -1 )
+{
+aFramedRedlines.erase(aFramedRedlines.begin() + i);
+}
+}
+}
+else
+aFramedRedlines.clear();
 }
 m_xFrameStartRange = nullptr;
 m_xFrameEndRange = nullptr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137200] Changing font for whole document using styles impossible

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137200

Timur  changed:

   What|Removed |Added

 Resolution|WONTFIX |NOTABUG

--- Comment #6 from Timur  ---
https://help.libreoffice.org/7.1/en-US/text/shared/optionen/01040300.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137200] Changing font for whole document using styles impossible

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137200

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|NOTABUG |WONTFIX
   Severity|normal  |enhancement

--- Comment #5 from V Stuart Foote  ---
Poof --> Enhancement.

And a straight => WONTFIX

Sorry.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137200] Changing font for whole document using styles impossible

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137200

--- Comment #4 from Paul Menzel 
 ---
Thank you for the detailed response. I think we misunderstand each other.

>From my point of view, you proved my point, that all the ways you described are
too complicated for normal users, like my grandparents, parents or non-computer
wizards. So, this report is a *feature request* to provide an *easy* way to set
a default font for a document.

I normally have the defaults, but one organization has a corporate style guide
requiring one font. Now, creating a document for that organization, and before
distributing it, I’d like to set the font required by the style guide as the
font for *only* that document.

It’s possible in principle, as the default font for LibreOffice Writer can be
changed in the options. That font is correctly set up for a document. Now, I’d
like to have a way to do just that for one document without having to create a
dedicated template or changing all styles.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: svx/source

2020-10-02 Thread Tomaž Vajngerl (via logerrit)
 svx/source/table/tablecontroller.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit e31474d71235bccee8568c4a952a8319bddf39e0
Author: Tomaž Vajngerl 
AuthorDate: Fri Oct 2 12:02:42 2020 +0200
Commit: Tomaž Vajngerl 
CommitDate: Fri Oct 2 16:05:56 2020 +0200

rearrange to not use pUndoObject after std::move

pGeoUndo is always nullptr in this case because of std::move, so
the SetSkipChangeLayout is never set.

Issue since: https://gerrit.libreoffice.org/c/core/+/78201

Change-Id: I4f1dcb3a25adeb0737e03aa9e9dfb193969250b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103827
Reviewed-by: Tomaž Vajngerl 
Tested-by: Tomaž Vajngerl 

diff --git a/svx/source/table/tablecontroller.cxx 
b/svx/source/table/tablecontroller.cxx
index b28522619bc6..f61ea7605567 100644
--- a/svx/source/table/tablecontroller.cxx
+++ b/svx/source/table/tablecontroller.cxx
@@ -1534,11 +1534,12 @@ void SvxTableController::changeTableEdge(const 
SfxRequest& rReq)
 {
 auto pUndoObject = 
rModel.GetSdrUndoFactory().CreateUndoGeoObject(rTableObj);
 rModel.BegUndo(pUndoObject->GetComment());
-rModel.AddUndo(std::move(pUndoObject));
 
 auto* pGeoUndo = static_cast(pUndoObject.get());
 if (pGeoUndo)
 pGeoUndo->SetSkipChangeLayout(true);
+
+rModel.AddUndo(std::move(pUndoObject));
 }
 tools::Rectangle aBoundRect;
 if (rTableObj.GetUserCall())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137207] there is no project container for combination of all LO-formats, odm is limited to writer

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137207

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
I disagree with this idea and don't see any problem with current file
extensions by its modules

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 137207] there is no project container for combination of all LO-formats, odm is limited to writer

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137207

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
I disagree with this idea and don't see any problem with current file
extensions by its modules

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 137204] LibreOffice 7.0

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137204

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from V Stuart Foote  ---
Nothing actionable in this BZ issue, smells like an erroneous submission.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137200] Changing font for whole document using styles impossible

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137200

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 CC||vstuart.fo...@utsa.edu
 Status|REOPENED|RESOLVED

--- Comment #3 from V Stuart Foote  ---
Sorry, Timur was correct if not overly polite.

Changes depend on object inheritence, and the autoupdate setting for the object
type. Text runs on document canvas are all Paragraph objects.

Documents are constructed from standard template defaults generating default
styles for the various document objects. Where inheritance is set for a style,
you may change the parent and have it affect the child, but it will only apply
if the autoupdate value is checked enabled. 

Otherwise you must modify the defaults then save to a template document and
apply that new template to the document you want to change.

Of course you can Directly Format the objects, overriding their style(s). Or
even edit the final ODF archive and directly edit the Font assignments in the
content.xml

And finally you can select all content remove its formatting, and apply a
single paragraph style to it, even the Default paragraph --but that will
clobber your layout.

Tools are there, Read the Manual

=> NAB

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/qa

2020-10-02 Thread Luboš Luňák (via logerrit)
 vcl/qa/cppunit/BackendTest.cxx |   15 +--
 1 file changed, 13 insertions(+), 2 deletions(-)

New commits:
commit 5ae845923499422540632456f1dafefa3ad49f4f
Author: Luboš Luňák 
AuthorDate: Mon Sep 28 16:05:38 2020 +0200
Commit: Luboš Luňák 
CommitDate: Fri Oct 2 15:43:14 2020 +0200

opt-out from checking vclbackendtest failures rather than opt-in

So that the default is checking, and if a VCL backend doesn't work
correctly (which is most of them now), then that should need
special-casing.

Change-Id: If55b09cfd64abe5f0efd798d91c303936ec0989b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103785
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/qa/cppunit/BackendTest.cxx b/vcl/qa/cppunit/BackendTest.cxx
index 1342c3a5ade9..ff495b10c1de 100644
--- a/vcl/qa/cppunit/BackendTest.cxx
+++ b/vcl/qa/cppunit/BackendTest.cxx
@@ -18,6 +18,7 @@
 
 #include 
 
+// Run tests from visualbackendtest ('bin/run visualbackendtest').
 class BackendTest : public test::BootstrapFixture
 {
 // if enabled - check the result images with:
@@ -72,16 +73,26 @@ public:
 // This ensures that all backends return a valid name.
 assert(!name.isEmpty());
 (void)name;
-return false;
+return true;
 }
 
 // Check whether tests should fail depending on which backend is used
 // (not all work). If you want to disable just a specific test
 // for a specific backend, use something like
 // 'if(SHOULD_ASSERT && aOutDevTest.getRenderBackendName() != "skia")'.
+// The macro uses opt-out rather than opt-in so that this doesn't "pass"
+// silently in case a new backend is added.
 #define SHOULD_ASSERT  
\
 (assertBackendNameNotEmpty(aOutDevTest.getRenderBackendName()) 
\
- || aOutDevTest.getRenderBackendName() == "skia")
+ && aOutDevTest.getRenderBackendName() != "svp"
\
+ && aOutDevTest.getRenderBackendName() != "opengl" 
\
+ && aOutDevTest.getRenderBackendName() != "qt5"
\
+ && aOutDevTest.getRenderBackendName() != "qt5svp" 
\
+ && aOutDevTest.getRenderBackendName() != "gtk3svp"
\
+ && aOutDevTest.getRenderBackendName() != "aqua"   
\
+ && aOutDevTest.getRenderBackendName() != "gen"
\
+ && aOutDevTest.getRenderBackendName() != "genpsp" 
\
+ && aOutDevTest.getRenderBackendName() != "win")
 
 void testDrawRectWithRectangle()
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/skia

2020-10-02 Thread Luboš Luňák (via logerrit)
 vcl/skia/gdiimpl.cxx |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 5acdb23a413ce82a279eb4fee0ddf867e989fec8
Author: Luboš Luňák 
AuthorDate: Tue Sep 29 19:33:08 2020 +0200
Commit: Luboš Luňák 
CommitDate: Fri Oct 2 15:42:48 2020 +0200

cache Skia bitmaps if they are small but to be scaled

In raster mode this still may cost a bit, especially with code
that paints the same bitmap repeatedly to create tiling.

Change-Id: I0b65414b418f96a8b1620c8487562b61bd87c221
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103783
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
index b6ffda221424..e194ba964c58 100644
--- a/vcl/skia/gdiimpl.cxx
+++ b/vcl/skia/gdiimpl.cxx
@@ -1491,9 +1491,8 @@ sk_sp 
SkiaSalGraphicsImpl::mergeCacheBitmaps(const SkiaSalBitmap& bitma
 // Probably not much point in caching of just doing a copy.
 if (alphaBitmap == nullptr && targetSize == bitmap.GetSize())
 return image;
-// Image too small to be worth caching.
-if (bitmap.GetSize().Width() < 100 && bitmap.GetSize().Height() < 100
-&& targetSize.Width() < 100 && targetSize.Height() < 100)
+// Image too small to be worth caching if not scaling.
+if (targetSize == bitmap.GetSize() && targetSize.Width() < 100 && 
targetSize.Height() < 100)
 return image;
 // In some cases (tdf#134237) the target size may be very large. In that 
case it's
 // better to rely on Skia to clip and draw only the necessary, rather than 
prepare
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: include/vcl

2020-10-02 Thread Luboš Luňák (via logerrit)
 include/vcl/BitmapAlphaClampFilter.hxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e9ecdfc758280189760d50ed2dfe454d3f83a0ea
Author: Luboš Luňák 
AuthorDate: Fri Oct 2 11:07:10 2020 +0200
Commit: Luboš Luňák 
CommitDate: Fri Oct 2 15:41:46 2020 +0200

fix header guard

Change-Id: I01e21c5ed1ffae27394ddb2b63a8c590f81325d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103824
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/include/vcl/BitmapAlphaClampFilter.hxx 
b/include/vcl/BitmapAlphaClampFilter.hxx
index c8b111d931d1..6926c3274e6b 100644
--- a/include/vcl/BitmapAlphaClampFilter.hxx
+++ b/include/vcl/BitmapAlphaClampFilter.hxx
@@ -8,8 +8,8 @@
  *
  */
 
-#ifndef INCLUDED_INCLUDE_VCL_BITMAPMONOCHROMEFILTER_HXX
-#define INCLUDED_INCLUDE_VCL_BITMAPMONOCHROMEFILTER_HXX
+#ifndef INCLUDED_INCLUDE_VCL_BITMAPALPHACLAMPFILTER_HXX
+#define INCLUDED_INCLUDE_VCL_BITMAPALPHACLAMPFILTER_HXX
 
 #include 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 136238] Deleting a very very large cross page table (26 pages) very very slow

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136238

--- Comment #9 from Xisco Faulí  ---
(In reply to Jean-Baptiste Faure from comment #8)
> (In reply to Commit Notification from comment #7)
> > Xisco Fauli committed a patch related to this issue.
> > It has been pushed to "libreoffice-7-0":
> > 
> > https://git.libreoffice.org/core/commit/
> > 3d6c7523aea5c2820f26c33688b2c9a767affc6b
> > 
> > tdf#136728: Revert "tdf#136238 speed up deleting large cross page table"
> > 
> 
> What is the reason of this revert ?
> 
> Best regards. JBF

tdf#136728

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136238] Deleting a very very large cross page table (26 pages) very very slow

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136238

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org

--- Comment #8 from Jean-Baptiste Faure  ---
(In reply to Commit Notification from comment #7)
> Xisco Fauli committed a patch related to this issue.
> It has been pushed to "libreoffice-7-0":
> 
> https://git.libreoffice.org/core/commit/
> 3d6c7523aea5c2820f26c33688b2c9a767affc6b
> 
> tdf#136728: Revert "tdf#136238 speed up deleting large cross page table"
> 

What is the reason of this revert ?

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 137207] there is no project container for combination of all LO-formats, odm is limited to writer

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137207

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||rb.hensc...@t-online.de,
   ||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
Thank you for the suggestion.

LibreOffice is OASIS ODF standards driven. ODF Master documents are provided
for in the ODF 1.2/1.3 standard.

You can already insert content from any LO module as OLE object into any
subdocument.

And no single moudule other than Writer benefits from the organization
complexity that the Writer centric ODF Master document provides.

IMHO => WF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 34940] EDITING: Start on click not added correctly to movies

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=34940

--- Comment #34 from Your Prince  ---
Excellent publish, very informative. I ponder why the opposite experts of this
sector don’t realize this. You should continue your writing. I’m confident, you
have got a great readers’ base already!

https://mstwotoes.com/fzmovies-latest-hollywood-and-bollywood-movies-free-download-fzmovies-net/
https://mstwotoes.com/o2tvseries-o2tvseries-download-free-o2tv-movies-download/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137207] there is no project container for combination of all LO-formats, odm is limited to writer

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137207

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||rb.hensc...@t-online.de,
   ||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
Thank you for the suggestion.

LibreOffice is OASIS ODF standards driven. ODF Master documents are provided
for in the ODF 1.2/1.3 standard.

You can already insert content from any LO module as OLE object into any
subdocument.

And no single moudule other than Writer benefits from the organization
complexity that the Writer centric ODF Master document provides.

IMHO => WF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129492] Similarity search not clear

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129492

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 CC||er...@redhat.com,
   ||sdc.bla...@youmail.dk

--- Comment #2 from sdc.bla...@youmail.dk ---
(In reply to Eike Rathke from comment #1)
> Maybe this can shed some light:
...but not enough.

Was going to try to improve, but not sure I understand completely.

If "Combine" is UNchecked in the Similarity Search dialog, then what happens?
(i.e., how is it different from when Combine is checked?)

(the source code says EITHER, does that mean that each parameter is used
exactly for a match  (which in everyday thinking sounds like "combine")

The mathematical explanation of relaxed WLD sounds like what one would expect 
(in everyday language use),if the descriptions of each parameter (on the help
page) are Combined. 

(a guess for) Possible text for help page under Combine heading:

"If unchecked, then search matches any item that matches one of the three
parameters.
If checked, then an intelligent combination of the settings for exchange, add,
and remove characters is used."

cc: Eike Rathke

Just curious:  if these interpretations are correct, then it is hard to
understand how checking or unchecking Combine will make a big difference in
practice.  If that naive speculation is completely wrong, then a practical
"tip" about when it is better to choose one or the other would be good (and
could be added to the help page in a "tip" box).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: oox/source

2020-10-02 Thread Caolán McNamara (via logerrit)
 oox/source/drawingml/diagram/diagramlayoutatoms.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a5963ebb46098be9aac32ff3d582255d97521df4
Author: Caolán McNamara 
AuthorDate: Fri Oct 2 08:50:02 2020 +0100
Commit: Caolán McNamara 
CommitDate: Fri Oct 2 15:12:37 2020 +0200

cid#1467667 Division or modulo by float zero

Change-Id: Ia332896190e09d6c5459ce80819c8f1263a60873
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103815
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx 
b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
index d1280406fedb..644c31790d64 100644
--- a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
+++ b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
@@ -321,11 +321,11 @@ void SnakeAlg::layoutShapeChildren(const 
AlgAtom::ParamMap& rMap, const ShapePtr
 awt::Size aCurrSize(aChildSize);
 // aShapeWidths items are a portion of nMaxRowWidth. We want 
the same ratio,
 // based on the original parent width, ignoring the aspect 
ratio request.
-double fWidthFactor = static_cast(aShapeWidths[index]) 
/ nMaxRowWidth;
 bool bWidthsFromConstraints
 = nCount >= 2 && 
rShape->getChildren()[1]->getDataNodeType() == XML_sibTrans;
-if (bWidthsFromConstraints)
+if (bWidthsFromConstraints && nMaxRowWidth)
 {
+double fWidthFactor = 
static_cast(aShapeWidths[index]) / nMaxRowWidth;
 // We can only work from constraints if spacing is 
represented by a real
 // child shape.
 aCurrSize.Width = rShape->getSize().Width * fWidthFactor;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sfx2/source

2020-10-02 Thread Miklos Vajna (via logerrit)
 sfx2/source/view/viewfrm.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 330f26bea4358658ac84b6d87270229fe71deb02
Author: Miklos Vajna 
AuthorDate: Fri Oct 2 12:29:46 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Oct 2 15:09:22 2020 +0200

sfx2: downgrade a warning in SfxViewFrame::ChildWindowState() to info

It happens every time on startup, so it's not that useful.

Change-Id: I570b8892847f2da3dd5b52e150eb7a2802bb407b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103828
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index ccb39350f223..6dc772e0c06e 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -3233,7 +3233,7 @@ void SfxViewFrame::ChildWindowState( SfxItemSet& rState )
 {
 if  ( !KnowsChildWindow( nSID ) )
 {
-SAL_WARN("sfx.view", "SID_SIDEBAR state requested, but no task 
pane child window exists for this ID!");
+SAL_INFO("sfx.view", "SID_SIDEBAR state requested, but no task 
pane child window exists for this ID!");
 rState.DisableItem( nSID );
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 108988] [META] Validity-related bugs and enhancements

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108988

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on||84874


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=84874
[Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with
promptTitle longer than 32 characters.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88175] [META] XLSX (OOXML) format limitations

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88175

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on|84874   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=84874
[Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with
promptTitle longer than 32 characters.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with promptTitle longer than 32 characters.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84874

NISZ LibreOffice Team  changed:

   What|Removed |Added

 CC||libreoff...@nisz.hu
 Blocks|88175   |108988


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=88175
[Bug 88175] [META] XLSX (OOXML) format limitations
https://bugs.documentfoundation.org/show_bug.cgi?id=108988
[Bug 108988] [META] Validity-related bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with promptTitle longer than 32 characters.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84874

--- Comment #16 from NISZ LibreOffice Team  ---
Created attachment 166038
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166038=edit
Example file with 256 character long validation saved as xlsx

This opens just fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with promptTitle longer than 32 characters.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84874

--- Comment #15 from NISZ LibreOffice Team  ---
Created attachment 166037
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166037=edit
Example file with 256 character long validation

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with promptTitle longer than 32 characters.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84874

--- Comment #14 from NISZ LibreOffice Team  ---
Created attachment 166036
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166036=edit
The xlsx with 257 characters long validation messages opened in Excel 13

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with promptTitle longer than 32 characters.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84874

--- Comment #13 from NISZ LibreOffice Team  ---
Created attachment 166035
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166035=edit
Example file as xlsx with 257 character long validation

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2020-10-02 Thread Caolán McNamara (via logerrit)
 sw/source/filter/basflt/fltshell.cxx  |   84 +-
 sw/source/filter/inc/fltshell.hxx |   12 ++--
 sw/source/filter/ww8/writerhelper.cxx |2 
 sw/source/filter/ww8/ww8par.cxx   |   32 ++--
 sw/source/filter/ww8/ww8par.hxx   |   16 +++---
 sw/source/filter/ww8/ww8par5.cxx  |2 
 sw/source/filter/ww8/ww8par6.cxx  |4 -
 7 files changed, 76 insertions(+), 76 deletions(-)

New commits:
commit 792eb7a903b48a6209b2d08dd728dcf9a8096449
Author: Caolán McNamara 
AuthorDate: Thu Oct 1 20:53:10 2020 +0100
Commit: Caolán McNamara 
CommitDate: Fri Oct 2 14:19:32 2020 +0200

SwWW8FltAnchorStack ctor never given a null SwDoc*

and similar

Change-Id: I046be0e41b79f2fd51ebec0da20fccb17d947732
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103823
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/filter/basflt/fltshell.cxx 
b/sw/source/filter/basflt/fltshell.cxx
index ceae383380af..4093ae3999be 100644
--- a/sw/source/filter/basflt/fltshell.cxx
+++ b/sw/source/filter/basflt/fltshell.cxx
@@ -51,14 +51,14 @@
 
 using namespace com::sun::star;
 
-static SwContentNode* GetContentNode(SwDoc* pDoc, SwNodeIndex& rIdx, bool 
bNext)
+static SwContentNode* GetContentNode(SwDoc& rDoc, SwNodeIndex& rIdx, bool 
bNext)
 {
 SwContentNode * pCNd = rIdx.GetNode().GetContentNode();
-if(!pCNd && nullptr == (pCNd = bNext ? pDoc->GetNodes().GoNext()
+if(!pCNd && nullptr == (pCNd = bNext ? rDoc.GetNodes().GoNext()
  : SwNodes::GoPrevious()))
 {
 pCNd = bNext ? SwNodes::GoPrevious()
- : pDoc->GetNodes().GoNext();
+ : rDoc.GetNodes().GoNext();
 OSL_ENSURE(pCNd, "no ContentNode found");
 }
 return pCNd;
@@ -105,7 +105,7 @@ void SwFltStackEntry::SetEndPos(const SwPosition& rEndPos)
 m_aPtPos.SetPos(rEndPos);
 }
 
-bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM& rRegion, RegionMode const 
eCheck,
+bool SwFltStackEntry::MakeRegion(SwDoc& rDoc, SwPaM& rRegion, RegionMode const 
eCheck,
 const SwFltPosition , const SwFltPosition , bool bIsParaEnd,
 sal_uInt16 nWhich)
 {
@@ -131,7 +131,7 @@ bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM& 
rRegion, RegionMode const e
 }
 // The content indices always apply to the node!
 rRegion.GetPoint()->nNode = rMkPos.m_nNode.GetIndex() + 1;
-SwContentNode* pCNd = GetContentNode(pDoc, rRegion.GetPoint()->nNode, 
true);
+SwContentNode* pCNd = GetContentNode(rDoc, rRegion.GetPoint()->nNode, 
true);
 
 SAL_WARN_IF(pCNd->Len() < rMkPos.m_nContent, "sw.ww8",
 "invalid content index " << rMkPos.m_nContent << " but text node has 
only " << pCNd->Len());
@@ -145,7 +145,7 @@ bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM& 
rRegion, RegionMode const e
 if (n >= rNodes.Count())
 return false;
 rRegion.GetPoint()->nNode = n;
-pCNd = GetContentNode(pDoc, rRegion.GetPoint()->nNode, false);
+pCNd = GetContentNode(rDoc, rRegion.GetPoint()->nNode, false);
 }
 SAL_WARN_IF(pCNd->Len() < rPtPos.m_nContent, "sw.ww8",
 "invalid content index " << rPtPos.m_nContent << " but text node has 
only " << pCNd->Len());
@@ -167,14 +167,14 @@ bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM& 
rRegion, RegionMode const e
 return bRet;
 }
 
-bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM& rRegion, RegionMode 
eCheck) const
+bool SwFltStackEntry::MakeRegion(SwDoc& rDoc, SwPaM& rRegion, RegionMode 
eCheck) const
 {
-return MakeRegion(pDoc, rRegion, eCheck, m_aMkPos, m_aPtPos, bIsParaEnd,
+return MakeRegion(rDoc, rRegion, eCheck, m_aMkPos, m_aPtPos, bIsParaEnd,
 pAttr->Which());
 }
 
-SwFltControlStack::SwFltControlStack(SwDoc* pDo, sal_uLong nFieldFl)
-: nFieldFlags(nFieldFl),bHasSdOD(true), bSdODChecked(false), pDoc(pDo), 
bIsEndStack(false)
+SwFltControlStack::SwFltControlStack(SwDoc& rDo, sal_uLong nFieldFl)
+: nFieldFlags(nFieldFl),bHasSdOD(true), bSdODChecked(false), rDoc(rDo), 
bIsEndStack(false)
 {
 }
 
@@ -206,7 +206,7 @@ void SwFltControlStack::MoveAttrs(const SwPosition& rPos, 
MoveAttrsMode eMode)
 {
 rEntry.m_aMkPos.m_nContent++;
 OSL_ENSURE( rEntry.m_aMkPos.m_nContent
-<= pDoc->GetNodes()[nPosNd]->GetContentNode()->Len(),
+<= rDoc.GetNodes()[nPosNd]->GetContentNode()->Len(),
 "Attribute ends after end of line" );
 }
 if (
@@ -227,7 +227,7 @@ void SwFltControlStack::MoveAttrs(const SwPosition& rPos, 
MoveAttrsMode eMode)
 }
 rEntry.m_aPtPos.m_nContent++;
 OSL_ENSURE( rEntry.m_aPtPos.m_nContent
-<= pDoc->GetNodes()[nPosNd]->GetContentNode()->Len(),
+<= rDoc.GetNodes()[nPosNd]->GetContentNode()->Len(),
 "Attribute ends after end of line" 

[Libreoffice-bugs] [Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with promptTitle longer than 32 characters.

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84874

--- Comment #12 from NISZ LibreOffice Team  ---
Created attachment 166034
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166034=edit
Example file from Calc master

So this has changed a bit in recent Excel.

Attached example file has 4 sheets on each of them a cell validation on A2 with
input title, input help, error title, error message each filled with 257
characters of loremipsum.

This exported to XLSX fails to open in my 2013, indicating invalid content on
each of the 4 sheets.

Reducing the length of the texts to 256 characters makes the xlsx export open
in Excel.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137207] New: there is no project container for combination of all LO-formats, odm is limited to writer

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137207

Bug ID: 137207
   Summary: there is no project container for combination of all
LO-formats, odm is limited to writer
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: paulyste...@web.de

odm is a first trial for complex projects with writer.

But more is necessary in projects with more parts of LO.

A super global document with all parts of LO is my idea.

In a main menu the parts are referenced and sorted.

All part documnents of libre office are possible parts. 

Writer, impress, calc, draw, base, formula documents with full possibilities
are grouped in super global document.
The parts are worked in the part programs.

So links in documents are nor lost with change of file system position.

I hope this idea is understood and good enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136437] .uno:NewRouting is named “Reset Routing” in Draw’s UI and “Reset Line Skew” in Help

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136437

Ayhan Yalçınsoy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |ayhanyalcin...@pisilinux.or
   |desktop.org |g

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133403] [UI] PDF export options dialog: Usage of term "bookmark" confusing

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133403

Ayhan Yalçınsoy  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |ayhanyalcin...@pisilinux.or
   |desktop.org |g
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 77373] TABLE: Circles in table were misplaced in .doc format

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77373

--- Comment #11 from Ettore Atalan  ---
Why should I retest my reported bug if no developer has worked on it in over
6.5 years because there is obviously no interest in fixing it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91755] Writer: regex helps misses examples 'x not y'

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91755

--- Comment #5 from sdc.bla...@youmail.dk ---
(In reply to V Stuart Foote from comment #3)
> Recently the ICU project relocated resources, now LO help is linked
> incorrectly. 
Patch in comment 3 updates the link.

> Not clear the project help article needs to be expanded as the ICU
> documentation is comprehensive. 
Shall we take a bold decision?

1. Nick's request could be addressed by adding an example that addresses
non-alphanumeric.  (e.g. to find all cases of word but not "word").
Other examples on the page give the template for how to present the example. 

If someone would provide the text, then I would add it to the regex help page.

(the downside with this solution is that the relevant regex operators are not
mentioned on the page. Would be relevant to add them -- but the ICU explanation
is incomprehensible, unless you know already know regex -- in which case a link
to the relevant "manual" might be better -- and two relevant links are already
available.)

2. Maybe better to add a tip on:  "Using Regular Expressions in Text Searches"
https://help.libreoffice.org/7.1/en-US/text/swriter/guide/search_regexp.html
(isn't that where a user might search?)  And instead of explaining how, just
give a short tip that indicates possibilities (which the user then has to RTM).
For example:  

To search for (Nick's type of case) here, then use (relevant syntax).

or

Use Positive Lookahead, Negative Lookahead, Positive Lookbehind, and Negative
Lookbehind to (short explanation of what they are good for).  See (link to ICU
manual) for relevant operators.

3.  And if 1 and 2 are rejected, then I propose this bug be resolved as NAB or
WF.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137185] EDITING Textbox and random text in shape forms two layers and it looks confusing

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137185

--- Comment #2 from NISZ LibreOffice Team  ---
Created attachment 166033
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166033=edit
Example file from Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: external/nss

2020-10-02 Thread Jan-Marek Glogowski (via logerrit)
 external/nss/ExternalProject_nss.mk  |1 
 external/nss/UnpackedTarball_nss.mk  |1 
 external/nss/nss-android.patch.1 |6 -
 external/nss/nss-restore-manual-pre-dependencies.patch.1 |   83 +++
 4 files changed, 86 insertions(+), 5 deletions(-)

New commits:
commit d2f9c55e065d559de903d540da28502646714a24
Author: Jan-Marek Glogowski 
AuthorDate: Thu Oct 1 12:57:53 2020 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Fri Oct 2 13:38:10 2020 +0200

nss: restore manual pre-dependency build

We had some seldom build failures on Windows, with errors like:
PermissionError: [WinError 32] The process cannot access the file
because it is being used by another process: '/nssckmdt.h'.

This happens, because of the "." / parent shell hack. Thinking
about it again, it doesn't prevent the parent make to run in
parallel to the "." directory make. So I tried to use a terminal
match-all rule like

ifneq (,$(filter .,$(DIRS)))
%::
# empty terminal rule triggered
$(error can't happen)
endif

to stop the original parent make, but that doesn't work and the
$(error ...) is triggered.

So AFAIK I'm out of options here and have to restore the old
manual pre-dependency build variant - still much better then no
parallel build.

An alternative idea was to put the rest of the rules.mk in the
"else" of the terminal rule, to skip all normal rules, but this
still leaves out all rules from the rest of the make-files,
which might result in some hard to debug errors.

This reverts my upstream patch 15608:744881490c78.

Change-Id: I9e2e9e1ec9f35697c7853c92f60434f514cba5ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103777
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 
Reviewed-by: Jan-Marek Glogowski 

diff --git a/external/nss/ExternalProject_nss.mk 
b/external/nss/ExternalProject_nss.mk
index a7099e34e7e7..25d4995ced44 100644
--- a/external/nss/ExternalProject_nss.mk
+++ b/external/nss/ExternalProject_nss.mk
@@ -59,7 +59,6 @@ $(call gb_ExternalProject_get_state_target,nss,build): $(call 
gb_ExternalExecuta
NSPR_CONFIGURE_OPTS="--build=$(BUILD_PLATFORM) 
--host=$(HOST_PLATFORM)") \
NSDISTMODE=copy \
$(MAKE) \
-   -j1 \
AR="$(AR)" \
RANLIB="$(RANLIB)" \
NMEDIT="$(NM)edit" \
diff --git a/external/nss/UnpackedTarball_nss.mk 
b/external/nss/UnpackedTarball_nss.mk
index 7921d36078bf..fb8b8b061265 100644
--- a/external/nss/UnpackedTarball_nss.mk
+++ b/external/nss/UnpackedTarball_nss.mk
@@ -28,6 +28,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,nss,\
 external/nss/macos-dlopen.patch.0 \
external/nss/nss.getopt.patch.0 \
external/nss/nss-win-arm64.patch \
+external/nss/nss-restore-manual-pre-dependencies.patch.1 \
 $(if $(filter iOS,$(OS)), \
 external/nss/nss-ios.patch) \
 $(if $(filter ANDROID,$(OS)), \
diff --git a/external/nss/nss-android.patch.1 b/external/nss/nss-android.patch.1
index 7d3807f73589..0f75715e8b86 100644
--- a/external/nss/nss-android.patch.1
+++ b/external/nss/nss-android.patch.1
@@ -62,13 +62,11 @@ diff -ur nss.org/nss/Makefile nss/nss/Makefile
$(MAKE) -C $(CORE_DEPTH)/../nspr/$(OBJDIR_NAME) install
 --- nss/nss/lib/ckfw/builtins/manifest.mn.orig 2019-11-26 15:18:22.185985193 
+0100
 +++ nss/nss/lib/ckfw/builtins/manifest.mn  2019-11-26 15:18:29.281982387 
+0100
-@@ -5,9 +5,7 @@
+@@ -5,7 +5,7 @@
  
  CORE_DEPTH = ../../..
  
--DIRS = . testlib
--
--testlib: .
+-DIRS = testlib
 +DIRS =
  
  MODULE = nss
diff --git a/external/nss/nss-restore-manual-pre-dependencies.patch.1 
b/external/nss/nss-restore-manual-pre-dependencies.patch.1
new file mode 100644
index ..ebcc5b48c540
--- /dev/null
+++ b/external/nss/nss-restore-manual-pre-dependencies.patch.1
@@ -0,0 +1,83 @@
+Revert of upstream:
+
+changeset:   15608:744881490c78
+user:Jan-Marek Glogowski 
+date:Wed May 13 19:00:40 2020 +
+summary: Bug 1637083 Replace pre-dependency with shell hack r=rrelyea
+
+--- b/nss/coreconf/rules.mkWed May 13 19:00:40 2020 +
 a/nss/coreconf/rules.mkTue May 12 21:33:43 2020 +
+@@ -31,21 +31,10 @@
+ USE_NT_C_SYNTAX=1
+ endif
+ 
+-# For whatever reason, "." can't be handled using make conditionals.
+-# Based on automake's SUBDIRS "." handling.
+ ifdef DIRS
+ ifndef IGNORE_DIRS
+-ifneq (,$(filter .,$(DIRS)))
+-TARGETS = $(NULL)
+-ALL_TRASH = $(NULL)
+-endif
+-
+ $(DIRS):
++  $(IGNORE_ERROR)@$(MAKE) -C $@ $(MAKECMDGOALS)
+-  $(IGNORE_ERROR)@if [ "$@" != "." ]; then \
+-  $(MAKE) -C $@ $(MAKECMDGOALS) ; \
+-  else \
+-  IGNORE_DIRS=1 $(MAKE) -C $@ $(MAKECMDGOALS) ; \
+-  fi
+   @$(CLICK_STOPWATCH)
+ 

[Libreoffice-bugs] [Bug 137163] libreoffice base report runs always twice (Windows)

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137163

--- Comment #8 from rimi...@yahoo.com ---
I completely uninstalled LibreOffice and installed version 6.4.4 and it works
fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108952] FILESAVE: DOCX: VML connectors lost after roundtrip

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108952

Balázs Regényi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |regenyi.balazs+libreoffice_
   |desktop.org |bugzi...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137143] Offer a Windows on ARM64 installer

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137143

--- Comment #3 from Jan-Marek Glogowski  ---
All patches should show up in "git log --stat --grep 'Windows Arm64'".

While the current LO starts and the build even creates a - still untested -
MSI, there is some stuff still missing / disabled, which is available in the
other Windows builds and which needs further work (apart from upstreaming the
patches and the obvious bugfixes):

* .NET / C#: is currently disabled. You could probably build most of it, except
for clihelper, which needs a library and header not in .NET 5.0, (mscoree.dll).
The header is still in the Git repo at:
https://github.com/dotnet/coreclr/blob/master/src/pal/prebuilt/inc/mscoree.h,
but not in the SDK download, last time I checked. (That dir is suspiciously
called prebuild, so it might not be the real origin of that file / code).
* gpgme: uses mingw / gcc to build, which doesn't support Windows Arm64,
according to: https://github.com/msys2/MSYS2-packages/issues/1276
* coinmp: probably just needs to add a ARM64 target to the solution file, like
I did for lcms2 in commit a8b0503b57a4736df3040e2faa4faf16ef1df062. There is
also a newer "1.8" release, just ~two years old. Probably some "interesting"
easy hack?
* skia: is currently build with MSVC. I had a quick look, but couldn't figure
out, if this needs an extra cross-compiler, like for MSVC, or just some
switches to select the host CPU when calling MSVC. A quick test already
generated errors for the precompiled headers for missing intrinsics, so I'm
quite sure I didn't select the correct target.
* firebird: configure complains / aborts w.r.t. some tests unable to work for
cross-compilation. The source offers a few MSVS solution files for a build, but
LO uses configure. I suggest to first check, if the build can use these (and
also ask base people), instead of configure. Probably would also get rid of
some / all Windows patches and maybe is faster.
* StarBasic DLL / FFI support: currently disabled by commit
b25aa1cd813478f1cb08bf4f2a79ed83852a33e9. This code needs an implementation for
Arm64. AFAIK it's like the "uno2cpp" part of the bridges code, but instead it's
just "basic2c", so no state and just C calls. So not sure, if this kind of
"code sharing" would work and is desired? Or generally use libffi here, which
we already need / use for Python?

Since I just did some debugging in QEMU using instdir, I also didn't run any
tests. Generally any 32-bit process hogs a CPU core, so there are some more
general bugs in either my Windows version or QEMU. The current Windows
installer ISOs also doesn't even boot into the installer (QEMU and edk2 git),
hogging a CPU with a black screen after pressing a key to start from the CD.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137142] Problem with Print dialog and GNOME Desktop Environment Universal Access accessibility

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137142

--- Comment #11 from DaveG  ---
Yeah a duplicate in terms of the effects, but not in terms of the environment. 
I notice the duplicate bug was re-opened after a patch to add a scroll bar.
I am left to conclude that the print dialogue box needs patching so that it is
agnostic towards the rest of the tech environment it operates under.  I
appreciate there may be some purists who say "only add a scroll bar when
necessary" so a scroll bar parch regardless would risk upsetting them.  Maybe a
switch off option somewhere?  that could be seen :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108253] [META] Calc cell formula bugs and enhancements

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108253
Bug 108253 depends on bug 136537, which changed state.

Bug 136537 Summary: Cell formulas get corrupted with Drag & Drop
https://bugs.documentfoundation.org/show_bug.cgi?id=136537

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 136537] Cell formulas get corrupted with Drag & Drop

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136537

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #7 from Heiko Tietze  ---
The expected behavior is effective if you add a row within the range or when
Tools > Options > Calc > General > Input Settings "Expand references when new
columns/rows are inserted" is enabled, see [1]. 
The other workflow, moving a selection, is not supported for good reasons.
While the first changes the whole sheet with the purpose of adding data the
latter is just to change the visualization. You drag the formula result to a
more prominent place, for example. Imagine to move not just a few rows down but
some columns to the right - would be surprising if the calculation changes
completely.
And last but not least this is exactly how MS Excel behaves. Moving a section
never changes the formula while adding a row does. => WF

[1]
file:///usr/lib/libreoffice/help/en-US/text/shared/optionen/01060300.html?System=UNIX=CALC=modules/scalc/ui/scgeneralpage/ScGeneralPage#bm_id3147211

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 136537] Cell formulas get corrupted with Drag & Drop

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136537

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #7 from Heiko Tietze  ---
The expected behavior is effective if you add a row within the range or when
Tools > Options > Calc > General > Input Settings "Expand references when new
columns/rows are inserted" is enabled, see [1]. 
The other workflow, moving a selection, is not supported for good reasons.
While the first changes the whole sheet with the purpose of adding data the
latter is just to change the visualization. You drag the formula result to a
more prominent place, for example. Imagine to move not just a few rows down but
some columns to the right - would be surprising if the calculation changes
completely.
And last but not least this is exactly how MS Excel behaves. Moving a section
never changes the formula while adding a row does. => WF

[1]
file:///usr/lib/libreoffice/help/en-US/text/shared/optionen/01060300.html?System=UNIX=CALC=modules/scalc/ui/scgeneralpage/ScGeneralPage#bm_id3147211

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/inc sw/source

2020-10-02 Thread Caolán McNamara (via logerrit)
 sw/inc/numrule.hxx|2 +-
 sw/source/core/doc/docnum.cxx |8 
 sw/source/core/doc/number.cxx |6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 597a746b38c4b3cb860cc997d532029d56a9f75a
Author: Caolán McNamara 
AuthorDate: Thu Oct 1 20:48:26 2020 +0100
Commit: Caolán McNamara 
CommitDate: Fri Oct 2 13:19:39 2020 +0200

SwNumRule::CheckCharFormats never passed null SwDoc*

Change-Id: I9f33af6cdf02e24a2a4da0694dda3a266832c0a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103822
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/inc/numrule.hxx b/sw/inc/numrule.hxx
index a4e986a9ae9c..ae6405424518 100644
--- a/sw/inc/numrule.hxx
+++ b/sw/inc/numrule.hxx
@@ -218,7 +218,7 @@ public:
 
 /** Tests whether the CharFormats are from the given doc
and copies them if appropriate. */
-void CheckCharFormats( SwDoc* pDoc );
+void CheckCharFormats( SwDoc& rDoc );
 
 const OUString& GetName() const { return msName; }
 
diff --git a/sw/source/core/doc/docnum.cxx b/sw/source/core/doc/docnum.cxx
index b0a38c0f406e..5d466edbd942 100644
--- a/sw/source/core/doc/docnum.cxx
+++ b/sw/source/core/doc/docnum.cxx
@@ -129,7 +129,7 @@ void SwDoc::SetOutlineNumRule( const SwNumRule& rRule )
 mpOutlineRule->SetAutoRule( true );
 
 // test whether the optional CharFormats are defined in this Document
-mpOutlineRule->CheckCharFormats( this );
+mpOutlineRule->CheckCharFormats( *this );
 
 // notify text nodes, which are registered at the outline style, about the
 // changed outline style
@@ -813,7 +813,7 @@ static void lcl_ChgNumRule( SwDoc& rDoc, const SwNumRule& 
rRule )
 if( !nChgFormatLevel ) // Nothing has been changed?
 {
 const bool bInvalidateNumRule( pOld->IsContinusNum() != 
rRule.IsContinusNum() );
-pOld->CheckCharFormats(  );
+pOld->CheckCharFormats( rDoc );
 pOld->SetContinusNum( rRule.IsContinusNum() );
 
 if ( bInvalidateNumRule )
@@ -844,7 +844,7 @@ static void lcl_ChgNumRule( SwDoc& rDoc, const SwNumRule& 
rRule )
 if ( nChgFormatLevel & ( 1 << n ) )
 pOld->Set( n, rRule.GetNumFormat( n ) );
 
-pOld->CheckCharFormats(  );
+pOld->CheckCharFormats( rDoc );
 pOld->SetInvalidRule( true );
 pOld->SetContinusNum( rRule.IsContinusNum() );
 
@@ -2464,7 +2464,7 @@ sal_uInt16 SwDoc::MakeNumRule( const OUString ,
 pNew->SetPoolHlpFileId( UCHAR_MAX );
 pNew->SetDefaultListId( OUString() );
 }
-pNew->CheckCharFormats( this );
+pNew->CheckCharFormats( *this );
 }
 else
 {
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index a565e22ce1fd..a75c2478320d 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -512,18 +512,18 @@ SwNumRule::~SwNumRule()
 maParagraphStyleList.clear();
 }
 
-void SwNumRule::CheckCharFormats( SwDoc* pDoc )
+void SwNumRule::CheckCharFormats( SwDoc& rDoc )
 {
 for(auto& rpNumFormat : maFormats)
 {
 if( rpNumFormat )
 {
 SwCharFormat* pFormat = rpNumFormat->GetCharFormat();
-if( pFormat && pFormat->GetDoc() != pDoc )
+if( pFormat && pFormat->GetDoc() !=  )
 {
 // copy
 SwNumFormat* pNew = new SwNumFormat( *rpNumFormat );
-pNew->SetCharFormat( pDoc->CopyCharFormat( *pFormat ) );
+pNew->SetCharFormat( rDoc.CopyCharFormat( *pFormat ) );
 rpNumFormat.reset(pNew);
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


<    1   2   3   4   >