[Libreoffice-bugs] [Bug 135310] [META] Writer outline folding bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=135310 Bug 135310 depends on bug 141390, which changed state. Bug 141390 Summary: Toggling "show outline content visibility button" sends one to the top of the document https://bugs.documentfoundation.org/show_bug.cgi?id=141390 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141390] Toggling "show outline content visibility button" sends one to the top of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=141390 Jim Raykowski changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142070] Elements are hard to read when using dark GTK theme in Tabbed UI on Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=142070 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142084] Order inversion of accented letters when typed in table cells
https://bugs.documentfoundation.org/show_bug.cgi?id=142084 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134665] [SLIDESHOW] Miscalculation of size of a shape/object in Animation : Emphasis - Grow and Shrink
https://bugs.documentfoundation.org/show_bug.cgi?id=134665 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment|target:7.2.0 |target:7.2.0| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142101] Memory usage opening 3 page presentation with (large) images gone up from 250 MB to 514 MB
https://bugs.documentfoundation.org/show_bug.cgi?id=142101 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142103] Japanese full-width characters: Should be cropped, if they are the first character
https://bugs.documentfoundation.org/show_bug.cgi?id=142103 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142090] Font antialiasing in libreoffice does not work under wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=142090 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137622] Every data shown 1899
https://bugs.documentfoundation.org/show_bug.cgi?id=137622 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137622] Every data shown 1899
https://bugs.documentfoundation.org/show_bug.cgi?id=137622 --- Comment #5 from QA Administrators --- Dear ASHIK ACHARYA, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93597] FILEOPEN:Round-tripping OOXML chart with style other than default results in blank chart
https://bugs.documentfoundation.org/show_bug.cgi?id=93597 --- Comment #9 from QA Administrators --- Dear Luke, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84205] FILESAVE: Theme Colors inverted in drawings after PPTX roundtrip (black part turned to white)
https://bugs.documentfoundation.org/show_bug.cgi?id=84205 --- Comment #25 from QA Administrators --- Dear Luke, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125327] Padding to text labels of the tabs on the Format Cells or Character dialogs need a bit more space before and after the label
https://bugs.documentfoundation.org/show_bug.cgi?id=125327 --- Comment #4 from QA Administrators --- Dear Roeland, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 30731] Cursor behaviour with Graphite fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=30731 --- Comment #21 from QA Administrators --- Dear RGB, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142381] DOCX export: Table behind chart
https://bugs.documentfoundation.org/show_bug.cgi?id=142381 --- Comment #3 from Harshita Nag --- When I try to reproduce it, the position of the table and chart does change, but the table doesn't go behind the chart. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142382] Bottom line of wrap 'Parallel' makes line break instead of gap
https://bugs.documentfoundation.org/show_bug.cgi?id=142382 --- Comment #1 from Harshita Nag --- Can't reproduce this. Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 27911b0455d8dcc08a0702372492a6ce00250cb7 CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-04-12_15:34:11 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103683] PDF export mediabox trimbox cropbox bleedbox artbox
https://bugs.documentfoundation.org/show_bug.cgi?id=103683 V Stuart Foote changed: What|Removed |Added URL|https://appszx.com/ | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142383] New: Impress Slide transition problems
https://bugs.documentfoundation.org/show_bug.cgi?id=142383 Bug ID: 142383 Summary: Impress Slide transition problems Product: LibreOffice Version: 7.1.3.2 release Hardware: Other OS: other Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lenscom...@lenshamn.com Description: I have tested the same Impress file on several different Windows 10 Pro computers and discovered the following: Fade smoothly transition works properly on at least four computers that have Intel Graphics on the motherboard. (Jerky transitions on some Intel computers before downloading latest drivers.) Fade smoothly transition on some AMD Radon graphics computers is jerky with flashing, and on one computer with an AMD motherboard crashes the program. Unknown graphics adapter on Lenova Laptop running Linux Mint 19.1 the Fade smoothly transition is jerky and flashes. Len Nasman, tech support for the Bristol Village retirement community computer club. Steps to Reproduce: 1.create several 16:9 slides 2.Set automatic slide advance 3.select Fade, smoothly option, start slide show Actual Results: Noted in description Expected Results: Different results with different display adapters as noted in description Reproducible: Always User Profile Reset: No Additional Info: Some other slide transitions are faulty on some display adapters -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141959] LibreOffice Vanilla - Writer displays lines across page width where none should be present - screen redraw issues
https://bugs.documentfoundation.org/show_bug.cgi?id=141959 --- Comment #6 from rahul kumar --- hellop Friends, Repair guides and disassembly information for Android phones of all shapes, sizes, and colors. Get everything you need to repair your phone yourself. Android ... https://androidji.com/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138759] DRAW - multipage file refuses to save after multiple edits between saves, requests password that was never set (MacOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=138759 --- Comment #10 from rahul kumar --- Nice post thanks for Sha... hello friends my name is rahul kumar my website. https://appszx.com/battlegrounds-mobile-india-apk/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103683] PDF export mediabox trimbox cropbox bleedbox artbox
https://bugs.documentfoundation.org/show_bug.cgi?id=103683 rahul kumar changed: What|Removed |Added URL||https://appszx.com/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103683] PDF export mediabox trimbox cropbox bleedbox artbox
https://bugs.documentfoundation.org/show_bug.cgi?id=103683 --- Comment #30 from rahul kumar --- Download link of the Battlegrounds Mobile India V1.0 apk link will be available on 18th May, Battlegrounds Mobile India for Android & IOS. https://appszx.com/battlegrounds-mobile-india-apk/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117930] FILESAVE; Error while exporting document to XHTML
https://bugs.documentfoundation.org/show_bug.cgi?id=117930 --- Comment #13 from Terrence Enger --- After the fix to bug 142367, in a local --enable-dbgutil build of commit cfe0e7dc, built and running on debian-buster, I see that the crash is gone and the msgbox is back. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142382] New: Bottom line of wrap 'Parallel' makes line break instead of gap
https://bugs.documentfoundation.org/show_bug.cgi?id=142382 Bug ID: 142382 Summary: Bottom line of wrap 'Parallel' makes line break instead of gap Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 172181 --> https://bugs.documentfoundation.org/attachment.cgi?id=172181=edit Document to reproduce the error Open attached document. Move the rectangle a little bit down, so that the line starting with 'a b c' needs to wrap. Error: After the 'j' is not a gap, but a line break. The text continues after the 'j' in a new line with 'k'. Expected: The 'k' is at the same line as the 'a b c' positioned below the 'y'. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133020] Problems rendering SVG files
https://bugs.documentfoundation.org/show_bug.cgi?id=133020 --- Comment #19 from Eyal Rozenberg --- I've just opened the SVG with: Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 0c67217d767baada12587dace9d29b955d50e774 CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (en_IL); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-04-26_09:25:26 I confirm that I can't ungroup the diagram object so as to access its constituent shapes. I would also expect that an SVG file opened in LO draw Now, if I right-click it and choose "Edit with external tool", it opens Inkscape, not an image editor. And in Inkscape, I can ungroup the shapes and manipulate them to my liking. Both in LO Draw and in Inkscape I can see the bottom piece of text saying "viewer does not support full SVG 1.1". I should also mention that this is not limited to the attached SVG file. If I save some SVG file I create in Inkscape, and open in from LO Draw, I also get the same thing: A single, non-ungroupable, object, editable with an external tool. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142365] Mouse pointer disappears over cells EDITING
https://bugs.documentfoundation.org/show_bug.cgi?id=142365 --- Comment #4 from Marco A.G.Pinto --- Created attachment 172180 --> https://bugs.documentfoundation.org/attachment.cgi?id=172180=edit Attached document Here is the ODS file. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62248] REPORTBUILDER: multiple groupings on same field broken
https://bugs.documentfoundation.org/show_bug.cgi?id=62248 --- Comment #16 from Matt K --- I did what the screenshot showed and still got an error. What version are you running on? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142365] Mouse pointer disappears over cells EDITING
https://bugs.documentfoundation.org/show_bug.cgi?id=142365 Marco A.G.Pinto changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from Marco A.G.Pinto --- Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 3d36ff1a1d94bcdb6facf12eec00a532b6640880 CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: CL I have attached the document. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: offapi/com sw/inc sw/qa sw/source
offapi/com/sun/star/text/TextTableRow.idl |8 ++
sw/inc/doc.hxx|2
sw/inc/swtable.hxx|2
sw/inc/unoprnms.hxx |1
sw/qa/extras/uiwriter/uiwriter2.cxx | 77 ++
sw/source/core/bastyp/init.cxx|2
sw/source/core/doc/DocumentRedlineManager.cxx | 34 +++
sw/source/core/docnode/ndtbl1.cxx | 26
sw/source/core/frmedt/fetab.cxx | 30 ++
sw/source/core/table/swtable.cxx | 15 +
sw/source/core/unocore/unomap.cxx |1
sw/source/filter/html/htmltab.cxx | 17 -
12 files changed, 199 insertions(+), 16 deletions(-)
New commits:
commit 05366b8e6683363688de8708a3d88cf144c7a2bf
Author: László Németh
AuthorDate: Wed May 19 12:22:24 2021 +0200
Commit: László Németh
CommitDate: Thu May 20 00:01:37 2021 +0200
tdf#60382 sw offapi: add change tracking of table/row deletion
This is a minimal extension of the text range based change
tracking to record and apply table row and table deletions
with full Undo/Redo support.
Add property IsNotTracked to com::sun::star::text::TextTableRow.
During recording of track changes, deletion of table rows wasn't
recorded: the rows removed completely with their text content.
Now the deletion deletes the cell content with change tracking,
setting also IsNotTracked property of table rows to FALSE. If
all tracked deletions were accepted in a row, and the result is
an empty row, the row will be removed, if its IsNotTracked
property is FALSE.
Note: Deletion of empty lines isn't recorded (they are simply
deleted). Hiding deleted rows hasn't been supported yet in
the Hide Changes mode.
OpenDocument supports only track changes of text ranges, but
not changes of the table structure, e.g. deletion of table
rows. For the native export it needs to extend ODF, and
depending on this future extension, can be based also on
SwExtraRedlineTable (which lacks of recording and Undo/Redo,
but supports OOXML round-trip of tracked table changes).
See also commit d688069023959ab97d14eb1dbfd5bf6ad3c1b160
"Add support for 'Table Row Redlines' in SW core" and its
follow-up commits.
Change-Id: I2e3807cf8ae8212bd51c210ef1c20c85878d0da8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115804
Tested-by: László Németh
Reviewed-by: László Németh
diff --git a/offapi/com/sun/star/text/TextTableRow.idl
b/offapi/com/sun/star/text/TextTableRow.idl
index d640d1c06cce..77191c9f57d1 100644
--- a/offapi/com/sun/star/text/TextTableRow.idl
+++ b/offapi/com/sun/star/text/TextTableRow.idl
@@ -105,6 +105,14 @@ published service TextTableRow
@since LibreOffice 6.1
*/
[optional, property] com::sun::star::graphic::XGraphic BackGraphic;
+
+/** If TRUE, the table row wasn't deleted or inserted with its tracked
cell content
+
+@since LibreOffice 7.2
+ */
+
+[optional, property, maybevoid] boolean IsNotTracked;
+
};
diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index 08510f634569..19a2b6af64b1 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -1489,6 +1489,8 @@ public:
bool BalanceRowHeight( const SwCursor& rCursor, bool bTstOnly, const bool
bOptimize );
void SetRowBackground( const SwCursor& rCursor, const SvxBrushItem );
static bool GetRowBackground( const SwCursor& rCursor,
std::unique_ptr& rToFill );
+/// rNotTracked = false means that the row was deleted or inserted with
its tracked cell content
+void SetRowNotTracked( const SwCursor& rCursor, const SvxPrintItem
);
void SetTabBorders( const SwCursor& rCursor, const SfxItemSet& rSet );
void SetTabLineStyle( const SwCursor& rCursor,
const Color* pColor, bool bSetLine,
diff --git a/sw/inc/swtable.hxx b/sw/inc/swtable.hxx
index 5432a24d60e4..6696c94d6cfc 100644
--- a/sw/inc/swtable.hxx
+++ b/sw/inc/swtable.hxx
@@ -444,6 +444,8 @@ public:
void RemoveFromTable();
const SwStartNode *GetSttNd() const { return m_pStartNode; }
sal_uLong GetSttIdx() const;
+// it doesn't contain box content
+bool IsEmpty() const;
// Search next/previous box with content.
SwTableBox* FindNextBox( const SwTable&, const SwTableBox*,
diff --git a/sw/inc/unoprnms.hxx b/sw/inc/unoprnms.hxx
index 9cceac0f8d0f..317ad79fa8ed 100644
--- a/sw/inc/unoprnms.hxx
+++ b/sw/inc/unoprnms.hxx
@@ -736,6 +736,7 @@
#define UNO_NAME_ITEMS "Items"
#define UNO_NAME_SELITEM "SelectedItem"
#define UNO_NAME_IS_SPLIT_ALLOWED "IsSplitAllowed"
+#define UNO_NAME_IS_NOT_TRACKED "IsNotTracked"
#define UNO_NAME_CHAR_HIDDEN "CharHidden"
#define UNO_NAME_IS_FOLLOWING_TEXT_FLOW "IsFollowingTextFlow"
#define UNO_NAME_WIDTH_TYPE "WidthType"
diff --git
[Libreoffice-bugs] [Bug 142365] Mouse pointer disappears over cells EDITING
https://bugs.documentfoundation.org/show_bug.cgi?id=142365 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO --- Comment #2 from m.a.riosv --- I can't reproduce it either Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: b1c0734ffe0f395757b6e0cea7830d820231afeb CPU threads: 4; OS: Windows 10.0 Build 21382; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL Please add the information on Menu/Help/About LibreOffice. Test if changing Skia on Menu/Tools/LibreOffice/View, has same effect. Does it happen with all files or with one particularly? If so, can you attach a sample file with the issue for test. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142315] I self publish on Amazon KDP, but I lose some of my formatting in the .odt format I write in, when I save as .doc and even worse, if I save as .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=142315 Monika Magdalena changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Assignee|libreoffice-b...@lists.free |moni...@moniques.site |desktop.org | Ever confirmed|1 |0 --- Comment #2 from Monika Magdalena --- Created attachment 172179 --> https://bugs.documentfoundation.org/attachment.cgi?id=172179=edit manuscript for conversion into .doc THe formatting gets lost somehow (headlines and paragraphs mainly) in saving as .doc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Intended behavior for wrap "parallel" for custom shapes?
Hi all, this is a question about correct way of wrap around a shape. The question is connected to bug 142305 "FILEOPEN DOCX wrap is tight in LibreOffice but not in Word". Take a text, insert a custom shape "Circle Pie", and set the wrap mode to "Parallel". Make sure, "Contour" is off. The pie is drawn into a free, rectangular area and the text wraps around this area. Drag the angle handles to make the pie a small sector. The free area becomes smaller, so that it remains tight to the sector. This is the behavior in LibreOffice since version 6.1, about April 2018. In versions before, the free area was always as large as the underlying circle of the sector. Is the new way an error or is it the intended behavior? ODF spec has only the wording "text wraps around the bounding box of the object" but does not define the term "bounding box". I personally like the new way. It makes the custom shape "Circle Pie" behave the same as the legacy sector shape and prevents large holes in the text. But before continuing in developing my patch, I need to know, whether the new way is really intended. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 142381] DOCX export: Table behind chart
https://bugs.documentfoundation.org/show_bug.cgi?id=142381 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression Version|7.2.0.0.alpha0+ Master |6.3.0.4 release --- Comment #2 from Telesto --- Also found in 7.0b1 and in Version: 6.3.7.0.0+ (x86) Build ID: 726535ec30f12697ceccd2f0640d9371a64dc5bd CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL not in Version: 6.2.0.0.alpha0+ Build ID: b1d1edff4e81a8299e2a17c7e562d144329549ab CPU threads: 4; OS: Windows 6.3; UI render: GL; Locale: nl-NL (nl_NL); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142380] DRY: Use CSS variables to eliminate repetition
https://bugs.documentfoundation.org/show_bug.cgi?id=142380 Olivier Hallot changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Olivier Hallot --- Yeah. Parametrize may give us better CSS management. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142381] DOCX export: Table behind chart
https://bugs.documentfoundation.org/show_bug.cgi?id=142381 --- Comment #1 from Telesto --- Created attachment 172178 --> https://bugs.documentfoundation.org/attachment.cgi?id=172178=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142381] New: DOCX export: Table behind chart
https://bugs.documentfoundation.org/show_bug.cgi?id=142381 Bug ID: 142381 Summary: DOCX export: Table behind chart Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: DOCX export: Table behind chart Steps to Reproduce: 1. Open the attached file 2. Save as DOCX 3. File reload Actual Results: Table behind chart Expected Results: Chart above table as in ODT Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d7f734db2c078ced3ce08ad58cd816a79abe3bcf CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Exports fine with 4.4.7.2 (and opens OK with 7.2) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142377] [FILEOPEN DOC] not responding when importing doc
https://bugs.documentfoundation.org/show_bug.cgi?id=142377 Telesto changed: What|Removed |Added Version|7.1.3.2 release |Inherited From OOo Status|UNCONFIRMED |NEW Ever confirmed|0 |1 OS|Linux (All) |All Component|Impress |Writer --- Comment #2 from Telesto --- Repro with Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d7f734db2c078ced3ce08ad58cd816a79abe3bcf CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL 4.4.7.2 4.0 3.0.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142377] [FILEOPEN DOC] not responding when importing doc
https://bugs.documentfoundation.org/show_bug.cgi?id=142377 --- Comment #1 from Telesto --- Created attachment 172177 --> https://bugs.documentfoundation.org/attachment.cgi?id=172177=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94617] method nStart overflow in pCode
https://bugs.documentfoundation.org/show_bug.cgi?id=94617 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||620 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=94 ||617 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142369] Basic drawings still get damaged
https://bugs.documentfoundation.org/show_bug.cgi?id=142369 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Telesto --- Repro Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d7f734db2c078ced3ce08ad58cd816a79abe3bcf CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL *** This bug has been marked as a duplicate of bug 109129 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109129] FILEOPEN: DOCX - Red curved arrow lines not rendered correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=109129 --- Comment #7 from Telesto --- *** Bug 142369 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142365] Mouse pointer disappears over cells EDITING
https://bugs.documentfoundation.org/show_bug.cgi?id=142365 --- Comment #1 from Telesto --- I can't repro Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d7f734db2c078ced3ce08ad58cd816a79abe3bcf CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/commonfuzzer.mk
vcl/commonfuzzer.mk |1 + 1 file changed, 1 insertion(+) New commits: commit cfe0e7dc4d32117ba604e713b8a70eb6576a1fa2 Author: Caolán McNamara AuthorDate: Wed May 19 20:45:20 2021 +0100 Commit: Caolán McNamara CommitDate: Wed May 19 21:47:20 2021 +0200 ofz: need vbaobj now as well Change-Id: If06bc0481f91818200b13ad122b08e4fdc09110c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115827 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/vcl/commonfuzzer.mk b/vcl/commonfuzzer.mk index ab462737f028..3e0891ac3b0f 100644 --- a/vcl/commonfuzzer.mk +++ b/vcl/commonfuzzer.mk @@ -146,6 +146,7 @@ fuzzer_calc_libraries = \ scfilt \ scd \ vbaevents \ +vbaobj \ sc \ for \ forui \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/sidebar/ChartAreaPanel.cxx | 30
chart2/source/controller/sidebar/ChartAreaPanel.hxx |1
chart2/source/controller/sidebar/ChartAxisPanel.cxx | 30
chart2/source/controller/sidebar/ChartAxisPanel.hxx |1
chart2/source/controller/sidebar/ChartElementsPanel.cxx | 17 ++---
chart2/source/controller/sidebar/ChartElementsPanel.hxx |1
chart2/source/controller/sidebar/ChartErrorBarPanel.cxx | 16 +---
chart2/source/controller/sidebar/ChartErrorBarPanel.hxx |1
chart2/source/controller/sidebar/ChartLinePanel.cxx | 30
chart2/source/controller/sidebar/ChartLinePanel.hxx |1
chart2/source/controller/sidebar/ChartSeriesPanel.cxx | 19 +-
chart2/source/controller/sidebar/ChartSeriesPanel.hxx |1
chart2/source/controller/sidebar/ChartTypePanel.cxx | 16 +---
chart2/source/controller/sidebar/ChartTypePanel.hxx |1
14 files changed, 100 insertions(+), 65 deletions(-)
New commits:
commit feb17e47bc04e2af6b4ecf7202764ce980f83242
Author: Caolán McNamara
AuthorDate: Wed May 19 17:36:48 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed May 19 21:38:06 2021 +0200
tdf#142364 exception thrown during destruction
Change-Id: I4e06ac82108e5381cd11fbd6407e1ce1e85c3ac6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115822
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/chart2/source/controller/sidebar/ChartAreaPanel.cxx
b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
index 51e71e22cf33..0378f7bbda6f 100644
--- a/chart2/source/controller/sidebar/ChartAreaPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
@@ -289,12 +289,7 @@ ChartAreaPanel::ChartAreaPanel(weld::Widget* pParent,
ChartAreaPanel::~ChartAreaPanel()
{
-css::uno::Reference xBroadcaster(mxModel,
css::uno::UNO_QUERY_THROW);
-xBroadcaster->removeModifyListener(mxListener);
-
-css::uno::Reference
xSelectionSupplier(mxModel->getCurrentController(), css::uno::UNO_QUERY);
-if (xSelectionSupplier.is())
-xSelectionSupplier->removeSelectionChangeListener(mxSelectionListener);
+doUpdateModel(nullptr);
}
void ChartAreaPanel::Initialize()
@@ -512,23 +507,25 @@ void ChartAreaPanel::selectionChanged(bool bCorrectType)
updateData();
}
-void ChartAreaPanel::updateModel(
-css::uno::Reference xModel)
+void ChartAreaPanel::doUpdateModel(css::uno::Reference
xModel)
{
if (mbModelValid)
{
css::uno::Reference
xBroadcaster(mxModel, css::uno::UNO_QUERY_THROW);
xBroadcaster->removeModifyListener(mxListener);
-}
-css::uno::Reference oldSelectionSupplier(
-mxModel->getCurrentController(), css::uno::UNO_QUERY);
-if (oldSelectionSupplier.is()) {
-
oldSelectionSupplier->removeSelectionChangeListener(mxSelectionListener);
+css::uno::Reference
oldSelectionSupplier(
+mxModel->getCurrentController(), css::uno::UNO_QUERY);
+if (oldSelectionSupplier.is()) {
+
oldSelectionSupplier->removeSelectionChangeListener(mxSelectionListener);
+}
}
mxModel = xModel;
-mbModelValid = true;
+mbModelValid = mxModel.is();
+
+if (!mbModelValid)
+return;
css::uno::Reference
xBroadcasterNew(mxModel, css::uno::UNO_QUERY_THROW);
xBroadcasterNew->addModifyListener(mxListener);
@@ -538,6 +535,11 @@ void ChartAreaPanel::updateModel(
xSelectionSupplier->addSelectionChangeListener(mxSelectionListener);
}
+void ChartAreaPanel::updateModel( css::uno::Reference
xModel)
+{
+doUpdateModel(xModel);
+}
+
}
diff --git a/chart2/source/controller/sidebar/ChartAreaPanel.hxx
b/chart2/source/controller/sidebar/ChartAreaPanel.hxx
index 01fb9077a178..110132ca4356 100644
--- a/chart2/source/controller/sidebar/ChartAreaPanel.hxx
+++ b/chart2/source/controller/sidebar/ChartAreaPanel.hxx
@@ -72,6 +72,7 @@ private:
rtl::Reference mxSelectionListener;
void Initialize();
+void doUpdateModel(css::uno::Reference xModel);
bool mbUpdate;
bool mbModelValid;
diff --git a/chart2/source/controller/sidebar/ChartAxisPanel.cxx
b/chart2/source/controller/sidebar/ChartAxisPanel.cxx
index f35a57bdf232..ccab43770b8f 100644
--- a/chart2/source/controller/sidebar/ChartAxisPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartAxisPanel.cxx
@@ -222,12 +222,7 @@ ChartAxisPanel::ChartAxisPanel(
ChartAxisPanel::~ChartAxisPanel()
{
-css::uno::Reference xBroadcaster(mxModel,
css::uno::UNO_QUERY_THROW);
-xBroadcaster->removeModifyListener(mxModifyListener);
-
-css::uno::Reference
xSelectionSupplier(mxModel->getCurrentController(), css::uno::UNO_QUERY);
-if (xSelectionSupplier.is())
-xSelectionSupplier->removeSelectionChangeListener(mxSelectionListener);
+doUpdateModel(nullptr);
mxCBShowLabel.reset();
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/ctredlin.hxx |2 +-
svx/source/dialog/SafeModeDialog.cxx | 15 ++-
svx/source/dialog/SafeModeDialog.hxx |2 +-
svx/source/dialog/ctredlin.cxx| 14 +++---
svx/source/tbxctrls/extrusioncontrols.cxx | 29 +
svx/source/tbxctrls/extrusioncontrols.hxx |7 +++
svx/source/tbxctrls/fontworkgallery.cxx | 27 ---
7 files changed, 35 insertions(+), 61 deletions(-)
New commits:
commit 9e27ac3ed8f2405a94bf07519ca7941731025e37
Author: Caolán McNamara
AuthorDate: Wed May 19 16:19:53 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed May 19 21:37:35 2021 +0200
use toggle instead of click for RadioButton
Change-Id: I8fb4a28f4be701858af0ae8e95ff0f45a5401490
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115821
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/svx/ctredlin.hxx b/include/svx/ctredlin.hxx
index cffb5be2fbee..c3e887ba1302 100644
--- a/include/svx/ctredlin.hxx
+++ b/include/svx/ctredlin.hxx
@@ -182,7 +182,7 @@ class SAL_WARN_UNUSED SVX_DLLPUBLIC SvxTPFilter final :
public SvxTPage
std::unique_ptr m_xEdComment;
DECL_LINK( SelDateHdl, weld::ComboBox&, void );
-DECL_LINK( RowEnableHdl, weld::Button&, void );
+DECL_LINK( RowEnableHdl, weld::ToggleButton&, void );
DECL_LINK( TimeHdl, weld::Button&, void );
DECL_LINK( ModifyHdl, weld::Entry&, void );
DECL_LINK( ModifyListBoxHdl, weld::ComboBox&, void );
diff --git a/svx/source/dialog/SafeModeDialog.cxx
b/svx/source/dialog/SafeModeDialog.cxx
index 6cd0f306ad34..a3c8d453f2e3 100644
--- a/svx/source/dialog/SafeModeDialog.cxx
+++ b/svx/source/dialog/SafeModeDialog.cxx
@@ -57,10 +57,7 @@ SafeModeDialog::SafeModeDialog(weld::Window* pParent)
, maBackupFileHelper()
{
m_xDialog->set_centered_on_parent(false);
-mxRadioRestore->connect_clicked(LINK(this, SafeModeDialog, RadioBtnHdl));
-mxRadioConfigure->connect_clicked(LINK(this, SafeModeDialog, RadioBtnHdl));
-mxRadioExtensions->connect_clicked(LINK(this, SafeModeDialog,
RadioBtnHdl));
-mxRadioReset->connect_clicked(LINK(this, SafeModeDialog, RadioBtnHdl));
+mxRadioRestore->connect_toggled(LINK(this, SafeModeDialog, RadioBtnHdl));
mxBtnContinue->connect_clicked(LINK(this, SafeModeDialog, DialogBtnHdl));
mxBtnRestart->connect_clicked(LINK(this, SafeModeDialog, DialogBtnHdl));
@@ -196,9 +193,9 @@ void SafeModeDialog::applyChanges()
css::uno::Reference< css::task::XInteractionHandler >());
}
-IMPL_LINK(SafeModeDialog, RadioBtnHdl, weld::Button&, rBtn, void)
+IMPL_LINK_NOARG(SafeModeDialog, RadioBtnHdl, weld::ToggleButton&, void)
{
-if ( == mxRadioRestore.get())
+if (mxRadioRestore->get_active())
{
// Enable the currently selected box
mxBoxRestore->set_sensitive(true);
@@ -209,7 +206,7 @@ IMPL_LINK(SafeModeDialog, RadioBtnHdl, weld::Button&, rBtn,
void)
mxBoxConfigure->set_sensitive(false);
mxBoxDeinstall->set_sensitive(false);
}
-else if ( == mxRadioConfigure.get())
+else if (mxRadioConfigure->get_active())
{
// Enable the currently selected box
mxBoxConfigure->set_sensitive(true);
@@ -221,7 +218,7 @@ IMPL_LINK(SafeModeDialog, RadioBtnHdl, weld::Button&, rBtn,
void)
mxBoxDeinstall->set_sensitive(false);
}
-else if ( == mxRadioExtensions.get())
+else if (mxRadioExtensions->get_active())
{
// Enable the currently selected box
mxBoxDeinstall->set_sensitive(true);
@@ -232,7 +229,7 @@ IMPL_LINK(SafeModeDialog, RadioBtnHdl, weld::Button&, rBtn,
void)
mxBoxConfigure->set_sensitive(false);
mxBoxReset->set_sensitive(false);
}
-else if ( == mxRadioReset.get())
+else if (mxRadioReset->get_active())
{
// Enable the currently selected box
mxBoxReset->set_sensitive(true);
diff --git a/svx/source/dialog/SafeModeDialog.hxx
b/svx/source/dialog/SafeModeDialog.hxx
index daba66caffce..fca3bd9249b4 100644
--- a/svx/source/dialog/SafeModeDialog.hxx
+++ b/svx/source/dialog/SafeModeDialog.hxx
@@ -56,7 +56,7 @@ private:
void enableDisableWidgets();
void applyChanges();
-DECL_LINK(RadioBtnHdl, weld::Button&, void);
+DECL_LINK(RadioBtnHdl, weld::ToggleButton&, void);
DECL_LINK(CheckBoxHdl, weld::ToggleButton&, void);
DECL_LINK(CreateZipBtnHdl, weld::Button&, void);
DECL_LINK(DialogBtnHdl, weld::Button&, void);
diff --git a/svx/source/dialog/ctredlin.cxx b/svx/source/dialog/ctredlin.cxx
index d80f84890161..0a472b2074f1 100644
--- a/svx/source/dialog/ctredlin.cxx
+++ b/svx/source/dialog/ctredlin.cxx
@@ -526,12 +526,12 @@ SvxTPFilter::SvxTPFilter(weld::Container* pParent)
m_xIbClock2->connect_clicked( LINK( this, SvxTPFilter,TimeHdl) );
m_xBtnRange->connect_clicked( LINK( this, SvxTPFilter, RefHandle));
-Link aLink=LINK(
[Libreoffice-commits] core.git: sc/source
sc/source/ui/dbgui/pfiltdlg.cxx |4 ++--
sc/source/ui/dbgui/pvfundlg.cxx |4 ++--
sc/source/ui/inc/pfiltdlg.hxx |2 +-
sc/source/ui/inc/pvfundlg.hxx |2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 14d03bf37063fcf5f0641989b1d0c06c49fe75c2
Author: Caolán McNamara
AuthorDate: Wed May 19 16:06:31 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed May 19 21:37:16 2021 +0200
use toggle instead of click for CheckButton
Change-Id: I26e2c0b77e95c99176daf830909824833453ce5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115820
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/dbgui/pfiltdlg.cxx b/sc/source/ui/dbgui/pfiltdlg.cxx
index 750526290c70..1fe50d32a204 100644
--- a/sc/source/ui/dbgui/pfiltdlg.cxx
+++ b/sc/source/ui/dbgui/pfiltdlg.cxx
@@ -76,7 +76,7 @@ void ScPivotFilterDlg::Init( const SfxItemSet& rArgSet )
const ScQueryItem& rQueryItem = static_cast(
rArgSet.Get( nWhichQuery ));
-m_xBtnCase->connect_clicked( LINK( this, ScPivotFilterDlg, CheckBoxHdl
) );
+m_xBtnCase->connect_toggled( LINK( this, ScPivotFilterDlg, CheckBoxHdl ) );
m_xLbField1->connect_changed ( LINK( this, ScPivotFilterDlg, LbSelectHdl
) );
m_xLbField2->connect_changed ( LINK( this, ScPivotFilterDlg, LbSelectHdl
) );
@@ -463,7 +463,7 @@ IMPL_LINK( ScPivotFilterDlg, LbSelectHdl, weld::ComboBox&,
rLb, void )
}
}
-IMPL_LINK(ScPivotFilterDlg, CheckBoxHdl, weld::Button&, rBox, void)
+IMPL_LINK(ScPivotFilterDlg, CheckBoxHdl, weld::ToggleButton&, rBox, void)
{
// update the value lists when dealing with uppercase/lowercase
diff --git a/sc/source/ui/dbgui/pvfundlg.cxx b/sc/source/ui/dbgui/pvfundlg.cxx
index 935bfe82e13b..43f4e33274a1 100644
--- a/sc/source/ui/dbgui/pvfundlg.cxx
+++ b/sc/source/ui/dbgui/pvfundlg.cxx
@@ -793,7 +793,7 @@ void ScDPSubtotalOptDlg::Init( const ScDPNameVec&
rDataFields, bool bEnableLayou
// *** AUTO SHOW ***
m_xCbShow->set_active( maLabelData.maShowInfo.IsEnabled );
-m_xCbShow->connect_clicked( LINK( this, ScDPSubtotalOptDlg, CheckHdl ) );
+m_xCbShow->connect_toggled( LINK( this, ScDPSubtotalOptDlg, CheckHdl ) );
m_xLbShowFrom->set_active(FromDataPilotFieldShowItemsMode(maLabelData.maShowInfo.ShowItemsMode));
tools::Long nCount = static_cast< tools::Long >(
maLabelData.maShowInfo.ItemCount );
@@ -879,7 +879,7 @@ IMPL_LINK(ScDPSubtotalOptDlg, RadioClickHdl, weld::Button&,
rBtn, void)
m_xLbSortBy->set_sensitive( != m_xRbSortMan.get());
}
-IMPL_LINK(ScDPSubtotalOptDlg, CheckHdl, weld::Button&, rCBox, void)
+IMPL_LINK(ScDPSubtotalOptDlg, CheckHdl, weld::ToggleButton&, rCBox, void)
{
if ( == m_xCbShow.get())
{
diff --git a/sc/source/ui/inc/pfiltdlg.hxx b/sc/source/ui/inc/pfiltdlg.hxx
index 00d5833628df..630515519f5c 100644
--- a/sc/source/ui/inc/pfiltdlg.hxx
+++ b/sc/source/ui/inc/pfiltdlg.hxx
@@ -87,7 +87,7 @@ private:
// Handler:
DECL_LINK( LbSelectHdl, weld::ComboBox&, void );
DECL_LINK( ValModifyHdl, weld::ComboBox&, void );
-DECL_LINK( CheckBoxHdl, weld::Button&, void );
+DECL_LINK( CheckBoxHdl, weld::ToggleButton&, void );
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/inc/pvfundlg.hxx b/sc/source/ui/inc/pvfundlg.hxx
index 6c75ee1a6f87..527999b609d3 100644
--- a/sc/source/ui/inc/pvfundlg.hxx
+++ b/sc/source/ui/inc/pvfundlg.hxx
@@ -152,7 +152,7 @@ private:
sal_Int32 FindListBoxEntry( const weld::ComboBox& rLBox,
std::u16string_view rEntry, sal_Int32 nStartPos ) const;
DECL_LINK( RadioClickHdl, weld::Button&, void );
-DECL_LINK( CheckHdl, weld::Button&, void );
+DECL_LINK( CheckHdl, weld::ToggleButton&, void );
DECL_LINK( SelectHdl, weld::ComboBox&, void );
DECL_LINK( ButtonClicked, weld::Button&, void );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/crnrdlg.hxx |3 --
sc/source/ui/miscdlgs/crnrdlg.cxx | 57 +-
2 files changed, 27 insertions(+), 33 deletions(-)
New commits:
commit 0ab9c2f1d763dd805eb63ba3a5ffa16e63bf7734
Author: Caolán McNamara
AuthorDate: Wed May 19 15:46:09 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed May 19 21:36:44 2021 +0200
use toggle instead of click for RadioButton
only listen for one toggle for the button grouping
Change-Id: I4c7f84eda2dfdb873371ae7ba8ede710f373dbda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115819
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/inc/crnrdlg.hxx b/sc/source/ui/inc/crnrdlg.hxx
index eaf0d1eb4598..6162eb3f76ca 100644
--- a/sc/source/ui/inc/crnrdlg.hxx
+++ b/sc/source/ui/inc/crnrdlg.hxx
@@ -83,8 +83,7 @@ private:
DECL_LINK( RemoveBtnHdl, weld::Button&, void );
DECL_LINK( Range1SelectHdl, weld::TreeView&, void );
DECL_LINK( Range1DataModifyHdl, formula::RefEdit&, void );
-DECL_LINK( ColClickHdl, weld::Button&, void );
-DECL_LINK( RowClickHdl, weld::Button&, void );
+DECL_LINK( ColRowToggleHdl, weld::ToggleButton&, void );
DECL_LINK( Range2DataModifyHdl, formula::RefEdit&, void );
DECL_LINK( GetEditFocusHdl, formula::RefEdit&, void );
DECL_LINK( LoseEditFocusHdl, formula::RefEdit&, void );
diff --git a/sc/source/ui/miscdlgs/crnrdlg.cxx
b/sc/source/ui/miscdlgs/crnrdlg.cxx
index c037405ef078..09ca326e6d9a 100644
--- a/sc/source/ui/miscdlgs/crnrdlg.cxx
+++ b/sc/source/ui/miscdlgs/crnrdlg.cxx
@@ -102,8 +102,7 @@ void ScColRowNameRangesDlg::Init()
m_xBtnRemove->connect_clicked ( LINK( this, ScColRowNameRangesDlg,
RemoveBtnHdl ) );
m_xLbRange->connect_changed( LINK( this, ScColRowNameRangesDlg,
Range1SelectHdl ) );
m_xEdAssign->SetModifyHdl ( LINK( this, ScColRowNameRangesDlg,
Range1DataModifyHdl ) );
-m_xBtnColHead->connect_clicked ( LINK( this, ScColRowNameRangesDlg,
ColClickHdl ) );
-m_xBtnRowHead->connect_clicked ( LINK( this, ScColRowNameRangesDlg,
RowClickHdl ) );
+m_xBtnColHead->connect_toggled ( LINK( this, ScColRowNameRangesDlg,
ColRowToggleHdl ) );
m_xEdAssign2->SetModifyHdl ( LINK( this, ScColRowNameRangesDlg,
Range2DataModifyHdl ) );
Link aEditLink = LINK( this,
ScColRowNameRangesDlg, GetEditFocusHdl );
@@ -729,40 +728,36 @@ IMPL_LINK_NOARG(ScColRowNameRangesDlg,
Range2DataModifyHdl, formula::RefEdit&, v
}
}
-// handler for the radio button for columns, adjust ranges
-IMPL_LINK_NOARG(ScColRowNameRangesDlg, ColClickHdl, weld::Button&, void)
+IMPL_LINK_NOARG(ScColRowNameRangesDlg, ColRowToggleHdl, weld::ToggleButton&,
void)
{
-if (!m_xBtnColHead->get_active())
-return;
-
-if ( theCurArea.aStart.Row() == 0 && theCurArea.aEnd.Row() ==
rDoc.MaxRow() )
+if (m_xBtnColHead->get_active())
{
-theCurArea.aEnd.SetRow( rDoc.MaxRow() - 1 );
-OUString aStr(theCurArea.Format(rDoc, ScRefFlags::RANGE_ABS_3D,
rDoc.GetAddressConvention()));
-m_xEdAssign->SetText( aStr );
+// handler for the radio button for columns, adjust ranges
+if ( theCurArea.aStart.Row() == 0 && theCurArea.aEnd.Row() ==
rDoc.MaxRow() )
+{
+theCurArea.aEnd.SetRow( rDoc.MaxRow() - 1 );
+OUString aStr(theCurArea.Format(rDoc, ScRefFlags::RANGE_ABS_3D,
rDoc.GetAddressConvention()));
+m_xEdAssign->SetText( aStr );
+}
+ScRange aRange( theCurData );
+aRange.aStart.SetRow( std::min(
static_cast(theCurArea.aEnd.Row() + 1),
static_cast(rDoc.MaxRow()) ) );
+aRange.aEnd.SetRow( rDoc.MaxRow() );
+AdjustColRowData( aRange );
}
-ScRange aRange( theCurData );
-aRange.aStart.SetRow( std::min(
static_cast(theCurArea.aEnd.Row() + 1),
static_cast(rDoc.MaxRow()) ) );
-aRange.aEnd.SetRow( rDoc.MaxRow() );
-AdjustColRowData( aRange );
-}
-
-// handler for the radio button for columns, adjust range
-IMPL_LINK_NOARG(ScColRowNameRangesDlg, RowClickHdl, weld::Button&, void)
-{
-if (!m_xBtnRowHead->get_active())
-return;
-
-if ( theCurArea.aStart.Col() == 0 && theCurArea.aEnd.Col() ==
rDoc.MaxCol() )
+else if (m_xBtnRowHead->get_active())
{
-theCurArea.aEnd.SetCol( rDoc.MaxCol() - 1 );
-OUString aStr(theCurArea.Format(rDoc, ScRefFlags::RANGE_ABS_3D,
rDoc.GetAddressConvention()));
-m_xEdAssign->SetText( aStr );
+// handler for the radio button for columns, adjust range
+if ( theCurArea.aStart.Col() == 0 && theCurArea.aEnd.Col() ==
rDoc.MaxCol() )
+{
+theCurArea.aEnd.SetCol( rDoc.MaxCol() - 1 );
+OUString aStr(theCurArea.Format(rDoc, ScRefFlags::RANGE_ABS_3D,
rDoc.GetAddressConvention()));
+m_xEdAssign->SetText( aStr );
+}
+ScRange aRange( theCurData );
+aRange.aStart.SetCol( static_cast(std::min(
[Libreoffice-commits] core.git: cui/source dbaccess/source sc/source sw/source
cui/source/dialogs/hlinettp.cxx |4 +--
cui/source/dialogs/passwdomdlg.cxx|4 +--
cui/source/inc/hlinettp.hxx |2 -
cui/source/inc/passwdomdlg.hxx|2 -
dbaccess/source/ui/dlg/adtabdlg.cxx |5 +---
dbaccess/source/ui/dlg/detailpages.cxx| 25 ++
dbaccess/source/ui/dlg/detailpages.hxx|1
dbaccess/source/ui/dlg/indexdialog.cxx|4 +--
dbaccess/source/ui/inc/WCPage.hxx |2 -
dbaccess/source/ui/inc/adtabdlg.hxx |2 -
dbaccess/source/ui/inc/indexdialog.hxx|2 -
dbaccess/source/ui/misc/WCPage.cxx|4 +--
sc/source/ui/StatisticsDialogs/SamplingDialog.cxx |6 ++---
sc/source/ui/dbgui/filtdlg.cxx|6 ++---
sc/source/ui/dbgui/validate.cxx |4 +--
sc/source/ui/inc/SamplingDialog.hxx |2 -
sc/source/ui/inc/filtdlg.hxx |2 -
sc/source/ui/inc/highred.hxx |2 -
sc/source/ui/inc/validate.hxx |2 -
sc/source/ui/miscdlgs/highred.cxx |4 +--
sw/source/ui/config/optload.cxx |5 +---
sw/source/uibase/inc/optload.hxx |2 -
22 files changed, 45 insertions(+), 47 deletions(-)
New commits:
commit 6815067b75ab79c050d07693a9a1b7e306a4af1b
Author: Caolán McNamara
AuthorDate: Wed May 19 15:16:47 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed May 19 21:36:02 2021 +0200
use toggle instead of click for RadioButton
only listen for one toggle for the button grouping
Change-Id: I0c1866c25793ffce50bcf5f5a07fcdc98f64aacc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115818
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/cui/source/dialogs/hlinettp.cxx b/cui/source/dialogs/hlinettp.cxx
index 86a3da492a69..5ee2aa70f90f 100644
--- a/cui/source/dialogs/hlinettp.cxx
+++ b/cui/source/dialogs/hlinettp.cxx
@@ -70,7 +70,7 @@
SvxHyperlinkInternetTp::SvxHyperlinkInternetTp(weld::Container* pParent,
Link aLink( LINK ( this, SvxHyperlinkInternetTp,
Click_SmartProtocol_Impl ) );
m_xRbtLinktypInternet->connect_clicked( aLink );
m_xRbtLinktypFTP->connect_clicked( aLink );
-m_xCbAnonymous->connect_clicked( LINK ( this, SvxHyperlinkInternetTp,
ClickAnonymousHdl_Impl ) );
+m_xCbAnonymous->connect_toggled( LINK ( this, SvxHyperlinkInternetTp,
ClickAnonymousHdl_Impl ) );
m_xEdLogin->connect_changed( LINK ( this, SvxHyperlinkInternetTp,
ModifiedLoginHdl_Impl ) );
m_xCbbTarget->connect_focus_out( LINK ( this, SvxHyperlinkInternetTp,
LostFocusTargetHdl_Impl ) );
m_xCbbTarget->connect_changed( LINK ( this, SvxHyperlinkInternetTp,
ModifiedTargetHdl_Impl ) );
@@ -325,7 +325,7 @@ IMPL_LINK_NOARG(SvxHyperlinkInternetTp,
Click_SmartProtocol_Impl, weld::Button&,
|* Click on Checkbox : Anonymous user
|*
|/
-IMPL_LINK_NOARG(SvxHyperlinkInternetTp, ClickAnonymousHdl_Impl, weld::Button&,
void)
+IMPL_LINK_NOARG(SvxHyperlinkInternetTp, ClickAnonymousHdl_Impl,
weld::ToggleButton&, void)
{
// disable login-editfields if checked
if ( m_xCbAnonymous->get_active() )
diff --git a/cui/source/dialogs/passwdomdlg.cxx
b/cui/source/dialogs/passwdomdlg.cxx
index 9c06e961498e..9f7986482596 100644
--- a/cui/source/dialogs/passwdomdlg.cxx
+++ b/cui/source/dialogs/passwdomdlg.cxx
@@ -132,7 +132,7 @@
PasswordToOpenModifyDialog::PasswordToOpenModifyDialog(weld::Window * pParent, s
if (!bIsPasswordToModify)
m_xOptionsExpander->hide();
-m_xOpenReadonlyCB->connect_clicked(LINK(this, PasswordToOpenModifyDialog,
ReadonlyOnOffHdl));
+m_xOpenReadonlyCB->connect_toggled(LINK(this, PasswordToOpenModifyDialog,
ReadonlyOnOffHdl));
ReadonlyOnOffHdl(*m_xOpenReadonlyCB);
}
@@ -159,7 +159,7 @@ bool
PasswordToOpenModifyDialog::IsRecommendToOpenReadonly() const
return m_xOpenReadonlyCB->get_active();
}
-IMPL_LINK_NOARG(PasswordToOpenModifyDialog, ReadonlyOnOffHdl, weld::Button&,
void)
+IMPL_LINK_NOARG(PasswordToOpenModifyDialog, ReadonlyOnOffHdl,
weld::ToggleButton&, void)
{
bool bEnable = m_xOpenReadonlyCB->get_active();
m_xPasswdToModifyED->set_sensitive(bEnable);
diff --git a/cui/source/inc/hlinettp.hxx b/cui/source/inc/hlinettp.hxx
index c317fc122fd4..ae09e8ac874f 100644
--- a/cui/source/inc/hlinettp.hxx
+++ b/cui/source/inc/hlinettp.hxx
@@ -46,7 +46,7 @@ private:
std::unique_ptr m_xCbAnonymous;
DECL_LINK( Click_SmartProtocol_Impl, weld::Button&, void ); ///<
Radiobutton clicked: Type HTTP or FTP
-DECL_LINK( ClickAnonymousHdl_Impl, weld::Button&, void ); ///< Checkbox :
Anonymous User
+DECL_LINK( ClickAnonymousHdl_Impl, weld::ToggleButton&, void ); ///<
Checkbox : Anonymous User
[Libreoffice-commits] core.git: cui/source
cui/source/customize/acccfg.cxx |5 ++---
cui/source/inc/acccfg.hxx |2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
New commits:
commit 3de15e365d120c92147f79dab082cca395abf75e
Author: Caolán McNamara
AuthorDate: Wed May 19 15:05:33 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed May 19 21:35:46 2021 +0200
use toggle instead of click for RadioButton
only listen for one toggle for the button grouping
Change-Id: I937331aebc2391e4026f69f16f9c7c9216981d0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115817
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/cui/source/customize/acccfg.cxx b/cui/source/customize/acccfg.cxx
index 8070e0716faf..4666aeac49ce 100644
--- a/cui/source/customize/acccfg.cxx
+++ b/cui/source/customize/acccfg.cxx
@@ -863,8 +863,7 @@
SfxAcceleratorConfigPage::SfxAcceleratorConfigPage(weld::Container* pPage,
m_xLoadButton->connect_clicked(LINK(this, SfxAcceleratorConfigPage, Load));
m_xSaveButton->connect_clicked(LINK(this, SfxAcceleratorConfigPage, Save));
m_xResetButton->connect_clicked(LINK(this, SfxAcceleratorConfigPage,
Default));
-m_xOfficeButton->connect_clicked(LINK(this, SfxAcceleratorConfigPage,
RadioHdl));
-m_xModuleButton->connect_clicked(LINK(this, SfxAcceleratorConfigPage,
RadioHdl));
+m_xOfficeButton->connect_toggled(LINK(this, SfxAcceleratorConfigPage,
RadioHdl));
m_xSearchEdit->connect_changed(LINK(this, SfxAcceleratorConfigPage,
SearchUpdateHdl));
m_xSearchEdit->connect_focus_out(LINK(this, SfxAcceleratorConfigPage,
FocusOut_Impl));
@@ -1254,7 +1253,7 @@ IMPL_LINK(SfxAcceleratorConfigPage, SelectHdl,
weld::TreeView&, rListBox, void)
}
}
-IMPL_LINK_NOARG(SfxAcceleratorConfigPage, RadioHdl, weld::Button&, void)
+IMPL_LINK_NOARG(SfxAcceleratorConfigPage, RadioHdl, weld::ToggleButton&, void)
{
uno::Reference xOld = m_xAct;
diff --git a/cui/source/inc/acccfg.hxx b/cui/source/inc/acccfg.hxx
index aecc923adec2..f4b72bed8585 100644
--- a/cui/source/inc/acccfg.hxx
+++ b/cui/source/inc/acccfg.hxx
@@ -122,7 +122,7 @@ private:
DECL_LINK(Save, weld::Button&, void);
DECL_LINK(Load, weld::Button&, void);
DECL_LINK(Default, weld::Button&, void);
-DECL_LINK(RadioHdl, weld::Button&, void);
+DECL_LINK(RadioHdl, weld::ToggleButton&, void);
DECL_LINK(ImplUpdateDataHdl, Timer*, void);
DECL_LINK(FocusOut_Impl, weld::Widget&, void);
DECL_LINK(TimeOut_Impl, Timer*, void);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142367] Writer crashes when opening docx (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=142367 --- Comment #5 from Timur --- Xisco, please comment if UI test would be of use. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source sw/qa
sd/source/ui/animations/CustomAnimationDialog.cxx |4 ++-- sw/qa/uitest/writer_tests6/tdf118883.py |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit c4adc2cffe5758b45633522b2ac42948b54f93c8 Author: Andrea Gelmini AuthorDate: Wed May 19 20:41:49 2021 +0200 Commit: Julien Nabet CommitDate: Wed May 19 21:17:16 2021 +0200 Fix typos Change-Id: I800e966cee8343099fb79f08959ba246a831aee0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115826 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/sd/source/ui/animations/CustomAnimationDialog.cxx b/sd/source/ui/animations/CustomAnimationDialog.cxx index f6cd3422fd21..1fb22575975e 100644 --- a/sd/source/ui/animations/CustomAnimationDialog.cxx +++ b/sd/source/ui/animations/CustomAnimationDialog.cxx @@ -691,8 +691,8 @@ void SdScalePropertyBox::setValue(const Any& rValue, const OUString&) aValues.First >>= fValue1; aValues.Second >>= fValue2; -// 'Size' drop down menu set by mnDirectioin when loading Grow and Shrink Animation -// Shouldn't compare a float directly to zero...should be fixed with delta epsilon compare +// 'Size' drop down menu set by mnDirection when loading Grow and Shrink Animation +// Shouldn't compare a float directly to zero... should be fixed with delta epsilon compare // Might be better to just have a flag in the content.xml for this if( (fValue1 == 0.0) && (fValue2 == 0.0) ) mnDirection = 3; // assume 'Both' scaling option when both are zero diff --git a/sw/qa/uitest/writer_tests6/tdf118883.py b/sw/qa/uitest/writer_tests6/tdf118883.py index 300412344fb0..9a7397d413b1 100644 --- a/sw/qa/uitest/writer_tests6/tdf118883.py +++ b/sw/qa/uitest/writer_tests6/tdf118883.py @@ -32,7 +32,7 @@ class Tdf118883(UITestCase): calc_document = self.ui_test.get_component() -# Without the fix in place, this test would have failed wiht +# Without the fix in place, this test would have failed with # AssertionError: 1 != 0 self.assertEqual(1, calc_document.DrawPages[0].getCount()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 43767] Writer FORMATTING: Impossible numbering with small Roman numbers of list with capital letters
https://bugs.documentfoundation.org/show_bug.cgi?id=43767 --- Comment #14 from Justin L --- Sometimes Writer delays loading the document, and then it doesn't convert to smallCaps. But normally you can see it load OK, then within seconds shift to smallCaps. I tried adding SvxCaseMap::NotMapped != GetCaseMap() everywhere I saw a similar comparison to GetOverline() and GetStrikeout(), but that didn't work. I'm lost. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docdesc.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 790135003b03b38a14efb7e0d345188607020a99 Author: Noel Grandin AuthorDate: Wed May 19 20:03:07 2021 +0200 Commit: Noel Grandin CommitDate: Wed May 19 20:47:22 2021 +0200 fix leak when removing PageDesc m_PageDescs owns the SwPageDesc entries, so when we remove from it, we need to delete that entry Change-Id: Ib6dbba227ec64c2d6cfc310b93e1d11397648847 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115824 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sw/source/core/doc/docdesc.cxx b/sw/source/core/doc/docdesc.cxx index fb7211dbae3b..b417ab0add9a 100644 --- a/sw/source/core/doc/docdesc.cxx +++ b/sw/source/core/doc/docdesc.cxx @@ -753,6 +753,7 @@ void SwDoc::DelPageDesc( size_t i, bool bBroadcast ) PreDelPageDesc(); // #i7983# m_PageDescs.erase(m_PageDescs.begin() + i); +delete getIDocumentState().SetModified(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-7.1.4.1'
Tag 'libreoffice-7.1.4.1' created by Christian Lohmaier at 2021-05-19 18:12 + Tag libreoffice-7.1.4.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmClVRoACgkQ9DSh76/u rqMc9BAAu+7oNeQrlLNWgSsSDr8eUFSq4/9FsvWOeyjEurIlfp6ffI2P5rXnsacd 8W3QkBv0fajTFMHIWKqoeWlEqtZK036Iy4qWWEAlmgLoWe+7Kz2txy2JLu0NA05i yThs7stawtKSqhr9Wt0mNiDvvlqnfgxMpg0+SQ52fET8ciy9b1BvbuscETDmCGg6 5u2UdM+W/X4eFtH/0qcojjwUhWVyqKJuc+pqrQj/qwH9/c4OUyHDuJFMvW6V8L7e soVGzc7y9Z9zhimw0SWtS7VGjq1csFCKG2vDjpzI3RGzIMI3D/kWVGAhmIDZLP9Y EC5RHuapnEsh+beVrxVYSV1TXGvvZxUQQ3ERltWE7NjTEkFCgkwCiOhCiqXkvwur J/C3NDvi3cwHh7uGYrtrejPkIZwNLVL3anesUff7A+69W8dqRsD5EyKw13j6FOlQ JGAbRL6aVGluHnatQeErQ7SnTg/IUpgTK3582DBn2Woe3TY91U9HejS/+S0hZkbm YW0Xqggw2o+2gjkXAJSNjEGn2fePx09l5WC3CHs1vtHZWmGQzSHaXHa4XtSZEILS Z+8Ssy3GoIdSj52aK3K69QH8bKOuTlWIs9+TBbuRT2wRIHniDB7ColEk6zKndjCT pVVi4KvICCscf+usoCRer61satZf0s5pvUc+I0LMziCUQdKPieM= =4y3n -END PGP SIGNATURE- Changes since co-2021-branch-point-208: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-7.1.4.1'
Tag 'libreoffice-7.1.4.1' created by Christian Lohmaier at 2021-05-19 18:12 + Tag libreoffice-7.1.4.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmClVRoACgkQ9DSh76/u rqNzYg/6AyTNxeV+82c80OEGz0UmE86XtqMoVNQQVxVxpABo1oRoWMJ+eWGAAQCr x53g/OZItjDJtTyEP6TSqhUMrrdG55OP2gfQKy1NYkQJ+hBfTs3LBaqZ50S1Xijj IzPFLLC/77eTGuPJ6GxibiY8fYTtcUdyqoYZAJK2x+1bB7d/sEqHApZrtEuM8zgE 8Xj+bGTPAJFPfQ26nfgYMgNtiwTOIBYzKfro/dEkLA9rcpucpMtNPTA1/TkWZhwe S/po4uDag66iYue89y8dw7KDgxEhPBbUcUCAKJscVvbZguECb8TmJ6dpoiUQvKFd xXj4zdCAquSPn3joxQV62xr3h4VnZ1ZAt0Y64Ho1lTIIdjU7ohnydCCMGbR7fOfG JEBikKFmZ/1KBcxJEHQ9K4y0uxIweWtiI1cOW9IX5n9uJgCm6wUqFZH48AIdpCGE 0kuk/+SdWydDytN1joNm49pjjIKXdMV6oldLpOCOt64tQ+ZVaTUcEM5+ziHjuEkR xjMIU3an5u1kgolwl3k57IBaFVicbykLU4fabiSE/YWL4qFqMaOVGCIUY2ocZaQd 6vzihoQQcygTbqSZBZSNG6PMGorZxSsaYcW/catWVSMzWwWNvCUBznEnMSTc3q4w y7VQBiPOaVhKOrRs+rmYW9oz0jtcl2XaP0drWdwmds0wONe7Ids= =icFU -END PGP SIGNATURE- Changes since co-2021-branch-point-4: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-7.1.4.1'
Tag 'libreoffice-7.1.4.1' created by Christian Lohmaier at 2021-05-19 18:12 + Tag libreoffice-7.1.4.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmClVRoACgkQ9DSh76/u rqNaGw//UZsKE8EVLADIwbxGtIlrSqFT/wiQXoUxFp2myhOI56HJjK3bWhOmTVeT 8kR5cJ1M4SG6kDX/tGTk38QV8IWbnQ4hXAoOlSowHpxIv+n/Q7GStp2JFNQPQwUJ 4ijXcy9Q9IJcEoMpFp/GoRadWC15UvYt/AJQKjMBJnqG/e6A1PFdqgzMDgcZd6RR LuZOXBZxEmSuthhfuik3vqz6KAI2oBeBrdy4UkktEBUF3jXt1eX6CGgqw1j4ghGu WF7sPXS4qNsanKCBpeBMGa8qzwDjZhuGASdyUSqdD1bcjkFjsWxS2Wn/qvnQ++xr NDxYrSs+XiwABv7RXYfzNVj8CQM34SOw9EO3DTUhVfk8G/CSGdgXHwvNUMNtCc8Y OmOzq5/Wupy3PUOVqk6s01Nw8JKThwcQm+hbVxSSUPMRwlmw0QQ8rypLc338e+sF M5XFpfHETbDbYudZNBsc9c5bDlX6n+9W75H70iYPVedrVuI1sxVEiybR7uAvJDSZ ikhwmoXbyacRzI+LkvsjBEOu6iN+WVDc2U04gKMy7g3w4WwEpAhU7EcrGGixWEwl fYvco7x68IE1BpQhxdIw3Q5z26eAx2RbjId+sMdsGRV7Z1x/Gqs5T/T7m0yqdWOS k/wUrdHfWh/3Mjl6n81wzlOkjibewP3lZFViPihczMG3HzFBF9g= =oIYJ -END PGP SIGNATURE- Changes since co-2021-branch-point-2: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-7.1.4.1'
Tag 'libreoffice-7.1.4.1' created by Christian Lohmaier at 2021-05-19 18:12 + Tag libreoffice-7.1.4.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmClVRQACgkQ9DSh76/u rqO6Aw//apjzDwMXkYfXBVvQigDkKrhl0JGDuPZFmocX2yJ4J1hSJZnnZZiGVGHZ pfn9RBqbMCgsy0ln54qcOYVUuT3OkYb2mcjTNpLb0oTMQa8JvkCQRq70dcbScHdN i0iqdZHB/FO4bwf+CHNqpI3CSDxYVjNTJgTMQMBNoNjo93Pu0woOYrxzLEanRm2p PEF/nCDlPF6eYJWsa1C8Obm9lK1MKa+9oPtllDaXgo/YiLaOp25jcEkMVxLDQkaT JJbM7QjAK8kBlWKIUxDEV4pkfomtW6iAfZ8kqXd8aH7qViVzu0b9ZvJntgUmhh1a 1a+XIVS2AjFh5spZlvdaQBkabKcHQrOLgiCZHnMkNqj49ICsoeDIzkhSMFJ3CZBB 35h1/LNXjaCYvz2wU3cPtP93mG/mmGS+uKGWogNRR4HqNh1lELCfv9ubQX65A2LZ xzuOiwg1otFmFiImXc3IByFJkXSUscaBNack5rmjKv73ajB4jmLjByepk35q1Awa jYbcXZa4cnDTy9U3n4n1GcaQzxZshcrvvHZo4kd3dy6cLuAea9LGExWnAxBTxX5o MeM5PBCTmKJhQi5kMag/MzUFLevfNhaqFJoFA25NcCboF8atrw44D97rJYpxD7oI x3CMEWhaE/GCqnADPqOu6PO5shUzs31+juWSlAwgKpP31Z0ZAaA= =8jir -END PGP SIGNATURE- Changes since co-2021-branch-point-1: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1-4' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8cde444b73bdff14f9a6accbe306c01779226800 Author: Christian Lohmaier AuthorDate: Wed May 19 20:13:09 2021 +0200 Commit: Christian Lohmaier CommitDate: Wed May 19 20:13:09 2021 +0200 bump product version to 7.1.4.1.0+ Change-Id: If62d284aa7bdbf805af58d07a2b27c174c3866bd diff --git a/configure.ac b/configure.ac index 65fe7f890988..27b1314c6d03 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[7.1.4.0.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[7.1.4.1.0+],[],[],[http://documentfoundation.org/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3586226899e74b821c584a19b06ffd104709ae14 Author: Christian Lohmaier AuthorDate: Wed May 19 20:11:22 2021 +0200 Commit: Christian Lohmaier CommitDate: Wed May 19 20:11:22 2021 +0200 bump product version to 7.1.5.0.0+ Change-Id: I0acb4e94d4604ef0f09a100e94916ebfa6a3a09d diff --git a/configure.ac b/configure.ac index 65fe7f890988..a63669c584ec 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[7.1.4.0.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[7.1.5.0.0+],[],[],[http://documentfoundation.org/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/defnamesbuffer.hxx |1 +
sc/source/filter/oox/defnamesbuffer.cxx |8
2 files changed, 9 insertions(+)
New commits:
commit f8c1048eb437b1e685b76198165844e2ecc97a56
Author: Noel Grandin
AuthorDate: Wed May 19 19:04:02 2021 +0200
Commit: Noel Grandin
CommitDate: Wed May 19 20:09:58 2021 +0200
fix leak in oox import
Change-Id: I5ff21841480d11c4bfae3c34fd12a6fb32e250e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115823
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/source/filter/inc/defnamesbuffer.hxx
b/sc/source/filter/inc/defnamesbuffer.hxx
index b0b3b1ee6baf..03eec97af201 100644
--- a/sc/source/filter/inc/defnamesbuffer.hxx
+++ b/sc/source/filter/inc/defnamesbuffer.hxx
@@ -87,6 +87,7 @@ class DefinedName : public DefinedNameBase
{
public:
explicitDefinedName( const WorkbookHelper& rHelper );
+virtual ~DefinedName() override;
/** Sets the attributes for this defined name from the passed attribute
set. */
voidimportDefinedName( const AttributeList& rAttribs );
diff --git a/sc/source/filter/oox/defnamesbuffer.cxx
b/sc/source/filter/oox/defnamesbuffer.cxx
index 5f1bc1c01bf4..a554ab9cd0f1 100644
--- a/sc/source/filter/oox/defnamesbuffer.cxx
+++ b/sc/source/filter/oox/defnamesbuffer.cxx
@@ -333,6 +333,14 @@ bool DefinedName::getAbsoluteRange( ScRange& orRange )
const
return getFormulaParser().extractCellRange( orRange, aFTokenSeq );
}
+DefinedName::~DefinedName()
+{
+// this kind of field is owned by us - see lcl_addNewByNameAndTokens
+if (mpScRangeData && maModel.mbHidden &&
+(mcBuiltinId == BIFF_DEFNAME_CRITERIA || mcBuiltinId ==
BIFF_DEFNAME_FILTERDATABASE))
+delete mpScRangeData;
+}
+
DefinedNamesBuffer::DefinedNamesBuffer( const WorkbookHelper& rHelper ) :
WorkbookHelper( rHelper )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'libreoffice-7-1-4'
New branch 'libreoffice-7-1-4' available with the following commits: commit c46a28bba22b6830f84f23ae89f0fe13b6371040 Author: Christian Lohmaier Date: Wed May 19 20:07:29 2021 +0200 Branch libreoffice-7-1-4 This is 'libreoffice-7-1-4' - the stable branch for the 7.1.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.1.x release, please use the 'libreoffice-7-1' branch. If you want to build something cool, unstable, and risky, use master. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Changes to 'libreoffice-7-1-4'
New branch 'libreoffice-7-1-4' available with the following commits: commit 8872c84ee7730808f4634dbbffa18d8664601515 Author: Christian Lohmaier Date: Wed May 19 20:07:07 2021 +0200 Branch libreoffice-7-1-4 This is 'libreoffice-7-1-4' - the stable branch for the 7.1.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.1.x release, please use the 'libreoffice-7-1' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I9f0b0de49065cffcd12c91ef5decda42ed0fc5a5 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'libreoffice-7-1-4'
New branch 'libreoffice-7-1-4' available with the following commits: commit c5022c0051eef702530dfe3bc10fcad025645cdd Author: Christian Lohmaier Date: Wed May 19 20:07:07 2021 +0200 Branch libreoffice-7-1-4 This is 'libreoffice-7-1-4' - the stable branch for the 7.1.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.1.x release, please use the 'libreoffice-7-1' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: Ice6e2268bada93dcda6bb19315acfd6576181df7 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-7-1-4'
New branch 'libreoffice-7-1-4' available with the following commits: commit 5086bdbd12a18a13ce8865fd4e1431a782543486 Author: Christian Lohmaier Date: Wed May 19 20:07:07 2021 +0200 Branch libreoffice-7-1-4 This is 'libreoffice-7-1-4' - the stable branch for the 7.1.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.1.x release, please use the 'libreoffice-7-1' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I5bdc2ba1d704cb84b60ee29cc5012317ee7b775b ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 868d78736ff06cc7a777329f42615a8dd550b2ea Author: Christian Lohmaier AuthorDate: Wed May 19 19:56:39 2021 +0200 Commit: Gerrit Code Review CommitDate: Wed May 19 19:56:39 2021 +0200 Update git submodules * Update translations from branch 'libreoffice-7-1' to 9b312fbdba1d75c6d086f4b3ee182e86de9b7797 - update translations for 7.1.4 rc1 and force-fix errors using pocheck Change-Id: I5cbaffa0b102e88fc4a075332f18b72e32cf5855 diff --git a/translations b/translations index 0a7477257a9a..9b312fbdba1d 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 0a7477257a9aa9c557c090f29f9d3b52e2cfda77 +Subproject commit 9b312fbdba1d75c6d086f4b3ee182e86de9b7797 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142288] FORMATTING: Impress "Screen 16:9/4:3" and PowerPoint "On-screen Show (16:9/4:3)" are different format
https://bugs.documentfoundation.org/show_bug.cgi?id=142288 --- Comment #7 from Regina Henschel --- (In reply to Heiko Tietze from comment #6) > Thought https://en.wikipedia.org/wiki/Display_size could be a basis for > reasoning but neither 25.4 nor 28cm fit on typical displays and need scaling. Scaling is done by the graphic card when running the slide show. The size here is relevant for editing, printing and PDF export, and should harmonize with the grid unit. You could add the size incl. units in brackets, same as PowerPoint does it for page sizes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 --- Comment #7 from Mr.Crocodile --- These are the information from Help -> About Libreoffice Version: 7.1.3.2 (x64) / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win Locale: it-IT (it_IT); UI: it-IT Calc: threaded Just for information, the problem is present also using Win10 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114272] [macOS] Some Asian characters are garbled with western fonts.
https://bugs.documentfoundation.org/show_bug.cgi?id=114272 --- Comment #21 from Volga --- (In reply to Kamei from comment #17) > Because I thought character rendering system may cause this. This is not related to font rendering system, but related to font fallback mechanism. I think LibreOffice need build new font fallback mechanism to fix this bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited
https://bugs.documentfoundation.org/show_bug.cgi?id=92620 Mr.Crocodile changed: What|Removed |Added Hardware|x86 (IA32) |x86-64 (AMD64) Version|4.4.3.2 release |Inherited From OOo --- Comment #6 from Mr.Crocodile --- Hi all and sorry for my late answer. I follow your advise and downloaded both version 3.3.0 and latest 7.1.3.2. I made the test with the document indicated in the comment by Buovjaga 2015-07-29 15:48:42 UTC. The error is still the same (as reported by Buovjaga 2015-07-29 15:48:42 UTC) with the latest version and with the oldest one. Hope this could help again. Have a nice evening. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134655] MacOS: Some of texts shows up as square
https://bugs.documentfoundation.org/show_bug.cgi?id=134655 Volga changed: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=10 |tion.org/show_bug.cgi?id=11 |8042|4272 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114272] [macOS] Some Asian characters are garbled with western fonts.
https://bugs.documentfoundation.org/show_bug.cgi?id=114272 Volga changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4655 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs
https://bugs.documentfoundation.org/show_bug.cgi?id=108042 Volga changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=13 | |4655| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: toolkit/source vcl/source
toolkit/source/helper/unowrapper.cxx | 24
vcl/source/window/window.cxx |5 +
2 files changed, 21 insertions(+), 8 deletions(-)
New commits:
commit 6989c3df0facf3a5cb373942c337cbc7879fc0db
Author: Noel Grandin
AuthorDate: Wed May 19 15:24:42 2021 +0200
Commit: Noel Grandin
CommitDate: Wed May 19 19:20:32 2021 +0200
fix crash in X-Ray extension
caused by
commit 883b7a34d288410ac6f820e91d9eaa65ba2b9cb1
DBG_ASSERT->assert in UnoWrapper
No idea why X-ray is triggering this, but it seems to work when I dial
it back to a SAL_WARN again
And also caused by
commit 5aa60be574ece81b27c8f63e6e809871c694dba0
fix leak in VCLXWindow
So disconnect the toolkit-window-peer from the vcl::Window before
disposing the peer.
Change-Id: I3310b76c1affc13c53c1e23810e383a8d2152ec7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115806
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/toolkit/source/helper/unowrapper.cxx
b/toolkit/source/helper/unowrapper.cxx
index 8474b45399c4..a83cd540ba5e 100644
--- a/toolkit/source/helper/unowrapper.cxx
+++ b/toolkit/source/helper/unowrapper.cxx
@@ -170,16 +170,24 @@ void UnoWrapper::SetWindowInterface( vcl::Window*
pWindow, const css::uno::Refer
if ( !pVCLXWindow )
return;
-css::uno::Reference< css::awt::XWindowPeer> xPeer =
pWindow->GetWindowPeer();
-if( xPeer.is() )
+if (!pWindow)
+{
+// we are disconnecting a peer from a window
+pVCLXWindow->SetWindow( nullptr );
+}
+else
{
-bool bSameInstance( pVCLXWindow == dynamic_cast< VCLXWindow* >(
xPeer.get() ));
-assert( bSameInstance && "UnoWrapper::SetWindowInterface: there is
already a WindowPeer/ComponentInterface for this VCL window" );
-if ( bSameInstance )
-return;
+css::uno::Reference< css::awt::XWindowPeer> xPeer =
pWindow->GetWindowPeer();
+if( xPeer.is() )
+{
+bool bSameInstance( pVCLXWindow == dynamic_cast< VCLXWindow* >(
xPeer.get() ));
+SAL_WARN_IF( !bSameInstance, "toolkit.helper",
"UnoWrapper::SetWindowInterface: there is already a
WindowPeer/ComponentInterface for this VCL window" );
+if ( bSameInstance )
+return;
+}
+pVCLXWindow->SetWindow( pWindow );
+pWindow->SetWindowPeer( xIFace, pVCLXWindow );
}
-pVCLXWindow->SetWindow( pWindow );
-pWindow->SetWindowPeer( xIFace, pVCLXWindow );
}
css::uno::Reference UnoWrapper::CreateMenuInterface(
PopupMenu* pPopupMenu )
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 0a279983d02d..fa3cb12133d5 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -3129,6 +3129,11 @@ void Window::SetWindowPeer( Reference<
css::awt::XWindowPeer > const & xPeer, VC
// be safe against re-entrance: first clear the old ref, then assign the
new one
if (mpWindowImpl->mxWindowPeer)
{
+// first, disconnect the peer from ourself, otherwise disposing it,
will dispose us
+UnoWrapperBase* pWrapper = UnoWrapperBase::GetUnoWrapper();
+SAL_WARN_IF( !pWrapper, "vcl.window", "SetComponentInterface: No
Wrapper!" );
+if ( pWrapper )
+pWrapper->SetWindowInterface( nullptr, mpWindowImpl->mxWindowPeer
);
mpWindowImpl->mxWindowPeer->dispose();
mpWindowImpl->mxWindowPeer.clear();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/modules/installer/simplepackage.pm |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
New commits:
commit 3f72d4d68817210ef6852e83d6d4bbdb540cea18
Author: Christian Lohmaier
AuthorDate: Wed May 19 15:34:54 2021 +0200
Commit: Christian Lohmaier
CommitDate: Wed May 19 19:17:10 2021 +0200
mac packaging: don't throw away codesign output for langpacks
The change to use backticks to capture the output was already done for
the main package in 6c4cb4e7e0afce2989c9fe596fd74a35eece6206, this
change now also fixes it for the langpacks
Change-Id: I26dcfb56342b9c3fc7b9c93f7d586c5c899b7232
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115808
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier
diff --git a/solenv/bin/modules/installer/simplepackage.pm
b/solenv/bin/modules/installer/simplepackage.pm
index 13dc81c0060a..e134eb4185ad 100644
--- a/solenv/bin/modules/installer/simplepackage.pm
+++ b/solenv/bin/modules/installer/simplepackage.pm
@@ -392,11 +392,12 @@ sub create_package
chdir $localfrom;
if ( $ENV{'MACOSX_CODESIGNING_IDENTITY'} ) {
-my @lp_sign = ('codesign', '--verbose', '--sign',
$ENV{'MACOSX_CODESIGNING_IDENTITY'}, '--deep', $appfolder);
-if (system(@lp_sign) == 0) {
-$infoline = "Success: \"@lp_sign\" executed
successfully!\n";
+my $lp_sign = "codesign --verbose --sign
$ENV{'MACOSX_CODESIGNING_IDENTITY'} --deep '$appfolder'" ;
+my $output = `$lp_sign 2>&1`;
+unless ($?) {
+$infoline = "Success: \"$lp_sign\" executed
successfully!\n";
} else {
-$infoline = "ERROR: Could not codesign the languagepack
using \"@lp_sign\"!\n";
+$infoline = "ERROR: Could not codesign the languagepack
using \"$lp_sign\"!\n$output\n";
}
push( @installer::globals::logfileinfo, $infoline);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118614] When a form showing a date field containing a valid date is exported as a PDF file with "Create PDF form" checked, the resultant PDF file shows an empty field.
https://bugs.documentfoundation.org/show_bug.cgi?id=118614 mgx0...@gmail.com changed: What|Removed |Added URL||https://crazymedium.com Whiteboard||PDF Books --- Comment #7 from mgx0...@gmail.com --- Thanks for sharing this -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142380] New: DRY: Use CSS variables to eliminate repetition
https://bugs.documentfoundation.org/show_bug.cgi?id=142380 Bug ID: 142380 Summary: DRY: Use CSS variables to eliminate repetition Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: low Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fit...@ubuntu.com CC: olivier.hal...@libreoffice.org Blocks: 97629 Use CSS variables so that values like font families and colors can be defined only once, and colors can be derived in a systematic, consistent fashion. All major browsers support them now. https://caniuse.com/css-variables Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97629 [Bug 97629] [META] Help Content Modernization -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97629] [META] Help Content Modernization
https://bugs.documentfoundation.org/show_bug.cgi?id=97629 Adolfo Jayme changed: What|Removed |Added Depends on||142380 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142380 [Bug 142380] DRY: Use CSS variables to eliminate repetition -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142367] Writer crashes when opening docx (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=142367 Noel Grandin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142285] "Scroll Here" on scrollbar can't be performed (neither with shift+click nor right+click on it)
https://bugs.documentfoundation.org/show_bug.cgi?id=142285 Heiko Tietze changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142254] UI: Navigator shows deleted images - still in track changes - while show track changes being disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=142254 --- Comment #5 from Heiko Tietze --- Consistency with the document where you still see the object. Sure, if TC are not shown we could hide the deleted content from the Navigator as well. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142379] New: Incorrect shape scaling silhouette
https://bugs.documentfoundation.org/show_bug.cgi?id=142379 Bug ID: 142379 Summary: Incorrect shape scaling silhouette Product: LibreOffice Version: 7.1.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jonatan.per...@gmail.com Description: When I try to scale either the height or the width of a shape it shows the silhouette as if I were scaling the whole shape. Steps to Reproduce: 1.Draw a basic shape on Impress 2.Try to scale the height Actual Results: Shows the silhouette as if I were scaling the whole shape. Expected Results: Shows the silhouette as if I were scaling the height. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.3.2 (x64) / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142288] FORMATTING: Impress "Screen 16:9/4:3" and PowerPoint "On-screen Show (16:9/4:3)" are different format
https://bugs.documentfoundation.org/show_bug.cgi?id=142288 --- Comment #6 from Heiko Tietze --- (In reply to Regina Henschel from comment #5) > I would only add such formats to the list of named formats. To duplicate the screen presentation formats sounds weird and confusing to me. * Screen 16:9 * Screen 16:10 * Screen 4:3 * On-Screen Show 16:9 * On-Screen Show 16:10 * On-Screen Show 4:3 Average users wonder what the difference between Screen and On-Screen Show might be. And the inch-crooked values are in the list anyway. Thought https://en.wikipedia.org/wiki/Display_size could be a basis for reasoning but neither 25.4 nor 28cm fit on typical displays and need scaling. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/animations/CustomAnimationPane.cxx |7 ++-
sd/source/ui/inc/CustomAnimationPane.hxx|1 +
2 files changed, 7 insertions(+), 1 deletion(-)
New commits:
commit 7bce577cca9e6ca24879affa6398f8fda840d921
Author: Caolán McNamara
AuthorDate: Wed May 19 14:37:10 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed May 19 18:23:21 2021 +0200
use toggle instead of click for CheckButton
Change-Id: I0cbe6cd1b93557ceba535a835c4a199761ca5f00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115812
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sd/source/ui/animations/CustomAnimationPane.cxx
b/sd/source/ui/animations/CustomAnimationPane.cxx
index 485d4de91e3d..2c7df6d9242a 100644
--- a/sd/source/ui/animations/CustomAnimationPane.cxx
+++ b/sd/source/ui/animations/CustomAnimationPane.cxx
@@ -182,7 +182,7 @@ void CustomAnimationPane::initialize()
mxPBMoveUp->connect_clicked( LINK( this, CustomAnimationPane, implClickHdl
) );
mxPBMoveDown->connect_clicked( LINK( this, CustomAnimationPane,
implClickHdl ) );
mxPBPlay->connect_clicked( LINK( this, CustomAnimationPane, implClickHdl )
);
-mxCBAutoPreview->connect_clicked( LINK( this, CustomAnimationPane,
implClickHdl ) );
+mxCBAutoPreview->connect_toggled( LINK( this, CustomAnimationPane,
implToggleHdl ) );
mxLBCategory->connect_changed( LINK(this, CustomAnimationPane,
UpdateAnimationLB) );
mxMFStartDelay->connect_value_changed( LINK(this, CustomAnimationPane,
DelayModifiedHdl) );
mxMFStartDelay->connect_focus_out(LINK( this, CustomAnimationPane,
DelayLoseFocusHdl));
@@ -2241,6 +2241,11 @@ sal_Int32 CustomAnimationPane::fillAnimationLB( bool
bHasText )
return nFirstEffect;
}
+IMPL_LINK(CustomAnimationPane, implToggleHdl, weld::ToggleButton&, rBtn, void)
+{
+implControlHdl();
+}
+
IMPL_LINK(CustomAnimationPane, implClickHdl, weld::Button&, rBtn, void)
{
implControlHdl();
diff --git a/sd/source/ui/inc/CustomAnimationPane.hxx
b/sd/source/ui/inc/CustomAnimationPane.hxx
index ff6fa75609e1..80d2aa4eef10 100644
--- a/sd/source/ui/inc/CustomAnimationPane.hxx
+++ b/sd/source/ui/inc/CustomAnimationPane.hxx
@@ -102,6 +102,7 @@ private:
DECL_LINK( implControlListBoxHdl, weld::ComboBox&, void );
DECL_LINK( implClickHdl, weld::Button&, void );
+DECL_LINK( implToggleHdl, weld::ToggleButton&, void );
DECL_LINK( implPropertyHdl, LinkParamNone*, void );
DECL_LINK( EventMultiplexerListener, tools::EventMultiplexerEvent&, void );
DECL_LINK( lateInitCallback, Timer *, void );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - extras/source
extras/source/autocorr/lang/ko/DocumentList.xml |1 - 1 file changed, 1 deletion(-) New commits: commit 8969b8959cd0292d2be1a43130ef7fbd89adfe81 Author: U-DESKTOP-042UROI\dhsung AuthorDate: Wed May 19 20:26:06 2021 +0900 Commit: Caolán McNamara CommitDate: Wed May 19 18:23:05 2021 +0200 Delete duplicated item in Korean autocorr list Delete duplicated item in Korean autocurr list (DocumentList.xml) Change-Id: I3cfaf27abb859dbcfc849082932006d20d0b22ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115799 Tested-by: Jenkins Reviewed-by: Caolán McNamara (cherry picked from commit be622ccf9b60290d0577314ac9d76fbcf1cce636) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115832 diff --git a/extras/source/autocorr/lang/ko/DocumentList.xml b/extras/source/autocorr/lang/ko/DocumentList.xml index 1cbf7330c36c..6f045f5e1086 100644 --- a/extras/source/autocorr/lang/ko/DocumentList.xml +++ b/extras/source/autocorr/lang/ko/DocumentList.xml @@ -2379,7 +2379,6 @@ - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142367] Writer crashes when opening docx (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=142367 --- Comment #4 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/819b30e937d227d1458ecc22b09ef994ebe7e17e tdf#142367 Writer crashes when opening docx It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142367] Writer crashes when opening docx (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=142367 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/AnnotationWin.hxx |3 +++
sw/source/uibase/docvw/AnnotationWin.cxx |1 +
sw/source/uibase/docvw/AnnotationWin2.cxx | 15 +--
3 files changed, 13 insertions(+), 6 deletions(-)
New commits:
commit 819b30e937d227d1458ecc22b09ef994ebe7e17e
Author: Noel Grandin
AuthorDate: Wed May 19 14:47:19 2021 +0200
Commit: Noel Grandin
CommitDate: Wed May 19 18:18:53 2021 +0200
tdf#142367 Writer crashes when opening docx
regression from
commit 5aa60be574ece81b27c8f63e6e809871c694dba0
fix leak in VCLXWindow
Make SwAnnotationWin follow the same pattern as all the other code and
return a custom accessibility object instead of trying to override the
toolkit peer object.
Change-Id: Ifa3a5da2fbbf082e6bb05281cc9d354d6ec3ba03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115805
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/AnnotationWin.hxx b/sw/inc/AnnotationWin.hxx
index f1ba8a499589..6cf6760aeb2b 100644
--- a/sw/inc/AnnotationWin.hxx
+++ b/sw/inc/AnnotationWin.hxx
@@ -49,6 +49,7 @@ namespace sw::sidebarwindows {
class SidebarTextControl;
class AnchorOverlayObject;
class ShadowOverlayObject;
+class SidebarWinAccessible;
}
@@ -271,6 +272,8 @@ class SAL_DLLPUBLIC_RTTI SwAnnotationWin : public
InterimItemWindow
SwFormatField* mpFormatField;
SwPostItField* mpField;
+
+rtl::Reference
mxSidebarWinAccessible;
};
} // end of namespace sw::annotation
diff --git a/sw/source/uibase/docvw/AnnotationWin.cxx
b/sw/source/uibase/docvw/AnnotationWin.cxx
index 49ea845944b8..e354a62204a8 100644
--- a/sw/source/uibase/docvw/AnnotationWin.cxx
+++ b/sw/source/uibase/docvw/AnnotationWin.cxx
@@ -62,6 +62,7 @@
#include "AnchorOverlayObject.hxx"
#include "OverlayRanges.hxx"
#include "SidebarTxtControl.hxx"
+#include "SidebarWinAcc.hxx"
#include
diff --git a/sw/source/uibase/docvw/AnnotationWin2.cxx
b/sw/source/uibase/docvw/AnnotationWin2.cxx
index f463bf7597f1..b2604377e2e0 100644
--- a/sw/source/uibase/docvw/AnnotationWin2.cxx
+++ b/sw/source/uibase/docvw/AnnotationWin2.cxx
@@ -1376,8 +1376,8 @@ void SwAnnotationWin::ChangeSidebarItem( SwSidebarItem
const & rSidebarItem )
mrSidebarItem = rSidebarItem;
mpAnchorFrame = mrSidebarItem.maLayoutInfo.mpAnchorFrame;
-if (SidebarWinAccessible* pAcc =
dynamic_cast(GetWindowPeer()))
-pAcc->ChangeSidebarItem( mrSidebarItem );
+if (mxSidebarWinAccessible)
+mxSidebarWinAccessible->ChangeSidebarItem( mrSidebarItem );
if ( bAnchorChanged )
{
@@ -1389,11 +1389,14 @@ void SwAnnotationWin::ChangeSidebarItem( SwSidebarItem
const & rSidebarItem )
css::uno::Reference< css::accessibility::XAccessible >
SwAnnotationWin::CreateAccessible()
{
-rtl::Reference pAcc( new SidebarWinAccessible( *this,
+// This is rather dodgy code. Normally in CreateAccessible, if we want a
custom
+// object, we return a custom object, but we do no override the default
toolkit
+// window peer.
+if (!mxSidebarWinAccessible)
+mxSidebarWinAccessible = new SidebarWinAccessible( *this,
mrView.GetWrtShell(),
- mrSidebarItem ) );
-SetWindowPeer( pAcc, pAcc.get() );
-return pAcc;
+ mrSidebarItem );
+return mxSidebarWinAccessible;
}
} // eof of namespace sw::sidebarwindows
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142084] Order inversion of accented letters when typed in table cells
https://bugs.documentfoundation.org/show_bug.cgi?id=142084 --- Comment #2 from J-F Thibault --- Indeed, the problem only occurs when typing directly, not through copy-paste. After checking out this bug https://bugs.documentfoundation.org/show_bug.cgi?id=136687 which is similar, I confirm that unchecking "Track Changes / Show" greatly reduces the propensity of the problem, but does not eliminate it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmlsecurity/source
xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx | 473 --
1 file changed, 228 insertions(+), 245 deletions(-)
New commits:
commit 585948aadf10f6eab7d716857fc671da2d421318
Author: Noel Grandin
AuthorDate: Wed May 19 15:52:52 2021 +0200
Commit: Noel Grandin
CommitDate: Wed May 19 18:16:50 2021 +0200
flatten SecurityEnvironment_NssImpl
Change-Id: I89e098c7ff913dfbc2cafbf0cdbabfbbca69110a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115813
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
index 21524c37163b..d7e85f577cbf 100644
--- a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
@@ -320,53 +320,53 @@ SecurityEnvironment_NssImpl::getPersonalCertificates()
Reference< XCertificate > SecurityEnvironment_NssImpl::getCertificate( const
OUString& issuerName, const Sequence< sal_Int8 >& serialNumber )
{
-rtl::Reference xcert;
-
-if( m_pHandler != nullptr ) {
-CERTIssuerAndSN issuerAndSN ;
-CERTCertificate* cert ;
-CERTName* nmIssuer ;
-char* chIssuer ;
-SECItem* derIssuer ;
-std::unique_ptr
arena(PORT_NewArena(DER_DEFAULT_CHUNKSIZE));
-if( arena == nullptr )
-throw RuntimeException() ;
+if( !m_pHandler )
+return nullptr;
-// Create cert info from issue and serial
-OString ostr = OUStringToOString( issuerName , RTL_TEXTENCODING_UTF8 )
;
-chIssuer = PL_strndup( ostr.getStr(),
static_cast(ostr.getLength()) ) ;
-nmIssuer = CERT_AsciiToName( chIssuer ) ;
-if( nmIssuer == nullptr ) {
-PL_strfree( chIssuer ) ;
-return nullptr; // no need for exception cf. i40394
-}
+rtl::Reference xcert;
+CERTIssuerAndSN issuerAndSN ;
+CERTCertificate* cert ;
+CERTName* nmIssuer ;
+char* chIssuer ;
+SECItem* derIssuer ;
+std::unique_ptr arena(PORT_NewArena(DER_DEFAULT_CHUNKSIZE));
+if( arena == nullptr )
+throw RuntimeException() ;
-derIssuer = SEC_ASN1EncodeItem( arena.get(), nullptr,
static_cast(nmIssuer), SEC_ASN1_GET( CERT_NameTemplate ) ) ;
-if( derIssuer == nullptr ) {
-PL_strfree( chIssuer ) ;
-CERT_DestroyName( nmIssuer ) ;
-throw RuntimeException() ;
-}
+// Create cert info from issue and serial
+OString ostr = OUStringToOString( issuerName , RTL_TEXTENCODING_UTF8 ) ;
+chIssuer = PL_strndup( ostr.getStr(), static_cast(ostr.getLength()) )
;
+nmIssuer = CERT_AsciiToName( chIssuer ) ;
+if( nmIssuer == nullptr ) {
+PL_strfree( chIssuer ) ;
+return nullptr; // no need for exception cf. i40394
+}
-memset( , 0, sizeof( issuerAndSN ) ) ;
+derIssuer = SEC_ASN1EncodeItem( arena.get(), nullptr,
static_cast(nmIssuer), SEC_ASN1_GET( CERT_NameTemplate ) ) ;
+if( derIssuer == nullptr ) {
+PL_strfree( chIssuer ) ;
+CERT_DestroyName( nmIssuer ) ;
+throw RuntimeException() ;
+}
-issuerAndSN.derIssuer.data = derIssuer->data ;
-issuerAndSN.derIssuer.len = derIssuer->len ;
+memset( , 0, sizeof( issuerAndSN ) ) ;
-issuerAndSN.serialNumber.data = reinterpret_cast(const_cast(serialNumber.getConstArray()));
-issuerAndSN.serialNumber.len = serialNumber.getLength() ;
+issuerAndSN.derIssuer.data = derIssuer->data ;
+issuerAndSN.derIssuer.len = derIssuer->len ;
-cert = CERT_FindCertByIssuerAndSN( m_pHandler, ) ;
-if( cert != nullptr ) {
-xcert = NssCertToXCert( cert ) ;
-}
+issuerAndSN.serialNumber.data = reinterpret_cast(const_cast(serialNumber.getConstArray()));
+issuerAndSN.serialNumber.len = serialNumber.getLength() ;
-PL_strfree( chIssuer ) ;
-CERT_DestroyName( nmIssuer ) ;
-//SECITEM_FreeItem( derIssuer, PR_FALSE ) ;
-CERT_DestroyCertificate( cert ) ;
+cert = CERT_FindCertByIssuerAndSN( m_pHandler, ) ;
+if( cert != nullptr ) {
+xcert = NssCertToXCert( cert ) ;
}
+PL_strfree( chIssuer ) ;
+CERT_DestroyName( nmIssuer ) ;
+//SECITEM_FreeItem( derIssuer, PR_FALSE ) ;
+CERT_DestroyCertificate( cert ) ;
+
return xcert ;
}
@@ -374,50 +374,41 @@ Sequence< Reference < XCertificate > >
SecurityEnvironment_NssImpl::buildCertifi
// Remember the signing certificate.
m_xSigningCertificate = begin;
-const X509Certificate_NssImpl* xcert ;
-const CERTCertificate* cert ;
-CERTCertList* certChain ;
-
Reference< XUnoTunnel > xCertTunnel( begin, UNO_QUERY_THROW ) ;
-xcert = reinterpret_cast(
+const X509Certificate_NssImpl* xcert =
reinterpret_cast(
sal::static_int_cast(xCertTunnel->getSomething(
[Libreoffice-commits] core.git: xmlsecurity/source
xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 928ce6043523a70d056d15210296d627d6223c2f
Author: Noel Grandin
AuthorDate: Wed May 19 15:55:48 2021 +0200
Commit: Noel Grandin
CommitDate: Wed May 19 18:17:11 2021 +0200
fix leak in verifyCertificate
Change-Id: I49dd9e0de9b3e44186ed90f00aeb88dad4736374
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115814
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
index d7e85f577cbf..081d37e0a01d 100644
--- a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
@@ -716,6 +716,7 @@ verifyCertificate( const Reference< csss::XCertificate >&
aCert,
SAL_INFO("xmlsecurity.xmlsec", "Destroying temporary certificate");
CERT_DestroyCertificate(tmpCert);
}
+PORT_FreeArena(log.arena, true);
return validity ;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90088] BASE: Basic instruction moveToInsertRow doesn't scroll to actual insert row if there are more than approximately 45 records in a grid control
https://bugs.documentfoundation.org/show_bug.cgi?id=90088 --- Comment #11 from Lionel Elie Mamane --- There are two moveToInsertRow() in the API. com::sun::star::sdbc::XResultSetUpdate::moveToInsertRow() or com::sun::star::form::runtime::FormFeature::MoveToInsertRow() My guess is about the latter. (In reply to Alex Thurgood from comment #10) > @Lionel : guessing that this has something to do with the way the UI > displays a cached subset of the resultset which doesn't get refreshed ? My guess is more that it is linked to the lazy loading of rows (when the UI displays a "*" next to the number of rows to say that not all rows are loaded yet). In that case, it can probably be worked around by: moveToLast() to force loading of all rows, then only moveToInsertRow() -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142364] Crash when closing document after canceling chart wizard (Writer)
https://bugs.documentfoundation.org/show_bug.cgi?id=142364 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #1 from Caolán McNamara --- I wonder if that always threw an exception, just that now its in a destructor that's fatal -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141567] Copy and Paste in Basic Editor pastes text twice
https://bugs.documentfoundation.org/show_bug.cgi?id=141567 --- Comment #5 from Olivier Hallot --- I found that Ctrl+ V paste twice, (Ctrl+C, Ctrl+V are usual copy for 99.99% of users). but Shft-Ins does not paste twice. (Ctrl+Ins and Shift+Ins are for the rest of users) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: icon-themes/sukapura icon-themes/sukapura_svg
icon-themes/sukapura/cmd/32/redo.png |binary icon-themes/sukapura/cmd/32/repeat.png |binary icon-themes/sukapura/cmd/32/undo.png |binary icon-themes/sukapura/cmd/lc_redo.png |binary icon-themes/sukapura/cmd/lc_repeat.png |binary icon-themes/sukapura/cmd/lc_undo.png |binary icon-themes/sukapura/cmd/sc_redo.png |binary icon-themes/sukapura/cmd/sc_repeat.png |binary icon-themes/sukapura/cmd/sc_undo.png |binary icon-themes/sukapura_svg/cmd/32/redo.svg |2 +- icon-themes/sukapura_svg/cmd/32/repeat.svg |2 +- icon-themes/sukapura_svg/cmd/32/undo.svg |2 +- icon-themes/sukapura_svg/cmd/lc_redo.svg |2 +- icon-themes/sukapura_svg/cmd/lc_repeat.svg |2 +- icon-themes/sukapura_svg/cmd/lc_undo.svg |2 +- icon-themes/sukapura_svg/cmd/sc_redo.svg |9 ++--- icon-themes/sukapura_svg/cmd/sc_repeat.svg |9 ++--- icon-themes/sukapura_svg/cmd/sc_undo.svg |9 ++--- 18 files changed, 24 insertions(+), 15 deletions(-) New commits: commit 07174ebe5bb5351f19d57ec5123a0efdfb6f5539 Author: Rizal Muttaqin AuthorDate: Wed May 19 16:43:12 2021 +0700 Commit: Rizal Muttaqin CommitDate: Wed May 19 17:46:10 2021 +0200 Sukapura: Update Undo & Redo, Repeat icons Change-Id: I142d4f49882fcb98bbf6502d0e4a96d212b58e2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115793 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos Reviewed-by: Rizal Muttaqin diff --git a/icon-themes/sukapura/cmd/32/redo.png b/icon-themes/sukapura/cmd/32/redo.png index d775b3d1b221..a9ed45f5f2cc 100644 Binary files a/icon-themes/sukapura/cmd/32/redo.png and b/icon-themes/sukapura/cmd/32/redo.png differ diff --git a/icon-themes/sukapura/cmd/32/repeat.png b/icon-themes/sukapura/cmd/32/repeat.png index 8b34859bdeb9..5bcc9de5241d 100644 Binary files a/icon-themes/sukapura/cmd/32/repeat.png and b/icon-themes/sukapura/cmd/32/repeat.png differ diff --git a/icon-themes/sukapura/cmd/32/undo.png b/icon-themes/sukapura/cmd/32/undo.png index dd37612846bf..9032f6b79d6a 100644 Binary files a/icon-themes/sukapura/cmd/32/undo.png and b/icon-themes/sukapura/cmd/32/undo.png differ diff --git a/icon-themes/sukapura/cmd/lc_redo.png b/icon-themes/sukapura/cmd/lc_redo.png index dd0ae59ed87a..c7f40d50a903 100644 Binary files a/icon-themes/sukapura/cmd/lc_redo.png and b/icon-themes/sukapura/cmd/lc_redo.png differ diff --git a/icon-themes/sukapura/cmd/lc_repeat.png b/icon-themes/sukapura/cmd/lc_repeat.png index 573835b79543..cf3735cb2319 100644 Binary files a/icon-themes/sukapura/cmd/lc_repeat.png and b/icon-themes/sukapura/cmd/lc_repeat.png differ diff --git a/icon-themes/sukapura/cmd/lc_undo.png b/icon-themes/sukapura/cmd/lc_undo.png index f7e513381a84..8294ac720ee3 100644 Binary files a/icon-themes/sukapura/cmd/lc_undo.png and b/icon-themes/sukapura/cmd/lc_undo.png differ diff --git a/icon-themes/sukapura/cmd/sc_redo.png b/icon-themes/sukapura/cmd/sc_redo.png index ada79c4152ab..59da338134e4 100644 Binary files a/icon-themes/sukapura/cmd/sc_redo.png and b/icon-themes/sukapura/cmd/sc_redo.png differ diff --git a/icon-themes/sukapura/cmd/sc_repeat.png b/icon-themes/sukapura/cmd/sc_repeat.png index 614cbb4a3141..4269ea5631ce 100644 Binary files a/icon-themes/sukapura/cmd/sc_repeat.png and b/icon-themes/sukapura/cmd/sc_repeat.png differ diff --git a/icon-themes/sukapura/cmd/sc_undo.png b/icon-themes/sukapura/cmd/sc_undo.png index 6b25ebedc378..54f5368d7aa7 100644 Binary files a/icon-themes/sukapura/cmd/sc_undo.png and b/icon-themes/sukapura/cmd/sc_undo.png differ diff --git a/icon-themes/sukapura_svg/cmd/32/redo.svg b/icon-themes/sukapura_svg/cmd/32/redo.svg index 721b546d3da3..5098e77f230d 100644 --- a/icon-themes/sukapura_svg/cmd/32/redo.svg +++ b/icon-themes/sukapura_svg/cmd/32/redo.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/sukapura_svg/cmd/32/repeat.svg b/icon-themes/sukapura_svg/cmd/32/repeat.svg index dd116a4149b6..39e06f885213 100644 --- a/icon-themes/sukapura_svg/cmd/32/repeat.svg +++ b/icon-themes/sukapura_svg/cmd/32/repeat.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/sukapura_svg/cmd/32/undo.svg b/icon-themes/sukapura_svg/cmd/32/undo.svg index 8ef2f36f9574..36536daec3d5 100644 --- a/icon-themes/sukapura_svg/cmd/32/undo.svg +++ b/icon-themes/sukapura_svg/cmd/32/undo.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git
[Libreoffice-bugs] [Bug 142378] New: FILEOPEN DOCX corner style is 'Rounded' but should be 'Mitered'
https://bugs.documentfoundation.org/show_bug.cgi?id=142378 Bug ID: 142378 Summary: FILEOPEN DOCX corner style is 'Rounded' but should be 'Mitered' Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 172176 --> https://bugs.documentfoundation.org/attachment.cgi?id=172176=edit Document with shape "Star" Open attached document. It contains a shape "Star" and a screenshot, how it looks in Word. The shape should have the corner style 'Mitered', but it is imported as 'Rounded'. The error is only in Writer. The same object in pptx opens fine in Impress. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141567] Copy and Paste in Basic Editor pastes text twice
https://bugs.documentfoundation.org/show_bug.cgi?id=141567 --- Comment #4 from Olivier Hallot --- does not happen with gen interface: Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: 5d8ac801c00fbf1dc16ee8dbfe8167baf7ea0ce0 CPU threads: 16; OS: Linux 5.11; UI render: Skia/Raster; VCL: x11 Locale: en-US (en_US.UTF-8); UI: pt-BR Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142119] calc: crash: 7.2.0.0.a0+ from 2021-05-06 4:55:12 doesn't start - crashes - in win7-64,
https://bugs.documentfoundation.org/show_bug.cgi?id=142119 Telesto changed: What|Removed |Added Keywords|regression | Resolution|--- |NOTOURBUG Status|UNCONFIRMED |RESOLVED --- Comment #14 from Telesto --- Ps. no clue what the proper status would be.. but because we are talking about Master.. let's opt for NOTOURBUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/inc sfx2/source
sfx2/inc/emojicontrol.hxx|4 ++--
sfx2/source/control/emojicontrol.cxx | 22 +++---
2 files changed, 13 insertions(+), 13 deletions(-)
New commits:
commit 749be84cefbce1c24b46ab8cc296064216087312
Author: Caolán McNamara
AuthorDate: Wed May 19 14:06:14 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed May 19 17:06:52 2021 +0200
use toggle instead of click for ToggleButton
Change-Id: Ia2382e030bb668528e0ad56fd91b19e8621531f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115810
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sfx2/inc/emojicontrol.hxx b/sfx2/inc/emojicontrol.hxx
index 2e2ab150762f..787405d101fb 100644
--- a/sfx2/inc/emojicontrol.hxx
+++ b/sfx2/inc/emojicontrol.hxx
@@ -36,9 +36,9 @@ public:
private:
static void ConvertLabelToUnicode(weld::ToggleButton& rBtn);
-FILTER_CATEGORY getFilter(const weld::Button& rBtn) const;
+FILTER_CATEGORY getFilter(const weld::ToggleButton& rBtn) const;
-DECL_LINK(ActivatePageHdl, weld::Button&, void);
+DECL_LINK(ActivatePageHdl, weld::ToggleButton&, void);
DECL_STATIC_LINK(SfxEmojiControl, InsertHdl, ThumbnailViewItem*, void);
std::unique_ptr mxPeopleBtn;
diff --git a/sfx2/source/control/emojicontrol.cxx
b/sfx2/source/control/emojicontrol.cxx
index c3e9910ddacd..0d51ce805e68 100644
--- a/sfx2/source/control/emojicontrol.cxx
+++ b/sfx2/source/control/emojicontrol.cxx
@@ -62,15 +62,15 @@ SfxEmojiControl::SfxEmojiControl(const EmojiPopup*
pControl, weld::Widget* pPare
ConvertLabelToUnicode(*mxFlagsBtn);
ConvertLabelToUnicode(*mxUnicode9Btn);
-mxPeopleBtn->connect_clicked(LINK(this, SfxEmojiControl, ActivatePageHdl));
-mxNatureBtn->connect_clicked(LINK(this, SfxEmojiControl, ActivatePageHdl));
-mxFoodBtn->connect_clicked(LINK(this, SfxEmojiControl, ActivatePageHdl));
-mxActivityBtn->connect_clicked(LINK(this, SfxEmojiControl,
ActivatePageHdl));
-mxTravelBtn->connect_clicked(LINK(this, SfxEmojiControl, ActivatePageHdl));
-mxObjectsBtn->connect_clicked(LINK(this, SfxEmojiControl,
ActivatePageHdl));
-mxSymbolsBtn->connect_clicked(LINK(this, SfxEmojiControl,
ActivatePageHdl));
-mxFlagsBtn->connect_clicked(LINK(this, SfxEmojiControl, ActivatePageHdl));
-mxUnicode9Btn->connect_clicked(LINK(this, SfxEmojiControl,
ActivatePageHdl));
+mxPeopleBtn->connect_toggled(LINK(this, SfxEmojiControl, ActivatePageHdl));
+mxNatureBtn->connect_toggled(LINK(this, SfxEmojiControl, ActivatePageHdl));
+mxFoodBtn->connect_toggled(LINK(this, SfxEmojiControl, ActivatePageHdl));
+mxActivityBtn->connect_toggled(LINK(this, SfxEmojiControl,
ActivatePageHdl));
+mxTravelBtn->connect_toggled(LINK(this, SfxEmojiControl, ActivatePageHdl));
+mxObjectsBtn->connect_toggled(LINK(this, SfxEmojiControl,
ActivatePageHdl));
+mxSymbolsBtn->connect_toggled(LINK(this, SfxEmojiControl,
ActivatePageHdl));
+mxFlagsBtn->connect_toggled(LINK(this, SfxEmojiControl, ActivatePageHdl));
+mxUnicode9Btn->connect_toggled(LINK(this, SfxEmojiControl,
ActivatePageHdl));
mxEmojiView->setItemMaxTextLength(ITEM_MAX_TEXT_LENGTH);
mxEmojiView->setItemDimensions(ITEM_MAX_WIDTH, 0, ITEM_MAX_HEIGHT,
ITEM_PADDING);
@@ -99,7 +99,7 @@ void
SfxEmojiControl::ConvertLabelToUnicode(weld::ToggleButton& rBtn)
rBtn.set_label(sHexText.toString());
}
-FILTER_CATEGORY SfxEmojiControl::getFilter(const weld::Button& rCurPageId)
const
+FILTER_CATEGORY SfxEmojiControl::getFilter(const weld::ToggleButton&
rCurPageId) const
{
if ( == mxPeopleBtn.get())
return FILTER_CATEGORY::PEOPLE;
@@ -123,7 +123,7 @@ FILTER_CATEGORY SfxEmojiControl::getFilter(const
weld::Button& rCurPageId) const
return FILTER_CATEGORY::PEOPLE;
}
-IMPL_LINK(SfxEmojiControl, ActivatePageHdl, weld::Button&, rButton, void)
+IMPL_LINK(SfxEmojiControl, ActivatePageHdl, weld::ToggleButton&, rButton, void)
{
mxPeopleBtn->set_active( == mxPeopleBtn.get());
mxNatureBtn->set_active( == mxNatureBtn.get());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/sfx2 sfx2/source
include/sfx2/printopt.hxx |6 +++---
include/sfx2/templatedlg.hxx|4 ++--
sfx2/source/dialog/printopt.cxx | 12 ++--
sfx2/source/dialog/templdlg.cxx |4 ++--
sfx2/source/dialog/versdlg.cxx | 16 ++--
sfx2/source/doc/templatedlg.cxx |8
sfx2/source/inc/templdgi.hxx|2 +-
sfx2/source/inc/versdlg.hxx |1 +
8 files changed, 29 insertions(+), 24 deletions(-)
New commits:
commit 747394659c5f0aa71053d84fc9fc4bee75fc34ef
Author: Caolán McNamara
AuthorDate: Wed May 19 14:16:46 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed May 19 17:07:09 2021 +0200
use toggle instead of click for ToggleButton
Change-Id: I8a1c6620cf009807cc43766b0cc972523e87e9c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115811
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/sfx2/printopt.hxx b/include/sfx2/printopt.hxx
index d93284f345a5..2a9992d26daf 100644
--- a/include/sfx2/printopt.hxx
+++ b/include/sfx2/printopt.hxx
@@ -60,9 +60,9 @@ private:
DECL_DLLPRIVATE_LINK( ToggleOutputPrinterRBHdl,
weld::ToggleButton&, void );
DECL_DLLPRIVATE_LINK( ToggleOutputPrintFileRBHdl,
weld::ToggleButton&, void);
-DECL_DLLPRIVATE_LINK( ClickReduceTransparencyCBHdl,
weld::Button&, void );
-DECL_DLLPRIVATE_LINK( ClickReduceGradientsCBHdl,
weld::Button&, void );
-DECL_DLLPRIVATE_LINK( ClickReduceBitmapsCBHdl,
weld::Button&, void );
+DECL_DLLPRIVATE_LINK( ClickReduceTransparencyCBHdl,
weld::ToggleButton&, void );
+DECL_DLLPRIVATE_LINK( ClickReduceGradientsCBHdl,
weld::ToggleButton&, void );
+DECL_DLLPRIVATE_LINK( ClickReduceBitmapsCBHdl,
weld::ToggleButton&, void );
DECL_DLLPRIVATE_LINK(
ToggleReduceGradientsStripesRBHdl, weld::ToggleButton&, void );
DECL_DLLPRIVATE_LINK(
ToggleReduceBitmapsResolutionRBHdl, weld::ToggleButton&, void );
diff --git a/include/sfx2/templatedlg.hxx b/include/sfx2/templatedlg.hxx
index 05a693611603..c83b2ab05880 100644
--- a/include/sfx2/templatedlg.hxx
+++ b/include/sfx2/templatedlg.hxx
@@ -86,8 +86,8 @@ protected:
DECL_LINK(ImplUpdateDataHdl, Timer*, void);
DECL_LINK(KeyInputHdl, const KeyEvent&, bool);
-DECL_LINK(ListViewHdl, weld::Button&, void);
-DECL_LINK(ThumbnailViewHdl, weld::Button&, void);
+DECL_LINK(ListViewHdl, weld::ToggleButton&, void);
+DECL_LINK(ThumbnailViewHdl, weld::ToggleButton&, void);
DECL_LINK(FocusRectLocalHdl, weld::Widget&, tools::Rectangle);
DECL_LINK(FocusRectSearchHdl, weld::Widget&, tools::Rectangle);
diff --git a/sfx2/source/dialog/printopt.cxx b/sfx2/source/dialog/printopt.cxx
index 5f4025fb57c0..2b106f9c5081 100644
--- a/sfx2/source/dialog/printopt.cxx
+++ b/sfx2/source/dialog/printopt.cxx
@@ -72,9 +72,9 @@
SfxCommonPrintOptionsTabPage::SfxCommonPrintOptionsTabPage(weld::Container* pPag
m_xPrinterOutputRB->connect_toggled( LINK( this,
SfxCommonPrintOptionsTabPage, ToggleOutputPrinterRBHdl ) );
m_xPrintFileOutputRB->connect_toggled( LINK( this,
SfxCommonPrintOptionsTabPage, ToggleOutputPrintFileRBHdl ) );
-m_xReduceTransparencyCB->connect_clicked( LINK( this,
SfxCommonPrintOptionsTabPage, ClickReduceTransparencyCBHdl ) );
-m_xReduceGradientsCB->connect_clicked( LINK( this,
SfxCommonPrintOptionsTabPage, ClickReduceGradientsCBHdl ) );
-m_xReduceBitmapsCB->connect_clicked( LINK( this,
SfxCommonPrintOptionsTabPage, ClickReduceBitmapsCBHdl ) );
+m_xReduceTransparencyCB->connect_toggled( LINK( this,
SfxCommonPrintOptionsTabPage, ClickReduceTransparencyCBHdl ) );
+m_xReduceGradientsCB->connect_toggled( LINK( this,
SfxCommonPrintOptionsTabPage, ClickReduceGradientsCBHdl ) );
+m_xReduceBitmapsCB->connect_toggled( LINK( this,
SfxCommonPrintOptionsTabPage, ClickReduceBitmapsCBHdl ) );
m_xReduceGradientsStripesRB->connect_toggled( LINK( this,
SfxCommonPrintOptionsTabPage, ToggleReduceGradientsStripesRBHdl ) );
m_xReduceBitmapsResolutionRB->connect_toggled( LINK( this,
SfxCommonPrintOptionsTabPage, ToggleReduceBitmapsResolutionRBHdl ) );
@@ -216,7 +216,7 @@ void SfxCommonPrintOptionsTabPage::ImplSaveControls(
PrinterOptions* pCurrentOpt
}
}
-IMPL_LINK_NOARG( SfxCommonPrintOptionsTabPage, ClickReduceTransparencyCBHdl,
weld::Button&, void )
+IMPL_LINK_NOARG( SfxCommonPrintOptionsTabPage, ClickReduceTransparencyCBHdl,
weld::ToggleButton&, void )
{
const bool bReduceTransparency = m_xReduceTransparencyCB->get_active();
@@ -226,7 +226,7 @@ IMPL_LINK_NOARG( SfxCommonPrintOptionsTabPage,
ClickReduceTransparencyCBHdl, wel
m_xTransparencyCB->set_sensitive( !bReduceTransparency );
}
-IMPL_LINK_NOARG( SfxCommonPrintOptionsTabPage, ClickReduceGradientsCBHdl,
weld::Button&, void )
+IMPL_LINK_NOARG(
