[Libreoffice-bugs] [Bug 147266] Moving cursor on M1 Macmini

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147266

--- Comment #6 from Alex Thurgood  ---
@Avrum :

Can you also let us know what you see in :

LibreOffice > Preferences > View

in particular which of the Skia options are activated / deactivated ?

These are listed as tick boxes under "Graphics Output".

Also try experimenting whether deactivating one, more or all of these options
has any effect on your vibrating cursor.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147342] New: [macOS] UI Scale not working on non HighDPI external display when using Skia and a laptop with Retina display (HighDPI)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147342

Bug ID: 147342
   Summary: [macOS] UI Scale not working on non HighDPI external
display when using Skia and a laptop with Retina
display (HighDPI)
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: ARM
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bertr...@presles.fr

Description:
When having a non HighDPI external screen (ex: 1080p screen) connected to a
MacBook Air/Pro with internal Retina display on, dragging and resizing the
LibreOffice window on the external display, the UI doesn't scale correctly when
Skia rendering is activated.

Steps to Reproduce:
1. Ensure to have version 7.3+ with Skia support
2. Ensure Skia rendering is enabled
3. Drag any LibreOffice window from internal laptop high dpi screen to normal
dpi external display (ex: 1080p) and resize the window

Actual Results:
The UI is too big for the screen low DPI

Expected Results:
The adapts to the screen DPI correctly, even if you drag and resize window on a
screen which have different DPI specs.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
System on which it was reproduced:

- MacBook Air M1 (2020)
- Dell 24" P2419HC external screen connected using USB-C
- macOS 12.2
- LibreOffice 7.3.0.3

Note: I checked the OpenGL case but of course that's Skia which is enabled in
that case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - extras/CustomTarget_autotextuser.mk extras/CustomTarget_tpldraw.mk extras/CustomTarget_tplofficorr.mk extras/CustomTarget_tploffimisc.mk extras/CustomTarget

[Christian Lohmaier (via logerrit)]

 extras/CustomTarget_autotextuser.mk |   68 ++---
 extras/CustomTarget_tpl_styles.mk   |  100 ++--
 extras/CustomTarget_tpldraw.mk  |   98 ++-
 extras/CustomTarget_tplofficorr.mk  |   99 ++-
 extras/CustomTarget_tploffimisc.mk  |   99 ++-
 extras/CustomTarget_tplpersonal.mk  |   99 ++-
 extras/CustomTarget_tplpresnt.mk|  112 ++--
 7 files changed, 140 insertions(+), 535 deletions(-)

New commits:
commit 967900354d36de50eff76e9622b0b4655d450f41
Author: Christian Lohmaier 
AuthorDate: Wed Feb 9 14:04:06 2022 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Feb 10 11:35:38 2022 +0100

simplify the template makefiles

can later be combined further, the process is the same/no real need for
separate makefile rules

Change-Id: Ic04acc4084605382147fa43a905fe559f9197d7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129726
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/extras/CustomTarget_tpl_styles.mk 
b/extras/CustomTarget_tpl_styles.mk
index 60897f38d801..6f1cce959d62 100644
--- a/extras/CustomTarget_tpl_styles.mk
+++ b/extras/CustomTarget_tpl_styles.mk
@@ -9,12 +9,6 @@
 
 $(eval $(call gb_CustomTarget_CustomTarget,extras/source/templates/styles))
 
-extras_TEMPLATES_STYLES := \
-   Default \
-   Modern \
-   Simple \
-
-
 extras_STYLES_XMLFILES := \
Default/META-INF/manifest.xml \
Default/meta.xml \
@@ -29,92 +23,38 @@ extras_STYLES_XMLFILES := \
Simple/styles.xml \
Simple/Thumbnails/thumbnail.png \
 
-
-extras_STYLES_MIMETYPEFILES := $(foreach 
atexts,$(extras_TEMPLATES_STYLES),$(atexts)/mimetype)
-
-
-$(call gb_CustomTarget_get_target,extras/source/templates/styles) : \
-   $(foreach atexts,$(extras_TEMPLATES_STYLES),$(call 
gb_CustomTarget_get_workdir,extras/source/templates/styles)/$(atexts).ott)
-
-$(call gb_CustomTarget_get_workdir,extras/source/templates/styles)/%/mimetype 
: $(SRCDIR)/extras/source/templates/styles/%/mimetype
-   $(call gb_Output_announce,templates/styles/$*/mimetype,$(true),CPY,1)
-   $(call gb_Trace_StartRange,templates/styles/$*/mimetype,CPY)
-   cp $< $@
-   $(call gb_Trace_EndRange,templates/styles/$*/mimetype,CPY)
-
-$(call gb_CustomTarget_get_workdir,extras/source/templates/styles)/%.jpg : 
$(SRCDIR)/extras/source/templates/styles/%.jpg
-   $(call gb_Output_announce,templates/styles/$*.jpg,$(true),CPY,1)
-   $(call gb_Trace_StartRange,templates/styles/$*.jpg,CPY)
-   cp $< $@
-   $(call gb_Trace_EndRange,templates/styles/$*.jpg,CPY)
-
-$(call gb_CustomTarget_get_workdir,extras/source/templates/styles)/%.png : 
$(SRCDIR)/extras/source/templates/styles/%.png
-   $(call gb_Output_announce,templates/styles/$*.png,$(true),CPY,1)
-   $(call gb_Trace_StartRange,templates/styles/$*.png,CPY)
-   cp $< $@
-   $(call gb_Trace_EndRange,templates/styles/$*.png,CPY)
-
-$(call gb_CustomTarget_get_workdir,extras/source/templates/styles)/%.rdf : 
$(SRCDIR)/extras/source/templates/styles/%.rdf
-   $(call gb_Output_announce,templates/styles/$*.rdf,$(true),CPY,1)
-   $(call gb_Trace_StartRange,templates/styles/$*.rdf,CPY)
+# param: style-base (e.g. Modern)
+extras_STYLES_XMLFILES_RELATIVE = $(subst $(1)/,,$(filter 
$(1)/%,$(extras_STYLES_XMLFILES)))
+
+.SECONDEXPANSION:
+# secondexpansion since the patterns not just cover a filename portion, but 
also include a
+# directory portion withdifferent number of elements
+# copy regular files (mimetype, *.jpg, *.png, *.rdf, *.svg, *.svm, …)
+$(call gb_CustomTarget_get_workdir,extras/source/templates/styles)/% : 
$(SRCDIR)/extras/source/templates/styles/% \
+| $$(dir $(call 
gb_CustomTarget_get_workdir,extras/source/templates/styles)/$$*).dir
+   $(call gb_Output_announce,templates/styles/$*,$(true),CPY,1)
+   $(call gb_Trace_StartRange,templates/styles/$*,CPY)
cp $< $@
-   $(call gb_Trace_EndRange,templates/styles/$*.rdf,CPY)
-
-$(call gb_CustomTarget_get_workdir,extras/source/templates/styles)/%.svg : 
$(SRCDIR)/extras/source/templates/styles/%.svg
-   $(call gb_Output_announce,templates/styles/$*.svg,$(true),CPY,1)
-   $(call gb_Trace_StartRange,templates/styles/$*.svg,CPY)
-   cp $< $@
-   $(call gb_Trace_EndRange,templates/styles/$*.svg,CPY)
-
-$(call gb_CustomTarget_get_workdir,extras/source/templates/styles)/%.svm : 
$(SRCDIR)/extras/source/templates/styles/%.svm
-   $(call gb_Output_announce,templates/styles/$*.svm,$(true),CPY,1)
-   $(call gb_Trace_StartRange,templates/styles/$*.svm,CPY)
-   cp $< $@
-   $(call gb_Trace_EndRange,templates/styles/$*.svm,CPY)
+   $(call gb_Trace_EndRange,templates/styles/$*,CPY)
 
 $(call gb_CustomTarget_get_workdir,extras/source/templates/styles)/%.xml : 

[Libreoffice-commits] core.git: extras/CustomTarget_autotextshare.mk extras/README.md extras/source

[Christian Lohmaier (via logerrit)]

 extras/CustomTarget_autotextshare.mk |  259 +++
 extras/README.md |7 
 2 files changed, 26 insertions(+), 240 deletions(-)

New commits:
commit f5ce765d560aaa6ac6c5a92048432dd1e6e8f851
Author: Christian Lohmaier 
AuthorDate: Tue Feb 8 10:52:39 2022 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Feb 10 11:35:04 2022 +0100

simplify autotextshare makefile/only build what's packaged

The multiple indirections/complex nested constructs don't really provide
any benefit here, they certainly don't make the makefile easier to read.

It was building the autotext .bau files for all languages, despite being
packaged only for the requested UI langauges (via AllLagPackage) and the
long list of autotext files was duplicated (even if all .bau files
should be built, the list could be reused from the other makefile)

Also remove the empty mimetype files and just touch them instead of
copying them.

The xml, mimetype and other files are now intermediates and are removed by
make once the .bau is built. (if that's not desired, they can be flagged as
.SECONDARY)

The list of individual files (3.6k lines) could also be cut down if
using e.g. make's wildcard function

Change-Id: I223a49d26d1de1435d62a68a04b3713278a8320c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129696
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/extras/CustomTarget_autotextshare.mk 
b/extras/CustomTarget_autotextshare.mk
index 5fb87adb7539..6eb4cd08de56 100644
--- a/extras/CustomTarget_autotextshare.mk
+++ b/extras/CustomTarget_autotextshare.mk
@@ -9,180 +9,6 @@
 
 $(eval $(call gb_CustomTarget_CustomTarget,extras/source/autotext))
 
-extras_AUTOTEXTSHARE_AUTOTEXTS := \
-   af/standard \
-   am/standard \
-   ar/standard \
-   as/standard \
-   ast/standard \
-   be/standard \
-   bg/crdbus50 \
-   bg/standard \
-   bg/template \
-   bn-IN/standard \
-   bn/standard \
-   bo/standard \
-   br/standard \
-   brx/standard \
-   bs/standard \
-   ca-valencia/standard \
-   ca/standard \
-   cs/crdbus50 \
-   cs/crdbus54 \
-   cs/standard \
-   cs/template \
-   cy/standard \
-   da/crdbus50 \
-   da/standard \
-   da/template \
-   de/crdbus50 \
-   de/standard \
-   de/template \
-   dgo/standard \
-   dsb/standard \
-   dz/standard \
-   el/standard \
-   en-GB/crdbus50 \
-   en-GB/standard \
-   en-GB/template \
-   en-US/crdbus50 \
-   en-US/standard \
-   en-US/template \
-   en-ZA/standard \
-   eo/standard \
-   es/crdbus50 \
-   es/standard \
-   es/template \
-   et/standard \
-   eu/standard \
-   fa/standard \
-   fi/standard \
-   fr/crdbus50 \
-   fr/standard \
-   fr/template \
-   fy/standard \
-   ga/standard \
-   gd/standard \
-   gl/standard \
-   gu/standard \
-   gug/standard \
-   he/standard \
-   hi/standard \
-   hr/standard \
-   hsb/standard \
-   hu/crdbus50 \
-   hu/crdbus54 \
-   hu/standard \
-   hu/template \
-   id/standard \
-   is/standard \
-   it/crdbus50 \
-   it/standard \
-   it/template \
-   ja/crdbus50 \
-   ja/standard \
-   ja/template \
-   ka/standard \
-   kab/standard \
-   kk/standard \
-   km/crdbus50 \
-   km/standard \
-   km/template \
-   kmr-Latn/standard \
-   kn/standard \
-   ko/crdbus50 \
-   ko/standard \
-   ko/template \
-   kok/standard \
-   ks/standard \
-   lb/standard \
-   lo/standard \
-   lt/standard \
-   lv/standard \
-   mai/standard \
-   mk/standard \
-   ml/standard \
-   mn/crdbus50 \
-   mn/standard \
-   mn/template \
-   mni/standard \
-   mr/standard \
-   my/standard \
-   nb/standard \
-   ne/standard \
-   nl/crdbus50 \
-   nl/standard \
-   nl/template \
-   nn/standard \
-   nr/standard \
-   nso/standard \
-   oc/standard \
-   om/standard \
-   or/standard \
-   pa-IN/standard \
-   pl/crdbus50 \
-   pl/standard \
-   pl/template \
-   pt-BR/crdbus50 \
-   pt-BR/standard \
-   pt-BR/template \
-   pt/crdbus50 \
-   pt/standard \
-   pt/template \
-   ro/standard \
-   ru/crdbus50 \
-   ru/standard \
-   ru/template \
-   rw/standard \
-   sa-IN/standard \
-   sat/standard \
-   sd/standard \
-   si/standard \
-   sid/standard \
-   sk/crdbus50 \
-   sk/crdbus54 \
-   sk/standard \
-   sk/template \
-   sl/crdbus50 \
-   sl/crdbus54 \
-   sl/standard \
-   sl/template \
-   sq/standard \
-   sr/standard \
-   sr-Latn/standard \
-   

[Libreoffice-commits] core.git: extras/CustomTarget_autocorr.mk extras/source

[Christian Lohmaier (via logerrit)]

 extras/CustomTarget_autocorr.mk |   79 
 1 file changed, 32 insertions(+), 47 deletions(-)

New commits:
commit a378b130c390423c22999db0841ad1fcf10b4e5c
Author: Christian Lohmaier 
AuthorDate: Mon Feb 7 17:12:49 2022 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Feb 10 11:34:44 2022 +0100

simplify autocorrect makefile

The multiple indirections/complex nested constructs don't really provide
any benefit here, they certainly don't make the makefile easier to read.

Also remove the empty mimetype files and just touch them instead of
copying them.

The xml and mimetype files are now intermediates and are removed by make
once the .dat is built. (if that's not desired, they can be flagged as
.SECONDARY)

Further simplification is possible when using the same language code
for both the intermediate directory as well as the source directory
layout and the .dat files

Change-Id: I0e0c28abcad2b404a88d1f32b9b9cdb53b4125c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129628
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/extras/CustomTarget_autocorr.mk b/extras/CustomTarget_autocorr.mk
index 8ac2dd86502a..16e2658dd53d 100644
--- a/extras/CustomTarget_autocorr.mk
+++ b/extras/CustomTarget_autocorr.mk
@@ -59,6 +59,8 @@ extras_AUTOCORR_LANGS := \
zh-CN:zh-CN \
zh-TW:zh-TW \
 
+extras_AUTOCORR_SHORTLANG  = $(firstword $(subst :, ,$(filter 
%:$(1),$(extras_AUTOCORR_LANGS
+
 extras_AUTOCORR_XMLFILES := \
af-ZA/DocumentList.xml \
af-ZA/META-INF/manifest.xml \
@@ -234,62 +236,45 @@ extras_AUTOCORR_XMLFILES := \
zh-TW/META-INF/manifest.xml \
zh-TW/SentenceExceptList.xml \
 
+# param: shortlang
+extras_AUTOCORR_XMLFILES_LANG = $(subst $(1)/,,$(filter 
$(1)/%,$(extras_AUTOCORR_XMLFILES)))
 
-extras_AUTOCORR_MIMETYPEFILES := $(foreach 
lang,$(extras_AUTOCORR_LANGS),$(firstword $(subst :, ,$(lang)))/mimetype)
-
-
-$(call gb_CustomTarget_get_target,extras/source/autocorr) : \
-   $(foreach lang,$(extras_AUTOCORR_LANGS),$(call 
gb_CustomTarget_get_workdir,extras/source/autocorr)/acor_$(lastword $(subst :, 
,$(lang))).dat)
-
-$(call gb_CustomTarget_get_workdir,extras/source/autocorr)/%/mimetype : 
$(SRCDIR)/extras/source/autocorr/lang/%/mimetype
-   $(call gb_Output_announce,autocorr/$*/mimetype,$(true),CPY,1)
-   $(call gb_Trace_StartRange,autocorr/$*/mimetype,CPY)
-   cp $< $@
-   $(call gb_Trace_EndRange,autocorr/$*/mimetype,CPY)
+$(call gb_CustomTarget_get_workdir,extras/source/autocorr)/%/mimetype : \
+| $(dir $(call 
gb_CustomTarget_get_workdir,extras/source/autocorr)/%/mimetype).dir
+   $(call gb_Output_announce,autocorr/$*/mimetype,$(true),TCH,1)
+   $(call gb_Trace_StartRange,autocorr/$*/mimetype,TCH)
+   touch $@
+   $(call gb_Trace_EndRange,autocorr/$*/mimetype,TCH)
 
+.SECONDEXPANSION:
+# secondexpansion since the pattern not just covers a file, but also a 
directory portion with
+# different number of elements (just the lang or lang/META-INF) and thus the 
directory dependency
+# needs the stem of the actual target to work as intended
 $(call gb_CustomTarget_get_workdir,extras/source/autocorr)/%.xml : 
$(SRCDIR)/extras/source/autocorr/lang/%.xml \
-   | $(call gb_ExternalExecutable_get_dependencies,xsltproc)
+| $(call gb_ExternalExecutable_get_dependencies,xsltproc) \
+  $$(dir $(call 
gb_CustomTarget_get_workdir,extras/source/autocorr)/$$*.xml).dir
$(call gb_Output_announce,autocorr/$*.xml,$(true),XSL,1)
$(call gb_Trace_StartRange,autocorr/$*.xml,XSL)
$(call gb_ExternalExecutable_get_command,xsltproc) --nonet -o $@ 
$(SRCDIR)/extras/util/compact.xsl $<
$(call gb_Trace_EndRange,autocorr/$*.xml,XSL)
 
-$(call gb_CustomTarget_get_workdir,extras/source/autocorr)/%.dat :
-   $(call gb_Output_announce,autocorr/$*.dat,$(true),ZIP,2)
-   $(call gb_Trace_StartRange,autocorr/$*.dat,ZIP)
+# secondexpansion necessry since the .dat are created with longlang form, 
while the other files
+# are created in the shortlang directory, and thus % cannot be used verbatim, 
the second expansion
+# allows the actual stem from the target to be used in the macro calls
+# there's no reason for the different directories thouch, so a janitorial 
cleanup would be
+# TODO: get rid of the shortform:longform language names when assembling the 
autocorr files
+$(call gb_CustomTarget_get_workdir,extras/source/autocorr)/acor_%.dat : \
+$$(addprefix \
+$(call gb_CustomTarget_get_workdir,extras/source/autocorr)/$$(call 
extras_AUTOCORR_SHORTLANG,$$*)/,\
+mimetype \
+$$(call extras_AUTOCORR_XMLFILES_LANG,$$(call 
extras_AUTOCORR_SHORTLANG,$$*)))
+   $(call gb_Output_announce,autocorr/acor_$*.dat,$(true),ZIP,2)
+   $(call gb_Trace_StartRange,autocorr/acor_$*.dat,ZIP)
$(call 

[Libreoffice-bugs] [Bug 147266] Moving cursor on M1 Macmini

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147266

Alex Thurgood  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #5 from Alex Thurgood  ---
(In reply to Avrum Lapin from comment #3)
> Thanks for your response
> 
> 
> Build
> 
>   Model Name: Mac mini
>   Model Identifier:   Macmini9,1
>   Chip:   Apple M1
>   Total Number of Cores:  8 (4 performance and 4 efficiency)
>   Memory: 16 GB
>   System Firmware Version:7429.81.3
>   OS Loader Version:  6723.140.2
>   Serial Number (system): H2WFQ0WHQ6NY
>   Hardware UUID:  84ADF1A2-7E23-5B2A-9986-2933DE478AB5
>   Provisioning UDID:  8103-001A64C02ED9001E
>   Activation Lock Status: Disabled
> 
> Hopefully this has the build info.  If not where is it?
> 


Thanks for the system info.
The LO build info is available from the LibreOffice application menu, when it
is running, go into the LibreOffice menu at the top of your screen, and choose
"About". This will display a dialog, you can click on the Version Information
icon to copy the information which is displayed below into the copy buffer, and
then paste it with Cmd-V into the reply window of this bug in your browser.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126344] Undo is slower and consumes more CPU time after pressing undo (compared to 6.1)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126344

--- Comment #4 from Dieter  ---
(In reply to Timur from comment #3)
> Why make 3 bugs out of 1?
> 
> *** This bug has been marked as a duplicate of bug 116400 ***

Bug 116400 is about PDF-generation. So are you sure, it's the correct bug for a
duplicate?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147341] The shortcuts of form 'alt+*' are not working as they used to before Libreoffice version 7.2.*

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147341

aystic  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||pmohitb3...@gmail.com
Version|unspecified |7.3.0.3 release
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147341] New: The shortcuts of form 'alt+*' are not working as they used to before Libreoffice version 7.2.*

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147341

Bug ID: 147341
   Summary: The shortcuts of form 'alt+*' are not working as they
used to before Libreoffice version 7.2.*
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pmohitb3...@gmail.com

Created attachment 178185
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178185=edit
The attachment shows the shortcut that has been set for the "alt+R" keybinding
and The unexpected behaviour that is happening on pressing the shortcut

===Libreoffice version details=
Version: 7.3.0.3 / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Calc: threaded

Issue===
I had some shortcuts setup for different character styles. For example, I had
the shortcut "alt+R" setup for changing the font color to red. It used to work
flawlessly in the previous versions of libreoffice. But in the recent version
>7.2.* whenever I press the "alt+R" the menu-dropdown opens. The shortcuts of
the form alt+* doesn't seem to work anymore hence I am forced to use
libreoffice 7.1.6 or below versions as they don't have this issue.

=Expected behaviour
On pressing the alt+* type of shortcuts the intended effect should take place
instead of menu taking over the opening the dropdowns.

Please refer to screenshots
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - include/sfx2 sc/source sfx2/source

[Dennis Francis (via logerrit)]

 include/sfx2/lokcharthelper.hxx |6 --
 sc/source/ui/unoobj/docuno.cxx  |4 ++--
 sfx2/source/view/lokcharthelper.cxx |   14 +++---
 3 files changed, 17 insertions(+), 7 deletions(-)

New commits:
commit 4fd2a14c6ee68f0574766ec7ec3dca35debe9d20
Author: Dennis Francis 
AuthorDate: Wed Feb 9 12:31:49 2022 +0530
Commit: Dennis Francis 
CommitDate: Thu Feb 10 11:29:17 2022 +0100

lokCalcRTL: global RTL: fix chart edit mode rendering

If global RTL flag is set, vcl-window X offset of chart window is
mirrored w.r.t parent window rectangle. This has to be undone to get the
correct chart bounding box in negative X document coordinates so that
the offset calculations for tile rendering remains the same for RTL
documents irrespective of the system/global RTL setting.

Change-Id: I3e181af4e7ab1257bcc88d44bbdb053a7d47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129704
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/include/sfx2/lokcharthelper.hxx b/include/sfx2/lokcharthelper.hxx
index aa7cfb5867ac..e447562e3dfd 100644
--- a/include/sfx2/lokcharthelper.hxx
+++ b/include/sfx2/lokcharthelper.hxx
@@ -28,11 +28,13 @@ private:
 css::uno::Reference mxController;
 css::uno::Reference mxDispatcher;
 VclPtr mpWindow;
+bool mbNegativeX;
 
 public:
-LokChartHelper(SfxViewShell* pViewShell)
+LokChartHelper(SfxViewShell* pViewShell, bool bNegativeX = false)
 : mpViewShell(pViewShell)
 , mpWindow(nullptr)
+, mbNegativeX(bNegativeX)
 {}
 
 css::uno::Reference& GetXController();
@@ -42,7 +44,7 @@ public:
 void Invalidate();
 
 bool Hit(const Point& aPos);
-static bool HitAny(const Point& aPos);
+static bool HitAny(const Point& aPos, bool bNegativeX = false);
 void PaintTile(VirtualDevice& rRenderContext, const tools::Rectangle& 
rTileRect);
 static void PaintAllChartsOnTile(VirtualDevice& rDevice,
  int nOutputWidth, int nOutputHeight,
diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index 86bd13cb5a16..bfcde729dd0f 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -733,11 +733,11 @@ void ScModelObj::postMouseEvent(int nType, int nX, int 
nY, int nCount, int nButt
 // check if user hit a chart which is being edited by him
 ScTabViewShell * pTabViewShell = pViewData->GetViewShell();
 SCTAB nTab = pViewData->GetTabNo();
-LokChartHelper aChartHelper(pTabViewShell);
 const ScDocument& rDoc = pDocShell->GetDocument();
 // In LOK RTL mode draw/svx operates in negative X coordinates
 // But the coordinates from client is always positive, so negate nX for 
draw.
 bool bDrawNegativeX = rDoc.IsNegativePage(nTab);
+LokChartHelper aChartHelper(pTabViewShell, bDrawNegativeX);
 int nDrawX = bDrawNegativeX ? -nX : nX;
 if (aChartHelper.postMouseEvent(nType, nDrawX, nY,
 nCount, nButtons, nModifier,
@@ -753,7 +753,7 @@ void ScModelObj::postMouseEvent(int nType, int nX, int nY, 
int nCount, int nButt
 // and, if so, skip current mouse event
 if (nType != LOK_MOUSEEVENT_MOUSEMOVE)
 {
-if (LokChartHelper::HitAny(aPointTwipDraw))
+if (LokChartHelper::HitAny(aPointTwipDraw, bDrawNegativeX))
 return;
 }
 
diff --git a/sfx2/source/view/lokcharthelper.cxx 
b/sfx2/source/view/lokcharthelper.cxx
index b0b71aaa0353..49bdf5860784 100644
--- a/sfx2/source/view/lokcharthelper.cxx
+++ b/sfx2/source/view/lokcharthelper.cxx
@@ -18,6 +18,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -137,6 +138,13 @@ tools::Rectangle LokChartHelper::GetChartBoundingBox()
 double fXScale( aCWMapMode.GetScaleX() );
 double fYScale( aCWMapMode.GetScaleY() );
 Point aOffset = pWindow->GetOffsetPixelFrom(*pRootWin);
+if (mbNegativeX && AllSettings::GetLayoutRTL())
+{
+// If global RTL flag is set, vcl-window X offset of 
chart window is
+// mirrored w.r.t parent window rectangle. This needs 
to be reverted.
+aOffset.setX(pRootWin->GetOutOffXPixel() + 
pRootWin->GetSizePixel().Width()
+- pWindow->GetOutOffXPixel() - 
pWindow->GetSizePixel().Width());
+}
 aOffset.setX( aOffset.X() * (TWIPS_PER_PIXEL / fXScale) );
 aOffset.setY( aOffset.Y() * (TWIPS_PER_PIXEL / fYScale) );
 Size aSize = pWindow->GetSizePixel();
@@ -171,7 +179,7 @@ bool LokChartHelper::Hit(const Point& aPos)
 return false;
 }
 
-bool LokChartHelper::HitAny(const Point& aPos)
+bool LokChartHelper::HitAny(const Point& aPos, bool bNegativeX)
 {
 SfxViewShell* pCurView = SfxViewShell::Current();

[Libreoffice-bugs] [Bug 146881] Allow individual paragraph styles to overrule "Add paragraph and table spacing to top of page" setting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146881

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 146881] Allow individual paragraph styles to overrule "Add paragraph and table spacing to top of page" setting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146881

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 147313] add "Set as Default" option to Manage dropdown menu in Template Manager

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147313

Heiko Tietze  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #1 from Heiko Tietze  ---
Would rather abstain from doing this:

* It opens Pandora's box and we could also add Edit to the Manage dropdown
* Manage belongs (primarily) to the categories, it combines the various
functions we had in the past at the bottom of the dialog; the context menu at
the template itself clearly belongs to this context
* the function is Reset _All Default_ Templates, there is no pendant to set all

Other opinions than my NAB?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 147313] add "Set as Default" option to Manage dropdown menu in Template Manager

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147313

Heiko Tietze  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #1 from Heiko Tietze  ---
Would rather abstain from doing this:

* It opens Pandora's box and we could also add Edit to the Manage dropdown
* Manage belongs (primarily) to the categories, it combines the various
functions we had in the past at the bottom of the dialog; the context menu at
the template itself clearly belongs to this context
* the function is Reset _All Default_ Templates, there is no pendant to set all

Other opinions than my NAB?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147223] LO freezes TEMPORARILY (but does NOT crash) when trying to "Save" or "Save As" to the desktop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147223

Alex Thurgood  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #12 from Alex Thurgood  ---
@Byron : please indicate whether the folder you are attempting to save the
document to contains a symbolic link (alias) to a network resource that is
offline when you try and save.

If so, this report is a DUPLICATE of bug 41987, which has been open since 2011,
and which has never received any love, almost certainly because it is
Mac-specific.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 41987] LibreOffice hangs when "Save As..." tries to re-mount previously used, but now inaccessible network volumes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=41987

Alex Thurgood  changed:

   What|Removed |Added

 CC||b...@whiteflamegreen.net

--- Comment #22 from Alex Thurgood  ---
*** Bug 137909 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137909] FILESAVE Hang on Save As...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137909

Alex Thurgood  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #18 from Alex Thurgood  ---
(In reply to bugz from comment #17)
> Yes! And removing it stops the reported behaviour.  
> 
> I assume this is still a bug though.  The networked volume isn't mounted,
> (and I can't for the moment mount it - which I'm supposing would also fix
> the problem).  The whole thing shouldn't hang, should it?  I'm not trying to
> write to that volume.



Excellent, thanks for testing.

This is the behaviour reported in bug 41987

*** This bug has been marked as a duplicate of bug 41987 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142694] Writer stops responding with busy CPU after opening this document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142694

--- Comment #3 from Gabor Kelemen (allotropia)  ---
Magic words for search:

Adding CC: to Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134842] FILESAVE - Export to .png or .jpg shrink the image adding white borders

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134842

--- Comment #4 from Telesto  ---
Repro
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 42c5506a9e9ef58efd8193a193464e3b49d481ca
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147273] Copying From Calc + Paste Unformatted Text into Writer = All Text in Single Cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147273

--- Comment #12 from Heiko Tietze  ---
(In reply to Xisco Faulí from comment #11)
> Yes, that the case for normal paste, but we need clarification about paste
> as unformatted text. To me, the currect behaviour is right but I wanted the
> UX opinion, that's why I added you

Paste adds unformatted, plain text; it won't overwrite any previous formatting
in the table, which is desired in most cases. 

And paste inserted cells with formatting when creating a new table. Makes sense
to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137523] Part of the footer of the first page is not shown at doc opening even is visible at save

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137523

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 CC||kelem...@ubuntu.com

--- Comment #7 from Gabor Kelemen (allotropia)  ---
Magic words for search:

Adding CC: to Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147172] Libreoffice drop-down menus not working in plasma wayland session

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147172

--- Comment #1 from giuseppe  ---
Can confirm this bug. It wasn't present with the previous build.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 51510] FILESAVE: Exporting documents with embedded SVG to doc or docx converts the image to low-resolution pixel graphics

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51510

Telesto  changed:

   What|Removed |Added

 CC||j...@mail.ossii.com.tw

--- Comment #25 from Telesto  ---
*** Bug 147331 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147331] Blurred QR code and barcode in Microsoft file formats

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147331

Telesto  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Telesto  ---
Confirm, however already reported (in a different context)

*** This bug has been marked as a duplicate of bug 51510 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147156] Table layout different after deleting rows & redo

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147156

Telesto  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Blocks|103100  |
 Status|UNCONFIRMED |NEW


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Telesto  changed:

   What|Removed |Added

 Depends on|147156  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147156
[Bug 147156] Table layout different after deleting rows & redo
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Telesto  changed:

   What|Removed |Added

 Depends on||147156


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147156
[Bug 147156] Table layout different after deleting rows & redo
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147156] Table layout different after deleting rows & redo

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147156

Telesto  changed:

   What|Removed |Added

 Blocks||103100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135784] Freeze when scrolling an abusive complex table file. 6.3 bailed out; rendering maybe broken but no freeze

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135784

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 CC||kelem...@ubuntu.com

--- Comment #6 from Gabor Kelemen (allotropia)  ---
Magic words for search:

Adding CC: to Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128966] Writer table: Center Vertically shows some rows as Align Top (click-in restores until next fileopen)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128966

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 CC||kelem...@ubuntu.com

--- Comment #13 from Gabor Kelemen (allotropia)  ---
Magic words for search:

Adding CC: to Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132269] FILEOPEN DOCX Rejecting tracked change makes floating table with CT disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132269

--- Comment #3 from Gabor Kelemen (allotropia)  ---
Magic words for search:

Adding CC: to Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141791] Collabora Office - About screen has a link to website that throws an error message on macOS Big Sur

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141791

Alex Thurgood  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Alex Thurgood  ---
Fixed in

Version: 21.06.15.1
Build ID: 60a66e4bf6afbf5d4221dab436bb1aca744a7ddf
CPU threads: 8; OS: Mac OS X 12.2; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/source

[Justin Luth (via logerrit)]

 sc/source/core/data/table4.cxx |   20 
 1 file changed, 16 insertions(+), 4 deletions(-)

New commits:
commit f3035cdb6a8d3ef56180640ef9d04031012250b9
Author: Justin Luth 
AuthorDate: Wed Feb 9 14:33:05 2022 +0200
Commit: Xisco Fauli 
CommitDate: Thu Feb 10 10:53:08 2022 +0100

tdf#113785 sc FillAutoSimple: also optimize in negative direction

By only coding the optimization for the downward autofill,
it totally broke an upward autofill.
So this patch simply fixes the LO 4.3ish regression
from commit a995462e6855061816c6529c366f20ace2b45868.

This fix means that the non-hidden cells get the auto-value
instead of being erased.

However, the hidden cells are still erased
(which is the topic of tdf#119957).

I'm not going to bother with a unit test for this
portion. If I can solve bug 119957 as well,
then the unit test for that can cover both situations.

Change-Id: If6320ccf87fa8893ca6766c265b7760cc46ed7d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129723
Tested-by: Jenkins
Reviewed-by: Justin Luth 
(cherry picked from commit 618084819babc839510860b74b36631749093c4c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129753
Reviewed-by: Xisco Fauli 

diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx
index 6ef2c3b439b2..d2fdde2718b8 100644
--- a/sc/source/core/data/table4.cxx
+++ b/sc/source/core/data/table4.cxx
@@ -1782,16 +1782,28 @@ void ScTable::FillAutoSimple(
 bool bIsOrdinalSuffix = false;
 
 bool bColHidden = false, bRowHidden = false;
+SCCOL nColHiddenFirst = rDocument.MaxCol();
 SCCOL nColHiddenLast = -1;
+SCROW nRowHiddenFirst = rDocument.MaxRow();
 SCROW nRowHiddenLast = -1;
 
 rInner = nIStart;
 while (true)// #i53728# with "for (;;)" old solaris/x86 compiler 
mis-optimizes
 {
-if (rCol > nColHiddenLast)
-bColHidden = ColHidden(rCol, nullptr, );
-if (rRow > nRowHiddenLast)
-bRowHidden = RowHidden(rRow, nullptr, );
+if (bPositive)
+{
+if (rCol > nColHiddenLast)
+bColHidden = ColHidden(rCol, nullptr, );
+if (rRow > nRowHiddenLast)
+bRowHidden = RowHidden(rRow, nullptr, );
+}
+else
+{
+if (rCol < nColHiddenFirst)
+bColHidden = ColHidden(rCol, );
+if (rRow < nRowHiddenFirst)
+bRowHidden = RowHidden(rRow, );
+}
 
 if (!bColHidden && !bRowHidden)
 {

[Libreoffice-bugs] [Bug 146875] Writer: ToC Index updating hangs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146875

--- Comment #13 from Gabor Kelemen (allotropia)  ---
Adding CC: to Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'refs/tags/mimo-5.4.7.2.M10' - external/nss

[Andras Timar (via logerrit)]

Rebased ref, commits from common ancestor:
commit 14c16e6857005f437bd8cdfde753d9e7ba020bbc
Author: Andras Timar 
AuthorDate: Wed Feb 9 11:59:50 2022 +0100
Commit: Andras Timar 
CommitDate: Thu Feb 10 10:41:30 2022 +0100

Need adding NSS_DISABLE_AVX2 for old vs2015 windows builds

Change-Id: Ib84092b3b3f7c0a304c79baa8b2549ee74f05cf8

diff --git a/external/nss/ExternalProject_nss.mk 
b/external/nss/ExternalProject_nss.mk
index 01b6b4e07794..aed6843a8106 100644
--- a/external/nss/ExternalProject_nss.mk
+++ b/external/nss/ExternalProject_nss.mk
@@ -30,6 +30,7 @@ $(call gb_ExternalProject_get_state_target,nss,build): $(call 
gb_ExternalProject
$(call gb_ExternalProject_run,build,\
$(if $(MSVC_USE_DEBUG_RUNTIME),USE_DEBUG_RTL=1,BUILD_OPT=1) \
OS_TARGET=WIN95 \
+   NSS_DISABLE_AVX2=1 \
$(if $(filter X86_64,$(CPUNAME)),USE_64=1) \
LIB="$(ILIB)" \
XCFLAGS="-arch:SSE $(SOLARINC)" \

[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-5-4-7-2' - external/nss

[Andras Timar (via logerrit)]

 external/nss/ExternalProject_nss.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 14c16e6857005f437bd8cdfde753d9e7ba020bbc
Author: Andras Timar 
AuthorDate: Wed Feb 9 11:59:50 2022 +0100
Commit: Andras Timar 
CommitDate: Thu Feb 10 10:41:30 2022 +0100

Need adding NSS_DISABLE_AVX2 for old vs2015 windows builds

Change-Id: Ib84092b3b3f7c0a304c79baa8b2549ee74f05cf8

diff --git a/external/nss/ExternalProject_nss.mk 
b/external/nss/ExternalProject_nss.mk
index 01b6b4e07794..aed6843a8106 100644
--- a/external/nss/ExternalProject_nss.mk
+++ b/external/nss/ExternalProject_nss.mk
@@ -30,6 +30,7 @@ $(call gb_ExternalProject_get_state_target,nss,build): $(call 
gb_ExternalProject
$(call gb_ExternalProject_run,build,\
$(if $(MSVC_USE_DEBUG_RUNTIME),USE_DEBUG_RTL=1,BUILD_OPT=1) \
OS_TARGET=WIN95 \
+   NSS_DISABLE_AVX2=1 \
$(if $(filter X86_64,$(CPUNAME)),USE_64=1) \
LIB="$(ILIB)" \
XCFLAGS="-arch:SSE $(SOLARINC)" \

Wants to join your community

[Danish]

Hi,

I am Ansari Danish . I am a computer science student and wants to start
open source Contribution. And I only knew some intermediate level of java
and nothing more. So wants to be a part of your community for kickstarting
my Career…

[Libreoffice-bugs] [Bug 147340] New: Libreoffice 7.3 Print bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147340

Bug ID: 147340
   Summary: Libreoffice 7.3 Print bug
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: thelupegaa...@gmail.com

Description:
To print in Landscape, do:
FORMAT/PAGE STYLE/Sub PAGE tab
there is an inversion: PORTRAIT gives a representation in HORIZONTAL rectangle
(symbol of landscape mode)
LANDSCAPE gives a representation in rectangle VERTICAL (symbol of the portrait
mode)
Choose what you need with the symbol, not with the title.

Actual Results:
solved with the steps above

Expected Results:
rewrite that part of page


Reproducible: Always


User Profile Reset: No



Additional Info:
none

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138991] UI: Incorrect unit of measurement with specific file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138991

--- Comment #6 from Xisco Faulí  ---
(In reply to raal from comment #5)
> Hi Xisco, according to comment 2 closing the bug.

Indeed. Thanks for taking care

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147273] Copying From Calc + Paste Unformatted Text into Writer = All Text in Single Cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147273

--- Comment #11 from Xisco Faulí  ---
(In reply to Heiko Tietze from comment #10)
> Concur with Stuart's statement, pasting into an existing table accepts plain
> text while pasting into a new paragraph inserts a table with all formatting. 
> 
> But I wonder if we have a documentation gap. Your call, Olivier.

Yes, that the case for normal paste, but we need clarification about paste as
unformatted text. To me, the currect behaviour is right but I wanted the UX
opinion, that's why I added you

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146745] LibreofficeWriter hangs if I move a Frame anchor to another page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146745

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 CC||kelem...@ubuntu.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147273] Copying From Calc + Paste Unformatted Text into Writer = All Text in Single Cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147273

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
URL||https://help.libreoffice.or
   ||g/7.3/en-US/text/shared/01/
   ||pastespecialmenu.html?
   ||R=WRITER
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||olivier.hallot@libreoffice.
   ||org
  Component|Writer  |Documentation

--- Comment #10 from Heiko Tietze  ---
Concur with Stuart's statement, pasting into an existing table accepts plain
text while pasting into a new paragraph inserts a table with all formatting. 

But I wonder if we have a documentation gap. Your call, Olivier.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 147273] Copying From Calc + Paste Unformatted Text into Writer = All Text in Single Cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147273

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
URL||https://help.libreoffice.or
   ||g/7.3/en-US/text/shared/01/
   ||pastespecialmenu.html?
   ||R=WRITER
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||olivier.hallot@libreoffice.
   ||org
  Component|Writer  |Documentation

--- Comment #10 from Heiko Tietze  ---
Concur with Stuart's statement, pasting into an existing table accepts plain
text while pasting into a new paragraph inserts a table with all formatting. 

But I wonder if we have a documentation gap. Your call, Olivier.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 147339] New: Collabora Office - no Extensions can be installed via Extension Manager UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147339

Bug ID: 147339
   Summary: Collabora Office - no Extensions can be installed via
Extension Manager UI
   Product: LibreOffice
   Version: 7.2.2.2 release
  Hardware: ARM
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ipla...@tuta.io

Description:
1) Start Collabora Office
2) Menu Tools > Extension Manager
3) Click on "Add" in the Extension Manager UI
4) Select an extension that has already been downloaded - click on Open
5) Error message displayed " Bad URL"
6) Extension manager UI refreshed, but extension not installed


Steps to Reproduce:
See above

Actual Results:
No extensions can be installed via the UI.

Expected Results:
Extensions should be installable, otherwise, what's the point of having a
UI/tool to install them.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Drag and dropping an extension onto a running instance of Collabora Office
produces the same error message.

Version: 21.06.15.1
Build ID: 60a66e4bf6afbf5d4221dab436bb1aca744a7ddf
CPU threads: 8; OS: Mac OS X 12.2; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116400] Very time lengthy PDF-generation due to Upgrade to ICU ( see comment 9 and 19 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116400

Julien Nabet  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #26 from Julien Nabet  ---
Eike: any thoughts here (since you did the last ICU updates)?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-21.06.16-1'

[Andras Timar (via logerrit)]

Tag 'cp-21.06.16-1' created by Andras Timar  at 
2022-02-10 09:20 +

cp-21.06.16-1

Changes since co-21.06.14-1-17:
---
 0 files changed
---

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-21.06.16-1'

[Andras Timar (via logerrit)]

Tag 'cp-21.06.16-1' created by Andras Timar  at 
2022-02-10 09:20 +

cp-21.06.16-1

Changes since cp-21.06.13-1-1:
---
 0 files changed
---

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-21.06.16-1'

[Adolfo Jayme Barrientos (via logerrit)]

Tag 'cp-21.06.16-1' created by Andras Timar  at 
2022-02-10 09:20 +

cp-21.06.16-1

Changes since co-2021-branch-point-10:
---
 0 files changed
---

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-21.06.16-1'

[Andras Timar (via logerrit)]

Tag 'cp-21.06.16-1' created by Andras Timar  at 
2022-02-10 09:20 +

cp-21.06.16-1

Changes since libreoffice-7-1-branch-point-5:
---
 0 files changed
---

[Libreoffice-bugs] [Bug 105035] FILEOPEN DOCX: Two frames, anchored to the same paragraph, imported as a single frame (comment 7)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105035

Justin L  changed:

   What|Removed |Added

   Keywords|bibisected, bisected,   |
   |filter:docx, regression |
Version|5.3.0.0.alpha1+ |unspecified

--- Comment #9 from Justin L  ---
The bibisect/regression information is now obsolete. I tested the two frames
combining into one with LO 3.5 and it was already happening at that time, so
likely inherited from OOo.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - configure.ac

[Andras Timar (via logerrit)]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 38e4d2f422afdeced7904b44687800d308b93249
Author: Andras Timar 
AuthorDate: Thu Feb 10 10:18:56 2022 +0100
Commit: Andras Timar 
CommitDate: Thu Feb 10 10:18:56 2022 +0100

Bump version to 21.06.16.1

Change-Id: If4a9c4f3445284eb6b16612b34c9017f642c3668

diff --git a/configure.ac b/configure.ac
index d285d3be39b3..7f38013dbb83 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[21.06.15.1],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[21.06.16.1],[],[],[https://collaboraoffice.com/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[Libreoffice-bugs] [Bug 116400] Very time lengthy PDF-generation due to Upgrade to ICU ( see comment 9 and 19 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116400

--- Comment #25 from Telesto  ---
(In reply to Timur from comment #19)
> So this is a problem (High for multiple bugs), but what is ICU, where to
> report?

Well the big question is, is it a implementation error at LibreOffice side or a
ICU bug. The performance degradation is - IIRC- being caused by the Break
Iterator

Changelog of 62 (https://icu.unicode.org/download/62#TOC-ICU4C-Download)
mentions a change here:
"Break Iterator Rules: "Safe" rules are no longer required for correct break
iterator operation. For back compatibility, existing rule sets containing safe
rules will continue to work, with the safe rules they contain being ignored.
The Break Iterator binary data format has been updated to reflect this change."

I admit having trouble to decipher the 'change log message' But I interpret it
that ICU might ignore certain defined (and previously required) LibO rules for
searching "boundary positions" since 62

So ICU break iterator might doing more work compared to previously (by design).
Which might be redundant in case of LibreOffice. So might be that the upgrade
did need some additional tweaking to adapt to context of LibreOffice, to
improve performance.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 84848] TOOLBAR: Removal/Hiding of cut, copy, paste in the standard toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84848

--- Comment #22 from Quest Dubai  ---
Thanks for sharing this information.
Entry2Exit visitor management system is a perfect tool to install at the
check-in area. 

Approve the data of the guests and assume full responsibility for the premises
with our completely robotized Visitor Management system in Dubai. 
Website: https://www.quest-me.com/visitor-management-system/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa sc/source

[Justin Luth (via logerrit)]

 sc/qa/uitest/calc_tests/autofill.py |   30 ++
 sc/qa/uitest/data/autofill.ods  |binary
 sc/source/core/data/table2.cxx  |7 +--
 3 files changed, 35 insertions(+), 2 deletions(-)

New commits:
commit bda200a5e9c4592bd61b7924fa171ec3265bfd24
Author: Justin Luth 
AuthorDate: Wed Feb 9 20:17:53 2022 +0200
Commit: Justin Luth 
CommitDate: Thu Feb 10 10:04:18 2022 +0100

tdf#113785 sc: IsDataFiltered must be normalized

I can't believe this hasn't caused major issues
and has survived as a bug for so long.

Due to the way IsDataFiltered is coded,
it is required that the range is normalized
in order to get any kind of meaningful result,
so lets ensure that.

Change-Id: I2ede77f738fbaeb05a0f1425a2e88e59fca08e9e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129735
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sc/qa/uitest/calc_tests/autofill.py 
b/sc/qa/uitest/calc_tests/autofill.py
index bdb45d00c9c9..294d60fd7102 100644
--- a/sc/qa/uitest/calc_tests/autofill.py
+++ b/sc/qa/uitest/calc_tests/autofill.py
@@ -49,6 +49,36 @@ class CalcAutofill(UITestCase):
 self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
10).getValue(), 17.34)
 self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
11).getValue(), 18.34)
 
+#Test that hidden cells are not affected / skipped in the 
increment process.
+#Simulate selecting cell A26 and dragging the fill handle in the 
bottom right corner of the cell down to A32
+gridwin.executeAction("SELECT", mkPropertyValues({"RANGE": 
"A26:A32"}))
+with 
self.ui_test.execute_dialog_through_command(".uno:FillSeries"):
+pass
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
25).getValue(), 18.34)
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
26).getValue(), 19.34)
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
27).getValue(), 5.0) #hidden
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
28).getValue(), 5.0) #hidden
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
29).getString(), "hiddenA30")
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
30).getValue(), 20.34) #overwrite "rows"
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
31).getValue(), 21.34)
+#Simulate selecting cell A26 and dragging the fill handle in the 
bottom right corner of the cell up to A19
+#   Note: start at empty cell A19 so Sheet - Fill Cells - Fill 
Series has good defaults
+gridwin.executeAction("SELECT", mkPropertyValues({"RANGE": 
"A19:A26"}))
+with 
self.ui_test.execute_dialog_through_command(".uno:FillSeries") as xDialog:
+xup = xDialog.getChild("up")
+xincrement = xDialog.getChild("increment")
+xup.executeAction("CLICK", tuple())
+xincrement.executeAction("TYPE", 
mkPropertyValues({"KEYCODE":"CTRL+A"}))
+xincrement.executeAction("TYPE", 
mkPropertyValues({"KEYCODE":"BACKSPACE"}))
+xincrement.executeAction("TYPE", 
mkPropertyValues({"TEXT":"-1"}))
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
19).getString(), "hiddenA20")
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
20).getValue(), 15.34)
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
21).getValue(), 5.0) #hidden
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
22).getValue(), 16.34) #overwrite "testing"
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
23).getValue(), 5.0) #hidden
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
24).getValue(), 17.34) #overwrite "hidden"
+self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
25).getValue(), 18.34)
+
 #Continue with the next cells with grey background
 gridwin.executeAction("SELECT", mkPropertyValues({"RANGE": 
"M12:M18"}))
 with 
self.ui_test.execute_dialog_through_command(".uno:FillSeries"):
diff --git a/sc/qa/uitest/data/autofill.ods b/sc/qa/uitest/data/autofill.ods
index 4456e8c8..90bf933c0c26 100644
Binary files a/sc/qa/uitest/data/autofill.ods and 
b/sc/qa/uitest/data/autofill.ods differ
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index fa322f333821..a19549e89f9d 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -3666,6 +3666,8 @@ void ScTable::ShowRows(SCROW nRow1, SCROW nRow2, bool 
bShow)
 
 bool ScTable::IsDataFiltered(SCCOL nColStart, SCROW nRowStart, SCCOL nColEnd, 
SCROW nRowEnd) const
 {
+assert(nColStart <= nColEnd && nRowStart <= nRowEnd
+   && "range must be normalized to obtain a valid result");
 for (SCROW i = nRowStart; i <= nRowEnd; ++i)
 {
 

[Libreoffice-bugs] [Bug 147338] New: Collabora Office - StartCenter - clicking on the Collabora Office logo sends user to LibreOffice website

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147338

Bug ID: 147338
   Summary: Collabora Office - StartCenter - clicking on the
Collabora Office logo sends user to LibreOffice
website
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: ARM
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ipla...@tuta.io

Description:
1) Start Collabora Office
2) Click on the Collabora Office logo
3) User is directed to the LibreOffice website

Steps to Reproduce:
See above

Actual Results:
User is directed to LibreOffice website and not Collabora website - this is
misleading for a branded product

Expected Results:
If anything, user should be directed to Collabora website.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 21.06.15.1
Build ID: 60a66e4bf6afbf5d4221dab436bb1aca744a7ddf
CPU threads: 8; OS: Mac OS X 12.2; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107779] Sorting breaks rows data alignement when functions include columns with no data

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107779

Heiko Tietze  changed:

   What|Removed |Added

URL||https://help.libreoffice.or
   ||g/7.3/en-US/text/shared/opt
   ||ionen/01060300.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107779] Sorting breaks rows data alignement when functions include columns with no data

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107779

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||olivier.hallot@libreoffice.
   ||org
   Keywords|needsUXEval |
  Component|Calc|Documentation

--- Comment #22 from Heiko Tietze  ---
To me, "Update references when sorting range of cells" is clearly a switch to
not sort the cells but the references. But at least we have a documentation
gap.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 107779] Sorting breaks rows data alignement when functions include columns with no data

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107779

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||olivier.hallot@libreoffice.
   ||org
   Keywords|needsUXEval |
  Component|Calc|Documentation

--- Comment #22 from Heiko Tietze  ---
To me, "Update references when sorting range of cells" is clearly a switch to
not sort the cells but the references. But at least we have a documentation
gap.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 147336] Collabora Office - Localized help not installed message, yet not possible to install separate localized help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147336

--- Comment #1 from Alex Thurgood  ---
For comparison, the Help button at the bottom left hand side of the StartCenter
also has the same problem, and displays the same error message.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147337] Collabora Office - Template Management dialog contains inactive Extensions button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147337

--- Comment #1 from Alex Thurgood  ---
FWIW, for comparison, the corresponding button in the StartCenter (the big
Extensions button at the bottom on the left hand side) does open a link in the
browser to the LO extensions website.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116400] Very time lengthy PDF-generation due to Upgrade to ICU ( see comment 9 and 19 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116400

--- Comment #24 from Buovjaga  ---
(In reply to Timur from comment #19)
> So this is a problem (High for multiple bugs), but what is ICU, where to
> report?

https://icu.unicode.org/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cui/source include/editeng include/sfx2 include/svx sc/inc sc/source sd/inc sd/source sw/inc sw/source

[Noel Grandin (via logerrit)]

 cui/source/tabpages/page.cxx  |3 -
 cui/source/tabpages/themepage.cxx |3 -
 include/editeng/editids.hrc   |4 +-
 include/editeng/eeitem.hxx|3 +
 include/sfx2/sfxsids.hrc  |   71 +++---
 include/svx/svxids.hrc|   20 +-
 sc/inc/sc.hrc |   67 ++-
 sc/inc/scitems.hxx|   21 +--
 sc/source/ui/dbgui/tpsort.cxx |4 +-
 sc/source/ui/optdlg/tpcalc.cxx|5 +-
 sc/source/ui/optdlg/tpformula.cxx |3 -
 sc/source/ui/view/cellsh1.cxx |   11 ++---
 sc/source/ui/view/cellsh2.cxx |   12 +++---
 sd/inc/app.hrc|2 -
 sd/inc/sdattr.hrc |   31 
 sd/source/core/anminfo.cxx|2 -
 sd/source/ui/dlg/paragr.cxx   |4 +-
 sd/source/ui/dlg/tpoption.cxx |   17 +++--
 sd/source/ui/func/fuprlout.cxx|8 ++--
 sw/inc/cmdid.h|   49 +-
 sw/source/ui/config/optpage.cxx   |6 +--
 sw/source/ui/frmdlg/frmpage.cxx   |2 -
 22 files changed, 171 insertions(+), 177 deletions(-)

New commits:
commit 1c0aa970650ffc7c749e0b5ea655ebb2d137c8ae
Author: Noel Grandin 
AuthorDate: Wed Feb 9 15:57:36 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu Feb 10 09:47:46 2022 +0100

add more TypedWhichId

Change-Id: I6401dcf2507ac53a71dbe4de4ba774aed905961e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129731
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index f78cda0ee602..69bbbcc10d94 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -665,8 +665,7 @@ bool SvxPageDescPage::FillItemSet( SfxItemSet* rSet )
 if (rOldSet.HasItem(SID_ATTR_CHAR_GRABBAG))
 {
 // Set gutter position.
-SfxGrabBagItem aGrabBagItem(
-static_cast(rOldSet.Get(SID_ATTR_CHAR_GRABBAG)));
+SfxGrabBagItem aGrabBagItem(rOldSet.Get(SID_ATTR_CHAR_GRABBAG));
 if (m_xGutterPositionLB->get_value_changed_from_saved())
 {
 bool bGutterAtTop = m_xGutterPositionLB->get_active() == 1;
diff --git a/cui/source/tabpages/themepage.cxx 
b/cui/source/tabpages/themepage.cxx
index 35eb9156398a..b175ae8754c3 100644
--- a/cui/source/tabpages/themepage.cxx
+++ b/cui/source/tabpages/themepage.cxx
@@ -133,8 +133,7 @@ bool SvxThemePage::FillItemSet(SfxItemSet* pAttrs)
 if (!rOldSet.HasItem(SID_ATTR_CHAR_GRABBAG))
 return true;
 
-SfxGrabBagItem aGrabBagItem(
-static_cast(rOldSet.Get(SID_ATTR_CHAR_GRABBAG)));
+SfxGrabBagItem aGrabBagItem(rOldSet.Get(SID_ATTR_CHAR_GRABBAG));
 
 comphelper::SequenceAsHashMap aMap;
 auto it = aGrabBagItem.GetGrabBag().find("Theme");
diff --git a/include/editeng/editids.hrc b/include/editeng/editids.hrc
index ac7c2bf763a9..91456529af23 100644
--- a/include/editeng/editids.hrc
+++ b/include/editeng/editids.hrc
@@ -88,7 +88,7 @@ class SvxLanguageItem;
 #define SID_ATTR_PARA_PAGENUM   ( SID_SVX_START + 457 )
 #define SID_ATTR_PARA_NUMRULE   ( SID_SVX_START + 587 )
 #define SID_ATTR_BRUSH_CHAR ( SID_SVX_START + 591 )
-#define SID_ATTR_NUMBERING_RULE ( SID_SVX_START + 855 )
+#define SID_ATTR_NUMBERING_RULE 
TypedWhichId( SID_SVX_START + 855 )
 #define SID_ATTR_CHAR_CHARSETCOLOR  ( SID_SVX_START + 877 )
 #define SID_ATTR_CHAR_CJK_FONT  ( SID_SVX_START + 887 )
 #define SID_ATTR_CHAR_CJK_FONTHEIGHT( SID_SVX_START + 888 )
@@ -123,7 +123,7 @@ class SvxLanguageItem;
 #define SID_ATTR_CHAR_LATIN_LANGUAGE( SID_SVX_START + 996 )
 #define SID_ATTR_CHAR_LATIN_POSTURE ( SID_SVX_START + 997 )
 #define SID_ATTR_CHAR_LATIN_WEIGHT  ( SID_SVX_START + 998 )
-#define SID_ATTR_CHAR_GRABBAG   ( SID_SVX_START + 1142 
)
+#define SID_ATTR_CHAR_GRABBAG   
TypedWhichId( SID_SVX_START + 1142 )
 #define SID_ATTR_CHAR_BACK_COLOR( SID_SVX_START + 1153 
)
 
 // these ID didn't exist prior to the svx split, add new ids here
diff --git a/include/editeng/eeitem.hxx b/include/editeng/eeitem.hxx
index e4908ee59e0c..28e5d8a0dd80 100644
--- a/include/editeng/eeitem.hxx
+++ b/include/editeng/eeitem.hxx
@@ -36,6 +36,7 @@ class SvxContourItem;
 class SvxCrossedOutItem;
 class SvxEmphasisMarkItem;
 class SvxEscapementItem;
+class SvxFieldItem;
 class SvxFontHeightItem;
 class SvxFontItem;
 class SvxForbiddenRuleItem;
@@ -134,7 +135,7 @@ constexpr sal_uInt16 EE_FEATURE_START   (EE_CHAR_END + 1);
 constexpr sal_uInt16 EE_FEATURE_TAB (EE_FEATURE_START + 0);
 constexpr sal_uInt16 EE_FEATURE_LINEBR  (EE_FEATURE_TAB + 1);
 constexpr sal_uInt16 

[Libreoffice-bugs] [Bug 147337] New: Collabora Office - Template Management dialog contains inactive Extensions button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147337

Bug ID: 147337
   Summary: Collabora Office - Template Management dialog contains
inactive Extensions button
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: ARM
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ipla...@tuta.io

Description:
1) Open the StartCenter
2) Click on the dropdown menu arrow on Templates
3) Click on Manage Templates
4) Click on the Extensions button - nothing happens

Steps to Reproduce:
See above

Actual Results:
The "Extensions" button in the Template Management dialog is inactive.

Expected Results:
The button should open a link in the default configured OS browser of choice
and load a URL for the Extensions page.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 21.06.15.1
Build ID: 60a66e4bf6afbf5d4221dab436bb1aca744a7ddf
CPU threads: 8; OS: Mac OS X 12.2; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147195] ScriptForge "L10N" service stopped working in LO 7.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147195

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEEDINFO

--- Comment #4 from Xisco Faulí  ---
Hello Rafael,
Probably this is the same issue as tdf#146836.
https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-7-3=1a343e3168c6ac8acf3279307275727e588ddcb7
just landed in libreoffice-7-3 and it should fix it.
Could you please wait a couple a days and test again with a daily build from
https://dev-builds.libreoffice.org/daily/libreoffice-7-3/current.html
containing the patch ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: wizards/source

[Jean-Pierre Ledure (via logerrit)]

 wizards/source/scriptforge/SF_Utils.xba |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 3e340d3f7b73c8577e58c561a34c2b826e77da51
Author: Jean-Pierre Ledure 
AuthorDate: Wed Feb 9 14:33:25 2022 +0100
Commit: Jean-Pierre Ledure 
CommitDate: Thu Feb 10 09:43:10 2022 +0100

ScriptForge - (SF_Utils) review optional argument of _Repr()

As from LO 7.3, optional missing arguments must not be used
in assignments and comparisons.
The Basic interpreter tolerated it before 7.3.

Probable commit having changed Basic behaviour:
https://gerrit.libreoffice.org/c/core/+/121794

A unique case of this singularity was found in the
SF_Utils._Repr()
method.

The bad consequence was that the commonly used
SF_Exception.DebugPrint()
method calls above method. This broke in fact
the whole ScriptForge library.

Change-Id: Iba8792b92c73c992429de4382bd8a3dc4b58a94f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129728
Tested-by: Jean-Pierre Ledure 
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure 

diff --git a/wizards/source/scriptforge/SF_Utils.xba 
b/wizards/source/scriptforge/SF_Utils.xba
index 2ca9a6fe09d3..a6a4f49abe4d 100644
--- a/wizards/source/scriptforge/SF_Utils.xba
+++ b/wizards/source/scriptforge/SF_Utils.xba
@@ -542,7 +542,8 @@ Const cstMaxLength = 2^15 - 1 32767
 Const cstByteLength = 25
 Const cstEtc =  … 
 
-   If IsMissing(plMax) Or plMax = 0 Then plMax = cstMaxLength
+   If IsMissing(plMax) Then plMax = cstMaxLength
+   If plMax = 0 Then plMax = cstMaxLength
If IsArray(pvArg) Then
sArg = SF_Array._Repr(pvArg)
Else

[Libreoffice-bugs] [Bug 147336] New: Collabora Office - Localized help not installed message, yet not possible to install separate localized help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147336

Bug ID: 147336
   Summary: Collabora Office - Localized help not installed
message, yet not possible to install separate
localized help
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: ARM
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ipla...@tuta.io

Description:
1 Open the StartCenter

2) Click on the dropdown menu arrow on the "Templates" entry on lefthand side
of StartCenter

3) Select "Manage Tepmlates" from the dropdown menu

4) Click on "Help"
An error message is displayed:

"L'aide interne de Collabora Office pour la langue de l'UI active (Français
(France)) n'est pas installée sur votre ordinateur."
"Vous pouvez soit l'installer depuis notre site web ou votre dépôt logiciel,
soit lire la version en ligne."

The choices are either "Access content online" or "Cancel".

There is no option to find, download, and install a localized help.


Steps to Reproduce:
See above

Actual Results:
No possibility to download and install localized help

Expected Results:
Either the error message is irrelevant, because Collabora simply doesn't bundle
and/or provide an integrated localized help, or else the message is relevant,
in which case the possibility to download and install the localized help
indicated by the message should be made available or included in the AppStore
bundle.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 21.06.15.1
Build ID: 60a66e4bf6afbf5d4221dab436bb1aca744a7ddf
CPU threads: 8; OS: Mac OS X 12.2; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: configure.ac

[Luboš Luňák (via logerrit)]

 configure.ac |1 -
 1 file changed, 1 deletion(-)

New commits:
commit cecf2082df0427babc491dfad10f6e15e0ec7583
Author: Luboš Luňák 
AuthorDate: Wed Feb 9 13:33:00 2022 +0100
Commit: Luboš Luňák 
CommitDate: Thu Feb 10 09:39:47 2022 +0100

do not use /arch:SSE with MSVC

It looks like I missed this one when making SSE2 our MSVC baseline
in 75edcfc0569ca76fa22db451fd61138e52870a62 .

Change-Id: Iec8dd1522187a32ed379d387439ee01074a624ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129722
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/configure.ac b/configure.ac
index bb53c75fac73..cb296ab52dc7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4270,7 +4270,6 @@ if test "$_os" = "WINNT"; then
 elif test -n "$WIN_MULTI_ARCH"; then
 BUILD_X86=TRUE
 CXX_X86_BINARY=`win_short_path_for_make "$MSVC_MULTI_PATH/cl.exe"`
-CXX_X86_BINARY+=" /arch:SSE"
 AC_MSG_RESULT([found])
 else
 AC_MSG_RESULT([not found])

[Libreoffice-commits] core.git: sc/inc sc/source

[Luboš Luňák (via logerrit)]

 sc/inc/fillinfo.hxx  |   22 +++---
 sc/source/core/data/fillinfo.cxx |   11 +++
 sc/source/ui/view/output.cxx |   12 ++--
 3 files changed, 32 insertions(+), 13 deletions(-)

New commits:
commit 73cfd7eeac7031c97a57bba82677f36ef1eff731
Author: Luboš Luňák 
AuthorDate: Tue Feb 8 20:54:16 2022 +0100
Commit: Luboš Luňák 
CommitDate: Thu Feb 10 09:39:13 2022 +0100

avoid destructing many unique_ptr's most of which are nullptr

With huge sheets there are so many CellInfo structures that
calling all the destructors actually shows up in profiler data
while trying to scroll around (it allocates CellInfo for every
column starting from 0 up to the last one wanted). Keep
the owning pointers in a vector that'll be much faster to process.

Change-Id: Ibadb05fcce467fb808c38e2ed9a13b4cfef3720e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129699
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/inc/fillinfo.hxx b/sc/inc/fillinfo.hxx
index e5926808bf60..0bc72e4e3ed3 100644
--- a/sc/inc/fillinfo.hxx
+++ b/sc/inc/fillinfo.hxx
@@ -101,6 +101,8 @@ struct CellInfo
 CellInfo()
 : pPatternAttr(nullptr)
 , pConditionSet(nullptr)
+, pDataBar(nullptr)
+, pIconSet(nullptr)
 , pBackground(nullptr)   // TODO: omit?
 , pLinesAttr(nullptr)
 , mpTLBRLine(nullptr)
@@ -134,9 +136,9 @@ struct CellInfo
 
 const ScPatternAttr*pPatternAttr;
 const SfxItemSet*   pConditionSet;
-std::optional  mxColorScale;
-std::unique_ptr pDataBar;
-std::unique_ptr pIconSet;
+std::optionalmxColorScale;
+const ScDataBarInfo*pDataBar;
+const ScIconSetInfo*pIconSet;
 
 const SvxBrushItem* pBackground;
 
@@ -229,6 +231,20 @@ struct ScTableInfo
 ~ScTableInfo();
 ScTableInfo(const ScTableInfo&) = delete;
 const ScTableInfo& operator=(const ScTableInfo&) = delete;
+
+void addDataBarInfo(std::unique_ptr info)
+{
+mDataBarInfos.push_back(std::move(info));
+}
+void addIconSetInfo(std::unique_ptr info)
+{
+mIconSetInfos.push_back(std::move(info));
+}
+private:
+// These are owned here and not in CellInfo to avoid freeing
+// memory for every pointer in CellInfo, most of which are nullptr.
+std::vector> mDataBarInfos;
+std::vector> mIconSetInfos;
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/core/data/fillinfo.cxx b/sc/source/core/data/fillinfo.cxx
index 1dca158f1e28..db18514b7120 100644
--- a/sc/source/core/data/fillinfo.cxx
+++ b/sc/source/core/data/fillinfo.cxx
@@ -276,7 +276,7 @@ void initColWidths(RowInfo* pRowInfo, const ScDocument* 
pDoc, double fColScale,
 }
 
 bool handleConditionalFormat(ScConditionalFormatList& rCondFormList, const 
ScCondFormatIndexes& rCondFormats,
-CellInfo* pInfo, ScStyleSheetPool* pStlPool,
+CellInfo* pInfo, ScTableInfo* pTableInfo, ScStyleSheetPool* pStlPool,
 const ScAddress& rAddr, bool& bHidden, bool& bHideFormula, bool 
bTabProtect)
 {
 bool bFound = false;
@@ -324,13 +324,15 @@ bool handleConditionalFormat(ScConditionalFormatList& 
rCondFormList, const ScCon
 
 if(aData.pDataBar)
 {
-pInfo->pDataBar = std::move(aData.pDataBar);
+pInfo->pDataBar = aData.pDataBar.get();
+pTableInfo->addDataBarInfo(std::move(aData.pDataBar));
 bFound = true;
 }
 
 if(aData.pIconSet)
 {
-pInfo->pIconSet = std::move(aData.pIconSet);
+pInfo->pIconSet = aData.pIconSet.get();
+pTableInfo->addIconSetInfo(std::move(aData.pIconSet));
 bFound = true;
 }
 
@@ -552,7 +554,8 @@ void ScDocument::FillInfo(
 
 if (bContainsCondFormat && pCondFormList)
 {
-bAnyCondition |= 
handleConditionalFormat(*pCondFormList, rCondFormats, pInfo, pStlPool, 
ScAddress(nCol, nCurRow, nTab),
+bAnyCondition |= 
handleConditionalFormat(*pCondFormList, rCondFormats,
+pInfo, , pStlPool, 
ScAddress(nCol, nCurRow, nTab),
 bHidden, bHideFormula, 
bTabProtect);
 }
 
diff --git a/sc/source/ui/view/output.cxx b/sc/source/ui/view/output.cxx
index 776c164cd2d7..810b01812769 100644
--- a/sc/source/ui/view/output.cxx
+++ b/sc/source/ui/view/output.cxx
@@ -789,8 +789,8 @@ static bool lcl_EqualBack( const RowInfo& rFirst, const 
RowInfo& rOther,
 if (pCol1 && (*pCol1 != *pCol2))
 return false;
 
-const ScDataBarInfo* pInfo1 = rFirst.cellInfo(nX).pDataBar.get();
-const ScDataBarInfo* pInfo2 = rOther.cellInfo(nX).pDataBar.get();
+const ScDataBarInfo* 

[Libreoffice-commits] core.git: sc/inc sc/source

[Luboš Luňák (via logerrit)]

 sc/inc/fillinfo.hxx  |   30 +-
 sc/source/core/data/fillinfo.cxx |  191 ++-
 sc/source/ui/inc/output.hxx  |2 
 sc/source/ui/view/gridwin4.cxx   |4 
 sc/source/ui/view/output.cxx |  161 +++-
 sc/source/ui/view/output2.cxx|   68 ++---
 sc/source/ui/view/printfun.cxx   |6 -
 7 files changed, 237 insertions(+), 225 deletions(-)

New commits:
commit d48e68407931fc33044aa7f3fc9e971897fac610
Author: Luboš Luňák 
AuthorDate: Tue Feb 8 20:02:04 2022 +0100
Commit: Luboš Luňák 
CommitDate: Thu Feb 10 09:38:54 2022 +0100

clean up accessing CellInfo array in RowInfo

The array allocates one extra item before and after, which means
all indexing must add 1 to column number. And a lot of the code
uses array index variables instead of column numbers, which
makes it confusing whether the value is +1 or not. To sort this
out, hide the array inside RowInfo and provide access functions
that will hide those +1 from caller code, plus it will do error
checking.

Change-Id: Ia91bd76e15fc6c96c09f27c742d71001f4c4151c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129698
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/inc/fillinfo.hxx b/sc/inc/fillinfo.hxx
index 9c8681d8f43e..e5926808bf60 100644
--- a/sc/inc/fillinfo.hxx
+++ b/sc/inc/fillinfo.hxx
@@ -176,7 +176,26 @@ struct RowInfo
 RowInfo(const RowInfo&) = delete;
 const RowInfo& operator=(const RowInfo&) = delete;
 
-CellInfo*   pCellInfo;
+CellInfo&   cellInfo(SCCOL nCol)
+{
+#ifdef DBG_UTIL
+assert( nCol >= -1 && nCol <= nCols + 1 );
+#endif
+return pCellInfo[ nCol + 1 ];
+}
+const CellInfo& cellInfo(SCCOL nCol) const
+{
+return const_cast(this)->cellInfo(nCol);
+}
+
+voidallocCellInfo(SCCOL cols)
+{
+#ifdef DBG_UTIL
+nCols = cols;
+#endif
+pCellInfo = new CellInfo[ cols + 2 ];
+}
+voidfreeCellInfo() { delete[] pCellInfo; }
 
 sal_uInt16  nHeight;
 SCROW   nRowNo;
@@ -186,6 +205,15 @@ struct RowInfo
 boolbAutoFilter:1;
 boolbPivotButton:1;
 boolbChanged:1;   // TRUE, if not tested
+
+private:
+// This class allocates CellInfo with also one item extra before and after.
+// To make handling easier, this is private and access functions take care 
of adjusting
+// the array indexes and error-checking.
+CellInfo*   pCellInfo;
+#ifdef DBG_UTIL
+SCCOL   nCols;
+#endif
 };
 
 struct ScTableInfo
diff --git a/sc/source/core/data/fillinfo.cxx b/sc/source/core/data/fillinfo.cxx
index e8480553fef3..1dca158f1e28 100644
--- a/sc/source/core/data/fillinfo.cxx
+++ b/sc/source/core/data/fillinfo.cxx
@@ -53,7 +53,7 @@ static void lcl_GetMergeRange( SCCOL nX, SCROW nY, SCSIZE 
nArrY,
 SCCOL nX1, SCROW nY1, SCTAB nTab,
 SCCOL& rStartX, SCROW& rStartY, SCCOL& rEndX, 
SCROW& rEndY )
 {
-CellInfo* pInfo = [nArrY].pCellInfo[nX+1];
+CellInfo* pInfo = [nArrY].cellInfo(nX);
 
 rStartX = nX;
 rStartY = nY;
@@ -67,8 +67,8 @@ static void lcl_GetMergeRange( SCCOL nX, SCROW nY, SCSIZE 
nArrY,
 --rStartX;
 if (rStartX >= nX1 && !pDoc->ColHidden(rStartX, nTab, nullptr, 
))
 {
-bHOver = pRowInfo[nArrY].pCellInfo[rStartX+1].bHOverlapped;
-bVOver = pRowInfo[nArrY].pCellInfo[rStartX+1].bVOverlapped;
+bHOver = pRowInfo[nArrY].cellInfo(rStartX).bHOverlapped;
+bVOver = pRowInfo[nArrY].cellInfo(rStartX).bVOverlapped;
 }
 else
 {
@@ -90,7 +90,7 @@ static void lcl_GetMergeRange( SCCOL nX, SCROW nY, SCSIZE 
nArrY,
 !pDoc->RowHidden(rStartY, nTab, nullptr, ) &&
 pRowInfo[nArrY].nRowNo == rStartY)
 {
-bVOver = pRowInfo[nArrY].pCellInfo[rStartX+1].bVOverlapped;
+bVOver = pRowInfo[nArrY].cellInfo(rStartX).bVOverlapped;
 }
 else
 {
@@ -106,7 +106,7 @@ static void lcl_GetMergeRange( SCCOL nX, SCROW nY, SCSIZE 
nArrY,
 !pDoc->RowHidden(rStartY, nTab, nullptr, ) &&
 pRowInfo[nArrY].nRowNo == rStartY)
 {
-pMerge = [nArrY].pCellInfo[rStartX+1].pPatternAttr->
+pMerge = [nArrY].cellInfo(rStartX).pPatternAttr->
 GetItem(ATTR_MERGE);
 }
 else
@@ -123,7 +123,7 @@ class RowInfoFiller
 ScDocument& mrDoc;
 SCTAB mnTab;
 RowInfo* mpRowInfo;
-SCCOL mnArrX;
+SCCOL mnCol;
 SCSIZE mnArrY;
 SCROW mnHiddenEndRow;
 bool mbHiddenRow;
@@ -147,15 +147,15 @@ class RowInfoFiller
 alignArray(nRow);
 
 RowInfo& rThisRowInfo = mpRowInfo[mnArrY];
-CellInfo& rInfo = rThisRowInfo.pCellInfo[mnArrX];
+

[Libreoffice-bugs] [Bug 147322] drag & drop table moving doesn't work (regression of tdf#84806)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147322

--- Comment #3 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/9493147ad6b046a4685896d594ed257800552f67

tdf#147181 tdf#147322 sw: fix drag & drop multiple table rows

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147181] FILEEDIT ODT Track changes of multiple table rows copied

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147181

--- Comment #10 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/9493147ad6b046a4685896d594ed257800552f67

tdf#147181 tdf#147322 sw: fix drag & drop multiple table rows

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/qa sw/source

[László Németh (via logerrit)]

 sw/qa/extras/uiwriter/uiwriter4.cxx |   55 
 sw/source/core/edit/edredln.cxx |   46 --
 sw/source/uibase/uiview/view2.cxx   |   14 -
 3 files changed, 112 insertions(+), 3 deletions(-)

New commits:
commit d4a503a030706bf609e498e25888d400cc5aaefa
Author: László Németh 
AuthorDate: Wed Feb 9 12:15:33 2022 +0100
Commit: László Németh 
CommitDate: Thu Feb 10 09:37:10 2022 +0100

tdf#147182 sw: accept/reject all changes of a table selection

Selecting multiple cells of a text table which contain
tracked text changes, and choosing Accept Track Change/Reject
Track Change, only text changes of the first cell were
accepted/rejected (a problem inherited from OOo).

The fix allows to accept/reject also all tracked row
deletions/insertions in the selected table rows by a single
click.

Note for manual testing: first cell of the selection should
still contain a tracked change, otherwise Accept Track Change/
Reject Track Change menu items/icons aren't active.

Conflicts:
sw/qa/extras/uiwriter/uiwriter4.cxx

Change-Id: I11e71075f4144bba86dda690ec712a24ccf815dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129717
Tested-by: László Németh 
Reviewed-by: László Németh 
(cherry-picked from commit 23846867ea32667ccf328c36142394dd6aaee8ba)

Change-Id: I0d04de5b4c482e64ffd1a3b166968163139e7791
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129743
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/uiwriter/uiwriter4.cxx 
b/sw/qa/extras/uiwriter/uiwriter4.cxx
index f7ff97ca1f02..aa807418e348 100644
--- a/sw/qa/extras/uiwriter/uiwriter4.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter4.cxx
@@ -202,6 +202,7 @@ public:
 void testTableRedlineRedoCrash();
 void testTableRemoveHasTextChangesOnly();
 void testTableRemoveHasTextChangesOnly2();
+void testTdf147182_AcceptAllChangesInTableSelection();
 void testTdf66405();
 void testTdf35021_tabOverMarginDemo();
 void testTdf106701_tabOverMarginAutotab();
@@ -329,6 +330,7 @@ public:
 CPPUNIT_TEST(testTableRedlineRedoCrash);
 CPPUNIT_TEST(testTableRemoveHasTextChangesOnly);
 CPPUNIT_TEST(testTableRemoveHasTextChangesOnly2);
+CPPUNIT_TEST(testTdf147182_AcceptAllChangesInTableSelection);
 CPPUNIT_TEST(testTdf66405);
 CPPUNIT_TEST(testTdf35021_tabOverMarginDemo);
 CPPUNIT_TEST(testTdf106701_tabOverMarginAutotab);
@@ -1657,6 +1659,59 @@ void 
SwUiWriterTest4::testTableRemoveHasTextChangesOnly2()
 CPPUNIT_ASSERT_EQUAL(static_cast(14), 
pEditShell->GetRedlineCount());
 }
 
+void SwUiWriterTest4::testTdf147182_AcceptAllChangesInTableSelection()
+{
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "TC-table-del-add.docx");
+CPPUNIT_ASSERT(pDoc);
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+CPPUNIT_ASSERT(pWrtShell);
+
+// check redline count
+SwEditShell* const pEditShell(pDoc->GetEditShell());
+CPPUNIT_ASSERT_EQUAL(static_cast(14), 
pEditShell->GetRedlineCount());
+
+// 4 rows in Show Changes mode
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+assertXPath(pXmlDoc, "/root/page[1]/body/tab[1]/row", 4);
+
+// Select the first table to get a table selection
+dispatchCommand(mxComponent, ".uno:SelectAll", {});
+dispatchCommand(mxComponent, ".uno:SelectAll", {});
+dispatchCommand(mxComponent, ".uno:AcceptTrackedChange", {});
+Scheduler::ProcessEventsToIdle();
+discardDumpedLayout();
+pXmlDoc = parseLayoutDump();
+// Accepting tracked changes in the selected table results 3 rows
+// This was 4 (only text changes of the first selected cell were accepted)
+assertXPath(pXmlDoc, "/root/page[1]/body/tab[1]/row", 3);
+CPPUNIT_ASSERT_EQUAL(static_cast(8), 
pEditShell->GetRedlineCount());
+
+// Undo: 4 rows again
+pDoc->GetIDocumentUndoRedo().Undo();
+discardDumpedLayout();
+pXmlDoc = parseLayoutDump();
+assertXPath(pXmlDoc, "/root/page[1]/body/tab[1]/row", 4);
+CPPUNIT_ASSERT_EQUAL(static_cast(14), 
pEditShell->GetRedlineCount());
+
+// To check Undo of HasTextChangesOnly reject the same row results 3 rows
+dispatchCommand(mxComponent, ".uno:Escape", {});
+dispatchCommand(mxComponent, ".uno:SelectAll", {});
+dispatchCommand(mxComponent, ".uno:SelectAll", {});
+dispatchCommand(mxComponent, ".uno:RejectTrackedChange", {});
+Scheduler::ProcessEventsToIdle();
+discardDumpedLayout();
+pXmlDoc = parseLayoutDump();
+// This was 4 (only text changes of the first selected cell were rejected)
+assertXPath(pXmlDoc, "/root/page[1]/body/tab[1]/row", 3);
+
+// Undo: 4 rows again
+pDoc->GetIDocumentUndoRedo().Undo();
+discardDumpedLayout();
+pXmlDoc = parseLayoutDump();
+assertXPath(pXmlDoc, "/root/page[1]/body/tab[1]/row", 4);
+

[Libreoffice-bugs] [Bug 147322] drag & drop table moving doesn't work (regression of tdf#84806)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147322

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0|target:7.4.0 target:7.3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147181] FILEEDIT ODT Track changes of multiple table rows copied

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147181

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0|target:7.4.0 target:7.3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/qa sw/source

[László Németh (via logerrit)]

 sw/qa/extras/uiwriter/uiwriter4.cxx  |  142 +++
 sw/source/uibase/dochdl/swdtflvr.cxx |  123 ++
 sw/source/uibase/inc/swdtflvr.hxx|7 -
 3 files changed, 255 insertions(+), 17 deletions(-)

New commits:
commit 9493147ad6b046a4685896d594ed257800552f67
Author: László Németh 
AuthorDate: Mon Feb 7 18:03:45 2022 +0100
Commit: László Németh 
CommitDate: Thu Feb 10 09:36:53 2022 +0100

tdf#147181 tdf#147322 sw: fix drag & drop multiple table rows

With change tracking, moving multiple table rows tracked
only the first row as deleted, and in the insertion point,
as inserted.

Without change tracking, only the first row were deleted
from the original position. This is a regression of tdf#84806
from commit 5e8aa259e48d5602b932353bb146ebb523982cf2
"tdf#146967 sw table: fix freezing in Hide Changes mode".

Add unit tests for the change tracking fix and for the original
table moving fix in commit 7fe64353dc9950e19182a59a486a1ecac27cf98e
"tdf#84806 Writer: drag and drop selected tables, don't empty".

Conflicts:
sw/qa/extras/uiwriter/uiwriter4.cxx

Change-Id: I43250fcef4bbf482e67a7414f4f655e75d226b55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129635
Tested-by: László Németh 
Reviewed-by: László Németh 
(cherry-picked from commit 2bb9ad2078e355b71ab25db0c46f3d0bb19cf6d4)

Change-Id: Id90664ba7611bb0fb7f03bcdf029ae4f211904cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129742
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/uiwriter/uiwriter4.cxx 
b/sw/qa/extras/uiwriter/uiwriter4.cxx
index 090938240c63..f7ff97ca1f02 100644
--- a/sw/qa/extras/uiwriter/uiwriter4.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter4.cxx
@@ -103,6 +103,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -260,6 +261,8 @@ public:
 void testTdf115013();
 void testTdf114536();
 void testTdf115065();
+void testTdf84806_MovingMultipleTableRows();
+void testTdf147181_TrackedMovingOfMultipleTableRows();
 void testTdf115132();
 void testXDrawPagesSupplier();
 void testTdf116403();
@@ -382,6 +385,8 @@ public:
 CPPUNIT_TEST(testTdf115013);
 CPPUNIT_TEST(testTdf114536);
 CPPUNIT_TEST(testTdf115065);
+CPPUNIT_TEST(testTdf84806_MovingMultipleTableRows);
+CPPUNIT_TEST(testTdf147181_TrackedMovingOfMultipleTableRows);
 CPPUNIT_TEST(testTdf115132);
 CPPUNIT_TEST(testXDrawPagesSupplier);
 CPPUNIT_TEST(testTdf116403);
@@ -2922,6 +2927,143 @@ void SwUiWriterTest4::testTdf115065()
 pWrtShell->Copy(*pWrtShell, ptFrom, ptTo);
 }
 
+void SwUiWriterTest4::testTdf84806_MovingMultipleTableRows()
+{
+// Moving of multiple table rows.
+// Source table (first one) has two rows;
+// destination (second one) has only one row
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "tdf115065.odt");
+CPPUNIT_ASSERT(pDoc);
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+CPPUNIT_ASSERT(pWrtShell);
+
+uno::Reference xTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xTables(xTablesSupplier->getTextTables(),
+uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTables->getCount());
+uno::Reference xTableNames = 
xTablesSupplier->getTextTables();
+CPPUNIT_ASSERT(xTableNames->hasByName("Table1"));
+CPPUNIT_ASSERT(xTableNames->hasByName("Table2"));
+uno::Reference xTable1(xTableNames->getByName("Table1"), 
uno::UNO_QUERY);
+uno::Reference xTable2(xTableNames->getByName("Table2"), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable1->getRows()->getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTable2->getRows()->getCount());
+
+// without redlining
+CPPUNIT_ASSERT_MESSAGE("redlining should be off",
+   !pDoc->getIDocumentRedlineAccess().IsRedlineOn());
+
+sw::UndoManager& rUndoManager = pDoc->GetUndoManager();
+
+pWrtShell->GotoTable("Table2");
+SwRect aRect = pWrtShell->GetCurrFrame()->getFrameArea();
+// Destination point is the middle of the first cell of second table
+Point ptTo(aRect.Left() + aRect.Width() / 2, aRect.Top() + aRect.Height() 
/ 2);
+
+// Move rows of the first table into the second table
+pWrtShell->GotoTable("Table1");
+pWrtShell->SelTable();
+rtl::Reference xTransfer = new SwTransferable(*pWrtShell);
+xTransfer->PrivateDrop(*pWrtShell, ptTo, /*bMove=*/true, 
/*bXSelection=*/true);
+
+// This was 2 tables
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTables->getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), xTable2->getRows()->getCount());
+
+// Undo results 2 tables
+rUndoManager.Undo();
+uno::Reference 
xTables2(xTablesSupplier->getTextTables(),
+ 

[Libreoffice-bugs] [Bug 147333] Sheet Styles in Calc (Page style)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147333

m.a.riosv  changed:

   What|Removed |Added

Summary|Sheet Styles in Calc|Sheet Styles in Calc (Page
   ||style)
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134632] Please bundle the Softastur Asturian Hunspell dictionary

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134632

Adolfo Jayme  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=59
   ||380

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - basic/source

[Julien Nabet (via logerrit)]

 basic/source/runtime/methods1.cxx |2 +-
 basic/source/runtime/stdobj.cxx   |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit bfb1aa23457425707aaa80c342820a25468df937
Author: Julien Nabet 
AuthorDate: Mon Feb 7 21:24:16 2022 +0100
Commit: Mike Kaganski 
CommitDate: Thu Feb 10 09:32:19 2022 +0100

tdf#147262: CallByName() argument names does not match that of VBA

Change-Id: I3029b98abbe3b8facf01f0e50a7efdff545c2141
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129646
Reviewed-by: Julien Nabet 
(cherry picked from commit a555aa25bd17781b2828e13ac81456a45387284d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129754
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/basic/source/runtime/methods1.cxx 
b/basic/source/runtime/methods1.cxx
index 117e84d73000..7e2d0c771a37 100644
--- a/basic/source/runtime/methods1.cxx
+++ b/basic/source/runtime/methods1.cxx
@@ -120,7 +120,7 @@ void SbRtl_CallByName(StarBASIC *, SbxArray & rPar, bool)
 return;
 }
 
-// 2. parameter is ProcedureName
+// 2. parameter is ProcName
 OUString aNameStr = rPar.Get(2)->GetOUString();
 
 // 3. parameter is CallType
diff --git a/basic/source/runtime/stdobj.cxx b/basic/source/runtime/stdobj.cxx
index 4adda6efafec..dcbc0ec05983 100644
--- a/basic/source/runtime/stdobj.cxx
+++ b/basic/source/runtime/stdobj.cxx
@@ -141,7 +141,7 @@ constexpr Method aMethods[] = {
 
 { u"CallByName",SbxVARIANT,  3 | FUNCTION_,
SbRtl_CallByName   },
 arg(u"Object",SbxOBJECT),
-arg(u"ProcedureName", SbxSTRING),
+arg(u"ProcName", SbxSTRING),
 arg(u"CallType",  SbxINTEGER),
 
 { u"CBool", SbxBOOL, 1 | FUNCTION_,
SbRtl_CBool},

[Libreoffice-bugs] [Bug 147135] Crash in: _GLOBAL__sub_I_protectiondlg.cxx.lto_priv.2643 ( Calc crashes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147135

--- Comment #64 from TBS  ---
I'm running LO 7.3.0.3 on PCLinuxOS.

No avx or avx2 flags available on the CPU or 2 computers, and Calc crashes on
both.

Other users with at least avx report no crashes.

See comment #60 by KJP for more.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - connectivity/source

[Stephan Bergmann (via logerrit)]

 connectivity/source/parse/sqlbison.y |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 6363eefbed60e3475061b8ea5aa8b6316d631d5e
Author: Stephan Bergmann 
AuthorDate: Tue Sep 14 12:20:48 2021 +0200
Commit: Michael Weghorn 
CommitDate: Thu Feb 10 09:30:34 2022 +0100

Adapt to Bison 3.8 internal yyn -> yyrule rename

see


"glr2.cc: log the execution of deferred actions" including "Rename argument 
yyn
as yyrule for clarity."

YYBISON was defined as 1 rather than as a representation of the Bison 
version
prior to


"yacc.c: provide the Bison version as an integral macro", which shouldn't 
be a
problem here.  And YYBISON is apparently completely undefined with
/usr/bin/bison on macOS.

(The preceding comment always mentioned "yyi" and "yyrmap" in apparent 
mismatch
with the actually used "yyn" and "yyr1" ever since
c25ec0608a167bcf1d891043f02273761c351701 "initial import", so just leave it
untouched.)

Change-Id: I4f901407aa21ed4abec84e661d813ee7599f02f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122082
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 45227d9b79dc4f2a2aa6874cd4e3c02b7934b197)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129744
Tested-by: Michael Weghorn 
Reviewed-by: Michael Weghorn 

diff --git a/connectivity/source/parse/sqlbison.y 
b/connectivity/source/parse/sqlbison.y
index dbf203f814a1..3aad860d2655 100644
--- a/connectivity/source/parse/sqlbison.y
+++ b/connectivity/source/parse/sqlbison.y
@@ -73,9 +73,15 @@ inline connectivity::OSQLInternalNode* newNode(const 
OUString& _newValue,
 
 // yyi is the internal number of the rule that is currently being reduced
 // This can be mapped to external rule number via the yyrmap.
+#if defined YYBISON && YYBISON >= 30800
+#define SQL_NEW_RULE   newNode("", SQLNodeType::Rule, 
yyr1[yyrule])
+#define SQL_NEW_LISTRULE   newNode("", SQLNodeType::ListRule, 
yyr1[yyrule])
+#define SQL_NEW_COMMALISTRULE   newNode("", SQLNodeType::CommaListRule, 
yyr1[yyrule])
+#else
 #define SQL_NEW_RULE   newNode("", SQLNodeType::Rule, 
yyr1[yyn])
 #define SQL_NEW_LISTRULE   newNode("", SQLNodeType::ListRule, 
yyr1[yyn])
 #define SQL_NEW_COMMALISTRULE   newNode("", SQLNodeType::CommaListRule, 
yyr1[yyn])
+#endif
 
 
 extern connectivity::OSQLParser* xxx_pGLOBAL_SQLPARSER;

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - external/libassuan

[Thorsten Behrens (via logerrit)]

 external/libassuan/ExternalProject_libassuan.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 184b871473cb88d25ffc59fb0d020ba80eaf5577
Author: Thorsten Behrens 
AuthorDate: Tue Dec 28 17:22:29 2021 +0100
Commit: Michael Weghorn 
CommitDate: Thu Feb 10 09:30:08 2022 +0100

Fix autoconf>=2.70 gcc-wrapper breakage

Re-generated configure file gets confused & claims not finding C89-
compatible compiler for gcc-wrapper-building libassuan with msvc
underneath.

Work-around the problem by telling toolchain right off that this
_is_ a std c compliant compiler.

Change-Id: I4fa23673b790bc70a9294951df545c27f5236f81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127641
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 1bb0e177124d5d6661b72df6c7d848fb23639652)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129748
Tested-by: Michael Weghorn 
Reviewed-by: Michael Weghorn 
(cherry picked from commit cf4f54c72bd8f2c7314a1ff457bf8e4a65e1f379)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129749

diff --git a/external/libassuan/ExternalProject_libassuan.mk 
b/external/libassuan/ExternalProject_libassuan.mk
index 899c21e4cec9..9237c35a5d31 100644
--- a/external/libassuan/ExternalProject_libassuan.mk
+++ b/external/libassuan/ExternalProject_libassuan.mk
@@ -30,6 +30,7 @@ $(call gb_ExternalProject_get_state_target,libassuan,build): 
$(call gb_Executabl
--disable-shared \
--disable-doc \
$(if $(verbose),--disable-silent-rules,--enable-silent-rules) \
+   CFLAGS="$(CFLAGS) -D__STDC__=1" \
CXXFLAGS="$(CXXFLAGS)" \
GPG_ERROR_CFLAGS="$(GPG_ERROR_CFLAGS)" \
GPG_ERROR_LIBS="$(GPG_ERROR_LIBS)" \

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - external/gpgmepp external/libassuan external/libgpg-error

[Thorsten Behrens (via logerrit)]

 external/gpgmepp/ExternalProject_gpgmepp.mk   |2 +-
 external/libassuan/ExternalProject_libassuan.mk   |2 +-
 external/libgpg-error/ExternalProject_libgpg-error.mk |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 59f893883b70dad1a7b9052ecb2b569681f8004c
Author: Thorsten Behrens 
AuthorDate: Tue Jun 15 18:03:27 2021 +0200
Commit: Michael Weghorn 
CommitDate: Thu Feb 10 09:29:48 2022 +0100

avoid windres preprocessor quoting-messups with current cygwin

apparently fresh installs of cygwin behave differently with the windres
command's quoting and treats --preprocessor='cpp foo bar' as a single file
"cpp foo bar" to run instead of running "cpp" with the arguments "foo"
and "bar".
(-D and -I options are passed to the preprocessor automatically, so no
need to prefix those with --preprocessor-arg)

Conflicts:
 - solenv/gbuild/platform/com_MSC_defs.mk

Change-Id: I711e968206f0769ff07152ebb9572e8b71c30cec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114965
Tested-by: Jenkins
Reviewed-by: Georgy Litvinov 
Reviewed-by: Christian Lohmaier 
(cherry picked from commit 9b120ad2773676c5445d4664e9c7007c575249a4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127097
Tested-by: Vasily Melenchuk 
Reviewed-by: Vasily Melenchuk 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 9fafa67c9bc85d9e5a13d18b7b7ecbc8de700c04)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129750
Tested-by: Michael Weghorn 
Reviewed-by: Michael Weghorn 

diff --git a/external/gpgmepp/ExternalProject_gpgmepp.mk 
b/external/gpgmepp/ExternalProject_gpgmepp.mk
index 452f922750d6..dac2fad1361b 100644
--- a/external/gpgmepp/ExternalProject_gpgmepp.mk
+++ b/external/gpgmepp/ExternalProject_gpgmepp.mk
@@ -40,7 +40,7 @@ $(call gb_ExternalProject_get_state_target,gpgmepp,build): 
$(call gb_Executable_
$(if $(ENABLE_DEBUG),$(gb_DEBUG_CFLAGS)) \
$(if $(filter 
$(true),$(gb_SYMBOL)),$(gb_DEBUGINFO_FLAGS))' \
--host=$(gb_ExternalProject_gpgmepp_host) \
-  RC='windres -O COFF 
--target=$(gb_ExternalProject_gpgmepp_target) --preprocessor='\''$(call 
gb_Executable_get_target,cpp) -+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)'\' \
+  RC='windres -O COFF 
--target=$(gb_ExternalProject_gpgmepp_target) --preprocessor=$(call 
gb_Executable_get_target,cpp) --preprocessor-arg=-+ -DRC_INVOKED 
-DWINAPI_FAMILY=0 $(SOLARINC)' \
   MAKE=$(MAKE) \
&& $(MAKE) \
)
diff --git a/external/libassuan/ExternalProject_libassuan.mk 
b/external/libassuan/ExternalProject_libassuan.mk
index 83d79a520988..899c21e4cec9 100644
--- a/external/libassuan/ExternalProject_libassuan.mk
+++ b/external/libassuan/ExternalProject_libassuan.mk
@@ -34,7 +34,7 @@ $(call gb_ExternalProject_get_state_target,libassuan,build): 
$(call gb_Executabl
GPG_ERROR_CFLAGS="$(GPG_ERROR_CFLAGS)" \
GPG_ERROR_LIBS="$(GPG_ERROR_LIBS)" \
 --host=$(gb_ExternalProject_libassuan_host) \
-   RC='windres -O COFF 
--target=$(gb_ExternalProject_libassuan_target) --preprocessor='\''$(call 
gb_Executable_get_target,cpp) -+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)'\' \
+   RC='windres -O COFF 
--target=$(gb_ExternalProject_libassuan_target) --preprocessor=$(call 
gb_Executable_get_target,cpp) --preprocessor-arg=-+ -DRC_INVOKED 
-DWINAPI_FAMILY=0 $(SOLARINC)' \
MAKE=$(MAKE) \
  && $(MAKE) \
)
diff --git a/external/libgpg-error/ExternalProject_libgpg-error.mk 
b/external/libgpg-error/ExternalProject_libgpg-error.mk
index 1fcd63180e20..e5155aad94c1 100644
--- a/external/libgpg-error/ExternalProject_libgpg-error.mk
+++ b/external/libgpg-error/ExternalProject_libgpg-error.mk
@@ -28,7 +28,7 @@ $(call 
gb_ExternalProject_get_state_target,libgpg-error,build): $(call gb_Execut
--disable-doc \
--disable-tests \
--host=$(gb_ExternalProject_libgpg-error_host) \
-   RC='windres -O COFF 
--target=$(gb_ExternalProject_libgpg-error_target) --preprocessor='\''$(call 
gb_Executable_get_target,cpp) -+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)'\' \
+   RC='windres -O COFF 
--target=$(gb_ExternalProject_libgpg-error_target) --preprocessor=$(call 
gb_Executable_get_target,cpp) --preprocessor-arg=-+ -DRC_INVOKED 
-DWINAPI_FAMILY=0 $(SOLARINC)' \
&& $(MAKE) \
)
 else

[Libreoffice-bugs] [Bug 146867] When adding a text box to eventually create a fillable pdf, the font specified in control properties -- font are not properly exported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146867

Regis Perdreau  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Regis Perdreau  ---
Confirmed in 7.1.7.2 Windows_X86_64

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116400] Very time lengthy PDF-generation due to Upgrade to ICU ( see comment 9 and 19 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116400

Timur  changed:

   What|Removed |Added

Summary|Very time lengthy   |Very time lengthy
   |PDF-generation ( see|PDF-generation due to
   |comment 9 and 19)   |Upgrade to ICU ( see
   ||comment 9 and 19 )

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116400] Very time lengthy PDF-generation ( see comment 9 and 19)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116400

--- Comment #23 from Timur  ---
Bug 126344 is the same file, same commit.
Steps to Reproduce:
1. Open attachment 140185 [details]
2. Press F5
3. Go to page 200
4. Set cursor at the beginning of pag 200
5. Press Shift & scroll to the bottom and select the end of the sentence (ergo
select everything from pag 200 until end)
6. Press Delete (wait until the CPU usage is down to nearly zero)
7. Press Undo (CTRL+Z

Actual Results:
30 seconds CPU spike after press undo. It's slower and more CPU hogging

Expected Results:
12 seconds spike in LibO 4.4.7.2 (comparison is bit off.. previously the
scheduling had more of idle way of doing things.. but it's to slow for sure..)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105948
Bug 105948 depends on bug 126344, which changed state.

Bug 126344 Summary: Undo is slower and consumes more CPU time after pressing 
undo (compared to 6.1)
https://bugs.documentfoundation.org/show_bug.cgi?id=126344

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116400] Very time lengthy PDF-generation ( see comment 9 and 19)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116400

--- Comment #22 from Timur  ---
*** Bug 126344 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126344] Undo is slower and consumes more CPU time after pressing undo (compared to 6.1)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126344

Timur  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #3 from Timur  ---
Why make 3 bugs out of 1?

*** This bug has been marked as a duplicate of bug 116400 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146836] ACCESS2BASE Library does not work with Libreoffice 7.3 rc2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146836

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #19 from Xisco Faulí  ---
(In reply to Jean-Pierre Ledure from comment #17)
> Tested on
> Version: 7.4.0.0.alpha0+ / LibreOffice Community
> Build ID: 845e53ea13b317bd8ef4dc42cd60ea51359f34ab
> CPU threads: 6; OS: Linux 5.4; UI render: default; VCL: gtk3
> Locale: en-US (en_US.UTF-8); UI: en-US
> Calc: threaded
> 
> I confirm that the commit solved the Access2Base issue described in the 1st
> message.
> 
> Can the correction please be cherry-picked to LO 7.3 ?
> 
> Thanks.

The patch just landed in libreoffice-7-3 branch <
https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-7-3=1a343e3168c6ac8acf3279307275727e588ddcb7
>
Closing

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116400] Very time lengthy PDF-generation ( see comment 9 and 19)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116400

--- Comment #21 from Timur  ---
Bug 134652 is the same file, same commit.
Open attachment 140185. Monitor the waiting time until CPU drops to around 0%.
Actual Results:90 seconds
Expected Results:  12 seconds with 6.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146281] [Feature Request] BaseDocumenter extension in Firebird not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146281

--- Comment #17 from Commit Notification 
 ---
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/1a343e3168c6ac8acf3279307275727e588ddcb7

tdf#144353, tdf#146281 - Correctly copy the information about variables

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146281] [Feature Request] BaseDocumenter extension in Firebird not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146281

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0|target:7.4.0 target:7.3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146836] ACCESS2BASE Library does not work with Libreoffice 7.3 rc2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146836

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |
 CC||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - basic/source

[Andreas Heinisch (via logerrit)]

 basic/source/sbx/sbxvar.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 1a343e3168c6ac8acf3279307275727e588ddcb7
Author: Andreas Heinisch 
AuthorDate: Thu Dec 23 20:04:30 2021 +0100
Commit: Xisco Fauli 
CommitDate: Thu Feb 10 09:20:16 2022 +0100

tdf#144353, tdf#146281 - Correctly copy the information about variables

During the assignment of a variable, copy its information only if there
isn't already one present.

Change-Id: I29fcfcd10406f2af0708a879d57e0a3c704f179e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127387
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch 
(cherry picked from commit d8428094c7f8b186b37c76fd7e9508a075424f80)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129752
Reviewed-by: Xisco Fauli 

diff --git a/basic/source/sbx/sbxvar.cxx b/basic/source/sbx/sbxvar.cxx
index b8be36ec2735..6097d25eb995 100644
--- a/basic/source/sbx/sbxvar.cxx
+++ b/basic/source/sbx/sbxvar.cxx
@@ -281,7 +281,10 @@ SbxVariable& SbxVariable::operator=( const SbxVariable& r )
 {
 SbxValue::operator=( r );
 // tdf#144353 - copy information about a missing parameter. See 
SbiRuntime::SetIsMissing.
-if (r.pInfo && !dynamic_cast())
+// We cannot unconditionally assign the data about a variable because 
we would overwrite
+// the information about parameters (name, type, flags, and ids). For 
instance, in the case
+// where a method will be initialized with a literal.
+if (!pInfo)
 pInfo = r.pInfo;
 m_aDeclareClassName = r.m_aDeclareClassName;
 m_xComListener = r.m_xComListener;

[Libreoffice-bugs] [Bug 141845] LibreOffice Vanilla / Collabora Productivity fails to open postgres connected ODB file using the postgres native connector

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141845

--- Comment #11 from Alex Thurgood  ---
Created attachment 178184
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178184=edit
Collabora AppStore list of announced bug fixes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109530] [META] File opening issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109530
Bug 109530 depends on bug 134652, which changed state.

Bug 134652 Summary: Lots of CPU time spend in break iterator one file open
https://bugs.documentfoundation.org/show_bug.cgi?id=134652

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116400] Very time lengthy PDF-generation ( see comment 9 and 19)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116400

--- Comment #20 from Timur  ---
*** Bug 134652 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134652] Lots of CPU time spend in break iterator one file open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134652

Timur  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Timur  ---
Enough already is to have money inflation in the world, no need to inflate the
bugs. Same file, same commit.

*** This bug has been marked as a duplicate of bug 116400 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141845] LibreOffice Vanilla / Collabora Productivity fails to open postgres connected ODB file using the postgres native connector

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141845

--- Comment #10 from Alex Thurgood  ---
With Collabora Office

Version: 21.06.15.1
Build ID: 60a66e4bf6afbf5d4221dab436bb1aca744a7ddf
CPU threads: 8; OS: Mac OS X 12.2; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

In the list of fixes (cf. screenshot) displayed on the AppStore, it says
postgres  upgraded to 13.5, yet, there is still no way to either create a new
connection to a running postgres instance (Step 1 of Create Database Wizard),
or successully load and read data from an existing postgres configured ODB.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116399] Sending a print job for a 400 paged document is rather slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116399

Timur  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |6400|

-- 
You are receiving this mail because:
You are the assignee for the bug.